Browse Source

small refactoring suggested on the code review

drsoares 6 years ago
parent
commit
4473ba495c
1 changed files with 2 additions and 10 deletions
  1. 2 10
      metadata_request.go

+ 2 - 10
metadata_request.go

@@ -37,15 +37,8 @@ func (r *MetadataRequest) decode(pd packetDecoder, version int16) error {
 	if err != nil {
 	if err != nil {
 		return err
 		return err
 	}
 	}
-	if size < 0 {
+	if size > 0 {
-		return nil
+		r.Topics = make([]string, size)
-	} else {
-		topicCount := size
-		if topicCount == 0 {
-			goto SKIP
-		}
-
-		r.Topics = make([]string, topicCount)
 		for i := range r.Topics {
 		for i := range r.Topics {
 			topic, err := pd.getString()
 			topic, err := pd.getString()
 			if err != nil {
 			if err != nil {
@@ -54,7 +47,6 @@ func (r *MetadataRequest) decode(pd packetDecoder, version int16) error {
 			r.Topics[i] = topic
 			r.Topics[i] = topic
 		}
 		}
 	}
 	}
-SKIP:
 	if r.Version > 3 {
 	if r.Version > 3 {
 		autoCreation, err := pd.getBool()
 		autoCreation, err := pd.getBool()
 		if err != nil {
 		if err != nil {