transport_test.go 40 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "math/rand"
  16. "net"
  17. "net/http"
  18. "net/url"
  19. "os"
  20. "reflect"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var (
  30. extNet = flag.Bool("extnet", false, "do external network tests")
  31. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  32. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  33. )
  34. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  35. func TestTransportExternal(t *testing.T) {
  36. if !*extNet {
  37. t.Skip("skipping external network test")
  38. }
  39. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  40. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  41. res, err := rt.RoundTrip(req)
  42. if err != nil {
  43. t.Fatalf("%v", err)
  44. }
  45. res.Write(os.Stdout)
  46. }
  47. func TestTransport(t *testing.T) {
  48. const body = "sup"
  49. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  50. io.WriteString(w, body)
  51. }, optOnlyServer)
  52. defer st.Close()
  53. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  54. defer tr.CloseIdleConnections()
  55. req, err := http.NewRequest("GET", st.ts.URL, nil)
  56. if err != nil {
  57. t.Fatal(err)
  58. }
  59. res, err := tr.RoundTrip(req)
  60. if err != nil {
  61. t.Fatal(err)
  62. }
  63. defer res.Body.Close()
  64. t.Logf("Got res: %+v", res)
  65. if g, w := res.StatusCode, 200; g != w {
  66. t.Errorf("StatusCode = %v; want %v", g, w)
  67. }
  68. if g, w := res.Status, "200 OK"; g != w {
  69. t.Errorf("Status = %q; want %q", g, w)
  70. }
  71. wantHeader := http.Header{
  72. "Content-Length": []string{"3"},
  73. "Content-Type": []string{"text/plain; charset=utf-8"},
  74. "Date": []string{"XXX"}, // see cleanDate
  75. }
  76. cleanDate(res)
  77. if !reflect.DeepEqual(res.Header, wantHeader) {
  78. t.Errorf("res Header = %v; want %v", res.Header, wantHeader)
  79. }
  80. if res.Request != req {
  81. t.Errorf("Response.Request = %p; want %p", res.Request, req)
  82. }
  83. if res.TLS == nil {
  84. t.Error("Response.TLS = nil; want non-nil")
  85. }
  86. slurp, err := ioutil.ReadAll(res.Body)
  87. if err != nil {
  88. t.Errorf("Body read: %v", err)
  89. } else if string(slurp) != body {
  90. t.Errorf("Body = %q; want %q", slurp, body)
  91. }
  92. }
  93. func TestTransportReusesConns(t *testing.T) {
  94. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  95. io.WriteString(w, r.RemoteAddr)
  96. }, optOnlyServer)
  97. defer st.Close()
  98. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  99. defer tr.CloseIdleConnections()
  100. get := func() string {
  101. req, err := http.NewRequest("GET", st.ts.URL, nil)
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. res, err := tr.RoundTrip(req)
  106. if err != nil {
  107. t.Fatal(err)
  108. }
  109. defer res.Body.Close()
  110. slurp, err := ioutil.ReadAll(res.Body)
  111. if err != nil {
  112. t.Fatalf("Body read: %v", err)
  113. }
  114. addr := strings.TrimSpace(string(slurp))
  115. if addr == "" {
  116. t.Fatalf("didn't get an addr in response")
  117. }
  118. return addr
  119. }
  120. first := get()
  121. second := get()
  122. if first != second {
  123. t.Errorf("first and second responses were on different connections: %q vs %q", first, second)
  124. }
  125. }
  126. // Tests that the Transport only keeps one pending dial open per destination address.
  127. // https://golang.org/issue/13397
  128. func TestTransportGroupsPendingDials(t *testing.T) {
  129. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  130. io.WriteString(w, r.RemoteAddr)
  131. }, optOnlyServer)
  132. defer st.Close()
  133. tr := &Transport{
  134. TLSClientConfig: tlsConfigInsecure,
  135. }
  136. defer tr.CloseIdleConnections()
  137. var (
  138. mu sync.Mutex
  139. dials = map[string]int{}
  140. )
  141. var wg sync.WaitGroup
  142. for i := 0; i < 10; i++ {
  143. wg.Add(1)
  144. go func() {
  145. defer wg.Done()
  146. req, err := http.NewRequest("GET", st.ts.URL, nil)
  147. if err != nil {
  148. t.Error(err)
  149. return
  150. }
  151. res, err := tr.RoundTrip(req)
  152. if err != nil {
  153. t.Error(err)
  154. return
  155. }
  156. defer res.Body.Close()
  157. slurp, err := ioutil.ReadAll(res.Body)
  158. if err != nil {
  159. t.Errorf("Body read: %v", err)
  160. }
  161. addr := strings.TrimSpace(string(slurp))
  162. if addr == "" {
  163. t.Errorf("didn't get an addr in response")
  164. }
  165. mu.Lock()
  166. dials[addr]++
  167. mu.Unlock()
  168. }()
  169. }
  170. wg.Wait()
  171. if len(dials) != 1 {
  172. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  173. }
  174. tr.CloseIdleConnections()
  175. if err := retry(50, 10*time.Millisecond, func() error {
  176. cp, ok := tr.connPool().(*clientConnPool)
  177. if !ok {
  178. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  179. }
  180. cp.mu.Lock()
  181. defer cp.mu.Unlock()
  182. if len(cp.dialing) != 0 {
  183. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  184. }
  185. if len(cp.conns) != 0 {
  186. return fmt.Errorf("conns = %v; want empty", cp.conns)
  187. }
  188. if len(cp.keys) != 0 {
  189. return fmt.Errorf("keys = %v; want empty", cp.keys)
  190. }
  191. return nil
  192. }); err != nil {
  193. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  194. }
  195. }
  196. func retry(tries int, delay time.Duration, fn func() error) error {
  197. var err error
  198. for i := 0; i < tries; i++ {
  199. err = fn()
  200. if err == nil {
  201. return nil
  202. }
  203. time.Sleep(delay)
  204. }
  205. return err
  206. }
  207. func TestTransportAbortClosesPipes(t *testing.T) {
  208. shutdown := make(chan struct{})
  209. st := newServerTester(t,
  210. func(w http.ResponseWriter, r *http.Request) {
  211. w.(http.Flusher).Flush()
  212. <-shutdown
  213. },
  214. optOnlyServer,
  215. )
  216. defer st.Close()
  217. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  218. done := make(chan struct{})
  219. requestMade := make(chan struct{})
  220. go func() {
  221. defer close(done)
  222. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  223. req, err := http.NewRequest("GET", st.ts.URL, nil)
  224. if err != nil {
  225. t.Fatal(err)
  226. }
  227. res, err := tr.RoundTrip(req)
  228. if err != nil {
  229. t.Fatal(err)
  230. }
  231. defer res.Body.Close()
  232. close(requestMade)
  233. _, err = ioutil.ReadAll(res.Body)
  234. if err == nil {
  235. t.Error("expected error from res.Body.Read")
  236. }
  237. }()
  238. <-requestMade
  239. // Now force the serve loop to end, via closing the connection.
  240. st.closeConn()
  241. // deadlock? that's a bug.
  242. select {
  243. case <-done:
  244. case <-time.After(3 * time.Second):
  245. t.Fatal("timeout")
  246. }
  247. }
  248. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  249. // could be a table-driven test with extra goodies.
  250. func TestTransportPath(t *testing.T) {
  251. gotc := make(chan *url.URL, 1)
  252. st := newServerTester(t,
  253. func(w http.ResponseWriter, r *http.Request) {
  254. gotc <- r.URL
  255. },
  256. optOnlyServer,
  257. )
  258. defer st.Close()
  259. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  260. defer tr.CloseIdleConnections()
  261. const (
  262. path = "/testpath"
  263. query = "q=1"
  264. )
  265. surl := st.ts.URL + path + "?" + query
  266. req, err := http.NewRequest("POST", surl, nil)
  267. if err != nil {
  268. t.Fatal(err)
  269. }
  270. c := &http.Client{Transport: tr}
  271. res, err := c.Do(req)
  272. if err != nil {
  273. t.Fatal(err)
  274. }
  275. defer res.Body.Close()
  276. got := <-gotc
  277. if got.Path != path {
  278. t.Errorf("Read Path = %q; want %q", got.Path, path)
  279. }
  280. if got.RawQuery != query {
  281. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  282. }
  283. }
  284. func randString(n int) string {
  285. rnd := rand.New(rand.NewSource(int64(n)))
  286. b := make([]byte, n)
  287. for i := range b {
  288. b[i] = byte(rnd.Intn(256))
  289. }
  290. return string(b)
  291. }
  292. var bodyTests = []struct {
  293. body string
  294. noContentLen bool
  295. }{
  296. {body: "some message"},
  297. {body: "some message", noContentLen: true},
  298. {body: ""},
  299. {body: "", noContentLen: true},
  300. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  301. {body: strings.Repeat("a", 1<<20)},
  302. {body: randString(16<<10 - 1)},
  303. {body: randString(16 << 10)},
  304. {body: randString(16<<10 + 1)},
  305. {body: randString(512<<10 - 1)},
  306. {body: randString(512 << 10)},
  307. {body: randString(512<<10 + 1)},
  308. {body: randString(1<<20 - 1)},
  309. {body: randString(1 << 20)},
  310. {body: randString(1<<20 + 2)},
  311. }
  312. func TestTransportBody(t *testing.T) {
  313. type reqInfo struct {
  314. req *http.Request
  315. slurp []byte
  316. err error
  317. }
  318. gotc := make(chan reqInfo, 1)
  319. st := newServerTester(t,
  320. func(w http.ResponseWriter, r *http.Request) {
  321. slurp, err := ioutil.ReadAll(r.Body)
  322. if err != nil {
  323. gotc <- reqInfo{err: err}
  324. } else {
  325. gotc <- reqInfo{req: r, slurp: slurp}
  326. }
  327. },
  328. optOnlyServer,
  329. )
  330. defer st.Close()
  331. for i, tt := range bodyTests {
  332. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  333. defer tr.CloseIdleConnections()
  334. var body io.Reader = strings.NewReader(tt.body)
  335. if tt.noContentLen {
  336. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  337. }
  338. req, err := http.NewRequest("POST", st.ts.URL, body)
  339. if err != nil {
  340. t.Fatalf("#%d: %v", i, err)
  341. }
  342. c := &http.Client{Transport: tr}
  343. res, err := c.Do(req)
  344. if err != nil {
  345. t.Fatalf("#%d: %v", i, err)
  346. }
  347. defer res.Body.Close()
  348. ri := <-gotc
  349. if ri.err != nil {
  350. t.Errorf("%#d: read error: %v", i, ri.err)
  351. continue
  352. }
  353. if got := string(ri.slurp); got != tt.body {
  354. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  355. }
  356. wantLen := int64(len(tt.body))
  357. if tt.noContentLen && tt.body != "" {
  358. wantLen = -1
  359. }
  360. if ri.req.ContentLength != wantLen {
  361. t.Errorf("#%d. handler got ContentLength = %v; want %v", i, ri.req.ContentLength, wantLen)
  362. }
  363. }
  364. }
  365. func shortString(v string) string {
  366. const maxLen = 100
  367. if len(v) <= maxLen {
  368. return v
  369. }
  370. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  371. }
  372. func TestTransportDialTLS(t *testing.T) {
  373. var mu sync.Mutex // guards following
  374. var gotReq, didDial bool
  375. ts := newServerTester(t,
  376. func(w http.ResponseWriter, r *http.Request) {
  377. mu.Lock()
  378. gotReq = true
  379. mu.Unlock()
  380. },
  381. optOnlyServer,
  382. )
  383. defer ts.Close()
  384. tr := &Transport{
  385. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  386. mu.Lock()
  387. didDial = true
  388. mu.Unlock()
  389. cfg.InsecureSkipVerify = true
  390. c, err := tls.Dial(netw, addr, cfg)
  391. if err != nil {
  392. return nil, err
  393. }
  394. return c, c.Handshake()
  395. },
  396. }
  397. defer tr.CloseIdleConnections()
  398. client := &http.Client{Transport: tr}
  399. res, err := client.Get(ts.ts.URL)
  400. if err != nil {
  401. t.Fatal(err)
  402. }
  403. res.Body.Close()
  404. mu.Lock()
  405. if !gotReq {
  406. t.Error("didn't get request")
  407. }
  408. if !didDial {
  409. t.Error("didn't use dial hook")
  410. }
  411. }
  412. func TestConfigureTransport(t *testing.T) {
  413. t1 := &http.Transport{}
  414. err := ConfigureTransport(t1)
  415. if err == errTransportVersion {
  416. t.Skip(err)
  417. }
  418. if err != nil {
  419. t.Fatal(err)
  420. }
  421. if got := fmt.Sprintf("%#v", *t1); !strings.Contains(got, `"h2"`) {
  422. // Laziness, to avoid buildtags.
  423. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  424. }
  425. wantNextProtos := []string{"h2", "http/1.1"}
  426. if t1.TLSClientConfig == nil {
  427. t.Errorf("nil t1.TLSClientConfig")
  428. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  429. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  430. }
  431. if err := ConfigureTransport(t1); err == nil {
  432. t.Error("unexpected success on second call to ConfigureTransport")
  433. }
  434. // And does it work?
  435. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  436. io.WriteString(w, r.Proto)
  437. }, optOnlyServer)
  438. defer st.Close()
  439. t1.TLSClientConfig.InsecureSkipVerify = true
  440. c := &http.Client{Transport: t1}
  441. res, err := c.Get(st.ts.URL)
  442. if err != nil {
  443. t.Fatal(err)
  444. }
  445. slurp, err := ioutil.ReadAll(res.Body)
  446. if err != nil {
  447. t.Fatal(err)
  448. }
  449. if got, want := string(slurp), "HTTP/2.0"; got != want {
  450. t.Errorf("body = %q; want %q", got, want)
  451. }
  452. }
  453. type capitalizeReader struct {
  454. r io.Reader
  455. }
  456. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  457. n, err = cr.r.Read(p)
  458. for i, b := range p[:n] {
  459. if b >= 'a' && b <= 'z' {
  460. p[i] = b - ('a' - 'A')
  461. }
  462. }
  463. return
  464. }
  465. type flushWriter struct {
  466. w io.Writer
  467. }
  468. func (fw flushWriter) Write(p []byte) (n int, err error) {
  469. n, err = fw.w.Write(p)
  470. if f, ok := fw.w.(http.Flusher); ok {
  471. f.Flush()
  472. }
  473. return
  474. }
  475. type clientTester struct {
  476. t *testing.T
  477. tr *Transport
  478. sc, cc net.Conn // server and client conn
  479. fr *Framer // server's framer
  480. client func() error
  481. server func() error
  482. }
  483. func newClientTester(t *testing.T) *clientTester {
  484. var dialOnce struct {
  485. sync.Mutex
  486. dialed bool
  487. }
  488. ct := &clientTester{
  489. t: t,
  490. }
  491. ct.tr = &Transport{
  492. TLSClientConfig: tlsConfigInsecure,
  493. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  494. dialOnce.Lock()
  495. defer dialOnce.Unlock()
  496. if dialOnce.dialed {
  497. return nil, errors.New("only one dial allowed in test mode")
  498. }
  499. dialOnce.dialed = true
  500. return ct.cc, nil
  501. },
  502. }
  503. ln := newLocalListener(t)
  504. cc, err := net.Dial("tcp", ln.Addr().String())
  505. if err != nil {
  506. t.Fatal(err)
  507. }
  508. sc, err := ln.Accept()
  509. if err != nil {
  510. t.Fatal(err)
  511. }
  512. ln.Close()
  513. ct.cc = cc
  514. ct.sc = sc
  515. ct.fr = NewFramer(sc, sc)
  516. return ct
  517. }
  518. func newLocalListener(t *testing.T) net.Listener {
  519. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  520. if err == nil {
  521. return ln
  522. }
  523. ln, err = net.Listen("tcp6", "[::1]:0")
  524. if err != nil {
  525. t.Fatal(err)
  526. }
  527. return ln
  528. }
  529. func (ct *clientTester) greet() {
  530. buf := make([]byte, len(ClientPreface))
  531. _, err := io.ReadFull(ct.sc, buf)
  532. if err != nil {
  533. ct.t.Fatalf("reading client preface: %v", err)
  534. }
  535. f, err := ct.fr.ReadFrame()
  536. if err != nil {
  537. ct.t.Fatalf("Reading client settings frame: %v", err)
  538. }
  539. if sf, ok := f.(*SettingsFrame); !ok {
  540. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  541. _ = sf // stash it away?
  542. }
  543. if err := ct.fr.WriteSettings(); err != nil {
  544. ct.t.Fatal(err)
  545. }
  546. if err := ct.fr.WriteSettingsAck(); err != nil {
  547. ct.t.Fatal(err)
  548. }
  549. }
  550. func (ct *clientTester) cleanup() {
  551. ct.tr.CloseIdleConnections()
  552. }
  553. func (ct *clientTester) run() {
  554. errc := make(chan error, 2)
  555. ct.start("client", errc, ct.client)
  556. ct.start("server", errc, ct.server)
  557. defer ct.cleanup()
  558. for i := 0; i < 2; i++ {
  559. if err := <-errc; err != nil {
  560. ct.t.Error(err)
  561. return
  562. }
  563. }
  564. }
  565. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  566. go func() {
  567. finished := false
  568. var err error
  569. defer func() {
  570. if !finished {
  571. err = fmt.Errorf("%s goroutine didn't finish.", which)
  572. } else if err != nil {
  573. err = fmt.Errorf("%s: %v", which, err)
  574. }
  575. errc <- err
  576. }()
  577. err = fn()
  578. finished = true
  579. }()
  580. }
  581. type countingReader struct {
  582. n *int64
  583. }
  584. func (r countingReader) Read(p []byte) (n int, err error) {
  585. for i := range p {
  586. p[i] = byte(i)
  587. }
  588. atomic.AddInt64(r.n, int64(len(p)))
  589. return len(p), err
  590. }
  591. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  592. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  593. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  594. const bodySize = 10 << 20
  595. ct := newClientTester(t)
  596. ct.client = func() error {
  597. var n int64 // atomic
  598. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  599. if err != nil {
  600. return err
  601. }
  602. res, err := ct.tr.RoundTrip(req)
  603. if err != nil {
  604. return fmt.Errorf("RoundTrip: %v", err)
  605. }
  606. defer res.Body.Close()
  607. if res.StatusCode != status {
  608. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  609. }
  610. slurp, err := ioutil.ReadAll(res.Body)
  611. if err != nil {
  612. return fmt.Errorf("Slurp: %v", err)
  613. }
  614. if len(slurp) > 0 {
  615. return fmt.Errorf("unexpected body: %q", slurp)
  616. }
  617. if status == 200 {
  618. if got := atomic.LoadInt64(&n); got != bodySize {
  619. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  620. }
  621. } else {
  622. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  623. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  624. }
  625. }
  626. return nil
  627. }
  628. ct.server = func() error {
  629. ct.greet()
  630. var buf bytes.Buffer
  631. enc := hpack.NewEncoder(&buf)
  632. var dataRecv int64
  633. var closed bool
  634. for {
  635. f, err := ct.fr.ReadFrame()
  636. if err != nil {
  637. return err
  638. }
  639. //println(fmt.Sprintf("server got frame: %v", f))
  640. switch f := f.(type) {
  641. case *WindowUpdateFrame, *SettingsFrame:
  642. case *HeadersFrame:
  643. if !f.HeadersEnded() {
  644. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  645. }
  646. if f.StreamEnded() {
  647. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  648. }
  649. time.Sleep(50 * time.Millisecond) // let client send body
  650. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  651. ct.fr.WriteHeaders(HeadersFrameParam{
  652. StreamID: f.StreamID,
  653. EndHeaders: true,
  654. EndStream: false,
  655. BlockFragment: buf.Bytes(),
  656. })
  657. case *DataFrame:
  658. dataLen := len(f.Data())
  659. dataRecv += int64(dataLen)
  660. if dataLen > 0 {
  661. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  662. return err
  663. }
  664. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  665. return err
  666. }
  667. }
  668. if !closed && ((status != 200 && dataRecv > 0) ||
  669. (status == 200 && dataRecv == bodySize)) {
  670. closed = true
  671. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  672. return err
  673. }
  674. return nil
  675. }
  676. default:
  677. return fmt.Errorf("Unexpected client frame %v", f)
  678. }
  679. }
  680. return nil
  681. }
  682. ct.run()
  683. }
  684. // See golang.org/issue/13444
  685. func TestTransportFullDuplex(t *testing.T) {
  686. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  687. w.WriteHeader(200) // redundant but for clarity
  688. w.(http.Flusher).Flush()
  689. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  690. fmt.Fprintf(w, "bye.\n")
  691. }, optOnlyServer)
  692. defer st.Close()
  693. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  694. defer tr.CloseIdleConnections()
  695. c := &http.Client{Transport: tr}
  696. pr, pw := io.Pipe()
  697. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  698. if err != nil {
  699. log.Fatal(err)
  700. }
  701. req.ContentLength = -1
  702. res, err := c.Do(req)
  703. if err != nil {
  704. log.Fatal(err)
  705. }
  706. defer res.Body.Close()
  707. if res.StatusCode != 200 {
  708. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  709. }
  710. bs := bufio.NewScanner(res.Body)
  711. want := func(v string) {
  712. if !bs.Scan() {
  713. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  714. }
  715. }
  716. write := func(v string) {
  717. _, err := io.WriteString(pw, v)
  718. if err != nil {
  719. t.Fatalf("pipe write: %v", err)
  720. }
  721. }
  722. write("foo\n")
  723. want("FOO")
  724. write("bar\n")
  725. want("BAR")
  726. pw.Close()
  727. want("bye.")
  728. if err := bs.Err(); err != nil {
  729. t.Fatal(err)
  730. }
  731. }
  732. func TestTransportConnectRequest(t *testing.T) {
  733. gotc := make(chan *http.Request, 1)
  734. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  735. gotc <- r
  736. }, optOnlyServer)
  737. defer st.Close()
  738. u, err := url.Parse(st.ts.URL)
  739. if err != nil {
  740. t.Fatal(err)
  741. }
  742. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  743. defer tr.CloseIdleConnections()
  744. c := &http.Client{Transport: tr}
  745. tests := []struct {
  746. req *http.Request
  747. want string
  748. }{
  749. {
  750. req: &http.Request{
  751. Method: "CONNECT",
  752. Header: http.Header{},
  753. URL: u,
  754. },
  755. want: u.Host,
  756. },
  757. {
  758. req: &http.Request{
  759. Method: "CONNECT",
  760. Header: http.Header{},
  761. URL: u,
  762. Host: "example.com:123",
  763. },
  764. want: "example.com:123",
  765. },
  766. }
  767. for i, tt := range tests {
  768. res, err := c.Do(tt.req)
  769. if err != nil {
  770. t.Errorf("%d. RoundTrip = %v", i, err)
  771. continue
  772. }
  773. res.Body.Close()
  774. req := <-gotc
  775. if req.Method != "CONNECT" {
  776. t.Errorf("method = %q; want CONNECT", req.Method)
  777. }
  778. if req.Host != tt.want {
  779. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  780. }
  781. if req.URL.Host != tt.want {
  782. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  783. }
  784. }
  785. }
  786. type headerType int
  787. const (
  788. noHeader headerType = iota // omitted
  789. oneHeader
  790. splitHeader // broken into continuation on purpose
  791. )
  792. const (
  793. f0 = noHeader
  794. f1 = oneHeader
  795. f2 = splitHeader
  796. d0 = false
  797. d1 = true
  798. )
  799. // Test all 36 combinations of response frame orders:
  800. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  801. // Generated by http://play.golang.org/p/SScqYKJYXd
  802. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  803. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  804. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  805. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  806. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  807. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  808. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  809. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  810. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  811. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  812. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  813. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  814. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  815. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  816. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  817. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  818. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  819. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  820. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  821. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  822. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  823. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  824. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  825. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  826. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  827. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  828. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  829. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  830. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  831. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  832. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  833. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  834. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  835. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  836. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  837. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  838. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  839. const reqBody = "some request body"
  840. const resBody = "some response body"
  841. if resHeader == noHeader {
  842. // TODO: test 100-continue followed by immediate
  843. // server stream reset, without headers in the middle?
  844. panic("invalid combination")
  845. }
  846. ct := newClientTester(t)
  847. ct.client = func() error {
  848. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  849. if expect100Continue != noHeader {
  850. req.Header.Set("Expect", "100-continue")
  851. }
  852. res, err := ct.tr.RoundTrip(req)
  853. if err != nil {
  854. return fmt.Errorf("RoundTrip: %v", err)
  855. }
  856. defer res.Body.Close()
  857. if res.StatusCode != 200 {
  858. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  859. }
  860. slurp, err := ioutil.ReadAll(res.Body)
  861. if err != nil {
  862. return fmt.Errorf("Slurp: %v", err)
  863. }
  864. wantBody := resBody
  865. if !withData {
  866. wantBody = ""
  867. }
  868. if string(slurp) != wantBody {
  869. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  870. }
  871. if trailers == noHeader {
  872. if len(res.Trailer) > 0 {
  873. t.Errorf("Trailer = %v; want none", res.Trailer)
  874. }
  875. } else {
  876. want := http.Header{"Some-Trailer": {"some-value"}}
  877. if !reflect.DeepEqual(res.Trailer, want) {
  878. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  879. }
  880. }
  881. return nil
  882. }
  883. ct.server = func() error {
  884. ct.greet()
  885. var buf bytes.Buffer
  886. enc := hpack.NewEncoder(&buf)
  887. for {
  888. f, err := ct.fr.ReadFrame()
  889. if err != nil {
  890. return err
  891. }
  892. switch f := f.(type) {
  893. case *WindowUpdateFrame, *SettingsFrame:
  894. case *DataFrame:
  895. // ignore for now.
  896. case *HeadersFrame:
  897. endStream := false
  898. send := func(mode headerType) {
  899. hbf := buf.Bytes()
  900. switch mode {
  901. case oneHeader:
  902. ct.fr.WriteHeaders(HeadersFrameParam{
  903. StreamID: f.StreamID,
  904. EndHeaders: true,
  905. EndStream: endStream,
  906. BlockFragment: hbf,
  907. })
  908. case splitHeader:
  909. if len(hbf) < 2 {
  910. panic("too small")
  911. }
  912. ct.fr.WriteHeaders(HeadersFrameParam{
  913. StreamID: f.StreamID,
  914. EndHeaders: false,
  915. EndStream: endStream,
  916. BlockFragment: hbf[:1],
  917. })
  918. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  919. default:
  920. panic("bogus mode")
  921. }
  922. }
  923. if expect100Continue != noHeader {
  924. buf.Reset()
  925. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  926. send(expect100Continue)
  927. }
  928. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  929. {
  930. buf.Reset()
  931. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  932. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  933. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  934. if trailers != noHeader {
  935. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  936. }
  937. endStream = withData == false && trailers == noHeader
  938. send(resHeader)
  939. }
  940. if withData {
  941. endStream = trailers == noHeader
  942. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  943. }
  944. if trailers != noHeader {
  945. endStream = true
  946. buf.Reset()
  947. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  948. send(trailers)
  949. }
  950. return nil
  951. }
  952. }
  953. }
  954. ct.run()
  955. }
  956. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  957. ct := newClientTester(t)
  958. ct.client = func() error {
  959. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  960. res, err := ct.tr.RoundTrip(req)
  961. if err != nil {
  962. return fmt.Errorf("RoundTrip: %v", err)
  963. }
  964. defer res.Body.Close()
  965. if res.StatusCode != 200 {
  966. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  967. }
  968. slurp, err := ioutil.ReadAll(res.Body)
  969. if err != nil {
  970. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  971. }
  972. if len(slurp) > 0 {
  973. return fmt.Errorf("body = %q; want nothing", slurp)
  974. }
  975. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  976. return fmt.Errorf("expected Some-Trailer")
  977. }
  978. return nil
  979. }
  980. ct.server = func() error {
  981. ct.greet()
  982. var n int
  983. var hf *HeadersFrame
  984. for hf == nil && n < 10 {
  985. f, err := ct.fr.ReadFrame()
  986. if err != nil {
  987. return err
  988. }
  989. hf, _ = f.(*HeadersFrame)
  990. n++
  991. }
  992. var buf bytes.Buffer
  993. enc := hpack.NewEncoder(&buf)
  994. // send headers without Trailer header
  995. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  996. ct.fr.WriteHeaders(HeadersFrameParam{
  997. StreamID: hf.StreamID,
  998. EndHeaders: true,
  999. EndStream: false,
  1000. BlockFragment: buf.Bytes(),
  1001. })
  1002. // send trailers
  1003. buf.Reset()
  1004. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  1005. ct.fr.WriteHeaders(HeadersFrameParam{
  1006. StreamID: hf.StreamID,
  1007. EndHeaders: true,
  1008. EndStream: true,
  1009. BlockFragment: buf.Bytes(),
  1010. })
  1011. return nil
  1012. }
  1013. ct.run()
  1014. }
  1015. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1016. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1017. }
  1018. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1019. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1020. }
  1021. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1022. testInvalidTrailer(t, trailers, errPseudoTrailers, func(enc *hpack.Encoder) {
  1023. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1024. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1025. })
  1026. }
  1027. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1028. testTransportInvalidTrailer_Capital(t, oneHeader)
  1029. }
  1030. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1031. testTransportInvalidTrailer_Capital(t, splitHeader)
  1032. }
  1033. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1034. testInvalidTrailer(t, trailers, errInvalidHeaderKey, func(enc *hpack.Encoder) {
  1035. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1036. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1037. })
  1038. }
  1039. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1040. ct := newClientTester(t)
  1041. ct.client = func() error {
  1042. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1043. res, err := ct.tr.RoundTrip(req)
  1044. if err != nil {
  1045. return fmt.Errorf("RoundTrip: %v", err)
  1046. }
  1047. defer res.Body.Close()
  1048. if res.StatusCode != 200 {
  1049. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1050. }
  1051. slurp, err := ioutil.ReadAll(res.Body)
  1052. if err != wantErr {
  1053. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, wantErr)
  1054. }
  1055. if len(slurp) > 0 {
  1056. return fmt.Errorf("body = %q; want nothing", slurp)
  1057. }
  1058. return nil
  1059. }
  1060. ct.server = func() error {
  1061. ct.greet()
  1062. var buf bytes.Buffer
  1063. enc := hpack.NewEncoder(&buf)
  1064. for {
  1065. f, err := ct.fr.ReadFrame()
  1066. if err != nil {
  1067. return err
  1068. }
  1069. switch f := f.(type) {
  1070. case *HeadersFrame:
  1071. var endStream bool
  1072. send := func(mode headerType) {
  1073. hbf := buf.Bytes()
  1074. switch mode {
  1075. case oneHeader:
  1076. ct.fr.WriteHeaders(HeadersFrameParam{
  1077. StreamID: f.StreamID,
  1078. EndHeaders: true,
  1079. EndStream: endStream,
  1080. BlockFragment: hbf,
  1081. })
  1082. case splitHeader:
  1083. if len(hbf) < 2 {
  1084. panic("too small")
  1085. }
  1086. ct.fr.WriteHeaders(HeadersFrameParam{
  1087. StreamID: f.StreamID,
  1088. EndHeaders: false,
  1089. EndStream: endStream,
  1090. BlockFragment: hbf[:1],
  1091. })
  1092. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1093. default:
  1094. panic("bogus mode")
  1095. }
  1096. }
  1097. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1098. {
  1099. buf.Reset()
  1100. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1101. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1102. endStream = false
  1103. send(oneHeader)
  1104. }
  1105. // Trailers:
  1106. {
  1107. endStream = true
  1108. buf.Reset()
  1109. writeTrailer(enc)
  1110. send(trailers)
  1111. }
  1112. return nil
  1113. }
  1114. }
  1115. }
  1116. ct.run()
  1117. }
  1118. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1119. ct := newClientTester(t)
  1120. ct.client = func() error {
  1121. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1122. res, err := ct.tr.RoundTrip(req)
  1123. if err != errResponseHeaderListSize {
  1124. if res != nil {
  1125. res.Body.Close()
  1126. }
  1127. size := int64(0)
  1128. for k, vv := range res.Header {
  1129. for _, v := range vv {
  1130. size += int64(len(k)) + int64(len(v)) + 32
  1131. }
  1132. }
  1133. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1134. }
  1135. return nil
  1136. }
  1137. ct.server = func() error {
  1138. ct.greet()
  1139. var buf bytes.Buffer
  1140. enc := hpack.NewEncoder(&buf)
  1141. for {
  1142. f, err := ct.fr.ReadFrame()
  1143. if err != nil {
  1144. return err
  1145. }
  1146. switch f := f.(type) {
  1147. case *HeadersFrame:
  1148. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1149. large := strings.Repeat("a", 1<<10)
  1150. for i := 0; i < 5042; i++ {
  1151. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1152. }
  1153. if size, want := buf.Len(), 6329; size != want {
  1154. // Note: this number might change if
  1155. // our hpack implementation
  1156. // changes. That's fine. This is
  1157. // just a sanity check that our
  1158. // response can fit in a single
  1159. // header block fragment frame.
  1160. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1161. }
  1162. ct.fr.WriteHeaders(HeadersFrameParam{
  1163. StreamID: f.StreamID,
  1164. EndHeaders: true,
  1165. EndStream: true,
  1166. BlockFragment: buf.Bytes(),
  1167. })
  1168. return nil
  1169. }
  1170. }
  1171. }
  1172. ct.run()
  1173. }
  1174. // Test that the the Transport returns a typed error from Response.Body.Read calls
  1175. // when the server sends an error. (here we use a panic, since that should generate
  1176. // a stream error, but others like cancel should be similar)
  1177. func TestTransportBodyReadErrorType(t *testing.T) {
  1178. doPanic := make(chan bool, 1)
  1179. st := newServerTester(t,
  1180. func(w http.ResponseWriter, r *http.Request) {
  1181. w.(http.Flusher).Flush() // force headers out
  1182. <-doPanic
  1183. panic("boom")
  1184. },
  1185. optOnlyServer,
  1186. optQuiet,
  1187. )
  1188. defer st.Close()
  1189. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1190. defer tr.CloseIdleConnections()
  1191. c := &http.Client{Transport: tr}
  1192. res, err := c.Get(st.ts.URL)
  1193. if err != nil {
  1194. t.Fatal(err)
  1195. }
  1196. defer res.Body.Close()
  1197. doPanic <- true
  1198. buf := make([]byte, 100)
  1199. n, err := res.Body.Read(buf)
  1200. want := StreamError{StreamID: 0x1, Code: 0x2}
  1201. if !reflect.DeepEqual(want, err) {
  1202. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1203. }
  1204. }
  1205. // golang.org/issue/13924
  1206. // This used to fail after many iterations, especially with -race:
  1207. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1208. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1209. var (
  1210. mu sync.Mutex
  1211. conn net.Conn // to close if set
  1212. )
  1213. st := newServerTester(t,
  1214. func(w http.ResponseWriter, r *http.Request) {
  1215. mu.Lock()
  1216. defer mu.Unlock()
  1217. if conn != nil {
  1218. conn.Close()
  1219. }
  1220. },
  1221. optOnlyServer,
  1222. )
  1223. defer st.Close()
  1224. tr := &Transport{
  1225. TLSClientConfig: tlsConfigInsecure,
  1226. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1227. tc, err := tls.Dial(network, addr, cfg)
  1228. if err != nil {
  1229. return nil, err
  1230. }
  1231. mu.Lock()
  1232. defer mu.Unlock()
  1233. conn = tc
  1234. return tc, nil
  1235. },
  1236. }
  1237. defer tr.CloseIdleConnections()
  1238. c := &http.Client{Transport: tr}
  1239. c.Get(st.ts.URL)
  1240. }
  1241. // Test that the http1 Transport.DisableKeepAlives option is respected
  1242. // and connections are closed as soon as idle.
  1243. // See golang.org/issue/14008
  1244. func TestTransportDisableKeepAlives(t *testing.T) {
  1245. st := newServerTester(t,
  1246. func(w http.ResponseWriter, r *http.Request) {
  1247. io.WriteString(w, "hi")
  1248. },
  1249. optOnlyServer,
  1250. )
  1251. defer st.Close()
  1252. connClosed := make(chan struct{}) // closed on tls.Conn.Close
  1253. tr := &Transport{
  1254. t1: &http.Transport{
  1255. DisableKeepAlives: true,
  1256. },
  1257. TLSClientConfig: tlsConfigInsecure,
  1258. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1259. tc, err := tls.Dial(network, addr, cfg)
  1260. if err != nil {
  1261. return nil, err
  1262. }
  1263. return &noteCloseConn{Conn: tc, closefn: func() { close(connClosed) }}, nil
  1264. },
  1265. }
  1266. c := &http.Client{Transport: tr}
  1267. res, err := c.Get(st.ts.URL)
  1268. if err != nil {
  1269. t.Fatal(err)
  1270. }
  1271. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1272. t.Fatal(err)
  1273. }
  1274. defer res.Body.Close()
  1275. select {
  1276. case <-connClosed:
  1277. case <-time.After(1 * time.Second):
  1278. t.Errorf("timeout")
  1279. }
  1280. }
  1281. // Test concurrent requests with Transport.DisableKeepAlives. We can share connections,
  1282. // but when things are totally idle, it still needs to close.
  1283. func TestTransportDisableKeepAlives_Concurrency(t *testing.T) {
  1284. const D = 25 * time.Millisecond
  1285. st := newServerTester(t,
  1286. func(w http.ResponseWriter, r *http.Request) {
  1287. time.Sleep(D)
  1288. io.WriteString(w, "hi")
  1289. },
  1290. optOnlyServer,
  1291. )
  1292. defer st.Close()
  1293. var dials int32
  1294. var conns sync.WaitGroup
  1295. tr := &Transport{
  1296. t1: &http.Transport{
  1297. DisableKeepAlives: true,
  1298. },
  1299. TLSClientConfig: tlsConfigInsecure,
  1300. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1301. tc, err := tls.Dial(network, addr, cfg)
  1302. if err != nil {
  1303. return nil, err
  1304. }
  1305. atomic.AddInt32(&dials, 1)
  1306. conns.Add(1)
  1307. return &noteCloseConn{Conn: tc, closefn: func() { conns.Done() }}, nil
  1308. },
  1309. }
  1310. c := &http.Client{Transport: tr}
  1311. var reqs sync.WaitGroup
  1312. const N = 20
  1313. for i := 0; i < N; i++ {
  1314. reqs.Add(1)
  1315. if i == N-1 {
  1316. // For the final request, try to make all the
  1317. // others close. This isn't verified in the
  1318. // count, other than the Log statement, since
  1319. // it's so timing dependent. This test is
  1320. // really to make sure we don't interrupt a
  1321. // valid request.
  1322. time.Sleep(D * 2)
  1323. }
  1324. go func() {
  1325. defer reqs.Done()
  1326. res, err := c.Get(st.ts.URL)
  1327. if err != nil {
  1328. t.Error(err)
  1329. return
  1330. }
  1331. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1332. t.Error(err)
  1333. return
  1334. }
  1335. res.Body.Close()
  1336. }()
  1337. }
  1338. reqs.Wait()
  1339. conns.Wait()
  1340. t.Logf("did %d dials, %d requests", atomic.LoadInt32(&dials), N)
  1341. }
  1342. type noteCloseConn struct {
  1343. net.Conn
  1344. onceClose sync.Once
  1345. closefn func()
  1346. }
  1347. func (c *noteCloseConn) Close() error {
  1348. c.onceClose.Do(c.closefn)
  1349. return c.Conn.Close()
  1350. }
  1351. func isTimeout(err error) bool {
  1352. switch err := err.(type) {
  1353. case nil:
  1354. return false
  1355. case *url.Error:
  1356. return isTimeout(err.Err)
  1357. case net.Error:
  1358. return err.Timeout()
  1359. }
  1360. return false
  1361. }
  1362. // Test that the http1 Transport.ResponseHeaderTimeout option and cancel is sent.
  1363. func TestTransportResponseHeaderTimeout_NoBody(t *testing.T) {
  1364. testTransportResponseHeaderTimeout(t, false)
  1365. }
  1366. func TestTransportResponseHeaderTimeout_Body(t *testing.T) {
  1367. testTransportResponseHeaderTimeout(t, true)
  1368. }
  1369. func testTransportResponseHeaderTimeout(t *testing.T, body bool) {
  1370. ct := newClientTester(t)
  1371. ct.tr.t1 = &http.Transport{
  1372. ResponseHeaderTimeout: 5 * time.Millisecond,
  1373. }
  1374. ct.client = func() error {
  1375. c := &http.Client{Transport: ct.tr}
  1376. var err error
  1377. var n int64
  1378. const bodySize = 4 << 20
  1379. if body {
  1380. _, err = c.Post("https://dummy.tld/", "text/foo", io.LimitReader(countingReader{&n}, bodySize))
  1381. } else {
  1382. _, err = c.Get("https://dummy.tld/")
  1383. }
  1384. if !isTimeout(err) {
  1385. t.Errorf("client expected timeout error; got %#v", err)
  1386. }
  1387. if body && n != bodySize {
  1388. t.Errorf("only read %d bytes of body; want %d", n, bodySize)
  1389. }
  1390. return nil
  1391. }
  1392. ct.server = func() error {
  1393. ct.greet()
  1394. for {
  1395. f, err := ct.fr.ReadFrame()
  1396. if err != nil {
  1397. t.Logf("ReadFrame: %v", err)
  1398. return nil
  1399. }
  1400. switch f := f.(type) {
  1401. case *DataFrame:
  1402. dataLen := len(f.Data())
  1403. if dataLen > 0 {
  1404. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  1405. return err
  1406. }
  1407. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  1408. return err
  1409. }
  1410. }
  1411. case *RSTStreamFrame:
  1412. if f.StreamID == 1 && f.ErrCode == ErrCodeCancel {
  1413. return nil
  1414. }
  1415. }
  1416. }
  1417. return nil
  1418. }
  1419. ct.run()
  1420. }
  1421. func TestTransportDisableCompression(t *testing.T) {
  1422. const body = "sup"
  1423. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1424. want := http.Header{
  1425. "User-Agent": []string{"Go-http-client/2.0"},
  1426. }
  1427. if !reflect.DeepEqual(r.Header, want) {
  1428. t.Errorf("request headers = %v; want %v", r.Header, want)
  1429. }
  1430. }, optOnlyServer)
  1431. defer st.Close()
  1432. tr := &Transport{
  1433. TLSClientConfig: tlsConfigInsecure,
  1434. t1: &http.Transport{
  1435. DisableCompression: true,
  1436. },
  1437. }
  1438. defer tr.CloseIdleConnections()
  1439. req, err := http.NewRequest("GET", st.ts.URL, nil)
  1440. if err != nil {
  1441. t.Fatal(err)
  1442. }
  1443. res, err := tr.RoundTrip(req)
  1444. if err != nil {
  1445. t.Fatal(err)
  1446. }
  1447. defer res.Body.Close()
  1448. }