server_test.go 90 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. logBuf *bytes.Buffer
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // writing headers:
  48. headerBuf bytes.Buffer
  49. hpackEnc *hpack.Encoder
  50. // reading frames:
  51. frc chan Frame
  52. frErrc chan error
  53. readTimer *time.Timer
  54. }
  55. func init() {
  56. testHookOnPanicMu = new(sync.Mutex)
  57. }
  58. func resetHooks() {
  59. testHookOnPanicMu.Lock()
  60. testHookOnPanic = nil
  61. testHookOnPanicMu.Unlock()
  62. }
  63. type serverTesterOpt string
  64. var optOnlyServer = serverTesterOpt("only_server")
  65. var optQuiet = serverTesterOpt("quiet_logging")
  66. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  67. resetHooks()
  68. logBuf := new(bytes.Buffer)
  69. ts := httptest.NewUnstartedServer(handler)
  70. tlsConfig := &tls.Config{
  71. InsecureSkipVerify: true,
  72. // The h2-14 is temporary, until curl is updated. (as used by unit tests
  73. // in Docker)
  74. NextProtos: []string{NextProtoTLS, "h2-14"},
  75. }
  76. var onlyServer, quiet bool
  77. for _, opt := range opts {
  78. switch v := opt.(type) {
  79. case func(*tls.Config):
  80. v(tlsConfig)
  81. case func(*httptest.Server):
  82. v(ts)
  83. case serverTesterOpt:
  84. switch v {
  85. case optOnlyServer:
  86. onlyServer = true
  87. case optQuiet:
  88. quiet = true
  89. }
  90. default:
  91. t.Fatalf("unknown newServerTester option type %T", v)
  92. }
  93. }
  94. ConfigureServer(ts.Config, &Server{})
  95. st := &serverTester{
  96. t: t,
  97. ts: ts,
  98. logBuf: logBuf,
  99. frc: make(chan Frame, 1),
  100. frErrc: make(chan error, 1),
  101. }
  102. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  103. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  104. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  105. if quiet {
  106. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  107. } else {
  108. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  109. }
  110. ts.StartTLS()
  111. if VerboseLogs {
  112. t.Logf("Running test server at: %s", ts.URL)
  113. }
  114. testHookGetServerConn = func(v *serverConn) {
  115. st.scMu.Lock()
  116. defer st.scMu.Unlock()
  117. st.sc = v
  118. st.sc.testHookCh = make(chan func(int))
  119. }
  120. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  121. if !onlyServer {
  122. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  123. if err != nil {
  124. t.Fatal(err)
  125. }
  126. st.cc = cc
  127. st.fr = NewFramer(cc, cc)
  128. }
  129. return st
  130. }
  131. func (st *serverTester) closeConn() {
  132. st.scMu.Lock()
  133. defer st.scMu.Unlock()
  134. st.sc.conn.Close()
  135. }
  136. func (st *serverTester) addLogFilter(phrase string) {
  137. st.logFilter = append(st.logFilter, phrase)
  138. }
  139. func (st *serverTester) stream(id uint32) *stream {
  140. ch := make(chan *stream, 1)
  141. st.sc.testHookCh <- func(int) {
  142. ch <- st.sc.streams[id]
  143. }
  144. return <-ch
  145. }
  146. func (st *serverTester) streamState(id uint32) streamState {
  147. ch := make(chan streamState, 1)
  148. st.sc.testHookCh <- func(int) {
  149. state, _ := st.sc.state(id)
  150. ch <- state
  151. }
  152. return <-ch
  153. }
  154. // loopNum reports how many times this conn's select loop has gone around.
  155. func (st *serverTester) loopNum() int {
  156. lastc := make(chan int, 1)
  157. st.sc.testHookCh <- func(loopNum int) {
  158. lastc <- loopNum
  159. }
  160. return <-lastc
  161. }
  162. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  163. // The heuristic is that the server connection's serve loop must schedule
  164. // 50 times in a row without any channel sends or receives occurring.
  165. func (st *serverTester) awaitIdle() {
  166. remain := 50
  167. last := st.loopNum()
  168. for remain > 0 {
  169. n := st.loopNum()
  170. if n == last+1 {
  171. remain--
  172. } else {
  173. remain = 50
  174. }
  175. last = n
  176. }
  177. }
  178. func (st *serverTester) Close() {
  179. if st.t.Failed() {
  180. // If we failed already (and are likely in a Fatal,
  181. // unwindowing), force close the connection, so the
  182. // httptest.Server doesn't wait forever for the conn
  183. // to close.
  184. if st.cc != nil {
  185. st.cc.Close()
  186. }
  187. }
  188. st.ts.Close()
  189. if st.cc != nil {
  190. st.cc.Close()
  191. }
  192. log.SetOutput(os.Stderr)
  193. }
  194. // greet initiates the client's HTTP/2 connection into a state where
  195. // frames may be sent.
  196. func (st *serverTester) greet() {
  197. st.writePreface()
  198. st.writeInitialSettings()
  199. st.wantSettings()
  200. st.writeSettingsAck()
  201. st.wantSettingsAck()
  202. }
  203. func (st *serverTester) writePreface() {
  204. n, err := st.cc.Write(clientPreface)
  205. if err != nil {
  206. st.t.Fatalf("Error writing client preface: %v", err)
  207. }
  208. if n != len(clientPreface) {
  209. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  210. }
  211. }
  212. func (st *serverTester) writeInitialSettings() {
  213. if err := st.fr.WriteSettings(); err != nil {
  214. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  215. }
  216. }
  217. func (st *serverTester) writeSettingsAck() {
  218. if err := st.fr.WriteSettingsAck(); err != nil {
  219. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  220. }
  221. }
  222. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  223. if err := st.fr.WriteHeaders(p); err != nil {
  224. st.t.Fatalf("Error writing HEADERS: %v", err)
  225. }
  226. }
  227. func (st *serverTester) encodeHeaderField(k, v string) {
  228. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  229. if err != nil {
  230. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  231. }
  232. }
  233. // encodeHeaderRaw is the magic-free version of encodeHeader.
  234. // It takes 0 or more (k, v) pairs and encodes them.
  235. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  236. if len(headers)%2 == 1 {
  237. panic("odd number of kv args")
  238. }
  239. st.headerBuf.Reset()
  240. for len(headers) > 0 {
  241. k, v := headers[0], headers[1]
  242. st.encodeHeaderField(k, v)
  243. headers = headers[2:]
  244. }
  245. return st.headerBuf.Bytes()
  246. }
  247. // encodeHeader encodes headers and returns their HPACK bytes. headers
  248. // must contain an even number of key/value pairs. There may be
  249. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  250. // :scheme headers default to GET, / and https.
  251. func (st *serverTester) encodeHeader(headers ...string) []byte {
  252. if len(headers)%2 == 1 {
  253. panic("odd number of kv args")
  254. }
  255. st.headerBuf.Reset()
  256. if len(headers) == 0 {
  257. // Fast path, mostly for benchmarks, so test code doesn't pollute
  258. // profiles when we're looking to improve server allocations.
  259. st.encodeHeaderField(":method", "GET")
  260. st.encodeHeaderField(":path", "/")
  261. st.encodeHeaderField(":scheme", "https")
  262. return st.headerBuf.Bytes()
  263. }
  264. if len(headers) == 2 && headers[0] == ":method" {
  265. // Another fast path for benchmarks.
  266. st.encodeHeaderField(":method", headers[1])
  267. st.encodeHeaderField(":path", "/")
  268. st.encodeHeaderField(":scheme", "https")
  269. return st.headerBuf.Bytes()
  270. }
  271. pseudoCount := map[string]int{}
  272. keys := []string{":method", ":path", ":scheme"}
  273. vals := map[string][]string{
  274. ":method": {"GET"},
  275. ":path": {"/"},
  276. ":scheme": {"https"},
  277. }
  278. for len(headers) > 0 {
  279. k, v := headers[0], headers[1]
  280. headers = headers[2:]
  281. if _, ok := vals[k]; !ok {
  282. keys = append(keys, k)
  283. }
  284. if strings.HasPrefix(k, ":") {
  285. pseudoCount[k]++
  286. if pseudoCount[k] == 1 {
  287. vals[k] = []string{v}
  288. } else {
  289. // Allows testing of invalid headers w/ dup pseudo fields.
  290. vals[k] = append(vals[k], v)
  291. }
  292. } else {
  293. vals[k] = append(vals[k], v)
  294. }
  295. }
  296. for _, k := range keys {
  297. for _, v := range vals[k] {
  298. st.encodeHeaderField(k, v)
  299. }
  300. }
  301. return st.headerBuf.Bytes()
  302. }
  303. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  304. func (st *serverTester) bodylessReq1(headers ...string) {
  305. st.writeHeaders(HeadersFrameParam{
  306. StreamID: 1, // clients send odd numbers
  307. BlockFragment: st.encodeHeader(headers...),
  308. EndStream: true,
  309. EndHeaders: true,
  310. })
  311. }
  312. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  313. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  314. st.t.Fatalf("Error writing DATA: %v", err)
  315. }
  316. }
  317. func (st *serverTester) readFrame() (Frame, error) {
  318. go func() {
  319. fr, err := st.fr.ReadFrame()
  320. if err != nil {
  321. st.frErrc <- err
  322. } else {
  323. st.frc <- fr
  324. }
  325. }()
  326. t := st.readTimer
  327. if t == nil {
  328. t = time.NewTimer(2 * time.Second)
  329. st.readTimer = t
  330. }
  331. t.Reset(2 * time.Second)
  332. defer t.Stop()
  333. select {
  334. case f := <-st.frc:
  335. return f, nil
  336. case err := <-st.frErrc:
  337. return nil, err
  338. case <-t.C:
  339. return nil, errors.New("timeout waiting for frame")
  340. }
  341. }
  342. func (st *serverTester) wantHeaders() *HeadersFrame {
  343. f, err := st.readFrame()
  344. if err != nil {
  345. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  346. }
  347. hf, ok := f.(*HeadersFrame)
  348. if !ok {
  349. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  350. }
  351. return hf
  352. }
  353. func (st *serverTester) wantContinuation() *ContinuationFrame {
  354. f, err := st.readFrame()
  355. if err != nil {
  356. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  357. }
  358. cf, ok := f.(*ContinuationFrame)
  359. if !ok {
  360. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  361. }
  362. return cf
  363. }
  364. func (st *serverTester) wantData() *DataFrame {
  365. f, err := st.readFrame()
  366. if err != nil {
  367. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  368. }
  369. df, ok := f.(*DataFrame)
  370. if !ok {
  371. st.t.Fatalf("got a %T; want *DataFrame", f)
  372. }
  373. return df
  374. }
  375. func (st *serverTester) wantSettings() *SettingsFrame {
  376. f, err := st.readFrame()
  377. if err != nil {
  378. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  379. }
  380. sf, ok := f.(*SettingsFrame)
  381. if !ok {
  382. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  383. }
  384. return sf
  385. }
  386. func (st *serverTester) wantPing() *PingFrame {
  387. f, err := st.readFrame()
  388. if err != nil {
  389. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  390. }
  391. pf, ok := f.(*PingFrame)
  392. if !ok {
  393. st.t.Fatalf("got a %T; want *PingFrame", f)
  394. }
  395. return pf
  396. }
  397. func (st *serverTester) wantGoAway() *GoAwayFrame {
  398. f, err := st.readFrame()
  399. if err != nil {
  400. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  401. }
  402. gf, ok := f.(*GoAwayFrame)
  403. if !ok {
  404. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  405. }
  406. return gf
  407. }
  408. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  409. f, err := st.readFrame()
  410. if err != nil {
  411. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  412. }
  413. rs, ok := f.(*RSTStreamFrame)
  414. if !ok {
  415. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  416. }
  417. if rs.FrameHeader.StreamID != streamID {
  418. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  419. }
  420. if rs.ErrCode != errCode {
  421. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  422. }
  423. }
  424. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  425. f, err := st.readFrame()
  426. if err != nil {
  427. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  428. }
  429. wu, ok := f.(*WindowUpdateFrame)
  430. if !ok {
  431. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  432. }
  433. if wu.FrameHeader.StreamID != streamID {
  434. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  435. }
  436. if wu.Increment != incr {
  437. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  438. }
  439. }
  440. func (st *serverTester) wantSettingsAck() {
  441. f, err := st.readFrame()
  442. if err != nil {
  443. st.t.Fatal(err)
  444. }
  445. sf, ok := f.(*SettingsFrame)
  446. if !ok {
  447. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  448. }
  449. if !sf.Header().Flags.Has(FlagSettingsAck) {
  450. st.t.Fatal("Settings Frame didn't have ACK set")
  451. }
  452. }
  453. func TestServer(t *testing.T) {
  454. gotReq := make(chan bool, 1)
  455. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  456. w.Header().Set("Foo", "Bar")
  457. gotReq <- true
  458. })
  459. defer st.Close()
  460. covers("3.5", `
  461. The server connection preface consists of a potentially empty
  462. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  463. server sends in the HTTP/2 connection.
  464. `)
  465. st.writePreface()
  466. st.writeInitialSettings()
  467. st.wantSettings()
  468. st.writeSettingsAck()
  469. st.wantSettingsAck()
  470. st.writeHeaders(HeadersFrameParam{
  471. StreamID: 1, // clients send odd numbers
  472. BlockFragment: st.encodeHeader(),
  473. EndStream: true, // no DATA frames
  474. EndHeaders: true,
  475. })
  476. select {
  477. case <-gotReq:
  478. case <-time.After(2 * time.Second):
  479. t.Error("timeout waiting for request")
  480. }
  481. }
  482. func TestServer_Request_Get(t *testing.T) {
  483. testServerRequest(t, func(st *serverTester) {
  484. st.writeHeaders(HeadersFrameParam{
  485. StreamID: 1, // clients send odd numbers
  486. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  487. EndStream: true, // no DATA frames
  488. EndHeaders: true,
  489. })
  490. }, func(r *http.Request) {
  491. if r.Method != "GET" {
  492. t.Errorf("Method = %q; want GET", r.Method)
  493. }
  494. if r.URL.Path != "/" {
  495. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  496. }
  497. if r.ContentLength != 0 {
  498. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  499. }
  500. if r.Close {
  501. t.Error("Close = true; want false")
  502. }
  503. if !strings.Contains(r.RemoteAddr, ":") {
  504. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  505. }
  506. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  507. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  508. }
  509. wantHeader := http.Header{
  510. "Foo-Bar": []string{"some-value"},
  511. }
  512. if !reflect.DeepEqual(r.Header, wantHeader) {
  513. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  514. }
  515. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  516. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  517. }
  518. })
  519. }
  520. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  521. testServerRequest(t, func(st *serverTester) {
  522. st.writeHeaders(HeadersFrameParam{
  523. StreamID: 1, // clients send odd numbers
  524. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  525. EndStream: true, // no DATA frames
  526. EndHeaders: true,
  527. })
  528. }, func(r *http.Request) {
  529. if r.RequestURI != "/%2f/" {
  530. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  531. }
  532. if r.URL.Path != "///" {
  533. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  534. }
  535. })
  536. }
  537. // TODO: add a test with EndStream=true on the HEADERS but setting a
  538. // Content-Length anyway. Should we just omit it and force it to
  539. // zero?
  540. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  541. testServerRequest(t, func(st *serverTester) {
  542. st.writeHeaders(HeadersFrameParam{
  543. StreamID: 1, // clients send odd numbers
  544. BlockFragment: st.encodeHeader(":method", "POST"),
  545. EndStream: true,
  546. EndHeaders: true,
  547. })
  548. }, func(r *http.Request) {
  549. if r.Method != "POST" {
  550. t.Errorf("Method = %q; want POST", r.Method)
  551. }
  552. if r.ContentLength != 0 {
  553. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  554. }
  555. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  556. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  557. }
  558. })
  559. }
  560. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  561. testBodyContents(t, -1, "", func(st *serverTester) {
  562. st.writeHeaders(HeadersFrameParam{
  563. StreamID: 1, // clients send odd numbers
  564. BlockFragment: st.encodeHeader(":method", "POST"),
  565. EndStream: false, // to say DATA frames are coming
  566. EndHeaders: true,
  567. })
  568. st.writeData(1, true, nil) // just kidding. empty body.
  569. })
  570. }
  571. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  572. const content = "Some content"
  573. testBodyContents(t, -1, content, func(st *serverTester) {
  574. st.writeHeaders(HeadersFrameParam{
  575. StreamID: 1, // clients send odd numbers
  576. BlockFragment: st.encodeHeader(":method", "POST"),
  577. EndStream: false, // to say DATA frames are coming
  578. EndHeaders: true,
  579. })
  580. st.writeData(1, true, []byte(content))
  581. })
  582. }
  583. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  584. const content = "Some content"
  585. testBodyContents(t, -1, content, func(st *serverTester) {
  586. st.writeHeaders(HeadersFrameParam{
  587. StreamID: 1, // clients send odd numbers
  588. BlockFragment: st.encodeHeader(":method", "POST"),
  589. EndStream: false, // to say DATA frames are coming
  590. EndHeaders: true,
  591. })
  592. st.writeData(1, false, []byte(content[:5]))
  593. st.writeData(1, true, []byte(content[5:]))
  594. })
  595. }
  596. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  597. const content = "Some content"
  598. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  599. st.writeHeaders(HeadersFrameParam{
  600. StreamID: 1, // clients send odd numbers
  601. BlockFragment: st.encodeHeader(
  602. ":method", "POST",
  603. "content-length", strconv.Itoa(len(content)),
  604. ),
  605. EndStream: false, // to say DATA frames are coming
  606. EndHeaders: true,
  607. })
  608. st.writeData(1, true, []byte(content))
  609. })
  610. }
  611. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  612. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  613. func(st *serverTester) {
  614. st.writeHeaders(HeadersFrameParam{
  615. StreamID: 1, // clients send odd numbers
  616. BlockFragment: st.encodeHeader(
  617. ":method", "POST",
  618. "content-length", "3",
  619. ),
  620. EndStream: false, // to say DATA frames are coming
  621. EndHeaders: true,
  622. })
  623. st.writeData(1, true, []byte("12"))
  624. })
  625. }
  626. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  627. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  628. func(st *serverTester) {
  629. st.writeHeaders(HeadersFrameParam{
  630. StreamID: 1, // clients send odd numbers
  631. BlockFragment: st.encodeHeader(
  632. ":method", "POST",
  633. "content-length", "4",
  634. ),
  635. EndStream: false, // to say DATA frames are coming
  636. EndHeaders: true,
  637. })
  638. st.writeData(1, true, []byte("12345"))
  639. })
  640. }
  641. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  642. testServerRequest(t, write, func(r *http.Request) {
  643. if r.Method != "POST" {
  644. t.Errorf("Method = %q; want POST", r.Method)
  645. }
  646. if r.ContentLength != wantContentLength {
  647. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  648. }
  649. all, err := ioutil.ReadAll(r.Body)
  650. if err != nil {
  651. t.Fatal(err)
  652. }
  653. if string(all) != wantBody {
  654. t.Errorf("Read = %q; want %q", all, wantBody)
  655. }
  656. if err := r.Body.Close(); err != nil {
  657. t.Fatalf("Close: %v", err)
  658. }
  659. })
  660. }
  661. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  662. testServerRequest(t, write, func(r *http.Request) {
  663. if r.Method != "POST" {
  664. t.Errorf("Method = %q; want POST", r.Method)
  665. }
  666. if r.ContentLength != wantContentLength {
  667. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  668. }
  669. all, err := ioutil.ReadAll(r.Body)
  670. if err == nil {
  671. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  672. wantReadError, all)
  673. }
  674. if !strings.Contains(err.Error(), wantReadError) {
  675. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  676. }
  677. if err := r.Body.Close(); err != nil {
  678. t.Fatalf("Close: %v", err)
  679. }
  680. })
  681. }
  682. // Using a Host header, instead of :authority
  683. func TestServer_Request_Get_Host(t *testing.T) {
  684. const host = "example.com"
  685. testServerRequest(t, func(st *serverTester) {
  686. st.writeHeaders(HeadersFrameParam{
  687. StreamID: 1, // clients send odd numbers
  688. BlockFragment: st.encodeHeader("host", host),
  689. EndStream: true,
  690. EndHeaders: true,
  691. })
  692. }, func(r *http.Request) {
  693. if r.Host != host {
  694. t.Errorf("Host = %q; want %q", r.Host, host)
  695. }
  696. })
  697. }
  698. // Using an :authority pseudo-header, instead of Host
  699. func TestServer_Request_Get_Authority(t *testing.T) {
  700. const host = "example.com"
  701. testServerRequest(t, func(st *serverTester) {
  702. st.writeHeaders(HeadersFrameParam{
  703. StreamID: 1, // clients send odd numbers
  704. BlockFragment: st.encodeHeader(":authority", host),
  705. EndStream: true,
  706. EndHeaders: true,
  707. })
  708. }, func(r *http.Request) {
  709. if r.Host != host {
  710. t.Errorf("Host = %q; want %q", r.Host, host)
  711. }
  712. })
  713. }
  714. func TestServer_Request_WithContinuation(t *testing.T) {
  715. wantHeader := http.Header{
  716. "Foo-One": []string{"value-one"},
  717. "Foo-Two": []string{"value-two"},
  718. "Foo-Three": []string{"value-three"},
  719. }
  720. testServerRequest(t, func(st *serverTester) {
  721. fullHeaders := st.encodeHeader(
  722. "foo-one", "value-one",
  723. "foo-two", "value-two",
  724. "foo-three", "value-three",
  725. )
  726. remain := fullHeaders
  727. chunks := 0
  728. for len(remain) > 0 {
  729. const maxChunkSize = 5
  730. chunk := remain
  731. if len(chunk) > maxChunkSize {
  732. chunk = chunk[:maxChunkSize]
  733. }
  734. remain = remain[len(chunk):]
  735. if chunks == 0 {
  736. st.writeHeaders(HeadersFrameParam{
  737. StreamID: 1, // clients send odd numbers
  738. BlockFragment: chunk,
  739. EndStream: true, // no DATA frames
  740. EndHeaders: false, // we'll have continuation frames
  741. })
  742. } else {
  743. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  744. if err != nil {
  745. t.Fatal(err)
  746. }
  747. }
  748. chunks++
  749. }
  750. if chunks < 2 {
  751. t.Fatal("too few chunks")
  752. }
  753. }, func(r *http.Request) {
  754. if !reflect.DeepEqual(r.Header, wantHeader) {
  755. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  756. }
  757. })
  758. }
  759. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  760. func TestServer_Request_CookieConcat(t *testing.T) {
  761. const host = "example.com"
  762. testServerRequest(t, func(st *serverTester) {
  763. st.bodylessReq1(
  764. ":authority", host,
  765. "cookie", "a=b",
  766. "cookie", "c=d",
  767. "cookie", "e=f",
  768. )
  769. }, func(r *http.Request) {
  770. const want = "a=b; c=d; e=f"
  771. if got := r.Header.Get("Cookie"); got != want {
  772. t.Errorf("Cookie = %q; want %q", got, want)
  773. }
  774. })
  775. }
  776. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  777. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  778. }
  779. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  780. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  781. }
  782. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  783. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  784. }
  785. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  786. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  787. }
  788. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  789. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  790. }
  791. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  792. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  793. }
  794. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  795. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  796. }
  797. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  798. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  799. }
  800. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  801. // 8.1.2.3 Request Pseudo-Header Fields
  802. // "All HTTP/2 requests MUST include exactly one valid value" ...
  803. testRejectRequest(t, func(st *serverTester) {
  804. st.addLogFilter("duplicate pseudo-header")
  805. st.bodylessReq1(":method", "GET", ":method", "POST")
  806. })
  807. }
  808. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  809. // 8.1.2.3 Request Pseudo-Header Fields
  810. // "All pseudo-header fields MUST appear in the header block
  811. // before regular header fields. Any request or response that
  812. // contains a pseudo-header field that appears in a header
  813. // block after a regular header field MUST be treated as
  814. // malformed (Section 8.1.2.6)."
  815. testRejectRequest(t, func(st *serverTester) {
  816. st.addLogFilter("pseudo-header after regular header")
  817. var buf bytes.Buffer
  818. enc := hpack.NewEncoder(&buf)
  819. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  820. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  821. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  822. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  823. st.writeHeaders(HeadersFrameParam{
  824. StreamID: 1, // clients send odd numbers
  825. BlockFragment: buf.Bytes(),
  826. EndStream: true,
  827. EndHeaders: true,
  828. })
  829. })
  830. }
  831. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  832. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  833. }
  834. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  835. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  836. }
  837. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  838. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  839. }
  840. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  841. testRejectRequest(t, func(st *serverTester) {
  842. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  843. st.bodylessReq1(":unknown_thing", "")
  844. })
  845. }
  846. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  847. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  848. t.Fatal("server request made it to handler; should've been rejected")
  849. })
  850. defer st.Close()
  851. st.greet()
  852. send(st)
  853. st.wantRSTStream(1, ErrCodeProtocol)
  854. }
  855. func TestServer_Request_Connect(t *testing.T) {
  856. testServerRequest(t, func(st *serverTester) {
  857. st.writeHeaders(HeadersFrameParam{
  858. StreamID: 1,
  859. BlockFragment: st.encodeHeaderRaw(
  860. ":method", "CONNECT",
  861. ":authority", "example.com:123",
  862. ),
  863. EndStream: true,
  864. EndHeaders: true,
  865. })
  866. }, func(r *http.Request) {
  867. if g, w := r.Method, "CONNECT"; g != w {
  868. t.Errorf("Method = %q; want %q", g, w)
  869. }
  870. if g, w := r.RequestURI, "example.com:123"; g != w {
  871. t.Errorf("RequestURI = %q; want %q", g, w)
  872. }
  873. if g, w := r.URL.Host, "example.com:123"; g != w {
  874. t.Errorf("URL.Host = %q; want %q", g, w)
  875. }
  876. })
  877. }
  878. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  879. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  880. st.writeHeaders(HeadersFrameParam{
  881. StreamID: 1,
  882. BlockFragment: st.encodeHeaderRaw(
  883. ":method", "CONNECT",
  884. ":authority", "example.com:123",
  885. ":path", "/bogus",
  886. ),
  887. EndStream: true,
  888. EndHeaders: true,
  889. })
  890. })
  891. }
  892. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  893. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  894. st.writeHeaders(HeadersFrameParam{
  895. StreamID: 1,
  896. BlockFragment: st.encodeHeaderRaw(
  897. ":method", "CONNECT",
  898. ":authority", "example.com:123",
  899. ":scheme", "https",
  900. ),
  901. EndStream: true,
  902. EndHeaders: true,
  903. })
  904. })
  905. }
  906. func TestServer_Ping(t *testing.T) {
  907. st := newServerTester(t, nil)
  908. defer st.Close()
  909. st.greet()
  910. // Server should ignore this one, since it has ACK set.
  911. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  912. if err := st.fr.WritePing(true, ackPingData); err != nil {
  913. t.Fatal(err)
  914. }
  915. // But the server should reply to this one, since ACK is false.
  916. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  917. if err := st.fr.WritePing(false, pingData); err != nil {
  918. t.Fatal(err)
  919. }
  920. pf := st.wantPing()
  921. if !pf.Flags.Has(FlagPingAck) {
  922. t.Error("response ping doesn't have ACK set")
  923. }
  924. if pf.Data != pingData {
  925. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  926. }
  927. }
  928. func TestServer_RejectsLargeFrames(t *testing.T) {
  929. if runtime.GOOS == "windows" {
  930. t.Skip("see golang.org/issue/13434")
  931. }
  932. st := newServerTester(t, nil)
  933. defer st.Close()
  934. st.greet()
  935. // Write too large of a frame (too large by one byte)
  936. // We ignore the return value because it's expected that the server
  937. // will only read the first 9 bytes (the headre) and then disconnect.
  938. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  939. gf := st.wantGoAway()
  940. if gf.ErrCode != ErrCodeFrameSize {
  941. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  942. }
  943. if st.logBuf.Len() != 0 {
  944. // Previously we spun here for a bit until the GOAWAY disconnect
  945. // timer fired, logging while we fired.
  946. t.Errorf("unexpected server output: %.500s\n", st.logBuf.Bytes())
  947. }
  948. }
  949. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  950. puppet := newHandlerPuppet()
  951. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  952. puppet.act(w, r)
  953. })
  954. defer st.Close()
  955. defer puppet.done()
  956. st.greet()
  957. st.writeHeaders(HeadersFrameParam{
  958. StreamID: 1, // clients send odd numbers
  959. BlockFragment: st.encodeHeader(":method", "POST"),
  960. EndStream: false, // data coming
  961. EndHeaders: true,
  962. })
  963. st.writeData(1, false, []byte("abcdef"))
  964. puppet.do(readBodyHandler(t, "abc"))
  965. st.wantWindowUpdate(0, 3)
  966. st.wantWindowUpdate(1, 3)
  967. puppet.do(readBodyHandler(t, "def"))
  968. st.wantWindowUpdate(0, 3)
  969. st.wantWindowUpdate(1, 3)
  970. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  971. puppet.do(readBodyHandler(t, "ghi"))
  972. puppet.do(readBodyHandler(t, "jkl"))
  973. st.wantWindowUpdate(0, 3)
  974. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  975. }
  976. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  977. st := newServerTester(t, nil)
  978. defer st.Close()
  979. st.greet()
  980. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  981. t.Fatal(err)
  982. }
  983. gf := st.wantGoAway()
  984. if gf.ErrCode != ErrCodeFlowControl {
  985. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  986. }
  987. if gf.LastStreamID != 0 {
  988. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  989. }
  990. }
  991. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  992. inHandler := make(chan bool)
  993. blockHandler := make(chan bool)
  994. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  995. inHandler <- true
  996. <-blockHandler
  997. })
  998. defer st.Close()
  999. defer close(blockHandler)
  1000. st.greet()
  1001. st.writeHeaders(HeadersFrameParam{
  1002. StreamID: 1,
  1003. BlockFragment: st.encodeHeader(":method", "POST"),
  1004. EndStream: false, // keep it open
  1005. EndHeaders: true,
  1006. })
  1007. <-inHandler
  1008. // Send a bogus window update:
  1009. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1010. t.Fatal(err)
  1011. }
  1012. st.wantRSTStream(1, ErrCodeFlowControl)
  1013. }
  1014. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1015. // then runs fn once in the handler, and verifies that the error returned from
  1016. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1017. func testServerPostUnblock(t *testing.T,
  1018. handler func(http.ResponseWriter, *http.Request) error,
  1019. fn func(*serverTester),
  1020. checkErr func(error),
  1021. otherHeaders ...string) {
  1022. inHandler := make(chan bool)
  1023. errc := make(chan error, 1)
  1024. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1025. inHandler <- true
  1026. errc <- handler(w, r)
  1027. })
  1028. st.greet()
  1029. st.writeHeaders(HeadersFrameParam{
  1030. StreamID: 1,
  1031. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1032. EndStream: false, // keep it open
  1033. EndHeaders: true,
  1034. })
  1035. <-inHandler
  1036. fn(st)
  1037. select {
  1038. case err := <-errc:
  1039. if checkErr != nil {
  1040. checkErr(err)
  1041. }
  1042. case <-time.After(5 * time.Second):
  1043. t.Fatal("timeout waiting for Handler to return")
  1044. }
  1045. st.Close()
  1046. }
  1047. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1048. testServerPostUnblock(t,
  1049. func(w http.ResponseWriter, r *http.Request) (err error) {
  1050. _, err = r.Body.Read(make([]byte, 1))
  1051. return
  1052. },
  1053. func(st *serverTester) {
  1054. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1055. t.Fatal(err)
  1056. }
  1057. },
  1058. func(err error) {
  1059. want := StreamError{StreamID: 0x1, Code: 0x8}
  1060. if !reflect.DeepEqual(err, want) {
  1061. t.Errorf("Read error = %v; want %v", err, want)
  1062. }
  1063. },
  1064. )
  1065. }
  1066. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1067. // Run this test a bunch, because it doesn't always
  1068. // deadlock. But with a bunch, it did.
  1069. n := 50
  1070. if testing.Short() {
  1071. n = 5
  1072. }
  1073. for i := 0; i < n; i++ {
  1074. testServer_RSTStream_Unblocks_Header_Write(t)
  1075. }
  1076. }
  1077. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1078. inHandler := make(chan bool, 1)
  1079. unblockHandler := make(chan bool, 1)
  1080. headerWritten := make(chan bool, 1)
  1081. wroteRST := make(chan bool, 1)
  1082. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1083. inHandler <- true
  1084. <-wroteRST
  1085. w.Header().Set("foo", "bar")
  1086. w.WriteHeader(200)
  1087. w.(http.Flusher).Flush()
  1088. headerWritten <- true
  1089. <-unblockHandler
  1090. })
  1091. defer st.Close()
  1092. st.greet()
  1093. st.writeHeaders(HeadersFrameParam{
  1094. StreamID: 1,
  1095. BlockFragment: st.encodeHeader(":method", "POST"),
  1096. EndStream: false, // keep it open
  1097. EndHeaders: true,
  1098. })
  1099. <-inHandler
  1100. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1101. t.Fatal(err)
  1102. }
  1103. wroteRST <- true
  1104. st.awaitIdle()
  1105. select {
  1106. case <-headerWritten:
  1107. case <-time.After(2 * time.Second):
  1108. t.Error("timeout waiting for header write")
  1109. }
  1110. unblockHandler <- true
  1111. }
  1112. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1113. testServerPostUnblock(t,
  1114. func(w http.ResponseWriter, r *http.Request) (err error) {
  1115. _, err = r.Body.Read(make([]byte, 1))
  1116. return
  1117. },
  1118. func(st *serverTester) { st.cc.Close() },
  1119. func(err error) {
  1120. if err == nil {
  1121. t.Error("unexpected nil error from Request.Body.Read")
  1122. }
  1123. },
  1124. )
  1125. }
  1126. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1127. <-w.(http.CloseNotifier).CloseNotify()
  1128. return nil
  1129. }
  1130. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1131. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1132. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1133. t.Fatal(err)
  1134. }
  1135. }, nil)
  1136. }
  1137. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1138. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1139. }
  1140. // that CloseNotify unblocks after a stream error due to the client's
  1141. // problem that's unrelated to them explicitly canceling it (which is
  1142. // TestServer_CloseNotify_After_RSTStream above)
  1143. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1144. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1145. // data longer than declared Content-Length => stream error
  1146. st.writeData(1, true, []byte("1234"))
  1147. }, nil, "content-length", "3")
  1148. }
  1149. func TestServer_StateTransitions(t *testing.T) {
  1150. var st *serverTester
  1151. inHandler := make(chan bool)
  1152. writeData := make(chan bool)
  1153. leaveHandler := make(chan bool)
  1154. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1155. inHandler <- true
  1156. if st.stream(1) == nil {
  1157. t.Errorf("nil stream 1 in handler")
  1158. }
  1159. if got, want := st.streamState(1), stateOpen; got != want {
  1160. t.Errorf("in handler, state is %v; want %v", got, want)
  1161. }
  1162. writeData <- true
  1163. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1164. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1165. }
  1166. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1167. t.Errorf("in handler, state is %v; want %v", got, want)
  1168. }
  1169. <-leaveHandler
  1170. })
  1171. st.greet()
  1172. if st.stream(1) != nil {
  1173. t.Fatal("stream 1 should be empty")
  1174. }
  1175. if got := st.streamState(1); got != stateIdle {
  1176. t.Fatalf("stream 1 should be idle; got %v", got)
  1177. }
  1178. st.writeHeaders(HeadersFrameParam{
  1179. StreamID: 1,
  1180. BlockFragment: st.encodeHeader(":method", "POST"),
  1181. EndStream: false, // keep it open
  1182. EndHeaders: true,
  1183. })
  1184. <-inHandler
  1185. <-writeData
  1186. st.writeData(1, true, nil)
  1187. leaveHandler <- true
  1188. hf := st.wantHeaders()
  1189. if !hf.StreamEnded() {
  1190. t.Fatal("expected END_STREAM flag")
  1191. }
  1192. if got, want := st.streamState(1), stateClosed; got != want {
  1193. t.Errorf("at end, state is %v; want %v", got, want)
  1194. }
  1195. if st.stream(1) != nil {
  1196. t.Fatal("at end, stream 1 should be gone")
  1197. }
  1198. }
  1199. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1200. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1201. testServerRejectsConn(t, func(st *serverTester) {
  1202. st.writeHeaders(HeadersFrameParam{
  1203. StreamID: 1,
  1204. BlockFragment: st.encodeHeader(),
  1205. EndStream: true,
  1206. EndHeaders: false,
  1207. })
  1208. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1209. StreamID: 3, // different stream.
  1210. BlockFragment: st.encodeHeader(),
  1211. EndStream: true,
  1212. EndHeaders: true,
  1213. })
  1214. })
  1215. }
  1216. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1217. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1218. testServerRejectsConn(t, func(st *serverTester) {
  1219. st.writeHeaders(HeadersFrameParam{
  1220. StreamID: 1,
  1221. BlockFragment: st.encodeHeader(),
  1222. EndStream: true,
  1223. EndHeaders: false,
  1224. })
  1225. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1226. t.Fatal(err)
  1227. }
  1228. })
  1229. }
  1230. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1231. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1232. testServerRejectsConn(t, func(st *serverTester) {
  1233. st.writeHeaders(HeadersFrameParam{
  1234. StreamID: 1,
  1235. BlockFragment: st.encodeHeader(),
  1236. EndStream: true,
  1237. EndHeaders: true,
  1238. })
  1239. st.wantHeaders()
  1240. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1241. t.Fatal(err)
  1242. }
  1243. })
  1244. }
  1245. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1246. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1247. testServerRejectsConn(t, func(st *serverTester) {
  1248. st.writeHeaders(HeadersFrameParam{
  1249. StreamID: 1,
  1250. BlockFragment: st.encodeHeader(),
  1251. EndStream: true,
  1252. EndHeaders: false,
  1253. })
  1254. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1255. t.Fatal(err)
  1256. }
  1257. })
  1258. }
  1259. // No HEADERS on stream 0.
  1260. func TestServer_Rejects_Headers0(t *testing.T) {
  1261. testServerRejectsConn(t, func(st *serverTester) {
  1262. st.fr.AllowIllegalWrites = true
  1263. st.writeHeaders(HeadersFrameParam{
  1264. StreamID: 0,
  1265. BlockFragment: st.encodeHeader(),
  1266. EndStream: true,
  1267. EndHeaders: true,
  1268. })
  1269. })
  1270. }
  1271. // No CONTINUATION on stream 0.
  1272. func TestServer_Rejects_Continuation0(t *testing.T) {
  1273. testServerRejectsConn(t, func(st *serverTester) {
  1274. st.fr.AllowIllegalWrites = true
  1275. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1276. t.Fatal(err)
  1277. }
  1278. })
  1279. }
  1280. func TestServer_Rejects_PushPromise(t *testing.T) {
  1281. testServerRejectsConn(t, func(st *serverTester) {
  1282. pp := PushPromiseParam{
  1283. StreamID: 1,
  1284. PromiseID: 3,
  1285. }
  1286. if err := st.fr.WritePushPromise(pp); err != nil {
  1287. t.Fatal(err)
  1288. }
  1289. })
  1290. }
  1291. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1292. // frame and a server close after the client does something
  1293. // deserving a CONNECTION_ERROR.
  1294. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1295. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1296. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1297. defer st.Close()
  1298. st.greet()
  1299. writeReq(st)
  1300. st.wantGoAway()
  1301. errc := make(chan error, 1)
  1302. go func() {
  1303. fr, err := st.fr.ReadFrame()
  1304. if err == nil {
  1305. err = fmt.Errorf("got frame of type %T", fr)
  1306. }
  1307. errc <- err
  1308. }()
  1309. select {
  1310. case err := <-errc:
  1311. if err != io.EOF {
  1312. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1313. }
  1314. case <-time.After(2 * time.Second):
  1315. t.Error("timeout waiting for disconnect")
  1316. }
  1317. }
  1318. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1319. // error code after a client sends a bogus request.
  1320. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1321. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1322. defer st.Close()
  1323. st.greet()
  1324. writeReq(st)
  1325. st.wantRSTStream(1, code)
  1326. }
  1327. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1328. // write a single request with writeReq, and then verify that the
  1329. // *http.Request is built correctly in checkReq.
  1330. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1331. gotReq := make(chan bool, 1)
  1332. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1333. if r.Body == nil {
  1334. t.Fatal("nil Body")
  1335. }
  1336. checkReq(r)
  1337. gotReq <- true
  1338. })
  1339. defer st.Close()
  1340. st.greet()
  1341. writeReq(st)
  1342. select {
  1343. case <-gotReq:
  1344. case <-time.After(2 * time.Second):
  1345. t.Error("timeout waiting for request")
  1346. }
  1347. }
  1348. func getSlash(st *serverTester) { st.bodylessReq1() }
  1349. func TestServer_Response_NoData(t *testing.T) {
  1350. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1351. // Nothing.
  1352. return nil
  1353. }, func(st *serverTester) {
  1354. getSlash(st)
  1355. hf := st.wantHeaders()
  1356. if !hf.StreamEnded() {
  1357. t.Fatal("want END_STREAM flag")
  1358. }
  1359. if !hf.HeadersEnded() {
  1360. t.Fatal("want END_HEADERS flag")
  1361. }
  1362. })
  1363. }
  1364. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1365. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1366. w.Header().Set("Foo-Bar", "some-value")
  1367. return nil
  1368. }, func(st *serverTester) {
  1369. getSlash(st)
  1370. hf := st.wantHeaders()
  1371. if !hf.StreamEnded() {
  1372. t.Fatal("want END_STREAM flag")
  1373. }
  1374. if !hf.HeadersEnded() {
  1375. t.Fatal("want END_HEADERS flag")
  1376. }
  1377. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1378. wanth := [][2]string{
  1379. {":status", "200"},
  1380. {"foo-bar", "some-value"},
  1381. {"content-type", "text/plain; charset=utf-8"},
  1382. {"content-length", "0"},
  1383. }
  1384. if !reflect.DeepEqual(goth, wanth) {
  1385. t.Errorf("Got headers %v; want %v", goth, wanth)
  1386. }
  1387. })
  1388. }
  1389. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1390. const msg = "<html>this is HTML."
  1391. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1392. w.Header().Set("Content-Type", "foo/bar")
  1393. io.WriteString(w, msg)
  1394. return nil
  1395. }, func(st *serverTester) {
  1396. getSlash(st)
  1397. hf := st.wantHeaders()
  1398. if hf.StreamEnded() {
  1399. t.Fatal("don't want END_STREAM, expecting data")
  1400. }
  1401. if !hf.HeadersEnded() {
  1402. t.Fatal("want END_HEADERS flag")
  1403. }
  1404. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1405. wanth := [][2]string{
  1406. {":status", "200"},
  1407. {"content-type", "foo/bar"},
  1408. {"content-length", strconv.Itoa(len(msg))},
  1409. }
  1410. if !reflect.DeepEqual(goth, wanth) {
  1411. t.Errorf("Got headers %v; want %v", goth, wanth)
  1412. }
  1413. df := st.wantData()
  1414. if !df.StreamEnded() {
  1415. t.Error("expected DATA to have END_STREAM flag")
  1416. }
  1417. if got := string(df.Data()); got != msg {
  1418. t.Errorf("got DATA %q; want %q", got, msg)
  1419. }
  1420. })
  1421. }
  1422. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1423. const msg = "hi"
  1424. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1425. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1426. io.WriteString(w, msg)
  1427. return nil
  1428. }, func(st *serverTester) {
  1429. getSlash(st)
  1430. hf := st.wantHeaders()
  1431. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1432. wanth := [][2]string{
  1433. {":status", "200"},
  1434. {"content-type", "text/plain; charset=utf-8"},
  1435. {"content-length", strconv.Itoa(len(msg))},
  1436. }
  1437. if !reflect.DeepEqual(goth, wanth) {
  1438. t.Errorf("Got headers %v; want %v", goth, wanth)
  1439. }
  1440. })
  1441. }
  1442. // Header accessed only after the initial write.
  1443. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1444. const msg = "<html>this is HTML."
  1445. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1446. io.WriteString(w, msg)
  1447. w.Header().Set("foo", "should be ignored")
  1448. return nil
  1449. }, func(st *serverTester) {
  1450. getSlash(st)
  1451. hf := st.wantHeaders()
  1452. if hf.StreamEnded() {
  1453. t.Fatal("unexpected END_STREAM")
  1454. }
  1455. if !hf.HeadersEnded() {
  1456. t.Fatal("want END_HEADERS flag")
  1457. }
  1458. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1459. wanth := [][2]string{
  1460. {":status", "200"},
  1461. {"content-type", "text/html; charset=utf-8"},
  1462. {"content-length", strconv.Itoa(len(msg))},
  1463. }
  1464. if !reflect.DeepEqual(goth, wanth) {
  1465. t.Errorf("Got headers %v; want %v", goth, wanth)
  1466. }
  1467. })
  1468. }
  1469. // Header accessed before the initial write and later mutated.
  1470. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1471. const msg = "<html>this is HTML."
  1472. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1473. w.Header().Set("foo", "proper value")
  1474. io.WriteString(w, msg)
  1475. w.Header().Set("foo", "should be ignored")
  1476. return nil
  1477. }, func(st *serverTester) {
  1478. getSlash(st)
  1479. hf := st.wantHeaders()
  1480. if hf.StreamEnded() {
  1481. t.Fatal("unexpected END_STREAM")
  1482. }
  1483. if !hf.HeadersEnded() {
  1484. t.Fatal("want END_HEADERS flag")
  1485. }
  1486. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1487. wanth := [][2]string{
  1488. {":status", "200"},
  1489. {"foo", "proper value"},
  1490. {"content-type", "text/html; charset=utf-8"},
  1491. {"content-length", strconv.Itoa(len(msg))},
  1492. }
  1493. if !reflect.DeepEqual(goth, wanth) {
  1494. t.Errorf("Got headers %v; want %v", goth, wanth)
  1495. }
  1496. })
  1497. }
  1498. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1499. const msg = "<html>this is HTML."
  1500. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1501. io.WriteString(w, msg)
  1502. return nil
  1503. }, func(st *serverTester) {
  1504. getSlash(st)
  1505. hf := st.wantHeaders()
  1506. if hf.StreamEnded() {
  1507. t.Fatal("don't want END_STREAM, expecting data")
  1508. }
  1509. if !hf.HeadersEnded() {
  1510. t.Fatal("want END_HEADERS flag")
  1511. }
  1512. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1513. wanth := [][2]string{
  1514. {":status", "200"},
  1515. {"content-type", "text/html; charset=utf-8"},
  1516. {"content-length", strconv.Itoa(len(msg))},
  1517. }
  1518. if !reflect.DeepEqual(goth, wanth) {
  1519. t.Errorf("Got headers %v; want %v", goth, wanth)
  1520. }
  1521. df := st.wantData()
  1522. if !df.StreamEnded() {
  1523. t.Error("expected DATA to have END_STREAM flag")
  1524. }
  1525. if got := string(df.Data()); got != msg {
  1526. t.Errorf("got DATA %q; want %q", got, msg)
  1527. }
  1528. })
  1529. }
  1530. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1531. const msg = "<html>this is HTML"
  1532. const msg2 = ", and this is the next chunk"
  1533. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1534. io.WriteString(w, msg)
  1535. w.(http.Flusher).Flush()
  1536. io.WriteString(w, msg2)
  1537. return nil
  1538. }, func(st *serverTester) {
  1539. getSlash(st)
  1540. hf := st.wantHeaders()
  1541. if hf.StreamEnded() {
  1542. t.Fatal("unexpected END_STREAM flag")
  1543. }
  1544. if !hf.HeadersEnded() {
  1545. t.Fatal("want END_HEADERS flag")
  1546. }
  1547. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1548. wanth := [][2]string{
  1549. {":status", "200"},
  1550. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1551. // and no content-length
  1552. }
  1553. if !reflect.DeepEqual(goth, wanth) {
  1554. t.Errorf("Got headers %v; want %v", goth, wanth)
  1555. }
  1556. {
  1557. df := st.wantData()
  1558. if df.StreamEnded() {
  1559. t.Error("unexpected END_STREAM flag")
  1560. }
  1561. if got := string(df.Data()); got != msg {
  1562. t.Errorf("got DATA %q; want %q", got, msg)
  1563. }
  1564. }
  1565. {
  1566. df := st.wantData()
  1567. if !df.StreamEnded() {
  1568. t.Error("wanted END_STREAM flag on last data chunk")
  1569. }
  1570. if got := string(df.Data()); got != msg2 {
  1571. t.Errorf("got DATA %q; want %q", got, msg2)
  1572. }
  1573. }
  1574. })
  1575. }
  1576. func TestServer_Response_LargeWrite(t *testing.T) {
  1577. const size = 1 << 20
  1578. const maxFrameSize = 16 << 10
  1579. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1580. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1581. if err != nil {
  1582. return fmt.Errorf("Write error: %v", err)
  1583. }
  1584. if n != size {
  1585. return fmt.Errorf("wrong size %d from Write", n)
  1586. }
  1587. return nil
  1588. }, func(st *serverTester) {
  1589. if err := st.fr.WriteSettings(
  1590. Setting{SettingInitialWindowSize, 0},
  1591. Setting{SettingMaxFrameSize, maxFrameSize},
  1592. ); err != nil {
  1593. t.Fatal(err)
  1594. }
  1595. st.wantSettingsAck()
  1596. getSlash(st) // make the single request
  1597. // Give the handler quota to write:
  1598. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1599. t.Fatal(err)
  1600. }
  1601. // Give the handler quota to write to connection-level
  1602. // window as well
  1603. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1604. t.Fatal(err)
  1605. }
  1606. hf := st.wantHeaders()
  1607. if hf.StreamEnded() {
  1608. t.Fatal("unexpected END_STREAM flag")
  1609. }
  1610. if !hf.HeadersEnded() {
  1611. t.Fatal("want END_HEADERS flag")
  1612. }
  1613. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1614. wanth := [][2]string{
  1615. {":status", "200"},
  1616. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1617. // and no content-length
  1618. }
  1619. if !reflect.DeepEqual(goth, wanth) {
  1620. t.Errorf("Got headers %v; want %v", goth, wanth)
  1621. }
  1622. var bytes, frames int
  1623. for {
  1624. df := st.wantData()
  1625. bytes += len(df.Data())
  1626. frames++
  1627. for _, b := range df.Data() {
  1628. if b != 'a' {
  1629. t.Fatal("non-'a' byte seen in DATA")
  1630. }
  1631. }
  1632. if df.StreamEnded() {
  1633. break
  1634. }
  1635. }
  1636. if bytes != size {
  1637. t.Errorf("Got %d bytes; want %d", bytes, size)
  1638. }
  1639. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1640. t.Errorf("Got %d frames; want %d", frames, size)
  1641. }
  1642. })
  1643. }
  1644. // Test that the handler can't write more than the client allows
  1645. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1646. const size = 1 << 20
  1647. const maxFrameSize = 16 << 10
  1648. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1649. w.(http.Flusher).Flush()
  1650. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1651. if err != nil {
  1652. return fmt.Errorf("Write error: %v", err)
  1653. }
  1654. if n != size {
  1655. return fmt.Errorf("wrong size %d from Write", n)
  1656. }
  1657. return nil
  1658. }, func(st *serverTester) {
  1659. // Set the window size to something explicit for this test.
  1660. // It's also how much initial data we expect.
  1661. const initWindowSize = 123
  1662. if err := st.fr.WriteSettings(
  1663. Setting{SettingInitialWindowSize, initWindowSize},
  1664. Setting{SettingMaxFrameSize, maxFrameSize},
  1665. ); err != nil {
  1666. t.Fatal(err)
  1667. }
  1668. st.wantSettingsAck()
  1669. getSlash(st) // make the single request
  1670. defer func() { st.fr.WriteRSTStream(1, ErrCodeCancel) }()
  1671. hf := st.wantHeaders()
  1672. if hf.StreamEnded() {
  1673. t.Fatal("unexpected END_STREAM flag")
  1674. }
  1675. if !hf.HeadersEnded() {
  1676. t.Fatal("want END_HEADERS flag")
  1677. }
  1678. df := st.wantData()
  1679. if got := len(df.Data()); got != initWindowSize {
  1680. t.Fatalf("Initial window size = %d but got DATA with %d bytes", initWindowSize, got)
  1681. }
  1682. for _, quota := range []int{1, 13, 127} {
  1683. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1684. t.Fatal(err)
  1685. }
  1686. df := st.wantData()
  1687. if int(quota) != len(df.Data()) {
  1688. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1689. }
  1690. }
  1691. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1692. t.Fatal(err)
  1693. }
  1694. })
  1695. }
  1696. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1697. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1698. const size = 1 << 20
  1699. const maxFrameSize = 16 << 10
  1700. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1701. w.(http.Flusher).Flush()
  1702. errc := make(chan error, 1)
  1703. go func() {
  1704. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1705. errc <- err
  1706. }()
  1707. select {
  1708. case err := <-errc:
  1709. if err == nil {
  1710. return errors.New("unexpected nil error from Write in handler")
  1711. }
  1712. return nil
  1713. case <-time.After(2 * time.Second):
  1714. return errors.New("timeout waiting for Write in handler")
  1715. }
  1716. }, func(st *serverTester) {
  1717. if err := st.fr.WriteSettings(
  1718. Setting{SettingInitialWindowSize, 0},
  1719. Setting{SettingMaxFrameSize, maxFrameSize},
  1720. ); err != nil {
  1721. t.Fatal(err)
  1722. }
  1723. st.wantSettingsAck()
  1724. getSlash(st) // make the single request
  1725. hf := st.wantHeaders()
  1726. if hf.StreamEnded() {
  1727. t.Fatal("unexpected END_STREAM flag")
  1728. }
  1729. if !hf.HeadersEnded() {
  1730. t.Fatal("want END_HEADERS flag")
  1731. }
  1732. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1733. t.Fatal(err)
  1734. }
  1735. })
  1736. }
  1737. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1738. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1739. w.(http.Flusher).Flush()
  1740. // Nothing; send empty DATA
  1741. return nil
  1742. }, func(st *serverTester) {
  1743. // Handler gets no data quota:
  1744. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1745. t.Fatal(err)
  1746. }
  1747. st.wantSettingsAck()
  1748. getSlash(st) // make the single request
  1749. hf := st.wantHeaders()
  1750. if hf.StreamEnded() {
  1751. t.Fatal("unexpected END_STREAM flag")
  1752. }
  1753. if !hf.HeadersEnded() {
  1754. t.Fatal("want END_HEADERS flag")
  1755. }
  1756. df := st.wantData()
  1757. if got := len(df.Data()); got != 0 {
  1758. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1759. }
  1760. if !df.StreamEnded() {
  1761. t.Fatal("DATA didn't have END_STREAM")
  1762. }
  1763. })
  1764. }
  1765. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1766. const msg = "foo"
  1767. const reply = "bar"
  1768. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1769. if v := r.Header.Get("Expect"); v != "" {
  1770. t.Errorf("Expect header = %q; want empty", v)
  1771. }
  1772. buf := make([]byte, len(msg))
  1773. // This read should trigger the 100-continue being sent.
  1774. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1775. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1776. }
  1777. _, err := io.WriteString(w, reply)
  1778. return err
  1779. }, func(st *serverTester) {
  1780. st.writeHeaders(HeadersFrameParam{
  1781. StreamID: 1, // clients send odd numbers
  1782. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1783. EndStream: false,
  1784. EndHeaders: true,
  1785. })
  1786. hf := st.wantHeaders()
  1787. if hf.StreamEnded() {
  1788. t.Fatal("unexpected END_STREAM flag")
  1789. }
  1790. if !hf.HeadersEnded() {
  1791. t.Fatal("want END_HEADERS flag")
  1792. }
  1793. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1794. wanth := [][2]string{
  1795. {":status", "100"},
  1796. }
  1797. if !reflect.DeepEqual(goth, wanth) {
  1798. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1799. }
  1800. // Okay, they sent status 100, so we can send our
  1801. // gigantic and/or sensitive "foo" payload now.
  1802. st.writeData(1, true, []byte(msg))
  1803. st.wantWindowUpdate(0, uint32(len(msg)))
  1804. hf = st.wantHeaders()
  1805. if hf.StreamEnded() {
  1806. t.Fatal("expected data to follow")
  1807. }
  1808. if !hf.HeadersEnded() {
  1809. t.Fatal("want END_HEADERS flag")
  1810. }
  1811. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1812. wanth = [][2]string{
  1813. {":status", "200"},
  1814. {"content-type", "text/plain; charset=utf-8"},
  1815. {"content-length", strconv.Itoa(len(reply))},
  1816. }
  1817. if !reflect.DeepEqual(goth, wanth) {
  1818. t.Errorf("Got headers %v; want %v", goth, wanth)
  1819. }
  1820. df := st.wantData()
  1821. if string(df.Data()) != reply {
  1822. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1823. }
  1824. if !df.StreamEnded() {
  1825. t.Errorf("expect data stream end")
  1826. }
  1827. })
  1828. }
  1829. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1830. errc := make(chan error, 1)
  1831. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1832. p := []byte("some data.\n")
  1833. for {
  1834. _, err := w.Write(p)
  1835. if err != nil {
  1836. errc <- err
  1837. return nil
  1838. }
  1839. }
  1840. }, func(st *serverTester) {
  1841. st.writeHeaders(HeadersFrameParam{
  1842. StreamID: 1,
  1843. BlockFragment: st.encodeHeader(),
  1844. EndStream: false,
  1845. EndHeaders: true,
  1846. })
  1847. hf := st.wantHeaders()
  1848. if hf.StreamEnded() {
  1849. t.Fatal("unexpected END_STREAM flag")
  1850. }
  1851. if !hf.HeadersEnded() {
  1852. t.Fatal("want END_HEADERS flag")
  1853. }
  1854. // Close the connection and wait for the handler to (hopefully) notice.
  1855. st.cc.Close()
  1856. select {
  1857. case <-errc:
  1858. case <-time.After(5 * time.Second):
  1859. t.Error("timeout")
  1860. }
  1861. })
  1862. }
  1863. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1864. const testPath = "/some/path"
  1865. inHandler := make(chan uint32)
  1866. leaveHandler := make(chan bool)
  1867. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1868. id := w.(*responseWriter).rws.stream.id
  1869. inHandler <- id
  1870. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1871. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1872. }
  1873. <-leaveHandler
  1874. })
  1875. defer st.Close()
  1876. st.greet()
  1877. nextStreamID := uint32(1)
  1878. streamID := func() uint32 {
  1879. defer func() { nextStreamID += 2 }()
  1880. return nextStreamID
  1881. }
  1882. sendReq := func(id uint32, headers ...string) {
  1883. st.writeHeaders(HeadersFrameParam{
  1884. StreamID: id,
  1885. BlockFragment: st.encodeHeader(headers...),
  1886. EndStream: true,
  1887. EndHeaders: true,
  1888. })
  1889. }
  1890. for i := 0; i < defaultMaxStreams; i++ {
  1891. sendReq(streamID())
  1892. <-inHandler
  1893. }
  1894. defer func() {
  1895. for i := 0; i < defaultMaxStreams; i++ {
  1896. leaveHandler <- true
  1897. }
  1898. }()
  1899. // And this one should cross the limit:
  1900. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  1901. // even if we're rejecting it)
  1902. rejectID := streamID()
  1903. headerBlock := st.encodeHeader(":path", testPath)
  1904. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  1905. st.writeHeaders(HeadersFrameParam{
  1906. StreamID: rejectID,
  1907. BlockFragment: frag1,
  1908. EndStream: true,
  1909. EndHeaders: false, // CONTINUATION coming
  1910. })
  1911. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  1912. t.Fatal(err)
  1913. }
  1914. st.wantRSTStream(rejectID, ErrCodeProtocol)
  1915. // But let a handler finish:
  1916. leaveHandler <- true
  1917. st.wantHeaders()
  1918. // And now another stream should be able to start:
  1919. goodID := streamID()
  1920. sendReq(goodID, ":path", testPath)
  1921. select {
  1922. case got := <-inHandler:
  1923. if got != goodID {
  1924. t.Errorf("Got stream %d; want %d", got, goodID)
  1925. }
  1926. case <-time.After(3 * time.Second):
  1927. t.Error("timeout waiting for handler")
  1928. }
  1929. }
  1930. // So many response headers that the server needs to use CONTINUATION frames:
  1931. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  1932. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1933. h := w.Header()
  1934. for i := 0; i < 5000; i++ {
  1935. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  1936. }
  1937. return nil
  1938. }, func(st *serverTester) {
  1939. getSlash(st)
  1940. hf := st.wantHeaders()
  1941. if hf.HeadersEnded() {
  1942. t.Fatal("got unwanted END_HEADERS flag")
  1943. }
  1944. n := 0
  1945. for {
  1946. n++
  1947. cf := st.wantContinuation()
  1948. if cf.HeadersEnded() {
  1949. break
  1950. }
  1951. }
  1952. if n < 5 {
  1953. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  1954. }
  1955. })
  1956. }
  1957. // This previously crashed (reported by Mathieu Lonjaret as observed
  1958. // while using Camlistore) because we got a DATA frame from the client
  1959. // after the handler exited and our logic at the time was wrong,
  1960. // keeping a stream in the map in stateClosed, which tickled an
  1961. // invariant check later when we tried to remove that stream (via
  1962. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  1963. // ended.
  1964. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  1965. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1966. // nothing
  1967. return nil
  1968. }, func(st *serverTester) {
  1969. st.writeHeaders(HeadersFrameParam{
  1970. StreamID: 1,
  1971. BlockFragment: st.encodeHeader(),
  1972. EndStream: false, // DATA is coming
  1973. EndHeaders: true,
  1974. })
  1975. hf := st.wantHeaders()
  1976. if !hf.HeadersEnded() || !hf.StreamEnded() {
  1977. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  1978. }
  1979. // Sent when the a Handler closes while a client has
  1980. // indicated it's still sending DATA:
  1981. st.wantRSTStream(1, ErrCodeCancel)
  1982. // Now the handler has ended, so it's ended its
  1983. // stream, but the client hasn't closed its side
  1984. // (stateClosedLocal). So send more data and verify
  1985. // it doesn't crash with an internal invariant panic, like
  1986. // it did before.
  1987. st.writeData(1, true, []byte("foo"))
  1988. // Sent after a peer sends data anyway (admittedly the
  1989. // previous RST_STREAM might've still been in-flight),
  1990. // but they'll get the more friendly 'cancel' code
  1991. // first.
  1992. st.wantRSTStream(1, ErrCodeStreamClosed)
  1993. // Set up a bunch of machinery to record the panic we saw
  1994. // previously.
  1995. var (
  1996. panMu sync.Mutex
  1997. panicVal interface{}
  1998. )
  1999. testHookOnPanicMu.Lock()
  2000. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2001. panMu.Lock()
  2002. panicVal = pv
  2003. panMu.Unlock()
  2004. return true
  2005. }
  2006. testHookOnPanicMu.Unlock()
  2007. // Now force the serve loop to end, via closing the connection.
  2008. st.cc.Close()
  2009. select {
  2010. case <-st.sc.doneServing:
  2011. // Loop has exited.
  2012. panMu.Lock()
  2013. got := panicVal
  2014. panMu.Unlock()
  2015. if got != nil {
  2016. t.Errorf("Got panic: %v", got)
  2017. }
  2018. case <-time.After(5 * time.Second):
  2019. t.Error("timeout")
  2020. }
  2021. })
  2022. }
  2023. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2024. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2025. func testRejectTLS(t *testing.T, max uint16) {
  2026. st := newServerTester(t, nil, func(c *tls.Config) {
  2027. c.MaxVersion = max
  2028. })
  2029. defer st.Close()
  2030. gf := st.wantGoAway()
  2031. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2032. t.Errorf("Got error code %v; want %v", got, want)
  2033. }
  2034. }
  2035. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2036. st := newServerTester(t, nil, func(c *tls.Config) {
  2037. // Only list bad ones:
  2038. c.CipherSuites = []uint16{
  2039. tls.TLS_RSA_WITH_RC4_128_SHA,
  2040. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2041. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2042. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2043. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2044. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2045. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2046. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2047. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2048. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2049. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2050. }
  2051. })
  2052. defer st.Close()
  2053. gf := st.wantGoAway()
  2054. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2055. t.Errorf("Got error code %v; want %v", got, want)
  2056. }
  2057. }
  2058. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2059. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2060. st := newServerTester(t, nil, func(c *tls.Config) {
  2061. // Have the client only support the one required by the spec.
  2062. c.CipherSuites = []uint16{requiredSuite}
  2063. }, func(ts *httptest.Server) {
  2064. var srv *http.Server = ts.Config
  2065. // Have the server configured with no specific cipher suites.
  2066. // This tests that Go's defaults include the required one.
  2067. srv.TLSConfig = nil
  2068. })
  2069. defer st.Close()
  2070. st.greet()
  2071. }
  2072. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2073. if f.Name == "date" {
  2074. return
  2075. }
  2076. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2077. }
  2078. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2079. st.decodedHeaders = nil
  2080. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2081. st.t.Fatalf("hpack decoding error: %v", err)
  2082. }
  2083. if err := st.hpackDec.Close(); err != nil {
  2084. st.t.Fatalf("hpack decoding error: %v", err)
  2085. }
  2086. return st.decodedHeaders
  2087. }
  2088. // testServerResponse sets up an idle HTTP/2 connection and lets you
  2089. // write a single request with writeReq, and then reply to it in some way with the provided handler,
  2090. // and then verify the output with the serverTester again (assuming the handler returns nil)
  2091. func testServerResponse(t testing.TB,
  2092. handler func(http.ResponseWriter, *http.Request) error,
  2093. client func(*serverTester),
  2094. ) {
  2095. errc := make(chan error, 1)
  2096. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2097. if r.Body == nil {
  2098. t.Fatal("nil Body")
  2099. }
  2100. errc <- handler(w, r)
  2101. })
  2102. defer st.Close()
  2103. donec := make(chan bool)
  2104. go func() {
  2105. defer close(donec)
  2106. st.greet()
  2107. client(st)
  2108. }()
  2109. select {
  2110. case <-donec:
  2111. return
  2112. case <-time.After(5 * time.Second):
  2113. t.Fatal("timeout")
  2114. }
  2115. select {
  2116. case err := <-errc:
  2117. if err != nil {
  2118. t.Fatalf("Error in handler: %v", err)
  2119. }
  2120. case <-time.After(2 * time.Second):
  2121. t.Error("timeout waiting for handler to finish")
  2122. }
  2123. }
  2124. // readBodyHandler returns an http Handler func that reads len(want)
  2125. // bytes from r.Body and fails t if the contents read were not
  2126. // the value of want.
  2127. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2128. return func(w http.ResponseWriter, r *http.Request) {
  2129. buf := make([]byte, len(want))
  2130. _, err := io.ReadFull(r.Body, buf)
  2131. if err != nil {
  2132. t.Error(err)
  2133. return
  2134. }
  2135. if string(buf) != want {
  2136. t.Errorf("read %q; want %q", buf, want)
  2137. }
  2138. }
  2139. }
  2140. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2141. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2142. // http://sourceforge.net/p/curl/bugs/1472/
  2143. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2144. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2145. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2146. if runtime.GOOS != "linux" {
  2147. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2148. }
  2149. if testing.Short() {
  2150. t.Skip("skipping curl test in short mode")
  2151. }
  2152. requireCurl(t)
  2153. var gotConn int32
  2154. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2155. const msg = "Hello from curl!\n"
  2156. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2157. w.Header().Set("Foo", "Bar")
  2158. w.Header().Set("Client-Proto", r.Proto)
  2159. io.WriteString(w, msg)
  2160. }))
  2161. ConfigureServer(ts.Config, &Server{
  2162. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2163. })
  2164. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2165. ts.StartTLS()
  2166. defer ts.Close()
  2167. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2168. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2169. defer kill(container)
  2170. resc := make(chan interface{}, 1)
  2171. go func() {
  2172. res, err := dockerLogs(container)
  2173. if err != nil {
  2174. resc <- err
  2175. } else {
  2176. resc <- res
  2177. }
  2178. }()
  2179. select {
  2180. case res := <-resc:
  2181. if err, ok := res.(error); ok {
  2182. t.Fatal(err)
  2183. }
  2184. body := string(res.([]byte))
  2185. // Search for both "key: value" and "key:value", since curl changed their format
  2186. // Our Dockerfile contains the latest version (no space), but just in case people
  2187. // didn't rebuild, check both.
  2188. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2189. t.Errorf("didn't see foo: Bar header")
  2190. t.Logf("Got: %s", body)
  2191. }
  2192. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2193. t.Errorf("didn't see client-proto: HTTP/2 header")
  2194. t.Logf("Got: %s", res)
  2195. }
  2196. if !strings.Contains(string(res.([]byte)), msg) {
  2197. t.Errorf("didn't see %q content", msg)
  2198. t.Logf("Got: %s", res)
  2199. }
  2200. case <-time.After(3 * time.Second):
  2201. t.Errorf("timeout waiting for curl")
  2202. }
  2203. if atomic.LoadInt32(&gotConn) == 0 {
  2204. t.Error("never saw an http2 connection")
  2205. }
  2206. }
  2207. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2208. func TestServerWithH2Load(t *testing.T) {
  2209. if !*doh2load {
  2210. t.Skip("Skipping without --h2load flag.")
  2211. }
  2212. if runtime.GOOS != "linux" {
  2213. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2214. }
  2215. requireH2load(t)
  2216. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2217. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2218. io.WriteString(w, msg)
  2219. w.(http.Flusher).Flush()
  2220. io.WriteString(w, msg)
  2221. }))
  2222. ts.StartTLS()
  2223. defer ts.Close()
  2224. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2225. "-n100000", "-c100", "-m100", ts.URL)
  2226. cmd.Stdout = os.Stdout
  2227. cmd.Stderr = os.Stderr
  2228. if err := cmd.Run(); err != nil {
  2229. t.Fatal(err)
  2230. }
  2231. }
  2232. // Issue 12843
  2233. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2234. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2235. defer st.Close()
  2236. // shake hands
  2237. st.writePreface()
  2238. st.writeInitialSettings()
  2239. frameSize := defaultMaxReadFrameSize
  2240. var advHeaderListSize *uint32
  2241. st.wantSettings().ForeachSetting(func(s Setting) error {
  2242. switch s.ID {
  2243. case SettingMaxFrameSize:
  2244. if s.Val < minMaxFrameSize {
  2245. frameSize = minMaxFrameSize
  2246. } else if s.Val > maxFrameSize {
  2247. frameSize = maxFrameSize
  2248. } else {
  2249. frameSize = int(s.Val)
  2250. }
  2251. case SettingMaxHeaderListSize:
  2252. advHeaderListSize = &s.Val
  2253. }
  2254. return nil
  2255. })
  2256. st.writeSettingsAck()
  2257. st.wantSettingsAck()
  2258. if advHeaderListSize == nil {
  2259. t.Errorf("server didn't advertise a max header list size")
  2260. } else if *advHeaderListSize == 0 {
  2261. t.Errorf("server advertised a max header list size of 0")
  2262. }
  2263. st.encodeHeaderField(":method", "GET")
  2264. st.encodeHeaderField(":path", "/")
  2265. st.encodeHeaderField(":scheme", "https")
  2266. cookie := strings.Repeat("*", 4058)
  2267. st.encodeHeaderField("cookie", cookie)
  2268. st.writeHeaders(HeadersFrameParam{
  2269. StreamID: 1,
  2270. BlockFragment: st.headerBuf.Bytes(),
  2271. EndStream: true,
  2272. EndHeaders: false,
  2273. })
  2274. // Capture the short encoding of a duplicate ~4K cookie, now
  2275. // that we've already sent it once.
  2276. st.headerBuf.Reset()
  2277. st.encodeHeaderField("cookie", cookie)
  2278. // Now send 1MB of it.
  2279. const size = 1 << 20
  2280. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2281. for len(b) > 0 {
  2282. chunk := b
  2283. if len(chunk) > frameSize {
  2284. chunk = chunk[:frameSize]
  2285. }
  2286. b = b[len(chunk):]
  2287. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2288. }
  2289. h := st.wantHeaders()
  2290. if !h.HeadersEnded() {
  2291. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2292. }
  2293. headers := st.decodeHeader(h.HeaderBlockFragment())
  2294. want := [][2]string{
  2295. {":status", "431"},
  2296. {"content-type", "text/html; charset=utf-8"},
  2297. {"content-length", "63"},
  2298. }
  2299. if !reflect.DeepEqual(headers, want) {
  2300. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2301. }
  2302. }
  2303. func TestCompressionErrorOnWrite(t *testing.T) {
  2304. const maxStrLen = 8 << 10
  2305. var serverConfig *http.Server
  2306. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2307. // No response body.
  2308. }, func(ts *httptest.Server) {
  2309. serverConfig = ts.Config
  2310. serverConfig.MaxHeaderBytes = maxStrLen
  2311. })
  2312. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2313. defer st.Close()
  2314. st.greet()
  2315. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2316. // Crank this up, now that we have a conn connected with the
  2317. // hpack.Decoder's max string length set has been initialized
  2318. // from the earlier low ~8K value. We want this higher so don't
  2319. // hit the max header list size. We only want to test hitting
  2320. // the max string size.
  2321. serverConfig.MaxHeaderBytes = 1 << 20
  2322. // First a request with a header that's exactly the max allowed size
  2323. // for the hpack compression. It's still too long for the header list
  2324. // size, so we'll get the 431 error, but that keeps the compression
  2325. // context still valid.
  2326. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2327. st.writeHeaders(HeadersFrameParam{
  2328. StreamID: 1,
  2329. BlockFragment: hbf,
  2330. EndStream: true,
  2331. EndHeaders: true,
  2332. })
  2333. h := st.wantHeaders()
  2334. if !h.HeadersEnded() {
  2335. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2336. }
  2337. headers := st.decodeHeader(h.HeaderBlockFragment())
  2338. want := [][2]string{
  2339. {":status", "431"},
  2340. {"content-type", "text/html; charset=utf-8"},
  2341. {"content-length", "63"},
  2342. }
  2343. if !reflect.DeepEqual(headers, want) {
  2344. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2345. }
  2346. df := st.wantData()
  2347. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2348. t.Errorf("Unexpected data body: %q", df.Data())
  2349. }
  2350. if !df.StreamEnded() {
  2351. t.Fatalf("expect data stream end")
  2352. }
  2353. // And now send one that's just one byte too big.
  2354. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2355. st.writeHeaders(HeadersFrameParam{
  2356. StreamID: 3,
  2357. BlockFragment: hbf,
  2358. EndStream: true,
  2359. EndHeaders: true,
  2360. })
  2361. ga := st.wantGoAway()
  2362. if ga.ErrCode != ErrCodeCompression {
  2363. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2364. }
  2365. }
  2366. func TestCompressionErrorOnClose(t *testing.T) {
  2367. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2368. // No response body.
  2369. })
  2370. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2371. defer st.Close()
  2372. st.greet()
  2373. hbf := st.encodeHeader("foo", "bar")
  2374. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2375. st.writeHeaders(HeadersFrameParam{
  2376. StreamID: 1,
  2377. BlockFragment: hbf,
  2378. EndStream: true,
  2379. EndHeaders: true,
  2380. })
  2381. ga := st.wantGoAway()
  2382. if ga.ErrCode != ErrCodeCompression {
  2383. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2384. }
  2385. }
  2386. // test that a server handler can read trailers from a client
  2387. func TestServerReadsTrailers(t *testing.T) {
  2388. const testBody = "some test body"
  2389. writeReq := func(st *serverTester) {
  2390. st.writeHeaders(HeadersFrameParam{
  2391. StreamID: 1, // clients send odd numbers
  2392. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2393. EndStream: false,
  2394. EndHeaders: true,
  2395. })
  2396. st.writeData(1, false, []byte(testBody))
  2397. st.writeHeaders(HeadersFrameParam{
  2398. StreamID: 1, // clients send odd numbers
  2399. BlockFragment: st.encodeHeaderRaw(
  2400. "foo", "foov",
  2401. "bar", "barv",
  2402. "baz", "bazv",
  2403. "surprise", "wasn't declared; shouldn't show up",
  2404. ),
  2405. EndStream: true,
  2406. EndHeaders: true,
  2407. })
  2408. }
  2409. checkReq := func(r *http.Request) {
  2410. wantTrailer := http.Header{
  2411. "Foo": nil,
  2412. "Bar": nil,
  2413. "Baz": nil,
  2414. }
  2415. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2416. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2417. }
  2418. slurp, err := ioutil.ReadAll(r.Body)
  2419. if string(slurp) != testBody {
  2420. t.Errorf("read body %q; want %q", slurp, testBody)
  2421. }
  2422. if err != nil {
  2423. t.Fatalf("Body slurp: %v", err)
  2424. }
  2425. wantTrailerAfter := http.Header{
  2426. "Foo": {"foov"},
  2427. "Bar": {"barv"},
  2428. "Baz": {"bazv"},
  2429. }
  2430. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2431. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2432. }
  2433. }
  2434. testServerRequest(t, writeReq, checkReq)
  2435. }
  2436. // test that a server handler can send trailers
  2437. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2438. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2439. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2440. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2441. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2442. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2443. w.Header().Add("Trailer", "Server-Trailer-C")
  2444. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2445. // Regular headers:
  2446. w.Header().Set("Foo", "Bar")
  2447. w.Header().Set("Content-Length", "5") // len("Hello")
  2448. io.WriteString(w, "Hello")
  2449. if withFlush {
  2450. w.(http.Flusher).Flush()
  2451. }
  2452. w.Header().Set("Server-Trailer-A", "valuea")
  2453. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2454. // After a flush, random keys like Server-Surprise shouldn't show up:
  2455. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2456. // But we do permit promoting keys to trailers after a
  2457. // flush if they start with the magic
  2458. // otherwise-invalid "Trailer:" prefix:
  2459. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2460. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2461. w.Header().Set("Trailer:Range", "invalid")
  2462. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2463. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2464. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2465. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2466. return nil
  2467. }, func(st *serverTester) {
  2468. getSlash(st)
  2469. hf := st.wantHeaders()
  2470. if hf.StreamEnded() {
  2471. t.Fatal("response HEADERS had END_STREAM")
  2472. }
  2473. if !hf.HeadersEnded() {
  2474. t.Fatal("response HEADERS didn't have END_HEADERS")
  2475. }
  2476. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2477. wanth := [][2]string{
  2478. {":status", "200"},
  2479. {"foo", "Bar"},
  2480. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2481. {"trailer", "Server-Trailer-C"},
  2482. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2483. {"content-type", "text/plain; charset=utf-8"},
  2484. {"content-length", "5"},
  2485. }
  2486. if !reflect.DeepEqual(goth, wanth) {
  2487. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2488. }
  2489. df := st.wantData()
  2490. if string(df.Data()) != "Hello" {
  2491. t.Fatalf("Client read %q; want Hello", df.Data())
  2492. }
  2493. if df.StreamEnded() {
  2494. t.Fatalf("data frame had STREAM_ENDED")
  2495. }
  2496. tf := st.wantHeaders() // for the trailers
  2497. if !tf.StreamEnded() {
  2498. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2499. }
  2500. if !tf.HeadersEnded() {
  2501. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2502. }
  2503. wanth = [][2]string{
  2504. {"post-header-trailer", "hi1"},
  2505. {"post-header-trailer2", "hi2"},
  2506. {"server-trailer-a", "valuea"},
  2507. {"server-trailer-c", "valuec"},
  2508. }
  2509. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2510. if !reflect.DeepEqual(goth, wanth) {
  2511. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2512. }
  2513. })
  2514. }
  2515. // validate transmitted header field names & values
  2516. // golang.org/issue/14048
  2517. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2518. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2519. w.Header().Add("OK1", "x")
  2520. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2521. w.Header().Add("Bad1\x00", "x") // null in key
  2522. w.Header().Add("Bad2", "x\x00y") // null in value
  2523. return nil
  2524. }, func(st *serverTester) {
  2525. getSlash(st)
  2526. hf := st.wantHeaders()
  2527. if !hf.StreamEnded() {
  2528. t.Error("response HEADERS lacked END_STREAM")
  2529. }
  2530. if !hf.HeadersEnded() {
  2531. t.Fatal("response HEADERS didn't have END_HEADERS")
  2532. }
  2533. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2534. wanth := [][2]string{
  2535. {":status", "200"},
  2536. {"ok1", "x"},
  2537. {"content-type", "text/plain; charset=utf-8"},
  2538. {"content-length", "0"},
  2539. }
  2540. if !reflect.DeepEqual(goth, wanth) {
  2541. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2542. }
  2543. })
  2544. }
  2545. func BenchmarkServerGets(b *testing.B) {
  2546. defer disableGoroutineTracking()()
  2547. b.ReportAllocs()
  2548. const msg = "Hello, world"
  2549. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2550. io.WriteString(w, msg)
  2551. })
  2552. defer st.Close()
  2553. st.greet()
  2554. // Give the server quota to reply. (plus it has the the 64KB)
  2555. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2556. b.Fatal(err)
  2557. }
  2558. for i := 0; i < b.N; i++ {
  2559. id := 1 + uint32(i)*2
  2560. st.writeHeaders(HeadersFrameParam{
  2561. StreamID: id,
  2562. BlockFragment: st.encodeHeader(),
  2563. EndStream: true,
  2564. EndHeaders: true,
  2565. })
  2566. st.wantHeaders()
  2567. df := st.wantData()
  2568. if !df.StreamEnded() {
  2569. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2570. }
  2571. }
  2572. }
  2573. func BenchmarkServerPosts(b *testing.B) {
  2574. defer disableGoroutineTracking()()
  2575. b.ReportAllocs()
  2576. const msg = "Hello, world"
  2577. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2578. io.WriteString(w, msg)
  2579. })
  2580. defer st.Close()
  2581. st.greet()
  2582. // Give the server quota to reply. (plus it has the the 64KB)
  2583. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2584. b.Fatal(err)
  2585. }
  2586. for i := 0; i < b.N; i++ {
  2587. id := 1 + uint32(i)*2
  2588. st.writeHeaders(HeadersFrameParam{
  2589. StreamID: id,
  2590. BlockFragment: st.encodeHeader(":method", "POST"),
  2591. EndStream: false,
  2592. EndHeaders: true,
  2593. })
  2594. st.writeData(id, true, nil)
  2595. st.wantHeaders()
  2596. df := st.wantData()
  2597. if !df.StreamEnded() {
  2598. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2599. }
  2600. }
  2601. }
  2602. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2603. // Verify we don't hang.
  2604. func TestIssue53(t *testing.T) {
  2605. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2606. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2607. s := &http.Server{
  2608. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2609. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2610. w.Write([]byte("hello"))
  2611. }),
  2612. }
  2613. s2 := &Server{
  2614. MaxReadFrameSize: 1 << 16,
  2615. PermitProhibitedCipherSuites: true,
  2616. }
  2617. c := &issue53Conn{[]byte(data), false, false}
  2618. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2619. if !c.closed {
  2620. t.Fatal("connection is not closed")
  2621. }
  2622. }
  2623. type issue53Conn struct {
  2624. data []byte
  2625. closed bool
  2626. written bool
  2627. }
  2628. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2629. if len(c.data) == 0 {
  2630. return 0, io.EOF
  2631. }
  2632. n = copy(b, c.data)
  2633. c.data = c.data[n:]
  2634. return
  2635. }
  2636. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2637. c.written = true
  2638. return len(b), nil
  2639. }
  2640. func (c *issue53Conn) Close() error {
  2641. c.closed = true
  2642. return nil
  2643. }
  2644. func (c *issue53Conn) LocalAddr() net.Addr {
  2645. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2646. }
  2647. func (c *issue53Conn) RemoteAddr() net.Addr {
  2648. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2649. }
  2650. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2651. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2652. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2653. // golang.org/issue/12895
  2654. func TestConfigureServer(t *testing.T) {
  2655. tests := []struct {
  2656. name string
  2657. in http.Server
  2658. wantErr string
  2659. }{
  2660. {
  2661. name: "empty server",
  2662. in: http.Server{},
  2663. },
  2664. {
  2665. name: "just the required cipher suite",
  2666. in: http.Server{
  2667. TLSConfig: &tls.Config{
  2668. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2669. },
  2670. },
  2671. },
  2672. {
  2673. name: "missing required cipher suite",
  2674. in: http.Server{
  2675. TLSConfig: &tls.Config{
  2676. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2677. },
  2678. },
  2679. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2680. },
  2681. {
  2682. name: "required after bad",
  2683. in: http.Server{
  2684. TLSConfig: &tls.Config{
  2685. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2686. },
  2687. },
  2688. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2689. },
  2690. {
  2691. name: "bad after required",
  2692. in: http.Server{
  2693. TLSConfig: &tls.Config{
  2694. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2695. },
  2696. },
  2697. },
  2698. }
  2699. for _, tt := range tests {
  2700. err := ConfigureServer(&tt.in, nil)
  2701. if (err != nil) != (tt.wantErr != "") {
  2702. if tt.wantErr != "" {
  2703. t.Errorf("%s: success, but want error", tt.name)
  2704. } else {
  2705. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2706. }
  2707. }
  2708. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2709. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2710. }
  2711. if err == nil && !tt.in.TLSConfig.PreferServerCipherSuites {
  2712. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2713. }
  2714. }
  2715. }
  2716. func TestServerRejectHeadWithBody(t *testing.T) {
  2717. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2718. // No response body.
  2719. })
  2720. defer st.Close()
  2721. st.greet()
  2722. st.writeHeaders(HeadersFrameParam{
  2723. StreamID: 1, // clients send odd numbers
  2724. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2725. EndStream: false, // what we're testing, a bogus HEAD request with body
  2726. EndHeaders: true,
  2727. })
  2728. st.wantRSTStream(1, ErrCodeProtocol)
  2729. }
  2730. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2731. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2732. // No response body. (or smaller than one frame)
  2733. })
  2734. defer st.Close()
  2735. st.greet()
  2736. st.writeHeaders(HeadersFrameParam{
  2737. StreamID: 1, // clients send odd numbers
  2738. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2739. EndStream: true,
  2740. EndHeaders: true,
  2741. })
  2742. h := st.wantHeaders()
  2743. headers := st.decodeHeader(h.HeaderBlockFragment())
  2744. want := [][2]string{
  2745. {":status", "200"},
  2746. {"content-type", "text/plain; charset=utf-8"},
  2747. }
  2748. if !reflect.DeepEqual(headers, want) {
  2749. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2750. }
  2751. }
  2752. // golang.org/issue/13495
  2753. func TestServerNoDuplicateContentType(t *testing.T) {
  2754. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2755. w.Header()["Content-Type"] = []string{""}
  2756. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2757. })
  2758. defer st.Close()
  2759. st.greet()
  2760. st.writeHeaders(HeadersFrameParam{
  2761. StreamID: 1,
  2762. BlockFragment: st.encodeHeader(),
  2763. EndStream: true,
  2764. EndHeaders: true,
  2765. })
  2766. h := st.wantHeaders()
  2767. headers := st.decodeHeader(h.HeaderBlockFragment())
  2768. want := [][2]string{
  2769. {":status", "200"},
  2770. {"content-type", ""},
  2771. {"content-length", "41"},
  2772. }
  2773. if !reflect.DeepEqual(headers, want) {
  2774. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2775. }
  2776. }
  2777. func disableGoroutineTracking() (restore func()) {
  2778. old := DebugGoroutines
  2779. DebugGoroutines = false
  2780. return func() { DebugGoroutines = old }
  2781. }
  2782. func BenchmarkServer_GetRequest(b *testing.B) {
  2783. defer disableGoroutineTracking()()
  2784. b.ReportAllocs()
  2785. const msg = "Hello, world."
  2786. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2787. n, err := io.Copy(ioutil.Discard, r.Body)
  2788. if err != nil || n > 0 {
  2789. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2790. }
  2791. io.WriteString(w, msg)
  2792. })
  2793. defer st.Close()
  2794. st.greet()
  2795. // Give the server quota to reply. (plus it has the the 64KB)
  2796. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2797. b.Fatal(err)
  2798. }
  2799. hbf := st.encodeHeader(":method", "GET")
  2800. for i := 0; i < b.N; i++ {
  2801. streamID := uint32(1 + 2*i)
  2802. st.writeHeaders(HeadersFrameParam{
  2803. StreamID: streamID,
  2804. BlockFragment: hbf,
  2805. EndStream: true,
  2806. EndHeaders: true,
  2807. })
  2808. st.wantHeaders()
  2809. st.wantData()
  2810. }
  2811. }
  2812. func BenchmarkServer_PostRequest(b *testing.B) {
  2813. defer disableGoroutineTracking()()
  2814. b.ReportAllocs()
  2815. const msg = "Hello, world."
  2816. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2817. n, err := io.Copy(ioutil.Discard, r.Body)
  2818. if err != nil || n > 0 {
  2819. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2820. }
  2821. io.WriteString(w, msg)
  2822. })
  2823. defer st.Close()
  2824. st.greet()
  2825. // Give the server quota to reply. (plus it has the the 64KB)
  2826. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2827. b.Fatal(err)
  2828. }
  2829. hbf := st.encodeHeader(":method", "POST")
  2830. for i := 0; i < b.N; i++ {
  2831. streamID := uint32(1 + 2*i)
  2832. st.writeHeaders(HeadersFrameParam{
  2833. StreamID: streamID,
  2834. BlockFragment: hbf,
  2835. EndStream: false,
  2836. EndHeaders: true,
  2837. })
  2838. st.writeData(streamID, true, nil)
  2839. st.wantHeaders()
  2840. st.wantData()
  2841. }
  2842. }
  2843. type connStateConn struct {
  2844. net.Conn
  2845. cs tls.ConnectionState
  2846. }
  2847. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  2848. // golang.org/issue/12737 -- handle any net.Conn, not just
  2849. // *tls.Conn.
  2850. func TestServerHandleCustomConn(t *testing.T) {
  2851. var s Server
  2852. c1, c2 := net.Pipe()
  2853. clientDone := make(chan struct{})
  2854. handlerDone := make(chan struct{})
  2855. var req *http.Request
  2856. go func() {
  2857. defer close(clientDone)
  2858. defer c2.Close()
  2859. fr := NewFramer(c2, c2)
  2860. io.WriteString(c2, ClientPreface)
  2861. fr.WriteSettings()
  2862. fr.WriteSettingsAck()
  2863. f, err := fr.ReadFrame()
  2864. if err != nil {
  2865. t.Error(err)
  2866. return
  2867. }
  2868. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  2869. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  2870. return
  2871. }
  2872. f, err = fr.ReadFrame()
  2873. if err != nil {
  2874. t.Error(err)
  2875. return
  2876. }
  2877. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  2878. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  2879. return
  2880. }
  2881. var henc hpackEncoder
  2882. fr.WriteHeaders(HeadersFrameParam{
  2883. StreamID: 1,
  2884. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  2885. EndStream: true,
  2886. EndHeaders: true,
  2887. })
  2888. go io.Copy(ioutil.Discard, c2)
  2889. <-handlerDone
  2890. }()
  2891. const testString = "my custom ConnectionState"
  2892. fakeConnState := tls.ConnectionState{
  2893. ServerName: testString,
  2894. Version: tls.VersionTLS12,
  2895. }
  2896. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  2897. BaseConfig: &http.Server{
  2898. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2899. defer close(handlerDone)
  2900. req = r
  2901. }),
  2902. }})
  2903. select {
  2904. case <-clientDone:
  2905. case <-time.After(5 * time.Second):
  2906. t.Fatal("timeout waiting for handler")
  2907. }
  2908. if req.TLS == nil {
  2909. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  2910. }
  2911. if req.TLS.ServerName != testString {
  2912. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  2913. }
  2914. }
  2915. // golang.org/issue/14214
  2916. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  2917. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2918. t.Errorf("should not get to Handler")
  2919. return nil
  2920. }, func(st *serverTester) {
  2921. st.bodylessReq1("connection", "foo")
  2922. hf := st.wantHeaders()
  2923. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2924. wanth := [][2]string{
  2925. {":status", "400"},
  2926. {"content-type", "text/plain; charset=utf-8"},
  2927. {"x-content-type-options", "nosniff"},
  2928. {"content-length", "51"},
  2929. }
  2930. if !reflect.DeepEqual(goth, wanth) {
  2931. t.Errorf("Got headers %v; want %v", goth, wanth)
  2932. }
  2933. })
  2934. }
  2935. type hpackEncoder struct {
  2936. enc *hpack.Encoder
  2937. buf bytes.Buffer
  2938. }
  2939. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  2940. if len(headers)%2 == 1 {
  2941. panic("odd number of kv args")
  2942. }
  2943. he.buf.Reset()
  2944. if he.enc == nil {
  2945. he.enc = hpack.NewEncoder(&he.buf)
  2946. }
  2947. for len(headers) > 0 {
  2948. k, v := headers[0], headers[1]
  2949. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  2950. if err != nil {
  2951. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  2952. }
  2953. headers = headers[2:]
  2954. }
  2955. return he.buf.Bytes()
  2956. }
  2957. func TestCheckValidHTTP2Request(t *testing.T) {
  2958. tests := []struct {
  2959. req *http.Request
  2960. want error
  2961. }{
  2962. {
  2963. req: &http.Request{Header: http.Header{"Te": {"trailers"}}},
  2964. want: nil,
  2965. },
  2966. {
  2967. req: &http.Request{Header: http.Header{"Te": {"trailers", "bogus"}}},
  2968. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  2969. },
  2970. {
  2971. req: &http.Request{Header: http.Header{"Foo": {""}}},
  2972. want: nil,
  2973. },
  2974. {
  2975. req: &http.Request{Header: http.Header{"Connection": {""}}},
  2976. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  2977. },
  2978. {
  2979. req: &http.Request{Header: http.Header{"Proxy-Connection": {""}}},
  2980. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  2981. },
  2982. {
  2983. req: &http.Request{Header: http.Header{"Keep-Alive": {""}}},
  2984. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  2985. },
  2986. {
  2987. req: &http.Request{Header: http.Header{"Upgrade": {""}}},
  2988. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  2989. },
  2990. }
  2991. for i, tt := range tests {
  2992. got := checkValidHTTP2Request(tt.req)
  2993. if !reflect.DeepEqual(got, tt.want) {
  2994. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  2995. }
  2996. }
  2997. }
  2998. // golang.org/issue/14030
  2999. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3000. const msg = "Hello"
  3001. const msg2 = "World"
  3002. doRead := make(chan bool, 1)
  3003. defer close(doRead) // fallback cleanup
  3004. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3005. io.WriteString(w, msg)
  3006. w.(http.Flusher).Flush()
  3007. // Do a read, which might force a 100-continue status to be sent.
  3008. <-doRead
  3009. r.Body.Read(make([]byte, 10))
  3010. io.WriteString(w, msg2)
  3011. }, optOnlyServer)
  3012. defer st.Close()
  3013. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3014. defer tr.CloseIdleConnections()
  3015. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3016. req.Header.Set("Expect", "100-continue")
  3017. res, err := tr.RoundTrip(req)
  3018. if err != nil {
  3019. t.Fatal(err)
  3020. }
  3021. defer res.Body.Close()
  3022. buf := make([]byte, len(msg))
  3023. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3024. t.Fatal(err)
  3025. }
  3026. if string(buf) != msg {
  3027. t.Fatalf("msg = %q; want %q", buf, msg)
  3028. }
  3029. doRead <- true
  3030. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3031. t.Fatal(err)
  3032. }
  3033. if string(buf) != msg2 {
  3034. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3035. }
  3036. }