transport_test.go 40 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "math/rand"
  16. "net"
  17. "net/http"
  18. "net/url"
  19. "os"
  20. "reflect"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var (
  30. extNet = flag.Bool("extnet", false, "do external network tests")
  31. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  32. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  33. )
  34. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  35. func TestTransportExternal(t *testing.T) {
  36. if !*extNet {
  37. t.Skip("skipping external network test")
  38. }
  39. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  40. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  41. res, err := rt.RoundTrip(req)
  42. if err != nil {
  43. t.Fatalf("%v", err)
  44. }
  45. res.Write(os.Stdout)
  46. }
  47. func TestTransport(t *testing.T) {
  48. const body = "sup"
  49. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  50. io.WriteString(w, body)
  51. }, optOnlyServer)
  52. defer st.Close()
  53. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  54. defer tr.CloseIdleConnections()
  55. req, err := http.NewRequest("GET", st.ts.URL, nil)
  56. if err != nil {
  57. t.Fatal(err)
  58. }
  59. res, err := tr.RoundTrip(req)
  60. if err != nil {
  61. t.Fatal(err)
  62. }
  63. defer res.Body.Close()
  64. t.Logf("Got res: %+v", res)
  65. if g, w := res.StatusCode, 200; g != w {
  66. t.Errorf("StatusCode = %v; want %v", g, w)
  67. }
  68. if g, w := res.Status, "200 OK"; g != w {
  69. t.Errorf("Status = %q; want %q", g, w)
  70. }
  71. wantHeader := http.Header{
  72. "Content-Length": []string{"3"},
  73. "Content-Type": []string{"text/plain; charset=utf-8"},
  74. "Date": []string{"XXX"}, // see cleanDate
  75. }
  76. cleanDate(res)
  77. if !reflect.DeepEqual(res.Header, wantHeader) {
  78. t.Errorf("res Header = %v; want %v", res.Header, wantHeader)
  79. }
  80. if res.Request != req {
  81. t.Errorf("Response.Request = %p; want %p", res.Request, req)
  82. }
  83. if res.TLS == nil {
  84. t.Error("Response.TLS = nil; want non-nil")
  85. }
  86. slurp, err := ioutil.ReadAll(res.Body)
  87. if err != nil {
  88. t.Errorf("Body read: %v", err)
  89. } else if string(slurp) != body {
  90. t.Errorf("Body = %q; want %q", slurp, body)
  91. }
  92. }
  93. func TestTransportReusesConns(t *testing.T) {
  94. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  95. io.WriteString(w, r.RemoteAddr)
  96. }, optOnlyServer)
  97. defer st.Close()
  98. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  99. defer tr.CloseIdleConnections()
  100. get := func() string {
  101. req, err := http.NewRequest("GET", st.ts.URL, nil)
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. res, err := tr.RoundTrip(req)
  106. if err != nil {
  107. t.Fatal(err)
  108. }
  109. defer res.Body.Close()
  110. slurp, err := ioutil.ReadAll(res.Body)
  111. if err != nil {
  112. t.Fatalf("Body read: %v", err)
  113. }
  114. addr := strings.TrimSpace(string(slurp))
  115. if addr == "" {
  116. t.Fatalf("didn't get an addr in response")
  117. }
  118. return addr
  119. }
  120. first := get()
  121. second := get()
  122. if first != second {
  123. t.Errorf("first and second responses were on different connections: %q vs %q", first, second)
  124. }
  125. }
  126. // Tests that the Transport only keeps one pending dial open per destination address.
  127. // https://golang.org/issue/13397
  128. func TestTransportGroupsPendingDials(t *testing.T) {
  129. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  130. io.WriteString(w, r.RemoteAddr)
  131. }, optOnlyServer)
  132. defer st.Close()
  133. tr := &Transport{
  134. TLSClientConfig: tlsConfigInsecure,
  135. }
  136. defer tr.CloseIdleConnections()
  137. var (
  138. mu sync.Mutex
  139. dials = map[string]int{}
  140. )
  141. var wg sync.WaitGroup
  142. for i := 0; i < 10; i++ {
  143. wg.Add(1)
  144. go func() {
  145. defer wg.Done()
  146. req, err := http.NewRequest("GET", st.ts.URL, nil)
  147. if err != nil {
  148. t.Error(err)
  149. return
  150. }
  151. res, err := tr.RoundTrip(req)
  152. if err != nil {
  153. t.Error(err)
  154. return
  155. }
  156. defer res.Body.Close()
  157. slurp, err := ioutil.ReadAll(res.Body)
  158. if err != nil {
  159. t.Errorf("Body read: %v", err)
  160. }
  161. addr := strings.TrimSpace(string(slurp))
  162. if addr == "" {
  163. t.Errorf("didn't get an addr in response")
  164. }
  165. mu.Lock()
  166. dials[addr]++
  167. mu.Unlock()
  168. }()
  169. }
  170. wg.Wait()
  171. if len(dials) != 1 {
  172. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  173. }
  174. tr.CloseIdleConnections()
  175. if err := retry(50, 10*time.Millisecond, func() error {
  176. cp, ok := tr.connPool().(*clientConnPool)
  177. if !ok {
  178. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  179. }
  180. cp.mu.Lock()
  181. defer cp.mu.Unlock()
  182. if len(cp.dialing) != 0 {
  183. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  184. }
  185. if len(cp.conns) != 0 {
  186. return fmt.Errorf("conns = %v; want empty", cp.conns)
  187. }
  188. if len(cp.keys) != 0 {
  189. return fmt.Errorf("keys = %v; want empty", cp.keys)
  190. }
  191. return nil
  192. }); err != nil {
  193. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  194. }
  195. }
  196. func retry(tries int, delay time.Duration, fn func() error) error {
  197. var err error
  198. for i := 0; i < tries; i++ {
  199. err = fn()
  200. if err == nil {
  201. return nil
  202. }
  203. time.Sleep(delay)
  204. }
  205. return err
  206. }
  207. func TestTransportAbortClosesPipes(t *testing.T) {
  208. shutdown := make(chan struct{})
  209. st := newServerTester(t,
  210. func(w http.ResponseWriter, r *http.Request) {
  211. w.(http.Flusher).Flush()
  212. <-shutdown
  213. },
  214. optOnlyServer,
  215. )
  216. defer st.Close()
  217. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  218. done := make(chan struct{})
  219. requestMade := make(chan struct{})
  220. go func() {
  221. defer close(done)
  222. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  223. req, err := http.NewRequest("GET", st.ts.URL, nil)
  224. if err != nil {
  225. t.Fatal(err)
  226. }
  227. res, err := tr.RoundTrip(req)
  228. if err != nil {
  229. t.Fatal(err)
  230. }
  231. defer res.Body.Close()
  232. close(requestMade)
  233. _, err = ioutil.ReadAll(res.Body)
  234. if err == nil {
  235. t.Error("expected error from res.Body.Read")
  236. }
  237. }()
  238. <-requestMade
  239. // Now force the serve loop to end, via closing the connection.
  240. st.closeConn()
  241. // deadlock? that's a bug.
  242. select {
  243. case <-done:
  244. case <-time.After(3 * time.Second):
  245. t.Fatal("timeout")
  246. }
  247. }
  248. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  249. // could be a table-driven test with extra goodies.
  250. func TestTransportPath(t *testing.T) {
  251. gotc := make(chan *url.URL, 1)
  252. st := newServerTester(t,
  253. func(w http.ResponseWriter, r *http.Request) {
  254. gotc <- r.URL
  255. },
  256. optOnlyServer,
  257. )
  258. defer st.Close()
  259. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  260. defer tr.CloseIdleConnections()
  261. const (
  262. path = "/testpath"
  263. query = "q=1"
  264. )
  265. surl := st.ts.URL + path + "?" + query
  266. req, err := http.NewRequest("POST", surl, nil)
  267. if err != nil {
  268. t.Fatal(err)
  269. }
  270. c := &http.Client{Transport: tr}
  271. res, err := c.Do(req)
  272. if err != nil {
  273. t.Fatal(err)
  274. }
  275. defer res.Body.Close()
  276. got := <-gotc
  277. if got.Path != path {
  278. t.Errorf("Read Path = %q; want %q", got.Path, path)
  279. }
  280. if got.RawQuery != query {
  281. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  282. }
  283. }
  284. func randString(n int) string {
  285. rnd := rand.New(rand.NewSource(int64(n)))
  286. b := make([]byte, n)
  287. for i := range b {
  288. b[i] = byte(rnd.Intn(256))
  289. }
  290. return string(b)
  291. }
  292. var bodyTests = []struct {
  293. body string
  294. noContentLen bool
  295. }{
  296. {body: "some message"},
  297. {body: "some message", noContentLen: true},
  298. {body: ""},
  299. {body: "", noContentLen: true},
  300. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  301. {body: strings.Repeat("a", 1<<20)},
  302. {body: randString(16<<10 - 1)},
  303. {body: randString(16 << 10)},
  304. {body: randString(16<<10 + 1)},
  305. {body: randString(512<<10 - 1)},
  306. {body: randString(512 << 10)},
  307. {body: randString(512<<10 + 1)},
  308. {body: randString(1<<20 - 1)},
  309. {body: randString(1 << 20)},
  310. {body: randString(1<<20 + 2)},
  311. }
  312. func TestTransportBody(t *testing.T) {
  313. type reqInfo struct {
  314. req *http.Request
  315. slurp []byte
  316. err error
  317. }
  318. gotc := make(chan reqInfo, 1)
  319. st := newServerTester(t,
  320. func(w http.ResponseWriter, r *http.Request) {
  321. slurp, err := ioutil.ReadAll(r.Body)
  322. if err != nil {
  323. gotc <- reqInfo{err: err}
  324. } else {
  325. gotc <- reqInfo{req: r, slurp: slurp}
  326. }
  327. },
  328. optOnlyServer,
  329. )
  330. defer st.Close()
  331. for i, tt := range bodyTests {
  332. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  333. defer tr.CloseIdleConnections()
  334. var body io.Reader = strings.NewReader(tt.body)
  335. if tt.noContentLen {
  336. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  337. }
  338. req, err := http.NewRequest("POST", st.ts.URL, body)
  339. if err != nil {
  340. t.Fatalf("#%d: %v", i, err)
  341. }
  342. c := &http.Client{Transport: tr}
  343. res, err := c.Do(req)
  344. if err != nil {
  345. t.Fatalf("#%d: %v", i, err)
  346. }
  347. defer res.Body.Close()
  348. ri := <-gotc
  349. if ri.err != nil {
  350. t.Errorf("%#d: read error: %v", i, ri.err)
  351. continue
  352. }
  353. if got := string(ri.slurp); got != tt.body {
  354. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  355. }
  356. wantLen := int64(len(tt.body))
  357. if tt.noContentLen && tt.body != "" {
  358. wantLen = -1
  359. }
  360. if ri.req.ContentLength != wantLen {
  361. t.Errorf("#%d. handler got ContentLength = %v; want %v", i, ri.req.ContentLength, wantLen)
  362. }
  363. }
  364. }
  365. func shortString(v string) string {
  366. const maxLen = 100
  367. if len(v) <= maxLen {
  368. return v
  369. }
  370. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  371. }
  372. func TestTransportDialTLS(t *testing.T) {
  373. var mu sync.Mutex // guards following
  374. var gotReq, didDial bool
  375. ts := newServerTester(t,
  376. func(w http.ResponseWriter, r *http.Request) {
  377. mu.Lock()
  378. gotReq = true
  379. mu.Unlock()
  380. },
  381. optOnlyServer,
  382. )
  383. defer ts.Close()
  384. tr := &Transport{
  385. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  386. mu.Lock()
  387. didDial = true
  388. mu.Unlock()
  389. cfg.InsecureSkipVerify = true
  390. c, err := tls.Dial(netw, addr, cfg)
  391. if err != nil {
  392. return nil, err
  393. }
  394. return c, c.Handshake()
  395. },
  396. }
  397. defer tr.CloseIdleConnections()
  398. client := &http.Client{Transport: tr}
  399. res, err := client.Get(ts.ts.URL)
  400. if err != nil {
  401. t.Fatal(err)
  402. }
  403. res.Body.Close()
  404. mu.Lock()
  405. if !gotReq {
  406. t.Error("didn't get request")
  407. }
  408. if !didDial {
  409. t.Error("didn't use dial hook")
  410. }
  411. }
  412. func TestConfigureTransport(t *testing.T) {
  413. t1 := &http.Transport{}
  414. err := ConfigureTransport(t1)
  415. if err == errTransportVersion {
  416. t.Skip(err)
  417. }
  418. if err != nil {
  419. t.Fatal(err)
  420. }
  421. if got := fmt.Sprintf("%#v", *t1); !strings.Contains(got, `"h2"`) {
  422. // Laziness, to avoid buildtags.
  423. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  424. }
  425. wantNextProtos := []string{"h2", "http/1.1"}
  426. if t1.TLSClientConfig == nil {
  427. t.Errorf("nil t1.TLSClientConfig")
  428. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  429. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  430. }
  431. if err := ConfigureTransport(t1); err == nil {
  432. t.Error("unexpected success on second call to ConfigureTransport")
  433. }
  434. // And does it work?
  435. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  436. io.WriteString(w, r.Proto)
  437. }, optOnlyServer)
  438. defer st.Close()
  439. t1.TLSClientConfig.InsecureSkipVerify = true
  440. c := &http.Client{Transport: t1}
  441. res, err := c.Get(st.ts.URL)
  442. if err != nil {
  443. t.Fatal(err)
  444. }
  445. slurp, err := ioutil.ReadAll(res.Body)
  446. if err != nil {
  447. t.Fatal(err)
  448. }
  449. if got, want := string(slurp), "HTTP/2.0"; got != want {
  450. t.Errorf("body = %q; want %q", got, want)
  451. }
  452. }
  453. type capitalizeReader struct {
  454. r io.Reader
  455. }
  456. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  457. n, err = cr.r.Read(p)
  458. for i, b := range p[:n] {
  459. if b >= 'a' && b <= 'z' {
  460. p[i] = b - ('a' - 'A')
  461. }
  462. }
  463. return
  464. }
  465. type flushWriter struct {
  466. w io.Writer
  467. }
  468. func (fw flushWriter) Write(p []byte) (n int, err error) {
  469. n, err = fw.w.Write(p)
  470. if f, ok := fw.w.(http.Flusher); ok {
  471. f.Flush()
  472. }
  473. return
  474. }
  475. type clientTester struct {
  476. t *testing.T
  477. tr *Transport
  478. sc, cc net.Conn // server and client conn
  479. fr *Framer // server's framer
  480. client func() error
  481. server func() error
  482. }
  483. func newClientTester(t *testing.T) *clientTester {
  484. var dialOnce struct {
  485. sync.Mutex
  486. dialed bool
  487. }
  488. ct := &clientTester{
  489. t: t,
  490. }
  491. ct.tr = &Transport{
  492. TLSClientConfig: tlsConfigInsecure,
  493. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  494. dialOnce.Lock()
  495. defer dialOnce.Unlock()
  496. if dialOnce.dialed {
  497. return nil, errors.New("only one dial allowed in test mode")
  498. }
  499. dialOnce.dialed = true
  500. return ct.cc, nil
  501. },
  502. }
  503. ln := newLocalListener(t)
  504. cc, err := net.Dial("tcp", ln.Addr().String())
  505. if err != nil {
  506. t.Fatal(err)
  507. }
  508. sc, err := ln.Accept()
  509. if err != nil {
  510. t.Fatal(err)
  511. }
  512. ln.Close()
  513. ct.cc = cc
  514. ct.sc = sc
  515. ct.fr = NewFramer(sc, sc)
  516. return ct
  517. }
  518. func newLocalListener(t *testing.T) net.Listener {
  519. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  520. if err == nil {
  521. return ln
  522. }
  523. ln, err = net.Listen("tcp6", "[::1]:0")
  524. if err != nil {
  525. t.Fatal(err)
  526. }
  527. return ln
  528. }
  529. func (ct *clientTester) greet() {
  530. buf := make([]byte, len(ClientPreface))
  531. _, err := io.ReadFull(ct.sc, buf)
  532. if err != nil {
  533. ct.t.Fatalf("reading client preface: %v", err)
  534. }
  535. f, err := ct.fr.ReadFrame()
  536. if err != nil {
  537. ct.t.Fatalf("Reading client settings frame: %v", err)
  538. }
  539. if sf, ok := f.(*SettingsFrame); !ok {
  540. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  541. _ = sf // stash it away?
  542. }
  543. if err := ct.fr.WriteSettings(); err != nil {
  544. ct.t.Fatal(err)
  545. }
  546. if err := ct.fr.WriteSettingsAck(); err != nil {
  547. ct.t.Fatal(err)
  548. }
  549. }
  550. func (ct *clientTester) cleanup() {
  551. ct.tr.CloseIdleConnections()
  552. }
  553. func (ct *clientTester) run() {
  554. errc := make(chan error, 2)
  555. ct.start("client", errc, ct.client)
  556. ct.start("server", errc, ct.server)
  557. defer ct.cleanup()
  558. for i := 0; i < 2; i++ {
  559. if err := <-errc; err != nil {
  560. ct.t.Error(err)
  561. return
  562. }
  563. }
  564. }
  565. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  566. go func() {
  567. finished := false
  568. var err error
  569. defer func() {
  570. if !finished {
  571. err = fmt.Errorf("%s goroutine didn't finish.", which)
  572. } else if err != nil {
  573. err = fmt.Errorf("%s: %v", which, err)
  574. }
  575. errc <- err
  576. }()
  577. err = fn()
  578. finished = true
  579. }()
  580. }
  581. type countingReader struct {
  582. n *int64
  583. }
  584. func (r countingReader) Read(p []byte) (n int, err error) {
  585. for i := range p {
  586. p[i] = byte(i)
  587. }
  588. atomic.AddInt64(r.n, int64(len(p)))
  589. return len(p), err
  590. }
  591. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  592. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  593. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  594. const bodySize = 10 << 20
  595. ct := newClientTester(t)
  596. ct.client = func() error {
  597. var n int64 // atomic
  598. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  599. if err != nil {
  600. return err
  601. }
  602. res, err := ct.tr.RoundTrip(req)
  603. if err != nil {
  604. return fmt.Errorf("RoundTrip: %v", err)
  605. }
  606. defer res.Body.Close()
  607. if res.StatusCode != status {
  608. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  609. }
  610. slurp, err := ioutil.ReadAll(res.Body)
  611. if err != nil {
  612. return fmt.Errorf("Slurp: %v", err)
  613. }
  614. if len(slurp) > 0 {
  615. return fmt.Errorf("unexpected body: %q", slurp)
  616. }
  617. if status == 200 {
  618. if got := atomic.LoadInt64(&n); got != bodySize {
  619. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  620. }
  621. } else {
  622. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  623. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  624. }
  625. }
  626. return nil
  627. }
  628. ct.server = func() error {
  629. ct.greet()
  630. var buf bytes.Buffer
  631. enc := hpack.NewEncoder(&buf)
  632. var dataRecv int64
  633. var closed bool
  634. for {
  635. f, err := ct.fr.ReadFrame()
  636. if err != nil {
  637. return err
  638. }
  639. //println(fmt.Sprintf("server got frame: %v", f))
  640. switch f := f.(type) {
  641. case *WindowUpdateFrame, *SettingsFrame:
  642. case *HeadersFrame:
  643. if !f.HeadersEnded() {
  644. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  645. }
  646. if f.StreamEnded() {
  647. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  648. }
  649. time.Sleep(50 * time.Millisecond) // let client send body
  650. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  651. ct.fr.WriteHeaders(HeadersFrameParam{
  652. StreamID: f.StreamID,
  653. EndHeaders: true,
  654. EndStream: false,
  655. BlockFragment: buf.Bytes(),
  656. })
  657. case *DataFrame:
  658. dataLen := len(f.Data())
  659. dataRecv += int64(dataLen)
  660. if dataLen > 0 {
  661. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  662. return err
  663. }
  664. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  665. return err
  666. }
  667. }
  668. if !closed && ((status != 200 && dataRecv > 0) ||
  669. (status == 200 && dataRecv == bodySize)) {
  670. closed = true
  671. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  672. return err
  673. }
  674. return nil
  675. }
  676. default:
  677. return fmt.Errorf("Unexpected client frame %v", f)
  678. }
  679. }
  680. return nil
  681. }
  682. ct.run()
  683. }
  684. // See golang.org/issue/13444
  685. func TestTransportFullDuplex(t *testing.T) {
  686. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  687. w.WriteHeader(200) // redundant but for clarity
  688. w.(http.Flusher).Flush()
  689. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  690. fmt.Fprintf(w, "bye.\n")
  691. }, optOnlyServer)
  692. defer st.Close()
  693. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  694. defer tr.CloseIdleConnections()
  695. c := &http.Client{Transport: tr}
  696. pr, pw := io.Pipe()
  697. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  698. if err != nil {
  699. log.Fatal(err)
  700. }
  701. req.ContentLength = -1
  702. res, err := c.Do(req)
  703. if err != nil {
  704. log.Fatal(err)
  705. }
  706. defer res.Body.Close()
  707. if res.StatusCode != 200 {
  708. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  709. }
  710. bs := bufio.NewScanner(res.Body)
  711. want := func(v string) {
  712. if !bs.Scan() {
  713. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  714. }
  715. }
  716. write := func(v string) {
  717. _, err := io.WriteString(pw, v)
  718. if err != nil {
  719. t.Fatalf("pipe write: %v", err)
  720. }
  721. }
  722. write("foo\n")
  723. want("FOO")
  724. write("bar\n")
  725. want("BAR")
  726. pw.Close()
  727. want("bye.")
  728. if err := bs.Err(); err != nil {
  729. t.Fatal(err)
  730. }
  731. }
  732. func TestTransportConnectRequest(t *testing.T) {
  733. gotc := make(chan *http.Request, 1)
  734. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  735. gotc <- r
  736. }, optOnlyServer)
  737. defer st.Close()
  738. u, err := url.Parse(st.ts.URL)
  739. if err != nil {
  740. t.Fatal(err)
  741. }
  742. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  743. defer tr.CloseIdleConnections()
  744. c := &http.Client{Transport: tr}
  745. tests := []struct {
  746. req *http.Request
  747. want string
  748. }{
  749. {
  750. req: &http.Request{
  751. Method: "CONNECT",
  752. Header: http.Header{},
  753. URL: u,
  754. },
  755. want: u.Host,
  756. },
  757. {
  758. req: &http.Request{
  759. Method: "CONNECT",
  760. Header: http.Header{},
  761. URL: u,
  762. Host: "example.com:123",
  763. },
  764. want: "example.com:123",
  765. },
  766. }
  767. for i, tt := range tests {
  768. res, err := c.Do(tt.req)
  769. if err != nil {
  770. t.Errorf("%d. RoundTrip = %v", i, err)
  771. continue
  772. }
  773. res.Body.Close()
  774. req := <-gotc
  775. if req.Method != "CONNECT" {
  776. t.Errorf("method = %q; want CONNECT", req.Method)
  777. }
  778. if req.Host != tt.want {
  779. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  780. }
  781. if req.URL.Host != tt.want {
  782. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  783. }
  784. }
  785. }
  786. type headerType int
  787. const (
  788. noHeader headerType = iota // omitted
  789. oneHeader
  790. splitHeader // broken into continuation on purpose
  791. )
  792. const (
  793. f0 = noHeader
  794. f1 = oneHeader
  795. f2 = splitHeader
  796. d0 = false
  797. d1 = true
  798. )
  799. // Test all 36 combinations of response frame orders:
  800. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  801. // Generated by http://play.golang.org/p/SScqYKJYXd
  802. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  803. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  804. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  805. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  806. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  807. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  808. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  809. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  810. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  811. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  812. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  813. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  814. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  815. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  816. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  817. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  818. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  819. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  820. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  821. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  822. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  823. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  824. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  825. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  826. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  827. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  828. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  829. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  830. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  831. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  832. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  833. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  834. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  835. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  836. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  837. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  838. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  839. const reqBody = "some request body"
  840. const resBody = "some response body"
  841. if resHeader == noHeader {
  842. // TODO: test 100-continue followed by immediate
  843. // server stream reset, without headers in the middle?
  844. panic("invalid combination")
  845. }
  846. ct := newClientTester(t)
  847. ct.client = func() error {
  848. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  849. if expect100Continue != noHeader {
  850. req.Header.Set("Expect", "100-continue")
  851. }
  852. res, err := ct.tr.RoundTrip(req)
  853. if err != nil {
  854. return fmt.Errorf("RoundTrip: %v", err)
  855. }
  856. defer res.Body.Close()
  857. if res.StatusCode != 200 {
  858. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  859. }
  860. slurp, err := ioutil.ReadAll(res.Body)
  861. if err != nil {
  862. return fmt.Errorf("Slurp: %v", err)
  863. }
  864. wantBody := resBody
  865. if !withData {
  866. wantBody = ""
  867. }
  868. if string(slurp) != wantBody {
  869. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  870. }
  871. if trailers == noHeader {
  872. if len(res.Trailer) > 0 {
  873. t.Errorf("Trailer = %v; want none", res.Trailer)
  874. }
  875. } else {
  876. want := http.Header{"Some-Trailer": {"some-value"}}
  877. if !reflect.DeepEqual(res.Trailer, want) {
  878. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  879. }
  880. }
  881. return nil
  882. }
  883. ct.server = func() error {
  884. ct.greet()
  885. var buf bytes.Buffer
  886. enc := hpack.NewEncoder(&buf)
  887. for {
  888. f, err := ct.fr.ReadFrame()
  889. if err != nil {
  890. return err
  891. }
  892. switch f := f.(type) {
  893. case *WindowUpdateFrame, *SettingsFrame:
  894. case *DataFrame:
  895. // ignore for now.
  896. case *HeadersFrame:
  897. endStream := false
  898. send := func(mode headerType) {
  899. hbf := buf.Bytes()
  900. switch mode {
  901. case oneHeader:
  902. ct.fr.WriteHeaders(HeadersFrameParam{
  903. StreamID: f.StreamID,
  904. EndHeaders: true,
  905. EndStream: endStream,
  906. BlockFragment: hbf,
  907. })
  908. case splitHeader:
  909. if len(hbf) < 2 {
  910. panic("too small")
  911. }
  912. ct.fr.WriteHeaders(HeadersFrameParam{
  913. StreamID: f.StreamID,
  914. EndHeaders: false,
  915. EndStream: endStream,
  916. BlockFragment: hbf[:1],
  917. })
  918. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  919. default:
  920. panic("bogus mode")
  921. }
  922. }
  923. if expect100Continue != noHeader {
  924. buf.Reset()
  925. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  926. send(expect100Continue)
  927. }
  928. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  929. {
  930. buf.Reset()
  931. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  932. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  933. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  934. if trailers != noHeader {
  935. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  936. }
  937. endStream = withData == false && trailers == noHeader
  938. send(resHeader)
  939. }
  940. if withData {
  941. endStream = trailers == noHeader
  942. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  943. }
  944. if trailers != noHeader {
  945. endStream = true
  946. buf.Reset()
  947. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  948. send(trailers)
  949. }
  950. return nil
  951. }
  952. }
  953. }
  954. ct.run()
  955. }
  956. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  957. ct := newClientTester(t)
  958. ct.client = func() error {
  959. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  960. res, err := ct.tr.RoundTrip(req)
  961. if err != nil {
  962. return fmt.Errorf("RoundTrip: %v", err)
  963. }
  964. defer res.Body.Close()
  965. if res.StatusCode != 200 {
  966. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  967. }
  968. slurp, err := ioutil.ReadAll(res.Body)
  969. if err != nil {
  970. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  971. }
  972. if len(slurp) > 0 {
  973. return fmt.Errorf("body = %q; want nothing", slurp)
  974. }
  975. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  976. return fmt.Errorf("expected Some-Trailer")
  977. }
  978. return nil
  979. }
  980. ct.server = func() error {
  981. ct.greet()
  982. var n int
  983. var hf *HeadersFrame
  984. for hf == nil && n < 10 {
  985. f, err := ct.fr.ReadFrame()
  986. if err != nil {
  987. return err
  988. }
  989. hf, _ = f.(*HeadersFrame)
  990. n++
  991. }
  992. var buf bytes.Buffer
  993. enc := hpack.NewEncoder(&buf)
  994. // send headers without Trailer header
  995. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  996. ct.fr.WriteHeaders(HeadersFrameParam{
  997. StreamID: hf.StreamID,
  998. EndHeaders: true,
  999. EndStream: false,
  1000. BlockFragment: buf.Bytes(),
  1001. })
  1002. // send trailers
  1003. buf.Reset()
  1004. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  1005. ct.fr.WriteHeaders(HeadersFrameParam{
  1006. StreamID: hf.StreamID,
  1007. EndHeaders: true,
  1008. EndStream: true,
  1009. BlockFragment: buf.Bytes(),
  1010. })
  1011. return nil
  1012. }
  1013. ct.run()
  1014. }
  1015. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1016. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1017. }
  1018. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1019. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1020. }
  1021. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1022. testInvalidTrailer(t, trailers, errPseudoTrailers, func(enc *hpack.Encoder) {
  1023. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1024. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1025. })
  1026. }
  1027. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1028. testTransportInvalidTrailer_Capital(t, oneHeader)
  1029. }
  1030. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1031. testTransportInvalidTrailer_Capital(t, splitHeader)
  1032. }
  1033. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1034. testInvalidTrailer(t, trailers, errInvalidHeaderFieldName, func(enc *hpack.Encoder) {
  1035. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1036. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1037. })
  1038. }
  1039. func TestTransportInvalidTrailer_EmptyFieldName(t *testing.T) {
  1040. testInvalidTrailer(t, oneHeader, errInvalidHeaderFieldName, func(enc *hpack.Encoder) {
  1041. enc.WriteField(hpack.HeaderField{Name: "", Value: "bad"})
  1042. })
  1043. }
  1044. func TestTransportInvalidTrailer_BinaryFieldValue(t *testing.T) {
  1045. testInvalidTrailer(t, oneHeader, errInvalidHeaderFieldValue, func(enc *hpack.Encoder) {
  1046. enc.WriteField(hpack.HeaderField{Name: "", Value: "has\nnewline"})
  1047. })
  1048. }
  1049. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1050. ct := newClientTester(t)
  1051. ct.client = func() error {
  1052. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1053. res, err := ct.tr.RoundTrip(req)
  1054. if err != nil {
  1055. return fmt.Errorf("RoundTrip: %v", err)
  1056. }
  1057. defer res.Body.Close()
  1058. if res.StatusCode != 200 {
  1059. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1060. }
  1061. slurp, err := ioutil.ReadAll(res.Body)
  1062. if err != wantErr {
  1063. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, wantErr)
  1064. }
  1065. if len(slurp) > 0 {
  1066. return fmt.Errorf("body = %q; want nothing", slurp)
  1067. }
  1068. return nil
  1069. }
  1070. ct.server = func() error {
  1071. ct.greet()
  1072. var buf bytes.Buffer
  1073. enc := hpack.NewEncoder(&buf)
  1074. for {
  1075. f, err := ct.fr.ReadFrame()
  1076. if err != nil {
  1077. return err
  1078. }
  1079. switch f := f.(type) {
  1080. case *HeadersFrame:
  1081. var endStream bool
  1082. send := func(mode headerType) {
  1083. hbf := buf.Bytes()
  1084. switch mode {
  1085. case oneHeader:
  1086. ct.fr.WriteHeaders(HeadersFrameParam{
  1087. StreamID: f.StreamID,
  1088. EndHeaders: true,
  1089. EndStream: endStream,
  1090. BlockFragment: hbf,
  1091. })
  1092. case splitHeader:
  1093. if len(hbf) < 2 {
  1094. panic("too small")
  1095. }
  1096. ct.fr.WriteHeaders(HeadersFrameParam{
  1097. StreamID: f.StreamID,
  1098. EndHeaders: false,
  1099. EndStream: endStream,
  1100. BlockFragment: hbf[:1],
  1101. })
  1102. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1103. default:
  1104. panic("bogus mode")
  1105. }
  1106. }
  1107. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1108. {
  1109. buf.Reset()
  1110. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1111. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1112. endStream = false
  1113. send(oneHeader)
  1114. }
  1115. // Trailers:
  1116. {
  1117. endStream = true
  1118. buf.Reset()
  1119. writeTrailer(enc)
  1120. send(trailers)
  1121. }
  1122. return nil
  1123. }
  1124. }
  1125. }
  1126. ct.run()
  1127. }
  1128. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1129. ct := newClientTester(t)
  1130. ct.client = func() error {
  1131. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1132. res, err := ct.tr.RoundTrip(req)
  1133. if err != errResponseHeaderListSize {
  1134. if res != nil {
  1135. res.Body.Close()
  1136. }
  1137. size := int64(0)
  1138. for k, vv := range res.Header {
  1139. for _, v := range vv {
  1140. size += int64(len(k)) + int64(len(v)) + 32
  1141. }
  1142. }
  1143. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1144. }
  1145. return nil
  1146. }
  1147. ct.server = func() error {
  1148. ct.greet()
  1149. var buf bytes.Buffer
  1150. enc := hpack.NewEncoder(&buf)
  1151. for {
  1152. f, err := ct.fr.ReadFrame()
  1153. if err != nil {
  1154. return err
  1155. }
  1156. switch f := f.(type) {
  1157. case *HeadersFrame:
  1158. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1159. large := strings.Repeat("a", 1<<10)
  1160. for i := 0; i < 5042; i++ {
  1161. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1162. }
  1163. if size, want := buf.Len(), 6329; size != want {
  1164. // Note: this number might change if
  1165. // our hpack implementation
  1166. // changes. That's fine. This is
  1167. // just a sanity check that our
  1168. // response can fit in a single
  1169. // header block fragment frame.
  1170. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1171. }
  1172. ct.fr.WriteHeaders(HeadersFrameParam{
  1173. StreamID: f.StreamID,
  1174. EndHeaders: true,
  1175. EndStream: true,
  1176. BlockFragment: buf.Bytes(),
  1177. })
  1178. return nil
  1179. }
  1180. }
  1181. }
  1182. ct.run()
  1183. }
  1184. // Test that the the Transport returns a typed error from Response.Body.Read calls
  1185. // when the server sends an error. (here we use a panic, since that should generate
  1186. // a stream error, but others like cancel should be similar)
  1187. func TestTransportBodyReadErrorType(t *testing.T) {
  1188. doPanic := make(chan bool, 1)
  1189. st := newServerTester(t,
  1190. func(w http.ResponseWriter, r *http.Request) {
  1191. w.(http.Flusher).Flush() // force headers out
  1192. <-doPanic
  1193. panic("boom")
  1194. },
  1195. optOnlyServer,
  1196. optQuiet,
  1197. )
  1198. defer st.Close()
  1199. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1200. defer tr.CloseIdleConnections()
  1201. c := &http.Client{Transport: tr}
  1202. res, err := c.Get(st.ts.URL)
  1203. if err != nil {
  1204. t.Fatal(err)
  1205. }
  1206. defer res.Body.Close()
  1207. doPanic <- true
  1208. buf := make([]byte, 100)
  1209. n, err := res.Body.Read(buf)
  1210. want := StreamError{StreamID: 0x1, Code: 0x2}
  1211. if !reflect.DeepEqual(want, err) {
  1212. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1213. }
  1214. }
  1215. // golang.org/issue/13924
  1216. // This used to fail after many iterations, especially with -race:
  1217. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1218. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1219. var (
  1220. mu sync.Mutex
  1221. conn net.Conn // to close if set
  1222. )
  1223. st := newServerTester(t,
  1224. func(w http.ResponseWriter, r *http.Request) {
  1225. mu.Lock()
  1226. defer mu.Unlock()
  1227. if conn != nil {
  1228. conn.Close()
  1229. }
  1230. },
  1231. optOnlyServer,
  1232. )
  1233. defer st.Close()
  1234. tr := &Transport{
  1235. TLSClientConfig: tlsConfigInsecure,
  1236. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1237. tc, err := tls.Dial(network, addr, cfg)
  1238. if err != nil {
  1239. return nil, err
  1240. }
  1241. mu.Lock()
  1242. defer mu.Unlock()
  1243. conn = tc
  1244. return tc, nil
  1245. },
  1246. }
  1247. defer tr.CloseIdleConnections()
  1248. c := &http.Client{Transport: tr}
  1249. c.Get(st.ts.URL)
  1250. }
  1251. // Test that the http1 Transport.DisableKeepAlives option is respected
  1252. // and connections are closed as soon as idle.
  1253. // See golang.org/issue/14008
  1254. func TestTransportDisableKeepAlives(t *testing.T) {
  1255. st := newServerTester(t,
  1256. func(w http.ResponseWriter, r *http.Request) {
  1257. io.WriteString(w, "hi")
  1258. },
  1259. optOnlyServer,
  1260. )
  1261. defer st.Close()
  1262. connClosed := make(chan struct{}) // closed on tls.Conn.Close
  1263. tr := &Transport{
  1264. t1: &http.Transport{
  1265. DisableKeepAlives: true,
  1266. },
  1267. TLSClientConfig: tlsConfigInsecure,
  1268. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1269. tc, err := tls.Dial(network, addr, cfg)
  1270. if err != nil {
  1271. return nil, err
  1272. }
  1273. return &noteCloseConn{Conn: tc, closefn: func() { close(connClosed) }}, nil
  1274. },
  1275. }
  1276. c := &http.Client{Transport: tr}
  1277. res, err := c.Get(st.ts.URL)
  1278. if err != nil {
  1279. t.Fatal(err)
  1280. }
  1281. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1282. t.Fatal(err)
  1283. }
  1284. defer res.Body.Close()
  1285. select {
  1286. case <-connClosed:
  1287. case <-time.After(1 * time.Second):
  1288. t.Errorf("timeout")
  1289. }
  1290. }
  1291. // Test concurrent requests with Transport.DisableKeepAlives. We can share connections,
  1292. // but when things are totally idle, it still needs to close.
  1293. func TestTransportDisableKeepAlives_Concurrency(t *testing.T) {
  1294. const D = 25 * time.Millisecond
  1295. st := newServerTester(t,
  1296. func(w http.ResponseWriter, r *http.Request) {
  1297. time.Sleep(D)
  1298. io.WriteString(w, "hi")
  1299. },
  1300. optOnlyServer,
  1301. )
  1302. defer st.Close()
  1303. var dials int32
  1304. var conns sync.WaitGroup
  1305. tr := &Transport{
  1306. t1: &http.Transport{
  1307. DisableKeepAlives: true,
  1308. },
  1309. TLSClientConfig: tlsConfigInsecure,
  1310. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1311. tc, err := tls.Dial(network, addr, cfg)
  1312. if err != nil {
  1313. return nil, err
  1314. }
  1315. atomic.AddInt32(&dials, 1)
  1316. conns.Add(1)
  1317. return &noteCloseConn{Conn: tc, closefn: func() { conns.Done() }}, nil
  1318. },
  1319. }
  1320. c := &http.Client{Transport: tr}
  1321. var reqs sync.WaitGroup
  1322. const N = 20
  1323. for i := 0; i < N; i++ {
  1324. reqs.Add(1)
  1325. if i == N-1 {
  1326. // For the final request, try to make all the
  1327. // others close. This isn't verified in the
  1328. // count, other than the Log statement, since
  1329. // it's so timing dependent. This test is
  1330. // really to make sure we don't interrupt a
  1331. // valid request.
  1332. time.Sleep(D * 2)
  1333. }
  1334. go func() {
  1335. defer reqs.Done()
  1336. res, err := c.Get(st.ts.URL)
  1337. if err != nil {
  1338. t.Error(err)
  1339. return
  1340. }
  1341. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1342. t.Error(err)
  1343. return
  1344. }
  1345. res.Body.Close()
  1346. }()
  1347. }
  1348. reqs.Wait()
  1349. conns.Wait()
  1350. t.Logf("did %d dials, %d requests", atomic.LoadInt32(&dials), N)
  1351. }
  1352. type noteCloseConn struct {
  1353. net.Conn
  1354. onceClose sync.Once
  1355. closefn func()
  1356. }
  1357. func (c *noteCloseConn) Close() error {
  1358. c.onceClose.Do(c.closefn)
  1359. return c.Conn.Close()
  1360. }
  1361. func isTimeout(err error) bool {
  1362. switch err := err.(type) {
  1363. case nil:
  1364. return false
  1365. case *url.Error:
  1366. return isTimeout(err.Err)
  1367. case net.Error:
  1368. return err.Timeout()
  1369. }
  1370. return false
  1371. }
  1372. // Test that the http1 Transport.ResponseHeaderTimeout option and cancel is sent.
  1373. func TestTransportResponseHeaderTimeout_NoBody(t *testing.T) {
  1374. testTransportResponseHeaderTimeout(t, false)
  1375. }
  1376. func TestTransportResponseHeaderTimeout_Body(t *testing.T) {
  1377. testTransportResponseHeaderTimeout(t, true)
  1378. }
  1379. func testTransportResponseHeaderTimeout(t *testing.T, body bool) {
  1380. ct := newClientTester(t)
  1381. ct.tr.t1 = &http.Transport{
  1382. ResponseHeaderTimeout: 5 * time.Millisecond,
  1383. }
  1384. ct.client = func() error {
  1385. c := &http.Client{Transport: ct.tr}
  1386. var err error
  1387. var n int64
  1388. const bodySize = 4 << 20
  1389. if body {
  1390. _, err = c.Post("https://dummy.tld/", "text/foo", io.LimitReader(countingReader{&n}, bodySize))
  1391. } else {
  1392. _, err = c.Get("https://dummy.tld/")
  1393. }
  1394. if !isTimeout(err) {
  1395. t.Errorf("client expected timeout error; got %#v", err)
  1396. }
  1397. if body && n != bodySize {
  1398. t.Errorf("only read %d bytes of body; want %d", n, bodySize)
  1399. }
  1400. return nil
  1401. }
  1402. ct.server = func() error {
  1403. ct.greet()
  1404. for {
  1405. f, err := ct.fr.ReadFrame()
  1406. if err != nil {
  1407. t.Logf("ReadFrame: %v", err)
  1408. return nil
  1409. }
  1410. switch f := f.(type) {
  1411. case *DataFrame:
  1412. dataLen := len(f.Data())
  1413. if dataLen > 0 {
  1414. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  1415. return err
  1416. }
  1417. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  1418. return err
  1419. }
  1420. }
  1421. case *RSTStreamFrame:
  1422. if f.StreamID == 1 && f.ErrCode == ErrCodeCancel {
  1423. return nil
  1424. }
  1425. }
  1426. }
  1427. return nil
  1428. }
  1429. ct.run()
  1430. }
  1431. func TestTransportDisableCompression(t *testing.T) {
  1432. const body = "sup"
  1433. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1434. want := http.Header{
  1435. "User-Agent": []string{"Go-http-client/2.0"},
  1436. }
  1437. if !reflect.DeepEqual(r.Header, want) {
  1438. t.Errorf("request headers = %v; want %v", r.Header, want)
  1439. }
  1440. }, optOnlyServer)
  1441. defer st.Close()
  1442. tr := &Transport{
  1443. TLSClientConfig: tlsConfigInsecure,
  1444. t1: &http.Transport{
  1445. DisableCompression: true,
  1446. },
  1447. }
  1448. defer tr.CloseIdleConnections()
  1449. req, err := http.NewRequest("GET", st.ts.URL, nil)
  1450. if err != nil {
  1451. t.Fatal(err)
  1452. }
  1453. res, err := tr.RoundTrip(req)
  1454. if err != nil {
  1455. t.Fatal(err)
  1456. }
  1457. defer res.Body.Close()
  1458. }