transport_test.go 34 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "math/rand"
  16. "net"
  17. "net/http"
  18. "net/url"
  19. "os"
  20. "reflect"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var (
  30. extNet = flag.Bool("extnet", false, "do external network tests")
  31. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  32. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  33. )
  34. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  35. func TestTransportExternal(t *testing.T) {
  36. if !*extNet {
  37. t.Skip("skipping external network test")
  38. }
  39. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  40. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  41. res, err := rt.RoundTrip(req)
  42. if err != nil {
  43. t.Fatalf("%v", err)
  44. }
  45. res.Write(os.Stdout)
  46. }
  47. func TestTransport(t *testing.T) {
  48. const body = "sup"
  49. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  50. io.WriteString(w, body)
  51. }, optOnlyServer)
  52. defer st.Close()
  53. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  54. defer tr.CloseIdleConnections()
  55. req, err := http.NewRequest("GET", st.ts.URL, nil)
  56. if err != nil {
  57. t.Fatal(err)
  58. }
  59. res, err := tr.RoundTrip(req)
  60. if err != nil {
  61. t.Fatal(err)
  62. }
  63. defer res.Body.Close()
  64. t.Logf("Got res: %+v", res)
  65. if g, w := res.StatusCode, 200; g != w {
  66. t.Errorf("StatusCode = %v; want %v", g, w)
  67. }
  68. if g, w := res.Status, "200 OK"; g != w {
  69. t.Errorf("Status = %q; want %q", g, w)
  70. }
  71. wantHeader := http.Header{
  72. "Content-Length": []string{"3"},
  73. "Content-Type": []string{"text/plain; charset=utf-8"},
  74. "Date": []string{"XXX"}, // see cleanDate
  75. }
  76. cleanDate(res)
  77. if !reflect.DeepEqual(res.Header, wantHeader) {
  78. t.Errorf("res Header = %v; want %v", res.Header, wantHeader)
  79. }
  80. if res.Request != req {
  81. t.Errorf("Response.Request = %p; want %p", res.Request, req)
  82. }
  83. if res.TLS == nil {
  84. t.Error("Response.TLS = nil; want non-nil")
  85. }
  86. slurp, err := ioutil.ReadAll(res.Body)
  87. if err != nil {
  88. t.Errorf("Body read: %v", err)
  89. } else if string(slurp) != body {
  90. t.Errorf("Body = %q; want %q", slurp, body)
  91. }
  92. }
  93. func TestTransportReusesConns(t *testing.T) {
  94. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  95. io.WriteString(w, r.RemoteAddr)
  96. }, optOnlyServer)
  97. defer st.Close()
  98. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  99. defer tr.CloseIdleConnections()
  100. get := func() string {
  101. req, err := http.NewRequest("GET", st.ts.URL, nil)
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. res, err := tr.RoundTrip(req)
  106. if err != nil {
  107. t.Fatal(err)
  108. }
  109. defer res.Body.Close()
  110. slurp, err := ioutil.ReadAll(res.Body)
  111. if err != nil {
  112. t.Fatalf("Body read: %v", err)
  113. }
  114. addr := strings.TrimSpace(string(slurp))
  115. if addr == "" {
  116. t.Fatalf("didn't get an addr in response")
  117. }
  118. return addr
  119. }
  120. first := get()
  121. second := get()
  122. if first != second {
  123. t.Errorf("first and second responses were on different connections: %q vs %q", first, second)
  124. }
  125. }
  126. // Tests that the Transport only keeps one pending dial open per destination address.
  127. // https://golang.org/issue/13397
  128. func TestTransportGroupsPendingDials(t *testing.T) {
  129. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  130. io.WriteString(w, r.RemoteAddr)
  131. }, optOnlyServer)
  132. defer st.Close()
  133. tr := &Transport{
  134. TLSClientConfig: tlsConfigInsecure,
  135. }
  136. defer tr.CloseIdleConnections()
  137. var (
  138. mu sync.Mutex
  139. dials = map[string]int{}
  140. )
  141. var wg sync.WaitGroup
  142. for i := 0; i < 10; i++ {
  143. wg.Add(1)
  144. go func() {
  145. defer wg.Done()
  146. req, err := http.NewRequest("GET", st.ts.URL, nil)
  147. if err != nil {
  148. t.Error(err)
  149. return
  150. }
  151. res, err := tr.RoundTrip(req)
  152. if err != nil {
  153. t.Error(err)
  154. return
  155. }
  156. defer res.Body.Close()
  157. slurp, err := ioutil.ReadAll(res.Body)
  158. if err != nil {
  159. t.Errorf("Body read: %v", err)
  160. }
  161. addr := strings.TrimSpace(string(slurp))
  162. if addr == "" {
  163. t.Errorf("didn't get an addr in response")
  164. }
  165. mu.Lock()
  166. dials[addr]++
  167. mu.Unlock()
  168. }()
  169. }
  170. wg.Wait()
  171. if len(dials) != 1 {
  172. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  173. }
  174. tr.CloseIdleConnections()
  175. if err := retry(50, 10*time.Millisecond, func() error {
  176. cp, ok := tr.connPool().(*clientConnPool)
  177. if !ok {
  178. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  179. }
  180. cp.mu.Lock()
  181. defer cp.mu.Unlock()
  182. if len(cp.dialing) != 0 {
  183. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  184. }
  185. if len(cp.conns) != 0 {
  186. return fmt.Errorf("conns = %v; want empty", cp.conns)
  187. }
  188. if len(cp.keys) != 0 {
  189. return fmt.Errorf("keys = %v; want empty", cp.keys)
  190. }
  191. return nil
  192. }); err != nil {
  193. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  194. }
  195. }
  196. func retry(tries int, delay time.Duration, fn func() error) error {
  197. var err error
  198. for i := 0; i < tries; i++ {
  199. err = fn()
  200. if err == nil {
  201. return nil
  202. }
  203. time.Sleep(delay)
  204. }
  205. return err
  206. }
  207. func TestTransportAbortClosesPipes(t *testing.T) {
  208. shutdown := make(chan struct{})
  209. st := newServerTester(t,
  210. func(w http.ResponseWriter, r *http.Request) {
  211. w.(http.Flusher).Flush()
  212. <-shutdown
  213. },
  214. optOnlyServer,
  215. )
  216. defer st.Close()
  217. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  218. done := make(chan struct{})
  219. requestMade := make(chan struct{})
  220. go func() {
  221. defer close(done)
  222. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  223. req, err := http.NewRequest("GET", st.ts.URL, nil)
  224. if err != nil {
  225. t.Fatal(err)
  226. }
  227. res, err := tr.RoundTrip(req)
  228. if err != nil {
  229. t.Fatal(err)
  230. }
  231. defer res.Body.Close()
  232. close(requestMade)
  233. _, err = ioutil.ReadAll(res.Body)
  234. if err == nil {
  235. t.Error("expected error from res.Body.Read")
  236. }
  237. }()
  238. <-requestMade
  239. // Now force the serve loop to end, via closing the connection.
  240. st.closeConn()
  241. // deadlock? that's a bug.
  242. select {
  243. case <-done:
  244. case <-time.After(3 * time.Second):
  245. t.Fatal("timeout")
  246. }
  247. }
  248. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  249. // could be a table-driven test with extra goodies.
  250. func TestTransportPath(t *testing.T) {
  251. gotc := make(chan *url.URL, 1)
  252. st := newServerTester(t,
  253. func(w http.ResponseWriter, r *http.Request) {
  254. gotc <- r.URL
  255. },
  256. optOnlyServer,
  257. )
  258. defer st.Close()
  259. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  260. defer tr.CloseIdleConnections()
  261. const (
  262. path = "/testpath"
  263. query = "q=1"
  264. )
  265. surl := st.ts.URL + path + "?" + query
  266. req, err := http.NewRequest("POST", surl, nil)
  267. if err != nil {
  268. t.Fatal(err)
  269. }
  270. c := &http.Client{Transport: tr}
  271. res, err := c.Do(req)
  272. if err != nil {
  273. t.Fatal(err)
  274. }
  275. defer res.Body.Close()
  276. got := <-gotc
  277. if got.Path != path {
  278. t.Errorf("Read Path = %q; want %q", got.Path, path)
  279. }
  280. if got.RawQuery != query {
  281. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  282. }
  283. }
  284. func randString(n int) string {
  285. rnd := rand.New(rand.NewSource(int64(n)))
  286. b := make([]byte, n)
  287. for i := range b {
  288. b[i] = byte(rnd.Intn(256))
  289. }
  290. return string(b)
  291. }
  292. var bodyTests = []struct {
  293. body string
  294. noContentLen bool
  295. }{
  296. {body: "some message"},
  297. {body: "some message", noContentLen: true},
  298. {body: ""},
  299. {body: "", noContentLen: true},
  300. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  301. {body: strings.Repeat("a", 1<<20)},
  302. {body: randString(16<<10 - 1)},
  303. {body: randString(16 << 10)},
  304. {body: randString(16<<10 + 1)},
  305. {body: randString(512<<10 - 1)},
  306. {body: randString(512 << 10)},
  307. {body: randString(512<<10 + 1)},
  308. {body: randString(1<<20 - 1)},
  309. {body: randString(1 << 20)},
  310. {body: randString(1<<20 + 2)},
  311. }
  312. func TestTransportBody(t *testing.T) {
  313. gotc := make(chan interface{}, 1)
  314. st := newServerTester(t,
  315. func(w http.ResponseWriter, r *http.Request) {
  316. slurp, err := ioutil.ReadAll(r.Body)
  317. if err != nil {
  318. gotc <- err
  319. } else {
  320. gotc <- string(slurp)
  321. }
  322. },
  323. optOnlyServer,
  324. )
  325. defer st.Close()
  326. for i, tt := range bodyTests {
  327. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  328. defer tr.CloseIdleConnections()
  329. var body io.Reader = strings.NewReader(tt.body)
  330. if tt.noContentLen {
  331. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  332. }
  333. req, err := http.NewRequest("POST", st.ts.URL, body)
  334. if err != nil {
  335. t.Fatalf("#%d: %v", i, err)
  336. }
  337. c := &http.Client{Transport: tr}
  338. res, err := c.Do(req)
  339. if err != nil {
  340. t.Fatalf("#%d: %v", i, err)
  341. }
  342. defer res.Body.Close()
  343. got := <-gotc
  344. if err, ok := got.(error); ok {
  345. t.Fatalf("#%d: %v", i, err)
  346. } else if got.(string) != tt.body {
  347. got := got.(string)
  348. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  349. }
  350. }
  351. }
  352. func shortString(v string) string {
  353. const maxLen = 100
  354. if len(v) <= maxLen {
  355. return v
  356. }
  357. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  358. }
  359. func TestTransportDialTLS(t *testing.T) {
  360. var mu sync.Mutex // guards following
  361. var gotReq, didDial bool
  362. ts := newServerTester(t,
  363. func(w http.ResponseWriter, r *http.Request) {
  364. mu.Lock()
  365. gotReq = true
  366. mu.Unlock()
  367. },
  368. optOnlyServer,
  369. )
  370. defer ts.Close()
  371. tr := &Transport{
  372. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  373. mu.Lock()
  374. didDial = true
  375. mu.Unlock()
  376. cfg.InsecureSkipVerify = true
  377. c, err := tls.Dial(netw, addr, cfg)
  378. if err != nil {
  379. return nil, err
  380. }
  381. return c, c.Handshake()
  382. },
  383. }
  384. defer tr.CloseIdleConnections()
  385. client := &http.Client{Transport: tr}
  386. res, err := client.Get(ts.ts.URL)
  387. if err != nil {
  388. t.Fatal(err)
  389. }
  390. res.Body.Close()
  391. mu.Lock()
  392. if !gotReq {
  393. t.Error("didn't get request")
  394. }
  395. if !didDial {
  396. t.Error("didn't use dial hook")
  397. }
  398. }
  399. func TestConfigureTransport(t *testing.T) {
  400. t1 := &http.Transport{}
  401. err := ConfigureTransport(t1)
  402. if err == errTransportVersion {
  403. t.Skip(err)
  404. }
  405. if err != nil {
  406. t.Fatal(err)
  407. }
  408. if got := fmt.Sprintf("%#v", *t1); !strings.Contains(got, `"h2"`) {
  409. // Laziness, to avoid buildtags.
  410. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  411. }
  412. wantNextProtos := []string{"h2", "http/1.1"}
  413. if t1.TLSClientConfig == nil {
  414. t.Errorf("nil t1.TLSClientConfig")
  415. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  416. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  417. }
  418. if err := ConfigureTransport(t1); err == nil {
  419. t.Error("unexpected success on second call to ConfigureTransport")
  420. }
  421. // And does it work?
  422. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  423. io.WriteString(w, r.Proto)
  424. }, optOnlyServer)
  425. defer st.Close()
  426. t1.TLSClientConfig.InsecureSkipVerify = true
  427. c := &http.Client{Transport: t1}
  428. res, err := c.Get(st.ts.URL)
  429. if err != nil {
  430. t.Fatal(err)
  431. }
  432. slurp, err := ioutil.ReadAll(res.Body)
  433. if err != nil {
  434. t.Fatal(err)
  435. }
  436. if got, want := string(slurp), "HTTP/2.0"; got != want {
  437. t.Errorf("body = %q; want %q", got, want)
  438. }
  439. }
  440. type capitalizeReader struct {
  441. r io.Reader
  442. }
  443. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  444. n, err = cr.r.Read(p)
  445. for i, b := range p[:n] {
  446. if b >= 'a' && b <= 'z' {
  447. p[i] = b - ('a' - 'A')
  448. }
  449. }
  450. return
  451. }
  452. type flushWriter struct {
  453. w io.Writer
  454. }
  455. func (fw flushWriter) Write(p []byte) (n int, err error) {
  456. n, err = fw.w.Write(p)
  457. if f, ok := fw.w.(http.Flusher); ok {
  458. f.Flush()
  459. }
  460. return
  461. }
  462. type clientTester struct {
  463. t *testing.T
  464. tr *Transport
  465. sc, cc net.Conn // server and client conn
  466. fr *Framer // server's framer
  467. client func() error
  468. server func() error
  469. }
  470. func newClientTester(t *testing.T) *clientTester {
  471. var dialOnce struct {
  472. sync.Mutex
  473. dialed bool
  474. }
  475. ct := &clientTester{
  476. t: t,
  477. }
  478. ct.tr = &Transport{
  479. TLSClientConfig: tlsConfigInsecure,
  480. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  481. dialOnce.Lock()
  482. defer dialOnce.Unlock()
  483. if dialOnce.dialed {
  484. return nil, errors.New("only one dial allowed in test mode")
  485. }
  486. dialOnce.dialed = true
  487. return ct.cc, nil
  488. },
  489. }
  490. ln := newLocalListener(t)
  491. cc, err := net.Dial("tcp", ln.Addr().String())
  492. if err != nil {
  493. t.Fatal(err)
  494. }
  495. sc, err := ln.Accept()
  496. if err != nil {
  497. t.Fatal(err)
  498. }
  499. ln.Close()
  500. ct.cc = cc
  501. ct.sc = sc
  502. ct.fr = NewFramer(sc, sc)
  503. return ct
  504. }
  505. func newLocalListener(t *testing.T) net.Listener {
  506. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  507. if err == nil {
  508. return ln
  509. }
  510. ln, err = net.Listen("tcp6", "[::1]:0")
  511. if err != nil {
  512. t.Fatal(err)
  513. }
  514. return ln
  515. }
  516. func (ct *clientTester) greet() {
  517. buf := make([]byte, len(ClientPreface))
  518. _, err := io.ReadFull(ct.sc, buf)
  519. if err != nil {
  520. ct.t.Fatalf("reading client preface: %v", err)
  521. }
  522. f, err := ct.fr.ReadFrame()
  523. if err != nil {
  524. ct.t.Fatalf("Reading client settings frame: %v", err)
  525. }
  526. if sf, ok := f.(*SettingsFrame); !ok {
  527. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  528. _ = sf // stash it away?
  529. }
  530. if err := ct.fr.WriteSettings(); err != nil {
  531. ct.t.Fatal(err)
  532. }
  533. if err := ct.fr.WriteSettingsAck(); err != nil {
  534. ct.t.Fatal(err)
  535. }
  536. }
  537. func (ct *clientTester) cleanup() {
  538. ct.tr.CloseIdleConnections()
  539. }
  540. func (ct *clientTester) run() {
  541. errc := make(chan error, 2)
  542. ct.start("client", errc, ct.client)
  543. ct.start("server", errc, ct.server)
  544. defer ct.cleanup()
  545. for i := 0; i < 2; i++ {
  546. if err := <-errc; err != nil {
  547. ct.t.Error(err)
  548. return
  549. }
  550. }
  551. }
  552. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  553. go func() {
  554. finished := false
  555. var err error
  556. defer func() {
  557. if !finished {
  558. err = fmt.Errorf("%s goroutine didn't finish.", which)
  559. } else if err != nil {
  560. err = fmt.Errorf("%s: %v", which, err)
  561. }
  562. errc <- err
  563. }()
  564. err = fn()
  565. finished = true
  566. }()
  567. }
  568. type countingReader struct {
  569. n *int64
  570. }
  571. func (r countingReader) Read(p []byte) (n int, err error) {
  572. for i := range p {
  573. p[i] = byte(i)
  574. }
  575. atomic.AddInt64(r.n, int64(len(p)))
  576. return len(p), err
  577. }
  578. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  579. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  580. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  581. const bodySize = 10 << 20
  582. ct := newClientTester(t)
  583. ct.client = func() error {
  584. var n int64 // atomic
  585. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  586. if err != nil {
  587. return err
  588. }
  589. res, err := ct.tr.RoundTrip(req)
  590. if err != nil {
  591. return fmt.Errorf("RoundTrip: %v", err)
  592. }
  593. defer res.Body.Close()
  594. if res.StatusCode != status {
  595. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  596. }
  597. slurp, err := ioutil.ReadAll(res.Body)
  598. if err != nil {
  599. return fmt.Errorf("Slurp: %v", err)
  600. }
  601. if len(slurp) > 0 {
  602. return fmt.Errorf("unexpected body: %q", slurp)
  603. }
  604. if status == 200 {
  605. if got := atomic.LoadInt64(&n); got != bodySize {
  606. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  607. }
  608. } else {
  609. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  610. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  611. }
  612. }
  613. return nil
  614. }
  615. ct.server = func() error {
  616. ct.greet()
  617. var buf bytes.Buffer
  618. enc := hpack.NewEncoder(&buf)
  619. var dataRecv int64
  620. var closed bool
  621. for {
  622. f, err := ct.fr.ReadFrame()
  623. if err != nil {
  624. return err
  625. }
  626. //println(fmt.Sprintf("server got frame: %v", f))
  627. switch f := f.(type) {
  628. case *WindowUpdateFrame, *SettingsFrame:
  629. case *HeadersFrame:
  630. if !f.HeadersEnded() {
  631. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  632. }
  633. if f.StreamEnded() {
  634. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  635. }
  636. time.Sleep(50 * time.Millisecond) // let client send body
  637. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  638. ct.fr.WriteHeaders(HeadersFrameParam{
  639. StreamID: f.StreamID,
  640. EndHeaders: true,
  641. EndStream: false,
  642. BlockFragment: buf.Bytes(),
  643. })
  644. case *DataFrame:
  645. dataLen := len(f.Data())
  646. dataRecv += int64(dataLen)
  647. if dataLen > 0 {
  648. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  649. return err
  650. }
  651. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  652. return err
  653. }
  654. }
  655. if !closed && ((status != 200 && dataRecv > 0) ||
  656. (status == 200 && dataRecv == bodySize)) {
  657. closed = true
  658. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  659. return err
  660. }
  661. return nil
  662. }
  663. default:
  664. return fmt.Errorf("Unexpected client frame %v", f)
  665. }
  666. }
  667. return nil
  668. }
  669. ct.run()
  670. }
  671. // See golang.org/issue/13444
  672. func TestTransportFullDuplex(t *testing.T) {
  673. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  674. w.WriteHeader(200) // redundant but for clarity
  675. w.(http.Flusher).Flush()
  676. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  677. fmt.Fprintf(w, "bye.\n")
  678. }, optOnlyServer)
  679. defer st.Close()
  680. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  681. defer tr.CloseIdleConnections()
  682. c := &http.Client{Transport: tr}
  683. pr, pw := io.Pipe()
  684. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  685. if err != nil {
  686. log.Fatal(err)
  687. }
  688. res, err := c.Do(req)
  689. if err != nil {
  690. log.Fatal(err)
  691. }
  692. defer res.Body.Close()
  693. if res.StatusCode != 200 {
  694. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  695. }
  696. bs := bufio.NewScanner(res.Body)
  697. want := func(v string) {
  698. if !bs.Scan() {
  699. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  700. }
  701. }
  702. write := func(v string) {
  703. _, err := io.WriteString(pw, v)
  704. if err != nil {
  705. t.Fatalf("pipe write: %v", err)
  706. }
  707. }
  708. write("foo\n")
  709. want("FOO")
  710. write("bar\n")
  711. want("BAR")
  712. pw.Close()
  713. want("bye.")
  714. if err := bs.Err(); err != nil {
  715. t.Fatal(err)
  716. }
  717. }
  718. func TestTransportConnectRequest(t *testing.T) {
  719. gotc := make(chan *http.Request, 1)
  720. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  721. gotc <- r
  722. }, optOnlyServer)
  723. defer st.Close()
  724. u, err := url.Parse(st.ts.URL)
  725. if err != nil {
  726. t.Fatal(err)
  727. }
  728. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  729. defer tr.CloseIdleConnections()
  730. c := &http.Client{Transport: tr}
  731. tests := []struct {
  732. req *http.Request
  733. want string
  734. }{
  735. {
  736. req: &http.Request{
  737. Method: "CONNECT",
  738. Header: http.Header{},
  739. URL: u,
  740. },
  741. want: u.Host,
  742. },
  743. {
  744. req: &http.Request{
  745. Method: "CONNECT",
  746. Header: http.Header{},
  747. URL: u,
  748. Host: "example.com:123",
  749. },
  750. want: "example.com:123",
  751. },
  752. }
  753. for i, tt := range tests {
  754. res, err := c.Do(tt.req)
  755. if err != nil {
  756. t.Errorf("%d. RoundTrip = %v", i, err)
  757. continue
  758. }
  759. res.Body.Close()
  760. req := <-gotc
  761. if req.Method != "CONNECT" {
  762. t.Errorf("method = %q; want CONNECT", req.Method)
  763. }
  764. if req.Host != tt.want {
  765. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  766. }
  767. if req.URL.Host != tt.want {
  768. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  769. }
  770. }
  771. }
  772. type headerType int
  773. const (
  774. noHeader headerType = iota // omitted
  775. oneHeader
  776. splitHeader // broken into continuation on purpose
  777. )
  778. const (
  779. f0 = noHeader
  780. f1 = oneHeader
  781. f2 = splitHeader
  782. d0 = false
  783. d1 = true
  784. )
  785. // Test all 36 combinations of response frame orders:
  786. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  787. // Generated by http://play.golang.org/p/SScqYKJYXd
  788. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  789. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  790. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  791. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  792. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  793. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  794. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  795. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  796. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  797. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  798. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  799. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  800. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  801. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  802. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  803. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  804. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  805. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  806. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  807. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  808. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  809. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  810. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  811. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  812. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  813. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  814. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  815. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  816. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  817. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  818. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  819. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  820. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  821. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  822. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  823. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  824. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  825. const reqBody = "some request body"
  826. const resBody = "some response body"
  827. if resHeader == noHeader {
  828. // TODO: test 100-continue followed by immediate
  829. // server stream reset, without headers in the middle?
  830. panic("invalid combination")
  831. }
  832. ct := newClientTester(t)
  833. ct.client = func() error {
  834. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  835. if expect100Continue != noHeader {
  836. req.Header.Set("Expect", "100-continue")
  837. }
  838. res, err := ct.tr.RoundTrip(req)
  839. if err != nil {
  840. return fmt.Errorf("RoundTrip: %v", err)
  841. }
  842. defer res.Body.Close()
  843. if res.StatusCode != 200 {
  844. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  845. }
  846. slurp, err := ioutil.ReadAll(res.Body)
  847. if err != nil {
  848. return fmt.Errorf("Slurp: %v", err)
  849. }
  850. wantBody := resBody
  851. if !withData {
  852. wantBody = ""
  853. }
  854. if string(slurp) != wantBody {
  855. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  856. }
  857. if trailers == noHeader {
  858. if len(res.Trailer) > 0 {
  859. t.Errorf("Trailer = %v; want none", res.Trailer)
  860. }
  861. } else {
  862. want := http.Header{"Some-Trailer": {"some-value"}}
  863. if !reflect.DeepEqual(res.Trailer, want) {
  864. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  865. }
  866. }
  867. return nil
  868. }
  869. ct.server = func() error {
  870. ct.greet()
  871. var buf bytes.Buffer
  872. enc := hpack.NewEncoder(&buf)
  873. for {
  874. f, err := ct.fr.ReadFrame()
  875. if err != nil {
  876. return err
  877. }
  878. switch f := f.(type) {
  879. case *WindowUpdateFrame, *SettingsFrame:
  880. case *DataFrame:
  881. // ignore for now.
  882. case *HeadersFrame:
  883. endStream := false
  884. send := func(mode headerType) {
  885. hbf := buf.Bytes()
  886. switch mode {
  887. case oneHeader:
  888. ct.fr.WriteHeaders(HeadersFrameParam{
  889. StreamID: f.StreamID,
  890. EndHeaders: true,
  891. EndStream: endStream,
  892. BlockFragment: hbf,
  893. })
  894. case splitHeader:
  895. if len(hbf) < 2 {
  896. panic("too small")
  897. }
  898. ct.fr.WriteHeaders(HeadersFrameParam{
  899. StreamID: f.StreamID,
  900. EndHeaders: false,
  901. EndStream: endStream,
  902. BlockFragment: hbf[:1],
  903. })
  904. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  905. default:
  906. panic("bogus mode")
  907. }
  908. }
  909. if expect100Continue != noHeader {
  910. buf.Reset()
  911. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  912. send(expect100Continue)
  913. }
  914. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  915. {
  916. buf.Reset()
  917. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  918. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  919. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  920. if trailers != noHeader {
  921. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  922. }
  923. endStream = withData == false && trailers == noHeader
  924. send(resHeader)
  925. }
  926. if withData {
  927. endStream = trailers == noHeader
  928. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  929. }
  930. if trailers != noHeader {
  931. endStream = true
  932. buf.Reset()
  933. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  934. send(trailers)
  935. }
  936. return nil
  937. }
  938. }
  939. }
  940. ct.run()
  941. }
  942. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  943. ct := newClientTester(t)
  944. ct.client = func() error {
  945. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  946. res, err := ct.tr.RoundTrip(req)
  947. if err != nil {
  948. return fmt.Errorf("RoundTrip: %v", err)
  949. }
  950. defer res.Body.Close()
  951. if res.StatusCode != 200 {
  952. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  953. }
  954. slurp, err := ioutil.ReadAll(res.Body)
  955. if err != nil {
  956. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  957. }
  958. if len(slurp) > 0 {
  959. return fmt.Errorf("body = %q; want nothing", slurp)
  960. }
  961. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  962. return fmt.Errorf("expected Some-Trailer")
  963. }
  964. return nil
  965. }
  966. ct.server = func() error {
  967. ct.greet()
  968. var n int
  969. var hf *HeadersFrame
  970. for hf == nil && n < 10 {
  971. f, err := ct.fr.ReadFrame()
  972. if err != nil {
  973. return err
  974. }
  975. hf, _ = f.(*HeadersFrame)
  976. n++
  977. }
  978. var buf bytes.Buffer
  979. enc := hpack.NewEncoder(&buf)
  980. // send headers without Trailer header
  981. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  982. ct.fr.WriteHeaders(HeadersFrameParam{
  983. StreamID: hf.StreamID,
  984. EndHeaders: true,
  985. EndStream: false,
  986. BlockFragment: buf.Bytes(),
  987. })
  988. // send trailers
  989. buf.Reset()
  990. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  991. ct.fr.WriteHeaders(HeadersFrameParam{
  992. StreamID: hf.StreamID,
  993. EndHeaders: true,
  994. EndStream: true,
  995. BlockFragment: buf.Bytes(),
  996. })
  997. return nil
  998. }
  999. ct.run()
  1000. }
  1001. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1002. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1003. }
  1004. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1005. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1006. }
  1007. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1008. testInvalidTrailer(t, trailers, errPseudoTrailers, func(enc *hpack.Encoder) {
  1009. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1010. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1011. })
  1012. }
  1013. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1014. testTransportInvalidTrailer_Capital(t, oneHeader)
  1015. }
  1016. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1017. testTransportInvalidTrailer_Capital(t, splitHeader)
  1018. }
  1019. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1020. testInvalidTrailer(t, trailers, errInvalidHeaderKey, func(enc *hpack.Encoder) {
  1021. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1022. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1023. })
  1024. }
  1025. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1026. ct := newClientTester(t)
  1027. ct.client = func() error {
  1028. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1029. res, err := ct.tr.RoundTrip(req)
  1030. if err != nil {
  1031. return fmt.Errorf("RoundTrip: %v", err)
  1032. }
  1033. defer res.Body.Close()
  1034. if res.StatusCode != 200 {
  1035. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1036. }
  1037. slurp, err := ioutil.ReadAll(res.Body)
  1038. if err != wantErr {
  1039. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, wantErr)
  1040. }
  1041. if len(slurp) > 0 {
  1042. return fmt.Errorf("body = %q; want nothing", slurp)
  1043. }
  1044. return nil
  1045. }
  1046. ct.server = func() error {
  1047. ct.greet()
  1048. var buf bytes.Buffer
  1049. enc := hpack.NewEncoder(&buf)
  1050. for {
  1051. f, err := ct.fr.ReadFrame()
  1052. if err != nil {
  1053. return err
  1054. }
  1055. switch f := f.(type) {
  1056. case *HeadersFrame:
  1057. var endStream bool
  1058. send := func(mode headerType) {
  1059. hbf := buf.Bytes()
  1060. switch mode {
  1061. case oneHeader:
  1062. ct.fr.WriteHeaders(HeadersFrameParam{
  1063. StreamID: f.StreamID,
  1064. EndHeaders: true,
  1065. EndStream: endStream,
  1066. BlockFragment: hbf,
  1067. })
  1068. case splitHeader:
  1069. if len(hbf) < 2 {
  1070. panic("too small")
  1071. }
  1072. ct.fr.WriteHeaders(HeadersFrameParam{
  1073. StreamID: f.StreamID,
  1074. EndHeaders: false,
  1075. EndStream: endStream,
  1076. BlockFragment: hbf[:1],
  1077. })
  1078. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1079. default:
  1080. panic("bogus mode")
  1081. }
  1082. }
  1083. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1084. {
  1085. buf.Reset()
  1086. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1087. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1088. endStream = false
  1089. send(oneHeader)
  1090. }
  1091. // Trailers:
  1092. {
  1093. endStream = true
  1094. buf.Reset()
  1095. writeTrailer(enc)
  1096. send(trailers)
  1097. }
  1098. return nil
  1099. }
  1100. }
  1101. }
  1102. ct.run()
  1103. }
  1104. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1105. ct := newClientTester(t)
  1106. ct.client = func() error {
  1107. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1108. res, err := ct.tr.RoundTrip(req)
  1109. if err != errResponseHeaderListSize {
  1110. if res != nil {
  1111. res.Body.Close()
  1112. }
  1113. size := int64(0)
  1114. for k, vv := range res.Header {
  1115. for _, v := range vv {
  1116. size += int64(len(k)) + int64(len(v)) + 32
  1117. }
  1118. }
  1119. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1120. }
  1121. return nil
  1122. }
  1123. ct.server = func() error {
  1124. ct.greet()
  1125. var buf bytes.Buffer
  1126. enc := hpack.NewEncoder(&buf)
  1127. for {
  1128. f, err := ct.fr.ReadFrame()
  1129. if err != nil {
  1130. return err
  1131. }
  1132. switch f := f.(type) {
  1133. case *HeadersFrame:
  1134. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1135. large := strings.Repeat("a", 1<<10)
  1136. for i := 0; i < 5042; i++ {
  1137. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1138. }
  1139. if size, want := buf.Len(), 6329; size != want {
  1140. // Note: this number might change if
  1141. // our hpack implementation
  1142. // changes. That's fine. This is
  1143. // just a sanity check that our
  1144. // response can fit in a single
  1145. // header block fragment frame.
  1146. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1147. }
  1148. ct.fr.WriteHeaders(HeadersFrameParam{
  1149. StreamID: f.StreamID,
  1150. EndHeaders: true,
  1151. EndStream: true,
  1152. BlockFragment: buf.Bytes(),
  1153. })
  1154. return nil
  1155. }
  1156. }
  1157. }
  1158. ct.run()
  1159. }
  1160. // Test that the the Transport returns a typed error from Response.Body.Read calls
  1161. // when the server sends an error. (here we use a panic, since that should generate
  1162. // a stream error, but others like cancel should be similar)
  1163. func TestTransportBodyReadErrorType(t *testing.T) {
  1164. doPanic := make(chan bool, 1)
  1165. st := newServerTester(t,
  1166. func(w http.ResponseWriter, r *http.Request) {
  1167. w.(http.Flusher).Flush() // force headers out
  1168. <-doPanic
  1169. panic("boom")
  1170. },
  1171. optOnlyServer,
  1172. optQuiet,
  1173. )
  1174. defer st.Close()
  1175. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1176. defer tr.CloseIdleConnections()
  1177. c := &http.Client{Transport: tr}
  1178. res, err := c.Get(st.ts.URL)
  1179. if err != nil {
  1180. t.Fatal(err)
  1181. }
  1182. defer res.Body.Close()
  1183. doPanic <- true
  1184. buf := make([]byte, 100)
  1185. n, err := res.Body.Read(buf)
  1186. want := StreamError{StreamID: 0x1, Code: 0x2}
  1187. if !reflect.DeepEqual(want, err) {
  1188. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1189. }
  1190. }
  1191. // golang.org/issue/13924
  1192. // This used to fail after many iterations, especially with -race:
  1193. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1194. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1195. var (
  1196. mu sync.Mutex
  1197. conn net.Conn // to close if set
  1198. )
  1199. st := newServerTester(t,
  1200. func(w http.ResponseWriter, r *http.Request) {
  1201. mu.Lock()
  1202. defer mu.Unlock()
  1203. if conn != nil {
  1204. conn.Close()
  1205. }
  1206. },
  1207. optOnlyServer,
  1208. )
  1209. defer st.Close()
  1210. tr := &Transport{
  1211. TLSClientConfig: tlsConfigInsecure,
  1212. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1213. tc, err := tls.Dial(network, addr, cfg)
  1214. if err != nil {
  1215. return nil, err
  1216. }
  1217. mu.Lock()
  1218. defer mu.Unlock()
  1219. conn = tc
  1220. return tc, nil
  1221. },
  1222. }
  1223. defer tr.CloseIdleConnections()
  1224. c := &http.Client{Transport: tr}
  1225. c.Get(st.ts.URL)
  1226. }