transport_test.go 108 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "math/rand"
  16. "net"
  17. "net/http"
  18. "net/http/httptest"
  19. "net/textproto"
  20. "net/url"
  21. "os"
  22. "reflect"
  23. "runtime"
  24. "sort"
  25. "strconv"
  26. "strings"
  27. "sync"
  28. "sync/atomic"
  29. "testing"
  30. "time"
  31. "golang.org/x/net/context"
  32. "golang.org/x/net/http2/hpack"
  33. )
  34. var (
  35. extNet = flag.Bool("extnet", false, "do external network tests")
  36. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  37. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  38. )
  39. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  40. var canceledCtx context.Context
  41. func init() {
  42. ctx, cancel := context.WithCancel(context.Background())
  43. cancel()
  44. canceledCtx = ctx
  45. }
  46. func TestTransportExternal(t *testing.T) {
  47. if !*extNet {
  48. t.Skip("skipping external network test")
  49. }
  50. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  51. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  52. res, err := rt.RoundTrip(req)
  53. if err != nil {
  54. t.Fatalf("%v", err)
  55. }
  56. res.Write(os.Stdout)
  57. }
  58. type fakeTLSConn struct {
  59. net.Conn
  60. }
  61. func (c *fakeTLSConn) ConnectionState() tls.ConnectionState {
  62. return tls.ConnectionState{
  63. Version: tls.VersionTLS12,
  64. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  65. }
  66. }
  67. func startH2cServer(t *testing.T) net.Listener {
  68. h2Server := &Server{}
  69. l := newLocalListener(t)
  70. go func() {
  71. conn, err := l.Accept()
  72. if err != nil {
  73. t.Error(err)
  74. return
  75. }
  76. h2Server.ServeConn(&fakeTLSConn{conn}, &ServeConnOpts{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  77. fmt.Fprintf(w, "Hello, %v, http: %v", r.URL.Path, r.TLS == nil)
  78. })})
  79. }()
  80. return l
  81. }
  82. func TestTransportH2c(t *testing.T) {
  83. l := startH2cServer(t)
  84. defer l.Close()
  85. req, err := http.NewRequest("GET", "http://"+l.Addr().String()+"/foobar", nil)
  86. if err != nil {
  87. t.Fatal(err)
  88. }
  89. tr := &Transport{
  90. AllowHTTP: true,
  91. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  92. return net.Dial(network, addr)
  93. },
  94. }
  95. res, err := tr.RoundTrip(req)
  96. if err != nil {
  97. t.Fatal(err)
  98. }
  99. if res.ProtoMajor != 2 {
  100. t.Fatal("proto not h2c")
  101. }
  102. body, err := ioutil.ReadAll(res.Body)
  103. if err != nil {
  104. t.Fatal(err)
  105. }
  106. if got, want := string(body), "Hello, /foobar, http: true"; got != want {
  107. t.Fatalf("response got %v, want %v", got, want)
  108. }
  109. }
  110. func TestTransport(t *testing.T) {
  111. const body = "sup"
  112. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  113. io.WriteString(w, body)
  114. }, optOnlyServer)
  115. defer st.Close()
  116. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  117. defer tr.CloseIdleConnections()
  118. req, err := http.NewRequest("GET", st.ts.URL, nil)
  119. if err != nil {
  120. t.Fatal(err)
  121. }
  122. res, err := tr.RoundTrip(req)
  123. if err != nil {
  124. t.Fatal(err)
  125. }
  126. defer res.Body.Close()
  127. t.Logf("Got res: %+v", res)
  128. if g, w := res.StatusCode, 200; g != w {
  129. t.Errorf("StatusCode = %v; want %v", g, w)
  130. }
  131. if g, w := res.Status, "200 OK"; g != w {
  132. t.Errorf("Status = %q; want %q", g, w)
  133. }
  134. wantHeader := http.Header{
  135. "Content-Length": []string{"3"},
  136. "Content-Type": []string{"text/plain; charset=utf-8"},
  137. "Date": []string{"XXX"}, // see cleanDate
  138. }
  139. cleanDate(res)
  140. if !reflect.DeepEqual(res.Header, wantHeader) {
  141. t.Errorf("res Header = %v; want %v", res.Header, wantHeader)
  142. }
  143. if res.Request != req {
  144. t.Errorf("Response.Request = %p; want %p", res.Request, req)
  145. }
  146. if res.TLS == nil {
  147. t.Error("Response.TLS = nil; want non-nil")
  148. }
  149. slurp, err := ioutil.ReadAll(res.Body)
  150. if err != nil {
  151. t.Errorf("Body read: %v", err)
  152. } else if string(slurp) != body {
  153. t.Errorf("Body = %q; want %q", slurp, body)
  154. }
  155. }
  156. func onSameConn(t *testing.T, modReq func(*http.Request)) bool {
  157. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  158. io.WriteString(w, r.RemoteAddr)
  159. }, optOnlyServer, func(c net.Conn, st http.ConnState) {
  160. t.Logf("conn %v is now state %v", c.RemoteAddr(), st)
  161. })
  162. defer st.Close()
  163. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  164. defer tr.CloseIdleConnections()
  165. get := func() string {
  166. req, err := http.NewRequest("GET", st.ts.URL, nil)
  167. if err != nil {
  168. t.Fatal(err)
  169. }
  170. modReq(req)
  171. res, err := tr.RoundTrip(req)
  172. if err != nil {
  173. t.Fatal(err)
  174. }
  175. defer res.Body.Close()
  176. slurp, err := ioutil.ReadAll(res.Body)
  177. if err != nil {
  178. t.Fatalf("Body read: %v", err)
  179. }
  180. addr := strings.TrimSpace(string(slurp))
  181. if addr == "" {
  182. t.Fatalf("didn't get an addr in response")
  183. }
  184. return addr
  185. }
  186. first := get()
  187. second := get()
  188. return first == second
  189. }
  190. func TestTransportReusesConns(t *testing.T) {
  191. if !onSameConn(t, func(*http.Request) {}) {
  192. t.Errorf("first and second responses were on different connections")
  193. }
  194. }
  195. func TestTransportReusesConn_RequestClose(t *testing.T) {
  196. if onSameConn(t, func(r *http.Request) { r.Close = true }) {
  197. t.Errorf("first and second responses were not on different connections")
  198. }
  199. }
  200. func TestTransportReusesConn_ConnClose(t *testing.T) {
  201. if onSameConn(t, func(r *http.Request) { r.Header.Set("Connection", "close") }) {
  202. t.Errorf("first and second responses were not on different connections")
  203. }
  204. }
  205. // Tests that the Transport only keeps one pending dial open per destination address.
  206. // https://golang.org/issue/13397
  207. func TestTransportGroupsPendingDials(t *testing.T) {
  208. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  209. io.WriteString(w, r.RemoteAddr)
  210. }, optOnlyServer)
  211. defer st.Close()
  212. tr := &Transport{
  213. TLSClientConfig: tlsConfigInsecure,
  214. }
  215. defer tr.CloseIdleConnections()
  216. var (
  217. mu sync.Mutex
  218. dials = map[string]int{}
  219. )
  220. var wg sync.WaitGroup
  221. for i := 0; i < 10; i++ {
  222. wg.Add(1)
  223. go func() {
  224. defer wg.Done()
  225. req, err := http.NewRequest("GET", st.ts.URL, nil)
  226. if err != nil {
  227. t.Error(err)
  228. return
  229. }
  230. res, err := tr.RoundTrip(req)
  231. if err != nil {
  232. t.Error(err)
  233. return
  234. }
  235. defer res.Body.Close()
  236. slurp, err := ioutil.ReadAll(res.Body)
  237. if err != nil {
  238. t.Errorf("Body read: %v", err)
  239. }
  240. addr := strings.TrimSpace(string(slurp))
  241. if addr == "" {
  242. t.Errorf("didn't get an addr in response")
  243. }
  244. mu.Lock()
  245. dials[addr]++
  246. mu.Unlock()
  247. }()
  248. }
  249. wg.Wait()
  250. if len(dials) != 1 {
  251. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  252. }
  253. tr.CloseIdleConnections()
  254. if err := retry(50, 10*time.Millisecond, func() error {
  255. cp, ok := tr.connPool().(*clientConnPool)
  256. if !ok {
  257. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  258. }
  259. cp.mu.Lock()
  260. defer cp.mu.Unlock()
  261. if len(cp.dialing) != 0 {
  262. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  263. }
  264. if len(cp.conns) != 0 {
  265. return fmt.Errorf("conns = %v; want empty", cp.conns)
  266. }
  267. if len(cp.keys) != 0 {
  268. return fmt.Errorf("keys = %v; want empty", cp.keys)
  269. }
  270. return nil
  271. }); err != nil {
  272. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  273. }
  274. }
  275. func retry(tries int, delay time.Duration, fn func() error) error {
  276. var err error
  277. for i := 0; i < tries; i++ {
  278. err = fn()
  279. if err == nil {
  280. return nil
  281. }
  282. time.Sleep(delay)
  283. }
  284. return err
  285. }
  286. func TestTransportAbortClosesPipes(t *testing.T) {
  287. shutdown := make(chan struct{})
  288. st := newServerTester(t,
  289. func(w http.ResponseWriter, r *http.Request) {
  290. w.(http.Flusher).Flush()
  291. <-shutdown
  292. },
  293. optOnlyServer,
  294. )
  295. defer st.Close()
  296. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  297. done := make(chan struct{})
  298. requestMade := make(chan struct{})
  299. go func() {
  300. defer close(done)
  301. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  302. req, err := http.NewRequest("GET", st.ts.URL, nil)
  303. if err != nil {
  304. t.Fatal(err)
  305. }
  306. res, err := tr.RoundTrip(req)
  307. if err != nil {
  308. t.Fatal(err)
  309. }
  310. defer res.Body.Close()
  311. close(requestMade)
  312. _, err = ioutil.ReadAll(res.Body)
  313. if err == nil {
  314. t.Error("expected error from res.Body.Read")
  315. }
  316. }()
  317. <-requestMade
  318. // Now force the serve loop to end, via closing the connection.
  319. st.closeConn()
  320. // deadlock? that's a bug.
  321. select {
  322. case <-done:
  323. case <-time.After(3 * time.Second):
  324. t.Fatal("timeout")
  325. }
  326. }
  327. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  328. // could be a table-driven test with extra goodies.
  329. func TestTransportPath(t *testing.T) {
  330. gotc := make(chan *url.URL, 1)
  331. st := newServerTester(t,
  332. func(w http.ResponseWriter, r *http.Request) {
  333. gotc <- r.URL
  334. },
  335. optOnlyServer,
  336. )
  337. defer st.Close()
  338. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  339. defer tr.CloseIdleConnections()
  340. const (
  341. path = "/testpath"
  342. query = "q=1"
  343. )
  344. surl := st.ts.URL + path + "?" + query
  345. req, err := http.NewRequest("POST", surl, nil)
  346. if err != nil {
  347. t.Fatal(err)
  348. }
  349. c := &http.Client{Transport: tr}
  350. res, err := c.Do(req)
  351. if err != nil {
  352. t.Fatal(err)
  353. }
  354. defer res.Body.Close()
  355. got := <-gotc
  356. if got.Path != path {
  357. t.Errorf("Read Path = %q; want %q", got.Path, path)
  358. }
  359. if got.RawQuery != query {
  360. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  361. }
  362. }
  363. func randString(n int) string {
  364. rnd := rand.New(rand.NewSource(int64(n)))
  365. b := make([]byte, n)
  366. for i := range b {
  367. b[i] = byte(rnd.Intn(256))
  368. }
  369. return string(b)
  370. }
  371. type panicReader struct{}
  372. func (panicReader) Read([]byte) (int, error) { panic("unexpected Read") }
  373. func (panicReader) Close() error { panic("unexpected Close") }
  374. func TestActualContentLength(t *testing.T) {
  375. tests := []struct {
  376. req *http.Request
  377. want int64
  378. }{
  379. // Verify we don't read from Body:
  380. 0: {
  381. req: &http.Request{Body: panicReader{}},
  382. want: -1,
  383. },
  384. // nil Body means 0, regardless of ContentLength:
  385. 1: {
  386. req: &http.Request{Body: nil, ContentLength: 5},
  387. want: 0,
  388. },
  389. // ContentLength is used if set.
  390. 2: {
  391. req: &http.Request{Body: panicReader{}, ContentLength: 5},
  392. want: 5,
  393. },
  394. // http.NoBody means 0, not -1.
  395. 3: {
  396. req: &http.Request{Body: go18httpNoBody()},
  397. want: 0,
  398. },
  399. }
  400. for i, tt := range tests {
  401. got := actualContentLength(tt.req)
  402. if got != tt.want {
  403. t.Errorf("test[%d]: got %d; want %d", i, got, tt.want)
  404. }
  405. }
  406. }
  407. func TestTransportBody(t *testing.T) {
  408. bodyTests := []struct {
  409. body string
  410. noContentLen bool
  411. }{
  412. {body: "some message"},
  413. {body: "some message", noContentLen: true},
  414. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  415. {body: strings.Repeat("a", 1<<20)},
  416. {body: randString(16<<10 - 1)},
  417. {body: randString(16 << 10)},
  418. {body: randString(16<<10 + 1)},
  419. {body: randString(512<<10 - 1)},
  420. {body: randString(512 << 10)},
  421. {body: randString(512<<10 + 1)},
  422. {body: randString(1<<20 - 1)},
  423. {body: randString(1 << 20)},
  424. {body: randString(1<<20 + 2)},
  425. }
  426. type reqInfo struct {
  427. req *http.Request
  428. slurp []byte
  429. err error
  430. }
  431. gotc := make(chan reqInfo, 1)
  432. st := newServerTester(t,
  433. func(w http.ResponseWriter, r *http.Request) {
  434. slurp, err := ioutil.ReadAll(r.Body)
  435. if err != nil {
  436. gotc <- reqInfo{err: err}
  437. } else {
  438. gotc <- reqInfo{req: r, slurp: slurp}
  439. }
  440. },
  441. optOnlyServer,
  442. )
  443. defer st.Close()
  444. for i, tt := range bodyTests {
  445. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  446. defer tr.CloseIdleConnections()
  447. var body io.Reader = strings.NewReader(tt.body)
  448. if tt.noContentLen {
  449. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  450. }
  451. req, err := http.NewRequest("POST", st.ts.URL, body)
  452. if err != nil {
  453. t.Fatalf("#%d: %v", i, err)
  454. }
  455. c := &http.Client{Transport: tr}
  456. res, err := c.Do(req)
  457. if err != nil {
  458. t.Fatalf("#%d: %v", i, err)
  459. }
  460. defer res.Body.Close()
  461. ri := <-gotc
  462. if ri.err != nil {
  463. t.Errorf("#%d: read error: %v", i, ri.err)
  464. continue
  465. }
  466. if got := string(ri.slurp); got != tt.body {
  467. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  468. }
  469. wantLen := int64(len(tt.body))
  470. if tt.noContentLen && tt.body != "" {
  471. wantLen = -1
  472. }
  473. if ri.req.ContentLength != wantLen {
  474. t.Errorf("#%d. handler got ContentLength = %v; want %v", i, ri.req.ContentLength, wantLen)
  475. }
  476. }
  477. }
  478. func shortString(v string) string {
  479. const maxLen = 100
  480. if len(v) <= maxLen {
  481. return v
  482. }
  483. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  484. }
  485. func TestTransportDialTLS(t *testing.T) {
  486. var mu sync.Mutex // guards following
  487. var gotReq, didDial bool
  488. ts := newServerTester(t,
  489. func(w http.ResponseWriter, r *http.Request) {
  490. mu.Lock()
  491. gotReq = true
  492. mu.Unlock()
  493. },
  494. optOnlyServer,
  495. )
  496. defer ts.Close()
  497. tr := &Transport{
  498. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  499. mu.Lock()
  500. didDial = true
  501. mu.Unlock()
  502. cfg.InsecureSkipVerify = true
  503. c, err := tls.Dial(netw, addr, cfg)
  504. if err != nil {
  505. return nil, err
  506. }
  507. return c, c.Handshake()
  508. },
  509. }
  510. defer tr.CloseIdleConnections()
  511. client := &http.Client{Transport: tr}
  512. res, err := client.Get(ts.ts.URL)
  513. if err != nil {
  514. t.Fatal(err)
  515. }
  516. res.Body.Close()
  517. mu.Lock()
  518. if !gotReq {
  519. t.Error("didn't get request")
  520. }
  521. if !didDial {
  522. t.Error("didn't use dial hook")
  523. }
  524. }
  525. func TestConfigureTransport(t *testing.T) {
  526. t1 := &http.Transport{}
  527. err := ConfigureTransport(t1)
  528. if err == errTransportVersion {
  529. t.Skip(err)
  530. }
  531. if err != nil {
  532. t.Fatal(err)
  533. }
  534. if got := fmt.Sprintf("%#v", t1); !strings.Contains(got, `"h2"`) {
  535. // Laziness, to avoid buildtags.
  536. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  537. }
  538. wantNextProtos := []string{"h2", "http/1.1"}
  539. if t1.TLSClientConfig == nil {
  540. t.Errorf("nil t1.TLSClientConfig")
  541. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  542. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  543. }
  544. if err := ConfigureTransport(t1); err == nil {
  545. t.Error("unexpected success on second call to ConfigureTransport")
  546. }
  547. // And does it work?
  548. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  549. io.WriteString(w, r.Proto)
  550. }, optOnlyServer)
  551. defer st.Close()
  552. t1.TLSClientConfig.InsecureSkipVerify = true
  553. c := &http.Client{Transport: t1}
  554. res, err := c.Get(st.ts.URL)
  555. if err != nil {
  556. t.Fatal(err)
  557. }
  558. slurp, err := ioutil.ReadAll(res.Body)
  559. if err != nil {
  560. t.Fatal(err)
  561. }
  562. if got, want := string(slurp), "HTTP/2.0"; got != want {
  563. t.Errorf("body = %q; want %q", got, want)
  564. }
  565. }
  566. type capitalizeReader struct {
  567. r io.Reader
  568. }
  569. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  570. n, err = cr.r.Read(p)
  571. for i, b := range p[:n] {
  572. if b >= 'a' && b <= 'z' {
  573. p[i] = b - ('a' - 'A')
  574. }
  575. }
  576. return
  577. }
  578. type flushWriter struct {
  579. w io.Writer
  580. }
  581. func (fw flushWriter) Write(p []byte) (n int, err error) {
  582. n, err = fw.w.Write(p)
  583. if f, ok := fw.w.(http.Flusher); ok {
  584. f.Flush()
  585. }
  586. return
  587. }
  588. type clientTester struct {
  589. t *testing.T
  590. tr *Transport
  591. sc, cc net.Conn // server and client conn
  592. fr *Framer // server's framer
  593. client func() error
  594. server func() error
  595. }
  596. func newClientTester(t *testing.T) *clientTester {
  597. var dialOnce struct {
  598. sync.Mutex
  599. dialed bool
  600. }
  601. ct := &clientTester{
  602. t: t,
  603. }
  604. ct.tr = &Transport{
  605. TLSClientConfig: tlsConfigInsecure,
  606. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  607. dialOnce.Lock()
  608. defer dialOnce.Unlock()
  609. if dialOnce.dialed {
  610. return nil, errors.New("only one dial allowed in test mode")
  611. }
  612. dialOnce.dialed = true
  613. return ct.cc, nil
  614. },
  615. }
  616. ln := newLocalListener(t)
  617. cc, err := net.Dial("tcp", ln.Addr().String())
  618. if err != nil {
  619. t.Fatal(err)
  620. }
  621. sc, err := ln.Accept()
  622. if err != nil {
  623. t.Fatal(err)
  624. }
  625. ln.Close()
  626. ct.cc = cc
  627. ct.sc = sc
  628. ct.fr = NewFramer(sc, sc)
  629. return ct
  630. }
  631. func newLocalListener(t *testing.T) net.Listener {
  632. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  633. if err == nil {
  634. return ln
  635. }
  636. ln, err = net.Listen("tcp6", "[::1]:0")
  637. if err != nil {
  638. t.Fatal(err)
  639. }
  640. return ln
  641. }
  642. func (ct *clientTester) greet(settings ...Setting) {
  643. buf := make([]byte, len(ClientPreface))
  644. _, err := io.ReadFull(ct.sc, buf)
  645. if err != nil {
  646. ct.t.Fatalf("reading client preface: %v", err)
  647. }
  648. f, err := ct.fr.ReadFrame()
  649. if err != nil {
  650. ct.t.Fatalf("Reading client settings frame: %v", err)
  651. }
  652. if sf, ok := f.(*SettingsFrame); !ok {
  653. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  654. _ = sf // stash it away?
  655. }
  656. if err := ct.fr.WriteSettings(settings...); err != nil {
  657. ct.t.Fatal(err)
  658. }
  659. if err := ct.fr.WriteSettingsAck(); err != nil {
  660. ct.t.Fatal(err)
  661. }
  662. }
  663. func (ct *clientTester) readNonSettingsFrame() (Frame, error) {
  664. for {
  665. f, err := ct.fr.ReadFrame()
  666. if err != nil {
  667. return nil, err
  668. }
  669. if _, ok := f.(*SettingsFrame); ok {
  670. continue
  671. }
  672. return f, nil
  673. }
  674. }
  675. func (ct *clientTester) cleanup() {
  676. ct.tr.CloseIdleConnections()
  677. }
  678. func (ct *clientTester) run() {
  679. errc := make(chan error, 2)
  680. ct.start("client", errc, ct.client)
  681. ct.start("server", errc, ct.server)
  682. defer ct.cleanup()
  683. for i := 0; i < 2; i++ {
  684. if err := <-errc; err != nil {
  685. ct.t.Error(err)
  686. return
  687. }
  688. }
  689. }
  690. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  691. go func() {
  692. finished := false
  693. var err error
  694. defer func() {
  695. if !finished {
  696. err = fmt.Errorf("%s goroutine didn't finish.", which)
  697. } else if err != nil {
  698. err = fmt.Errorf("%s: %v", which, err)
  699. }
  700. errc <- err
  701. }()
  702. err = fn()
  703. finished = true
  704. }()
  705. }
  706. func (ct *clientTester) readFrame() (Frame, error) {
  707. return readFrameTimeout(ct.fr, 2*time.Second)
  708. }
  709. func (ct *clientTester) firstHeaders() (*HeadersFrame, error) {
  710. for {
  711. f, err := ct.readFrame()
  712. if err != nil {
  713. return nil, fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  714. }
  715. switch f.(type) {
  716. case *WindowUpdateFrame, *SettingsFrame:
  717. continue
  718. }
  719. hf, ok := f.(*HeadersFrame)
  720. if !ok {
  721. return nil, fmt.Errorf("Got %T; want HeadersFrame", f)
  722. }
  723. return hf, nil
  724. }
  725. }
  726. type countingReader struct {
  727. n *int64
  728. }
  729. func (r countingReader) Read(p []byte) (n int, err error) {
  730. for i := range p {
  731. p[i] = byte(i)
  732. }
  733. atomic.AddInt64(r.n, int64(len(p)))
  734. return len(p), err
  735. }
  736. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  737. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  738. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  739. const bodySize = 10 << 20
  740. clientDone := make(chan struct{})
  741. ct := newClientTester(t)
  742. ct.client = func() error {
  743. defer ct.cc.(*net.TCPConn).CloseWrite()
  744. defer close(clientDone)
  745. var n int64 // atomic
  746. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  747. if err != nil {
  748. return err
  749. }
  750. res, err := ct.tr.RoundTrip(req)
  751. if err != nil {
  752. return fmt.Errorf("RoundTrip: %v", err)
  753. }
  754. defer res.Body.Close()
  755. if res.StatusCode != status {
  756. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  757. }
  758. slurp, err := ioutil.ReadAll(res.Body)
  759. if err != nil {
  760. return fmt.Errorf("Slurp: %v", err)
  761. }
  762. if len(slurp) > 0 {
  763. return fmt.Errorf("unexpected body: %q", slurp)
  764. }
  765. if status == 200 {
  766. if got := atomic.LoadInt64(&n); got != bodySize {
  767. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  768. }
  769. } else {
  770. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  771. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  772. }
  773. }
  774. return nil
  775. }
  776. ct.server = func() error {
  777. ct.greet()
  778. var buf bytes.Buffer
  779. enc := hpack.NewEncoder(&buf)
  780. var dataRecv int64
  781. var closed bool
  782. for {
  783. f, err := ct.fr.ReadFrame()
  784. if err != nil {
  785. select {
  786. case <-clientDone:
  787. // If the client's done, it
  788. // will have reported any
  789. // errors on its side.
  790. return nil
  791. default:
  792. return err
  793. }
  794. }
  795. //println(fmt.Sprintf("server got frame: %v", f))
  796. switch f := f.(type) {
  797. case *WindowUpdateFrame, *SettingsFrame:
  798. case *HeadersFrame:
  799. if !f.HeadersEnded() {
  800. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  801. }
  802. if f.StreamEnded() {
  803. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  804. }
  805. case *DataFrame:
  806. dataLen := len(f.Data())
  807. if dataLen > 0 {
  808. if dataRecv == 0 {
  809. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  810. ct.fr.WriteHeaders(HeadersFrameParam{
  811. StreamID: f.StreamID,
  812. EndHeaders: true,
  813. EndStream: false,
  814. BlockFragment: buf.Bytes(),
  815. })
  816. }
  817. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  818. return err
  819. }
  820. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  821. return err
  822. }
  823. }
  824. dataRecv += int64(dataLen)
  825. if !closed && ((status != 200 && dataRecv > 0) ||
  826. (status == 200 && dataRecv == bodySize)) {
  827. closed = true
  828. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  829. return err
  830. }
  831. }
  832. default:
  833. return fmt.Errorf("Unexpected client frame %v", f)
  834. }
  835. }
  836. }
  837. ct.run()
  838. }
  839. // See golang.org/issue/13444
  840. func TestTransportFullDuplex(t *testing.T) {
  841. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  842. w.WriteHeader(200) // redundant but for clarity
  843. w.(http.Flusher).Flush()
  844. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  845. fmt.Fprintf(w, "bye.\n")
  846. }, optOnlyServer)
  847. defer st.Close()
  848. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  849. defer tr.CloseIdleConnections()
  850. c := &http.Client{Transport: tr}
  851. pr, pw := io.Pipe()
  852. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  853. if err != nil {
  854. t.Fatal(err)
  855. }
  856. req.ContentLength = -1
  857. res, err := c.Do(req)
  858. if err != nil {
  859. t.Fatal(err)
  860. }
  861. defer res.Body.Close()
  862. if res.StatusCode != 200 {
  863. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  864. }
  865. bs := bufio.NewScanner(res.Body)
  866. want := func(v string) {
  867. if !bs.Scan() {
  868. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  869. }
  870. }
  871. write := func(v string) {
  872. _, err := io.WriteString(pw, v)
  873. if err != nil {
  874. t.Fatalf("pipe write: %v", err)
  875. }
  876. }
  877. write("foo\n")
  878. want("FOO")
  879. write("bar\n")
  880. want("BAR")
  881. pw.Close()
  882. want("bye.")
  883. if err := bs.Err(); err != nil {
  884. t.Fatal(err)
  885. }
  886. }
  887. func TestTransportConnectRequest(t *testing.T) {
  888. gotc := make(chan *http.Request, 1)
  889. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  890. gotc <- r
  891. }, optOnlyServer)
  892. defer st.Close()
  893. u, err := url.Parse(st.ts.URL)
  894. if err != nil {
  895. t.Fatal(err)
  896. }
  897. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  898. defer tr.CloseIdleConnections()
  899. c := &http.Client{Transport: tr}
  900. tests := []struct {
  901. req *http.Request
  902. want string
  903. }{
  904. {
  905. req: &http.Request{
  906. Method: "CONNECT",
  907. Header: http.Header{},
  908. URL: u,
  909. },
  910. want: u.Host,
  911. },
  912. {
  913. req: &http.Request{
  914. Method: "CONNECT",
  915. Header: http.Header{},
  916. URL: u,
  917. Host: "example.com:123",
  918. },
  919. want: "example.com:123",
  920. },
  921. }
  922. for i, tt := range tests {
  923. res, err := c.Do(tt.req)
  924. if err != nil {
  925. t.Errorf("%d. RoundTrip = %v", i, err)
  926. continue
  927. }
  928. res.Body.Close()
  929. req := <-gotc
  930. if req.Method != "CONNECT" {
  931. t.Errorf("method = %q; want CONNECT", req.Method)
  932. }
  933. if req.Host != tt.want {
  934. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  935. }
  936. if req.URL.Host != tt.want {
  937. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  938. }
  939. }
  940. }
  941. type headerType int
  942. const (
  943. noHeader headerType = iota // omitted
  944. oneHeader
  945. splitHeader // broken into continuation on purpose
  946. )
  947. const (
  948. f0 = noHeader
  949. f1 = oneHeader
  950. f2 = splitHeader
  951. d0 = false
  952. d1 = true
  953. )
  954. // Test all 36 combinations of response frame orders:
  955. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  956. // Generated by http://play.golang.org/p/SScqYKJYXd
  957. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  958. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  959. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  960. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  961. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  962. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  963. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  964. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  965. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  966. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  967. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  968. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  969. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  970. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  971. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  972. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  973. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  974. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  975. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  976. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  977. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  978. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  979. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  980. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  981. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  982. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  983. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  984. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  985. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  986. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  987. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  988. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  989. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  990. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  991. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  992. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  993. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  994. const reqBody = "some request body"
  995. const resBody = "some response body"
  996. if resHeader == noHeader {
  997. // TODO: test 100-continue followed by immediate
  998. // server stream reset, without headers in the middle?
  999. panic("invalid combination")
  1000. }
  1001. ct := newClientTester(t)
  1002. ct.client = func() error {
  1003. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  1004. if expect100Continue != noHeader {
  1005. req.Header.Set("Expect", "100-continue")
  1006. }
  1007. res, err := ct.tr.RoundTrip(req)
  1008. if err != nil {
  1009. return fmt.Errorf("RoundTrip: %v", err)
  1010. }
  1011. defer res.Body.Close()
  1012. if res.StatusCode != 200 {
  1013. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1014. }
  1015. slurp, err := ioutil.ReadAll(res.Body)
  1016. if err != nil {
  1017. return fmt.Errorf("Slurp: %v", err)
  1018. }
  1019. wantBody := resBody
  1020. if !withData {
  1021. wantBody = ""
  1022. }
  1023. if string(slurp) != wantBody {
  1024. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  1025. }
  1026. if trailers == noHeader {
  1027. if len(res.Trailer) > 0 {
  1028. t.Errorf("Trailer = %v; want none", res.Trailer)
  1029. }
  1030. } else {
  1031. want := http.Header{"Some-Trailer": {"some-value"}}
  1032. if !reflect.DeepEqual(res.Trailer, want) {
  1033. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  1034. }
  1035. }
  1036. return nil
  1037. }
  1038. ct.server = func() error {
  1039. ct.greet()
  1040. var buf bytes.Buffer
  1041. enc := hpack.NewEncoder(&buf)
  1042. for {
  1043. f, err := ct.fr.ReadFrame()
  1044. if err != nil {
  1045. return err
  1046. }
  1047. endStream := false
  1048. send := func(mode headerType) {
  1049. hbf := buf.Bytes()
  1050. switch mode {
  1051. case oneHeader:
  1052. ct.fr.WriteHeaders(HeadersFrameParam{
  1053. StreamID: f.Header().StreamID,
  1054. EndHeaders: true,
  1055. EndStream: endStream,
  1056. BlockFragment: hbf,
  1057. })
  1058. case splitHeader:
  1059. if len(hbf) < 2 {
  1060. panic("too small")
  1061. }
  1062. ct.fr.WriteHeaders(HeadersFrameParam{
  1063. StreamID: f.Header().StreamID,
  1064. EndHeaders: false,
  1065. EndStream: endStream,
  1066. BlockFragment: hbf[:1],
  1067. })
  1068. ct.fr.WriteContinuation(f.Header().StreamID, true, hbf[1:])
  1069. default:
  1070. panic("bogus mode")
  1071. }
  1072. }
  1073. switch f := f.(type) {
  1074. case *WindowUpdateFrame, *SettingsFrame:
  1075. case *DataFrame:
  1076. if !f.StreamEnded() {
  1077. // No need to send flow control tokens. The test request body is tiny.
  1078. continue
  1079. }
  1080. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1081. {
  1082. buf.Reset()
  1083. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1084. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  1085. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  1086. if trailers != noHeader {
  1087. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  1088. }
  1089. endStream = withData == false && trailers == noHeader
  1090. send(resHeader)
  1091. }
  1092. if withData {
  1093. endStream = trailers == noHeader
  1094. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  1095. }
  1096. if trailers != noHeader {
  1097. endStream = true
  1098. buf.Reset()
  1099. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  1100. send(trailers)
  1101. }
  1102. if endStream {
  1103. return nil
  1104. }
  1105. case *HeadersFrame:
  1106. if expect100Continue != noHeader {
  1107. buf.Reset()
  1108. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  1109. send(expect100Continue)
  1110. }
  1111. }
  1112. }
  1113. }
  1114. ct.run()
  1115. }
  1116. // Issue 26189, Issue 17739: ignore unknown 1xx responses
  1117. func TestTransportUnknown1xx(t *testing.T) {
  1118. var buf bytes.Buffer
  1119. defer func() { got1xxFuncForTests = nil }()
  1120. got1xxFuncForTests = func(code int, header textproto.MIMEHeader) error {
  1121. fmt.Fprintf(&buf, "code=%d header=%v\n", code, header)
  1122. return nil
  1123. }
  1124. ct := newClientTester(t)
  1125. ct.client = func() error {
  1126. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1127. res, err := ct.tr.RoundTrip(req)
  1128. if err != nil {
  1129. return fmt.Errorf("RoundTrip: %v", err)
  1130. }
  1131. defer res.Body.Close()
  1132. if res.StatusCode != 204 {
  1133. return fmt.Errorf("status code = %v; want 204", res.StatusCode)
  1134. }
  1135. want := `code=110 header=map[Foo-Bar:[110]]
  1136. code=111 header=map[Foo-Bar:[111]]
  1137. code=112 header=map[Foo-Bar:[112]]
  1138. code=113 header=map[Foo-Bar:[113]]
  1139. code=114 header=map[Foo-Bar:[114]]
  1140. `
  1141. if got := buf.String(); got != want {
  1142. t.Errorf("Got trace:\n%s\nWant:\n%s", got, want)
  1143. }
  1144. return nil
  1145. }
  1146. ct.server = func() error {
  1147. ct.greet()
  1148. var buf bytes.Buffer
  1149. enc := hpack.NewEncoder(&buf)
  1150. for {
  1151. f, err := ct.fr.ReadFrame()
  1152. if err != nil {
  1153. return err
  1154. }
  1155. switch f := f.(type) {
  1156. case *WindowUpdateFrame, *SettingsFrame:
  1157. case *HeadersFrame:
  1158. for i := 110; i <= 114; i++ {
  1159. buf.Reset()
  1160. enc.WriteField(hpack.HeaderField{Name: ":status", Value: fmt.Sprint(i)})
  1161. enc.WriteField(hpack.HeaderField{Name: "foo-bar", Value: fmt.Sprint(i)})
  1162. ct.fr.WriteHeaders(HeadersFrameParam{
  1163. StreamID: f.StreamID,
  1164. EndHeaders: true,
  1165. EndStream: false,
  1166. BlockFragment: buf.Bytes(),
  1167. })
  1168. }
  1169. buf.Reset()
  1170. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  1171. ct.fr.WriteHeaders(HeadersFrameParam{
  1172. StreamID: f.StreamID,
  1173. EndHeaders: true,
  1174. EndStream: false,
  1175. BlockFragment: buf.Bytes(),
  1176. })
  1177. return nil
  1178. }
  1179. }
  1180. }
  1181. ct.run()
  1182. }
  1183. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  1184. ct := newClientTester(t)
  1185. ct.client = func() error {
  1186. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1187. res, err := ct.tr.RoundTrip(req)
  1188. if err != nil {
  1189. return fmt.Errorf("RoundTrip: %v", err)
  1190. }
  1191. defer res.Body.Close()
  1192. if res.StatusCode != 200 {
  1193. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1194. }
  1195. slurp, err := ioutil.ReadAll(res.Body)
  1196. if err != nil {
  1197. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  1198. }
  1199. if len(slurp) > 0 {
  1200. return fmt.Errorf("body = %q; want nothing", slurp)
  1201. }
  1202. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  1203. return fmt.Errorf("expected Some-Trailer")
  1204. }
  1205. return nil
  1206. }
  1207. ct.server = func() error {
  1208. ct.greet()
  1209. var n int
  1210. var hf *HeadersFrame
  1211. for hf == nil && n < 10 {
  1212. f, err := ct.fr.ReadFrame()
  1213. if err != nil {
  1214. return err
  1215. }
  1216. hf, _ = f.(*HeadersFrame)
  1217. n++
  1218. }
  1219. var buf bytes.Buffer
  1220. enc := hpack.NewEncoder(&buf)
  1221. // send headers without Trailer header
  1222. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1223. ct.fr.WriteHeaders(HeadersFrameParam{
  1224. StreamID: hf.StreamID,
  1225. EndHeaders: true,
  1226. EndStream: false,
  1227. BlockFragment: buf.Bytes(),
  1228. })
  1229. // send trailers
  1230. buf.Reset()
  1231. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  1232. ct.fr.WriteHeaders(HeadersFrameParam{
  1233. StreamID: hf.StreamID,
  1234. EndHeaders: true,
  1235. EndStream: true,
  1236. BlockFragment: buf.Bytes(),
  1237. })
  1238. return nil
  1239. }
  1240. ct.run()
  1241. }
  1242. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1243. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1244. }
  1245. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1246. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1247. }
  1248. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1249. testInvalidTrailer(t, trailers, pseudoHeaderError(":colon"), func(enc *hpack.Encoder) {
  1250. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1251. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1252. })
  1253. }
  1254. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1255. testTransportInvalidTrailer_Capital(t, oneHeader)
  1256. }
  1257. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1258. testTransportInvalidTrailer_Capital(t, splitHeader)
  1259. }
  1260. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1261. testInvalidTrailer(t, trailers, headerFieldNameError("Capital"), func(enc *hpack.Encoder) {
  1262. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1263. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1264. })
  1265. }
  1266. func TestTransportInvalidTrailer_EmptyFieldName(t *testing.T) {
  1267. testInvalidTrailer(t, oneHeader, headerFieldNameError(""), func(enc *hpack.Encoder) {
  1268. enc.WriteField(hpack.HeaderField{Name: "", Value: "bad"})
  1269. })
  1270. }
  1271. func TestTransportInvalidTrailer_BinaryFieldValue(t *testing.T) {
  1272. testInvalidTrailer(t, oneHeader, headerFieldValueError("has\nnewline"), func(enc *hpack.Encoder) {
  1273. enc.WriteField(hpack.HeaderField{Name: "x", Value: "has\nnewline"})
  1274. })
  1275. }
  1276. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1277. ct := newClientTester(t)
  1278. ct.client = func() error {
  1279. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1280. res, err := ct.tr.RoundTrip(req)
  1281. if err != nil {
  1282. return fmt.Errorf("RoundTrip: %v", err)
  1283. }
  1284. defer res.Body.Close()
  1285. if res.StatusCode != 200 {
  1286. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1287. }
  1288. slurp, err := ioutil.ReadAll(res.Body)
  1289. se, ok := err.(StreamError)
  1290. if !ok || se.Cause != wantErr {
  1291. return fmt.Errorf("res.Body ReadAll error = %q, %#v; want StreamError with cause %T, %#v", slurp, err, wantErr, wantErr)
  1292. }
  1293. if len(slurp) > 0 {
  1294. return fmt.Errorf("body = %q; want nothing", slurp)
  1295. }
  1296. return nil
  1297. }
  1298. ct.server = func() error {
  1299. ct.greet()
  1300. var buf bytes.Buffer
  1301. enc := hpack.NewEncoder(&buf)
  1302. for {
  1303. f, err := ct.fr.ReadFrame()
  1304. if err != nil {
  1305. return err
  1306. }
  1307. switch f := f.(type) {
  1308. case *HeadersFrame:
  1309. var endStream bool
  1310. send := func(mode headerType) {
  1311. hbf := buf.Bytes()
  1312. switch mode {
  1313. case oneHeader:
  1314. ct.fr.WriteHeaders(HeadersFrameParam{
  1315. StreamID: f.StreamID,
  1316. EndHeaders: true,
  1317. EndStream: endStream,
  1318. BlockFragment: hbf,
  1319. })
  1320. case splitHeader:
  1321. if len(hbf) < 2 {
  1322. panic("too small")
  1323. }
  1324. ct.fr.WriteHeaders(HeadersFrameParam{
  1325. StreamID: f.StreamID,
  1326. EndHeaders: false,
  1327. EndStream: endStream,
  1328. BlockFragment: hbf[:1],
  1329. })
  1330. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1331. default:
  1332. panic("bogus mode")
  1333. }
  1334. }
  1335. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1336. {
  1337. buf.Reset()
  1338. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1339. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1340. endStream = false
  1341. send(oneHeader)
  1342. }
  1343. // Trailers:
  1344. {
  1345. endStream = true
  1346. buf.Reset()
  1347. writeTrailer(enc)
  1348. send(trailers)
  1349. }
  1350. return nil
  1351. }
  1352. }
  1353. }
  1354. ct.run()
  1355. }
  1356. // headerListSize returns the HTTP2 header list size of h.
  1357. // http://httpwg.org/specs/rfc7540.html#SETTINGS_MAX_HEADER_LIST_SIZE
  1358. // http://httpwg.org/specs/rfc7540.html#MaxHeaderBlock
  1359. func headerListSize(h http.Header) (size uint32) {
  1360. for k, vv := range h {
  1361. for _, v := range vv {
  1362. hf := hpack.HeaderField{Name: k, Value: v}
  1363. size += hf.Size()
  1364. }
  1365. }
  1366. return size
  1367. }
  1368. // padHeaders adds data to an http.Header until headerListSize(h) ==
  1369. // limit. Due to the way header list sizes are calculated, padHeaders
  1370. // cannot add fewer than len("Pad-Headers") + 32 bytes to h, and will
  1371. // call t.Fatal if asked to do so. PadHeaders first reserves enough
  1372. // space for an empty "Pad-Headers" key, then adds as many copies of
  1373. // filler as possible. Any remaining bytes necessary to push the
  1374. // header list size up to limit are added to h["Pad-Headers"].
  1375. func padHeaders(t *testing.T, h http.Header, limit uint64, filler string) {
  1376. if limit > 0xffffffff {
  1377. t.Fatalf("padHeaders: refusing to pad to more than 2^32-1 bytes. limit = %v", limit)
  1378. }
  1379. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1380. minPadding := uint64(hf.Size())
  1381. size := uint64(headerListSize(h))
  1382. minlimit := size + minPadding
  1383. if limit < minlimit {
  1384. t.Fatalf("padHeaders: limit %v < %v", limit, minlimit)
  1385. }
  1386. // Use a fixed-width format for name so that fieldSize
  1387. // remains constant.
  1388. nameFmt := "Pad-Headers-%06d"
  1389. hf = hpack.HeaderField{Name: fmt.Sprintf(nameFmt, 1), Value: filler}
  1390. fieldSize := uint64(hf.Size())
  1391. // Add as many complete filler values as possible, leaving
  1392. // room for at least one empty "Pad-Headers" key.
  1393. limit = limit - minPadding
  1394. for i := 0; size+fieldSize < limit; i++ {
  1395. name := fmt.Sprintf(nameFmt, i)
  1396. h.Add(name, filler)
  1397. size += fieldSize
  1398. }
  1399. // Add enough bytes to reach limit.
  1400. remain := limit - size
  1401. lastValue := strings.Repeat("*", int(remain))
  1402. h.Add("Pad-Headers", lastValue)
  1403. }
  1404. func TestPadHeaders(t *testing.T) {
  1405. check := func(h http.Header, limit uint32, fillerLen int) {
  1406. if h == nil {
  1407. h = make(http.Header)
  1408. }
  1409. filler := strings.Repeat("f", fillerLen)
  1410. padHeaders(t, h, uint64(limit), filler)
  1411. gotSize := headerListSize(h)
  1412. if gotSize != limit {
  1413. t.Errorf("Got size = %v; want %v", gotSize, limit)
  1414. }
  1415. }
  1416. // Try all possible combinations for small fillerLen and limit.
  1417. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1418. minLimit := hf.Size()
  1419. for limit := minLimit; limit <= 128; limit++ {
  1420. for fillerLen := 0; uint32(fillerLen) <= limit; fillerLen++ {
  1421. check(nil, limit, fillerLen)
  1422. }
  1423. }
  1424. // Try a few tests with larger limits, plus cumulative
  1425. // tests. Since these tests are cumulative, tests[i+1].limit
  1426. // must be >= tests[i].limit + minLimit. See the comment on
  1427. // padHeaders for more info on why the limit arg has this
  1428. // restriction.
  1429. tests := []struct {
  1430. fillerLen int
  1431. limit uint32
  1432. }{
  1433. {
  1434. fillerLen: 64,
  1435. limit: 1024,
  1436. },
  1437. {
  1438. fillerLen: 1024,
  1439. limit: 1286,
  1440. },
  1441. {
  1442. fillerLen: 256,
  1443. limit: 2048,
  1444. },
  1445. {
  1446. fillerLen: 1024,
  1447. limit: 10 * 1024,
  1448. },
  1449. {
  1450. fillerLen: 1023,
  1451. limit: 11 * 1024,
  1452. },
  1453. }
  1454. h := make(http.Header)
  1455. for _, tc := range tests {
  1456. check(nil, tc.limit, tc.fillerLen)
  1457. check(h, tc.limit, tc.fillerLen)
  1458. }
  1459. }
  1460. func TestTransportChecksRequestHeaderListSize(t *testing.T) {
  1461. st := newServerTester(t,
  1462. func(w http.ResponseWriter, r *http.Request) {
  1463. // Consume body & force client to send
  1464. // trailers before writing response.
  1465. // ioutil.ReadAll returns non-nil err for
  1466. // requests that attempt to send greater than
  1467. // maxHeaderListSize bytes of trailers, since
  1468. // those requests generate a stream reset.
  1469. ioutil.ReadAll(r.Body)
  1470. r.Body.Close()
  1471. },
  1472. func(ts *httptest.Server) {
  1473. ts.Config.MaxHeaderBytes = 16 << 10
  1474. },
  1475. optOnlyServer,
  1476. optQuiet,
  1477. )
  1478. defer st.Close()
  1479. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1480. defer tr.CloseIdleConnections()
  1481. checkRoundTrip := func(req *http.Request, wantErr error, desc string) {
  1482. res, err := tr.RoundTrip(req)
  1483. if err != wantErr {
  1484. if res != nil {
  1485. res.Body.Close()
  1486. }
  1487. t.Errorf("%v: RoundTrip err = %v; want %v", desc, err, wantErr)
  1488. return
  1489. }
  1490. if err == nil {
  1491. if res == nil {
  1492. t.Errorf("%v: response nil; want non-nil.", desc)
  1493. return
  1494. }
  1495. defer res.Body.Close()
  1496. if res.StatusCode != http.StatusOK {
  1497. t.Errorf("%v: response status = %v; want %v", desc, res.StatusCode, http.StatusOK)
  1498. }
  1499. return
  1500. }
  1501. if res != nil {
  1502. t.Errorf("%v: RoundTrip err = %v but response non-nil", desc, err)
  1503. }
  1504. }
  1505. headerListSizeForRequest := func(req *http.Request) (size uint64) {
  1506. contentLen := actualContentLength(req)
  1507. trailers, err := commaSeparatedTrailers(req)
  1508. if err != nil {
  1509. t.Fatalf("headerListSizeForRequest: %v", err)
  1510. }
  1511. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  1512. cc.henc = hpack.NewEncoder(&cc.hbuf)
  1513. cc.mu.Lock()
  1514. hdrs, err := cc.encodeHeaders(req, true, trailers, contentLen)
  1515. cc.mu.Unlock()
  1516. if err != nil {
  1517. t.Fatalf("headerListSizeForRequest: %v", err)
  1518. }
  1519. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(hf hpack.HeaderField) {
  1520. size += uint64(hf.Size())
  1521. })
  1522. if len(hdrs) > 0 {
  1523. if _, err := hpackDec.Write(hdrs); err != nil {
  1524. t.Fatalf("headerListSizeForRequest: %v", err)
  1525. }
  1526. }
  1527. return size
  1528. }
  1529. // Create a new Request for each test, rather than reusing the
  1530. // same Request, to avoid a race when modifying req.Headers.
  1531. // See https://github.com/golang/go/issues/21316
  1532. newRequest := func() *http.Request {
  1533. // Body must be non-nil to enable writing trailers.
  1534. body := strings.NewReader("hello")
  1535. req, err := http.NewRequest("POST", st.ts.URL, body)
  1536. if err != nil {
  1537. t.Fatalf("newRequest: NewRequest: %v", err)
  1538. }
  1539. return req
  1540. }
  1541. // Make an arbitrary request to ensure we get the server's
  1542. // settings frame and initialize peerMaxHeaderListSize.
  1543. req := newRequest()
  1544. checkRoundTrip(req, nil, "Initial request")
  1545. // Get the ClientConn associated with the request and validate
  1546. // peerMaxHeaderListSize.
  1547. addr := authorityAddr(req.URL.Scheme, req.URL.Host)
  1548. cc, err := tr.connPool().GetClientConn(req, addr)
  1549. if err != nil {
  1550. t.Fatalf("GetClientConn: %v", err)
  1551. }
  1552. cc.mu.Lock()
  1553. peerSize := cc.peerMaxHeaderListSize
  1554. cc.mu.Unlock()
  1555. st.scMu.Lock()
  1556. wantSize := uint64(st.sc.maxHeaderListSize())
  1557. st.scMu.Unlock()
  1558. if peerSize != wantSize {
  1559. t.Errorf("peerMaxHeaderListSize = %v; want %v", peerSize, wantSize)
  1560. }
  1561. // Sanity check peerSize. (*serverConn) maxHeaderListSize adds
  1562. // 320 bytes of padding.
  1563. wantHeaderBytes := uint64(st.ts.Config.MaxHeaderBytes) + 320
  1564. if peerSize != wantHeaderBytes {
  1565. t.Errorf("peerMaxHeaderListSize = %v; want %v.", peerSize, wantHeaderBytes)
  1566. }
  1567. // Pad headers & trailers, but stay under peerSize.
  1568. req = newRequest()
  1569. req.Header = make(http.Header)
  1570. req.Trailer = make(http.Header)
  1571. filler := strings.Repeat("*", 1024)
  1572. padHeaders(t, req.Trailer, peerSize, filler)
  1573. // cc.encodeHeaders adds some default headers to the request,
  1574. // so we need to leave room for those.
  1575. defaultBytes := headerListSizeForRequest(req)
  1576. padHeaders(t, req.Header, peerSize-defaultBytes, filler)
  1577. checkRoundTrip(req, nil, "Headers & Trailers under limit")
  1578. // Add enough header bytes to push us over peerSize.
  1579. req = newRequest()
  1580. req.Header = make(http.Header)
  1581. padHeaders(t, req.Header, peerSize, filler)
  1582. checkRoundTrip(req, errRequestHeaderListSize, "Headers over limit")
  1583. // Push trailers over the limit.
  1584. req = newRequest()
  1585. req.Trailer = make(http.Header)
  1586. padHeaders(t, req.Trailer, peerSize+1, filler)
  1587. checkRoundTrip(req, errRequestHeaderListSize, "Trailers over limit")
  1588. // Send headers with a single large value.
  1589. req = newRequest()
  1590. filler = strings.Repeat("*", int(peerSize))
  1591. req.Header = make(http.Header)
  1592. req.Header.Set("Big", filler)
  1593. checkRoundTrip(req, errRequestHeaderListSize, "Single large header")
  1594. // Send trailers with a single large value.
  1595. req = newRequest()
  1596. req.Trailer = make(http.Header)
  1597. req.Trailer.Set("Big", filler)
  1598. checkRoundTrip(req, errRequestHeaderListSize, "Single large trailer")
  1599. }
  1600. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1601. ct := newClientTester(t)
  1602. ct.client = func() error {
  1603. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1604. res, err := ct.tr.RoundTrip(req)
  1605. if err != errResponseHeaderListSize {
  1606. if res != nil {
  1607. res.Body.Close()
  1608. }
  1609. size := int64(0)
  1610. for k, vv := range res.Header {
  1611. for _, v := range vv {
  1612. size += int64(len(k)) + int64(len(v)) + 32
  1613. }
  1614. }
  1615. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1616. }
  1617. return nil
  1618. }
  1619. ct.server = func() error {
  1620. ct.greet()
  1621. var buf bytes.Buffer
  1622. enc := hpack.NewEncoder(&buf)
  1623. for {
  1624. f, err := ct.fr.ReadFrame()
  1625. if err != nil {
  1626. return err
  1627. }
  1628. switch f := f.(type) {
  1629. case *HeadersFrame:
  1630. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1631. large := strings.Repeat("a", 1<<10)
  1632. for i := 0; i < 5042; i++ {
  1633. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1634. }
  1635. if size, want := buf.Len(), 6329; size != want {
  1636. // Note: this number might change if
  1637. // our hpack implementation
  1638. // changes. That's fine. This is
  1639. // just a sanity check that our
  1640. // response can fit in a single
  1641. // header block fragment frame.
  1642. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1643. }
  1644. ct.fr.WriteHeaders(HeadersFrameParam{
  1645. StreamID: f.StreamID,
  1646. EndHeaders: true,
  1647. EndStream: true,
  1648. BlockFragment: buf.Bytes(),
  1649. })
  1650. return nil
  1651. }
  1652. }
  1653. }
  1654. ct.run()
  1655. }
  1656. // Test that the Transport returns a typed error from Response.Body.Read calls
  1657. // when the server sends an error. (here we use a panic, since that should generate
  1658. // a stream error, but others like cancel should be similar)
  1659. func TestTransportBodyReadErrorType(t *testing.T) {
  1660. doPanic := make(chan bool, 1)
  1661. st := newServerTester(t,
  1662. func(w http.ResponseWriter, r *http.Request) {
  1663. w.(http.Flusher).Flush() // force headers out
  1664. <-doPanic
  1665. panic("boom")
  1666. },
  1667. optOnlyServer,
  1668. optQuiet,
  1669. )
  1670. defer st.Close()
  1671. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1672. defer tr.CloseIdleConnections()
  1673. c := &http.Client{Transport: tr}
  1674. res, err := c.Get(st.ts.URL)
  1675. if err != nil {
  1676. t.Fatal(err)
  1677. }
  1678. defer res.Body.Close()
  1679. doPanic <- true
  1680. buf := make([]byte, 100)
  1681. n, err := res.Body.Read(buf)
  1682. want := StreamError{StreamID: 0x1, Code: 0x2}
  1683. if !reflect.DeepEqual(want, err) {
  1684. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1685. }
  1686. }
  1687. // golang.org/issue/13924
  1688. // This used to fail after many iterations, especially with -race:
  1689. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1690. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1691. var (
  1692. mu sync.Mutex
  1693. conn net.Conn // to close if set
  1694. )
  1695. st := newServerTester(t,
  1696. func(w http.ResponseWriter, r *http.Request) {
  1697. mu.Lock()
  1698. defer mu.Unlock()
  1699. if conn != nil {
  1700. conn.Close()
  1701. }
  1702. },
  1703. optOnlyServer,
  1704. )
  1705. defer st.Close()
  1706. tr := &Transport{
  1707. TLSClientConfig: tlsConfigInsecure,
  1708. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1709. tc, err := tls.Dial(network, addr, cfg)
  1710. if err != nil {
  1711. return nil, err
  1712. }
  1713. mu.Lock()
  1714. defer mu.Unlock()
  1715. conn = tc
  1716. return tc, nil
  1717. },
  1718. }
  1719. defer tr.CloseIdleConnections()
  1720. c := &http.Client{Transport: tr}
  1721. c.Get(st.ts.URL)
  1722. }
  1723. // Test that the http1 Transport.DisableKeepAlives option is respected
  1724. // and connections are closed as soon as idle.
  1725. // See golang.org/issue/14008
  1726. func TestTransportDisableKeepAlives(t *testing.T) {
  1727. st := newServerTester(t,
  1728. func(w http.ResponseWriter, r *http.Request) {
  1729. io.WriteString(w, "hi")
  1730. },
  1731. optOnlyServer,
  1732. )
  1733. defer st.Close()
  1734. connClosed := make(chan struct{}) // closed on tls.Conn.Close
  1735. tr := &Transport{
  1736. t1: &http.Transport{
  1737. DisableKeepAlives: true,
  1738. },
  1739. TLSClientConfig: tlsConfigInsecure,
  1740. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1741. tc, err := tls.Dial(network, addr, cfg)
  1742. if err != nil {
  1743. return nil, err
  1744. }
  1745. return &noteCloseConn{Conn: tc, closefn: func() { close(connClosed) }}, nil
  1746. },
  1747. }
  1748. c := &http.Client{Transport: tr}
  1749. res, err := c.Get(st.ts.URL)
  1750. if err != nil {
  1751. t.Fatal(err)
  1752. }
  1753. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1754. t.Fatal(err)
  1755. }
  1756. defer res.Body.Close()
  1757. select {
  1758. case <-connClosed:
  1759. case <-time.After(1 * time.Second):
  1760. t.Errorf("timeout")
  1761. }
  1762. }
  1763. // Test concurrent requests with Transport.DisableKeepAlives. We can share connections,
  1764. // but when things are totally idle, it still needs to close.
  1765. func TestTransportDisableKeepAlives_Concurrency(t *testing.T) {
  1766. const D = 25 * time.Millisecond
  1767. st := newServerTester(t,
  1768. func(w http.ResponseWriter, r *http.Request) {
  1769. time.Sleep(D)
  1770. io.WriteString(w, "hi")
  1771. },
  1772. optOnlyServer,
  1773. )
  1774. defer st.Close()
  1775. var dials int32
  1776. var conns sync.WaitGroup
  1777. tr := &Transport{
  1778. t1: &http.Transport{
  1779. DisableKeepAlives: true,
  1780. },
  1781. TLSClientConfig: tlsConfigInsecure,
  1782. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1783. tc, err := tls.Dial(network, addr, cfg)
  1784. if err != nil {
  1785. return nil, err
  1786. }
  1787. atomic.AddInt32(&dials, 1)
  1788. conns.Add(1)
  1789. return &noteCloseConn{Conn: tc, closefn: func() { conns.Done() }}, nil
  1790. },
  1791. }
  1792. c := &http.Client{Transport: tr}
  1793. var reqs sync.WaitGroup
  1794. const N = 20
  1795. for i := 0; i < N; i++ {
  1796. reqs.Add(1)
  1797. if i == N-1 {
  1798. // For the final request, try to make all the
  1799. // others close. This isn't verified in the
  1800. // count, other than the Log statement, since
  1801. // it's so timing dependent. This test is
  1802. // really to make sure we don't interrupt a
  1803. // valid request.
  1804. time.Sleep(D * 2)
  1805. }
  1806. go func() {
  1807. defer reqs.Done()
  1808. res, err := c.Get(st.ts.URL)
  1809. if err != nil {
  1810. t.Error(err)
  1811. return
  1812. }
  1813. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1814. t.Error(err)
  1815. return
  1816. }
  1817. res.Body.Close()
  1818. }()
  1819. }
  1820. reqs.Wait()
  1821. conns.Wait()
  1822. t.Logf("did %d dials, %d requests", atomic.LoadInt32(&dials), N)
  1823. }
  1824. type noteCloseConn struct {
  1825. net.Conn
  1826. onceClose sync.Once
  1827. closefn func()
  1828. }
  1829. func (c *noteCloseConn) Close() error {
  1830. c.onceClose.Do(c.closefn)
  1831. return c.Conn.Close()
  1832. }
  1833. func isTimeout(err error) bool {
  1834. switch err := err.(type) {
  1835. case nil:
  1836. return false
  1837. case *url.Error:
  1838. return isTimeout(err.Err)
  1839. case net.Error:
  1840. return err.Timeout()
  1841. }
  1842. return false
  1843. }
  1844. // Test that the http1 Transport.ResponseHeaderTimeout option and cancel is sent.
  1845. func TestTransportResponseHeaderTimeout_NoBody(t *testing.T) {
  1846. testTransportResponseHeaderTimeout(t, false)
  1847. }
  1848. func TestTransportResponseHeaderTimeout_Body(t *testing.T) {
  1849. testTransportResponseHeaderTimeout(t, true)
  1850. }
  1851. func testTransportResponseHeaderTimeout(t *testing.T, body bool) {
  1852. ct := newClientTester(t)
  1853. ct.tr.t1 = &http.Transport{
  1854. ResponseHeaderTimeout: 5 * time.Millisecond,
  1855. }
  1856. ct.client = func() error {
  1857. c := &http.Client{Transport: ct.tr}
  1858. var err error
  1859. var n int64
  1860. const bodySize = 4 << 20
  1861. if body {
  1862. _, err = c.Post("https://dummy.tld/", "text/foo", io.LimitReader(countingReader{&n}, bodySize))
  1863. } else {
  1864. _, err = c.Get("https://dummy.tld/")
  1865. }
  1866. if !isTimeout(err) {
  1867. t.Errorf("client expected timeout error; got %#v", err)
  1868. }
  1869. if body && n != bodySize {
  1870. t.Errorf("only read %d bytes of body; want %d", n, bodySize)
  1871. }
  1872. return nil
  1873. }
  1874. ct.server = func() error {
  1875. ct.greet()
  1876. for {
  1877. f, err := ct.fr.ReadFrame()
  1878. if err != nil {
  1879. t.Logf("ReadFrame: %v", err)
  1880. return nil
  1881. }
  1882. switch f := f.(type) {
  1883. case *DataFrame:
  1884. dataLen := len(f.Data())
  1885. if dataLen > 0 {
  1886. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  1887. return err
  1888. }
  1889. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  1890. return err
  1891. }
  1892. }
  1893. case *RSTStreamFrame:
  1894. if f.StreamID == 1 && f.ErrCode == ErrCodeCancel {
  1895. return nil
  1896. }
  1897. }
  1898. }
  1899. }
  1900. ct.run()
  1901. }
  1902. func TestTransportDisableCompression(t *testing.T) {
  1903. const body = "sup"
  1904. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1905. want := http.Header{
  1906. "User-Agent": []string{"Go-http-client/2.0"},
  1907. }
  1908. if !reflect.DeepEqual(r.Header, want) {
  1909. t.Errorf("request headers = %v; want %v", r.Header, want)
  1910. }
  1911. }, optOnlyServer)
  1912. defer st.Close()
  1913. tr := &Transport{
  1914. TLSClientConfig: tlsConfigInsecure,
  1915. t1: &http.Transport{
  1916. DisableCompression: true,
  1917. },
  1918. }
  1919. defer tr.CloseIdleConnections()
  1920. req, err := http.NewRequest("GET", st.ts.URL, nil)
  1921. if err != nil {
  1922. t.Fatal(err)
  1923. }
  1924. res, err := tr.RoundTrip(req)
  1925. if err != nil {
  1926. t.Fatal(err)
  1927. }
  1928. defer res.Body.Close()
  1929. }
  1930. // RFC 7540 section 8.1.2.2
  1931. func TestTransportRejectsConnHeaders(t *testing.T) {
  1932. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1933. var got []string
  1934. for k := range r.Header {
  1935. got = append(got, k)
  1936. }
  1937. sort.Strings(got)
  1938. w.Header().Set("Got-Header", strings.Join(got, ","))
  1939. }, optOnlyServer)
  1940. defer st.Close()
  1941. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1942. defer tr.CloseIdleConnections()
  1943. tests := []struct {
  1944. key string
  1945. value []string
  1946. want string
  1947. }{
  1948. {
  1949. key: "Upgrade",
  1950. value: []string{"anything"},
  1951. want: "ERROR: http2: invalid Upgrade request header: [\"anything\"]",
  1952. },
  1953. {
  1954. key: "Connection",
  1955. value: []string{"foo"},
  1956. want: "ERROR: http2: invalid Connection request header: [\"foo\"]",
  1957. },
  1958. {
  1959. key: "Connection",
  1960. value: []string{"close"},
  1961. want: "Accept-Encoding,User-Agent",
  1962. },
  1963. {
  1964. key: "Connection",
  1965. value: []string{"CLoSe"},
  1966. want: "Accept-Encoding,User-Agent",
  1967. },
  1968. {
  1969. key: "Connection",
  1970. value: []string{"close", "something-else"},
  1971. want: "ERROR: http2: invalid Connection request header: [\"close\" \"something-else\"]",
  1972. },
  1973. {
  1974. key: "Connection",
  1975. value: []string{"keep-alive"},
  1976. want: "Accept-Encoding,User-Agent",
  1977. },
  1978. {
  1979. key: "Connection",
  1980. value: []string{"Keep-ALIVE"},
  1981. want: "Accept-Encoding,User-Agent",
  1982. },
  1983. {
  1984. key: "Proxy-Connection", // just deleted and ignored
  1985. value: []string{"keep-alive"},
  1986. want: "Accept-Encoding,User-Agent",
  1987. },
  1988. {
  1989. key: "Transfer-Encoding",
  1990. value: []string{""},
  1991. want: "Accept-Encoding,User-Agent",
  1992. },
  1993. {
  1994. key: "Transfer-Encoding",
  1995. value: []string{"foo"},
  1996. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"foo\"]",
  1997. },
  1998. {
  1999. key: "Transfer-Encoding",
  2000. value: []string{"chunked"},
  2001. want: "Accept-Encoding,User-Agent",
  2002. },
  2003. {
  2004. key: "Transfer-Encoding",
  2005. value: []string{"chunked", "other"},
  2006. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"chunked\" \"other\"]",
  2007. },
  2008. {
  2009. key: "Content-Length",
  2010. value: []string{"123"},
  2011. want: "Accept-Encoding,User-Agent",
  2012. },
  2013. {
  2014. key: "Keep-Alive",
  2015. value: []string{"doop"},
  2016. want: "Accept-Encoding,User-Agent",
  2017. },
  2018. }
  2019. for _, tt := range tests {
  2020. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2021. req.Header[tt.key] = tt.value
  2022. res, err := tr.RoundTrip(req)
  2023. var got string
  2024. if err != nil {
  2025. got = fmt.Sprintf("ERROR: %v", err)
  2026. } else {
  2027. got = res.Header.Get("Got-Header")
  2028. res.Body.Close()
  2029. }
  2030. if got != tt.want {
  2031. t.Errorf("For key %q, value %q, got = %q; want %q", tt.key, tt.value, got, tt.want)
  2032. }
  2033. }
  2034. }
  2035. // golang.org/issue/14048
  2036. func TestTransportFailsOnInvalidHeaders(t *testing.T) {
  2037. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2038. var got []string
  2039. for k := range r.Header {
  2040. got = append(got, k)
  2041. }
  2042. sort.Strings(got)
  2043. w.Header().Set("Got-Header", strings.Join(got, ","))
  2044. }, optOnlyServer)
  2045. defer st.Close()
  2046. tests := [...]struct {
  2047. h http.Header
  2048. wantErr string
  2049. }{
  2050. 0: {
  2051. h: http.Header{"with space": {"foo"}},
  2052. wantErr: `invalid HTTP header name "with space"`,
  2053. },
  2054. 1: {
  2055. h: http.Header{"name": {"Брэд"}},
  2056. wantErr: "", // okay
  2057. },
  2058. 2: {
  2059. h: http.Header{"имя": {"Brad"}},
  2060. wantErr: `invalid HTTP header name "имя"`,
  2061. },
  2062. 3: {
  2063. h: http.Header{"foo": {"foo\x01bar"}},
  2064. wantErr: `invalid HTTP header value "foo\x01bar" for header "foo"`,
  2065. },
  2066. }
  2067. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2068. defer tr.CloseIdleConnections()
  2069. for i, tt := range tests {
  2070. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2071. req.Header = tt.h
  2072. res, err := tr.RoundTrip(req)
  2073. var bad bool
  2074. if tt.wantErr == "" {
  2075. if err != nil {
  2076. bad = true
  2077. t.Errorf("case %d: error = %v; want no error", i, err)
  2078. }
  2079. } else {
  2080. if !strings.Contains(fmt.Sprint(err), tt.wantErr) {
  2081. bad = true
  2082. t.Errorf("case %d: error = %v; want error %q", i, err, tt.wantErr)
  2083. }
  2084. }
  2085. if err == nil {
  2086. if bad {
  2087. t.Logf("case %d: server got headers %q", i, res.Header.Get("Got-Header"))
  2088. }
  2089. res.Body.Close()
  2090. }
  2091. }
  2092. }
  2093. // Tests that gzipReader doesn't crash on a second Read call following
  2094. // the first Read call's gzip.NewReader returning an error.
  2095. func TestGzipReader_DoubleReadCrash(t *testing.T) {
  2096. gz := &gzipReader{
  2097. body: ioutil.NopCloser(strings.NewReader("0123456789")),
  2098. }
  2099. var buf [1]byte
  2100. n, err1 := gz.Read(buf[:])
  2101. if n != 0 || !strings.Contains(fmt.Sprint(err1), "invalid header") {
  2102. t.Fatalf("Read = %v, %v; want 0, invalid header", n, err1)
  2103. }
  2104. n, err2 := gz.Read(buf[:])
  2105. if n != 0 || err2 != err1 {
  2106. t.Fatalf("second Read = %v, %v; want 0, %v", n, err2, err1)
  2107. }
  2108. }
  2109. func TestTransportNewTLSConfig(t *testing.T) {
  2110. tests := [...]struct {
  2111. conf *tls.Config
  2112. host string
  2113. want *tls.Config
  2114. }{
  2115. // Normal case.
  2116. 0: {
  2117. conf: nil,
  2118. host: "foo.com",
  2119. want: &tls.Config{
  2120. ServerName: "foo.com",
  2121. NextProtos: []string{NextProtoTLS},
  2122. },
  2123. },
  2124. // User-provided name (bar.com) takes precedence:
  2125. 1: {
  2126. conf: &tls.Config{
  2127. ServerName: "bar.com",
  2128. },
  2129. host: "foo.com",
  2130. want: &tls.Config{
  2131. ServerName: "bar.com",
  2132. NextProtos: []string{NextProtoTLS},
  2133. },
  2134. },
  2135. // NextProto is prepended:
  2136. 2: {
  2137. conf: &tls.Config{
  2138. NextProtos: []string{"foo", "bar"},
  2139. },
  2140. host: "example.com",
  2141. want: &tls.Config{
  2142. ServerName: "example.com",
  2143. NextProtos: []string{NextProtoTLS, "foo", "bar"},
  2144. },
  2145. },
  2146. // NextProto is not duplicated:
  2147. 3: {
  2148. conf: &tls.Config{
  2149. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2150. },
  2151. host: "example.com",
  2152. want: &tls.Config{
  2153. ServerName: "example.com",
  2154. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2155. },
  2156. },
  2157. }
  2158. for i, tt := range tests {
  2159. // Ignore the session ticket keys part, which ends up populating
  2160. // unexported fields in the Config:
  2161. if tt.conf != nil {
  2162. tt.conf.SessionTicketsDisabled = true
  2163. }
  2164. tr := &Transport{TLSClientConfig: tt.conf}
  2165. got := tr.newTLSConfig(tt.host)
  2166. got.SessionTicketsDisabled = false
  2167. if !reflect.DeepEqual(got, tt.want) {
  2168. t.Errorf("%d. got %#v; want %#v", i, got, tt.want)
  2169. }
  2170. }
  2171. }
  2172. // The Google GFE responds to HEAD requests with a HEADERS frame
  2173. // without END_STREAM, followed by a 0-length DATA frame with
  2174. // END_STREAM. Make sure we don't get confused by that. (We did.)
  2175. func TestTransportReadHeadResponse(t *testing.T) {
  2176. ct := newClientTester(t)
  2177. clientDone := make(chan struct{})
  2178. ct.client = func() error {
  2179. defer close(clientDone)
  2180. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2181. res, err := ct.tr.RoundTrip(req)
  2182. if err != nil {
  2183. return err
  2184. }
  2185. if res.ContentLength != 123 {
  2186. return fmt.Errorf("Content-Length = %d; want 123", res.ContentLength)
  2187. }
  2188. slurp, err := ioutil.ReadAll(res.Body)
  2189. if err != nil {
  2190. return fmt.Errorf("ReadAll: %v", err)
  2191. }
  2192. if len(slurp) > 0 {
  2193. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2194. }
  2195. return nil
  2196. }
  2197. ct.server = func() error {
  2198. ct.greet()
  2199. for {
  2200. f, err := ct.fr.ReadFrame()
  2201. if err != nil {
  2202. t.Logf("ReadFrame: %v", err)
  2203. return nil
  2204. }
  2205. hf, ok := f.(*HeadersFrame)
  2206. if !ok {
  2207. continue
  2208. }
  2209. var buf bytes.Buffer
  2210. enc := hpack.NewEncoder(&buf)
  2211. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2212. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2213. ct.fr.WriteHeaders(HeadersFrameParam{
  2214. StreamID: hf.StreamID,
  2215. EndHeaders: true,
  2216. EndStream: false, // as the GFE does
  2217. BlockFragment: buf.Bytes(),
  2218. })
  2219. ct.fr.WriteData(hf.StreamID, true, nil)
  2220. <-clientDone
  2221. return nil
  2222. }
  2223. }
  2224. ct.run()
  2225. }
  2226. func TestTransportReadHeadResponseWithBody(t *testing.T) {
  2227. // This test use not valid response format.
  2228. // Discarding logger output to not spam tests output.
  2229. log.SetOutput(ioutil.Discard)
  2230. defer log.SetOutput(os.Stderr)
  2231. response := "redirecting to /elsewhere"
  2232. ct := newClientTester(t)
  2233. clientDone := make(chan struct{})
  2234. ct.client = func() error {
  2235. defer close(clientDone)
  2236. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2237. res, err := ct.tr.RoundTrip(req)
  2238. if err != nil {
  2239. return err
  2240. }
  2241. if res.ContentLength != int64(len(response)) {
  2242. return fmt.Errorf("Content-Length = %d; want %d", res.ContentLength, len(response))
  2243. }
  2244. slurp, err := ioutil.ReadAll(res.Body)
  2245. if err != nil {
  2246. return fmt.Errorf("ReadAll: %v", err)
  2247. }
  2248. if len(slurp) > 0 {
  2249. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2250. }
  2251. return nil
  2252. }
  2253. ct.server = func() error {
  2254. ct.greet()
  2255. for {
  2256. f, err := ct.fr.ReadFrame()
  2257. if err != nil {
  2258. t.Logf("ReadFrame: %v", err)
  2259. return nil
  2260. }
  2261. hf, ok := f.(*HeadersFrame)
  2262. if !ok {
  2263. continue
  2264. }
  2265. var buf bytes.Buffer
  2266. enc := hpack.NewEncoder(&buf)
  2267. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2268. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: strconv.Itoa(len(response))})
  2269. ct.fr.WriteHeaders(HeadersFrameParam{
  2270. StreamID: hf.StreamID,
  2271. EndHeaders: true,
  2272. EndStream: false,
  2273. BlockFragment: buf.Bytes(),
  2274. })
  2275. ct.fr.WriteData(hf.StreamID, true, []byte(response))
  2276. <-clientDone
  2277. return nil
  2278. }
  2279. }
  2280. ct.run()
  2281. }
  2282. type neverEnding byte
  2283. func (b neverEnding) Read(p []byte) (int, error) {
  2284. for i := range p {
  2285. p[i] = byte(b)
  2286. }
  2287. return len(p), nil
  2288. }
  2289. // golang.org/issue/15425: test that a handler closing the request
  2290. // body doesn't terminate the stream to the peer. (It just stops
  2291. // readability from the handler's side, and eventually the client
  2292. // runs out of flow control tokens)
  2293. func TestTransportHandlerBodyClose(t *testing.T) {
  2294. const bodySize = 10 << 20
  2295. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2296. r.Body.Close()
  2297. io.Copy(w, io.LimitReader(neverEnding('A'), bodySize))
  2298. }, optOnlyServer)
  2299. defer st.Close()
  2300. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2301. defer tr.CloseIdleConnections()
  2302. g0 := runtime.NumGoroutine()
  2303. const numReq = 10
  2304. for i := 0; i < numReq; i++ {
  2305. req, err := http.NewRequest("POST", st.ts.URL, struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2306. if err != nil {
  2307. t.Fatal(err)
  2308. }
  2309. res, err := tr.RoundTrip(req)
  2310. if err != nil {
  2311. t.Fatal(err)
  2312. }
  2313. n, err := io.Copy(ioutil.Discard, res.Body)
  2314. res.Body.Close()
  2315. if n != bodySize || err != nil {
  2316. t.Fatalf("req#%d: Copy = %d, %v; want %d, nil", i, n, err, bodySize)
  2317. }
  2318. }
  2319. tr.CloseIdleConnections()
  2320. if !waitCondition(5*time.Second, 100*time.Millisecond, func() bool {
  2321. gd := runtime.NumGoroutine() - g0
  2322. return gd < numReq/2
  2323. }) {
  2324. t.Errorf("appeared to leak goroutines")
  2325. }
  2326. }
  2327. // https://golang.org/issue/15930
  2328. func TestTransportFlowControl(t *testing.T) {
  2329. const bufLen = 64 << 10
  2330. var total int64 = 100 << 20 // 100MB
  2331. if testing.Short() {
  2332. total = 10 << 20
  2333. }
  2334. var wrote int64 // updated atomically
  2335. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2336. b := make([]byte, bufLen)
  2337. for wrote < total {
  2338. n, err := w.Write(b)
  2339. atomic.AddInt64(&wrote, int64(n))
  2340. if err != nil {
  2341. t.Errorf("ResponseWriter.Write error: %v", err)
  2342. break
  2343. }
  2344. w.(http.Flusher).Flush()
  2345. }
  2346. }, optOnlyServer)
  2347. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2348. defer tr.CloseIdleConnections()
  2349. req, err := http.NewRequest("GET", st.ts.URL, nil)
  2350. if err != nil {
  2351. t.Fatal("NewRequest error:", err)
  2352. }
  2353. resp, err := tr.RoundTrip(req)
  2354. if err != nil {
  2355. t.Fatal("RoundTrip error:", err)
  2356. }
  2357. defer resp.Body.Close()
  2358. var read int64
  2359. b := make([]byte, bufLen)
  2360. for {
  2361. n, err := resp.Body.Read(b)
  2362. if err == io.EOF {
  2363. break
  2364. }
  2365. if err != nil {
  2366. t.Fatal("Read error:", err)
  2367. }
  2368. read += int64(n)
  2369. const max = transportDefaultStreamFlow
  2370. if w := atomic.LoadInt64(&wrote); -max > read-w || read-w > max {
  2371. t.Fatalf("Too much data inflight: server wrote %v bytes but client only received %v", w, read)
  2372. }
  2373. // Let the server get ahead of the client.
  2374. time.Sleep(1 * time.Millisecond)
  2375. }
  2376. }
  2377. // golang.org/issue/14627 -- if the server sends a GOAWAY frame, make
  2378. // the Transport remember it and return it back to users (via
  2379. // RoundTrip or request body reads) if needed (e.g. if the server
  2380. // proceeds to close the TCP connection before the client gets its
  2381. // response)
  2382. func TestTransportUsesGoAwayDebugError_RoundTrip(t *testing.T) {
  2383. testTransportUsesGoAwayDebugError(t, false)
  2384. }
  2385. func TestTransportUsesGoAwayDebugError_Body(t *testing.T) {
  2386. testTransportUsesGoAwayDebugError(t, true)
  2387. }
  2388. func testTransportUsesGoAwayDebugError(t *testing.T, failMidBody bool) {
  2389. ct := newClientTester(t)
  2390. clientDone := make(chan struct{})
  2391. const goAwayErrCode = ErrCodeHTTP11Required // arbitrary
  2392. const goAwayDebugData = "some debug data"
  2393. ct.client = func() error {
  2394. defer close(clientDone)
  2395. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2396. res, err := ct.tr.RoundTrip(req)
  2397. if failMidBody {
  2398. if err != nil {
  2399. return fmt.Errorf("unexpected client RoundTrip error: %v", err)
  2400. }
  2401. _, err = io.Copy(ioutil.Discard, res.Body)
  2402. res.Body.Close()
  2403. }
  2404. want := GoAwayError{
  2405. LastStreamID: 5,
  2406. ErrCode: goAwayErrCode,
  2407. DebugData: goAwayDebugData,
  2408. }
  2409. if !reflect.DeepEqual(err, want) {
  2410. t.Errorf("RoundTrip error = %T: %#v, want %T (%#v)", err, err, want, want)
  2411. }
  2412. return nil
  2413. }
  2414. ct.server = func() error {
  2415. ct.greet()
  2416. for {
  2417. f, err := ct.fr.ReadFrame()
  2418. if err != nil {
  2419. t.Logf("ReadFrame: %v", err)
  2420. return nil
  2421. }
  2422. hf, ok := f.(*HeadersFrame)
  2423. if !ok {
  2424. continue
  2425. }
  2426. if failMidBody {
  2427. var buf bytes.Buffer
  2428. enc := hpack.NewEncoder(&buf)
  2429. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2430. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2431. ct.fr.WriteHeaders(HeadersFrameParam{
  2432. StreamID: hf.StreamID,
  2433. EndHeaders: true,
  2434. EndStream: false,
  2435. BlockFragment: buf.Bytes(),
  2436. })
  2437. }
  2438. // Write two GOAWAY frames, to test that the Transport takes
  2439. // the interesting parts of both.
  2440. ct.fr.WriteGoAway(5, ErrCodeNo, []byte(goAwayDebugData))
  2441. ct.fr.WriteGoAway(5, goAwayErrCode, nil)
  2442. ct.sc.(*net.TCPConn).CloseWrite()
  2443. <-clientDone
  2444. return nil
  2445. }
  2446. }
  2447. ct.run()
  2448. }
  2449. func testTransportReturnsUnusedFlowControl(t *testing.T, oneDataFrame bool) {
  2450. ct := newClientTester(t)
  2451. clientClosed := make(chan struct{})
  2452. serverWroteFirstByte := make(chan struct{})
  2453. ct.client = func() error {
  2454. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2455. res, err := ct.tr.RoundTrip(req)
  2456. if err != nil {
  2457. return err
  2458. }
  2459. <-serverWroteFirstByte
  2460. if n, err := res.Body.Read(make([]byte, 1)); err != nil || n != 1 {
  2461. return fmt.Errorf("body read = %v, %v; want 1, nil", n, err)
  2462. }
  2463. res.Body.Close() // leaving 4999 bytes unread
  2464. close(clientClosed)
  2465. return nil
  2466. }
  2467. ct.server = func() error {
  2468. ct.greet()
  2469. var hf *HeadersFrame
  2470. for {
  2471. f, err := ct.fr.ReadFrame()
  2472. if err != nil {
  2473. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2474. }
  2475. switch f.(type) {
  2476. case *WindowUpdateFrame, *SettingsFrame:
  2477. continue
  2478. }
  2479. var ok bool
  2480. hf, ok = f.(*HeadersFrame)
  2481. if !ok {
  2482. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2483. }
  2484. break
  2485. }
  2486. var buf bytes.Buffer
  2487. enc := hpack.NewEncoder(&buf)
  2488. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2489. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2490. ct.fr.WriteHeaders(HeadersFrameParam{
  2491. StreamID: hf.StreamID,
  2492. EndHeaders: true,
  2493. EndStream: false,
  2494. BlockFragment: buf.Bytes(),
  2495. })
  2496. // Two cases:
  2497. // - Send one DATA frame with 5000 bytes.
  2498. // - Send two DATA frames with 1 and 4999 bytes each.
  2499. //
  2500. // In both cases, the client should consume one byte of data,
  2501. // refund that byte, then refund the following 4999 bytes.
  2502. //
  2503. // In the second case, the server waits for the client connection to
  2504. // close before seconding the second DATA frame. This tests the case
  2505. // where the client receives a DATA frame after it has reset the stream.
  2506. if oneDataFrame {
  2507. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 5000))
  2508. close(serverWroteFirstByte)
  2509. <-clientClosed
  2510. } else {
  2511. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 1))
  2512. close(serverWroteFirstByte)
  2513. <-clientClosed
  2514. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 4999))
  2515. }
  2516. waitingFor := "RSTStreamFrame"
  2517. for {
  2518. f, err := ct.fr.ReadFrame()
  2519. if err != nil {
  2520. return fmt.Errorf("ReadFrame while waiting for %s: %v", waitingFor, err)
  2521. }
  2522. if _, ok := f.(*SettingsFrame); ok {
  2523. continue
  2524. }
  2525. switch waitingFor {
  2526. case "RSTStreamFrame":
  2527. if rf, ok := f.(*RSTStreamFrame); !ok || rf.ErrCode != ErrCodeCancel {
  2528. return fmt.Errorf("Expected a RSTStreamFrame with code cancel; got %v", summarizeFrame(f))
  2529. }
  2530. waitingFor = "WindowUpdateFrame"
  2531. case "WindowUpdateFrame":
  2532. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != 4999 {
  2533. return fmt.Errorf("Expected WindowUpdateFrame for 4999 bytes; got %v", summarizeFrame(f))
  2534. }
  2535. return nil
  2536. }
  2537. }
  2538. }
  2539. ct.run()
  2540. }
  2541. // See golang.org/issue/16481
  2542. func TestTransportReturnsUnusedFlowControlSingleWrite(t *testing.T) {
  2543. testTransportReturnsUnusedFlowControl(t, true)
  2544. }
  2545. // See golang.org/issue/20469
  2546. func TestTransportReturnsUnusedFlowControlMultipleWrites(t *testing.T) {
  2547. testTransportReturnsUnusedFlowControl(t, false)
  2548. }
  2549. // Issue 16612: adjust flow control on open streams when transport
  2550. // receives SETTINGS with INITIAL_WINDOW_SIZE from server.
  2551. func TestTransportAdjustsFlowControl(t *testing.T) {
  2552. ct := newClientTester(t)
  2553. clientDone := make(chan struct{})
  2554. const bodySize = 1 << 20
  2555. ct.client = func() error {
  2556. defer ct.cc.(*net.TCPConn).CloseWrite()
  2557. defer close(clientDone)
  2558. req, _ := http.NewRequest("POST", "https://dummy.tld/", struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2559. res, err := ct.tr.RoundTrip(req)
  2560. if err != nil {
  2561. return err
  2562. }
  2563. res.Body.Close()
  2564. return nil
  2565. }
  2566. ct.server = func() error {
  2567. _, err := io.ReadFull(ct.sc, make([]byte, len(ClientPreface)))
  2568. if err != nil {
  2569. return fmt.Errorf("reading client preface: %v", err)
  2570. }
  2571. var gotBytes int64
  2572. var sentSettings bool
  2573. for {
  2574. f, err := ct.fr.ReadFrame()
  2575. if err != nil {
  2576. select {
  2577. case <-clientDone:
  2578. return nil
  2579. default:
  2580. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2581. }
  2582. }
  2583. switch f := f.(type) {
  2584. case *DataFrame:
  2585. gotBytes += int64(len(f.Data()))
  2586. // After we've got half the client's
  2587. // initial flow control window's worth
  2588. // of request body data, give it just
  2589. // enough flow control to finish.
  2590. if gotBytes >= initialWindowSize/2 && !sentSettings {
  2591. sentSettings = true
  2592. ct.fr.WriteSettings(Setting{ID: SettingInitialWindowSize, Val: bodySize})
  2593. ct.fr.WriteWindowUpdate(0, bodySize)
  2594. ct.fr.WriteSettingsAck()
  2595. }
  2596. if f.StreamEnded() {
  2597. var buf bytes.Buffer
  2598. enc := hpack.NewEncoder(&buf)
  2599. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2600. ct.fr.WriteHeaders(HeadersFrameParam{
  2601. StreamID: f.StreamID,
  2602. EndHeaders: true,
  2603. EndStream: true,
  2604. BlockFragment: buf.Bytes(),
  2605. })
  2606. }
  2607. }
  2608. }
  2609. }
  2610. ct.run()
  2611. }
  2612. // See golang.org/issue/16556
  2613. func TestTransportReturnsDataPaddingFlowControl(t *testing.T) {
  2614. ct := newClientTester(t)
  2615. unblockClient := make(chan bool, 1)
  2616. ct.client = func() error {
  2617. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2618. res, err := ct.tr.RoundTrip(req)
  2619. if err != nil {
  2620. return err
  2621. }
  2622. defer res.Body.Close()
  2623. <-unblockClient
  2624. return nil
  2625. }
  2626. ct.server = func() error {
  2627. ct.greet()
  2628. var hf *HeadersFrame
  2629. for {
  2630. f, err := ct.fr.ReadFrame()
  2631. if err != nil {
  2632. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2633. }
  2634. switch f.(type) {
  2635. case *WindowUpdateFrame, *SettingsFrame:
  2636. continue
  2637. }
  2638. var ok bool
  2639. hf, ok = f.(*HeadersFrame)
  2640. if !ok {
  2641. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2642. }
  2643. break
  2644. }
  2645. var buf bytes.Buffer
  2646. enc := hpack.NewEncoder(&buf)
  2647. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2648. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2649. ct.fr.WriteHeaders(HeadersFrameParam{
  2650. StreamID: hf.StreamID,
  2651. EndHeaders: true,
  2652. EndStream: false,
  2653. BlockFragment: buf.Bytes(),
  2654. })
  2655. pad := make([]byte, 5)
  2656. ct.fr.WriteDataPadded(hf.StreamID, false, make([]byte, 5000), pad) // without ending stream
  2657. f, err := ct.readNonSettingsFrame()
  2658. if err != nil {
  2659. return fmt.Errorf("ReadFrame while waiting for first WindowUpdateFrame: %v", err)
  2660. }
  2661. wantBack := uint32(len(pad)) + 1 // one byte for the length of the padding
  2662. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID != 0 {
  2663. return fmt.Errorf("Expected conn WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2664. }
  2665. f, err = ct.readNonSettingsFrame()
  2666. if err != nil {
  2667. return fmt.Errorf("ReadFrame while waiting for second WindowUpdateFrame: %v", err)
  2668. }
  2669. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID == 0 {
  2670. return fmt.Errorf("Expected stream WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2671. }
  2672. unblockClient <- true
  2673. return nil
  2674. }
  2675. ct.run()
  2676. }
  2677. // golang.org/issue/16572 -- RoundTrip shouldn't hang when it gets a
  2678. // StreamError as a result of the response HEADERS
  2679. func TestTransportReturnsErrorOnBadResponseHeaders(t *testing.T) {
  2680. ct := newClientTester(t)
  2681. ct.client = func() error {
  2682. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2683. res, err := ct.tr.RoundTrip(req)
  2684. if err == nil {
  2685. res.Body.Close()
  2686. return errors.New("unexpected successful GET")
  2687. }
  2688. want := StreamError{1, ErrCodeProtocol, headerFieldNameError(" content-type")}
  2689. if !reflect.DeepEqual(want, err) {
  2690. t.Errorf("RoundTrip error = %#v; want %#v", err, want)
  2691. }
  2692. return nil
  2693. }
  2694. ct.server = func() error {
  2695. ct.greet()
  2696. hf, err := ct.firstHeaders()
  2697. if err != nil {
  2698. return err
  2699. }
  2700. var buf bytes.Buffer
  2701. enc := hpack.NewEncoder(&buf)
  2702. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2703. enc.WriteField(hpack.HeaderField{Name: " content-type", Value: "bogus"}) // bogus spaces
  2704. ct.fr.WriteHeaders(HeadersFrameParam{
  2705. StreamID: hf.StreamID,
  2706. EndHeaders: true,
  2707. EndStream: false,
  2708. BlockFragment: buf.Bytes(),
  2709. })
  2710. for {
  2711. fr, err := ct.readFrame()
  2712. if err != nil {
  2713. return fmt.Errorf("error waiting for RST_STREAM from client: %v", err)
  2714. }
  2715. if _, ok := fr.(*SettingsFrame); ok {
  2716. continue
  2717. }
  2718. if rst, ok := fr.(*RSTStreamFrame); !ok || rst.StreamID != 1 || rst.ErrCode != ErrCodeProtocol {
  2719. t.Errorf("Frame = %v; want RST_STREAM for stream 1 with ErrCodeProtocol", summarizeFrame(fr))
  2720. }
  2721. break
  2722. }
  2723. return nil
  2724. }
  2725. ct.run()
  2726. }
  2727. // byteAndEOFReader returns is in an io.Reader which reads one byte
  2728. // (the underlying byte) and io.EOF at once in its Read call.
  2729. type byteAndEOFReader byte
  2730. func (b byteAndEOFReader) Read(p []byte) (n int, err error) {
  2731. if len(p) == 0 {
  2732. panic("unexpected useless call")
  2733. }
  2734. p[0] = byte(b)
  2735. return 1, io.EOF
  2736. }
  2737. // Issue 16788: the Transport had a regression where it started
  2738. // sending a spurious DATA frame with a duplicate END_STREAM bit after
  2739. // the request body writer goroutine had already read an EOF from the
  2740. // Request.Body and included the END_STREAM on a data-carrying DATA
  2741. // frame.
  2742. //
  2743. // Notably, to trigger this, the requests need to use a Request.Body
  2744. // which returns (non-0, io.EOF) and also needs to set the ContentLength
  2745. // explicitly.
  2746. func TestTransportBodyDoubleEndStream(t *testing.T) {
  2747. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2748. // Nothing.
  2749. }, optOnlyServer)
  2750. defer st.Close()
  2751. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2752. defer tr.CloseIdleConnections()
  2753. for i := 0; i < 2; i++ {
  2754. req, _ := http.NewRequest("POST", st.ts.URL, byteAndEOFReader('a'))
  2755. req.ContentLength = 1
  2756. res, err := tr.RoundTrip(req)
  2757. if err != nil {
  2758. t.Fatalf("failure on req %d: %v", i+1, err)
  2759. }
  2760. defer res.Body.Close()
  2761. }
  2762. }
  2763. // golang.org/issue/16847, golang.org/issue/19103
  2764. func TestTransportRequestPathPseudo(t *testing.T) {
  2765. type result struct {
  2766. path string
  2767. err string
  2768. }
  2769. tests := []struct {
  2770. req *http.Request
  2771. want result
  2772. }{
  2773. 0: {
  2774. req: &http.Request{
  2775. Method: "GET",
  2776. URL: &url.URL{
  2777. Host: "foo.com",
  2778. Path: "/foo",
  2779. },
  2780. },
  2781. want: result{path: "/foo"},
  2782. },
  2783. // In Go 1.7, we accepted paths of "//foo".
  2784. // In Go 1.8, we rejected it (issue 16847).
  2785. // In Go 1.9, we accepted it again (issue 19103).
  2786. 1: {
  2787. req: &http.Request{
  2788. Method: "GET",
  2789. URL: &url.URL{
  2790. Host: "foo.com",
  2791. Path: "//foo",
  2792. },
  2793. },
  2794. want: result{path: "//foo"},
  2795. },
  2796. // Opaque with //$Matching_Hostname/path
  2797. 2: {
  2798. req: &http.Request{
  2799. Method: "GET",
  2800. URL: &url.URL{
  2801. Scheme: "https",
  2802. Opaque: "//foo.com/path",
  2803. Host: "foo.com",
  2804. Path: "/ignored",
  2805. },
  2806. },
  2807. want: result{path: "/path"},
  2808. },
  2809. // Opaque with some other Request.Host instead:
  2810. 3: {
  2811. req: &http.Request{
  2812. Method: "GET",
  2813. Host: "bar.com",
  2814. URL: &url.URL{
  2815. Scheme: "https",
  2816. Opaque: "//bar.com/path",
  2817. Host: "foo.com",
  2818. Path: "/ignored",
  2819. },
  2820. },
  2821. want: result{path: "/path"},
  2822. },
  2823. // Opaque without the leading "//":
  2824. 4: {
  2825. req: &http.Request{
  2826. Method: "GET",
  2827. URL: &url.URL{
  2828. Opaque: "/path",
  2829. Host: "foo.com",
  2830. Path: "/ignored",
  2831. },
  2832. },
  2833. want: result{path: "/path"},
  2834. },
  2835. // Opaque we can't handle:
  2836. 5: {
  2837. req: &http.Request{
  2838. Method: "GET",
  2839. URL: &url.URL{
  2840. Scheme: "https",
  2841. Opaque: "//unknown_host/path",
  2842. Host: "foo.com",
  2843. Path: "/ignored",
  2844. },
  2845. },
  2846. want: result{err: `invalid request :path "https://unknown_host/path" from URL.Opaque = "//unknown_host/path"`},
  2847. },
  2848. // A CONNECT request:
  2849. 6: {
  2850. req: &http.Request{
  2851. Method: "CONNECT",
  2852. URL: &url.URL{
  2853. Host: "foo.com",
  2854. },
  2855. },
  2856. want: result{},
  2857. },
  2858. }
  2859. for i, tt := range tests {
  2860. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  2861. cc.henc = hpack.NewEncoder(&cc.hbuf)
  2862. cc.mu.Lock()
  2863. hdrs, err := cc.encodeHeaders(tt.req, false, "", -1)
  2864. cc.mu.Unlock()
  2865. var got result
  2866. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(f hpack.HeaderField) {
  2867. if f.Name == ":path" {
  2868. got.path = f.Value
  2869. }
  2870. })
  2871. if err != nil {
  2872. got.err = err.Error()
  2873. } else if len(hdrs) > 0 {
  2874. if _, err := hpackDec.Write(hdrs); err != nil {
  2875. t.Errorf("%d. bogus hpack: %v", i, err)
  2876. continue
  2877. }
  2878. }
  2879. if got != tt.want {
  2880. t.Errorf("%d. got %+v; want %+v", i, got, tt.want)
  2881. }
  2882. }
  2883. }
  2884. // golang.org/issue/17071 -- don't sniff the first byte of the request body
  2885. // before we've determined that the ClientConn is usable.
  2886. func TestRoundTripDoesntConsumeRequestBodyEarly(t *testing.T) {
  2887. const body = "foo"
  2888. req, _ := http.NewRequest("POST", "http://foo.com/", ioutil.NopCloser(strings.NewReader(body)))
  2889. cc := &ClientConn{
  2890. closed: true,
  2891. }
  2892. _, err := cc.RoundTrip(req)
  2893. if err != errClientConnUnusable {
  2894. t.Fatalf("RoundTrip = %v; want errClientConnUnusable", err)
  2895. }
  2896. slurp, err := ioutil.ReadAll(req.Body)
  2897. if err != nil {
  2898. t.Errorf("ReadAll = %v", err)
  2899. }
  2900. if string(slurp) != body {
  2901. t.Errorf("Body = %q; want %q", slurp, body)
  2902. }
  2903. }
  2904. func TestClientConnPing(t *testing.T) {
  2905. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {}, optOnlyServer)
  2906. defer st.Close()
  2907. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2908. defer tr.CloseIdleConnections()
  2909. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  2910. if err != nil {
  2911. t.Fatal(err)
  2912. }
  2913. if err = cc.Ping(context.Background()); err != nil {
  2914. t.Fatal(err)
  2915. }
  2916. }
  2917. // Issue 16974: if the server sent a DATA frame after the user
  2918. // canceled the Transport's Request, the Transport previously wrote to a
  2919. // closed pipe, got an error, and ended up closing the whole TCP
  2920. // connection.
  2921. func TestTransportCancelDataResponseRace(t *testing.T) {
  2922. cancel := make(chan struct{})
  2923. clientGotError := make(chan bool, 1)
  2924. const msg = "Hello."
  2925. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2926. if strings.Contains(r.URL.Path, "/hello") {
  2927. time.Sleep(50 * time.Millisecond)
  2928. io.WriteString(w, msg)
  2929. return
  2930. }
  2931. for i := 0; i < 50; i++ {
  2932. io.WriteString(w, "Some data.")
  2933. w.(http.Flusher).Flush()
  2934. if i == 2 {
  2935. close(cancel)
  2936. <-clientGotError
  2937. }
  2938. time.Sleep(10 * time.Millisecond)
  2939. }
  2940. }, optOnlyServer)
  2941. defer st.Close()
  2942. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2943. defer tr.CloseIdleConnections()
  2944. c := &http.Client{Transport: tr}
  2945. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2946. req.Cancel = cancel
  2947. res, err := c.Do(req)
  2948. if err != nil {
  2949. t.Fatal(err)
  2950. }
  2951. if _, err = io.Copy(ioutil.Discard, res.Body); err == nil {
  2952. t.Fatal("unexpected success")
  2953. }
  2954. clientGotError <- true
  2955. res, err = c.Get(st.ts.URL + "/hello")
  2956. if err != nil {
  2957. t.Fatal(err)
  2958. }
  2959. slurp, err := ioutil.ReadAll(res.Body)
  2960. if err != nil {
  2961. t.Fatal(err)
  2962. }
  2963. if string(slurp) != msg {
  2964. t.Errorf("Got = %q; want %q", slurp, msg)
  2965. }
  2966. }
  2967. // Issue 21316: It should be safe to reuse an http.Request after the
  2968. // request has completed.
  2969. func TestTransportNoRaceOnRequestObjectAfterRequestComplete(t *testing.T) {
  2970. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2971. w.WriteHeader(200)
  2972. io.WriteString(w, "body")
  2973. }, optOnlyServer)
  2974. defer st.Close()
  2975. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2976. defer tr.CloseIdleConnections()
  2977. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2978. resp, err := tr.RoundTrip(req)
  2979. if err != nil {
  2980. t.Fatal(err)
  2981. }
  2982. if _, err = io.Copy(ioutil.Discard, resp.Body); err != nil {
  2983. t.Fatalf("error reading response body: %v", err)
  2984. }
  2985. if err := resp.Body.Close(); err != nil {
  2986. t.Fatalf("error closing response body: %v", err)
  2987. }
  2988. // This access of req.Header should not race with code in the transport.
  2989. req.Header = http.Header{}
  2990. }
  2991. func TestTransportRetryAfterGOAWAY(t *testing.T) {
  2992. var dialer struct {
  2993. sync.Mutex
  2994. count int
  2995. }
  2996. ct1 := make(chan *clientTester)
  2997. ct2 := make(chan *clientTester)
  2998. ln := newLocalListener(t)
  2999. defer ln.Close()
  3000. tr := &Transport{
  3001. TLSClientConfig: tlsConfigInsecure,
  3002. }
  3003. tr.DialTLS = func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  3004. dialer.Lock()
  3005. defer dialer.Unlock()
  3006. dialer.count++
  3007. if dialer.count == 3 {
  3008. return nil, errors.New("unexpected number of dials")
  3009. }
  3010. cc, err := net.Dial("tcp", ln.Addr().String())
  3011. if err != nil {
  3012. return nil, fmt.Errorf("dial error: %v", err)
  3013. }
  3014. sc, err := ln.Accept()
  3015. if err != nil {
  3016. return nil, fmt.Errorf("accept error: %v", err)
  3017. }
  3018. ct := &clientTester{
  3019. t: t,
  3020. tr: tr,
  3021. cc: cc,
  3022. sc: sc,
  3023. fr: NewFramer(sc, sc),
  3024. }
  3025. switch dialer.count {
  3026. case 1:
  3027. ct1 <- ct
  3028. case 2:
  3029. ct2 <- ct
  3030. }
  3031. return cc, nil
  3032. }
  3033. errs := make(chan error, 3)
  3034. done := make(chan struct{})
  3035. defer close(done)
  3036. // Client.
  3037. go func() {
  3038. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3039. res, err := tr.RoundTrip(req)
  3040. if res != nil {
  3041. res.Body.Close()
  3042. if got := res.Header.Get("Foo"); got != "bar" {
  3043. err = fmt.Errorf("foo header = %q; want bar", got)
  3044. }
  3045. }
  3046. if err != nil {
  3047. err = fmt.Errorf("RoundTrip: %v", err)
  3048. }
  3049. errs <- err
  3050. }()
  3051. connToClose := make(chan io.Closer, 2)
  3052. // Server for the first request.
  3053. go func() {
  3054. var ct *clientTester
  3055. select {
  3056. case ct = <-ct1:
  3057. case <-done:
  3058. return
  3059. }
  3060. connToClose <- ct.cc
  3061. ct.greet()
  3062. hf, err := ct.firstHeaders()
  3063. if err != nil {
  3064. errs <- fmt.Errorf("server1 failed reading HEADERS: %v", err)
  3065. return
  3066. }
  3067. t.Logf("server1 got %v", hf)
  3068. if err := ct.fr.WriteGoAway(0 /*max id*/, ErrCodeNo, nil); err != nil {
  3069. errs <- fmt.Errorf("server1 failed writing GOAWAY: %v", err)
  3070. return
  3071. }
  3072. errs <- nil
  3073. }()
  3074. // Server for the second request.
  3075. go func() {
  3076. var ct *clientTester
  3077. select {
  3078. case ct = <-ct2:
  3079. case <-done:
  3080. return
  3081. }
  3082. connToClose <- ct.cc
  3083. ct.greet()
  3084. hf, err := ct.firstHeaders()
  3085. if err != nil {
  3086. errs <- fmt.Errorf("server2 failed reading HEADERS: %v", err)
  3087. return
  3088. }
  3089. t.Logf("server2 got %v", hf)
  3090. var buf bytes.Buffer
  3091. enc := hpack.NewEncoder(&buf)
  3092. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3093. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  3094. err = ct.fr.WriteHeaders(HeadersFrameParam{
  3095. StreamID: hf.StreamID,
  3096. EndHeaders: true,
  3097. EndStream: false,
  3098. BlockFragment: buf.Bytes(),
  3099. })
  3100. if err != nil {
  3101. errs <- fmt.Errorf("server2 failed writing response HEADERS: %v", err)
  3102. } else {
  3103. errs <- nil
  3104. }
  3105. }()
  3106. for k := 0; k < 3; k++ {
  3107. select {
  3108. case err := <-errs:
  3109. if err != nil {
  3110. t.Error(err)
  3111. }
  3112. case <-time.After(1 * time.Second):
  3113. t.Errorf("timed out")
  3114. }
  3115. }
  3116. for {
  3117. select {
  3118. case c := <-connToClose:
  3119. c.Close()
  3120. default:
  3121. return
  3122. }
  3123. }
  3124. }
  3125. func TestTransportRetryAfterRefusedStream(t *testing.T) {
  3126. clientDone := make(chan struct{})
  3127. ct := newClientTester(t)
  3128. ct.client = func() error {
  3129. defer ct.cc.(*net.TCPConn).CloseWrite()
  3130. defer close(clientDone)
  3131. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3132. resp, err := ct.tr.RoundTrip(req)
  3133. if err != nil {
  3134. return fmt.Errorf("RoundTrip: %v", err)
  3135. }
  3136. resp.Body.Close()
  3137. if resp.StatusCode != 204 {
  3138. return fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3139. }
  3140. return nil
  3141. }
  3142. ct.server = func() error {
  3143. ct.greet()
  3144. var buf bytes.Buffer
  3145. enc := hpack.NewEncoder(&buf)
  3146. nreq := 0
  3147. for {
  3148. f, err := ct.fr.ReadFrame()
  3149. if err != nil {
  3150. select {
  3151. case <-clientDone:
  3152. // If the client's done, it
  3153. // will have reported any
  3154. // errors on its side.
  3155. return nil
  3156. default:
  3157. return err
  3158. }
  3159. }
  3160. switch f := f.(type) {
  3161. case *WindowUpdateFrame, *SettingsFrame:
  3162. case *HeadersFrame:
  3163. if !f.HeadersEnded() {
  3164. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3165. }
  3166. nreq++
  3167. if nreq == 1 {
  3168. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3169. } else {
  3170. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3171. ct.fr.WriteHeaders(HeadersFrameParam{
  3172. StreamID: f.StreamID,
  3173. EndHeaders: true,
  3174. EndStream: true,
  3175. BlockFragment: buf.Bytes(),
  3176. })
  3177. }
  3178. default:
  3179. return fmt.Errorf("Unexpected client frame %v", f)
  3180. }
  3181. }
  3182. }
  3183. ct.run()
  3184. }
  3185. func TestTransportRetryHasLimit(t *testing.T) {
  3186. // Skip in short mode because the total expected delay is 1s+2s+4s+8s+16s=29s.
  3187. if testing.Short() {
  3188. t.Skip("skipping long test in short mode")
  3189. }
  3190. clientDone := make(chan struct{})
  3191. ct := newClientTester(t)
  3192. ct.client = func() error {
  3193. defer ct.cc.(*net.TCPConn).CloseWrite()
  3194. defer close(clientDone)
  3195. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3196. resp, err := ct.tr.RoundTrip(req)
  3197. if err == nil {
  3198. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3199. }
  3200. t.Logf("expected error, got: %v", err)
  3201. return nil
  3202. }
  3203. ct.server = func() error {
  3204. ct.greet()
  3205. for {
  3206. f, err := ct.fr.ReadFrame()
  3207. if err != nil {
  3208. select {
  3209. case <-clientDone:
  3210. // If the client's done, it
  3211. // will have reported any
  3212. // errors on its side.
  3213. return nil
  3214. default:
  3215. return err
  3216. }
  3217. }
  3218. switch f := f.(type) {
  3219. case *WindowUpdateFrame, *SettingsFrame:
  3220. case *HeadersFrame:
  3221. if !f.HeadersEnded() {
  3222. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3223. }
  3224. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3225. default:
  3226. return fmt.Errorf("Unexpected client frame %v", f)
  3227. }
  3228. }
  3229. }
  3230. ct.run()
  3231. }
  3232. func TestTransportResponseDataBeforeHeaders(t *testing.T) {
  3233. // This test use not valid response format.
  3234. // Discarding logger output to not spam tests output.
  3235. log.SetOutput(ioutil.Discard)
  3236. defer log.SetOutput(os.Stderr)
  3237. ct := newClientTester(t)
  3238. ct.client = func() error {
  3239. defer ct.cc.(*net.TCPConn).CloseWrite()
  3240. req := httptest.NewRequest("GET", "https://dummy.tld/", nil)
  3241. // First request is normal to ensure the check is per stream and not per connection.
  3242. _, err := ct.tr.RoundTrip(req)
  3243. if err != nil {
  3244. return fmt.Errorf("RoundTrip expected no error, got: %v", err)
  3245. }
  3246. // Second request returns a DATA frame with no HEADERS.
  3247. resp, err := ct.tr.RoundTrip(req)
  3248. if err == nil {
  3249. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3250. }
  3251. if err, ok := err.(StreamError); !ok || err.Code != ErrCodeProtocol {
  3252. return fmt.Errorf("expected stream PROTOCOL_ERROR, got: %v", err)
  3253. }
  3254. return nil
  3255. }
  3256. ct.server = func() error {
  3257. ct.greet()
  3258. for {
  3259. f, err := ct.fr.ReadFrame()
  3260. if err == io.EOF {
  3261. return nil
  3262. } else if err != nil {
  3263. return err
  3264. }
  3265. switch f := f.(type) {
  3266. case *WindowUpdateFrame, *SettingsFrame:
  3267. case *HeadersFrame:
  3268. switch f.StreamID {
  3269. case 1:
  3270. // Send a valid response to first request.
  3271. var buf bytes.Buffer
  3272. enc := hpack.NewEncoder(&buf)
  3273. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3274. ct.fr.WriteHeaders(HeadersFrameParam{
  3275. StreamID: f.StreamID,
  3276. EndHeaders: true,
  3277. EndStream: true,
  3278. BlockFragment: buf.Bytes(),
  3279. })
  3280. case 3:
  3281. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3282. }
  3283. default:
  3284. return fmt.Errorf("Unexpected client frame %v", f)
  3285. }
  3286. }
  3287. }
  3288. ct.run()
  3289. }
  3290. func TestTransportRequestsStallAtServerLimit(t *testing.T) {
  3291. const maxConcurrent = 2
  3292. greet := make(chan struct{}) // server sends initial SETTINGS frame
  3293. gotRequest := make(chan struct{}) // server received a request
  3294. clientDone := make(chan struct{})
  3295. // Collect errors from goroutines.
  3296. var wg sync.WaitGroup
  3297. errs := make(chan error, 100)
  3298. defer func() {
  3299. wg.Wait()
  3300. close(errs)
  3301. for err := range errs {
  3302. t.Error(err)
  3303. }
  3304. }()
  3305. // We will send maxConcurrent+2 requests. This checker goroutine waits for the
  3306. // following stages:
  3307. // 1. The first maxConcurrent requests are received by the server.
  3308. // 2. The client will cancel the next request
  3309. // 3. The server is unblocked so it can service the first maxConcurrent requests
  3310. // 4. The client will send the final request
  3311. wg.Add(1)
  3312. unblockClient := make(chan struct{})
  3313. clientRequestCancelled := make(chan struct{})
  3314. unblockServer := make(chan struct{})
  3315. go func() {
  3316. defer wg.Done()
  3317. // Stage 1.
  3318. for k := 0; k < maxConcurrent; k++ {
  3319. <-gotRequest
  3320. }
  3321. // Stage 2.
  3322. close(unblockClient)
  3323. <-clientRequestCancelled
  3324. // Stage 3: give some time for the final RoundTrip call to be scheduled and
  3325. // verify that the final request is not sent.
  3326. time.Sleep(50 * time.Millisecond)
  3327. select {
  3328. case <-gotRequest:
  3329. errs <- errors.New("last request did not stall")
  3330. close(unblockServer)
  3331. return
  3332. default:
  3333. }
  3334. close(unblockServer)
  3335. // Stage 4.
  3336. <-gotRequest
  3337. }()
  3338. ct := newClientTester(t)
  3339. ct.client = func() error {
  3340. var wg sync.WaitGroup
  3341. defer func() {
  3342. wg.Wait()
  3343. close(clientDone)
  3344. ct.cc.(*net.TCPConn).CloseWrite()
  3345. }()
  3346. for k := 0; k < maxConcurrent+2; k++ {
  3347. wg.Add(1)
  3348. go func(k int) {
  3349. defer wg.Done()
  3350. // Don't send the second request until after receiving SETTINGS from the server
  3351. // to avoid a race where we use the default SettingMaxConcurrentStreams, which
  3352. // is much larger than maxConcurrent. We have to send the first request before
  3353. // waiting because the first request triggers the dial and greet.
  3354. if k > 0 {
  3355. <-greet
  3356. }
  3357. // Block until maxConcurrent requests are sent before sending any more.
  3358. if k >= maxConcurrent {
  3359. <-unblockClient
  3360. }
  3361. req, _ := http.NewRequest("GET", fmt.Sprintf("https://dummy.tld/%d", k), nil)
  3362. if k == maxConcurrent {
  3363. // This request will be canceled.
  3364. cancel := make(chan struct{})
  3365. req.Cancel = cancel
  3366. close(cancel)
  3367. _, err := ct.tr.RoundTrip(req)
  3368. close(clientRequestCancelled)
  3369. if err == nil {
  3370. errs <- fmt.Errorf("RoundTrip(%d) should have failed due to cancel", k)
  3371. return
  3372. }
  3373. } else {
  3374. resp, err := ct.tr.RoundTrip(req)
  3375. if err != nil {
  3376. errs <- fmt.Errorf("RoundTrip(%d): %v", k, err)
  3377. return
  3378. }
  3379. ioutil.ReadAll(resp.Body)
  3380. resp.Body.Close()
  3381. if resp.StatusCode != 204 {
  3382. errs <- fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3383. return
  3384. }
  3385. }
  3386. }(k)
  3387. }
  3388. return nil
  3389. }
  3390. ct.server = func() error {
  3391. var wg sync.WaitGroup
  3392. defer wg.Wait()
  3393. ct.greet(Setting{SettingMaxConcurrentStreams, maxConcurrent})
  3394. // Server write loop.
  3395. var buf bytes.Buffer
  3396. enc := hpack.NewEncoder(&buf)
  3397. writeResp := make(chan uint32, maxConcurrent+1)
  3398. wg.Add(1)
  3399. go func() {
  3400. defer wg.Done()
  3401. <-unblockServer
  3402. for id := range writeResp {
  3403. buf.Reset()
  3404. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3405. ct.fr.WriteHeaders(HeadersFrameParam{
  3406. StreamID: id,
  3407. EndHeaders: true,
  3408. EndStream: true,
  3409. BlockFragment: buf.Bytes(),
  3410. })
  3411. }
  3412. }()
  3413. // Server read loop.
  3414. var nreq int
  3415. for {
  3416. f, err := ct.fr.ReadFrame()
  3417. if err != nil {
  3418. select {
  3419. case <-clientDone:
  3420. // If the client's done, it will have reported any errors on its side.
  3421. return nil
  3422. default:
  3423. return err
  3424. }
  3425. }
  3426. switch f := f.(type) {
  3427. case *WindowUpdateFrame:
  3428. case *SettingsFrame:
  3429. // Wait for the client SETTINGS ack until ending the greet.
  3430. close(greet)
  3431. case *HeadersFrame:
  3432. if !f.HeadersEnded() {
  3433. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3434. }
  3435. gotRequest <- struct{}{}
  3436. nreq++
  3437. writeResp <- f.StreamID
  3438. if nreq == maxConcurrent+1 {
  3439. close(writeResp)
  3440. }
  3441. default:
  3442. return fmt.Errorf("Unexpected client frame %v", f)
  3443. }
  3444. }
  3445. }
  3446. ct.run()
  3447. }
  3448. func TestAuthorityAddr(t *testing.T) {
  3449. tests := []struct {
  3450. scheme, authority string
  3451. want string
  3452. }{
  3453. {"http", "foo.com", "foo.com:80"},
  3454. {"https", "foo.com", "foo.com:443"},
  3455. {"https", "foo.com:1234", "foo.com:1234"},
  3456. {"https", "1.2.3.4:1234", "1.2.3.4:1234"},
  3457. {"https", "1.2.3.4", "1.2.3.4:443"},
  3458. {"https", "[::1]:1234", "[::1]:1234"},
  3459. {"https", "[::1]", "[::1]:443"},
  3460. }
  3461. for _, tt := range tests {
  3462. got := authorityAddr(tt.scheme, tt.authority)
  3463. if got != tt.want {
  3464. t.Errorf("authorityAddr(%q, %q) = %q; want %q", tt.scheme, tt.authority, got, tt.want)
  3465. }
  3466. }
  3467. }
  3468. // Issue 20448: stop allocating for DATA frames' payload after
  3469. // Response.Body.Close is called.
  3470. func TestTransportAllocationsAfterResponseBodyClose(t *testing.T) {
  3471. megabyteZero := make([]byte, 1<<20)
  3472. writeErr := make(chan error, 1)
  3473. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3474. w.(http.Flusher).Flush()
  3475. var sum int64
  3476. for i := 0; i < 100; i++ {
  3477. n, err := w.Write(megabyteZero)
  3478. sum += int64(n)
  3479. if err != nil {
  3480. writeErr <- err
  3481. return
  3482. }
  3483. }
  3484. t.Logf("wrote all %d bytes", sum)
  3485. writeErr <- nil
  3486. }, optOnlyServer)
  3487. defer st.Close()
  3488. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3489. defer tr.CloseIdleConnections()
  3490. c := &http.Client{Transport: tr}
  3491. res, err := c.Get(st.ts.URL)
  3492. if err != nil {
  3493. t.Fatal(err)
  3494. }
  3495. var buf [1]byte
  3496. if _, err := res.Body.Read(buf[:]); err != nil {
  3497. t.Error(err)
  3498. }
  3499. if err := res.Body.Close(); err != nil {
  3500. t.Error(err)
  3501. }
  3502. trb, ok := res.Body.(transportResponseBody)
  3503. if !ok {
  3504. t.Fatalf("res.Body = %T; want transportResponseBody", res.Body)
  3505. }
  3506. if trb.cs.bufPipe.b != nil {
  3507. t.Errorf("response body pipe is still open")
  3508. }
  3509. gotErr := <-writeErr
  3510. if gotErr == nil {
  3511. t.Errorf("Handler unexpectedly managed to write its entire response without getting an error")
  3512. } else if gotErr != errStreamClosed {
  3513. t.Errorf("Handler Write err = %v; want errStreamClosed", gotErr)
  3514. }
  3515. }
  3516. // Issue 18891: make sure Request.Body == NoBody means no DATA frame
  3517. // is ever sent, even if empty.
  3518. func TestTransportNoBodyMeansNoDATA(t *testing.T) {
  3519. ct := newClientTester(t)
  3520. unblockClient := make(chan bool)
  3521. ct.client = func() error {
  3522. req, _ := http.NewRequest("GET", "https://dummy.tld/", go18httpNoBody())
  3523. ct.tr.RoundTrip(req)
  3524. <-unblockClient
  3525. return nil
  3526. }
  3527. ct.server = func() error {
  3528. defer close(unblockClient)
  3529. defer ct.cc.(*net.TCPConn).Close()
  3530. ct.greet()
  3531. for {
  3532. f, err := ct.fr.ReadFrame()
  3533. if err != nil {
  3534. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  3535. }
  3536. switch f := f.(type) {
  3537. default:
  3538. return fmt.Errorf("Got %T; want HeadersFrame", f)
  3539. case *WindowUpdateFrame, *SettingsFrame:
  3540. continue
  3541. case *HeadersFrame:
  3542. if !f.StreamEnded() {
  3543. return fmt.Errorf("got headers frame without END_STREAM")
  3544. }
  3545. return nil
  3546. }
  3547. }
  3548. }
  3549. ct.run()
  3550. }
  3551. func benchSimpleRoundTrip(b *testing.B, nHeaders int) {
  3552. defer disableGoroutineTracking()()
  3553. b.ReportAllocs()
  3554. st := newServerTester(b,
  3555. func(w http.ResponseWriter, r *http.Request) {
  3556. },
  3557. optOnlyServer,
  3558. optQuiet,
  3559. )
  3560. defer st.Close()
  3561. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3562. defer tr.CloseIdleConnections()
  3563. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3564. if err != nil {
  3565. b.Fatal(err)
  3566. }
  3567. for i := 0; i < nHeaders; i++ {
  3568. name := fmt.Sprint("A-", i)
  3569. req.Header.Set(name, "*")
  3570. }
  3571. b.ResetTimer()
  3572. for i := 0; i < b.N; i++ {
  3573. res, err := tr.RoundTrip(req)
  3574. if err != nil {
  3575. if res != nil {
  3576. res.Body.Close()
  3577. }
  3578. b.Fatalf("RoundTrip err = %v; want nil", err)
  3579. }
  3580. res.Body.Close()
  3581. if res.StatusCode != http.StatusOK {
  3582. b.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3583. }
  3584. }
  3585. }
  3586. type infiniteReader struct{}
  3587. func (r infiniteReader) Read(b []byte) (int, error) {
  3588. return len(b), nil
  3589. }
  3590. // Issue 20521: it is not an error to receive a response and end stream
  3591. // from the server without the body being consumed.
  3592. func TestTransportResponseAndResetWithoutConsumingBodyRace(t *testing.T) {
  3593. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3594. w.WriteHeader(http.StatusOK)
  3595. }, optOnlyServer)
  3596. defer st.Close()
  3597. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3598. defer tr.CloseIdleConnections()
  3599. // The request body needs to be big enough to trigger flow control.
  3600. req, _ := http.NewRequest("PUT", st.ts.URL, infiniteReader{})
  3601. res, err := tr.RoundTrip(req)
  3602. if err != nil {
  3603. t.Fatal(err)
  3604. }
  3605. if res.StatusCode != http.StatusOK {
  3606. t.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3607. }
  3608. }
  3609. // Verify transport doesn't crash when receiving bogus response lacking a :status header.
  3610. // Issue 22880.
  3611. func TestTransportHandlesInvalidStatuslessResponse(t *testing.T) {
  3612. ct := newClientTester(t)
  3613. ct.client = func() error {
  3614. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3615. _, err := ct.tr.RoundTrip(req)
  3616. const substr = "malformed response from server: missing status pseudo header"
  3617. if !strings.Contains(fmt.Sprint(err), substr) {
  3618. return fmt.Errorf("RoundTrip error = %v; want substring %q", err, substr)
  3619. }
  3620. return nil
  3621. }
  3622. ct.server = func() error {
  3623. ct.greet()
  3624. var buf bytes.Buffer
  3625. enc := hpack.NewEncoder(&buf)
  3626. for {
  3627. f, err := ct.fr.ReadFrame()
  3628. if err != nil {
  3629. return err
  3630. }
  3631. switch f := f.(type) {
  3632. case *HeadersFrame:
  3633. enc.WriteField(hpack.HeaderField{Name: "content-type", Value: "text/html"}) // no :status header
  3634. ct.fr.WriteHeaders(HeadersFrameParam{
  3635. StreamID: f.StreamID,
  3636. EndHeaders: true,
  3637. EndStream: false, // we'll send some DATA to try to crash the transport
  3638. BlockFragment: buf.Bytes(),
  3639. })
  3640. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3641. return nil
  3642. }
  3643. }
  3644. }
  3645. ct.run()
  3646. }
  3647. func BenchmarkClientRequestHeaders(b *testing.B) {
  3648. b.Run(" 0 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 0) })
  3649. b.Run(" 10 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 10) })
  3650. b.Run(" 100 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 100) })
  3651. b.Run("1000 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 1000) })
  3652. }
  3653. func activeStreams(cc *ClientConn) int {
  3654. cc.mu.Lock()
  3655. defer cc.mu.Unlock()
  3656. return len(cc.streams)
  3657. }
  3658. type closeMode int
  3659. const (
  3660. closeAtHeaders closeMode = iota
  3661. closeAtBody
  3662. shutdown
  3663. shutdownCancel
  3664. )
  3665. // See golang.org/issue/17292
  3666. func testClientConnClose(t *testing.T, closeMode closeMode) {
  3667. clientDone := make(chan struct{})
  3668. defer close(clientDone)
  3669. handlerDone := make(chan struct{})
  3670. closeDone := make(chan struct{})
  3671. beforeHeader := func() {}
  3672. bodyWrite := func(w http.ResponseWriter) {}
  3673. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3674. defer close(handlerDone)
  3675. beforeHeader()
  3676. w.WriteHeader(http.StatusOK)
  3677. w.(http.Flusher).Flush()
  3678. bodyWrite(w)
  3679. select {
  3680. case <-w.(http.CloseNotifier).CloseNotify():
  3681. // client closed connection before completion
  3682. if closeMode == shutdown || closeMode == shutdownCancel {
  3683. t.Error("expected request to complete")
  3684. }
  3685. case <-clientDone:
  3686. if closeMode == closeAtHeaders || closeMode == closeAtBody {
  3687. t.Error("expected connection closed by client")
  3688. }
  3689. }
  3690. }, optOnlyServer)
  3691. defer st.Close()
  3692. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3693. defer tr.CloseIdleConnections()
  3694. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  3695. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3696. if err != nil {
  3697. t.Fatal(err)
  3698. }
  3699. if closeMode == closeAtHeaders {
  3700. beforeHeader = func() {
  3701. if err := cc.Close(); err != nil {
  3702. t.Error(err)
  3703. }
  3704. close(closeDone)
  3705. }
  3706. }
  3707. var sendBody chan struct{}
  3708. if closeMode == closeAtBody {
  3709. sendBody = make(chan struct{})
  3710. bodyWrite = func(w http.ResponseWriter) {
  3711. <-sendBody
  3712. b := make([]byte, 32)
  3713. w.Write(b)
  3714. w.(http.Flusher).Flush()
  3715. if err := cc.Close(); err != nil {
  3716. t.Errorf("unexpected ClientConn close error: %v", err)
  3717. }
  3718. close(closeDone)
  3719. w.Write(b)
  3720. w.(http.Flusher).Flush()
  3721. }
  3722. }
  3723. res, err := cc.RoundTrip(req)
  3724. if res != nil {
  3725. defer res.Body.Close()
  3726. }
  3727. if closeMode == closeAtHeaders {
  3728. got := fmt.Sprint(err)
  3729. want := "http2: client connection force closed via ClientConn.Close"
  3730. if got != want {
  3731. t.Fatalf("RoundTrip error = %v, want %v", got, want)
  3732. }
  3733. } else {
  3734. if err != nil {
  3735. t.Fatalf("RoundTrip: %v", err)
  3736. }
  3737. if got, want := activeStreams(cc), 1; got != want {
  3738. t.Errorf("got %d active streams, want %d", got, want)
  3739. }
  3740. }
  3741. switch closeMode {
  3742. case shutdownCancel:
  3743. if err = cc.Shutdown(canceledCtx); err != errCanceled {
  3744. t.Errorf("got %v, want %v", err, errCanceled)
  3745. }
  3746. if cc.closing == false {
  3747. t.Error("expected closing to be true")
  3748. }
  3749. if cc.CanTakeNewRequest() == true {
  3750. t.Error("CanTakeNewRequest to return false")
  3751. }
  3752. if v, want := len(cc.streams), 1; v != want {
  3753. t.Errorf("expected %d active streams, got %d", want, v)
  3754. }
  3755. clientDone <- struct{}{}
  3756. <-handlerDone
  3757. case shutdown:
  3758. wait := make(chan struct{})
  3759. shutdownEnterWaitStateHook = func() {
  3760. close(wait)
  3761. shutdownEnterWaitStateHook = func() {}
  3762. }
  3763. defer func() { shutdownEnterWaitStateHook = func() {} }()
  3764. shutdown := make(chan struct{}, 1)
  3765. go func() {
  3766. if err = cc.Shutdown(context.Background()); err != nil {
  3767. t.Error(err)
  3768. }
  3769. close(shutdown)
  3770. }()
  3771. // Let the shutdown to enter wait state
  3772. <-wait
  3773. cc.mu.Lock()
  3774. if cc.closing == false {
  3775. t.Error("expected closing to be true")
  3776. }
  3777. cc.mu.Unlock()
  3778. if cc.CanTakeNewRequest() == true {
  3779. t.Error("CanTakeNewRequest to return false")
  3780. }
  3781. if got, want := activeStreams(cc), 1; got != want {
  3782. t.Errorf("got %d active streams, want %d", got, want)
  3783. }
  3784. // Let the active request finish
  3785. clientDone <- struct{}{}
  3786. // Wait for the shutdown to end
  3787. select {
  3788. case <-shutdown:
  3789. case <-time.After(2 * time.Second):
  3790. t.Fatal("expected server connection to close")
  3791. }
  3792. case closeAtHeaders, closeAtBody:
  3793. if closeMode == closeAtBody {
  3794. go close(sendBody)
  3795. if _, err := io.Copy(ioutil.Discard, res.Body); err == nil {
  3796. t.Error("expected a Copy error, got nil")
  3797. }
  3798. }
  3799. <-closeDone
  3800. if got, want := activeStreams(cc), 0; got != want {
  3801. t.Errorf("got %d active streams, want %d", got, want)
  3802. }
  3803. // wait for server to get the connection close notice
  3804. select {
  3805. case <-handlerDone:
  3806. case <-time.After(2 * time.Second):
  3807. t.Fatal("expected server connection to close")
  3808. }
  3809. }
  3810. }
  3811. // The client closes the connection just after the server got the client's HEADERS
  3812. // frame, but before the server sends its HEADERS response back. The expected
  3813. // result is an error on RoundTrip explaining the client closed the connection.
  3814. func TestClientConnCloseAtHeaders(t *testing.T) {
  3815. testClientConnClose(t, closeAtHeaders)
  3816. }
  3817. // The client closes the connection between two server's response DATA frames.
  3818. // The expected behavior is a response body io read error on the client.
  3819. func TestClientConnCloseAtBody(t *testing.T) {
  3820. testClientConnClose(t, closeAtBody)
  3821. }
  3822. // The client sends a GOAWAY frame before the server finished processing a request.
  3823. // We expect the connection not to close until the request is completed.
  3824. func TestClientConnShutdown(t *testing.T) {
  3825. testClientConnClose(t, shutdown)
  3826. }
  3827. // The client sends a GOAWAY frame before the server finishes processing a request,
  3828. // but cancels the passed context before the request is completed. The expected
  3829. // behavior is the client closing the connection after the context is canceled.
  3830. func TestClientConnShutdownCancel(t *testing.T) {
  3831. testClientConnClose(t, shutdownCancel)
  3832. }
  3833. // Issue 25009: use Request.GetBody if present, even if it seems like
  3834. // we might not need it. Apparently something else can still read from
  3835. // the original request body. Data race? In any case, rewinding
  3836. // unconditionally on retry is a nicer model anyway and should
  3837. // simplify code in the future (after the Go 1.11 freeze)
  3838. func TestTransportUsesGetBodyWhenPresent(t *testing.T) {
  3839. calls := 0
  3840. someBody := func() io.ReadCloser {
  3841. return struct{ io.ReadCloser }{ioutil.NopCloser(bytes.NewReader(nil))}
  3842. }
  3843. req := &http.Request{
  3844. Body: someBody(),
  3845. GetBody: func() (io.ReadCloser, error) {
  3846. calls++
  3847. return someBody(), nil
  3848. },
  3849. }
  3850. afterBodyWrite := false // pretend we haven't read+written the body yet
  3851. req2, err := shouldRetryRequest(req, errClientConnUnusable, afterBodyWrite)
  3852. if err != nil {
  3853. t.Fatal(err)
  3854. }
  3855. if calls != 1 {
  3856. t.Errorf("Calls = %d; want 1", calls)
  3857. }
  3858. if req2 == req {
  3859. t.Error("req2 changed")
  3860. }
  3861. if req2 == nil {
  3862. t.Fatal("req2 is nil")
  3863. }
  3864. if req2.Body == nil {
  3865. t.Fatal("req2.Body is nil")
  3866. }
  3867. if req2.GetBody == nil {
  3868. t.Fatal("req2.GetBody is nil")
  3869. }
  3870. if req2.Body == req.Body {
  3871. t.Error("req2.Body unchanged")
  3872. }
  3873. }
  3874. // Issue 22891: verify that the "https" altproto we register with net/http
  3875. // is a certain type: a struct with one field with our *http2.Transport in it.
  3876. func TestNoDialH2RoundTripperType(t *testing.T) {
  3877. t1 := new(http.Transport)
  3878. t2 := new(Transport)
  3879. rt := noDialH2RoundTripper{t2}
  3880. if err := registerHTTPSProtocol(t1, rt); err != nil {
  3881. t.Fatal(err)
  3882. }
  3883. rv := reflect.ValueOf(rt)
  3884. if rv.Type().Kind() != reflect.Struct {
  3885. t.Fatalf("kind = %v; net/http expects struct", rv.Type().Kind())
  3886. }
  3887. if n := rv.Type().NumField(); n != 1 {
  3888. t.Fatalf("fields = %d; net/http expects 1", n)
  3889. }
  3890. v := rv.Field(0)
  3891. if _, ok := v.Interface().(*Transport); !ok {
  3892. t.Fatalf("wrong kind %T; want *Transport", v.Interface())
  3893. }
  3894. }