server_test.go 90 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. logBuf *bytes.Buffer
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // writing headers:
  48. headerBuf bytes.Buffer
  49. hpackEnc *hpack.Encoder
  50. // reading frames:
  51. frc chan Frame
  52. frErrc chan error
  53. readTimer *time.Timer
  54. }
  55. func init() {
  56. testHookOnPanicMu = new(sync.Mutex)
  57. }
  58. func resetHooks() {
  59. testHookOnPanicMu.Lock()
  60. testHookOnPanic = nil
  61. testHookOnPanicMu.Unlock()
  62. }
  63. type serverTesterOpt string
  64. var optOnlyServer = serverTesterOpt("only_server")
  65. var optQuiet = serverTesterOpt("quiet_logging")
  66. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  67. resetHooks()
  68. logBuf := new(bytes.Buffer)
  69. ts := httptest.NewUnstartedServer(handler)
  70. tlsConfig := &tls.Config{
  71. InsecureSkipVerify: true,
  72. // The h2-14 is temporary, until curl is updated. (as used by unit tests
  73. // in Docker)
  74. NextProtos: []string{NextProtoTLS, "h2-14"},
  75. }
  76. var onlyServer, quiet bool
  77. for _, opt := range opts {
  78. switch v := opt.(type) {
  79. case func(*tls.Config):
  80. v(tlsConfig)
  81. case func(*httptest.Server):
  82. v(ts)
  83. case serverTesterOpt:
  84. switch v {
  85. case optOnlyServer:
  86. onlyServer = true
  87. case optQuiet:
  88. quiet = true
  89. }
  90. case func(net.Conn, http.ConnState):
  91. ts.Config.ConnState = v
  92. default:
  93. t.Fatalf("unknown newServerTester option type %T", v)
  94. }
  95. }
  96. ConfigureServer(ts.Config, &Server{})
  97. st := &serverTester{
  98. t: t,
  99. ts: ts,
  100. logBuf: logBuf,
  101. frc: make(chan Frame, 1),
  102. frErrc: make(chan error, 1),
  103. }
  104. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  105. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  106. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  107. if quiet {
  108. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  109. } else {
  110. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  111. }
  112. ts.StartTLS()
  113. if VerboseLogs {
  114. t.Logf("Running test server at: %s", ts.URL)
  115. }
  116. testHookGetServerConn = func(v *serverConn) {
  117. st.scMu.Lock()
  118. defer st.scMu.Unlock()
  119. st.sc = v
  120. st.sc.testHookCh = make(chan func(int))
  121. }
  122. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  123. if !onlyServer {
  124. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  125. if err != nil {
  126. t.Fatal(err)
  127. }
  128. st.cc = cc
  129. st.fr = NewFramer(cc, cc)
  130. }
  131. return st
  132. }
  133. func (st *serverTester) closeConn() {
  134. st.scMu.Lock()
  135. defer st.scMu.Unlock()
  136. st.sc.conn.Close()
  137. }
  138. func (st *serverTester) addLogFilter(phrase string) {
  139. st.logFilter = append(st.logFilter, phrase)
  140. }
  141. func (st *serverTester) stream(id uint32) *stream {
  142. ch := make(chan *stream, 1)
  143. st.sc.testHookCh <- func(int) {
  144. ch <- st.sc.streams[id]
  145. }
  146. return <-ch
  147. }
  148. func (st *serverTester) streamState(id uint32) streamState {
  149. ch := make(chan streamState, 1)
  150. st.sc.testHookCh <- func(int) {
  151. state, _ := st.sc.state(id)
  152. ch <- state
  153. }
  154. return <-ch
  155. }
  156. // loopNum reports how many times this conn's select loop has gone around.
  157. func (st *serverTester) loopNum() int {
  158. lastc := make(chan int, 1)
  159. st.sc.testHookCh <- func(loopNum int) {
  160. lastc <- loopNum
  161. }
  162. return <-lastc
  163. }
  164. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  165. // The heuristic is that the server connection's serve loop must schedule
  166. // 50 times in a row without any channel sends or receives occurring.
  167. func (st *serverTester) awaitIdle() {
  168. remain := 50
  169. last := st.loopNum()
  170. for remain > 0 {
  171. n := st.loopNum()
  172. if n == last+1 {
  173. remain--
  174. } else {
  175. remain = 50
  176. }
  177. last = n
  178. }
  179. }
  180. func (st *serverTester) Close() {
  181. if st.t.Failed() {
  182. // If we failed already (and are likely in a Fatal,
  183. // unwindowing), force close the connection, so the
  184. // httptest.Server doesn't wait forever for the conn
  185. // to close.
  186. if st.cc != nil {
  187. st.cc.Close()
  188. }
  189. }
  190. st.ts.Close()
  191. if st.cc != nil {
  192. st.cc.Close()
  193. }
  194. log.SetOutput(os.Stderr)
  195. }
  196. // greet initiates the client's HTTP/2 connection into a state where
  197. // frames may be sent.
  198. func (st *serverTester) greet() {
  199. st.writePreface()
  200. st.writeInitialSettings()
  201. st.wantSettings()
  202. st.writeSettingsAck()
  203. st.wantSettingsAck()
  204. }
  205. func (st *serverTester) writePreface() {
  206. n, err := st.cc.Write(clientPreface)
  207. if err != nil {
  208. st.t.Fatalf("Error writing client preface: %v", err)
  209. }
  210. if n != len(clientPreface) {
  211. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  212. }
  213. }
  214. func (st *serverTester) writeInitialSettings() {
  215. if err := st.fr.WriteSettings(); err != nil {
  216. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  217. }
  218. }
  219. func (st *serverTester) writeSettingsAck() {
  220. if err := st.fr.WriteSettingsAck(); err != nil {
  221. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  222. }
  223. }
  224. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  225. if err := st.fr.WriteHeaders(p); err != nil {
  226. st.t.Fatalf("Error writing HEADERS: %v", err)
  227. }
  228. }
  229. func (st *serverTester) encodeHeaderField(k, v string) {
  230. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  231. if err != nil {
  232. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  233. }
  234. }
  235. // encodeHeaderRaw is the magic-free version of encodeHeader.
  236. // It takes 0 or more (k, v) pairs and encodes them.
  237. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  238. if len(headers)%2 == 1 {
  239. panic("odd number of kv args")
  240. }
  241. st.headerBuf.Reset()
  242. for len(headers) > 0 {
  243. k, v := headers[0], headers[1]
  244. st.encodeHeaderField(k, v)
  245. headers = headers[2:]
  246. }
  247. return st.headerBuf.Bytes()
  248. }
  249. // encodeHeader encodes headers and returns their HPACK bytes. headers
  250. // must contain an even number of key/value pairs. There may be
  251. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  252. // :scheme headers default to GET, / and https.
  253. func (st *serverTester) encodeHeader(headers ...string) []byte {
  254. if len(headers)%2 == 1 {
  255. panic("odd number of kv args")
  256. }
  257. st.headerBuf.Reset()
  258. if len(headers) == 0 {
  259. // Fast path, mostly for benchmarks, so test code doesn't pollute
  260. // profiles when we're looking to improve server allocations.
  261. st.encodeHeaderField(":method", "GET")
  262. st.encodeHeaderField(":path", "/")
  263. st.encodeHeaderField(":scheme", "https")
  264. return st.headerBuf.Bytes()
  265. }
  266. if len(headers) == 2 && headers[0] == ":method" {
  267. // Another fast path for benchmarks.
  268. st.encodeHeaderField(":method", headers[1])
  269. st.encodeHeaderField(":path", "/")
  270. st.encodeHeaderField(":scheme", "https")
  271. return st.headerBuf.Bytes()
  272. }
  273. pseudoCount := map[string]int{}
  274. keys := []string{":method", ":path", ":scheme"}
  275. vals := map[string][]string{
  276. ":method": {"GET"},
  277. ":path": {"/"},
  278. ":scheme": {"https"},
  279. }
  280. for len(headers) > 0 {
  281. k, v := headers[0], headers[1]
  282. headers = headers[2:]
  283. if _, ok := vals[k]; !ok {
  284. keys = append(keys, k)
  285. }
  286. if strings.HasPrefix(k, ":") {
  287. pseudoCount[k]++
  288. if pseudoCount[k] == 1 {
  289. vals[k] = []string{v}
  290. } else {
  291. // Allows testing of invalid headers w/ dup pseudo fields.
  292. vals[k] = append(vals[k], v)
  293. }
  294. } else {
  295. vals[k] = append(vals[k], v)
  296. }
  297. }
  298. for _, k := range keys {
  299. for _, v := range vals[k] {
  300. st.encodeHeaderField(k, v)
  301. }
  302. }
  303. return st.headerBuf.Bytes()
  304. }
  305. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  306. func (st *serverTester) bodylessReq1(headers ...string) {
  307. st.writeHeaders(HeadersFrameParam{
  308. StreamID: 1, // clients send odd numbers
  309. BlockFragment: st.encodeHeader(headers...),
  310. EndStream: true,
  311. EndHeaders: true,
  312. })
  313. }
  314. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  315. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  316. st.t.Fatalf("Error writing DATA: %v", err)
  317. }
  318. }
  319. func (st *serverTester) readFrame() (Frame, error) {
  320. go func() {
  321. fr, err := st.fr.ReadFrame()
  322. if err != nil {
  323. st.frErrc <- err
  324. } else {
  325. st.frc <- fr
  326. }
  327. }()
  328. t := st.readTimer
  329. if t == nil {
  330. t = time.NewTimer(2 * time.Second)
  331. st.readTimer = t
  332. }
  333. t.Reset(2 * time.Second)
  334. defer t.Stop()
  335. select {
  336. case f := <-st.frc:
  337. return f, nil
  338. case err := <-st.frErrc:
  339. return nil, err
  340. case <-t.C:
  341. return nil, errors.New("timeout waiting for frame")
  342. }
  343. }
  344. func (st *serverTester) wantHeaders() *HeadersFrame {
  345. f, err := st.readFrame()
  346. if err != nil {
  347. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  348. }
  349. hf, ok := f.(*HeadersFrame)
  350. if !ok {
  351. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  352. }
  353. return hf
  354. }
  355. func (st *serverTester) wantContinuation() *ContinuationFrame {
  356. f, err := st.readFrame()
  357. if err != nil {
  358. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  359. }
  360. cf, ok := f.(*ContinuationFrame)
  361. if !ok {
  362. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  363. }
  364. return cf
  365. }
  366. func (st *serverTester) wantData() *DataFrame {
  367. f, err := st.readFrame()
  368. if err != nil {
  369. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  370. }
  371. df, ok := f.(*DataFrame)
  372. if !ok {
  373. st.t.Fatalf("got a %T; want *DataFrame", f)
  374. }
  375. return df
  376. }
  377. func (st *serverTester) wantSettings() *SettingsFrame {
  378. f, err := st.readFrame()
  379. if err != nil {
  380. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  381. }
  382. sf, ok := f.(*SettingsFrame)
  383. if !ok {
  384. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  385. }
  386. return sf
  387. }
  388. func (st *serverTester) wantPing() *PingFrame {
  389. f, err := st.readFrame()
  390. if err != nil {
  391. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  392. }
  393. pf, ok := f.(*PingFrame)
  394. if !ok {
  395. st.t.Fatalf("got a %T; want *PingFrame", f)
  396. }
  397. return pf
  398. }
  399. func (st *serverTester) wantGoAway() *GoAwayFrame {
  400. f, err := st.readFrame()
  401. if err != nil {
  402. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  403. }
  404. gf, ok := f.(*GoAwayFrame)
  405. if !ok {
  406. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  407. }
  408. return gf
  409. }
  410. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  411. f, err := st.readFrame()
  412. if err != nil {
  413. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  414. }
  415. rs, ok := f.(*RSTStreamFrame)
  416. if !ok {
  417. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  418. }
  419. if rs.FrameHeader.StreamID != streamID {
  420. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  421. }
  422. if rs.ErrCode != errCode {
  423. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  424. }
  425. }
  426. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  427. f, err := st.readFrame()
  428. if err != nil {
  429. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  430. }
  431. wu, ok := f.(*WindowUpdateFrame)
  432. if !ok {
  433. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  434. }
  435. if wu.FrameHeader.StreamID != streamID {
  436. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  437. }
  438. if wu.Increment != incr {
  439. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  440. }
  441. }
  442. func (st *serverTester) wantSettingsAck() {
  443. f, err := st.readFrame()
  444. if err != nil {
  445. st.t.Fatal(err)
  446. }
  447. sf, ok := f.(*SettingsFrame)
  448. if !ok {
  449. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  450. }
  451. if !sf.Header().Flags.Has(FlagSettingsAck) {
  452. st.t.Fatal("Settings Frame didn't have ACK set")
  453. }
  454. }
  455. func TestServer(t *testing.T) {
  456. gotReq := make(chan bool, 1)
  457. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  458. w.Header().Set("Foo", "Bar")
  459. gotReq <- true
  460. })
  461. defer st.Close()
  462. covers("3.5", `
  463. The server connection preface consists of a potentially empty
  464. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  465. server sends in the HTTP/2 connection.
  466. `)
  467. st.writePreface()
  468. st.writeInitialSettings()
  469. st.wantSettings()
  470. st.writeSettingsAck()
  471. st.wantSettingsAck()
  472. st.writeHeaders(HeadersFrameParam{
  473. StreamID: 1, // clients send odd numbers
  474. BlockFragment: st.encodeHeader(),
  475. EndStream: true, // no DATA frames
  476. EndHeaders: true,
  477. })
  478. select {
  479. case <-gotReq:
  480. case <-time.After(2 * time.Second):
  481. t.Error("timeout waiting for request")
  482. }
  483. }
  484. func TestServer_Request_Get(t *testing.T) {
  485. testServerRequest(t, func(st *serverTester) {
  486. st.writeHeaders(HeadersFrameParam{
  487. StreamID: 1, // clients send odd numbers
  488. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  489. EndStream: true, // no DATA frames
  490. EndHeaders: true,
  491. })
  492. }, func(r *http.Request) {
  493. if r.Method != "GET" {
  494. t.Errorf("Method = %q; want GET", r.Method)
  495. }
  496. if r.URL.Path != "/" {
  497. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  498. }
  499. if r.ContentLength != 0 {
  500. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  501. }
  502. if r.Close {
  503. t.Error("Close = true; want false")
  504. }
  505. if !strings.Contains(r.RemoteAddr, ":") {
  506. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  507. }
  508. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  509. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  510. }
  511. wantHeader := http.Header{
  512. "Foo-Bar": []string{"some-value"},
  513. }
  514. if !reflect.DeepEqual(r.Header, wantHeader) {
  515. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  516. }
  517. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  518. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  519. }
  520. })
  521. }
  522. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  523. testServerRequest(t, func(st *serverTester) {
  524. st.writeHeaders(HeadersFrameParam{
  525. StreamID: 1, // clients send odd numbers
  526. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  527. EndStream: true, // no DATA frames
  528. EndHeaders: true,
  529. })
  530. }, func(r *http.Request) {
  531. if r.RequestURI != "/%2f/" {
  532. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  533. }
  534. if r.URL.Path != "///" {
  535. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  536. }
  537. })
  538. }
  539. // TODO: add a test with EndStream=true on the HEADERS but setting a
  540. // Content-Length anyway. Should we just omit it and force it to
  541. // zero?
  542. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  543. testServerRequest(t, func(st *serverTester) {
  544. st.writeHeaders(HeadersFrameParam{
  545. StreamID: 1, // clients send odd numbers
  546. BlockFragment: st.encodeHeader(":method", "POST"),
  547. EndStream: true,
  548. EndHeaders: true,
  549. })
  550. }, func(r *http.Request) {
  551. if r.Method != "POST" {
  552. t.Errorf("Method = %q; want POST", r.Method)
  553. }
  554. if r.ContentLength != 0 {
  555. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  556. }
  557. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  558. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  559. }
  560. })
  561. }
  562. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  563. testBodyContents(t, -1, "", func(st *serverTester) {
  564. st.writeHeaders(HeadersFrameParam{
  565. StreamID: 1, // clients send odd numbers
  566. BlockFragment: st.encodeHeader(":method", "POST"),
  567. EndStream: false, // to say DATA frames are coming
  568. EndHeaders: true,
  569. })
  570. st.writeData(1, true, nil) // just kidding. empty body.
  571. })
  572. }
  573. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  574. const content = "Some content"
  575. testBodyContents(t, -1, content, func(st *serverTester) {
  576. st.writeHeaders(HeadersFrameParam{
  577. StreamID: 1, // clients send odd numbers
  578. BlockFragment: st.encodeHeader(":method", "POST"),
  579. EndStream: false, // to say DATA frames are coming
  580. EndHeaders: true,
  581. })
  582. st.writeData(1, true, []byte(content))
  583. })
  584. }
  585. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  586. const content = "Some content"
  587. testBodyContents(t, -1, content, func(st *serverTester) {
  588. st.writeHeaders(HeadersFrameParam{
  589. StreamID: 1, // clients send odd numbers
  590. BlockFragment: st.encodeHeader(":method", "POST"),
  591. EndStream: false, // to say DATA frames are coming
  592. EndHeaders: true,
  593. })
  594. st.writeData(1, false, []byte(content[:5]))
  595. st.writeData(1, true, []byte(content[5:]))
  596. })
  597. }
  598. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  599. const content = "Some content"
  600. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  601. st.writeHeaders(HeadersFrameParam{
  602. StreamID: 1, // clients send odd numbers
  603. BlockFragment: st.encodeHeader(
  604. ":method", "POST",
  605. "content-length", strconv.Itoa(len(content)),
  606. ),
  607. EndStream: false, // to say DATA frames are coming
  608. EndHeaders: true,
  609. })
  610. st.writeData(1, true, []byte(content))
  611. })
  612. }
  613. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  614. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  615. func(st *serverTester) {
  616. st.writeHeaders(HeadersFrameParam{
  617. StreamID: 1, // clients send odd numbers
  618. BlockFragment: st.encodeHeader(
  619. ":method", "POST",
  620. "content-length", "3",
  621. ),
  622. EndStream: false, // to say DATA frames are coming
  623. EndHeaders: true,
  624. })
  625. st.writeData(1, true, []byte("12"))
  626. })
  627. }
  628. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  629. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  630. func(st *serverTester) {
  631. st.writeHeaders(HeadersFrameParam{
  632. StreamID: 1, // clients send odd numbers
  633. BlockFragment: st.encodeHeader(
  634. ":method", "POST",
  635. "content-length", "4",
  636. ),
  637. EndStream: false, // to say DATA frames are coming
  638. EndHeaders: true,
  639. })
  640. st.writeData(1, true, []byte("12345"))
  641. })
  642. }
  643. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  644. testServerRequest(t, write, func(r *http.Request) {
  645. if r.Method != "POST" {
  646. t.Errorf("Method = %q; want POST", r.Method)
  647. }
  648. if r.ContentLength != wantContentLength {
  649. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  650. }
  651. all, err := ioutil.ReadAll(r.Body)
  652. if err != nil {
  653. t.Fatal(err)
  654. }
  655. if string(all) != wantBody {
  656. t.Errorf("Read = %q; want %q", all, wantBody)
  657. }
  658. if err := r.Body.Close(); err != nil {
  659. t.Fatalf("Close: %v", err)
  660. }
  661. })
  662. }
  663. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  664. testServerRequest(t, write, func(r *http.Request) {
  665. if r.Method != "POST" {
  666. t.Errorf("Method = %q; want POST", r.Method)
  667. }
  668. if r.ContentLength != wantContentLength {
  669. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  670. }
  671. all, err := ioutil.ReadAll(r.Body)
  672. if err == nil {
  673. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  674. wantReadError, all)
  675. }
  676. if !strings.Contains(err.Error(), wantReadError) {
  677. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  678. }
  679. if err := r.Body.Close(); err != nil {
  680. t.Fatalf("Close: %v", err)
  681. }
  682. })
  683. }
  684. // Using a Host header, instead of :authority
  685. func TestServer_Request_Get_Host(t *testing.T) {
  686. const host = "example.com"
  687. testServerRequest(t, func(st *serverTester) {
  688. st.writeHeaders(HeadersFrameParam{
  689. StreamID: 1, // clients send odd numbers
  690. BlockFragment: st.encodeHeader("host", host),
  691. EndStream: true,
  692. EndHeaders: true,
  693. })
  694. }, func(r *http.Request) {
  695. if r.Host != host {
  696. t.Errorf("Host = %q; want %q", r.Host, host)
  697. }
  698. })
  699. }
  700. // Using an :authority pseudo-header, instead of Host
  701. func TestServer_Request_Get_Authority(t *testing.T) {
  702. const host = "example.com"
  703. testServerRequest(t, func(st *serverTester) {
  704. st.writeHeaders(HeadersFrameParam{
  705. StreamID: 1, // clients send odd numbers
  706. BlockFragment: st.encodeHeader(":authority", host),
  707. EndStream: true,
  708. EndHeaders: true,
  709. })
  710. }, func(r *http.Request) {
  711. if r.Host != host {
  712. t.Errorf("Host = %q; want %q", r.Host, host)
  713. }
  714. })
  715. }
  716. func TestServer_Request_WithContinuation(t *testing.T) {
  717. wantHeader := http.Header{
  718. "Foo-One": []string{"value-one"},
  719. "Foo-Two": []string{"value-two"},
  720. "Foo-Three": []string{"value-three"},
  721. }
  722. testServerRequest(t, func(st *serverTester) {
  723. fullHeaders := st.encodeHeader(
  724. "foo-one", "value-one",
  725. "foo-two", "value-two",
  726. "foo-three", "value-three",
  727. )
  728. remain := fullHeaders
  729. chunks := 0
  730. for len(remain) > 0 {
  731. const maxChunkSize = 5
  732. chunk := remain
  733. if len(chunk) > maxChunkSize {
  734. chunk = chunk[:maxChunkSize]
  735. }
  736. remain = remain[len(chunk):]
  737. if chunks == 0 {
  738. st.writeHeaders(HeadersFrameParam{
  739. StreamID: 1, // clients send odd numbers
  740. BlockFragment: chunk,
  741. EndStream: true, // no DATA frames
  742. EndHeaders: false, // we'll have continuation frames
  743. })
  744. } else {
  745. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  746. if err != nil {
  747. t.Fatal(err)
  748. }
  749. }
  750. chunks++
  751. }
  752. if chunks < 2 {
  753. t.Fatal("too few chunks")
  754. }
  755. }, func(r *http.Request) {
  756. if !reflect.DeepEqual(r.Header, wantHeader) {
  757. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  758. }
  759. })
  760. }
  761. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  762. func TestServer_Request_CookieConcat(t *testing.T) {
  763. const host = "example.com"
  764. testServerRequest(t, func(st *serverTester) {
  765. st.bodylessReq1(
  766. ":authority", host,
  767. "cookie", "a=b",
  768. "cookie", "c=d",
  769. "cookie", "e=f",
  770. )
  771. }, func(r *http.Request) {
  772. const want = "a=b; c=d; e=f"
  773. if got := r.Header.Get("Cookie"); got != want {
  774. t.Errorf("Cookie = %q; want %q", got, want)
  775. }
  776. })
  777. }
  778. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  779. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  780. }
  781. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  782. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  783. }
  784. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  785. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  786. }
  787. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  788. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  789. }
  790. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  791. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  792. }
  793. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  794. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  795. }
  796. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  797. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  798. }
  799. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  800. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  801. }
  802. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  803. // 8.1.2.3 Request Pseudo-Header Fields
  804. // "All HTTP/2 requests MUST include exactly one valid value" ...
  805. testRejectRequest(t, func(st *serverTester) {
  806. st.addLogFilter("duplicate pseudo-header")
  807. st.bodylessReq1(":method", "GET", ":method", "POST")
  808. })
  809. }
  810. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  811. // 8.1.2.3 Request Pseudo-Header Fields
  812. // "All pseudo-header fields MUST appear in the header block
  813. // before regular header fields. Any request or response that
  814. // contains a pseudo-header field that appears in a header
  815. // block after a regular header field MUST be treated as
  816. // malformed (Section 8.1.2.6)."
  817. testRejectRequest(t, func(st *serverTester) {
  818. st.addLogFilter("pseudo-header after regular header")
  819. var buf bytes.Buffer
  820. enc := hpack.NewEncoder(&buf)
  821. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  822. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  823. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  824. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  825. st.writeHeaders(HeadersFrameParam{
  826. StreamID: 1, // clients send odd numbers
  827. BlockFragment: buf.Bytes(),
  828. EndStream: true,
  829. EndHeaders: true,
  830. })
  831. })
  832. }
  833. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  834. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  835. }
  836. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  837. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  838. }
  839. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  840. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  841. }
  842. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  843. testRejectRequest(t, func(st *serverTester) {
  844. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  845. st.bodylessReq1(":unknown_thing", "")
  846. })
  847. }
  848. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  849. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  850. t.Fatal("server request made it to handler; should've been rejected")
  851. })
  852. defer st.Close()
  853. st.greet()
  854. send(st)
  855. st.wantRSTStream(1, ErrCodeProtocol)
  856. }
  857. func TestServer_Request_Connect(t *testing.T) {
  858. testServerRequest(t, func(st *serverTester) {
  859. st.writeHeaders(HeadersFrameParam{
  860. StreamID: 1,
  861. BlockFragment: st.encodeHeaderRaw(
  862. ":method", "CONNECT",
  863. ":authority", "example.com:123",
  864. ),
  865. EndStream: true,
  866. EndHeaders: true,
  867. })
  868. }, func(r *http.Request) {
  869. if g, w := r.Method, "CONNECT"; g != w {
  870. t.Errorf("Method = %q; want %q", g, w)
  871. }
  872. if g, w := r.RequestURI, "example.com:123"; g != w {
  873. t.Errorf("RequestURI = %q; want %q", g, w)
  874. }
  875. if g, w := r.URL.Host, "example.com:123"; g != w {
  876. t.Errorf("URL.Host = %q; want %q", g, w)
  877. }
  878. })
  879. }
  880. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  881. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  882. st.writeHeaders(HeadersFrameParam{
  883. StreamID: 1,
  884. BlockFragment: st.encodeHeaderRaw(
  885. ":method", "CONNECT",
  886. ":authority", "example.com:123",
  887. ":path", "/bogus",
  888. ),
  889. EndStream: true,
  890. EndHeaders: true,
  891. })
  892. })
  893. }
  894. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  895. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  896. st.writeHeaders(HeadersFrameParam{
  897. StreamID: 1,
  898. BlockFragment: st.encodeHeaderRaw(
  899. ":method", "CONNECT",
  900. ":authority", "example.com:123",
  901. ":scheme", "https",
  902. ),
  903. EndStream: true,
  904. EndHeaders: true,
  905. })
  906. })
  907. }
  908. func TestServer_Ping(t *testing.T) {
  909. st := newServerTester(t, nil)
  910. defer st.Close()
  911. st.greet()
  912. // Server should ignore this one, since it has ACK set.
  913. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  914. if err := st.fr.WritePing(true, ackPingData); err != nil {
  915. t.Fatal(err)
  916. }
  917. // But the server should reply to this one, since ACK is false.
  918. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  919. if err := st.fr.WritePing(false, pingData); err != nil {
  920. t.Fatal(err)
  921. }
  922. pf := st.wantPing()
  923. if !pf.Flags.Has(FlagPingAck) {
  924. t.Error("response ping doesn't have ACK set")
  925. }
  926. if pf.Data != pingData {
  927. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  928. }
  929. }
  930. func TestServer_RejectsLargeFrames(t *testing.T) {
  931. if runtime.GOOS == "windows" {
  932. t.Skip("see golang.org/issue/13434")
  933. }
  934. st := newServerTester(t, nil)
  935. defer st.Close()
  936. st.greet()
  937. // Write too large of a frame (too large by one byte)
  938. // We ignore the return value because it's expected that the server
  939. // will only read the first 9 bytes (the headre) and then disconnect.
  940. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  941. gf := st.wantGoAway()
  942. if gf.ErrCode != ErrCodeFrameSize {
  943. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  944. }
  945. if st.logBuf.Len() != 0 {
  946. // Previously we spun here for a bit until the GOAWAY disconnect
  947. // timer fired, logging while we fired.
  948. t.Errorf("unexpected server output: %.500s\n", st.logBuf.Bytes())
  949. }
  950. }
  951. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  952. puppet := newHandlerPuppet()
  953. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  954. puppet.act(w, r)
  955. })
  956. defer st.Close()
  957. defer puppet.done()
  958. st.greet()
  959. st.writeHeaders(HeadersFrameParam{
  960. StreamID: 1, // clients send odd numbers
  961. BlockFragment: st.encodeHeader(":method", "POST"),
  962. EndStream: false, // data coming
  963. EndHeaders: true,
  964. })
  965. st.writeData(1, false, []byte("abcdef"))
  966. puppet.do(readBodyHandler(t, "abc"))
  967. st.wantWindowUpdate(0, 3)
  968. st.wantWindowUpdate(1, 3)
  969. puppet.do(readBodyHandler(t, "def"))
  970. st.wantWindowUpdate(0, 3)
  971. st.wantWindowUpdate(1, 3)
  972. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  973. puppet.do(readBodyHandler(t, "ghi"))
  974. puppet.do(readBodyHandler(t, "jkl"))
  975. st.wantWindowUpdate(0, 3)
  976. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  977. }
  978. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  979. st := newServerTester(t, nil)
  980. defer st.Close()
  981. st.greet()
  982. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  983. t.Fatal(err)
  984. }
  985. gf := st.wantGoAway()
  986. if gf.ErrCode != ErrCodeFlowControl {
  987. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  988. }
  989. if gf.LastStreamID != 0 {
  990. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  991. }
  992. }
  993. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  994. inHandler := make(chan bool)
  995. blockHandler := make(chan bool)
  996. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  997. inHandler <- true
  998. <-blockHandler
  999. })
  1000. defer st.Close()
  1001. defer close(blockHandler)
  1002. st.greet()
  1003. st.writeHeaders(HeadersFrameParam{
  1004. StreamID: 1,
  1005. BlockFragment: st.encodeHeader(":method", "POST"),
  1006. EndStream: false, // keep it open
  1007. EndHeaders: true,
  1008. })
  1009. <-inHandler
  1010. // Send a bogus window update:
  1011. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1012. t.Fatal(err)
  1013. }
  1014. st.wantRSTStream(1, ErrCodeFlowControl)
  1015. }
  1016. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1017. // then runs fn once in the handler, and verifies that the error returned from
  1018. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1019. func testServerPostUnblock(t *testing.T,
  1020. handler func(http.ResponseWriter, *http.Request) error,
  1021. fn func(*serverTester),
  1022. checkErr func(error),
  1023. otherHeaders ...string) {
  1024. inHandler := make(chan bool)
  1025. errc := make(chan error, 1)
  1026. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1027. inHandler <- true
  1028. errc <- handler(w, r)
  1029. })
  1030. st.greet()
  1031. st.writeHeaders(HeadersFrameParam{
  1032. StreamID: 1,
  1033. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1034. EndStream: false, // keep it open
  1035. EndHeaders: true,
  1036. })
  1037. <-inHandler
  1038. fn(st)
  1039. select {
  1040. case err := <-errc:
  1041. if checkErr != nil {
  1042. checkErr(err)
  1043. }
  1044. case <-time.After(5 * time.Second):
  1045. t.Fatal("timeout waiting for Handler to return")
  1046. }
  1047. st.Close()
  1048. }
  1049. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1050. testServerPostUnblock(t,
  1051. func(w http.ResponseWriter, r *http.Request) (err error) {
  1052. _, err = r.Body.Read(make([]byte, 1))
  1053. return
  1054. },
  1055. func(st *serverTester) {
  1056. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1057. t.Fatal(err)
  1058. }
  1059. },
  1060. func(err error) {
  1061. want := StreamError{StreamID: 0x1, Code: 0x8}
  1062. if !reflect.DeepEqual(err, want) {
  1063. t.Errorf("Read error = %v; want %v", err, want)
  1064. }
  1065. },
  1066. )
  1067. }
  1068. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1069. // Run this test a bunch, because it doesn't always
  1070. // deadlock. But with a bunch, it did.
  1071. n := 50
  1072. if testing.Short() {
  1073. n = 5
  1074. }
  1075. for i := 0; i < n; i++ {
  1076. testServer_RSTStream_Unblocks_Header_Write(t)
  1077. }
  1078. }
  1079. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1080. inHandler := make(chan bool, 1)
  1081. unblockHandler := make(chan bool, 1)
  1082. headerWritten := make(chan bool, 1)
  1083. wroteRST := make(chan bool, 1)
  1084. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1085. inHandler <- true
  1086. <-wroteRST
  1087. w.Header().Set("foo", "bar")
  1088. w.WriteHeader(200)
  1089. w.(http.Flusher).Flush()
  1090. headerWritten <- true
  1091. <-unblockHandler
  1092. })
  1093. defer st.Close()
  1094. st.greet()
  1095. st.writeHeaders(HeadersFrameParam{
  1096. StreamID: 1,
  1097. BlockFragment: st.encodeHeader(":method", "POST"),
  1098. EndStream: false, // keep it open
  1099. EndHeaders: true,
  1100. })
  1101. <-inHandler
  1102. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1103. t.Fatal(err)
  1104. }
  1105. wroteRST <- true
  1106. st.awaitIdle()
  1107. select {
  1108. case <-headerWritten:
  1109. case <-time.After(2 * time.Second):
  1110. t.Error("timeout waiting for header write")
  1111. }
  1112. unblockHandler <- true
  1113. }
  1114. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1115. testServerPostUnblock(t,
  1116. func(w http.ResponseWriter, r *http.Request) (err error) {
  1117. _, err = r.Body.Read(make([]byte, 1))
  1118. return
  1119. },
  1120. func(st *serverTester) { st.cc.Close() },
  1121. func(err error) {
  1122. if err == nil {
  1123. t.Error("unexpected nil error from Request.Body.Read")
  1124. }
  1125. },
  1126. )
  1127. }
  1128. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1129. <-w.(http.CloseNotifier).CloseNotify()
  1130. return nil
  1131. }
  1132. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1133. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1134. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1135. t.Fatal(err)
  1136. }
  1137. }, nil)
  1138. }
  1139. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1140. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1141. }
  1142. // that CloseNotify unblocks after a stream error due to the client's
  1143. // problem that's unrelated to them explicitly canceling it (which is
  1144. // TestServer_CloseNotify_After_RSTStream above)
  1145. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1146. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1147. // data longer than declared Content-Length => stream error
  1148. st.writeData(1, true, []byte("1234"))
  1149. }, nil, "content-length", "3")
  1150. }
  1151. func TestServer_StateTransitions(t *testing.T) {
  1152. var st *serverTester
  1153. inHandler := make(chan bool)
  1154. writeData := make(chan bool)
  1155. leaveHandler := make(chan bool)
  1156. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1157. inHandler <- true
  1158. if st.stream(1) == nil {
  1159. t.Errorf("nil stream 1 in handler")
  1160. }
  1161. if got, want := st.streamState(1), stateOpen; got != want {
  1162. t.Errorf("in handler, state is %v; want %v", got, want)
  1163. }
  1164. writeData <- true
  1165. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1166. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1167. }
  1168. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1169. t.Errorf("in handler, state is %v; want %v", got, want)
  1170. }
  1171. <-leaveHandler
  1172. })
  1173. st.greet()
  1174. if st.stream(1) != nil {
  1175. t.Fatal("stream 1 should be empty")
  1176. }
  1177. if got := st.streamState(1); got != stateIdle {
  1178. t.Fatalf("stream 1 should be idle; got %v", got)
  1179. }
  1180. st.writeHeaders(HeadersFrameParam{
  1181. StreamID: 1,
  1182. BlockFragment: st.encodeHeader(":method", "POST"),
  1183. EndStream: false, // keep it open
  1184. EndHeaders: true,
  1185. })
  1186. <-inHandler
  1187. <-writeData
  1188. st.writeData(1, true, nil)
  1189. leaveHandler <- true
  1190. hf := st.wantHeaders()
  1191. if !hf.StreamEnded() {
  1192. t.Fatal("expected END_STREAM flag")
  1193. }
  1194. if got, want := st.streamState(1), stateClosed; got != want {
  1195. t.Errorf("at end, state is %v; want %v", got, want)
  1196. }
  1197. if st.stream(1) != nil {
  1198. t.Fatal("at end, stream 1 should be gone")
  1199. }
  1200. }
  1201. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1202. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1203. testServerRejectsConn(t, func(st *serverTester) {
  1204. st.writeHeaders(HeadersFrameParam{
  1205. StreamID: 1,
  1206. BlockFragment: st.encodeHeader(),
  1207. EndStream: true,
  1208. EndHeaders: false,
  1209. })
  1210. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1211. StreamID: 3, // different stream.
  1212. BlockFragment: st.encodeHeader(),
  1213. EndStream: true,
  1214. EndHeaders: true,
  1215. })
  1216. })
  1217. }
  1218. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1219. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1220. testServerRejectsConn(t, func(st *serverTester) {
  1221. st.writeHeaders(HeadersFrameParam{
  1222. StreamID: 1,
  1223. BlockFragment: st.encodeHeader(),
  1224. EndStream: true,
  1225. EndHeaders: false,
  1226. })
  1227. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1228. t.Fatal(err)
  1229. }
  1230. })
  1231. }
  1232. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1233. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1234. testServerRejectsConn(t, func(st *serverTester) {
  1235. st.writeHeaders(HeadersFrameParam{
  1236. StreamID: 1,
  1237. BlockFragment: st.encodeHeader(),
  1238. EndStream: true,
  1239. EndHeaders: true,
  1240. })
  1241. st.wantHeaders()
  1242. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1243. t.Fatal(err)
  1244. }
  1245. })
  1246. }
  1247. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1248. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1249. testServerRejectsConn(t, func(st *serverTester) {
  1250. st.writeHeaders(HeadersFrameParam{
  1251. StreamID: 1,
  1252. BlockFragment: st.encodeHeader(),
  1253. EndStream: true,
  1254. EndHeaders: false,
  1255. })
  1256. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1257. t.Fatal(err)
  1258. }
  1259. })
  1260. }
  1261. // No HEADERS on stream 0.
  1262. func TestServer_Rejects_Headers0(t *testing.T) {
  1263. testServerRejectsConn(t, func(st *serverTester) {
  1264. st.fr.AllowIllegalWrites = true
  1265. st.writeHeaders(HeadersFrameParam{
  1266. StreamID: 0,
  1267. BlockFragment: st.encodeHeader(),
  1268. EndStream: true,
  1269. EndHeaders: true,
  1270. })
  1271. })
  1272. }
  1273. // No CONTINUATION on stream 0.
  1274. func TestServer_Rejects_Continuation0(t *testing.T) {
  1275. testServerRejectsConn(t, func(st *serverTester) {
  1276. st.fr.AllowIllegalWrites = true
  1277. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1278. t.Fatal(err)
  1279. }
  1280. })
  1281. }
  1282. func TestServer_Rejects_PushPromise(t *testing.T) {
  1283. testServerRejectsConn(t, func(st *serverTester) {
  1284. pp := PushPromiseParam{
  1285. StreamID: 1,
  1286. PromiseID: 3,
  1287. }
  1288. if err := st.fr.WritePushPromise(pp); err != nil {
  1289. t.Fatal(err)
  1290. }
  1291. })
  1292. }
  1293. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1294. // frame and a server close after the client does something
  1295. // deserving a CONNECTION_ERROR.
  1296. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1297. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1298. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1299. defer st.Close()
  1300. st.greet()
  1301. writeReq(st)
  1302. st.wantGoAway()
  1303. errc := make(chan error, 1)
  1304. go func() {
  1305. fr, err := st.fr.ReadFrame()
  1306. if err == nil {
  1307. err = fmt.Errorf("got frame of type %T", fr)
  1308. }
  1309. errc <- err
  1310. }()
  1311. select {
  1312. case err := <-errc:
  1313. if err != io.EOF {
  1314. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1315. }
  1316. case <-time.After(2 * time.Second):
  1317. t.Error("timeout waiting for disconnect")
  1318. }
  1319. }
  1320. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1321. // error code after a client sends a bogus request.
  1322. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1323. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1324. defer st.Close()
  1325. st.greet()
  1326. writeReq(st)
  1327. st.wantRSTStream(1, code)
  1328. }
  1329. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1330. // write a single request with writeReq, and then verify that the
  1331. // *http.Request is built correctly in checkReq.
  1332. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1333. gotReq := make(chan bool, 1)
  1334. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1335. if r.Body == nil {
  1336. t.Fatal("nil Body")
  1337. }
  1338. checkReq(r)
  1339. gotReq <- true
  1340. })
  1341. defer st.Close()
  1342. st.greet()
  1343. writeReq(st)
  1344. select {
  1345. case <-gotReq:
  1346. case <-time.After(2 * time.Second):
  1347. t.Error("timeout waiting for request")
  1348. }
  1349. }
  1350. func getSlash(st *serverTester) { st.bodylessReq1() }
  1351. func TestServer_Response_NoData(t *testing.T) {
  1352. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1353. // Nothing.
  1354. return nil
  1355. }, func(st *serverTester) {
  1356. getSlash(st)
  1357. hf := st.wantHeaders()
  1358. if !hf.StreamEnded() {
  1359. t.Fatal("want END_STREAM flag")
  1360. }
  1361. if !hf.HeadersEnded() {
  1362. t.Fatal("want END_HEADERS flag")
  1363. }
  1364. })
  1365. }
  1366. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1367. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1368. w.Header().Set("Foo-Bar", "some-value")
  1369. return nil
  1370. }, func(st *serverTester) {
  1371. getSlash(st)
  1372. hf := st.wantHeaders()
  1373. if !hf.StreamEnded() {
  1374. t.Fatal("want END_STREAM flag")
  1375. }
  1376. if !hf.HeadersEnded() {
  1377. t.Fatal("want END_HEADERS flag")
  1378. }
  1379. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1380. wanth := [][2]string{
  1381. {":status", "200"},
  1382. {"foo-bar", "some-value"},
  1383. {"content-type", "text/plain; charset=utf-8"},
  1384. {"content-length", "0"},
  1385. }
  1386. if !reflect.DeepEqual(goth, wanth) {
  1387. t.Errorf("Got headers %v; want %v", goth, wanth)
  1388. }
  1389. })
  1390. }
  1391. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1392. const msg = "<html>this is HTML."
  1393. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1394. w.Header().Set("Content-Type", "foo/bar")
  1395. io.WriteString(w, msg)
  1396. return nil
  1397. }, func(st *serverTester) {
  1398. getSlash(st)
  1399. hf := st.wantHeaders()
  1400. if hf.StreamEnded() {
  1401. t.Fatal("don't want END_STREAM, expecting data")
  1402. }
  1403. if !hf.HeadersEnded() {
  1404. t.Fatal("want END_HEADERS flag")
  1405. }
  1406. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1407. wanth := [][2]string{
  1408. {":status", "200"},
  1409. {"content-type", "foo/bar"},
  1410. {"content-length", strconv.Itoa(len(msg))},
  1411. }
  1412. if !reflect.DeepEqual(goth, wanth) {
  1413. t.Errorf("Got headers %v; want %v", goth, wanth)
  1414. }
  1415. df := st.wantData()
  1416. if !df.StreamEnded() {
  1417. t.Error("expected DATA to have END_STREAM flag")
  1418. }
  1419. if got := string(df.Data()); got != msg {
  1420. t.Errorf("got DATA %q; want %q", got, msg)
  1421. }
  1422. })
  1423. }
  1424. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1425. const msg = "hi"
  1426. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1427. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1428. io.WriteString(w, msg)
  1429. return nil
  1430. }, func(st *serverTester) {
  1431. getSlash(st)
  1432. hf := st.wantHeaders()
  1433. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1434. wanth := [][2]string{
  1435. {":status", "200"},
  1436. {"content-type", "text/plain; charset=utf-8"},
  1437. {"content-length", strconv.Itoa(len(msg))},
  1438. }
  1439. if !reflect.DeepEqual(goth, wanth) {
  1440. t.Errorf("Got headers %v; want %v", goth, wanth)
  1441. }
  1442. })
  1443. }
  1444. // Header accessed only after the initial write.
  1445. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1446. const msg = "<html>this is HTML."
  1447. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1448. io.WriteString(w, msg)
  1449. w.Header().Set("foo", "should be ignored")
  1450. return nil
  1451. }, func(st *serverTester) {
  1452. getSlash(st)
  1453. hf := st.wantHeaders()
  1454. if hf.StreamEnded() {
  1455. t.Fatal("unexpected END_STREAM")
  1456. }
  1457. if !hf.HeadersEnded() {
  1458. t.Fatal("want END_HEADERS flag")
  1459. }
  1460. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1461. wanth := [][2]string{
  1462. {":status", "200"},
  1463. {"content-type", "text/html; charset=utf-8"},
  1464. {"content-length", strconv.Itoa(len(msg))},
  1465. }
  1466. if !reflect.DeepEqual(goth, wanth) {
  1467. t.Errorf("Got headers %v; want %v", goth, wanth)
  1468. }
  1469. })
  1470. }
  1471. // Header accessed before the initial write and later mutated.
  1472. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1473. const msg = "<html>this is HTML."
  1474. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1475. w.Header().Set("foo", "proper value")
  1476. io.WriteString(w, msg)
  1477. w.Header().Set("foo", "should be ignored")
  1478. return nil
  1479. }, func(st *serverTester) {
  1480. getSlash(st)
  1481. hf := st.wantHeaders()
  1482. if hf.StreamEnded() {
  1483. t.Fatal("unexpected END_STREAM")
  1484. }
  1485. if !hf.HeadersEnded() {
  1486. t.Fatal("want END_HEADERS flag")
  1487. }
  1488. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1489. wanth := [][2]string{
  1490. {":status", "200"},
  1491. {"foo", "proper value"},
  1492. {"content-type", "text/html; charset=utf-8"},
  1493. {"content-length", strconv.Itoa(len(msg))},
  1494. }
  1495. if !reflect.DeepEqual(goth, wanth) {
  1496. t.Errorf("Got headers %v; want %v", goth, wanth)
  1497. }
  1498. })
  1499. }
  1500. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1501. const msg = "<html>this is HTML."
  1502. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1503. io.WriteString(w, msg)
  1504. return nil
  1505. }, func(st *serverTester) {
  1506. getSlash(st)
  1507. hf := st.wantHeaders()
  1508. if hf.StreamEnded() {
  1509. t.Fatal("don't want END_STREAM, expecting data")
  1510. }
  1511. if !hf.HeadersEnded() {
  1512. t.Fatal("want END_HEADERS flag")
  1513. }
  1514. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1515. wanth := [][2]string{
  1516. {":status", "200"},
  1517. {"content-type", "text/html; charset=utf-8"},
  1518. {"content-length", strconv.Itoa(len(msg))},
  1519. }
  1520. if !reflect.DeepEqual(goth, wanth) {
  1521. t.Errorf("Got headers %v; want %v", goth, wanth)
  1522. }
  1523. df := st.wantData()
  1524. if !df.StreamEnded() {
  1525. t.Error("expected DATA to have END_STREAM flag")
  1526. }
  1527. if got := string(df.Data()); got != msg {
  1528. t.Errorf("got DATA %q; want %q", got, msg)
  1529. }
  1530. })
  1531. }
  1532. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1533. const msg = "<html>this is HTML"
  1534. const msg2 = ", and this is the next chunk"
  1535. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1536. io.WriteString(w, msg)
  1537. w.(http.Flusher).Flush()
  1538. io.WriteString(w, msg2)
  1539. return nil
  1540. }, func(st *serverTester) {
  1541. getSlash(st)
  1542. hf := st.wantHeaders()
  1543. if hf.StreamEnded() {
  1544. t.Fatal("unexpected END_STREAM flag")
  1545. }
  1546. if !hf.HeadersEnded() {
  1547. t.Fatal("want END_HEADERS flag")
  1548. }
  1549. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1550. wanth := [][2]string{
  1551. {":status", "200"},
  1552. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1553. // and no content-length
  1554. }
  1555. if !reflect.DeepEqual(goth, wanth) {
  1556. t.Errorf("Got headers %v; want %v", goth, wanth)
  1557. }
  1558. {
  1559. df := st.wantData()
  1560. if df.StreamEnded() {
  1561. t.Error("unexpected END_STREAM flag")
  1562. }
  1563. if got := string(df.Data()); got != msg {
  1564. t.Errorf("got DATA %q; want %q", got, msg)
  1565. }
  1566. }
  1567. {
  1568. df := st.wantData()
  1569. if !df.StreamEnded() {
  1570. t.Error("wanted END_STREAM flag on last data chunk")
  1571. }
  1572. if got := string(df.Data()); got != msg2 {
  1573. t.Errorf("got DATA %q; want %q", got, msg2)
  1574. }
  1575. }
  1576. })
  1577. }
  1578. func TestServer_Response_LargeWrite(t *testing.T) {
  1579. const size = 1 << 20
  1580. const maxFrameSize = 16 << 10
  1581. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1582. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1583. if err != nil {
  1584. return fmt.Errorf("Write error: %v", err)
  1585. }
  1586. if n != size {
  1587. return fmt.Errorf("wrong size %d from Write", n)
  1588. }
  1589. return nil
  1590. }, func(st *serverTester) {
  1591. if err := st.fr.WriteSettings(
  1592. Setting{SettingInitialWindowSize, 0},
  1593. Setting{SettingMaxFrameSize, maxFrameSize},
  1594. ); err != nil {
  1595. t.Fatal(err)
  1596. }
  1597. st.wantSettingsAck()
  1598. getSlash(st) // make the single request
  1599. // Give the handler quota to write:
  1600. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1601. t.Fatal(err)
  1602. }
  1603. // Give the handler quota to write to connection-level
  1604. // window as well
  1605. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1606. t.Fatal(err)
  1607. }
  1608. hf := st.wantHeaders()
  1609. if hf.StreamEnded() {
  1610. t.Fatal("unexpected END_STREAM flag")
  1611. }
  1612. if !hf.HeadersEnded() {
  1613. t.Fatal("want END_HEADERS flag")
  1614. }
  1615. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1616. wanth := [][2]string{
  1617. {":status", "200"},
  1618. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1619. // and no content-length
  1620. }
  1621. if !reflect.DeepEqual(goth, wanth) {
  1622. t.Errorf("Got headers %v; want %v", goth, wanth)
  1623. }
  1624. var bytes, frames int
  1625. for {
  1626. df := st.wantData()
  1627. bytes += len(df.Data())
  1628. frames++
  1629. for _, b := range df.Data() {
  1630. if b != 'a' {
  1631. t.Fatal("non-'a' byte seen in DATA")
  1632. }
  1633. }
  1634. if df.StreamEnded() {
  1635. break
  1636. }
  1637. }
  1638. if bytes != size {
  1639. t.Errorf("Got %d bytes; want %d", bytes, size)
  1640. }
  1641. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1642. t.Errorf("Got %d frames; want %d", frames, size)
  1643. }
  1644. })
  1645. }
  1646. // Test that the handler can't write more than the client allows
  1647. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1648. const size = 1 << 20
  1649. const maxFrameSize = 16 << 10
  1650. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1651. w.(http.Flusher).Flush()
  1652. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1653. if err != nil {
  1654. return fmt.Errorf("Write error: %v", err)
  1655. }
  1656. if n != size {
  1657. return fmt.Errorf("wrong size %d from Write", n)
  1658. }
  1659. return nil
  1660. }, func(st *serverTester) {
  1661. // Set the window size to something explicit for this test.
  1662. // It's also how much initial data we expect.
  1663. const initWindowSize = 123
  1664. if err := st.fr.WriteSettings(
  1665. Setting{SettingInitialWindowSize, initWindowSize},
  1666. Setting{SettingMaxFrameSize, maxFrameSize},
  1667. ); err != nil {
  1668. t.Fatal(err)
  1669. }
  1670. st.wantSettingsAck()
  1671. getSlash(st) // make the single request
  1672. defer func() { st.fr.WriteRSTStream(1, ErrCodeCancel) }()
  1673. hf := st.wantHeaders()
  1674. if hf.StreamEnded() {
  1675. t.Fatal("unexpected END_STREAM flag")
  1676. }
  1677. if !hf.HeadersEnded() {
  1678. t.Fatal("want END_HEADERS flag")
  1679. }
  1680. df := st.wantData()
  1681. if got := len(df.Data()); got != initWindowSize {
  1682. t.Fatalf("Initial window size = %d but got DATA with %d bytes", initWindowSize, got)
  1683. }
  1684. for _, quota := range []int{1, 13, 127} {
  1685. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1686. t.Fatal(err)
  1687. }
  1688. df := st.wantData()
  1689. if int(quota) != len(df.Data()) {
  1690. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1691. }
  1692. }
  1693. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1694. t.Fatal(err)
  1695. }
  1696. })
  1697. }
  1698. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1699. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1700. const size = 1 << 20
  1701. const maxFrameSize = 16 << 10
  1702. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1703. w.(http.Flusher).Flush()
  1704. errc := make(chan error, 1)
  1705. go func() {
  1706. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1707. errc <- err
  1708. }()
  1709. select {
  1710. case err := <-errc:
  1711. if err == nil {
  1712. return errors.New("unexpected nil error from Write in handler")
  1713. }
  1714. return nil
  1715. case <-time.After(2 * time.Second):
  1716. return errors.New("timeout waiting for Write in handler")
  1717. }
  1718. }, func(st *serverTester) {
  1719. if err := st.fr.WriteSettings(
  1720. Setting{SettingInitialWindowSize, 0},
  1721. Setting{SettingMaxFrameSize, maxFrameSize},
  1722. ); err != nil {
  1723. t.Fatal(err)
  1724. }
  1725. st.wantSettingsAck()
  1726. getSlash(st) // make the single request
  1727. hf := st.wantHeaders()
  1728. if hf.StreamEnded() {
  1729. t.Fatal("unexpected END_STREAM flag")
  1730. }
  1731. if !hf.HeadersEnded() {
  1732. t.Fatal("want END_HEADERS flag")
  1733. }
  1734. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1735. t.Fatal(err)
  1736. }
  1737. })
  1738. }
  1739. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1740. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1741. w.(http.Flusher).Flush()
  1742. // Nothing; send empty DATA
  1743. return nil
  1744. }, func(st *serverTester) {
  1745. // Handler gets no data quota:
  1746. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1747. t.Fatal(err)
  1748. }
  1749. st.wantSettingsAck()
  1750. getSlash(st) // make the single request
  1751. hf := st.wantHeaders()
  1752. if hf.StreamEnded() {
  1753. t.Fatal("unexpected END_STREAM flag")
  1754. }
  1755. if !hf.HeadersEnded() {
  1756. t.Fatal("want END_HEADERS flag")
  1757. }
  1758. df := st.wantData()
  1759. if got := len(df.Data()); got != 0 {
  1760. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1761. }
  1762. if !df.StreamEnded() {
  1763. t.Fatal("DATA didn't have END_STREAM")
  1764. }
  1765. })
  1766. }
  1767. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1768. const msg = "foo"
  1769. const reply = "bar"
  1770. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1771. if v := r.Header.Get("Expect"); v != "" {
  1772. t.Errorf("Expect header = %q; want empty", v)
  1773. }
  1774. buf := make([]byte, len(msg))
  1775. // This read should trigger the 100-continue being sent.
  1776. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1777. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1778. }
  1779. _, err := io.WriteString(w, reply)
  1780. return err
  1781. }, func(st *serverTester) {
  1782. st.writeHeaders(HeadersFrameParam{
  1783. StreamID: 1, // clients send odd numbers
  1784. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1785. EndStream: false,
  1786. EndHeaders: true,
  1787. })
  1788. hf := st.wantHeaders()
  1789. if hf.StreamEnded() {
  1790. t.Fatal("unexpected END_STREAM flag")
  1791. }
  1792. if !hf.HeadersEnded() {
  1793. t.Fatal("want END_HEADERS flag")
  1794. }
  1795. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1796. wanth := [][2]string{
  1797. {":status", "100"},
  1798. }
  1799. if !reflect.DeepEqual(goth, wanth) {
  1800. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1801. }
  1802. // Okay, they sent status 100, so we can send our
  1803. // gigantic and/or sensitive "foo" payload now.
  1804. st.writeData(1, true, []byte(msg))
  1805. st.wantWindowUpdate(0, uint32(len(msg)))
  1806. hf = st.wantHeaders()
  1807. if hf.StreamEnded() {
  1808. t.Fatal("expected data to follow")
  1809. }
  1810. if !hf.HeadersEnded() {
  1811. t.Fatal("want END_HEADERS flag")
  1812. }
  1813. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1814. wanth = [][2]string{
  1815. {":status", "200"},
  1816. {"content-type", "text/plain; charset=utf-8"},
  1817. {"content-length", strconv.Itoa(len(reply))},
  1818. }
  1819. if !reflect.DeepEqual(goth, wanth) {
  1820. t.Errorf("Got headers %v; want %v", goth, wanth)
  1821. }
  1822. df := st.wantData()
  1823. if string(df.Data()) != reply {
  1824. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1825. }
  1826. if !df.StreamEnded() {
  1827. t.Errorf("expect data stream end")
  1828. }
  1829. })
  1830. }
  1831. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1832. errc := make(chan error, 1)
  1833. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1834. p := []byte("some data.\n")
  1835. for {
  1836. _, err := w.Write(p)
  1837. if err != nil {
  1838. errc <- err
  1839. return nil
  1840. }
  1841. }
  1842. }, func(st *serverTester) {
  1843. st.writeHeaders(HeadersFrameParam{
  1844. StreamID: 1,
  1845. BlockFragment: st.encodeHeader(),
  1846. EndStream: false,
  1847. EndHeaders: true,
  1848. })
  1849. hf := st.wantHeaders()
  1850. if hf.StreamEnded() {
  1851. t.Fatal("unexpected END_STREAM flag")
  1852. }
  1853. if !hf.HeadersEnded() {
  1854. t.Fatal("want END_HEADERS flag")
  1855. }
  1856. // Close the connection and wait for the handler to (hopefully) notice.
  1857. st.cc.Close()
  1858. select {
  1859. case <-errc:
  1860. case <-time.After(5 * time.Second):
  1861. t.Error("timeout")
  1862. }
  1863. })
  1864. }
  1865. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1866. const testPath = "/some/path"
  1867. inHandler := make(chan uint32)
  1868. leaveHandler := make(chan bool)
  1869. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1870. id := w.(*responseWriter).rws.stream.id
  1871. inHandler <- id
  1872. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1873. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1874. }
  1875. <-leaveHandler
  1876. })
  1877. defer st.Close()
  1878. st.greet()
  1879. nextStreamID := uint32(1)
  1880. streamID := func() uint32 {
  1881. defer func() { nextStreamID += 2 }()
  1882. return nextStreamID
  1883. }
  1884. sendReq := func(id uint32, headers ...string) {
  1885. st.writeHeaders(HeadersFrameParam{
  1886. StreamID: id,
  1887. BlockFragment: st.encodeHeader(headers...),
  1888. EndStream: true,
  1889. EndHeaders: true,
  1890. })
  1891. }
  1892. for i := 0; i < defaultMaxStreams; i++ {
  1893. sendReq(streamID())
  1894. <-inHandler
  1895. }
  1896. defer func() {
  1897. for i := 0; i < defaultMaxStreams; i++ {
  1898. leaveHandler <- true
  1899. }
  1900. }()
  1901. // And this one should cross the limit:
  1902. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  1903. // even if we're rejecting it)
  1904. rejectID := streamID()
  1905. headerBlock := st.encodeHeader(":path", testPath)
  1906. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  1907. st.writeHeaders(HeadersFrameParam{
  1908. StreamID: rejectID,
  1909. BlockFragment: frag1,
  1910. EndStream: true,
  1911. EndHeaders: false, // CONTINUATION coming
  1912. })
  1913. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  1914. t.Fatal(err)
  1915. }
  1916. st.wantRSTStream(rejectID, ErrCodeProtocol)
  1917. // But let a handler finish:
  1918. leaveHandler <- true
  1919. st.wantHeaders()
  1920. // And now another stream should be able to start:
  1921. goodID := streamID()
  1922. sendReq(goodID, ":path", testPath)
  1923. select {
  1924. case got := <-inHandler:
  1925. if got != goodID {
  1926. t.Errorf("Got stream %d; want %d", got, goodID)
  1927. }
  1928. case <-time.After(3 * time.Second):
  1929. t.Error("timeout waiting for handler")
  1930. }
  1931. }
  1932. // So many response headers that the server needs to use CONTINUATION frames:
  1933. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  1934. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1935. h := w.Header()
  1936. for i := 0; i < 5000; i++ {
  1937. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  1938. }
  1939. return nil
  1940. }, func(st *serverTester) {
  1941. getSlash(st)
  1942. hf := st.wantHeaders()
  1943. if hf.HeadersEnded() {
  1944. t.Fatal("got unwanted END_HEADERS flag")
  1945. }
  1946. n := 0
  1947. for {
  1948. n++
  1949. cf := st.wantContinuation()
  1950. if cf.HeadersEnded() {
  1951. break
  1952. }
  1953. }
  1954. if n < 5 {
  1955. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  1956. }
  1957. })
  1958. }
  1959. // This previously crashed (reported by Mathieu Lonjaret as observed
  1960. // while using Camlistore) because we got a DATA frame from the client
  1961. // after the handler exited and our logic at the time was wrong,
  1962. // keeping a stream in the map in stateClosed, which tickled an
  1963. // invariant check later when we tried to remove that stream (via
  1964. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  1965. // ended.
  1966. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  1967. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1968. // nothing
  1969. return nil
  1970. }, func(st *serverTester) {
  1971. st.writeHeaders(HeadersFrameParam{
  1972. StreamID: 1,
  1973. BlockFragment: st.encodeHeader(),
  1974. EndStream: false, // DATA is coming
  1975. EndHeaders: true,
  1976. })
  1977. hf := st.wantHeaders()
  1978. if !hf.HeadersEnded() || !hf.StreamEnded() {
  1979. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  1980. }
  1981. // Sent when the a Handler closes while a client has
  1982. // indicated it's still sending DATA:
  1983. st.wantRSTStream(1, ErrCodeCancel)
  1984. // Now the handler has ended, so it's ended its
  1985. // stream, but the client hasn't closed its side
  1986. // (stateClosedLocal). So send more data and verify
  1987. // it doesn't crash with an internal invariant panic, like
  1988. // it did before.
  1989. st.writeData(1, true, []byte("foo"))
  1990. // Sent after a peer sends data anyway (admittedly the
  1991. // previous RST_STREAM might've still been in-flight),
  1992. // but they'll get the more friendly 'cancel' code
  1993. // first.
  1994. st.wantRSTStream(1, ErrCodeStreamClosed)
  1995. // Set up a bunch of machinery to record the panic we saw
  1996. // previously.
  1997. var (
  1998. panMu sync.Mutex
  1999. panicVal interface{}
  2000. )
  2001. testHookOnPanicMu.Lock()
  2002. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2003. panMu.Lock()
  2004. panicVal = pv
  2005. panMu.Unlock()
  2006. return true
  2007. }
  2008. testHookOnPanicMu.Unlock()
  2009. // Now force the serve loop to end, via closing the connection.
  2010. st.cc.Close()
  2011. select {
  2012. case <-st.sc.doneServing:
  2013. // Loop has exited.
  2014. panMu.Lock()
  2015. got := panicVal
  2016. panMu.Unlock()
  2017. if got != nil {
  2018. t.Errorf("Got panic: %v", got)
  2019. }
  2020. case <-time.After(5 * time.Second):
  2021. t.Error("timeout")
  2022. }
  2023. })
  2024. }
  2025. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2026. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2027. func testRejectTLS(t *testing.T, max uint16) {
  2028. st := newServerTester(t, nil, func(c *tls.Config) {
  2029. c.MaxVersion = max
  2030. })
  2031. defer st.Close()
  2032. gf := st.wantGoAway()
  2033. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2034. t.Errorf("Got error code %v; want %v", got, want)
  2035. }
  2036. }
  2037. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2038. st := newServerTester(t, nil, func(c *tls.Config) {
  2039. // Only list bad ones:
  2040. c.CipherSuites = []uint16{
  2041. tls.TLS_RSA_WITH_RC4_128_SHA,
  2042. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2043. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2044. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2045. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2046. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2047. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2048. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2049. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2050. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2051. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2052. }
  2053. })
  2054. defer st.Close()
  2055. gf := st.wantGoAway()
  2056. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2057. t.Errorf("Got error code %v; want %v", got, want)
  2058. }
  2059. }
  2060. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2061. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2062. st := newServerTester(t, nil, func(c *tls.Config) {
  2063. // Have the client only support the one required by the spec.
  2064. c.CipherSuites = []uint16{requiredSuite}
  2065. }, func(ts *httptest.Server) {
  2066. var srv *http.Server = ts.Config
  2067. // Have the server configured with no specific cipher suites.
  2068. // This tests that Go's defaults include the required one.
  2069. srv.TLSConfig = nil
  2070. })
  2071. defer st.Close()
  2072. st.greet()
  2073. }
  2074. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2075. if f.Name == "date" {
  2076. return
  2077. }
  2078. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2079. }
  2080. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2081. st.decodedHeaders = nil
  2082. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2083. st.t.Fatalf("hpack decoding error: %v", err)
  2084. }
  2085. if err := st.hpackDec.Close(); err != nil {
  2086. st.t.Fatalf("hpack decoding error: %v", err)
  2087. }
  2088. return st.decodedHeaders
  2089. }
  2090. // testServerResponse sets up an idle HTTP/2 connection and lets you
  2091. // write a single request with writeReq, and then reply to it in some way with the provided handler,
  2092. // and then verify the output with the serverTester again (assuming the handler returns nil)
  2093. func testServerResponse(t testing.TB,
  2094. handler func(http.ResponseWriter, *http.Request) error,
  2095. client func(*serverTester),
  2096. ) {
  2097. errc := make(chan error, 1)
  2098. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2099. if r.Body == nil {
  2100. t.Fatal("nil Body")
  2101. }
  2102. errc <- handler(w, r)
  2103. })
  2104. defer st.Close()
  2105. donec := make(chan bool)
  2106. go func() {
  2107. defer close(donec)
  2108. st.greet()
  2109. client(st)
  2110. }()
  2111. select {
  2112. case <-donec:
  2113. return
  2114. case <-time.After(5 * time.Second):
  2115. t.Fatal("timeout")
  2116. }
  2117. select {
  2118. case err := <-errc:
  2119. if err != nil {
  2120. t.Fatalf("Error in handler: %v", err)
  2121. }
  2122. case <-time.After(2 * time.Second):
  2123. t.Error("timeout waiting for handler to finish")
  2124. }
  2125. }
  2126. // readBodyHandler returns an http Handler func that reads len(want)
  2127. // bytes from r.Body and fails t if the contents read were not
  2128. // the value of want.
  2129. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2130. return func(w http.ResponseWriter, r *http.Request) {
  2131. buf := make([]byte, len(want))
  2132. _, err := io.ReadFull(r.Body, buf)
  2133. if err != nil {
  2134. t.Error(err)
  2135. return
  2136. }
  2137. if string(buf) != want {
  2138. t.Errorf("read %q; want %q", buf, want)
  2139. }
  2140. }
  2141. }
  2142. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2143. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2144. // http://sourceforge.net/p/curl/bugs/1472/
  2145. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2146. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2147. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2148. if runtime.GOOS != "linux" {
  2149. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2150. }
  2151. if testing.Short() {
  2152. t.Skip("skipping curl test in short mode")
  2153. }
  2154. requireCurl(t)
  2155. var gotConn int32
  2156. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2157. const msg = "Hello from curl!\n"
  2158. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2159. w.Header().Set("Foo", "Bar")
  2160. w.Header().Set("Client-Proto", r.Proto)
  2161. io.WriteString(w, msg)
  2162. }))
  2163. ConfigureServer(ts.Config, &Server{
  2164. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2165. })
  2166. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2167. ts.StartTLS()
  2168. defer ts.Close()
  2169. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2170. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2171. defer kill(container)
  2172. resc := make(chan interface{}, 1)
  2173. go func() {
  2174. res, err := dockerLogs(container)
  2175. if err != nil {
  2176. resc <- err
  2177. } else {
  2178. resc <- res
  2179. }
  2180. }()
  2181. select {
  2182. case res := <-resc:
  2183. if err, ok := res.(error); ok {
  2184. t.Fatal(err)
  2185. }
  2186. body := string(res.([]byte))
  2187. // Search for both "key: value" and "key:value", since curl changed their format
  2188. // Our Dockerfile contains the latest version (no space), but just in case people
  2189. // didn't rebuild, check both.
  2190. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2191. t.Errorf("didn't see foo: Bar header")
  2192. t.Logf("Got: %s", body)
  2193. }
  2194. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2195. t.Errorf("didn't see client-proto: HTTP/2 header")
  2196. t.Logf("Got: %s", res)
  2197. }
  2198. if !strings.Contains(string(res.([]byte)), msg) {
  2199. t.Errorf("didn't see %q content", msg)
  2200. t.Logf("Got: %s", res)
  2201. }
  2202. case <-time.After(3 * time.Second):
  2203. t.Errorf("timeout waiting for curl")
  2204. }
  2205. if atomic.LoadInt32(&gotConn) == 0 {
  2206. t.Error("never saw an http2 connection")
  2207. }
  2208. }
  2209. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2210. func TestServerWithH2Load(t *testing.T) {
  2211. if !*doh2load {
  2212. t.Skip("Skipping without --h2load flag.")
  2213. }
  2214. if runtime.GOOS != "linux" {
  2215. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2216. }
  2217. requireH2load(t)
  2218. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2219. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2220. io.WriteString(w, msg)
  2221. w.(http.Flusher).Flush()
  2222. io.WriteString(w, msg)
  2223. }))
  2224. ts.StartTLS()
  2225. defer ts.Close()
  2226. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2227. "-n100000", "-c100", "-m100", ts.URL)
  2228. cmd.Stdout = os.Stdout
  2229. cmd.Stderr = os.Stderr
  2230. if err := cmd.Run(); err != nil {
  2231. t.Fatal(err)
  2232. }
  2233. }
  2234. // Issue 12843
  2235. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2236. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2237. defer st.Close()
  2238. // shake hands
  2239. st.writePreface()
  2240. st.writeInitialSettings()
  2241. frameSize := defaultMaxReadFrameSize
  2242. var advHeaderListSize *uint32
  2243. st.wantSettings().ForeachSetting(func(s Setting) error {
  2244. switch s.ID {
  2245. case SettingMaxFrameSize:
  2246. if s.Val < minMaxFrameSize {
  2247. frameSize = minMaxFrameSize
  2248. } else if s.Val > maxFrameSize {
  2249. frameSize = maxFrameSize
  2250. } else {
  2251. frameSize = int(s.Val)
  2252. }
  2253. case SettingMaxHeaderListSize:
  2254. advHeaderListSize = &s.Val
  2255. }
  2256. return nil
  2257. })
  2258. st.writeSettingsAck()
  2259. st.wantSettingsAck()
  2260. if advHeaderListSize == nil {
  2261. t.Errorf("server didn't advertise a max header list size")
  2262. } else if *advHeaderListSize == 0 {
  2263. t.Errorf("server advertised a max header list size of 0")
  2264. }
  2265. st.encodeHeaderField(":method", "GET")
  2266. st.encodeHeaderField(":path", "/")
  2267. st.encodeHeaderField(":scheme", "https")
  2268. cookie := strings.Repeat("*", 4058)
  2269. st.encodeHeaderField("cookie", cookie)
  2270. st.writeHeaders(HeadersFrameParam{
  2271. StreamID: 1,
  2272. BlockFragment: st.headerBuf.Bytes(),
  2273. EndStream: true,
  2274. EndHeaders: false,
  2275. })
  2276. // Capture the short encoding of a duplicate ~4K cookie, now
  2277. // that we've already sent it once.
  2278. st.headerBuf.Reset()
  2279. st.encodeHeaderField("cookie", cookie)
  2280. // Now send 1MB of it.
  2281. const size = 1 << 20
  2282. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2283. for len(b) > 0 {
  2284. chunk := b
  2285. if len(chunk) > frameSize {
  2286. chunk = chunk[:frameSize]
  2287. }
  2288. b = b[len(chunk):]
  2289. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2290. }
  2291. h := st.wantHeaders()
  2292. if !h.HeadersEnded() {
  2293. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2294. }
  2295. headers := st.decodeHeader(h.HeaderBlockFragment())
  2296. want := [][2]string{
  2297. {":status", "431"},
  2298. {"content-type", "text/html; charset=utf-8"},
  2299. {"content-length", "63"},
  2300. }
  2301. if !reflect.DeepEqual(headers, want) {
  2302. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2303. }
  2304. }
  2305. func TestCompressionErrorOnWrite(t *testing.T) {
  2306. const maxStrLen = 8 << 10
  2307. var serverConfig *http.Server
  2308. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2309. // No response body.
  2310. }, func(ts *httptest.Server) {
  2311. serverConfig = ts.Config
  2312. serverConfig.MaxHeaderBytes = maxStrLen
  2313. })
  2314. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2315. defer st.Close()
  2316. st.greet()
  2317. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2318. // Crank this up, now that we have a conn connected with the
  2319. // hpack.Decoder's max string length set has been initialized
  2320. // from the earlier low ~8K value. We want this higher so don't
  2321. // hit the max header list size. We only want to test hitting
  2322. // the max string size.
  2323. serverConfig.MaxHeaderBytes = 1 << 20
  2324. // First a request with a header that's exactly the max allowed size
  2325. // for the hpack compression. It's still too long for the header list
  2326. // size, so we'll get the 431 error, but that keeps the compression
  2327. // context still valid.
  2328. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2329. st.writeHeaders(HeadersFrameParam{
  2330. StreamID: 1,
  2331. BlockFragment: hbf,
  2332. EndStream: true,
  2333. EndHeaders: true,
  2334. })
  2335. h := st.wantHeaders()
  2336. if !h.HeadersEnded() {
  2337. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2338. }
  2339. headers := st.decodeHeader(h.HeaderBlockFragment())
  2340. want := [][2]string{
  2341. {":status", "431"},
  2342. {"content-type", "text/html; charset=utf-8"},
  2343. {"content-length", "63"},
  2344. }
  2345. if !reflect.DeepEqual(headers, want) {
  2346. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2347. }
  2348. df := st.wantData()
  2349. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2350. t.Errorf("Unexpected data body: %q", df.Data())
  2351. }
  2352. if !df.StreamEnded() {
  2353. t.Fatalf("expect data stream end")
  2354. }
  2355. // And now send one that's just one byte too big.
  2356. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2357. st.writeHeaders(HeadersFrameParam{
  2358. StreamID: 3,
  2359. BlockFragment: hbf,
  2360. EndStream: true,
  2361. EndHeaders: true,
  2362. })
  2363. ga := st.wantGoAway()
  2364. if ga.ErrCode != ErrCodeCompression {
  2365. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2366. }
  2367. }
  2368. func TestCompressionErrorOnClose(t *testing.T) {
  2369. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2370. // No response body.
  2371. })
  2372. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2373. defer st.Close()
  2374. st.greet()
  2375. hbf := st.encodeHeader("foo", "bar")
  2376. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2377. st.writeHeaders(HeadersFrameParam{
  2378. StreamID: 1,
  2379. BlockFragment: hbf,
  2380. EndStream: true,
  2381. EndHeaders: true,
  2382. })
  2383. ga := st.wantGoAway()
  2384. if ga.ErrCode != ErrCodeCompression {
  2385. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2386. }
  2387. }
  2388. // test that a server handler can read trailers from a client
  2389. func TestServerReadsTrailers(t *testing.T) {
  2390. const testBody = "some test body"
  2391. writeReq := func(st *serverTester) {
  2392. st.writeHeaders(HeadersFrameParam{
  2393. StreamID: 1, // clients send odd numbers
  2394. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2395. EndStream: false,
  2396. EndHeaders: true,
  2397. })
  2398. st.writeData(1, false, []byte(testBody))
  2399. st.writeHeaders(HeadersFrameParam{
  2400. StreamID: 1, // clients send odd numbers
  2401. BlockFragment: st.encodeHeaderRaw(
  2402. "foo", "foov",
  2403. "bar", "barv",
  2404. "baz", "bazv",
  2405. "surprise", "wasn't declared; shouldn't show up",
  2406. ),
  2407. EndStream: true,
  2408. EndHeaders: true,
  2409. })
  2410. }
  2411. checkReq := func(r *http.Request) {
  2412. wantTrailer := http.Header{
  2413. "Foo": nil,
  2414. "Bar": nil,
  2415. "Baz": nil,
  2416. }
  2417. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2418. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2419. }
  2420. slurp, err := ioutil.ReadAll(r.Body)
  2421. if string(slurp) != testBody {
  2422. t.Errorf("read body %q; want %q", slurp, testBody)
  2423. }
  2424. if err != nil {
  2425. t.Fatalf("Body slurp: %v", err)
  2426. }
  2427. wantTrailerAfter := http.Header{
  2428. "Foo": {"foov"},
  2429. "Bar": {"barv"},
  2430. "Baz": {"bazv"},
  2431. }
  2432. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2433. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2434. }
  2435. }
  2436. testServerRequest(t, writeReq, checkReq)
  2437. }
  2438. // test that a server handler can send trailers
  2439. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2440. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2441. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2442. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2443. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2444. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2445. w.Header().Add("Trailer", "Server-Trailer-C")
  2446. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2447. // Regular headers:
  2448. w.Header().Set("Foo", "Bar")
  2449. w.Header().Set("Content-Length", "5") // len("Hello")
  2450. io.WriteString(w, "Hello")
  2451. if withFlush {
  2452. w.(http.Flusher).Flush()
  2453. }
  2454. w.Header().Set("Server-Trailer-A", "valuea")
  2455. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2456. // After a flush, random keys like Server-Surprise shouldn't show up:
  2457. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2458. // But we do permit promoting keys to trailers after a
  2459. // flush if they start with the magic
  2460. // otherwise-invalid "Trailer:" prefix:
  2461. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2462. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2463. w.Header().Set("Trailer:Range", "invalid")
  2464. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2465. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2466. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2467. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2468. return nil
  2469. }, func(st *serverTester) {
  2470. getSlash(st)
  2471. hf := st.wantHeaders()
  2472. if hf.StreamEnded() {
  2473. t.Fatal("response HEADERS had END_STREAM")
  2474. }
  2475. if !hf.HeadersEnded() {
  2476. t.Fatal("response HEADERS didn't have END_HEADERS")
  2477. }
  2478. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2479. wanth := [][2]string{
  2480. {":status", "200"},
  2481. {"foo", "Bar"},
  2482. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2483. {"trailer", "Server-Trailer-C"},
  2484. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2485. {"content-type", "text/plain; charset=utf-8"},
  2486. {"content-length", "5"},
  2487. }
  2488. if !reflect.DeepEqual(goth, wanth) {
  2489. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2490. }
  2491. df := st.wantData()
  2492. if string(df.Data()) != "Hello" {
  2493. t.Fatalf("Client read %q; want Hello", df.Data())
  2494. }
  2495. if df.StreamEnded() {
  2496. t.Fatalf("data frame had STREAM_ENDED")
  2497. }
  2498. tf := st.wantHeaders() // for the trailers
  2499. if !tf.StreamEnded() {
  2500. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2501. }
  2502. if !tf.HeadersEnded() {
  2503. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2504. }
  2505. wanth = [][2]string{
  2506. {"post-header-trailer", "hi1"},
  2507. {"post-header-trailer2", "hi2"},
  2508. {"server-trailer-a", "valuea"},
  2509. {"server-trailer-c", "valuec"},
  2510. }
  2511. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2512. if !reflect.DeepEqual(goth, wanth) {
  2513. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2514. }
  2515. })
  2516. }
  2517. // validate transmitted header field names & values
  2518. // golang.org/issue/14048
  2519. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2520. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2521. w.Header().Add("OK1", "x")
  2522. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2523. w.Header().Add("Bad1\x00", "x") // null in key
  2524. w.Header().Add("Bad2", "x\x00y") // null in value
  2525. return nil
  2526. }, func(st *serverTester) {
  2527. getSlash(st)
  2528. hf := st.wantHeaders()
  2529. if !hf.StreamEnded() {
  2530. t.Error("response HEADERS lacked END_STREAM")
  2531. }
  2532. if !hf.HeadersEnded() {
  2533. t.Fatal("response HEADERS didn't have END_HEADERS")
  2534. }
  2535. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2536. wanth := [][2]string{
  2537. {":status", "200"},
  2538. {"ok1", "x"},
  2539. {"content-type", "text/plain; charset=utf-8"},
  2540. {"content-length", "0"},
  2541. }
  2542. if !reflect.DeepEqual(goth, wanth) {
  2543. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2544. }
  2545. })
  2546. }
  2547. func BenchmarkServerGets(b *testing.B) {
  2548. defer disableGoroutineTracking()()
  2549. b.ReportAllocs()
  2550. const msg = "Hello, world"
  2551. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2552. io.WriteString(w, msg)
  2553. })
  2554. defer st.Close()
  2555. st.greet()
  2556. // Give the server quota to reply. (plus it has the the 64KB)
  2557. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2558. b.Fatal(err)
  2559. }
  2560. for i := 0; i < b.N; i++ {
  2561. id := 1 + uint32(i)*2
  2562. st.writeHeaders(HeadersFrameParam{
  2563. StreamID: id,
  2564. BlockFragment: st.encodeHeader(),
  2565. EndStream: true,
  2566. EndHeaders: true,
  2567. })
  2568. st.wantHeaders()
  2569. df := st.wantData()
  2570. if !df.StreamEnded() {
  2571. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2572. }
  2573. }
  2574. }
  2575. func BenchmarkServerPosts(b *testing.B) {
  2576. defer disableGoroutineTracking()()
  2577. b.ReportAllocs()
  2578. const msg = "Hello, world"
  2579. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2580. io.WriteString(w, msg)
  2581. })
  2582. defer st.Close()
  2583. st.greet()
  2584. // Give the server quota to reply. (plus it has the the 64KB)
  2585. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2586. b.Fatal(err)
  2587. }
  2588. for i := 0; i < b.N; i++ {
  2589. id := 1 + uint32(i)*2
  2590. st.writeHeaders(HeadersFrameParam{
  2591. StreamID: id,
  2592. BlockFragment: st.encodeHeader(":method", "POST"),
  2593. EndStream: false,
  2594. EndHeaders: true,
  2595. })
  2596. st.writeData(id, true, nil)
  2597. st.wantHeaders()
  2598. df := st.wantData()
  2599. if !df.StreamEnded() {
  2600. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2601. }
  2602. }
  2603. }
  2604. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2605. // Verify we don't hang.
  2606. func TestIssue53(t *testing.T) {
  2607. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2608. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2609. s := &http.Server{
  2610. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2611. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2612. w.Write([]byte("hello"))
  2613. }),
  2614. }
  2615. s2 := &Server{
  2616. MaxReadFrameSize: 1 << 16,
  2617. PermitProhibitedCipherSuites: true,
  2618. }
  2619. c := &issue53Conn{[]byte(data), false, false}
  2620. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2621. if !c.closed {
  2622. t.Fatal("connection is not closed")
  2623. }
  2624. }
  2625. type issue53Conn struct {
  2626. data []byte
  2627. closed bool
  2628. written bool
  2629. }
  2630. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2631. if len(c.data) == 0 {
  2632. return 0, io.EOF
  2633. }
  2634. n = copy(b, c.data)
  2635. c.data = c.data[n:]
  2636. return
  2637. }
  2638. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2639. c.written = true
  2640. return len(b), nil
  2641. }
  2642. func (c *issue53Conn) Close() error {
  2643. c.closed = true
  2644. return nil
  2645. }
  2646. func (c *issue53Conn) LocalAddr() net.Addr {
  2647. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2648. }
  2649. func (c *issue53Conn) RemoteAddr() net.Addr {
  2650. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2651. }
  2652. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2653. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2654. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2655. // golang.org/issue/12895
  2656. func TestConfigureServer(t *testing.T) {
  2657. tests := []struct {
  2658. name string
  2659. in http.Server
  2660. wantErr string
  2661. }{
  2662. {
  2663. name: "empty server",
  2664. in: http.Server{},
  2665. },
  2666. {
  2667. name: "just the required cipher suite",
  2668. in: http.Server{
  2669. TLSConfig: &tls.Config{
  2670. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2671. },
  2672. },
  2673. },
  2674. {
  2675. name: "missing required cipher suite",
  2676. in: http.Server{
  2677. TLSConfig: &tls.Config{
  2678. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2679. },
  2680. },
  2681. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2682. },
  2683. {
  2684. name: "required after bad",
  2685. in: http.Server{
  2686. TLSConfig: &tls.Config{
  2687. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2688. },
  2689. },
  2690. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2691. },
  2692. {
  2693. name: "bad after required",
  2694. in: http.Server{
  2695. TLSConfig: &tls.Config{
  2696. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2697. },
  2698. },
  2699. },
  2700. }
  2701. for _, tt := range tests {
  2702. err := ConfigureServer(&tt.in, nil)
  2703. if (err != nil) != (tt.wantErr != "") {
  2704. if tt.wantErr != "" {
  2705. t.Errorf("%s: success, but want error", tt.name)
  2706. } else {
  2707. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2708. }
  2709. }
  2710. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2711. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2712. }
  2713. if err == nil && !tt.in.TLSConfig.PreferServerCipherSuites {
  2714. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2715. }
  2716. }
  2717. }
  2718. func TestServerRejectHeadWithBody(t *testing.T) {
  2719. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2720. // No response body.
  2721. })
  2722. defer st.Close()
  2723. st.greet()
  2724. st.writeHeaders(HeadersFrameParam{
  2725. StreamID: 1, // clients send odd numbers
  2726. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2727. EndStream: false, // what we're testing, a bogus HEAD request with body
  2728. EndHeaders: true,
  2729. })
  2730. st.wantRSTStream(1, ErrCodeProtocol)
  2731. }
  2732. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2733. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2734. // No response body. (or smaller than one frame)
  2735. })
  2736. defer st.Close()
  2737. st.greet()
  2738. st.writeHeaders(HeadersFrameParam{
  2739. StreamID: 1, // clients send odd numbers
  2740. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2741. EndStream: true,
  2742. EndHeaders: true,
  2743. })
  2744. h := st.wantHeaders()
  2745. headers := st.decodeHeader(h.HeaderBlockFragment())
  2746. want := [][2]string{
  2747. {":status", "200"},
  2748. {"content-type", "text/plain; charset=utf-8"},
  2749. }
  2750. if !reflect.DeepEqual(headers, want) {
  2751. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2752. }
  2753. }
  2754. // golang.org/issue/13495
  2755. func TestServerNoDuplicateContentType(t *testing.T) {
  2756. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2757. w.Header()["Content-Type"] = []string{""}
  2758. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2759. })
  2760. defer st.Close()
  2761. st.greet()
  2762. st.writeHeaders(HeadersFrameParam{
  2763. StreamID: 1,
  2764. BlockFragment: st.encodeHeader(),
  2765. EndStream: true,
  2766. EndHeaders: true,
  2767. })
  2768. h := st.wantHeaders()
  2769. headers := st.decodeHeader(h.HeaderBlockFragment())
  2770. want := [][2]string{
  2771. {":status", "200"},
  2772. {"content-type", ""},
  2773. {"content-length", "41"},
  2774. }
  2775. if !reflect.DeepEqual(headers, want) {
  2776. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2777. }
  2778. }
  2779. func disableGoroutineTracking() (restore func()) {
  2780. old := DebugGoroutines
  2781. DebugGoroutines = false
  2782. return func() { DebugGoroutines = old }
  2783. }
  2784. func BenchmarkServer_GetRequest(b *testing.B) {
  2785. defer disableGoroutineTracking()()
  2786. b.ReportAllocs()
  2787. const msg = "Hello, world."
  2788. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2789. n, err := io.Copy(ioutil.Discard, r.Body)
  2790. if err != nil || n > 0 {
  2791. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2792. }
  2793. io.WriteString(w, msg)
  2794. })
  2795. defer st.Close()
  2796. st.greet()
  2797. // Give the server quota to reply. (plus it has the the 64KB)
  2798. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2799. b.Fatal(err)
  2800. }
  2801. hbf := st.encodeHeader(":method", "GET")
  2802. for i := 0; i < b.N; i++ {
  2803. streamID := uint32(1 + 2*i)
  2804. st.writeHeaders(HeadersFrameParam{
  2805. StreamID: streamID,
  2806. BlockFragment: hbf,
  2807. EndStream: true,
  2808. EndHeaders: true,
  2809. })
  2810. st.wantHeaders()
  2811. st.wantData()
  2812. }
  2813. }
  2814. func BenchmarkServer_PostRequest(b *testing.B) {
  2815. defer disableGoroutineTracking()()
  2816. b.ReportAllocs()
  2817. const msg = "Hello, world."
  2818. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2819. n, err := io.Copy(ioutil.Discard, r.Body)
  2820. if err != nil || n > 0 {
  2821. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2822. }
  2823. io.WriteString(w, msg)
  2824. })
  2825. defer st.Close()
  2826. st.greet()
  2827. // Give the server quota to reply. (plus it has the the 64KB)
  2828. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2829. b.Fatal(err)
  2830. }
  2831. hbf := st.encodeHeader(":method", "POST")
  2832. for i := 0; i < b.N; i++ {
  2833. streamID := uint32(1 + 2*i)
  2834. st.writeHeaders(HeadersFrameParam{
  2835. StreamID: streamID,
  2836. BlockFragment: hbf,
  2837. EndStream: false,
  2838. EndHeaders: true,
  2839. })
  2840. st.writeData(streamID, true, nil)
  2841. st.wantHeaders()
  2842. st.wantData()
  2843. }
  2844. }
  2845. type connStateConn struct {
  2846. net.Conn
  2847. cs tls.ConnectionState
  2848. }
  2849. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  2850. // golang.org/issue/12737 -- handle any net.Conn, not just
  2851. // *tls.Conn.
  2852. func TestServerHandleCustomConn(t *testing.T) {
  2853. var s Server
  2854. c1, c2 := net.Pipe()
  2855. clientDone := make(chan struct{})
  2856. handlerDone := make(chan struct{})
  2857. var req *http.Request
  2858. go func() {
  2859. defer close(clientDone)
  2860. defer c2.Close()
  2861. fr := NewFramer(c2, c2)
  2862. io.WriteString(c2, ClientPreface)
  2863. fr.WriteSettings()
  2864. fr.WriteSettingsAck()
  2865. f, err := fr.ReadFrame()
  2866. if err != nil {
  2867. t.Error(err)
  2868. return
  2869. }
  2870. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  2871. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  2872. return
  2873. }
  2874. f, err = fr.ReadFrame()
  2875. if err != nil {
  2876. t.Error(err)
  2877. return
  2878. }
  2879. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  2880. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  2881. return
  2882. }
  2883. var henc hpackEncoder
  2884. fr.WriteHeaders(HeadersFrameParam{
  2885. StreamID: 1,
  2886. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  2887. EndStream: true,
  2888. EndHeaders: true,
  2889. })
  2890. go io.Copy(ioutil.Discard, c2)
  2891. <-handlerDone
  2892. }()
  2893. const testString = "my custom ConnectionState"
  2894. fakeConnState := tls.ConnectionState{
  2895. ServerName: testString,
  2896. Version: tls.VersionTLS12,
  2897. }
  2898. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  2899. BaseConfig: &http.Server{
  2900. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2901. defer close(handlerDone)
  2902. req = r
  2903. }),
  2904. }})
  2905. select {
  2906. case <-clientDone:
  2907. case <-time.After(5 * time.Second):
  2908. t.Fatal("timeout waiting for handler")
  2909. }
  2910. if req.TLS == nil {
  2911. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  2912. }
  2913. if req.TLS.ServerName != testString {
  2914. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  2915. }
  2916. }
  2917. // golang.org/issue/14214
  2918. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  2919. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2920. t.Errorf("should not get to Handler")
  2921. return nil
  2922. }, func(st *serverTester) {
  2923. st.bodylessReq1("connection", "foo")
  2924. hf := st.wantHeaders()
  2925. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2926. wanth := [][2]string{
  2927. {":status", "400"},
  2928. {"content-type", "text/plain; charset=utf-8"},
  2929. {"x-content-type-options", "nosniff"},
  2930. {"content-length", "51"},
  2931. }
  2932. if !reflect.DeepEqual(goth, wanth) {
  2933. t.Errorf("Got headers %v; want %v", goth, wanth)
  2934. }
  2935. })
  2936. }
  2937. type hpackEncoder struct {
  2938. enc *hpack.Encoder
  2939. buf bytes.Buffer
  2940. }
  2941. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  2942. if len(headers)%2 == 1 {
  2943. panic("odd number of kv args")
  2944. }
  2945. he.buf.Reset()
  2946. if he.enc == nil {
  2947. he.enc = hpack.NewEncoder(&he.buf)
  2948. }
  2949. for len(headers) > 0 {
  2950. k, v := headers[0], headers[1]
  2951. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  2952. if err != nil {
  2953. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  2954. }
  2955. headers = headers[2:]
  2956. }
  2957. return he.buf.Bytes()
  2958. }
  2959. func TestCheckValidHTTP2Request(t *testing.T) {
  2960. tests := []struct {
  2961. req *http.Request
  2962. want error
  2963. }{
  2964. {
  2965. req: &http.Request{Header: http.Header{"Te": {"trailers"}}},
  2966. want: nil,
  2967. },
  2968. {
  2969. req: &http.Request{Header: http.Header{"Te": {"trailers", "bogus"}}},
  2970. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  2971. },
  2972. {
  2973. req: &http.Request{Header: http.Header{"Foo": {""}}},
  2974. want: nil,
  2975. },
  2976. {
  2977. req: &http.Request{Header: http.Header{"Connection": {""}}},
  2978. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  2979. },
  2980. {
  2981. req: &http.Request{Header: http.Header{"Proxy-Connection": {""}}},
  2982. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  2983. },
  2984. {
  2985. req: &http.Request{Header: http.Header{"Keep-Alive": {""}}},
  2986. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  2987. },
  2988. {
  2989. req: &http.Request{Header: http.Header{"Upgrade": {""}}},
  2990. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  2991. },
  2992. }
  2993. for i, tt := range tests {
  2994. got := checkValidHTTP2Request(tt.req)
  2995. if !reflect.DeepEqual(got, tt.want) {
  2996. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  2997. }
  2998. }
  2999. }
  3000. // golang.org/issue/14030
  3001. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3002. const msg = "Hello"
  3003. const msg2 = "World"
  3004. doRead := make(chan bool, 1)
  3005. defer close(doRead) // fallback cleanup
  3006. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3007. io.WriteString(w, msg)
  3008. w.(http.Flusher).Flush()
  3009. // Do a read, which might force a 100-continue status to be sent.
  3010. <-doRead
  3011. r.Body.Read(make([]byte, 10))
  3012. io.WriteString(w, msg2)
  3013. }, optOnlyServer)
  3014. defer st.Close()
  3015. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3016. defer tr.CloseIdleConnections()
  3017. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3018. req.Header.Set("Expect", "100-continue")
  3019. res, err := tr.RoundTrip(req)
  3020. if err != nil {
  3021. t.Fatal(err)
  3022. }
  3023. defer res.Body.Close()
  3024. buf := make([]byte, len(msg))
  3025. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3026. t.Fatal(err)
  3027. }
  3028. if string(buf) != msg {
  3029. t.Fatalf("msg = %q; want %q", buf, msg)
  3030. }
  3031. doRead <- true
  3032. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3033. t.Fatal(err)
  3034. }
  3035. if string(buf) != msg2 {
  3036. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3037. }
  3038. }