server_test.go 103 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. serverLogBuf bytes.Buffer // logger for httptest.Server
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // If http2debug!=2, then we capture Frame debug logs that will be written
  48. // to t.Log after a test fails. The read and write logs use separate locks
  49. // and buffers so we don't accidentally introduce synchronization between
  50. // the read and write goroutines, which may hide data races.
  51. frameReadLogMu sync.Mutex
  52. frameReadLogBuf bytes.Buffer
  53. frameWriteLogMu sync.Mutex
  54. frameWriteLogBuf bytes.Buffer
  55. // writing headers:
  56. headerBuf bytes.Buffer
  57. hpackEnc *hpack.Encoder
  58. }
  59. func init() {
  60. testHookOnPanicMu = new(sync.Mutex)
  61. goAwayTimeout = 25 * time.Millisecond
  62. }
  63. func resetHooks() {
  64. testHookOnPanicMu.Lock()
  65. testHookOnPanic = nil
  66. testHookOnPanicMu.Unlock()
  67. }
  68. type serverTesterOpt string
  69. var optOnlyServer = serverTesterOpt("only_server")
  70. var optQuiet = serverTesterOpt("quiet_logging")
  71. var optFramerReuseFrames = serverTesterOpt("frame_reuse_frames")
  72. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  73. resetHooks()
  74. ts := httptest.NewUnstartedServer(handler)
  75. tlsConfig := &tls.Config{
  76. InsecureSkipVerify: true,
  77. NextProtos: []string{NextProtoTLS},
  78. }
  79. var onlyServer, quiet, framerReuseFrames bool
  80. h2server := new(Server)
  81. for _, opt := range opts {
  82. switch v := opt.(type) {
  83. case func(*tls.Config):
  84. v(tlsConfig)
  85. case func(*httptest.Server):
  86. v(ts)
  87. case func(*Server):
  88. v(h2server)
  89. case serverTesterOpt:
  90. switch v {
  91. case optOnlyServer:
  92. onlyServer = true
  93. case optQuiet:
  94. quiet = true
  95. case optFramerReuseFrames:
  96. framerReuseFrames = true
  97. }
  98. case func(net.Conn, http.ConnState):
  99. ts.Config.ConnState = v
  100. default:
  101. t.Fatalf("unknown newServerTester option type %T", v)
  102. }
  103. }
  104. ConfigureServer(ts.Config, h2server)
  105. st := &serverTester{
  106. t: t,
  107. ts: ts,
  108. }
  109. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  110. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  111. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  112. if quiet {
  113. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  114. } else {
  115. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, &st.serverLogBuf), "", log.LstdFlags)
  116. }
  117. ts.StartTLS()
  118. if VerboseLogs {
  119. t.Logf("Running test server at: %s", ts.URL)
  120. }
  121. testHookGetServerConn = func(v *serverConn) {
  122. st.scMu.Lock()
  123. defer st.scMu.Unlock()
  124. st.sc = v
  125. }
  126. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  127. if !onlyServer {
  128. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  129. if err != nil {
  130. t.Fatal(err)
  131. }
  132. st.cc = cc
  133. st.fr = NewFramer(cc, cc)
  134. if framerReuseFrames {
  135. st.fr.SetReuseFrames()
  136. }
  137. if !logFrameReads && !logFrameWrites {
  138. st.fr.debugReadLoggerf = func(m string, v ...interface{}) {
  139. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  140. st.frameReadLogMu.Lock()
  141. fmt.Fprintf(&st.frameReadLogBuf, m, v...)
  142. st.frameReadLogMu.Unlock()
  143. }
  144. st.fr.debugWriteLoggerf = func(m string, v ...interface{}) {
  145. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  146. st.frameWriteLogMu.Lock()
  147. fmt.Fprintf(&st.frameWriteLogBuf, m, v...)
  148. st.frameWriteLogMu.Unlock()
  149. }
  150. st.fr.logReads = true
  151. st.fr.logWrites = true
  152. }
  153. }
  154. return st
  155. }
  156. func (st *serverTester) closeConn() {
  157. st.scMu.Lock()
  158. defer st.scMu.Unlock()
  159. st.sc.conn.Close()
  160. }
  161. func (st *serverTester) addLogFilter(phrase string) {
  162. st.logFilter = append(st.logFilter, phrase)
  163. }
  164. func (st *serverTester) stream(id uint32) *stream {
  165. ch := make(chan *stream, 1)
  166. st.sc.serveMsgCh <- func(int) {
  167. ch <- st.sc.streams[id]
  168. }
  169. return <-ch
  170. }
  171. func (st *serverTester) streamState(id uint32) streamState {
  172. ch := make(chan streamState, 1)
  173. st.sc.serveMsgCh <- func(int) {
  174. state, _ := st.sc.state(id)
  175. ch <- state
  176. }
  177. return <-ch
  178. }
  179. // loopNum reports how many times this conn's select loop has gone around.
  180. func (st *serverTester) loopNum() int {
  181. lastc := make(chan int, 1)
  182. st.sc.serveMsgCh <- func(loopNum int) {
  183. lastc <- loopNum
  184. }
  185. return <-lastc
  186. }
  187. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  188. // The heuristic is that the server connection's serve loop must schedule
  189. // 50 times in a row without any channel sends or receives occurring.
  190. func (st *serverTester) awaitIdle() {
  191. remain := 50
  192. last := st.loopNum()
  193. for remain > 0 {
  194. n := st.loopNum()
  195. if n == last+1 {
  196. remain--
  197. } else {
  198. remain = 50
  199. }
  200. last = n
  201. }
  202. }
  203. func (st *serverTester) Close() {
  204. if st.t.Failed() {
  205. st.frameReadLogMu.Lock()
  206. if st.frameReadLogBuf.Len() > 0 {
  207. st.t.Logf("Framer read log:\n%s", st.frameReadLogBuf.String())
  208. }
  209. st.frameReadLogMu.Unlock()
  210. st.frameWriteLogMu.Lock()
  211. if st.frameWriteLogBuf.Len() > 0 {
  212. st.t.Logf("Framer write log:\n%s", st.frameWriteLogBuf.String())
  213. }
  214. st.frameWriteLogMu.Unlock()
  215. // If we failed already (and are likely in a Fatal,
  216. // unwindowing), force close the connection, so the
  217. // httptest.Server doesn't wait forever for the conn
  218. // to close.
  219. if st.cc != nil {
  220. st.cc.Close()
  221. }
  222. }
  223. st.ts.Close()
  224. if st.cc != nil {
  225. st.cc.Close()
  226. }
  227. log.SetOutput(os.Stderr)
  228. }
  229. // greet initiates the client's HTTP/2 connection into a state where
  230. // frames may be sent.
  231. func (st *serverTester) greet() {
  232. st.greetAndCheckSettings(func(Setting) error { return nil })
  233. }
  234. func (st *serverTester) greetAndCheckSettings(checkSetting func(s Setting) error) {
  235. st.writePreface()
  236. st.writeInitialSettings()
  237. st.wantSettings().ForeachSetting(checkSetting)
  238. st.writeSettingsAck()
  239. // The initial WINDOW_UPDATE and SETTINGS ACK can come in any order.
  240. var gotSettingsAck bool
  241. var gotWindowUpdate bool
  242. for i := 0; i < 2; i++ {
  243. f, err := st.readFrame()
  244. if err != nil {
  245. st.t.Fatal(err)
  246. }
  247. switch f := f.(type) {
  248. case *SettingsFrame:
  249. if !f.Header().Flags.Has(FlagSettingsAck) {
  250. st.t.Fatal("Settings Frame didn't have ACK set")
  251. }
  252. gotSettingsAck = true
  253. case *WindowUpdateFrame:
  254. if f.FrameHeader.StreamID != 0 {
  255. st.t.Fatalf("WindowUpdate StreamID = %d; want 0", f.FrameHeader.StreamID)
  256. }
  257. incr := uint32((&Server{}).initialConnRecvWindowSize() - initialWindowSize)
  258. if f.Increment != incr {
  259. st.t.Fatalf("WindowUpdate increment = %d; want %d", f.Increment, incr)
  260. }
  261. gotWindowUpdate = true
  262. default:
  263. st.t.Fatalf("Wanting a settings ACK or window update, received a %T", f)
  264. }
  265. }
  266. if !gotSettingsAck {
  267. st.t.Fatalf("Didn't get a settings ACK")
  268. }
  269. if !gotWindowUpdate {
  270. st.t.Fatalf("Didn't get a window update")
  271. }
  272. }
  273. func (st *serverTester) writePreface() {
  274. n, err := st.cc.Write(clientPreface)
  275. if err != nil {
  276. st.t.Fatalf("Error writing client preface: %v", err)
  277. }
  278. if n != len(clientPreface) {
  279. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  280. }
  281. }
  282. func (st *serverTester) writeInitialSettings() {
  283. if err := st.fr.WriteSettings(); err != nil {
  284. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  285. }
  286. }
  287. func (st *serverTester) writeSettingsAck() {
  288. if err := st.fr.WriteSettingsAck(); err != nil {
  289. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  290. }
  291. }
  292. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  293. if err := st.fr.WriteHeaders(p); err != nil {
  294. st.t.Fatalf("Error writing HEADERS: %v", err)
  295. }
  296. }
  297. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  298. if err := st.fr.WritePriority(id, p); err != nil {
  299. st.t.Fatalf("Error writing PRIORITY: %v", err)
  300. }
  301. }
  302. func (st *serverTester) encodeHeaderField(k, v string) {
  303. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  304. if err != nil {
  305. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  306. }
  307. }
  308. // encodeHeaderRaw is the magic-free version of encodeHeader.
  309. // It takes 0 or more (k, v) pairs and encodes them.
  310. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  311. if len(headers)%2 == 1 {
  312. panic("odd number of kv args")
  313. }
  314. st.headerBuf.Reset()
  315. for len(headers) > 0 {
  316. k, v := headers[0], headers[1]
  317. st.encodeHeaderField(k, v)
  318. headers = headers[2:]
  319. }
  320. return st.headerBuf.Bytes()
  321. }
  322. // encodeHeader encodes headers and returns their HPACK bytes. headers
  323. // must contain an even number of key/value pairs. There may be
  324. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  325. // :scheme headers default to GET, / and https. The :authority header
  326. // defaults to st.ts.Listener.Addr().
  327. func (st *serverTester) encodeHeader(headers ...string) []byte {
  328. if len(headers)%2 == 1 {
  329. panic("odd number of kv args")
  330. }
  331. st.headerBuf.Reset()
  332. defaultAuthority := st.ts.Listener.Addr().String()
  333. if len(headers) == 0 {
  334. // Fast path, mostly for benchmarks, so test code doesn't pollute
  335. // profiles when we're looking to improve server allocations.
  336. st.encodeHeaderField(":method", "GET")
  337. st.encodeHeaderField(":scheme", "https")
  338. st.encodeHeaderField(":authority", defaultAuthority)
  339. st.encodeHeaderField(":path", "/")
  340. return st.headerBuf.Bytes()
  341. }
  342. if len(headers) == 2 && headers[0] == ":method" {
  343. // Another fast path for benchmarks.
  344. st.encodeHeaderField(":method", headers[1])
  345. st.encodeHeaderField(":scheme", "https")
  346. st.encodeHeaderField(":authority", defaultAuthority)
  347. st.encodeHeaderField(":path", "/")
  348. return st.headerBuf.Bytes()
  349. }
  350. pseudoCount := map[string]int{}
  351. keys := []string{":method", ":scheme", ":authority", ":path"}
  352. vals := map[string][]string{
  353. ":method": {"GET"},
  354. ":scheme": {"https"},
  355. ":authority": {defaultAuthority},
  356. ":path": {"/"},
  357. }
  358. for len(headers) > 0 {
  359. k, v := headers[0], headers[1]
  360. headers = headers[2:]
  361. if _, ok := vals[k]; !ok {
  362. keys = append(keys, k)
  363. }
  364. if strings.HasPrefix(k, ":") {
  365. pseudoCount[k]++
  366. if pseudoCount[k] == 1 {
  367. vals[k] = []string{v}
  368. } else {
  369. // Allows testing of invalid headers w/ dup pseudo fields.
  370. vals[k] = append(vals[k], v)
  371. }
  372. } else {
  373. vals[k] = append(vals[k], v)
  374. }
  375. }
  376. for _, k := range keys {
  377. for _, v := range vals[k] {
  378. st.encodeHeaderField(k, v)
  379. }
  380. }
  381. return st.headerBuf.Bytes()
  382. }
  383. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  384. func (st *serverTester) bodylessReq1(headers ...string) {
  385. st.writeHeaders(HeadersFrameParam{
  386. StreamID: 1, // clients send odd numbers
  387. BlockFragment: st.encodeHeader(headers...),
  388. EndStream: true,
  389. EndHeaders: true,
  390. })
  391. }
  392. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  393. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  394. st.t.Fatalf("Error writing DATA: %v", err)
  395. }
  396. }
  397. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  398. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  399. st.t.Fatalf("Error writing DATA: %v", err)
  400. }
  401. }
  402. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  403. ch := make(chan interface{}, 1)
  404. go func() {
  405. fr, err := fr.ReadFrame()
  406. if err != nil {
  407. ch <- err
  408. } else {
  409. ch <- fr
  410. }
  411. }()
  412. t := time.NewTimer(wait)
  413. select {
  414. case v := <-ch:
  415. t.Stop()
  416. if fr, ok := v.(Frame); ok {
  417. return fr, nil
  418. }
  419. return nil, v.(error)
  420. case <-t.C:
  421. return nil, errors.New("timeout waiting for frame")
  422. }
  423. }
  424. func (st *serverTester) readFrame() (Frame, error) {
  425. return readFrameTimeout(st.fr, 2*time.Second)
  426. }
  427. func (st *serverTester) wantHeaders() *HeadersFrame {
  428. f, err := st.readFrame()
  429. if err != nil {
  430. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  431. }
  432. hf, ok := f.(*HeadersFrame)
  433. if !ok {
  434. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  435. }
  436. return hf
  437. }
  438. func (st *serverTester) wantContinuation() *ContinuationFrame {
  439. f, err := st.readFrame()
  440. if err != nil {
  441. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  442. }
  443. cf, ok := f.(*ContinuationFrame)
  444. if !ok {
  445. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  446. }
  447. return cf
  448. }
  449. func (st *serverTester) wantData() *DataFrame {
  450. f, err := st.readFrame()
  451. if err != nil {
  452. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  453. }
  454. df, ok := f.(*DataFrame)
  455. if !ok {
  456. st.t.Fatalf("got a %T; want *DataFrame", f)
  457. }
  458. return df
  459. }
  460. func (st *serverTester) wantSettings() *SettingsFrame {
  461. f, err := st.readFrame()
  462. if err != nil {
  463. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  464. }
  465. sf, ok := f.(*SettingsFrame)
  466. if !ok {
  467. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  468. }
  469. return sf
  470. }
  471. func (st *serverTester) wantPing() *PingFrame {
  472. f, err := st.readFrame()
  473. if err != nil {
  474. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  475. }
  476. pf, ok := f.(*PingFrame)
  477. if !ok {
  478. st.t.Fatalf("got a %T; want *PingFrame", f)
  479. }
  480. return pf
  481. }
  482. func (st *serverTester) wantGoAway() *GoAwayFrame {
  483. f, err := st.readFrame()
  484. if err != nil {
  485. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  486. }
  487. gf, ok := f.(*GoAwayFrame)
  488. if !ok {
  489. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  490. }
  491. return gf
  492. }
  493. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  494. f, err := st.readFrame()
  495. if err != nil {
  496. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  497. }
  498. rs, ok := f.(*RSTStreamFrame)
  499. if !ok {
  500. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  501. }
  502. if rs.FrameHeader.StreamID != streamID {
  503. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  504. }
  505. if rs.ErrCode != errCode {
  506. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  507. }
  508. }
  509. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  510. f, err := st.readFrame()
  511. if err != nil {
  512. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  513. }
  514. wu, ok := f.(*WindowUpdateFrame)
  515. if !ok {
  516. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  517. }
  518. if wu.FrameHeader.StreamID != streamID {
  519. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  520. }
  521. if wu.Increment != incr {
  522. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  523. }
  524. }
  525. func (st *serverTester) wantSettingsAck() {
  526. f, err := st.readFrame()
  527. if err != nil {
  528. st.t.Fatal(err)
  529. }
  530. sf, ok := f.(*SettingsFrame)
  531. if !ok {
  532. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  533. }
  534. if !sf.Header().Flags.Has(FlagSettingsAck) {
  535. st.t.Fatal("Settings Frame didn't have ACK set")
  536. }
  537. }
  538. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  539. f, err := st.readFrame()
  540. if err != nil {
  541. st.t.Fatal(err)
  542. }
  543. ppf, ok := f.(*PushPromiseFrame)
  544. if !ok {
  545. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  546. }
  547. return ppf
  548. }
  549. func TestServer(t *testing.T) {
  550. gotReq := make(chan bool, 1)
  551. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  552. w.Header().Set("Foo", "Bar")
  553. gotReq <- true
  554. })
  555. defer st.Close()
  556. covers("3.5", `
  557. The server connection preface consists of a potentially empty
  558. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  559. server sends in the HTTP/2 connection.
  560. `)
  561. st.greet()
  562. st.writeHeaders(HeadersFrameParam{
  563. StreamID: 1, // clients send odd numbers
  564. BlockFragment: st.encodeHeader(),
  565. EndStream: true, // no DATA frames
  566. EndHeaders: true,
  567. })
  568. select {
  569. case <-gotReq:
  570. case <-time.After(2 * time.Second):
  571. t.Error("timeout waiting for request")
  572. }
  573. }
  574. func TestServer_Request_Get(t *testing.T) {
  575. testServerRequest(t, func(st *serverTester) {
  576. st.writeHeaders(HeadersFrameParam{
  577. StreamID: 1, // clients send odd numbers
  578. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  579. EndStream: true, // no DATA frames
  580. EndHeaders: true,
  581. })
  582. }, func(r *http.Request) {
  583. if r.Method != "GET" {
  584. t.Errorf("Method = %q; want GET", r.Method)
  585. }
  586. if r.URL.Path != "/" {
  587. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  588. }
  589. if r.ContentLength != 0 {
  590. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  591. }
  592. if r.Close {
  593. t.Error("Close = true; want false")
  594. }
  595. if !strings.Contains(r.RemoteAddr, ":") {
  596. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  597. }
  598. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  599. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  600. }
  601. wantHeader := http.Header{
  602. "Foo-Bar": []string{"some-value"},
  603. }
  604. if !reflect.DeepEqual(r.Header, wantHeader) {
  605. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  606. }
  607. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  608. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  609. }
  610. })
  611. }
  612. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  613. testServerRequest(t, func(st *serverTester) {
  614. st.writeHeaders(HeadersFrameParam{
  615. StreamID: 1, // clients send odd numbers
  616. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  617. EndStream: true, // no DATA frames
  618. EndHeaders: true,
  619. })
  620. }, func(r *http.Request) {
  621. if r.RequestURI != "/%2f/" {
  622. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  623. }
  624. if r.URL.Path != "///" {
  625. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  626. }
  627. })
  628. }
  629. // TODO: add a test with EndStream=true on the HEADERS but setting a
  630. // Content-Length anyway. Should we just omit it and force it to
  631. // zero?
  632. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  633. testServerRequest(t, func(st *serverTester) {
  634. st.writeHeaders(HeadersFrameParam{
  635. StreamID: 1, // clients send odd numbers
  636. BlockFragment: st.encodeHeader(":method", "POST"),
  637. EndStream: true,
  638. EndHeaders: true,
  639. })
  640. }, func(r *http.Request) {
  641. if r.Method != "POST" {
  642. t.Errorf("Method = %q; want POST", r.Method)
  643. }
  644. if r.ContentLength != 0 {
  645. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  646. }
  647. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  648. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  649. }
  650. })
  651. }
  652. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  653. testBodyContents(t, -1, "", func(st *serverTester) {
  654. st.writeHeaders(HeadersFrameParam{
  655. StreamID: 1, // clients send odd numbers
  656. BlockFragment: st.encodeHeader(":method", "POST"),
  657. EndStream: false, // to say DATA frames are coming
  658. EndHeaders: true,
  659. })
  660. st.writeData(1, true, nil) // just kidding. empty body.
  661. })
  662. }
  663. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  664. const content = "Some content"
  665. testBodyContents(t, -1, content, func(st *serverTester) {
  666. st.writeHeaders(HeadersFrameParam{
  667. StreamID: 1, // clients send odd numbers
  668. BlockFragment: st.encodeHeader(":method", "POST"),
  669. EndStream: false, // to say DATA frames are coming
  670. EndHeaders: true,
  671. })
  672. st.writeData(1, true, []byte(content))
  673. })
  674. }
  675. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  676. const content = "Some content"
  677. testBodyContents(t, -1, content, func(st *serverTester) {
  678. st.writeHeaders(HeadersFrameParam{
  679. StreamID: 1, // clients send odd numbers
  680. BlockFragment: st.encodeHeader(":method", "POST"),
  681. EndStream: false, // to say DATA frames are coming
  682. EndHeaders: true,
  683. })
  684. st.writeData(1, false, []byte(content[:5]))
  685. st.writeData(1, true, []byte(content[5:]))
  686. })
  687. }
  688. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  689. const content = "Some content"
  690. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  691. st.writeHeaders(HeadersFrameParam{
  692. StreamID: 1, // clients send odd numbers
  693. BlockFragment: st.encodeHeader(
  694. ":method", "POST",
  695. "content-length", strconv.Itoa(len(content)),
  696. ),
  697. EndStream: false, // to say DATA frames are coming
  698. EndHeaders: true,
  699. })
  700. st.writeData(1, true, []byte(content))
  701. })
  702. }
  703. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  704. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  705. func(st *serverTester) {
  706. st.writeHeaders(HeadersFrameParam{
  707. StreamID: 1, // clients send odd numbers
  708. BlockFragment: st.encodeHeader(
  709. ":method", "POST",
  710. "content-length", "3",
  711. ),
  712. EndStream: false, // to say DATA frames are coming
  713. EndHeaders: true,
  714. })
  715. st.writeData(1, true, []byte("12"))
  716. })
  717. }
  718. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  719. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  720. func(st *serverTester) {
  721. st.writeHeaders(HeadersFrameParam{
  722. StreamID: 1, // clients send odd numbers
  723. BlockFragment: st.encodeHeader(
  724. ":method", "POST",
  725. "content-length", "4",
  726. ),
  727. EndStream: false, // to say DATA frames are coming
  728. EndHeaders: true,
  729. })
  730. st.writeData(1, true, []byte("12345"))
  731. })
  732. }
  733. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  734. testServerRequest(t, write, func(r *http.Request) {
  735. if r.Method != "POST" {
  736. t.Errorf("Method = %q; want POST", r.Method)
  737. }
  738. if r.ContentLength != wantContentLength {
  739. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  740. }
  741. all, err := ioutil.ReadAll(r.Body)
  742. if err != nil {
  743. t.Fatal(err)
  744. }
  745. if string(all) != wantBody {
  746. t.Errorf("Read = %q; want %q", all, wantBody)
  747. }
  748. if err := r.Body.Close(); err != nil {
  749. t.Fatalf("Close: %v", err)
  750. }
  751. })
  752. }
  753. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  754. testServerRequest(t, write, func(r *http.Request) {
  755. if r.Method != "POST" {
  756. t.Errorf("Method = %q; want POST", r.Method)
  757. }
  758. if r.ContentLength != wantContentLength {
  759. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  760. }
  761. all, err := ioutil.ReadAll(r.Body)
  762. if err == nil {
  763. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  764. wantReadError, all)
  765. }
  766. if !strings.Contains(err.Error(), wantReadError) {
  767. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  768. }
  769. if err := r.Body.Close(); err != nil {
  770. t.Fatalf("Close: %v", err)
  771. }
  772. })
  773. }
  774. // Using a Host header, instead of :authority
  775. func TestServer_Request_Get_Host(t *testing.T) {
  776. const host = "example.com"
  777. testServerRequest(t, func(st *serverTester) {
  778. st.writeHeaders(HeadersFrameParam{
  779. StreamID: 1, // clients send odd numbers
  780. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  781. EndStream: true,
  782. EndHeaders: true,
  783. })
  784. }, func(r *http.Request) {
  785. if r.Host != host {
  786. t.Errorf("Host = %q; want %q", r.Host, host)
  787. }
  788. })
  789. }
  790. // Using an :authority pseudo-header, instead of Host
  791. func TestServer_Request_Get_Authority(t *testing.T) {
  792. const host = "example.com"
  793. testServerRequest(t, func(st *serverTester) {
  794. st.writeHeaders(HeadersFrameParam{
  795. StreamID: 1, // clients send odd numbers
  796. BlockFragment: st.encodeHeader(":authority", host),
  797. EndStream: true,
  798. EndHeaders: true,
  799. })
  800. }, func(r *http.Request) {
  801. if r.Host != host {
  802. t.Errorf("Host = %q; want %q", r.Host, host)
  803. }
  804. })
  805. }
  806. func TestServer_Request_WithContinuation(t *testing.T) {
  807. wantHeader := http.Header{
  808. "Foo-One": []string{"value-one"},
  809. "Foo-Two": []string{"value-two"},
  810. "Foo-Three": []string{"value-three"},
  811. }
  812. testServerRequest(t, func(st *serverTester) {
  813. fullHeaders := st.encodeHeader(
  814. "foo-one", "value-one",
  815. "foo-two", "value-two",
  816. "foo-three", "value-three",
  817. )
  818. remain := fullHeaders
  819. chunks := 0
  820. for len(remain) > 0 {
  821. const maxChunkSize = 5
  822. chunk := remain
  823. if len(chunk) > maxChunkSize {
  824. chunk = chunk[:maxChunkSize]
  825. }
  826. remain = remain[len(chunk):]
  827. if chunks == 0 {
  828. st.writeHeaders(HeadersFrameParam{
  829. StreamID: 1, // clients send odd numbers
  830. BlockFragment: chunk,
  831. EndStream: true, // no DATA frames
  832. EndHeaders: false, // we'll have continuation frames
  833. })
  834. } else {
  835. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  836. if err != nil {
  837. t.Fatal(err)
  838. }
  839. }
  840. chunks++
  841. }
  842. if chunks < 2 {
  843. t.Fatal("too few chunks")
  844. }
  845. }, func(r *http.Request) {
  846. if !reflect.DeepEqual(r.Header, wantHeader) {
  847. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  848. }
  849. })
  850. }
  851. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  852. func TestServer_Request_CookieConcat(t *testing.T) {
  853. const host = "example.com"
  854. testServerRequest(t, func(st *serverTester) {
  855. st.bodylessReq1(
  856. ":authority", host,
  857. "cookie", "a=b",
  858. "cookie", "c=d",
  859. "cookie", "e=f",
  860. )
  861. }, func(r *http.Request) {
  862. const want = "a=b; c=d; e=f"
  863. if got := r.Header.Get("Cookie"); got != want {
  864. t.Errorf("Cookie = %q; want %q", got, want)
  865. }
  866. })
  867. }
  868. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  869. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  870. }
  871. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  872. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  873. }
  874. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  875. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  876. }
  877. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  878. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  879. }
  880. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  881. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  882. }
  883. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  884. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  885. }
  886. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  887. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  888. }
  889. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  890. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  891. }
  892. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  893. // 8.1.2.3 Request Pseudo-Header Fields
  894. // "All HTTP/2 requests MUST include exactly one valid value" ...
  895. testRejectRequest(t, func(st *serverTester) {
  896. st.addLogFilter("duplicate pseudo-header")
  897. st.bodylessReq1(":method", "GET", ":method", "POST")
  898. })
  899. }
  900. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  901. // 8.1.2.3 Request Pseudo-Header Fields
  902. // "All pseudo-header fields MUST appear in the header block
  903. // before regular header fields. Any request or response that
  904. // contains a pseudo-header field that appears in a header
  905. // block after a regular header field MUST be treated as
  906. // malformed (Section 8.1.2.6)."
  907. testRejectRequest(t, func(st *serverTester) {
  908. st.addLogFilter("pseudo-header after regular header")
  909. var buf bytes.Buffer
  910. enc := hpack.NewEncoder(&buf)
  911. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  912. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  913. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  914. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  915. st.writeHeaders(HeadersFrameParam{
  916. StreamID: 1, // clients send odd numbers
  917. BlockFragment: buf.Bytes(),
  918. EndStream: true,
  919. EndHeaders: true,
  920. })
  921. })
  922. }
  923. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  924. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  925. }
  926. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  927. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  928. }
  929. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  930. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  931. }
  932. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  933. testRejectRequest(t, func(st *serverTester) {
  934. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  935. st.bodylessReq1(":unknown_thing", "")
  936. })
  937. }
  938. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  939. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  940. t.Error("server request made it to handler; should've been rejected")
  941. })
  942. defer st.Close()
  943. st.greet()
  944. send(st)
  945. st.wantRSTStream(1, ErrCodeProtocol)
  946. }
  947. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  948. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  949. t.Error("server request made it to handler; should've been rejected")
  950. }, optQuiet)
  951. defer st.Close()
  952. st.greet()
  953. send(st)
  954. gf := st.wantGoAway()
  955. if gf.ErrCode != ErrCodeProtocol {
  956. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  957. }
  958. }
  959. // Section 5.1, on idle connections: "Receiving any frame other than
  960. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  961. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  962. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  963. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  964. st.fr.WriteWindowUpdate(123, 456)
  965. })
  966. }
  967. func TestRejectFrameOnIdle_Data(t *testing.T) {
  968. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  969. st.fr.WriteData(123, true, nil)
  970. })
  971. }
  972. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  973. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  974. st.fr.WriteRSTStream(123, ErrCodeCancel)
  975. })
  976. }
  977. func TestServer_Request_Connect(t *testing.T) {
  978. testServerRequest(t, func(st *serverTester) {
  979. st.writeHeaders(HeadersFrameParam{
  980. StreamID: 1,
  981. BlockFragment: st.encodeHeaderRaw(
  982. ":method", "CONNECT",
  983. ":authority", "example.com:123",
  984. ),
  985. EndStream: true,
  986. EndHeaders: true,
  987. })
  988. }, func(r *http.Request) {
  989. if g, w := r.Method, "CONNECT"; g != w {
  990. t.Errorf("Method = %q; want %q", g, w)
  991. }
  992. if g, w := r.RequestURI, "example.com:123"; g != w {
  993. t.Errorf("RequestURI = %q; want %q", g, w)
  994. }
  995. if g, w := r.URL.Host, "example.com:123"; g != w {
  996. t.Errorf("URL.Host = %q; want %q", g, w)
  997. }
  998. })
  999. }
  1000. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  1001. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1002. st.writeHeaders(HeadersFrameParam{
  1003. StreamID: 1,
  1004. BlockFragment: st.encodeHeaderRaw(
  1005. ":method", "CONNECT",
  1006. ":authority", "example.com:123",
  1007. ":path", "/bogus",
  1008. ),
  1009. EndStream: true,
  1010. EndHeaders: true,
  1011. })
  1012. })
  1013. }
  1014. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  1015. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1016. st.writeHeaders(HeadersFrameParam{
  1017. StreamID: 1,
  1018. BlockFragment: st.encodeHeaderRaw(
  1019. ":method", "CONNECT",
  1020. ":authority", "example.com:123",
  1021. ":scheme", "https",
  1022. ),
  1023. EndStream: true,
  1024. EndHeaders: true,
  1025. })
  1026. })
  1027. }
  1028. func TestServer_Ping(t *testing.T) {
  1029. st := newServerTester(t, nil)
  1030. defer st.Close()
  1031. st.greet()
  1032. // Server should ignore this one, since it has ACK set.
  1033. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  1034. if err := st.fr.WritePing(true, ackPingData); err != nil {
  1035. t.Fatal(err)
  1036. }
  1037. // But the server should reply to this one, since ACK is false.
  1038. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  1039. if err := st.fr.WritePing(false, pingData); err != nil {
  1040. t.Fatal(err)
  1041. }
  1042. pf := st.wantPing()
  1043. if !pf.Flags.Has(FlagPingAck) {
  1044. t.Error("response ping doesn't have ACK set")
  1045. }
  1046. if pf.Data != pingData {
  1047. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  1048. }
  1049. }
  1050. func TestServer_RejectsLargeFrames(t *testing.T) {
  1051. if runtime.GOOS == "windows" {
  1052. t.Skip("see golang.org/issue/13434")
  1053. }
  1054. st := newServerTester(t, nil)
  1055. defer st.Close()
  1056. st.greet()
  1057. // Write too large of a frame (too large by one byte)
  1058. // We ignore the return value because it's expected that the server
  1059. // will only read the first 9 bytes (the headre) and then disconnect.
  1060. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  1061. gf := st.wantGoAway()
  1062. if gf.ErrCode != ErrCodeFrameSize {
  1063. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  1064. }
  1065. if st.serverLogBuf.Len() != 0 {
  1066. // Previously we spun here for a bit until the GOAWAY disconnect
  1067. // timer fired, logging while we fired.
  1068. t.Errorf("unexpected server output: %.500s\n", st.serverLogBuf.Bytes())
  1069. }
  1070. }
  1071. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1072. puppet := newHandlerPuppet()
  1073. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1074. puppet.act(w, r)
  1075. })
  1076. defer st.Close()
  1077. defer puppet.done()
  1078. st.greet()
  1079. st.writeHeaders(HeadersFrameParam{
  1080. StreamID: 1, // clients send odd numbers
  1081. BlockFragment: st.encodeHeader(":method", "POST"),
  1082. EndStream: false, // data coming
  1083. EndHeaders: true,
  1084. })
  1085. st.writeData(1, false, []byte("abcdef"))
  1086. puppet.do(readBodyHandler(t, "abc"))
  1087. st.wantWindowUpdate(0, 3)
  1088. st.wantWindowUpdate(1, 3)
  1089. puppet.do(readBodyHandler(t, "def"))
  1090. st.wantWindowUpdate(0, 3)
  1091. st.wantWindowUpdate(1, 3)
  1092. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1093. puppet.do(readBodyHandler(t, "ghi"))
  1094. puppet.do(readBodyHandler(t, "jkl"))
  1095. st.wantWindowUpdate(0, 3)
  1096. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1097. }
  1098. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1099. // See golang.org/issue/16556
  1100. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1101. puppet := newHandlerPuppet()
  1102. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1103. puppet.act(w, r)
  1104. })
  1105. defer st.Close()
  1106. defer puppet.done()
  1107. st.greet()
  1108. st.writeHeaders(HeadersFrameParam{
  1109. StreamID: 1,
  1110. BlockFragment: st.encodeHeader(":method", "POST"),
  1111. EndStream: false,
  1112. EndHeaders: true,
  1113. })
  1114. st.writeDataPadded(1, false, []byte("abcdef"), []byte{0, 0, 0, 0})
  1115. // Expect to immediately get our 5 bytes of padding back for
  1116. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1117. st.wantWindowUpdate(0, 5)
  1118. st.wantWindowUpdate(1, 5)
  1119. puppet.do(readBodyHandler(t, "abc"))
  1120. st.wantWindowUpdate(0, 3)
  1121. st.wantWindowUpdate(1, 3)
  1122. puppet.do(readBodyHandler(t, "def"))
  1123. st.wantWindowUpdate(0, 3)
  1124. st.wantWindowUpdate(1, 3)
  1125. }
  1126. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1127. st := newServerTester(t, nil)
  1128. defer st.Close()
  1129. st.greet()
  1130. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1131. t.Fatal(err)
  1132. }
  1133. gf := st.wantGoAway()
  1134. if gf.ErrCode != ErrCodeFlowControl {
  1135. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1136. }
  1137. if gf.LastStreamID != 0 {
  1138. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1139. }
  1140. }
  1141. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1142. inHandler := make(chan bool)
  1143. blockHandler := make(chan bool)
  1144. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1145. inHandler <- true
  1146. <-blockHandler
  1147. })
  1148. defer st.Close()
  1149. defer close(blockHandler)
  1150. st.greet()
  1151. st.writeHeaders(HeadersFrameParam{
  1152. StreamID: 1,
  1153. BlockFragment: st.encodeHeader(":method", "POST"),
  1154. EndStream: false, // keep it open
  1155. EndHeaders: true,
  1156. })
  1157. <-inHandler
  1158. // Send a bogus window update:
  1159. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1160. t.Fatal(err)
  1161. }
  1162. st.wantRSTStream(1, ErrCodeFlowControl)
  1163. }
  1164. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1165. // then runs fn once in the handler, and verifies that the error returned from
  1166. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1167. func testServerPostUnblock(t *testing.T,
  1168. handler func(http.ResponseWriter, *http.Request) error,
  1169. fn func(*serverTester),
  1170. checkErr func(error),
  1171. otherHeaders ...string) {
  1172. inHandler := make(chan bool)
  1173. errc := make(chan error, 1)
  1174. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1175. inHandler <- true
  1176. errc <- handler(w, r)
  1177. })
  1178. defer st.Close()
  1179. st.greet()
  1180. st.writeHeaders(HeadersFrameParam{
  1181. StreamID: 1,
  1182. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1183. EndStream: false, // keep it open
  1184. EndHeaders: true,
  1185. })
  1186. <-inHandler
  1187. fn(st)
  1188. select {
  1189. case err := <-errc:
  1190. if checkErr != nil {
  1191. checkErr(err)
  1192. }
  1193. case <-time.After(5 * time.Second):
  1194. t.Fatal("timeout waiting for Handler to return")
  1195. }
  1196. }
  1197. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1198. testServerPostUnblock(t,
  1199. func(w http.ResponseWriter, r *http.Request) (err error) {
  1200. _, err = r.Body.Read(make([]byte, 1))
  1201. return
  1202. },
  1203. func(st *serverTester) {
  1204. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1205. t.Fatal(err)
  1206. }
  1207. },
  1208. func(err error) {
  1209. want := StreamError{StreamID: 0x1, Code: 0x8}
  1210. if !reflect.DeepEqual(err, want) {
  1211. t.Errorf("Read error = %v; want %v", err, want)
  1212. }
  1213. },
  1214. )
  1215. }
  1216. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1217. // Run this test a bunch, because it doesn't always
  1218. // deadlock. But with a bunch, it did.
  1219. n := 50
  1220. if testing.Short() {
  1221. n = 5
  1222. }
  1223. for i := 0; i < n; i++ {
  1224. testServer_RSTStream_Unblocks_Header_Write(t)
  1225. }
  1226. }
  1227. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1228. inHandler := make(chan bool, 1)
  1229. unblockHandler := make(chan bool, 1)
  1230. headerWritten := make(chan bool, 1)
  1231. wroteRST := make(chan bool, 1)
  1232. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1233. inHandler <- true
  1234. <-wroteRST
  1235. w.Header().Set("foo", "bar")
  1236. w.WriteHeader(200)
  1237. w.(http.Flusher).Flush()
  1238. headerWritten <- true
  1239. <-unblockHandler
  1240. })
  1241. defer st.Close()
  1242. st.greet()
  1243. st.writeHeaders(HeadersFrameParam{
  1244. StreamID: 1,
  1245. BlockFragment: st.encodeHeader(":method", "POST"),
  1246. EndStream: false, // keep it open
  1247. EndHeaders: true,
  1248. })
  1249. <-inHandler
  1250. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1251. t.Fatal(err)
  1252. }
  1253. wroteRST <- true
  1254. st.awaitIdle()
  1255. select {
  1256. case <-headerWritten:
  1257. case <-time.After(2 * time.Second):
  1258. t.Error("timeout waiting for header write")
  1259. }
  1260. unblockHandler <- true
  1261. }
  1262. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1263. testServerPostUnblock(t,
  1264. func(w http.ResponseWriter, r *http.Request) (err error) {
  1265. _, err = r.Body.Read(make([]byte, 1))
  1266. return
  1267. },
  1268. func(st *serverTester) { st.cc.Close() },
  1269. func(err error) {
  1270. if err == nil {
  1271. t.Error("unexpected nil error from Request.Body.Read")
  1272. }
  1273. },
  1274. )
  1275. }
  1276. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1277. <-w.(http.CloseNotifier).CloseNotify()
  1278. return nil
  1279. }
  1280. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1281. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1282. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1283. t.Fatal(err)
  1284. }
  1285. }, nil)
  1286. }
  1287. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1288. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1289. }
  1290. // that CloseNotify unblocks after a stream error due to the client's
  1291. // problem that's unrelated to them explicitly canceling it (which is
  1292. // TestServer_CloseNotify_After_RSTStream above)
  1293. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1294. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1295. // data longer than declared Content-Length => stream error
  1296. st.writeData(1, true, []byte("1234"))
  1297. }, nil, "content-length", "3")
  1298. }
  1299. func TestServer_StateTransitions(t *testing.T) {
  1300. var st *serverTester
  1301. inHandler := make(chan bool)
  1302. writeData := make(chan bool)
  1303. leaveHandler := make(chan bool)
  1304. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1305. inHandler <- true
  1306. if st.stream(1) == nil {
  1307. t.Errorf("nil stream 1 in handler")
  1308. }
  1309. if got, want := st.streamState(1), stateOpen; got != want {
  1310. t.Errorf("in handler, state is %v; want %v", got, want)
  1311. }
  1312. writeData <- true
  1313. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1314. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1315. }
  1316. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1317. t.Errorf("in handler, state is %v; want %v", got, want)
  1318. }
  1319. <-leaveHandler
  1320. })
  1321. st.greet()
  1322. if st.stream(1) != nil {
  1323. t.Fatal("stream 1 should be empty")
  1324. }
  1325. if got := st.streamState(1); got != stateIdle {
  1326. t.Fatalf("stream 1 should be idle; got %v", got)
  1327. }
  1328. st.writeHeaders(HeadersFrameParam{
  1329. StreamID: 1,
  1330. BlockFragment: st.encodeHeader(":method", "POST"),
  1331. EndStream: false, // keep it open
  1332. EndHeaders: true,
  1333. })
  1334. <-inHandler
  1335. <-writeData
  1336. st.writeData(1, true, nil)
  1337. leaveHandler <- true
  1338. hf := st.wantHeaders()
  1339. if !hf.StreamEnded() {
  1340. t.Fatal("expected END_STREAM flag")
  1341. }
  1342. if got, want := st.streamState(1), stateClosed; got != want {
  1343. t.Errorf("at end, state is %v; want %v", got, want)
  1344. }
  1345. if st.stream(1) != nil {
  1346. t.Fatal("at end, stream 1 should be gone")
  1347. }
  1348. }
  1349. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1350. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1351. testServerRejectsConn(t, func(st *serverTester) {
  1352. st.writeHeaders(HeadersFrameParam{
  1353. StreamID: 1,
  1354. BlockFragment: st.encodeHeader(),
  1355. EndStream: true,
  1356. EndHeaders: false,
  1357. })
  1358. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1359. StreamID: 3, // different stream.
  1360. BlockFragment: st.encodeHeader(),
  1361. EndStream: true,
  1362. EndHeaders: true,
  1363. })
  1364. })
  1365. }
  1366. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1367. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1368. testServerRejectsConn(t, func(st *serverTester) {
  1369. st.writeHeaders(HeadersFrameParam{
  1370. StreamID: 1,
  1371. BlockFragment: st.encodeHeader(),
  1372. EndStream: true,
  1373. EndHeaders: false,
  1374. })
  1375. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1376. t.Fatal(err)
  1377. }
  1378. })
  1379. }
  1380. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1381. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1382. testServerRejectsConn(t, func(st *serverTester) {
  1383. st.writeHeaders(HeadersFrameParam{
  1384. StreamID: 1,
  1385. BlockFragment: st.encodeHeader(),
  1386. EndStream: true,
  1387. EndHeaders: true,
  1388. })
  1389. st.wantHeaders()
  1390. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1391. t.Fatal(err)
  1392. }
  1393. })
  1394. }
  1395. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1396. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1397. testServerRejectsConn(t, func(st *serverTester) {
  1398. st.writeHeaders(HeadersFrameParam{
  1399. StreamID: 1,
  1400. BlockFragment: st.encodeHeader(),
  1401. EndStream: true,
  1402. EndHeaders: false,
  1403. })
  1404. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1405. t.Fatal(err)
  1406. }
  1407. })
  1408. }
  1409. // No HEADERS on stream 0.
  1410. func TestServer_Rejects_Headers0(t *testing.T) {
  1411. testServerRejectsConn(t, func(st *serverTester) {
  1412. st.fr.AllowIllegalWrites = true
  1413. st.writeHeaders(HeadersFrameParam{
  1414. StreamID: 0,
  1415. BlockFragment: st.encodeHeader(),
  1416. EndStream: true,
  1417. EndHeaders: true,
  1418. })
  1419. })
  1420. }
  1421. // No CONTINUATION on stream 0.
  1422. func TestServer_Rejects_Continuation0(t *testing.T) {
  1423. testServerRejectsConn(t, func(st *serverTester) {
  1424. st.fr.AllowIllegalWrites = true
  1425. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1426. t.Fatal(err)
  1427. }
  1428. })
  1429. }
  1430. // No PRIORITY on stream 0.
  1431. func TestServer_Rejects_Priority0(t *testing.T) {
  1432. testServerRejectsConn(t, func(st *serverTester) {
  1433. st.fr.AllowIllegalWrites = true
  1434. st.writePriority(0, PriorityParam{StreamDep: 1})
  1435. })
  1436. }
  1437. // No HEADERS frame with a self-dependence.
  1438. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1439. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1440. st.fr.AllowIllegalWrites = true
  1441. st.writeHeaders(HeadersFrameParam{
  1442. StreamID: 1,
  1443. BlockFragment: st.encodeHeader(),
  1444. EndStream: true,
  1445. EndHeaders: true,
  1446. Priority: PriorityParam{StreamDep: 1},
  1447. })
  1448. })
  1449. }
  1450. // No PRIORTY frame with a self-dependence.
  1451. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1452. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1453. st.fr.AllowIllegalWrites = true
  1454. st.writePriority(1, PriorityParam{StreamDep: 1})
  1455. })
  1456. }
  1457. func TestServer_Rejects_PushPromise(t *testing.T) {
  1458. testServerRejectsConn(t, func(st *serverTester) {
  1459. pp := PushPromiseParam{
  1460. StreamID: 1,
  1461. PromiseID: 3,
  1462. }
  1463. if err := st.fr.WritePushPromise(pp); err != nil {
  1464. t.Fatal(err)
  1465. }
  1466. })
  1467. }
  1468. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1469. // frame and a server close after the client does something
  1470. // deserving a CONNECTION_ERROR.
  1471. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1472. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1473. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1474. defer st.Close()
  1475. st.greet()
  1476. writeReq(st)
  1477. st.wantGoAway()
  1478. errc := make(chan error, 1)
  1479. go func() {
  1480. fr, err := st.fr.ReadFrame()
  1481. if err == nil {
  1482. err = fmt.Errorf("got frame of type %T", fr)
  1483. }
  1484. errc <- err
  1485. }()
  1486. select {
  1487. case err := <-errc:
  1488. if err != io.EOF {
  1489. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1490. }
  1491. case <-time.After(2 * time.Second):
  1492. t.Error("timeout waiting for disconnect")
  1493. }
  1494. }
  1495. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1496. // error code after a client sends a bogus request.
  1497. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1498. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1499. defer st.Close()
  1500. st.greet()
  1501. writeReq(st)
  1502. st.wantRSTStream(1, code)
  1503. }
  1504. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1505. // write a single request with writeReq, and then verify that the
  1506. // *http.Request is built correctly in checkReq.
  1507. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1508. gotReq := make(chan bool, 1)
  1509. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1510. if r.Body == nil {
  1511. t.Fatal("nil Body")
  1512. }
  1513. checkReq(r)
  1514. gotReq <- true
  1515. })
  1516. defer st.Close()
  1517. st.greet()
  1518. writeReq(st)
  1519. select {
  1520. case <-gotReq:
  1521. case <-time.After(2 * time.Second):
  1522. t.Error("timeout waiting for request")
  1523. }
  1524. }
  1525. func getSlash(st *serverTester) { st.bodylessReq1() }
  1526. func TestServer_Response_NoData(t *testing.T) {
  1527. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1528. // Nothing.
  1529. return nil
  1530. }, func(st *serverTester) {
  1531. getSlash(st)
  1532. hf := st.wantHeaders()
  1533. if !hf.StreamEnded() {
  1534. t.Fatal("want END_STREAM flag")
  1535. }
  1536. if !hf.HeadersEnded() {
  1537. t.Fatal("want END_HEADERS flag")
  1538. }
  1539. })
  1540. }
  1541. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1542. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1543. w.Header().Set("Foo-Bar", "some-value")
  1544. return nil
  1545. }, func(st *serverTester) {
  1546. getSlash(st)
  1547. hf := st.wantHeaders()
  1548. if !hf.StreamEnded() {
  1549. t.Fatal("want END_STREAM flag")
  1550. }
  1551. if !hf.HeadersEnded() {
  1552. t.Fatal("want END_HEADERS flag")
  1553. }
  1554. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1555. wanth := [][2]string{
  1556. {":status", "200"},
  1557. {"foo-bar", "some-value"},
  1558. {"content-length", "0"},
  1559. }
  1560. if !reflect.DeepEqual(goth, wanth) {
  1561. t.Errorf("Got headers %v; want %v", goth, wanth)
  1562. }
  1563. })
  1564. }
  1565. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1566. const msg = "<html>this is HTML."
  1567. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1568. w.Header().Set("Content-Type", "foo/bar")
  1569. io.WriteString(w, msg)
  1570. return nil
  1571. }, func(st *serverTester) {
  1572. getSlash(st)
  1573. hf := st.wantHeaders()
  1574. if hf.StreamEnded() {
  1575. t.Fatal("don't want END_STREAM, expecting data")
  1576. }
  1577. if !hf.HeadersEnded() {
  1578. t.Fatal("want END_HEADERS flag")
  1579. }
  1580. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1581. wanth := [][2]string{
  1582. {":status", "200"},
  1583. {"content-type", "foo/bar"},
  1584. {"content-length", strconv.Itoa(len(msg))},
  1585. }
  1586. if !reflect.DeepEqual(goth, wanth) {
  1587. t.Errorf("Got headers %v; want %v", goth, wanth)
  1588. }
  1589. df := st.wantData()
  1590. if !df.StreamEnded() {
  1591. t.Error("expected DATA to have END_STREAM flag")
  1592. }
  1593. if got := string(df.Data()); got != msg {
  1594. t.Errorf("got DATA %q; want %q", got, msg)
  1595. }
  1596. })
  1597. }
  1598. func TestServer_Response_Nosniff_WithoutContentType(t *testing.T) {
  1599. const msg = "<html>this is HTML."
  1600. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1601. w.Header().Set("X-Content-Type-Options", "nosniff")
  1602. w.WriteHeader(200)
  1603. io.WriteString(w, msg)
  1604. return nil
  1605. }, func(st *serverTester) {
  1606. getSlash(st)
  1607. hf := st.wantHeaders()
  1608. if hf.StreamEnded() {
  1609. t.Fatal("don't want END_STREAM, expecting data")
  1610. }
  1611. if !hf.HeadersEnded() {
  1612. t.Fatal("want END_HEADERS flag")
  1613. }
  1614. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1615. wanth := [][2]string{
  1616. {":status", "200"},
  1617. {"x-content-type-options", "nosniff"},
  1618. {"content-type", "application/octet-stream"},
  1619. {"content-length", strconv.Itoa(len(msg))},
  1620. }
  1621. if !reflect.DeepEqual(goth, wanth) {
  1622. t.Errorf("Got headers %v; want %v", goth, wanth)
  1623. }
  1624. df := st.wantData()
  1625. if !df.StreamEnded() {
  1626. t.Error("expected DATA to have END_STREAM flag")
  1627. }
  1628. if got := string(df.Data()); got != msg {
  1629. t.Errorf("got DATA %q; want %q", got, msg)
  1630. }
  1631. })
  1632. }
  1633. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1634. const msg = "hi"
  1635. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1636. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1637. io.WriteString(w, msg)
  1638. return nil
  1639. }, func(st *serverTester) {
  1640. getSlash(st)
  1641. hf := st.wantHeaders()
  1642. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1643. wanth := [][2]string{
  1644. {":status", "200"},
  1645. {"content-type", "text/plain; charset=utf-8"},
  1646. {"content-length", strconv.Itoa(len(msg))},
  1647. {"x-content-type-options", "nosniff"},
  1648. }
  1649. if !reflect.DeepEqual(goth, wanth) {
  1650. t.Errorf("Got headers %v; want %v", goth, wanth)
  1651. }
  1652. })
  1653. }
  1654. // Header accessed only after the initial write.
  1655. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1656. const msg = "<html>this is HTML."
  1657. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1658. io.WriteString(w, msg)
  1659. w.Header().Set("foo", "should be ignored")
  1660. return nil
  1661. }, func(st *serverTester) {
  1662. getSlash(st)
  1663. hf := st.wantHeaders()
  1664. if hf.StreamEnded() {
  1665. t.Fatal("unexpected END_STREAM")
  1666. }
  1667. if !hf.HeadersEnded() {
  1668. t.Fatal("want END_HEADERS flag")
  1669. }
  1670. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1671. wanth := [][2]string{
  1672. {":status", "200"},
  1673. {"content-type", "text/html; charset=utf-8"},
  1674. {"content-length", strconv.Itoa(len(msg))},
  1675. }
  1676. if !reflect.DeepEqual(goth, wanth) {
  1677. t.Errorf("Got headers %v; want %v", goth, wanth)
  1678. }
  1679. })
  1680. }
  1681. // Header accessed before the initial write and later mutated.
  1682. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1683. const msg = "<html>this is HTML."
  1684. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1685. w.Header().Set("foo", "proper value")
  1686. io.WriteString(w, msg)
  1687. w.Header().Set("foo", "should be ignored")
  1688. return nil
  1689. }, func(st *serverTester) {
  1690. getSlash(st)
  1691. hf := st.wantHeaders()
  1692. if hf.StreamEnded() {
  1693. t.Fatal("unexpected END_STREAM")
  1694. }
  1695. if !hf.HeadersEnded() {
  1696. t.Fatal("want END_HEADERS flag")
  1697. }
  1698. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1699. wanth := [][2]string{
  1700. {":status", "200"},
  1701. {"foo", "proper value"},
  1702. {"content-type", "text/html; charset=utf-8"},
  1703. {"content-length", strconv.Itoa(len(msg))},
  1704. }
  1705. if !reflect.DeepEqual(goth, wanth) {
  1706. t.Errorf("Got headers %v; want %v", goth, wanth)
  1707. }
  1708. })
  1709. }
  1710. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1711. const msg = "<html>this is HTML."
  1712. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1713. io.WriteString(w, msg)
  1714. return nil
  1715. }, func(st *serverTester) {
  1716. getSlash(st)
  1717. hf := st.wantHeaders()
  1718. if hf.StreamEnded() {
  1719. t.Fatal("don't want END_STREAM, expecting data")
  1720. }
  1721. if !hf.HeadersEnded() {
  1722. t.Fatal("want END_HEADERS flag")
  1723. }
  1724. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1725. wanth := [][2]string{
  1726. {":status", "200"},
  1727. {"content-type", "text/html; charset=utf-8"},
  1728. {"content-length", strconv.Itoa(len(msg))},
  1729. }
  1730. if !reflect.DeepEqual(goth, wanth) {
  1731. t.Errorf("Got headers %v; want %v", goth, wanth)
  1732. }
  1733. df := st.wantData()
  1734. if !df.StreamEnded() {
  1735. t.Error("expected DATA to have END_STREAM flag")
  1736. }
  1737. if got := string(df.Data()); got != msg {
  1738. t.Errorf("got DATA %q; want %q", got, msg)
  1739. }
  1740. })
  1741. }
  1742. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1743. const msg = "<html>this is HTML"
  1744. const msg2 = ", and this is the next chunk"
  1745. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1746. io.WriteString(w, msg)
  1747. w.(http.Flusher).Flush()
  1748. io.WriteString(w, msg2)
  1749. return nil
  1750. }, func(st *serverTester) {
  1751. getSlash(st)
  1752. hf := st.wantHeaders()
  1753. if hf.StreamEnded() {
  1754. t.Fatal("unexpected END_STREAM flag")
  1755. }
  1756. if !hf.HeadersEnded() {
  1757. t.Fatal("want END_HEADERS flag")
  1758. }
  1759. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1760. wanth := [][2]string{
  1761. {":status", "200"},
  1762. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1763. // and no content-length
  1764. }
  1765. if !reflect.DeepEqual(goth, wanth) {
  1766. t.Errorf("Got headers %v; want %v", goth, wanth)
  1767. }
  1768. {
  1769. df := st.wantData()
  1770. if df.StreamEnded() {
  1771. t.Error("unexpected END_STREAM flag")
  1772. }
  1773. if got := string(df.Data()); got != msg {
  1774. t.Errorf("got DATA %q; want %q", got, msg)
  1775. }
  1776. }
  1777. {
  1778. df := st.wantData()
  1779. if !df.StreamEnded() {
  1780. t.Error("wanted END_STREAM flag on last data chunk")
  1781. }
  1782. if got := string(df.Data()); got != msg2 {
  1783. t.Errorf("got DATA %q; want %q", got, msg2)
  1784. }
  1785. }
  1786. })
  1787. }
  1788. func TestServer_Response_LargeWrite(t *testing.T) {
  1789. const size = 1 << 20
  1790. const maxFrameSize = 16 << 10
  1791. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1792. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1793. if err != nil {
  1794. return fmt.Errorf("Write error: %v", err)
  1795. }
  1796. if n != size {
  1797. return fmt.Errorf("wrong size %d from Write", n)
  1798. }
  1799. return nil
  1800. }, func(st *serverTester) {
  1801. if err := st.fr.WriteSettings(
  1802. Setting{SettingInitialWindowSize, 0},
  1803. Setting{SettingMaxFrameSize, maxFrameSize},
  1804. ); err != nil {
  1805. t.Fatal(err)
  1806. }
  1807. st.wantSettingsAck()
  1808. getSlash(st) // make the single request
  1809. // Give the handler quota to write:
  1810. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1811. t.Fatal(err)
  1812. }
  1813. // Give the handler quota to write to connection-level
  1814. // window as well
  1815. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1816. t.Fatal(err)
  1817. }
  1818. hf := st.wantHeaders()
  1819. if hf.StreamEnded() {
  1820. t.Fatal("unexpected END_STREAM flag")
  1821. }
  1822. if !hf.HeadersEnded() {
  1823. t.Fatal("want END_HEADERS flag")
  1824. }
  1825. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1826. wanth := [][2]string{
  1827. {":status", "200"},
  1828. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1829. {"x-content-type-options", "nosniff"},
  1830. // and no content-length
  1831. }
  1832. if !reflect.DeepEqual(goth, wanth) {
  1833. t.Errorf("Got headers %v; want %v", goth, wanth)
  1834. }
  1835. var bytes, frames int
  1836. for {
  1837. df := st.wantData()
  1838. bytes += len(df.Data())
  1839. frames++
  1840. for _, b := range df.Data() {
  1841. if b != 'a' {
  1842. t.Fatal("non-'a' byte seen in DATA")
  1843. }
  1844. }
  1845. if df.StreamEnded() {
  1846. break
  1847. }
  1848. }
  1849. if bytes != size {
  1850. t.Errorf("Got %d bytes; want %d", bytes, size)
  1851. }
  1852. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1853. t.Errorf("Got %d frames; want %d", frames, size)
  1854. }
  1855. })
  1856. }
  1857. // Test that the handler can't write more than the client allows
  1858. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1859. // Make these reads. Before each read, the client adds exactly enough
  1860. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1861. reads := []int{123, 1, 13, 127}
  1862. size := 0
  1863. for _, n := range reads {
  1864. size += n
  1865. }
  1866. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1867. w.(http.Flusher).Flush()
  1868. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1869. if err != nil {
  1870. return fmt.Errorf("Write error: %v", err)
  1871. }
  1872. if n != size {
  1873. return fmt.Errorf("wrong size %d from Write", n)
  1874. }
  1875. return nil
  1876. }, func(st *serverTester) {
  1877. // Set the window size to something explicit for this test.
  1878. // It's also how much initial data we expect.
  1879. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1880. t.Fatal(err)
  1881. }
  1882. st.wantSettingsAck()
  1883. getSlash(st) // make the single request
  1884. hf := st.wantHeaders()
  1885. if hf.StreamEnded() {
  1886. t.Fatal("unexpected END_STREAM flag")
  1887. }
  1888. if !hf.HeadersEnded() {
  1889. t.Fatal("want END_HEADERS flag")
  1890. }
  1891. df := st.wantData()
  1892. if got := len(df.Data()); got != reads[0] {
  1893. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1894. }
  1895. for _, quota := range reads[1:] {
  1896. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1897. t.Fatal(err)
  1898. }
  1899. df := st.wantData()
  1900. if int(quota) != len(df.Data()) {
  1901. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1902. }
  1903. }
  1904. })
  1905. }
  1906. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1907. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1908. const size = 1 << 20
  1909. const maxFrameSize = 16 << 10
  1910. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1911. w.(http.Flusher).Flush()
  1912. errc := make(chan error, 1)
  1913. go func() {
  1914. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1915. errc <- err
  1916. }()
  1917. select {
  1918. case err := <-errc:
  1919. if err == nil {
  1920. return errors.New("unexpected nil error from Write in handler")
  1921. }
  1922. return nil
  1923. case <-time.After(2 * time.Second):
  1924. return errors.New("timeout waiting for Write in handler")
  1925. }
  1926. }, func(st *serverTester) {
  1927. if err := st.fr.WriteSettings(
  1928. Setting{SettingInitialWindowSize, 0},
  1929. Setting{SettingMaxFrameSize, maxFrameSize},
  1930. ); err != nil {
  1931. t.Fatal(err)
  1932. }
  1933. st.wantSettingsAck()
  1934. getSlash(st) // make the single request
  1935. hf := st.wantHeaders()
  1936. if hf.StreamEnded() {
  1937. t.Fatal("unexpected END_STREAM flag")
  1938. }
  1939. if !hf.HeadersEnded() {
  1940. t.Fatal("want END_HEADERS flag")
  1941. }
  1942. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1943. t.Fatal(err)
  1944. }
  1945. })
  1946. }
  1947. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1948. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1949. w.(http.Flusher).Flush()
  1950. // Nothing; send empty DATA
  1951. return nil
  1952. }, func(st *serverTester) {
  1953. // Handler gets no data quota:
  1954. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1955. t.Fatal(err)
  1956. }
  1957. st.wantSettingsAck()
  1958. getSlash(st) // make the single request
  1959. hf := st.wantHeaders()
  1960. if hf.StreamEnded() {
  1961. t.Fatal("unexpected END_STREAM flag")
  1962. }
  1963. if !hf.HeadersEnded() {
  1964. t.Fatal("want END_HEADERS flag")
  1965. }
  1966. df := st.wantData()
  1967. if got := len(df.Data()); got != 0 {
  1968. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1969. }
  1970. if !df.StreamEnded() {
  1971. t.Fatal("DATA didn't have END_STREAM")
  1972. }
  1973. })
  1974. }
  1975. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1976. const msg = "foo"
  1977. const reply = "bar"
  1978. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1979. if v := r.Header.Get("Expect"); v != "" {
  1980. t.Errorf("Expect header = %q; want empty", v)
  1981. }
  1982. buf := make([]byte, len(msg))
  1983. // This read should trigger the 100-continue being sent.
  1984. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1985. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1986. }
  1987. _, err := io.WriteString(w, reply)
  1988. return err
  1989. }, func(st *serverTester) {
  1990. st.writeHeaders(HeadersFrameParam{
  1991. StreamID: 1, // clients send odd numbers
  1992. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1993. EndStream: false,
  1994. EndHeaders: true,
  1995. })
  1996. hf := st.wantHeaders()
  1997. if hf.StreamEnded() {
  1998. t.Fatal("unexpected END_STREAM flag")
  1999. }
  2000. if !hf.HeadersEnded() {
  2001. t.Fatal("want END_HEADERS flag")
  2002. }
  2003. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2004. wanth := [][2]string{
  2005. {":status", "100"},
  2006. }
  2007. if !reflect.DeepEqual(goth, wanth) {
  2008. t.Fatalf("Got headers %v; want %v", goth, wanth)
  2009. }
  2010. // Okay, they sent status 100, so we can send our
  2011. // gigantic and/or sensitive "foo" payload now.
  2012. st.writeData(1, true, []byte(msg))
  2013. st.wantWindowUpdate(0, uint32(len(msg)))
  2014. hf = st.wantHeaders()
  2015. if hf.StreamEnded() {
  2016. t.Fatal("expected data to follow")
  2017. }
  2018. if !hf.HeadersEnded() {
  2019. t.Fatal("want END_HEADERS flag")
  2020. }
  2021. goth = st.decodeHeader(hf.HeaderBlockFragment())
  2022. wanth = [][2]string{
  2023. {":status", "200"},
  2024. {"content-type", "text/plain; charset=utf-8"},
  2025. {"content-length", strconv.Itoa(len(reply))},
  2026. {"x-content-type-options", "nosniff"},
  2027. }
  2028. if !reflect.DeepEqual(goth, wanth) {
  2029. t.Errorf("Got headers %v; want %v", goth, wanth)
  2030. }
  2031. df := st.wantData()
  2032. if string(df.Data()) != reply {
  2033. t.Errorf("Client read %q; want %q", df.Data(), reply)
  2034. }
  2035. if !df.StreamEnded() {
  2036. t.Errorf("expect data stream end")
  2037. }
  2038. })
  2039. }
  2040. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  2041. errc := make(chan error, 1)
  2042. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2043. p := []byte("some data.\n")
  2044. for {
  2045. _, err := w.Write(p)
  2046. if err != nil {
  2047. errc <- err
  2048. return nil
  2049. }
  2050. }
  2051. }, func(st *serverTester) {
  2052. st.writeHeaders(HeadersFrameParam{
  2053. StreamID: 1,
  2054. BlockFragment: st.encodeHeader(),
  2055. EndStream: false,
  2056. EndHeaders: true,
  2057. })
  2058. hf := st.wantHeaders()
  2059. if hf.StreamEnded() {
  2060. t.Fatal("unexpected END_STREAM flag")
  2061. }
  2062. if !hf.HeadersEnded() {
  2063. t.Fatal("want END_HEADERS flag")
  2064. }
  2065. // Close the connection and wait for the handler to (hopefully) notice.
  2066. st.cc.Close()
  2067. select {
  2068. case <-errc:
  2069. case <-time.After(5 * time.Second):
  2070. t.Error("timeout")
  2071. }
  2072. })
  2073. }
  2074. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  2075. const testPath = "/some/path"
  2076. inHandler := make(chan uint32)
  2077. leaveHandler := make(chan bool)
  2078. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2079. id := w.(*responseWriter).rws.stream.id
  2080. inHandler <- id
  2081. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  2082. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  2083. }
  2084. <-leaveHandler
  2085. })
  2086. defer st.Close()
  2087. st.greet()
  2088. nextStreamID := uint32(1)
  2089. streamID := func() uint32 {
  2090. defer func() { nextStreamID += 2 }()
  2091. return nextStreamID
  2092. }
  2093. sendReq := func(id uint32, headers ...string) {
  2094. st.writeHeaders(HeadersFrameParam{
  2095. StreamID: id,
  2096. BlockFragment: st.encodeHeader(headers...),
  2097. EndStream: true,
  2098. EndHeaders: true,
  2099. })
  2100. }
  2101. for i := 0; i < defaultMaxStreams; i++ {
  2102. sendReq(streamID())
  2103. <-inHandler
  2104. }
  2105. defer func() {
  2106. for i := 0; i < defaultMaxStreams; i++ {
  2107. leaveHandler <- true
  2108. }
  2109. }()
  2110. // And this one should cross the limit:
  2111. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2112. // even if we're rejecting it)
  2113. rejectID := streamID()
  2114. headerBlock := st.encodeHeader(":path", testPath)
  2115. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2116. st.writeHeaders(HeadersFrameParam{
  2117. StreamID: rejectID,
  2118. BlockFragment: frag1,
  2119. EndStream: true,
  2120. EndHeaders: false, // CONTINUATION coming
  2121. })
  2122. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2123. t.Fatal(err)
  2124. }
  2125. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2126. // But let a handler finish:
  2127. leaveHandler <- true
  2128. st.wantHeaders()
  2129. // And now another stream should be able to start:
  2130. goodID := streamID()
  2131. sendReq(goodID, ":path", testPath)
  2132. select {
  2133. case got := <-inHandler:
  2134. if got != goodID {
  2135. t.Errorf("Got stream %d; want %d", got, goodID)
  2136. }
  2137. case <-time.After(3 * time.Second):
  2138. t.Error("timeout waiting for handler")
  2139. }
  2140. }
  2141. // So many response headers that the server needs to use CONTINUATION frames:
  2142. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2143. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2144. h := w.Header()
  2145. for i := 0; i < 5000; i++ {
  2146. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2147. }
  2148. return nil
  2149. }, func(st *serverTester) {
  2150. getSlash(st)
  2151. hf := st.wantHeaders()
  2152. if hf.HeadersEnded() {
  2153. t.Fatal("got unwanted END_HEADERS flag")
  2154. }
  2155. n := 0
  2156. for {
  2157. n++
  2158. cf := st.wantContinuation()
  2159. if cf.HeadersEnded() {
  2160. break
  2161. }
  2162. }
  2163. if n < 5 {
  2164. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2165. }
  2166. })
  2167. }
  2168. // This previously crashed (reported by Mathieu Lonjaret as observed
  2169. // while using Camlistore) because we got a DATA frame from the client
  2170. // after the handler exited and our logic at the time was wrong,
  2171. // keeping a stream in the map in stateClosed, which tickled an
  2172. // invariant check later when we tried to remove that stream (via
  2173. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2174. // ended.
  2175. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2176. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2177. // nothing
  2178. return nil
  2179. }, func(st *serverTester) {
  2180. st.writeHeaders(HeadersFrameParam{
  2181. StreamID: 1,
  2182. BlockFragment: st.encodeHeader(),
  2183. EndStream: false, // DATA is coming
  2184. EndHeaders: true,
  2185. })
  2186. hf := st.wantHeaders()
  2187. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2188. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2189. }
  2190. // Sent when the a Handler closes while a client has
  2191. // indicated it's still sending DATA:
  2192. st.wantRSTStream(1, ErrCodeNo)
  2193. // Now the handler has ended, so it's ended its
  2194. // stream, but the client hasn't closed its side
  2195. // (stateClosedLocal). So send more data and verify
  2196. // it doesn't crash with an internal invariant panic, like
  2197. // it did before.
  2198. st.writeData(1, true, []byte("foo"))
  2199. // Get our flow control bytes back, since the handler didn't get them.
  2200. st.wantWindowUpdate(0, uint32(len("foo")))
  2201. // Sent after a peer sends data anyway (admittedly the
  2202. // previous RST_STREAM might've still been in-flight),
  2203. // but they'll get the more friendly 'cancel' code
  2204. // first.
  2205. st.wantRSTStream(1, ErrCodeStreamClosed)
  2206. // Set up a bunch of machinery to record the panic we saw
  2207. // previously.
  2208. var (
  2209. panMu sync.Mutex
  2210. panicVal interface{}
  2211. )
  2212. testHookOnPanicMu.Lock()
  2213. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2214. panMu.Lock()
  2215. panicVal = pv
  2216. panMu.Unlock()
  2217. return true
  2218. }
  2219. testHookOnPanicMu.Unlock()
  2220. // Now force the serve loop to end, via closing the connection.
  2221. st.cc.Close()
  2222. select {
  2223. case <-st.sc.doneServing:
  2224. // Loop has exited.
  2225. panMu.Lock()
  2226. got := panicVal
  2227. panMu.Unlock()
  2228. if got != nil {
  2229. t.Errorf("Got panic: %v", got)
  2230. }
  2231. case <-time.After(5 * time.Second):
  2232. t.Error("timeout")
  2233. }
  2234. })
  2235. }
  2236. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2237. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2238. func testRejectTLS(t *testing.T, max uint16) {
  2239. st := newServerTester(t, nil, func(c *tls.Config) {
  2240. c.MaxVersion = max
  2241. })
  2242. defer st.Close()
  2243. gf := st.wantGoAway()
  2244. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2245. t.Errorf("Got error code %v; want %v", got, want)
  2246. }
  2247. }
  2248. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2249. st := newServerTester(t, nil, func(c *tls.Config) {
  2250. // Only list bad ones:
  2251. c.CipherSuites = []uint16{
  2252. tls.TLS_RSA_WITH_RC4_128_SHA,
  2253. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2254. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2255. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2256. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2257. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2258. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2259. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2260. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2261. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2262. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2263. cipher_TLS_RSA_WITH_AES_128_CBC_SHA256,
  2264. }
  2265. })
  2266. defer st.Close()
  2267. gf := st.wantGoAway()
  2268. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2269. t.Errorf("Got error code %v; want %v", got, want)
  2270. }
  2271. }
  2272. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2273. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2274. st := newServerTester(t, nil, func(c *tls.Config) {
  2275. // Have the client only support the one required by the spec.
  2276. c.CipherSuites = []uint16{requiredSuite}
  2277. }, func(ts *httptest.Server) {
  2278. var srv *http.Server = ts.Config
  2279. // Have the server configured with no specific cipher suites.
  2280. // This tests that Go's defaults include the required one.
  2281. srv.TLSConfig = nil
  2282. })
  2283. defer st.Close()
  2284. st.greet()
  2285. }
  2286. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2287. if f.Name == "date" {
  2288. return
  2289. }
  2290. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2291. }
  2292. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2293. st.decodedHeaders = nil
  2294. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2295. st.t.Fatalf("hpack decoding error: %v", err)
  2296. }
  2297. if err := st.hpackDec.Close(); err != nil {
  2298. st.t.Fatalf("hpack decoding error: %v", err)
  2299. }
  2300. return st.decodedHeaders
  2301. }
  2302. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2303. // write a single request that must be handled by the handler. This waits up to 5s
  2304. // for client to return, then up to an additional 2s for the handler to return.
  2305. func testServerResponse(t testing.TB,
  2306. handler func(http.ResponseWriter, *http.Request) error,
  2307. client func(*serverTester),
  2308. ) {
  2309. errc := make(chan error, 1)
  2310. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2311. if r.Body == nil {
  2312. t.Fatal("nil Body")
  2313. }
  2314. errc <- handler(w, r)
  2315. })
  2316. defer st.Close()
  2317. donec := make(chan bool)
  2318. go func() {
  2319. defer close(donec)
  2320. st.greet()
  2321. client(st)
  2322. }()
  2323. select {
  2324. case <-donec:
  2325. case <-time.After(5 * time.Second):
  2326. t.Fatal("timeout in client")
  2327. }
  2328. select {
  2329. case err := <-errc:
  2330. if err != nil {
  2331. t.Fatalf("Error in handler: %v", err)
  2332. }
  2333. case <-time.After(2 * time.Second):
  2334. t.Fatal("timeout in handler")
  2335. }
  2336. }
  2337. // readBodyHandler returns an http Handler func that reads len(want)
  2338. // bytes from r.Body and fails t if the contents read were not
  2339. // the value of want.
  2340. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2341. return func(w http.ResponseWriter, r *http.Request) {
  2342. buf := make([]byte, len(want))
  2343. _, err := io.ReadFull(r.Body, buf)
  2344. if err != nil {
  2345. t.Error(err)
  2346. return
  2347. }
  2348. if string(buf) != want {
  2349. t.Errorf("read %q; want %q", buf, want)
  2350. }
  2351. }
  2352. }
  2353. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2354. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2355. // http://sourceforge.net/p/curl/bugs/1472/
  2356. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2357. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2358. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2359. if runtime.GOOS != "linux" {
  2360. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2361. }
  2362. if testing.Short() {
  2363. t.Skip("skipping curl test in short mode")
  2364. }
  2365. requireCurl(t)
  2366. var gotConn int32
  2367. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2368. const msg = "Hello from curl!\n"
  2369. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2370. w.Header().Set("Foo", "Bar")
  2371. w.Header().Set("Client-Proto", r.Proto)
  2372. io.WriteString(w, msg)
  2373. }))
  2374. ConfigureServer(ts.Config, &Server{
  2375. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2376. })
  2377. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2378. ts.StartTLS()
  2379. defer ts.Close()
  2380. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2381. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2382. defer kill(container)
  2383. resc := make(chan interface{}, 1)
  2384. go func() {
  2385. res, err := dockerLogs(container)
  2386. if err != nil {
  2387. resc <- err
  2388. } else {
  2389. resc <- res
  2390. }
  2391. }()
  2392. select {
  2393. case res := <-resc:
  2394. if err, ok := res.(error); ok {
  2395. t.Fatal(err)
  2396. }
  2397. body := string(res.([]byte))
  2398. // Search for both "key: value" and "key:value", since curl changed their format
  2399. // Our Dockerfile contains the latest version (no space), but just in case people
  2400. // didn't rebuild, check both.
  2401. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2402. t.Errorf("didn't see foo: Bar header")
  2403. t.Logf("Got: %s", body)
  2404. }
  2405. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2406. t.Errorf("didn't see client-proto: HTTP/2 header")
  2407. t.Logf("Got: %s", res)
  2408. }
  2409. if !strings.Contains(string(res.([]byte)), msg) {
  2410. t.Errorf("didn't see %q content", msg)
  2411. t.Logf("Got: %s", res)
  2412. }
  2413. case <-time.After(3 * time.Second):
  2414. t.Errorf("timeout waiting for curl")
  2415. }
  2416. if atomic.LoadInt32(&gotConn) == 0 {
  2417. t.Error("never saw an http2 connection")
  2418. }
  2419. }
  2420. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2421. func TestServerWithH2Load(t *testing.T) {
  2422. if !*doh2load {
  2423. t.Skip("Skipping without --h2load flag.")
  2424. }
  2425. if runtime.GOOS != "linux" {
  2426. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2427. }
  2428. requireH2load(t)
  2429. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2430. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2431. io.WriteString(w, msg)
  2432. w.(http.Flusher).Flush()
  2433. io.WriteString(w, msg)
  2434. }))
  2435. ts.StartTLS()
  2436. defer ts.Close()
  2437. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2438. "-n100000", "-c100", "-m100", ts.URL)
  2439. cmd.Stdout = os.Stdout
  2440. cmd.Stderr = os.Stderr
  2441. if err := cmd.Run(); err != nil {
  2442. t.Fatal(err)
  2443. }
  2444. }
  2445. // Issue 12843
  2446. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2447. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2448. defer st.Close()
  2449. // shake hands
  2450. frameSize := defaultMaxReadFrameSize
  2451. var advHeaderListSize *uint32
  2452. st.greetAndCheckSettings(func(s Setting) error {
  2453. switch s.ID {
  2454. case SettingMaxFrameSize:
  2455. if s.Val < minMaxFrameSize {
  2456. frameSize = minMaxFrameSize
  2457. } else if s.Val > maxFrameSize {
  2458. frameSize = maxFrameSize
  2459. } else {
  2460. frameSize = int(s.Val)
  2461. }
  2462. case SettingMaxHeaderListSize:
  2463. advHeaderListSize = &s.Val
  2464. }
  2465. return nil
  2466. })
  2467. if advHeaderListSize == nil {
  2468. t.Errorf("server didn't advertise a max header list size")
  2469. } else if *advHeaderListSize == 0 {
  2470. t.Errorf("server advertised a max header list size of 0")
  2471. }
  2472. st.encodeHeaderField(":method", "GET")
  2473. st.encodeHeaderField(":path", "/")
  2474. st.encodeHeaderField(":scheme", "https")
  2475. cookie := strings.Repeat("*", 4058)
  2476. st.encodeHeaderField("cookie", cookie)
  2477. st.writeHeaders(HeadersFrameParam{
  2478. StreamID: 1,
  2479. BlockFragment: st.headerBuf.Bytes(),
  2480. EndStream: true,
  2481. EndHeaders: false,
  2482. })
  2483. // Capture the short encoding of a duplicate ~4K cookie, now
  2484. // that we've already sent it once.
  2485. st.headerBuf.Reset()
  2486. st.encodeHeaderField("cookie", cookie)
  2487. // Now send 1MB of it.
  2488. const size = 1 << 20
  2489. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2490. for len(b) > 0 {
  2491. chunk := b
  2492. if len(chunk) > frameSize {
  2493. chunk = chunk[:frameSize]
  2494. }
  2495. b = b[len(chunk):]
  2496. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2497. }
  2498. h := st.wantHeaders()
  2499. if !h.HeadersEnded() {
  2500. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2501. }
  2502. headers := st.decodeHeader(h.HeaderBlockFragment())
  2503. want := [][2]string{
  2504. {":status", "431"},
  2505. {"content-type", "text/html; charset=utf-8"},
  2506. {"content-length", "63"},
  2507. }
  2508. if !reflect.DeepEqual(headers, want) {
  2509. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2510. }
  2511. }
  2512. func TestCompressionErrorOnWrite(t *testing.T) {
  2513. const maxStrLen = 8 << 10
  2514. var serverConfig *http.Server
  2515. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2516. // No response body.
  2517. }, func(ts *httptest.Server) {
  2518. serverConfig = ts.Config
  2519. serverConfig.MaxHeaderBytes = maxStrLen
  2520. })
  2521. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2522. defer st.Close()
  2523. st.greet()
  2524. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2525. // Crank this up, now that we have a conn connected with the
  2526. // hpack.Decoder's max string length set has been initialized
  2527. // from the earlier low ~8K value. We want this higher so don't
  2528. // hit the max header list size. We only want to test hitting
  2529. // the max string size.
  2530. serverConfig.MaxHeaderBytes = 1 << 20
  2531. // First a request with a header that's exactly the max allowed size
  2532. // for the hpack compression. It's still too long for the header list
  2533. // size, so we'll get the 431 error, but that keeps the compression
  2534. // context still valid.
  2535. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2536. st.writeHeaders(HeadersFrameParam{
  2537. StreamID: 1,
  2538. BlockFragment: hbf,
  2539. EndStream: true,
  2540. EndHeaders: true,
  2541. })
  2542. h := st.wantHeaders()
  2543. if !h.HeadersEnded() {
  2544. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2545. }
  2546. headers := st.decodeHeader(h.HeaderBlockFragment())
  2547. want := [][2]string{
  2548. {":status", "431"},
  2549. {"content-type", "text/html; charset=utf-8"},
  2550. {"content-length", "63"},
  2551. }
  2552. if !reflect.DeepEqual(headers, want) {
  2553. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2554. }
  2555. df := st.wantData()
  2556. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2557. t.Errorf("Unexpected data body: %q", df.Data())
  2558. }
  2559. if !df.StreamEnded() {
  2560. t.Fatalf("expect data stream end")
  2561. }
  2562. // And now send one that's just one byte too big.
  2563. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2564. st.writeHeaders(HeadersFrameParam{
  2565. StreamID: 3,
  2566. BlockFragment: hbf,
  2567. EndStream: true,
  2568. EndHeaders: true,
  2569. })
  2570. ga := st.wantGoAway()
  2571. if ga.ErrCode != ErrCodeCompression {
  2572. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2573. }
  2574. }
  2575. func TestCompressionErrorOnClose(t *testing.T) {
  2576. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2577. // No response body.
  2578. })
  2579. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2580. defer st.Close()
  2581. st.greet()
  2582. hbf := st.encodeHeader("foo", "bar")
  2583. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2584. st.writeHeaders(HeadersFrameParam{
  2585. StreamID: 1,
  2586. BlockFragment: hbf,
  2587. EndStream: true,
  2588. EndHeaders: true,
  2589. })
  2590. ga := st.wantGoAway()
  2591. if ga.ErrCode != ErrCodeCompression {
  2592. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2593. }
  2594. }
  2595. // test that a server handler can read trailers from a client
  2596. func TestServerReadsTrailers(t *testing.T) {
  2597. const testBody = "some test body"
  2598. writeReq := func(st *serverTester) {
  2599. st.writeHeaders(HeadersFrameParam{
  2600. StreamID: 1, // clients send odd numbers
  2601. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2602. EndStream: false,
  2603. EndHeaders: true,
  2604. })
  2605. st.writeData(1, false, []byte(testBody))
  2606. st.writeHeaders(HeadersFrameParam{
  2607. StreamID: 1, // clients send odd numbers
  2608. BlockFragment: st.encodeHeaderRaw(
  2609. "foo", "foov",
  2610. "bar", "barv",
  2611. "baz", "bazv",
  2612. "surprise", "wasn't declared; shouldn't show up",
  2613. ),
  2614. EndStream: true,
  2615. EndHeaders: true,
  2616. })
  2617. }
  2618. checkReq := func(r *http.Request) {
  2619. wantTrailer := http.Header{
  2620. "Foo": nil,
  2621. "Bar": nil,
  2622. "Baz": nil,
  2623. }
  2624. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2625. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2626. }
  2627. slurp, err := ioutil.ReadAll(r.Body)
  2628. if string(slurp) != testBody {
  2629. t.Errorf("read body %q; want %q", slurp, testBody)
  2630. }
  2631. if err != nil {
  2632. t.Fatalf("Body slurp: %v", err)
  2633. }
  2634. wantTrailerAfter := http.Header{
  2635. "Foo": {"foov"},
  2636. "Bar": {"barv"},
  2637. "Baz": {"bazv"},
  2638. }
  2639. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2640. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2641. }
  2642. }
  2643. testServerRequest(t, writeReq, checkReq)
  2644. }
  2645. // test that a server handler can send trailers
  2646. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2647. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2648. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2649. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2650. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2651. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2652. w.Header().Add("Trailer", "Server-Trailer-C")
  2653. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2654. // Regular headers:
  2655. w.Header().Set("Foo", "Bar")
  2656. w.Header().Set("Content-Length", "5") // len("Hello")
  2657. io.WriteString(w, "Hello")
  2658. if withFlush {
  2659. w.(http.Flusher).Flush()
  2660. }
  2661. w.Header().Set("Server-Trailer-A", "valuea")
  2662. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2663. // After a flush, random keys like Server-Surprise shouldn't show up:
  2664. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2665. // But we do permit promoting keys to trailers after a
  2666. // flush if they start with the magic
  2667. // otherwise-invalid "Trailer:" prefix:
  2668. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2669. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2670. w.Header().Set("Trailer:Range", "invalid")
  2671. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2672. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 7230 4.1.2")
  2673. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 7230 4.1.2")
  2674. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 7230 4.1.2")
  2675. return nil
  2676. }, func(st *serverTester) {
  2677. getSlash(st)
  2678. hf := st.wantHeaders()
  2679. if hf.StreamEnded() {
  2680. t.Fatal("response HEADERS had END_STREAM")
  2681. }
  2682. if !hf.HeadersEnded() {
  2683. t.Fatal("response HEADERS didn't have END_HEADERS")
  2684. }
  2685. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2686. wanth := [][2]string{
  2687. {":status", "200"},
  2688. {"foo", "Bar"},
  2689. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2690. {"trailer", "Server-Trailer-C"},
  2691. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2692. {"content-type", "text/plain; charset=utf-8"},
  2693. {"content-length", "5"},
  2694. {"x-content-type-options", "nosniff"},
  2695. }
  2696. if !reflect.DeepEqual(goth, wanth) {
  2697. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2698. }
  2699. df := st.wantData()
  2700. if string(df.Data()) != "Hello" {
  2701. t.Fatalf("Client read %q; want Hello", df.Data())
  2702. }
  2703. if df.StreamEnded() {
  2704. t.Fatalf("data frame had STREAM_ENDED")
  2705. }
  2706. tf := st.wantHeaders() // for the trailers
  2707. if !tf.StreamEnded() {
  2708. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2709. }
  2710. if !tf.HeadersEnded() {
  2711. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2712. }
  2713. wanth = [][2]string{
  2714. {"post-header-trailer", "hi1"},
  2715. {"post-header-trailer2", "hi2"},
  2716. {"server-trailer-a", "valuea"},
  2717. {"server-trailer-c", "valuec"},
  2718. }
  2719. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2720. if !reflect.DeepEqual(goth, wanth) {
  2721. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2722. }
  2723. })
  2724. }
  2725. // validate transmitted header field names & values
  2726. // golang.org/issue/14048
  2727. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2728. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2729. w.Header().Add("OK1", "x")
  2730. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2731. w.Header().Add("Bad1\x00", "x") // null in key
  2732. w.Header().Add("Bad2", "x\x00y") // null in value
  2733. return nil
  2734. }, func(st *serverTester) {
  2735. getSlash(st)
  2736. hf := st.wantHeaders()
  2737. if !hf.StreamEnded() {
  2738. t.Error("response HEADERS lacked END_STREAM")
  2739. }
  2740. if !hf.HeadersEnded() {
  2741. t.Fatal("response HEADERS didn't have END_HEADERS")
  2742. }
  2743. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2744. wanth := [][2]string{
  2745. {":status", "200"},
  2746. {"ok1", "x"},
  2747. {"content-length", "0"},
  2748. }
  2749. if !reflect.DeepEqual(goth, wanth) {
  2750. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2751. }
  2752. })
  2753. }
  2754. func BenchmarkServerGets(b *testing.B) {
  2755. defer disableGoroutineTracking()()
  2756. b.ReportAllocs()
  2757. const msg = "Hello, world"
  2758. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2759. io.WriteString(w, msg)
  2760. })
  2761. defer st.Close()
  2762. st.greet()
  2763. // Give the server quota to reply. (plus it has the 64KB)
  2764. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2765. b.Fatal(err)
  2766. }
  2767. for i := 0; i < b.N; i++ {
  2768. id := 1 + uint32(i)*2
  2769. st.writeHeaders(HeadersFrameParam{
  2770. StreamID: id,
  2771. BlockFragment: st.encodeHeader(),
  2772. EndStream: true,
  2773. EndHeaders: true,
  2774. })
  2775. st.wantHeaders()
  2776. df := st.wantData()
  2777. if !df.StreamEnded() {
  2778. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2779. }
  2780. }
  2781. }
  2782. func BenchmarkServerPosts(b *testing.B) {
  2783. defer disableGoroutineTracking()()
  2784. b.ReportAllocs()
  2785. const msg = "Hello, world"
  2786. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2787. // Consume the (empty) body from th peer before replying, otherwise
  2788. // the server will sometimes (depending on scheduling) send the peer a
  2789. // a RST_STREAM with the CANCEL error code.
  2790. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2791. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2792. }
  2793. io.WriteString(w, msg)
  2794. })
  2795. defer st.Close()
  2796. st.greet()
  2797. // Give the server quota to reply. (plus it has the 64KB)
  2798. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2799. b.Fatal(err)
  2800. }
  2801. for i := 0; i < b.N; i++ {
  2802. id := 1 + uint32(i)*2
  2803. st.writeHeaders(HeadersFrameParam{
  2804. StreamID: id,
  2805. BlockFragment: st.encodeHeader(":method", "POST"),
  2806. EndStream: false,
  2807. EndHeaders: true,
  2808. })
  2809. st.writeData(id, true, nil)
  2810. st.wantHeaders()
  2811. df := st.wantData()
  2812. if !df.StreamEnded() {
  2813. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2814. }
  2815. }
  2816. }
  2817. // Send a stream of messages from server to client in separate data frames.
  2818. // Brings up performance issues seen in long streams.
  2819. // Created to show problem in go issue #18502
  2820. func BenchmarkServerToClientStreamDefaultOptions(b *testing.B) {
  2821. benchmarkServerToClientStream(b)
  2822. }
  2823. // Justification for Change-Id: Iad93420ef6c3918f54249d867098f1dadfa324d8
  2824. // Expect to see memory/alloc reduction by opting in to Frame reuse with the Framer.
  2825. func BenchmarkServerToClientStreamReuseFrames(b *testing.B) {
  2826. benchmarkServerToClientStream(b, optFramerReuseFrames)
  2827. }
  2828. func benchmarkServerToClientStream(b *testing.B, newServerOpts ...interface{}) {
  2829. defer disableGoroutineTracking()()
  2830. b.ReportAllocs()
  2831. const msgLen = 1
  2832. // default window size
  2833. const windowSize = 1<<16 - 1
  2834. // next message to send from the server and for the client to expect
  2835. nextMsg := func(i int) []byte {
  2836. msg := make([]byte, msgLen)
  2837. msg[0] = byte(i)
  2838. if len(msg) != msgLen {
  2839. panic("invalid test setup msg length")
  2840. }
  2841. return msg
  2842. }
  2843. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2844. // Consume the (empty) body from th peer before replying, otherwise
  2845. // the server will sometimes (depending on scheduling) send the peer a
  2846. // a RST_STREAM with the CANCEL error code.
  2847. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2848. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2849. }
  2850. for i := 0; i < b.N; i += 1 {
  2851. w.Write(nextMsg(i))
  2852. w.(http.Flusher).Flush()
  2853. }
  2854. }, newServerOpts...)
  2855. defer st.Close()
  2856. st.greet()
  2857. const id = uint32(1)
  2858. st.writeHeaders(HeadersFrameParam{
  2859. StreamID: id,
  2860. BlockFragment: st.encodeHeader(":method", "POST"),
  2861. EndStream: false,
  2862. EndHeaders: true,
  2863. })
  2864. st.writeData(id, true, nil)
  2865. st.wantHeaders()
  2866. var pendingWindowUpdate = uint32(0)
  2867. for i := 0; i < b.N; i += 1 {
  2868. expected := nextMsg(i)
  2869. df := st.wantData()
  2870. if bytes.Compare(expected, df.data) != 0 {
  2871. b.Fatalf("Bad message received; want %v; got %v", expected, df.data)
  2872. }
  2873. // try to send infrequent but large window updates so they don't overwhelm the test
  2874. pendingWindowUpdate += uint32(len(df.data))
  2875. if pendingWindowUpdate >= windowSize/2 {
  2876. if err := st.fr.WriteWindowUpdate(0, pendingWindowUpdate); err != nil {
  2877. b.Fatal(err)
  2878. }
  2879. if err := st.fr.WriteWindowUpdate(id, pendingWindowUpdate); err != nil {
  2880. b.Fatal(err)
  2881. }
  2882. pendingWindowUpdate = 0
  2883. }
  2884. }
  2885. df := st.wantData()
  2886. if !df.StreamEnded() {
  2887. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2888. }
  2889. }
  2890. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2891. // Verify we don't hang.
  2892. func TestIssue53(t *testing.T) {
  2893. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2894. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2895. s := &http.Server{
  2896. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2897. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2898. w.Write([]byte("hello"))
  2899. }),
  2900. }
  2901. s2 := &Server{
  2902. MaxReadFrameSize: 1 << 16,
  2903. PermitProhibitedCipherSuites: true,
  2904. }
  2905. c := &issue53Conn{[]byte(data), false, false}
  2906. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2907. if !c.closed {
  2908. t.Fatal("connection is not closed")
  2909. }
  2910. }
  2911. type issue53Conn struct {
  2912. data []byte
  2913. closed bool
  2914. written bool
  2915. }
  2916. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2917. if len(c.data) == 0 {
  2918. return 0, io.EOF
  2919. }
  2920. n = copy(b, c.data)
  2921. c.data = c.data[n:]
  2922. return
  2923. }
  2924. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2925. c.written = true
  2926. return len(b), nil
  2927. }
  2928. func (c *issue53Conn) Close() error {
  2929. c.closed = true
  2930. return nil
  2931. }
  2932. func (c *issue53Conn) LocalAddr() net.Addr {
  2933. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2934. }
  2935. func (c *issue53Conn) RemoteAddr() net.Addr {
  2936. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2937. }
  2938. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2939. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2940. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2941. // golang.org/issue/12895
  2942. func TestConfigureServer(t *testing.T) {
  2943. tests := []struct {
  2944. name string
  2945. tlsConfig *tls.Config
  2946. wantErr string
  2947. }{
  2948. {
  2949. name: "empty server",
  2950. },
  2951. {
  2952. name: "just the required cipher suite",
  2953. tlsConfig: &tls.Config{
  2954. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2955. },
  2956. },
  2957. {
  2958. name: "just the alternative required cipher suite",
  2959. tlsConfig: &tls.Config{
  2960. CipherSuites: []uint16{tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256},
  2961. },
  2962. },
  2963. {
  2964. name: "missing required cipher suite",
  2965. tlsConfig: &tls.Config{
  2966. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2967. },
  2968. wantErr: "is missing an HTTP/2-required AES_128_GCM_SHA256 cipher.",
  2969. },
  2970. {
  2971. name: "required after bad",
  2972. tlsConfig: &tls.Config{
  2973. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2974. },
  2975. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2976. },
  2977. {
  2978. name: "bad after required",
  2979. tlsConfig: &tls.Config{
  2980. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2981. },
  2982. },
  2983. }
  2984. for _, tt := range tests {
  2985. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2986. err := ConfigureServer(srv, nil)
  2987. if (err != nil) != (tt.wantErr != "") {
  2988. if tt.wantErr != "" {
  2989. t.Errorf("%s: success, but want error", tt.name)
  2990. } else {
  2991. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2992. }
  2993. }
  2994. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2995. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2996. }
  2997. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2998. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2999. }
  3000. }
  3001. }
  3002. func TestServerRejectHeadWithBody(t *testing.T) {
  3003. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3004. // No response body.
  3005. })
  3006. defer st.Close()
  3007. st.greet()
  3008. st.writeHeaders(HeadersFrameParam{
  3009. StreamID: 1, // clients send odd numbers
  3010. BlockFragment: st.encodeHeader(":method", "HEAD"),
  3011. EndStream: false, // what we're testing, a bogus HEAD request with body
  3012. EndHeaders: true,
  3013. })
  3014. st.wantRSTStream(1, ErrCodeProtocol)
  3015. }
  3016. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  3017. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3018. // No response body. (or smaller than one frame)
  3019. })
  3020. defer st.Close()
  3021. st.greet()
  3022. st.writeHeaders(HeadersFrameParam{
  3023. StreamID: 1, // clients send odd numbers
  3024. BlockFragment: st.encodeHeader(":method", "HEAD"),
  3025. EndStream: true,
  3026. EndHeaders: true,
  3027. })
  3028. h := st.wantHeaders()
  3029. headers := st.decodeHeader(h.HeaderBlockFragment())
  3030. want := [][2]string{
  3031. {":status", "200"},
  3032. }
  3033. if !reflect.DeepEqual(headers, want) {
  3034. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3035. }
  3036. }
  3037. // golang.org/issue/13495
  3038. func TestServerNoDuplicateContentType(t *testing.T) {
  3039. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3040. w.Header()["Content-Type"] = []string{""}
  3041. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  3042. })
  3043. defer st.Close()
  3044. st.greet()
  3045. st.writeHeaders(HeadersFrameParam{
  3046. StreamID: 1,
  3047. BlockFragment: st.encodeHeader(),
  3048. EndStream: true,
  3049. EndHeaders: true,
  3050. })
  3051. h := st.wantHeaders()
  3052. headers := st.decodeHeader(h.HeaderBlockFragment())
  3053. want := [][2]string{
  3054. {":status", "200"},
  3055. {"content-type", ""},
  3056. {"content-length", "41"},
  3057. {"x-content-type-options", "nosniff"},
  3058. }
  3059. if !reflect.DeepEqual(headers, want) {
  3060. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3061. }
  3062. }
  3063. func disableGoroutineTracking() (restore func()) {
  3064. old := DebugGoroutines
  3065. DebugGoroutines = false
  3066. return func() { DebugGoroutines = old }
  3067. }
  3068. func BenchmarkServer_GetRequest(b *testing.B) {
  3069. defer disableGoroutineTracking()()
  3070. b.ReportAllocs()
  3071. const msg = "Hello, world."
  3072. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3073. n, err := io.Copy(ioutil.Discard, r.Body)
  3074. if err != nil || n > 0 {
  3075. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3076. }
  3077. io.WriteString(w, msg)
  3078. })
  3079. defer st.Close()
  3080. st.greet()
  3081. // Give the server quota to reply. (plus it has the 64KB)
  3082. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3083. b.Fatal(err)
  3084. }
  3085. hbf := st.encodeHeader(":method", "GET")
  3086. for i := 0; i < b.N; i++ {
  3087. streamID := uint32(1 + 2*i)
  3088. st.writeHeaders(HeadersFrameParam{
  3089. StreamID: streamID,
  3090. BlockFragment: hbf,
  3091. EndStream: true,
  3092. EndHeaders: true,
  3093. })
  3094. st.wantHeaders()
  3095. st.wantData()
  3096. }
  3097. }
  3098. func BenchmarkServer_PostRequest(b *testing.B) {
  3099. defer disableGoroutineTracking()()
  3100. b.ReportAllocs()
  3101. const msg = "Hello, world."
  3102. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3103. n, err := io.Copy(ioutil.Discard, r.Body)
  3104. if err != nil || n > 0 {
  3105. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3106. }
  3107. io.WriteString(w, msg)
  3108. })
  3109. defer st.Close()
  3110. st.greet()
  3111. // Give the server quota to reply. (plus it has the 64KB)
  3112. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3113. b.Fatal(err)
  3114. }
  3115. hbf := st.encodeHeader(":method", "POST")
  3116. for i := 0; i < b.N; i++ {
  3117. streamID := uint32(1 + 2*i)
  3118. st.writeHeaders(HeadersFrameParam{
  3119. StreamID: streamID,
  3120. BlockFragment: hbf,
  3121. EndStream: false,
  3122. EndHeaders: true,
  3123. })
  3124. st.writeData(streamID, true, nil)
  3125. st.wantHeaders()
  3126. st.wantData()
  3127. }
  3128. }
  3129. type connStateConn struct {
  3130. net.Conn
  3131. cs tls.ConnectionState
  3132. }
  3133. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  3134. // golang.org/issue/12737 -- handle any net.Conn, not just
  3135. // *tls.Conn.
  3136. func TestServerHandleCustomConn(t *testing.T) {
  3137. var s Server
  3138. c1, c2 := net.Pipe()
  3139. clientDone := make(chan struct{})
  3140. handlerDone := make(chan struct{})
  3141. var req *http.Request
  3142. go func() {
  3143. defer close(clientDone)
  3144. defer c2.Close()
  3145. fr := NewFramer(c2, c2)
  3146. io.WriteString(c2, ClientPreface)
  3147. fr.WriteSettings()
  3148. fr.WriteSettingsAck()
  3149. f, err := fr.ReadFrame()
  3150. if err != nil {
  3151. t.Error(err)
  3152. return
  3153. }
  3154. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  3155. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  3156. return
  3157. }
  3158. f, err = fr.ReadFrame()
  3159. if err != nil {
  3160. t.Error(err)
  3161. return
  3162. }
  3163. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  3164. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  3165. return
  3166. }
  3167. var henc hpackEncoder
  3168. fr.WriteHeaders(HeadersFrameParam{
  3169. StreamID: 1,
  3170. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  3171. EndStream: true,
  3172. EndHeaders: true,
  3173. })
  3174. go io.Copy(ioutil.Discard, c2)
  3175. <-handlerDone
  3176. }()
  3177. const testString = "my custom ConnectionState"
  3178. fakeConnState := tls.ConnectionState{
  3179. ServerName: testString,
  3180. Version: tls.VersionTLS12,
  3181. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  3182. }
  3183. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3184. BaseConfig: &http.Server{
  3185. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3186. defer close(handlerDone)
  3187. req = r
  3188. }),
  3189. }})
  3190. select {
  3191. case <-clientDone:
  3192. case <-time.After(5 * time.Second):
  3193. t.Fatal("timeout waiting for handler")
  3194. }
  3195. if req.TLS == nil {
  3196. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3197. }
  3198. if req.TLS.ServerName != testString {
  3199. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3200. }
  3201. }
  3202. // golang.org/issue/14214
  3203. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3204. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3205. t.Error("should not get to Handler")
  3206. })
  3207. defer st.Close()
  3208. st.greet()
  3209. st.bodylessReq1("connection", "foo")
  3210. hf := st.wantHeaders()
  3211. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3212. wanth := [][2]string{
  3213. {":status", "400"},
  3214. {"content-type", "text/plain; charset=utf-8"},
  3215. {"x-content-type-options", "nosniff"},
  3216. {"content-length", "51"},
  3217. }
  3218. if !reflect.DeepEqual(goth, wanth) {
  3219. t.Errorf("Got headers %v; want %v", goth, wanth)
  3220. }
  3221. }
  3222. type hpackEncoder struct {
  3223. enc *hpack.Encoder
  3224. buf bytes.Buffer
  3225. }
  3226. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3227. if len(headers)%2 == 1 {
  3228. panic("odd number of kv args")
  3229. }
  3230. he.buf.Reset()
  3231. if he.enc == nil {
  3232. he.enc = hpack.NewEncoder(&he.buf)
  3233. }
  3234. for len(headers) > 0 {
  3235. k, v := headers[0], headers[1]
  3236. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3237. if err != nil {
  3238. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3239. }
  3240. headers = headers[2:]
  3241. }
  3242. return he.buf.Bytes()
  3243. }
  3244. func TestCheckValidHTTP2Request(t *testing.T) {
  3245. tests := []struct {
  3246. h http.Header
  3247. want error
  3248. }{
  3249. {
  3250. h: http.Header{"Te": {"trailers"}},
  3251. want: nil,
  3252. },
  3253. {
  3254. h: http.Header{"Te": {"trailers", "bogus"}},
  3255. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3256. },
  3257. {
  3258. h: http.Header{"Foo": {""}},
  3259. want: nil,
  3260. },
  3261. {
  3262. h: http.Header{"Connection": {""}},
  3263. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3264. },
  3265. {
  3266. h: http.Header{"Proxy-Connection": {""}},
  3267. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3268. },
  3269. {
  3270. h: http.Header{"Keep-Alive": {""}},
  3271. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3272. },
  3273. {
  3274. h: http.Header{"Upgrade": {""}},
  3275. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3276. },
  3277. }
  3278. for i, tt := range tests {
  3279. got := checkValidHTTP2RequestHeaders(tt.h)
  3280. if !reflect.DeepEqual(got, tt.want) {
  3281. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3282. }
  3283. }
  3284. }
  3285. // golang.org/issue/14030
  3286. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3287. const msg = "Hello"
  3288. const msg2 = "World"
  3289. doRead := make(chan bool, 1)
  3290. defer close(doRead) // fallback cleanup
  3291. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3292. io.WriteString(w, msg)
  3293. w.(http.Flusher).Flush()
  3294. // Do a read, which might force a 100-continue status to be sent.
  3295. <-doRead
  3296. r.Body.Read(make([]byte, 10))
  3297. io.WriteString(w, msg2)
  3298. }, optOnlyServer)
  3299. defer st.Close()
  3300. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3301. defer tr.CloseIdleConnections()
  3302. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3303. req.Header.Set("Expect", "100-continue")
  3304. res, err := tr.RoundTrip(req)
  3305. if err != nil {
  3306. t.Fatal(err)
  3307. }
  3308. defer res.Body.Close()
  3309. buf := make([]byte, len(msg))
  3310. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3311. t.Fatal(err)
  3312. }
  3313. if string(buf) != msg {
  3314. t.Fatalf("msg = %q; want %q", buf, msg)
  3315. }
  3316. doRead <- true
  3317. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3318. t.Fatal(err)
  3319. }
  3320. if string(buf) != msg2 {
  3321. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3322. }
  3323. }
  3324. type funcReader func([]byte) (n int, err error)
  3325. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3326. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3327. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3328. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3329. unblock := make(chan bool, 1)
  3330. defer close(unblock)
  3331. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3332. // Don't read the 16KB request body. Wait until the client's
  3333. // done sending it and then return. This should cause the Server
  3334. // to then return those 16KB of flow control to the client.
  3335. <-unblock
  3336. }, optOnlyServer)
  3337. defer st.Close()
  3338. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3339. defer tr.CloseIdleConnections()
  3340. // This previously hung on the 4th iteration.
  3341. for i := 0; i < 6; i++ {
  3342. body := io.MultiReader(
  3343. io.LimitReader(neverEnding('A'), 16<<10),
  3344. funcReader(func([]byte) (n int, err error) {
  3345. unblock <- true
  3346. return 0, io.EOF
  3347. }),
  3348. )
  3349. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3350. res, err := tr.RoundTrip(req)
  3351. if err != nil {
  3352. t.Fatal(err)
  3353. }
  3354. res.Body.Close()
  3355. }
  3356. }
  3357. func TestServerIdleTimeout(t *testing.T) {
  3358. if testing.Short() {
  3359. t.Skip("skipping in short mode")
  3360. }
  3361. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3362. }, func(h2s *Server) {
  3363. h2s.IdleTimeout = 500 * time.Millisecond
  3364. })
  3365. defer st.Close()
  3366. st.greet()
  3367. ga := st.wantGoAway()
  3368. if ga.ErrCode != ErrCodeNo {
  3369. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3370. }
  3371. }
  3372. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3373. if testing.Short() {
  3374. t.Skip("skipping in short mode")
  3375. }
  3376. const timeout = 250 * time.Millisecond
  3377. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3378. time.Sleep(timeout * 2)
  3379. }, func(h2s *Server) {
  3380. h2s.IdleTimeout = timeout
  3381. })
  3382. defer st.Close()
  3383. st.greet()
  3384. // Send a request which takes twice the timeout. Verifies the
  3385. // idle timeout doesn't fire while we're in a request:
  3386. st.bodylessReq1()
  3387. st.wantHeaders()
  3388. // But the idle timeout should be rearmed after the request
  3389. // is done:
  3390. ga := st.wantGoAway()
  3391. if ga.ErrCode != ErrCodeNo {
  3392. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3393. }
  3394. }
  3395. // grpc-go closes the Request.Body currently with a Read.
  3396. // Verify that it doesn't race.
  3397. // See https://github.com/grpc/grpc-go/pull/938
  3398. func TestRequestBodyReadCloseRace(t *testing.T) {
  3399. for i := 0; i < 100; i++ {
  3400. body := &requestBody{
  3401. pipe: &pipe{
  3402. b: new(bytes.Buffer),
  3403. },
  3404. }
  3405. body.pipe.CloseWithError(io.EOF)
  3406. done := make(chan bool, 1)
  3407. buf := make([]byte, 10)
  3408. go func() {
  3409. time.Sleep(1 * time.Millisecond)
  3410. body.Close()
  3411. done <- true
  3412. }()
  3413. body.Read(buf)
  3414. <-done
  3415. }
  3416. }
  3417. func TestIssue20704Race(t *testing.T) {
  3418. if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
  3419. t.Skip("skipping in short mode")
  3420. }
  3421. const (
  3422. itemSize = 1 << 10
  3423. itemCount = 100
  3424. )
  3425. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3426. for i := 0; i < itemCount; i++ {
  3427. _, err := w.Write(make([]byte, itemSize))
  3428. if err != nil {
  3429. return
  3430. }
  3431. }
  3432. }, optOnlyServer)
  3433. defer st.Close()
  3434. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3435. defer tr.CloseIdleConnections()
  3436. cl := &http.Client{Transport: tr}
  3437. for i := 0; i < 1000; i++ {
  3438. resp, err := cl.Get(st.ts.URL)
  3439. if err != nil {
  3440. t.Fatal(err)
  3441. }
  3442. // Force a RST stream to the server by closing without
  3443. // reading the body:
  3444. resp.Body.Close()
  3445. }
  3446. }