server_test.go 48 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. // See https://code.google.com/p/go/source/browse/CONTRIBUTORS
  5. // Licensed under the same terms as Go itself:
  6. // https://code.google.com/p/go/source/browse/LICENSE
  7. package http2
  8. import (
  9. "bytes"
  10. "crypto/tls"
  11. "errors"
  12. "fmt"
  13. "io"
  14. "io/ioutil"
  15. "log"
  16. "net"
  17. "net/http"
  18. "net/http/httptest"
  19. "os"
  20. "reflect"
  21. "runtime"
  22. "strconv"
  23. "strings"
  24. "sync"
  25. "sync/atomic"
  26. "testing"
  27. "time"
  28. "github.com/bradfitz/http2/hpack"
  29. )
  30. type serverTester struct {
  31. cc net.Conn // client conn
  32. t *testing.T
  33. ts *httptest.Server
  34. fr *Framer
  35. logBuf *bytes.Buffer
  36. sc *serverConn
  37. logFilter []string // substrings to filter out
  38. }
  39. func newServerTester(t *testing.T, handler http.HandlerFunc) *serverTester {
  40. logBuf := new(bytes.Buffer)
  41. ts := httptest.NewUnstartedServer(handler)
  42. ConfigureServer(ts.Config, &Server{})
  43. st := &serverTester{
  44. t: t,
  45. ts: ts,
  46. logBuf: logBuf,
  47. }
  48. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  49. ts.Config.ErrorLog = log.New(io.MultiWriter(twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  50. ts.StartTLS()
  51. if VerboseLogs {
  52. t.Logf("Running test server at: %s", ts.URL)
  53. }
  54. var (
  55. mu sync.Mutex
  56. sc *serverConn
  57. )
  58. testHookGetServerConn = func(v *serverConn) {
  59. mu.Lock()
  60. defer mu.Unlock()
  61. sc = v
  62. sc.testHookCh = make(chan func())
  63. }
  64. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), &tls.Config{
  65. InsecureSkipVerify: true,
  66. NextProtos: []string{NextProtoTLS},
  67. })
  68. if err != nil {
  69. t.Fatal(err)
  70. }
  71. log.SetOutput(twriter{t: t, st: st})
  72. st.cc = cc
  73. st.fr = NewFramer(cc, cc)
  74. mu.Lock()
  75. st.sc = sc
  76. mu.Unlock() // unnecessary, but looks weird without.
  77. return st
  78. }
  79. func (st *serverTester) addLogFilter(phrase string) {
  80. st.logFilter = append(st.logFilter, phrase)
  81. }
  82. func (st *serverTester) stream(id uint32) *stream {
  83. ch := make(chan *stream, 1)
  84. st.sc.testHookCh <- func() {
  85. ch <- st.sc.streams[id]
  86. }
  87. return <-ch
  88. }
  89. func (st *serverTester) streamState(id uint32) streamState {
  90. ch := make(chan streamState, 1)
  91. st.sc.testHookCh <- func() {
  92. ch <- st.sc.state(id)
  93. }
  94. return <-ch
  95. }
  96. func (st *serverTester) Close() {
  97. st.ts.Close()
  98. st.cc.Close()
  99. log.SetOutput(os.Stderr)
  100. }
  101. // greet initiates the client's HTTP/2 connection into a state where
  102. // frames may be sent.
  103. func (st *serverTester) greet() {
  104. st.writePreface()
  105. st.writeInitialSettings()
  106. st.wantSettings()
  107. st.writeSettingsAck()
  108. st.wantSettingsAck()
  109. }
  110. func (st *serverTester) writePreface() {
  111. n, err := st.cc.Write(clientPreface)
  112. if err != nil {
  113. st.t.Fatalf("Error writing client preface: %v", err)
  114. }
  115. if n != len(clientPreface) {
  116. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  117. }
  118. }
  119. func (st *serverTester) writeInitialSettings() {
  120. if err := st.fr.WriteSettings(); err != nil {
  121. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  122. }
  123. }
  124. func (st *serverTester) writeSettingsAck() {
  125. if err := st.fr.WriteSettingsAck(); err != nil {
  126. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  127. }
  128. }
  129. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  130. if err := st.fr.WriteHeaders(p); err != nil {
  131. st.t.Fatalf("Error writing HEADERS: %v", err)
  132. }
  133. }
  134. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  135. func (st *serverTester) bodylessReq1(headers ...string) {
  136. st.writeHeaders(HeadersFrameParam{
  137. StreamID: 1, // clients send odd numbers
  138. BlockFragment: encodeHeader(st.t, headers...),
  139. EndStream: true,
  140. EndHeaders: true,
  141. })
  142. }
  143. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  144. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  145. st.t.Fatalf("Error writing DATA: %v", err)
  146. }
  147. }
  148. func (st *serverTester) readFrame() (Frame, error) {
  149. frc := make(chan Frame, 1)
  150. errc := make(chan error, 1)
  151. go func() {
  152. fr, err := st.fr.ReadFrame()
  153. if err != nil {
  154. errc <- err
  155. } else {
  156. frc <- fr
  157. }
  158. }()
  159. t := time.NewTimer(2 * time.Second)
  160. defer t.Stop()
  161. select {
  162. case f := <-frc:
  163. return f, nil
  164. case err := <-errc:
  165. return nil, err
  166. case <-t.C:
  167. return nil, errors.New("timeout waiting for frame")
  168. }
  169. }
  170. func (st *serverTester) wantHeaders() *HeadersFrame {
  171. f, err := st.readFrame()
  172. if err != nil {
  173. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  174. }
  175. hf, ok := f.(*HeadersFrame)
  176. if !ok {
  177. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  178. }
  179. return hf
  180. }
  181. func (st *serverTester) wantContinuation() *ContinuationFrame {
  182. f, err := st.readFrame()
  183. if err != nil {
  184. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  185. }
  186. cf, ok := f.(*ContinuationFrame)
  187. if !ok {
  188. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  189. }
  190. return cf
  191. }
  192. func (st *serverTester) wantData() *DataFrame {
  193. f, err := st.readFrame()
  194. if err != nil {
  195. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  196. }
  197. df, ok := f.(*DataFrame)
  198. if !ok {
  199. st.t.Fatalf("got a %T; want *DataFrame", f)
  200. }
  201. return df
  202. }
  203. func (st *serverTester) wantSettings() *SettingsFrame {
  204. f, err := st.readFrame()
  205. if err != nil {
  206. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  207. }
  208. sf, ok := f.(*SettingsFrame)
  209. if !ok {
  210. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  211. }
  212. return sf
  213. }
  214. func (st *serverTester) wantPing() *PingFrame {
  215. f, err := st.readFrame()
  216. if err != nil {
  217. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  218. }
  219. pf, ok := f.(*PingFrame)
  220. if !ok {
  221. st.t.Fatalf("got a %T; want *PingFrame", f)
  222. }
  223. return pf
  224. }
  225. func (st *serverTester) wantGoAway() *GoAwayFrame {
  226. f, err := st.readFrame()
  227. if err != nil {
  228. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  229. }
  230. gf, ok := f.(*GoAwayFrame)
  231. if !ok {
  232. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  233. }
  234. return gf
  235. }
  236. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  237. f, err := st.readFrame()
  238. if err != nil {
  239. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  240. }
  241. rs, ok := f.(*RSTStreamFrame)
  242. if !ok {
  243. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  244. }
  245. if rs.FrameHeader.StreamID != streamID {
  246. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  247. }
  248. if rs.ErrCode != errCode {
  249. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  250. }
  251. }
  252. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  253. f, err := st.readFrame()
  254. if err != nil {
  255. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  256. }
  257. wu, ok := f.(*WindowUpdateFrame)
  258. if !ok {
  259. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  260. }
  261. if wu.FrameHeader.StreamID != streamID {
  262. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  263. }
  264. if wu.Increment != incr {
  265. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  266. }
  267. }
  268. func (st *serverTester) wantSettingsAck() {
  269. f, err := st.readFrame()
  270. if err != nil {
  271. st.t.Fatal(err)
  272. }
  273. sf, ok := f.(*SettingsFrame)
  274. if !ok {
  275. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  276. }
  277. if !sf.Header().Flags.Has(FlagSettingsAck) {
  278. st.t.Fatal("Settings Frame didn't have ACK set")
  279. }
  280. }
  281. func TestServer(t *testing.T) {
  282. gotReq := make(chan bool, 1)
  283. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  284. w.Header().Set("Foo", "Bar")
  285. gotReq <- true
  286. })
  287. defer st.Close()
  288. covers("3.5", `
  289. The server connection preface consists of a potentially empty
  290. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  291. server sends in the HTTP/2 connection.
  292. `)
  293. st.writePreface()
  294. st.writeInitialSettings()
  295. st.wantSettings()
  296. st.writeSettingsAck()
  297. st.wantSettingsAck()
  298. st.writeHeaders(HeadersFrameParam{
  299. StreamID: 1, // clients send odd numbers
  300. BlockFragment: encodeHeader(t),
  301. EndStream: true, // no DATA frames
  302. EndHeaders: true,
  303. })
  304. select {
  305. case <-gotReq:
  306. case <-time.After(2 * time.Second):
  307. t.Error("timeout waiting for request")
  308. }
  309. }
  310. func TestServer_Request_Get(t *testing.T) {
  311. testServerRequest(t, func(st *serverTester) {
  312. st.writeHeaders(HeadersFrameParam{
  313. StreamID: 1, // clients send odd numbers
  314. BlockFragment: encodeHeader(t, "foo-bar", "some-value"),
  315. EndStream: true, // no DATA frames
  316. EndHeaders: true,
  317. })
  318. }, func(r *http.Request) {
  319. if r.Method != "GET" {
  320. t.Errorf("Method = %q; want GET", r.Method)
  321. }
  322. if r.URL.Path != "/" {
  323. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  324. }
  325. if r.ContentLength != 0 {
  326. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  327. }
  328. if r.Close {
  329. t.Error("Close = true; want false")
  330. }
  331. if !strings.Contains(r.RemoteAddr, ":") {
  332. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  333. }
  334. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  335. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  336. }
  337. wantHeader := http.Header{
  338. "Foo-Bar": []string{"some-value"},
  339. }
  340. if !reflect.DeepEqual(r.Header, wantHeader) {
  341. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  342. }
  343. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  344. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  345. }
  346. })
  347. }
  348. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  349. testServerRequest(t, func(st *serverTester) {
  350. st.writeHeaders(HeadersFrameParam{
  351. StreamID: 1, // clients send odd numbers
  352. BlockFragment: encodeHeader(t, ":path", "/%2f/"),
  353. EndStream: true, // no DATA frames
  354. EndHeaders: true,
  355. })
  356. }, func(r *http.Request) {
  357. if r.RequestURI != "/%2f/" {
  358. t.Errorf("RequestURI = %q; want /%2f/", r.RequestURI)
  359. }
  360. if r.URL.Path != "///" {
  361. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  362. }
  363. })
  364. }
  365. // TODO: add a test with EndStream=true on the HEADERS but setting a
  366. // Content-Length anyway. Should we just omit it and force it to
  367. // zero?
  368. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  369. testServerRequest(t, func(st *serverTester) {
  370. st.writeHeaders(HeadersFrameParam{
  371. StreamID: 1, // clients send odd numbers
  372. BlockFragment: encodeHeader(t, ":method", "POST"),
  373. EndStream: true,
  374. EndHeaders: true,
  375. })
  376. }, func(r *http.Request) {
  377. if r.Method != "POST" {
  378. t.Errorf("Method = %q; want POST", r.Method)
  379. }
  380. if r.ContentLength != 0 {
  381. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  382. }
  383. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  384. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  385. }
  386. })
  387. }
  388. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  389. testBodyContents(t, -1, "", func(st *serverTester) {
  390. st.writeHeaders(HeadersFrameParam{
  391. StreamID: 1, // clients send odd numbers
  392. BlockFragment: encodeHeader(t, ":method", "POST"),
  393. EndStream: false, // to say DATA frames are coming
  394. EndHeaders: true,
  395. })
  396. st.writeData(1, true, nil) // just kidding. empty body.
  397. })
  398. }
  399. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  400. const content = "Some content"
  401. testBodyContents(t, -1, content, func(st *serverTester) {
  402. st.writeHeaders(HeadersFrameParam{
  403. StreamID: 1, // clients send odd numbers
  404. BlockFragment: encodeHeader(t, ":method", "POST"),
  405. EndStream: false, // to say DATA frames are coming
  406. EndHeaders: true,
  407. })
  408. st.writeData(1, true, []byte(content))
  409. })
  410. }
  411. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  412. const content = "Some content"
  413. testBodyContents(t, -1, content, func(st *serverTester) {
  414. st.writeHeaders(HeadersFrameParam{
  415. StreamID: 1, // clients send odd numbers
  416. BlockFragment: encodeHeader(t, ":method", "POST"),
  417. EndStream: false, // to say DATA frames are coming
  418. EndHeaders: true,
  419. })
  420. st.writeData(1, false, []byte(content[:5]))
  421. st.writeData(1, true, []byte(content[5:]))
  422. })
  423. }
  424. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  425. const content = "Some content"
  426. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  427. st.writeHeaders(HeadersFrameParam{
  428. StreamID: 1, // clients send odd numbers
  429. BlockFragment: encodeHeader(t,
  430. ":method", "POST",
  431. "content-length", strconv.Itoa(len(content)),
  432. ),
  433. EndStream: false, // to say DATA frames are coming
  434. EndHeaders: true,
  435. })
  436. st.writeData(1, true, []byte(content))
  437. })
  438. }
  439. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  440. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  441. func(st *serverTester) {
  442. st.writeHeaders(HeadersFrameParam{
  443. StreamID: 1, // clients send odd numbers
  444. BlockFragment: encodeHeader(t,
  445. ":method", "POST",
  446. "content-length", "3",
  447. ),
  448. EndStream: false, // to say DATA frames are coming
  449. EndHeaders: true,
  450. })
  451. st.writeData(1, true, []byte("12"))
  452. })
  453. }
  454. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  455. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  456. func(st *serverTester) {
  457. st.writeHeaders(HeadersFrameParam{
  458. StreamID: 1, // clients send odd numbers
  459. BlockFragment: encodeHeader(t,
  460. ":method", "POST",
  461. "content-length", "4",
  462. ),
  463. EndStream: false, // to say DATA frames are coming
  464. EndHeaders: true,
  465. })
  466. st.writeData(1, true, []byte("12345"))
  467. })
  468. }
  469. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  470. testServerRequest(t, write, func(r *http.Request) {
  471. if r.Method != "POST" {
  472. t.Errorf("Method = %q; want POST", r.Method)
  473. }
  474. if r.ContentLength != wantContentLength {
  475. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  476. }
  477. all, err := ioutil.ReadAll(r.Body)
  478. if err != nil {
  479. t.Fatal(err)
  480. }
  481. if string(all) != wantBody {
  482. t.Errorf("Read = %q; want %q", all, wantBody)
  483. }
  484. if err := r.Body.Close(); err != nil {
  485. t.Fatalf("Close: %v", err)
  486. }
  487. })
  488. }
  489. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  490. testServerRequest(t, write, func(r *http.Request) {
  491. if r.Method != "POST" {
  492. t.Errorf("Method = %q; want POST", r.Method)
  493. }
  494. if r.ContentLength != wantContentLength {
  495. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  496. }
  497. all, err := ioutil.ReadAll(r.Body)
  498. if err == nil {
  499. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  500. wantReadError, all)
  501. }
  502. if !strings.Contains(err.Error(), wantReadError) {
  503. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  504. }
  505. if err := r.Body.Close(); err != nil {
  506. t.Fatalf("Close: %v", err)
  507. }
  508. })
  509. }
  510. // Using a Host header, instead of :authority
  511. func TestServer_Request_Get_Host(t *testing.T) {
  512. const host = "example.com"
  513. testServerRequest(t, func(st *serverTester) {
  514. st.writeHeaders(HeadersFrameParam{
  515. StreamID: 1, // clients send odd numbers
  516. BlockFragment: encodeHeader(t, "host", host),
  517. EndStream: true,
  518. EndHeaders: true,
  519. })
  520. }, func(r *http.Request) {
  521. if r.Host != host {
  522. t.Errorf("Host = %q; want %q", r.Host, host)
  523. }
  524. })
  525. }
  526. // Using an :authority pseudo-header, instead of Host
  527. func TestServer_Request_Get_Authority(t *testing.T) {
  528. const host = "example.com"
  529. testServerRequest(t, func(st *serverTester) {
  530. st.writeHeaders(HeadersFrameParam{
  531. StreamID: 1, // clients send odd numbers
  532. BlockFragment: encodeHeader(t, ":authority", host),
  533. EndStream: true,
  534. EndHeaders: true,
  535. })
  536. }, func(r *http.Request) {
  537. if r.Host != host {
  538. t.Errorf("Host = %q; want %q", r.Host, host)
  539. }
  540. })
  541. }
  542. func TestServer_Request_WithContinuation(t *testing.T) {
  543. wantHeader := http.Header{
  544. "Foo-One": []string{"value-one"},
  545. "Foo-Two": []string{"value-two"},
  546. "Foo-Three": []string{"value-three"},
  547. }
  548. testServerRequest(t, func(st *serverTester) {
  549. fullHeaders := encodeHeader(t,
  550. "foo-one", "value-one",
  551. "foo-two", "value-two",
  552. "foo-three", "value-three",
  553. )
  554. remain := fullHeaders
  555. chunks := 0
  556. for len(remain) > 0 {
  557. const maxChunkSize = 5
  558. chunk := remain
  559. if len(chunk) > maxChunkSize {
  560. chunk = chunk[:maxChunkSize]
  561. }
  562. remain = remain[len(chunk):]
  563. if chunks == 0 {
  564. st.writeHeaders(HeadersFrameParam{
  565. StreamID: 1, // clients send odd numbers
  566. BlockFragment: chunk,
  567. EndStream: true, // no DATA frames
  568. EndHeaders: false, // we'll have continuation frames
  569. })
  570. } else {
  571. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  572. if err != nil {
  573. t.Fatal(err)
  574. }
  575. }
  576. chunks++
  577. }
  578. if chunks < 2 {
  579. t.Fatal("too few chunks")
  580. }
  581. }, func(r *http.Request) {
  582. if !reflect.DeepEqual(r.Header, wantHeader) {
  583. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  584. }
  585. })
  586. }
  587. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  588. func TestServer_Request_CookieConcat(t *testing.T) {
  589. const host = "example.com"
  590. testServerRequest(t, func(st *serverTester) {
  591. st.bodylessReq1(
  592. ":authority", host,
  593. "cookie", "a=b",
  594. "cookie", "c=d",
  595. "cookie", "e=f",
  596. )
  597. }, func(r *http.Request) {
  598. const want = "a=b; c=d; e=f"
  599. if got := r.Header.Get("Cookie"); got != want {
  600. t.Errorf("Cookie = %q; want %q", got, want)
  601. }
  602. })
  603. }
  604. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  605. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  606. }
  607. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  608. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  609. }
  610. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  611. // 8.1.2.3 Request Pseudo-Header Fields
  612. // "All HTTP/2 requests MUST include exactly one valid value" ...
  613. testRejectRequest(t, func(st *serverTester) {
  614. st.addLogFilter("duplicate pseudo-header")
  615. st.bodylessReq1(":method", "GET", ":method", "POST")
  616. })
  617. }
  618. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  619. // 8.1.2.3 Request Pseudo-Header Fields
  620. // "All pseudo-header fields MUST appear in the header block
  621. // before regular header fields. Any request or response that
  622. // contains a pseudo-header field that appears in a header
  623. // block after a regular header field MUST be treated as
  624. // malformed (Section 8.1.2.6)."
  625. testRejectRequest(t, func(st *serverTester) {
  626. st.addLogFilter("pseudo-header after regular header")
  627. var buf bytes.Buffer
  628. enc := hpack.NewEncoder(&buf)
  629. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  630. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  631. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  632. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  633. st.writeHeaders(HeadersFrameParam{
  634. StreamID: 1, // clients send odd numbers
  635. BlockFragment: buf.Bytes(),
  636. EndStream: true,
  637. EndHeaders: true,
  638. })
  639. })
  640. }
  641. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  642. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  643. }
  644. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  645. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  646. }
  647. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  648. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  649. }
  650. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  651. testRejectRequest(t, func(st *serverTester) {
  652. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  653. st.bodylessReq1(":unknown_thing", "")
  654. })
  655. }
  656. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  657. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  658. t.Fatal("server request made it to handler; should've been rejected")
  659. })
  660. defer st.Close()
  661. st.greet()
  662. send(st)
  663. st.wantRSTStream(1, ErrCodeProtocol)
  664. }
  665. func TestServer_Ping(t *testing.T) {
  666. st := newServerTester(t, nil)
  667. defer st.Close()
  668. st.greet()
  669. // Server should ignore this one, since it has ACK set.
  670. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  671. if err := st.fr.WritePing(true, ackPingData); err != nil {
  672. t.Fatal(err)
  673. }
  674. // But the server should reply to this one, since ACK is false.
  675. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  676. if err := st.fr.WritePing(false, pingData); err != nil {
  677. t.Fatal(err)
  678. }
  679. pf := st.wantPing()
  680. if !pf.Flags.Has(FlagPingAck) {
  681. t.Error("response ping doesn't have ACK set")
  682. }
  683. if pf.Data != pingData {
  684. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  685. }
  686. }
  687. func TestServer_RejectsLargeFrames(t *testing.T) {
  688. st := newServerTester(t, nil)
  689. defer st.Close()
  690. st.greet()
  691. // Write too large of a frame (too large by one byte)
  692. // We ignore the return value because it's expected that the server
  693. // will only read the first 9 bytes (the headre) and then disconnect.
  694. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  695. gf := st.wantGoAway()
  696. if gf.ErrCode != ErrCodeFrameSize {
  697. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  698. }
  699. }
  700. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  701. puppet := newHandlerPuppet()
  702. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  703. puppet.act(w, r)
  704. })
  705. defer st.Close()
  706. defer puppet.done()
  707. st.greet()
  708. st.writeHeaders(HeadersFrameParam{
  709. StreamID: 1, // clients send odd numbers
  710. BlockFragment: encodeHeader(t, ":method", "POST"),
  711. EndStream: false, // data coming
  712. EndHeaders: true,
  713. })
  714. st.writeData(1, true, []byte("abcdef"))
  715. puppet.do(func(w http.ResponseWriter, r *http.Request) {
  716. buf := make([]byte, 3)
  717. _, err := io.ReadFull(r.Body, buf)
  718. if err != nil {
  719. t.Error(err)
  720. return
  721. }
  722. if string(buf) != "abc" {
  723. t.Errorf("read %q; want abc", buf)
  724. }
  725. })
  726. st.wantWindowUpdate(0, 3)
  727. st.wantWindowUpdate(1, 3)
  728. puppet.do(func(w http.ResponseWriter, r *http.Request) {
  729. buf := make([]byte, 3)
  730. _, err := io.ReadFull(r.Body, buf)
  731. if err != nil {
  732. t.Error(err)
  733. return
  734. }
  735. if string(buf) != "def" {
  736. t.Errorf("read %q; want abc", buf)
  737. }
  738. })
  739. st.wantWindowUpdate(0, 3)
  740. st.wantWindowUpdate(1, 3)
  741. }
  742. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  743. st := newServerTester(t, nil)
  744. defer st.Close()
  745. st.greet()
  746. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  747. t.Fatal(err)
  748. }
  749. gf := st.wantGoAway()
  750. if gf.ErrCode != ErrCodeFlowControl {
  751. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  752. }
  753. if gf.LastStreamID != 0 {
  754. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  755. }
  756. }
  757. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  758. inHandler := make(chan bool)
  759. blockHandler := make(chan bool)
  760. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  761. inHandler <- true
  762. <-blockHandler
  763. })
  764. defer st.Close()
  765. defer close(blockHandler)
  766. st.greet()
  767. st.writeHeaders(HeadersFrameParam{
  768. StreamID: 1,
  769. BlockFragment: encodeHeader(st.t, ":method", "POST"),
  770. EndStream: false, // keep it open
  771. EndHeaders: true,
  772. })
  773. <-inHandler
  774. // Send a bogus window update:
  775. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  776. t.Fatal(err)
  777. }
  778. st.wantRSTStream(1, ErrCodeFlowControl)
  779. }
  780. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  781. // then runs fn once in the handler, and verifies that the error returned from
  782. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  783. func testServerPostUnblock(t *testing.T,
  784. handler func(http.ResponseWriter, *http.Request) error,
  785. fn func(*serverTester),
  786. checkErr func(error),
  787. otherHeaders ...string) {
  788. inHandler := make(chan bool)
  789. errc := make(chan error, 1)
  790. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  791. inHandler <- true
  792. errc <- handler(w, r)
  793. })
  794. st.greet()
  795. st.writeHeaders(HeadersFrameParam{
  796. StreamID: 1,
  797. BlockFragment: encodeHeader(st.t, append([]string{":method", "POST"}, otherHeaders...)...),
  798. EndStream: false, // keep it open
  799. EndHeaders: true,
  800. })
  801. <-inHandler
  802. fn(st)
  803. select {
  804. case err := <-errc:
  805. if checkErr != nil {
  806. checkErr(err)
  807. }
  808. case <-time.After(5 * time.Second):
  809. t.Fatal("timeout waiting for Handler to return")
  810. }
  811. st.Close()
  812. }
  813. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  814. testServerPostUnblock(t,
  815. func(w http.ResponseWriter, r *http.Request) (err error) {
  816. _, err = r.Body.Read(make([]byte, 1))
  817. return
  818. },
  819. func(st *serverTester) {
  820. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  821. t.Fatal(err)
  822. }
  823. },
  824. func(err error) {
  825. if err == nil {
  826. t.Error("unexpected nil error from Request.Body.Read")
  827. }
  828. },
  829. )
  830. }
  831. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  832. testServerPostUnblock(t,
  833. func(w http.ResponseWriter, r *http.Request) (err error) {
  834. _, err = r.Body.Read(make([]byte, 1))
  835. return
  836. },
  837. func(st *serverTester) { st.cc.Close() },
  838. func(err error) {
  839. if err == nil {
  840. t.Error("unexpected nil error from Request.Body.Read")
  841. }
  842. },
  843. )
  844. }
  845. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  846. <-w.(http.CloseNotifier).CloseNotify()
  847. return nil
  848. }
  849. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  850. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  851. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  852. t.Fatal(err)
  853. }
  854. }, nil)
  855. }
  856. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  857. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  858. }
  859. // that CloseNotify unblocks after a stream error due to the client's
  860. // problem that's unrelated to them explicitly canceling it (which is
  861. // TestServer_CloseNotify_After_RSTStream above)
  862. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  863. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  864. // data longer than declared Content-Length => stream error
  865. st.writeData(1, true, []byte("1234"))
  866. }, nil, "content-length", "3")
  867. }
  868. func TestServer_StateTransitions(t *testing.T) {
  869. var st *serverTester
  870. inHandler := make(chan bool)
  871. writeData := make(chan bool)
  872. leaveHandler := make(chan bool)
  873. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  874. inHandler <- true
  875. if st.stream(1) == nil {
  876. t.Errorf("nil stream 1 in handler")
  877. }
  878. if got, want := st.streamState(1), stateOpen; got != want {
  879. t.Errorf("in handler, state is %v; want %v", got, want)
  880. }
  881. writeData <- true
  882. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  883. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  884. }
  885. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  886. t.Errorf("in handler, state is %v; want %v", got, want)
  887. }
  888. <-leaveHandler
  889. })
  890. st.greet()
  891. if st.stream(1) != nil {
  892. t.Fatal("stream 1 should be empty")
  893. }
  894. if got := st.streamState(1); got != stateIdle {
  895. t.Fatalf("stream 1 should be idle; got %v", got)
  896. }
  897. st.writeHeaders(HeadersFrameParam{
  898. StreamID: 1,
  899. BlockFragment: encodeHeader(st.t, ":method", "POST"),
  900. EndStream: false, // keep it open
  901. EndHeaders: true,
  902. })
  903. <-inHandler
  904. <-writeData
  905. st.writeData(1, true, nil)
  906. leaveHandler <- true
  907. hf := st.wantHeaders()
  908. if !hf.StreamEnded() {
  909. t.Fatal("expected END_STREAM flag")
  910. }
  911. if got, want := st.streamState(1), stateClosed; got != want {
  912. t.Errorf("at end, state is %v; want %v", got, want)
  913. }
  914. if st.stream(1) != nil {
  915. t.Fatal("at end, stream 1 should be gone")
  916. }
  917. }
  918. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  919. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  920. testServerRejects(t, func(st *serverTester) {
  921. st.writeHeaders(HeadersFrameParam{
  922. StreamID: 1,
  923. BlockFragment: encodeHeader(st.t),
  924. EndStream: true,
  925. EndHeaders: false,
  926. })
  927. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  928. StreamID: 3, // different stream.
  929. BlockFragment: encodeHeader(st.t),
  930. EndStream: true,
  931. EndHeaders: true,
  932. })
  933. })
  934. }
  935. // test HEADERS w/o EndHeaders + PING (should get rejected)
  936. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  937. testServerRejects(t, func(st *serverTester) {
  938. st.writeHeaders(HeadersFrameParam{
  939. StreamID: 1,
  940. BlockFragment: encodeHeader(st.t),
  941. EndStream: true,
  942. EndHeaders: false,
  943. })
  944. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  945. t.Fatal(err)
  946. }
  947. })
  948. }
  949. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  950. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  951. testServerRejects(t, func(st *serverTester) {
  952. st.writeHeaders(HeadersFrameParam{
  953. StreamID: 1,
  954. BlockFragment: encodeHeader(st.t),
  955. EndStream: true,
  956. EndHeaders: true,
  957. })
  958. st.wantHeaders()
  959. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  960. t.Fatal(err)
  961. }
  962. })
  963. }
  964. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  965. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  966. testServerRejects(t, func(st *serverTester) {
  967. st.writeHeaders(HeadersFrameParam{
  968. StreamID: 1,
  969. BlockFragment: encodeHeader(st.t),
  970. EndStream: true,
  971. EndHeaders: false,
  972. })
  973. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  974. t.Fatal(err)
  975. }
  976. })
  977. }
  978. // No HEADERS on stream 0.
  979. func TestServer_Rejects_Headers0(t *testing.T) {
  980. testServerRejects(t, func(st *serverTester) {
  981. st.fr.AllowIllegalWrites = true
  982. st.writeHeaders(HeadersFrameParam{
  983. StreamID: 0,
  984. BlockFragment: encodeHeader(st.t),
  985. EndStream: true,
  986. EndHeaders: true,
  987. })
  988. })
  989. }
  990. // No CONTINUATION on stream 0.
  991. func TestServer_Rejects_Continuation0(t *testing.T) {
  992. testServerRejects(t, func(st *serverTester) {
  993. st.fr.AllowIllegalWrites = true
  994. if err := st.fr.WriteContinuation(0, true, encodeHeader(t)); err != nil {
  995. t.Fatal(err)
  996. }
  997. })
  998. }
  999. // testServerRejects tests that the server hangs up with a GOAWAY
  1000. // frame and a server close after the client does something
  1001. // deserving a CONNECTION_ERROR.
  1002. func testServerRejects(t *testing.T, writeReq func(*serverTester)) {
  1003. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1004. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1005. defer st.Close()
  1006. st.greet()
  1007. writeReq(st)
  1008. st.wantGoAway()
  1009. errc := make(chan error, 1)
  1010. go func() {
  1011. fr, err := st.fr.ReadFrame()
  1012. if err == nil {
  1013. err = fmt.Errorf("got frame of type %T", fr)
  1014. }
  1015. errc <- err
  1016. }()
  1017. select {
  1018. case err := <-errc:
  1019. if err != io.EOF {
  1020. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1021. }
  1022. case <-time.After(2 * time.Second):
  1023. t.Error("timeout waiting for disconnect")
  1024. }
  1025. }
  1026. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1027. // write a single request with writeReq, and then verify that the
  1028. // *http.Request is built correctly in checkReq.
  1029. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1030. gotReq := make(chan bool, 1)
  1031. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1032. if r.Body == nil {
  1033. t.Fatal("nil Body")
  1034. }
  1035. checkReq(r)
  1036. gotReq <- true
  1037. })
  1038. defer st.Close()
  1039. st.greet()
  1040. writeReq(st)
  1041. select {
  1042. case <-gotReq:
  1043. case <-time.After(2 * time.Second):
  1044. t.Error("timeout waiting for request")
  1045. }
  1046. }
  1047. func getSlash(st *serverTester) { st.bodylessReq1() }
  1048. func TestServer_Response_NoData(t *testing.T) {
  1049. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1050. // Nothing.
  1051. return nil
  1052. }, func(st *serverTester) {
  1053. getSlash(st)
  1054. hf := st.wantHeaders()
  1055. if !hf.StreamEnded() {
  1056. t.Fatal("want END_STREAM flag")
  1057. }
  1058. if !hf.HeadersEnded() {
  1059. t.Fatal("want END_HEADERS flag")
  1060. }
  1061. })
  1062. }
  1063. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1064. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1065. w.Header().Set("Foo-Bar", "some-value")
  1066. return nil
  1067. }, func(st *serverTester) {
  1068. getSlash(st)
  1069. hf := st.wantHeaders()
  1070. if !hf.StreamEnded() {
  1071. t.Fatal("want END_STREAM flag")
  1072. }
  1073. if !hf.HeadersEnded() {
  1074. t.Fatal("want END_HEADERS flag")
  1075. }
  1076. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1077. wanth := [][2]string{
  1078. {":status", "200"},
  1079. {"foo-bar", "some-value"},
  1080. {"content-type", "text/plain; charset=utf-8"},
  1081. {"content-length", "0"},
  1082. }
  1083. if !reflect.DeepEqual(goth, wanth) {
  1084. t.Errorf("Got headers %v; want %v", goth, wanth)
  1085. }
  1086. })
  1087. }
  1088. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1089. const msg = "<html>this is HTML."
  1090. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1091. w.Header().Set("Content-Type", "foo/bar")
  1092. io.WriteString(w, msg)
  1093. return nil
  1094. }, func(st *serverTester) {
  1095. getSlash(st)
  1096. hf := st.wantHeaders()
  1097. if hf.StreamEnded() {
  1098. t.Fatal("don't want END_STREAM, expecting data")
  1099. }
  1100. if !hf.HeadersEnded() {
  1101. t.Fatal("want END_HEADERS flag")
  1102. }
  1103. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1104. wanth := [][2]string{
  1105. {":status", "200"},
  1106. {"content-type", "foo/bar"},
  1107. {"content-length", strconv.Itoa(len(msg))},
  1108. }
  1109. if !reflect.DeepEqual(goth, wanth) {
  1110. t.Errorf("Got headers %v; want %v", goth, wanth)
  1111. }
  1112. df := st.wantData()
  1113. if !df.StreamEnded() {
  1114. t.Error("expected DATA to have END_STREAM flag")
  1115. }
  1116. if got := string(df.Data()); got != msg {
  1117. t.Errorf("got DATA %q; want %q", got, msg)
  1118. }
  1119. })
  1120. }
  1121. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1122. const msg = "hi"
  1123. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1124. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1125. io.WriteString(w, msg)
  1126. return nil
  1127. }, func(st *serverTester) {
  1128. getSlash(st)
  1129. hf := st.wantHeaders()
  1130. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1131. wanth := [][2]string{
  1132. {":status", "200"},
  1133. {"content-type", "text/plain; charset=utf-8"},
  1134. {"content-length", strconv.Itoa(len(msg))},
  1135. }
  1136. if !reflect.DeepEqual(goth, wanth) {
  1137. t.Errorf("Got headers %v; want %v", goth, wanth)
  1138. }
  1139. })
  1140. }
  1141. // Header accessed only after the initial write.
  1142. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1143. const msg = "<html>this is HTML."
  1144. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1145. io.WriteString(w, msg)
  1146. w.Header().Set("foo", "should be ignored")
  1147. return nil
  1148. }, func(st *serverTester) {
  1149. getSlash(st)
  1150. hf := st.wantHeaders()
  1151. if hf.StreamEnded() {
  1152. t.Fatal("unexpected END_STREAM")
  1153. }
  1154. if !hf.HeadersEnded() {
  1155. t.Fatal("want END_HEADERS flag")
  1156. }
  1157. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1158. wanth := [][2]string{
  1159. {":status", "200"},
  1160. {"content-type", "text/html; charset=utf-8"},
  1161. {"content-length", strconv.Itoa(len(msg))},
  1162. }
  1163. if !reflect.DeepEqual(goth, wanth) {
  1164. t.Errorf("Got headers %v; want %v", goth, wanth)
  1165. }
  1166. })
  1167. }
  1168. // Header accessed before the initial write and later mutated.
  1169. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1170. const msg = "<html>this is HTML."
  1171. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1172. w.Header().Set("foo", "proper value")
  1173. io.WriteString(w, msg)
  1174. w.Header().Set("foo", "should be ignored")
  1175. return nil
  1176. }, func(st *serverTester) {
  1177. getSlash(st)
  1178. hf := st.wantHeaders()
  1179. if hf.StreamEnded() {
  1180. t.Fatal("unexpected END_STREAM")
  1181. }
  1182. if !hf.HeadersEnded() {
  1183. t.Fatal("want END_HEADERS flag")
  1184. }
  1185. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1186. wanth := [][2]string{
  1187. {":status", "200"},
  1188. {"foo", "proper value"},
  1189. {"content-type", "text/html; charset=utf-8"},
  1190. {"content-length", strconv.Itoa(len(msg))},
  1191. }
  1192. if !reflect.DeepEqual(goth, wanth) {
  1193. t.Errorf("Got headers %v; want %v", goth, wanth)
  1194. }
  1195. })
  1196. }
  1197. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1198. const msg = "<html>this is HTML."
  1199. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1200. io.WriteString(w, msg)
  1201. return nil
  1202. }, func(st *serverTester) {
  1203. getSlash(st)
  1204. hf := st.wantHeaders()
  1205. if hf.StreamEnded() {
  1206. t.Fatal("don't want END_STREAM, expecting data")
  1207. }
  1208. if !hf.HeadersEnded() {
  1209. t.Fatal("want END_HEADERS flag")
  1210. }
  1211. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1212. wanth := [][2]string{
  1213. {":status", "200"},
  1214. {"content-type", "text/html; charset=utf-8"},
  1215. {"content-length", strconv.Itoa(len(msg))},
  1216. }
  1217. if !reflect.DeepEqual(goth, wanth) {
  1218. t.Errorf("Got headers %v; want %v", goth, wanth)
  1219. }
  1220. df := st.wantData()
  1221. if !df.StreamEnded() {
  1222. t.Error("expected DATA to have END_STREAM flag")
  1223. }
  1224. if got := string(df.Data()); got != msg {
  1225. t.Errorf("got DATA %q; want %q", got, msg)
  1226. }
  1227. })
  1228. }
  1229. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1230. const msg = "<html>this is HTML"
  1231. const msg2 = ", and this is the next chunk"
  1232. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1233. io.WriteString(w, msg)
  1234. w.(http.Flusher).Flush()
  1235. io.WriteString(w, msg2)
  1236. return nil
  1237. }, func(st *serverTester) {
  1238. getSlash(st)
  1239. hf := st.wantHeaders()
  1240. if hf.StreamEnded() {
  1241. t.Fatal("unexpected END_STREAM flag")
  1242. }
  1243. if !hf.HeadersEnded() {
  1244. t.Fatal("want END_HEADERS flag")
  1245. }
  1246. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1247. wanth := [][2]string{
  1248. {":status", "200"},
  1249. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1250. // and no content-length
  1251. }
  1252. if !reflect.DeepEqual(goth, wanth) {
  1253. t.Errorf("Got headers %v; want %v", goth, wanth)
  1254. }
  1255. {
  1256. df := st.wantData()
  1257. if df.StreamEnded() {
  1258. t.Error("unexpected END_STREAM flag")
  1259. }
  1260. if got := string(df.Data()); got != msg {
  1261. t.Errorf("got DATA %q; want %q", got, msg)
  1262. }
  1263. }
  1264. {
  1265. df := st.wantData()
  1266. if !df.StreamEnded() {
  1267. t.Error("wanted END_STREAM flag on last data chunk")
  1268. }
  1269. if got := string(df.Data()); got != msg2 {
  1270. t.Errorf("got DATA %q; want %q", got, msg2)
  1271. }
  1272. }
  1273. })
  1274. }
  1275. func TestServer_Response_LargeWrite(t *testing.T) {
  1276. const size = 1 << 20
  1277. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1278. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1279. if err != nil {
  1280. return fmt.Errorf("Write error: %v", err)
  1281. }
  1282. if n != size {
  1283. return fmt.Errorf("wrong size %d from Write", n)
  1284. }
  1285. return nil
  1286. }, func(st *serverTester) {
  1287. getSlash(st) // make the single request
  1288. // Give the handler quota to write:
  1289. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1290. t.Fatal(err)
  1291. }
  1292. hf := st.wantHeaders()
  1293. if hf.StreamEnded() {
  1294. t.Fatal("unexpected END_STREAM flag")
  1295. }
  1296. if !hf.HeadersEnded() {
  1297. t.Fatal("want END_HEADERS flag")
  1298. }
  1299. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1300. wanth := [][2]string{
  1301. {":status", "200"},
  1302. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1303. // and no content-length
  1304. }
  1305. if !reflect.DeepEqual(goth, wanth) {
  1306. t.Errorf("Got headers %v; want %v", goth, wanth)
  1307. }
  1308. var bytes, frames int
  1309. for {
  1310. df := st.wantData()
  1311. bytes += len(df.Data())
  1312. frames++
  1313. for _, b := range df.Data() {
  1314. if b != 'a' {
  1315. t.Fatal("non-'a' byte seen in DATA")
  1316. }
  1317. }
  1318. if df.StreamEnded() {
  1319. break
  1320. }
  1321. }
  1322. if bytes != size {
  1323. t.Errorf("Got %d bytes; want %d", bytes, size)
  1324. }
  1325. if want := 257; frames != want {
  1326. t.Errorf("Got %d frames; want %d", frames, size)
  1327. }
  1328. })
  1329. }
  1330. // Test that the handler can't write more than the client allows
  1331. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1332. const size = 1 << 20
  1333. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1334. w.(http.Flusher).Flush()
  1335. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1336. if err != nil {
  1337. return fmt.Errorf("Write error: %v", err)
  1338. }
  1339. if n != size {
  1340. return fmt.Errorf("wrong size %d from Write", n)
  1341. }
  1342. return nil
  1343. }, func(st *serverTester) {
  1344. // Set the window size to something explicit for this test.
  1345. // It's also how much initial data we expect.
  1346. const initWindowSize = 123
  1347. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, initWindowSize}); err != nil {
  1348. t.Fatal(err)
  1349. }
  1350. st.wantSettingsAck()
  1351. getSlash(st) // make the single request
  1352. defer func() { st.fr.WriteRSTStream(1, ErrCodeCancel) }()
  1353. hf := st.wantHeaders()
  1354. if hf.StreamEnded() {
  1355. t.Fatal("unexpected END_STREAM flag")
  1356. }
  1357. if !hf.HeadersEnded() {
  1358. t.Fatal("want END_HEADERS flag")
  1359. }
  1360. df := st.wantData()
  1361. if got := len(df.Data()); got != initWindowSize {
  1362. t.Fatalf("Initial window size = %d but got DATA with %d bytes", initWindowSize, got)
  1363. }
  1364. for _, quota := range []int{1, 13, 127} {
  1365. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1366. t.Fatal(err)
  1367. }
  1368. df := st.wantData()
  1369. if int(quota) != len(df.Data()) {
  1370. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1371. }
  1372. }
  1373. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1374. t.Fatal(err)
  1375. }
  1376. })
  1377. }
  1378. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1379. const msg = "foo"
  1380. const reply = "bar"
  1381. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1382. if v := r.Header.Get("Expect"); v != "" {
  1383. t.Errorf("Expect header = %q; want empty", v)
  1384. }
  1385. buf := make([]byte, len(msg))
  1386. // This read should trigger the 100-continue being sent.
  1387. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1388. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1389. }
  1390. _, err := io.WriteString(w, reply)
  1391. return err
  1392. }, func(st *serverTester) {
  1393. st.writeHeaders(HeadersFrameParam{
  1394. StreamID: 1, // clients send odd numbers
  1395. BlockFragment: encodeHeader(st.t, ":method", "POST", "expect", "100-continue"),
  1396. EndStream: false,
  1397. EndHeaders: true,
  1398. })
  1399. hf := st.wantHeaders()
  1400. if hf.StreamEnded() {
  1401. t.Fatal("unexpected END_STREAM flag")
  1402. }
  1403. if !hf.HeadersEnded() {
  1404. t.Fatal("want END_HEADERS flag")
  1405. }
  1406. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1407. wanth := [][2]string{
  1408. {":status", "100"},
  1409. }
  1410. if !reflect.DeepEqual(goth, wanth) {
  1411. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1412. }
  1413. // Okay, they sent status 100, so we can send our
  1414. // gigantic and/or sensitive "foo" payload now.
  1415. st.writeData(1, true, []byte(msg))
  1416. st.wantWindowUpdate(0, uint32(len(msg)))
  1417. st.wantWindowUpdate(1, uint32(len(msg)))
  1418. hf = st.wantHeaders()
  1419. if hf.StreamEnded() {
  1420. t.Fatal("expected data to follow")
  1421. }
  1422. if !hf.HeadersEnded() {
  1423. t.Fatal("want END_HEADERS flag")
  1424. }
  1425. goth = decodeHeader(t, hf.HeaderBlockFragment())
  1426. wanth = [][2]string{
  1427. {":status", "200"},
  1428. {"content-type", "text/plain; charset=utf-8"},
  1429. {"content-length", strconv.Itoa(len(reply))},
  1430. }
  1431. if !reflect.DeepEqual(goth, wanth) {
  1432. t.Errorf("Got headers %v; want %v", goth, wanth)
  1433. }
  1434. df := st.wantData()
  1435. if string(df.Data()) != reply {
  1436. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1437. }
  1438. if !df.StreamEnded() {
  1439. t.Errorf("expect data stream end")
  1440. }
  1441. })
  1442. }
  1443. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1444. errc := make(chan error, 1)
  1445. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1446. p := []byte("some data.\n")
  1447. for {
  1448. _, err := w.Write(p)
  1449. if err != nil {
  1450. errc <- err
  1451. return nil
  1452. }
  1453. }
  1454. }, func(st *serverTester) {
  1455. st.writeHeaders(HeadersFrameParam{
  1456. StreamID: 1,
  1457. BlockFragment: encodeHeader(st.t),
  1458. EndStream: false,
  1459. EndHeaders: true,
  1460. })
  1461. hf := st.wantHeaders()
  1462. if hf.StreamEnded() {
  1463. t.Fatal("unexpected END_STREAM flag")
  1464. }
  1465. if !hf.HeadersEnded() {
  1466. t.Fatal("want END_HEADERS flag")
  1467. }
  1468. // Close the connection and wait for the handler to (hopefully) notice.
  1469. st.cc.Close()
  1470. select {
  1471. case <-errc:
  1472. case <-time.After(5 * time.Second):
  1473. t.Error("timeout")
  1474. }
  1475. })
  1476. }
  1477. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1478. const testPath = "/some/path"
  1479. inHandler := make(chan uint32)
  1480. leaveHandler := make(chan bool)
  1481. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1482. id := w.(*responseWriter).rws.stream.id
  1483. inHandler <- id
  1484. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1485. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1486. }
  1487. <-leaveHandler
  1488. })
  1489. defer st.Close()
  1490. st.greet()
  1491. nextStreamID := uint32(1)
  1492. streamID := func() uint32 {
  1493. defer func() { nextStreamID += 2 }()
  1494. return nextStreamID
  1495. }
  1496. sendReq := func(id uint32, headers ...string) {
  1497. st.writeHeaders(HeadersFrameParam{
  1498. StreamID: id,
  1499. BlockFragment: encodeHeader(st.t, headers...),
  1500. EndStream: true,
  1501. EndHeaders: true,
  1502. })
  1503. }
  1504. for i := 0; i < defaultMaxStreams; i++ {
  1505. sendReq(streamID())
  1506. <-inHandler
  1507. }
  1508. defer func() {
  1509. for i := 0; i < defaultMaxStreams; i++ {
  1510. leaveHandler <- true
  1511. }
  1512. }()
  1513. // And this one should cross the limit:
  1514. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  1515. // even if we're rejecting it)
  1516. rejectID := streamID()
  1517. headerBlock := encodeHeader(st.t, ":path", testPath)
  1518. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  1519. st.writeHeaders(HeadersFrameParam{
  1520. StreamID: rejectID,
  1521. BlockFragment: frag1,
  1522. EndStream: true,
  1523. EndHeaders: false, // CONTINUATION coming
  1524. })
  1525. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  1526. t.Fatal(err)
  1527. }
  1528. st.wantRSTStream(rejectID, ErrCodeProtocol)
  1529. // But let a handler finish:
  1530. leaveHandler <- true
  1531. st.wantHeaders()
  1532. // And now another stream should be able to start:
  1533. goodID := streamID()
  1534. sendReq(goodID, ":path", testPath)
  1535. select {
  1536. case got := <-inHandler:
  1537. if got != goodID {
  1538. t.Errorf("Got stream %d; want %d", got, goodID)
  1539. }
  1540. case <-time.After(3 * time.Second):
  1541. t.Error("timeout waiting for handler")
  1542. }
  1543. }
  1544. // So many response headers that the server needs to use CONTINUATION frames:
  1545. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  1546. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1547. h := w.Header()
  1548. for i := 0; i < 5000; i++ {
  1549. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  1550. }
  1551. return nil
  1552. }, func(st *serverTester) {
  1553. getSlash(st)
  1554. hf := st.wantHeaders()
  1555. if hf.HeadersEnded() {
  1556. t.Fatal("got unwanted END_HEADERS flag")
  1557. }
  1558. n := 0
  1559. for {
  1560. n++
  1561. cf := st.wantContinuation()
  1562. if cf.HeadersEnded() {
  1563. break
  1564. }
  1565. }
  1566. if n < 5 {
  1567. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)")
  1568. }
  1569. })
  1570. }
  1571. func decodeHeader(t *testing.T, headerBlock []byte) (pairs [][2]string) {
  1572. d := hpack.NewDecoder(initialHeaderTableSize, func(f hpack.HeaderField) {
  1573. pairs = append(pairs, [2]string{f.Name, f.Value})
  1574. })
  1575. if _, err := d.Write(headerBlock); err != nil {
  1576. t.Fatalf("hpack decoding error: %v", err)
  1577. }
  1578. if err := d.Close(); err != nil {
  1579. t.Fatalf("hpack decoding error: %v", err)
  1580. }
  1581. return
  1582. }
  1583. // testServerResponse sets up an idle HTTP/2 connection and lets you
  1584. // write a single request with writeReq, and then reply to it in some way with the provided handler,
  1585. // and then verify the output with the serverTester again (assuming the handler returns nil)
  1586. func testServerResponse(t *testing.T,
  1587. handler func(http.ResponseWriter, *http.Request) error,
  1588. client func(*serverTester),
  1589. ) {
  1590. errc := make(chan error, 1)
  1591. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1592. if r.Body == nil {
  1593. t.Fatal("nil Body")
  1594. }
  1595. errc <- handler(w, r)
  1596. })
  1597. defer st.Close()
  1598. donec := make(chan bool)
  1599. go func() {
  1600. defer close(donec)
  1601. st.greet()
  1602. client(st)
  1603. }()
  1604. select {
  1605. case <-donec:
  1606. return
  1607. case <-time.After(5 * time.Second):
  1608. t.Fatal("timeout")
  1609. }
  1610. select {
  1611. case err := <-errc:
  1612. if err != nil {
  1613. t.Fatalf("Error in handler: %v", err)
  1614. }
  1615. case <-time.After(2 * time.Second):
  1616. t.Error("timeout waiting for handler to finish")
  1617. }
  1618. }
  1619. func TestServerWithCurl(t *testing.T) {
  1620. if runtime.GOOS == "darwin" {
  1621. t.Skip("skipping Docker test on Darwin; requires --net which won't work with boot2docker anyway")
  1622. }
  1623. requireCurl(t)
  1624. const msg = "Hello from curl!\n"
  1625. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  1626. w.Header().Set("Foo", "Bar")
  1627. io.WriteString(w, msg)
  1628. }))
  1629. ConfigureServer(ts.Config, &Server{})
  1630. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  1631. ts.StartTLS()
  1632. defer ts.Close()
  1633. var gotConn int32
  1634. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  1635. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  1636. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  1637. defer kill(container)
  1638. resc := make(chan interface{}, 1)
  1639. go func() {
  1640. res, err := dockerLogs(container)
  1641. if err != nil {
  1642. resc <- err
  1643. } else {
  1644. resc <- res
  1645. }
  1646. }()
  1647. select {
  1648. case res := <-resc:
  1649. if err, ok := res.(error); ok {
  1650. t.Fatal(err)
  1651. }
  1652. if !strings.Contains(string(res.([]byte)), "< foo:Bar") {
  1653. t.Errorf("didn't see foo:Bar header")
  1654. t.Logf("Got: %s", res)
  1655. }
  1656. if !strings.Contains(string(res.([]byte)), msg) {
  1657. t.Errorf("didn't see %q content", msg)
  1658. t.Logf("Got: %s", res)
  1659. }
  1660. case <-time.After(3 * time.Second):
  1661. t.Errorf("timeout waiting for curl")
  1662. }
  1663. if atomic.LoadInt32(&gotConn) == 0 {
  1664. t.Error("never saw an http2 connection")
  1665. }
  1666. }