transport_test.go 112 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "context"
  9. "crypto/tls"
  10. "errors"
  11. "flag"
  12. "fmt"
  13. "io"
  14. "io/ioutil"
  15. "log"
  16. "math/rand"
  17. "net"
  18. "net/http"
  19. "net/http/httptest"
  20. "net/http/httptrace"
  21. "net/textproto"
  22. "net/url"
  23. "os"
  24. "reflect"
  25. "runtime"
  26. "sort"
  27. "strconv"
  28. "strings"
  29. "sync"
  30. "sync/atomic"
  31. "testing"
  32. "time"
  33. "golang.org/x/net/http2/hpack"
  34. )
  35. var (
  36. extNet = flag.Bool("extnet", false, "do external network tests")
  37. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  38. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  39. )
  40. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  41. var canceledCtx context.Context
  42. func init() {
  43. ctx, cancel := context.WithCancel(context.Background())
  44. cancel()
  45. canceledCtx = ctx
  46. }
  47. func TestTransportExternal(t *testing.T) {
  48. if !*extNet {
  49. t.Skip("skipping external network test")
  50. }
  51. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  52. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  53. res, err := rt.RoundTrip(req)
  54. if err != nil {
  55. t.Fatalf("%v", err)
  56. }
  57. res.Write(os.Stdout)
  58. }
  59. type fakeTLSConn struct {
  60. net.Conn
  61. }
  62. func (c *fakeTLSConn) ConnectionState() tls.ConnectionState {
  63. return tls.ConnectionState{
  64. Version: tls.VersionTLS12,
  65. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  66. }
  67. }
  68. func startH2cServer(t *testing.T) net.Listener {
  69. h2Server := &Server{}
  70. l := newLocalListener(t)
  71. go func() {
  72. conn, err := l.Accept()
  73. if err != nil {
  74. t.Error(err)
  75. return
  76. }
  77. h2Server.ServeConn(&fakeTLSConn{conn}, &ServeConnOpts{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  78. fmt.Fprintf(w, "Hello, %v, http: %v", r.URL.Path, r.TLS == nil)
  79. })})
  80. }()
  81. return l
  82. }
  83. func TestTransportH2c(t *testing.T) {
  84. l := startH2cServer(t)
  85. defer l.Close()
  86. req, err := http.NewRequest("GET", "http://"+l.Addr().String()+"/foobar", nil)
  87. if err != nil {
  88. t.Fatal(err)
  89. }
  90. var gotConnCnt int32
  91. trace := &httptrace.ClientTrace{
  92. GotConn: func(connInfo httptrace.GotConnInfo) {
  93. if !connInfo.Reused {
  94. atomic.AddInt32(&gotConnCnt, 1)
  95. }
  96. },
  97. }
  98. req = req.WithContext(httptrace.WithClientTrace(req.Context(), trace))
  99. tr := &Transport{
  100. AllowHTTP: true,
  101. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  102. return net.Dial(network, addr)
  103. },
  104. }
  105. res, err := tr.RoundTrip(req)
  106. if err != nil {
  107. t.Fatal(err)
  108. }
  109. if res.ProtoMajor != 2 {
  110. t.Fatal("proto not h2c")
  111. }
  112. body, err := ioutil.ReadAll(res.Body)
  113. if err != nil {
  114. t.Fatal(err)
  115. }
  116. if got, want := string(body), "Hello, /foobar, http: true"; got != want {
  117. t.Fatalf("response got %v, want %v", got, want)
  118. }
  119. if got, want := gotConnCnt, int32(1); got != want {
  120. t.Errorf("Too many got connections: %d", gotConnCnt)
  121. }
  122. }
  123. func TestTransport(t *testing.T) {
  124. const body = "sup"
  125. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  126. io.WriteString(w, body)
  127. }, optOnlyServer)
  128. defer st.Close()
  129. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  130. defer tr.CloseIdleConnections()
  131. u, err := url.Parse(st.ts.URL)
  132. if err != nil {
  133. t.Fatal(err)
  134. }
  135. for i, m := range []string{"GET", ""} {
  136. req := &http.Request{
  137. Method: m,
  138. URL: u,
  139. }
  140. res, err := tr.RoundTrip(req)
  141. if err != nil {
  142. t.Fatalf("%d: %s", i, err)
  143. }
  144. t.Logf("%d: Got res: %+v", i, res)
  145. if g, w := res.StatusCode, 200; g != w {
  146. t.Errorf("%d: StatusCode = %v; want %v", i, g, w)
  147. }
  148. if g, w := res.Status, "200 OK"; g != w {
  149. t.Errorf("%d: Status = %q; want %q", i, g, w)
  150. }
  151. wantHeader := http.Header{
  152. "Content-Length": []string{"3"},
  153. "Content-Type": []string{"text/plain; charset=utf-8"},
  154. "Date": []string{"XXX"}, // see cleanDate
  155. }
  156. cleanDate(res)
  157. if !reflect.DeepEqual(res.Header, wantHeader) {
  158. t.Errorf("%d: res Header = %v; want %v", i, res.Header, wantHeader)
  159. }
  160. if res.Request != req {
  161. t.Errorf("%d: Response.Request = %p; want %p", i, res.Request, req)
  162. }
  163. if res.TLS == nil {
  164. t.Errorf("%d: Response.TLS = nil; want non-nil", i)
  165. }
  166. slurp, err := ioutil.ReadAll(res.Body)
  167. if err != nil {
  168. t.Errorf("%d: Body read: %v", i, err)
  169. } else if string(slurp) != body {
  170. t.Errorf("%d: Body = %q; want %q", i, slurp, body)
  171. }
  172. res.Body.Close()
  173. }
  174. }
  175. func onSameConn(t *testing.T, modReq func(*http.Request)) bool {
  176. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  177. io.WriteString(w, r.RemoteAddr)
  178. }, optOnlyServer, func(c net.Conn, st http.ConnState) {
  179. t.Logf("conn %v is now state %v", c.RemoteAddr(), st)
  180. })
  181. defer st.Close()
  182. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  183. defer tr.CloseIdleConnections()
  184. get := func() string {
  185. req, err := http.NewRequest("GET", st.ts.URL, nil)
  186. if err != nil {
  187. t.Fatal(err)
  188. }
  189. modReq(req)
  190. res, err := tr.RoundTrip(req)
  191. if err != nil {
  192. t.Fatal(err)
  193. }
  194. defer res.Body.Close()
  195. slurp, err := ioutil.ReadAll(res.Body)
  196. if err != nil {
  197. t.Fatalf("Body read: %v", err)
  198. }
  199. addr := strings.TrimSpace(string(slurp))
  200. if addr == "" {
  201. t.Fatalf("didn't get an addr in response")
  202. }
  203. return addr
  204. }
  205. first := get()
  206. second := get()
  207. return first == second
  208. }
  209. func TestTransportReusesConns(t *testing.T) {
  210. if !onSameConn(t, func(*http.Request) {}) {
  211. t.Errorf("first and second responses were on different connections")
  212. }
  213. }
  214. func TestTransportReusesConn_RequestClose(t *testing.T) {
  215. if onSameConn(t, func(r *http.Request) { r.Close = true }) {
  216. t.Errorf("first and second responses were not on different connections")
  217. }
  218. }
  219. func TestTransportReusesConn_ConnClose(t *testing.T) {
  220. if onSameConn(t, func(r *http.Request) { r.Header.Set("Connection", "close") }) {
  221. t.Errorf("first and second responses were not on different connections")
  222. }
  223. }
  224. // Tests that the Transport only keeps one pending dial open per destination address.
  225. // https://golang.org/issue/13397
  226. func TestTransportGroupsPendingDials(t *testing.T) {
  227. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  228. io.WriteString(w, r.RemoteAddr)
  229. }, optOnlyServer)
  230. defer st.Close()
  231. tr := &Transport{
  232. TLSClientConfig: tlsConfigInsecure,
  233. }
  234. defer tr.CloseIdleConnections()
  235. var (
  236. mu sync.Mutex
  237. dials = map[string]int{}
  238. )
  239. var gotConnCnt int32
  240. trace := &httptrace.ClientTrace{
  241. GotConn: func(connInfo httptrace.GotConnInfo) {
  242. if !connInfo.Reused {
  243. atomic.AddInt32(&gotConnCnt, 1)
  244. }
  245. },
  246. }
  247. var wg sync.WaitGroup
  248. for i := 0; i < 10; i++ {
  249. wg.Add(1)
  250. go func() {
  251. defer wg.Done()
  252. req, err := http.NewRequest("GET", st.ts.URL, nil)
  253. if err != nil {
  254. t.Error(err)
  255. return
  256. }
  257. req = req.WithContext(httptrace.WithClientTrace(req.Context(), trace))
  258. res, err := tr.RoundTrip(req)
  259. if err != nil {
  260. t.Error(err)
  261. return
  262. }
  263. defer res.Body.Close()
  264. slurp, err := ioutil.ReadAll(res.Body)
  265. if err != nil {
  266. t.Errorf("Body read: %v", err)
  267. }
  268. addr := strings.TrimSpace(string(slurp))
  269. if addr == "" {
  270. t.Errorf("didn't get an addr in response")
  271. }
  272. mu.Lock()
  273. dials[addr]++
  274. mu.Unlock()
  275. }()
  276. }
  277. wg.Wait()
  278. if len(dials) != 1 {
  279. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  280. }
  281. tr.CloseIdleConnections()
  282. if err := retry(50, 10*time.Millisecond, func() error {
  283. cp, ok := tr.connPool().(*clientConnPool)
  284. if !ok {
  285. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  286. }
  287. cp.mu.Lock()
  288. defer cp.mu.Unlock()
  289. if len(cp.dialing) != 0 {
  290. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  291. }
  292. if len(cp.conns) != 0 {
  293. return fmt.Errorf("conns = %v; want empty", cp.conns)
  294. }
  295. if len(cp.keys) != 0 {
  296. return fmt.Errorf("keys = %v; want empty", cp.keys)
  297. }
  298. return nil
  299. }); err != nil {
  300. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  301. }
  302. if got, want := gotConnCnt, int32(1); got != want {
  303. t.Errorf("Too many got connections: %d", gotConnCnt)
  304. }
  305. }
  306. func retry(tries int, delay time.Duration, fn func() error) error {
  307. var err error
  308. for i := 0; i < tries; i++ {
  309. err = fn()
  310. if err == nil {
  311. return nil
  312. }
  313. time.Sleep(delay)
  314. }
  315. return err
  316. }
  317. func TestTransportAbortClosesPipes(t *testing.T) {
  318. shutdown := make(chan struct{})
  319. st := newServerTester(t,
  320. func(w http.ResponseWriter, r *http.Request) {
  321. w.(http.Flusher).Flush()
  322. <-shutdown
  323. },
  324. optOnlyServer,
  325. )
  326. defer st.Close()
  327. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  328. done := make(chan struct{})
  329. requestMade := make(chan struct{})
  330. go func() {
  331. defer close(done)
  332. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  333. req, err := http.NewRequest("GET", st.ts.URL, nil)
  334. if err != nil {
  335. t.Fatal(err)
  336. }
  337. res, err := tr.RoundTrip(req)
  338. if err != nil {
  339. t.Fatal(err)
  340. }
  341. defer res.Body.Close()
  342. close(requestMade)
  343. _, err = ioutil.ReadAll(res.Body)
  344. if err == nil {
  345. t.Error("expected error from res.Body.Read")
  346. }
  347. }()
  348. <-requestMade
  349. // Now force the serve loop to end, via closing the connection.
  350. st.closeConn()
  351. // deadlock? that's a bug.
  352. select {
  353. case <-done:
  354. case <-time.After(3 * time.Second):
  355. t.Fatal("timeout")
  356. }
  357. }
  358. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  359. // could be a table-driven test with extra goodies.
  360. func TestTransportPath(t *testing.T) {
  361. gotc := make(chan *url.URL, 1)
  362. st := newServerTester(t,
  363. func(w http.ResponseWriter, r *http.Request) {
  364. gotc <- r.URL
  365. },
  366. optOnlyServer,
  367. )
  368. defer st.Close()
  369. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  370. defer tr.CloseIdleConnections()
  371. const (
  372. path = "/testpath"
  373. query = "q=1"
  374. )
  375. surl := st.ts.URL + path + "?" + query
  376. req, err := http.NewRequest("POST", surl, nil)
  377. if err != nil {
  378. t.Fatal(err)
  379. }
  380. c := &http.Client{Transport: tr}
  381. res, err := c.Do(req)
  382. if err != nil {
  383. t.Fatal(err)
  384. }
  385. defer res.Body.Close()
  386. got := <-gotc
  387. if got.Path != path {
  388. t.Errorf("Read Path = %q; want %q", got.Path, path)
  389. }
  390. if got.RawQuery != query {
  391. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  392. }
  393. }
  394. func randString(n int) string {
  395. rnd := rand.New(rand.NewSource(int64(n)))
  396. b := make([]byte, n)
  397. for i := range b {
  398. b[i] = byte(rnd.Intn(256))
  399. }
  400. return string(b)
  401. }
  402. type panicReader struct{}
  403. func (panicReader) Read([]byte) (int, error) { panic("unexpected Read") }
  404. func (panicReader) Close() error { panic("unexpected Close") }
  405. func TestActualContentLength(t *testing.T) {
  406. tests := []struct {
  407. req *http.Request
  408. want int64
  409. }{
  410. // Verify we don't read from Body:
  411. 0: {
  412. req: &http.Request{Body: panicReader{}},
  413. want: -1,
  414. },
  415. // nil Body means 0, regardless of ContentLength:
  416. 1: {
  417. req: &http.Request{Body: nil, ContentLength: 5},
  418. want: 0,
  419. },
  420. // ContentLength is used if set.
  421. 2: {
  422. req: &http.Request{Body: panicReader{}, ContentLength: 5},
  423. want: 5,
  424. },
  425. // http.NoBody means 0, not -1.
  426. 3: {
  427. req: &http.Request{Body: http.NoBody},
  428. want: 0,
  429. },
  430. }
  431. for i, tt := range tests {
  432. got := actualContentLength(tt.req)
  433. if got != tt.want {
  434. t.Errorf("test[%d]: got %d; want %d", i, got, tt.want)
  435. }
  436. }
  437. }
  438. func TestTransportBody(t *testing.T) {
  439. bodyTests := []struct {
  440. body string
  441. noContentLen bool
  442. }{
  443. {body: "some message"},
  444. {body: "some message", noContentLen: true},
  445. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  446. {body: strings.Repeat("a", 1<<20)},
  447. {body: randString(16<<10 - 1)},
  448. {body: randString(16 << 10)},
  449. {body: randString(16<<10 + 1)},
  450. {body: randString(512<<10 - 1)},
  451. {body: randString(512 << 10)},
  452. {body: randString(512<<10 + 1)},
  453. {body: randString(1<<20 - 1)},
  454. {body: randString(1 << 20)},
  455. {body: randString(1<<20 + 2)},
  456. }
  457. type reqInfo struct {
  458. req *http.Request
  459. slurp []byte
  460. err error
  461. }
  462. gotc := make(chan reqInfo, 1)
  463. st := newServerTester(t,
  464. func(w http.ResponseWriter, r *http.Request) {
  465. slurp, err := ioutil.ReadAll(r.Body)
  466. if err != nil {
  467. gotc <- reqInfo{err: err}
  468. } else {
  469. gotc <- reqInfo{req: r, slurp: slurp}
  470. }
  471. },
  472. optOnlyServer,
  473. )
  474. defer st.Close()
  475. for i, tt := range bodyTests {
  476. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  477. defer tr.CloseIdleConnections()
  478. var body io.Reader = strings.NewReader(tt.body)
  479. if tt.noContentLen {
  480. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  481. }
  482. req, err := http.NewRequest("POST", st.ts.URL, body)
  483. if err != nil {
  484. t.Fatalf("#%d: %v", i, err)
  485. }
  486. c := &http.Client{Transport: tr}
  487. res, err := c.Do(req)
  488. if err != nil {
  489. t.Fatalf("#%d: %v", i, err)
  490. }
  491. defer res.Body.Close()
  492. ri := <-gotc
  493. if ri.err != nil {
  494. t.Errorf("#%d: read error: %v", i, ri.err)
  495. continue
  496. }
  497. if got := string(ri.slurp); got != tt.body {
  498. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  499. }
  500. wantLen := int64(len(tt.body))
  501. if tt.noContentLen && tt.body != "" {
  502. wantLen = -1
  503. }
  504. if ri.req.ContentLength != wantLen {
  505. t.Errorf("#%d. handler got ContentLength = %v; want %v", i, ri.req.ContentLength, wantLen)
  506. }
  507. }
  508. }
  509. func shortString(v string) string {
  510. const maxLen = 100
  511. if len(v) <= maxLen {
  512. return v
  513. }
  514. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  515. }
  516. func TestTransportDialTLS(t *testing.T) {
  517. var mu sync.Mutex // guards following
  518. var gotReq, didDial bool
  519. ts := newServerTester(t,
  520. func(w http.ResponseWriter, r *http.Request) {
  521. mu.Lock()
  522. gotReq = true
  523. mu.Unlock()
  524. },
  525. optOnlyServer,
  526. )
  527. defer ts.Close()
  528. tr := &Transport{
  529. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  530. mu.Lock()
  531. didDial = true
  532. mu.Unlock()
  533. cfg.InsecureSkipVerify = true
  534. c, err := tls.Dial(netw, addr, cfg)
  535. if err != nil {
  536. return nil, err
  537. }
  538. return c, c.Handshake()
  539. },
  540. }
  541. defer tr.CloseIdleConnections()
  542. client := &http.Client{Transport: tr}
  543. res, err := client.Get(ts.ts.URL)
  544. if err != nil {
  545. t.Fatal(err)
  546. }
  547. res.Body.Close()
  548. mu.Lock()
  549. if !gotReq {
  550. t.Error("didn't get request")
  551. }
  552. if !didDial {
  553. t.Error("didn't use dial hook")
  554. }
  555. }
  556. func TestConfigureTransport(t *testing.T) {
  557. t1 := &http.Transport{}
  558. err := ConfigureTransport(t1)
  559. if err != nil {
  560. t.Fatal(err)
  561. }
  562. if got := fmt.Sprintf("%#v", t1); !strings.Contains(got, `"h2"`) {
  563. // Laziness, to avoid buildtags.
  564. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  565. }
  566. wantNextProtos := []string{"h2", "http/1.1"}
  567. if t1.TLSClientConfig == nil {
  568. t.Errorf("nil t1.TLSClientConfig")
  569. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  570. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  571. }
  572. if err := ConfigureTransport(t1); err == nil {
  573. t.Error("unexpected success on second call to ConfigureTransport")
  574. }
  575. // And does it work?
  576. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  577. io.WriteString(w, r.Proto)
  578. }, optOnlyServer)
  579. defer st.Close()
  580. t1.TLSClientConfig.InsecureSkipVerify = true
  581. c := &http.Client{Transport: t1}
  582. res, err := c.Get(st.ts.URL)
  583. if err != nil {
  584. t.Fatal(err)
  585. }
  586. slurp, err := ioutil.ReadAll(res.Body)
  587. if err != nil {
  588. t.Fatal(err)
  589. }
  590. if got, want := string(slurp), "HTTP/2.0"; got != want {
  591. t.Errorf("body = %q; want %q", got, want)
  592. }
  593. }
  594. type capitalizeReader struct {
  595. r io.Reader
  596. }
  597. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  598. n, err = cr.r.Read(p)
  599. for i, b := range p[:n] {
  600. if b >= 'a' && b <= 'z' {
  601. p[i] = b - ('a' - 'A')
  602. }
  603. }
  604. return
  605. }
  606. type flushWriter struct {
  607. w io.Writer
  608. }
  609. func (fw flushWriter) Write(p []byte) (n int, err error) {
  610. n, err = fw.w.Write(p)
  611. if f, ok := fw.w.(http.Flusher); ok {
  612. f.Flush()
  613. }
  614. return
  615. }
  616. type clientTester struct {
  617. t *testing.T
  618. tr *Transport
  619. sc, cc net.Conn // server and client conn
  620. fr *Framer // server's framer
  621. client func() error
  622. server func() error
  623. }
  624. func newClientTester(t *testing.T) *clientTester {
  625. var dialOnce struct {
  626. sync.Mutex
  627. dialed bool
  628. }
  629. ct := &clientTester{
  630. t: t,
  631. }
  632. ct.tr = &Transport{
  633. TLSClientConfig: tlsConfigInsecure,
  634. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  635. dialOnce.Lock()
  636. defer dialOnce.Unlock()
  637. if dialOnce.dialed {
  638. return nil, errors.New("only one dial allowed in test mode")
  639. }
  640. dialOnce.dialed = true
  641. return ct.cc, nil
  642. },
  643. }
  644. ln := newLocalListener(t)
  645. cc, err := net.Dial("tcp", ln.Addr().String())
  646. if err != nil {
  647. t.Fatal(err)
  648. }
  649. sc, err := ln.Accept()
  650. if err != nil {
  651. t.Fatal(err)
  652. }
  653. ln.Close()
  654. ct.cc = cc
  655. ct.sc = sc
  656. ct.fr = NewFramer(sc, sc)
  657. return ct
  658. }
  659. func newLocalListener(t *testing.T) net.Listener {
  660. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  661. if err == nil {
  662. return ln
  663. }
  664. ln, err = net.Listen("tcp6", "[::1]:0")
  665. if err != nil {
  666. t.Fatal(err)
  667. }
  668. return ln
  669. }
  670. func (ct *clientTester) greet(settings ...Setting) {
  671. buf := make([]byte, len(ClientPreface))
  672. _, err := io.ReadFull(ct.sc, buf)
  673. if err != nil {
  674. ct.t.Fatalf("reading client preface: %v", err)
  675. }
  676. f, err := ct.fr.ReadFrame()
  677. if err != nil {
  678. ct.t.Fatalf("Reading client settings frame: %v", err)
  679. }
  680. if sf, ok := f.(*SettingsFrame); !ok {
  681. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  682. _ = sf // stash it away?
  683. }
  684. if err := ct.fr.WriteSettings(settings...); err != nil {
  685. ct.t.Fatal(err)
  686. }
  687. if err := ct.fr.WriteSettingsAck(); err != nil {
  688. ct.t.Fatal(err)
  689. }
  690. }
  691. func (ct *clientTester) readNonSettingsFrame() (Frame, error) {
  692. for {
  693. f, err := ct.fr.ReadFrame()
  694. if err != nil {
  695. return nil, err
  696. }
  697. if _, ok := f.(*SettingsFrame); ok {
  698. continue
  699. }
  700. return f, nil
  701. }
  702. }
  703. func (ct *clientTester) cleanup() {
  704. ct.tr.CloseIdleConnections()
  705. }
  706. func (ct *clientTester) run() {
  707. errc := make(chan error, 2)
  708. ct.start("client", errc, ct.client)
  709. ct.start("server", errc, ct.server)
  710. defer ct.cleanup()
  711. for i := 0; i < 2; i++ {
  712. if err := <-errc; err != nil {
  713. ct.t.Error(err)
  714. return
  715. }
  716. }
  717. }
  718. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  719. go func() {
  720. finished := false
  721. var err error
  722. defer func() {
  723. if !finished {
  724. err = fmt.Errorf("%s goroutine didn't finish.", which)
  725. } else if err != nil {
  726. err = fmt.Errorf("%s: %v", which, err)
  727. }
  728. errc <- err
  729. }()
  730. err = fn()
  731. finished = true
  732. }()
  733. }
  734. func (ct *clientTester) readFrame() (Frame, error) {
  735. return readFrameTimeout(ct.fr, 2*time.Second)
  736. }
  737. func (ct *clientTester) firstHeaders() (*HeadersFrame, error) {
  738. for {
  739. f, err := ct.readFrame()
  740. if err != nil {
  741. return nil, fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  742. }
  743. switch f.(type) {
  744. case *WindowUpdateFrame, *SettingsFrame:
  745. continue
  746. }
  747. hf, ok := f.(*HeadersFrame)
  748. if !ok {
  749. return nil, fmt.Errorf("Got %T; want HeadersFrame", f)
  750. }
  751. return hf, nil
  752. }
  753. }
  754. type countingReader struct {
  755. n *int64
  756. }
  757. func (r countingReader) Read(p []byte) (n int, err error) {
  758. for i := range p {
  759. p[i] = byte(i)
  760. }
  761. atomic.AddInt64(r.n, int64(len(p)))
  762. return len(p), err
  763. }
  764. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  765. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  766. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  767. const bodySize = 10 << 20
  768. clientDone := make(chan struct{})
  769. ct := newClientTester(t)
  770. ct.client = func() error {
  771. defer ct.cc.(*net.TCPConn).CloseWrite()
  772. defer close(clientDone)
  773. var n int64 // atomic
  774. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  775. if err != nil {
  776. return err
  777. }
  778. res, err := ct.tr.RoundTrip(req)
  779. if err != nil {
  780. return fmt.Errorf("RoundTrip: %v", err)
  781. }
  782. defer res.Body.Close()
  783. if res.StatusCode != status {
  784. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  785. }
  786. slurp, err := ioutil.ReadAll(res.Body)
  787. if err != nil {
  788. return fmt.Errorf("Slurp: %v", err)
  789. }
  790. if len(slurp) > 0 {
  791. return fmt.Errorf("unexpected body: %q", slurp)
  792. }
  793. if status == 200 {
  794. if got := atomic.LoadInt64(&n); got != bodySize {
  795. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  796. }
  797. } else {
  798. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  799. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  800. }
  801. }
  802. return nil
  803. }
  804. ct.server = func() error {
  805. ct.greet()
  806. var buf bytes.Buffer
  807. enc := hpack.NewEncoder(&buf)
  808. var dataRecv int64
  809. var closed bool
  810. for {
  811. f, err := ct.fr.ReadFrame()
  812. if err != nil {
  813. select {
  814. case <-clientDone:
  815. // If the client's done, it
  816. // will have reported any
  817. // errors on its side.
  818. return nil
  819. default:
  820. return err
  821. }
  822. }
  823. //println(fmt.Sprintf("server got frame: %v", f))
  824. switch f := f.(type) {
  825. case *WindowUpdateFrame, *SettingsFrame:
  826. case *HeadersFrame:
  827. if !f.HeadersEnded() {
  828. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  829. }
  830. if f.StreamEnded() {
  831. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  832. }
  833. case *DataFrame:
  834. dataLen := len(f.Data())
  835. if dataLen > 0 {
  836. if dataRecv == 0 {
  837. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  838. ct.fr.WriteHeaders(HeadersFrameParam{
  839. StreamID: f.StreamID,
  840. EndHeaders: true,
  841. EndStream: false,
  842. BlockFragment: buf.Bytes(),
  843. })
  844. }
  845. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  846. return err
  847. }
  848. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  849. return err
  850. }
  851. }
  852. dataRecv += int64(dataLen)
  853. if !closed && ((status != 200 && dataRecv > 0) ||
  854. (status == 200 && dataRecv == bodySize)) {
  855. closed = true
  856. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  857. return err
  858. }
  859. }
  860. default:
  861. return fmt.Errorf("Unexpected client frame %v", f)
  862. }
  863. }
  864. }
  865. ct.run()
  866. }
  867. // See golang.org/issue/13444
  868. func TestTransportFullDuplex(t *testing.T) {
  869. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  870. w.WriteHeader(200) // redundant but for clarity
  871. w.(http.Flusher).Flush()
  872. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  873. fmt.Fprintf(w, "bye.\n")
  874. }, optOnlyServer)
  875. defer st.Close()
  876. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  877. defer tr.CloseIdleConnections()
  878. c := &http.Client{Transport: tr}
  879. pr, pw := io.Pipe()
  880. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  881. if err != nil {
  882. t.Fatal(err)
  883. }
  884. req.ContentLength = -1
  885. res, err := c.Do(req)
  886. if err != nil {
  887. t.Fatal(err)
  888. }
  889. defer res.Body.Close()
  890. if res.StatusCode != 200 {
  891. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  892. }
  893. bs := bufio.NewScanner(res.Body)
  894. want := func(v string) {
  895. if !bs.Scan() {
  896. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  897. }
  898. }
  899. write := func(v string) {
  900. _, err := io.WriteString(pw, v)
  901. if err != nil {
  902. t.Fatalf("pipe write: %v", err)
  903. }
  904. }
  905. write("foo\n")
  906. want("FOO")
  907. write("bar\n")
  908. want("BAR")
  909. pw.Close()
  910. want("bye.")
  911. if err := bs.Err(); err != nil {
  912. t.Fatal(err)
  913. }
  914. }
  915. func TestTransportConnectRequest(t *testing.T) {
  916. gotc := make(chan *http.Request, 1)
  917. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  918. gotc <- r
  919. }, optOnlyServer)
  920. defer st.Close()
  921. u, err := url.Parse(st.ts.URL)
  922. if err != nil {
  923. t.Fatal(err)
  924. }
  925. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  926. defer tr.CloseIdleConnections()
  927. c := &http.Client{Transport: tr}
  928. tests := []struct {
  929. req *http.Request
  930. want string
  931. }{
  932. {
  933. req: &http.Request{
  934. Method: "CONNECT",
  935. Header: http.Header{},
  936. URL: u,
  937. },
  938. want: u.Host,
  939. },
  940. {
  941. req: &http.Request{
  942. Method: "CONNECT",
  943. Header: http.Header{},
  944. URL: u,
  945. Host: "example.com:123",
  946. },
  947. want: "example.com:123",
  948. },
  949. }
  950. for i, tt := range tests {
  951. res, err := c.Do(tt.req)
  952. if err != nil {
  953. t.Errorf("%d. RoundTrip = %v", i, err)
  954. continue
  955. }
  956. res.Body.Close()
  957. req := <-gotc
  958. if req.Method != "CONNECT" {
  959. t.Errorf("method = %q; want CONNECT", req.Method)
  960. }
  961. if req.Host != tt.want {
  962. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  963. }
  964. if req.URL.Host != tt.want {
  965. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  966. }
  967. }
  968. }
  969. type headerType int
  970. const (
  971. noHeader headerType = iota // omitted
  972. oneHeader
  973. splitHeader // broken into continuation on purpose
  974. )
  975. const (
  976. f0 = noHeader
  977. f1 = oneHeader
  978. f2 = splitHeader
  979. d0 = false
  980. d1 = true
  981. )
  982. // Test all 36 combinations of response frame orders:
  983. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  984. // Generated by http://play.golang.org/p/SScqYKJYXd
  985. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  986. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  987. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  988. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  989. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  990. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  991. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  992. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  993. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  994. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  995. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  996. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  997. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  998. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  999. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  1000. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  1001. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  1002. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  1003. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  1004. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  1005. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  1006. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  1007. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  1008. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  1009. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  1010. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  1011. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  1012. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  1013. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  1014. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  1015. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  1016. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  1017. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  1018. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  1019. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  1020. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  1021. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  1022. const reqBody = "some request body"
  1023. const resBody = "some response body"
  1024. if resHeader == noHeader {
  1025. // TODO: test 100-continue followed by immediate
  1026. // server stream reset, without headers in the middle?
  1027. panic("invalid combination")
  1028. }
  1029. ct := newClientTester(t)
  1030. ct.client = func() error {
  1031. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  1032. if expect100Continue != noHeader {
  1033. req.Header.Set("Expect", "100-continue")
  1034. }
  1035. res, err := ct.tr.RoundTrip(req)
  1036. if err != nil {
  1037. return fmt.Errorf("RoundTrip: %v", err)
  1038. }
  1039. defer res.Body.Close()
  1040. if res.StatusCode != 200 {
  1041. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1042. }
  1043. slurp, err := ioutil.ReadAll(res.Body)
  1044. if err != nil {
  1045. return fmt.Errorf("Slurp: %v", err)
  1046. }
  1047. wantBody := resBody
  1048. if !withData {
  1049. wantBody = ""
  1050. }
  1051. if string(slurp) != wantBody {
  1052. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  1053. }
  1054. if trailers == noHeader {
  1055. if len(res.Trailer) > 0 {
  1056. t.Errorf("Trailer = %v; want none", res.Trailer)
  1057. }
  1058. } else {
  1059. want := http.Header{"Some-Trailer": {"some-value"}}
  1060. if !reflect.DeepEqual(res.Trailer, want) {
  1061. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  1062. }
  1063. }
  1064. return nil
  1065. }
  1066. ct.server = func() error {
  1067. ct.greet()
  1068. var buf bytes.Buffer
  1069. enc := hpack.NewEncoder(&buf)
  1070. for {
  1071. f, err := ct.fr.ReadFrame()
  1072. if err != nil {
  1073. return err
  1074. }
  1075. endStream := false
  1076. send := func(mode headerType) {
  1077. hbf := buf.Bytes()
  1078. switch mode {
  1079. case oneHeader:
  1080. ct.fr.WriteHeaders(HeadersFrameParam{
  1081. StreamID: f.Header().StreamID,
  1082. EndHeaders: true,
  1083. EndStream: endStream,
  1084. BlockFragment: hbf,
  1085. })
  1086. case splitHeader:
  1087. if len(hbf) < 2 {
  1088. panic("too small")
  1089. }
  1090. ct.fr.WriteHeaders(HeadersFrameParam{
  1091. StreamID: f.Header().StreamID,
  1092. EndHeaders: false,
  1093. EndStream: endStream,
  1094. BlockFragment: hbf[:1],
  1095. })
  1096. ct.fr.WriteContinuation(f.Header().StreamID, true, hbf[1:])
  1097. default:
  1098. panic("bogus mode")
  1099. }
  1100. }
  1101. switch f := f.(type) {
  1102. case *WindowUpdateFrame, *SettingsFrame:
  1103. case *DataFrame:
  1104. if !f.StreamEnded() {
  1105. // No need to send flow control tokens. The test request body is tiny.
  1106. continue
  1107. }
  1108. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1109. {
  1110. buf.Reset()
  1111. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1112. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  1113. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  1114. if trailers != noHeader {
  1115. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  1116. }
  1117. endStream = withData == false && trailers == noHeader
  1118. send(resHeader)
  1119. }
  1120. if withData {
  1121. endStream = trailers == noHeader
  1122. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  1123. }
  1124. if trailers != noHeader {
  1125. endStream = true
  1126. buf.Reset()
  1127. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  1128. send(trailers)
  1129. }
  1130. if endStream {
  1131. return nil
  1132. }
  1133. case *HeadersFrame:
  1134. if expect100Continue != noHeader {
  1135. buf.Reset()
  1136. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  1137. send(expect100Continue)
  1138. }
  1139. }
  1140. }
  1141. }
  1142. ct.run()
  1143. }
  1144. // Issue 26189, Issue 17739: ignore unknown 1xx responses
  1145. func TestTransportUnknown1xx(t *testing.T) {
  1146. var buf bytes.Buffer
  1147. defer func() { got1xxFuncForTests = nil }()
  1148. got1xxFuncForTests = func(code int, header textproto.MIMEHeader) error {
  1149. fmt.Fprintf(&buf, "code=%d header=%v\n", code, header)
  1150. return nil
  1151. }
  1152. ct := newClientTester(t)
  1153. ct.client = func() error {
  1154. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1155. res, err := ct.tr.RoundTrip(req)
  1156. if err != nil {
  1157. return fmt.Errorf("RoundTrip: %v", err)
  1158. }
  1159. defer res.Body.Close()
  1160. if res.StatusCode != 204 {
  1161. return fmt.Errorf("status code = %v; want 204", res.StatusCode)
  1162. }
  1163. want := `code=110 header=map[Foo-Bar:[110]]
  1164. code=111 header=map[Foo-Bar:[111]]
  1165. code=112 header=map[Foo-Bar:[112]]
  1166. code=113 header=map[Foo-Bar:[113]]
  1167. code=114 header=map[Foo-Bar:[114]]
  1168. `
  1169. if got := buf.String(); got != want {
  1170. t.Errorf("Got trace:\n%s\nWant:\n%s", got, want)
  1171. }
  1172. return nil
  1173. }
  1174. ct.server = func() error {
  1175. ct.greet()
  1176. var buf bytes.Buffer
  1177. enc := hpack.NewEncoder(&buf)
  1178. for {
  1179. f, err := ct.fr.ReadFrame()
  1180. if err != nil {
  1181. return err
  1182. }
  1183. switch f := f.(type) {
  1184. case *WindowUpdateFrame, *SettingsFrame:
  1185. case *HeadersFrame:
  1186. for i := 110; i <= 114; i++ {
  1187. buf.Reset()
  1188. enc.WriteField(hpack.HeaderField{Name: ":status", Value: fmt.Sprint(i)})
  1189. enc.WriteField(hpack.HeaderField{Name: "foo-bar", Value: fmt.Sprint(i)})
  1190. ct.fr.WriteHeaders(HeadersFrameParam{
  1191. StreamID: f.StreamID,
  1192. EndHeaders: true,
  1193. EndStream: false,
  1194. BlockFragment: buf.Bytes(),
  1195. })
  1196. }
  1197. buf.Reset()
  1198. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  1199. ct.fr.WriteHeaders(HeadersFrameParam{
  1200. StreamID: f.StreamID,
  1201. EndHeaders: true,
  1202. EndStream: false,
  1203. BlockFragment: buf.Bytes(),
  1204. })
  1205. return nil
  1206. }
  1207. }
  1208. }
  1209. ct.run()
  1210. }
  1211. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  1212. ct := newClientTester(t)
  1213. ct.client = func() error {
  1214. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1215. res, err := ct.tr.RoundTrip(req)
  1216. if err != nil {
  1217. return fmt.Errorf("RoundTrip: %v", err)
  1218. }
  1219. defer res.Body.Close()
  1220. if res.StatusCode != 200 {
  1221. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1222. }
  1223. slurp, err := ioutil.ReadAll(res.Body)
  1224. if err != nil {
  1225. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  1226. }
  1227. if len(slurp) > 0 {
  1228. return fmt.Errorf("body = %q; want nothing", slurp)
  1229. }
  1230. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  1231. return fmt.Errorf("expected Some-Trailer")
  1232. }
  1233. return nil
  1234. }
  1235. ct.server = func() error {
  1236. ct.greet()
  1237. var n int
  1238. var hf *HeadersFrame
  1239. for hf == nil && n < 10 {
  1240. f, err := ct.fr.ReadFrame()
  1241. if err != nil {
  1242. return err
  1243. }
  1244. hf, _ = f.(*HeadersFrame)
  1245. n++
  1246. }
  1247. var buf bytes.Buffer
  1248. enc := hpack.NewEncoder(&buf)
  1249. // send headers without Trailer header
  1250. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1251. ct.fr.WriteHeaders(HeadersFrameParam{
  1252. StreamID: hf.StreamID,
  1253. EndHeaders: true,
  1254. EndStream: false,
  1255. BlockFragment: buf.Bytes(),
  1256. })
  1257. // send trailers
  1258. buf.Reset()
  1259. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  1260. ct.fr.WriteHeaders(HeadersFrameParam{
  1261. StreamID: hf.StreamID,
  1262. EndHeaders: true,
  1263. EndStream: true,
  1264. BlockFragment: buf.Bytes(),
  1265. })
  1266. return nil
  1267. }
  1268. ct.run()
  1269. }
  1270. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1271. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1272. }
  1273. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1274. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1275. }
  1276. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1277. testInvalidTrailer(t, trailers, pseudoHeaderError(":colon"), func(enc *hpack.Encoder) {
  1278. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1279. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1280. })
  1281. }
  1282. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1283. testTransportInvalidTrailer_Capital(t, oneHeader)
  1284. }
  1285. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1286. testTransportInvalidTrailer_Capital(t, splitHeader)
  1287. }
  1288. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1289. testInvalidTrailer(t, trailers, headerFieldNameError("Capital"), func(enc *hpack.Encoder) {
  1290. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1291. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1292. })
  1293. }
  1294. func TestTransportInvalidTrailer_EmptyFieldName(t *testing.T) {
  1295. testInvalidTrailer(t, oneHeader, headerFieldNameError(""), func(enc *hpack.Encoder) {
  1296. enc.WriteField(hpack.HeaderField{Name: "", Value: "bad"})
  1297. })
  1298. }
  1299. func TestTransportInvalidTrailer_BinaryFieldValue(t *testing.T) {
  1300. testInvalidTrailer(t, oneHeader, headerFieldValueError("has\nnewline"), func(enc *hpack.Encoder) {
  1301. enc.WriteField(hpack.HeaderField{Name: "x", Value: "has\nnewline"})
  1302. })
  1303. }
  1304. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1305. ct := newClientTester(t)
  1306. ct.client = func() error {
  1307. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1308. res, err := ct.tr.RoundTrip(req)
  1309. if err != nil {
  1310. return fmt.Errorf("RoundTrip: %v", err)
  1311. }
  1312. defer res.Body.Close()
  1313. if res.StatusCode != 200 {
  1314. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1315. }
  1316. slurp, err := ioutil.ReadAll(res.Body)
  1317. se, ok := err.(StreamError)
  1318. if !ok || se.Cause != wantErr {
  1319. return fmt.Errorf("res.Body ReadAll error = %q, %#v; want StreamError with cause %T, %#v", slurp, err, wantErr, wantErr)
  1320. }
  1321. if len(slurp) > 0 {
  1322. return fmt.Errorf("body = %q; want nothing", slurp)
  1323. }
  1324. return nil
  1325. }
  1326. ct.server = func() error {
  1327. ct.greet()
  1328. var buf bytes.Buffer
  1329. enc := hpack.NewEncoder(&buf)
  1330. for {
  1331. f, err := ct.fr.ReadFrame()
  1332. if err != nil {
  1333. return err
  1334. }
  1335. switch f := f.(type) {
  1336. case *HeadersFrame:
  1337. var endStream bool
  1338. send := func(mode headerType) {
  1339. hbf := buf.Bytes()
  1340. switch mode {
  1341. case oneHeader:
  1342. ct.fr.WriteHeaders(HeadersFrameParam{
  1343. StreamID: f.StreamID,
  1344. EndHeaders: true,
  1345. EndStream: endStream,
  1346. BlockFragment: hbf,
  1347. })
  1348. case splitHeader:
  1349. if len(hbf) < 2 {
  1350. panic("too small")
  1351. }
  1352. ct.fr.WriteHeaders(HeadersFrameParam{
  1353. StreamID: f.StreamID,
  1354. EndHeaders: false,
  1355. EndStream: endStream,
  1356. BlockFragment: hbf[:1],
  1357. })
  1358. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1359. default:
  1360. panic("bogus mode")
  1361. }
  1362. }
  1363. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1364. {
  1365. buf.Reset()
  1366. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1367. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1368. endStream = false
  1369. send(oneHeader)
  1370. }
  1371. // Trailers:
  1372. {
  1373. endStream = true
  1374. buf.Reset()
  1375. writeTrailer(enc)
  1376. send(trailers)
  1377. }
  1378. return nil
  1379. }
  1380. }
  1381. }
  1382. ct.run()
  1383. }
  1384. // headerListSize returns the HTTP2 header list size of h.
  1385. // http://httpwg.org/specs/rfc7540.html#SETTINGS_MAX_HEADER_LIST_SIZE
  1386. // http://httpwg.org/specs/rfc7540.html#MaxHeaderBlock
  1387. func headerListSize(h http.Header) (size uint32) {
  1388. for k, vv := range h {
  1389. for _, v := range vv {
  1390. hf := hpack.HeaderField{Name: k, Value: v}
  1391. size += hf.Size()
  1392. }
  1393. }
  1394. return size
  1395. }
  1396. // padHeaders adds data to an http.Header until headerListSize(h) ==
  1397. // limit. Due to the way header list sizes are calculated, padHeaders
  1398. // cannot add fewer than len("Pad-Headers") + 32 bytes to h, and will
  1399. // call t.Fatal if asked to do so. PadHeaders first reserves enough
  1400. // space for an empty "Pad-Headers" key, then adds as many copies of
  1401. // filler as possible. Any remaining bytes necessary to push the
  1402. // header list size up to limit are added to h["Pad-Headers"].
  1403. func padHeaders(t *testing.T, h http.Header, limit uint64, filler string) {
  1404. if limit > 0xffffffff {
  1405. t.Fatalf("padHeaders: refusing to pad to more than 2^32-1 bytes. limit = %v", limit)
  1406. }
  1407. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1408. minPadding := uint64(hf.Size())
  1409. size := uint64(headerListSize(h))
  1410. minlimit := size + minPadding
  1411. if limit < minlimit {
  1412. t.Fatalf("padHeaders: limit %v < %v", limit, minlimit)
  1413. }
  1414. // Use a fixed-width format for name so that fieldSize
  1415. // remains constant.
  1416. nameFmt := "Pad-Headers-%06d"
  1417. hf = hpack.HeaderField{Name: fmt.Sprintf(nameFmt, 1), Value: filler}
  1418. fieldSize := uint64(hf.Size())
  1419. // Add as many complete filler values as possible, leaving
  1420. // room for at least one empty "Pad-Headers" key.
  1421. limit = limit - minPadding
  1422. for i := 0; size+fieldSize < limit; i++ {
  1423. name := fmt.Sprintf(nameFmt, i)
  1424. h.Add(name, filler)
  1425. size += fieldSize
  1426. }
  1427. // Add enough bytes to reach limit.
  1428. remain := limit - size
  1429. lastValue := strings.Repeat("*", int(remain))
  1430. h.Add("Pad-Headers", lastValue)
  1431. }
  1432. func TestPadHeaders(t *testing.T) {
  1433. check := func(h http.Header, limit uint32, fillerLen int) {
  1434. if h == nil {
  1435. h = make(http.Header)
  1436. }
  1437. filler := strings.Repeat("f", fillerLen)
  1438. padHeaders(t, h, uint64(limit), filler)
  1439. gotSize := headerListSize(h)
  1440. if gotSize != limit {
  1441. t.Errorf("Got size = %v; want %v", gotSize, limit)
  1442. }
  1443. }
  1444. // Try all possible combinations for small fillerLen and limit.
  1445. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1446. minLimit := hf.Size()
  1447. for limit := minLimit; limit <= 128; limit++ {
  1448. for fillerLen := 0; uint32(fillerLen) <= limit; fillerLen++ {
  1449. check(nil, limit, fillerLen)
  1450. }
  1451. }
  1452. // Try a few tests with larger limits, plus cumulative
  1453. // tests. Since these tests are cumulative, tests[i+1].limit
  1454. // must be >= tests[i].limit + minLimit. See the comment on
  1455. // padHeaders for more info on why the limit arg has this
  1456. // restriction.
  1457. tests := []struct {
  1458. fillerLen int
  1459. limit uint32
  1460. }{
  1461. {
  1462. fillerLen: 64,
  1463. limit: 1024,
  1464. },
  1465. {
  1466. fillerLen: 1024,
  1467. limit: 1286,
  1468. },
  1469. {
  1470. fillerLen: 256,
  1471. limit: 2048,
  1472. },
  1473. {
  1474. fillerLen: 1024,
  1475. limit: 10 * 1024,
  1476. },
  1477. {
  1478. fillerLen: 1023,
  1479. limit: 11 * 1024,
  1480. },
  1481. }
  1482. h := make(http.Header)
  1483. for _, tc := range tests {
  1484. check(nil, tc.limit, tc.fillerLen)
  1485. check(h, tc.limit, tc.fillerLen)
  1486. }
  1487. }
  1488. func TestTransportChecksRequestHeaderListSize(t *testing.T) {
  1489. st := newServerTester(t,
  1490. func(w http.ResponseWriter, r *http.Request) {
  1491. // Consume body & force client to send
  1492. // trailers before writing response.
  1493. // ioutil.ReadAll returns non-nil err for
  1494. // requests that attempt to send greater than
  1495. // maxHeaderListSize bytes of trailers, since
  1496. // those requests generate a stream reset.
  1497. ioutil.ReadAll(r.Body)
  1498. r.Body.Close()
  1499. },
  1500. func(ts *httptest.Server) {
  1501. ts.Config.MaxHeaderBytes = 16 << 10
  1502. },
  1503. optOnlyServer,
  1504. optQuiet,
  1505. )
  1506. defer st.Close()
  1507. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1508. defer tr.CloseIdleConnections()
  1509. checkRoundTrip := func(req *http.Request, wantErr error, desc string) {
  1510. res, err := tr.RoundTrip(req)
  1511. if err != wantErr {
  1512. if res != nil {
  1513. res.Body.Close()
  1514. }
  1515. t.Errorf("%v: RoundTrip err = %v; want %v", desc, err, wantErr)
  1516. return
  1517. }
  1518. if err == nil {
  1519. if res == nil {
  1520. t.Errorf("%v: response nil; want non-nil.", desc)
  1521. return
  1522. }
  1523. defer res.Body.Close()
  1524. if res.StatusCode != http.StatusOK {
  1525. t.Errorf("%v: response status = %v; want %v", desc, res.StatusCode, http.StatusOK)
  1526. }
  1527. return
  1528. }
  1529. if res != nil {
  1530. t.Errorf("%v: RoundTrip err = %v but response non-nil", desc, err)
  1531. }
  1532. }
  1533. headerListSizeForRequest := func(req *http.Request) (size uint64) {
  1534. contentLen := actualContentLength(req)
  1535. trailers, err := commaSeparatedTrailers(req)
  1536. if err != nil {
  1537. t.Fatalf("headerListSizeForRequest: %v", err)
  1538. }
  1539. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  1540. cc.henc = hpack.NewEncoder(&cc.hbuf)
  1541. cc.mu.Lock()
  1542. hdrs, err := cc.encodeHeaders(req, true, trailers, contentLen)
  1543. cc.mu.Unlock()
  1544. if err != nil {
  1545. t.Fatalf("headerListSizeForRequest: %v", err)
  1546. }
  1547. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(hf hpack.HeaderField) {
  1548. size += uint64(hf.Size())
  1549. })
  1550. if len(hdrs) > 0 {
  1551. if _, err := hpackDec.Write(hdrs); err != nil {
  1552. t.Fatalf("headerListSizeForRequest: %v", err)
  1553. }
  1554. }
  1555. return size
  1556. }
  1557. // Create a new Request for each test, rather than reusing the
  1558. // same Request, to avoid a race when modifying req.Headers.
  1559. // See https://github.com/golang/go/issues/21316
  1560. newRequest := func() *http.Request {
  1561. // Body must be non-nil to enable writing trailers.
  1562. body := strings.NewReader("hello")
  1563. req, err := http.NewRequest("POST", st.ts.URL, body)
  1564. if err != nil {
  1565. t.Fatalf("newRequest: NewRequest: %v", err)
  1566. }
  1567. return req
  1568. }
  1569. // Make an arbitrary request to ensure we get the server's
  1570. // settings frame and initialize peerMaxHeaderListSize.
  1571. req := newRequest()
  1572. checkRoundTrip(req, nil, "Initial request")
  1573. // Get the ClientConn associated with the request and validate
  1574. // peerMaxHeaderListSize.
  1575. addr := authorityAddr(req.URL.Scheme, req.URL.Host)
  1576. cc, err := tr.connPool().GetClientConn(req, addr)
  1577. if err != nil {
  1578. t.Fatalf("GetClientConn: %v", err)
  1579. }
  1580. cc.mu.Lock()
  1581. peerSize := cc.peerMaxHeaderListSize
  1582. cc.mu.Unlock()
  1583. st.scMu.Lock()
  1584. wantSize := uint64(st.sc.maxHeaderListSize())
  1585. st.scMu.Unlock()
  1586. if peerSize != wantSize {
  1587. t.Errorf("peerMaxHeaderListSize = %v; want %v", peerSize, wantSize)
  1588. }
  1589. // Sanity check peerSize. (*serverConn) maxHeaderListSize adds
  1590. // 320 bytes of padding.
  1591. wantHeaderBytes := uint64(st.ts.Config.MaxHeaderBytes) + 320
  1592. if peerSize != wantHeaderBytes {
  1593. t.Errorf("peerMaxHeaderListSize = %v; want %v.", peerSize, wantHeaderBytes)
  1594. }
  1595. // Pad headers & trailers, but stay under peerSize.
  1596. req = newRequest()
  1597. req.Header = make(http.Header)
  1598. req.Trailer = make(http.Header)
  1599. filler := strings.Repeat("*", 1024)
  1600. padHeaders(t, req.Trailer, peerSize, filler)
  1601. // cc.encodeHeaders adds some default headers to the request,
  1602. // so we need to leave room for those.
  1603. defaultBytes := headerListSizeForRequest(req)
  1604. padHeaders(t, req.Header, peerSize-defaultBytes, filler)
  1605. checkRoundTrip(req, nil, "Headers & Trailers under limit")
  1606. // Add enough header bytes to push us over peerSize.
  1607. req = newRequest()
  1608. req.Header = make(http.Header)
  1609. padHeaders(t, req.Header, peerSize, filler)
  1610. checkRoundTrip(req, errRequestHeaderListSize, "Headers over limit")
  1611. // Push trailers over the limit.
  1612. req = newRequest()
  1613. req.Trailer = make(http.Header)
  1614. padHeaders(t, req.Trailer, peerSize+1, filler)
  1615. checkRoundTrip(req, errRequestHeaderListSize, "Trailers over limit")
  1616. // Send headers with a single large value.
  1617. req = newRequest()
  1618. filler = strings.Repeat("*", int(peerSize))
  1619. req.Header = make(http.Header)
  1620. req.Header.Set("Big", filler)
  1621. checkRoundTrip(req, errRequestHeaderListSize, "Single large header")
  1622. // Send trailers with a single large value.
  1623. req = newRequest()
  1624. req.Trailer = make(http.Header)
  1625. req.Trailer.Set("Big", filler)
  1626. checkRoundTrip(req, errRequestHeaderListSize, "Single large trailer")
  1627. }
  1628. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1629. ct := newClientTester(t)
  1630. ct.client = func() error {
  1631. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1632. res, err := ct.tr.RoundTrip(req)
  1633. if err != errResponseHeaderListSize {
  1634. if res != nil {
  1635. res.Body.Close()
  1636. }
  1637. size := int64(0)
  1638. for k, vv := range res.Header {
  1639. for _, v := range vv {
  1640. size += int64(len(k)) + int64(len(v)) + 32
  1641. }
  1642. }
  1643. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1644. }
  1645. return nil
  1646. }
  1647. ct.server = func() error {
  1648. ct.greet()
  1649. var buf bytes.Buffer
  1650. enc := hpack.NewEncoder(&buf)
  1651. for {
  1652. f, err := ct.fr.ReadFrame()
  1653. if err != nil {
  1654. return err
  1655. }
  1656. switch f := f.(type) {
  1657. case *HeadersFrame:
  1658. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1659. large := strings.Repeat("a", 1<<10)
  1660. for i := 0; i < 5042; i++ {
  1661. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1662. }
  1663. if size, want := buf.Len(), 6329; size != want {
  1664. // Note: this number might change if
  1665. // our hpack implementation
  1666. // changes. That's fine. This is
  1667. // just a sanity check that our
  1668. // response can fit in a single
  1669. // header block fragment frame.
  1670. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1671. }
  1672. ct.fr.WriteHeaders(HeadersFrameParam{
  1673. StreamID: f.StreamID,
  1674. EndHeaders: true,
  1675. EndStream: true,
  1676. BlockFragment: buf.Bytes(),
  1677. })
  1678. return nil
  1679. }
  1680. }
  1681. }
  1682. ct.run()
  1683. }
  1684. // Test that the Transport returns a typed error from Response.Body.Read calls
  1685. // when the server sends an error. (here we use a panic, since that should generate
  1686. // a stream error, but others like cancel should be similar)
  1687. func TestTransportBodyReadErrorType(t *testing.T) {
  1688. doPanic := make(chan bool, 1)
  1689. st := newServerTester(t,
  1690. func(w http.ResponseWriter, r *http.Request) {
  1691. w.(http.Flusher).Flush() // force headers out
  1692. <-doPanic
  1693. panic("boom")
  1694. },
  1695. optOnlyServer,
  1696. optQuiet,
  1697. )
  1698. defer st.Close()
  1699. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1700. defer tr.CloseIdleConnections()
  1701. c := &http.Client{Transport: tr}
  1702. res, err := c.Get(st.ts.URL)
  1703. if err != nil {
  1704. t.Fatal(err)
  1705. }
  1706. defer res.Body.Close()
  1707. doPanic <- true
  1708. buf := make([]byte, 100)
  1709. n, err := res.Body.Read(buf)
  1710. want := StreamError{StreamID: 0x1, Code: 0x2}
  1711. if !reflect.DeepEqual(want, err) {
  1712. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1713. }
  1714. }
  1715. // golang.org/issue/13924
  1716. // This used to fail after many iterations, especially with -race:
  1717. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1718. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1719. var (
  1720. mu sync.Mutex
  1721. conn net.Conn // to close if set
  1722. )
  1723. st := newServerTester(t,
  1724. func(w http.ResponseWriter, r *http.Request) {
  1725. mu.Lock()
  1726. defer mu.Unlock()
  1727. if conn != nil {
  1728. conn.Close()
  1729. }
  1730. },
  1731. optOnlyServer,
  1732. )
  1733. defer st.Close()
  1734. tr := &Transport{
  1735. TLSClientConfig: tlsConfigInsecure,
  1736. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1737. tc, err := tls.Dial(network, addr, cfg)
  1738. if err != nil {
  1739. return nil, err
  1740. }
  1741. mu.Lock()
  1742. defer mu.Unlock()
  1743. conn = tc
  1744. return tc, nil
  1745. },
  1746. }
  1747. defer tr.CloseIdleConnections()
  1748. c := &http.Client{Transport: tr}
  1749. c.Get(st.ts.URL)
  1750. }
  1751. // Test that the http1 Transport.DisableKeepAlives option is respected
  1752. // and connections are closed as soon as idle.
  1753. // See golang.org/issue/14008
  1754. func TestTransportDisableKeepAlives(t *testing.T) {
  1755. st := newServerTester(t,
  1756. func(w http.ResponseWriter, r *http.Request) {
  1757. io.WriteString(w, "hi")
  1758. },
  1759. optOnlyServer,
  1760. )
  1761. defer st.Close()
  1762. connClosed := make(chan struct{}) // closed on tls.Conn.Close
  1763. tr := &Transport{
  1764. t1: &http.Transport{
  1765. DisableKeepAlives: true,
  1766. },
  1767. TLSClientConfig: tlsConfigInsecure,
  1768. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1769. tc, err := tls.Dial(network, addr, cfg)
  1770. if err != nil {
  1771. return nil, err
  1772. }
  1773. return &noteCloseConn{Conn: tc, closefn: func() { close(connClosed) }}, nil
  1774. },
  1775. }
  1776. c := &http.Client{Transport: tr}
  1777. res, err := c.Get(st.ts.URL)
  1778. if err != nil {
  1779. t.Fatal(err)
  1780. }
  1781. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1782. t.Fatal(err)
  1783. }
  1784. defer res.Body.Close()
  1785. select {
  1786. case <-connClosed:
  1787. case <-time.After(1 * time.Second):
  1788. t.Errorf("timeout")
  1789. }
  1790. }
  1791. // Test concurrent requests with Transport.DisableKeepAlives. We can share connections,
  1792. // but when things are totally idle, it still needs to close.
  1793. func TestTransportDisableKeepAlives_Concurrency(t *testing.T) {
  1794. const D = 25 * time.Millisecond
  1795. st := newServerTester(t,
  1796. func(w http.ResponseWriter, r *http.Request) {
  1797. time.Sleep(D)
  1798. io.WriteString(w, "hi")
  1799. },
  1800. optOnlyServer,
  1801. )
  1802. defer st.Close()
  1803. var dials int32
  1804. var conns sync.WaitGroup
  1805. tr := &Transport{
  1806. t1: &http.Transport{
  1807. DisableKeepAlives: true,
  1808. },
  1809. TLSClientConfig: tlsConfigInsecure,
  1810. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1811. tc, err := tls.Dial(network, addr, cfg)
  1812. if err != nil {
  1813. return nil, err
  1814. }
  1815. atomic.AddInt32(&dials, 1)
  1816. conns.Add(1)
  1817. return &noteCloseConn{Conn: tc, closefn: func() { conns.Done() }}, nil
  1818. },
  1819. }
  1820. c := &http.Client{Transport: tr}
  1821. var reqs sync.WaitGroup
  1822. const N = 20
  1823. for i := 0; i < N; i++ {
  1824. reqs.Add(1)
  1825. if i == N-1 {
  1826. // For the final request, try to make all the
  1827. // others close. This isn't verified in the
  1828. // count, other than the Log statement, since
  1829. // it's so timing dependent. This test is
  1830. // really to make sure we don't interrupt a
  1831. // valid request.
  1832. time.Sleep(D * 2)
  1833. }
  1834. go func() {
  1835. defer reqs.Done()
  1836. res, err := c.Get(st.ts.URL)
  1837. if err != nil {
  1838. t.Error(err)
  1839. return
  1840. }
  1841. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1842. t.Error(err)
  1843. return
  1844. }
  1845. res.Body.Close()
  1846. }()
  1847. }
  1848. reqs.Wait()
  1849. conns.Wait()
  1850. t.Logf("did %d dials, %d requests", atomic.LoadInt32(&dials), N)
  1851. }
  1852. type noteCloseConn struct {
  1853. net.Conn
  1854. onceClose sync.Once
  1855. closefn func()
  1856. }
  1857. func (c *noteCloseConn) Close() error {
  1858. c.onceClose.Do(c.closefn)
  1859. return c.Conn.Close()
  1860. }
  1861. func isTimeout(err error) bool {
  1862. switch err := err.(type) {
  1863. case nil:
  1864. return false
  1865. case *url.Error:
  1866. return isTimeout(err.Err)
  1867. case net.Error:
  1868. return err.Timeout()
  1869. }
  1870. return false
  1871. }
  1872. // Test that the http1 Transport.ResponseHeaderTimeout option and cancel is sent.
  1873. func TestTransportResponseHeaderTimeout_NoBody(t *testing.T) {
  1874. testTransportResponseHeaderTimeout(t, false)
  1875. }
  1876. func TestTransportResponseHeaderTimeout_Body(t *testing.T) {
  1877. testTransportResponseHeaderTimeout(t, true)
  1878. }
  1879. func testTransportResponseHeaderTimeout(t *testing.T, body bool) {
  1880. ct := newClientTester(t)
  1881. ct.tr.t1 = &http.Transport{
  1882. ResponseHeaderTimeout: 5 * time.Millisecond,
  1883. }
  1884. ct.client = func() error {
  1885. c := &http.Client{Transport: ct.tr}
  1886. var err error
  1887. var n int64
  1888. const bodySize = 4 << 20
  1889. if body {
  1890. _, err = c.Post("https://dummy.tld/", "text/foo", io.LimitReader(countingReader{&n}, bodySize))
  1891. } else {
  1892. _, err = c.Get("https://dummy.tld/")
  1893. }
  1894. if !isTimeout(err) {
  1895. t.Errorf("client expected timeout error; got %#v", err)
  1896. }
  1897. if body && n != bodySize {
  1898. t.Errorf("only read %d bytes of body; want %d", n, bodySize)
  1899. }
  1900. return nil
  1901. }
  1902. ct.server = func() error {
  1903. ct.greet()
  1904. for {
  1905. f, err := ct.fr.ReadFrame()
  1906. if err != nil {
  1907. t.Logf("ReadFrame: %v", err)
  1908. return nil
  1909. }
  1910. switch f := f.(type) {
  1911. case *DataFrame:
  1912. dataLen := len(f.Data())
  1913. if dataLen > 0 {
  1914. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  1915. return err
  1916. }
  1917. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  1918. return err
  1919. }
  1920. }
  1921. case *RSTStreamFrame:
  1922. if f.StreamID == 1 && f.ErrCode == ErrCodeCancel {
  1923. return nil
  1924. }
  1925. }
  1926. }
  1927. }
  1928. ct.run()
  1929. }
  1930. func TestTransportDisableCompression(t *testing.T) {
  1931. const body = "sup"
  1932. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1933. want := http.Header{
  1934. "User-Agent": []string{"Go-http-client/2.0"},
  1935. }
  1936. if !reflect.DeepEqual(r.Header, want) {
  1937. t.Errorf("request headers = %v; want %v", r.Header, want)
  1938. }
  1939. }, optOnlyServer)
  1940. defer st.Close()
  1941. tr := &Transport{
  1942. TLSClientConfig: tlsConfigInsecure,
  1943. t1: &http.Transport{
  1944. DisableCompression: true,
  1945. },
  1946. }
  1947. defer tr.CloseIdleConnections()
  1948. req, err := http.NewRequest("GET", st.ts.URL, nil)
  1949. if err != nil {
  1950. t.Fatal(err)
  1951. }
  1952. res, err := tr.RoundTrip(req)
  1953. if err != nil {
  1954. t.Fatal(err)
  1955. }
  1956. defer res.Body.Close()
  1957. }
  1958. // RFC 7540 section 8.1.2.2
  1959. func TestTransportRejectsConnHeaders(t *testing.T) {
  1960. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1961. var got []string
  1962. for k := range r.Header {
  1963. got = append(got, k)
  1964. }
  1965. sort.Strings(got)
  1966. w.Header().Set("Got-Header", strings.Join(got, ","))
  1967. }, optOnlyServer)
  1968. defer st.Close()
  1969. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1970. defer tr.CloseIdleConnections()
  1971. tests := []struct {
  1972. key string
  1973. value []string
  1974. want string
  1975. }{
  1976. {
  1977. key: "Upgrade",
  1978. value: []string{"anything"},
  1979. want: "ERROR: http2: invalid Upgrade request header: [\"anything\"]",
  1980. },
  1981. {
  1982. key: "Connection",
  1983. value: []string{"foo"},
  1984. want: "ERROR: http2: invalid Connection request header: [\"foo\"]",
  1985. },
  1986. {
  1987. key: "Connection",
  1988. value: []string{"close"},
  1989. want: "Accept-Encoding,User-Agent",
  1990. },
  1991. {
  1992. key: "Connection",
  1993. value: []string{"CLoSe"},
  1994. want: "Accept-Encoding,User-Agent",
  1995. },
  1996. {
  1997. key: "Connection",
  1998. value: []string{"close", "something-else"},
  1999. want: "ERROR: http2: invalid Connection request header: [\"close\" \"something-else\"]",
  2000. },
  2001. {
  2002. key: "Connection",
  2003. value: []string{"keep-alive"},
  2004. want: "Accept-Encoding,User-Agent",
  2005. },
  2006. {
  2007. key: "Connection",
  2008. value: []string{"Keep-ALIVE"},
  2009. want: "Accept-Encoding,User-Agent",
  2010. },
  2011. {
  2012. key: "Proxy-Connection", // just deleted and ignored
  2013. value: []string{"keep-alive"},
  2014. want: "Accept-Encoding,User-Agent",
  2015. },
  2016. {
  2017. key: "Transfer-Encoding",
  2018. value: []string{""},
  2019. want: "Accept-Encoding,User-Agent",
  2020. },
  2021. {
  2022. key: "Transfer-Encoding",
  2023. value: []string{"foo"},
  2024. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"foo\"]",
  2025. },
  2026. {
  2027. key: "Transfer-Encoding",
  2028. value: []string{"chunked"},
  2029. want: "Accept-Encoding,User-Agent",
  2030. },
  2031. {
  2032. key: "Transfer-Encoding",
  2033. value: []string{"chunked", "other"},
  2034. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"chunked\" \"other\"]",
  2035. },
  2036. {
  2037. key: "Content-Length",
  2038. value: []string{"123"},
  2039. want: "Accept-Encoding,User-Agent",
  2040. },
  2041. {
  2042. key: "Keep-Alive",
  2043. value: []string{"doop"},
  2044. want: "Accept-Encoding,User-Agent",
  2045. },
  2046. }
  2047. for _, tt := range tests {
  2048. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2049. req.Header[tt.key] = tt.value
  2050. res, err := tr.RoundTrip(req)
  2051. var got string
  2052. if err != nil {
  2053. got = fmt.Sprintf("ERROR: %v", err)
  2054. } else {
  2055. got = res.Header.Get("Got-Header")
  2056. res.Body.Close()
  2057. }
  2058. if got != tt.want {
  2059. t.Errorf("For key %q, value %q, got = %q; want %q", tt.key, tt.value, got, tt.want)
  2060. }
  2061. }
  2062. }
  2063. // golang.org/issue/14048
  2064. func TestTransportFailsOnInvalidHeaders(t *testing.T) {
  2065. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2066. var got []string
  2067. for k := range r.Header {
  2068. got = append(got, k)
  2069. }
  2070. sort.Strings(got)
  2071. w.Header().Set("Got-Header", strings.Join(got, ","))
  2072. }, optOnlyServer)
  2073. defer st.Close()
  2074. tests := [...]struct {
  2075. h http.Header
  2076. wantErr string
  2077. }{
  2078. 0: {
  2079. h: http.Header{"with space": {"foo"}},
  2080. wantErr: `invalid HTTP header name "with space"`,
  2081. },
  2082. 1: {
  2083. h: http.Header{"name": {"Брэд"}},
  2084. wantErr: "", // okay
  2085. },
  2086. 2: {
  2087. h: http.Header{"имя": {"Brad"}},
  2088. wantErr: `invalid HTTP header name "имя"`,
  2089. },
  2090. 3: {
  2091. h: http.Header{"foo": {"foo\x01bar"}},
  2092. wantErr: `invalid HTTP header value "foo\x01bar" for header "foo"`,
  2093. },
  2094. }
  2095. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2096. defer tr.CloseIdleConnections()
  2097. for i, tt := range tests {
  2098. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2099. req.Header = tt.h
  2100. res, err := tr.RoundTrip(req)
  2101. var bad bool
  2102. if tt.wantErr == "" {
  2103. if err != nil {
  2104. bad = true
  2105. t.Errorf("case %d: error = %v; want no error", i, err)
  2106. }
  2107. } else {
  2108. if !strings.Contains(fmt.Sprint(err), tt.wantErr) {
  2109. bad = true
  2110. t.Errorf("case %d: error = %v; want error %q", i, err, tt.wantErr)
  2111. }
  2112. }
  2113. if err == nil {
  2114. if bad {
  2115. t.Logf("case %d: server got headers %q", i, res.Header.Get("Got-Header"))
  2116. }
  2117. res.Body.Close()
  2118. }
  2119. }
  2120. }
  2121. // Tests that gzipReader doesn't crash on a second Read call following
  2122. // the first Read call's gzip.NewReader returning an error.
  2123. func TestGzipReader_DoubleReadCrash(t *testing.T) {
  2124. gz := &gzipReader{
  2125. body: ioutil.NopCloser(strings.NewReader("0123456789")),
  2126. }
  2127. var buf [1]byte
  2128. n, err1 := gz.Read(buf[:])
  2129. if n != 0 || !strings.Contains(fmt.Sprint(err1), "invalid header") {
  2130. t.Fatalf("Read = %v, %v; want 0, invalid header", n, err1)
  2131. }
  2132. n, err2 := gz.Read(buf[:])
  2133. if n != 0 || err2 != err1 {
  2134. t.Fatalf("second Read = %v, %v; want 0, %v", n, err2, err1)
  2135. }
  2136. }
  2137. func TestTransportNewTLSConfig(t *testing.T) {
  2138. tests := [...]struct {
  2139. conf *tls.Config
  2140. host string
  2141. want *tls.Config
  2142. }{
  2143. // Normal case.
  2144. 0: {
  2145. conf: nil,
  2146. host: "foo.com",
  2147. want: &tls.Config{
  2148. ServerName: "foo.com",
  2149. NextProtos: []string{NextProtoTLS},
  2150. },
  2151. },
  2152. // User-provided name (bar.com) takes precedence:
  2153. 1: {
  2154. conf: &tls.Config{
  2155. ServerName: "bar.com",
  2156. },
  2157. host: "foo.com",
  2158. want: &tls.Config{
  2159. ServerName: "bar.com",
  2160. NextProtos: []string{NextProtoTLS},
  2161. },
  2162. },
  2163. // NextProto is prepended:
  2164. 2: {
  2165. conf: &tls.Config{
  2166. NextProtos: []string{"foo", "bar"},
  2167. },
  2168. host: "example.com",
  2169. want: &tls.Config{
  2170. ServerName: "example.com",
  2171. NextProtos: []string{NextProtoTLS, "foo", "bar"},
  2172. },
  2173. },
  2174. // NextProto is not duplicated:
  2175. 3: {
  2176. conf: &tls.Config{
  2177. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2178. },
  2179. host: "example.com",
  2180. want: &tls.Config{
  2181. ServerName: "example.com",
  2182. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2183. },
  2184. },
  2185. }
  2186. for i, tt := range tests {
  2187. // Ignore the session ticket keys part, which ends up populating
  2188. // unexported fields in the Config:
  2189. if tt.conf != nil {
  2190. tt.conf.SessionTicketsDisabled = true
  2191. }
  2192. tr := &Transport{TLSClientConfig: tt.conf}
  2193. got := tr.newTLSConfig(tt.host)
  2194. got.SessionTicketsDisabled = false
  2195. if !reflect.DeepEqual(got, tt.want) {
  2196. t.Errorf("%d. got %#v; want %#v", i, got, tt.want)
  2197. }
  2198. }
  2199. }
  2200. // The Google GFE responds to HEAD requests with a HEADERS frame
  2201. // without END_STREAM, followed by a 0-length DATA frame with
  2202. // END_STREAM. Make sure we don't get confused by that. (We did.)
  2203. func TestTransportReadHeadResponse(t *testing.T) {
  2204. ct := newClientTester(t)
  2205. clientDone := make(chan struct{})
  2206. ct.client = func() error {
  2207. defer close(clientDone)
  2208. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2209. res, err := ct.tr.RoundTrip(req)
  2210. if err != nil {
  2211. return err
  2212. }
  2213. if res.ContentLength != 123 {
  2214. return fmt.Errorf("Content-Length = %d; want 123", res.ContentLength)
  2215. }
  2216. slurp, err := ioutil.ReadAll(res.Body)
  2217. if err != nil {
  2218. return fmt.Errorf("ReadAll: %v", err)
  2219. }
  2220. if len(slurp) > 0 {
  2221. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2222. }
  2223. return nil
  2224. }
  2225. ct.server = func() error {
  2226. ct.greet()
  2227. for {
  2228. f, err := ct.fr.ReadFrame()
  2229. if err != nil {
  2230. t.Logf("ReadFrame: %v", err)
  2231. return nil
  2232. }
  2233. hf, ok := f.(*HeadersFrame)
  2234. if !ok {
  2235. continue
  2236. }
  2237. var buf bytes.Buffer
  2238. enc := hpack.NewEncoder(&buf)
  2239. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2240. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2241. ct.fr.WriteHeaders(HeadersFrameParam{
  2242. StreamID: hf.StreamID,
  2243. EndHeaders: true,
  2244. EndStream: false, // as the GFE does
  2245. BlockFragment: buf.Bytes(),
  2246. })
  2247. ct.fr.WriteData(hf.StreamID, true, nil)
  2248. <-clientDone
  2249. return nil
  2250. }
  2251. }
  2252. ct.run()
  2253. }
  2254. func TestTransportReadHeadResponseWithBody(t *testing.T) {
  2255. // This test use not valid response format.
  2256. // Discarding logger output to not spam tests output.
  2257. log.SetOutput(ioutil.Discard)
  2258. defer log.SetOutput(os.Stderr)
  2259. response := "redirecting to /elsewhere"
  2260. ct := newClientTester(t)
  2261. clientDone := make(chan struct{})
  2262. ct.client = func() error {
  2263. defer close(clientDone)
  2264. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2265. res, err := ct.tr.RoundTrip(req)
  2266. if err != nil {
  2267. return err
  2268. }
  2269. if res.ContentLength != int64(len(response)) {
  2270. return fmt.Errorf("Content-Length = %d; want %d", res.ContentLength, len(response))
  2271. }
  2272. slurp, err := ioutil.ReadAll(res.Body)
  2273. if err != nil {
  2274. return fmt.Errorf("ReadAll: %v", err)
  2275. }
  2276. if len(slurp) > 0 {
  2277. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2278. }
  2279. return nil
  2280. }
  2281. ct.server = func() error {
  2282. ct.greet()
  2283. for {
  2284. f, err := ct.fr.ReadFrame()
  2285. if err != nil {
  2286. t.Logf("ReadFrame: %v", err)
  2287. return nil
  2288. }
  2289. hf, ok := f.(*HeadersFrame)
  2290. if !ok {
  2291. continue
  2292. }
  2293. var buf bytes.Buffer
  2294. enc := hpack.NewEncoder(&buf)
  2295. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2296. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: strconv.Itoa(len(response))})
  2297. ct.fr.WriteHeaders(HeadersFrameParam{
  2298. StreamID: hf.StreamID,
  2299. EndHeaders: true,
  2300. EndStream: false,
  2301. BlockFragment: buf.Bytes(),
  2302. })
  2303. ct.fr.WriteData(hf.StreamID, true, []byte(response))
  2304. <-clientDone
  2305. return nil
  2306. }
  2307. }
  2308. ct.run()
  2309. }
  2310. type neverEnding byte
  2311. func (b neverEnding) Read(p []byte) (int, error) {
  2312. for i := range p {
  2313. p[i] = byte(b)
  2314. }
  2315. return len(p), nil
  2316. }
  2317. // golang.org/issue/15425: test that a handler closing the request
  2318. // body doesn't terminate the stream to the peer. (It just stops
  2319. // readability from the handler's side, and eventually the client
  2320. // runs out of flow control tokens)
  2321. func TestTransportHandlerBodyClose(t *testing.T) {
  2322. const bodySize = 10 << 20
  2323. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2324. r.Body.Close()
  2325. io.Copy(w, io.LimitReader(neverEnding('A'), bodySize))
  2326. }, optOnlyServer)
  2327. defer st.Close()
  2328. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2329. defer tr.CloseIdleConnections()
  2330. g0 := runtime.NumGoroutine()
  2331. const numReq = 10
  2332. for i := 0; i < numReq; i++ {
  2333. req, err := http.NewRequest("POST", st.ts.URL, struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2334. if err != nil {
  2335. t.Fatal(err)
  2336. }
  2337. res, err := tr.RoundTrip(req)
  2338. if err != nil {
  2339. t.Fatal(err)
  2340. }
  2341. n, err := io.Copy(ioutil.Discard, res.Body)
  2342. res.Body.Close()
  2343. if n != bodySize || err != nil {
  2344. t.Fatalf("req#%d: Copy = %d, %v; want %d, nil", i, n, err, bodySize)
  2345. }
  2346. }
  2347. tr.CloseIdleConnections()
  2348. if !waitCondition(5*time.Second, 100*time.Millisecond, func() bool {
  2349. gd := runtime.NumGoroutine() - g0
  2350. return gd < numReq/2
  2351. }) {
  2352. t.Errorf("appeared to leak goroutines")
  2353. }
  2354. }
  2355. // https://golang.org/issue/15930
  2356. func TestTransportFlowControl(t *testing.T) {
  2357. const bufLen = 64 << 10
  2358. var total int64 = 100 << 20 // 100MB
  2359. if testing.Short() {
  2360. total = 10 << 20
  2361. }
  2362. var wrote int64 // updated atomically
  2363. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2364. b := make([]byte, bufLen)
  2365. for wrote < total {
  2366. n, err := w.Write(b)
  2367. atomic.AddInt64(&wrote, int64(n))
  2368. if err != nil {
  2369. t.Errorf("ResponseWriter.Write error: %v", err)
  2370. break
  2371. }
  2372. w.(http.Flusher).Flush()
  2373. }
  2374. }, optOnlyServer)
  2375. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2376. defer tr.CloseIdleConnections()
  2377. req, err := http.NewRequest("GET", st.ts.URL, nil)
  2378. if err != nil {
  2379. t.Fatal("NewRequest error:", err)
  2380. }
  2381. resp, err := tr.RoundTrip(req)
  2382. if err != nil {
  2383. t.Fatal("RoundTrip error:", err)
  2384. }
  2385. defer resp.Body.Close()
  2386. var read int64
  2387. b := make([]byte, bufLen)
  2388. for {
  2389. n, err := resp.Body.Read(b)
  2390. if err == io.EOF {
  2391. break
  2392. }
  2393. if err != nil {
  2394. t.Fatal("Read error:", err)
  2395. }
  2396. read += int64(n)
  2397. const max = transportDefaultStreamFlow
  2398. if w := atomic.LoadInt64(&wrote); -max > read-w || read-w > max {
  2399. t.Fatalf("Too much data inflight: server wrote %v bytes but client only received %v", w, read)
  2400. }
  2401. // Let the server get ahead of the client.
  2402. time.Sleep(1 * time.Millisecond)
  2403. }
  2404. }
  2405. // golang.org/issue/14627 -- if the server sends a GOAWAY frame, make
  2406. // the Transport remember it and return it back to users (via
  2407. // RoundTrip or request body reads) if needed (e.g. if the server
  2408. // proceeds to close the TCP connection before the client gets its
  2409. // response)
  2410. func TestTransportUsesGoAwayDebugError_RoundTrip(t *testing.T) {
  2411. testTransportUsesGoAwayDebugError(t, false)
  2412. }
  2413. func TestTransportUsesGoAwayDebugError_Body(t *testing.T) {
  2414. testTransportUsesGoAwayDebugError(t, true)
  2415. }
  2416. func testTransportUsesGoAwayDebugError(t *testing.T, failMidBody bool) {
  2417. ct := newClientTester(t)
  2418. clientDone := make(chan struct{})
  2419. const goAwayErrCode = ErrCodeHTTP11Required // arbitrary
  2420. const goAwayDebugData = "some debug data"
  2421. ct.client = func() error {
  2422. defer close(clientDone)
  2423. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2424. res, err := ct.tr.RoundTrip(req)
  2425. if failMidBody {
  2426. if err != nil {
  2427. return fmt.Errorf("unexpected client RoundTrip error: %v", err)
  2428. }
  2429. _, err = io.Copy(ioutil.Discard, res.Body)
  2430. res.Body.Close()
  2431. }
  2432. want := GoAwayError{
  2433. LastStreamID: 5,
  2434. ErrCode: goAwayErrCode,
  2435. DebugData: goAwayDebugData,
  2436. }
  2437. if !reflect.DeepEqual(err, want) {
  2438. t.Errorf("RoundTrip error = %T: %#v, want %T (%#v)", err, err, want, want)
  2439. }
  2440. return nil
  2441. }
  2442. ct.server = func() error {
  2443. ct.greet()
  2444. for {
  2445. f, err := ct.fr.ReadFrame()
  2446. if err != nil {
  2447. t.Logf("ReadFrame: %v", err)
  2448. return nil
  2449. }
  2450. hf, ok := f.(*HeadersFrame)
  2451. if !ok {
  2452. continue
  2453. }
  2454. if failMidBody {
  2455. var buf bytes.Buffer
  2456. enc := hpack.NewEncoder(&buf)
  2457. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2458. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2459. ct.fr.WriteHeaders(HeadersFrameParam{
  2460. StreamID: hf.StreamID,
  2461. EndHeaders: true,
  2462. EndStream: false,
  2463. BlockFragment: buf.Bytes(),
  2464. })
  2465. }
  2466. // Write two GOAWAY frames, to test that the Transport takes
  2467. // the interesting parts of both.
  2468. ct.fr.WriteGoAway(5, ErrCodeNo, []byte(goAwayDebugData))
  2469. ct.fr.WriteGoAway(5, goAwayErrCode, nil)
  2470. ct.sc.(*net.TCPConn).CloseWrite()
  2471. <-clientDone
  2472. return nil
  2473. }
  2474. }
  2475. ct.run()
  2476. }
  2477. func testTransportReturnsUnusedFlowControl(t *testing.T, oneDataFrame bool) {
  2478. ct := newClientTester(t)
  2479. clientClosed := make(chan struct{})
  2480. serverWroteFirstByte := make(chan struct{})
  2481. ct.client = func() error {
  2482. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2483. res, err := ct.tr.RoundTrip(req)
  2484. if err != nil {
  2485. return err
  2486. }
  2487. <-serverWroteFirstByte
  2488. if n, err := res.Body.Read(make([]byte, 1)); err != nil || n != 1 {
  2489. return fmt.Errorf("body read = %v, %v; want 1, nil", n, err)
  2490. }
  2491. res.Body.Close() // leaving 4999 bytes unread
  2492. close(clientClosed)
  2493. return nil
  2494. }
  2495. ct.server = func() error {
  2496. ct.greet()
  2497. var hf *HeadersFrame
  2498. for {
  2499. f, err := ct.fr.ReadFrame()
  2500. if err != nil {
  2501. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2502. }
  2503. switch f.(type) {
  2504. case *WindowUpdateFrame, *SettingsFrame:
  2505. continue
  2506. }
  2507. var ok bool
  2508. hf, ok = f.(*HeadersFrame)
  2509. if !ok {
  2510. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2511. }
  2512. break
  2513. }
  2514. var buf bytes.Buffer
  2515. enc := hpack.NewEncoder(&buf)
  2516. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2517. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2518. ct.fr.WriteHeaders(HeadersFrameParam{
  2519. StreamID: hf.StreamID,
  2520. EndHeaders: true,
  2521. EndStream: false,
  2522. BlockFragment: buf.Bytes(),
  2523. })
  2524. // Two cases:
  2525. // - Send one DATA frame with 5000 bytes.
  2526. // - Send two DATA frames with 1 and 4999 bytes each.
  2527. //
  2528. // In both cases, the client should consume one byte of data,
  2529. // refund that byte, then refund the following 4999 bytes.
  2530. //
  2531. // In the second case, the server waits for the client connection to
  2532. // close before seconding the second DATA frame. This tests the case
  2533. // where the client receives a DATA frame after it has reset the stream.
  2534. if oneDataFrame {
  2535. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 5000))
  2536. close(serverWroteFirstByte)
  2537. <-clientClosed
  2538. } else {
  2539. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 1))
  2540. close(serverWroteFirstByte)
  2541. <-clientClosed
  2542. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 4999))
  2543. }
  2544. waitingFor := "RSTStreamFrame"
  2545. for {
  2546. f, err := ct.fr.ReadFrame()
  2547. if err != nil {
  2548. return fmt.Errorf("ReadFrame while waiting for %s: %v", waitingFor, err)
  2549. }
  2550. if _, ok := f.(*SettingsFrame); ok {
  2551. continue
  2552. }
  2553. switch waitingFor {
  2554. case "RSTStreamFrame":
  2555. if rf, ok := f.(*RSTStreamFrame); !ok || rf.ErrCode != ErrCodeCancel {
  2556. return fmt.Errorf("Expected a RSTStreamFrame with code cancel; got %v", summarizeFrame(f))
  2557. }
  2558. waitingFor = "WindowUpdateFrame"
  2559. case "WindowUpdateFrame":
  2560. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != 4999 {
  2561. return fmt.Errorf("Expected WindowUpdateFrame for 4999 bytes; got %v", summarizeFrame(f))
  2562. }
  2563. return nil
  2564. }
  2565. }
  2566. }
  2567. ct.run()
  2568. }
  2569. // See golang.org/issue/16481
  2570. func TestTransportReturnsUnusedFlowControlSingleWrite(t *testing.T) {
  2571. testTransportReturnsUnusedFlowControl(t, true)
  2572. }
  2573. // See golang.org/issue/20469
  2574. func TestTransportReturnsUnusedFlowControlMultipleWrites(t *testing.T) {
  2575. testTransportReturnsUnusedFlowControl(t, false)
  2576. }
  2577. // Issue 16612: adjust flow control on open streams when transport
  2578. // receives SETTINGS with INITIAL_WINDOW_SIZE from server.
  2579. func TestTransportAdjustsFlowControl(t *testing.T) {
  2580. ct := newClientTester(t)
  2581. clientDone := make(chan struct{})
  2582. const bodySize = 1 << 20
  2583. ct.client = func() error {
  2584. defer ct.cc.(*net.TCPConn).CloseWrite()
  2585. defer close(clientDone)
  2586. req, _ := http.NewRequest("POST", "https://dummy.tld/", struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2587. res, err := ct.tr.RoundTrip(req)
  2588. if err != nil {
  2589. return err
  2590. }
  2591. res.Body.Close()
  2592. return nil
  2593. }
  2594. ct.server = func() error {
  2595. _, err := io.ReadFull(ct.sc, make([]byte, len(ClientPreface)))
  2596. if err != nil {
  2597. return fmt.Errorf("reading client preface: %v", err)
  2598. }
  2599. var gotBytes int64
  2600. var sentSettings bool
  2601. for {
  2602. f, err := ct.fr.ReadFrame()
  2603. if err != nil {
  2604. select {
  2605. case <-clientDone:
  2606. return nil
  2607. default:
  2608. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2609. }
  2610. }
  2611. switch f := f.(type) {
  2612. case *DataFrame:
  2613. gotBytes += int64(len(f.Data()))
  2614. // After we've got half the client's
  2615. // initial flow control window's worth
  2616. // of request body data, give it just
  2617. // enough flow control to finish.
  2618. if gotBytes >= initialWindowSize/2 && !sentSettings {
  2619. sentSettings = true
  2620. ct.fr.WriteSettings(Setting{ID: SettingInitialWindowSize, Val: bodySize})
  2621. ct.fr.WriteWindowUpdate(0, bodySize)
  2622. ct.fr.WriteSettingsAck()
  2623. }
  2624. if f.StreamEnded() {
  2625. var buf bytes.Buffer
  2626. enc := hpack.NewEncoder(&buf)
  2627. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2628. ct.fr.WriteHeaders(HeadersFrameParam{
  2629. StreamID: f.StreamID,
  2630. EndHeaders: true,
  2631. EndStream: true,
  2632. BlockFragment: buf.Bytes(),
  2633. })
  2634. }
  2635. }
  2636. }
  2637. }
  2638. ct.run()
  2639. }
  2640. // See golang.org/issue/16556
  2641. func TestTransportReturnsDataPaddingFlowControl(t *testing.T) {
  2642. ct := newClientTester(t)
  2643. unblockClient := make(chan bool, 1)
  2644. ct.client = func() error {
  2645. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2646. res, err := ct.tr.RoundTrip(req)
  2647. if err != nil {
  2648. return err
  2649. }
  2650. defer res.Body.Close()
  2651. <-unblockClient
  2652. return nil
  2653. }
  2654. ct.server = func() error {
  2655. ct.greet()
  2656. var hf *HeadersFrame
  2657. for {
  2658. f, err := ct.fr.ReadFrame()
  2659. if err != nil {
  2660. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2661. }
  2662. switch f.(type) {
  2663. case *WindowUpdateFrame, *SettingsFrame:
  2664. continue
  2665. }
  2666. var ok bool
  2667. hf, ok = f.(*HeadersFrame)
  2668. if !ok {
  2669. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2670. }
  2671. break
  2672. }
  2673. var buf bytes.Buffer
  2674. enc := hpack.NewEncoder(&buf)
  2675. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2676. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2677. ct.fr.WriteHeaders(HeadersFrameParam{
  2678. StreamID: hf.StreamID,
  2679. EndHeaders: true,
  2680. EndStream: false,
  2681. BlockFragment: buf.Bytes(),
  2682. })
  2683. pad := make([]byte, 5)
  2684. ct.fr.WriteDataPadded(hf.StreamID, false, make([]byte, 5000), pad) // without ending stream
  2685. f, err := ct.readNonSettingsFrame()
  2686. if err != nil {
  2687. return fmt.Errorf("ReadFrame while waiting for first WindowUpdateFrame: %v", err)
  2688. }
  2689. wantBack := uint32(len(pad)) + 1 // one byte for the length of the padding
  2690. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID != 0 {
  2691. return fmt.Errorf("Expected conn WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2692. }
  2693. f, err = ct.readNonSettingsFrame()
  2694. if err != nil {
  2695. return fmt.Errorf("ReadFrame while waiting for second WindowUpdateFrame: %v", err)
  2696. }
  2697. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID == 0 {
  2698. return fmt.Errorf("Expected stream WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2699. }
  2700. unblockClient <- true
  2701. return nil
  2702. }
  2703. ct.run()
  2704. }
  2705. // golang.org/issue/16572 -- RoundTrip shouldn't hang when it gets a
  2706. // StreamError as a result of the response HEADERS
  2707. func TestTransportReturnsErrorOnBadResponseHeaders(t *testing.T) {
  2708. ct := newClientTester(t)
  2709. ct.client = func() error {
  2710. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2711. res, err := ct.tr.RoundTrip(req)
  2712. if err == nil {
  2713. res.Body.Close()
  2714. return errors.New("unexpected successful GET")
  2715. }
  2716. want := StreamError{1, ErrCodeProtocol, headerFieldNameError(" content-type")}
  2717. if !reflect.DeepEqual(want, err) {
  2718. t.Errorf("RoundTrip error = %#v; want %#v", err, want)
  2719. }
  2720. return nil
  2721. }
  2722. ct.server = func() error {
  2723. ct.greet()
  2724. hf, err := ct.firstHeaders()
  2725. if err != nil {
  2726. return err
  2727. }
  2728. var buf bytes.Buffer
  2729. enc := hpack.NewEncoder(&buf)
  2730. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2731. enc.WriteField(hpack.HeaderField{Name: " content-type", Value: "bogus"}) // bogus spaces
  2732. ct.fr.WriteHeaders(HeadersFrameParam{
  2733. StreamID: hf.StreamID,
  2734. EndHeaders: true,
  2735. EndStream: false,
  2736. BlockFragment: buf.Bytes(),
  2737. })
  2738. for {
  2739. fr, err := ct.readFrame()
  2740. if err != nil {
  2741. return fmt.Errorf("error waiting for RST_STREAM from client: %v", err)
  2742. }
  2743. if _, ok := fr.(*SettingsFrame); ok {
  2744. continue
  2745. }
  2746. if rst, ok := fr.(*RSTStreamFrame); !ok || rst.StreamID != 1 || rst.ErrCode != ErrCodeProtocol {
  2747. t.Errorf("Frame = %v; want RST_STREAM for stream 1 with ErrCodeProtocol", summarizeFrame(fr))
  2748. }
  2749. break
  2750. }
  2751. return nil
  2752. }
  2753. ct.run()
  2754. }
  2755. // byteAndEOFReader returns is in an io.Reader which reads one byte
  2756. // (the underlying byte) and io.EOF at once in its Read call.
  2757. type byteAndEOFReader byte
  2758. func (b byteAndEOFReader) Read(p []byte) (n int, err error) {
  2759. if len(p) == 0 {
  2760. panic("unexpected useless call")
  2761. }
  2762. p[0] = byte(b)
  2763. return 1, io.EOF
  2764. }
  2765. // Issue 16788: the Transport had a regression where it started
  2766. // sending a spurious DATA frame with a duplicate END_STREAM bit after
  2767. // the request body writer goroutine had already read an EOF from the
  2768. // Request.Body and included the END_STREAM on a data-carrying DATA
  2769. // frame.
  2770. //
  2771. // Notably, to trigger this, the requests need to use a Request.Body
  2772. // which returns (non-0, io.EOF) and also needs to set the ContentLength
  2773. // explicitly.
  2774. func TestTransportBodyDoubleEndStream(t *testing.T) {
  2775. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2776. // Nothing.
  2777. }, optOnlyServer)
  2778. defer st.Close()
  2779. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2780. defer tr.CloseIdleConnections()
  2781. for i := 0; i < 2; i++ {
  2782. req, _ := http.NewRequest("POST", st.ts.URL, byteAndEOFReader('a'))
  2783. req.ContentLength = 1
  2784. res, err := tr.RoundTrip(req)
  2785. if err != nil {
  2786. t.Fatalf("failure on req %d: %v", i+1, err)
  2787. }
  2788. defer res.Body.Close()
  2789. }
  2790. }
  2791. // golang.org/issue/16847, golang.org/issue/19103
  2792. func TestTransportRequestPathPseudo(t *testing.T) {
  2793. type result struct {
  2794. path string
  2795. err string
  2796. }
  2797. tests := []struct {
  2798. req *http.Request
  2799. want result
  2800. }{
  2801. 0: {
  2802. req: &http.Request{
  2803. Method: "GET",
  2804. URL: &url.URL{
  2805. Host: "foo.com",
  2806. Path: "/foo",
  2807. },
  2808. },
  2809. want: result{path: "/foo"},
  2810. },
  2811. // In Go 1.7, we accepted paths of "//foo".
  2812. // In Go 1.8, we rejected it (issue 16847).
  2813. // In Go 1.9, we accepted it again (issue 19103).
  2814. 1: {
  2815. req: &http.Request{
  2816. Method: "GET",
  2817. URL: &url.URL{
  2818. Host: "foo.com",
  2819. Path: "//foo",
  2820. },
  2821. },
  2822. want: result{path: "//foo"},
  2823. },
  2824. // Opaque with //$Matching_Hostname/path
  2825. 2: {
  2826. req: &http.Request{
  2827. Method: "GET",
  2828. URL: &url.URL{
  2829. Scheme: "https",
  2830. Opaque: "//foo.com/path",
  2831. Host: "foo.com",
  2832. Path: "/ignored",
  2833. },
  2834. },
  2835. want: result{path: "/path"},
  2836. },
  2837. // Opaque with some other Request.Host instead:
  2838. 3: {
  2839. req: &http.Request{
  2840. Method: "GET",
  2841. Host: "bar.com",
  2842. URL: &url.URL{
  2843. Scheme: "https",
  2844. Opaque: "//bar.com/path",
  2845. Host: "foo.com",
  2846. Path: "/ignored",
  2847. },
  2848. },
  2849. want: result{path: "/path"},
  2850. },
  2851. // Opaque without the leading "//":
  2852. 4: {
  2853. req: &http.Request{
  2854. Method: "GET",
  2855. URL: &url.URL{
  2856. Opaque: "/path",
  2857. Host: "foo.com",
  2858. Path: "/ignored",
  2859. },
  2860. },
  2861. want: result{path: "/path"},
  2862. },
  2863. // Opaque we can't handle:
  2864. 5: {
  2865. req: &http.Request{
  2866. Method: "GET",
  2867. URL: &url.URL{
  2868. Scheme: "https",
  2869. Opaque: "//unknown_host/path",
  2870. Host: "foo.com",
  2871. Path: "/ignored",
  2872. },
  2873. },
  2874. want: result{err: `invalid request :path "https://unknown_host/path" from URL.Opaque = "//unknown_host/path"`},
  2875. },
  2876. // A CONNECT request:
  2877. 6: {
  2878. req: &http.Request{
  2879. Method: "CONNECT",
  2880. URL: &url.URL{
  2881. Host: "foo.com",
  2882. },
  2883. },
  2884. want: result{},
  2885. },
  2886. }
  2887. for i, tt := range tests {
  2888. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  2889. cc.henc = hpack.NewEncoder(&cc.hbuf)
  2890. cc.mu.Lock()
  2891. hdrs, err := cc.encodeHeaders(tt.req, false, "", -1)
  2892. cc.mu.Unlock()
  2893. var got result
  2894. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(f hpack.HeaderField) {
  2895. if f.Name == ":path" {
  2896. got.path = f.Value
  2897. }
  2898. })
  2899. if err != nil {
  2900. got.err = err.Error()
  2901. } else if len(hdrs) > 0 {
  2902. if _, err := hpackDec.Write(hdrs); err != nil {
  2903. t.Errorf("%d. bogus hpack: %v", i, err)
  2904. continue
  2905. }
  2906. }
  2907. if got != tt.want {
  2908. t.Errorf("%d. got %+v; want %+v", i, got, tt.want)
  2909. }
  2910. }
  2911. }
  2912. // golang.org/issue/17071 -- don't sniff the first byte of the request body
  2913. // before we've determined that the ClientConn is usable.
  2914. func TestRoundTripDoesntConsumeRequestBodyEarly(t *testing.T) {
  2915. const body = "foo"
  2916. req, _ := http.NewRequest("POST", "http://foo.com/", ioutil.NopCloser(strings.NewReader(body)))
  2917. cc := &ClientConn{
  2918. closed: true,
  2919. }
  2920. _, err := cc.RoundTrip(req)
  2921. if err != errClientConnUnusable {
  2922. t.Fatalf("RoundTrip = %v; want errClientConnUnusable", err)
  2923. }
  2924. slurp, err := ioutil.ReadAll(req.Body)
  2925. if err != nil {
  2926. t.Errorf("ReadAll = %v", err)
  2927. }
  2928. if string(slurp) != body {
  2929. t.Errorf("Body = %q; want %q", slurp, body)
  2930. }
  2931. }
  2932. func TestClientConnPing(t *testing.T) {
  2933. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {}, optOnlyServer)
  2934. defer st.Close()
  2935. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2936. defer tr.CloseIdleConnections()
  2937. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  2938. if err != nil {
  2939. t.Fatal(err)
  2940. }
  2941. if err = cc.Ping(context.Background()); err != nil {
  2942. t.Fatal(err)
  2943. }
  2944. }
  2945. // Issue 16974: if the server sent a DATA frame after the user
  2946. // canceled the Transport's Request, the Transport previously wrote to a
  2947. // closed pipe, got an error, and ended up closing the whole TCP
  2948. // connection.
  2949. func TestTransportCancelDataResponseRace(t *testing.T) {
  2950. cancel := make(chan struct{})
  2951. clientGotError := make(chan bool, 1)
  2952. const msg = "Hello."
  2953. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2954. if strings.Contains(r.URL.Path, "/hello") {
  2955. time.Sleep(50 * time.Millisecond)
  2956. io.WriteString(w, msg)
  2957. return
  2958. }
  2959. for i := 0; i < 50; i++ {
  2960. io.WriteString(w, "Some data.")
  2961. w.(http.Flusher).Flush()
  2962. if i == 2 {
  2963. close(cancel)
  2964. <-clientGotError
  2965. }
  2966. time.Sleep(10 * time.Millisecond)
  2967. }
  2968. }, optOnlyServer)
  2969. defer st.Close()
  2970. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2971. defer tr.CloseIdleConnections()
  2972. c := &http.Client{Transport: tr}
  2973. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2974. req.Cancel = cancel
  2975. res, err := c.Do(req)
  2976. if err != nil {
  2977. t.Fatal(err)
  2978. }
  2979. if _, err = io.Copy(ioutil.Discard, res.Body); err == nil {
  2980. t.Fatal("unexpected success")
  2981. }
  2982. clientGotError <- true
  2983. res, err = c.Get(st.ts.URL + "/hello")
  2984. if err != nil {
  2985. t.Fatal(err)
  2986. }
  2987. slurp, err := ioutil.ReadAll(res.Body)
  2988. if err != nil {
  2989. t.Fatal(err)
  2990. }
  2991. if string(slurp) != msg {
  2992. t.Errorf("Got = %q; want %q", slurp, msg)
  2993. }
  2994. }
  2995. // Issue 21316: It should be safe to reuse an http.Request after the
  2996. // request has completed.
  2997. func TestTransportNoRaceOnRequestObjectAfterRequestComplete(t *testing.T) {
  2998. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2999. w.WriteHeader(200)
  3000. io.WriteString(w, "body")
  3001. }, optOnlyServer)
  3002. defer st.Close()
  3003. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3004. defer tr.CloseIdleConnections()
  3005. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  3006. resp, err := tr.RoundTrip(req)
  3007. if err != nil {
  3008. t.Fatal(err)
  3009. }
  3010. if _, err = io.Copy(ioutil.Discard, resp.Body); err != nil {
  3011. t.Fatalf("error reading response body: %v", err)
  3012. }
  3013. if err := resp.Body.Close(); err != nil {
  3014. t.Fatalf("error closing response body: %v", err)
  3015. }
  3016. // This access of req.Header should not race with code in the transport.
  3017. req.Header = http.Header{}
  3018. }
  3019. func TestTransportRetryAfterGOAWAY(t *testing.T) {
  3020. var dialer struct {
  3021. sync.Mutex
  3022. count int
  3023. }
  3024. ct1 := make(chan *clientTester)
  3025. ct2 := make(chan *clientTester)
  3026. ln := newLocalListener(t)
  3027. defer ln.Close()
  3028. tr := &Transport{
  3029. TLSClientConfig: tlsConfigInsecure,
  3030. }
  3031. tr.DialTLS = func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  3032. dialer.Lock()
  3033. defer dialer.Unlock()
  3034. dialer.count++
  3035. if dialer.count == 3 {
  3036. return nil, errors.New("unexpected number of dials")
  3037. }
  3038. cc, err := net.Dial("tcp", ln.Addr().String())
  3039. if err != nil {
  3040. return nil, fmt.Errorf("dial error: %v", err)
  3041. }
  3042. sc, err := ln.Accept()
  3043. if err != nil {
  3044. return nil, fmt.Errorf("accept error: %v", err)
  3045. }
  3046. ct := &clientTester{
  3047. t: t,
  3048. tr: tr,
  3049. cc: cc,
  3050. sc: sc,
  3051. fr: NewFramer(sc, sc),
  3052. }
  3053. switch dialer.count {
  3054. case 1:
  3055. ct1 <- ct
  3056. case 2:
  3057. ct2 <- ct
  3058. }
  3059. return cc, nil
  3060. }
  3061. errs := make(chan error, 3)
  3062. done := make(chan struct{})
  3063. defer close(done)
  3064. // Client.
  3065. go func() {
  3066. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3067. res, err := tr.RoundTrip(req)
  3068. if res != nil {
  3069. res.Body.Close()
  3070. if got := res.Header.Get("Foo"); got != "bar" {
  3071. err = fmt.Errorf("foo header = %q; want bar", got)
  3072. }
  3073. }
  3074. if err != nil {
  3075. err = fmt.Errorf("RoundTrip: %v", err)
  3076. }
  3077. errs <- err
  3078. }()
  3079. connToClose := make(chan io.Closer, 2)
  3080. // Server for the first request.
  3081. go func() {
  3082. var ct *clientTester
  3083. select {
  3084. case ct = <-ct1:
  3085. case <-done:
  3086. return
  3087. }
  3088. connToClose <- ct.cc
  3089. ct.greet()
  3090. hf, err := ct.firstHeaders()
  3091. if err != nil {
  3092. errs <- fmt.Errorf("server1 failed reading HEADERS: %v", err)
  3093. return
  3094. }
  3095. t.Logf("server1 got %v", hf)
  3096. if err := ct.fr.WriteGoAway(0 /*max id*/, ErrCodeNo, nil); err != nil {
  3097. errs <- fmt.Errorf("server1 failed writing GOAWAY: %v", err)
  3098. return
  3099. }
  3100. errs <- nil
  3101. }()
  3102. // Server for the second request.
  3103. go func() {
  3104. var ct *clientTester
  3105. select {
  3106. case ct = <-ct2:
  3107. case <-done:
  3108. return
  3109. }
  3110. connToClose <- ct.cc
  3111. ct.greet()
  3112. hf, err := ct.firstHeaders()
  3113. if err != nil {
  3114. errs <- fmt.Errorf("server2 failed reading HEADERS: %v", err)
  3115. return
  3116. }
  3117. t.Logf("server2 got %v", hf)
  3118. var buf bytes.Buffer
  3119. enc := hpack.NewEncoder(&buf)
  3120. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3121. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  3122. err = ct.fr.WriteHeaders(HeadersFrameParam{
  3123. StreamID: hf.StreamID,
  3124. EndHeaders: true,
  3125. EndStream: false,
  3126. BlockFragment: buf.Bytes(),
  3127. })
  3128. if err != nil {
  3129. errs <- fmt.Errorf("server2 failed writing response HEADERS: %v", err)
  3130. } else {
  3131. errs <- nil
  3132. }
  3133. }()
  3134. for k := 0; k < 3; k++ {
  3135. select {
  3136. case err := <-errs:
  3137. if err != nil {
  3138. t.Error(err)
  3139. }
  3140. case <-time.After(1 * time.Second):
  3141. t.Errorf("timed out")
  3142. }
  3143. }
  3144. for {
  3145. select {
  3146. case c := <-connToClose:
  3147. c.Close()
  3148. default:
  3149. return
  3150. }
  3151. }
  3152. }
  3153. func TestTransportRetryAfterRefusedStream(t *testing.T) {
  3154. clientDone := make(chan struct{})
  3155. ct := newClientTester(t)
  3156. ct.client = func() error {
  3157. defer ct.cc.(*net.TCPConn).CloseWrite()
  3158. defer close(clientDone)
  3159. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3160. resp, err := ct.tr.RoundTrip(req)
  3161. if err != nil {
  3162. return fmt.Errorf("RoundTrip: %v", err)
  3163. }
  3164. resp.Body.Close()
  3165. if resp.StatusCode != 204 {
  3166. return fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3167. }
  3168. return nil
  3169. }
  3170. ct.server = func() error {
  3171. ct.greet()
  3172. var buf bytes.Buffer
  3173. enc := hpack.NewEncoder(&buf)
  3174. nreq := 0
  3175. for {
  3176. f, err := ct.fr.ReadFrame()
  3177. if err != nil {
  3178. select {
  3179. case <-clientDone:
  3180. // If the client's done, it
  3181. // will have reported any
  3182. // errors on its side.
  3183. return nil
  3184. default:
  3185. return err
  3186. }
  3187. }
  3188. switch f := f.(type) {
  3189. case *WindowUpdateFrame, *SettingsFrame:
  3190. case *HeadersFrame:
  3191. if !f.HeadersEnded() {
  3192. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3193. }
  3194. nreq++
  3195. if nreq == 1 {
  3196. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3197. } else {
  3198. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3199. ct.fr.WriteHeaders(HeadersFrameParam{
  3200. StreamID: f.StreamID,
  3201. EndHeaders: true,
  3202. EndStream: true,
  3203. BlockFragment: buf.Bytes(),
  3204. })
  3205. }
  3206. default:
  3207. return fmt.Errorf("Unexpected client frame %v", f)
  3208. }
  3209. }
  3210. }
  3211. ct.run()
  3212. }
  3213. func TestTransportRetryHasLimit(t *testing.T) {
  3214. // Skip in short mode because the total expected delay is 1s+2s+4s+8s+16s=29s.
  3215. if testing.Short() {
  3216. t.Skip("skipping long test in short mode")
  3217. }
  3218. clientDone := make(chan struct{})
  3219. ct := newClientTester(t)
  3220. ct.client = func() error {
  3221. defer ct.cc.(*net.TCPConn).CloseWrite()
  3222. defer close(clientDone)
  3223. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3224. resp, err := ct.tr.RoundTrip(req)
  3225. if err == nil {
  3226. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3227. }
  3228. t.Logf("expected error, got: %v", err)
  3229. return nil
  3230. }
  3231. ct.server = func() error {
  3232. ct.greet()
  3233. for {
  3234. f, err := ct.fr.ReadFrame()
  3235. if err != nil {
  3236. select {
  3237. case <-clientDone:
  3238. // If the client's done, it
  3239. // will have reported any
  3240. // errors on its side.
  3241. return nil
  3242. default:
  3243. return err
  3244. }
  3245. }
  3246. switch f := f.(type) {
  3247. case *WindowUpdateFrame, *SettingsFrame:
  3248. case *HeadersFrame:
  3249. if !f.HeadersEnded() {
  3250. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3251. }
  3252. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3253. default:
  3254. return fmt.Errorf("Unexpected client frame %v", f)
  3255. }
  3256. }
  3257. }
  3258. ct.run()
  3259. }
  3260. func TestTransportResponseDataBeforeHeaders(t *testing.T) {
  3261. // This test use not valid response format.
  3262. // Discarding logger output to not spam tests output.
  3263. log.SetOutput(ioutil.Discard)
  3264. defer log.SetOutput(os.Stderr)
  3265. ct := newClientTester(t)
  3266. ct.client = func() error {
  3267. defer ct.cc.(*net.TCPConn).CloseWrite()
  3268. req := httptest.NewRequest("GET", "https://dummy.tld/", nil)
  3269. // First request is normal to ensure the check is per stream and not per connection.
  3270. _, err := ct.tr.RoundTrip(req)
  3271. if err != nil {
  3272. return fmt.Errorf("RoundTrip expected no error, got: %v", err)
  3273. }
  3274. // Second request returns a DATA frame with no HEADERS.
  3275. resp, err := ct.tr.RoundTrip(req)
  3276. if err == nil {
  3277. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3278. }
  3279. if err, ok := err.(StreamError); !ok || err.Code != ErrCodeProtocol {
  3280. return fmt.Errorf("expected stream PROTOCOL_ERROR, got: %v", err)
  3281. }
  3282. return nil
  3283. }
  3284. ct.server = func() error {
  3285. ct.greet()
  3286. for {
  3287. f, err := ct.fr.ReadFrame()
  3288. if err == io.EOF {
  3289. return nil
  3290. } else if err != nil {
  3291. return err
  3292. }
  3293. switch f := f.(type) {
  3294. case *WindowUpdateFrame, *SettingsFrame:
  3295. case *HeadersFrame:
  3296. switch f.StreamID {
  3297. case 1:
  3298. // Send a valid response to first request.
  3299. var buf bytes.Buffer
  3300. enc := hpack.NewEncoder(&buf)
  3301. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3302. ct.fr.WriteHeaders(HeadersFrameParam{
  3303. StreamID: f.StreamID,
  3304. EndHeaders: true,
  3305. EndStream: true,
  3306. BlockFragment: buf.Bytes(),
  3307. })
  3308. case 3:
  3309. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3310. }
  3311. default:
  3312. return fmt.Errorf("Unexpected client frame %v", f)
  3313. }
  3314. }
  3315. }
  3316. ct.run()
  3317. }
  3318. // tests Transport.StrictMaxConcurrentStreams
  3319. func TestTransportRequestsStallAtServerLimit(t *testing.T) {
  3320. const maxConcurrent = 2
  3321. greet := make(chan struct{}) // server sends initial SETTINGS frame
  3322. gotRequest := make(chan struct{}) // server received a request
  3323. clientDone := make(chan struct{})
  3324. // Collect errors from goroutines.
  3325. var wg sync.WaitGroup
  3326. errs := make(chan error, 100)
  3327. defer func() {
  3328. wg.Wait()
  3329. close(errs)
  3330. for err := range errs {
  3331. t.Error(err)
  3332. }
  3333. }()
  3334. // We will send maxConcurrent+2 requests. This checker goroutine waits for the
  3335. // following stages:
  3336. // 1. The first maxConcurrent requests are received by the server.
  3337. // 2. The client will cancel the next request
  3338. // 3. The server is unblocked so it can service the first maxConcurrent requests
  3339. // 4. The client will send the final request
  3340. wg.Add(1)
  3341. unblockClient := make(chan struct{})
  3342. clientRequestCancelled := make(chan struct{})
  3343. unblockServer := make(chan struct{})
  3344. go func() {
  3345. defer wg.Done()
  3346. // Stage 1.
  3347. for k := 0; k < maxConcurrent; k++ {
  3348. <-gotRequest
  3349. }
  3350. // Stage 2.
  3351. close(unblockClient)
  3352. <-clientRequestCancelled
  3353. // Stage 3: give some time for the final RoundTrip call to be scheduled and
  3354. // verify that the final request is not sent.
  3355. time.Sleep(50 * time.Millisecond)
  3356. select {
  3357. case <-gotRequest:
  3358. errs <- errors.New("last request did not stall")
  3359. close(unblockServer)
  3360. return
  3361. default:
  3362. }
  3363. close(unblockServer)
  3364. // Stage 4.
  3365. <-gotRequest
  3366. }()
  3367. ct := newClientTester(t)
  3368. ct.tr.StrictMaxConcurrentStreams = true
  3369. ct.client = func() error {
  3370. var wg sync.WaitGroup
  3371. defer func() {
  3372. wg.Wait()
  3373. close(clientDone)
  3374. ct.cc.(*net.TCPConn).CloseWrite()
  3375. }()
  3376. for k := 0; k < maxConcurrent+2; k++ {
  3377. wg.Add(1)
  3378. go func(k int) {
  3379. defer wg.Done()
  3380. // Don't send the second request until after receiving SETTINGS from the server
  3381. // to avoid a race where we use the default SettingMaxConcurrentStreams, which
  3382. // is much larger than maxConcurrent. We have to send the first request before
  3383. // waiting because the first request triggers the dial and greet.
  3384. if k > 0 {
  3385. <-greet
  3386. }
  3387. // Block until maxConcurrent requests are sent before sending any more.
  3388. if k >= maxConcurrent {
  3389. <-unblockClient
  3390. }
  3391. req, _ := http.NewRequest("GET", fmt.Sprintf("https://dummy.tld/%d", k), nil)
  3392. if k == maxConcurrent {
  3393. // This request will be canceled.
  3394. cancel := make(chan struct{})
  3395. req.Cancel = cancel
  3396. close(cancel)
  3397. _, err := ct.tr.RoundTrip(req)
  3398. close(clientRequestCancelled)
  3399. if err == nil {
  3400. errs <- fmt.Errorf("RoundTrip(%d) should have failed due to cancel", k)
  3401. return
  3402. }
  3403. } else {
  3404. resp, err := ct.tr.RoundTrip(req)
  3405. if err != nil {
  3406. errs <- fmt.Errorf("RoundTrip(%d): %v", k, err)
  3407. return
  3408. }
  3409. ioutil.ReadAll(resp.Body)
  3410. resp.Body.Close()
  3411. if resp.StatusCode != 204 {
  3412. errs <- fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3413. return
  3414. }
  3415. }
  3416. }(k)
  3417. }
  3418. return nil
  3419. }
  3420. ct.server = func() error {
  3421. var wg sync.WaitGroup
  3422. defer wg.Wait()
  3423. ct.greet(Setting{SettingMaxConcurrentStreams, maxConcurrent})
  3424. // Server write loop.
  3425. var buf bytes.Buffer
  3426. enc := hpack.NewEncoder(&buf)
  3427. writeResp := make(chan uint32, maxConcurrent+1)
  3428. wg.Add(1)
  3429. go func() {
  3430. defer wg.Done()
  3431. <-unblockServer
  3432. for id := range writeResp {
  3433. buf.Reset()
  3434. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3435. ct.fr.WriteHeaders(HeadersFrameParam{
  3436. StreamID: id,
  3437. EndHeaders: true,
  3438. EndStream: true,
  3439. BlockFragment: buf.Bytes(),
  3440. })
  3441. }
  3442. }()
  3443. // Server read loop.
  3444. var nreq int
  3445. for {
  3446. f, err := ct.fr.ReadFrame()
  3447. if err != nil {
  3448. select {
  3449. case <-clientDone:
  3450. // If the client's done, it will have reported any errors on its side.
  3451. return nil
  3452. default:
  3453. return err
  3454. }
  3455. }
  3456. switch f := f.(type) {
  3457. case *WindowUpdateFrame:
  3458. case *SettingsFrame:
  3459. // Wait for the client SETTINGS ack until ending the greet.
  3460. close(greet)
  3461. case *HeadersFrame:
  3462. if !f.HeadersEnded() {
  3463. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3464. }
  3465. gotRequest <- struct{}{}
  3466. nreq++
  3467. writeResp <- f.StreamID
  3468. if nreq == maxConcurrent+1 {
  3469. close(writeResp)
  3470. }
  3471. default:
  3472. return fmt.Errorf("Unexpected client frame %v", f)
  3473. }
  3474. }
  3475. }
  3476. ct.run()
  3477. }
  3478. func TestAuthorityAddr(t *testing.T) {
  3479. tests := []struct {
  3480. scheme, authority string
  3481. want string
  3482. }{
  3483. {"http", "foo.com", "foo.com:80"},
  3484. {"https", "foo.com", "foo.com:443"},
  3485. {"https", "foo.com:1234", "foo.com:1234"},
  3486. {"https", "1.2.3.4:1234", "1.2.3.4:1234"},
  3487. {"https", "1.2.3.4", "1.2.3.4:443"},
  3488. {"https", "[::1]:1234", "[::1]:1234"},
  3489. {"https", "[::1]", "[::1]:443"},
  3490. }
  3491. for _, tt := range tests {
  3492. got := authorityAddr(tt.scheme, tt.authority)
  3493. if got != tt.want {
  3494. t.Errorf("authorityAddr(%q, %q) = %q; want %q", tt.scheme, tt.authority, got, tt.want)
  3495. }
  3496. }
  3497. }
  3498. // Issue 20448: stop allocating for DATA frames' payload after
  3499. // Response.Body.Close is called.
  3500. func TestTransportAllocationsAfterResponseBodyClose(t *testing.T) {
  3501. megabyteZero := make([]byte, 1<<20)
  3502. writeErr := make(chan error, 1)
  3503. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3504. w.(http.Flusher).Flush()
  3505. var sum int64
  3506. for i := 0; i < 100; i++ {
  3507. n, err := w.Write(megabyteZero)
  3508. sum += int64(n)
  3509. if err != nil {
  3510. writeErr <- err
  3511. return
  3512. }
  3513. }
  3514. t.Logf("wrote all %d bytes", sum)
  3515. writeErr <- nil
  3516. }, optOnlyServer)
  3517. defer st.Close()
  3518. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3519. defer tr.CloseIdleConnections()
  3520. c := &http.Client{Transport: tr}
  3521. res, err := c.Get(st.ts.URL)
  3522. if err != nil {
  3523. t.Fatal(err)
  3524. }
  3525. var buf [1]byte
  3526. if _, err := res.Body.Read(buf[:]); err != nil {
  3527. t.Error(err)
  3528. }
  3529. if err := res.Body.Close(); err != nil {
  3530. t.Error(err)
  3531. }
  3532. trb, ok := res.Body.(transportResponseBody)
  3533. if !ok {
  3534. t.Fatalf("res.Body = %T; want transportResponseBody", res.Body)
  3535. }
  3536. if trb.cs.bufPipe.b != nil {
  3537. t.Errorf("response body pipe is still open")
  3538. }
  3539. gotErr := <-writeErr
  3540. if gotErr == nil {
  3541. t.Errorf("Handler unexpectedly managed to write its entire response without getting an error")
  3542. } else if gotErr != errStreamClosed {
  3543. t.Errorf("Handler Write err = %v; want errStreamClosed", gotErr)
  3544. }
  3545. }
  3546. // Issue 18891: make sure Request.Body == NoBody means no DATA frame
  3547. // is ever sent, even if empty.
  3548. func TestTransportNoBodyMeansNoDATA(t *testing.T) {
  3549. ct := newClientTester(t)
  3550. unblockClient := make(chan bool)
  3551. ct.client = func() error {
  3552. req, _ := http.NewRequest("GET", "https://dummy.tld/", http.NoBody)
  3553. ct.tr.RoundTrip(req)
  3554. <-unblockClient
  3555. return nil
  3556. }
  3557. ct.server = func() error {
  3558. defer close(unblockClient)
  3559. defer ct.cc.(*net.TCPConn).Close()
  3560. ct.greet()
  3561. for {
  3562. f, err := ct.fr.ReadFrame()
  3563. if err != nil {
  3564. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  3565. }
  3566. switch f := f.(type) {
  3567. default:
  3568. return fmt.Errorf("Got %T; want HeadersFrame", f)
  3569. case *WindowUpdateFrame, *SettingsFrame:
  3570. continue
  3571. case *HeadersFrame:
  3572. if !f.StreamEnded() {
  3573. return fmt.Errorf("got headers frame without END_STREAM")
  3574. }
  3575. return nil
  3576. }
  3577. }
  3578. }
  3579. ct.run()
  3580. }
  3581. func benchSimpleRoundTrip(b *testing.B, nHeaders int) {
  3582. defer disableGoroutineTracking()()
  3583. b.ReportAllocs()
  3584. st := newServerTester(b,
  3585. func(w http.ResponseWriter, r *http.Request) {
  3586. },
  3587. optOnlyServer,
  3588. optQuiet,
  3589. )
  3590. defer st.Close()
  3591. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3592. defer tr.CloseIdleConnections()
  3593. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3594. if err != nil {
  3595. b.Fatal(err)
  3596. }
  3597. for i := 0; i < nHeaders; i++ {
  3598. name := fmt.Sprint("A-", i)
  3599. req.Header.Set(name, "*")
  3600. }
  3601. b.ResetTimer()
  3602. for i := 0; i < b.N; i++ {
  3603. res, err := tr.RoundTrip(req)
  3604. if err != nil {
  3605. if res != nil {
  3606. res.Body.Close()
  3607. }
  3608. b.Fatalf("RoundTrip err = %v; want nil", err)
  3609. }
  3610. res.Body.Close()
  3611. if res.StatusCode != http.StatusOK {
  3612. b.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3613. }
  3614. }
  3615. }
  3616. type infiniteReader struct{}
  3617. func (r infiniteReader) Read(b []byte) (int, error) {
  3618. return len(b), nil
  3619. }
  3620. // Issue 20521: it is not an error to receive a response and end stream
  3621. // from the server without the body being consumed.
  3622. func TestTransportResponseAndResetWithoutConsumingBodyRace(t *testing.T) {
  3623. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3624. w.WriteHeader(http.StatusOK)
  3625. }, optOnlyServer)
  3626. defer st.Close()
  3627. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3628. defer tr.CloseIdleConnections()
  3629. // The request body needs to be big enough to trigger flow control.
  3630. req, _ := http.NewRequest("PUT", st.ts.URL, infiniteReader{})
  3631. res, err := tr.RoundTrip(req)
  3632. if err != nil {
  3633. t.Fatal(err)
  3634. }
  3635. if res.StatusCode != http.StatusOK {
  3636. t.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3637. }
  3638. }
  3639. // Verify transport doesn't crash when receiving bogus response lacking a :status header.
  3640. // Issue 22880.
  3641. func TestTransportHandlesInvalidStatuslessResponse(t *testing.T) {
  3642. ct := newClientTester(t)
  3643. ct.client = func() error {
  3644. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3645. _, err := ct.tr.RoundTrip(req)
  3646. const substr = "malformed response from server: missing status pseudo header"
  3647. if !strings.Contains(fmt.Sprint(err), substr) {
  3648. return fmt.Errorf("RoundTrip error = %v; want substring %q", err, substr)
  3649. }
  3650. return nil
  3651. }
  3652. ct.server = func() error {
  3653. ct.greet()
  3654. var buf bytes.Buffer
  3655. enc := hpack.NewEncoder(&buf)
  3656. for {
  3657. f, err := ct.fr.ReadFrame()
  3658. if err != nil {
  3659. return err
  3660. }
  3661. switch f := f.(type) {
  3662. case *HeadersFrame:
  3663. enc.WriteField(hpack.HeaderField{Name: "content-type", Value: "text/html"}) // no :status header
  3664. ct.fr.WriteHeaders(HeadersFrameParam{
  3665. StreamID: f.StreamID,
  3666. EndHeaders: true,
  3667. EndStream: false, // we'll send some DATA to try to crash the transport
  3668. BlockFragment: buf.Bytes(),
  3669. })
  3670. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3671. return nil
  3672. }
  3673. }
  3674. }
  3675. ct.run()
  3676. }
  3677. func BenchmarkClientRequestHeaders(b *testing.B) {
  3678. b.Run(" 0 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 0) })
  3679. b.Run(" 10 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 10) })
  3680. b.Run(" 100 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 100) })
  3681. b.Run("1000 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 1000) })
  3682. }
  3683. func activeStreams(cc *ClientConn) int {
  3684. cc.mu.Lock()
  3685. defer cc.mu.Unlock()
  3686. return len(cc.streams)
  3687. }
  3688. type closeMode int
  3689. const (
  3690. closeAtHeaders closeMode = iota
  3691. closeAtBody
  3692. shutdown
  3693. shutdownCancel
  3694. )
  3695. // See golang.org/issue/17292
  3696. func testClientConnClose(t *testing.T, closeMode closeMode) {
  3697. clientDone := make(chan struct{})
  3698. defer close(clientDone)
  3699. handlerDone := make(chan struct{})
  3700. closeDone := make(chan struct{})
  3701. beforeHeader := func() {}
  3702. bodyWrite := func(w http.ResponseWriter) {}
  3703. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3704. defer close(handlerDone)
  3705. beforeHeader()
  3706. w.WriteHeader(http.StatusOK)
  3707. w.(http.Flusher).Flush()
  3708. bodyWrite(w)
  3709. select {
  3710. case <-w.(http.CloseNotifier).CloseNotify():
  3711. // client closed connection before completion
  3712. if closeMode == shutdown || closeMode == shutdownCancel {
  3713. t.Error("expected request to complete")
  3714. }
  3715. case <-clientDone:
  3716. if closeMode == closeAtHeaders || closeMode == closeAtBody {
  3717. t.Error("expected connection closed by client")
  3718. }
  3719. }
  3720. }, optOnlyServer)
  3721. defer st.Close()
  3722. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3723. defer tr.CloseIdleConnections()
  3724. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  3725. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3726. if err != nil {
  3727. t.Fatal(err)
  3728. }
  3729. if closeMode == closeAtHeaders {
  3730. beforeHeader = func() {
  3731. if err := cc.Close(); err != nil {
  3732. t.Error(err)
  3733. }
  3734. close(closeDone)
  3735. }
  3736. }
  3737. var sendBody chan struct{}
  3738. if closeMode == closeAtBody {
  3739. sendBody = make(chan struct{})
  3740. bodyWrite = func(w http.ResponseWriter) {
  3741. <-sendBody
  3742. b := make([]byte, 32)
  3743. w.Write(b)
  3744. w.(http.Flusher).Flush()
  3745. if err := cc.Close(); err != nil {
  3746. t.Errorf("unexpected ClientConn close error: %v", err)
  3747. }
  3748. close(closeDone)
  3749. w.Write(b)
  3750. w.(http.Flusher).Flush()
  3751. }
  3752. }
  3753. res, err := cc.RoundTrip(req)
  3754. if res != nil {
  3755. defer res.Body.Close()
  3756. }
  3757. if closeMode == closeAtHeaders {
  3758. got := fmt.Sprint(err)
  3759. want := "http2: client connection force closed via ClientConn.Close"
  3760. if got != want {
  3761. t.Fatalf("RoundTrip error = %v, want %v", got, want)
  3762. }
  3763. } else {
  3764. if err != nil {
  3765. t.Fatalf("RoundTrip: %v", err)
  3766. }
  3767. if got, want := activeStreams(cc), 1; got != want {
  3768. t.Errorf("got %d active streams, want %d", got, want)
  3769. }
  3770. }
  3771. switch closeMode {
  3772. case shutdownCancel:
  3773. if err = cc.Shutdown(canceledCtx); err != context.Canceled {
  3774. t.Errorf("got %v, want %v", err, context.Canceled)
  3775. }
  3776. if cc.closing == false {
  3777. t.Error("expected closing to be true")
  3778. }
  3779. if cc.CanTakeNewRequest() == true {
  3780. t.Error("CanTakeNewRequest to return false")
  3781. }
  3782. if v, want := len(cc.streams), 1; v != want {
  3783. t.Errorf("expected %d active streams, got %d", want, v)
  3784. }
  3785. clientDone <- struct{}{}
  3786. <-handlerDone
  3787. case shutdown:
  3788. wait := make(chan struct{})
  3789. shutdownEnterWaitStateHook = func() {
  3790. close(wait)
  3791. shutdownEnterWaitStateHook = func() {}
  3792. }
  3793. defer func() { shutdownEnterWaitStateHook = func() {} }()
  3794. shutdown := make(chan struct{}, 1)
  3795. go func() {
  3796. if err = cc.Shutdown(context.Background()); err != nil {
  3797. t.Error(err)
  3798. }
  3799. close(shutdown)
  3800. }()
  3801. // Let the shutdown to enter wait state
  3802. <-wait
  3803. cc.mu.Lock()
  3804. if cc.closing == false {
  3805. t.Error("expected closing to be true")
  3806. }
  3807. cc.mu.Unlock()
  3808. if cc.CanTakeNewRequest() == true {
  3809. t.Error("CanTakeNewRequest to return false")
  3810. }
  3811. if got, want := activeStreams(cc), 1; got != want {
  3812. t.Errorf("got %d active streams, want %d", got, want)
  3813. }
  3814. // Let the active request finish
  3815. clientDone <- struct{}{}
  3816. // Wait for the shutdown to end
  3817. select {
  3818. case <-shutdown:
  3819. case <-time.After(2 * time.Second):
  3820. t.Fatal("expected server connection to close")
  3821. }
  3822. case closeAtHeaders, closeAtBody:
  3823. if closeMode == closeAtBody {
  3824. go close(sendBody)
  3825. if _, err := io.Copy(ioutil.Discard, res.Body); err == nil {
  3826. t.Error("expected a Copy error, got nil")
  3827. }
  3828. }
  3829. <-closeDone
  3830. if got, want := activeStreams(cc), 0; got != want {
  3831. t.Errorf("got %d active streams, want %d", got, want)
  3832. }
  3833. // wait for server to get the connection close notice
  3834. select {
  3835. case <-handlerDone:
  3836. case <-time.After(2 * time.Second):
  3837. t.Fatal("expected server connection to close")
  3838. }
  3839. }
  3840. }
  3841. // The client closes the connection just after the server got the client's HEADERS
  3842. // frame, but before the server sends its HEADERS response back. The expected
  3843. // result is an error on RoundTrip explaining the client closed the connection.
  3844. func TestClientConnCloseAtHeaders(t *testing.T) {
  3845. testClientConnClose(t, closeAtHeaders)
  3846. }
  3847. // The client closes the connection between two server's response DATA frames.
  3848. // The expected behavior is a response body io read error on the client.
  3849. func TestClientConnCloseAtBody(t *testing.T) {
  3850. testClientConnClose(t, closeAtBody)
  3851. }
  3852. // The client sends a GOAWAY frame before the server finished processing a request.
  3853. // We expect the connection not to close until the request is completed.
  3854. func TestClientConnShutdown(t *testing.T) {
  3855. testClientConnClose(t, shutdown)
  3856. }
  3857. // The client sends a GOAWAY frame before the server finishes processing a request,
  3858. // but cancels the passed context before the request is completed. The expected
  3859. // behavior is the client closing the connection after the context is canceled.
  3860. func TestClientConnShutdownCancel(t *testing.T) {
  3861. testClientConnClose(t, shutdownCancel)
  3862. }
  3863. // Issue 25009: use Request.GetBody if present, even if it seems like
  3864. // we might not need it. Apparently something else can still read from
  3865. // the original request body. Data race? In any case, rewinding
  3866. // unconditionally on retry is a nicer model anyway and should
  3867. // simplify code in the future (after the Go 1.11 freeze)
  3868. func TestTransportUsesGetBodyWhenPresent(t *testing.T) {
  3869. calls := 0
  3870. someBody := func() io.ReadCloser {
  3871. return struct{ io.ReadCloser }{ioutil.NopCloser(bytes.NewReader(nil))}
  3872. }
  3873. req := &http.Request{
  3874. Body: someBody(),
  3875. GetBody: func() (io.ReadCloser, error) {
  3876. calls++
  3877. return someBody(), nil
  3878. },
  3879. }
  3880. afterBodyWrite := false // pretend we haven't read+written the body yet
  3881. req2, err := shouldRetryRequest(req, errClientConnUnusable, afterBodyWrite)
  3882. if err != nil {
  3883. t.Fatal(err)
  3884. }
  3885. if calls != 1 {
  3886. t.Errorf("Calls = %d; want 1", calls)
  3887. }
  3888. if req2 == req {
  3889. t.Error("req2 changed")
  3890. }
  3891. if req2 == nil {
  3892. t.Fatal("req2 is nil")
  3893. }
  3894. if req2.Body == nil {
  3895. t.Fatal("req2.Body is nil")
  3896. }
  3897. if req2.GetBody == nil {
  3898. t.Fatal("req2.GetBody is nil")
  3899. }
  3900. if req2.Body == req.Body {
  3901. t.Error("req2.Body unchanged")
  3902. }
  3903. }
  3904. // Issue 22891: verify that the "https" altproto we register with net/http
  3905. // is a certain type: a struct with one field with our *http2.Transport in it.
  3906. func TestNoDialH2RoundTripperType(t *testing.T) {
  3907. t1 := new(http.Transport)
  3908. t2 := new(Transport)
  3909. rt := noDialH2RoundTripper{t2}
  3910. if err := registerHTTPSProtocol(t1, rt); err != nil {
  3911. t.Fatal(err)
  3912. }
  3913. rv := reflect.ValueOf(rt)
  3914. if rv.Type().Kind() != reflect.Struct {
  3915. t.Fatalf("kind = %v; net/http expects struct", rv.Type().Kind())
  3916. }
  3917. if n := rv.Type().NumField(); n != 1 {
  3918. t.Fatalf("fields = %d; net/http expects 1", n)
  3919. }
  3920. v := rv.Field(0)
  3921. if _, ok := v.Interface().(*Transport); !ok {
  3922. t.Fatalf("wrong kind %T; want *Transport", v.Interface())
  3923. }
  3924. }
  3925. type errReader struct {
  3926. body []byte
  3927. err error
  3928. }
  3929. func (r *errReader) Read(p []byte) (int, error) {
  3930. if len(r.body) > 0 {
  3931. n := copy(p, r.body)
  3932. r.body = r.body[n:]
  3933. return n, nil
  3934. }
  3935. return 0, r.err
  3936. }
  3937. func testTransportBodyReadError(t *testing.T, body []byte) {
  3938. if runtime.GOOS == "windows" {
  3939. // So far we've only seen this be flaky on Windows,
  3940. // perhaps due to TCP behavior on shutdowns while
  3941. // unread data is in flight. This test should be
  3942. // fixed, but a skip is better than annoying people
  3943. // for now.
  3944. t.Skip("skipping flaky test on Windows; https://golang.org/issue/31260")
  3945. }
  3946. clientDone := make(chan struct{})
  3947. ct := newClientTester(t)
  3948. ct.client = func() error {
  3949. defer ct.cc.(*net.TCPConn).CloseWrite()
  3950. defer close(clientDone)
  3951. checkNoStreams := func() error {
  3952. cp, ok := ct.tr.connPool().(*clientConnPool)
  3953. if !ok {
  3954. return fmt.Errorf("conn pool is %T; want *clientConnPool", ct.tr.connPool())
  3955. }
  3956. cp.mu.Lock()
  3957. defer cp.mu.Unlock()
  3958. conns, ok := cp.conns["dummy.tld:443"]
  3959. if !ok {
  3960. return fmt.Errorf("missing connection")
  3961. }
  3962. if len(conns) != 1 {
  3963. return fmt.Errorf("conn pool size: %v; expect 1", len(conns))
  3964. }
  3965. if activeStreams(conns[0]) != 0 {
  3966. return fmt.Errorf("active streams count: %v; want 0", activeStreams(conns[0]))
  3967. }
  3968. return nil
  3969. }
  3970. bodyReadError := errors.New("body read error")
  3971. body := &errReader{body, bodyReadError}
  3972. req, err := http.NewRequest("PUT", "https://dummy.tld/", body)
  3973. if err != nil {
  3974. return err
  3975. }
  3976. _, err = ct.tr.RoundTrip(req)
  3977. if err != bodyReadError {
  3978. return fmt.Errorf("err = %v; want %v", err, bodyReadError)
  3979. }
  3980. if err = checkNoStreams(); err != nil {
  3981. return err
  3982. }
  3983. return nil
  3984. }
  3985. ct.server = func() error {
  3986. ct.greet()
  3987. var receivedBody []byte
  3988. var resetCount int
  3989. for {
  3990. f, err := ct.fr.ReadFrame()
  3991. t.Logf("server: ReadFrame = %v, %v", f, err)
  3992. if err != nil {
  3993. select {
  3994. case <-clientDone:
  3995. // If the client's done, it
  3996. // will have reported any
  3997. // errors on its side.
  3998. if bytes.Compare(receivedBody, body) != 0 {
  3999. return fmt.Errorf("body: %q; expected %q", receivedBody, body)
  4000. }
  4001. if resetCount != 1 {
  4002. return fmt.Errorf("stream reset count: %v; expected: 1", resetCount)
  4003. }
  4004. return nil
  4005. default:
  4006. return err
  4007. }
  4008. }
  4009. switch f := f.(type) {
  4010. case *WindowUpdateFrame, *SettingsFrame:
  4011. case *HeadersFrame:
  4012. case *DataFrame:
  4013. receivedBody = append(receivedBody, f.Data()...)
  4014. case *RSTStreamFrame:
  4015. resetCount++
  4016. default:
  4017. return fmt.Errorf("Unexpected client frame %v", f)
  4018. }
  4019. }
  4020. }
  4021. ct.run()
  4022. }
  4023. func TestTransportBodyReadError_Immediately(t *testing.T) { testTransportBodyReadError(t, nil) }
  4024. func TestTransportBodyReadError_Some(t *testing.T) { testTransportBodyReadError(t, []byte("123")) }