server_test.go 108 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "context"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "net"
  16. "net/http"
  17. "net/http/httptest"
  18. "os"
  19. "os/exec"
  20. "reflect"
  21. "runtime"
  22. "strconv"
  23. "strings"
  24. "sync"
  25. "sync/atomic"
  26. "testing"
  27. "time"
  28. "golang.org/x/net/http2/hpack"
  29. )
  30. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  31. func stderrv() io.Writer {
  32. if *stderrVerbose {
  33. return os.Stderr
  34. }
  35. return ioutil.Discard
  36. }
  37. type serverTester struct {
  38. cc net.Conn // client conn
  39. t testing.TB
  40. ts *httptest.Server
  41. fr *Framer
  42. serverLogBuf bytes.Buffer // logger for httptest.Server
  43. logFilter []string // substrings to filter out
  44. scMu sync.Mutex // guards sc
  45. sc *serverConn
  46. hpackDec *hpack.Decoder
  47. decodedHeaders [][2]string
  48. // If http2debug!=2, then we capture Frame debug logs that will be written
  49. // to t.Log after a test fails. The read and write logs use separate locks
  50. // and buffers so we don't accidentally introduce synchronization between
  51. // the read and write goroutines, which may hide data races.
  52. frameReadLogMu sync.Mutex
  53. frameReadLogBuf bytes.Buffer
  54. frameWriteLogMu sync.Mutex
  55. frameWriteLogBuf bytes.Buffer
  56. // writing headers:
  57. headerBuf bytes.Buffer
  58. hpackEnc *hpack.Encoder
  59. }
  60. func init() {
  61. testHookOnPanicMu = new(sync.Mutex)
  62. goAwayTimeout = 25 * time.Millisecond
  63. }
  64. func resetHooks() {
  65. testHookOnPanicMu.Lock()
  66. testHookOnPanic = nil
  67. testHookOnPanicMu.Unlock()
  68. }
  69. type serverTesterOpt string
  70. var optOnlyServer = serverTesterOpt("only_server")
  71. var optQuiet = serverTesterOpt("quiet_logging")
  72. var optFramerReuseFrames = serverTesterOpt("frame_reuse_frames")
  73. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  74. resetHooks()
  75. ts := httptest.NewUnstartedServer(handler)
  76. tlsConfig := &tls.Config{
  77. InsecureSkipVerify: true,
  78. NextProtos: []string{NextProtoTLS},
  79. }
  80. var onlyServer, quiet, framerReuseFrames bool
  81. h2server := new(Server)
  82. for _, opt := range opts {
  83. switch v := opt.(type) {
  84. case func(*tls.Config):
  85. v(tlsConfig)
  86. case func(*httptest.Server):
  87. v(ts)
  88. case func(*Server):
  89. v(h2server)
  90. case serverTesterOpt:
  91. switch v {
  92. case optOnlyServer:
  93. onlyServer = true
  94. case optQuiet:
  95. quiet = true
  96. case optFramerReuseFrames:
  97. framerReuseFrames = true
  98. }
  99. case func(net.Conn, http.ConnState):
  100. ts.Config.ConnState = v
  101. default:
  102. t.Fatalf("unknown newServerTester option type %T", v)
  103. }
  104. }
  105. ConfigureServer(ts.Config, h2server)
  106. st := &serverTester{
  107. t: t,
  108. ts: ts,
  109. }
  110. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  111. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  112. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  113. if quiet {
  114. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  115. } else {
  116. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, &st.serverLogBuf), "", log.LstdFlags)
  117. }
  118. ts.StartTLS()
  119. if VerboseLogs {
  120. t.Logf("Running test server at: %s", ts.URL)
  121. }
  122. testHookGetServerConn = func(v *serverConn) {
  123. st.scMu.Lock()
  124. defer st.scMu.Unlock()
  125. st.sc = v
  126. }
  127. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  128. if !onlyServer {
  129. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  130. if err != nil {
  131. t.Fatal(err)
  132. }
  133. st.cc = cc
  134. st.fr = NewFramer(cc, cc)
  135. if framerReuseFrames {
  136. st.fr.SetReuseFrames()
  137. }
  138. if !logFrameReads && !logFrameWrites {
  139. st.fr.debugReadLoggerf = func(m string, v ...interface{}) {
  140. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  141. st.frameReadLogMu.Lock()
  142. fmt.Fprintf(&st.frameReadLogBuf, m, v...)
  143. st.frameReadLogMu.Unlock()
  144. }
  145. st.fr.debugWriteLoggerf = func(m string, v ...interface{}) {
  146. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  147. st.frameWriteLogMu.Lock()
  148. fmt.Fprintf(&st.frameWriteLogBuf, m, v...)
  149. st.frameWriteLogMu.Unlock()
  150. }
  151. st.fr.logReads = true
  152. st.fr.logWrites = true
  153. }
  154. }
  155. return st
  156. }
  157. func (st *serverTester) closeConn() {
  158. st.scMu.Lock()
  159. defer st.scMu.Unlock()
  160. st.sc.conn.Close()
  161. }
  162. func (st *serverTester) addLogFilter(phrase string) {
  163. st.logFilter = append(st.logFilter, phrase)
  164. }
  165. func (st *serverTester) stream(id uint32) *stream {
  166. ch := make(chan *stream, 1)
  167. st.sc.serveMsgCh <- func(int) {
  168. ch <- st.sc.streams[id]
  169. }
  170. return <-ch
  171. }
  172. func (st *serverTester) streamState(id uint32) streamState {
  173. ch := make(chan streamState, 1)
  174. st.sc.serveMsgCh <- func(int) {
  175. state, _ := st.sc.state(id)
  176. ch <- state
  177. }
  178. return <-ch
  179. }
  180. // loopNum reports how many times this conn's select loop has gone around.
  181. func (st *serverTester) loopNum() int {
  182. lastc := make(chan int, 1)
  183. st.sc.serveMsgCh <- func(loopNum int) {
  184. lastc <- loopNum
  185. }
  186. return <-lastc
  187. }
  188. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  189. // The heuristic is that the server connection's serve loop must schedule
  190. // 50 times in a row without any channel sends or receives occurring.
  191. func (st *serverTester) awaitIdle() {
  192. remain := 50
  193. last := st.loopNum()
  194. for remain > 0 {
  195. n := st.loopNum()
  196. if n == last+1 {
  197. remain--
  198. } else {
  199. remain = 50
  200. }
  201. last = n
  202. }
  203. }
  204. func (st *serverTester) Close() {
  205. if st.t.Failed() {
  206. st.frameReadLogMu.Lock()
  207. if st.frameReadLogBuf.Len() > 0 {
  208. st.t.Logf("Framer read log:\n%s", st.frameReadLogBuf.String())
  209. }
  210. st.frameReadLogMu.Unlock()
  211. st.frameWriteLogMu.Lock()
  212. if st.frameWriteLogBuf.Len() > 0 {
  213. st.t.Logf("Framer write log:\n%s", st.frameWriteLogBuf.String())
  214. }
  215. st.frameWriteLogMu.Unlock()
  216. // If we failed already (and are likely in a Fatal,
  217. // unwindowing), force close the connection, so the
  218. // httptest.Server doesn't wait forever for the conn
  219. // to close.
  220. if st.cc != nil {
  221. st.cc.Close()
  222. }
  223. }
  224. st.ts.Close()
  225. if st.cc != nil {
  226. st.cc.Close()
  227. }
  228. log.SetOutput(os.Stderr)
  229. }
  230. // greet initiates the client's HTTP/2 connection into a state where
  231. // frames may be sent.
  232. func (st *serverTester) greet() {
  233. st.greetAndCheckSettings(func(Setting) error { return nil })
  234. }
  235. func (st *serverTester) greetAndCheckSettings(checkSetting func(s Setting) error) {
  236. st.writePreface()
  237. st.writeInitialSettings()
  238. st.wantSettings().ForeachSetting(checkSetting)
  239. st.writeSettingsAck()
  240. // The initial WINDOW_UPDATE and SETTINGS ACK can come in any order.
  241. var gotSettingsAck bool
  242. var gotWindowUpdate bool
  243. for i := 0; i < 2; i++ {
  244. f, err := st.readFrame()
  245. if err != nil {
  246. st.t.Fatal(err)
  247. }
  248. switch f := f.(type) {
  249. case *SettingsFrame:
  250. if !f.Header().Flags.Has(FlagSettingsAck) {
  251. st.t.Fatal("Settings Frame didn't have ACK set")
  252. }
  253. gotSettingsAck = true
  254. case *WindowUpdateFrame:
  255. if f.FrameHeader.StreamID != 0 {
  256. st.t.Fatalf("WindowUpdate StreamID = %d; want 0", f.FrameHeader.StreamID)
  257. }
  258. incr := uint32((&Server{}).initialConnRecvWindowSize() - initialWindowSize)
  259. if f.Increment != incr {
  260. st.t.Fatalf("WindowUpdate increment = %d; want %d", f.Increment, incr)
  261. }
  262. gotWindowUpdate = true
  263. default:
  264. st.t.Fatalf("Wanting a settings ACK or window update, received a %T", f)
  265. }
  266. }
  267. if !gotSettingsAck {
  268. st.t.Fatalf("Didn't get a settings ACK")
  269. }
  270. if !gotWindowUpdate {
  271. st.t.Fatalf("Didn't get a window update")
  272. }
  273. }
  274. func (st *serverTester) writePreface() {
  275. n, err := st.cc.Write(clientPreface)
  276. if err != nil {
  277. st.t.Fatalf("Error writing client preface: %v", err)
  278. }
  279. if n != len(clientPreface) {
  280. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  281. }
  282. }
  283. func (st *serverTester) writeInitialSettings() {
  284. if err := st.fr.WriteSettings(); err != nil {
  285. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  286. }
  287. }
  288. func (st *serverTester) writeSettingsAck() {
  289. if err := st.fr.WriteSettingsAck(); err != nil {
  290. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  291. }
  292. }
  293. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  294. if err := st.fr.WriteHeaders(p); err != nil {
  295. st.t.Fatalf("Error writing HEADERS: %v", err)
  296. }
  297. }
  298. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  299. if err := st.fr.WritePriority(id, p); err != nil {
  300. st.t.Fatalf("Error writing PRIORITY: %v", err)
  301. }
  302. }
  303. func (st *serverTester) encodeHeaderField(k, v string) {
  304. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  305. if err != nil {
  306. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  307. }
  308. }
  309. // encodeHeaderRaw is the magic-free version of encodeHeader.
  310. // It takes 0 or more (k, v) pairs and encodes them.
  311. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  312. if len(headers)%2 == 1 {
  313. panic("odd number of kv args")
  314. }
  315. st.headerBuf.Reset()
  316. for len(headers) > 0 {
  317. k, v := headers[0], headers[1]
  318. st.encodeHeaderField(k, v)
  319. headers = headers[2:]
  320. }
  321. return st.headerBuf.Bytes()
  322. }
  323. // encodeHeader encodes headers and returns their HPACK bytes. headers
  324. // must contain an even number of key/value pairs. There may be
  325. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  326. // :scheme headers default to GET, / and https. The :authority header
  327. // defaults to st.ts.Listener.Addr().
  328. func (st *serverTester) encodeHeader(headers ...string) []byte {
  329. if len(headers)%2 == 1 {
  330. panic("odd number of kv args")
  331. }
  332. st.headerBuf.Reset()
  333. defaultAuthority := st.ts.Listener.Addr().String()
  334. if len(headers) == 0 {
  335. // Fast path, mostly for benchmarks, so test code doesn't pollute
  336. // profiles when we're looking to improve server allocations.
  337. st.encodeHeaderField(":method", "GET")
  338. st.encodeHeaderField(":scheme", "https")
  339. st.encodeHeaderField(":authority", defaultAuthority)
  340. st.encodeHeaderField(":path", "/")
  341. return st.headerBuf.Bytes()
  342. }
  343. if len(headers) == 2 && headers[0] == ":method" {
  344. // Another fast path for benchmarks.
  345. st.encodeHeaderField(":method", headers[1])
  346. st.encodeHeaderField(":scheme", "https")
  347. st.encodeHeaderField(":authority", defaultAuthority)
  348. st.encodeHeaderField(":path", "/")
  349. return st.headerBuf.Bytes()
  350. }
  351. pseudoCount := map[string]int{}
  352. keys := []string{":method", ":scheme", ":authority", ":path"}
  353. vals := map[string][]string{
  354. ":method": {"GET"},
  355. ":scheme": {"https"},
  356. ":authority": {defaultAuthority},
  357. ":path": {"/"},
  358. }
  359. for len(headers) > 0 {
  360. k, v := headers[0], headers[1]
  361. headers = headers[2:]
  362. if _, ok := vals[k]; !ok {
  363. keys = append(keys, k)
  364. }
  365. if strings.HasPrefix(k, ":") {
  366. pseudoCount[k]++
  367. if pseudoCount[k] == 1 {
  368. vals[k] = []string{v}
  369. } else {
  370. // Allows testing of invalid headers w/ dup pseudo fields.
  371. vals[k] = append(vals[k], v)
  372. }
  373. } else {
  374. vals[k] = append(vals[k], v)
  375. }
  376. }
  377. for _, k := range keys {
  378. for _, v := range vals[k] {
  379. st.encodeHeaderField(k, v)
  380. }
  381. }
  382. return st.headerBuf.Bytes()
  383. }
  384. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  385. func (st *serverTester) bodylessReq1(headers ...string) {
  386. st.writeHeaders(HeadersFrameParam{
  387. StreamID: 1, // clients send odd numbers
  388. BlockFragment: st.encodeHeader(headers...),
  389. EndStream: true,
  390. EndHeaders: true,
  391. })
  392. }
  393. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  394. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  395. st.t.Fatalf("Error writing DATA: %v", err)
  396. }
  397. }
  398. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  399. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  400. st.t.Fatalf("Error writing DATA: %v", err)
  401. }
  402. }
  403. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  404. ch := make(chan interface{}, 1)
  405. go func() {
  406. fr, err := fr.ReadFrame()
  407. if err != nil {
  408. ch <- err
  409. } else {
  410. ch <- fr
  411. }
  412. }()
  413. t := time.NewTimer(wait)
  414. select {
  415. case v := <-ch:
  416. t.Stop()
  417. if fr, ok := v.(Frame); ok {
  418. return fr, nil
  419. }
  420. return nil, v.(error)
  421. case <-t.C:
  422. return nil, errors.New("timeout waiting for frame")
  423. }
  424. }
  425. func (st *serverTester) readFrame() (Frame, error) {
  426. return readFrameTimeout(st.fr, 2*time.Second)
  427. }
  428. func (st *serverTester) wantHeaders() *HeadersFrame {
  429. f, err := st.readFrame()
  430. if err != nil {
  431. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  432. }
  433. hf, ok := f.(*HeadersFrame)
  434. if !ok {
  435. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  436. }
  437. return hf
  438. }
  439. func (st *serverTester) wantContinuation() *ContinuationFrame {
  440. f, err := st.readFrame()
  441. if err != nil {
  442. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  443. }
  444. cf, ok := f.(*ContinuationFrame)
  445. if !ok {
  446. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  447. }
  448. return cf
  449. }
  450. func (st *serverTester) wantData() *DataFrame {
  451. f, err := st.readFrame()
  452. if err != nil {
  453. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  454. }
  455. df, ok := f.(*DataFrame)
  456. if !ok {
  457. st.t.Fatalf("got a %T; want *DataFrame", f)
  458. }
  459. return df
  460. }
  461. func (st *serverTester) wantSettings() *SettingsFrame {
  462. f, err := st.readFrame()
  463. if err != nil {
  464. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  465. }
  466. sf, ok := f.(*SettingsFrame)
  467. if !ok {
  468. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  469. }
  470. return sf
  471. }
  472. func (st *serverTester) wantPing() *PingFrame {
  473. f, err := st.readFrame()
  474. if err != nil {
  475. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  476. }
  477. pf, ok := f.(*PingFrame)
  478. if !ok {
  479. st.t.Fatalf("got a %T; want *PingFrame", f)
  480. }
  481. return pf
  482. }
  483. func (st *serverTester) wantGoAway() *GoAwayFrame {
  484. f, err := st.readFrame()
  485. if err != nil {
  486. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  487. }
  488. gf, ok := f.(*GoAwayFrame)
  489. if !ok {
  490. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  491. }
  492. return gf
  493. }
  494. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  495. f, err := st.readFrame()
  496. if err != nil {
  497. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  498. }
  499. rs, ok := f.(*RSTStreamFrame)
  500. if !ok {
  501. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  502. }
  503. if rs.FrameHeader.StreamID != streamID {
  504. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  505. }
  506. if rs.ErrCode != errCode {
  507. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  508. }
  509. }
  510. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  511. f, err := st.readFrame()
  512. if err != nil {
  513. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  514. }
  515. wu, ok := f.(*WindowUpdateFrame)
  516. if !ok {
  517. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  518. }
  519. if wu.FrameHeader.StreamID != streamID {
  520. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  521. }
  522. if wu.Increment != incr {
  523. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  524. }
  525. }
  526. func (st *serverTester) wantSettingsAck() {
  527. f, err := st.readFrame()
  528. if err != nil {
  529. st.t.Fatal(err)
  530. }
  531. sf, ok := f.(*SettingsFrame)
  532. if !ok {
  533. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  534. }
  535. if !sf.Header().Flags.Has(FlagSettingsAck) {
  536. st.t.Fatal("Settings Frame didn't have ACK set")
  537. }
  538. }
  539. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  540. f, err := st.readFrame()
  541. if err != nil {
  542. st.t.Fatal(err)
  543. }
  544. ppf, ok := f.(*PushPromiseFrame)
  545. if !ok {
  546. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  547. }
  548. return ppf
  549. }
  550. func TestServer(t *testing.T) {
  551. gotReq := make(chan bool, 1)
  552. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  553. w.Header().Set("Foo", "Bar")
  554. gotReq <- true
  555. })
  556. defer st.Close()
  557. covers("3.5", `
  558. The server connection preface consists of a potentially empty
  559. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  560. server sends in the HTTP/2 connection.
  561. `)
  562. st.greet()
  563. st.writeHeaders(HeadersFrameParam{
  564. StreamID: 1, // clients send odd numbers
  565. BlockFragment: st.encodeHeader(),
  566. EndStream: true, // no DATA frames
  567. EndHeaders: true,
  568. })
  569. select {
  570. case <-gotReq:
  571. case <-time.After(2 * time.Second):
  572. t.Error("timeout waiting for request")
  573. }
  574. }
  575. func TestServer_Request_Get(t *testing.T) {
  576. testServerRequest(t, func(st *serverTester) {
  577. st.writeHeaders(HeadersFrameParam{
  578. StreamID: 1, // clients send odd numbers
  579. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  580. EndStream: true, // no DATA frames
  581. EndHeaders: true,
  582. })
  583. }, func(r *http.Request) {
  584. if r.Method != "GET" {
  585. t.Errorf("Method = %q; want GET", r.Method)
  586. }
  587. if r.URL.Path != "/" {
  588. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  589. }
  590. if r.ContentLength != 0 {
  591. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  592. }
  593. if r.Close {
  594. t.Error("Close = true; want false")
  595. }
  596. if !strings.Contains(r.RemoteAddr, ":") {
  597. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  598. }
  599. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  600. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  601. }
  602. wantHeader := http.Header{
  603. "Foo-Bar": []string{"some-value"},
  604. }
  605. if !reflect.DeepEqual(r.Header, wantHeader) {
  606. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  607. }
  608. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  609. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  610. }
  611. })
  612. }
  613. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  614. testServerRequest(t, func(st *serverTester) {
  615. st.writeHeaders(HeadersFrameParam{
  616. StreamID: 1, // clients send odd numbers
  617. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  618. EndStream: true, // no DATA frames
  619. EndHeaders: true,
  620. })
  621. }, func(r *http.Request) {
  622. if r.RequestURI != "/%2f/" {
  623. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  624. }
  625. if r.URL.Path != "///" {
  626. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  627. }
  628. })
  629. }
  630. // TODO: add a test with EndStream=true on the HEADERS but setting a
  631. // Content-Length anyway. Should we just omit it and force it to
  632. // zero?
  633. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  634. testServerRequest(t, func(st *serverTester) {
  635. st.writeHeaders(HeadersFrameParam{
  636. StreamID: 1, // clients send odd numbers
  637. BlockFragment: st.encodeHeader(":method", "POST"),
  638. EndStream: true,
  639. EndHeaders: true,
  640. })
  641. }, func(r *http.Request) {
  642. if r.Method != "POST" {
  643. t.Errorf("Method = %q; want POST", r.Method)
  644. }
  645. if r.ContentLength != 0 {
  646. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  647. }
  648. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  649. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  650. }
  651. })
  652. }
  653. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  654. testBodyContents(t, -1, "", func(st *serverTester) {
  655. st.writeHeaders(HeadersFrameParam{
  656. StreamID: 1, // clients send odd numbers
  657. BlockFragment: st.encodeHeader(":method", "POST"),
  658. EndStream: false, // to say DATA frames are coming
  659. EndHeaders: true,
  660. })
  661. st.writeData(1, true, nil) // just kidding. empty body.
  662. })
  663. }
  664. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  665. const content = "Some content"
  666. testBodyContents(t, -1, content, func(st *serverTester) {
  667. st.writeHeaders(HeadersFrameParam{
  668. StreamID: 1, // clients send odd numbers
  669. BlockFragment: st.encodeHeader(":method", "POST"),
  670. EndStream: false, // to say DATA frames are coming
  671. EndHeaders: true,
  672. })
  673. st.writeData(1, true, []byte(content))
  674. })
  675. }
  676. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  677. const content = "Some content"
  678. testBodyContents(t, -1, content, func(st *serverTester) {
  679. st.writeHeaders(HeadersFrameParam{
  680. StreamID: 1, // clients send odd numbers
  681. BlockFragment: st.encodeHeader(":method", "POST"),
  682. EndStream: false, // to say DATA frames are coming
  683. EndHeaders: true,
  684. })
  685. st.writeData(1, false, []byte(content[:5]))
  686. st.writeData(1, true, []byte(content[5:]))
  687. })
  688. }
  689. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  690. const content = "Some content"
  691. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  692. st.writeHeaders(HeadersFrameParam{
  693. StreamID: 1, // clients send odd numbers
  694. BlockFragment: st.encodeHeader(
  695. ":method", "POST",
  696. "content-length", strconv.Itoa(len(content)),
  697. ),
  698. EndStream: false, // to say DATA frames are coming
  699. EndHeaders: true,
  700. })
  701. st.writeData(1, true, []byte(content))
  702. })
  703. }
  704. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  705. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  706. func(st *serverTester) {
  707. st.writeHeaders(HeadersFrameParam{
  708. StreamID: 1, // clients send odd numbers
  709. BlockFragment: st.encodeHeader(
  710. ":method", "POST",
  711. "content-length", "3",
  712. ),
  713. EndStream: false, // to say DATA frames are coming
  714. EndHeaders: true,
  715. })
  716. st.writeData(1, true, []byte("12"))
  717. })
  718. }
  719. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  720. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  721. func(st *serverTester) {
  722. st.writeHeaders(HeadersFrameParam{
  723. StreamID: 1, // clients send odd numbers
  724. BlockFragment: st.encodeHeader(
  725. ":method", "POST",
  726. "content-length", "4",
  727. ),
  728. EndStream: false, // to say DATA frames are coming
  729. EndHeaders: true,
  730. })
  731. st.writeData(1, true, []byte("12345"))
  732. })
  733. }
  734. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  735. testServerRequest(t, write, func(r *http.Request) {
  736. if r.Method != "POST" {
  737. t.Errorf("Method = %q; want POST", r.Method)
  738. }
  739. if r.ContentLength != wantContentLength {
  740. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  741. }
  742. all, err := ioutil.ReadAll(r.Body)
  743. if err != nil {
  744. t.Fatal(err)
  745. }
  746. if string(all) != wantBody {
  747. t.Errorf("Read = %q; want %q", all, wantBody)
  748. }
  749. if err := r.Body.Close(); err != nil {
  750. t.Fatalf("Close: %v", err)
  751. }
  752. })
  753. }
  754. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  755. testServerRequest(t, write, func(r *http.Request) {
  756. if r.Method != "POST" {
  757. t.Errorf("Method = %q; want POST", r.Method)
  758. }
  759. if r.ContentLength != wantContentLength {
  760. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  761. }
  762. all, err := ioutil.ReadAll(r.Body)
  763. if err == nil {
  764. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  765. wantReadError, all)
  766. }
  767. if !strings.Contains(err.Error(), wantReadError) {
  768. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  769. }
  770. if err := r.Body.Close(); err != nil {
  771. t.Fatalf("Close: %v", err)
  772. }
  773. })
  774. }
  775. // Using a Host header, instead of :authority
  776. func TestServer_Request_Get_Host(t *testing.T) {
  777. const host = "example.com"
  778. testServerRequest(t, func(st *serverTester) {
  779. st.writeHeaders(HeadersFrameParam{
  780. StreamID: 1, // clients send odd numbers
  781. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  782. EndStream: true,
  783. EndHeaders: true,
  784. })
  785. }, func(r *http.Request) {
  786. if r.Host != host {
  787. t.Errorf("Host = %q; want %q", r.Host, host)
  788. }
  789. })
  790. }
  791. // Using an :authority pseudo-header, instead of Host
  792. func TestServer_Request_Get_Authority(t *testing.T) {
  793. const host = "example.com"
  794. testServerRequest(t, func(st *serverTester) {
  795. st.writeHeaders(HeadersFrameParam{
  796. StreamID: 1, // clients send odd numbers
  797. BlockFragment: st.encodeHeader(":authority", host),
  798. EndStream: true,
  799. EndHeaders: true,
  800. })
  801. }, func(r *http.Request) {
  802. if r.Host != host {
  803. t.Errorf("Host = %q; want %q", r.Host, host)
  804. }
  805. })
  806. }
  807. func TestServer_Request_WithContinuation(t *testing.T) {
  808. wantHeader := http.Header{
  809. "Foo-One": []string{"value-one"},
  810. "Foo-Two": []string{"value-two"},
  811. "Foo-Three": []string{"value-three"},
  812. }
  813. testServerRequest(t, func(st *serverTester) {
  814. fullHeaders := st.encodeHeader(
  815. "foo-one", "value-one",
  816. "foo-two", "value-two",
  817. "foo-three", "value-three",
  818. )
  819. remain := fullHeaders
  820. chunks := 0
  821. for len(remain) > 0 {
  822. const maxChunkSize = 5
  823. chunk := remain
  824. if len(chunk) > maxChunkSize {
  825. chunk = chunk[:maxChunkSize]
  826. }
  827. remain = remain[len(chunk):]
  828. if chunks == 0 {
  829. st.writeHeaders(HeadersFrameParam{
  830. StreamID: 1, // clients send odd numbers
  831. BlockFragment: chunk,
  832. EndStream: true, // no DATA frames
  833. EndHeaders: false, // we'll have continuation frames
  834. })
  835. } else {
  836. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  837. if err != nil {
  838. t.Fatal(err)
  839. }
  840. }
  841. chunks++
  842. }
  843. if chunks < 2 {
  844. t.Fatal("too few chunks")
  845. }
  846. }, func(r *http.Request) {
  847. if !reflect.DeepEqual(r.Header, wantHeader) {
  848. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  849. }
  850. })
  851. }
  852. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  853. func TestServer_Request_CookieConcat(t *testing.T) {
  854. const host = "example.com"
  855. testServerRequest(t, func(st *serverTester) {
  856. st.bodylessReq1(
  857. ":authority", host,
  858. "cookie", "a=b",
  859. "cookie", "c=d",
  860. "cookie", "e=f",
  861. )
  862. }, func(r *http.Request) {
  863. const want = "a=b; c=d; e=f"
  864. if got := r.Header.Get("Cookie"); got != want {
  865. t.Errorf("Cookie = %q; want %q", got, want)
  866. }
  867. })
  868. }
  869. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  870. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  871. }
  872. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  873. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  874. }
  875. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  876. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  877. }
  878. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  879. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  880. }
  881. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  882. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  883. }
  884. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  885. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  886. }
  887. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  888. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  889. }
  890. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  891. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  892. }
  893. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  894. // 8.1.2.3 Request Pseudo-Header Fields
  895. // "All HTTP/2 requests MUST include exactly one valid value" ...
  896. testRejectRequest(t, func(st *serverTester) {
  897. st.addLogFilter("duplicate pseudo-header")
  898. st.bodylessReq1(":method", "GET", ":method", "POST")
  899. })
  900. }
  901. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  902. // 8.1.2.3 Request Pseudo-Header Fields
  903. // "All pseudo-header fields MUST appear in the header block
  904. // before regular header fields. Any request or response that
  905. // contains a pseudo-header field that appears in a header
  906. // block after a regular header field MUST be treated as
  907. // malformed (Section 8.1.2.6)."
  908. testRejectRequest(t, func(st *serverTester) {
  909. st.addLogFilter("pseudo-header after regular header")
  910. var buf bytes.Buffer
  911. enc := hpack.NewEncoder(&buf)
  912. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  913. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  914. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  915. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  916. st.writeHeaders(HeadersFrameParam{
  917. StreamID: 1, // clients send odd numbers
  918. BlockFragment: buf.Bytes(),
  919. EndStream: true,
  920. EndHeaders: true,
  921. })
  922. })
  923. }
  924. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  925. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  926. }
  927. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  928. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  929. }
  930. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  931. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  932. }
  933. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  934. testRejectRequest(t, func(st *serverTester) {
  935. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  936. st.bodylessReq1(":unknown_thing", "")
  937. })
  938. }
  939. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  940. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  941. t.Error("server request made it to handler; should've been rejected")
  942. })
  943. defer st.Close()
  944. st.greet()
  945. send(st)
  946. st.wantRSTStream(1, ErrCodeProtocol)
  947. }
  948. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  949. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  950. t.Error("server request made it to handler; should've been rejected")
  951. }, optQuiet)
  952. defer st.Close()
  953. st.greet()
  954. send(st)
  955. gf := st.wantGoAway()
  956. if gf.ErrCode != ErrCodeProtocol {
  957. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  958. }
  959. }
  960. // Section 5.1, on idle connections: "Receiving any frame other than
  961. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  962. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  963. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  964. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  965. st.fr.WriteWindowUpdate(123, 456)
  966. })
  967. }
  968. func TestRejectFrameOnIdle_Data(t *testing.T) {
  969. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  970. st.fr.WriteData(123, true, nil)
  971. })
  972. }
  973. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  974. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  975. st.fr.WriteRSTStream(123, ErrCodeCancel)
  976. })
  977. }
  978. func TestServer_Request_Connect(t *testing.T) {
  979. testServerRequest(t, func(st *serverTester) {
  980. st.writeHeaders(HeadersFrameParam{
  981. StreamID: 1,
  982. BlockFragment: st.encodeHeaderRaw(
  983. ":method", "CONNECT",
  984. ":authority", "example.com:123",
  985. ),
  986. EndStream: true,
  987. EndHeaders: true,
  988. })
  989. }, func(r *http.Request) {
  990. if g, w := r.Method, "CONNECT"; g != w {
  991. t.Errorf("Method = %q; want %q", g, w)
  992. }
  993. if g, w := r.RequestURI, "example.com:123"; g != w {
  994. t.Errorf("RequestURI = %q; want %q", g, w)
  995. }
  996. if g, w := r.URL.Host, "example.com:123"; g != w {
  997. t.Errorf("URL.Host = %q; want %q", g, w)
  998. }
  999. })
  1000. }
  1001. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  1002. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1003. st.writeHeaders(HeadersFrameParam{
  1004. StreamID: 1,
  1005. BlockFragment: st.encodeHeaderRaw(
  1006. ":method", "CONNECT",
  1007. ":authority", "example.com:123",
  1008. ":path", "/bogus",
  1009. ),
  1010. EndStream: true,
  1011. EndHeaders: true,
  1012. })
  1013. })
  1014. }
  1015. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  1016. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1017. st.writeHeaders(HeadersFrameParam{
  1018. StreamID: 1,
  1019. BlockFragment: st.encodeHeaderRaw(
  1020. ":method", "CONNECT",
  1021. ":authority", "example.com:123",
  1022. ":scheme", "https",
  1023. ),
  1024. EndStream: true,
  1025. EndHeaders: true,
  1026. })
  1027. })
  1028. }
  1029. func TestServer_Ping(t *testing.T) {
  1030. st := newServerTester(t, nil)
  1031. defer st.Close()
  1032. st.greet()
  1033. // Server should ignore this one, since it has ACK set.
  1034. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  1035. if err := st.fr.WritePing(true, ackPingData); err != nil {
  1036. t.Fatal(err)
  1037. }
  1038. // But the server should reply to this one, since ACK is false.
  1039. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  1040. if err := st.fr.WritePing(false, pingData); err != nil {
  1041. t.Fatal(err)
  1042. }
  1043. pf := st.wantPing()
  1044. if !pf.Flags.Has(FlagPingAck) {
  1045. t.Error("response ping doesn't have ACK set")
  1046. }
  1047. if pf.Data != pingData {
  1048. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  1049. }
  1050. }
  1051. func TestServer_MaxQueuedControlFrames(t *testing.T) {
  1052. if testing.Short() {
  1053. t.Skip("skipping in short mode")
  1054. }
  1055. st := newServerTester(t, nil)
  1056. defer st.Close()
  1057. st.greet()
  1058. const extraPings = 500000 // enough to fill the TCP buffers
  1059. for i := 0; i < maxQueuedControlFrames+extraPings; i++ {
  1060. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  1061. if err := st.fr.WritePing(false, pingData); err != nil {
  1062. if i == 0 {
  1063. t.Fatal(err)
  1064. }
  1065. // We expect the connection to get closed by the server when the TCP
  1066. // buffer fills up and the write queue reaches MaxQueuedControlFrames.
  1067. t.Logf("sent %d PING frames", i)
  1068. return
  1069. }
  1070. }
  1071. t.Errorf("unexpected success sending all PING frames")
  1072. }
  1073. func TestServer_RejectsLargeFrames(t *testing.T) {
  1074. if runtime.GOOS == "windows" {
  1075. t.Skip("see golang.org/issue/13434")
  1076. }
  1077. st := newServerTester(t, nil)
  1078. defer st.Close()
  1079. st.greet()
  1080. // Write too large of a frame (too large by one byte)
  1081. // We ignore the return value because it's expected that the server
  1082. // will only read the first 9 bytes (the headre) and then disconnect.
  1083. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  1084. gf := st.wantGoAway()
  1085. if gf.ErrCode != ErrCodeFrameSize {
  1086. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  1087. }
  1088. if st.serverLogBuf.Len() != 0 {
  1089. // Previously we spun here for a bit until the GOAWAY disconnect
  1090. // timer fired, logging while we fired.
  1091. t.Errorf("unexpected server output: %.500s\n", st.serverLogBuf.Bytes())
  1092. }
  1093. }
  1094. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1095. puppet := newHandlerPuppet()
  1096. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1097. puppet.act(w, r)
  1098. })
  1099. defer st.Close()
  1100. defer puppet.done()
  1101. st.greet()
  1102. st.writeHeaders(HeadersFrameParam{
  1103. StreamID: 1, // clients send odd numbers
  1104. BlockFragment: st.encodeHeader(":method", "POST"),
  1105. EndStream: false, // data coming
  1106. EndHeaders: true,
  1107. })
  1108. st.writeData(1, false, []byte("abcdef"))
  1109. puppet.do(readBodyHandler(t, "abc"))
  1110. st.wantWindowUpdate(0, 3)
  1111. st.wantWindowUpdate(1, 3)
  1112. puppet.do(readBodyHandler(t, "def"))
  1113. st.wantWindowUpdate(0, 3)
  1114. st.wantWindowUpdate(1, 3)
  1115. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1116. puppet.do(readBodyHandler(t, "ghi"))
  1117. puppet.do(readBodyHandler(t, "jkl"))
  1118. st.wantWindowUpdate(0, 3)
  1119. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1120. }
  1121. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1122. // See golang.org/issue/16556
  1123. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1124. puppet := newHandlerPuppet()
  1125. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1126. puppet.act(w, r)
  1127. })
  1128. defer st.Close()
  1129. defer puppet.done()
  1130. st.greet()
  1131. st.writeHeaders(HeadersFrameParam{
  1132. StreamID: 1,
  1133. BlockFragment: st.encodeHeader(":method", "POST"),
  1134. EndStream: false,
  1135. EndHeaders: true,
  1136. })
  1137. st.writeDataPadded(1, false, []byte("abcdef"), []byte{0, 0, 0, 0})
  1138. // Expect to immediately get our 5 bytes of padding back for
  1139. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1140. st.wantWindowUpdate(0, 5)
  1141. st.wantWindowUpdate(1, 5)
  1142. puppet.do(readBodyHandler(t, "abc"))
  1143. st.wantWindowUpdate(0, 3)
  1144. st.wantWindowUpdate(1, 3)
  1145. puppet.do(readBodyHandler(t, "def"))
  1146. st.wantWindowUpdate(0, 3)
  1147. st.wantWindowUpdate(1, 3)
  1148. }
  1149. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1150. st := newServerTester(t, nil)
  1151. defer st.Close()
  1152. st.greet()
  1153. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1154. t.Fatal(err)
  1155. }
  1156. gf := st.wantGoAway()
  1157. if gf.ErrCode != ErrCodeFlowControl {
  1158. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1159. }
  1160. if gf.LastStreamID != 0 {
  1161. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1162. }
  1163. }
  1164. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1165. inHandler := make(chan bool)
  1166. blockHandler := make(chan bool)
  1167. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1168. inHandler <- true
  1169. <-blockHandler
  1170. })
  1171. defer st.Close()
  1172. defer close(blockHandler)
  1173. st.greet()
  1174. st.writeHeaders(HeadersFrameParam{
  1175. StreamID: 1,
  1176. BlockFragment: st.encodeHeader(":method", "POST"),
  1177. EndStream: false, // keep it open
  1178. EndHeaders: true,
  1179. })
  1180. <-inHandler
  1181. // Send a bogus window update:
  1182. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1183. t.Fatal(err)
  1184. }
  1185. st.wantRSTStream(1, ErrCodeFlowControl)
  1186. }
  1187. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1188. // then runs fn once in the handler, and verifies that the error returned from
  1189. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1190. func testServerPostUnblock(t *testing.T,
  1191. handler func(http.ResponseWriter, *http.Request) error,
  1192. fn func(*serverTester),
  1193. checkErr func(error),
  1194. otherHeaders ...string) {
  1195. inHandler := make(chan bool)
  1196. errc := make(chan error, 1)
  1197. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1198. inHandler <- true
  1199. errc <- handler(w, r)
  1200. })
  1201. defer st.Close()
  1202. st.greet()
  1203. st.writeHeaders(HeadersFrameParam{
  1204. StreamID: 1,
  1205. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1206. EndStream: false, // keep it open
  1207. EndHeaders: true,
  1208. })
  1209. <-inHandler
  1210. fn(st)
  1211. select {
  1212. case err := <-errc:
  1213. if checkErr != nil {
  1214. checkErr(err)
  1215. }
  1216. case <-time.After(5 * time.Second):
  1217. t.Fatal("timeout waiting for Handler to return")
  1218. }
  1219. }
  1220. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1221. testServerPostUnblock(t,
  1222. func(w http.ResponseWriter, r *http.Request) (err error) {
  1223. _, err = r.Body.Read(make([]byte, 1))
  1224. return
  1225. },
  1226. func(st *serverTester) {
  1227. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1228. t.Fatal(err)
  1229. }
  1230. },
  1231. func(err error) {
  1232. want := StreamError{StreamID: 0x1, Code: 0x8}
  1233. if !reflect.DeepEqual(err, want) {
  1234. t.Errorf("Read error = %v; want %v", err, want)
  1235. }
  1236. },
  1237. )
  1238. }
  1239. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1240. // Run this test a bunch, because it doesn't always
  1241. // deadlock. But with a bunch, it did.
  1242. n := 50
  1243. if testing.Short() {
  1244. n = 5
  1245. }
  1246. for i := 0; i < n; i++ {
  1247. testServer_RSTStream_Unblocks_Header_Write(t)
  1248. }
  1249. }
  1250. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1251. inHandler := make(chan bool, 1)
  1252. unblockHandler := make(chan bool, 1)
  1253. headerWritten := make(chan bool, 1)
  1254. wroteRST := make(chan bool, 1)
  1255. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1256. inHandler <- true
  1257. <-wroteRST
  1258. w.Header().Set("foo", "bar")
  1259. w.WriteHeader(200)
  1260. w.(http.Flusher).Flush()
  1261. headerWritten <- true
  1262. <-unblockHandler
  1263. })
  1264. defer st.Close()
  1265. st.greet()
  1266. st.writeHeaders(HeadersFrameParam{
  1267. StreamID: 1,
  1268. BlockFragment: st.encodeHeader(":method", "POST"),
  1269. EndStream: false, // keep it open
  1270. EndHeaders: true,
  1271. })
  1272. <-inHandler
  1273. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1274. t.Fatal(err)
  1275. }
  1276. wroteRST <- true
  1277. st.awaitIdle()
  1278. select {
  1279. case <-headerWritten:
  1280. case <-time.After(2 * time.Second):
  1281. t.Error("timeout waiting for header write")
  1282. }
  1283. unblockHandler <- true
  1284. }
  1285. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1286. testServerPostUnblock(t,
  1287. func(w http.ResponseWriter, r *http.Request) (err error) {
  1288. _, err = r.Body.Read(make([]byte, 1))
  1289. return
  1290. },
  1291. func(st *serverTester) { st.cc.Close() },
  1292. func(err error) {
  1293. if err == nil {
  1294. t.Error("unexpected nil error from Request.Body.Read")
  1295. }
  1296. },
  1297. )
  1298. }
  1299. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1300. <-w.(http.CloseNotifier).CloseNotify()
  1301. return nil
  1302. }
  1303. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1304. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1305. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1306. t.Fatal(err)
  1307. }
  1308. }, nil)
  1309. }
  1310. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1311. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1312. }
  1313. // that CloseNotify unblocks after a stream error due to the client's
  1314. // problem that's unrelated to them explicitly canceling it (which is
  1315. // TestServer_CloseNotify_After_RSTStream above)
  1316. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1317. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1318. // data longer than declared Content-Length => stream error
  1319. st.writeData(1, true, []byte("1234"))
  1320. }, nil, "content-length", "3")
  1321. }
  1322. func TestServer_StateTransitions(t *testing.T) {
  1323. var st *serverTester
  1324. inHandler := make(chan bool)
  1325. writeData := make(chan bool)
  1326. leaveHandler := make(chan bool)
  1327. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1328. inHandler <- true
  1329. if st.stream(1) == nil {
  1330. t.Errorf("nil stream 1 in handler")
  1331. }
  1332. if got, want := st.streamState(1), stateOpen; got != want {
  1333. t.Errorf("in handler, state is %v; want %v", got, want)
  1334. }
  1335. writeData <- true
  1336. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1337. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1338. }
  1339. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1340. t.Errorf("in handler, state is %v; want %v", got, want)
  1341. }
  1342. <-leaveHandler
  1343. })
  1344. st.greet()
  1345. if st.stream(1) != nil {
  1346. t.Fatal("stream 1 should be empty")
  1347. }
  1348. if got := st.streamState(1); got != stateIdle {
  1349. t.Fatalf("stream 1 should be idle; got %v", got)
  1350. }
  1351. st.writeHeaders(HeadersFrameParam{
  1352. StreamID: 1,
  1353. BlockFragment: st.encodeHeader(":method", "POST"),
  1354. EndStream: false, // keep it open
  1355. EndHeaders: true,
  1356. })
  1357. <-inHandler
  1358. <-writeData
  1359. st.writeData(1, true, nil)
  1360. leaveHandler <- true
  1361. hf := st.wantHeaders()
  1362. if !hf.StreamEnded() {
  1363. t.Fatal("expected END_STREAM flag")
  1364. }
  1365. if got, want := st.streamState(1), stateClosed; got != want {
  1366. t.Errorf("at end, state is %v; want %v", got, want)
  1367. }
  1368. if st.stream(1) != nil {
  1369. t.Fatal("at end, stream 1 should be gone")
  1370. }
  1371. }
  1372. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1373. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1374. testServerRejectsConn(t, func(st *serverTester) {
  1375. st.writeHeaders(HeadersFrameParam{
  1376. StreamID: 1,
  1377. BlockFragment: st.encodeHeader(),
  1378. EndStream: true,
  1379. EndHeaders: false,
  1380. })
  1381. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1382. StreamID: 3, // different stream.
  1383. BlockFragment: st.encodeHeader(),
  1384. EndStream: true,
  1385. EndHeaders: true,
  1386. })
  1387. })
  1388. }
  1389. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1390. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1391. testServerRejectsConn(t, func(st *serverTester) {
  1392. st.writeHeaders(HeadersFrameParam{
  1393. StreamID: 1,
  1394. BlockFragment: st.encodeHeader(),
  1395. EndStream: true,
  1396. EndHeaders: false,
  1397. })
  1398. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1399. t.Fatal(err)
  1400. }
  1401. })
  1402. }
  1403. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1404. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1405. testServerRejectsConn(t, func(st *serverTester) {
  1406. st.writeHeaders(HeadersFrameParam{
  1407. StreamID: 1,
  1408. BlockFragment: st.encodeHeader(),
  1409. EndStream: true,
  1410. EndHeaders: true,
  1411. })
  1412. st.wantHeaders()
  1413. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1414. t.Fatal(err)
  1415. }
  1416. })
  1417. }
  1418. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1419. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1420. testServerRejectsConn(t, func(st *serverTester) {
  1421. st.writeHeaders(HeadersFrameParam{
  1422. StreamID: 1,
  1423. BlockFragment: st.encodeHeader(),
  1424. EndStream: true,
  1425. EndHeaders: false,
  1426. })
  1427. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1428. t.Fatal(err)
  1429. }
  1430. })
  1431. }
  1432. // No HEADERS on stream 0.
  1433. func TestServer_Rejects_Headers0(t *testing.T) {
  1434. testServerRejectsConn(t, func(st *serverTester) {
  1435. st.fr.AllowIllegalWrites = true
  1436. st.writeHeaders(HeadersFrameParam{
  1437. StreamID: 0,
  1438. BlockFragment: st.encodeHeader(),
  1439. EndStream: true,
  1440. EndHeaders: true,
  1441. })
  1442. })
  1443. }
  1444. // No CONTINUATION on stream 0.
  1445. func TestServer_Rejects_Continuation0(t *testing.T) {
  1446. testServerRejectsConn(t, func(st *serverTester) {
  1447. st.fr.AllowIllegalWrites = true
  1448. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1449. t.Fatal(err)
  1450. }
  1451. })
  1452. }
  1453. // No PRIORITY on stream 0.
  1454. func TestServer_Rejects_Priority0(t *testing.T) {
  1455. testServerRejectsConn(t, func(st *serverTester) {
  1456. st.fr.AllowIllegalWrites = true
  1457. st.writePriority(0, PriorityParam{StreamDep: 1})
  1458. })
  1459. }
  1460. // No HEADERS frame with a self-dependence.
  1461. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1462. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1463. st.fr.AllowIllegalWrites = true
  1464. st.writeHeaders(HeadersFrameParam{
  1465. StreamID: 1,
  1466. BlockFragment: st.encodeHeader(),
  1467. EndStream: true,
  1468. EndHeaders: true,
  1469. Priority: PriorityParam{StreamDep: 1},
  1470. })
  1471. })
  1472. }
  1473. // No PRIORTY frame with a self-dependence.
  1474. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1475. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1476. st.fr.AllowIllegalWrites = true
  1477. st.writePriority(1, PriorityParam{StreamDep: 1})
  1478. })
  1479. }
  1480. func TestServer_Rejects_PushPromise(t *testing.T) {
  1481. testServerRejectsConn(t, func(st *serverTester) {
  1482. pp := PushPromiseParam{
  1483. StreamID: 1,
  1484. PromiseID: 3,
  1485. }
  1486. if err := st.fr.WritePushPromise(pp); err != nil {
  1487. t.Fatal(err)
  1488. }
  1489. })
  1490. }
  1491. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1492. // frame and a server close after the client does something
  1493. // deserving a CONNECTION_ERROR.
  1494. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1495. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1496. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1497. defer st.Close()
  1498. st.greet()
  1499. writeReq(st)
  1500. st.wantGoAway()
  1501. errc := make(chan error, 1)
  1502. go func() {
  1503. fr, err := st.fr.ReadFrame()
  1504. if err == nil {
  1505. err = fmt.Errorf("got frame of type %T", fr)
  1506. }
  1507. errc <- err
  1508. }()
  1509. select {
  1510. case err := <-errc:
  1511. if err != io.EOF {
  1512. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1513. }
  1514. case <-time.After(2 * time.Second):
  1515. t.Error("timeout waiting for disconnect")
  1516. }
  1517. }
  1518. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1519. // error code after a client sends a bogus request.
  1520. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1521. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1522. defer st.Close()
  1523. st.greet()
  1524. writeReq(st)
  1525. st.wantRSTStream(1, code)
  1526. }
  1527. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1528. // write a single request with writeReq, and then verify that the
  1529. // *http.Request is built correctly in checkReq.
  1530. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1531. gotReq := make(chan bool, 1)
  1532. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1533. if r.Body == nil {
  1534. t.Fatal("nil Body")
  1535. }
  1536. checkReq(r)
  1537. gotReq <- true
  1538. })
  1539. defer st.Close()
  1540. st.greet()
  1541. writeReq(st)
  1542. select {
  1543. case <-gotReq:
  1544. case <-time.After(2 * time.Second):
  1545. t.Error("timeout waiting for request")
  1546. }
  1547. }
  1548. func getSlash(st *serverTester) { st.bodylessReq1() }
  1549. func TestServer_Response_NoData(t *testing.T) {
  1550. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1551. // Nothing.
  1552. return nil
  1553. }, func(st *serverTester) {
  1554. getSlash(st)
  1555. hf := st.wantHeaders()
  1556. if !hf.StreamEnded() {
  1557. t.Fatal("want END_STREAM flag")
  1558. }
  1559. if !hf.HeadersEnded() {
  1560. t.Fatal("want END_HEADERS flag")
  1561. }
  1562. })
  1563. }
  1564. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1565. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1566. w.Header().Set("Foo-Bar", "some-value")
  1567. return nil
  1568. }, func(st *serverTester) {
  1569. getSlash(st)
  1570. hf := st.wantHeaders()
  1571. if !hf.StreamEnded() {
  1572. t.Fatal("want END_STREAM flag")
  1573. }
  1574. if !hf.HeadersEnded() {
  1575. t.Fatal("want END_HEADERS flag")
  1576. }
  1577. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1578. wanth := [][2]string{
  1579. {":status", "200"},
  1580. {"foo-bar", "some-value"},
  1581. {"content-length", "0"},
  1582. }
  1583. if !reflect.DeepEqual(goth, wanth) {
  1584. t.Errorf("Got headers %v; want %v", goth, wanth)
  1585. }
  1586. })
  1587. }
  1588. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1589. const msg = "<html>this is HTML."
  1590. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1591. w.Header().Set("Content-Type", "foo/bar")
  1592. io.WriteString(w, msg)
  1593. return nil
  1594. }, func(st *serverTester) {
  1595. getSlash(st)
  1596. hf := st.wantHeaders()
  1597. if hf.StreamEnded() {
  1598. t.Fatal("don't want END_STREAM, expecting data")
  1599. }
  1600. if !hf.HeadersEnded() {
  1601. t.Fatal("want END_HEADERS flag")
  1602. }
  1603. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1604. wanth := [][2]string{
  1605. {":status", "200"},
  1606. {"content-type", "foo/bar"},
  1607. {"content-length", strconv.Itoa(len(msg))},
  1608. }
  1609. if !reflect.DeepEqual(goth, wanth) {
  1610. t.Errorf("Got headers %v; want %v", goth, wanth)
  1611. }
  1612. df := st.wantData()
  1613. if !df.StreamEnded() {
  1614. t.Error("expected DATA to have END_STREAM flag")
  1615. }
  1616. if got := string(df.Data()); got != msg {
  1617. t.Errorf("got DATA %q; want %q", got, msg)
  1618. }
  1619. })
  1620. }
  1621. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1622. const msg = "hi"
  1623. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1624. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1625. io.WriteString(w, msg)
  1626. return nil
  1627. }, func(st *serverTester) {
  1628. getSlash(st)
  1629. hf := st.wantHeaders()
  1630. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1631. wanth := [][2]string{
  1632. {":status", "200"},
  1633. {"content-type", "text/plain; charset=utf-8"},
  1634. {"content-length", strconv.Itoa(len(msg))},
  1635. }
  1636. if !reflect.DeepEqual(goth, wanth) {
  1637. t.Errorf("Got headers %v; want %v", goth, wanth)
  1638. }
  1639. })
  1640. }
  1641. // Header accessed only after the initial write.
  1642. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1643. const msg = "<html>this is HTML."
  1644. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1645. io.WriteString(w, msg)
  1646. w.Header().Set("foo", "should be ignored")
  1647. return nil
  1648. }, func(st *serverTester) {
  1649. getSlash(st)
  1650. hf := st.wantHeaders()
  1651. if hf.StreamEnded() {
  1652. t.Fatal("unexpected END_STREAM")
  1653. }
  1654. if !hf.HeadersEnded() {
  1655. t.Fatal("want END_HEADERS flag")
  1656. }
  1657. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1658. wanth := [][2]string{
  1659. {":status", "200"},
  1660. {"content-type", "text/html; charset=utf-8"},
  1661. {"content-length", strconv.Itoa(len(msg))},
  1662. }
  1663. if !reflect.DeepEqual(goth, wanth) {
  1664. t.Errorf("Got headers %v; want %v", goth, wanth)
  1665. }
  1666. })
  1667. }
  1668. // Header accessed before the initial write and later mutated.
  1669. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1670. const msg = "<html>this is HTML."
  1671. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1672. w.Header().Set("foo", "proper value")
  1673. io.WriteString(w, msg)
  1674. w.Header().Set("foo", "should be ignored")
  1675. return nil
  1676. }, func(st *serverTester) {
  1677. getSlash(st)
  1678. hf := st.wantHeaders()
  1679. if hf.StreamEnded() {
  1680. t.Fatal("unexpected END_STREAM")
  1681. }
  1682. if !hf.HeadersEnded() {
  1683. t.Fatal("want END_HEADERS flag")
  1684. }
  1685. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1686. wanth := [][2]string{
  1687. {":status", "200"},
  1688. {"foo", "proper value"},
  1689. {"content-type", "text/html; charset=utf-8"},
  1690. {"content-length", strconv.Itoa(len(msg))},
  1691. }
  1692. if !reflect.DeepEqual(goth, wanth) {
  1693. t.Errorf("Got headers %v; want %v", goth, wanth)
  1694. }
  1695. })
  1696. }
  1697. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1698. const msg = "<html>this is HTML."
  1699. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1700. io.WriteString(w, msg)
  1701. return nil
  1702. }, func(st *serverTester) {
  1703. getSlash(st)
  1704. hf := st.wantHeaders()
  1705. if hf.StreamEnded() {
  1706. t.Fatal("don't want END_STREAM, expecting data")
  1707. }
  1708. if !hf.HeadersEnded() {
  1709. t.Fatal("want END_HEADERS flag")
  1710. }
  1711. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1712. wanth := [][2]string{
  1713. {":status", "200"},
  1714. {"content-type", "text/html; charset=utf-8"},
  1715. {"content-length", strconv.Itoa(len(msg))},
  1716. }
  1717. if !reflect.DeepEqual(goth, wanth) {
  1718. t.Errorf("Got headers %v; want %v", goth, wanth)
  1719. }
  1720. df := st.wantData()
  1721. if !df.StreamEnded() {
  1722. t.Error("expected DATA to have END_STREAM flag")
  1723. }
  1724. if got := string(df.Data()); got != msg {
  1725. t.Errorf("got DATA %q; want %q", got, msg)
  1726. }
  1727. })
  1728. }
  1729. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1730. const msg = "<html>this is HTML"
  1731. const msg2 = ", and this is the next chunk"
  1732. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1733. io.WriteString(w, msg)
  1734. w.(http.Flusher).Flush()
  1735. io.WriteString(w, msg2)
  1736. return nil
  1737. }, func(st *serverTester) {
  1738. getSlash(st)
  1739. hf := st.wantHeaders()
  1740. if hf.StreamEnded() {
  1741. t.Fatal("unexpected END_STREAM flag")
  1742. }
  1743. if !hf.HeadersEnded() {
  1744. t.Fatal("want END_HEADERS flag")
  1745. }
  1746. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1747. wanth := [][2]string{
  1748. {":status", "200"},
  1749. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1750. // and no content-length
  1751. }
  1752. if !reflect.DeepEqual(goth, wanth) {
  1753. t.Errorf("Got headers %v; want %v", goth, wanth)
  1754. }
  1755. {
  1756. df := st.wantData()
  1757. if df.StreamEnded() {
  1758. t.Error("unexpected END_STREAM flag")
  1759. }
  1760. if got := string(df.Data()); got != msg {
  1761. t.Errorf("got DATA %q; want %q", got, msg)
  1762. }
  1763. }
  1764. {
  1765. df := st.wantData()
  1766. if !df.StreamEnded() {
  1767. t.Error("wanted END_STREAM flag on last data chunk")
  1768. }
  1769. if got := string(df.Data()); got != msg2 {
  1770. t.Errorf("got DATA %q; want %q", got, msg2)
  1771. }
  1772. }
  1773. })
  1774. }
  1775. func TestServer_Response_LargeWrite(t *testing.T) {
  1776. const size = 1 << 20
  1777. const maxFrameSize = 16 << 10
  1778. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1779. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1780. if err != nil {
  1781. return fmt.Errorf("Write error: %v", err)
  1782. }
  1783. if n != size {
  1784. return fmt.Errorf("wrong size %d from Write", n)
  1785. }
  1786. return nil
  1787. }, func(st *serverTester) {
  1788. if err := st.fr.WriteSettings(
  1789. Setting{SettingInitialWindowSize, 0},
  1790. Setting{SettingMaxFrameSize, maxFrameSize},
  1791. ); err != nil {
  1792. t.Fatal(err)
  1793. }
  1794. st.wantSettingsAck()
  1795. getSlash(st) // make the single request
  1796. // Give the handler quota to write:
  1797. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1798. t.Fatal(err)
  1799. }
  1800. // Give the handler quota to write to connection-level
  1801. // window as well
  1802. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1803. t.Fatal(err)
  1804. }
  1805. hf := st.wantHeaders()
  1806. if hf.StreamEnded() {
  1807. t.Fatal("unexpected END_STREAM flag")
  1808. }
  1809. if !hf.HeadersEnded() {
  1810. t.Fatal("want END_HEADERS flag")
  1811. }
  1812. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1813. wanth := [][2]string{
  1814. {":status", "200"},
  1815. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1816. // and no content-length
  1817. }
  1818. if !reflect.DeepEqual(goth, wanth) {
  1819. t.Errorf("Got headers %v; want %v", goth, wanth)
  1820. }
  1821. var bytes, frames int
  1822. for {
  1823. df := st.wantData()
  1824. bytes += len(df.Data())
  1825. frames++
  1826. for _, b := range df.Data() {
  1827. if b != 'a' {
  1828. t.Fatal("non-'a' byte seen in DATA")
  1829. }
  1830. }
  1831. if df.StreamEnded() {
  1832. break
  1833. }
  1834. }
  1835. if bytes != size {
  1836. t.Errorf("Got %d bytes; want %d", bytes, size)
  1837. }
  1838. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1839. t.Errorf("Got %d frames; want %d", frames, size)
  1840. }
  1841. })
  1842. }
  1843. // Test that the handler can't write more than the client allows
  1844. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1845. // Make these reads. Before each read, the client adds exactly enough
  1846. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1847. reads := []int{123, 1, 13, 127}
  1848. size := 0
  1849. for _, n := range reads {
  1850. size += n
  1851. }
  1852. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1853. w.(http.Flusher).Flush()
  1854. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1855. if err != nil {
  1856. return fmt.Errorf("Write error: %v", err)
  1857. }
  1858. if n != size {
  1859. return fmt.Errorf("wrong size %d from Write", n)
  1860. }
  1861. return nil
  1862. }, func(st *serverTester) {
  1863. // Set the window size to something explicit for this test.
  1864. // It's also how much initial data we expect.
  1865. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1866. t.Fatal(err)
  1867. }
  1868. st.wantSettingsAck()
  1869. getSlash(st) // make the single request
  1870. hf := st.wantHeaders()
  1871. if hf.StreamEnded() {
  1872. t.Fatal("unexpected END_STREAM flag")
  1873. }
  1874. if !hf.HeadersEnded() {
  1875. t.Fatal("want END_HEADERS flag")
  1876. }
  1877. df := st.wantData()
  1878. if got := len(df.Data()); got != reads[0] {
  1879. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1880. }
  1881. for _, quota := range reads[1:] {
  1882. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1883. t.Fatal(err)
  1884. }
  1885. df := st.wantData()
  1886. if int(quota) != len(df.Data()) {
  1887. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1888. }
  1889. }
  1890. })
  1891. }
  1892. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1893. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1894. const size = 1 << 20
  1895. const maxFrameSize = 16 << 10
  1896. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1897. w.(http.Flusher).Flush()
  1898. errc := make(chan error, 1)
  1899. go func() {
  1900. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1901. errc <- err
  1902. }()
  1903. select {
  1904. case err := <-errc:
  1905. if err == nil {
  1906. return errors.New("unexpected nil error from Write in handler")
  1907. }
  1908. return nil
  1909. case <-time.After(2 * time.Second):
  1910. return errors.New("timeout waiting for Write in handler")
  1911. }
  1912. }, func(st *serverTester) {
  1913. if err := st.fr.WriteSettings(
  1914. Setting{SettingInitialWindowSize, 0},
  1915. Setting{SettingMaxFrameSize, maxFrameSize},
  1916. ); err != nil {
  1917. t.Fatal(err)
  1918. }
  1919. st.wantSettingsAck()
  1920. getSlash(st) // make the single request
  1921. hf := st.wantHeaders()
  1922. if hf.StreamEnded() {
  1923. t.Fatal("unexpected END_STREAM flag")
  1924. }
  1925. if !hf.HeadersEnded() {
  1926. t.Fatal("want END_HEADERS flag")
  1927. }
  1928. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1929. t.Fatal(err)
  1930. }
  1931. })
  1932. }
  1933. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1934. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1935. w.(http.Flusher).Flush()
  1936. // Nothing; send empty DATA
  1937. return nil
  1938. }, func(st *serverTester) {
  1939. // Handler gets no data quota:
  1940. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1941. t.Fatal(err)
  1942. }
  1943. st.wantSettingsAck()
  1944. getSlash(st) // make the single request
  1945. hf := st.wantHeaders()
  1946. if hf.StreamEnded() {
  1947. t.Fatal("unexpected END_STREAM flag")
  1948. }
  1949. if !hf.HeadersEnded() {
  1950. t.Fatal("want END_HEADERS flag")
  1951. }
  1952. df := st.wantData()
  1953. if got := len(df.Data()); got != 0 {
  1954. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1955. }
  1956. if !df.StreamEnded() {
  1957. t.Fatal("DATA didn't have END_STREAM")
  1958. }
  1959. })
  1960. }
  1961. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1962. const msg = "foo"
  1963. const reply = "bar"
  1964. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1965. if v := r.Header.Get("Expect"); v != "" {
  1966. t.Errorf("Expect header = %q; want empty", v)
  1967. }
  1968. buf := make([]byte, len(msg))
  1969. // This read should trigger the 100-continue being sent.
  1970. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1971. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1972. }
  1973. _, err := io.WriteString(w, reply)
  1974. return err
  1975. }, func(st *serverTester) {
  1976. st.writeHeaders(HeadersFrameParam{
  1977. StreamID: 1, // clients send odd numbers
  1978. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1979. EndStream: false,
  1980. EndHeaders: true,
  1981. })
  1982. hf := st.wantHeaders()
  1983. if hf.StreamEnded() {
  1984. t.Fatal("unexpected END_STREAM flag")
  1985. }
  1986. if !hf.HeadersEnded() {
  1987. t.Fatal("want END_HEADERS flag")
  1988. }
  1989. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1990. wanth := [][2]string{
  1991. {":status", "100"},
  1992. }
  1993. if !reflect.DeepEqual(goth, wanth) {
  1994. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1995. }
  1996. // Okay, they sent status 100, so we can send our
  1997. // gigantic and/or sensitive "foo" payload now.
  1998. st.writeData(1, true, []byte(msg))
  1999. st.wantWindowUpdate(0, uint32(len(msg)))
  2000. hf = st.wantHeaders()
  2001. if hf.StreamEnded() {
  2002. t.Fatal("expected data to follow")
  2003. }
  2004. if !hf.HeadersEnded() {
  2005. t.Fatal("want END_HEADERS flag")
  2006. }
  2007. goth = st.decodeHeader(hf.HeaderBlockFragment())
  2008. wanth = [][2]string{
  2009. {":status", "200"},
  2010. {"content-type", "text/plain; charset=utf-8"},
  2011. {"content-length", strconv.Itoa(len(reply))},
  2012. }
  2013. if !reflect.DeepEqual(goth, wanth) {
  2014. t.Errorf("Got headers %v; want %v", goth, wanth)
  2015. }
  2016. df := st.wantData()
  2017. if string(df.Data()) != reply {
  2018. t.Errorf("Client read %q; want %q", df.Data(), reply)
  2019. }
  2020. if !df.StreamEnded() {
  2021. t.Errorf("expect data stream end")
  2022. }
  2023. })
  2024. }
  2025. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  2026. errc := make(chan error, 1)
  2027. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2028. p := []byte("some data.\n")
  2029. for {
  2030. _, err := w.Write(p)
  2031. if err != nil {
  2032. errc <- err
  2033. return nil
  2034. }
  2035. }
  2036. }, func(st *serverTester) {
  2037. st.writeHeaders(HeadersFrameParam{
  2038. StreamID: 1,
  2039. BlockFragment: st.encodeHeader(),
  2040. EndStream: false,
  2041. EndHeaders: true,
  2042. })
  2043. hf := st.wantHeaders()
  2044. if hf.StreamEnded() {
  2045. t.Fatal("unexpected END_STREAM flag")
  2046. }
  2047. if !hf.HeadersEnded() {
  2048. t.Fatal("want END_HEADERS flag")
  2049. }
  2050. // Close the connection and wait for the handler to (hopefully) notice.
  2051. st.cc.Close()
  2052. select {
  2053. case <-errc:
  2054. case <-time.After(5 * time.Second):
  2055. t.Error("timeout")
  2056. }
  2057. })
  2058. }
  2059. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  2060. const testPath = "/some/path"
  2061. inHandler := make(chan uint32)
  2062. leaveHandler := make(chan bool)
  2063. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2064. id := w.(*responseWriter).rws.stream.id
  2065. inHandler <- id
  2066. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  2067. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  2068. }
  2069. <-leaveHandler
  2070. })
  2071. defer st.Close()
  2072. st.greet()
  2073. nextStreamID := uint32(1)
  2074. streamID := func() uint32 {
  2075. defer func() { nextStreamID += 2 }()
  2076. return nextStreamID
  2077. }
  2078. sendReq := func(id uint32, headers ...string) {
  2079. st.writeHeaders(HeadersFrameParam{
  2080. StreamID: id,
  2081. BlockFragment: st.encodeHeader(headers...),
  2082. EndStream: true,
  2083. EndHeaders: true,
  2084. })
  2085. }
  2086. for i := 0; i < defaultMaxStreams; i++ {
  2087. sendReq(streamID())
  2088. <-inHandler
  2089. }
  2090. defer func() {
  2091. for i := 0; i < defaultMaxStreams; i++ {
  2092. leaveHandler <- true
  2093. }
  2094. }()
  2095. // And this one should cross the limit:
  2096. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2097. // even if we're rejecting it)
  2098. rejectID := streamID()
  2099. headerBlock := st.encodeHeader(":path", testPath)
  2100. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2101. st.writeHeaders(HeadersFrameParam{
  2102. StreamID: rejectID,
  2103. BlockFragment: frag1,
  2104. EndStream: true,
  2105. EndHeaders: false, // CONTINUATION coming
  2106. })
  2107. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2108. t.Fatal(err)
  2109. }
  2110. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2111. // But let a handler finish:
  2112. leaveHandler <- true
  2113. st.wantHeaders()
  2114. // And now another stream should be able to start:
  2115. goodID := streamID()
  2116. sendReq(goodID, ":path", testPath)
  2117. select {
  2118. case got := <-inHandler:
  2119. if got != goodID {
  2120. t.Errorf("Got stream %d; want %d", got, goodID)
  2121. }
  2122. case <-time.After(3 * time.Second):
  2123. t.Error("timeout waiting for handler")
  2124. }
  2125. }
  2126. // So many response headers that the server needs to use CONTINUATION frames:
  2127. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2128. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2129. h := w.Header()
  2130. for i := 0; i < 5000; i++ {
  2131. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2132. }
  2133. return nil
  2134. }, func(st *serverTester) {
  2135. getSlash(st)
  2136. hf := st.wantHeaders()
  2137. if hf.HeadersEnded() {
  2138. t.Fatal("got unwanted END_HEADERS flag")
  2139. }
  2140. n := 0
  2141. for {
  2142. n++
  2143. cf := st.wantContinuation()
  2144. if cf.HeadersEnded() {
  2145. break
  2146. }
  2147. }
  2148. if n < 5 {
  2149. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2150. }
  2151. })
  2152. }
  2153. // This previously crashed (reported by Mathieu Lonjaret as observed
  2154. // while using Camlistore) because we got a DATA frame from the client
  2155. // after the handler exited and our logic at the time was wrong,
  2156. // keeping a stream in the map in stateClosed, which tickled an
  2157. // invariant check later when we tried to remove that stream (via
  2158. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2159. // ended.
  2160. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2161. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2162. // nothing
  2163. return nil
  2164. }, func(st *serverTester) {
  2165. st.writeHeaders(HeadersFrameParam{
  2166. StreamID: 1,
  2167. BlockFragment: st.encodeHeader(),
  2168. EndStream: false, // DATA is coming
  2169. EndHeaders: true,
  2170. })
  2171. hf := st.wantHeaders()
  2172. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2173. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2174. }
  2175. // Sent when the a Handler closes while a client has
  2176. // indicated it's still sending DATA:
  2177. st.wantRSTStream(1, ErrCodeNo)
  2178. // Now the handler has ended, so it's ended its
  2179. // stream, but the client hasn't closed its side
  2180. // (stateClosedLocal). So send more data and verify
  2181. // it doesn't crash with an internal invariant panic, like
  2182. // it did before.
  2183. st.writeData(1, true, []byte("foo"))
  2184. // Get our flow control bytes back, since the handler didn't get them.
  2185. st.wantWindowUpdate(0, uint32(len("foo")))
  2186. // Sent after a peer sends data anyway (admittedly the
  2187. // previous RST_STREAM might've still been in-flight),
  2188. // but they'll get the more friendly 'cancel' code
  2189. // first.
  2190. st.wantRSTStream(1, ErrCodeStreamClosed)
  2191. // Set up a bunch of machinery to record the panic we saw
  2192. // previously.
  2193. var (
  2194. panMu sync.Mutex
  2195. panicVal interface{}
  2196. )
  2197. testHookOnPanicMu.Lock()
  2198. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2199. panMu.Lock()
  2200. panicVal = pv
  2201. panMu.Unlock()
  2202. return true
  2203. }
  2204. testHookOnPanicMu.Unlock()
  2205. // Now force the serve loop to end, via closing the connection.
  2206. st.cc.Close()
  2207. select {
  2208. case <-st.sc.doneServing:
  2209. // Loop has exited.
  2210. panMu.Lock()
  2211. got := panicVal
  2212. panMu.Unlock()
  2213. if got != nil {
  2214. t.Errorf("Got panic: %v", got)
  2215. }
  2216. case <-time.After(5 * time.Second):
  2217. t.Error("timeout")
  2218. }
  2219. })
  2220. }
  2221. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2222. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2223. func testRejectTLS(t *testing.T, max uint16) {
  2224. st := newServerTester(t, nil, func(c *tls.Config) {
  2225. c.MaxVersion = max
  2226. })
  2227. defer st.Close()
  2228. gf := st.wantGoAway()
  2229. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2230. t.Errorf("Got error code %v; want %v", got, want)
  2231. }
  2232. }
  2233. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2234. st := newServerTester(t, nil, func(c *tls.Config) {
  2235. // All TLS 1.3 ciphers are good. Test with TLS 1.2.
  2236. c.MaxVersion = tls.VersionTLS12
  2237. // Only list bad ones:
  2238. c.CipherSuites = []uint16{
  2239. tls.TLS_RSA_WITH_RC4_128_SHA,
  2240. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2241. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2242. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2243. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2244. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2245. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2246. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2247. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2248. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2249. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2250. cipher_TLS_RSA_WITH_AES_128_CBC_SHA256,
  2251. }
  2252. })
  2253. defer st.Close()
  2254. gf := st.wantGoAway()
  2255. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2256. t.Errorf("Got error code %v; want %v", got, want)
  2257. }
  2258. }
  2259. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2260. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2261. st := newServerTester(t, nil, func(c *tls.Config) {
  2262. // Have the client only support the one required by the spec.
  2263. c.CipherSuites = []uint16{requiredSuite}
  2264. }, func(ts *httptest.Server) {
  2265. var srv *http.Server = ts.Config
  2266. // Have the server configured with no specific cipher suites.
  2267. // This tests that Go's defaults include the required one.
  2268. srv.TLSConfig = nil
  2269. })
  2270. defer st.Close()
  2271. st.greet()
  2272. }
  2273. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2274. if f.Name == "date" {
  2275. return
  2276. }
  2277. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2278. }
  2279. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2280. st.decodedHeaders = nil
  2281. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2282. st.t.Fatalf("hpack decoding error: %v", err)
  2283. }
  2284. if err := st.hpackDec.Close(); err != nil {
  2285. st.t.Fatalf("hpack decoding error: %v", err)
  2286. }
  2287. return st.decodedHeaders
  2288. }
  2289. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2290. // write a single request that must be handled by the handler. This waits up to 5s
  2291. // for client to return, then up to an additional 2s for the handler to return.
  2292. func testServerResponse(t testing.TB,
  2293. handler func(http.ResponseWriter, *http.Request) error,
  2294. client func(*serverTester),
  2295. ) {
  2296. errc := make(chan error, 1)
  2297. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2298. if r.Body == nil {
  2299. t.Fatal("nil Body")
  2300. }
  2301. errc <- handler(w, r)
  2302. })
  2303. defer st.Close()
  2304. donec := make(chan bool)
  2305. go func() {
  2306. defer close(donec)
  2307. st.greet()
  2308. client(st)
  2309. }()
  2310. select {
  2311. case <-donec:
  2312. case <-time.After(5 * time.Second):
  2313. t.Fatal("timeout in client")
  2314. }
  2315. select {
  2316. case err := <-errc:
  2317. if err != nil {
  2318. t.Fatalf("Error in handler: %v", err)
  2319. }
  2320. case <-time.After(2 * time.Second):
  2321. t.Fatal("timeout in handler")
  2322. }
  2323. }
  2324. // readBodyHandler returns an http Handler func that reads len(want)
  2325. // bytes from r.Body and fails t if the contents read were not
  2326. // the value of want.
  2327. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2328. return func(w http.ResponseWriter, r *http.Request) {
  2329. buf := make([]byte, len(want))
  2330. _, err := io.ReadFull(r.Body, buf)
  2331. if err != nil {
  2332. t.Error(err)
  2333. return
  2334. }
  2335. if string(buf) != want {
  2336. t.Errorf("read %q; want %q", buf, want)
  2337. }
  2338. }
  2339. }
  2340. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2341. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2342. // http://sourceforge.net/p/curl/bugs/1472/
  2343. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2344. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2345. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2346. if runtime.GOOS != "linux" {
  2347. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2348. }
  2349. if testing.Short() {
  2350. t.Skip("skipping curl test in short mode")
  2351. }
  2352. requireCurl(t)
  2353. var gotConn int32
  2354. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2355. const msg = "Hello from curl!\n"
  2356. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2357. w.Header().Set("Foo", "Bar")
  2358. w.Header().Set("Client-Proto", r.Proto)
  2359. io.WriteString(w, msg)
  2360. }))
  2361. ConfigureServer(ts.Config, &Server{
  2362. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2363. })
  2364. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2365. ts.StartTLS()
  2366. defer ts.Close()
  2367. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2368. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2369. defer kill(container)
  2370. resc := make(chan interface{}, 1)
  2371. go func() {
  2372. res, err := dockerLogs(container)
  2373. if err != nil {
  2374. resc <- err
  2375. } else {
  2376. resc <- res
  2377. }
  2378. }()
  2379. select {
  2380. case res := <-resc:
  2381. if err, ok := res.(error); ok {
  2382. t.Fatal(err)
  2383. }
  2384. body := string(res.([]byte))
  2385. // Search for both "key: value" and "key:value", since curl changed their format
  2386. // Our Dockerfile contains the latest version (no space), but just in case people
  2387. // didn't rebuild, check both.
  2388. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2389. t.Errorf("didn't see foo: Bar header")
  2390. t.Logf("Got: %s", body)
  2391. }
  2392. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2393. t.Errorf("didn't see client-proto: HTTP/2 header")
  2394. t.Logf("Got: %s", res)
  2395. }
  2396. if !strings.Contains(string(res.([]byte)), msg) {
  2397. t.Errorf("didn't see %q content", msg)
  2398. t.Logf("Got: %s", res)
  2399. }
  2400. case <-time.After(3 * time.Second):
  2401. t.Errorf("timeout waiting for curl")
  2402. }
  2403. if atomic.LoadInt32(&gotConn) == 0 {
  2404. t.Error("never saw an http2 connection")
  2405. }
  2406. }
  2407. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2408. func TestServerWithH2Load(t *testing.T) {
  2409. if !*doh2load {
  2410. t.Skip("Skipping without --h2load flag.")
  2411. }
  2412. if runtime.GOOS != "linux" {
  2413. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2414. }
  2415. requireH2load(t)
  2416. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2417. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2418. io.WriteString(w, msg)
  2419. w.(http.Flusher).Flush()
  2420. io.WriteString(w, msg)
  2421. }))
  2422. ts.StartTLS()
  2423. defer ts.Close()
  2424. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2425. "-n100000", "-c100", "-m100", ts.URL)
  2426. cmd.Stdout = os.Stdout
  2427. cmd.Stderr = os.Stderr
  2428. if err := cmd.Run(); err != nil {
  2429. t.Fatal(err)
  2430. }
  2431. }
  2432. // Issue 12843
  2433. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2434. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2435. defer st.Close()
  2436. // shake hands
  2437. frameSize := defaultMaxReadFrameSize
  2438. var advHeaderListSize *uint32
  2439. st.greetAndCheckSettings(func(s Setting) error {
  2440. switch s.ID {
  2441. case SettingMaxFrameSize:
  2442. if s.Val < minMaxFrameSize {
  2443. frameSize = minMaxFrameSize
  2444. } else if s.Val > maxFrameSize {
  2445. frameSize = maxFrameSize
  2446. } else {
  2447. frameSize = int(s.Val)
  2448. }
  2449. case SettingMaxHeaderListSize:
  2450. advHeaderListSize = &s.Val
  2451. }
  2452. return nil
  2453. })
  2454. if advHeaderListSize == nil {
  2455. t.Errorf("server didn't advertise a max header list size")
  2456. } else if *advHeaderListSize == 0 {
  2457. t.Errorf("server advertised a max header list size of 0")
  2458. }
  2459. st.encodeHeaderField(":method", "GET")
  2460. st.encodeHeaderField(":path", "/")
  2461. st.encodeHeaderField(":scheme", "https")
  2462. cookie := strings.Repeat("*", 4058)
  2463. st.encodeHeaderField("cookie", cookie)
  2464. st.writeHeaders(HeadersFrameParam{
  2465. StreamID: 1,
  2466. BlockFragment: st.headerBuf.Bytes(),
  2467. EndStream: true,
  2468. EndHeaders: false,
  2469. })
  2470. // Capture the short encoding of a duplicate ~4K cookie, now
  2471. // that we've already sent it once.
  2472. st.headerBuf.Reset()
  2473. st.encodeHeaderField("cookie", cookie)
  2474. // Now send 1MB of it.
  2475. const size = 1 << 20
  2476. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2477. for len(b) > 0 {
  2478. chunk := b
  2479. if len(chunk) > frameSize {
  2480. chunk = chunk[:frameSize]
  2481. }
  2482. b = b[len(chunk):]
  2483. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2484. }
  2485. h := st.wantHeaders()
  2486. if !h.HeadersEnded() {
  2487. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2488. }
  2489. headers := st.decodeHeader(h.HeaderBlockFragment())
  2490. want := [][2]string{
  2491. {":status", "431"},
  2492. {"content-type", "text/html; charset=utf-8"},
  2493. {"content-length", "63"},
  2494. }
  2495. if !reflect.DeepEqual(headers, want) {
  2496. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2497. }
  2498. }
  2499. func TestServer_Response_Stream_With_Missing_Trailer(t *testing.T) {
  2500. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2501. w.Header().Set("Trailer", "test-trailer")
  2502. return nil
  2503. }, func(st *serverTester) {
  2504. getSlash(st)
  2505. hf := st.wantHeaders()
  2506. if !hf.HeadersEnded() {
  2507. t.Fatal("want END_HEADERS flag")
  2508. }
  2509. df := st.wantData()
  2510. if len(df.data) != 0 {
  2511. t.Fatal("did not want data")
  2512. }
  2513. if !df.StreamEnded() {
  2514. t.Fatal("want END_STREAM flag")
  2515. }
  2516. })
  2517. }
  2518. func TestCompressionErrorOnWrite(t *testing.T) {
  2519. const maxStrLen = 8 << 10
  2520. var serverConfig *http.Server
  2521. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2522. // No response body.
  2523. }, func(ts *httptest.Server) {
  2524. serverConfig = ts.Config
  2525. serverConfig.MaxHeaderBytes = maxStrLen
  2526. })
  2527. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2528. defer st.Close()
  2529. st.greet()
  2530. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2531. // Crank this up, now that we have a conn connected with the
  2532. // hpack.Decoder's max string length set has been initialized
  2533. // from the earlier low ~8K value. We want this higher so don't
  2534. // hit the max header list size. We only want to test hitting
  2535. // the max string size.
  2536. serverConfig.MaxHeaderBytes = 1 << 20
  2537. // First a request with a header that's exactly the max allowed size
  2538. // for the hpack compression. It's still too long for the header list
  2539. // size, so we'll get the 431 error, but that keeps the compression
  2540. // context still valid.
  2541. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2542. st.writeHeaders(HeadersFrameParam{
  2543. StreamID: 1,
  2544. BlockFragment: hbf,
  2545. EndStream: true,
  2546. EndHeaders: true,
  2547. })
  2548. h := st.wantHeaders()
  2549. if !h.HeadersEnded() {
  2550. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2551. }
  2552. headers := st.decodeHeader(h.HeaderBlockFragment())
  2553. want := [][2]string{
  2554. {":status", "431"},
  2555. {"content-type", "text/html; charset=utf-8"},
  2556. {"content-length", "63"},
  2557. }
  2558. if !reflect.DeepEqual(headers, want) {
  2559. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2560. }
  2561. df := st.wantData()
  2562. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2563. t.Errorf("Unexpected data body: %q", df.Data())
  2564. }
  2565. if !df.StreamEnded() {
  2566. t.Fatalf("expect data stream end")
  2567. }
  2568. // And now send one that's just one byte too big.
  2569. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2570. st.writeHeaders(HeadersFrameParam{
  2571. StreamID: 3,
  2572. BlockFragment: hbf,
  2573. EndStream: true,
  2574. EndHeaders: true,
  2575. })
  2576. ga := st.wantGoAway()
  2577. if ga.ErrCode != ErrCodeCompression {
  2578. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2579. }
  2580. }
  2581. func TestCompressionErrorOnClose(t *testing.T) {
  2582. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2583. // No response body.
  2584. })
  2585. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2586. defer st.Close()
  2587. st.greet()
  2588. hbf := st.encodeHeader("foo", "bar")
  2589. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2590. st.writeHeaders(HeadersFrameParam{
  2591. StreamID: 1,
  2592. BlockFragment: hbf,
  2593. EndStream: true,
  2594. EndHeaders: true,
  2595. })
  2596. ga := st.wantGoAway()
  2597. if ga.ErrCode != ErrCodeCompression {
  2598. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2599. }
  2600. }
  2601. // test that a server handler can read trailers from a client
  2602. func TestServerReadsTrailers(t *testing.T) {
  2603. const testBody = "some test body"
  2604. writeReq := func(st *serverTester) {
  2605. st.writeHeaders(HeadersFrameParam{
  2606. StreamID: 1, // clients send odd numbers
  2607. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2608. EndStream: false,
  2609. EndHeaders: true,
  2610. })
  2611. st.writeData(1, false, []byte(testBody))
  2612. st.writeHeaders(HeadersFrameParam{
  2613. StreamID: 1, // clients send odd numbers
  2614. BlockFragment: st.encodeHeaderRaw(
  2615. "foo", "foov",
  2616. "bar", "barv",
  2617. "baz", "bazv",
  2618. "surprise", "wasn't declared; shouldn't show up",
  2619. ),
  2620. EndStream: true,
  2621. EndHeaders: true,
  2622. })
  2623. }
  2624. checkReq := func(r *http.Request) {
  2625. wantTrailer := http.Header{
  2626. "Foo": nil,
  2627. "Bar": nil,
  2628. "Baz": nil,
  2629. }
  2630. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2631. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2632. }
  2633. slurp, err := ioutil.ReadAll(r.Body)
  2634. if string(slurp) != testBody {
  2635. t.Errorf("read body %q; want %q", slurp, testBody)
  2636. }
  2637. if err != nil {
  2638. t.Fatalf("Body slurp: %v", err)
  2639. }
  2640. wantTrailerAfter := http.Header{
  2641. "Foo": {"foov"},
  2642. "Bar": {"barv"},
  2643. "Baz": {"bazv"},
  2644. }
  2645. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2646. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2647. }
  2648. }
  2649. testServerRequest(t, writeReq, checkReq)
  2650. }
  2651. // test that a server handler can send trailers
  2652. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2653. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2654. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2655. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2656. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2657. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2658. w.Header().Add("Trailer", "Server-Trailer-C")
  2659. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2660. // Regular headers:
  2661. w.Header().Set("Foo", "Bar")
  2662. w.Header().Set("Content-Length", "5") // len("Hello")
  2663. io.WriteString(w, "Hello")
  2664. if withFlush {
  2665. w.(http.Flusher).Flush()
  2666. }
  2667. w.Header().Set("Server-Trailer-A", "valuea")
  2668. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2669. // After a flush, random keys like Server-Surprise shouldn't show up:
  2670. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2671. // But we do permit promoting keys to trailers after a
  2672. // flush if they start with the magic
  2673. // otherwise-invalid "Trailer:" prefix:
  2674. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2675. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2676. w.Header().Set("Trailer:Range", "invalid")
  2677. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2678. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 7230 4.1.2")
  2679. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 7230 4.1.2")
  2680. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 7230 4.1.2")
  2681. return nil
  2682. }, func(st *serverTester) {
  2683. getSlash(st)
  2684. hf := st.wantHeaders()
  2685. if hf.StreamEnded() {
  2686. t.Fatal("response HEADERS had END_STREAM")
  2687. }
  2688. if !hf.HeadersEnded() {
  2689. t.Fatal("response HEADERS didn't have END_HEADERS")
  2690. }
  2691. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2692. wanth := [][2]string{
  2693. {":status", "200"},
  2694. {"foo", "Bar"},
  2695. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2696. {"trailer", "Server-Trailer-C"},
  2697. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2698. {"content-type", "text/plain; charset=utf-8"},
  2699. {"content-length", "5"},
  2700. }
  2701. if !reflect.DeepEqual(goth, wanth) {
  2702. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2703. }
  2704. df := st.wantData()
  2705. if string(df.Data()) != "Hello" {
  2706. t.Fatalf("Client read %q; want Hello", df.Data())
  2707. }
  2708. if df.StreamEnded() {
  2709. t.Fatalf("data frame had STREAM_ENDED")
  2710. }
  2711. tf := st.wantHeaders() // for the trailers
  2712. if !tf.StreamEnded() {
  2713. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2714. }
  2715. if !tf.HeadersEnded() {
  2716. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2717. }
  2718. wanth = [][2]string{
  2719. {"post-header-trailer", "hi1"},
  2720. {"post-header-trailer2", "hi2"},
  2721. {"server-trailer-a", "valuea"},
  2722. {"server-trailer-c", "valuec"},
  2723. }
  2724. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2725. if !reflect.DeepEqual(goth, wanth) {
  2726. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2727. }
  2728. })
  2729. }
  2730. // validate transmitted header field names & values
  2731. // golang.org/issue/14048
  2732. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2733. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2734. w.Header().Add("OK1", "x")
  2735. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2736. w.Header().Add("Bad1\x00", "x") // null in key
  2737. w.Header().Add("Bad2", "x\x00y") // null in value
  2738. return nil
  2739. }, func(st *serverTester) {
  2740. getSlash(st)
  2741. hf := st.wantHeaders()
  2742. if !hf.StreamEnded() {
  2743. t.Error("response HEADERS lacked END_STREAM")
  2744. }
  2745. if !hf.HeadersEnded() {
  2746. t.Fatal("response HEADERS didn't have END_HEADERS")
  2747. }
  2748. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2749. wanth := [][2]string{
  2750. {":status", "200"},
  2751. {"ok1", "x"},
  2752. {"content-length", "0"},
  2753. }
  2754. if !reflect.DeepEqual(goth, wanth) {
  2755. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2756. }
  2757. })
  2758. }
  2759. func BenchmarkServerGets(b *testing.B) {
  2760. defer disableGoroutineTracking()()
  2761. b.ReportAllocs()
  2762. const msg = "Hello, world"
  2763. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2764. io.WriteString(w, msg)
  2765. })
  2766. defer st.Close()
  2767. st.greet()
  2768. // Give the server quota to reply. (plus it has the 64KB)
  2769. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2770. b.Fatal(err)
  2771. }
  2772. for i := 0; i < b.N; i++ {
  2773. id := 1 + uint32(i)*2
  2774. st.writeHeaders(HeadersFrameParam{
  2775. StreamID: id,
  2776. BlockFragment: st.encodeHeader(),
  2777. EndStream: true,
  2778. EndHeaders: true,
  2779. })
  2780. st.wantHeaders()
  2781. df := st.wantData()
  2782. if !df.StreamEnded() {
  2783. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2784. }
  2785. }
  2786. }
  2787. func BenchmarkServerPosts(b *testing.B) {
  2788. defer disableGoroutineTracking()()
  2789. b.ReportAllocs()
  2790. const msg = "Hello, world"
  2791. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2792. // Consume the (empty) body from th peer before replying, otherwise
  2793. // the server will sometimes (depending on scheduling) send the peer a
  2794. // a RST_STREAM with the CANCEL error code.
  2795. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2796. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2797. }
  2798. io.WriteString(w, msg)
  2799. })
  2800. defer st.Close()
  2801. st.greet()
  2802. // Give the server quota to reply. (plus it has the 64KB)
  2803. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2804. b.Fatal(err)
  2805. }
  2806. for i := 0; i < b.N; i++ {
  2807. id := 1 + uint32(i)*2
  2808. st.writeHeaders(HeadersFrameParam{
  2809. StreamID: id,
  2810. BlockFragment: st.encodeHeader(":method", "POST"),
  2811. EndStream: false,
  2812. EndHeaders: true,
  2813. })
  2814. st.writeData(id, true, nil)
  2815. st.wantHeaders()
  2816. df := st.wantData()
  2817. if !df.StreamEnded() {
  2818. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2819. }
  2820. }
  2821. }
  2822. // Send a stream of messages from server to client in separate data frames.
  2823. // Brings up performance issues seen in long streams.
  2824. // Created to show problem in go issue #18502
  2825. func BenchmarkServerToClientStreamDefaultOptions(b *testing.B) {
  2826. benchmarkServerToClientStream(b)
  2827. }
  2828. // Justification for Change-Id: Iad93420ef6c3918f54249d867098f1dadfa324d8
  2829. // Expect to see memory/alloc reduction by opting in to Frame reuse with the Framer.
  2830. func BenchmarkServerToClientStreamReuseFrames(b *testing.B) {
  2831. benchmarkServerToClientStream(b, optFramerReuseFrames)
  2832. }
  2833. func benchmarkServerToClientStream(b *testing.B, newServerOpts ...interface{}) {
  2834. defer disableGoroutineTracking()()
  2835. b.ReportAllocs()
  2836. const msgLen = 1
  2837. // default window size
  2838. const windowSize = 1<<16 - 1
  2839. // next message to send from the server and for the client to expect
  2840. nextMsg := func(i int) []byte {
  2841. msg := make([]byte, msgLen)
  2842. msg[0] = byte(i)
  2843. if len(msg) != msgLen {
  2844. panic("invalid test setup msg length")
  2845. }
  2846. return msg
  2847. }
  2848. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2849. // Consume the (empty) body from th peer before replying, otherwise
  2850. // the server will sometimes (depending on scheduling) send the peer a
  2851. // a RST_STREAM with the CANCEL error code.
  2852. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2853. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2854. }
  2855. for i := 0; i < b.N; i += 1 {
  2856. w.Write(nextMsg(i))
  2857. w.(http.Flusher).Flush()
  2858. }
  2859. }, newServerOpts...)
  2860. defer st.Close()
  2861. st.greet()
  2862. const id = uint32(1)
  2863. st.writeHeaders(HeadersFrameParam{
  2864. StreamID: id,
  2865. BlockFragment: st.encodeHeader(":method", "POST"),
  2866. EndStream: false,
  2867. EndHeaders: true,
  2868. })
  2869. st.writeData(id, true, nil)
  2870. st.wantHeaders()
  2871. var pendingWindowUpdate = uint32(0)
  2872. for i := 0; i < b.N; i += 1 {
  2873. expected := nextMsg(i)
  2874. df := st.wantData()
  2875. if bytes.Compare(expected, df.data) != 0 {
  2876. b.Fatalf("Bad message received; want %v; got %v", expected, df.data)
  2877. }
  2878. // try to send infrequent but large window updates so they don't overwhelm the test
  2879. pendingWindowUpdate += uint32(len(df.data))
  2880. if pendingWindowUpdate >= windowSize/2 {
  2881. if err := st.fr.WriteWindowUpdate(0, pendingWindowUpdate); err != nil {
  2882. b.Fatal(err)
  2883. }
  2884. if err := st.fr.WriteWindowUpdate(id, pendingWindowUpdate); err != nil {
  2885. b.Fatal(err)
  2886. }
  2887. pendingWindowUpdate = 0
  2888. }
  2889. }
  2890. df := st.wantData()
  2891. if !df.StreamEnded() {
  2892. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2893. }
  2894. }
  2895. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2896. // Verify we don't hang.
  2897. func TestIssue53(t *testing.T) {
  2898. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2899. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2900. s := &http.Server{
  2901. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2902. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2903. w.Write([]byte("hello"))
  2904. }),
  2905. }
  2906. s2 := &Server{
  2907. MaxReadFrameSize: 1 << 16,
  2908. PermitProhibitedCipherSuites: true,
  2909. }
  2910. c := &issue53Conn{[]byte(data), false, false}
  2911. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2912. if !c.closed {
  2913. t.Fatal("connection is not closed")
  2914. }
  2915. }
  2916. type issue53Conn struct {
  2917. data []byte
  2918. closed bool
  2919. written bool
  2920. }
  2921. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2922. if len(c.data) == 0 {
  2923. return 0, io.EOF
  2924. }
  2925. n = copy(b, c.data)
  2926. c.data = c.data[n:]
  2927. return
  2928. }
  2929. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2930. c.written = true
  2931. return len(b), nil
  2932. }
  2933. func (c *issue53Conn) Close() error {
  2934. c.closed = true
  2935. return nil
  2936. }
  2937. func (c *issue53Conn) LocalAddr() net.Addr {
  2938. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2939. }
  2940. func (c *issue53Conn) RemoteAddr() net.Addr {
  2941. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2942. }
  2943. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2944. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2945. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2946. // golang.org/issue/12895
  2947. func TestConfigureServer(t *testing.T) {
  2948. tests := []struct {
  2949. name string
  2950. tlsConfig *tls.Config
  2951. wantErr string
  2952. }{
  2953. {
  2954. name: "empty server",
  2955. },
  2956. {
  2957. name: "just the required cipher suite",
  2958. tlsConfig: &tls.Config{
  2959. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2960. },
  2961. },
  2962. {
  2963. name: "just the alternative required cipher suite",
  2964. tlsConfig: &tls.Config{
  2965. CipherSuites: []uint16{tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256},
  2966. },
  2967. },
  2968. {
  2969. name: "missing required cipher suite",
  2970. tlsConfig: &tls.Config{
  2971. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2972. },
  2973. wantErr: "is missing an HTTP/2-required AES_128_GCM_SHA256 cipher.",
  2974. },
  2975. {
  2976. name: "required after bad",
  2977. tlsConfig: &tls.Config{
  2978. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2979. },
  2980. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2981. },
  2982. {
  2983. name: "bad after required",
  2984. tlsConfig: &tls.Config{
  2985. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2986. },
  2987. },
  2988. }
  2989. for _, tt := range tests {
  2990. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2991. err := ConfigureServer(srv, nil)
  2992. if (err != nil) != (tt.wantErr != "") {
  2993. if tt.wantErr != "" {
  2994. t.Errorf("%s: success, but want error", tt.name)
  2995. } else {
  2996. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2997. }
  2998. }
  2999. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  3000. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  3001. }
  3002. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  3003. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  3004. }
  3005. }
  3006. }
  3007. func TestServerRejectHeadWithBody(t *testing.T) {
  3008. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3009. // No response body.
  3010. })
  3011. defer st.Close()
  3012. st.greet()
  3013. st.writeHeaders(HeadersFrameParam{
  3014. StreamID: 1, // clients send odd numbers
  3015. BlockFragment: st.encodeHeader(":method", "HEAD"),
  3016. EndStream: false, // what we're testing, a bogus HEAD request with body
  3017. EndHeaders: true,
  3018. })
  3019. st.wantRSTStream(1, ErrCodeProtocol)
  3020. }
  3021. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  3022. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3023. // No response body. (or smaller than one frame)
  3024. })
  3025. defer st.Close()
  3026. st.greet()
  3027. st.writeHeaders(HeadersFrameParam{
  3028. StreamID: 1, // clients send odd numbers
  3029. BlockFragment: st.encodeHeader(":method", "HEAD"),
  3030. EndStream: true,
  3031. EndHeaders: true,
  3032. })
  3033. h := st.wantHeaders()
  3034. headers := st.decodeHeader(h.HeaderBlockFragment())
  3035. want := [][2]string{
  3036. {":status", "200"},
  3037. }
  3038. if !reflect.DeepEqual(headers, want) {
  3039. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3040. }
  3041. }
  3042. // golang.org/issue/13495
  3043. func TestServerNoDuplicateContentType(t *testing.T) {
  3044. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3045. w.Header()["Content-Type"] = []string{""}
  3046. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  3047. })
  3048. defer st.Close()
  3049. st.greet()
  3050. st.writeHeaders(HeadersFrameParam{
  3051. StreamID: 1,
  3052. BlockFragment: st.encodeHeader(),
  3053. EndStream: true,
  3054. EndHeaders: true,
  3055. })
  3056. h := st.wantHeaders()
  3057. headers := st.decodeHeader(h.HeaderBlockFragment())
  3058. want := [][2]string{
  3059. {":status", "200"},
  3060. {"content-type", ""},
  3061. {"content-length", "41"},
  3062. }
  3063. if !reflect.DeepEqual(headers, want) {
  3064. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3065. }
  3066. }
  3067. func disableGoroutineTracking() (restore func()) {
  3068. old := DebugGoroutines
  3069. DebugGoroutines = false
  3070. return func() { DebugGoroutines = old }
  3071. }
  3072. func BenchmarkServer_GetRequest(b *testing.B) {
  3073. defer disableGoroutineTracking()()
  3074. b.ReportAllocs()
  3075. const msg = "Hello, world."
  3076. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3077. n, err := io.Copy(ioutil.Discard, r.Body)
  3078. if err != nil || n > 0 {
  3079. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3080. }
  3081. io.WriteString(w, msg)
  3082. })
  3083. defer st.Close()
  3084. st.greet()
  3085. // Give the server quota to reply. (plus it has the 64KB)
  3086. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3087. b.Fatal(err)
  3088. }
  3089. hbf := st.encodeHeader(":method", "GET")
  3090. for i := 0; i < b.N; i++ {
  3091. streamID := uint32(1 + 2*i)
  3092. st.writeHeaders(HeadersFrameParam{
  3093. StreamID: streamID,
  3094. BlockFragment: hbf,
  3095. EndStream: true,
  3096. EndHeaders: true,
  3097. })
  3098. st.wantHeaders()
  3099. st.wantData()
  3100. }
  3101. }
  3102. func BenchmarkServer_PostRequest(b *testing.B) {
  3103. defer disableGoroutineTracking()()
  3104. b.ReportAllocs()
  3105. const msg = "Hello, world."
  3106. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3107. n, err := io.Copy(ioutil.Discard, r.Body)
  3108. if err != nil || n > 0 {
  3109. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3110. }
  3111. io.WriteString(w, msg)
  3112. })
  3113. defer st.Close()
  3114. st.greet()
  3115. // Give the server quota to reply. (plus it has the 64KB)
  3116. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3117. b.Fatal(err)
  3118. }
  3119. hbf := st.encodeHeader(":method", "POST")
  3120. for i := 0; i < b.N; i++ {
  3121. streamID := uint32(1 + 2*i)
  3122. st.writeHeaders(HeadersFrameParam{
  3123. StreamID: streamID,
  3124. BlockFragment: hbf,
  3125. EndStream: false,
  3126. EndHeaders: true,
  3127. })
  3128. st.writeData(streamID, true, nil)
  3129. st.wantHeaders()
  3130. st.wantData()
  3131. }
  3132. }
  3133. type connStateConn struct {
  3134. net.Conn
  3135. cs tls.ConnectionState
  3136. }
  3137. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  3138. // golang.org/issue/12737 -- handle any net.Conn, not just
  3139. // *tls.Conn.
  3140. func TestServerHandleCustomConn(t *testing.T) {
  3141. var s Server
  3142. c1, c2 := net.Pipe()
  3143. clientDone := make(chan struct{})
  3144. handlerDone := make(chan struct{})
  3145. var req *http.Request
  3146. go func() {
  3147. defer close(clientDone)
  3148. defer c2.Close()
  3149. fr := NewFramer(c2, c2)
  3150. io.WriteString(c2, ClientPreface)
  3151. fr.WriteSettings()
  3152. fr.WriteSettingsAck()
  3153. f, err := fr.ReadFrame()
  3154. if err != nil {
  3155. t.Error(err)
  3156. return
  3157. }
  3158. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  3159. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  3160. return
  3161. }
  3162. f, err = fr.ReadFrame()
  3163. if err != nil {
  3164. t.Error(err)
  3165. return
  3166. }
  3167. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  3168. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  3169. return
  3170. }
  3171. var henc hpackEncoder
  3172. fr.WriteHeaders(HeadersFrameParam{
  3173. StreamID: 1,
  3174. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  3175. EndStream: true,
  3176. EndHeaders: true,
  3177. })
  3178. go io.Copy(ioutil.Discard, c2)
  3179. <-handlerDone
  3180. }()
  3181. const testString = "my custom ConnectionState"
  3182. fakeConnState := tls.ConnectionState{
  3183. ServerName: testString,
  3184. Version: tls.VersionTLS12,
  3185. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  3186. }
  3187. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3188. BaseConfig: &http.Server{
  3189. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3190. defer close(handlerDone)
  3191. req = r
  3192. }),
  3193. }})
  3194. select {
  3195. case <-clientDone:
  3196. case <-time.After(5 * time.Second):
  3197. t.Fatal("timeout waiting for handler")
  3198. }
  3199. if req.TLS == nil {
  3200. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3201. }
  3202. if req.TLS.ServerName != testString {
  3203. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3204. }
  3205. }
  3206. // golang.org/issue/14214
  3207. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3208. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3209. t.Error("should not get to Handler")
  3210. })
  3211. defer st.Close()
  3212. st.greet()
  3213. st.bodylessReq1("connection", "foo")
  3214. hf := st.wantHeaders()
  3215. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3216. wanth := [][2]string{
  3217. {":status", "400"},
  3218. {"content-type", "text/plain; charset=utf-8"},
  3219. {"x-content-type-options", "nosniff"},
  3220. {"content-length", "51"},
  3221. }
  3222. if !reflect.DeepEqual(goth, wanth) {
  3223. t.Errorf("Got headers %v; want %v", goth, wanth)
  3224. }
  3225. }
  3226. type hpackEncoder struct {
  3227. enc *hpack.Encoder
  3228. buf bytes.Buffer
  3229. }
  3230. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3231. if len(headers)%2 == 1 {
  3232. panic("odd number of kv args")
  3233. }
  3234. he.buf.Reset()
  3235. if he.enc == nil {
  3236. he.enc = hpack.NewEncoder(&he.buf)
  3237. }
  3238. for len(headers) > 0 {
  3239. k, v := headers[0], headers[1]
  3240. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3241. if err != nil {
  3242. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3243. }
  3244. headers = headers[2:]
  3245. }
  3246. return he.buf.Bytes()
  3247. }
  3248. func TestCheckValidHTTP2Request(t *testing.T) {
  3249. tests := []struct {
  3250. h http.Header
  3251. want error
  3252. }{
  3253. {
  3254. h: http.Header{"Te": {"trailers"}},
  3255. want: nil,
  3256. },
  3257. {
  3258. h: http.Header{"Te": {"trailers", "bogus"}},
  3259. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3260. },
  3261. {
  3262. h: http.Header{"Foo": {""}},
  3263. want: nil,
  3264. },
  3265. {
  3266. h: http.Header{"Connection": {""}},
  3267. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3268. },
  3269. {
  3270. h: http.Header{"Proxy-Connection": {""}},
  3271. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3272. },
  3273. {
  3274. h: http.Header{"Keep-Alive": {""}},
  3275. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3276. },
  3277. {
  3278. h: http.Header{"Upgrade": {""}},
  3279. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3280. },
  3281. }
  3282. for i, tt := range tests {
  3283. got := checkValidHTTP2RequestHeaders(tt.h)
  3284. if !equalError(got, tt.want) {
  3285. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3286. }
  3287. }
  3288. }
  3289. // golang.org/issue/14030
  3290. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3291. const msg = "Hello"
  3292. const msg2 = "World"
  3293. doRead := make(chan bool, 1)
  3294. defer close(doRead) // fallback cleanup
  3295. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3296. io.WriteString(w, msg)
  3297. w.(http.Flusher).Flush()
  3298. // Do a read, which might force a 100-continue status to be sent.
  3299. <-doRead
  3300. r.Body.Read(make([]byte, 10))
  3301. io.WriteString(w, msg2)
  3302. }, optOnlyServer)
  3303. defer st.Close()
  3304. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3305. defer tr.CloseIdleConnections()
  3306. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3307. req.Header.Set("Expect", "100-continue")
  3308. res, err := tr.RoundTrip(req)
  3309. if err != nil {
  3310. t.Fatal(err)
  3311. }
  3312. defer res.Body.Close()
  3313. buf := make([]byte, len(msg))
  3314. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3315. t.Fatal(err)
  3316. }
  3317. if string(buf) != msg {
  3318. t.Fatalf("msg = %q; want %q", buf, msg)
  3319. }
  3320. doRead <- true
  3321. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3322. t.Fatal(err)
  3323. }
  3324. if string(buf) != msg2 {
  3325. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3326. }
  3327. }
  3328. type funcReader func([]byte) (n int, err error)
  3329. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3330. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3331. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3332. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3333. unblock := make(chan bool, 1)
  3334. defer close(unblock)
  3335. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3336. // Don't read the 16KB request body. Wait until the client's
  3337. // done sending it and then return. This should cause the Server
  3338. // to then return those 16KB of flow control to the client.
  3339. <-unblock
  3340. }, optOnlyServer)
  3341. defer st.Close()
  3342. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3343. defer tr.CloseIdleConnections()
  3344. // This previously hung on the 4th iteration.
  3345. for i := 0; i < 6; i++ {
  3346. body := io.MultiReader(
  3347. io.LimitReader(neverEnding('A'), 16<<10),
  3348. funcReader(func([]byte) (n int, err error) {
  3349. unblock <- true
  3350. return 0, io.EOF
  3351. }),
  3352. )
  3353. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3354. res, err := tr.RoundTrip(req)
  3355. if err != nil {
  3356. t.Fatal(err)
  3357. }
  3358. res.Body.Close()
  3359. }
  3360. }
  3361. func TestServerIdleTimeout(t *testing.T) {
  3362. if testing.Short() {
  3363. t.Skip("skipping in short mode")
  3364. }
  3365. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3366. }, func(h2s *Server) {
  3367. h2s.IdleTimeout = 500 * time.Millisecond
  3368. })
  3369. defer st.Close()
  3370. st.greet()
  3371. ga := st.wantGoAway()
  3372. if ga.ErrCode != ErrCodeNo {
  3373. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3374. }
  3375. }
  3376. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3377. if testing.Short() {
  3378. t.Skip("skipping in short mode")
  3379. }
  3380. const timeout = 250 * time.Millisecond
  3381. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3382. time.Sleep(timeout * 2)
  3383. }, func(h2s *Server) {
  3384. h2s.IdleTimeout = timeout
  3385. })
  3386. defer st.Close()
  3387. st.greet()
  3388. // Send a request which takes twice the timeout. Verifies the
  3389. // idle timeout doesn't fire while we're in a request:
  3390. st.bodylessReq1()
  3391. st.wantHeaders()
  3392. // But the idle timeout should be rearmed after the request
  3393. // is done:
  3394. ga := st.wantGoAway()
  3395. if ga.ErrCode != ErrCodeNo {
  3396. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3397. }
  3398. }
  3399. // grpc-go closes the Request.Body currently with a Read.
  3400. // Verify that it doesn't race.
  3401. // See https://github.com/grpc/grpc-go/pull/938
  3402. func TestRequestBodyReadCloseRace(t *testing.T) {
  3403. for i := 0; i < 100; i++ {
  3404. body := &requestBody{
  3405. pipe: &pipe{
  3406. b: new(bytes.Buffer),
  3407. },
  3408. }
  3409. body.pipe.CloseWithError(io.EOF)
  3410. done := make(chan bool, 1)
  3411. buf := make([]byte, 10)
  3412. go func() {
  3413. time.Sleep(1 * time.Millisecond)
  3414. body.Close()
  3415. done <- true
  3416. }()
  3417. body.Read(buf)
  3418. <-done
  3419. }
  3420. }
  3421. func TestIssue20704Race(t *testing.T) {
  3422. if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
  3423. t.Skip("skipping in short mode")
  3424. }
  3425. const (
  3426. itemSize = 1 << 10
  3427. itemCount = 100
  3428. )
  3429. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3430. for i := 0; i < itemCount; i++ {
  3431. _, err := w.Write(make([]byte, itemSize))
  3432. if err != nil {
  3433. return
  3434. }
  3435. }
  3436. }, optOnlyServer)
  3437. defer st.Close()
  3438. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3439. defer tr.CloseIdleConnections()
  3440. cl := &http.Client{Transport: tr}
  3441. for i := 0; i < 1000; i++ {
  3442. resp, err := cl.Get(st.ts.URL)
  3443. if err != nil {
  3444. t.Fatal(err)
  3445. }
  3446. // Force a RST stream to the server by closing without
  3447. // reading the body:
  3448. resp.Body.Close()
  3449. }
  3450. }
  3451. func TestServer_Rejects_TooSmall(t *testing.T) {
  3452. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  3453. ioutil.ReadAll(r.Body)
  3454. return nil
  3455. }, func(st *serverTester) {
  3456. st.writeHeaders(HeadersFrameParam{
  3457. StreamID: 1, // clients send odd numbers
  3458. BlockFragment: st.encodeHeader(
  3459. ":method", "POST",
  3460. "content-length", "4",
  3461. ),
  3462. EndStream: false, // to say DATA frames are coming
  3463. EndHeaders: true,
  3464. })
  3465. st.writeData(1, true, []byte("12345"))
  3466. st.wantRSTStream(1, ErrCodeProtocol)
  3467. })
  3468. }
  3469. // Tests that a handler setting "Connection: close" results in a GOAWAY being sent,
  3470. // and the connection still completing.
  3471. func TestServerHandlerConnectionClose(t *testing.T) {
  3472. unblockHandler := make(chan bool, 1)
  3473. defer close(unblockHandler) // backup; in case of errors
  3474. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  3475. w.Header().Set("Connection", "close")
  3476. w.Header().Set("Foo", "bar")
  3477. w.(http.Flusher).Flush()
  3478. <-unblockHandler
  3479. return nil
  3480. }, func(st *serverTester) {
  3481. st.writeHeaders(HeadersFrameParam{
  3482. StreamID: 1,
  3483. BlockFragment: st.encodeHeader(),
  3484. EndStream: true,
  3485. EndHeaders: true,
  3486. })
  3487. var sawGoAway bool
  3488. var sawRes bool
  3489. for {
  3490. f, err := st.readFrame()
  3491. if err == io.EOF {
  3492. break
  3493. }
  3494. if err != nil {
  3495. t.Fatal(err)
  3496. }
  3497. switch f := f.(type) {
  3498. case *GoAwayFrame:
  3499. sawGoAway = true
  3500. unblockHandler <- true
  3501. if f.LastStreamID != 1 || f.ErrCode != ErrCodeNo {
  3502. t.Errorf("unexpected GOAWAY frame: %v", summarizeFrame(f))
  3503. }
  3504. case *HeadersFrame:
  3505. goth := st.decodeHeader(f.HeaderBlockFragment())
  3506. wanth := [][2]string{
  3507. {":status", "200"},
  3508. {"foo", "bar"},
  3509. }
  3510. if !reflect.DeepEqual(goth, wanth) {
  3511. t.Errorf("got headers %v; want %v", goth, wanth)
  3512. }
  3513. sawRes = true
  3514. case *DataFrame:
  3515. if f.StreamID != 1 || !f.StreamEnded() || len(f.Data()) != 0 {
  3516. t.Errorf("unexpected DATA frame: %v", summarizeFrame(f))
  3517. }
  3518. default:
  3519. t.Logf("unexpected frame: %v", summarizeFrame(f))
  3520. }
  3521. }
  3522. if !sawGoAway {
  3523. t.Errorf("didn't see GOAWAY")
  3524. }
  3525. if !sawRes {
  3526. t.Errorf("didn't see response")
  3527. }
  3528. })
  3529. }
  3530. func TestServer_Headers_HalfCloseRemote(t *testing.T) {
  3531. var st *serverTester
  3532. writeData := make(chan bool)
  3533. writeHeaders := make(chan bool)
  3534. leaveHandler := make(chan bool)
  3535. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3536. if st.stream(1) == nil {
  3537. t.Errorf("nil stream 1 in handler")
  3538. }
  3539. if got, want := st.streamState(1), stateOpen; got != want {
  3540. t.Errorf("in handler, state is %v; want %v", got, want)
  3541. }
  3542. writeData <- true
  3543. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  3544. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  3545. }
  3546. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  3547. t.Errorf("in handler, state is %v; want %v", got, want)
  3548. }
  3549. writeHeaders <- true
  3550. <-leaveHandler
  3551. })
  3552. st.greet()
  3553. st.writeHeaders(HeadersFrameParam{
  3554. StreamID: 1,
  3555. BlockFragment: st.encodeHeader(),
  3556. EndStream: false, // keep it open
  3557. EndHeaders: true,
  3558. })
  3559. <-writeData
  3560. st.writeData(1, true, nil)
  3561. <-writeHeaders
  3562. st.writeHeaders(HeadersFrameParam{
  3563. StreamID: 1,
  3564. BlockFragment: st.encodeHeader(),
  3565. EndStream: false, // keep it open
  3566. EndHeaders: true,
  3567. })
  3568. defer close(leaveHandler)
  3569. st.wantRSTStream(1, ErrCodeStreamClosed)
  3570. }
  3571. func TestServerGracefulShutdown(t *testing.T) {
  3572. var st *serverTester
  3573. handlerDone := make(chan struct{})
  3574. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3575. defer close(handlerDone)
  3576. go st.ts.Config.Shutdown(context.Background())
  3577. ga := st.wantGoAway()
  3578. if ga.ErrCode != ErrCodeNo {
  3579. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3580. }
  3581. if ga.LastStreamID != 1 {
  3582. t.Errorf("GOAWAY LastStreamID = %v; want 1", ga.LastStreamID)
  3583. }
  3584. w.Header().Set("x-foo", "bar")
  3585. })
  3586. defer st.Close()
  3587. st.greet()
  3588. st.bodylessReq1()
  3589. select {
  3590. case <-handlerDone:
  3591. case <-time.After(5 * time.Second):
  3592. t.Fatalf("server did not shutdown?")
  3593. }
  3594. hf := st.wantHeaders()
  3595. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3596. wanth := [][2]string{
  3597. {":status", "200"},
  3598. {"x-foo", "bar"},
  3599. {"content-length", "0"},
  3600. }
  3601. if !reflect.DeepEqual(goth, wanth) {
  3602. t.Errorf("Got headers %v; want %v", goth, wanth)
  3603. }
  3604. n, err := st.cc.Read([]byte{0})
  3605. if n != 0 || err == nil {
  3606. t.Errorf("Read = %v, %v; want 0, non-nil", n, err)
  3607. }
  3608. }