server_test.go 97 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. logBuf *bytes.Buffer
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // writing headers:
  48. headerBuf bytes.Buffer
  49. hpackEnc *hpack.Encoder
  50. }
  51. func init() {
  52. testHookOnPanicMu = new(sync.Mutex)
  53. }
  54. func resetHooks() {
  55. testHookOnPanicMu.Lock()
  56. testHookOnPanic = nil
  57. testHookOnPanicMu.Unlock()
  58. }
  59. type serverTesterOpt string
  60. var optOnlyServer = serverTesterOpt("only_server")
  61. var optQuiet = serverTesterOpt("quiet_logging")
  62. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  63. resetHooks()
  64. logBuf := new(bytes.Buffer)
  65. ts := httptest.NewUnstartedServer(handler)
  66. tlsConfig := &tls.Config{
  67. InsecureSkipVerify: true,
  68. // The h2-14 is temporary, until curl is updated. (as used by unit tests
  69. // in Docker)
  70. NextProtos: []string{NextProtoTLS, "h2-14"},
  71. }
  72. var onlyServer, quiet bool
  73. h2server := new(Server)
  74. for _, opt := range opts {
  75. switch v := opt.(type) {
  76. case func(*tls.Config):
  77. v(tlsConfig)
  78. case func(*httptest.Server):
  79. v(ts)
  80. case func(*Server):
  81. v(h2server)
  82. case serverTesterOpt:
  83. switch v {
  84. case optOnlyServer:
  85. onlyServer = true
  86. case optQuiet:
  87. quiet = true
  88. }
  89. case func(net.Conn, http.ConnState):
  90. ts.Config.ConnState = v
  91. default:
  92. t.Fatalf("unknown newServerTester option type %T", v)
  93. }
  94. }
  95. ConfigureServer(ts.Config, h2server)
  96. st := &serverTester{
  97. t: t,
  98. ts: ts,
  99. logBuf: logBuf,
  100. }
  101. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  102. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  103. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  104. if quiet {
  105. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  106. } else {
  107. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  108. }
  109. ts.StartTLS()
  110. if VerboseLogs {
  111. t.Logf("Running test server at: %s", ts.URL)
  112. }
  113. testHookGetServerConn = func(v *serverConn) {
  114. st.scMu.Lock()
  115. defer st.scMu.Unlock()
  116. st.sc = v
  117. st.sc.testHookCh = make(chan func(int))
  118. }
  119. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  120. if !onlyServer {
  121. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  122. if err != nil {
  123. t.Fatal(err)
  124. }
  125. st.cc = cc
  126. st.fr = NewFramer(cc, cc)
  127. }
  128. return st
  129. }
  130. func (st *serverTester) closeConn() {
  131. st.scMu.Lock()
  132. defer st.scMu.Unlock()
  133. st.sc.conn.Close()
  134. }
  135. func (st *serverTester) addLogFilter(phrase string) {
  136. st.logFilter = append(st.logFilter, phrase)
  137. }
  138. func (st *serverTester) stream(id uint32) *stream {
  139. ch := make(chan *stream, 1)
  140. st.sc.testHookCh <- func(int) {
  141. ch <- st.sc.streams[id]
  142. }
  143. return <-ch
  144. }
  145. func (st *serverTester) streamState(id uint32) streamState {
  146. ch := make(chan streamState, 1)
  147. st.sc.testHookCh <- func(int) {
  148. state, _ := st.sc.state(id)
  149. ch <- state
  150. }
  151. return <-ch
  152. }
  153. // loopNum reports how many times this conn's select loop has gone around.
  154. func (st *serverTester) loopNum() int {
  155. lastc := make(chan int, 1)
  156. st.sc.testHookCh <- func(loopNum int) {
  157. lastc <- loopNum
  158. }
  159. return <-lastc
  160. }
  161. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  162. // The heuristic is that the server connection's serve loop must schedule
  163. // 50 times in a row without any channel sends or receives occurring.
  164. func (st *serverTester) awaitIdle() {
  165. remain := 50
  166. last := st.loopNum()
  167. for remain > 0 {
  168. n := st.loopNum()
  169. if n == last+1 {
  170. remain--
  171. } else {
  172. remain = 50
  173. }
  174. last = n
  175. }
  176. }
  177. func (st *serverTester) Close() {
  178. if st.t.Failed() {
  179. // If we failed already (and are likely in a Fatal,
  180. // unwindowing), force close the connection, so the
  181. // httptest.Server doesn't wait forever for the conn
  182. // to close.
  183. if st.cc != nil {
  184. st.cc.Close()
  185. }
  186. }
  187. st.ts.Close()
  188. if st.cc != nil {
  189. st.cc.Close()
  190. }
  191. log.SetOutput(os.Stderr)
  192. }
  193. // greet initiates the client's HTTP/2 connection into a state where
  194. // frames may be sent.
  195. func (st *serverTester) greet() {
  196. st.writePreface()
  197. st.writeInitialSettings()
  198. st.wantSettings()
  199. st.writeSettingsAck()
  200. st.wantSettingsAck()
  201. }
  202. func (st *serverTester) writePreface() {
  203. n, err := st.cc.Write(clientPreface)
  204. if err != nil {
  205. st.t.Fatalf("Error writing client preface: %v", err)
  206. }
  207. if n != len(clientPreface) {
  208. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  209. }
  210. }
  211. func (st *serverTester) writeInitialSettings() {
  212. if err := st.fr.WriteSettings(); err != nil {
  213. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  214. }
  215. }
  216. func (st *serverTester) writeSettingsAck() {
  217. if err := st.fr.WriteSettingsAck(); err != nil {
  218. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  219. }
  220. }
  221. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  222. if err := st.fr.WriteHeaders(p); err != nil {
  223. st.t.Fatalf("Error writing HEADERS: %v", err)
  224. }
  225. }
  226. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  227. if err := st.fr.WritePriority(id, p); err != nil {
  228. st.t.Fatalf("Error writing PRIORITY: %v", err)
  229. }
  230. }
  231. func (st *serverTester) encodeHeaderField(k, v string) {
  232. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  233. if err != nil {
  234. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  235. }
  236. }
  237. // encodeHeaderRaw is the magic-free version of encodeHeader.
  238. // It takes 0 or more (k, v) pairs and encodes them.
  239. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  240. if len(headers)%2 == 1 {
  241. panic("odd number of kv args")
  242. }
  243. st.headerBuf.Reset()
  244. for len(headers) > 0 {
  245. k, v := headers[0], headers[1]
  246. st.encodeHeaderField(k, v)
  247. headers = headers[2:]
  248. }
  249. return st.headerBuf.Bytes()
  250. }
  251. // encodeHeader encodes headers and returns their HPACK bytes. headers
  252. // must contain an even number of key/value pairs. There may be
  253. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  254. // :scheme headers default to GET, / and https. The :authority header
  255. // defaults to st.ts.Listener.Addr().
  256. func (st *serverTester) encodeHeader(headers ...string) []byte {
  257. if len(headers)%2 == 1 {
  258. panic("odd number of kv args")
  259. }
  260. st.headerBuf.Reset()
  261. defaultAuthority := st.ts.Listener.Addr().String()
  262. if len(headers) == 0 {
  263. // Fast path, mostly for benchmarks, so test code doesn't pollute
  264. // profiles when we're looking to improve server allocations.
  265. st.encodeHeaderField(":method", "GET")
  266. st.encodeHeaderField(":scheme", "https")
  267. st.encodeHeaderField(":authority", defaultAuthority)
  268. st.encodeHeaderField(":path", "/")
  269. return st.headerBuf.Bytes()
  270. }
  271. if len(headers) == 2 && headers[0] == ":method" {
  272. // Another fast path for benchmarks.
  273. st.encodeHeaderField(":method", headers[1])
  274. st.encodeHeaderField(":scheme", "https")
  275. st.encodeHeaderField(":authority", defaultAuthority)
  276. st.encodeHeaderField(":path", "/")
  277. return st.headerBuf.Bytes()
  278. }
  279. pseudoCount := map[string]int{}
  280. keys := []string{":method", ":scheme", ":authority", ":path"}
  281. vals := map[string][]string{
  282. ":method": {"GET"},
  283. ":scheme": {"https"},
  284. ":authority": {defaultAuthority},
  285. ":path": {"/"},
  286. }
  287. for len(headers) > 0 {
  288. k, v := headers[0], headers[1]
  289. headers = headers[2:]
  290. if _, ok := vals[k]; !ok {
  291. keys = append(keys, k)
  292. }
  293. if strings.HasPrefix(k, ":") {
  294. pseudoCount[k]++
  295. if pseudoCount[k] == 1 {
  296. vals[k] = []string{v}
  297. } else {
  298. // Allows testing of invalid headers w/ dup pseudo fields.
  299. vals[k] = append(vals[k], v)
  300. }
  301. } else {
  302. vals[k] = append(vals[k], v)
  303. }
  304. }
  305. for _, k := range keys {
  306. for _, v := range vals[k] {
  307. st.encodeHeaderField(k, v)
  308. }
  309. }
  310. return st.headerBuf.Bytes()
  311. }
  312. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  313. func (st *serverTester) bodylessReq1(headers ...string) {
  314. st.writeHeaders(HeadersFrameParam{
  315. StreamID: 1, // clients send odd numbers
  316. BlockFragment: st.encodeHeader(headers...),
  317. EndStream: true,
  318. EndHeaders: true,
  319. })
  320. }
  321. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  322. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  323. st.t.Fatalf("Error writing DATA: %v", err)
  324. }
  325. }
  326. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  327. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  328. st.t.Fatalf("Error writing DATA: %v", err)
  329. }
  330. }
  331. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  332. ch := make(chan interface{}, 1)
  333. go func() {
  334. fr, err := fr.ReadFrame()
  335. if err != nil {
  336. ch <- err
  337. } else {
  338. ch <- fr
  339. }
  340. }()
  341. t := time.NewTimer(wait)
  342. select {
  343. case v := <-ch:
  344. t.Stop()
  345. if fr, ok := v.(Frame); ok {
  346. return fr, nil
  347. }
  348. return nil, v.(error)
  349. case <-t.C:
  350. return nil, errors.New("timeout waiting for frame")
  351. }
  352. }
  353. func (st *serverTester) readFrame() (Frame, error) {
  354. return readFrameTimeout(st.fr, 2*time.Second)
  355. }
  356. func (st *serverTester) wantHeaders() *HeadersFrame {
  357. f, err := st.readFrame()
  358. if err != nil {
  359. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  360. }
  361. hf, ok := f.(*HeadersFrame)
  362. if !ok {
  363. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  364. }
  365. return hf
  366. }
  367. func (st *serverTester) wantContinuation() *ContinuationFrame {
  368. f, err := st.readFrame()
  369. if err != nil {
  370. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  371. }
  372. cf, ok := f.(*ContinuationFrame)
  373. if !ok {
  374. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  375. }
  376. return cf
  377. }
  378. func (st *serverTester) wantData() *DataFrame {
  379. f, err := st.readFrame()
  380. if err != nil {
  381. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  382. }
  383. df, ok := f.(*DataFrame)
  384. if !ok {
  385. st.t.Fatalf("got a %T; want *DataFrame", f)
  386. }
  387. return df
  388. }
  389. func (st *serverTester) wantSettings() *SettingsFrame {
  390. f, err := st.readFrame()
  391. if err != nil {
  392. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  393. }
  394. sf, ok := f.(*SettingsFrame)
  395. if !ok {
  396. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  397. }
  398. return sf
  399. }
  400. func (st *serverTester) wantPing() *PingFrame {
  401. f, err := st.readFrame()
  402. if err != nil {
  403. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  404. }
  405. pf, ok := f.(*PingFrame)
  406. if !ok {
  407. st.t.Fatalf("got a %T; want *PingFrame", f)
  408. }
  409. return pf
  410. }
  411. func (st *serverTester) wantGoAway() *GoAwayFrame {
  412. f, err := st.readFrame()
  413. if err != nil {
  414. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  415. }
  416. gf, ok := f.(*GoAwayFrame)
  417. if !ok {
  418. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  419. }
  420. return gf
  421. }
  422. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  423. f, err := st.readFrame()
  424. if err != nil {
  425. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  426. }
  427. rs, ok := f.(*RSTStreamFrame)
  428. if !ok {
  429. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  430. }
  431. if rs.FrameHeader.StreamID != streamID {
  432. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  433. }
  434. if rs.ErrCode != errCode {
  435. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  436. }
  437. }
  438. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  439. f, err := st.readFrame()
  440. if err != nil {
  441. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  442. }
  443. wu, ok := f.(*WindowUpdateFrame)
  444. if !ok {
  445. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  446. }
  447. if wu.FrameHeader.StreamID != streamID {
  448. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  449. }
  450. if wu.Increment != incr {
  451. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  452. }
  453. }
  454. func (st *serverTester) wantSettingsAck() {
  455. f, err := st.readFrame()
  456. if err != nil {
  457. st.t.Fatal(err)
  458. }
  459. sf, ok := f.(*SettingsFrame)
  460. if !ok {
  461. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  462. }
  463. if !sf.Header().Flags.Has(FlagSettingsAck) {
  464. st.t.Fatal("Settings Frame didn't have ACK set")
  465. }
  466. }
  467. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  468. f, err := st.readFrame()
  469. if err != nil {
  470. st.t.Fatal(err)
  471. }
  472. ppf, ok := f.(*PushPromiseFrame)
  473. if !ok {
  474. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  475. }
  476. return ppf
  477. }
  478. func TestServer(t *testing.T) {
  479. gotReq := make(chan bool, 1)
  480. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  481. w.Header().Set("Foo", "Bar")
  482. gotReq <- true
  483. })
  484. defer st.Close()
  485. covers("3.5", `
  486. The server connection preface consists of a potentially empty
  487. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  488. server sends in the HTTP/2 connection.
  489. `)
  490. st.writePreface()
  491. st.writeInitialSettings()
  492. st.wantSettings()
  493. st.writeSettingsAck()
  494. st.wantSettingsAck()
  495. st.writeHeaders(HeadersFrameParam{
  496. StreamID: 1, // clients send odd numbers
  497. BlockFragment: st.encodeHeader(),
  498. EndStream: true, // no DATA frames
  499. EndHeaders: true,
  500. })
  501. select {
  502. case <-gotReq:
  503. case <-time.After(2 * time.Second):
  504. t.Error("timeout waiting for request")
  505. }
  506. }
  507. func TestServer_Request_Get(t *testing.T) {
  508. testServerRequest(t, func(st *serverTester) {
  509. st.writeHeaders(HeadersFrameParam{
  510. StreamID: 1, // clients send odd numbers
  511. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  512. EndStream: true, // no DATA frames
  513. EndHeaders: true,
  514. })
  515. }, func(r *http.Request) {
  516. if r.Method != "GET" {
  517. t.Errorf("Method = %q; want GET", r.Method)
  518. }
  519. if r.URL.Path != "/" {
  520. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  521. }
  522. if r.ContentLength != 0 {
  523. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  524. }
  525. if r.Close {
  526. t.Error("Close = true; want false")
  527. }
  528. if !strings.Contains(r.RemoteAddr, ":") {
  529. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  530. }
  531. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  532. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  533. }
  534. wantHeader := http.Header{
  535. "Foo-Bar": []string{"some-value"},
  536. }
  537. if !reflect.DeepEqual(r.Header, wantHeader) {
  538. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  539. }
  540. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  541. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  542. }
  543. })
  544. }
  545. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  546. testServerRequest(t, func(st *serverTester) {
  547. st.writeHeaders(HeadersFrameParam{
  548. StreamID: 1, // clients send odd numbers
  549. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  550. EndStream: true, // no DATA frames
  551. EndHeaders: true,
  552. })
  553. }, func(r *http.Request) {
  554. if r.RequestURI != "/%2f/" {
  555. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  556. }
  557. if r.URL.Path != "///" {
  558. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  559. }
  560. })
  561. }
  562. // TODO: add a test with EndStream=true on the HEADERS but setting a
  563. // Content-Length anyway. Should we just omit it and force it to
  564. // zero?
  565. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  566. testServerRequest(t, func(st *serverTester) {
  567. st.writeHeaders(HeadersFrameParam{
  568. StreamID: 1, // clients send odd numbers
  569. BlockFragment: st.encodeHeader(":method", "POST"),
  570. EndStream: true,
  571. EndHeaders: true,
  572. })
  573. }, func(r *http.Request) {
  574. if r.Method != "POST" {
  575. t.Errorf("Method = %q; want POST", r.Method)
  576. }
  577. if r.ContentLength != 0 {
  578. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  579. }
  580. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  581. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  582. }
  583. })
  584. }
  585. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  586. testBodyContents(t, -1, "", func(st *serverTester) {
  587. st.writeHeaders(HeadersFrameParam{
  588. StreamID: 1, // clients send odd numbers
  589. BlockFragment: st.encodeHeader(":method", "POST"),
  590. EndStream: false, // to say DATA frames are coming
  591. EndHeaders: true,
  592. })
  593. st.writeData(1, true, nil) // just kidding. empty body.
  594. })
  595. }
  596. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  597. const content = "Some content"
  598. testBodyContents(t, -1, content, func(st *serverTester) {
  599. st.writeHeaders(HeadersFrameParam{
  600. StreamID: 1, // clients send odd numbers
  601. BlockFragment: st.encodeHeader(":method", "POST"),
  602. EndStream: false, // to say DATA frames are coming
  603. EndHeaders: true,
  604. })
  605. st.writeData(1, true, []byte(content))
  606. })
  607. }
  608. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  609. const content = "Some content"
  610. testBodyContents(t, -1, content, func(st *serverTester) {
  611. st.writeHeaders(HeadersFrameParam{
  612. StreamID: 1, // clients send odd numbers
  613. BlockFragment: st.encodeHeader(":method", "POST"),
  614. EndStream: false, // to say DATA frames are coming
  615. EndHeaders: true,
  616. })
  617. st.writeData(1, false, []byte(content[:5]))
  618. st.writeData(1, true, []byte(content[5:]))
  619. })
  620. }
  621. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  622. const content = "Some content"
  623. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  624. st.writeHeaders(HeadersFrameParam{
  625. StreamID: 1, // clients send odd numbers
  626. BlockFragment: st.encodeHeader(
  627. ":method", "POST",
  628. "content-length", strconv.Itoa(len(content)),
  629. ),
  630. EndStream: false, // to say DATA frames are coming
  631. EndHeaders: true,
  632. })
  633. st.writeData(1, true, []byte(content))
  634. })
  635. }
  636. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  637. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  638. func(st *serverTester) {
  639. st.writeHeaders(HeadersFrameParam{
  640. StreamID: 1, // clients send odd numbers
  641. BlockFragment: st.encodeHeader(
  642. ":method", "POST",
  643. "content-length", "3",
  644. ),
  645. EndStream: false, // to say DATA frames are coming
  646. EndHeaders: true,
  647. })
  648. st.writeData(1, true, []byte("12"))
  649. })
  650. }
  651. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  652. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  653. func(st *serverTester) {
  654. st.writeHeaders(HeadersFrameParam{
  655. StreamID: 1, // clients send odd numbers
  656. BlockFragment: st.encodeHeader(
  657. ":method", "POST",
  658. "content-length", "4",
  659. ),
  660. EndStream: false, // to say DATA frames are coming
  661. EndHeaders: true,
  662. })
  663. st.writeData(1, true, []byte("12345"))
  664. })
  665. }
  666. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  667. testServerRequest(t, write, func(r *http.Request) {
  668. if r.Method != "POST" {
  669. t.Errorf("Method = %q; want POST", r.Method)
  670. }
  671. if r.ContentLength != wantContentLength {
  672. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  673. }
  674. all, err := ioutil.ReadAll(r.Body)
  675. if err != nil {
  676. t.Fatal(err)
  677. }
  678. if string(all) != wantBody {
  679. t.Errorf("Read = %q; want %q", all, wantBody)
  680. }
  681. if err := r.Body.Close(); err != nil {
  682. t.Fatalf("Close: %v", err)
  683. }
  684. })
  685. }
  686. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  687. testServerRequest(t, write, func(r *http.Request) {
  688. if r.Method != "POST" {
  689. t.Errorf("Method = %q; want POST", r.Method)
  690. }
  691. if r.ContentLength != wantContentLength {
  692. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  693. }
  694. all, err := ioutil.ReadAll(r.Body)
  695. if err == nil {
  696. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  697. wantReadError, all)
  698. }
  699. if !strings.Contains(err.Error(), wantReadError) {
  700. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  701. }
  702. if err := r.Body.Close(); err != nil {
  703. t.Fatalf("Close: %v", err)
  704. }
  705. })
  706. }
  707. // Using a Host header, instead of :authority
  708. func TestServer_Request_Get_Host(t *testing.T) {
  709. const host = "example.com"
  710. testServerRequest(t, func(st *serverTester) {
  711. st.writeHeaders(HeadersFrameParam{
  712. StreamID: 1, // clients send odd numbers
  713. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  714. EndStream: true,
  715. EndHeaders: true,
  716. })
  717. }, func(r *http.Request) {
  718. if r.Host != host {
  719. t.Errorf("Host = %q; want %q", r.Host, host)
  720. }
  721. })
  722. }
  723. // Using an :authority pseudo-header, instead of Host
  724. func TestServer_Request_Get_Authority(t *testing.T) {
  725. const host = "example.com"
  726. testServerRequest(t, func(st *serverTester) {
  727. st.writeHeaders(HeadersFrameParam{
  728. StreamID: 1, // clients send odd numbers
  729. BlockFragment: st.encodeHeader(":authority", host),
  730. EndStream: true,
  731. EndHeaders: true,
  732. })
  733. }, func(r *http.Request) {
  734. if r.Host != host {
  735. t.Errorf("Host = %q; want %q", r.Host, host)
  736. }
  737. })
  738. }
  739. func TestServer_Request_WithContinuation(t *testing.T) {
  740. wantHeader := http.Header{
  741. "Foo-One": []string{"value-one"},
  742. "Foo-Two": []string{"value-two"},
  743. "Foo-Three": []string{"value-three"},
  744. }
  745. testServerRequest(t, func(st *serverTester) {
  746. fullHeaders := st.encodeHeader(
  747. "foo-one", "value-one",
  748. "foo-two", "value-two",
  749. "foo-three", "value-three",
  750. )
  751. remain := fullHeaders
  752. chunks := 0
  753. for len(remain) > 0 {
  754. const maxChunkSize = 5
  755. chunk := remain
  756. if len(chunk) > maxChunkSize {
  757. chunk = chunk[:maxChunkSize]
  758. }
  759. remain = remain[len(chunk):]
  760. if chunks == 0 {
  761. st.writeHeaders(HeadersFrameParam{
  762. StreamID: 1, // clients send odd numbers
  763. BlockFragment: chunk,
  764. EndStream: true, // no DATA frames
  765. EndHeaders: false, // we'll have continuation frames
  766. })
  767. } else {
  768. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  769. if err != nil {
  770. t.Fatal(err)
  771. }
  772. }
  773. chunks++
  774. }
  775. if chunks < 2 {
  776. t.Fatal("too few chunks")
  777. }
  778. }, func(r *http.Request) {
  779. if !reflect.DeepEqual(r.Header, wantHeader) {
  780. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  781. }
  782. })
  783. }
  784. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  785. func TestServer_Request_CookieConcat(t *testing.T) {
  786. const host = "example.com"
  787. testServerRequest(t, func(st *serverTester) {
  788. st.bodylessReq1(
  789. ":authority", host,
  790. "cookie", "a=b",
  791. "cookie", "c=d",
  792. "cookie", "e=f",
  793. )
  794. }, func(r *http.Request) {
  795. const want = "a=b; c=d; e=f"
  796. if got := r.Header.Get("Cookie"); got != want {
  797. t.Errorf("Cookie = %q; want %q", got, want)
  798. }
  799. })
  800. }
  801. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  802. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  803. }
  804. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  805. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  806. }
  807. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  808. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  809. }
  810. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  811. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  812. }
  813. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  814. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  815. }
  816. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  817. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  818. }
  819. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  820. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  821. }
  822. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  823. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  824. }
  825. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  826. // 8.1.2.3 Request Pseudo-Header Fields
  827. // "All HTTP/2 requests MUST include exactly one valid value" ...
  828. testRejectRequest(t, func(st *serverTester) {
  829. st.addLogFilter("duplicate pseudo-header")
  830. st.bodylessReq1(":method", "GET", ":method", "POST")
  831. })
  832. }
  833. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  834. // 8.1.2.3 Request Pseudo-Header Fields
  835. // "All pseudo-header fields MUST appear in the header block
  836. // before regular header fields. Any request or response that
  837. // contains a pseudo-header field that appears in a header
  838. // block after a regular header field MUST be treated as
  839. // malformed (Section 8.1.2.6)."
  840. testRejectRequest(t, func(st *serverTester) {
  841. st.addLogFilter("pseudo-header after regular header")
  842. var buf bytes.Buffer
  843. enc := hpack.NewEncoder(&buf)
  844. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  845. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  846. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  847. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  848. st.writeHeaders(HeadersFrameParam{
  849. StreamID: 1, // clients send odd numbers
  850. BlockFragment: buf.Bytes(),
  851. EndStream: true,
  852. EndHeaders: true,
  853. })
  854. })
  855. }
  856. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  857. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  858. }
  859. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  860. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  861. }
  862. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  863. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  864. }
  865. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  866. testRejectRequest(t, func(st *serverTester) {
  867. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  868. st.bodylessReq1(":unknown_thing", "")
  869. })
  870. }
  871. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  872. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  873. t.Error("server request made it to handler; should've been rejected")
  874. })
  875. defer st.Close()
  876. st.greet()
  877. send(st)
  878. st.wantRSTStream(1, ErrCodeProtocol)
  879. }
  880. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  881. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  882. t.Error("server request made it to handler; should've been rejected")
  883. }, optQuiet)
  884. defer st.Close()
  885. st.greet()
  886. send(st)
  887. gf := st.wantGoAway()
  888. if gf.ErrCode != ErrCodeProtocol {
  889. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  890. }
  891. }
  892. // Section 5.1, on idle connections: "Receiving any frame other than
  893. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  894. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  895. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  896. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  897. st.fr.WriteWindowUpdate(123, 456)
  898. })
  899. }
  900. func TestRejectFrameOnIdle_Data(t *testing.T) {
  901. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  902. st.fr.WriteData(123, true, nil)
  903. })
  904. }
  905. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  906. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  907. st.fr.WriteRSTStream(123, ErrCodeCancel)
  908. })
  909. }
  910. func TestServer_Request_Connect(t *testing.T) {
  911. testServerRequest(t, func(st *serverTester) {
  912. st.writeHeaders(HeadersFrameParam{
  913. StreamID: 1,
  914. BlockFragment: st.encodeHeaderRaw(
  915. ":method", "CONNECT",
  916. ":authority", "example.com:123",
  917. ),
  918. EndStream: true,
  919. EndHeaders: true,
  920. })
  921. }, func(r *http.Request) {
  922. if g, w := r.Method, "CONNECT"; g != w {
  923. t.Errorf("Method = %q; want %q", g, w)
  924. }
  925. if g, w := r.RequestURI, "example.com:123"; g != w {
  926. t.Errorf("RequestURI = %q; want %q", g, w)
  927. }
  928. if g, w := r.URL.Host, "example.com:123"; g != w {
  929. t.Errorf("URL.Host = %q; want %q", g, w)
  930. }
  931. })
  932. }
  933. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  934. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  935. st.writeHeaders(HeadersFrameParam{
  936. StreamID: 1,
  937. BlockFragment: st.encodeHeaderRaw(
  938. ":method", "CONNECT",
  939. ":authority", "example.com:123",
  940. ":path", "/bogus",
  941. ),
  942. EndStream: true,
  943. EndHeaders: true,
  944. })
  945. })
  946. }
  947. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  948. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  949. st.writeHeaders(HeadersFrameParam{
  950. StreamID: 1,
  951. BlockFragment: st.encodeHeaderRaw(
  952. ":method", "CONNECT",
  953. ":authority", "example.com:123",
  954. ":scheme", "https",
  955. ),
  956. EndStream: true,
  957. EndHeaders: true,
  958. })
  959. })
  960. }
  961. func TestServer_Ping(t *testing.T) {
  962. st := newServerTester(t, nil)
  963. defer st.Close()
  964. st.greet()
  965. // Server should ignore this one, since it has ACK set.
  966. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  967. if err := st.fr.WritePing(true, ackPingData); err != nil {
  968. t.Fatal(err)
  969. }
  970. // But the server should reply to this one, since ACK is false.
  971. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  972. if err := st.fr.WritePing(false, pingData); err != nil {
  973. t.Fatal(err)
  974. }
  975. pf := st.wantPing()
  976. if !pf.Flags.Has(FlagPingAck) {
  977. t.Error("response ping doesn't have ACK set")
  978. }
  979. if pf.Data != pingData {
  980. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  981. }
  982. }
  983. func TestServer_RejectsLargeFrames(t *testing.T) {
  984. if runtime.GOOS == "windows" {
  985. t.Skip("see golang.org/issue/13434")
  986. }
  987. st := newServerTester(t, nil)
  988. defer st.Close()
  989. st.greet()
  990. // Write too large of a frame (too large by one byte)
  991. // We ignore the return value because it's expected that the server
  992. // will only read the first 9 bytes (the headre) and then disconnect.
  993. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  994. gf := st.wantGoAway()
  995. if gf.ErrCode != ErrCodeFrameSize {
  996. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  997. }
  998. if st.logBuf.Len() != 0 {
  999. // Previously we spun here for a bit until the GOAWAY disconnect
  1000. // timer fired, logging while we fired.
  1001. t.Errorf("unexpected server output: %.500s\n", st.logBuf.Bytes())
  1002. }
  1003. }
  1004. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1005. puppet := newHandlerPuppet()
  1006. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1007. puppet.act(w, r)
  1008. })
  1009. defer st.Close()
  1010. defer puppet.done()
  1011. st.greet()
  1012. st.writeHeaders(HeadersFrameParam{
  1013. StreamID: 1, // clients send odd numbers
  1014. BlockFragment: st.encodeHeader(":method", "POST"),
  1015. EndStream: false, // data coming
  1016. EndHeaders: true,
  1017. })
  1018. st.writeData(1, false, []byte("abcdef"))
  1019. puppet.do(readBodyHandler(t, "abc"))
  1020. st.wantWindowUpdate(0, 3)
  1021. st.wantWindowUpdate(1, 3)
  1022. puppet.do(readBodyHandler(t, "def"))
  1023. st.wantWindowUpdate(0, 3)
  1024. st.wantWindowUpdate(1, 3)
  1025. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1026. puppet.do(readBodyHandler(t, "ghi"))
  1027. puppet.do(readBodyHandler(t, "jkl"))
  1028. st.wantWindowUpdate(0, 3)
  1029. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1030. }
  1031. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1032. // See golang.org/issue/16556
  1033. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1034. puppet := newHandlerPuppet()
  1035. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1036. puppet.act(w, r)
  1037. })
  1038. defer st.Close()
  1039. defer puppet.done()
  1040. st.greet()
  1041. st.writeHeaders(HeadersFrameParam{
  1042. StreamID: 1,
  1043. BlockFragment: st.encodeHeader(":method", "POST"),
  1044. EndStream: false,
  1045. EndHeaders: true,
  1046. })
  1047. st.writeDataPadded(1, false, []byte("abcdef"), []byte("1234"))
  1048. // Expect to immediately get our 5 bytes of padding back for
  1049. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1050. st.wantWindowUpdate(0, 5)
  1051. st.wantWindowUpdate(1, 5)
  1052. puppet.do(readBodyHandler(t, "abc"))
  1053. st.wantWindowUpdate(0, 3)
  1054. st.wantWindowUpdate(1, 3)
  1055. puppet.do(readBodyHandler(t, "def"))
  1056. st.wantWindowUpdate(0, 3)
  1057. st.wantWindowUpdate(1, 3)
  1058. }
  1059. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1060. st := newServerTester(t, nil)
  1061. defer st.Close()
  1062. st.greet()
  1063. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1064. t.Fatal(err)
  1065. }
  1066. gf := st.wantGoAway()
  1067. if gf.ErrCode != ErrCodeFlowControl {
  1068. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1069. }
  1070. if gf.LastStreamID != 0 {
  1071. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1072. }
  1073. }
  1074. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1075. inHandler := make(chan bool)
  1076. blockHandler := make(chan bool)
  1077. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1078. inHandler <- true
  1079. <-blockHandler
  1080. })
  1081. defer st.Close()
  1082. defer close(blockHandler)
  1083. st.greet()
  1084. st.writeHeaders(HeadersFrameParam{
  1085. StreamID: 1,
  1086. BlockFragment: st.encodeHeader(":method", "POST"),
  1087. EndStream: false, // keep it open
  1088. EndHeaders: true,
  1089. })
  1090. <-inHandler
  1091. // Send a bogus window update:
  1092. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1093. t.Fatal(err)
  1094. }
  1095. st.wantRSTStream(1, ErrCodeFlowControl)
  1096. }
  1097. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1098. // then runs fn once in the handler, and verifies that the error returned from
  1099. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1100. func testServerPostUnblock(t *testing.T,
  1101. handler func(http.ResponseWriter, *http.Request) error,
  1102. fn func(*serverTester),
  1103. checkErr func(error),
  1104. otherHeaders ...string) {
  1105. inHandler := make(chan bool)
  1106. errc := make(chan error, 1)
  1107. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1108. inHandler <- true
  1109. errc <- handler(w, r)
  1110. })
  1111. st.greet()
  1112. st.writeHeaders(HeadersFrameParam{
  1113. StreamID: 1,
  1114. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1115. EndStream: false, // keep it open
  1116. EndHeaders: true,
  1117. })
  1118. <-inHandler
  1119. fn(st)
  1120. select {
  1121. case err := <-errc:
  1122. if checkErr != nil {
  1123. checkErr(err)
  1124. }
  1125. case <-time.After(5 * time.Second):
  1126. t.Fatal("timeout waiting for Handler to return")
  1127. }
  1128. st.Close()
  1129. }
  1130. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1131. testServerPostUnblock(t,
  1132. func(w http.ResponseWriter, r *http.Request) (err error) {
  1133. _, err = r.Body.Read(make([]byte, 1))
  1134. return
  1135. },
  1136. func(st *serverTester) {
  1137. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1138. t.Fatal(err)
  1139. }
  1140. },
  1141. func(err error) {
  1142. want := StreamError{StreamID: 0x1, Code: 0x8}
  1143. if !reflect.DeepEqual(err, want) {
  1144. t.Errorf("Read error = %v; want %v", err, want)
  1145. }
  1146. },
  1147. )
  1148. }
  1149. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1150. // Run this test a bunch, because it doesn't always
  1151. // deadlock. But with a bunch, it did.
  1152. n := 50
  1153. if testing.Short() {
  1154. n = 5
  1155. }
  1156. for i := 0; i < n; i++ {
  1157. testServer_RSTStream_Unblocks_Header_Write(t)
  1158. }
  1159. }
  1160. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1161. inHandler := make(chan bool, 1)
  1162. unblockHandler := make(chan bool, 1)
  1163. headerWritten := make(chan bool, 1)
  1164. wroteRST := make(chan bool, 1)
  1165. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1166. inHandler <- true
  1167. <-wroteRST
  1168. w.Header().Set("foo", "bar")
  1169. w.WriteHeader(200)
  1170. w.(http.Flusher).Flush()
  1171. headerWritten <- true
  1172. <-unblockHandler
  1173. })
  1174. defer st.Close()
  1175. st.greet()
  1176. st.writeHeaders(HeadersFrameParam{
  1177. StreamID: 1,
  1178. BlockFragment: st.encodeHeader(":method", "POST"),
  1179. EndStream: false, // keep it open
  1180. EndHeaders: true,
  1181. })
  1182. <-inHandler
  1183. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1184. t.Fatal(err)
  1185. }
  1186. wroteRST <- true
  1187. st.awaitIdle()
  1188. select {
  1189. case <-headerWritten:
  1190. case <-time.After(2 * time.Second):
  1191. t.Error("timeout waiting for header write")
  1192. }
  1193. unblockHandler <- true
  1194. }
  1195. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1196. testServerPostUnblock(t,
  1197. func(w http.ResponseWriter, r *http.Request) (err error) {
  1198. _, err = r.Body.Read(make([]byte, 1))
  1199. return
  1200. },
  1201. func(st *serverTester) { st.cc.Close() },
  1202. func(err error) {
  1203. if err == nil {
  1204. t.Error("unexpected nil error from Request.Body.Read")
  1205. }
  1206. },
  1207. )
  1208. }
  1209. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1210. <-w.(http.CloseNotifier).CloseNotify()
  1211. return nil
  1212. }
  1213. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1214. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1215. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1216. t.Fatal(err)
  1217. }
  1218. }, nil)
  1219. }
  1220. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1221. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1222. }
  1223. // that CloseNotify unblocks after a stream error due to the client's
  1224. // problem that's unrelated to them explicitly canceling it (which is
  1225. // TestServer_CloseNotify_After_RSTStream above)
  1226. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1227. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1228. // data longer than declared Content-Length => stream error
  1229. st.writeData(1, true, []byte("1234"))
  1230. }, nil, "content-length", "3")
  1231. }
  1232. func TestServer_StateTransitions(t *testing.T) {
  1233. var st *serverTester
  1234. inHandler := make(chan bool)
  1235. writeData := make(chan bool)
  1236. leaveHandler := make(chan bool)
  1237. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1238. inHandler <- true
  1239. if st.stream(1) == nil {
  1240. t.Errorf("nil stream 1 in handler")
  1241. }
  1242. if got, want := st.streamState(1), stateOpen; got != want {
  1243. t.Errorf("in handler, state is %v; want %v", got, want)
  1244. }
  1245. writeData <- true
  1246. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1247. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1248. }
  1249. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1250. t.Errorf("in handler, state is %v; want %v", got, want)
  1251. }
  1252. <-leaveHandler
  1253. })
  1254. st.greet()
  1255. if st.stream(1) != nil {
  1256. t.Fatal("stream 1 should be empty")
  1257. }
  1258. if got := st.streamState(1); got != stateIdle {
  1259. t.Fatalf("stream 1 should be idle; got %v", got)
  1260. }
  1261. st.writeHeaders(HeadersFrameParam{
  1262. StreamID: 1,
  1263. BlockFragment: st.encodeHeader(":method", "POST"),
  1264. EndStream: false, // keep it open
  1265. EndHeaders: true,
  1266. })
  1267. <-inHandler
  1268. <-writeData
  1269. st.writeData(1, true, nil)
  1270. leaveHandler <- true
  1271. hf := st.wantHeaders()
  1272. if !hf.StreamEnded() {
  1273. t.Fatal("expected END_STREAM flag")
  1274. }
  1275. if got, want := st.streamState(1), stateClosed; got != want {
  1276. t.Errorf("at end, state is %v; want %v", got, want)
  1277. }
  1278. if st.stream(1) != nil {
  1279. t.Fatal("at end, stream 1 should be gone")
  1280. }
  1281. }
  1282. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1283. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1284. testServerRejectsConn(t, func(st *serverTester) {
  1285. st.writeHeaders(HeadersFrameParam{
  1286. StreamID: 1,
  1287. BlockFragment: st.encodeHeader(),
  1288. EndStream: true,
  1289. EndHeaders: false,
  1290. })
  1291. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1292. StreamID: 3, // different stream.
  1293. BlockFragment: st.encodeHeader(),
  1294. EndStream: true,
  1295. EndHeaders: true,
  1296. })
  1297. })
  1298. }
  1299. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1300. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1301. testServerRejectsConn(t, func(st *serverTester) {
  1302. st.writeHeaders(HeadersFrameParam{
  1303. StreamID: 1,
  1304. BlockFragment: st.encodeHeader(),
  1305. EndStream: true,
  1306. EndHeaders: false,
  1307. })
  1308. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1309. t.Fatal(err)
  1310. }
  1311. })
  1312. }
  1313. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1314. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1315. testServerRejectsConn(t, func(st *serverTester) {
  1316. st.writeHeaders(HeadersFrameParam{
  1317. StreamID: 1,
  1318. BlockFragment: st.encodeHeader(),
  1319. EndStream: true,
  1320. EndHeaders: true,
  1321. })
  1322. st.wantHeaders()
  1323. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1324. t.Fatal(err)
  1325. }
  1326. })
  1327. }
  1328. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1329. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1330. testServerRejectsConn(t, func(st *serverTester) {
  1331. st.writeHeaders(HeadersFrameParam{
  1332. StreamID: 1,
  1333. BlockFragment: st.encodeHeader(),
  1334. EndStream: true,
  1335. EndHeaders: false,
  1336. })
  1337. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1338. t.Fatal(err)
  1339. }
  1340. })
  1341. }
  1342. // No HEADERS on stream 0.
  1343. func TestServer_Rejects_Headers0(t *testing.T) {
  1344. testServerRejectsConn(t, func(st *serverTester) {
  1345. st.fr.AllowIllegalWrites = true
  1346. st.writeHeaders(HeadersFrameParam{
  1347. StreamID: 0,
  1348. BlockFragment: st.encodeHeader(),
  1349. EndStream: true,
  1350. EndHeaders: true,
  1351. })
  1352. })
  1353. }
  1354. // No CONTINUATION on stream 0.
  1355. func TestServer_Rejects_Continuation0(t *testing.T) {
  1356. testServerRejectsConn(t, func(st *serverTester) {
  1357. st.fr.AllowIllegalWrites = true
  1358. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1359. t.Fatal(err)
  1360. }
  1361. })
  1362. }
  1363. // No PRIORITY on stream 0.
  1364. func TestServer_Rejects_Priority0(t *testing.T) {
  1365. testServerRejectsConn(t, func(st *serverTester) {
  1366. st.fr.AllowIllegalWrites = true
  1367. st.writePriority(0, PriorityParam{StreamDep: 1})
  1368. })
  1369. }
  1370. // No HEADERS frame with a self-dependence.
  1371. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1372. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1373. st.fr.AllowIllegalWrites = true
  1374. st.writeHeaders(HeadersFrameParam{
  1375. StreamID: 1,
  1376. BlockFragment: st.encodeHeader(),
  1377. EndStream: true,
  1378. EndHeaders: true,
  1379. Priority: PriorityParam{StreamDep: 1},
  1380. })
  1381. })
  1382. }
  1383. // No PRIORTY frame with a self-dependence.
  1384. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1385. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1386. st.fr.AllowIllegalWrites = true
  1387. st.writePriority(1, PriorityParam{StreamDep: 1})
  1388. })
  1389. }
  1390. func TestServer_Rejects_PushPromise(t *testing.T) {
  1391. testServerRejectsConn(t, func(st *serverTester) {
  1392. pp := PushPromiseParam{
  1393. StreamID: 1,
  1394. PromiseID: 3,
  1395. }
  1396. if err := st.fr.WritePushPromise(pp); err != nil {
  1397. t.Fatal(err)
  1398. }
  1399. })
  1400. }
  1401. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1402. // frame and a server close after the client does something
  1403. // deserving a CONNECTION_ERROR.
  1404. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1405. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1406. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1407. defer st.Close()
  1408. st.greet()
  1409. writeReq(st)
  1410. st.wantGoAway()
  1411. errc := make(chan error, 1)
  1412. go func() {
  1413. fr, err := st.fr.ReadFrame()
  1414. if err == nil {
  1415. err = fmt.Errorf("got frame of type %T", fr)
  1416. }
  1417. errc <- err
  1418. }()
  1419. select {
  1420. case err := <-errc:
  1421. if err != io.EOF {
  1422. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1423. }
  1424. case <-time.After(2 * time.Second):
  1425. t.Error("timeout waiting for disconnect")
  1426. }
  1427. }
  1428. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1429. // error code after a client sends a bogus request.
  1430. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1431. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1432. defer st.Close()
  1433. st.greet()
  1434. writeReq(st)
  1435. st.wantRSTStream(1, code)
  1436. }
  1437. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1438. // write a single request with writeReq, and then verify that the
  1439. // *http.Request is built correctly in checkReq.
  1440. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1441. gotReq := make(chan bool, 1)
  1442. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1443. if r.Body == nil {
  1444. t.Fatal("nil Body")
  1445. }
  1446. checkReq(r)
  1447. gotReq <- true
  1448. })
  1449. defer st.Close()
  1450. st.greet()
  1451. writeReq(st)
  1452. select {
  1453. case <-gotReq:
  1454. case <-time.After(2 * time.Second):
  1455. t.Error("timeout waiting for request")
  1456. }
  1457. }
  1458. func getSlash(st *serverTester) { st.bodylessReq1() }
  1459. func TestServer_Response_NoData(t *testing.T) {
  1460. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1461. // Nothing.
  1462. return nil
  1463. }, func(st *serverTester) {
  1464. getSlash(st)
  1465. hf := st.wantHeaders()
  1466. if !hf.StreamEnded() {
  1467. t.Fatal("want END_STREAM flag")
  1468. }
  1469. if !hf.HeadersEnded() {
  1470. t.Fatal("want END_HEADERS flag")
  1471. }
  1472. })
  1473. }
  1474. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1475. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1476. w.Header().Set("Foo-Bar", "some-value")
  1477. return nil
  1478. }, func(st *serverTester) {
  1479. getSlash(st)
  1480. hf := st.wantHeaders()
  1481. if !hf.StreamEnded() {
  1482. t.Fatal("want END_STREAM flag")
  1483. }
  1484. if !hf.HeadersEnded() {
  1485. t.Fatal("want END_HEADERS flag")
  1486. }
  1487. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1488. wanth := [][2]string{
  1489. {":status", "200"},
  1490. {"foo-bar", "some-value"},
  1491. {"content-type", "text/plain; charset=utf-8"},
  1492. {"content-length", "0"},
  1493. }
  1494. if !reflect.DeepEqual(goth, wanth) {
  1495. t.Errorf("Got headers %v; want %v", goth, wanth)
  1496. }
  1497. })
  1498. }
  1499. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1500. const msg = "<html>this is HTML."
  1501. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1502. w.Header().Set("Content-Type", "foo/bar")
  1503. io.WriteString(w, msg)
  1504. return nil
  1505. }, func(st *serverTester) {
  1506. getSlash(st)
  1507. hf := st.wantHeaders()
  1508. if hf.StreamEnded() {
  1509. t.Fatal("don't want END_STREAM, expecting data")
  1510. }
  1511. if !hf.HeadersEnded() {
  1512. t.Fatal("want END_HEADERS flag")
  1513. }
  1514. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1515. wanth := [][2]string{
  1516. {":status", "200"},
  1517. {"content-type", "foo/bar"},
  1518. {"content-length", strconv.Itoa(len(msg))},
  1519. }
  1520. if !reflect.DeepEqual(goth, wanth) {
  1521. t.Errorf("Got headers %v; want %v", goth, wanth)
  1522. }
  1523. df := st.wantData()
  1524. if !df.StreamEnded() {
  1525. t.Error("expected DATA to have END_STREAM flag")
  1526. }
  1527. if got := string(df.Data()); got != msg {
  1528. t.Errorf("got DATA %q; want %q", got, msg)
  1529. }
  1530. })
  1531. }
  1532. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1533. const msg = "hi"
  1534. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1535. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1536. io.WriteString(w, msg)
  1537. return nil
  1538. }, func(st *serverTester) {
  1539. getSlash(st)
  1540. hf := st.wantHeaders()
  1541. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1542. wanth := [][2]string{
  1543. {":status", "200"},
  1544. {"content-type", "text/plain; charset=utf-8"},
  1545. {"content-length", strconv.Itoa(len(msg))},
  1546. }
  1547. if !reflect.DeepEqual(goth, wanth) {
  1548. t.Errorf("Got headers %v; want %v", goth, wanth)
  1549. }
  1550. })
  1551. }
  1552. // Header accessed only after the initial write.
  1553. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1554. const msg = "<html>this is HTML."
  1555. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1556. io.WriteString(w, msg)
  1557. w.Header().Set("foo", "should be ignored")
  1558. return nil
  1559. }, func(st *serverTester) {
  1560. getSlash(st)
  1561. hf := st.wantHeaders()
  1562. if hf.StreamEnded() {
  1563. t.Fatal("unexpected END_STREAM")
  1564. }
  1565. if !hf.HeadersEnded() {
  1566. t.Fatal("want END_HEADERS flag")
  1567. }
  1568. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1569. wanth := [][2]string{
  1570. {":status", "200"},
  1571. {"content-type", "text/html; charset=utf-8"},
  1572. {"content-length", strconv.Itoa(len(msg))},
  1573. }
  1574. if !reflect.DeepEqual(goth, wanth) {
  1575. t.Errorf("Got headers %v; want %v", goth, wanth)
  1576. }
  1577. })
  1578. }
  1579. // Header accessed before the initial write and later mutated.
  1580. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1581. const msg = "<html>this is HTML."
  1582. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1583. w.Header().Set("foo", "proper value")
  1584. io.WriteString(w, msg)
  1585. w.Header().Set("foo", "should be ignored")
  1586. return nil
  1587. }, func(st *serverTester) {
  1588. getSlash(st)
  1589. hf := st.wantHeaders()
  1590. if hf.StreamEnded() {
  1591. t.Fatal("unexpected END_STREAM")
  1592. }
  1593. if !hf.HeadersEnded() {
  1594. t.Fatal("want END_HEADERS flag")
  1595. }
  1596. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1597. wanth := [][2]string{
  1598. {":status", "200"},
  1599. {"foo", "proper value"},
  1600. {"content-type", "text/html; charset=utf-8"},
  1601. {"content-length", strconv.Itoa(len(msg))},
  1602. }
  1603. if !reflect.DeepEqual(goth, wanth) {
  1604. t.Errorf("Got headers %v; want %v", goth, wanth)
  1605. }
  1606. })
  1607. }
  1608. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1609. const msg = "<html>this is HTML."
  1610. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1611. io.WriteString(w, msg)
  1612. return nil
  1613. }, func(st *serverTester) {
  1614. getSlash(st)
  1615. hf := st.wantHeaders()
  1616. if hf.StreamEnded() {
  1617. t.Fatal("don't want END_STREAM, expecting data")
  1618. }
  1619. if !hf.HeadersEnded() {
  1620. t.Fatal("want END_HEADERS flag")
  1621. }
  1622. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1623. wanth := [][2]string{
  1624. {":status", "200"},
  1625. {"content-type", "text/html; charset=utf-8"},
  1626. {"content-length", strconv.Itoa(len(msg))},
  1627. }
  1628. if !reflect.DeepEqual(goth, wanth) {
  1629. t.Errorf("Got headers %v; want %v", goth, wanth)
  1630. }
  1631. df := st.wantData()
  1632. if !df.StreamEnded() {
  1633. t.Error("expected DATA to have END_STREAM flag")
  1634. }
  1635. if got := string(df.Data()); got != msg {
  1636. t.Errorf("got DATA %q; want %q", got, msg)
  1637. }
  1638. })
  1639. }
  1640. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1641. const msg = "<html>this is HTML"
  1642. const msg2 = ", and this is the next chunk"
  1643. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1644. io.WriteString(w, msg)
  1645. w.(http.Flusher).Flush()
  1646. io.WriteString(w, msg2)
  1647. return nil
  1648. }, func(st *serverTester) {
  1649. getSlash(st)
  1650. hf := st.wantHeaders()
  1651. if hf.StreamEnded() {
  1652. t.Fatal("unexpected END_STREAM flag")
  1653. }
  1654. if !hf.HeadersEnded() {
  1655. t.Fatal("want END_HEADERS flag")
  1656. }
  1657. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1658. wanth := [][2]string{
  1659. {":status", "200"},
  1660. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1661. // and no content-length
  1662. }
  1663. if !reflect.DeepEqual(goth, wanth) {
  1664. t.Errorf("Got headers %v; want %v", goth, wanth)
  1665. }
  1666. {
  1667. df := st.wantData()
  1668. if df.StreamEnded() {
  1669. t.Error("unexpected END_STREAM flag")
  1670. }
  1671. if got := string(df.Data()); got != msg {
  1672. t.Errorf("got DATA %q; want %q", got, msg)
  1673. }
  1674. }
  1675. {
  1676. df := st.wantData()
  1677. if !df.StreamEnded() {
  1678. t.Error("wanted END_STREAM flag on last data chunk")
  1679. }
  1680. if got := string(df.Data()); got != msg2 {
  1681. t.Errorf("got DATA %q; want %q", got, msg2)
  1682. }
  1683. }
  1684. })
  1685. }
  1686. func TestServer_Response_LargeWrite(t *testing.T) {
  1687. const size = 1 << 20
  1688. const maxFrameSize = 16 << 10
  1689. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1690. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1691. if err != nil {
  1692. return fmt.Errorf("Write error: %v", err)
  1693. }
  1694. if n != size {
  1695. return fmt.Errorf("wrong size %d from Write", n)
  1696. }
  1697. return nil
  1698. }, func(st *serverTester) {
  1699. if err := st.fr.WriteSettings(
  1700. Setting{SettingInitialWindowSize, 0},
  1701. Setting{SettingMaxFrameSize, maxFrameSize},
  1702. ); err != nil {
  1703. t.Fatal(err)
  1704. }
  1705. st.wantSettingsAck()
  1706. getSlash(st) // make the single request
  1707. // Give the handler quota to write:
  1708. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1709. t.Fatal(err)
  1710. }
  1711. // Give the handler quota to write to connection-level
  1712. // window as well
  1713. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1714. t.Fatal(err)
  1715. }
  1716. hf := st.wantHeaders()
  1717. if hf.StreamEnded() {
  1718. t.Fatal("unexpected END_STREAM flag")
  1719. }
  1720. if !hf.HeadersEnded() {
  1721. t.Fatal("want END_HEADERS flag")
  1722. }
  1723. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1724. wanth := [][2]string{
  1725. {":status", "200"},
  1726. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1727. // and no content-length
  1728. }
  1729. if !reflect.DeepEqual(goth, wanth) {
  1730. t.Errorf("Got headers %v; want %v", goth, wanth)
  1731. }
  1732. var bytes, frames int
  1733. for {
  1734. df := st.wantData()
  1735. bytes += len(df.Data())
  1736. frames++
  1737. for _, b := range df.Data() {
  1738. if b != 'a' {
  1739. t.Fatal("non-'a' byte seen in DATA")
  1740. }
  1741. }
  1742. if df.StreamEnded() {
  1743. break
  1744. }
  1745. }
  1746. if bytes != size {
  1747. t.Errorf("Got %d bytes; want %d", bytes, size)
  1748. }
  1749. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1750. t.Errorf("Got %d frames; want %d", frames, size)
  1751. }
  1752. })
  1753. }
  1754. // Test that the handler can't write more than the client allows
  1755. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1756. // Make these reads. Before each read, the client adds exactly enough
  1757. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1758. reads := []int{123, 1, 13, 127}
  1759. size := 0
  1760. for _, n := range reads {
  1761. size += n
  1762. }
  1763. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1764. w.(http.Flusher).Flush()
  1765. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1766. if err != nil {
  1767. return fmt.Errorf("Write error: %v", err)
  1768. }
  1769. if n != size {
  1770. return fmt.Errorf("wrong size %d from Write", n)
  1771. }
  1772. return nil
  1773. }, func(st *serverTester) {
  1774. // Set the window size to something explicit for this test.
  1775. // It's also how much initial data we expect.
  1776. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1777. t.Fatal(err)
  1778. }
  1779. st.wantSettingsAck()
  1780. getSlash(st) // make the single request
  1781. hf := st.wantHeaders()
  1782. if hf.StreamEnded() {
  1783. t.Fatal("unexpected END_STREAM flag")
  1784. }
  1785. if !hf.HeadersEnded() {
  1786. t.Fatal("want END_HEADERS flag")
  1787. }
  1788. df := st.wantData()
  1789. if got := len(df.Data()); got != reads[0] {
  1790. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1791. }
  1792. for _, quota := range reads[1:] {
  1793. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1794. t.Fatal(err)
  1795. }
  1796. df := st.wantData()
  1797. if int(quota) != len(df.Data()) {
  1798. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1799. }
  1800. }
  1801. })
  1802. }
  1803. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1804. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1805. const size = 1 << 20
  1806. const maxFrameSize = 16 << 10
  1807. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1808. w.(http.Flusher).Flush()
  1809. errc := make(chan error, 1)
  1810. go func() {
  1811. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1812. errc <- err
  1813. }()
  1814. select {
  1815. case err := <-errc:
  1816. if err == nil {
  1817. return errors.New("unexpected nil error from Write in handler")
  1818. }
  1819. return nil
  1820. case <-time.After(2 * time.Second):
  1821. return errors.New("timeout waiting for Write in handler")
  1822. }
  1823. }, func(st *serverTester) {
  1824. if err := st.fr.WriteSettings(
  1825. Setting{SettingInitialWindowSize, 0},
  1826. Setting{SettingMaxFrameSize, maxFrameSize},
  1827. ); err != nil {
  1828. t.Fatal(err)
  1829. }
  1830. st.wantSettingsAck()
  1831. getSlash(st) // make the single request
  1832. hf := st.wantHeaders()
  1833. if hf.StreamEnded() {
  1834. t.Fatal("unexpected END_STREAM flag")
  1835. }
  1836. if !hf.HeadersEnded() {
  1837. t.Fatal("want END_HEADERS flag")
  1838. }
  1839. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1840. t.Fatal(err)
  1841. }
  1842. })
  1843. }
  1844. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1845. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1846. w.(http.Flusher).Flush()
  1847. // Nothing; send empty DATA
  1848. return nil
  1849. }, func(st *serverTester) {
  1850. // Handler gets no data quota:
  1851. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1852. t.Fatal(err)
  1853. }
  1854. st.wantSettingsAck()
  1855. getSlash(st) // make the single request
  1856. hf := st.wantHeaders()
  1857. if hf.StreamEnded() {
  1858. t.Fatal("unexpected END_STREAM flag")
  1859. }
  1860. if !hf.HeadersEnded() {
  1861. t.Fatal("want END_HEADERS flag")
  1862. }
  1863. df := st.wantData()
  1864. if got := len(df.Data()); got != 0 {
  1865. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1866. }
  1867. if !df.StreamEnded() {
  1868. t.Fatal("DATA didn't have END_STREAM")
  1869. }
  1870. })
  1871. }
  1872. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1873. const msg = "foo"
  1874. const reply = "bar"
  1875. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1876. if v := r.Header.Get("Expect"); v != "" {
  1877. t.Errorf("Expect header = %q; want empty", v)
  1878. }
  1879. buf := make([]byte, len(msg))
  1880. // This read should trigger the 100-continue being sent.
  1881. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1882. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1883. }
  1884. _, err := io.WriteString(w, reply)
  1885. return err
  1886. }, func(st *serverTester) {
  1887. st.writeHeaders(HeadersFrameParam{
  1888. StreamID: 1, // clients send odd numbers
  1889. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1890. EndStream: false,
  1891. EndHeaders: true,
  1892. })
  1893. hf := st.wantHeaders()
  1894. if hf.StreamEnded() {
  1895. t.Fatal("unexpected END_STREAM flag")
  1896. }
  1897. if !hf.HeadersEnded() {
  1898. t.Fatal("want END_HEADERS flag")
  1899. }
  1900. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1901. wanth := [][2]string{
  1902. {":status", "100"},
  1903. }
  1904. if !reflect.DeepEqual(goth, wanth) {
  1905. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1906. }
  1907. // Okay, they sent status 100, so we can send our
  1908. // gigantic and/or sensitive "foo" payload now.
  1909. st.writeData(1, true, []byte(msg))
  1910. st.wantWindowUpdate(0, uint32(len(msg)))
  1911. hf = st.wantHeaders()
  1912. if hf.StreamEnded() {
  1913. t.Fatal("expected data to follow")
  1914. }
  1915. if !hf.HeadersEnded() {
  1916. t.Fatal("want END_HEADERS flag")
  1917. }
  1918. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1919. wanth = [][2]string{
  1920. {":status", "200"},
  1921. {"content-type", "text/plain; charset=utf-8"},
  1922. {"content-length", strconv.Itoa(len(reply))},
  1923. }
  1924. if !reflect.DeepEqual(goth, wanth) {
  1925. t.Errorf("Got headers %v; want %v", goth, wanth)
  1926. }
  1927. df := st.wantData()
  1928. if string(df.Data()) != reply {
  1929. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1930. }
  1931. if !df.StreamEnded() {
  1932. t.Errorf("expect data stream end")
  1933. }
  1934. })
  1935. }
  1936. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1937. errc := make(chan error, 1)
  1938. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1939. p := []byte("some data.\n")
  1940. for {
  1941. _, err := w.Write(p)
  1942. if err != nil {
  1943. errc <- err
  1944. return nil
  1945. }
  1946. }
  1947. }, func(st *serverTester) {
  1948. st.writeHeaders(HeadersFrameParam{
  1949. StreamID: 1,
  1950. BlockFragment: st.encodeHeader(),
  1951. EndStream: false,
  1952. EndHeaders: true,
  1953. })
  1954. hf := st.wantHeaders()
  1955. if hf.StreamEnded() {
  1956. t.Fatal("unexpected END_STREAM flag")
  1957. }
  1958. if !hf.HeadersEnded() {
  1959. t.Fatal("want END_HEADERS flag")
  1960. }
  1961. // Close the connection and wait for the handler to (hopefully) notice.
  1962. st.cc.Close()
  1963. select {
  1964. case <-errc:
  1965. case <-time.After(5 * time.Second):
  1966. t.Error("timeout")
  1967. }
  1968. })
  1969. }
  1970. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1971. const testPath = "/some/path"
  1972. inHandler := make(chan uint32)
  1973. leaveHandler := make(chan bool)
  1974. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1975. id := w.(*responseWriter).rws.stream.id
  1976. inHandler <- id
  1977. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1978. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1979. }
  1980. <-leaveHandler
  1981. })
  1982. defer st.Close()
  1983. st.greet()
  1984. nextStreamID := uint32(1)
  1985. streamID := func() uint32 {
  1986. defer func() { nextStreamID += 2 }()
  1987. return nextStreamID
  1988. }
  1989. sendReq := func(id uint32, headers ...string) {
  1990. st.writeHeaders(HeadersFrameParam{
  1991. StreamID: id,
  1992. BlockFragment: st.encodeHeader(headers...),
  1993. EndStream: true,
  1994. EndHeaders: true,
  1995. })
  1996. }
  1997. for i := 0; i < defaultMaxStreams; i++ {
  1998. sendReq(streamID())
  1999. <-inHandler
  2000. }
  2001. defer func() {
  2002. for i := 0; i < defaultMaxStreams; i++ {
  2003. leaveHandler <- true
  2004. }
  2005. }()
  2006. // And this one should cross the limit:
  2007. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2008. // even if we're rejecting it)
  2009. rejectID := streamID()
  2010. headerBlock := st.encodeHeader(":path", testPath)
  2011. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2012. st.writeHeaders(HeadersFrameParam{
  2013. StreamID: rejectID,
  2014. BlockFragment: frag1,
  2015. EndStream: true,
  2016. EndHeaders: false, // CONTINUATION coming
  2017. })
  2018. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2019. t.Fatal(err)
  2020. }
  2021. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2022. // But let a handler finish:
  2023. leaveHandler <- true
  2024. st.wantHeaders()
  2025. // And now another stream should be able to start:
  2026. goodID := streamID()
  2027. sendReq(goodID, ":path", testPath)
  2028. select {
  2029. case got := <-inHandler:
  2030. if got != goodID {
  2031. t.Errorf("Got stream %d; want %d", got, goodID)
  2032. }
  2033. case <-time.After(3 * time.Second):
  2034. t.Error("timeout waiting for handler")
  2035. }
  2036. }
  2037. // So many response headers that the server needs to use CONTINUATION frames:
  2038. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2039. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2040. h := w.Header()
  2041. for i := 0; i < 5000; i++ {
  2042. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2043. }
  2044. return nil
  2045. }, func(st *serverTester) {
  2046. getSlash(st)
  2047. hf := st.wantHeaders()
  2048. if hf.HeadersEnded() {
  2049. t.Fatal("got unwanted END_HEADERS flag")
  2050. }
  2051. n := 0
  2052. for {
  2053. n++
  2054. cf := st.wantContinuation()
  2055. if cf.HeadersEnded() {
  2056. break
  2057. }
  2058. }
  2059. if n < 5 {
  2060. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2061. }
  2062. })
  2063. }
  2064. // This previously crashed (reported by Mathieu Lonjaret as observed
  2065. // while using Camlistore) because we got a DATA frame from the client
  2066. // after the handler exited and our logic at the time was wrong,
  2067. // keeping a stream in the map in stateClosed, which tickled an
  2068. // invariant check later when we tried to remove that stream (via
  2069. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2070. // ended.
  2071. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2072. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2073. // nothing
  2074. return nil
  2075. }, func(st *serverTester) {
  2076. st.writeHeaders(HeadersFrameParam{
  2077. StreamID: 1,
  2078. BlockFragment: st.encodeHeader(),
  2079. EndStream: false, // DATA is coming
  2080. EndHeaders: true,
  2081. })
  2082. hf := st.wantHeaders()
  2083. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2084. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2085. }
  2086. // Sent when the a Handler closes while a client has
  2087. // indicated it's still sending DATA:
  2088. st.wantRSTStream(1, ErrCodeCancel)
  2089. // Now the handler has ended, so it's ended its
  2090. // stream, but the client hasn't closed its side
  2091. // (stateClosedLocal). So send more data and verify
  2092. // it doesn't crash with an internal invariant panic, like
  2093. // it did before.
  2094. st.writeData(1, true, []byte("foo"))
  2095. // Get our flow control bytes back, since the handler didn't get them.
  2096. st.wantWindowUpdate(0, uint32(len("foo")))
  2097. // Sent after a peer sends data anyway (admittedly the
  2098. // previous RST_STREAM might've still been in-flight),
  2099. // but they'll get the more friendly 'cancel' code
  2100. // first.
  2101. st.wantRSTStream(1, ErrCodeStreamClosed)
  2102. // Set up a bunch of machinery to record the panic we saw
  2103. // previously.
  2104. var (
  2105. panMu sync.Mutex
  2106. panicVal interface{}
  2107. )
  2108. testHookOnPanicMu.Lock()
  2109. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2110. panMu.Lock()
  2111. panicVal = pv
  2112. panMu.Unlock()
  2113. return true
  2114. }
  2115. testHookOnPanicMu.Unlock()
  2116. // Now force the serve loop to end, via closing the connection.
  2117. st.cc.Close()
  2118. select {
  2119. case <-st.sc.doneServing:
  2120. // Loop has exited.
  2121. panMu.Lock()
  2122. got := panicVal
  2123. panMu.Unlock()
  2124. if got != nil {
  2125. t.Errorf("Got panic: %v", got)
  2126. }
  2127. case <-time.After(5 * time.Second):
  2128. t.Error("timeout")
  2129. }
  2130. })
  2131. }
  2132. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2133. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2134. func testRejectTLS(t *testing.T, max uint16) {
  2135. st := newServerTester(t, nil, func(c *tls.Config) {
  2136. c.MaxVersion = max
  2137. })
  2138. defer st.Close()
  2139. gf := st.wantGoAway()
  2140. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2141. t.Errorf("Got error code %v; want %v", got, want)
  2142. }
  2143. }
  2144. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2145. st := newServerTester(t, nil, func(c *tls.Config) {
  2146. // Only list bad ones:
  2147. c.CipherSuites = []uint16{
  2148. tls.TLS_RSA_WITH_RC4_128_SHA,
  2149. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2150. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2151. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2152. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2153. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2154. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2155. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2156. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2157. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2158. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2159. }
  2160. })
  2161. defer st.Close()
  2162. gf := st.wantGoAway()
  2163. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2164. t.Errorf("Got error code %v; want %v", got, want)
  2165. }
  2166. }
  2167. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2168. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2169. st := newServerTester(t, nil, func(c *tls.Config) {
  2170. // Have the client only support the one required by the spec.
  2171. c.CipherSuites = []uint16{requiredSuite}
  2172. }, func(ts *httptest.Server) {
  2173. var srv *http.Server = ts.Config
  2174. // Have the server configured with no specific cipher suites.
  2175. // This tests that Go's defaults include the required one.
  2176. srv.TLSConfig = nil
  2177. })
  2178. defer st.Close()
  2179. st.greet()
  2180. }
  2181. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2182. if f.Name == "date" {
  2183. return
  2184. }
  2185. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2186. }
  2187. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2188. st.decodedHeaders = nil
  2189. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2190. st.t.Fatalf("hpack decoding error: %v", err)
  2191. }
  2192. if err := st.hpackDec.Close(); err != nil {
  2193. st.t.Fatalf("hpack decoding error: %v", err)
  2194. }
  2195. return st.decodedHeaders
  2196. }
  2197. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2198. // write a single request that must be handled by the handler. This waits up to 5s
  2199. // for client to return, then up to an additional 2s for the handler to return.
  2200. func testServerResponse(t testing.TB,
  2201. handler func(http.ResponseWriter, *http.Request) error,
  2202. client func(*serverTester),
  2203. ) {
  2204. errc := make(chan error, 1)
  2205. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2206. if r.Body == nil {
  2207. t.Fatal("nil Body")
  2208. }
  2209. errc <- handler(w, r)
  2210. })
  2211. defer st.Close()
  2212. donec := make(chan bool)
  2213. go func() {
  2214. defer close(donec)
  2215. st.greet()
  2216. client(st)
  2217. }()
  2218. select {
  2219. case <-donec:
  2220. case <-time.After(5 * time.Second):
  2221. t.Fatal("timeout in client")
  2222. }
  2223. select {
  2224. case err := <-errc:
  2225. if err != nil {
  2226. t.Fatalf("Error in handler: %v", err)
  2227. }
  2228. case <-time.After(2 * time.Second):
  2229. t.Fatal("timeout in handler")
  2230. }
  2231. }
  2232. // readBodyHandler returns an http Handler func that reads len(want)
  2233. // bytes from r.Body and fails t if the contents read were not
  2234. // the value of want.
  2235. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2236. return func(w http.ResponseWriter, r *http.Request) {
  2237. buf := make([]byte, len(want))
  2238. _, err := io.ReadFull(r.Body, buf)
  2239. if err != nil {
  2240. t.Error(err)
  2241. return
  2242. }
  2243. if string(buf) != want {
  2244. t.Errorf("read %q; want %q", buf, want)
  2245. }
  2246. }
  2247. }
  2248. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2249. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2250. // http://sourceforge.net/p/curl/bugs/1472/
  2251. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2252. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2253. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2254. if runtime.GOOS != "linux" {
  2255. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2256. }
  2257. if testing.Short() {
  2258. t.Skip("skipping curl test in short mode")
  2259. }
  2260. requireCurl(t)
  2261. var gotConn int32
  2262. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2263. const msg = "Hello from curl!\n"
  2264. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2265. w.Header().Set("Foo", "Bar")
  2266. w.Header().Set("Client-Proto", r.Proto)
  2267. io.WriteString(w, msg)
  2268. }))
  2269. ConfigureServer(ts.Config, &Server{
  2270. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2271. })
  2272. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2273. ts.StartTLS()
  2274. defer ts.Close()
  2275. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2276. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2277. defer kill(container)
  2278. resc := make(chan interface{}, 1)
  2279. go func() {
  2280. res, err := dockerLogs(container)
  2281. if err != nil {
  2282. resc <- err
  2283. } else {
  2284. resc <- res
  2285. }
  2286. }()
  2287. select {
  2288. case res := <-resc:
  2289. if err, ok := res.(error); ok {
  2290. t.Fatal(err)
  2291. }
  2292. body := string(res.([]byte))
  2293. // Search for both "key: value" and "key:value", since curl changed their format
  2294. // Our Dockerfile contains the latest version (no space), but just in case people
  2295. // didn't rebuild, check both.
  2296. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2297. t.Errorf("didn't see foo: Bar header")
  2298. t.Logf("Got: %s", body)
  2299. }
  2300. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2301. t.Errorf("didn't see client-proto: HTTP/2 header")
  2302. t.Logf("Got: %s", res)
  2303. }
  2304. if !strings.Contains(string(res.([]byte)), msg) {
  2305. t.Errorf("didn't see %q content", msg)
  2306. t.Logf("Got: %s", res)
  2307. }
  2308. case <-time.After(3 * time.Second):
  2309. t.Errorf("timeout waiting for curl")
  2310. }
  2311. if atomic.LoadInt32(&gotConn) == 0 {
  2312. t.Error("never saw an http2 connection")
  2313. }
  2314. }
  2315. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2316. func TestServerWithH2Load(t *testing.T) {
  2317. if !*doh2load {
  2318. t.Skip("Skipping without --h2load flag.")
  2319. }
  2320. if runtime.GOOS != "linux" {
  2321. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2322. }
  2323. requireH2load(t)
  2324. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2325. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2326. io.WriteString(w, msg)
  2327. w.(http.Flusher).Flush()
  2328. io.WriteString(w, msg)
  2329. }))
  2330. ts.StartTLS()
  2331. defer ts.Close()
  2332. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2333. "-n100000", "-c100", "-m100", ts.URL)
  2334. cmd.Stdout = os.Stdout
  2335. cmd.Stderr = os.Stderr
  2336. if err := cmd.Run(); err != nil {
  2337. t.Fatal(err)
  2338. }
  2339. }
  2340. // Issue 12843
  2341. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2342. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2343. defer st.Close()
  2344. // shake hands
  2345. st.writePreface()
  2346. st.writeInitialSettings()
  2347. frameSize := defaultMaxReadFrameSize
  2348. var advHeaderListSize *uint32
  2349. st.wantSettings().ForeachSetting(func(s Setting) error {
  2350. switch s.ID {
  2351. case SettingMaxFrameSize:
  2352. if s.Val < minMaxFrameSize {
  2353. frameSize = minMaxFrameSize
  2354. } else if s.Val > maxFrameSize {
  2355. frameSize = maxFrameSize
  2356. } else {
  2357. frameSize = int(s.Val)
  2358. }
  2359. case SettingMaxHeaderListSize:
  2360. advHeaderListSize = &s.Val
  2361. }
  2362. return nil
  2363. })
  2364. st.writeSettingsAck()
  2365. st.wantSettingsAck()
  2366. if advHeaderListSize == nil {
  2367. t.Errorf("server didn't advertise a max header list size")
  2368. } else if *advHeaderListSize == 0 {
  2369. t.Errorf("server advertised a max header list size of 0")
  2370. }
  2371. st.encodeHeaderField(":method", "GET")
  2372. st.encodeHeaderField(":path", "/")
  2373. st.encodeHeaderField(":scheme", "https")
  2374. cookie := strings.Repeat("*", 4058)
  2375. st.encodeHeaderField("cookie", cookie)
  2376. st.writeHeaders(HeadersFrameParam{
  2377. StreamID: 1,
  2378. BlockFragment: st.headerBuf.Bytes(),
  2379. EndStream: true,
  2380. EndHeaders: false,
  2381. })
  2382. // Capture the short encoding of a duplicate ~4K cookie, now
  2383. // that we've already sent it once.
  2384. st.headerBuf.Reset()
  2385. st.encodeHeaderField("cookie", cookie)
  2386. // Now send 1MB of it.
  2387. const size = 1 << 20
  2388. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2389. for len(b) > 0 {
  2390. chunk := b
  2391. if len(chunk) > frameSize {
  2392. chunk = chunk[:frameSize]
  2393. }
  2394. b = b[len(chunk):]
  2395. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2396. }
  2397. h := st.wantHeaders()
  2398. if !h.HeadersEnded() {
  2399. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2400. }
  2401. headers := st.decodeHeader(h.HeaderBlockFragment())
  2402. want := [][2]string{
  2403. {":status", "431"},
  2404. {"content-type", "text/html; charset=utf-8"},
  2405. {"content-length", "63"},
  2406. }
  2407. if !reflect.DeepEqual(headers, want) {
  2408. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2409. }
  2410. }
  2411. func TestCompressionErrorOnWrite(t *testing.T) {
  2412. const maxStrLen = 8 << 10
  2413. var serverConfig *http.Server
  2414. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2415. // No response body.
  2416. }, func(ts *httptest.Server) {
  2417. serverConfig = ts.Config
  2418. serverConfig.MaxHeaderBytes = maxStrLen
  2419. })
  2420. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2421. defer st.Close()
  2422. st.greet()
  2423. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2424. // Crank this up, now that we have a conn connected with the
  2425. // hpack.Decoder's max string length set has been initialized
  2426. // from the earlier low ~8K value. We want this higher so don't
  2427. // hit the max header list size. We only want to test hitting
  2428. // the max string size.
  2429. serverConfig.MaxHeaderBytes = 1 << 20
  2430. // First a request with a header that's exactly the max allowed size
  2431. // for the hpack compression. It's still too long for the header list
  2432. // size, so we'll get the 431 error, but that keeps the compression
  2433. // context still valid.
  2434. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2435. st.writeHeaders(HeadersFrameParam{
  2436. StreamID: 1,
  2437. BlockFragment: hbf,
  2438. EndStream: true,
  2439. EndHeaders: true,
  2440. })
  2441. h := st.wantHeaders()
  2442. if !h.HeadersEnded() {
  2443. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2444. }
  2445. headers := st.decodeHeader(h.HeaderBlockFragment())
  2446. want := [][2]string{
  2447. {":status", "431"},
  2448. {"content-type", "text/html; charset=utf-8"},
  2449. {"content-length", "63"},
  2450. }
  2451. if !reflect.DeepEqual(headers, want) {
  2452. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2453. }
  2454. df := st.wantData()
  2455. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2456. t.Errorf("Unexpected data body: %q", df.Data())
  2457. }
  2458. if !df.StreamEnded() {
  2459. t.Fatalf("expect data stream end")
  2460. }
  2461. // And now send one that's just one byte too big.
  2462. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2463. st.writeHeaders(HeadersFrameParam{
  2464. StreamID: 3,
  2465. BlockFragment: hbf,
  2466. EndStream: true,
  2467. EndHeaders: true,
  2468. })
  2469. ga := st.wantGoAway()
  2470. if ga.ErrCode != ErrCodeCompression {
  2471. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2472. }
  2473. }
  2474. func TestCompressionErrorOnClose(t *testing.T) {
  2475. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2476. // No response body.
  2477. })
  2478. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2479. defer st.Close()
  2480. st.greet()
  2481. hbf := st.encodeHeader("foo", "bar")
  2482. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2483. st.writeHeaders(HeadersFrameParam{
  2484. StreamID: 1,
  2485. BlockFragment: hbf,
  2486. EndStream: true,
  2487. EndHeaders: true,
  2488. })
  2489. ga := st.wantGoAway()
  2490. if ga.ErrCode != ErrCodeCompression {
  2491. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2492. }
  2493. }
  2494. // test that a server handler can read trailers from a client
  2495. func TestServerReadsTrailers(t *testing.T) {
  2496. const testBody = "some test body"
  2497. writeReq := func(st *serverTester) {
  2498. st.writeHeaders(HeadersFrameParam{
  2499. StreamID: 1, // clients send odd numbers
  2500. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2501. EndStream: false,
  2502. EndHeaders: true,
  2503. })
  2504. st.writeData(1, false, []byte(testBody))
  2505. st.writeHeaders(HeadersFrameParam{
  2506. StreamID: 1, // clients send odd numbers
  2507. BlockFragment: st.encodeHeaderRaw(
  2508. "foo", "foov",
  2509. "bar", "barv",
  2510. "baz", "bazv",
  2511. "surprise", "wasn't declared; shouldn't show up",
  2512. ),
  2513. EndStream: true,
  2514. EndHeaders: true,
  2515. })
  2516. }
  2517. checkReq := func(r *http.Request) {
  2518. wantTrailer := http.Header{
  2519. "Foo": nil,
  2520. "Bar": nil,
  2521. "Baz": nil,
  2522. }
  2523. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2524. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2525. }
  2526. slurp, err := ioutil.ReadAll(r.Body)
  2527. if string(slurp) != testBody {
  2528. t.Errorf("read body %q; want %q", slurp, testBody)
  2529. }
  2530. if err != nil {
  2531. t.Fatalf("Body slurp: %v", err)
  2532. }
  2533. wantTrailerAfter := http.Header{
  2534. "Foo": {"foov"},
  2535. "Bar": {"barv"},
  2536. "Baz": {"bazv"},
  2537. }
  2538. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2539. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2540. }
  2541. }
  2542. testServerRequest(t, writeReq, checkReq)
  2543. }
  2544. // test that a server handler can send trailers
  2545. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2546. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2547. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2548. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2549. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2550. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2551. w.Header().Add("Trailer", "Server-Trailer-C")
  2552. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2553. // Regular headers:
  2554. w.Header().Set("Foo", "Bar")
  2555. w.Header().Set("Content-Length", "5") // len("Hello")
  2556. io.WriteString(w, "Hello")
  2557. if withFlush {
  2558. w.(http.Flusher).Flush()
  2559. }
  2560. w.Header().Set("Server-Trailer-A", "valuea")
  2561. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2562. // After a flush, random keys like Server-Surprise shouldn't show up:
  2563. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2564. // But we do permit promoting keys to trailers after a
  2565. // flush if they start with the magic
  2566. // otherwise-invalid "Trailer:" prefix:
  2567. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2568. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2569. w.Header().Set("Trailer:Range", "invalid")
  2570. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2571. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2572. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2573. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2574. return nil
  2575. }, func(st *serverTester) {
  2576. getSlash(st)
  2577. hf := st.wantHeaders()
  2578. if hf.StreamEnded() {
  2579. t.Fatal("response HEADERS had END_STREAM")
  2580. }
  2581. if !hf.HeadersEnded() {
  2582. t.Fatal("response HEADERS didn't have END_HEADERS")
  2583. }
  2584. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2585. wanth := [][2]string{
  2586. {":status", "200"},
  2587. {"foo", "Bar"},
  2588. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2589. {"trailer", "Server-Trailer-C"},
  2590. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2591. {"content-type", "text/plain; charset=utf-8"},
  2592. {"content-length", "5"},
  2593. }
  2594. if !reflect.DeepEqual(goth, wanth) {
  2595. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2596. }
  2597. df := st.wantData()
  2598. if string(df.Data()) != "Hello" {
  2599. t.Fatalf("Client read %q; want Hello", df.Data())
  2600. }
  2601. if df.StreamEnded() {
  2602. t.Fatalf("data frame had STREAM_ENDED")
  2603. }
  2604. tf := st.wantHeaders() // for the trailers
  2605. if !tf.StreamEnded() {
  2606. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2607. }
  2608. if !tf.HeadersEnded() {
  2609. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2610. }
  2611. wanth = [][2]string{
  2612. {"post-header-trailer", "hi1"},
  2613. {"post-header-trailer2", "hi2"},
  2614. {"server-trailer-a", "valuea"},
  2615. {"server-trailer-c", "valuec"},
  2616. }
  2617. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2618. if !reflect.DeepEqual(goth, wanth) {
  2619. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2620. }
  2621. })
  2622. }
  2623. // validate transmitted header field names & values
  2624. // golang.org/issue/14048
  2625. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2626. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2627. w.Header().Add("OK1", "x")
  2628. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2629. w.Header().Add("Bad1\x00", "x") // null in key
  2630. w.Header().Add("Bad2", "x\x00y") // null in value
  2631. return nil
  2632. }, func(st *serverTester) {
  2633. getSlash(st)
  2634. hf := st.wantHeaders()
  2635. if !hf.StreamEnded() {
  2636. t.Error("response HEADERS lacked END_STREAM")
  2637. }
  2638. if !hf.HeadersEnded() {
  2639. t.Fatal("response HEADERS didn't have END_HEADERS")
  2640. }
  2641. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2642. wanth := [][2]string{
  2643. {":status", "200"},
  2644. {"ok1", "x"},
  2645. {"content-type", "text/plain; charset=utf-8"},
  2646. {"content-length", "0"},
  2647. }
  2648. if !reflect.DeepEqual(goth, wanth) {
  2649. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2650. }
  2651. })
  2652. }
  2653. func BenchmarkServerGets(b *testing.B) {
  2654. defer disableGoroutineTracking()()
  2655. b.ReportAllocs()
  2656. const msg = "Hello, world"
  2657. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2658. io.WriteString(w, msg)
  2659. })
  2660. defer st.Close()
  2661. st.greet()
  2662. // Give the server quota to reply. (plus it has the the 64KB)
  2663. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2664. b.Fatal(err)
  2665. }
  2666. for i := 0; i < b.N; i++ {
  2667. id := 1 + uint32(i)*2
  2668. st.writeHeaders(HeadersFrameParam{
  2669. StreamID: id,
  2670. BlockFragment: st.encodeHeader(),
  2671. EndStream: true,
  2672. EndHeaders: true,
  2673. })
  2674. st.wantHeaders()
  2675. df := st.wantData()
  2676. if !df.StreamEnded() {
  2677. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2678. }
  2679. }
  2680. }
  2681. func BenchmarkServerPosts(b *testing.B) {
  2682. defer disableGoroutineTracking()()
  2683. b.ReportAllocs()
  2684. const msg = "Hello, world"
  2685. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2686. // Consume the (empty) body from th peer before replying, otherwise
  2687. // the server will sometimes (depending on scheduling) send the peer a
  2688. // a RST_STREAM with the CANCEL error code.
  2689. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2690. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2691. }
  2692. io.WriteString(w, msg)
  2693. })
  2694. defer st.Close()
  2695. st.greet()
  2696. // Give the server quota to reply. (plus it has the the 64KB)
  2697. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2698. b.Fatal(err)
  2699. }
  2700. for i := 0; i < b.N; i++ {
  2701. id := 1 + uint32(i)*2
  2702. st.writeHeaders(HeadersFrameParam{
  2703. StreamID: id,
  2704. BlockFragment: st.encodeHeader(":method", "POST"),
  2705. EndStream: false,
  2706. EndHeaders: true,
  2707. })
  2708. st.writeData(id, true, nil)
  2709. st.wantHeaders()
  2710. df := st.wantData()
  2711. if !df.StreamEnded() {
  2712. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2713. }
  2714. }
  2715. }
  2716. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2717. // Verify we don't hang.
  2718. func TestIssue53(t *testing.T) {
  2719. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2720. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2721. s := &http.Server{
  2722. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2723. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2724. w.Write([]byte("hello"))
  2725. }),
  2726. }
  2727. s2 := &Server{
  2728. MaxReadFrameSize: 1 << 16,
  2729. PermitProhibitedCipherSuites: true,
  2730. }
  2731. c := &issue53Conn{[]byte(data), false, false}
  2732. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2733. if !c.closed {
  2734. t.Fatal("connection is not closed")
  2735. }
  2736. }
  2737. type issue53Conn struct {
  2738. data []byte
  2739. closed bool
  2740. written bool
  2741. }
  2742. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2743. if len(c.data) == 0 {
  2744. return 0, io.EOF
  2745. }
  2746. n = copy(b, c.data)
  2747. c.data = c.data[n:]
  2748. return
  2749. }
  2750. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2751. c.written = true
  2752. return len(b), nil
  2753. }
  2754. func (c *issue53Conn) Close() error {
  2755. c.closed = true
  2756. return nil
  2757. }
  2758. func (c *issue53Conn) LocalAddr() net.Addr {
  2759. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2760. }
  2761. func (c *issue53Conn) RemoteAddr() net.Addr {
  2762. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2763. }
  2764. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2765. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2766. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2767. // golang.org/issue/12895
  2768. func TestConfigureServer(t *testing.T) {
  2769. tests := []struct {
  2770. name string
  2771. tlsConfig *tls.Config
  2772. wantErr string
  2773. }{
  2774. {
  2775. name: "empty server",
  2776. },
  2777. {
  2778. name: "just the required cipher suite",
  2779. tlsConfig: &tls.Config{
  2780. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2781. },
  2782. },
  2783. {
  2784. name: "missing required cipher suite",
  2785. tlsConfig: &tls.Config{
  2786. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2787. },
  2788. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2789. },
  2790. {
  2791. name: "required after bad",
  2792. tlsConfig: &tls.Config{
  2793. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2794. },
  2795. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2796. },
  2797. {
  2798. name: "bad after required",
  2799. tlsConfig: &tls.Config{
  2800. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2801. },
  2802. },
  2803. }
  2804. for _, tt := range tests {
  2805. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2806. err := ConfigureServer(srv, nil)
  2807. if (err != nil) != (tt.wantErr != "") {
  2808. if tt.wantErr != "" {
  2809. t.Errorf("%s: success, but want error", tt.name)
  2810. } else {
  2811. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2812. }
  2813. }
  2814. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2815. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2816. }
  2817. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2818. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2819. }
  2820. }
  2821. }
  2822. func TestServerRejectHeadWithBody(t *testing.T) {
  2823. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2824. // No response body.
  2825. })
  2826. defer st.Close()
  2827. st.greet()
  2828. st.writeHeaders(HeadersFrameParam{
  2829. StreamID: 1, // clients send odd numbers
  2830. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2831. EndStream: false, // what we're testing, a bogus HEAD request with body
  2832. EndHeaders: true,
  2833. })
  2834. st.wantRSTStream(1, ErrCodeProtocol)
  2835. }
  2836. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2837. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2838. // No response body. (or smaller than one frame)
  2839. })
  2840. defer st.Close()
  2841. st.greet()
  2842. st.writeHeaders(HeadersFrameParam{
  2843. StreamID: 1, // clients send odd numbers
  2844. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2845. EndStream: true,
  2846. EndHeaders: true,
  2847. })
  2848. h := st.wantHeaders()
  2849. headers := st.decodeHeader(h.HeaderBlockFragment())
  2850. want := [][2]string{
  2851. {":status", "200"},
  2852. {"content-type", "text/plain; charset=utf-8"},
  2853. }
  2854. if !reflect.DeepEqual(headers, want) {
  2855. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2856. }
  2857. }
  2858. // golang.org/issue/13495
  2859. func TestServerNoDuplicateContentType(t *testing.T) {
  2860. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2861. w.Header()["Content-Type"] = []string{""}
  2862. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2863. })
  2864. defer st.Close()
  2865. st.greet()
  2866. st.writeHeaders(HeadersFrameParam{
  2867. StreamID: 1,
  2868. BlockFragment: st.encodeHeader(),
  2869. EndStream: true,
  2870. EndHeaders: true,
  2871. })
  2872. h := st.wantHeaders()
  2873. headers := st.decodeHeader(h.HeaderBlockFragment())
  2874. want := [][2]string{
  2875. {":status", "200"},
  2876. {"content-type", ""},
  2877. {"content-length", "41"},
  2878. }
  2879. if !reflect.DeepEqual(headers, want) {
  2880. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2881. }
  2882. }
  2883. func disableGoroutineTracking() (restore func()) {
  2884. old := DebugGoroutines
  2885. DebugGoroutines = false
  2886. return func() { DebugGoroutines = old }
  2887. }
  2888. func BenchmarkServer_GetRequest(b *testing.B) {
  2889. defer disableGoroutineTracking()()
  2890. b.ReportAllocs()
  2891. const msg = "Hello, world."
  2892. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2893. n, err := io.Copy(ioutil.Discard, r.Body)
  2894. if err != nil || n > 0 {
  2895. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2896. }
  2897. io.WriteString(w, msg)
  2898. })
  2899. defer st.Close()
  2900. st.greet()
  2901. // Give the server quota to reply. (plus it has the the 64KB)
  2902. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2903. b.Fatal(err)
  2904. }
  2905. hbf := st.encodeHeader(":method", "GET")
  2906. for i := 0; i < b.N; i++ {
  2907. streamID := uint32(1 + 2*i)
  2908. st.writeHeaders(HeadersFrameParam{
  2909. StreamID: streamID,
  2910. BlockFragment: hbf,
  2911. EndStream: true,
  2912. EndHeaders: true,
  2913. })
  2914. st.wantHeaders()
  2915. st.wantData()
  2916. }
  2917. }
  2918. func BenchmarkServer_PostRequest(b *testing.B) {
  2919. defer disableGoroutineTracking()()
  2920. b.ReportAllocs()
  2921. const msg = "Hello, world."
  2922. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2923. n, err := io.Copy(ioutil.Discard, r.Body)
  2924. if err != nil || n > 0 {
  2925. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2926. }
  2927. io.WriteString(w, msg)
  2928. })
  2929. defer st.Close()
  2930. st.greet()
  2931. // Give the server quota to reply. (plus it has the the 64KB)
  2932. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2933. b.Fatal(err)
  2934. }
  2935. hbf := st.encodeHeader(":method", "POST")
  2936. for i := 0; i < b.N; i++ {
  2937. streamID := uint32(1 + 2*i)
  2938. st.writeHeaders(HeadersFrameParam{
  2939. StreamID: streamID,
  2940. BlockFragment: hbf,
  2941. EndStream: false,
  2942. EndHeaders: true,
  2943. })
  2944. st.writeData(streamID, true, nil)
  2945. st.wantHeaders()
  2946. st.wantData()
  2947. }
  2948. }
  2949. type connStateConn struct {
  2950. net.Conn
  2951. cs tls.ConnectionState
  2952. }
  2953. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  2954. // golang.org/issue/12737 -- handle any net.Conn, not just
  2955. // *tls.Conn.
  2956. func TestServerHandleCustomConn(t *testing.T) {
  2957. var s Server
  2958. c1, c2 := net.Pipe()
  2959. clientDone := make(chan struct{})
  2960. handlerDone := make(chan struct{})
  2961. var req *http.Request
  2962. go func() {
  2963. defer close(clientDone)
  2964. defer c2.Close()
  2965. fr := NewFramer(c2, c2)
  2966. io.WriteString(c2, ClientPreface)
  2967. fr.WriteSettings()
  2968. fr.WriteSettingsAck()
  2969. f, err := fr.ReadFrame()
  2970. if err != nil {
  2971. t.Error(err)
  2972. return
  2973. }
  2974. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  2975. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  2976. return
  2977. }
  2978. f, err = fr.ReadFrame()
  2979. if err != nil {
  2980. t.Error(err)
  2981. return
  2982. }
  2983. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  2984. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  2985. return
  2986. }
  2987. var henc hpackEncoder
  2988. fr.WriteHeaders(HeadersFrameParam{
  2989. StreamID: 1,
  2990. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  2991. EndStream: true,
  2992. EndHeaders: true,
  2993. })
  2994. go io.Copy(ioutil.Discard, c2)
  2995. <-handlerDone
  2996. }()
  2997. const testString = "my custom ConnectionState"
  2998. fakeConnState := tls.ConnectionState{
  2999. ServerName: testString,
  3000. Version: tls.VersionTLS12,
  3001. }
  3002. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3003. BaseConfig: &http.Server{
  3004. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3005. defer close(handlerDone)
  3006. req = r
  3007. }),
  3008. }})
  3009. select {
  3010. case <-clientDone:
  3011. case <-time.After(5 * time.Second):
  3012. t.Fatal("timeout waiting for handler")
  3013. }
  3014. if req.TLS == nil {
  3015. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3016. }
  3017. if req.TLS.ServerName != testString {
  3018. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3019. }
  3020. }
  3021. // golang.org/issue/14214
  3022. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3023. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3024. t.Error("should not get to Handler")
  3025. })
  3026. defer st.Close()
  3027. st.greet()
  3028. st.bodylessReq1("connection", "foo")
  3029. hf := st.wantHeaders()
  3030. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3031. wanth := [][2]string{
  3032. {":status", "400"},
  3033. {"content-type", "text/plain; charset=utf-8"},
  3034. {"x-content-type-options", "nosniff"},
  3035. {"content-length", "51"},
  3036. }
  3037. if !reflect.DeepEqual(goth, wanth) {
  3038. t.Errorf("Got headers %v; want %v", goth, wanth)
  3039. }
  3040. }
  3041. type hpackEncoder struct {
  3042. enc *hpack.Encoder
  3043. buf bytes.Buffer
  3044. }
  3045. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3046. if len(headers)%2 == 1 {
  3047. panic("odd number of kv args")
  3048. }
  3049. he.buf.Reset()
  3050. if he.enc == nil {
  3051. he.enc = hpack.NewEncoder(&he.buf)
  3052. }
  3053. for len(headers) > 0 {
  3054. k, v := headers[0], headers[1]
  3055. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3056. if err != nil {
  3057. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3058. }
  3059. headers = headers[2:]
  3060. }
  3061. return he.buf.Bytes()
  3062. }
  3063. func TestCheckValidHTTP2Request(t *testing.T) {
  3064. tests := []struct {
  3065. h http.Header
  3066. want error
  3067. }{
  3068. {
  3069. h: http.Header{"Te": {"trailers"}},
  3070. want: nil,
  3071. },
  3072. {
  3073. h: http.Header{"Te": {"trailers", "bogus"}},
  3074. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3075. },
  3076. {
  3077. h: http.Header{"Foo": {""}},
  3078. want: nil,
  3079. },
  3080. {
  3081. h: http.Header{"Connection": {""}},
  3082. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3083. },
  3084. {
  3085. h: http.Header{"Proxy-Connection": {""}},
  3086. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3087. },
  3088. {
  3089. h: http.Header{"Keep-Alive": {""}},
  3090. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3091. },
  3092. {
  3093. h: http.Header{"Upgrade": {""}},
  3094. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3095. },
  3096. }
  3097. for i, tt := range tests {
  3098. got := checkValidHTTP2RequestHeaders(tt.h)
  3099. if !reflect.DeepEqual(got, tt.want) {
  3100. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3101. }
  3102. }
  3103. }
  3104. // golang.org/issue/14030
  3105. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3106. const msg = "Hello"
  3107. const msg2 = "World"
  3108. doRead := make(chan bool, 1)
  3109. defer close(doRead) // fallback cleanup
  3110. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3111. io.WriteString(w, msg)
  3112. w.(http.Flusher).Flush()
  3113. // Do a read, which might force a 100-continue status to be sent.
  3114. <-doRead
  3115. r.Body.Read(make([]byte, 10))
  3116. io.WriteString(w, msg2)
  3117. }, optOnlyServer)
  3118. defer st.Close()
  3119. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3120. defer tr.CloseIdleConnections()
  3121. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3122. req.Header.Set("Expect", "100-continue")
  3123. res, err := tr.RoundTrip(req)
  3124. if err != nil {
  3125. t.Fatal(err)
  3126. }
  3127. defer res.Body.Close()
  3128. buf := make([]byte, len(msg))
  3129. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3130. t.Fatal(err)
  3131. }
  3132. if string(buf) != msg {
  3133. t.Fatalf("msg = %q; want %q", buf, msg)
  3134. }
  3135. doRead <- true
  3136. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3137. t.Fatal(err)
  3138. }
  3139. if string(buf) != msg2 {
  3140. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3141. }
  3142. }
  3143. type funcReader func([]byte) (n int, err error)
  3144. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3145. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3146. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3147. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3148. unblock := make(chan bool, 1)
  3149. defer close(unblock)
  3150. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3151. // Don't read the 16KB request body. Wait until the client's
  3152. // done sending it and then return. This should cause the Server
  3153. // to then return those 16KB of flow control to the client.
  3154. <-unblock
  3155. }, optOnlyServer)
  3156. defer st.Close()
  3157. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3158. defer tr.CloseIdleConnections()
  3159. // This previously hung on the 4th iteration.
  3160. for i := 0; i < 6; i++ {
  3161. body := io.MultiReader(
  3162. io.LimitReader(neverEnding('A'), 16<<10),
  3163. funcReader(func([]byte) (n int, err error) {
  3164. unblock <- true
  3165. return 0, io.EOF
  3166. }),
  3167. )
  3168. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3169. res, err := tr.RoundTrip(req)
  3170. if err != nil {
  3171. t.Fatal(err)
  3172. }
  3173. res.Body.Close()
  3174. }
  3175. }
  3176. func TestServerIdleTimeout(t *testing.T) {
  3177. if testing.Short() {
  3178. t.Skip("skipping in short mode")
  3179. }
  3180. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3181. }, func(h2s *Server) {
  3182. h2s.IdleTimeout = 500 * time.Millisecond
  3183. })
  3184. defer st.Close()
  3185. st.greet()
  3186. ga := st.wantGoAway()
  3187. if ga.ErrCode != ErrCodeNo {
  3188. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3189. }
  3190. }
  3191. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3192. if testing.Short() {
  3193. t.Skip("skipping in short mode")
  3194. }
  3195. const timeout = 250 * time.Millisecond
  3196. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3197. time.Sleep(timeout * 2)
  3198. }, func(h2s *Server) {
  3199. h2s.IdleTimeout = timeout
  3200. })
  3201. defer st.Close()
  3202. st.greet()
  3203. // Send a request which takes twice the timeout. Verifies the
  3204. // idle timeout doesn't fire while we're in a request:
  3205. st.bodylessReq1()
  3206. st.wantHeaders()
  3207. // But the idle timeout should be rearmed after the request
  3208. // is done:
  3209. ga := st.wantGoAway()
  3210. if ga.ErrCode != ErrCodeNo {
  3211. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3212. }
  3213. }
  3214. // grpc-go closes the Request.Body currently with a Read.
  3215. // Verify that it doesn't race.
  3216. // See https://github.com/grpc/grpc-go/pull/938
  3217. func TestRequestBodyReadCloseRace(t *testing.T) {
  3218. for i := 0; i < 100; i++ {
  3219. body := &requestBody{
  3220. pipe: &pipe{
  3221. b: new(bytes.Buffer),
  3222. },
  3223. }
  3224. body.pipe.CloseWithError(io.EOF)
  3225. done := make(chan bool, 1)
  3226. buf := make([]byte, 10)
  3227. go func() {
  3228. time.Sleep(1 * time.Millisecond)
  3229. body.Close()
  3230. done <- true
  3231. }()
  3232. body.Read(buf)
  3233. <-done
  3234. }
  3235. }
  3236. func TestServerGracefulShutdown(t *testing.T) {
  3237. shutdownCh := make(chan struct{})
  3238. defer func() { h1ServerShutdownChan = nil }()
  3239. h1ServerShutdownChan = func(*http.Server) <-chan struct{} { return shutdownCh }
  3240. var st *serverTester
  3241. handlerDone := make(chan struct{})
  3242. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3243. defer close(handlerDone)
  3244. close(shutdownCh)
  3245. ga := st.wantGoAway()
  3246. if ga.ErrCode != ErrCodeNo {
  3247. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3248. }
  3249. if ga.LastStreamID != 1 {
  3250. t.Errorf("GOAWAY LastStreamID = %v; want 1", ga.LastStreamID)
  3251. }
  3252. w.Header().Set("x-foo", "bar")
  3253. })
  3254. defer st.Close()
  3255. st.greet()
  3256. st.bodylessReq1()
  3257. <-handlerDone
  3258. hf := st.wantHeaders()
  3259. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3260. wanth := [][2]string{
  3261. {":status", "200"},
  3262. {"x-foo", "bar"},
  3263. {"content-type", "text/plain; charset=utf-8"},
  3264. {"content-length", "0"},
  3265. }
  3266. if !reflect.DeepEqual(goth, wanth) {
  3267. t.Errorf("Got headers %v; want %v", goth, wanth)
  3268. }
  3269. n, err := st.cc.Read([]byte{0})
  3270. if n != 0 || err == nil {
  3271. t.Errorf("Read = %v, %v; want 0, non-nil", n, err)
  3272. }
  3273. }