server_test.go 96 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. logBuf *bytes.Buffer
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // writing headers:
  48. headerBuf bytes.Buffer
  49. hpackEnc *hpack.Encoder
  50. }
  51. func init() {
  52. testHookOnPanicMu = new(sync.Mutex)
  53. }
  54. func resetHooks() {
  55. testHookOnPanicMu.Lock()
  56. testHookOnPanic = nil
  57. testHookOnPanicMu.Unlock()
  58. }
  59. type serverTesterOpt string
  60. var optOnlyServer = serverTesterOpt("only_server")
  61. var optQuiet = serverTesterOpt("quiet_logging")
  62. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  63. resetHooks()
  64. logBuf := new(bytes.Buffer)
  65. ts := httptest.NewUnstartedServer(handler)
  66. tlsConfig := &tls.Config{
  67. InsecureSkipVerify: true,
  68. // The h2-14 is temporary, until curl is updated. (as used by unit tests
  69. // in Docker)
  70. NextProtos: []string{NextProtoTLS, "h2-14"},
  71. }
  72. var onlyServer, quiet bool
  73. h2server := new(Server)
  74. for _, opt := range opts {
  75. switch v := opt.(type) {
  76. case func(*tls.Config):
  77. v(tlsConfig)
  78. case func(*httptest.Server):
  79. v(ts)
  80. case func(*Server):
  81. v(h2server)
  82. case serverTesterOpt:
  83. switch v {
  84. case optOnlyServer:
  85. onlyServer = true
  86. case optQuiet:
  87. quiet = true
  88. }
  89. case func(net.Conn, http.ConnState):
  90. ts.Config.ConnState = v
  91. default:
  92. t.Fatalf("unknown newServerTester option type %T", v)
  93. }
  94. }
  95. ConfigureServer(ts.Config, h2server)
  96. st := &serverTester{
  97. t: t,
  98. ts: ts,
  99. logBuf: logBuf,
  100. }
  101. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  102. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  103. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  104. if quiet {
  105. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  106. } else {
  107. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  108. }
  109. ts.StartTLS()
  110. if VerboseLogs {
  111. t.Logf("Running test server at: %s", ts.URL)
  112. }
  113. testHookGetServerConn = func(v *serverConn) {
  114. st.scMu.Lock()
  115. defer st.scMu.Unlock()
  116. st.sc = v
  117. st.sc.testHookCh = make(chan func(int))
  118. }
  119. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  120. if !onlyServer {
  121. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  122. if err != nil {
  123. t.Fatal(err)
  124. }
  125. st.cc = cc
  126. st.fr = NewFramer(cc, cc)
  127. }
  128. return st
  129. }
  130. func (st *serverTester) closeConn() {
  131. st.scMu.Lock()
  132. defer st.scMu.Unlock()
  133. st.sc.conn.Close()
  134. }
  135. func (st *serverTester) addLogFilter(phrase string) {
  136. st.logFilter = append(st.logFilter, phrase)
  137. }
  138. func (st *serverTester) stream(id uint32) *stream {
  139. ch := make(chan *stream, 1)
  140. st.sc.testHookCh <- func(int) {
  141. ch <- st.sc.streams[id]
  142. }
  143. return <-ch
  144. }
  145. func (st *serverTester) streamState(id uint32) streamState {
  146. ch := make(chan streamState, 1)
  147. st.sc.testHookCh <- func(int) {
  148. state, _ := st.sc.state(id)
  149. ch <- state
  150. }
  151. return <-ch
  152. }
  153. // loopNum reports how many times this conn's select loop has gone around.
  154. func (st *serverTester) loopNum() int {
  155. lastc := make(chan int, 1)
  156. st.sc.testHookCh <- func(loopNum int) {
  157. lastc <- loopNum
  158. }
  159. return <-lastc
  160. }
  161. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  162. // The heuristic is that the server connection's serve loop must schedule
  163. // 50 times in a row without any channel sends or receives occurring.
  164. func (st *serverTester) awaitIdle() {
  165. remain := 50
  166. last := st.loopNum()
  167. for remain > 0 {
  168. n := st.loopNum()
  169. if n == last+1 {
  170. remain--
  171. } else {
  172. remain = 50
  173. }
  174. last = n
  175. }
  176. }
  177. func (st *serverTester) Close() {
  178. if st.t.Failed() {
  179. // If we failed already (and are likely in a Fatal,
  180. // unwindowing), force close the connection, so the
  181. // httptest.Server doesn't wait forever for the conn
  182. // to close.
  183. if st.cc != nil {
  184. st.cc.Close()
  185. }
  186. }
  187. st.ts.Close()
  188. if st.cc != nil {
  189. st.cc.Close()
  190. }
  191. log.SetOutput(os.Stderr)
  192. }
  193. // greet initiates the client's HTTP/2 connection into a state where
  194. // frames may be sent.
  195. func (st *serverTester) greet() {
  196. st.writePreface()
  197. st.writeInitialSettings()
  198. st.wantSettings()
  199. st.writeSettingsAck()
  200. st.wantSettingsAck()
  201. }
  202. func (st *serverTester) writePreface() {
  203. n, err := st.cc.Write(clientPreface)
  204. if err != nil {
  205. st.t.Fatalf("Error writing client preface: %v", err)
  206. }
  207. if n != len(clientPreface) {
  208. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  209. }
  210. }
  211. func (st *serverTester) writeInitialSettings() {
  212. if err := st.fr.WriteSettings(); err != nil {
  213. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  214. }
  215. }
  216. func (st *serverTester) writeSettingsAck() {
  217. if err := st.fr.WriteSettingsAck(); err != nil {
  218. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  219. }
  220. }
  221. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  222. if err := st.fr.WriteHeaders(p); err != nil {
  223. st.t.Fatalf("Error writing HEADERS: %v", err)
  224. }
  225. }
  226. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  227. if err := st.fr.WritePriority(id, p); err != nil {
  228. st.t.Fatalf("Error writing PRIORITY: %v", err)
  229. }
  230. }
  231. func (st *serverTester) encodeHeaderField(k, v string) {
  232. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  233. if err != nil {
  234. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  235. }
  236. }
  237. // encodeHeaderRaw is the magic-free version of encodeHeader.
  238. // It takes 0 or more (k, v) pairs and encodes them.
  239. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  240. if len(headers)%2 == 1 {
  241. panic("odd number of kv args")
  242. }
  243. st.headerBuf.Reset()
  244. for len(headers) > 0 {
  245. k, v := headers[0], headers[1]
  246. st.encodeHeaderField(k, v)
  247. headers = headers[2:]
  248. }
  249. return st.headerBuf.Bytes()
  250. }
  251. // encodeHeader encodes headers and returns their HPACK bytes. headers
  252. // must contain an even number of key/value pairs. There may be
  253. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  254. // :scheme headers default to GET, / and https.
  255. func (st *serverTester) encodeHeader(headers ...string) []byte {
  256. if len(headers)%2 == 1 {
  257. panic("odd number of kv args")
  258. }
  259. st.headerBuf.Reset()
  260. if len(headers) == 0 {
  261. // Fast path, mostly for benchmarks, so test code doesn't pollute
  262. // profiles when we're looking to improve server allocations.
  263. st.encodeHeaderField(":method", "GET")
  264. st.encodeHeaderField(":path", "/")
  265. st.encodeHeaderField(":scheme", "https")
  266. return st.headerBuf.Bytes()
  267. }
  268. if len(headers) == 2 && headers[0] == ":method" {
  269. // Another fast path for benchmarks.
  270. st.encodeHeaderField(":method", headers[1])
  271. st.encodeHeaderField(":path", "/")
  272. st.encodeHeaderField(":scheme", "https")
  273. return st.headerBuf.Bytes()
  274. }
  275. pseudoCount := map[string]int{}
  276. keys := []string{":method", ":path", ":scheme"}
  277. vals := map[string][]string{
  278. ":method": {"GET"},
  279. ":path": {"/"},
  280. ":scheme": {"https"},
  281. }
  282. for len(headers) > 0 {
  283. k, v := headers[0], headers[1]
  284. headers = headers[2:]
  285. if _, ok := vals[k]; !ok {
  286. keys = append(keys, k)
  287. }
  288. if strings.HasPrefix(k, ":") {
  289. pseudoCount[k]++
  290. if pseudoCount[k] == 1 {
  291. vals[k] = []string{v}
  292. } else {
  293. // Allows testing of invalid headers w/ dup pseudo fields.
  294. vals[k] = append(vals[k], v)
  295. }
  296. } else {
  297. vals[k] = append(vals[k], v)
  298. }
  299. }
  300. for _, k := range keys {
  301. for _, v := range vals[k] {
  302. st.encodeHeaderField(k, v)
  303. }
  304. }
  305. return st.headerBuf.Bytes()
  306. }
  307. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  308. func (st *serverTester) bodylessReq1(headers ...string) {
  309. st.writeHeaders(HeadersFrameParam{
  310. StreamID: 1, // clients send odd numbers
  311. BlockFragment: st.encodeHeader(headers...),
  312. EndStream: true,
  313. EndHeaders: true,
  314. })
  315. }
  316. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  317. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  318. st.t.Fatalf("Error writing DATA: %v", err)
  319. }
  320. }
  321. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  322. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  323. st.t.Fatalf("Error writing DATA: %v", err)
  324. }
  325. }
  326. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  327. ch := make(chan interface{}, 1)
  328. go func() {
  329. fr, err := fr.ReadFrame()
  330. if err != nil {
  331. ch <- err
  332. } else {
  333. ch <- fr
  334. }
  335. }()
  336. t := time.NewTimer(wait)
  337. select {
  338. case v := <-ch:
  339. t.Stop()
  340. if fr, ok := v.(Frame); ok {
  341. return fr, nil
  342. }
  343. return nil, v.(error)
  344. case <-t.C:
  345. return nil, errors.New("timeout waiting for frame")
  346. }
  347. }
  348. func (st *serverTester) readFrame() (Frame, error) {
  349. return readFrameTimeout(st.fr, 2*time.Second)
  350. }
  351. func (st *serverTester) wantHeaders() *HeadersFrame {
  352. f, err := st.readFrame()
  353. if err != nil {
  354. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  355. }
  356. hf, ok := f.(*HeadersFrame)
  357. if !ok {
  358. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  359. }
  360. return hf
  361. }
  362. func (st *serverTester) wantContinuation() *ContinuationFrame {
  363. f, err := st.readFrame()
  364. if err != nil {
  365. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  366. }
  367. cf, ok := f.(*ContinuationFrame)
  368. if !ok {
  369. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  370. }
  371. return cf
  372. }
  373. func (st *serverTester) wantData() *DataFrame {
  374. f, err := st.readFrame()
  375. if err != nil {
  376. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  377. }
  378. df, ok := f.(*DataFrame)
  379. if !ok {
  380. st.t.Fatalf("got a %T; want *DataFrame", f)
  381. }
  382. return df
  383. }
  384. func (st *serverTester) wantSettings() *SettingsFrame {
  385. f, err := st.readFrame()
  386. if err != nil {
  387. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  388. }
  389. sf, ok := f.(*SettingsFrame)
  390. if !ok {
  391. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  392. }
  393. return sf
  394. }
  395. func (st *serverTester) wantPing() *PingFrame {
  396. f, err := st.readFrame()
  397. if err != nil {
  398. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  399. }
  400. pf, ok := f.(*PingFrame)
  401. if !ok {
  402. st.t.Fatalf("got a %T; want *PingFrame", f)
  403. }
  404. return pf
  405. }
  406. func (st *serverTester) wantGoAway() *GoAwayFrame {
  407. f, err := st.readFrame()
  408. if err != nil {
  409. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  410. }
  411. gf, ok := f.(*GoAwayFrame)
  412. if !ok {
  413. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  414. }
  415. return gf
  416. }
  417. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  418. f, err := st.readFrame()
  419. if err != nil {
  420. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  421. }
  422. rs, ok := f.(*RSTStreamFrame)
  423. if !ok {
  424. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  425. }
  426. if rs.FrameHeader.StreamID != streamID {
  427. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  428. }
  429. if rs.ErrCode != errCode {
  430. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  431. }
  432. }
  433. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  434. f, err := st.readFrame()
  435. if err != nil {
  436. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  437. }
  438. wu, ok := f.(*WindowUpdateFrame)
  439. if !ok {
  440. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  441. }
  442. if wu.FrameHeader.StreamID != streamID {
  443. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  444. }
  445. if wu.Increment != incr {
  446. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  447. }
  448. }
  449. func (st *serverTester) wantSettingsAck() {
  450. f, err := st.readFrame()
  451. if err != nil {
  452. st.t.Fatal(err)
  453. }
  454. sf, ok := f.(*SettingsFrame)
  455. if !ok {
  456. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  457. }
  458. if !sf.Header().Flags.Has(FlagSettingsAck) {
  459. st.t.Fatal("Settings Frame didn't have ACK set")
  460. }
  461. }
  462. func TestServer(t *testing.T) {
  463. gotReq := make(chan bool, 1)
  464. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  465. w.Header().Set("Foo", "Bar")
  466. gotReq <- true
  467. })
  468. defer st.Close()
  469. covers("3.5", `
  470. The server connection preface consists of a potentially empty
  471. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  472. server sends in the HTTP/2 connection.
  473. `)
  474. st.writePreface()
  475. st.writeInitialSettings()
  476. st.wantSettings()
  477. st.writeSettingsAck()
  478. st.wantSettingsAck()
  479. st.writeHeaders(HeadersFrameParam{
  480. StreamID: 1, // clients send odd numbers
  481. BlockFragment: st.encodeHeader(),
  482. EndStream: true, // no DATA frames
  483. EndHeaders: true,
  484. })
  485. select {
  486. case <-gotReq:
  487. case <-time.After(2 * time.Second):
  488. t.Error("timeout waiting for request")
  489. }
  490. }
  491. func TestServer_Request_Get(t *testing.T) {
  492. testServerRequest(t, func(st *serverTester) {
  493. st.writeHeaders(HeadersFrameParam{
  494. StreamID: 1, // clients send odd numbers
  495. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  496. EndStream: true, // no DATA frames
  497. EndHeaders: true,
  498. })
  499. }, func(r *http.Request) {
  500. if r.Method != "GET" {
  501. t.Errorf("Method = %q; want GET", r.Method)
  502. }
  503. if r.URL.Path != "/" {
  504. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  505. }
  506. if r.ContentLength != 0 {
  507. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  508. }
  509. if r.Close {
  510. t.Error("Close = true; want false")
  511. }
  512. if !strings.Contains(r.RemoteAddr, ":") {
  513. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  514. }
  515. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  516. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  517. }
  518. wantHeader := http.Header{
  519. "Foo-Bar": []string{"some-value"},
  520. }
  521. if !reflect.DeepEqual(r.Header, wantHeader) {
  522. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  523. }
  524. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  525. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  526. }
  527. })
  528. }
  529. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  530. testServerRequest(t, func(st *serverTester) {
  531. st.writeHeaders(HeadersFrameParam{
  532. StreamID: 1, // clients send odd numbers
  533. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  534. EndStream: true, // no DATA frames
  535. EndHeaders: true,
  536. })
  537. }, func(r *http.Request) {
  538. if r.RequestURI != "/%2f/" {
  539. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  540. }
  541. if r.URL.Path != "///" {
  542. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  543. }
  544. })
  545. }
  546. // TODO: add a test with EndStream=true on the HEADERS but setting a
  547. // Content-Length anyway. Should we just omit it and force it to
  548. // zero?
  549. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  550. testServerRequest(t, func(st *serverTester) {
  551. st.writeHeaders(HeadersFrameParam{
  552. StreamID: 1, // clients send odd numbers
  553. BlockFragment: st.encodeHeader(":method", "POST"),
  554. EndStream: true,
  555. EndHeaders: true,
  556. })
  557. }, func(r *http.Request) {
  558. if r.Method != "POST" {
  559. t.Errorf("Method = %q; want POST", r.Method)
  560. }
  561. if r.ContentLength != 0 {
  562. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  563. }
  564. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  565. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  566. }
  567. })
  568. }
  569. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  570. testBodyContents(t, -1, "", func(st *serverTester) {
  571. st.writeHeaders(HeadersFrameParam{
  572. StreamID: 1, // clients send odd numbers
  573. BlockFragment: st.encodeHeader(":method", "POST"),
  574. EndStream: false, // to say DATA frames are coming
  575. EndHeaders: true,
  576. })
  577. st.writeData(1, true, nil) // just kidding. empty body.
  578. })
  579. }
  580. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  581. const content = "Some content"
  582. testBodyContents(t, -1, content, func(st *serverTester) {
  583. st.writeHeaders(HeadersFrameParam{
  584. StreamID: 1, // clients send odd numbers
  585. BlockFragment: st.encodeHeader(":method", "POST"),
  586. EndStream: false, // to say DATA frames are coming
  587. EndHeaders: true,
  588. })
  589. st.writeData(1, true, []byte(content))
  590. })
  591. }
  592. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  593. const content = "Some content"
  594. testBodyContents(t, -1, content, func(st *serverTester) {
  595. st.writeHeaders(HeadersFrameParam{
  596. StreamID: 1, // clients send odd numbers
  597. BlockFragment: st.encodeHeader(":method", "POST"),
  598. EndStream: false, // to say DATA frames are coming
  599. EndHeaders: true,
  600. })
  601. st.writeData(1, false, []byte(content[:5]))
  602. st.writeData(1, true, []byte(content[5:]))
  603. })
  604. }
  605. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  606. const content = "Some content"
  607. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  608. st.writeHeaders(HeadersFrameParam{
  609. StreamID: 1, // clients send odd numbers
  610. BlockFragment: st.encodeHeader(
  611. ":method", "POST",
  612. "content-length", strconv.Itoa(len(content)),
  613. ),
  614. EndStream: false, // to say DATA frames are coming
  615. EndHeaders: true,
  616. })
  617. st.writeData(1, true, []byte(content))
  618. })
  619. }
  620. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  621. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  622. func(st *serverTester) {
  623. st.writeHeaders(HeadersFrameParam{
  624. StreamID: 1, // clients send odd numbers
  625. BlockFragment: st.encodeHeader(
  626. ":method", "POST",
  627. "content-length", "3",
  628. ),
  629. EndStream: false, // to say DATA frames are coming
  630. EndHeaders: true,
  631. })
  632. st.writeData(1, true, []byte("12"))
  633. })
  634. }
  635. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  636. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  637. func(st *serverTester) {
  638. st.writeHeaders(HeadersFrameParam{
  639. StreamID: 1, // clients send odd numbers
  640. BlockFragment: st.encodeHeader(
  641. ":method", "POST",
  642. "content-length", "4",
  643. ),
  644. EndStream: false, // to say DATA frames are coming
  645. EndHeaders: true,
  646. })
  647. st.writeData(1, true, []byte("12345"))
  648. })
  649. }
  650. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  651. testServerRequest(t, write, func(r *http.Request) {
  652. if r.Method != "POST" {
  653. t.Errorf("Method = %q; want POST", r.Method)
  654. }
  655. if r.ContentLength != wantContentLength {
  656. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  657. }
  658. all, err := ioutil.ReadAll(r.Body)
  659. if err != nil {
  660. t.Fatal(err)
  661. }
  662. if string(all) != wantBody {
  663. t.Errorf("Read = %q; want %q", all, wantBody)
  664. }
  665. if err := r.Body.Close(); err != nil {
  666. t.Fatalf("Close: %v", err)
  667. }
  668. })
  669. }
  670. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  671. testServerRequest(t, write, func(r *http.Request) {
  672. if r.Method != "POST" {
  673. t.Errorf("Method = %q; want POST", r.Method)
  674. }
  675. if r.ContentLength != wantContentLength {
  676. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  677. }
  678. all, err := ioutil.ReadAll(r.Body)
  679. if err == nil {
  680. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  681. wantReadError, all)
  682. }
  683. if !strings.Contains(err.Error(), wantReadError) {
  684. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  685. }
  686. if err := r.Body.Close(); err != nil {
  687. t.Fatalf("Close: %v", err)
  688. }
  689. })
  690. }
  691. // Using a Host header, instead of :authority
  692. func TestServer_Request_Get_Host(t *testing.T) {
  693. const host = "example.com"
  694. testServerRequest(t, func(st *serverTester) {
  695. st.writeHeaders(HeadersFrameParam{
  696. StreamID: 1, // clients send odd numbers
  697. BlockFragment: st.encodeHeader("host", host),
  698. EndStream: true,
  699. EndHeaders: true,
  700. })
  701. }, func(r *http.Request) {
  702. if r.Host != host {
  703. t.Errorf("Host = %q; want %q", r.Host, host)
  704. }
  705. })
  706. }
  707. // Using an :authority pseudo-header, instead of Host
  708. func TestServer_Request_Get_Authority(t *testing.T) {
  709. const host = "example.com"
  710. testServerRequest(t, func(st *serverTester) {
  711. st.writeHeaders(HeadersFrameParam{
  712. StreamID: 1, // clients send odd numbers
  713. BlockFragment: st.encodeHeader(":authority", host),
  714. EndStream: true,
  715. EndHeaders: true,
  716. })
  717. }, func(r *http.Request) {
  718. if r.Host != host {
  719. t.Errorf("Host = %q; want %q", r.Host, host)
  720. }
  721. })
  722. }
  723. func TestServer_Request_WithContinuation(t *testing.T) {
  724. wantHeader := http.Header{
  725. "Foo-One": []string{"value-one"},
  726. "Foo-Two": []string{"value-two"},
  727. "Foo-Three": []string{"value-three"},
  728. }
  729. testServerRequest(t, func(st *serverTester) {
  730. fullHeaders := st.encodeHeader(
  731. "foo-one", "value-one",
  732. "foo-two", "value-two",
  733. "foo-three", "value-three",
  734. )
  735. remain := fullHeaders
  736. chunks := 0
  737. for len(remain) > 0 {
  738. const maxChunkSize = 5
  739. chunk := remain
  740. if len(chunk) > maxChunkSize {
  741. chunk = chunk[:maxChunkSize]
  742. }
  743. remain = remain[len(chunk):]
  744. if chunks == 0 {
  745. st.writeHeaders(HeadersFrameParam{
  746. StreamID: 1, // clients send odd numbers
  747. BlockFragment: chunk,
  748. EndStream: true, // no DATA frames
  749. EndHeaders: false, // we'll have continuation frames
  750. })
  751. } else {
  752. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  753. if err != nil {
  754. t.Fatal(err)
  755. }
  756. }
  757. chunks++
  758. }
  759. if chunks < 2 {
  760. t.Fatal("too few chunks")
  761. }
  762. }, func(r *http.Request) {
  763. if !reflect.DeepEqual(r.Header, wantHeader) {
  764. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  765. }
  766. })
  767. }
  768. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  769. func TestServer_Request_CookieConcat(t *testing.T) {
  770. const host = "example.com"
  771. testServerRequest(t, func(st *serverTester) {
  772. st.bodylessReq1(
  773. ":authority", host,
  774. "cookie", "a=b",
  775. "cookie", "c=d",
  776. "cookie", "e=f",
  777. )
  778. }, func(r *http.Request) {
  779. const want = "a=b; c=d; e=f"
  780. if got := r.Header.Get("Cookie"); got != want {
  781. t.Errorf("Cookie = %q; want %q", got, want)
  782. }
  783. })
  784. }
  785. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  786. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  787. }
  788. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  789. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  790. }
  791. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  792. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  793. }
  794. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  795. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  796. }
  797. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  798. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  799. }
  800. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  801. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  802. }
  803. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  804. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  805. }
  806. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  807. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  808. }
  809. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  810. // 8.1.2.3 Request Pseudo-Header Fields
  811. // "All HTTP/2 requests MUST include exactly one valid value" ...
  812. testRejectRequest(t, func(st *serverTester) {
  813. st.addLogFilter("duplicate pseudo-header")
  814. st.bodylessReq1(":method", "GET", ":method", "POST")
  815. })
  816. }
  817. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  818. // 8.1.2.3 Request Pseudo-Header Fields
  819. // "All pseudo-header fields MUST appear in the header block
  820. // before regular header fields. Any request or response that
  821. // contains a pseudo-header field that appears in a header
  822. // block after a regular header field MUST be treated as
  823. // malformed (Section 8.1.2.6)."
  824. testRejectRequest(t, func(st *serverTester) {
  825. st.addLogFilter("pseudo-header after regular header")
  826. var buf bytes.Buffer
  827. enc := hpack.NewEncoder(&buf)
  828. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  829. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  830. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  831. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  832. st.writeHeaders(HeadersFrameParam{
  833. StreamID: 1, // clients send odd numbers
  834. BlockFragment: buf.Bytes(),
  835. EndStream: true,
  836. EndHeaders: true,
  837. })
  838. })
  839. }
  840. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  841. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  842. }
  843. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  844. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  845. }
  846. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  847. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  848. }
  849. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  850. testRejectRequest(t, func(st *serverTester) {
  851. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  852. st.bodylessReq1(":unknown_thing", "")
  853. })
  854. }
  855. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  856. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  857. t.Error("server request made it to handler; should've been rejected")
  858. })
  859. defer st.Close()
  860. st.greet()
  861. send(st)
  862. st.wantRSTStream(1, ErrCodeProtocol)
  863. }
  864. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  865. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  866. t.Error("server request made it to handler; should've been rejected")
  867. }, optQuiet)
  868. defer st.Close()
  869. st.greet()
  870. send(st)
  871. gf := st.wantGoAway()
  872. if gf.ErrCode != ErrCodeProtocol {
  873. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  874. }
  875. }
  876. // Section 5.1, on idle connections: "Receiving any frame other than
  877. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  878. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  879. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  880. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  881. st.fr.WriteWindowUpdate(123, 456)
  882. })
  883. }
  884. func TestRejectFrameOnIdle_Data(t *testing.T) {
  885. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  886. st.fr.WriteData(123, true, nil)
  887. })
  888. }
  889. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  890. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  891. st.fr.WriteRSTStream(123, ErrCodeCancel)
  892. })
  893. }
  894. func TestServer_Request_Connect(t *testing.T) {
  895. testServerRequest(t, func(st *serverTester) {
  896. st.writeHeaders(HeadersFrameParam{
  897. StreamID: 1,
  898. BlockFragment: st.encodeHeaderRaw(
  899. ":method", "CONNECT",
  900. ":authority", "example.com:123",
  901. ),
  902. EndStream: true,
  903. EndHeaders: true,
  904. })
  905. }, func(r *http.Request) {
  906. if g, w := r.Method, "CONNECT"; g != w {
  907. t.Errorf("Method = %q; want %q", g, w)
  908. }
  909. if g, w := r.RequestURI, "example.com:123"; g != w {
  910. t.Errorf("RequestURI = %q; want %q", g, w)
  911. }
  912. if g, w := r.URL.Host, "example.com:123"; g != w {
  913. t.Errorf("URL.Host = %q; want %q", g, w)
  914. }
  915. })
  916. }
  917. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  918. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  919. st.writeHeaders(HeadersFrameParam{
  920. StreamID: 1,
  921. BlockFragment: st.encodeHeaderRaw(
  922. ":method", "CONNECT",
  923. ":authority", "example.com:123",
  924. ":path", "/bogus",
  925. ),
  926. EndStream: true,
  927. EndHeaders: true,
  928. })
  929. })
  930. }
  931. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  932. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  933. st.writeHeaders(HeadersFrameParam{
  934. StreamID: 1,
  935. BlockFragment: st.encodeHeaderRaw(
  936. ":method", "CONNECT",
  937. ":authority", "example.com:123",
  938. ":scheme", "https",
  939. ),
  940. EndStream: true,
  941. EndHeaders: true,
  942. })
  943. })
  944. }
  945. func TestServer_Ping(t *testing.T) {
  946. st := newServerTester(t, nil)
  947. defer st.Close()
  948. st.greet()
  949. // Server should ignore this one, since it has ACK set.
  950. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  951. if err := st.fr.WritePing(true, ackPingData); err != nil {
  952. t.Fatal(err)
  953. }
  954. // But the server should reply to this one, since ACK is false.
  955. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  956. if err := st.fr.WritePing(false, pingData); err != nil {
  957. t.Fatal(err)
  958. }
  959. pf := st.wantPing()
  960. if !pf.Flags.Has(FlagPingAck) {
  961. t.Error("response ping doesn't have ACK set")
  962. }
  963. if pf.Data != pingData {
  964. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  965. }
  966. }
  967. func TestServer_RejectsLargeFrames(t *testing.T) {
  968. if runtime.GOOS == "windows" {
  969. t.Skip("see golang.org/issue/13434")
  970. }
  971. st := newServerTester(t, nil)
  972. defer st.Close()
  973. st.greet()
  974. // Write too large of a frame (too large by one byte)
  975. // We ignore the return value because it's expected that the server
  976. // will only read the first 9 bytes (the headre) and then disconnect.
  977. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  978. gf := st.wantGoAway()
  979. if gf.ErrCode != ErrCodeFrameSize {
  980. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  981. }
  982. if st.logBuf.Len() != 0 {
  983. // Previously we spun here for a bit until the GOAWAY disconnect
  984. // timer fired, logging while we fired.
  985. t.Errorf("unexpected server output: %.500s\n", st.logBuf.Bytes())
  986. }
  987. }
  988. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  989. puppet := newHandlerPuppet()
  990. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  991. puppet.act(w, r)
  992. })
  993. defer st.Close()
  994. defer puppet.done()
  995. st.greet()
  996. st.writeHeaders(HeadersFrameParam{
  997. StreamID: 1, // clients send odd numbers
  998. BlockFragment: st.encodeHeader(":method", "POST"),
  999. EndStream: false, // data coming
  1000. EndHeaders: true,
  1001. })
  1002. st.writeData(1, false, []byte("abcdef"))
  1003. puppet.do(readBodyHandler(t, "abc"))
  1004. st.wantWindowUpdate(0, 3)
  1005. st.wantWindowUpdate(1, 3)
  1006. puppet.do(readBodyHandler(t, "def"))
  1007. st.wantWindowUpdate(0, 3)
  1008. st.wantWindowUpdate(1, 3)
  1009. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1010. puppet.do(readBodyHandler(t, "ghi"))
  1011. puppet.do(readBodyHandler(t, "jkl"))
  1012. st.wantWindowUpdate(0, 3)
  1013. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1014. }
  1015. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1016. // See golang.org/issue/16556
  1017. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1018. puppet := newHandlerPuppet()
  1019. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1020. puppet.act(w, r)
  1021. })
  1022. defer st.Close()
  1023. defer puppet.done()
  1024. st.greet()
  1025. st.writeHeaders(HeadersFrameParam{
  1026. StreamID: 1,
  1027. BlockFragment: st.encodeHeader(":method", "POST"),
  1028. EndStream: false,
  1029. EndHeaders: true,
  1030. })
  1031. st.writeDataPadded(1, false, []byte("abcdef"), []byte("1234"))
  1032. // Expect to immediately get our 5 bytes of padding back for
  1033. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1034. st.wantWindowUpdate(0, 5)
  1035. st.wantWindowUpdate(1, 5)
  1036. puppet.do(readBodyHandler(t, "abc"))
  1037. st.wantWindowUpdate(0, 3)
  1038. st.wantWindowUpdate(1, 3)
  1039. puppet.do(readBodyHandler(t, "def"))
  1040. st.wantWindowUpdate(0, 3)
  1041. st.wantWindowUpdate(1, 3)
  1042. }
  1043. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1044. st := newServerTester(t, nil)
  1045. defer st.Close()
  1046. st.greet()
  1047. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1048. t.Fatal(err)
  1049. }
  1050. gf := st.wantGoAway()
  1051. if gf.ErrCode != ErrCodeFlowControl {
  1052. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1053. }
  1054. if gf.LastStreamID != 0 {
  1055. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1056. }
  1057. }
  1058. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1059. inHandler := make(chan bool)
  1060. blockHandler := make(chan bool)
  1061. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1062. inHandler <- true
  1063. <-blockHandler
  1064. })
  1065. defer st.Close()
  1066. defer close(blockHandler)
  1067. st.greet()
  1068. st.writeHeaders(HeadersFrameParam{
  1069. StreamID: 1,
  1070. BlockFragment: st.encodeHeader(":method", "POST"),
  1071. EndStream: false, // keep it open
  1072. EndHeaders: true,
  1073. })
  1074. <-inHandler
  1075. // Send a bogus window update:
  1076. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1077. t.Fatal(err)
  1078. }
  1079. st.wantRSTStream(1, ErrCodeFlowControl)
  1080. }
  1081. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1082. // then runs fn once in the handler, and verifies that the error returned from
  1083. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1084. func testServerPostUnblock(t *testing.T,
  1085. handler func(http.ResponseWriter, *http.Request) error,
  1086. fn func(*serverTester),
  1087. checkErr func(error),
  1088. otherHeaders ...string) {
  1089. inHandler := make(chan bool)
  1090. errc := make(chan error, 1)
  1091. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1092. inHandler <- true
  1093. errc <- handler(w, r)
  1094. })
  1095. st.greet()
  1096. st.writeHeaders(HeadersFrameParam{
  1097. StreamID: 1,
  1098. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1099. EndStream: false, // keep it open
  1100. EndHeaders: true,
  1101. })
  1102. <-inHandler
  1103. fn(st)
  1104. select {
  1105. case err := <-errc:
  1106. if checkErr != nil {
  1107. checkErr(err)
  1108. }
  1109. case <-time.After(5 * time.Second):
  1110. t.Fatal("timeout waiting for Handler to return")
  1111. }
  1112. st.Close()
  1113. }
  1114. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1115. testServerPostUnblock(t,
  1116. func(w http.ResponseWriter, r *http.Request) (err error) {
  1117. _, err = r.Body.Read(make([]byte, 1))
  1118. return
  1119. },
  1120. func(st *serverTester) {
  1121. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1122. t.Fatal(err)
  1123. }
  1124. },
  1125. func(err error) {
  1126. want := StreamError{StreamID: 0x1, Code: 0x8}
  1127. if !reflect.DeepEqual(err, want) {
  1128. t.Errorf("Read error = %v; want %v", err, want)
  1129. }
  1130. },
  1131. )
  1132. }
  1133. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1134. // Run this test a bunch, because it doesn't always
  1135. // deadlock. But with a bunch, it did.
  1136. n := 50
  1137. if testing.Short() {
  1138. n = 5
  1139. }
  1140. for i := 0; i < n; i++ {
  1141. testServer_RSTStream_Unblocks_Header_Write(t)
  1142. }
  1143. }
  1144. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1145. inHandler := make(chan bool, 1)
  1146. unblockHandler := make(chan bool, 1)
  1147. headerWritten := make(chan bool, 1)
  1148. wroteRST := make(chan bool, 1)
  1149. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1150. inHandler <- true
  1151. <-wroteRST
  1152. w.Header().Set("foo", "bar")
  1153. w.WriteHeader(200)
  1154. w.(http.Flusher).Flush()
  1155. headerWritten <- true
  1156. <-unblockHandler
  1157. })
  1158. defer st.Close()
  1159. st.greet()
  1160. st.writeHeaders(HeadersFrameParam{
  1161. StreamID: 1,
  1162. BlockFragment: st.encodeHeader(":method", "POST"),
  1163. EndStream: false, // keep it open
  1164. EndHeaders: true,
  1165. })
  1166. <-inHandler
  1167. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1168. t.Fatal(err)
  1169. }
  1170. wroteRST <- true
  1171. st.awaitIdle()
  1172. select {
  1173. case <-headerWritten:
  1174. case <-time.After(2 * time.Second):
  1175. t.Error("timeout waiting for header write")
  1176. }
  1177. unblockHandler <- true
  1178. }
  1179. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1180. testServerPostUnblock(t,
  1181. func(w http.ResponseWriter, r *http.Request) (err error) {
  1182. _, err = r.Body.Read(make([]byte, 1))
  1183. return
  1184. },
  1185. func(st *serverTester) { st.cc.Close() },
  1186. func(err error) {
  1187. if err == nil {
  1188. t.Error("unexpected nil error from Request.Body.Read")
  1189. }
  1190. },
  1191. )
  1192. }
  1193. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1194. <-w.(http.CloseNotifier).CloseNotify()
  1195. return nil
  1196. }
  1197. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1198. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1199. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1200. t.Fatal(err)
  1201. }
  1202. }, nil)
  1203. }
  1204. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1205. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1206. }
  1207. // that CloseNotify unblocks after a stream error due to the client's
  1208. // problem that's unrelated to them explicitly canceling it (which is
  1209. // TestServer_CloseNotify_After_RSTStream above)
  1210. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1211. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1212. // data longer than declared Content-Length => stream error
  1213. st.writeData(1, true, []byte("1234"))
  1214. }, nil, "content-length", "3")
  1215. }
  1216. func TestServer_StateTransitions(t *testing.T) {
  1217. var st *serverTester
  1218. inHandler := make(chan bool)
  1219. writeData := make(chan bool)
  1220. leaveHandler := make(chan bool)
  1221. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1222. inHandler <- true
  1223. if st.stream(1) == nil {
  1224. t.Errorf("nil stream 1 in handler")
  1225. }
  1226. if got, want := st.streamState(1), stateOpen; got != want {
  1227. t.Errorf("in handler, state is %v; want %v", got, want)
  1228. }
  1229. writeData <- true
  1230. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1231. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1232. }
  1233. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1234. t.Errorf("in handler, state is %v; want %v", got, want)
  1235. }
  1236. <-leaveHandler
  1237. })
  1238. st.greet()
  1239. if st.stream(1) != nil {
  1240. t.Fatal("stream 1 should be empty")
  1241. }
  1242. if got := st.streamState(1); got != stateIdle {
  1243. t.Fatalf("stream 1 should be idle; got %v", got)
  1244. }
  1245. st.writeHeaders(HeadersFrameParam{
  1246. StreamID: 1,
  1247. BlockFragment: st.encodeHeader(":method", "POST"),
  1248. EndStream: false, // keep it open
  1249. EndHeaders: true,
  1250. })
  1251. <-inHandler
  1252. <-writeData
  1253. st.writeData(1, true, nil)
  1254. leaveHandler <- true
  1255. hf := st.wantHeaders()
  1256. if !hf.StreamEnded() {
  1257. t.Fatal("expected END_STREAM flag")
  1258. }
  1259. if got, want := st.streamState(1), stateClosed; got != want {
  1260. t.Errorf("at end, state is %v; want %v", got, want)
  1261. }
  1262. if st.stream(1) != nil {
  1263. t.Fatal("at end, stream 1 should be gone")
  1264. }
  1265. }
  1266. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1267. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1268. testServerRejectsConn(t, func(st *serverTester) {
  1269. st.writeHeaders(HeadersFrameParam{
  1270. StreamID: 1,
  1271. BlockFragment: st.encodeHeader(),
  1272. EndStream: true,
  1273. EndHeaders: false,
  1274. })
  1275. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1276. StreamID: 3, // different stream.
  1277. BlockFragment: st.encodeHeader(),
  1278. EndStream: true,
  1279. EndHeaders: true,
  1280. })
  1281. })
  1282. }
  1283. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1284. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1285. testServerRejectsConn(t, func(st *serverTester) {
  1286. st.writeHeaders(HeadersFrameParam{
  1287. StreamID: 1,
  1288. BlockFragment: st.encodeHeader(),
  1289. EndStream: true,
  1290. EndHeaders: false,
  1291. })
  1292. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1293. t.Fatal(err)
  1294. }
  1295. })
  1296. }
  1297. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1298. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1299. testServerRejectsConn(t, func(st *serverTester) {
  1300. st.writeHeaders(HeadersFrameParam{
  1301. StreamID: 1,
  1302. BlockFragment: st.encodeHeader(),
  1303. EndStream: true,
  1304. EndHeaders: true,
  1305. })
  1306. st.wantHeaders()
  1307. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1308. t.Fatal(err)
  1309. }
  1310. })
  1311. }
  1312. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1313. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1314. testServerRejectsConn(t, func(st *serverTester) {
  1315. st.writeHeaders(HeadersFrameParam{
  1316. StreamID: 1,
  1317. BlockFragment: st.encodeHeader(),
  1318. EndStream: true,
  1319. EndHeaders: false,
  1320. })
  1321. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1322. t.Fatal(err)
  1323. }
  1324. })
  1325. }
  1326. // No HEADERS on stream 0.
  1327. func TestServer_Rejects_Headers0(t *testing.T) {
  1328. testServerRejectsConn(t, func(st *serverTester) {
  1329. st.fr.AllowIllegalWrites = true
  1330. st.writeHeaders(HeadersFrameParam{
  1331. StreamID: 0,
  1332. BlockFragment: st.encodeHeader(),
  1333. EndStream: true,
  1334. EndHeaders: true,
  1335. })
  1336. })
  1337. }
  1338. // No CONTINUATION on stream 0.
  1339. func TestServer_Rejects_Continuation0(t *testing.T) {
  1340. testServerRejectsConn(t, func(st *serverTester) {
  1341. st.fr.AllowIllegalWrites = true
  1342. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1343. t.Fatal(err)
  1344. }
  1345. })
  1346. }
  1347. // No PRIORITY on stream 0.
  1348. func TestServer_Rejects_Priority0(t *testing.T) {
  1349. testServerRejectsConn(t, func(st *serverTester) {
  1350. st.fr.AllowIllegalWrites = true
  1351. st.writePriority(0, PriorityParam{StreamDep: 1})
  1352. })
  1353. }
  1354. // No HEADERS frame with a self-dependence.
  1355. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1356. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1357. st.fr.AllowIllegalWrites = true
  1358. st.writeHeaders(HeadersFrameParam{
  1359. StreamID: 1,
  1360. BlockFragment: st.encodeHeader(),
  1361. EndStream: true,
  1362. EndHeaders: true,
  1363. Priority: PriorityParam{StreamDep: 1},
  1364. })
  1365. })
  1366. }
  1367. // No PRIORTY frame with a self-dependence.
  1368. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1369. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1370. st.fr.AllowIllegalWrites = true
  1371. st.writePriority(1, PriorityParam{StreamDep: 1})
  1372. })
  1373. }
  1374. func TestServer_Rejects_PushPromise(t *testing.T) {
  1375. testServerRejectsConn(t, func(st *serverTester) {
  1376. pp := PushPromiseParam{
  1377. StreamID: 1,
  1378. PromiseID: 3,
  1379. }
  1380. if err := st.fr.WritePushPromise(pp); err != nil {
  1381. t.Fatal(err)
  1382. }
  1383. })
  1384. }
  1385. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1386. // frame and a server close after the client does something
  1387. // deserving a CONNECTION_ERROR.
  1388. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1389. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1390. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1391. defer st.Close()
  1392. st.greet()
  1393. writeReq(st)
  1394. st.wantGoAway()
  1395. errc := make(chan error, 1)
  1396. go func() {
  1397. fr, err := st.fr.ReadFrame()
  1398. if err == nil {
  1399. err = fmt.Errorf("got frame of type %T", fr)
  1400. }
  1401. errc <- err
  1402. }()
  1403. select {
  1404. case err := <-errc:
  1405. if err != io.EOF {
  1406. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1407. }
  1408. case <-time.After(2 * time.Second):
  1409. t.Error("timeout waiting for disconnect")
  1410. }
  1411. }
  1412. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1413. // error code after a client sends a bogus request.
  1414. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1415. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1416. defer st.Close()
  1417. st.greet()
  1418. writeReq(st)
  1419. st.wantRSTStream(1, code)
  1420. }
  1421. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1422. // write a single request with writeReq, and then verify that the
  1423. // *http.Request is built correctly in checkReq.
  1424. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1425. gotReq := make(chan bool, 1)
  1426. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1427. if r.Body == nil {
  1428. t.Fatal("nil Body")
  1429. }
  1430. checkReq(r)
  1431. gotReq <- true
  1432. })
  1433. defer st.Close()
  1434. st.greet()
  1435. writeReq(st)
  1436. select {
  1437. case <-gotReq:
  1438. case <-time.After(2 * time.Second):
  1439. t.Error("timeout waiting for request")
  1440. }
  1441. }
  1442. func getSlash(st *serverTester) { st.bodylessReq1() }
  1443. func TestServer_Response_NoData(t *testing.T) {
  1444. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1445. // Nothing.
  1446. return nil
  1447. }, func(st *serverTester) {
  1448. getSlash(st)
  1449. hf := st.wantHeaders()
  1450. if !hf.StreamEnded() {
  1451. t.Fatal("want END_STREAM flag")
  1452. }
  1453. if !hf.HeadersEnded() {
  1454. t.Fatal("want END_HEADERS flag")
  1455. }
  1456. })
  1457. }
  1458. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1459. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1460. w.Header().Set("Foo-Bar", "some-value")
  1461. return nil
  1462. }, func(st *serverTester) {
  1463. getSlash(st)
  1464. hf := st.wantHeaders()
  1465. if !hf.StreamEnded() {
  1466. t.Fatal("want END_STREAM flag")
  1467. }
  1468. if !hf.HeadersEnded() {
  1469. t.Fatal("want END_HEADERS flag")
  1470. }
  1471. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1472. wanth := [][2]string{
  1473. {":status", "200"},
  1474. {"foo-bar", "some-value"},
  1475. {"content-type", "text/plain; charset=utf-8"},
  1476. {"content-length", "0"},
  1477. }
  1478. if !reflect.DeepEqual(goth, wanth) {
  1479. t.Errorf("Got headers %v; want %v", goth, wanth)
  1480. }
  1481. })
  1482. }
  1483. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1484. const msg = "<html>this is HTML."
  1485. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1486. w.Header().Set("Content-Type", "foo/bar")
  1487. io.WriteString(w, msg)
  1488. return nil
  1489. }, func(st *serverTester) {
  1490. getSlash(st)
  1491. hf := st.wantHeaders()
  1492. if hf.StreamEnded() {
  1493. t.Fatal("don't want END_STREAM, expecting data")
  1494. }
  1495. if !hf.HeadersEnded() {
  1496. t.Fatal("want END_HEADERS flag")
  1497. }
  1498. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1499. wanth := [][2]string{
  1500. {":status", "200"},
  1501. {"content-type", "foo/bar"},
  1502. {"content-length", strconv.Itoa(len(msg))},
  1503. }
  1504. if !reflect.DeepEqual(goth, wanth) {
  1505. t.Errorf("Got headers %v; want %v", goth, wanth)
  1506. }
  1507. df := st.wantData()
  1508. if !df.StreamEnded() {
  1509. t.Error("expected DATA to have END_STREAM flag")
  1510. }
  1511. if got := string(df.Data()); got != msg {
  1512. t.Errorf("got DATA %q; want %q", got, msg)
  1513. }
  1514. })
  1515. }
  1516. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1517. const msg = "hi"
  1518. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1519. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1520. io.WriteString(w, msg)
  1521. return nil
  1522. }, func(st *serverTester) {
  1523. getSlash(st)
  1524. hf := st.wantHeaders()
  1525. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1526. wanth := [][2]string{
  1527. {":status", "200"},
  1528. {"content-type", "text/plain; charset=utf-8"},
  1529. {"content-length", strconv.Itoa(len(msg))},
  1530. }
  1531. if !reflect.DeepEqual(goth, wanth) {
  1532. t.Errorf("Got headers %v; want %v", goth, wanth)
  1533. }
  1534. })
  1535. }
  1536. // Header accessed only after the initial write.
  1537. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1538. const msg = "<html>this is HTML."
  1539. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1540. io.WriteString(w, msg)
  1541. w.Header().Set("foo", "should be ignored")
  1542. return nil
  1543. }, func(st *serverTester) {
  1544. getSlash(st)
  1545. hf := st.wantHeaders()
  1546. if hf.StreamEnded() {
  1547. t.Fatal("unexpected END_STREAM")
  1548. }
  1549. if !hf.HeadersEnded() {
  1550. t.Fatal("want END_HEADERS flag")
  1551. }
  1552. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1553. wanth := [][2]string{
  1554. {":status", "200"},
  1555. {"content-type", "text/html; charset=utf-8"},
  1556. {"content-length", strconv.Itoa(len(msg))},
  1557. }
  1558. if !reflect.DeepEqual(goth, wanth) {
  1559. t.Errorf("Got headers %v; want %v", goth, wanth)
  1560. }
  1561. })
  1562. }
  1563. // Header accessed before the initial write and later mutated.
  1564. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1565. const msg = "<html>this is HTML."
  1566. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1567. w.Header().Set("foo", "proper value")
  1568. io.WriteString(w, msg)
  1569. w.Header().Set("foo", "should be ignored")
  1570. return nil
  1571. }, func(st *serverTester) {
  1572. getSlash(st)
  1573. hf := st.wantHeaders()
  1574. if hf.StreamEnded() {
  1575. t.Fatal("unexpected END_STREAM")
  1576. }
  1577. if !hf.HeadersEnded() {
  1578. t.Fatal("want END_HEADERS flag")
  1579. }
  1580. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1581. wanth := [][2]string{
  1582. {":status", "200"},
  1583. {"foo", "proper value"},
  1584. {"content-type", "text/html; charset=utf-8"},
  1585. {"content-length", strconv.Itoa(len(msg))},
  1586. }
  1587. if !reflect.DeepEqual(goth, wanth) {
  1588. t.Errorf("Got headers %v; want %v", goth, wanth)
  1589. }
  1590. })
  1591. }
  1592. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1593. const msg = "<html>this is HTML."
  1594. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1595. io.WriteString(w, msg)
  1596. return nil
  1597. }, func(st *serverTester) {
  1598. getSlash(st)
  1599. hf := st.wantHeaders()
  1600. if hf.StreamEnded() {
  1601. t.Fatal("don't want END_STREAM, expecting data")
  1602. }
  1603. if !hf.HeadersEnded() {
  1604. t.Fatal("want END_HEADERS flag")
  1605. }
  1606. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1607. wanth := [][2]string{
  1608. {":status", "200"},
  1609. {"content-type", "text/html; charset=utf-8"},
  1610. {"content-length", strconv.Itoa(len(msg))},
  1611. }
  1612. if !reflect.DeepEqual(goth, wanth) {
  1613. t.Errorf("Got headers %v; want %v", goth, wanth)
  1614. }
  1615. df := st.wantData()
  1616. if !df.StreamEnded() {
  1617. t.Error("expected DATA to have END_STREAM flag")
  1618. }
  1619. if got := string(df.Data()); got != msg {
  1620. t.Errorf("got DATA %q; want %q", got, msg)
  1621. }
  1622. })
  1623. }
  1624. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1625. const msg = "<html>this is HTML"
  1626. const msg2 = ", and this is the next chunk"
  1627. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1628. io.WriteString(w, msg)
  1629. w.(http.Flusher).Flush()
  1630. io.WriteString(w, msg2)
  1631. return nil
  1632. }, func(st *serverTester) {
  1633. getSlash(st)
  1634. hf := st.wantHeaders()
  1635. if hf.StreamEnded() {
  1636. t.Fatal("unexpected END_STREAM flag")
  1637. }
  1638. if !hf.HeadersEnded() {
  1639. t.Fatal("want END_HEADERS flag")
  1640. }
  1641. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1642. wanth := [][2]string{
  1643. {":status", "200"},
  1644. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1645. // and no content-length
  1646. }
  1647. if !reflect.DeepEqual(goth, wanth) {
  1648. t.Errorf("Got headers %v; want %v", goth, wanth)
  1649. }
  1650. {
  1651. df := st.wantData()
  1652. if df.StreamEnded() {
  1653. t.Error("unexpected END_STREAM flag")
  1654. }
  1655. if got := string(df.Data()); got != msg {
  1656. t.Errorf("got DATA %q; want %q", got, msg)
  1657. }
  1658. }
  1659. {
  1660. df := st.wantData()
  1661. if !df.StreamEnded() {
  1662. t.Error("wanted END_STREAM flag on last data chunk")
  1663. }
  1664. if got := string(df.Data()); got != msg2 {
  1665. t.Errorf("got DATA %q; want %q", got, msg2)
  1666. }
  1667. }
  1668. })
  1669. }
  1670. func TestServer_Response_LargeWrite(t *testing.T) {
  1671. const size = 1 << 20
  1672. const maxFrameSize = 16 << 10
  1673. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1674. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1675. if err != nil {
  1676. return fmt.Errorf("Write error: %v", err)
  1677. }
  1678. if n != size {
  1679. return fmt.Errorf("wrong size %d from Write", n)
  1680. }
  1681. return nil
  1682. }, func(st *serverTester) {
  1683. if err := st.fr.WriteSettings(
  1684. Setting{SettingInitialWindowSize, 0},
  1685. Setting{SettingMaxFrameSize, maxFrameSize},
  1686. ); err != nil {
  1687. t.Fatal(err)
  1688. }
  1689. st.wantSettingsAck()
  1690. getSlash(st) // make the single request
  1691. // Give the handler quota to write:
  1692. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1693. t.Fatal(err)
  1694. }
  1695. // Give the handler quota to write to connection-level
  1696. // window as well
  1697. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1698. t.Fatal(err)
  1699. }
  1700. hf := st.wantHeaders()
  1701. if hf.StreamEnded() {
  1702. t.Fatal("unexpected END_STREAM flag")
  1703. }
  1704. if !hf.HeadersEnded() {
  1705. t.Fatal("want END_HEADERS flag")
  1706. }
  1707. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1708. wanth := [][2]string{
  1709. {":status", "200"},
  1710. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1711. // and no content-length
  1712. }
  1713. if !reflect.DeepEqual(goth, wanth) {
  1714. t.Errorf("Got headers %v; want %v", goth, wanth)
  1715. }
  1716. var bytes, frames int
  1717. for {
  1718. df := st.wantData()
  1719. bytes += len(df.Data())
  1720. frames++
  1721. for _, b := range df.Data() {
  1722. if b != 'a' {
  1723. t.Fatal("non-'a' byte seen in DATA")
  1724. }
  1725. }
  1726. if df.StreamEnded() {
  1727. break
  1728. }
  1729. }
  1730. if bytes != size {
  1731. t.Errorf("Got %d bytes; want %d", bytes, size)
  1732. }
  1733. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1734. t.Errorf("Got %d frames; want %d", frames, size)
  1735. }
  1736. })
  1737. }
  1738. // Test that the handler can't write more than the client allows
  1739. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1740. // Make these reads. Before each read, the client adds exactly enough
  1741. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1742. reads := []int{123, 1, 13, 127}
  1743. size := 0
  1744. for _, n := range reads {
  1745. size += n
  1746. }
  1747. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1748. w.(http.Flusher).Flush()
  1749. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1750. if err != nil {
  1751. return fmt.Errorf("Write error: %v", err)
  1752. }
  1753. if n != size {
  1754. return fmt.Errorf("wrong size %d from Write", n)
  1755. }
  1756. return nil
  1757. }, func(st *serverTester) {
  1758. // Set the window size to something explicit for this test.
  1759. // It's also how much initial data we expect.
  1760. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1761. t.Fatal(err)
  1762. }
  1763. st.wantSettingsAck()
  1764. getSlash(st) // make the single request
  1765. hf := st.wantHeaders()
  1766. if hf.StreamEnded() {
  1767. t.Fatal("unexpected END_STREAM flag")
  1768. }
  1769. if !hf.HeadersEnded() {
  1770. t.Fatal("want END_HEADERS flag")
  1771. }
  1772. df := st.wantData()
  1773. if got := len(df.Data()); got != reads[0] {
  1774. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1775. }
  1776. for _, quota := range reads[1:] {
  1777. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1778. t.Fatal(err)
  1779. }
  1780. df := st.wantData()
  1781. if int(quota) != len(df.Data()) {
  1782. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1783. }
  1784. }
  1785. })
  1786. }
  1787. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1788. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1789. const size = 1 << 20
  1790. const maxFrameSize = 16 << 10
  1791. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1792. w.(http.Flusher).Flush()
  1793. errc := make(chan error, 1)
  1794. go func() {
  1795. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1796. errc <- err
  1797. }()
  1798. select {
  1799. case err := <-errc:
  1800. if err == nil {
  1801. return errors.New("unexpected nil error from Write in handler")
  1802. }
  1803. return nil
  1804. case <-time.After(2 * time.Second):
  1805. return errors.New("timeout waiting for Write in handler")
  1806. }
  1807. }, func(st *serverTester) {
  1808. if err := st.fr.WriteSettings(
  1809. Setting{SettingInitialWindowSize, 0},
  1810. Setting{SettingMaxFrameSize, maxFrameSize},
  1811. ); err != nil {
  1812. t.Fatal(err)
  1813. }
  1814. st.wantSettingsAck()
  1815. getSlash(st) // make the single request
  1816. hf := st.wantHeaders()
  1817. if hf.StreamEnded() {
  1818. t.Fatal("unexpected END_STREAM flag")
  1819. }
  1820. if !hf.HeadersEnded() {
  1821. t.Fatal("want END_HEADERS flag")
  1822. }
  1823. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1824. t.Fatal(err)
  1825. }
  1826. })
  1827. }
  1828. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1829. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1830. w.(http.Flusher).Flush()
  1831. // Nothing; send empty DATA
  1832. return nil
  1833. }, func(st *serverTester) {
  1834. // Handler gets no data quota:
  1835. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1836. t.Fatal(err)
  1837. }
  1838. st.wantSettingsAck()
  1839. getSlash(st) // make the single request
  1840. hf := st.wantHeaders()
  1841. if hf.StreamEnded() {
  1842. t.Fatal("unexpected END_STREAM flag")
  1843. }
  1844. if !hf.HeadersEnded() {
  1845. t.Fatal("want END_HEADERS flag")
  1846. }
  1847. df := st.wantData()
  1848. if got := len(df.Data()); got != 0 {
  1849. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1850. }
  1851. if !df.StreamEnded() {
  1852. t.Fatal("DATA didn't have END_STREAM")
  1853. }
  1854. })
  1855. }
  1856. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1857. const msg = "foo"
  1858. const reply = "bar"
  1859. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1860. if v := r.Header.Get("Expect"); v != "" {
  1861. t.Errorf("Expect header = %q; want empty", v)
  1862. }
  1863. buf := make([]byte, len(msg))
  1864. // This read should trigger the 100-continue being sent.
  1865. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1866. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1867. }
  1868. _, err := io.WriteString(w, reply)
  1869. return err
  1870. }, func(st *serverTester) {
  1871. st.writeHeaders(HeadersFrameParam{
  1872. StreamID: 1, // clients send odd numbers
  1873. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1874. EndStream: false,
  1875. EndHeaders: true,
  1876. })
  1877. hf := st.wantHeaders()
  1878. if hf.StreamEnded() {
  1879. t.Fatal("unexpected END_STREAM flag")
  1880. }
  1881. if !hf.HeadersEnded() {
  1882. t.Fatal("want END_HEADERS flag")
  1883. }
  1884. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1885. wanth := [][2]string{
  1886. {":status", "100"},
  1887. }
  1888. if !reflect.DeepEqual(goth, wanth) {
  1889. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1890. }
  1891. // Okay, they sent status 100, so we can send our
  1892. // gigantic and/or sensitive "foo" payload now.
  1893. st.writeData(1, true, []byte(msg))
  1894. st.wantWindowUpdate(0, uint32(len(msg)))
  1895. hf = st.wantHeaders()
  1896. if hf.StreamEnded() {
  1897. t.Fatal("expected data to follow")
  1898. }
  1899. if !hf.HeadersEnded() {
  1900. t.Fatal("want END_HEADERS flag")
  1901. }
  1902. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1903. wanth = [][2]string{
  1904. {":status", "200"},
  1905. {"content-type", "text/plain; charset=utf-8"},
  1906. {"content-length", strconv.Itoa(len(reply))},
  1907. }
  1908. if !reflect.DeepEqual(goth, wanth) {
  1909. t.Errorf("Got headers %v; want %v", goth, wanth)
  1910. }
  1911. df := st.wantData()
  1912. if string(df.Data()) != reply {
  1913. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1914. }
  1915. if !df.StreamEnded() {
  1916. t.Errorf("expect data stream end")
  1917. }
  1918. })
  1919. }
  1920. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1921. errc := make(chan error, 1)
  1922. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1923. p := []byte("some data.\n")
  1924. for {
  1925. _, err := w.Write(p)
  1926. if err != nil {
  1927. errc <- err
  1928. return nil
  1929. }
  1930. }
  1931. }, func(st *serverTester) {
  1932. st.writeHeaders(HeadersFrameParam{
  1933. StreamID: 1,
  1934. BlockFragment: st.encodeHeader(),
  1935. EndStream: false,
  1936. EndHeaders: true,
  1937. })
  1938. hf := st.wantHeaders()
  1939. if hf.StreamEnded() {
  1940. t.Fatal("unexpected END_STREAM flag")
  1941. }
  1942. if !hf.HeadersEnded() {
  1943. t.Fatal("want END_HEADERS flag")
  1944. }
  1945. // Close the connection and wait for the handler to (hopefully) notice.
  1946. st.cc.Close()
  1947. select {
  1948. case <-errc:
  1949. case <-time.After(5 * time.Second):
  1950. t.Error("timeout")
  1951. }
  1952. })
  1953. }
  1954. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1955. const testPath = "/some/path"
  1956. inHandler := make(chan uint32)
  1957. leaveHandler := make(chan bool)
  1958. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1959. id := w.(*responseWriter).rws.stream.id
  1960. inHandler <- id
  1961. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1962. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1963. }
  1964. <-leaveHandler
  1965. })
  1966. defer st.Close()
  1967. st.greet()
  1968. nextStreamID := uint32(1)
  1969. streamID := func() uint32 {
  1970. defer func() { nextStreamID += 2 }()
  1971. return nextStreamID
  1972. }
  1973. sendReq := func(id uint32, headers ...string) {
  1974. st.writeHeaders(HeadersFrameParam{
  1975. StreamID: id,
  1976. BlockFragment: st.encodeHeader(headers...),
  1977. EndStream: true,
  1978. EndHeaders: true,
  1979. })
  1980. }
  1981. for i := 0; i < defaultMaxStreams; i++ {
  1982. sendReq(streamID())
  1983. <-inHandler
  1984. }
  1985. defer func() {
  1986. for i := 0; i < defaultMaxStreams; i++ {
  1987. leaveHandler <- true
  1988. }
  1989. }()
  1990. // And this one should cross the limit:
  1991. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  1992. // even if we're rejecting it)
  1993. rejectID := streamID()
  1994. headerBlock := st.encodeHeader(":path", testPath)
  1995. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  1996. st.writeHeaders(HeadersFrameParam{
  1997. StreamID: rejectID,
  1998. BlockFragment: frag1,
  1999. EndStream: true,
  2000. EndHeaders: false, // CONTINUATION coming
  2001. })
  2002. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2003. t.Fatal(err)
  2004. }
  2005. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2006. // But let a handler finish:
  2007. leaveHandler <- true
  2008. st.wantHeaders()
  2009. // And now another stream should be able to start:
  2010. goodID := streamID()
  2011. sendReq(goodID, ":path", testPath)
  2012. select {
  2013. case got := <-inHandler:
  2014. if got != goodID {
  2015. t.Errorf("Got stream %d; want %d", got, goodID)
  2016. }
  2017. case <-time.After(3 * time.Second):
  2018. t.Error("timeout waiting for handler")
  2019. }
  2020. }
  2021. // So many response headers that the server needs to use CONTINUATION frames:
  2022. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2023. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2024. h := w.Header()
  2025. for i := 0; i < 5000; i++ {
  2026. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2027. }
  2028. return nil
  2029. }, func(st *serverTester) {
  2030. getSlash(st)
  2031. hf := st.wantHeaders()
  2032. if hf.HeadersEnded() {
  2033. t.Fatal("got unwanted END_HEADERS flag")
  2034. }
  2035. n := 0
  2036. for {
  2037. n++
  2038. cf := st.wantContinuation()
  2039. if cf.HeadersEnded() {
  2040. break
  2041. }
  2042. }
  2043. if n < 5 {
  2044. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2045. }
  2046. })
  2047. }
  2048. // This previously crashed (reported by Mathieu Lonjaret as observed
  2049. // while using Camlistore) because we got a DATA frame from the client
  2050. // after the handler exited and our logic at the time was wrong,
  2051. // keeping a stream in the map in stateClosed, which tickled an
  2052. // invariant check later when we tried to remove that stream (via
  2053. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2054. // ended.
  2055. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2056. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2057. // nothing
  2058. return nil
  2059. }, func(st *serverTester) {
  2060. st.writeHeaders(HeadersFrameParam{
  2061. StreamID: 1,
  2062. BlockFragment: st.encodeHeader(),
  2063. EndStream: false, // DATA is coming
  2064. EndHeaders: true,
  2065. })
  2066. hf := st.wantHeaders()
  2067. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2068. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2069. }
  2070. // Sent when the a Handler closes while a client has
  2071. // indicated it's still sending DATA:
  2072. st.wantRSTStream(1, ErrCodeCancel)
  2073. // Now the handler has ended, so it's ended its
  2074. // stream, but the client hasn't closed its side
  2075. // (stateClosedLocal). So send more data and verify
  2076. // it doesn't crash with an internal invariant panic, like
  2077. // it did before.
  2078. st.writeData(1, true, []byte("foo"))
  2079. // Get our flow control bytes back, since the handler didn't get them.
  2080. st.wantWindowUpdate(0, uint32(len("foo")))
  2081. // Sent after a peer sends data anyway (admittedly the
  2082. // previous RST_STREAM might've still been in-flight),
  2083. // but they'll get the more friendly 'cancel' code
  2084. // first.
  2085. st.wantRSTStream(1, ErrCodeStreamClosed)
  2086. // Set up a bunch of machinery to record the panic we saw
  2087. // previously.
  2088. var (
  2089. panMu sync.Mutex
  2090. panicVal interface{}
  2091. )
  2092. testHookOnPanicMu.Lock()
  2093. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2094. panMu.Lock()
  2095. panicVal = pv
  2096. panMu.Unlock()
  2097. return true
  2098. }
  2099. testHookOnPanicMu.Unlock()
  2100. // Now force the serve loop to end, via closing the connection.
  2101. st.cc.Close()
  2102. select {
  2103. case <-st.sc.doneServing:
  2104. // Loop has exited.
  2105. panMu.Lock()
  2106. got := panicVal
  2107. panMu.Unlock()
  2108. if got != nil {
  2109. t.Errorf("Got panic: %v", got)
  2110. }
  2111. case <-time.After(5 * time.Second):
  2112. t.Error("timeout")
  2113. }
  2114. })
  2115. }
  2116. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2117. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2118. func testRejectTLS(t *testing.T, max uint16) {
  2119. st := newServerTester(t, nil, func(c *tls.Config) {
  2120. c.MaxVersion = max
  2121. })
  2122. defer st.Close()
  2123. gf := st.wantGoAway()
  2124. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2125. t.Errorf("Got error code %v; want %v", got, want)
  2126. }
  2127. }
  2128. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2129. st := newServerTester(t, nil, func(c *tls.Config) {
  2130. // Only list bad ones:
  2131. c.CipherSuites = []uint16{
  2132. tls.TLS_RSA_WITH_RC4_128_SHA,
  2133. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2134. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2135. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2136. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2137. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2138. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2139. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2140. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2141. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2142. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2143. }
  2144. })
  2145. defer st.Close()
  2146. gf := st.wantGoAway()
  2147. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2148. t.Errorf("Got error code %v; want %v", got, want)
  2149. }
  2150. }
  2151. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2152. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2153. st := newServerTester(t, nil, func(c *tls.Config) {
  2154. // Have the client only support the one required by the spec.
  2155. c.CipherSuites = []uint16{requiredSuite}
  2156. }, func(ts *httptest.Server) {
  2157. var srv *http.Server = ts.Config
  2158. // Have the server configured with no specific cipher suites.
  2159. // This tests that Go's defaults include the required one.
  2160. srv.TLSConfig = nil
  2161. })
  2162. defer st.Close()
  2163. st.greet()
  2164. }
  2165. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2166. if f.Name == "date" {
  2167. return
  2168. }
  2169. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2170. }
  2171. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2172. st.decodedHeaders = nil
  2173. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2174. st.t.Fatalf("hpack decoding error: %v", err)
  2175. }
  2176. if err := st.hpackDec.Close(); err != nil {
  2177. st.t.Fatalf("hpack decoding error: %v", err)
  2178. }
  2179. return st.decodedHeaders
  2180. }
  2181. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2182. // write a single request that must be handled by the handler. This waits up to 5s
  2183. // for client to return, then up to an additional 2s for the handler to return.
  2184. func testServerResponse(t testing.TB,
  2185. handler func(http.ResponseWriter, *http.Request) error,
  2186. client func(*serverTester),
  2187. ) {
  2188. errc := make(chan error, 1)
  2189. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2190. if r.Body == nil {
  2191. t.Fatal("nil Body")
  2192. }
  2193. errc <- handler(w, r)
  2194. })
  2195. defer st.Close()
  2196. donec := make(chan bool)
  2197. go func() {
  2198. defer close(donec)
  2199. st.greet()
  2200. client(st)
  2201. }()
  2202. select {
  2203. case <-donec:
  2204. case <-time.After(5 * time.Second):
  2205. t.Fatal("timeout in client")
  2206. }
  2207. select {
  2208. case err := <-errc:
  2209. if err != nil {
  2210. t.Fatalf("Error in handler: %v", err)
  2211. }
  2212. case <-time.After(2 * time.Second):
  2213. t.Fatal("timeout in handler")
  2214. }
  2215. }
  2216. // readBodyHandler returns an http Handler func that reads len(want)
  2217. // bytes from r.Body and fails t if the contents read were not
  2218. // the value of want.
  2219. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2220. return func(w http.ResponseWriter, r *http.Request) {
  2221. buf := make([]byte, len(want))
  2222. _, err := io.ReadFull(r.Body, buf)
  2223. if err != nil {
  2224. t.Error(err)
  2225. return
  2226. }
  2227. if string(buf) != want {
  2228. t.Errorf("read %q; want %q", buf, want)
  2229. }
  2230. }
  2231. }
  2232. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2233. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2234. // http://sourceforge.net/p/curl/bugs/1472/
  2235. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2236. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2237. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2238. if runtime.GOOS != "linux" {
  2239. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2240. }
  2241. if testing.Short() {
  2242. t.Skip("skipping curl test in short mode")
  2243. }
  2244. requireCurl(t)
  2245. var gotConn int32
  2246. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2247. const msg = "Hello from curl!\n"
  2248. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2249. w.Header().Set("Foo", "Bar")
  2250. w.Header().Set("Client-Proto", r.Proto)
  2251. io.WriteString(w, msg)
  2252. }))
  2253. ConfigureServer(ts.Config, &Server{
  2254. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2255. })
  2256. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2257. ts.StartTLS()
  2258. defer ts.Close()
  2259. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2260. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2261. defer kill(container)
  2262. resc := make(chan interface{}, 1)
  2263. go func() {
  2264. res, err := dockerLogs(container)
  2265. if err != nil {
  2266. resc <- err
  2267. } else {
  2268. resc <- res
  2269. }
  2270. }()
  2271. select {
  2272. case res := <-resc:
  2273. if err, ok := res.(error); ok {
  2274. t.Fatal(err)
  2275. }
  2276. body := string(res.([]byte))
  2277. // Search for both "key: value" and "key:value", since curl changed their format
  2278. // Our Dockerfile contains the latest version (no space), but just in case people
  2279. // didn't rebuild, check both.
  2280. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2281. t.Errorf("didn't see foo: Bar header")
  2282. t.Logf("Got: %s", body)
  2283. }
  2284. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2285. t.Errorf("didn't see client-proto: HTTP/2 header")
  2286. t.Logf("Got: %s", res)
  2287. }
  2288. if !strings.Contains(string(res.([]byte)), msg) {
  2289. t.Errorf("didn't see %q content", msg)
  2290. t.Logf("Got: %s", res)
  2291. }
  2292. case <-time.After(3 * time.Second):
  2293. t.Errorf("timeout waiting for curl")
  2294. }
  2295. if atomic.LoadInt32(&gotConn) == 0 {
  2296. t.Error("never saw an http2 connection")
  2297. }
  2298. }
  2299. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2300. func TestServerWithH2Load(t *testing.T) {
  2301. if !*doh2load {
  2302. t.Skip("Skipping without --h2load flag.")
  2303. }
  2304. if runtime.GOOS != "linux" {
  2305. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2306. }
  2307. requireH2load(t)
  2308. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2309. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2310. io.WriteString(w, msg)
  2311. w.(http.Flusher).Flush()
  2312. io.WriteString(w, msg)
  2313. }))
  2314. ts.StartTLS()
  2315. defer ts.Close()
  2316. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2317. "-n100000", "-c100", "-m100", ts.URL)
  2318. cmd.Stdout = os.Stdout
  2319. cmd.Stderr = os.Stderr
  2320. if err := cmd.Run(); err != nil {
  2321. t.Fatal(err)
  2322. }
  2323. }
  2324. // Issue 12843
  2325. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2326. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2327. defer st.Close()
  2328. // shake hands
  2329. st.writePreface()
  2330. st.writeInitialSettings()
  2331. frameSize := defaultMaxReadFrameSize
  2332. var advHeaderListSize *uint32
  2333. st.wantSettings().ForeachSetting(func(s Setting) error {
  2334. switch s.ID {
  2335. case SettingMaxFrameSize:
  2336. if s.Val < minMaxFrameSize {
  2337. frameSize = minMaxFrameSize
  2338. } else if s.Val > maxFrameSize {
  2339. frameSize = maxFrameSize
  2340. } else {
  2341. frameSize = int(s.Val)
  2342. }
  2343. case SettingMaxHeaderListSize:
  2344. advHeaderListSize = &s.Val
  2345. }
  2346. return nil
  2347. })
  2348. st.writeSettingsAck()
  2349. st.wantSettingsAck()
  2350. if advHeaderListSize == nil {
  2351. t.Errorf("server didn't advertise a max header list size")
  2352. } else if *advHeaderListSize == 0 {
  2353. t.Errorf("server advertised a max header list size of 0")
  2354. }
  2355. st.encodeHeaderField(":method", "GET")
  2356. st.encodeHeaderField(":path", "/")
  2357. st.encodeHeaderField(":scheme", "https")
  2358. cookie := strings.Repeat("*", 4058)
  2359. st.encodeHeaderField("cookie", cookie)
  2360. st.writeHeaders(HeadersFrameParam{
  2361. StreamID: 1,
  2362. BlockFragment: st.headerBuf.Bytes(),
  2363. EndStream: true,
  2364. EndHeaders: false,
  2365. })
  2366. // Capture the short encoding of a duplicate ~4K cookie, now
  2367. // that we've already sent it once.
  2368. st.headerBuf.Reset()
  2369. st.encodeHeaderField("cookie", cookie)
  2370. // Now send 1MB of it.
  2371. const size = 1 << 20
  2372. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2373. for len(b) > 0 {
  2374. chunk := b
  2375. if len(chunk) > frameSize {
  2376. chunk = chunk[:frameSize]
  2377. }
  2378. b = b[len(chunk):]
  2379. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2380. }
  2381. h := st.wantHeaders()
  2382. if !h.HeadersEnded() {
  2383. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2384. }
  2385. headers := st.decodeHeader(h.HeaderBlockFragment())
  2386. want := [][2]string{
  2387. {":status", "431"},
  2388. {"content-type", "text/html; charset=utf-8"},
  2389. {"content-length", "63"},
  2390. }
  2391. if !reflect.DeepEqual(headers, want) {
  2392. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2393. }
  2394. }
  2395. func TestCompressionErrorOnWrite(t *testing.T) {
  2396. const maxStrLen = 8 << 10
  2397. var serverConfig *http.Server
  2398. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2399. // No response body.
  2400. }, func(ts *httptest.Server) {
  2401. serverConfig = ts.Config
  2402. serverConfig.MaxHeaderBytes = maxStrLen
  2403. })
  2404. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2405. defer st.Close()
  2406. st.greet()
  2407. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2408. // Crank this up, now that we have a conn connected with the
  2409. // hpack.Decoder's max string length set has been initialized
  2410. // from the earlier low ~8K value. We want this higher so don't
  2411. // hit the max header list size. We only want to test hitting
  2412. // the max string size.
  2413. serverConfig.MaxHeaderBytes = 1 << 20
  2414. // First a request with a header that's exactly the max allowed size
  2415. // for the hpack compression. It's still too long for the header list
  2416. // size, so we'll get the 431 error, but that keeps the compression
  2417. // context still valid.
  2418. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2419. st.writeHeaders(HeadersFrameParam{
  2420. StreamID: 1,
  2421. BlockFragment: hbf,
  2422. EndStream: true,
  2423. EndHeaders: true,
  2424. })
  2425. h := st.wantHeaders()
  2426. if !h.HeadersEnded() {
  2427. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2428. }
  2429. headers := st.decodeHeader(h.HeaderBlockFragment())
  2430. want := [][2]string{
  2431. {":status", "431"},
  2432. {"content-type", "text/html; charset=utf-8"},
  2433. {"content-length", "63"},
  2434. }
  2435. if !reflect.DeepEqual(headers, want) {
  2436. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2437. }
  2438. df := st.wantData()
  2439. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2440. t.Errorf("Unexpected data body: %q", df.Data())
  2441. }
  2442. if !df.StreamEnded() {
  2443. t.Fatalf("expect data stream end")
  2444. }
  2445. // And now send one that's just one byte too big.
  2446. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2447. st.writeHeaders(HeadersFrameParam{
  2448. StreamID: 3,
  2449. BlockFragment: hbf,
  2450. EndStream: true,
  2451. EndHeaders: true,
  2452. })
  2453. ga := st.wantGoAway()
  2454. if ga.ErrCode != ErrCodeCompression {
  2455. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2456. }
  2457. }
  2458. func TestCompressionErrorOnClose(t *testing.T) {
  2459. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2460. // No response body.
  2461. })
  2462. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2463. defer st.Close()
  2464. st.greet()
  2465. hbf := st.encodeHeader("foo", "bar")
  2466. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2467. st.writeHeaders(HeadersFrameParam{
  2468. StreamID: 1,
  2469. BlockFragment: hbf,
  2470. EndStream: true,
  2471. EndHeaders: true,
  2472. })
  2473. ga := st.wantGoAway()
  2474. if ga.ErrCode != ErrCodeCompression {
  2475. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2476. }
  2477. }
  2478. // test that a server handler can read trailers from a client
  2479. func TestServerReadsTrailers(t *testing.T) {
  2480. const testBody = "some test body"
  2481. writeReq := func(st *serverTester) {
  2482. st.writeHeaders(HeadersFrameParam{
  2483. StreamID: 1, // clients send odd numbers
  2484. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2485. EndStream: false,
  2486. EndHeaders: true,
  2487. })
  2488. st.writeData(1, false, []byte(testBody))
  2489. st.writeHeaders(HeadersFrameParam{
  2490. StreamID: 1, // clients send odd numbers
  2491. BlockFragment: st.encodeHeaderRaw(
  2492. "foo", "foov",
  2493. "bar", "barv",
  2494. "baz", "bazv",
  2495. "surprise", "wasn't declared; shouldn't show up",
  2496. ),
  2497. EndStream: true,
  2498. EndHeaders: true,
  2499. })
  2500. }
  2501. checkReq := func(r *http.Request) {
  2502. wantTrailer := http.Header{
  2503. "Foo": nil,
  2504. "Bar": nil,
  2505. "Baz": nil,
  2506. }
  2507. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2508. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2509. }
  2510. slurp, err := ioutil.ReadAll(r.Body)
  2511. if string(slurp) != testBody {
  2512. t.Errorf("read body %q; want %q", slurp, testBody)
  2513. }
  2514. if err != nil {
  2515. t.Fatalf("Body slurp: %v", err)
  2516. }
  2517. wantTrailerAfter := http.Header{
  2518. "Foo": {"foov"},
  2519. "Bar": {"barv"},
  2520. "Baz": {"bazv"},
  2521. }
  2522. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2523. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2524. }
  2525. }
  2526. testServerRequest(t, writeReq, checkReq)
  2527. }
  2528. // test that a server handler can send trailers
  2529. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2530. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2531. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2532. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2533. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2534. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2535. w.Header().Add("Trailer", "Server-Trailer-C")
  2536. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2537. // Regular headers:
  2538. w.Header().Set("Foo", "Bar")
  2539. w.Header().Set("Content-Length", "5") // len("Hello")
  2540. io.WriteString(w, "Hello")
  2541. if withFlush {
  2542. w.(http.Flusher).Flush()
  2543. }
  2544. w.Header().Set("Server-Trailer-A", "valuea")
  2545. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2546. // After a flush, random keys like Server-Surprise shouldn't show up:
  2547. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2548. // But we do permit promoting keys to trailers after a
  2549. // flush if they start with the magic
  2550. // otherwise-invalid "Trailer:" prefix:
  2551. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2552. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2553. w.Header().Set("Trailer:Range", "invalid")
  2554. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2555. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2556. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2557. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2558. return nil
  2559. }, func(st *serverTester) {
  2560. getSlash(st)
  2561. hf := st.wantHeaders()
  2562. if hf.StreamEnded() {
  2563. t.Fatal("response HEADERS had END_STREAM")
  2564. }
  2565. if !hf.HeadersEnded() {
  2566. t.Fatal("response HEADERS didn't have END_HEADERS")
  2567. }
  2568. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2569. wanth := [][2]string{
  2570. {":status", "200"},
  2571. {"foo", "Bar"},
  2572. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2573. {"trailer", "Server-Trailer-C"},
  2574. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2575. {"content-type", "text/plain; charset=utf-8"},
  2576. {"content-length", "5"},
  2577. }
  2578. if !reflect.DeepEqual(goth, wanth) {
  2579. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2580. }
  2581. df := st.wantData()
  2582. if string(df.Data()) != "Hello" {
  2583. t.Fatalf("Client read %q; want Hello", df.Data())
  2584. }
  2585. if df.StreamEnded() {
  2586. t.Fatalf("data frame had STREAM_ENDED")
  2587. }
  2588. tf := st.wantHeaders() // for the trailers
  2589. if !tf.StreamEnded() {
  2590. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2591. }
  2592. if !tf.HeadersEnded() {
  2593. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2594. }
  2595. wanth = [][2]string{
  2596. {"post-header-trailer", "hi1"},
  2597. {"post-header-trailer2", "hi2"},
  2598. {"server-trailer-a", "valuea"},
  2599. {"server-trailer-c", "valuec"},
  2600. }
  2601. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2602. if !reflect.DeepEqual(goth, wanth) {
  2603. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2604. }
  2605. })
  2606. }
  2607. // validate transmitted header field names & values
  2608. // golang.org/issue/14048
  2609. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2610. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2611. w.Header().Add("OK1", "x")
  2612. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2613. w.Header().Add("Bad1\x00", "x") // null in key
  2614. w.Header().Add("Bad2", "x\x00y") // null in value
  2615. return nil
  2616. }, func(st *serverTester) {
  2617. getSlash(st)
  2618. hf := st.wantHeaders()
  2619. if !hf.StreamEnded() {
  2620. t.Error("response HEADERS lacked END_STREAM")
  2621. }
  2622. if !hf.HeadersEnded() {
  2623. t.Fatal("response HEADERS didn't have END_HEADERS")
  2624. }
  2625. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2626. wanth := [][2]string{
  2627. {":status", "200"},
  2628. {"ok1", "x"},
  2629. {"content-type", "text/plain; charset=utf-8"},
  2630. {"content-length", "0"},
  2631. }
  2632. if !reflect.DeepEqual(goth, wanth) {
  2633. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2634. }
  2635. })
  2636. }
  2637. func BenchmarkServerGets(b *testing.B) {
  2638. defer disableGoroutineTracking()()
  2639. b.ReportAllocs()
  2640. const msg = "Hello, world"
  2641. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2642. io.WriteString(w, msg)
  2643. })
  2644. defer st.Close()
  2645. st.greet()
  2646. // Give the server quota to reply. (plus it has the the 64KB)
  2647. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2648. b.Fatal(err)
  2649. }
  2650. for i := 0; i < b.N; i++ {
  2651. id := 1 + uint32(i)*2
  2652. st.writeHeaders(HeadersFrameParam{
  2653. StreamID: id,
  2654. BlockFragment: st.encodeHeader(),
  2655. EndStream: true,
  2656. EndHeaders: true,
  2657. })
  2658. st.wantHeaders()
  2659. df := st.wantData()
  2660. if !df.StreamEnded() {
  2661. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2662. }
  2663. }
  2664. }
  2665. func BenchmarkServerPosts(b *testing.B) {
  2666. defer disableGoroutineTracking()()
  2667. b.ReportAllocs()
  2668. const msg = "Hello, world"
  2669. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2670. // Consume the (empty) body from th peer before replying, otherwise
  2671. // the server will sometimes (depending on scheduling) send the peer a
  2672. // a RST_STREAM with the CANCEL error code.
  2673. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2674. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2675. }
  2676. io.WriteString(w, msg)
  2677. })
  2678. defer st.Close()
  2679. st.greet()
  2680. // Give the server quota to reply. (plus it has the the 64KB)
  2681. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2682. b.Fatal(err)
  2683. }
  2684. for i := 0; i < b.N; i++ {
  2685. id := 1 + uint32(i)*2
  2686. st.writeHeaders(HeadersFrameParam{
  2687. StreamID: id,
  2688. BlockFragment: st.encodeHeader(":method", "POST"),
  2689. EndStream: false,
  2690. EndHeaders: true,
  2691. })
  2692. st.writeData(id, true, nil)
  2693. st.wantHeaders()
  2694. df := st.wantData()
  2695. if !df.StreamEnded() {
  2696. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2697. }
  2698. }
  2699. }
  2700. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2701. // Verify we don't hang.
  2702. func TestIssue53(t *testing.T) {
  2703. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2704. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2705. s := &http.Server{
  2706. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2707. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2708. w.Write([]byte("hello"))
  2709. }),
  2710. }
  2711. s2 := &Server{
  2712. MaxReadFrameSize: 1 << 16,
  2713. PermitProhibitedCipherSuites: true,
  2714. }
  2715. c := &issue53Conn{[]byte(data), false, false}
  2716. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2717. if !c.closed {
  2718. t.Fatal("connection is not closed")
  2719. }
  2720. }
  2721. type issue53Conn struct {
  2722. data []byte
  2723. closed bool
  2724. written bool
  2725. }
  2726. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2727. if len(c.data) == 0 {
  2728. return 0, io.EOF
  2729. }
  2730. n = copy(b, c.data)
  2731. c.data = c.data[n:]
  2732. return
  2733. }
  2734. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2735. c.written = true
  2736. return len(b), nil
  2737. }
  2738. func (c *issue53Conn) Close() error {
  2739. c.closed = true
  2740. return nil
  2741. }
  2742. func (c *issue53Conn) LocalAddr() net.Addr {
  2743. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2744. }
  2745. func (c *issue53Conn) RemoteAddr() net.Addr {
  2746. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2747. }
  2748. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2749. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2750. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2751. // golang.org/issue/12895
  2752. func TestConfigureServer(t *testing.T) {
  2753. tests := []struct {
  2754. name string
  2755. tlsConfig *tls.Config
  2756. wantErr string
  2757. }{
  2758. {
  2759. name: "empty server",
  2760. },
  2761. {
  2762. name: "just the required cipher suite",
  2763. tlsConfig: &tls.Config{
  2764. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2765. },
  2766. },
  2767. {
  2768. name: "missing required cipher suite",
  2769. tlsConfig: &tls.Config{
  2770. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2771. },
  2772. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2773. },
  2774. {
  2775. name: "required after bad",
  2776. tlsConfig: &tls.Config{
  2777. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2778. },
  2779. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2780. },
  2781. {
  2782. name: "bad after required",
  2783. tlsConfig: &tls.Config{
  2784. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2785. },
  2786. },
  2787. }
  2788. for _, tt := range tests {
  2789. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2790. err := ConfigureServer(srv, nil)
  2791. if (err != nil) != (tt.wantErr != "") {
  2792. if tt.wantErr != "" {
  2793. t.Errorf("%s: success, but want error", tt.name)
  2794. } else {
  2795. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2796. }
  2797. }
  2798. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2799. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2800. }
  2801. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2802. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2803. }
  2804. }
  2805. }
  2806. func TestServerRejectHeadWithBody(t *testing.T) {
  2807. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2808. // No response body.
  2809. })
  2810. defer st.Close()
  2811. st.greet()
  2812. st.writeHeaders(HeadersFrameParam{
  2813. StreamID: 1, // clients send odd numbers
  2814. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2815. EndStream: false, // what we're testing, a bogus HEAD request with body
  2816. EndHeaders: true,
  2817. })
  2818. st.wantRSTStream(1, ErrCodeProtocol)
  2819. }
  2820. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2821. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2822. // No response body. (or smaller than one frame)
  2823. })
  2824. defer st.Close()
  2825. st.greet()
  2826. st.writeHeaders(HeadersFrameParam{
  2827. StreamID: 1, // clients send odd numbers
  2828. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2829. EndStream: true,
  2830. EndHeaders: true,
  2831. })
  2832. h := st.wantHeaders()
  2833. headers := st.decodeHeader(h.HeaderBlockFragment())
  2834. want := [][2]string{
  2835. {":status", "200"},
  2836. {"content-type", "text/plain; charset=utf-8"},
  2837. }
  2838. if !reflect.DeepEqual(headers, want) {
  2839. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2840. }
  2841. }
  2842. // golang.org/issue/13495
  2843. func TestServerNoDuplicateContentType(t *testing.T) {
  2844. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2845. w.Header()["Content-Type"] = []string{""}
  2846. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2847. })
  2848. defer st.Close()
  2849. st.greet()
  2850. st.writeHeaders(HeadersFrameParam{
  2851. StreamID: 1,
  2852. BlockFragment: st.encodeHeader(),
  2853. EndStream: true,
  2854. EndHeaders: true,
  2855. })
  2856. h := st.wantHeaders()
  2857. headers := st.decodeHeader(h.HeaderBlockFragment())
  2858. want := [][2]string{
  2859. {":status", "200"},
  2860. {"content-type", ""},
  2861. {"content-length", "41"},
  2862. }
  2863. if !reflect.DeepEqual(headers, want) {
  2864. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2865. }
  2866. }
  2867. func disableGoroutineTracking() (restore func()) {
  2868. old := DebugGoroutines
  2869. DebugGoroutines = false
  2870. return func() { DebugGoroutines = old }
  2871. }
  2872. func BenchmarkServer_GetRequest(b *testing.B) {
  2873. defer disableGoroutineTracking()()
  2874. b.ReportAllocs()
  2875. const msg = "Hello, world."
  2876. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2877. n, err := io.Copy(ioutil.Discard, r.Body)
  2878. if err != nil || n > 0 {
  2879. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2880. }
  2881. io.WriteString(w, msg)
  2882. })
  2883. defer st.Close()
  2884. st.greet()
  2885. // Give the server quota to reply. (plus it has the the 64KB)
  2886. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2887. b.Fatal(err)
  2888. }
  2889. hbf := st.encodeHeader(":method", "GET")
  2890. for i := 0; i < b.N; i++ {
  2891. streamID := uint32(1 + 2*i)
  2892. st.writeHeaders(HeadersFrameParam{
  2893. StreamID: streamID,
  2894. BlockFragment: hbf,
  2895. EndStream: true,
  2896. EndHeaders: true,
  2897. })
  2898. st.wantHeaders()
  2899. st.wantData()
  2900. }
  2901. }
  2902. func BenchmarkServer_PostRequest(b *testing.B) {
  2903. defer disableGoroutineTracking()()
  2904. b.ReportAllocs()
  2905. const msg = "Hello, world."
  2906. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2907. n, err := io.Copy(ioutil.Discard, r.Body)
  2908. if err != nil || n > 0 {
  2909. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2910. }
  2911. io.WriteString(w, msg)
  2912. })
  2913. defer st.Close()
  2914. st.greet()
  2915. // Give the server quota to reply. (plus it has the the 64KB)
  2916. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2917. b.Fatal(err)
  2918. }
  2919. hbf := st.encodeHeader(":method", "POST")
  2920. for i := 0; i < b.N; i++ {
  2921. streamID := uint32(1 + 2*i)
  2922. st.writeHeaders(HeadersFrameParam{
  2923. StreamID: streamID,
  2924. BlockFragment: hbf,
  2925. EndStream: false,
  2926. EndHeaders: true,
  2927. })
  2928. st.writeData(streamID, true, nil)
  2929. st.wantHeaders()
  2930. st.wantData()
  2931. }
  2932. }
  2933. type connStateConn struct {
  2934. net.Conn
  2935. cs tls.ConnectionState
  2936. }
  2937. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  2938. // golang.org/issue/12737 -- handle any net.Conn, not just
  2939. // *tls.Conn.
  2940. func TestServerHandleCustomConn(t *testing.T) {
  2941. var s Server
  2942. c1, c2 := net.Pipe()
  2943. clientDone := make(chan struct{})
  2944. handlerDone := make(chan struct{})
  2945. var req *http.Request
  2946. go func() {
  2947. defer close(clientDone)
  2948. defer c2.Close()
  2949. fr := NewFramer(c2, c2)
  2950. io.WriteString(c2, ClientPreface)
  2951. fr.WriteSettings()
  2952. fr.WriteSettingsAck()
  2953. f, err := fr.ReadFrame()
  2954. if err != nil {
  2955. t.Error(err)
  2956. return
  2957. }
  2958. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  2959. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  2960. return
  2961. }
  2962. f, err = fr.ReadFrame()
  2963. if err != nil {
  2964. t.Error(err)
  2965. return
  2966. }
  2967. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  2968. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  2969. return
  2970. }
  2971. var henc hpackEncoder
  2972. fr.WriteHeaders(HeadersFrameParam{
  2973. StreamID: 1,
  2974. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  2975. EndStream: true,
  2976. EndHeaders: true,
  2977. })
  2978. go io.Copy(ioutil.Discard, c2)
  2979. <-handlerDone
  2980. }()
  2981. const testString = "my custom ConnectionState"
  2982. fakeConnState := tls.ConnectionState{
  2983. ServerName: testString,
  2984. Version: tls.VersionTLS12,
  2985. }
  2986. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  2987. BaseConfig: &http.Server{
  2988. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2989. defer close(handlerDone)
  2990. req = r
  2991. }),
  2992. }})
  2993. select {
  2994. case <-clientDone:
  2995. case <-time.After(5 * time.Second):
  2996. t.Fatal("timeout waiting for handler")
  2997. }
  2998. if req.TLS == nil {
  2999. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3000. }
  3001. if req.TLS.ServerName != testString {
  3002. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3003. }
  3004. }
  3005. // golang.org/issue/14214
  3006. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3007. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3008. t.Error("should not get to Handler")
  3009. })
  3010. defer st.Close()
  3011. st.greet()
  3012. st.bodylessReq1("connection", "foo")
  3013. hf := st.wantHeaders()
  3014. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3015. wanth := [][2]string{
  3016. {":status", "400"},
  3017. {"content-type", "text/plain; charset=utf-8"},
  3018. {"x-content-type-options", "nosniff"},
  3019. {"content-length", "51"},
  3020. }
  3021. if !reflect.DeepEqual(goth, wanth) {
  3022. t.Errorf("Got headers %v; want %v", goth, wanth)
  3023. }
  3024. }
  3025. type hpackEncoder struct {
  3026. enc *hpack.Encoder
  3027. buf bytes.Buffer
  3028. }
  3029. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3030. if len(headers)%2 == 1 {
  3031. panic("odd number of kv args")
  3032. }
  3033. he.buf.Reset()
  3034. if he.enc == nil {
  3035. he.enc = hpack.NewEncoder(&he.buf)
  3036. }
  3037. for len(headers) > 0 {
  3038. k, v := headers[0], headers[1]
  3039. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3040. if err != nil {
  3041. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3042. }
  3043. headers = headers[2:]
  3044. }
  3045. return he.buf.Bytes()
  3046. }
  3047. func TestCheckValidHTTP2Request(t *testing.T) {
  3048. tests := []struct {
  3049. req *http.Request
  3050. want error
  3051. }{
  3052. {
  3053. req: &http.Request{Header: http.Header{"Te": {"trailers"}}},
  3054. want: nil,
  3055. },
  3056. {
  3057. req: &http.Request{Header: http.Header{"Te": {"trailers", "bogus"}}},
  3058. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3059. },
  3060. {
  3061. req: &http.Request{Header: http.Header{"Foo": {""}}},
  3062. want: nil,
  3063. },
  3064. {
  3065. req: &http.Request{Header: http.Header{"Connection": {""}}},
  3066. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3067. },
  3068. {
  3069. req: &http.Request{Header: http.Header{"Proxy-Connection": {""}}},
  3070. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3071. },
  3072. {
  3073. req: &http.Request{Header: http.Header{"Keep-Alive": {""}}},
  3074. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3075. },
  3076. {
  3077. req: &http.Request{Header: http.Header{"Upgrade": {""}}},
  3078. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3079. },
  3080. }
  3081. for i, tt := range tests {
  3082. got := checkValidHTTP2Request(tt.req)
  3083. if !reflect.DeepEqual(got, tt.want) {
  3084. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3085. }
  3086. }
  3087. }
  3088. // golang.org/issue/14030
  3089. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3090. const msg = "Hello"
  3091. const msg2 = "World"
  3092. doRead := make(chan bool, 1)
  3093. defer close(doRead) // fallback cleanup
  3094. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3095. io.WriteString(w, msg)
  3096. w.(http.Flusher).Flush()
  3097. // Do a read, which might force a 100-continue status to be sent.
  3098. <-doRead
  3099. r.Body.Read(make([]byte, 10))
  3100. io.WriteString(w, msg2)
  3101. }, optOnlyServer)
  3102. defer st.Close()
  3103. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3104. defer tr.CloseIdleConnections()
  3105. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3106. req.Header.Set("Expect", "100-continue")
  3107. res, err := tr.RoundTrip(req)
  3108. if err != nil {
  3109. t.Fatal(err)
  3110. }
  3111. defer res.Body.Close()
  3112. buf := make([]byte, len(msg))
  3113. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3114. t.Fatal(err)
  3115. }
  3116. if string(buf) != msg {
  3117. t.Fatalf("msg = %q; want %q", buf, msg)
  3118. }
  3119. doRead <- true
  3120. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3121. t.Fatal(err)
  3122. }
  3123. if string(buf) != msg2 {
  3124. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3125. }
  3126. }
  3127. type funcReader func([]byte) (n int, err error)
  3128. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3129. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3130. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3131. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3132. unblock := make(chan bool, 1)
  3133. defer close(unblock)
  3134. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3135. // Don't read the 16KB request body. Wait until the client's
  3136. // done sending it and then return. This should cause the Server
  3137. // to then return those 16KB of flow control to the client.
  3138. <-unblock
  3139. }, optOnlyServer)
  3140. defer st.Close()
  3141. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3142. defer tr.CloseIdleConnections()
  3143. // This previously hung on the 4th iteration.
  3144. for i := 0; i < 6; i++ {
  3145. body := io.MultiReader(
  3146. io.LimitReader(neverEnding('A'), 16<<10),
  3147. funcReader(func([]byte) (n int, err error) {
  3148. unblock <- true
  3149. return 0, io.EOF
  3150. }),
  3151. )
  3152. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3153. res, err := tr.RoundTrip(req)
  3154. if err != nil {
  3155. t.Fatal(err)
  3156. }
  3157. res.Body.Close()
  3158. }
  3159. }
  3160. func TestServerIdleTimeout(t *testing.T) {
  3161. if testing.Short() {
  3162. t.Skip("skipping in short mode")
  3163. }
  3164. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3165. }, func(h2s *Server) {
  3166. h2s.IdleTimeout = 500 * time.Millisecond
  3167. })
  3168. defer st.Close()
  3169. st.greet()
  3170. ga := st.wantGoAway()
  3171. if ga.ErrCode != ErrCodeNo {
  3172. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3173. }
  3174. }
  3175. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3176. if testing.Short() {
  3177. t.Skip("skipping in short mode")
  3178. }
  3179. const timeout = 250 * time.Millisecond
  3180. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3181. time.Sleep(timeout * 2)
  3182. }, func(h2s *Server) {
  3183. h2s.IdleTimeout = timeout
  3184. })
  3185. defer st.Close()
  3186. st.greet()
  3187. // Send a request which takes twice the timeout. Verifies the
  3188. // idle timeout doesn't fire while we're in a request:
  3189. st.bodylessReq1()
  3190. st.wantHeaders()
  3191. // But the idle timeout should be rearmed after the request
  3192. // is done:
  3193. ga := st.wantGoAway()
  3194. if ga.ErrCode != ErrCodeNo {
  3195. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3196. }
  3197. }
  3198. // grpc-go closes the Request.Body currently with a Read.
  3199. // Verify that it doesn't race.
  3200. // See https://github.com/grpc/grpc-go/pull/938
  3201. func TestRequestBodyReadCloseRace(t *testing.T) {
  3202. for i := 0; i < 100; i++ {
  3203. body := &requestBody{
  3204. pipe: &pipe{
  3205. b: new(bytes.Buffer),
  3206. },
  3207. }
  3208. body.pipe.CloseWithError(io.EOF)
  3209. done := make(chan bool, 1)
  3210. buf := make([]byte, 10)
  3211. go func() {
  3212. time.Sleep(1 * time.Millisecond)
  3213. body.Close()
  3214. done <- true
  3215. }()
  3216. body.Read(buf)
  3217. <-done
  3218. }
  3219. }