server_test.go 92 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. logBuf *bytes.Buffer
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // writing headers:
  48. headerBuf bytes.Buffer
  49. hpackEnc *hpack.Encoder
  50. // reading frames:
  51. frc chan Frame
  52. frErrc chan error
  53. readTimer *time.Timer
  54. }
  55. func init() {
  56. testHookOnPanicMu = new(sync.Mutex)
  57. }
  58. func resetHooks() {
  59. testHookOnPanicMu.Lock()
  60. testHookOnPanic = nil
  61. testHookOnPanicMu.Unlock()
  62. }
  63. type serverTesterOpt string
  64. var optOnlyServer = serverTesterOpt("only_server")
  65. var optQuiet = serverTesterOpt("quiet_logging")
  66. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  67. resetHooks()
  68. logBuf := new(bytes.Buffer)
  69. ts := httptest.NewUnstartedServer(handler)
  70. tlsConfig := &tls.Config{
  71. InsecureSkipVerify: true,
  72. // The h2-14 is temporary, until curl is updated. (as used by unit tests
  73. // in Docker)
  74. NextProtos: []string{NextProtoTLS, "h2-14"},
  75. }
  76. var onlyServer, quiet bool
  77. for _, opt := range opts {
  78. switch v := opt.(type) {
  79. case func(*tls.Config):
  80. v(tlsConfig)
  81. case func(*httptest.Server):
  82. v(ts)
  83. case serverTesterOpt:
  84. switch v {
  85. case optOnlyServer:
  86. onlyServer = true
  87. case optQuiet:
  88. quiet = true
  89. }
  90. case func(net.Conn, http.ConnState):
  91. ts.Config.ConnState = v
  92. default:
  93. t.Fatalf("unknown newServerTester option type %T", v)
  94. }
  95. }
  96. ConfigureServer(ts.Config, &Server{})
  97. st := &serverTester{
  98. t: t,
  99. ts: ts,
  100. logBuf: logBuf,
  101. frc: make(chan Frame, 1),
  102. frErrc: make(chan error, 1),
  103. }
  104. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  105. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  106. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  107. if quiet {
  108. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  109. } else {
  110. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  111. }
  112. ts.StartTLS()
  113. if VerboseLogs {
  114. t.Logf("Running test server at: %s", ts.URL)
  115. }
  116. testHookGetServerConn = func(v *serverConn) {
  117. st.scMu.Lock()
  118. defer st.scMu.Unlock()
  119. st.sc = v
  120. st.sc.testHookCh = make(chan func(int))
  121. }
  122. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  123. if !onlyServer {
  124. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  125. if err != nil {
  126. t.Fatal(err)
  127. }
  128. st.cc = cc
  129. st.fr = NewFramer(cc, cc)
  130. }
  131. return st
  132. }
  133. func (st *serverTester) closeConn() {
  134. st.scMu.Lock()
  135. defer st.scMu.Unlock()
  136. st.sc.conn.Close()
  137. }
  138. func (st *serverTester) addLogFilter(phrase string) {
  139. st.logFilter = append(st.logFilter, phrase)
  140. }
  141. func (st *serverTester) stream(id uint32) *stream {
  142. ch := make(chan *stream, 1)
  143. st.sc.testHookCh <- func(int) {
  144. ch <- st.sc.streams[id]
  145. }
  146. return <-ch
  147. }
  148. func (st *serverTester) streamState(id uint32) streamState {
  149. ch := make(chan streamState, 1)
  150. st.sc.testHookCh <- func(int) {
  151. state, _ := st.sc.state(id)
  152. ch <- state
  153. }
  154. return <-ch
  155. }
  156. // loopNum reports how many times this conn's select loop has gone around.
  157. func (st *serverTester) loopNum() int {
  158. lastc := make(chan int, 1)
  159. st.sc.testHookCh <- func(loopNum int) {
  160. lastc <- loopNum
  161. }
  162. return <-lastc
  163. }
  164. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  165. // The heuristic is that the server connection's serve loop must schedule
  166. // 50 times in a row without any channel sends or receives occurring.
  167. func (st *serverTester) awaitIdle() {
  168. remain := 50
  169. last := st.loopNum()
  170. for remain > 0 {
  171. n := st.loopNum()
  172. if n == last+1 {
  173. remain--
  174. } else {
  175. remain = 50
  176. }
  177. last = n
  178. }
  179. }
  180. func (st *serverTester) Close() {
  181. if st.t.Failed() {
  182. // If we failed already (and are likely in a Fatal,
  183. // unwindowing), force close the connection, so the
  184. // httptest.Server doesn't wait forever for the conn
  185. // to close.
  186. if st.cc != nil {
  187. st.cc.Close()
  188. }
  189. }
  190. st.ts.Close()
  191. if st.cc != nil {
  192. st.cc.Close()
  193. }
  194. log.SetOutput(os.Stderr)
  195. }
  196. // greet initiates the client's HTTP/2 connection into a state where
  197. // frames may be sent.
  198. func (st *serverTester) greet() {
  199. st.writePreface()
  200. st.writeInitialSettings()
  201. st.wantSettings()
  202. st.writeSettingsAck()
  203. st.wantSettingsAck()
  204. }
  205. func (st *serverTester) writePreface() {
  206. n, err := st.cc.Write(clientPreface)
  207. if err != nil {
  208. st.t.Fatalf("Error writing client preface: %v", err)
  209. }
  210. if n != len(clientPreface) {
  211. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  212. }
  213. }
  214. func (st *serverTester) writeInitialSettings() {
  215. if err := st.fr.WriteSettings(); err != nil {
  216. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  217. }
  218. }
  219. func (st *serverTester) writeSettingsAck() {
  220. if err := st.fr.WriteSettingsAck(); err != nil {
  221. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  222. }
  223. }
  224. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  225. if err := st.fr.WriteHeaders(p); err != nil {
  226. st.t.Fatalf("Error writing HEADERS: %v", err)
  227. }
  228. }
  229. func (st *serverTester) encodeHeaderField(k, v string) {
  230. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  231. if err != nil {
  232. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  233. }
  234. }
  235. // encodeHeaderRaw is the magic-free version of encodeHeader.
  236. // It takes 0 or more (k, v) pairs and encodes them.
  237. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  238. if len(headers)%2 == 1 {
  239. panic("odd number of kv args")
  240. }
  241. st.headerBuf.Reset()
  242. for len(headers) > 0 {
  243. k, v := headers[0], headers[1]
  244. st.encodeHeaderField(k, v)
  245. headers = headers[2:]
  246. }
  247. return st.headerBuf.Bytes()
  248. }
  249. // encodeHeader encodes headers and returns their HPACK bytes. headers
  250. // must contain an even number of key/value pairs. There may be
  251. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  252. // :scheme headers default to GET, / and https.
  253. func (st *serverTester) encodeHeader(headers ...string) []byte {
  254. if len(headers)%2 == 1 {
  255. panic("odd number of kv args")
  256. }
  257. st.headerBuf.Reset()
  258. if len(headers) == 0 {
  259. // Fast path, mostly for benchmarks, so test code doesn't pollute
  260. // profiles when we're looking to improve server allocations.
  261. st.encodeHeaderField(":method", "GET")
  262. st.encodeHeaderField(":path", "/")
  263. st.encodeHeaderField(":scheme", "https")
  264. return st.headerBuf.Bytes()
  265. }
  266. if len(headers) == 2 && headers[0] == ":method" {
  267. // Another fast path for benchmarks.
  268. st.encodeHeaderField(":method", headers[1])
  269. st.encodeHeaderField(":path", "/")
  270. st.encodeHeaderField(":scheme", "https")
  271. return st.headerBuf.Bytes()
  272. }
  273. pseudoCount := map[string]int{}
  274. keys := []string{":method", ":path", ":scheme"}
  275. vals := map[string][]string{
  276. ":method": {"GET"},
  277. ":path": {"/"},
  278. ":scheme": {"https"},
  279. }
  280. for len(headers) > 0 {
  281. k, v := headers[0], headers[1]
  282. headers = headers[2:]
  283. if _, ok := vals[k]; !ok {
  284. keys = append(keys, k)
  285. }
  286. if strings.HasPrefix(k, ":") {
  287. pseudoCount[k]++
  288. if pseudoCount[k] == 1 {
  289. vals[k] = []string{v}
  290. } else {
  291. // Allows testing of invalid headers w/ dup pseudo fields.
  292. vals[k] = append(vals[k], v)
  293. }
  294. } else {
  295. vals[k] = append(vals[k], v)
  296. }
  297. }
  298. for _, k := range keys {
  299. for _, v := range vals[k] {
  300. st.encodeHeaderField(k, v)
  301. }
  302. }
  303. return st.headerBuf.Bytes()
  304. }
  305. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  306. func (st *serverTester) bodylessReq1(headers ...string) {
  307. st.writeHeaders(HeadersFrameParam{
  308. StreamID: 1, // clients send odd numbers
  309. BlockFragment: st.encodeHeader(headers...),
  310. EndStream: true,
  311. EndHeaders: true,
  312. })
  313. }
  314. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  315. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  316. st.t.Fatalf("Error writing DATA: %v", err)
  317. }
  318. }
  319. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  320. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  321. st.t.Fatalf("Error writing DATA: %v", err)
  322. }
  323. }
  324. func (st *serverTester) readFrame() (Frame, error) {
  325. go func() {
  326. fr, err := st.fr.ReadFrame()
  327. if err != nil {
  328. st.frErrc <- err
  329. } else {
  330. st.frc <- fr
  331. }
  332. }()
  333. t := st.readTimer
  334. if t == nil {
  335. t = time.NewTimer(2 * time.Second)
  336. st.readTimer = t
  337. }
  338. t.Reset(2 * time.Second)
  339. defer t.Stop()
  340. select {
  341. case f := <-st.frc:
  342. return f, nil
  343. case err := <-st.frErrc:
  344. return nil, err
  345. case <-t.C:
  346. return nil, errors.New("timeout waiting for frame")
  347. }
  348. }
  349. func (st *serverTester) wantHeaders() *HeadersFrame {
  350. f, err := st.readFrame()
  351. if err != nil {
  352. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  353. }
  354. hf, ok := f.(*HeadersFrame)
  355. if !ok {
  356. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  357. }
  358. return hf
  359. }
  360. func (st *serverTester) wantContinuation() *ContinuationFrame {
  361. f, err := st.readFrame()
  362. if err != nil {
  363. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  364. }
  365. cf, ok := f.(*ContinuationFrame)
  366. if !ok {
  367. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  368. }
  369. return cf
  370. }
  371. func (st *serverTester) wantData() *DataFrame {
  372. f, err := st.readFrame()
  373. if err != nil {
  374. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  375. }
  376. df, ok := f.(*DataFrame)
  377. if !ok {
  378. st.t.Fatalf("got a %T; want *DataFrame", f)
  379. }
  380. return df
  381. }
  382. func (st *serverTester) wantSettings() *SettingsFrame {
  383. f, err := st.readFrame()
  384. if err != nil {
  385. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  386. }
  387. sf, ok := f.(*SettingsFrame)
  388. if !ok {
  389. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  390. }
  391. return sf
  392. }
  393. func (st *serverTester) wantPing() *PingFrame {
  394. f, err := st.readFrame()
  395. if err != nil {
  396. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  397. }
  398. pf, ok := f.(*PingFrame)
  399. if !ok {
  400. st.t.Fatalf("got a %T; want *PingFrame", f)
  401. }
  402. return pf
  403. }
  404. func (st *serverTester) wantGoAway() *GoAwayFrame {
  405. f, err := st.readFrame()
  406. if err != nil {
  407. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  408. }
  409. gf, ok := f.(*GoAwayFrame)
  410. if !ok {
  411. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  412. }
  413. return gf
  414. }
  415. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  416. f, err := st.readFrame()
  417. if err != nil {
  418. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  419. }
  420. rs, ok := f.(*RSTStreamFrame)
  421. if !ok {
  422. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  423. }
  424. if rs.FrameHeader.StreamID != streamID {
  425. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  426. }
  427. if rs.ErrCode != errCode {
  428. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  429. }
  430. }
  431. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  432. f, err := st.readFrame()
  433. if err != nil {
  434. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  435. }
  436. wu, ok := f.(*WindowUpdateFrame)
  437. if !ok {
  438. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  439. }
  440. if wu.FrameHeader.StreamID != streamID {
  441. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  442. }
  443. if wu.Increment != incr {
  444. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  445. }
  446. }
  447. func (st *serverTester) wantSettingsAck() {
  448. f, err := st.readFrame()
  449. if err != nil {
  450. st.t.Fatal(err)
  451. }
  452. sf, ok := f.(*SettingsFrame)
  453. if !ok {
  454. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  455. }
  456. if !sf.Header().Flags.Has(FlagSettingsAck) {
  457. st.t.Fatal("Settings Frame didn't have ACK set")
  458. }
  459. }
  460. func TestServer(t *testing.T) {
  461. gotReq := make(chan bool, 1)
  462. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  463. w.Header().Set("Foo", "Bar")
  464. gotReq <- true
  465. })
  466. defer st.Close()
  467. covers("3.5", `
  468. The server connection preface consists of a potentially empty
  469. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  470. server sends in the HTTP/2 connection.
  471. `)
  472. st.writePreface()
  473. st.writeInitialSettings()
  474. st.wantSettings()
  475. st.writeSettingsAck()
  476. st.wantSettingsAck()
  477. st.writeHeaders(HeadersFrameParam{
  478. StreamID: 1, // clients send odd numbers
  479. BlockFragment: st.encodeHeader(),
  480. EndStream: true, // no DATA frames
  481. EndHeaders: true,
  482. })
  483. select {
  484. case <-gotReq:
  485. case <-time.After(2 * time.Second):
  486. t.Error("timeout waiting for request")
  487. }
  488. }
  489. func TestServer_Request_Get(t *testing.T) {
  490. testServerRequest(t, func(st *serverTester) {
  491. st.writeHeaders(HeadersFrameParam{
  492. StreamID: 1, // clients send odd numbers
  493. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  494. EndStream: true, // no DATA frames
  495. EndHeaders: true,
  496. })
  497. }, func(r *http.Request) {
  498. if r.Method != "GET" {
  499. t.Errorf("Method = %q; want GET", r.Method)
  500. }
  501. if r.URL.Path != "/" {
  502. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  503. }
  504. if r.ContentLength != 0 {
  505. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  506. }
  507. if r.Close {
  508. t.Error("Close = true; want false")
  509. }
  510. if !strings.Contains(r.RemoteAddr, ":") {
  511. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  512. }
  513. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  514. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  515. }
  516. wantHeader := http.Header{
  517. "Foo-Bar": []string{"some-value"},
  518. }
  519. if !reflect.DeepEqual(r.Header, wantHeader) {
  520. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  521. }
  522. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  523. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  524. }
  525. })
  526. }
  527. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  528. testServerRequest(t, func(st *serverTester) {
  529. st.writeHeaders(HeadersFrameParam{
  530. StreamID: 1, // clients send odd numbers
  531. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  532. EndStream: true, // no DATA frames
  533. EndHeaders: true,
  534. })
  535. }, func(r *http.Request) {
  536. if r.RequestURI != "/%2f/" {
  537. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  538. }
  539. if r.URL.Path != "///" {
  540. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  541. }
  542. })
  543. }
  544. // TODO: add a test with EndStream=true on the HEADERS but setting a
  545. // Content-Length anyway. Should we just omit it and force it to
  546. // zero?
  547. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  548. testServerRequest(t, func(st *serverTester) {
  549. st.writeHeaders(HeadersFrameParam{
  550. StreamID: 1, // clients send odd numbers
  551. BlockFragment: st.encodeHeader(":method", "POST"),
  552. EndStream: true,
  553. EndHeaders: true,
  554. })
  555. }, func(r *http.Request) {
  556. if r.Method != "POST" {
  557. t.Errorf("Method = %q; want POST", r.Method)
  558. }
  559. if r.ContentLength != 0 {
  560. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  561. }
  562. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  563. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  564. }
  565. })
  566. }
  567. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  568. testBodyContents(t, -1, "", func(st *serverTester) {
  569. st.writeHeaders(HeadersFrameParam{
  570. StreamID: 1, // clients send odd numbers
  571. BlockFragment: st.encodeHeader(":method", "POST"),
  572. EndStream: false, // to say DATA frames are coming
  573. EndHeaders: true,
  574. })
  575. st.writeData(1, true, nil) // just kidding. empty body.
  576. })
  577. }
  578. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  579. const content = "Some content"
  580. testBodyContents(t, -1, content, func(st *serverTester) {
  581. st.writeHeaders(HeadersFrameParam{
  582. StreamID: 1, // clients send odd numbers
  583. BlockFragment: st.encodeHeader(":method", "POST"),
  584. EndStream: false, // to say DATA frames are coming
  585. EndHeaders: true,
  586. })
  587. st.writeData(1, true, []byte(content))
  588. })
  589. }
  590. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  591. const content = "Some content"
  592. testBodyContents(t, -1, content, func(st *serverTester) {
  593. st.writeHeaders(HeadersFrameParam{
  594. StreamID: 1, // clients send odd numbers
  595. BlockFragment: st.encodeHeader(":method", "POST"),
  596. EndStream: false, // to say DATA frames are coming
  597. EndHeaders: true,
  598. })
  599. st.writeData(1, false, []byte(content[:5]))
  600. st.writeData(1, true, []byte(content[5:]))
  601. })
  602. }
  603. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  604. const content = "Some content"
  605. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  606. st.writeHeaders(HeadersFrameParam{
  607. StreamID: 1, // clients send odd numbers
  608. BlockFragment: st.encodeHeader(
  609. ":method", "POST",
  610. "content-length", strconv.Itoa(len(content)),
  611. ),
  612. EndStream: false, // to say DATA frames are coming
  613. EndHeaders: true,
  614. })
  615. st.writeData(1, true, []byte(content))
  616. })
  617. }
  618. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  619. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  620. func(st *serverTester) {
  621. st.writeHeaders(HeadersFrameParam{
  622. StreamID: 1, // clients send odd numbers
  623. BlockFragment: st.encodeHeader(
  624. ":method", "POST",
  625. "content-length", "3",
  626. ),
  627. EndStream: false, // to say DATA frames are coming
  628. EndHeaders: true,
  629. })
  630. st.writeData(1, true, []byte("12"))
  631. })
  632. }
  633. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  634. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  635. func(st *serverTester) {
  636. st.writeHeaders(HeadersFrameParam{
  637. StreamID: 1, // clients send odd numbers
  638. BlockFragment: st.encodeHeader(
  639. ":method", "POST",
  640. "content-length", "4",
  641. ),
  642. EndStream: false, // to say DATA frames are coming
  643. EndHeaders: true,
  644. })
  645. st.writeData(1, true, []byte("12345"))
  646. })
  647. }
  648. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  649. testServerRequest(t, write, func(r *http.Request) {
  650. if r.Method != "POST" {
  651. t.Errorf("Method = %q; want POST", r.Method)
  652. }
  653. if r.ContentLength != wantContentLength {
  654. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  655. }
  656. all, err := ioutil.ReadAll(r.Body)
  657. if err != nil {
  658. t.Fatal(err)
  659. }
  660. if string(all) != wantBody {
  661. t.Errorf("Read = %q; want %q", all, wantBody)
  662. }
  663. if err := r.Body.Close(); err != nil {
  664. t.Fatalf("Close: %v", err)
  665. }
  666. })
  667. }
  668. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  669. testServerRequest(t, write, func(r *http.Request) {
  670. if r.Method != "POST" {
  671. t.Errorf("Method = %q; want POST", r.Method)
  672. }
  673. if r.ContentLength != wantContentLength {
  674. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  675. }
  676. all, err := ioutil.ReadAll(r.Body)
  677. if err == nil {
  678. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  679. wantReadError, all)
  680. }
  681. if !strings.Contains(err.Error(), wantReadError) {
  682. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  683. }
  684. if err := r.Body.Close(); err != nil {
  685. t.Fatalf("Close: %v", err)
  686. }
  687. })
  688. }
  689. // Using a Host header, instead of :authority
  690. func TestServer_Request_Get_Host(t *testing.T) {
  691. const host = "example.com"
  692. testServerRequest(t, func(st *serverTester) {
  693. st.writeHeaders(HeadersFrameParam{
  694. StreamID: 1, // clients send odd numbers
  695. BlockFragment: st.encodeHeader("host", host),
  696. EndStream: true,
  697. EndHeaders: true,
  698. })
  699. }, func(r *http.Request) {
  700. if r.Host != host {
  701. t.Errorf("Host = %q; want %q", r.Host, host)
  702. }
  703. })
  704. }
  705. // Using an :authority pseudo-header, instead of Host
  706. func TestServer_Request_Get_Authority(t *testing.T) {
  707. const host = "example.com"
  708. testServerRequest(t, func(st *serverTester) {
  709. st.writeHeaders(HeadersFrameParam{
  710. StreamID: 1, // clients send odd numbers
  711. BlockFragment: st.encodeHeader(":authority", host),
  712. EndStream: true,
  713. EndHeaders: true,
  714. })
  715. }, func(r *http.Request) {
  716. if r.Host != host {
  717. t.Errorf("Host = %q; want %q", r.Host, host)
  718. }
  719. })
  720. }
  721. func TestServer_Request_WithContinuation(t *testing.T) {
  722. wantHeader := http.Header{
  723. "Foo-One": []string{"value-one"},
  724. "Foo-Two": []string{"value-two"},
  725. "Foo-Three": []string{"value-three"},
  726. }
  727. testServerRequest(t, func(st *serverTester) {
  728. fullHeaders := st.encodeHeader(
  729. "foo-one", "value-one",
  730. "foo-two", "value-two",
  731. "foo-three", "value-three",
  732. )
  733. remain := fullHeaders
  734. chunks := 0
  735. for len(remain) > 0 {
  736. const maxChunkSize = 5
  737. chunk := remain
  738. if len(chunk) > maxChunkSize {
  739. chunk = chunk[:maxChunkSize]
  740. }
  741. remain = remain[len(chunk):]
  742. if chunks == 0 {
  743. st.writeHeaders(HeadersFrameParam{
  744. StreamID: 1, // clients send odd numbers
  745. BlockFragment: chunk,
  746. EndStream: true, // no DATA frames
  747. EndHeaders: false, // we'll have continuation frames
  748. })
  749. } else {
  750. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  751. if err != nil {
  752. t.Fatal(err)
  753. }
  754. }
  755. chunks++
  756. }
  757. if chunks < 2 {
  758. t.Fatal("too few chunks")
  759. }
  760. }, func(r *http.Request) {
  761. if !reflect.DeepEqual(r.Header, wantHeader) {
  762. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  763. }
  764. })
  765. }
  766. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  767. func TestServer_Request_CookieConcat(t *testing.T) {
  768. const host = "example.com"
  769. testServerRequest(t, func(st *serverTester) {
  770. st.bodylessReq1(
  771. ":authority", host,
  772. "cookie", "a=b",
  773. "cookie", "c=d",
  774. "cookie", "e=f",
  775. )
  776. }, func(r *http.Request) {
  777. const want = "a=b; c=d; e=f"
  778. if got := r.Header.Get("Cookie"); got != want {
  779. t.Errorf("Cookie = %q; want %q", got, want)
  780. }
  781. })
  782. }
  783. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  784. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  785. }
  786. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  787. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  788. }
  789. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  790. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  791. }
  792. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  793. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  794. }
  795. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  796. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  797. }
  798. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  799. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  800. }
  801. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  802. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  803. }
  804. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  805. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  806. }
  807. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  808. // 8.1.2.3 Request Pseudo-Header Fields
  809. // "All HTTP/2 requests MUST include exactly one valid value" ...
  810. testRejectRequest(t, func(st *serverTester) {
  811. st.addLogFilter("duplicate pseudo-header")
  812. st.bodylessReq1(":method", "GET", ":method", "POST")
  813. })
  814. }
  815. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  816. // 8.1.2.3 Request Pseudo-Header Fields
  817. // "All pseudo-header fields MUST appear in the header block
  818. // before regular header fields. Any request or response that
  819. // contains a pseudo-header field that appears in a header
  820. // block after a regular header field MUST be treated as
  821. // malformed (Section 8.1.2.6)."
  822. testRejectRequest(t, func(st *serverTester) {
  823. st.addLogFilter("pseudo-header after regular header")
  824. var buf bytes.Buffer
  825. enc := hpack.NewEncoder(&buf)
  826. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  827. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  828. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  829. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  830. st.writeHeaders(HeadersFrameParam{
  831. StreamID: 1, // clients send odd numbers
  832. BlockFragment: buf.Bytes(),
  833. EndStream: true,
  834. EndHeaders: true,
  835. })
  836. })
  837. }
  838. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  839. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  840. }
  841. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  842. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  843. }
  844. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  845. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  846. }
  847. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  848. testRejectRequest(t, func(st *serverTester) {
  849. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  850. st.bodylessReq1(":unknown_thing", "")
  851. })
  852. }
  853. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  854. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  855. t.Fatal("server request made it to handler; should've been rejected")
  856. })
  857. defer st.Close()
  858. st.greet()
  859. send(st)
  860. st.wantRSTStream(1, ErrCodeProtocol)
  861. }
  862. func TestServer_Request_Connect(t *testing.T) {
  863. testServerRequest(t, func(st *serverTester) {
  864. st.writeHeaders(HeadersFrameParam{
  865. StreamID: 1,
  866. BlockFragment: st.encodeHeaderRaw(
  867. ":method", "CONNECT",
  868. ":authority", "example.com:123",
  869. ),
  870. EndStream: true,
  871. EndHeaders: true,
  872. })
  873. }, func(r *http.Request) {
  874. if g, w := r.Method, "CONNECT"; g != w {
  875. t.Errorf("Method = %q; want %q", g, w)
  876. }
  877. if g, w := r.RequestURI, "example.com:123"; g != w {
  878. t.Errorf("RequestURI = %q; want %q", g, w)
  879. }
  880. if g, w := r.URL.Host, "example.com:123"; g != w {
  881. t.Errorf("URL.Host = %q; want %q", g, w)
  882. }
  883. })
  884. }
  885. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  886. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  887. st.writeHeaders(HeadersFrameParam{
  888. StreamID: 1,
  889. BlockFragment: st.encodeHeaderRaw(
  890. ":method", "CONNECT",
  891. ":authority", "example.com:123",
  892. ":path", "/bogus",
  893. ),
  894. EndStream: true,
  895. EndHeaders: true,
  896. })
  897. })
  898. }
  899. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  900. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  901. st.writeHeaders(HeadersFrameParam{
  902. StreamID: 1,
  903. BlockFragment: st.encodeHeaderRaw(
  904. ":method", "CONNECT",
  905. ":authority", "example.com:123",
  906. ":scheme", "https",
  907. ),
  908. EndStream: true,
  909. EndHeaders: true,
  910. })
  911. })
  912. }
  913. func TestServer_Ping(t *testing.T) {
  914. st := newServerTester(t, nil)
  915. defer st.Close()
  916. st.greet()
  917. // Server should ignore this one, since it has ACK set.
  918. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  919. if err := st.fr.WritePing(true, ackPingData); err != nil {
  920. t.Fatal(err)
  921. }
  922. // But the server should reply to this one, since ACK is false.
  923. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  924. if err := st.fr.WritePing(false, pingData); err != nil {
  925. t.Fatal(err)
  926. }
  927. pf := st.wantPing()
  928. if !pf.Flags.Has(FlagPingAck) {
  929. t.Error("response ping doesn't have ACK set")
  930. }
  931. if pf.Data != pingData {
  932. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  933. }
  934. }
  935. func TestServer_RejectsLargeFrames(t *testing.T) {
  936. if runtime.GOOS == "windows" {
  937. t.Skip("see golang.org/issue/13434")
  938. }
  939. st := newServerTester(t, nil)
  940. defer st.Close()
  941. st.greet()
  942. // Write too large of a frame (too large by one byte)
  943. // We ignore the return value because it's expected that the server
  944. // will only read the first 9 bytes (the headre) and then disconnect.
  945. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  946. gf := st.wantGoAway()
  947. if gf.ErrCode != ErrCodeFrameSize {
  948. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  949. }
  950. if st.logBuf.Len() != 0 {
  951. // Previously we spun here for a bit until the GOAWAY disconnect
  952. // timer fired, logging while we fired.
  953. t.Errorf("unexpected server output: %.500s\n", st.logBuf.Bytes())
  954. }
  955. }
  956. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  957. puppet := newHandlerPuppet()
  958. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  959. puppet.act(w, r)
  960. })
  961. defer st.Close()
  962. defer puppet.done()
  963. st.greet()
  964. st.writeHeaders(HeadersFrameParam{
  965. StreamID: 1, // clients send odd numbers
  966. BlockFragment: st.encodeHeader(":method", "POST"),
  967. EndStream: false, // data coming
  968. EndHeaders: true,
  969. })
  970. st.writeData(1, false, []byte("abcdef"))
  971. puppet.do(readBodyHandler(t, "abc"))
  972. st.wantWindowUpdate(0, 3)
  973. st.wantWindowUpdate(1, 3)
  974. puppet.do(readBodyHandler(t, "def"))
  975. st.wantWindowUpdate(0, 3)
  976. st.wantWindowUpdate(1, 3)
  977. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  978. puppet.do(readBodyHandler(t, "ghi"))
  979. puppet.do(readBodyHandler(t, "jkl"))
  980. st.wantWindowUpdate(0, 3)
  981. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  982. }
  983. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  984. // See golang.org/issue/16556
  985. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  986. puppet := newHandlerPuppet()
  987. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  988. puppet.act(w, r)
  989. })
  990. defer st.Close()
  991. defer puppet.done()
  992. st.greet()
  993. st.writeHeaders(HeadersFrameParam{
  994. StreamID: 1,
  995. BlockFragment: st.encodeHeader(":method", "POST"),
  996. EndStream: false,
  997. EndHeaders: true,
  998. })
  999. st.writeDataPadded(1, false, []byte("abcdef"), []byte("1234"))
  1000. // Expect to immediately get our 5 bytes of padding back for
  1001. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1002. st.wantWindowUpdate(0, 5)
  1003. st.wantWindowUpdate(1, 5)
  1004. puppet.do(readBodyHandler(t, "abc"))
  1005. st.wantWindowUpdate(0, 3)
  1006. st.wantWindowUpdate(1, 3)
  1007. puppet.do(readBodyHandler(t, "def"))
  1008. st.wantWindowUpdate(0, 3)
  1009. st.wantWindowUpdate(1, 3)
  1010. }
  1011. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1012. st := newServerTester(t, nil)
  1013. defer st.Close()
  1014. st.greet()
  1015. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1016. t.Fatal(err)
  1017. }
  1018. gf := st.wantGoAway()
  1019. if gf.ErrCode != ErrCodeFlowControl {
  1020. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1021. }
  1022. if gf.LastStreamID != 0 {
  1023. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1024. }
  1025. }
  1026. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1027. inHandler := make(chan bool)
  1028. blockHandler := make(chan bool)
  1029. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1030. inHandler <- true
  1031. <-blockHandler
  1032. })
  1033. defer st.Close()
  1034. defer close(blockHandler)
  1035. st.greet()
  1036. st.writeHeaders(HeadersFrameParam{
  1037. StreamID: 1,
  1038. BlockFragment: st.encodeHeader(":method", "POST"),
  1039. EndStream: false, // keep it open
  1040. EndHeaders: true,
  1041. })
  1042. <-inHandler
  1043. // Send a bogus window update:
  1044. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1045. t.Fatal(err)
  1046. }
  1047. st.wantRSTStream(1, ErrCodeFlowControl)
  1048. }
  1049. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1050. // then runs fn once in the handler, and verifies that the error returned from
  1051. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1052. func testServerPostUnblock(t *testing.T,
  1053. handler func(http.ResponseWriter, *http.Request) error,
  1054. fn func(*serverTester),
  1055. checkErr func(error),
  1056. otherHeaders ...string) {
  1057. inHandler := make(chan bool)
  1058. errc := make(chan error, 1)
  1059. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1060. inHandler <- true
  1061. errc <- handler(w, r)
  1062. })
  1063. st.greet()
  1064. st.writeHeaders(HeadersFrameParam{
  1065. StreamID: 1,
  1066. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1067. EndStream: false, // keep it open
  1068. EndHeaders: true,
  1069. })
  1070. <-inHandler
  1071. fn(st)
  1072. select {
  1073. case err := <-errc:
  1074. if checkErr != nil {
  1075. checkErr(err)
  1076. }
  1077. case <-time.After(5 * time.Second):
  1078. t.Fatal("timeout waiting for Handler to return")
  1079. }
  1080. st.Close()
  1081. }
  1082. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1083. testServerPostUnblock(t,
  1084. func(w http.ResponseWriter, r *http.Request) (err error) {
  1085. _, err = r.Body.Read(make([]byte, 1))
  1086. return
  1087. },
  1088. func(st *serverTester) {
  1089. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1090. t.Fatal(err)
  1091. }
  1092. },
  1093. func(err error) {
  1094. want := StreamError{StreamID: 0x1, Code: 0x8}
  1095. if !reflect.DeepEqual(err, want) {
  1096. t.Errorf("Read error = %v; want %v", err, want)
  1097. }
  1098. },
  1099. )
  1100. }
  1101. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1102. // Run this test a bunch, because it doesn't always
  1103. // deadlock. But with a bunch, it did.
  1104. n := 50
  1105. if testing.Short() {
  1106. n = 5
  1107. }
  1108. for i := 0; i < n; i++ {
  1109. testServer_RSTStream_Unblocks_Header_Write(t)
  1110. }
  1111. }
  1112. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1113. inHandler := make(chan bool, 1)
  1114. unblockHandler := make(chan bool, 1)
  1115. headerWritten := make(chan bool, 1)
  1116. wroteRST := make(chan bool, 1)
  1117. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1118. inHandler <- true
  1119. <-wroteRST
  1120. w.Header().Set("foo", "bar")
  1121. w.WriteHeader(200)
  1122. w.(http.Flusher).Flush()
  1123. headerWritten <- true
  1124. <-unblockHandler
  1125. })
  1126. defer st.Close()
  1127. st.greet()
  1128. st.writeHeaders(HeadersFrameParam{
  1129. StreamID: 1,
  1130. BlockFragment: st.encodeHeader(":method", "POST"),
  1131. EndStream: false, // keep it open
  1132. EndHeaders: true,
  1133. })
  1134. <-inHandler
  1135. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1136. t.Fatal(err)
  1137. }
  1138. wroteRST <- true
  1139. st.awaitIdle()
  1140. select {
  1141. case <-headerWritten:
  1142. case <-time.After(2 * time.Second):
  1143. t.Error("timeout waiting for header write")
  1144. }
  1145. unblockHandler <- true
  1146. }
  1147. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1148. testServerPostUnblock(t,
  1149. func(w http.ResponseWriter, r *http.Request) (err error) {
  1150. _, err = r.Body.Read(make([]byte, 1))
  1151. return
  1152. },
  1153. func(st *serverTester) { st.cc.Close() },
  1154. func(err error) {
  1155. if err == nil {
  1156. t.Error("unexpected nil error from Request.Body.Read")
  1157. }
  1158. },
  1159. )
  1160. }
  1161. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1162. <-w.(http.CloseNotifier).CloseNotify()
  1163. return nil
  1164. }
  1165. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1166. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1167. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1168. t.Fatal(err)
  1169. }
  1170. }, nil)
  1171. }
  1172. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1173. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1174. }
  1175. // that CloseNotify unblocks after a stream error due to the client's
  1176. // problem that's unrelated to them explicitly canceling it (which is
  1177. // TestServer_CloseNotify_After_RSTStream above)
  1178. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1179. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1180. // data longer than declared Content-Length => stream error
  1181. st.writeData(1, true, []byte("1234"))
  1182. }, nil, "content-length", "3")
  1183. }
  1184. func TestServer_StateTransitions(t *testing.T) {
  1185. var st *serverTester
  1186. inHandler := make(chan bool)
  1187. writeData := make(chan bool)
  1188. leaveHandler := make(chan bool)
  1189. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1190. inHandler <- true
  1191. if st.stream(1) == nil {
  1192. t.Errorf("nil stream 1 in handler")
  1193. }
  1194. if got, want := st.streamState(1), stateOpen; got != want {
  1195. t.Errorf("in handler, state is %v; want %v", got, want)
  1196. }
  1197. writeData <- true
  1198. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1199. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1200. }
  1201. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1202. t.Errorf("in handler, state is %v; want %v", got, want)
  1203. }
  1204. <-leaveHandler
  1205. })
  1206. st.greet()
  1207. if st.stream(1) != nil {
  1208. t.Fatal("stream 1 should be empty")
  1209. }
  1210. if got := st.streamState(1); got != stateIdle {
  1211. t.Fatalf("stream 1 should be idle; got %v", got)
  1212. }
  1213. st.writeHeaders(HeadersFrameParam{
  1214. StreamID: 1,
  1215. BlockFragment: st.encodeHeader(":method", "POST"),
  1216. EndStream: false, // keep it open
  1217. EndHeaders: true,
  1218. })
  1219. <-inHandler
  1220. <-writeData
  1221. st.writeData(1, true, nil)
  1222. leaveHandler <- true
  1223. hf := st.wantHeaders()
  1224. if !hf.StreamEnded() {
  1225. t.Fatal("expected END_STREAM flag")
  1226. }
  1227. if got, want := st.streamState(1), stateClosed; got != want {
  1228. t.Errorf("at end, state is %v; want %v", got, want)
  1229. }
  1230. if st.stream(1) != nil {
  1231. t.Fatal("at end, stream 1 should be gone")
  1232. }
  1233. }
  1234. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1235. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1236. testServerRejectsConn(t, func(st *serverTester) {
  1237. st.writeHeaders(HeadersFrameParam{
  1238. StreamID: 1,
  1239. BlockFragment: st.encodeHeader(),
  1240. EndStream: true,
  1241. EndHeaders: false,
  1242. })
  1243. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1244. StreamID: 3, // different stream.
  1245. BlockFragment: st.encodeHeader(),
  1246. EndStream: true,
  1247. EndHeaders: true,
  1248. })
  1249. })
  1250. }
  1251. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1252. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1253. testServerRejectsConn(t, func(st *serverTester) {
  1254. st.writeHeaders(HeadersFrameParam{
  1255. StreamID: 1,
  1256. BlockFragment: st.encodeHeader(),
  1257. EndStream: true,
  1258. EndHeaders: false,
  1259. })
  1260. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1261. t.Fatal(err)
  1262. }
  1263. })
  1264. }
  1265. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1266. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1267. testServerRejectsConn(t, func(st *serverTester) {
  1268. st.writeHeaders(HeadersFrameParam{
  1269. StreamID: 1,
  1270. BlockFragment: st.encodeHeader(),
  1271. EndStream: true,
  1272. EndHeaders: true,
  1273. })
  1274. st.wantHeaders()
  1275. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1276. t.Fatal(err)
  1277. }
  1278. })
  1279. }
  1280. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1281. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1282. testServerRejectsConn(t, func(st *serverTester) {
  1283. st.writeHeaders(HeadersFrameParam{
  1284. StreamID: 1,
  1285. BlockFragment: st.encodeHeader(),
  1286. EndStream: true,
  1287. EndHeaders: false,
  1288. })
  1289. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1290. t.Fatal(err)
  1291. }
  1292. })
  1293. }
  1294. // No HEADERS on stream 0.
  1295. func TestServer_Rejects_Headers0(t *testing.T) {
  1296. testServerRejectsConn(t, func(st *serverTester) {
  1297. st.fr.AllowIllegalWrites = true
  1298. st.writeHeaders(HeadersFrameParam{
  1299. StreamID: 0,
  1300. BlockFragment: st.encodeHeader(),
  1301. EndStream: true,
  1302. EndHeaders: true,
  1303. })
  1304. })
  1305. }
  1306. // No CONTINUATION on stream 0.
  1307. func TestServer_Rejects_Continuation0(t *testing.T) {
  1308. testServerRejectsConn(t, func(st *serverTester) {
  1309. st.fr.AllowIllegalWrites = true
  1310. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1311. t.Fatal(err)
  1312. }
  1313. })
  1314. }
  1315. func TestServer_Rejects_PushPromise(t *testing.T) {
  1316. testServerRejectsConn(t, func(st *serverTester) {
  1317. pp := PushPromiseParam{
  1318. StreamID: 1,
  1319. PromiseID: 3,
  1320. }
  1321. if err := st.fr.WritePushPromise(pp); err != nil {
  1322. t.Fatal(err)
  1323. }
  1324. })
  1325. }
  1326. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1327. // frame and a server close after the client does something
  1328. // deserving a CONNECTION_ERROR.
  1329. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1330. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1331. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1332. defer st.Close()
  1333. st.greet()
  1334. writeReq(st)
  1335. st.wantGoAway()
  1336. errc := make(chan error, 1)
  1337. go func() {
  1338. fr, err := st.fr.ReadFrame()
  1339. if err == nil {
  1340. err = fmt.Errorf("got frame of type %T", fr)
  1341. }
  1342. errc <- err
  1343. }()
  1344. select {
  1345. case err := <-errc:
  1346. if err != io.EOF {
  1347. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1348. }
  1349. case <-time.After(2 * time.Second):
  1350. t.Error("timeout waiting for disconnect")
  1351. }
  1352. }
  1353. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1354. // error code after a client sends a bogus request.
  1355. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1356. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1357. defer st.Close()
  1358. st.greet()
  1359. writeReq(st)
  1360. st.wantRSTStream(1, code)
  1361. }
  1362. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1363. // write a single request with writeReq, and then verify that the
  1364. // *http.Request is built correctly in checkReq.
  1365. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1366. gotReq := make(chan bool, 1)
  1367. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1368. if r.Body == nil {
  1369. t.Fatal("nil Body")
  1370. }
  1371. checkReq(r)
  1372. gotReq <- true
  1373. })
  1374. defer st.Close()
  1375. st.greet()
  1376. writeReq(st)
  1377. select {
  1378. case <-gotReq:
  1379. case <-time.After(2 * time.Second):
  1380. t.Error("timeout waiting for request")
  1381. }
  1382. }
  1383. func getSlash(st *serverTester) { st.bodylessReq1() }
  1384. func TestServer_Response_NoData(t *testing.T) {
  1385. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1386. // Nothing.
  1387. return nil
  1388. }, func(st *serverTester) {
  1389. getSlash(st)
  1390. hf := st.wantHeaders()
  1391. if !hf.StreamEnded() {
  1392. t.Fatal("want END_STREAM flag")
  1393. }
  1394. if !hf.HeadersEnded() {
  1395. t.Fatal("want END_HEADERS flag")
  1396. }
  1397. })
  1398. }
  1399. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1400. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1401. w.Header().Set("Foo-Bar", "some-value")
  1402. return nil
  1403. }, func(st *serverTester) {
  1404. getSlash(st)
  1405. hf := st.wantHeaders()
  1406. if !hf.StreamEnded() {
  1407. t.Fatal("want END_STREAM flag")
  1408. }
  1409. if !hf.HeadersEnded() {
  1410. t.Fatal("want END_HEADERS flag")
  1411. }
  1412. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1413. wanth := [][2]string{
  1414. {":status", "200"},
  1415. {"foo-bar", "some-value"},
  1416. {"content-type", "text/plain; charset=utf-8"},
  1417. {"content-length", "0"},
  1418. }
  1419. if !reflect.DeepEqual(goth, wanth) {
  1420. t.Errorf("Got headers %v; want %v", goth, wanth)
  1421. }
  1422. })
  1423. }
  1424. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1425. const msg = "<html>this is HTML."
  1426. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1427. w.Header().Set("Content-Type", "foo/bar")
  1428. io.WriteString(w, msg)
  1429. return nil
  1430. }, func(st *serverTester) {
  1431. getSlash(st)
  1432. hf := st.wantHeaders()
  1433. if hf.StreamEnded() {
  1434. t.Fatal("don't want END_STREAM, expecting data")
  1435. }
  1436. if !hf.HeadersEnded() {
  1437. t.Fatal("want END_HEADERS flag")
  1438. }
  1439. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1440. wanth := [][2]string{
  1441. {":status", "200"},
  1442. {"content-type", "foo/bar"},
  1443. {"content-length", strconv.Itoa(len(msg))},
  1444. }
  1445. if !reflect.DeepEqual(goth, wanth) {
  1446. t.Errorf("Got headers %v; want %v", goth, wanth)
  1447. }
  1448. df := st.wantData()
  1449. if !df.StreamEnded() {
  1450. t.Error("expected DATA to have END_STREAM flag")
  1451. }
  1452. if got := string(df.Data()); got != msg {
  1453. t.Errorf("got DATA %q; want %q", got, msg)
  1454. }
  1455. })
  1456. }
  1457. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1458. const msg = "hi"
  1459. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1460. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1461. io.WriteString(w, msg)
  1462. return nil
  1463. }, func(st *serverTester) {
  1464. getSlash(st)
  1465. hf := st.wantHeaders()
  1466. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1467. wanth := [][2]string{
  1468. {":status", "200"},
  1469. {"content-type", "text/plain; charset=utf-8"},
  1470. {"content-length", strconv.Itoa(len(msg))},
  1471. }
  1472. if !reflect.DeepEqual(goth, wanth) {
  1473. t.Errorf("Got headers %v; want %v", goth, wanth)
  1474. }
  1475. })
  1476. }
  1477. // Header accessed only after the initial write.
  1478. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1479. const msg = "<html>this is HTML."
  1480. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1481. io.WriteString(w, msg)
  1482. w.Header().Set("foo", "should be ignored")
  1483. return nil
  1484. }, func(st *serverTester) {
  1485. getSlash(st)
  1486. hf := st.wantHeaders()
  1487. if hf.StreamEnded() {
  1488. t.Fatal("unexpected END_STREAM")
  1489. }
  1490. if !hf.HeadersEnded() {
  1491. t.Fatal("want END_HEADERS flag")
  1492. }
  1493. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1494. wanth := [][2]string{
  1495. {":status", "200"},
  1496. {"content-type", "text/html; charset=utf-8"},
  1497. {"content-length", strconv.Itoa(len(msg))},
  1498. }
  1499. if !reflect.DeepEqual(goth, wanth) {
  1500. t.Errorf("Got headers %v; want %v", goth, wanth)
  1501. }
  1502. })
  1503. }
  1504. // Header accessed before the initial write and later mutated.
  1505. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1506. const msg = "<html>this is HTML."
  1507. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1508. w.Header().Set("foo", "proper value")
  1509. io.WriteString(w, msg)
  1510. w.Header().Set("foo", "should be ignored")
  1511. return nil
  1512. }, func(st *serverTester) {
  1513. getSlash(st)
  1514. hf := st.wantHeaders()
  1515. if hf.StreamEnded() {
  1516. t.Fatal("unexpected END_STREAM")
  1517. }
  1518. if !hf.HeadersEnded() {
  1519. t.Fatal("want END_HEADERS flag")
  1520. }
  1521. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1522. wanth := [][2]string{
  1523. {":status", "200"},
  1524. {"foo", "proper value"},
  1525. {"content-type", "text/html; charset=utf-8"},
  1526. {"content-length", strconv.Itoa(len(msg))},
  1527. }
  1528. if !reflect.DeepEqual(goth, wanth) {
  1529. t.Errorf("Got headers %v; want %v", goth, wanth)
  1530. }
  1531. })
  1532. }
  1533. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1534. const msg = "<html>this is HTML."
  1535. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1536. io.WriteString(w, msg)
  1537. return nil
  1538. }, func(st *serverTester) {
  1539. getSlash(st)
  1540. hf := st.wantHeaders()
  1541. if hf.StreamEnded() {
  1542. t.Fatal("don't want END_STREAM, expecting data")
  1543. }
  1544. if !hf.HeadersEnded() {
  1545. t.Fatal("want END_HEADERS flag")
  1546. }
  1547. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1548. wanth := [][2]string{
  1549. {":status", "200"},
  1550. {"content-type", "text/html; charset=utf-8"},
  1551. {"content-length", strconv.Itoa(len(msg))},
  1552. }
  1553. if !reflect.DeepEqual(goth, wanth) {
  1554. t.Errorf("Got headers %v; want %v", goth, wanth)
  1555. }
  1556. df := st.wantData()
  1557. if !df.StreamEnded() {
  1558. t.Error("expected DATA to have END_STREAM flag")
  1559. }
  1560. if got := string(df.Data()); got != msg {
  1561. t.Errorf("got DATA %q; want %q", got, msg)
  1562. }
  1563. })
  1564. }
  1565. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1566. const msg = "<html>this is HTML"
  1567. const msg2 = ", and this is the next chunk"
  1568. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1569. io.WriteString(w, msg)
  1570. w.(http.Flusher).Flush()
  1571. io.WriteString(w, msg2)
  1572. return nil
  1573. }, func(st *serverTester) {
  1574. getSlash(st)
  1575. hf := st.wantHeaders()
  1576. if hf.StreamEnded() {
  1577. t.Fatal("unexpected END_STREAM flag")
  1578. }
  1579. if !hf.HeadersEnded() {
  1580. t.Fatal("want END_HEADERS flag")
  1581. }
  1582. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1583. wanth := [][2]string{
  1584. {":status", "200"},
  1585. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1586. // and no content-length
  1587. }
  1588. if !reflect.DeepEqual(goth, wanth) {
  1589. t.Errorf("Got headers %v; want %v", goth, wanth)
  1590. }
  1591. {
  1592. df := st.wantData()
  1593. if df.StreamEnded() {
  1594. t.Error("unexpected END_STREAM flag")
  1595. }
  1596. if got := string(df.Data()); got != msg {
  1597. t.Errorf("got DATA %q; want %q", got, msg)
  1598. }
  1599. }
  1600. {
  1601. df := st.wantData()
  1602. if !df.StreamEnded() {
  1603. t.Error("wanted END_STREAM flag on last data chunk")
  1604. }
  1605. if got := string(df.Data()); got != msg2 {
  1606. t.Errorf("got DATA %q; want %q", got, msg2)
  1607. }
  1608. }
  1609. })
  1610. }
  1611. func TestServer_Response_LargeWrite(t *testing.T) {
  1612. const size = 1 << 20
  1613. const maxFrameSize = 16 << 10
  1614. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1615. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1616. if err != nil {
  1617. return fmt.Errorf("Write error: %v", err)
  1618. }
  1619. if n != size {
  1620. return fmt.Errorf("wrong size %d from Write", n)
  1621. }
  1622. return nil
  1623. }, func(st *serverTester) {
  1624. if err := st.fr.WriteSettings(
  1625. Setting{SettingInitialWindowSize, 0},
  1626. Setting{SettingMaxFrameSize, maxFrameSize},
  1627. ); err != nil {
  1628. t.Fatal(err)
  1629. }
  1630. st.wantSettingsAck()
  1631. getSlash(st) // make the single request
  1632. // Give the handler quota to write:
  1633. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1634. t.Fatal(err)
  1635. }
  1636. // Give the handler quota to write to connection-level
  1637. // window as well
  1638. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1639. t.Fatal(err)
  1640. }
  1641. hf := st.wantHeaders()
  1642. if hf.StreamEnded() {
  1643. t.Fatal("unexpected END_STREAM flag")
  1644. }
  1645. if !hf.HeadersEnded() {
  1646. t.Fatal("want END_HEADERS flag")
  1647. }
  1648. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1649. wanth := [][2]string{
  1650. {":status", "200"},
  1651. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1652. // and no content-length
  1653. }
  1654. if !reflect.DeepEqual(goth, wanth) {
  1655. t.Errorf("Got headers %v; want %v", goth, wanth)
  1656. }
  1657. var bytes, frames int
  1658. for {
  1659. df := st.wantData()
  1660. bytes += len(df.Data())
  1661. frames++
  1662. for _, b := range df.Data() {
  1663. if b != 'a' {
  1664. t.Fatal("non-'a' byte seen in DATA")
  1665. }
  1666. }
  1667. if df.StreamEnded() {
  1668. break
  1669. }
  1670. }
  1671. if bytes != size {
  1672. t.Errorf("Got %d bytes; want %d", bytes, size)
  1673. }
  1674. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1675. t.Errorf("Got %d frames; want %d", frames, size)
  1676. }
  1677. })
  1678. }
  1679. // Test that the handler can't write more than the client allows
  1680. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1681. const size = 1 << 20
  1682. const maxFrameSize = 16 << 10
  1683. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1684. w.(http.Flusher).Flush()
  1685. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1686. if err != nil {
  1687. return fmt.Errorf("Write error: %v", err)
  1688. }
  1689. if n != size {
  1690. return fmt.Errorf("wrong size %d from Write", n)
  1691. }
  1692. return nil
  1693. }, func(st *serverTester) {
  1694. // Set the window size to something explicit for this test.
  1695. // It's also how much initial data we expect.
  1696. const initWindowSize = 123
  1697. if err := st.fr.WriteSettings(
  1698. Setting{SettingInitialWindowSize, initWindowSize},
  1699. Setting{SettingMaxFrameSize, maxFrameSize},
  1700. ); err != nil {
  1701. t.Fatal(err)
  1702. }
  1703. st.wantSettingsAck()
  1704. getSlash(st) // make the single request
  1705. defer func() { st.fr.WriteRSTStream(1, ErrCodeCancel) }()
  1706. hf := st.wantHeaders()
  1707. if hf.StreamEnded() {
  1708. t.Fatal("unexpected END_STREAM flag")
  1709. }
  1710. if !hf.HeadersEnded() {
  1711. t.Fatal("want END_HEADERS flag")
  1712. }
  1713. df := st.wantData()
  1714. if got := len(df.Data()); got != initWindowSize {
  1715. t.Fatalf("Initial window size = %d but got DATA with %d bytes", initWindowSize, got)
  1716. }
  1717. for _, quota := range []int{1, 13, 127} {
  1718. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1719. t.Fatal(err)
  1720. }
  1721. df := st.wantData()
  1722. if int(quota) != len(df.Data()) {
  1723. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1724. }
  1725. }
  1726. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1727. t.Fatal(err)
  1728. }
  1729. })
  1730. }
  1731. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1732. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1733. const size = 1 << 20
  1734. const maxFrameSize = 16 << 10
  1735. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1736. w.(http.Flusher).Flush()
  1737. errc := make(chan error, 1)
  1738. go func() {
  1739. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1740. errc <- err
  1741. }()
  1742. select {
  1743. case err := <-errc:
  1744. if err == nil {
  1745. return errors.New("unexpected nil error from Write in handler")
  1746. }
  1747. return nil
  1748. case <-time.After(2 * time.Second):
  1749. return errors.New("timeout waiting for Write in handler")
  1750. }
  1751. }, func(st *serverTester) {
  1752. if err := st.fr.WriteSettings(
  1753. Setting{SettingInitialWindowSize, 0},
  1754. Setting{SettingMaxFrameSize, maxFrameSize},
  1755. ); err != nil {
  1756. t.Fatal(err)
  1757. }
  1758. st.wantSettingsAck()
  1759. getSlash(st) // make the single request
  1760. hf := st.wantHeaders()
  1761. if hf.StreamEnded() {
  1762. t.Fatal("unexpected END_STREAM flag")
  1763. }
  1764. if !hf.HeadersEnded() {
  1765. t.Fatal("want END_HEADERS flag")
  1766. }
  1767. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1768. t.Fatal(err)
  1769. }
  1770. })
  1771. }
  1772. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1773. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1774. w.(http.Flusher).Flush()
  1775. // Nothing; send empty DATA
  1776. return nil
  1777. }, func(st *serverTester) {
  1778. // Handler gets no data quota:
  1779. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1780. t.Fatal(err)
  1781. }
  1782. st.wantSettingsAck()
  1783. getSlash(st) // make the single request
  1784. hf := st.wantHeaders()
  1785. if hf.StreamEnded() {
  1786. t.Fatal("unexpected END_STREAM flag")
  1787. }
  1788. if !hf.HeadersEnded() {
  1789. t.Fatal("want END_HEADERS flag")
  1790. }
  1791. df := st.wantData()
  1792. if got := len(df.Data()); got != 0 {
  1793. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1794. }
  1795. if !df.StreamEnded() {
  1796. t.Fatal("DATA didn't have END_STREAM")
  1797. }
  1798. })
  1799. }
  1800. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1801. const msg = "foo"
  1802. const reply = "bar"
  1803. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1804. if v := r.Header.Get("Expect"); v != "" {
  1805. t.Errorf("Expect header = %q; want empty", v)
  1806. }
  1807. buf := make([]byte, len(msg))
  1808. // This read should trigger the 100-continue being sent.
  1809. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1810. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1811. }
  1812. _, err := io.WriteString(w, reply)
  1813. return err
  1814. }, func(st *serverTester) {
  1815. st.writeHeaders(HeadersFrameParam{
  1816. StreamID: 1, // clients send odd numbers
  1817. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1818. EndStream: false,
  1819. EndHeaders: true,
  1820. })
  1821. hf := st.wantHeaders()
  1822. if hf.StreamEnded() {
  1823. t.Fatal("unexpected END_STREAM flag")
  1824. }
  1825. if !hf.HeadersEnded() {
  1826. t.Fatal("want END_HEADERS flag")
  1827. }
  1828. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1829. wanth := [][2]string{
  1830. {":status", "100"},
  1831. }
  1832. if !reflect.DeepEqual(goth, wanth) {
  1833. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1834. }
  1835. // Okay, they sent status 100, so we can send our
  1836. // gigantic and/or sensitive "foo" payload now.
  1837. st.writeData(1, true, []byte(msg))
  1838. st.wantWindowUpdate(0, uint32(len(msg)))
  1839. hf = st.wantHeaders()
  1840. if hf.StreamEnded() {
  1841. t.Fatal("expected data to follow")
  1842. }
  1843. if !hf.HeadersEnded() {
  1844. t.Fatal("want END_HEADERS flag")
  1845. }
  1846. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1847. wanth = [][2]string{
  1848. {":status", "200"},
  1849. {"content-type", "text/plain; charset=utf-8"},
  1850. {"content-length", strconv.Itoa(len(reply))},
  1851. }
  1852. if !reflect.DeepEqual(goth, wanth) {
  1853. t.Errorf("Got headers %v; want %v", goth, wanth)
  1854. }
  1855. df := st.wantData()
  1856. if string(df.Data()) != reply {
  1857. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1858. }
  1859. if !df.StreamEnded() {
  1860. t.Errorf("expect data stream end")
  1861. }
  1862. })
  1863. }
  1864. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1865. errc := make(chan error, 1)
  1866. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1867. p := []byte("some data.\n")
  1868. for {
  1869. _, err := w.Write(p)
  1870. if err != nil {
  1871. errc <- err
  1872. return nil
  1873. }
  1874. }
  1875. }, func(st *serverTester) {
  1876. st.writeHeaders(HeadersFrameParam{
  1877. StreamID: 1,
  1878. BlockFragment: st.encodeHeader(),
  1879. EndStream: false,
  1880. EndHeaders: true,
  1881. })
  1882. hf := st.wantHeaders()
  1883. if hf.StreamEnded() {
  1884. t.Fatal("unexpected END_STREAM flag")
  1885. }
  1886. if !hf.HeadersEnded() {
  1887. t.Fatal("want END_HEADERS flag")
  1888. }
  1889. // Close the connection and wait for the handler to (hopefully) notice.
  1890. st.cc.Close()
  1891. select {
  1892. case <-errc:
  1893. case <-time.After(5 * time.Second):
  1894. t.Error("timeout")
  1895. }
  1896. })
  1897. }
  1898. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1899. const testPath = "/some/path"
  1900. inHandler := make(chan uint32)
  1901. leaveHandler := make(chan bool)
  1902. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1903. id := w.(*responseWriter).rws.stream.id
  1904. inHandler <- id
  1905. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1906. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1907. }
  1908. <-leaveHandler
  1909. })
  1910. defer st.Close()
  1911. st.greet()
  1912. nextStreamID := uint32(1)
  1913. streamID := func() uint32 {
  1914. defer func() { nextStreamID += 2 }()
  1915. return nextStreamID
  1916. }
  1917. sendReq := func(id uint32, headers ...string) {
  1918. st.writeHeaders(HeadersFrameParam{
  1919. StreamID: id,
  1920. BlockFragment: st.encodeHeader(headers...),
  1921. EndStream: true,
  1922. EndHeaders: true,
  1923. })
  1924. }
  1925. for i := 0; i < defaultMaxStreams; i++ {
  1926. sendReq(streamID())
  1927. <-inHandler
  1928. }
  1929. defer func() {
  1930. for i := 0; i < defaultMaxStreams; i++ {
  1931. leaveHandler <- true
  1932. }
  1933. }()
  1934. // And this one should cross the limit:
  1935. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  1936. // even if we're rejecting it)
  1937. rejectID := streamID()
  1938. headerBlock := st.encodeHeader(":path", testPath)
  1939. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  1940. st.writeHeaders(HeadersFrameParam{
  1941. StreamID: rejectID,
  1942. BlockFragment: frag1,
  1943. EndStream: true,
  1944. EndHeaders: false, // CONTINUATION coming
  1945. })
  1946. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  1947. t.Fatal(err)
  1948. }
  1949. st.wantRSTStream(rejectID, ErrCodeProtocol)
  1950. // But let a handler finish:
  1951. leaveHandler <- true
  1952. st.wantHeaders()
  1953. // And now another stream should be able to start:
  1954. goodID := streamID()
  1955. sendReq(goodID, ":path", testPath)
  1956. select {
  1957. case got := <-inHandler:
  1958. if got != goodID {
  1959. t.Errorf("Got stream %d; want %d", got, goodID)
  1960. }
  1961. case <-time.After(3 * time.Second):
  1962. t.Error("timeout waiting for handler")
  1963. }
  1964. }
  1965. // So many response headers that the server needs to use CONTINUATION frames:
  1966. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  1967. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1968. h := w.Header()
  1969. for i := 0; i < 5000; i++ {
  1970. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  1971. }
  1972. return nil
  1973. }, func(st *serverTester) {
  1974. getSlash(st)
  1975. hf := st.wantHeaders()
  1976. if hf.HeadersEnded() {
  1977. t.Fatal("got unwanted END_HEADERS flag")
  1978. }
  1979. n := 0
  1980. for {
  1981. n++
  1982. cf := st.wantContinuation()
  1983. if cf.HeadersEnded() {
  1984. break
  1985. }
  1986. }
  1987. if n < 5 {
  1988. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  1989. }
  1990. })
  1991. }
  1992. // This previously crashed (reported by Mathieu Lonjaret as observed
  1993. // while using Camlistore) because we got a DATA frame from the client
  1994. // after the handler exited and our logic at the time was wrong,
  1995. // keeping a stream in the map in stateClosed, which tickled an
  1996. // invariant check later when we tried to remove that stream (via
  1997. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  1998. // ended.
  1999. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2000. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2001. // nothing
  2002. return nil
  2003. }, func(st *serverTester) {
  2004. st.writeHeaders(HeadersFrameParam{
  2005. StreamID: 1,
  2006. BlockFragment: st.encodeHeader(),
  2007. EndStream: false, // DATA is coming
  2008. EndHeaders: true,
  2009. })
  2010. hf := st.wantHeaders()
  2011. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2012. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2013. }
  2014. // Sent when the a Handler closes while a client has
  2015. // indicated it's still sending DATA:
  2016. st.wantRSTStream(1, ErrCodeCancel)
  2017. // Now the handler has ended, so it's ended its
  2018. // stream, but the client hasn't closed its side
  2019. // (stateClosedLocal). So send more data and verify
  2020. // it doesn't crash with an internal invariant panic, like
  2021. // it did before.
  2022. st.writeData(1, true, []byte("foo"))
  2023. // Get our flow control bytes back, since the handler didn't get them.
  2024. st.wantWindowUpdate(0, uint32(len("foo")))
  2025. // Sent after a peer sends data anyway (admittedly the
  2026. // previous RST_STREAM might've still been in-flight),
  2027. // but they'll get the more friendly 'cancel' code
  2028. // first.
  2029. st.wantRSTStream(1, ErrCodeStreamClosed)
  2030. // Set up a bunch of machinery to record the panic we saw
  2031. // previously.
  2032. var (
  2033. panMu sync.Mutex
  2034. panicVal interface{}
  2035. )
  2036. testHookOnPanicMu.Lock()
  2037. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2038. panMu.Lock()
  2039. panicVal = pv
  2040. panMu.Unlock()
  2041. return true
  2042. }
  2043. testHookOnPanicMu.Unlock()
  2044. // Now force the serve loop to end, via closing the connection.
  2045. st.cc.Close()
  2046. select {
  2047. case <-st.sc.doneServing:
  2048. // Loop has exited.
  2049. panMu.Lock()
  2050. got := panicVal
  2051. panMu.Unlock()
  2052. if got != nil {
  2053. t.Errorf("Got panic: %v", got)
  2054. }
  2055. case <-time.After(5 * time.Second):
  2056. t.Error("timeout")
  2057. }
  2058. })
  2059. }
  2060. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2061. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2062. func testRejectTLS(t *testing.T, max uint16) {
  2063. st := newServerTester(t, nil, func(c *tls.Config) {
  2064. c.MaxVersion = max
  2065. })
  2066. defer st.Close()
  2067. gf := st.wantGoAway()
  2068. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2069. t.Errorf("Got error code %v; want %v", got, want)
  2070. }
  2071. }
  2072. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2073. st := newServerTester(t, nil, func(c *tls.Config) {
  2074. // Only list bad ones:
  2075. c.CipherSuites = []uint16{
  2076. tls.TLS_RSA_WITH_RC4_128_SHA,
  2077. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2078. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2079. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2080. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2081. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2082. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2083. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2084. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2085. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2086. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2087. }
  2088. })
  2089. defer st.Close()
  2090. gf := st.wantGoAway()
  2091. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2092. t.Errorf("Got error code %v; want %v", got, want)
  2093. }
  2094. }
  2095. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2096. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2097. st := newServerTester(t, nil, func(c *tls.Config) {
  2098. // Have the client only support the one required by the spec.
  2099. c.CipherSuites = []uint16{requiredSuite}
  2100. }, func(ts *httptest.Server) {
  2101. var srv *http.Server = ts.Config
  2102. // Have the server configured with no specific cipher suites.
  2103. // This tests that Go's defaults include the required one.
  2104. srv.TLSConfig = nil
  2105. })
  2106. defer st.Close()
  2107. st.greet()
  2108. }
  2109. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2110. if f.Name == "date" {
  2111. return
  2112. }
  2113. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2114. }
  2115. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2116. st.decodedHeaders = nil
  2117. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2118. st.t.Fatalf("hpack decoding error: %v", err)
  2119. }
  2120. if err := st.hpackDec.Close(); err != nil {
  2121. st.t.Fatalf("hpack decoding error: %v", err)
  2122. }
  2123. return st.decodedHeaders
  2124. }
  2125. // testServerResponse sets up an idle HTTP/2 connection and lets you
  2126. // write a single request with writeReq, and then reply to it in some way with the provided handler,
  2127. // and then verify the output with the serverTester again (assuming the handler returns nil)
  2128. func testServerResponse(t testing.TB,
  2129. handler func(http.ResponseWriter, *http.Request) error,
  2130. client func(*serverTester),
  2131. ) {
  2132. errc := make(chan error, 1)
  2133. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2134. if r.Body == nil {
  2135. t.Fatal("nil Body")
  2136. }
  2137. errc <- handler(w, r)
  2138. })
  2139. defer st.Close()
  2140. donec := make(chan bool)
  2141. go func() {
  2142. defer close(donec)
  2143. st.greet()
  2144. client(st)
  2145. }()
  2146. select {
  2147. case <-donec:
  2148. return
  2149. case <-time.After(5 * time.Second):
  2150. t.Fatal("timeout")
  2151. }
  2152. select {
  2153. case err := <-errc:
  2154. if err != nil {
  2155. t.Fatalf("Error in handler: %v", err)
  2156. }
  2157. case <-time.After(2 * time.Second):
  2158. t.Error("timeout waiting for handler to finish")
  2159. }
  2160. }
  2161. // readBodyHandler returns an http Handler func that reads len(want)
  2162. // bytes from r.Body and fails t if the contents read were not
  2163. // the value of want.
  2164. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2165. return func(w http.ResponseWriter, r *http.Request) {
  2166. buf := make([]byte, len(want))
  2167. _, err := io.ReadFull(r.Body, buf)
  2168. if err != nil {
  2169. t.Error(err)
  2170. return
  2171. }
  2172. if string(buf) != want {
  2173. t.Errorf("read %q; want %q", buf, want)
  2174. }
  2175. }
  2176. }
  2177. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2178. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2179. // http://sourceforge.net/p/curl/bugs/1472/
  2180. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2181. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2182. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2183. if runtime.GOOS != "linux" {
  2184. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2185. }
  2186. if testing.Short() {
  2187. t.Skip("skipping curl test in short mode")
  2188. }
  2189. requireCurl(t)
  2190. var gotConn int32
  2191. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2192. const msg = "Hello from curl!\n"
  2193. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2194. w.Header().Set("Foo", "Bar")
  2195. w.Header().Set("Client-Proto", r.Proto)
  2196. io.WriteString(w, msg)
  2197. }))
  2198. ConfigureServer(ts.Config, &Server{
  2199. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2200. })
  2201. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2202. ts.StartTLS()
  2203. defer ts.Close()
  2204. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2205. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2206. defer kill(container)
  2207. resc := make(chan interface{}, 1)
  2208. go func() {
  2209. res, err := dockerLogs(container)
  2210. if err != nil {
  2211. resc <- err
  2212. } else {
  2213. resc <- res
  2214. }
  2215. }()
  2216. select {
  2217. case res := <-resc:
  2218. if err, ok := res.(error); ok {
  2219. t.Fatal(err)
  2220. }
  2221. body := string(res.([]byte))
  2222. // Search for both "key: value" and "key:value", since curl changed their format
  2223. // Our Dockerfile contains the latest version (no space), but just in case people
  2224. // didn't rebuild, check both.
  2225. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2226. t.Errorf("didn't see foo: Bar header")
  2227. t.Logf("Got: %s", body)
  2228. }
  2229. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2230. t.Errorf("didn't see client-proto: HTTP/2 header")
  2231. t.Logf("Got: %s", res)
  2232. }
  2233. if !strings.Contains(string(res.([]byte)), msg) {
  2234. t.Errorf("didn't see %q content", msg)
  2235. t.Logf("Got: %s", res)
  2236. }
  2237. case <-time.After(3 * time.Second):
  2238. t.Errorf("timeout waiting for curl")
  2239. }
  2240. if atomic.LoadInt32(&gotConn) == 0 {
  2241. t.Error("never saw an http2 connection")
  2242. }
  2243. }
  2244. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2245. func TestServerWithH2Load(t *testing.T) {
  2246. if !*doh2load {
  2247. t.Skip("Skipping without --h2load flag.")
  2248. }
  2249. if runtime.GOOS != "linux" {
  2250. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2251. }
  2252. requireH2load(t)
  2253. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2254. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2255. io.WriteString(w, msg)
  2256. w.(http.Flusher).Flush()
  2257. io.WriteString(w, msg)
  2258. }))
  2259. ts.StartTLS()
  2260. defer ts.Close()
  2261. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2262. "-n100000", "-c100", "-m100", ts.URL)
  2263. cmd.Stdout = os.Stdout
  2264. cmd.Stderr = os.Stderr
  2265. if err := cmd.Run(); err != nil {
  2266. t.Fatal(err)
  2267. }
  2268. }
  2269. // Issue 12843
  2270. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2271. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2272. defer st.Close()
  2273. // shake hands
  2274. st.writePreface()
  2275. st.writeInitialSettings()
  2276. frameSize := defaultMaxReadFrameSize
  2277. var advHeaderListSize *uint32
  2278. st.wantSettings().ForeachSetting(func(s Setting) error {
  2279. switch s.ID {
  2280. case SettingMaxFrameSize:
  2281. if s.Val < minMaxFrameSize {
  2282. frameSize = minMaxFrameSize
  2283. } else if s.Val > maxFrameSize {
  2284. frameSize = maxFrameSize
  2285. } else {
  2286. frameSize = int(s.Val)
  2287. }
  2288. case SettingMaxHeaderListSize:
  2289. advHeaderListSize = &s.Val
  2290. }
  2291. return nil
  2292. })
  2293. st.writeSettingsAck()
  2294. st.wantSettingsAck()
  2295. if advHeaderListSize == nil {
  2296. t.Errorf("server didn't advertise a max header list size")
  2297. } else if *advHeaderListSize == 0 {
  2298. t.Errorf("server advertised a max header list size of 0")
  2299. }
  2300. st.encodeHeaderField(":method", "GET")
  2301. st.encodeHeaderField(":path", "/")
  2302. st.encodeHeaderField(":scheme", "https")
  2303. cookie := strings.Repeat("*", 4058)
  2304. st.encodeHeaderField("cookie", cookie)
  2305. st.writeHeaders(HeadersFrameParam{
  2306. StreamID: 1,
  2307. BlockFragment: st.headerBuf.Bytes(),
  2308. EndStream: true,
  2309. EndHeaders: false,
  2310. })
  2311. // Capture the short encoding of a duplicate ~4K cookie, now
  2312. // that we've already sent it once.
  2313. st.headerBuf.Reset()
  2314. st.encodeHeaderField("cookie", cookie)
  2315. // Now send 1MB of it.
  2316. const size = 1 << 20
  2317. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2318. for len(b) > 0 {
  2319. chunk := b
  2320. if len(chunk) > frameSize {
  2321. chunk = chunk[:frameSize]
  2322. }
  2323. b = b[len(chunk):]
  2324. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2325. }
  2326. h := st.wantHeaders()
  2327. if !h.HeadersEnded() {
  2328. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2329. }
  2330. headers := st.decodeHeader(h.HeaderBlockFragment())
  2331. want := [][2]string{
  2332. {":status", "431"},
  2333. {"content-type", "text/html; charset=utf-8"},
  2334. {"content-length", "63"},
  2335. }
  2336. if !reflect.DeepEqual(headers, want) {
  2337. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2338. }
  2339. }
  2340. func TestCompressionErrorOnWrite(t *testing.T) {
  2341. const maxStrLen = 8 << 10
  2342. var serverConfig *http.Server
  2343. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2344. // No response body.
  2345. }, func(ts *httptest.Server) {
  2346. serverConfig = ts.Config
  2347. serverConfig.MaxHeaderBytes = maxStrLen
  2348. })
  2349. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2350. defer st.Close()
  2351. st.greet()
  2352. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2353. // Crank this up, now that we have a conn connected with the
  2354. // hpack.Decoder's max string length set has been initialized
  2355. // from the earlier low ~8K value. We want this higher so don't
  2356. // hit the max header list size. We only want to test hitting
  2357. // the max string size.
  2358. serverConfig.MaxHeaderBytes = 1 << 20
  2359. // First a request with a header that's exactly the max allowed size
  2360. // for the hpack compression. It's still too long for the header list
  2361. // size, so we'll get the 431 error, but that keeps the compression
  2362. // context still valid.
  2363. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2364. st.writeHeaders(HeadersFrameParam{
  2365. StreamID: 1,
  2366. BlockFragment: hbf,
  2367. EndStream: true,
  2368. EndHeaders: true,
  2369. })
  2370. h := st.wantHeaders()
  2371. if !h.HeadersEnded() {
  2372. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2373. }
  2374. headers := st.decodeHeader(h.HeaderBlockFragment())
  2375. want := [][2]string{
  2376. {":status", "431"},
  2377. {"content-type", "text/html; charset=utf-8"},
  2378. {"content-length", "63"},
  2379. }
  2380. if !reflect.DeepEqual(headers, want) {
  2381. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2382. }
  2383. df := st.wantData()
  2384. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2385. t.Errorf("Unexpected data body: %q", df.Data())
  2386. }
  2387. if !df.StreamEnded() {
  2388. t.Fatalf("expect data stream end")
  2389. }
  2390. // And now send one that's just one byte too big.
  2391. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2392. st.writeHeaders(HeadersFrameParam{
  2393. StreamID: 3,
  2394. BlockFragment: hbf,
  2395. EndStream: true,
  2396. EndHeaders: true,
  2397. })
  2398. ga := st.wantGoAway()
  2399. if ga.ErrCode != ErrCodeCompression {
  2400. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2401. }
  2402. }
  2403. func TestCompressionErrorOnClose(t *testing.T) {
  2404. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2405. // No response body.
  2406. })
  2407. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2408. defer st.Close()
  2409. st.greet()
  2410. hbf := st.encodeHeader("foo", "bar")
  2411. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2412. st.writeHeaders(HeadersFrameParam{
  2413. StreamID: 1,
  2414. BlockFragment: hbf,
  2415. EndStream: true,
  2416. EndHeaders: true,
  2417. })
  2418. ga := st.wantGoAway()
  2419. if ga.ErrCode != ErrCodeCompression {
  2420. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2421. }
  2422. }
  2423. // test that a server handler can read trailers from a client
  2424. func TestServerReadsTrailers(t *testing.T) {
  2425. const testBody = "some test body"
  2426. writeReq := func(st *serverTester) {
  2427. st.writeHeaders(HeadersFrameParam{
  2428. StreamID: 1, // clients send odd numbers
  2429. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2430. EndStream: false,
  2431. EndHeaders: true,
  2432. })
  2433. st.writeData(1, false, []byte(testBody))
  2434. st.writeHeaders(HeadersFrameParam{
  2435. StreamID: 1, // clients send odd numbers
  2436. BlockFragment: st.encodeHeaderRaw(
  2437. "foo", "foov",
  2438. "bar", "barv",
  2439. "baz", "bazv",
  2440. "surprise", "wasn't declared; shouldn't show up",
  2441. ),
  2442. EndStream: true,
  2443. EndHeaders: true,
  2444. })
  2445. }
  2446. checkReq := func(r *http.Request) {
  2447. wantTrailer := http.Header{
  2448. "Foo": nil,
  2449. "Bar": nil,
  2450. "Baz": nil,
  2451. }
  2452. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2453. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2454. }
  2455. slurp, err := ioutil.ReadAll(r.Body)
  2456. if string(slurp) != testBody {
  2457. t.Errorf("read body %q; want %q", slurp, testBody)
  2458. }
  2459. if err != nil {
  2460. t.Fatalf("Body slurp: %v", err)
  2461. }
  2462. wantTrailerAfter := http.Header{
  2463. "Foo": {"foov"},
  2464. "Bar": {"barv"},
  2465. "Baz": {"bazv"},
  2466. }
  2467. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2468. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2469. }
  2470. }
  2471. testServerRequest(t, writeReq, checkReq)
  2472. }
  2473. // test that a server handler can send trailers
  2474. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2475. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2476. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2477. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2478. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2479. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2480. w.Header().Add("Trailer", "Server-Trailer-C")
  2481. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2482. // Regular headers:
  2483. w.Header().Set("Foo", "Bar")
  2484. w.Header().Set("Content-Length", "5") // len("Hello")
  2485. io.WriteString(w, "Hello")
  2486. if withFlush {
  2487. w.(http.Flusher).Flush()
  2488. }
  2489. w.Header().Set("Server-Trailer-A", "valuea")
  2490. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2491. // After a flush, random keys like Server-Surprise shouldn't show up:
  2492. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2493. // But we do permit promoting keys to trailers after a
  2494. // flush if they start with the magic
  2495. // otherwise-invalid "Trailer:" prefix:
  2496. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2497. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2498. w.Header().Set("Trailer:Range", "invalid")
  2499. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2500. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2501. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2502. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2503. return nil
  2504. }, func(st *serverTester) {
  2505. getSlash(st)
  2506. hf := st.wantHeaders()
  2507. if hf.StreamEnded() {
  2508. t.Fatal("response HEADERS had END_STREAM")
  2509. }
  2510. if !hf.HeadersEnded() {
  2511. t.Fatal("response HEADERS didn't have END_HEADERS")
  2512. }
  2513. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2514. wanth := [][2]string{
  2515. {":status", "200"},
  2516. {"foo", "Bar"},
  2517. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2518. {"trailer", "Server-Trailer-C"},
  2519. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2520. {"content-type", "text/plain; charset=utf-8"},
  2521. {"content-length", "5"},
  2522. }
  2523. if !reflect.DeepEqual(goth, wanth) {
  2524. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2525. }
  2526. df := st.wantData()
  2527. if string(df.Data()) != "Hello" {
  2528. t.Fatalf("Client read %q; want Hello", df.Data())
  2529. }
  2530. if df.StreamEnded() {
  2531. t.Fatalf("data frame had STREAM_ENDED")
  2532. }
  2533. tf := st.wantHeaders() // for the trailers
  2534. if !tf.StreamEnded() {
  2535. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2536. }
  2537. if !tf.HeadersEnded() {
  2538. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2539. }
  2540. wanth = [][2]string{
  2541. {"post-header-trailer", "hi1"},
  2542. {"post-header-trailer2", "hi2"},
  2543. {"server-trailer-a", "valuea"},
  2544. {"server-trailer-c", "valuec"},
  2545. }
  2546. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2547. if !reflect.DeepEqual(goth, wanth) {
  2548. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2549. }
  2550. })
  2551. }
  2552. // validate transmitted header field names & values
  2553. // golang.org/issue/14048
  2554. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2555. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2556. w.Header().Add("OK1", "x")
  2557. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2558. w.Header().Add("Bad1\x00", "x") // null in key
  2559. w.Header().Add("Bad2", "x\x00y") // null in value
  2560. return nil
  2561. }, func(st *serverTester) {
  2562. getSlash(st)
  2563. hf := st.wantHeaders()
  2564. if !hf.StreamEnded() {
  2565. t.Error("response HEADERS lacked END_STREAM")
  2566. }
  2567. if !hf.HeadersEnded() {
  2568. t.Fatal("response HEADERS didn't have END_HEADERS")
  2569. }
  2570. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2571. wanth := [][2]string{
  2572. {":status", "200"},
  2573. {"ok1", "x"},
  2574. {"content-type", "text/plain; charset=utf-8"},
  2575. {"content-length", "0"},
  2576. }
  2577. if !reflect.DeepEqual(goth, wanth) {
  2578. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2579. }
  2580. })
  2581. }
  2582. func BenchmarkServerGets(b *testing.B) {
  2583. defer disableGoroutineTracking()()
  2584. b.ReportAllocs()
  2585. const msg = "Hello, world"
  2586. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2587. io.WriteString(w, msg)
  2588. })
  2589. defer st.Close()
  2590. st.greet()
  2591. // Give the server quota to reply. (plus it has the the 64KB)
  2592. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2593. b.Fatal(err)
  2594. }
  2595. for i := 0; i < b.N; i++ {
  2596. id := 1 + uint32(i)*2
  2597. st.writeHeaders(HeadersFrameParam{
  2598. StreamID: id,
  2599. BlockFragment: st.encodeHeader(),
  2600. EndStream: true,
  2601. EndHeaders: true,
  2602. })
  2603. st.wantHeaders()
  2604. df := st.wantData()
  2605. if !df.StreamEnded() {
  2606. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2607. }
  2608. }
  2609. }
  2610. func BenchmarkServerPosts(b *testing.B) {
  2611. defer disableGoroutineTracking()()
  2612. b.ReportAllocs()
  2613. const msg = "Hello, world"
  2614. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2615. io.WriteString(w, msg)
  2616. })
  2617. defer st.Close()
  2618. st.greet()
  2619. // Give the server quota to reply. (plus it has the the 64KB)
  2620. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2621. b.Fatal(err)
  2622. }
  2623. for i := 0; i < b.N; i++ {
  2624. id := 1 + uint32(i)*2
  2625. st.writeHeaders(HeadersFrameParam{
  2626. StreamID: id,
  2627. BlockFragment: st.encodeHeader(":method", "POST"),
  2628. EndStream: false,
  2629. EndHeaders: true,
  2630. })
  2631. st.writeData(id, true, nil)
  2632. st.wantHeaders()
  2633. df := st.wantData()
  2634. if !df.StreamEnded() {
  2635. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2636. }
  2637. }
  2638. }
  2639. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2640. // Verify we don't hang.
  2641. func TestIssue53(t *testing.T) {
  2642. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2643. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2644. s := &http.Server{
  2645. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2646. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2647. w.Write([]byte("hello"))
  2648. }),
  2649. }
  2650. s2 := &Server{
  2651. MaxReadFrameSize: 1 << 16,
  2652. PermitProhibitedCipherSuites: true,
  2653. }
  2654. c := &issue53Conn{[]byte(data), false, false}
  2655. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2656. if !c.closed {
  2657. t.Fatal("connection is not closed")
  2658. }
  2659. }
  2660. type issue53Conn struct {
  2661. data []byte
  2662. closed bool
  2663. written bool
  2664. }
  2665. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2666. if len(c.data) == 0 {
  2667. return 0, io.EOF
  2668. }
  2669. n = copy(b, c.data)
  2670. c.data = c.data[n:]
  2671. return
  2672. }
  2673. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2674. c.written = true
  2675. return len(b), nil
  2676. }
  2677. func (c *issue53Conn) Close() error {
  2678. c.closed = true
  2679. return nil
  2680. }
  2681. func (c *issue53Conn) LocalAddr() net.Addr {
  2682. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2683. }
  2684. func (c *issue53Conn) RemoteAddr() net.Addr {
  2685. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2686. }
  2687. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2688. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2689. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2690. // golang.org/issue/12895
  2691. func TestConfigureServer(t *testing.T) {
  2692. tests := []struct {
  2693. name string
  2694. in http.Server
  2695. wantErr string
  2696. }{
  2697. {
  2698. name: "empty server",
  2699. in: http.Server{},
  2700. },
  2701. {
  2702. name: "just the required cipher suite",
  2703. in: http.Server{
  2704. TLSConfig: &tls.Config{
  2705. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2706. },
  2707. },
  2708. },
  2709. {
  2710. name: "missing required cipher suite",
  2711. in: http.Server{
  2712. TLSConfig: &tls.Config{
  2713. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2714. },
  2715. },
  2716. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2717. },
  2718. {
  2719. name: "required after bad",
  2720. in: http.Server{
  2721. TLSConfig: &tls.Config{
  2722. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2723. },
  2724. },
  2725. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2726. },
  2727. {
  2728. name: "bad after required",
  2729. in: http.Server{
  2730. TLSConfig: &tls.Config{
  2731. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2732. },
  2733. },
  2734. },
  2735. }
  2736. for _, tt := range tests {
  2737. err := ConfigureServer(&tt.in, nil)
  2738. if (err != nil) != (tt.wantErr != "") {
  2739. if tt.wantErr != "" {
  2740. t.Errorf("%s: success, but want error", tt.name)
  2741. } else {
  2742. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2743. }
  2744. }
  2745. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2746. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2747. }
  2748. if err == nil && !tt.in.TLSConfig.PreferServerCipherSuites {
  2749. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2750. }
  2751. }
  2752. }
  2753. func TestServerRejectHeadWithBody(t *testing.T) {
  2754. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2755. // No response body.
  2756. })
  2757. defer st.Close()
  2758. st.greet()
  2759. st.writeHeaders(HeadersFrameParam{
  2760. StreamID: 1, // clients send odd numbers
  2761. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2762. EndStream: false, // what we're testing, a bogus HEAD request with body
  2763. EndHeaders: true,
  2764. })
  2765. st.wantRSTStream(1, ErrCodeProtocol)
  2766. }
  2767. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2768. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2769. // No response body. (or smaller than one frame)
  2770. })
  2771. defer st.Close()
  2772. st.greet()
  2773. st.writeHeaders(HeadersFrameParam{
  2774. StreamID: 1, // clients send odd numbers
  2775. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2776. EndStream: true,
  2777. EndHeaders: true,
  2778. })
  2779. h := st.wantHeaders()
  2780. headers := st.decodeHeader(h.HeaderBlockFragment())
  2781. want := [][2]string{
  2782. {":status", "200"},
  2783. {"content-type", "text/plain; charset=utf-8"},
  2784. }
  2785. if !reflect.DeepEqual(headers, want) {
  2786. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2787. }
  2788. }
  2789. // golang.org/issue/13495
  2790. func TestServerNoDuplicateContentType(t *testing.T) {
  2791. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2792. w.Header()["Content-Type"] = []string{""}
  2793. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2794. })
  2795. defer st.Close()
  2796. st.greet()
  2797. st.writeHeaders(HeadersFrameParam{
  2798. StreamID: 1,
  2799. BlockFragment: st.encodeHeader(),
  2800. EndStream: true,
  2801. EndHeaders: true,
  2802. })
  2803. h := st.wantHeaders()
  2804. headers := st.decodeHeader(h.HeaderBlockFragment())
  2805. want := [][2]string{
  2806. {":status", "200"},
  2807. {"content-type", ""},
  2808. {"content-length", "41"},
  2809. }
  2810. if !reflect.DeepEqual(headers, want) {
  2811. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2812. }
  2813. }
  2814. func disableGoroutineTracking() (restore func()) {
  2815. old := DebugGoroutines
  2816. DebugGoroutines = false
  2817. return func() { DebugGoroutines = old }
  2818. }
  2819. func BenchmarkServer_GetRequest(b *testing.B) {
  2820. defer disableGoroutineTracking()()
  2821. b.ReportAllocs()
  2822. const msg = "Hello, world."
  2823. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2824. n, err := io.Copy(ioutil.Discard, r.Body)
  2825. if err != nil || n > 0 {
  2826. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2827. }
  2828. io.WriteString(w, msg)
  2829. })
  2830. defer st.Close()
  2831. st.greet()
  2832. // Give the server quota to reply. (plus it has the the 64KB)
  2833. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2834. b.Fatal(err)
  2835. }
  2836. hbf := st.encodeHeader(":method", "GET")
  2837. for i := 0; i < b.N; i++ {
  2838. streamID := uint32(1 + 2*i)
  2839. st.writeHeaders(HeadersFrameParam{
  2840. StreamID: streamID,
  2841. BlockFragment: hbf,
  2842. EndStream: true,
  2843. EndHeaders: true,
  2844. })
  2845. st.wantHeaders()
  2846. st.wantData()
  2847. }
  2848. }
  2849. func BenchmarkServer_PostRequest(b *testing.B) {
  2850. defer disableGoroutineTracking()()
  2851. b.ReportAllocs()
  2852. const msg = "Hello, world."
  2853. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2854. n, err := io.Copy(ioutil.Discard, r.Body)
  2855. if err != nil || n > 0 {
  2856. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2857. }
  2858. io.WriteString(w, msg)
  2859. })
  2860. defer st.Close()
  2861. st.greet()
  2862. // Give the server quota to reply. (plus it has the the 64KB)
  2863. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2864. b.Fatal(err)
  2865. }
  2866. hbf := st.encodeHeader(":method", "POST")
  2867. for i := 0; i < b.N; i++ {
  2868. streamID := uint32(1 + 2*i)
  2869. st.writeHeaders(HeadersFrameParam{
  2870. StreamID: streamID,
  2871. BlockFragment: hbf,
  2872. EndStream: false,
  2873. EndHeaders: true,
  2874. })
  2875. st.writeData(streamID, true, nil)
  2876. st.wantHeaders()
  2877. st.wantData()
  2878. }
  2879. }
  2880. type connStateConn struct {
  2881. net.Conn
  2882. cs tls.ConnectionState
  2883. }
  2884. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  2885. // golang.org/issue/12737 -- handle any net.Conn, not just
  2886. // *tls.Conn.
  2887. func TestServerHandleCustomConn(t *testing.T) {
  2888. var s Server
  2889. c1, c2 := net.Pipe()
  2890. clientDone := make(chan struct{})
  2891. handlerDone := make(chan struct{})
  2892. var req *http.Request
  2893. go func() {
  2894. defer close(clientDone)
  2895. defer c2.Close()
  2896. fr := NewFramer(c2, c2)
  2897. io.WriteString(c2, ClientPreface)
  2898. fr.WriteSettings()
  2899. fr.WriteSettingsAck()
  2900. f, err := fr.ReadFrame()
  2901. if err != nil {
  2902. t.Error(err)
  2903. return
  2904. }
  2905. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  2906. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  2907. return
  2908. }
  2909. f, err = fr.ReadFrame()
  2910. if err != nil {
  2911. t.Error(err)
  2912. return
  2913. }
  2914. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  2915. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  2916. return
  2917. }
  2918. var henc hpackEncoder
  2919. fr.WriteHeaders(HeadersFrameParam{
  2920. StreamID: 1,
  2921. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  2922. EndStream: true,
  2923. EndHeaders: true,
  2924. })
  2925. go io.Copy(ioutil.Discard, c2)
  2926. <-handlerDone
  2927. }()
  2928. const testString = "my custom ConnectionState"
  2929. fakeConnState := tls.ConnectionState{
  2930. ServerName: testString,
  2931. Version: tls.VersionTLS12,
  2932. }
  2933. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  2934. BaseConfig: &http.Server{
  2935. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2936. defer close(handlerDone)
  2937. req = r
  2938. }),
  2939. }})
  2940. select {
  2941. case <-clientDone:
  2942. case <-time.After(5 * time.Second):
  2943. t.Fatal("timeout waiting for handler")
  2944. }
  2945. if req.TLS == nil {
  2946. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  2947. }
  2948. if req.TLS.ServerName != testString {
  2949. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  2950. }
  2951. }
  2952. // golang.org/issue/14214
  2953. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  2954. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2955. t.Errorf("should not get to Handler")
  2956. return nil
  2957. }, func(st *serverTester) {
  2958. st.bodylessReq1("connection", "foo")
  2959. hf := st.wantHeaders()
  2960. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2961. wanth := [][2]string{
  2962. {":status", "400"},
  2963. {"content-type", "text/plain; charset=utf-8"},
  2964. {"x-content-type-options", "nosniff"},
  2965. {"content-length", "51"},
  2966. }
  2967. if !reflect.DeepEqual(goth, wanth) {
  2968. t.Errorf("Got headers %v; want %v", goth, wanth)
  2969. }
  2970. })
  2971. }
  2972. type hpackEncoder struct {
  2973. enc *hpack.Encoder
  2974. buf bytes.Buffer
  2975. }
  2976. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  2977. if len(headers)%2 == 1 {
  2978. panic("odd number of kv args")
  2979. }
  2980. he.buf.Reset()
  2981. if he.enc == nil {
  2982. he.enc = hpack.NewEncoder(&he.buf)
  2983. }
  2984. for len(headers) > 0 {
  2985. k, v := headers[0], headers[1]
  2986. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  2987. if err != nil {
  2988. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  2989. }
  2990. headers = headers[2:]
  2991. }
  2992. return he.buf.Bytes()
  2993. }
  2994. func TestCheckValidHTTP2Request(t *testing.T) {
  2995. tests := []struct {
  2996. req *http.Request
  2997. want error
  2998. }{
  2999. {
  3000. req: &http.Request{Header: http.Header{"Te": {"trailers"}}},
  3001. want: nil,
  3002. },
  3003. {
  3004. req: &http.Request{Header: http.Header{"Te": {"trailers", "bogus"}}},
  3005. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3006. },
  3007. {
  3008. req: &http.Request{Header: http.Header{"Foo": {""}}},
  3009. want: nil,
  3010. },
  3011. {
  3012. req: &http.Request{Header: http.Header{"Connection": {""}}},
  3013. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3014. },
  3015. {
  3016. req: &http.Request{Header: http.Header{"Proxy-Connection": {""}}},
  3017. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3018. },
  3019. {
  3020. req: &http.Request{Header: http.Header{"Keep-Alive": {""}}},
  3021. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3022. },
  3023. {
  3024. req: &http.Request{Header: http.Header{"Upgrade": {""}}},
  3025. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3026. },
  3027. }
  3028. for i, tt := range tests {
  3029. got := checkValidHTTP2Request(tt.req)
  3030. if !reflect.DeepEqual(got, tt.want) {
  3031. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3032. }
  3033. }
  3034. }
  3035. // golang.org/issue/14030
  3036. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3037. const msg = "Hello"
  3038. const msg2 = "World"
  3039. doRead := make(chan bool, 1)
  3040. defer close(doRead) // fallback cleanup
  3041. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3042. io.WriteString(w, msg)
  3043. w.(http.Flusher).Flush()
  3044. // Do a read, which might force a 100-continue status to be sent.
  3045. <-doRead
  3046. r.Body.Read(make([]byte, 10))
  3047. io.WriteString(w, msg2)
  3048. }, optOnlyServer)
  3049. defer st.Close()
  3050. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3051. defer tr.CloseIdleConnections()
  3052. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3053. req.Header.Set("Expect", "100-continue")
  3054. res, err := tr.RoundTrip(req)
  3055. if err != nil {
  3056. t.Fatal(err)
  3057. }
  3058. defer res.Body.Close()
  3059. buf := make([]byte, len(msg))
  3060. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3061. t.Fatal(err)
  3062. }
  3063. if string(buf) != msg {
  3064. t.Fatalf("msg = %q; want %q", buf, msg)
  3065. }
  3066. doRead <- true
  3067. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3068. t.Fatal(err)
  3069. }
  3070. if string(buf) != msg2 {
  3071. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3072. }
  3073. }
  3074. type funcReader func([]byte) (n int, err error)
  3075. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3076. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3077. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3078. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3079. unblock := make(chan bool, 1)
  3080. defer close(unblock)
  3081. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3082. // Don't read the 16KB request body. Wait until the client's
  3083. // done sending it and then return. This should cause the Server
  3084. // to then return those 16KB of flow control to the client.
  3085. <-unblock
  3086. }, optOnlyServer)
  3087. defer st.Close()
  3088. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3089. defer tr.CloseIdleConnections()
  3090. // This previously hung on the 4th iteration.
  3091. for i := 0; i < 6; i++ {
  3092. body := io.MultiReader(
  3093. io.LimitReader(neverEnding('A'), 16<<10),
  3094. funcReader(func([]byte) (n int, err error) {
  3095. unblock <- true
  3096. return 0, io.EOF
  3097. }),
  3098. )
  3099. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3100. res, err := tr.RoundTrip(req)
  3101. if err != nil {
  3102. t.Fatal(err)
  3103. }
  3104. res.Body.Close()
  3105. }
  3106. }