server_test.go 97 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. logBuf *bytes.Buffer
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // writing headers:
  48. headerBuf bytes.Buffer
  49. hpackEnc *hpack.Encoder
  50. }
  51. func init() {
  52. testHookOnPanicMu = new(sync.Mutex)
  53. }
  54. func resetHooks() {
  55. testHookOnPanicMu.Lock()
  56. testHookOnPanic = nil
  57. testHookOnPanicMu.Unlock()
  58. }
  59. type serverTesterOpt string
  60. var optOnlyServer = serverTesterOpt("only_server")
  61. var optQuiet = serverTesterOpt("quiet_logging")
  62. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  63. resetHooks()
  64. logBuf := new(bytes.Buffer)
  65. ts := httptest.NewUnstartedServer(handler)
  66. tlsConfig := &tls.Config{
  67. InsecureSkipVerify: true,
  68. NextProtos: []string{NextProtoTLS},
  69. }
  70. var onlyServer, quiet bool
  71. h2server := new(Server)
  72. for _, opt := range opts {
  73. switch v := opt.(type) {
  74. case func(*tls.Config):
  75. v(tlsConfig)
  76. case func(*httptest.Server):
  77. v(ts)
  78. case func(*Server):
  79. v(h2server)
  80. case serverTesterOpt:
  81. switch v {
  82. case optOnlyServer:
  83. onlyServer = true
  84. case optQuiet:
  85. quiet = true
  86. }
  87. case func(net.Conn, http.ConnState):
  88. ts.Config.ConnState = v
  89. default:
  90. t.Fatalf("unknown newServerTester option type %T", v)
  91. }
  92. }
  93. ConfigureServer(ts.Config, h2server)
  94. st := &serverTester{
  95. t: t,
  96. ts: ts,
  97. logBuf: logBuf,
  98. }
  99. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  100. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  101. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  102. if quiet {
  103. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  104. } else {
  105. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  106. }
  107. ts.StartTLS()
  108. if VerboseLogs {
  109. t.Logf("Running test server at: %s", ts.URL)
  110. }
  111. testHookGetServerConn = func(v *serverConn) {
  112. st.scMu.Lock()
  113. defer st.scMu.Unlock()
  114. st.sc = v
  115. st.sc.testHookCh = make(chan func(int))
  116. }
  117. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  118. if !onlyServer {
  119. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  120. if err != nil {
  121. t.Fatal(err)
  122. }
  123. st.cc = cc
  124. st.fr = NewFramer(cc, cc)
  125. }
  126. return st
  127. }
  128. func (st *serverTester) closeConn() {
  129. st.scMu.Lock()
  130. defer st.scMu.Unlock()
  131. st.sc.conn.Close()
  132. }
  133. func (st *serverTester) addLogFilter(phrase string) {
  134. st.logFilter = append(st.logFilter, phrase)
  135. }
  136. func (st *serverTester) stream(id uint32) *stream {
  137. ch := make(chan *stream, 1)
  138. st.sc.testHookCh <- func(int) {
  139. ch <- st.sc.streams[id]
  140. }
  141. return <-ch
  142. }
  143. func (st *serverTester) streamState(id uint32) streamState {
  144. ch := make(chan streamState, 1)
  145. st.sc.testHookCh <- func(int) {
  146. state, _ := st.sc.state(id)
  147. ch <- state
  148. }
  149. return <-ch
  150. }
  151. // loopNum reports how many times this conn's select loop has gone around.
  152. func (st *serverTester) loopNum() int {
  153. lastc := make(chan int, 1)
  154. st.sc.testHookCh <- func(loopNum int) {
  155. lastc <- loopNum
  156. }
  157. return <-lastc
  158. }
  159. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  160. // The heuristic is that the server connection's serve loop must schedule
  161. // 50 times in a row without any channel sends or receives occurring.
  162. func (st *serverTester) awaitIdle() {
  163. remain := 50
  164. last := st.loopNum()
  165. for remain > 0 {
  166. n := st.loopNum()
  167. if n == last+1 {
  168. remain--
  169. } else {
  170. remain = 50
  171. }
  172. last = n
  173. }
  174. }
  175. func (st *serverTester) Close() {
  176. if st.t.Failed() {
  177. // If we failed already (and are likely in a Fatal,
  178. // unwindowing), force close the connection, so the
  179. // httptest.Server doesn't wait forever for the conn
  180. // to close.
  181. if st.cc != nil {
  182. st.cc.Close()
  183. }
  184. }
  185. st.ts.Close()
  186. if st.cc != nil {
  187. st.cc.Close()
  188. }
  189. log.SetOutput(os.Stderr)
  190. }
  191. // greet initiates the client's HTTP/2 connection into a state where
  192. // frames may be sent.
  193. func (st *serverTester) greet() {
  194. st.writePreface()
  195. st.writeInitialSettings()
  196. st.wantSettings()
  197. st.writeSettingsAck()
  198. st.wantSettingsAck()
  199. }
  200. func (st *serverTester) writePreface() {
  201. n, err := st.cc.Write(clientPreface)
  202. if err != nil {
  203. st.t.Fatalf("Error writing client preface: %v", err)
  204. }
  205. if n != len(clientPreface) {
  206. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  207. }
  208. }
  209. func (st *serverTester) writeInitialSettings() {
  210. if err := st.fr.WriteSettings(); err != nil {
  211. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  212. }
  213. }
  214. func (st *serverTester) writeSettingsAck() {
  215. if err := st.fr.WriteSettingsAck(); err != nil {
  216. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  217. }
  218. }
  219. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  220. if err := st.fr.WriteHeaders(p); err != nil {
  221. st.t.Fatalf("Error writing HEADERS: %v", err)
  222. }
  223. }
  224. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  225. if err := st.fr.WritePriority(id, p); err != nil {
  226. st.t.Fatalf("Error writing PRIORITY: %v", err)
  227. }
  228. }
  229. func (st *serverTester) encodeHeaderField(k, v string) {
  230. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  231. if err != nil {
  232. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  233. }
  234. }
  235. // encodeHeaderRaw is the magic-free version of encodeHeader.
  236. // It takes 0 or more (k, v) pairs and encodes them.
  237. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  238. if len(headers)%2 == 1 {
  239. panic("odd number of kv args")
  240. }
  241. st.headerBuf.Reset()
  242. for len(headers) > 0 {
  243. k, v := headers[0], headers[1]
  244. st.encodeHeaderField(k, v)
  245. headers = headers[2:]
  246. }
  247. return st.headerBuf.Bytes()
  248. }
  249. // encodeHeader encodes headers and returns their HPACK bytes. headers
  250. // must contain an even number of key/value pairs. There may be
  251. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  252. // :scheme headers default to GET, / and https. The :authority header
  253. // defaults to st.ts.Listener.Addr().
  254. func (st *serverTester) encodeHeader(headers ...string) []byte {
  255. if len(headers)%2 == 1 {
  256. panic("odd number of kv args")
  257. }
  258. st.headerBuf.Reset()
  259. defaultAuthority := st.ts.Listener.Addr().String()
  260. if len(headers) == 0 {
  261. // Fast path, mostly for benchmarks, so test code doesn't pollute
  262. // profiles when we're looking to improve server allocations.
  263. st.encodeHeaderField(":method", "GET")
  264. st.encodeHeaderField(":scheme", "https")
  265. st.encodeHeaderField(":authority", defaultAuthority)
  266. st.encodeHeaderField(":path", "/")
  267. return st.headerBuf.Bytes()
  268. }
  269. if len(headers) == 2 && headers[0] == ":method" {
  270. // Another fast path for benchmarks.
  271. st.encodeHeaderField(":method", headers[1])
  272. st.encodeHeaderField(":scheme", "https")
  273. st.encodeHeaderField(":authority", defaultAuthority)
  274. st.encodeHeaderField(":path", "/")
  275. return st.headerBuf.Bytes()
  276. }
  277. pseudoCount := map[string]int{}
  278. keys := []string{":method", ":scheme", ":authority", ":path"}
  279. vals := map[string][]string{
  280. ":method": {"GET"},
  281. ":scheme": {"https"},
  282. ":authority": {defaultAuthority},
  283. ":path": {"/"},
  284. }
  285. for len(headers) > 0 {
  286. k, v := headers[0], headers[1]
  287. headers = headers[2:]
  288. if _, ok := vals[k]; !ok {
  289. keys = append(keys, k)
  290. }
  291. if strings.HasPrefix(k, ":") {
  292. pseudoCount[k]++
  293. if pseudoCount[k] == 1 {
  294. vals[k] = []string{v}
  295. } else {
  296. // Allows testing of invalid headers w/ dup pseudo fields.
  297. vals[k] = append(vals[k], v)
  298. }
  299. } else {
  300. vals[k] = append(vals[k], v)
  301. }
  302. }
  303. for _, k := range keys {
  304. for _, v := range vals[k] {
  305. st.encodeHeaderField(k, v)
  306. }
  307. }
  308. return st.headerBuf.Bytes()
  309. }
  310. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  311. func (st *serverTester) bodylessReq1(headers ...string) {
  312. st.writeHeaders(HeadersFrameParam{
  313. StreamID: 1, // clients send odd numbers
  314. BlockFragment: st.encodeHeader(headers...),
  315. EndStream: true,
  316. EndHeaders: true,
  317. })
  318. }
  319. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  320. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  321. st.t.Fatalf("Error writing DATA: %v", err)
  322. }
  323. }
  324. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  325. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  326. st.t.Fatalf("Error writing DATA: %v", err)
  327. }
  328. }
  329. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  330. ch := make(chan interface{}, 1)
  331. go func() {
  332. fr, err := fr.ReadFrame()
  333. if err != nil {
  334. ch <- err
  335. } else {
  336. ch <- fr
  337. }
  338. }()
  339. t := time.NewTimer(wait)
  340. select {
  341. case v := <-ch:
  342. t.Stop()
  343. if fr, ok := v.(Frame); ok {
  344. return fr, nil
  345. }
  346. return nil, v.(error)
  347. case <-t.C:
  348. return nil, errors.New("timeout waiting for frame")
  349. }
  350. }
  351. func (st *serverTester) readFrame() (Frame, error) {
  352. return readFrameTimeout(st.fr, 2*time.Second)
  353. }
  354. func (st *serverTester) wantHeaders() *HeadersFrame {
  355. f, err := st.readFrame()
  356. if err != nil {
  357. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  358. }
  359. hf, ok := f.(*HeadersFrame)
  360. if !ok {
  361. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  362. }
  363. return hf
  364. }
  365. func (st *serverTester) wantContinuation() *ContinuationFrame {
  366. f, err := st.readFrame()
  367. if err != nil {
  368. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  369. }
  370. cf, ok := f.(*ContinuationFrame)
  371. if !ok {
  372. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  373. }
  374. return cf
  375. }
  376. func (st *serverTester) wantData() *DataFrame {
  377. f, err := st.readFrame()
  378. if err != nil {
  379. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  380. }
  381. df, ok := f.(*DataFrame)
  382. if !ok {
  383. st.t.Fatalf("got a %T; want *DataFrame", f)
  384. }
  385. return df
  386. }
  387. func (st *serverTester) wantSettings() *SettingsFrame {
  388. f, err := st.readFrame()
  389. if err != nil {
  390. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  391. }
  392. sf, ok := f.(*SettingsFrame)
  393. if !ok {
  394. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  395. }
  396. return sf
  397. }
  398. func (st *serverTester) wantPing() *PingFrame {
  399. f, err := st.readFrame()
  400. if err != nil {
  401. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  402. }
  403. pf, ok := f.(*PingFrame)
  404. if !ok {
  405. st.t.Fatalf("got a %T; want *PingFrame", f)
  406. }
  407. return pf
  408. }
  409. func (st *serverTester) wantGoAway() *GoAwayFrame {
  410. f, err := st.readFrame()
  411. if err != nil {
  412. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  413. }
  414. gf, ok := f.(*GoAwayFrame)
  415. if !ok {
  416. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  417. }
  418. return gf
  419. }
  420. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  421. f, err := st.readFrame()
  422. if err != nil {
  423. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  424. }
  425. rs, ok := f.(*RSTStreamFrame)
  426. if !ok {
  427. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  428. }
  429. if rs.FrameHeader.StreamID != streamID {
  430. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  431. }
  432. if rs.ErrCode != errCode {
  433. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  434. }
  435. }
  436. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  437. f, err := st.readFrame()
  438. if err != nil {
  439. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  440. }
  441. wu, ok := f.(*WindowUpdateFrame)
  442. if !ok {
  443. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  444. }
  445. if wu.FrameHeader.StreamID != streamID {
  446. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  447. }
  448. if wu.Increment != incr {
  449. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  450. }
  451. }
  452. func (st *serverTester) wantSettingsAck() {
  453. f, err := st.readFrame()
  454. if err != nil {
  455. st.t.Fatal(err)
  456. }
  457. sf, ok := f.(*SettingsFrame)
  458. if !ok {
  459. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  460. }
  461. if !sf.Header().Flags.Has(FlagSettingsAck) {
  462. st.t.Fatal("Settings Frame didn't have ACK set")
  463. }
  464. }
  465. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  466. f, err := st.readFrame()
  467. if err != nil {
  468. st.t.Fatal(err)
  469. }
  470. ppf, ok := f.(*PushPromiseFrame)
  471. if !ok {
  472. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  473. }
  474. return ppf
  475. }
  476. func TestServer(t *testing.T) {
  477. gotReq := make(chan bool, 1)
  478. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  479. w.Header().Set("Foo", "Bar")
  480. gotReq <- true
  481. })
  482. defer st.Close()
  483. covers("3.5", `
  484. The server connection preface consists of a potentially empty
  485. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  486. server sends in the HTTP/2 connection.
  487. `)
  488. st.writePreface()
  489. st.writeInitialSettings()
  490. st.wantSettings()
  491. st.writeSettingsAck()
  492. st.wantSettingsAck()
  493. st.writeHeaders(HeadersFrameParam{
  494. StreamID: 1, // clients send odd numbers
  495. BlockFragment: st.encodeHeader(),
  496. EndStream: true, // no DATA frames
  497. EndHeaders: true,
  498. })
  499. select {
  500. case <-gotReq:
  501. case <-time.After(2 * time.Second):
  502. t.Error("timeout waiting for request")
  503. }
  504. }
  505. func TestServer_Request_Get(t *testing.T) {
  506. testServerRequest(t, func(st *serverTester) {
  507. st.writeHeaders(HeadersFrameParam{
  508. StreamID: 1, // clients send odd numbers
  509. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  510. EndStream: true, // no DATA frames
  511. EndHeaders: true,
  512. })
  513. }, func(r *http.Request) {
  514. if r.Method != "GET" {
  515. t.Errorf("Method = %q; want GET", r.Method)
  516. }
  517. if r.URL.Path != "/" {
  518. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  519. }
  520. if r.ContentLength != 0 {
  521. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  522. }
  523. if r.Close {
  524. t.Error("Close = true; want false")
  525. }
  526. if !strings.Contains(r.RemoteAddr, ":") {
  527. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  528. }
  529. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  530. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  531. }
  532. wantHeader := http.Header{
  533. "Foo-Bar": []string{"some-value"},
  534. }
  535. if !reflect.DeepEqual(r.Header, wantHeader) {
  536. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  537. }
  538. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  539. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  540. }
  541. })
  542. }
  543. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  544. testServerRequest(t, func(st *serverTester) {
  545. st.writeHeaders(HeadersFrameParam{
  546. StreamID: 1, // clients send odd numbers
  547. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  548. EndStream: true, // no DATA frames
  549. EndHeaders: true,
  550. })
  551. }, func(r *http.Request) {
  552. if r.RequestURI != "/%2f/" {
  553. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  554. }
  555. if r.URL.Path != "///" {
  556. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  557. }
  558. })
  559. }
  560. // TODO: add a test with EndStream=true on the HEADERS but setting a
  561. // Content-Length anyway. Should we just omit it and force it to
  562. // zero?
  563. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  564. testServerRequest(t, func(st *serverTester) {
  565. st.writeHeaders(HeadersFrameParam{
  566. StreamID: 1, // clients send odd numbers
  567. BlockFragment: st.encodeHeader(":method", "POST"),
  568. EndStream: true,
  569. EndHeaders: true,
  570. })
  571. }, func(r *http.Request) {
  572. if r.Method != "POST" {
  573. t.Errorf("Method = %q; want POST", r.Method)
  574. }
  575. if r.ContentLength != 0 {
  576. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  577. }
  578. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  579. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  580. }
  581. })
  582. }
  583. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  584. testBodyContents(t, -1, "", func(st *serverTester) {
  585. st.writeHeaders(HeadersFrameParam{
  586. StreamID: 1, // clients send odd numbers
  587. BlockFragment: st.encodeHeader(":method", "POST"),
  588. EndStream: false, // to say DATA frames are coming
  589. EndHeaders: true,
  590. })
  591. st.writeData(1, true, nil) // just kidding. empty body.
  592. })
  593. }
  594. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  595. const content = "Some content"
  596. testBodyContents(t, -1, content, func(st *serverTester) {
  597. st.writeHeaders(HeadersFrameParam{
  598. StreamID: 1, // clients send odd numbers
  599. BlockFragment: st.encodeHeader(":method", "POST"),
  600. EndStream: false, // to say DATA frames are coming
  601. EndHeaders: true,
  602. })
  603. st.writeData(1, true, []byte(content))
  604. })
  605. }
  606. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  607. const content = "Some content"
  608. testBodyContents(t, -1, content, func(st *serverTester) {
  609. st.writeHeaders(HeadersFrameParam{
  610. StreamID: 1, // clients send odd numbers
  611. BlockFragment: st.encodeHeader(":method", "POST"),
  612. EndStream: false, // to say DATA frames are coming
  613. EndHeaders: true,
  614. })
  615. st.writeData(1, false, []byte(content[:5]))
  616. st.writeData(1, true, []byte(content[5:]))
  617. })
  618. }
  619. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  620. const content = "Some content"
  621. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  622. st.writeHeaders(HeadersFrameParam{
  623. StreamID: 1, // clients send odd numbers
  624. BlockFragment: st.encodeHeader(
  625. ":method", "POST",
  626. "content-length", strconv.Itoa(len(content)),
  627. ),
  628. EndStream: false, // to say DATA frames are coming
  629. EndHeaders: true,
  630. })
  631. st.writeData(1, true, []byte(content))
  632. })
  633. }
  634. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  635. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  636. func(st *serverTester) {
  637. st.writeHeaders(HeadersFrameParam{
  638. StreamID: 1, // clients send odd numbers
  639. BlockFragment: st.encodeHeader(
  640. ":method", "POST",
  641. "content-length", "3",
  642. ),
  643. EndStream: false, // to say DATA frames are coming
  644. EndHeaders: true,
  645. })
  646. st.writeData(1, true, []byte("12"))
  647. })
  648. }
  649. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  650. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  651. func(st *serverTester) {
  652. st.writeHeaders(HeadersFrameParam{
  653. StreamID: 1, // clients send odd numbers
  654. BlockFragment: st.encodeHeader(
  655. ":method", "POST",
  656. "content-length", "4",
  657. ),
  658. EndStream: false, // to say DATA frames are coming
  659. EndHeaders: true,
  660. })
  661. st.writeData(1, true, []byte("12345"))
  662. })
  663. }
  664. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  665. testServerRequest(t, write, func(r *http.Request) {
  666. if r.Method != "POST" {
  667. t.Errorf("Method = %q; want POST", r.Method)
  668. }
  669. if r.ContentLength != wantContentLength {
  670. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  671. }
  672. all, err := ioutil.ReadAll(r.Body)
  673. if err != nil {
  674. t.Fatal(err)
  675. }
  676. if string(all) != wantBody {
  677. t.Errorf("Read = %q; want %q", all, wantBody)
  678. }
  679. if err := r.Body.Close(); err != nil {
  680. t.Fatalf("Close: %v", err)
  681. }
  682. })
  683. }
  684. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  685. testServerRequest(t, write, func(r *http.Request) {
  686. if r.Method != "POST" {
  687. t.Errorf("Method = %q; want POST", r.Method)
  688. }
  689. if r.ContentLength != wantContentLength {
  690. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  691. }
  692. all, err := ioutil.ReadAll(r.Body)
  693. if err == nil {
  694. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  695. wantReadError, all)
  696. }
  697. if !strings.Contains(err.Error(), wantReadError) {
  698. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  699. }
  700. if err := r.Body.Close(); err != nil {
  701. t.Fatalf("Close: %v", err)
  702. }
  703. })
  704. }
  705. // Using a Host header, instead of :authority
  706. func TestServer_Request_Get_Host(t *testing.T) {
  707. const host = "example.com"
  708. testServerRequest(t, func(st *serverTester) {
  709. st.writeHeaders(HeadersFrameParam{
  710. StreamID: 1, // clients send odd numbers
  711. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  712. EndStream: true,
  713. EndHeaders: true,
  714. })
  715. }, func(r *http.Request) {
  716. if r.Host != host {
  717. t.Errorf("Host = %q; want %q", r.Host, host)
  718. }
  719. })
  720. }
  721. // Using an :authority pseudo-header, instead of Host
  722. func TestServer_Request_Get_Authority(t *testing.T) {
  723. const host = "example.com"
  724. testServerRequest(t, func(st *serverTester) {
  725. st.writeHeaders(HeadersFrameParam{
  726. StreamID: 1, // clients send odd numbers
  727. BlockFragment: st.encodeHeader(":authority", host),
  728. EndStream: true,
  729. EndHeaders: true,
  730. })
  731. }, func(r *http.Request) {
  732. if r.Host != host {
  733. t.Errorf("Host = %q; want %q", r.Host, host)
  734. }
  735. })
  736. }
  737. func TestServer_Request_WithContinuation(t *testing.T) {
  738. wantHeader := http.Header{
  739. "Foo-One": []string{"value-one"},
  740. "Foo-Two": []string{"value-two"},
  741. "Foo-Three": []string{"value-three"},
  742. }
  743. testServerRequest(t, func(st *serverTester) {
  744. fullHeaders := st.encodeHeader(
  745. "foo-one", "value-one",
  746. "foo-two", "value-two",
  747. "foo-three", "value-three",
  748. )
  749. remain := fullHeaders
  750. chunks := 0
  751. for len(remain) > 0 {
  752. const maxChunkSize = 5
  753. chunk := remain
  754. if len(chunk) > maxChunkSize {
  755. chunk = chunk[:maxChunkSize]
  756. }
  757. remain = remain[len(chunk):]
  758. if chunks == 0 {
  759. st.writeHeaders(HeadersFrameParam{
  760. StreamID: 1, // clients send odd numbers
  761. BlockFragment: chunk,
  762. EndStream: true, // no DATA frames
  763. EndHeaders: false, // we'll have continuation frames
  764. })
  765. } else {
  766. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  767. if err != nil {
  768. t.Fatal(err)
  769. }
  770. }
  771. chunks++
  772. }
  773. if chunks < 2 {
  774. t.Fatal("too few chunks")
  775. }
  776. }, func(r *http.Request) {
  777. if !reflect.DeepEqual(r.Header, wantHeader) {
  778. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  779. }
  780. })
  781. }
  782. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  783. func TestServer_Request_CookieConcat(t *testing.T) {
  784. const host = "example.com"
  785. testServerRequest(t, func(st *serverTester) {
  786. st.bodylessReq1(
  787. ":authority", host,
  788. "cookie", "a=b",
  789. "cookie", "c=d",
  790. "cookie", "e=f",
  791. )
  792. }, func(r *http.Request) {
  793. const want = "a=b; c=d; e=f"
  794. if got := r.Header.Get("Cookie"); got != want {
  795. t.Errorf("Cookie = %q; want %q", got, want)
  796. }
  797. })
  798. }
  799. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  800. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  801. }
  802. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  803. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  804. }
  805. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  806. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  807. }
  808. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  809. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  810. }
  811. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  812. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  813. }
  814. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  815. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  816. }
  817. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  818. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  819. }
  820. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  821. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  822. }
  823. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  824. // 8.1.2.3 Request Pseudo-Header Fields
  825. // "All HTTP/2 requests MUST include exactly one valid value" ...
  826. testRejectRequest(t, func(st *serverTester) {
  827. st.addLogFilter("duplicate pseudo-header")
  828. st.bodylessReq1(":method", "GET", ":method", "POST")
  829. })
  830. }
  831. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  832. // 8.1.2.3 Request Pseudo-Header Fields
  833. // "All pseudo-header fields MUST appear in the header block
  834. // before regular header fields. Any request or response that
  835. // contains a pseudo-header field that appears in a header
  836. // block after a regular header field MUST be treated as
  837. // malformed (Section 8.1.2.6)."
  838. testRejectRequest(t, func(st *serverTester) {
  839. st.addLogFilter("pseudo-header after regular header")
  840. var buf bytes.Buffer
  841. enc := hpack.NewEncoder(&buf)
  842. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  843. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  844. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  845. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  846. st.writeHeaders(HeadersFrameParam{
  847. StreamID: 1, // clients send odd numbers
  848. BlockFragment: buf.Bytes(),
  849. EndStream: true,
  850. EndHeaders: true,
  851. })
  852. })
  853. }
  854. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  855. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  856. }
  857. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  858. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  859. }
  860. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  861. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  862. }
  863. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  864. testRejectRequest(t, func(st *serverTester) {
  865. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  866. st.bodylessReq1(":unknown_thing", "")
  867. })
  868. }
  869. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  870. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  871. t.Error("server request made it to handler; should've been rejected")
  872. })
  873. defer st.Close()
  874. st.greet()
  875. send(st)
  876. st.wantRSTStream(1, ErrCodeProtocol)
  877. }
  878. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  879. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  880. t.Error("server request made it to handler; should've been rejected")
  881. }, optQuiet)
  882. defer st.Close()
  883. st.greet()
  884. send(st)
  885. gf := st.wantGoAway()
  886. if gf.ErrCode != ErrCodeProtocol {
  887. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  888. }
  889. }
  890. // Section 5.1, on idle connections: "Receiving any frame other than
  891. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  892. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  893. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  894. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  895. st.fr.WriteWindowUpdate(123, 456)
  896. })
  897. }
  898. func TestRejectFrameOnIdle_Data(t *testing.T) {
  899. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  900. st.fr.WriteData(123, true, nil)
  901. })
  902. }
  903. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  904. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  905. st.fr.WriteRSTStream(123, ErrCodeCancel)
  906. })
  907. }
  908. func TestServer_Request_Connect(t *testing.T) {
  909. testServerRequest(t, func(st *serverTester) {
  910. st.writeHeaders(HeadersFrameParam{
  911. StreamID: 1,
  912. BlockFragment: st.encodeHeaderRaw(
  913. ":method", "CONNECT",
  914. ":authority", "example.com:123",
  915. ),
  916. EndStream: true,
  917. EndHeaders: true,
  918. })
  919. }, func(r *http.Request) {
  920. if g, w := r.Method, "CONNECT"; g != w {
  921. t.Errorf("Method = %q; want %q", g, w)
  922. }
  923. if g, w := r.RequestURI, "example.com:123"; g != w {
  924. t.Errorf("RequestURI = %q; want %q", g, w)
  925. }
  926. if g, w := r.URL.Host, "example.com:123"; g != w {
  927. t.Errorf("URL.Host = %q; want %q", g, w)
  928. }
  929. })
  930. }
  931. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  932. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  933. st.writeHeaders(HeadersFrameParam{
  934. StreamID: 1,
  935. BlockFragment: st.encodeHeaderRaw(
  936. ":method", "CONNECT",
  937. ":authority", "example.com:123",
  938. ":path", "/bogus",
  939. ),
  940. EndStream: true,
  941. EndHeaders: true,
  942. })
  943. })
  944. }
  945. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  946. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  947. st.writeHeaders(HeadersFrameParam{
  948. StreamID: 1,
  949. BlockFragment: st.encodeHeaderRaw(
  950. ":method", "CONNECT",
  951. ":authority", "example.com:123",
  952. ":scheme", "https",
  953. ),
  954. EndStream: true,
  955. EndHeaders: true,
  956. })
  957. })
  958. }
  959. func TestServer_Ping(t *testing.T) {
  960. st := newServerTester(t, nil)
  961. defer st.Close()
  962. st.greet()
  963. // Server should ignore this one, since it has ACK set.
  964. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  965. if err := st.fr.WritePing(true, ackPingData); err != nil {
  966. t.Fatal(err)
  967. }
  968. // But the server should reply to this one, since ACK is false.
  969. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  970. if err := st.fr.WritePing(false, pingData); err != nil {
  971. t.Fatal(err)
  972. }
  973. pf := st.wantPing()
  974. if !pf.Flags.Has(FlagPingAck) {
  975. t.Error("response ping doesn't have ACK set")
  976. }
  977. if pf.Data != pingData {
  978. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  979. }
  980. }
  981. func TestServer_RejectsLargeFrames(t *testing.T) {
  982. if runtime.GOOS == "windows" {
  983. t.Skip("see golang.org/issue/13434")
  984. }
  985. st := newServerTester(t, nil)
  986. defer st.Close()
  987. st.greet()
  988. // Write too large of a frame (too large by one byte)
  989. // We ignore the return value because it's expected that the server
  990. // will only read the first 9 bytes (the headre) and then disconnect.
  991. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  992. gf := st.wantGoAway()
  993. if gf.ErrCode != ErrCodeFrameSize {
  994. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  995. }
  996. if st.logBuf.Len() != 0 {
  997. // Previously we spun here for a bit until the GOAWAY disconnect
  998. // timer fired, logging while we fired.
  999. t.Errorf("unexpected server output: %.500s\n", st.logBuf.Bytes())
  1000. }
  1001. }
  1002. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1003. puppet := newHandlerPuppet()
  1004. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1005. puppet.act(w, r)
  1006. })
  1007. defer st.Close()
  1008. defer puppet.done()
  1009. st.greet()
  1010. st.writeHeaders(HeadersFrameParam{
  1011. StreamID: 1, // clients send odd numbers
  1012. BlockFragment: st.encodeHeader(":method", "POST"),
  1013. EndStream: false, // data coming
  1014. EndHeaders: true,
  1015. })
  1016. st.writeData(1, false, []byte("abcdef"))
  1017. puppet.do(readBodyHandler(t, "abc"))
  1018. st.wantWindowUpdate(0, 3)
  1019. st.wantWindowUpdate(1, 3)
  1020. puppet.do(readBodyHandler(t, "def"))
  1021. st.wantWindowUpdate(0, 3)
  1022. st.wantWindowUpdate(1, 3)
  1023. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1024. puppet.do(readBodyHandler(t, "ghi"))
  1025. puppet.do(readBodyHandler(t, "jkl"))
  1026. st.wantWindowUpdate(0, 3)
  1027. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1028. }
  1029. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1030. // See golang.org/issue/16556
  1031. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1032. puppet := newHandlerPuppet()
  1033. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1034. puppet.act(w, r)
  1035. })
  1036. defer st.Close()
  1037. defer puppet.done()
  1038. st.greet()
  1039. st.writeHeaders(HeadersFrameParam{
  1040. StreamID: 1,
  1041. BlockFragment: st.encodeHeader(":method", "POST"),
  1042. EndStream: false,
  1043. EndHeaders: true,
  1044. })
  1045. st.writeDataPadded(1, false, []byte("abcdef"), []byte("1234"))
  1046. // Expect to immediately get our 5 bytes of padding back for
  1047. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1048. st.wantWindowUpdate(0, 5)
  1049. st.wantWindowUpdate(1, 5)
  1050. puppet.do(readBodyHandler(t, "abc"))
  1051. st.wantWindowUpdate(0, 3)
  1052. st.wantWindowUpdate(1, 3)
  1053. puppet.do(readBodyHandler(t, "def"))
  1054. st.wantWindowUpdate(0, 3)
  1055. st.wantWindowUpdate(1, 3)
  1056. }
  1057. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1058. st := newServerTester(t, nil)
  1059. defer st.Close()
  1060. st.greet()
  1061. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1062. t.Fatal(err)
  1063. }
  1064. gf := st.wantGoAway()
  1065. if gf.ErrCode != ErrCodeFlowControl {
  1066. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1067. }
  1068. if gf.LastStreamID != 0 {
  1069. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1070. }
  1071. }
  1072. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1073. inHandler := make(chan bool)
  1074. blockHandler := make(chan bool)
  1075. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1076. inHandler <- true
  1077. <-blockHandler
  1078. })
  1079. defer st.Close()
  1080. defer close(blockHandler)
  1081. st.greet()
  1082. st.writeHeaders(HeadersFrameParam{
  1083. StreamID: 1,
  1084. BlockFragment: st.encodeHeader(":method", "POST"),
  1085. EndStream: false, // keep it open
  1086. EndHeaders: true,
  1087. })
  1088. <-inHandler
  1089. // Send a bogus window update:
  1090. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1091. t.Fatal(err)
  1092. }
  1093. st.wantRSTStream(1, ErrCodeFlowControl)
  1094. }
  1095. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1096. // then runs fn once in the handler, and verifies that the error returned from
  1097. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1098. func testServerPostUnblock(t *testing.T,
  1099. handler func(http.ResponseWriter, *http.Request) error,
  1100. fn func(*serverTester),
  1101. checkErr func(error),
  1102. otherHeaders ...string) {
  1103. inHandler := make(chan bool)
  1104. errc := make(chan error, 1)
  1105. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1106. inHandler <- true
  1107. errc <- handler(w, r)
  1108. })
  1109. st.greet()
  1110. st.writeHeaders(HeadersFrameParam{
  1111. StreamID: 1,
  1112. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1113. EndStream: false, // keep it open
  1114. EndHeaders: true,
  1115. })
  1116. <-inHandler
  1117. fn(st)
  1118. select {
  1119. case err := <-errc:
  1120. if checkErr != nil {
  1121. checkErr(err)
  1122. }
  1123. case <-time.After(5 * time.Second):
  1124. t.Fatal("timeout waiting for Handler to return")
  1125. }
  1126. st.Close()
  1127. }
  1128. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1129. testServerPostUnblock(t,
  1130. func(w http.ResponseWriter, r *http.Request) (err error) {
  1131. _, err = r.Body.Read(make([]byte, 1))
  1132. return
  1133. },
  1134. func(st *serverTester) {
  1135. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1136. t.Fatal(err)
  1137. }
  1138. },
  1139. func(err error) {
  1140. want := StreamError{StreamID: 0x1, Code: 0x8}
  1141. if !reflect.DeepEqual(err, want) {
  1142. t.Errorf("Read error = %v; want %v", err, want)
  1143. }
  1144. },
  1145. )
  1146. }
  1147. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1148. // Run this test a bunch, because it doesn't always
  1149. // deadlock. But with a bunch, it did.
  1150. n := 50
  1151. if testing.Short() {
  1152. n = 5
  1153. }
  1154. for i := 0; i < n; i++ {
  1155. testServer_RSTStream_Unblocks_Header_Write(t)
  1156. }
  1157. }
  1158. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1159. inHandler := make(chan bool, 1)
  1160. unblockHandler := make(chan bool, 1)
  1161. headerWritten := make(chan bool, 1)
  1162. wroteRST := make(chan bool, 1)
  1163. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1164. inHandler <- true
  1165. <-wroteRST
  1166. w.Header().Set("foo", "bar")
  1167. w.WriteHeader(200)
  1168. w.(http.Flusher).Flush()
  1169. headerWritten <- true
  1170. <-unblockHandler
  1171. })
  1172. defer st.Close()
  1173. st.greet()
  1174. st.writeHeaders(HeadersFrameParam{
  1175. StreamID: 1,
  1176. BlockFragment: st.encodeHeader(":method", "POST"),
  1177. EndStream: false, // keep it open
  1178. EndHeaders: true,
  1179. })
  1180. <-inHandler
  1181. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1182. t.Fatal(err)
  1183. }
  1184. wroteRST <- true
  1185. st.awaitIdle()
  1186. select {
  1187. case <-headerWritten:
  1188. case <-time.After(2 * time.Second):
  1189. t.Error("timeout waiting for header write")
  1190. }
  1191. unblockHandler <- true
  1192. }
  1193. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1194. testServerPostUnblock(t,
  1195. func(w http.ResponseWriter, r *http.Request) (err error) {
  1196. _, err = r.Body.Read(make([]byte, 1))
  1197. return
  1198. },
  1199. func(st *serverTester) { st.cc.Close() },
  1200. func(err error) {
  1201. if err == nil {
  1202. t.Error("unexpected nil error from Request.Body.Read")
  1203. }
  1204. },
  1205. )
  1206. }
  1207. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1208. <-w.(http.CloseNotifier).CloseNotify()
  1209. return nil
  1210. }
  1211. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1212. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1213. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1214. t.Fatal(err)
  1215. }
  1216. }, nil)
  1217. }
  1218. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1219. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1220. }
  1221. // that CloseNotify unblocks after a stream error due to the client's
  1222. // problem that's unrelated to them explicitly canceling it (which is
  1223. // TestServer_CloseNotify_After_RSTStream above)
  1224. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1225. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1226. // data longer than declared Content-Length => stream error
  1227. st.writeData(1, true, []byte("1234"))
  1228. }, nil, "content-length", "3")
  1229. }
  1230. func TestServer_StateTransitions(t *testing.T) {
  1231. var st *serverTester
  1232. inHandler := make(chan bool)
  1233. writeData := make(chan bool)
  1234. leaveHandler := make(chan bool)
  1235. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1236. inHandler <- true
  1237. if st.stream(1) == nil {
  1238. t.Errorf("nil stream 1 in handler")
  1239. }
  1240. if got, want := st.streamState(1), stateOpen; got != want {
  1241. t.Errorf("in handler, state is %v; want %v", got, want)
  1242. }
  1243. writeData <- true
  1244. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1245. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1246. }
  1247. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1248. t.Errorf("in handler, state is %v; want %v", got, want)
  1249. }
  1250. <-leaveHandler
  1251. })
  1252. st.greet()
  1253. if st.stream(1) != nil {
  1254. t.Fatal("stream 1 should be empty")
  1255. }
  1256. if got := st.streamState(1); got != stateIdle {
  1257. t.Fatalf("stream 1 should be idle; got %v", got)
  1258. }
  1259. st.writeHeaders(HeadersFrameParam{
  1260. StreamID: 1,
  1261. BlockFragment: st.encodeHeader(":method", "POST"),
  1262. EndStream: false, // keep it open
  1263. EndHeaders: true,
  1264. })
  1265. <-inHandler
  1266. <-writeData
  1267. st.writeData(1, true, nil)
  1268. leaveHandler <- true
  1269. hf := st.wantHeaders()
  1270. if !hf.StreamEnded() {
  1271. t.Fatal("expected END_STREAM flag")
  1272. }
  1273. if got, want := st.streamState(1), stateClosed; got != want {
  1274. t.Errorf("at end, state is %v; want %v", got, want)
  1275. }
  1276. if st.stream(1) != nil {
  1277. t.Fatal("at end, stream 1 should be gone")
  1278. }
  1279. }
  1280. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1281. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1282. testServerRejectsConn(t, func(st *serverTester) {
  1283. st.writeHeaders(HeadersFrameParam{
  1284. StreamID: 1,
  1285. BlockFragment: st.encodeHeader(),
  1286. EndStream: true,
  1287. EndHeaders: false,
  1288. })
  1289. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1290. StreamID: 3, // different stream.
  1291. BlockFragment: st.encodeHeader(),
  1292. EndStream: true,
  1293. EndHeaders: true,
  1294. })
  1295. })
  1296. }
  1297. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1298. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1299. testServerRejectsConn(t, func(st *serverTester) {
  1300. st.writeHeaders(HeadersFrameParam{
  1301. StreamID: 1,
  1302. BlockFragment: st.encodeHeader(),
  1303. EndStream: true,
  1304. EndHeaders: false,
  1305. })
  1306. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1307. t.Fatal(err)
  1308. }
  1309. })
  1310. }
  1311. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1312. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1313. testServerRejectsConn(t, func(st *serverTester) {
  1314. st.writeHeaders(HeadersFrameParam{
  1315. StreamID: 1,
  1316. BlockFragment: st.encodeHeader(),
  1317. EndStream: true,
  1318. EndHeaders: true,
  1319. })
  1320. st.wantHeaders()
  1321. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1322. t.Fatal(err)
  1323. }
  1324. })
  1325. }
  1326. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1327. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1328. testServerRejectsConn(t, func(st *serverTester) {
  1329. st.writeHeaders(HeadersFrameParam{
  1330. StreamID: 1,
  1331. BlockFragment: st.encodeHeader(),
  1332. EndStream: true,
  1333. EndHeaders: false,
  1334. })
  1335. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1336. t.Fatal(err)
  1337. }
  1338. })
  1339. }
  1340. // No HEADERS on stream 0.
  1341. func TestServer_Rejects_Headers0(t *testing.T) {
  1342. testServerRejectsConn(t, func(st *serverTester) {
  1343. st.fr.AllowIllegalWrites = true
  1344. st.writeHeaders(HeadersFrameParam{
  1345. StreamID: 0,
  1346. BlockFragment: st.encodeHeader(),
  1347. EndStream: true,
  1348. EndHeaders: true,
  1349. })
  1350. })
  1351. }
  1352. // No CONTINUATION on stream 0.
  1353. func TestServer_Rejects_Continuation0(t *testing.T) {
  1354. testServerRejectsConn(t, func(st *serverTester) {
  1355. st.fr.AllowIllegalWrites = true
  1356. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1357. t.Fatal(err)
  1358. }
  1359. })
  1360. }
  1361. // No PRIORITY on stream 0.
  1362. func TestServer_Rejects_Priority0(t *testing.T) {
  1363. testServerRejectsConn(t, func(st *serverTester) {
  1364. st.fr.AllowIllegalWrites = true
  1365. st.writePriority(0, PriorityParam{StreamDep: 1})
  1366. })
  1367. }
  1368. // No HEADERS frame with a self-dependence.
  1369. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1370. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1371. st.fr.AllowIllegalWrites = true
  1372. st.writeHeaders(HeadersFrameParam{
  1373. StreamID: 1,
  1374. BlockFragment: st.encodeHeader(),
  1375. EndStream: true,
  1376. EndHeaders: true,
  1377. Priority: PriorityParam{StreamDep: 1},
  1378. })
  1379. })
  1380. }
  1381. // No PRIORTY frame with a self-dependence.
  1382. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1383. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1384. st.fr.AllowIllegalWrites = true
  1385. st.writePriority(1, PriorityParam{StreamDep: 1})
  1386. })
  1387. }
  1388. func TestServer_Rejects_PushPromise(t *testing.T) {
  1389. testServerRejectsConn(t, func(st *serverTester) {
  1390. pp := PushPromiseParam{
  1391. StreamID: 1,
  1392. PromiseID: 3,
  1393. }
  1394. if err := st.fr.WritePushPromise(pp); err != nil {
  1395. t.Fatal(err)
  1396. }
  1397. })
  1398. }
  1399. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1400. // frame and a server close after the client does something
  1401. // deserving a CONNECTION_ERROR.
  1402. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1403. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1404. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1405. defer st.Close()
  1406. st.greet()
  1407. writeReq(st)
  1408. st.wantGoAway()
  1409. errc := make(chan error, 1)
  1410. go func() {
  1411. fr, err := st.fr.ReadFrame()
  1412. if err == nil {
  1413. err = fmt.Errorf("got frame of type %T", fr)
  1414. }
  1415. errc <- err
  1416. }()
  1417. select {
  1418. case err := <-errc:
  1419. if err != io.EOF {
  1420. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1421. }
  1422. case <-time.After(2 * time.Second):
  1423. t.Error("timeout waiting for disconnect")
  1424. }
  1425. }
  1426. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1427. // error code after a client sends a bogus request.
  1428. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1429. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1430. defer st.Close()
  1431. st.greet()
  1432. writeReq(st)
  1433. st.wantRSTStream(1, code)
  1434. }
  1435. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1436. // write a single request with writeReq, and then verify that the
  1437. // *http.Request is built correctly in checkReq.
  1438. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1439. gotReq := make(chan bool, 1)
  1440. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1441. if r.Body == nil {
  1442. t.Fatal("nil Body")
  1443. }
  1444. checkReq(r)
  1445. gotReq <- true
  1446. })
  1447. defer st.Close()
  1448. st.greet()
  1449. writeReq(st)
  1450. select {
  1451. case <-gotReq:
  1452. case <-time.After(2 * time.Second):
  1453. t.Error("timeout waiting for request")
  1454. }
  1455. }
  1456. func getSlash(st *serverTester) { st.bodylessReq1() }
  1457. func TestServer_Response_NoData(t *testing.T) {
  1458. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1459. // Nothing.
  1460. return nil
  1461. }, func(st *serverTester) {
  1462. getSlash(st)
  1463. hf := st.wantHeaders()
  1464. if !hf.StreamEnded() {
  1465. t.Fatal("want END_STREAM flag")
  1466. }
  1467. if !hf.HeadersEnded() {
  1468. t.Fatal("want END_HEADERS flag")
  1469. }
  1470. })
  1471. }
  1472. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1473. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1474. w.Header().Set("Foo-Bar", "some-value")
  1475. return nil
  1476. }, func(st *serverTester) {
  1477. getSlash(st)
  1478. hf := st.wantHeaders()
  1479. if !hf.StreamEnded() {
  1480. t.Fatal("want END_STREAM flag")
  1481. }
  1482. if !hf.HeadersEnded() {
  1483. t.Fatal("want END_HEADERS flag")
  1484. }
  1485. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1486. wanth := [][2]string{
  1487. {":status", "200"},
  1488. {"foo-bar", "some-value"},
  1489. {"content-type", "text/plain; charset=utf-8"},
  1490. {"content-length", "0"},
  1491. }
  1492. if !reflect.DeepEqual(goth, wanth) {
  1493. t.Errorf("Got headers %v; want %v", goth, wanth)
  1494. }
  1495. })
  1496. }
  1497. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1498. const msg = "<html>this is HTML."
  1499. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1500. w.Header().Set("Content-Type", "foo/bar")
  1501. io.WriteString(w, msg)
  1502. return nil
  1503. }, func(st *serverTester) {
  1504. getSlash(st)
  1505. hf := st.wantHeaders()
  1506. if hf.StreamEnded() {
  1507. t.Fatal("don't want END_STREAM, expecting data")
  1508. }
  1509. if !hf.HeadersEnded() {
  1510. t.Fatal("want END_HEADERS flag")
  1511. }
  1512. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1513. wanth := [][2]string{
  1514. {":status", "200"},
  1515. {"content-type", "foo/bar"},
  1516. {"content-length", strconv.Itoa(len(msg))},
  1517. }
  1518. if !reflect.DeepEqual(goth, wanth) {
  1519. t.Errorf("Got headers %v; want %v", goth, wanth)
  1520. }
  1521. df := st.wantData()
  1522. if !df.StreamEnded() {
  1523. t.Error("expected DATA to have END_STREAM flag")
  1524. }
  1525. if got := string(df.Data()); got != msg {
  1526. t.Errorf("got DATA %q; want %q", got, msg)
  1527. }
  1528. })
  1529. }
  1530. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1531. const msg = "hi"
  1532. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1533. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1534. io.WriteString(w, msg)
  1535. return nil
  1536. }, func(st *serverTester) {
  1537. getSlash(st)
  1538. hf := st.wantHeaders()
  1539. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1540. wanth := [][2]string{
  1541. {":status", "200"},
  1542. {"content-type", "text/plain; charset=utf-8"},
  1543. {"content-length", strconv.Itoa(len(msg))},
  1544. }
  1545. if !reflect.DeepEqual(goth, wanth) {
  1546. t.Errorf("Got headers %v; want %v", goth, wanth)
  1547. }
  1548. })
  1549. }
  1550. // Header accessed only after the initial write.
  1551. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1552. const msg = "<html>this is HTML."
  1553. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1554. io.WriteString(w, msg)
  1555. w.Header().Set("foo", "should be ignored")
  1556. return nil
  1557. }, func(st *serverTester) {
  1558. getSlash(st)
  1559. hf := st.wantHeaders()
  1560. if hf.StreamEnded() {
  1561. t.Fatal("unexpected END_STREAM")
  1562. }
  1563. if !hf.HeadersEnded() {
  1564. t.Fatal("want END_HEADERS flag")
  1565. }
  1566. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1567. wanth := [][2]string{
  1568. {":status", "200"},
  1569. {"content-type", "text/html; charset=utf-8"},
  1570. {"content-length", strconv.Itoa(len(msg))},
  1571. }
  1572. if !reflect.DeepEqual(goth, wanth) {
  1573. t.Errorf("Got headers %v; want %v", goth, wanth)
  1574. }
  1575. })
  1576. }
  1577. // Header accessed before the initial write and later mutated.
  1578. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1579. const msg = "<html>this is HTML."
  1580. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1581. w.Header().Set("foo", "proper value")
  1582. io.WriteString(w, msg)
  1583. w.Header().Set("foo", "should be ignored")
  1584. return nil
  1585. }, func(st *serverTester) {
  1586. getSlash(st)
  1587. hf := st.wantHeaders()
  1588. if hf.StreamEnded() {
  1589. t.Fatal("unexpected END_STREAM")
  1590. }
  1591. if !hf.HeadersEnded() {
  1592. t.Fatal("want END_HEADERS flag")
  1593. }
  1594. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1595. wanth := [][2]string{
  1596. {":status", "200"},
  1597. {"foo", "proper value"},
  1598. {"content-type", "text/html; charset=utf-8"},
  1599. {"content-length", strconv.Itoa(len(msg))},
  1600. }
  1601. if !reflect.DeepEqual(goth, wanth) {
  1602. t.Errorf("Got headers %v; want %v", goth, wanth)
  1603. }
  1604. })
  1605. }
  1606. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1607. const msg = "<html>this is HTML."
  1608. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1609. io.WriteString(w, msg)
  1610. return nil
  1611. }, func(st *serverTester) {
  1612. getSlash(st)
  1613. hf := st.wantHeaders()
  1614. if hf.StreamEnded() {
  1615. t.Fatal("don't want END_STREAM, expecting data")
  1616. }
  1617. if !hf.HeadersEnded() {
  1618. t.Fatal("want END_HEADERS flag")
  1619. }
  1620. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1621. wanth := [][2]string{
  1622. {":status", "200"},
  1623. {"content-type", "text/html; charset=utf-8"},
  1624. {"content-length", strconv.Itoa(len(msg))},
  1625. }
  1626. if !reflect.DeepEqual(goth, wanth) {
  1627. t.Errorf("Got headers %v; want %v", goth, wanth)
  1628. }
  1629. df := st.wantData()
  1630. if !df.StreamEnded() {
  1631. t.Error("expected DATA to have END_STREAM flag")
  1632. }
  1633. if got := string(df.Data()); got != msg {
  1634. t.Errorf("got DATA %q; want %q", got, msg)
  1635. }
  1636. })
  1637. }
  1638. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1639. const msg = "<html>this is HTML"
  1640. const msg2 = ", and this is the next chunk"
  1641. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1642. io.WriteString(w, msg)
  1643. w.(http.Flusher).Flush()
  1644. io.WriteString(w, msg2)
  1645. return nil
  1646. }, func(st *serverTester) {
  1647. getSlash(st)
  1648. hf := st.wantHeaders()
  1649. if hf.StreamEnded() {
  1650. t.Fatal("unexpected END_STREAM flag")
  1651. }
  1652. if !hf.HeadersEnded() {
  1653. t.Fatal("want END_HEADERS flag")
  1654. }
  1655. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1656. wanth := [][2]string{
  1657. {":status", "200"},
  1658. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1659. // and no content-length
  1660. }
  1661. if !reflect.DeepEqual(goth, wanth) {
  1662. t.Errorf("Got headers %v; want %v", goth, wanth)
  1663. }
  1664. {
  1665. df := st.wantData()
  1666. if df.StreamEnded() {
  1667. t.Error("unexpected END_STREAM flag")
  1668. }
  1669. if got := string(df.Data()); got != msg {
  1670. t.Errorf("got DATA %q; want %q", got, msg)
  1671. }
  1672. }
  1673. {
  1674. df := st.wantData()
  1675. if !df.StreamEnded() {
  1676. t.Error("wanted END_STREAM flag on last data chunk")
  1677. }
  1678. if got := string(df.Data()); got != msg2 {
  1679. t.Errorf("got DATA %q; want %q", got, msg2)
  1680. }
  1681. }
  1682. })
  1683. }
  1684. func TestServer_Response_LargeWrite(t *testing.T) {
  1685. const size = 1 << 20
  1686. const maxFrameSize = 16 << 10
  1687. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1688. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1689. if err != nil {
  1690. return fmt.Errorf("Write error: %v", err)
  1691. }
  1692. if n != size {
  1693. return fmt.Errorf("wrong size %d from Write", n)
  1694. }
  1695. return nil
  1696. }, func(st *serverTester) {
  1697. if err := st.fr.WriteSettings(
  1698. Setting{SettingInitialWindowSize, 0},
  1699. Setting{SettingMaxFrameSize, maxFrameSize},
  1700. ); err != nil {
  1701. t.Fatal(err)
  1702. }
  1703. st.wantSettingsAck()
  1704. getSlash(st) // make the single request
  1705. // Give the handler quota to write:
  1706. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1707. t.Fatal(err)
  1708. }
  1709. // Give the handler quota to write to connection-level
  1710. // window as well
  1711. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1712. t.Fatal(err)
  1713. }
  1714. hf := st.wantHeaders()
  1715. if hf.StreamEnded() {
  1716. t.Fatal("unexpected END_STREAM flag")
  1717. }
  1718. if !hf.HeadersEnded() {
  1719. t.Fatal("want END_HEADERS flag")
  1720. }
  1721. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1722. wanth := [][2]string{
  1723. {":status", "200"},
  1724. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1725. // and no content-length
  1726. }
  1727. if !reflect.DeepEqual(goth, wanth) {
  1728. t.Errorf("Got headers %v; want %v", goth, wanth)
  1729. }
  1730. var bytes, frames int
  1731. for {
  1732. df := st.wantData()
  1733. bytes += len(df.Data())
  1734. frames++
  1735. for _, b := range df.Data() {
  1736. if b != 'a' {
  1737. t.Fatal("non-'a' byte seen in DATA")
  1738. }
  1739. }
  1740. if df.StreamEnded() {
  1741. break
  1742. }
  1743. }
  1744. if bytes != size {
  1745. t.Errorf("Got %d bytes; want %d", bytes, size)
  1746. }
  1747. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1748. t.Errorf("Got %d frames; want %d", frames, size)
  1749. }
  1750. })
  1751. }
  1752. // Test that the handler can't write more than the client allows
  1753. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1754. // Make these reads. Before each read, the client adds exactly enough
  1755. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1756. reads := []int{123, 1, 13, 127}
  1757. size := 0
  1758. for _, n := range reads {
  1759. size += n
  1760. }
  1761. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1762. w.(http.Flusher).Flush()
  1763. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1764. if err != nil {
  1765. return fmt.Errorf("Write error: %v", err)
  1766. }
  1767. if n != size {
  1768. return fmt.Errorf("wrong size %d from Write", n)
  1769. }
  1770. return nil
  1771. }, func(st *serverTester) {
  1772. // Set the window size to something explicit for this test.
  1773. // It's also how much initial data we expect.
  1774. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1775. t.Fatal(err)
  1776. }
  1777. st.wantSettingsAck()
  1778. getSlash(st) // make the single request
  1779. hf := st.wantHeaders()
  1780. if hf.StreamEnded() {
  1781. t.Fatal("unexpected END_STREAM flag")
  1782. }
  1783. if !hf.HeadersEnded() {
  1784. t.Fatal("want END_HEADERS flag")
  1785. }
  1786. df := st.wantData()
  1787. if got := len(df.Data()); got != reads[0] {
  1788. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1789. }
  1790. for _, quota := range reads[1:] {
  1791. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1792. t.Fatal(err)
  1793. }
  1794. df := st.wantData()
  1795. if int(quota) != len(df.Data()) {
  1796. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1797. }
  1798. }
  1799. })
  1800. }
  1801. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1802. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1803. const size = 1 << 20
  1804. const maxFrameSize = 16 << 10
  1805. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1806. w.(http.Flusher).Flush()
  1807. errc := make(chan error, 1)
  1808. go func() {
  1809. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1810. errc <- err
  1811. }()
  1812. select {
  1813. case err := <-errc:
  1814. if err == nil {
  1815. return errors.New("unexpected nil error from Write in handler")
  1816. }
  1817. return nil
  1818. case <-time.After(2 * time.Second):
  1819. return errors.New("timeout waiting for Write in handler")
  1820. }
  1821. }, func(st *serverTester) {
  1822. if err := st.fr.WriteSettings(
  1823. Setting{SettingInitialWindowSize, 0},
  1824. Setting{SettingMaxFrameSize, maxFrameSize},
  1825. ); err != nil {
  1826. t.Fatal(err)
  1827. }
  1828. st.wantSettingsAck()
  1829. getSlash(st) // make the single request
  1830. hf := st.wantHeaders()
  1831. if hf.StreamEnded() {
  1832. t.Fatal("unexpected END_STREAM flag")
  1833. }
  1834. if !hf.HeadersEnded() {
  1835. t.Fatal("want END_HEADERS flag")
  1836. }
  1837. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1838. t.Fatal(err)
  1839. }
  1840. })
  1841. }
  1842. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1843. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1844. w.(http.Flusher).Flush()
  1845. // Nothing; send empty DATA
  1846. return nil
  1847. }, func(st *serverTester) {
  1848. // Handler gets no data quota:
  1849. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1850. t.Fatal(err)
  1851. }
  1852. st.wantSettingsAck()
  1853. getSlash(st) // make the single request
  1854. hf := st.wantHeaders()
  1855. if hf.StreamEnded() {
  1856. t.Fatal("unexpected END_STREAM flag")
  1857. }
  1858. if !hf.HeadersEnded() {
  1859. t.Fatal("want END_HEADERS flag")
  1860. }
  1861. df := st.wantData()
  1862. if got := len(df.Data()); got != 0 {
  1863. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1864. }
  1865. if !df.StreamEnded() {
  1866. t.Fatal("DATA didn't have END_STREAM")
  1867. }
  1868. })
  1869. }
  1870. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1871. const msg = "foo"
  1872. const reply = "bar"
  1873. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1874. if v := r.Header.Get("Expect"); v != "" {
  1875. t.Errorf("Expect header = %q; want empty", v)
  1876. }
  1877. buf := make([]byte, len(msg))
  1878. // This read should trigger the 100-continue being sent.
  1879. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1880. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1881. }
  1882. _, err := io.WriteString(w, reply)
  1883. return err
  1884. }, func(st *serverTester) {
  1885. st.writeHeaders(HeadersFrameParam{
  1886. StreamID: 1, // clients send odd numbers
  1887. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1888. EndStream: false,
  1889. EndHeaders: true,
  1890. })
  1891. hf := st.wantHeaders()
  1892. if hf.StreamEnded() {
  1893. t.Fatal("unexpected END_STREAM flag")
  1894. }
  1895. if !hf.HeadersEnded() {
  1896. t.Fatal("want END_HEADERS flag")
  1897. }
  1898. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1899. wanth := [][2]string{
  1900. {":status", "100"},
  1901. }
  1902. if !reflect.DeepEqual(goth, wanth) {
  1903. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1904. }
  1905. // Okay, they sent status 100, so we can send our
  1906. // gigantic and/or sensitive "foo" payload now.
  1907. st.writeData(1, true, []byte(msg))
  1908. st.wantWindowUpdate(0, uint32(len(msg)))
  1909. hf = st.wantHeaders()
  1910. if hf.StreamEnded() {
  1911. t.Fatal("expected data to follow")
  1912. }
  1913. if !hf.HeadersEnded() {
  1914. t.Fatal("want END_HEADERS flag")
  1915. }
  1916. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1917. wanth = [][2]string{
  1918. {":status", "200"},
  1919. {"content-type", "text/plain; charset=utf-8"},
  1920. {"content-length", strconv.Itoa(len(reply))},
  1921. }
  1922. if !reflect.DeepEqual(goth, wanth) {
  1923. t.Errorf("Got headers %v; want %v", goth, wanth)
  1924. }
  1925. df := st.wantData()
  1926. if string(df.Data()) != reply {
  1927. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1928. }
  1929. if !df.StreamEnded() {
  1930. t.Errorf("expect data stream end")
  1931. }
  1932. })
  1933. }
  1934. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1935. errc := make(chan error, 1)
  1936. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1937. p := []byte("some data.\n")
  1938. for {
  1939. _, err := w.Write(p)
  1940. if err != nil {
  1941. errc <- err
  1942. return nil
  1943. }
  1944. }
  1945. }, func(st *serverTester) {
  1946. st.writeHeaders(HeadersFrameParam{
  1947. StreamID: 1,
  1948. BlockFragment: st.encodeHeader(),
  1949. EndStream: false,
  1950. EndHeaders: true,
  1951. })
  1952. hf := st.wantHeaders()
  1953. if hf.StreamEnded() {
  1954. t.Fatal("unexpected END_STREAM flag")
  1955. }
  1956. if !hf.HeadersEnded() {
  1957. t.Fatal("want END_HEADERS flag")
  1958. }
  1959. // Close the connection and wait for the handler to (hopefully) notice.
  1960. st.cc.Close()
  1961. select {
  1962. case <-errc:
  1963. case <-time.After(5 * time.Second):
  1964. t.Error("timeout")
  1965. }
  1966. })
  1967. }
  1968. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1969. const testPath = "/some/path"
  1970. inHandler := make(chan uint32)
  1971. leaveHandler := make(chan bool)
  1972. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1973. id := w.(*responseWriter).rws.stream.id
  1974. inHandler <- id
  1975. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1976. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1977. }
  1978. <-leaveHandler
  1979. })
  1980. defer st.Close()
  1981. st.greet()
  1982. nextStreamID := uint32(1)
  1983. streamID := func() uint32 {
  1984. defer func() { nextStreamID += 2 }()
  1985. return nextStreamID
  1986. }
  1987. sendReq := func(id uint32, headers ...string) {
  1988. st.writeHeaders(HeadersFrameParam{
  1989. StreamID: id,
  1990. BlockFragment: st.encodeHeader(headers...),
  1991. EndStream: true,
  1992. EndHeaders: true,
  1993. })
  1994. }
  1995. for i := 0; i < defaultMaxStreams; i++ {
  1996. sendReq(streamID())
  1997. <-inHandler
  1998. }
  1999. defer func() {
  2000. for i := 0; i < defaultMaxStreams; i++ {
  2001. leaveHandler <- true
  2002. }
  2003. }()
  2004. // And this one should cross the limit:
  2005. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2006. // even if we're rejecting it)
  2007. rejectID := streamID()
  2008. headerBlock := st.encodeHeader(":path", testPath)
  2009. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2010. st.writeHeaders(HeadersFrameParam{
  2011. StreamID: rejectID,
  2012. BlockFragment: frag1,
  2013. EndStream: true,
  2014. EndHeaders: false, // CONTINUATION coming
  2015. })
  2016. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2017. t.Fatal(err)
  2018. }
  2019. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2020. // But let a handler finish:
  2021. leaveHandler <- true
  2022. st.wantHeaders()
  2023. // And now another stream should be able to start:
  2024. goodID := streamID()
  2025. sendReq(goodID, ":path", testPath)
  2026. select {
  2027. case got := <-inHandler:
  2028. if got != goodID {
  2029. t.Errorf("Got stream %d; want %d", got, goodID)
  2030. }
  2031. case <-time.After(3 * time.Second):
  2032. t.Error("timeout waiting for handler")
  2033. }
  2034. }
  2035. // So many response headers that the server needs to use CONTINUATION frames:
  2036. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2037. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2038. h := w.Header()
  2039. for i := 0; i < 5000; i++ {
  2040. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2041. }
  2042. return nil
  2043. }, func(st *serverTester) {
  2044. getSlash(st)
  2045. hf := st.wantHeaders()
  2046. if hf.HeadersEnded() {
  2047. t.Fatal("got unwanted END_HEADERS flag")
  2048. }
  2049. n := 0
  2050. for {
  2051. n++
  2052. cf := st.wantContinuation()
  2053. if cf.HeadersEnded() {
  2054. break
  2055. }
  2056. }
  2057. if n < 5 {
  2058. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2059. }
  2060. })
  2061. }
  2062. // This previously crashed (reported by Mathieu Lonjaret as observed
  2063. // while using Camlistore) because we got a DATA frame from the client
  2064. // after the handler exited and our logic at the time was wrong,
  2065. // keeping a stream in the map in stateClosed, which tickled an
  2066. // invariant check later when we tried to remove that stream (via
  2067. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2068. // ended.
  2069. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2070. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2071. // nothing
  2072. return nil
  2073. }, func(st *serverTester) {
  2074. st.writeHeaders(HeadersFrameParam{
  2075. StreamID: 1,
  2076. BlockFragment: st.encodeHeader(),
  2077. EndStream: false, // DATA is coming
  2078. EndHeaders: true,
  2079. })
  2080. hf := st.wantHeaders()
  2081. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2082. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2083. }
  2084. // Sent when the a Handler closes while a client has
  2085. // indicated it's still sending DATA:
  2086. st.wantRSTStream(1, ErrCodeCancel)
  2087. // Now the handler has ended, so it's ended its
  2088. // stream, but the client hasn't closed its side
  2089. // (stateClosedLocal). So send more data and verify
  2090. // it doesn't crash with an internal invariant panic, like
  2091. // it did before.
  2092. st.writeData(1, true, []byte("foo"))
  2093. // Get our flow control bytes back, since the handler didn't get them.
  2094. st.wantWindowUpdate(0, uint32(len("foo")))
  2095. // Sent after a peer sends data anyway (admittedly the
  2096. // previous RST_STREAM might've still been in-flight),
  2097. // but they'll get the more friendly 'cancel' code
  2098. // first.
  2099. st.wantRSTStream(1, ErrCodeStreamClosed)
  2100. // Set up a bunch of machinery to record the panic we saw
  2101. // previously.
  2102. var (
  2103. panMu sync.Mutex
  2104. panicVal interface{}
  2105. )
  2106. testHookOnPanicMu.Lock()
  2107. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2108. panMu.Lock()
  2109. panicVal = pv
  2110. panMu.Unlock()
  2111. return true
  2112. }
  2113. testHookOnPanicMu.Unlock()
  2114. // Now force the serve loop to end, via closing the connection.
  2115. st.cc.Close()
  2116. select {
  2117. case <-st.sc.doneServing:
  2118. // Loop has exited.
  2119. panMu.Lock()
  2120. got := panicVal
  2121. panMu.Unlock()
  2122. if got != nil {
  2123. t.Errorf("Got panic: %v", got)
  2124. }
  2125. case <-time.After(5 * time.Second):
  2126. t.Error("timeout")
  2127. }
  2128. })
  2129. }
  2130. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2131. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2132. func testRejectTLS(t *testing.T, max uint16) {
  2133. st := newServerTester(t, nil, func(c *tls.Config) {
  2134. c.MaxVersion = max
  2135. })
  2136. defer st.Close()
  2137. gf := st.wantGoAway()
  2138. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2139. t.Errorf("Got error code %v; want %v", got, want)
  2140. }
  2141. }
  2142. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2143. st := newServerTester(t, nil, func(c *tls.Config) {
  2144. // Only list bad ones:
  2145. c.CipherSuites = []uint16{
  2146. tls.TLS_RSA_WITH_RC4_128_SHA,
  2147. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2148. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2149. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2150. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2151. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2152. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2153. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2154. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2155. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2156. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2157. }
  2158. })
  2159. defer st.Close()
  2160. gf := st.wantGoAway()
  2161. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2162. t.Errorf("Got error code %v; want %v", got, want)
  2163. }
  2164. }
  2165. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2166. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2167. st := newServerTester(t, nil, func(c *tls.Config) {
  2168. // Have the client only support the one required by the spec.
  2169. c.CipherSuites = []uint16{requiredSuite}
  2170. }, func(ts *httptest.Server) {
  2171. var srv *http.Server = ts.Config
  2172. // Have the server configured with no specific cipher suites.
  2173. // This tests that Go's defaults include the required one.
  2174. srv.TLSConfig = nil
  2175. })
  2176. defer st.Close()
  2177. st.greet()
  2178. }
  2179. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2180. if f.Name == "date" {
  2181. return
  2182. }
  2183. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2184. }
  2185. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2186. st.decodedHeaders = nil
  2187. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2188. st.t.Fatalf("hpack decoding error: %v", err)
  2189. }
  2190. if err := st.hpackDec.Close(); err != nil {
  2191. st.t.Fatalf("hpack decoding error: %v", err)
  2192. }
  2193. return st.decodedHeaders
  2194. }
  2195. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2196. // write a single request that must be handled by the handler. This waits up to 5s
  2197. // for client to return, then up to an additional 2s for the handler to return.
  2198. func testServerResponse(t testing.TB,
  2199. handler func(http.ResponseWriter, *http.Request) error,
  2200. client func(*serverTester),
  2201. ) {
  2202. errc := make(chan error, 1)
  2203. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2204. if r.Body == nil {
  2205. t.Fatal("nil Body")
  2206. }
  2207. errc <- handler(w, r)
  2208. })
  2209. defer st.Close()
  2210. donec := make(chan bool)
  2211. go func() {
  2212. defer close(donec)
  2213. st.greet()
  2214. client(st)
  2215. }()
  2216. select {
  2217. case <-donec:
  2218. case <-time.After(5 * time.Second):
  2219. t.Fatal("timeout in client")
  2220. }
  2221. select {
  2222. case err := <-errc:
  2223. if err != nil {
  2224. t.Fatalf("Error in handler: %v", err)
  2225. }
  2226. case <-time.After(2 * time.Second):
  2227. t.Fatal("timeout in handler")
  2228. }
  2229. }
  2230. // readBodyHandler returns an http Handler func that reads len(want)
  2231. // bytes from r.Body and fails t if the contents read were not
  2232. // the value of want.
  2233. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2234. return func(w http.ResponseWriter, r *http.Request) {
  2235. buf := make([]byte, len(want))
  2236. _, err := io.ReadFull(r.Body, buf)
  2237. if err != nil {
  2238. t.Error(err)
  2239. return
  2240. }
  2241. if string(buf) != want {
  2242. t.Errorf("read %q; want %q", buf, want)
  2243. }
  2244. }
  2245. }
  2246. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2247. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2248. // http://sourceforge.net/p/curl/bugs/1472/
  2249. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2250. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2251. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2252. if runtime.GOOS != "linux" {
  2253. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2254. }
  2255. if testing.Short() {
  2256. t.Skip("skipping curl test in short mode")
  2257. }
  2258. requireCurl(t)
  2259. var gotConn int32
  2260. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2261. const msg = "Hello from curl!\n"
  2262. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2263. w.Header().Set("Foo", "Bar")
  2264. w.Header().Set("Client-Proto", r.Proto)
  2265. io.WriteString(w, msg)
  2266. }))
  2267. ConfigureServer(ts.Config, &Server{
  2268. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2269. })
  2270. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2271. ts.StartTLS()
  2272. defer ts.Close()
  2273. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2274. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2275. defer kill(container)
  2276. resc := make(chan interface{}, 1)
  2277. go func() {
  2278. res, err := dockerLogs(container)
  2279. if err != nil {
  2280. resc <- err
  2281. } else {
  2282. resc <- res
  2283. }
  2284. }()
  2285. select {
  2286. case res := <-resc:
  2287. if err, ok := res.(error); ok {
  2288. t.Fatal(err)
  2289. }
  2290. body := string(res.([]byte))
  2291. // Search for both "key: value" and "key:value", since curl changed their format
  2292. // Our Dockerfile contains the latest version (no space), but just in case people
  2293. // didn't rebuild, check both.
  2294. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2295. t.Errorf("didn't see foo: Bar header")
  2296. t.Logf("Got: %s", body)
  2297. }
  2298. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2299. t.Errorf("didn't see client-proto: HTTP/2 header")
  2300. t.Logf("Got: %s", res)
  2301. }
  2302. if !strings.Contains(string(res.([]byte)), msg) {
  2303. t.Errorf("didn't see %q content", msg)
  2304. t.Logf("Got: %s", res)
  2305. }
  2306. case <-time.After(3 * time.Second):
  2307. t.Errorf("timeout waiting for curl")
  2308. }
  2309. if atomic.LoadInt32(&gotConn) == 0 {
  2310. t.Error("never saw an http2 connection")
  2311. }
  2312. }
  2313. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2314. func TestServerWithH2Load(t *testing.T) {
  2315. if !*doh2load {
  2316. t.Skip("Skipping without --h2load flag.")
  2317. }
  2318. if runtime.GOOS != "linux" {
  2319. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2320. }
  2321. requireH2load(t)
  2322. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2323. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2324. io.WriteString(w, msg)
  2325. w.(http.Flusher).Flush()
  2326. io.WriteString(w, msg)
  2327. }))
  2328. ts.StartTLS()
  2329. defer ts.Close()
  2330. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2331. "-n100000", "-c100", "-m100", ts.URL)
  2332. cmd.Stdout = os.Stdout
  2333. cmd.Stderr = os.Stderr
  2334. if err := cmd.Run(); err != nil {
  2335. t.Fatal(err)
  2336. }
  2337. }
  2338. // Issue 12843
  2339. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2340. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2341. defer st.Close()
  2342. // shake hands
  2343. st.writePreface()
  2344. st.writeInitialSettings()
  2345. frameSize := defaultMaxReadFrameSize
  2346. var advHeaderListSize *uint32
  2347. st.wantSettings().ForeachSetting(func(s Setting) error {
  2348. switch s.ID {
  2349. case SettingMaxFrameSize:
  2350. if s.Val < minMaxFrameSize {
  2351. frameSize = minMaxFrameSize
  2352. } else if s.Val > maxFrameSize {
  2353. frameSize = maxFrameSize
  2354. } else {
  2355. frameSize = int(s.Val)
  2356. }
  2357. case SettingMaxHeaderListSize:
  2358. advHeaderListSize = &s.Val
  2359. }
  2360. return nil
  2361. })
  2362. st.writeSettingsAck()
  2363. st.wantSettingsAck()
  2364. if advHeaderListSize == nil {
  2365. t.Errorf("server didn't advertise a max header list size")
  2366. } else if *advHeaderListSize == 0 {
  2367. t.Errorf("server advertised a max header list size of 0")
  2368. }
  2369. st.encodeHeaderField(":method", "GET")
  2370. st.encodeHeaderField(":path", "/")
  2371. st.encodeHeaderField(":scheme", "https")
  2372. cookie := strings.Repeat("*", 4058)
  2373. st.encodeHeaderField("cookie", cookie)
  2374. st.writeHeaders(HeadersFrameParam{
  2375. StreamID: 1,
  2376. BlockFragment: st.headerBuf.Bytes(),
  2377. EndStream: true,
  2378. EndHeaders: false,
  2379. })
  2380. // Capture the short encoding of a duplicate ~4K cookie, now
  2381. // that we've already sent it once.
  2382. st.headerBuf.Reset()
  2383. st.encodeHeaderField("cookie", cookie)
  2384. // Now send 1MB of it.
  2385. const size = 1 << 20
  2386. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2387. for len(b) > 0 {
  2388. chunk := b
  2389. if len(chunk) > frameSize {
  2390. chunk = chunk[:frameSize]
  2391. }
  2392. b = b[len(chunk):]
  2393. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2394. }
  2395. h := st.wantHeaders()
  2396. if !h.HeadersEnded() {
  2397. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2398. }
  2399. headers := st.decodeHeader(h.HeaderBlockFragment())
  2400. want := [][2]string{
  2401. {":status", "431"},
  2402. {"content-type", "text/html; charset=utf-8"},
  2403. {"content-length", "63"},
  2404. }
  2405. if !reflect.DeepEqual(headers, want) {
  2406. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2407. }
  2408. }
  2409. func TestCompressionErrorOnWrite(t *testing.T) {
  2410. const maxStrLen = 8 << 10
  2411. var serverConfig *http.Server
  2412. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2413. // No response body.
  2414. }, func(ts *httptest.Server) {
  2415. serverConfig = ts.Config
  2416. serverConfig.MaxHeaderBytes = maxStrLen
  2417. })
  2418. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2419. defer st.Close()
  2420. st.greet()
  2421. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2422. // Crank this up, now that we have a conn connected with the
  2423. // hpack.Decoder's max string length set has been initialized
  2424. // from the earlier low ~8K value. We want this higher so don't
  2425. // hit the max header list size. We only want to test hitting
  2426. // the max string size.
  2427. serverConfig.MaxHeaderBytes = 1 << 20
  2428. // First a request with a header that's exactly the max allowed size
  2429. // for the hpack compression. It's still too long for the header list
  2430. // size, so we'll get the 431 error, but that keeps the compression
  2431. // context still valid.
  2432. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2433. st.writeHeaders(HeadersFrameParam{
  2434. StreamID: 1,
  2435. BlockFragment: hbf,
  2436. EndStream: true,
  2437. EndHeaders: true,
  2438. })
  2439. h := st.wantHeaders()
  2440. if !h.HeadersEnded() {
  2441. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2442. }
  2443. headers := st.decodeHeader(h.HeaderBlockFragment())
  2444. want := [][2]string{
  2445. {":status", "431"},
  2446. {"content-type", "text/html; charset=utf-8"},
  2447. {"content-length", "63"},
  2448. }
  2449. if !reflect.DeepEqual(headers, want) {
  2450. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2451. }
  2452. df := st.wantData()
  2453. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2454. t.Errorf("Unexpected data body: %q", df.Data())
  2455. }
  2456. if !df.StreamEnded() {
  2457. t.Fatalf("expect data stream end")
  2458. }
  2459. // And now send one that's just one byte too big.
  2460. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2461. st.writeHeaders(HeadersFrameParam{
  2462. StreamID: 3,
  2463. BlockFragment: hbf,
  2464. EndStream: true,
  2465. EndHeaders: true,
  2466. })
  2467. ga := st.wantGoAway()
  2468. if ga.ErrCode != ErrCodeCompression {
  2469. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2470. }
  2471. }
  2472. func TestCompressionErrorOnClose(t *testing.T) {
  2473. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2474. // No response body.
  2475. })
  2476. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2477. defer st.Close()
  2478. st.greet()
  2479. hbf := st.encodeHeader("foo", "bar")
  2480. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2481. st.writeHeaders(HeadersFrameParam{
  2482. StreamID: 1,
  2483. BlockFragment: hbf,
  2484. EndStream: true,
  2485. EndHeaders: true,
  2486. })
  2487. ga := st.wantGoAway()
  2488. if ga.ErrCode != ErrCodeCompression {
  2489. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2490. }
  2491. }
  2492. // test that a server handler can read trailers from a client
  2493. func TestServerReadsTrailers(t *testing.T) {
  2494. const testBody = "some test body"
  2495. writeReq := func(st *serverTester) {
  2496. st.writeHeaders(HeadersFrameParam{
  2497. StreamID: 1, // clients send odd numbers
  2498. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2499. EndStream: false,
  2500. EndHeaders: true,
  2501. })
  2502. st.writeData(1, false, []byte(testBody))
  2503. st.writeHeaders(HeadersFrameParam{
  2504. StreamID: 1, // clients send odd numbers
  2505. BlockFragment: st.encodeHeaderRaw(
  2506. "foo", "foov",
  2507. "bar", "barv",
  2508. "baz", "bazv",
  2509. "surprise", "wasn't declared; shouldn't show up",
  2510. ),
  2511. EndStream: true,
  2512. EndHeaders: true,
  2513. })
  2514. }
  2515. checkReq := func(r *http.Request) {
  2516. wantTrailer := http.Header{
  2517. "Foo": nil,
  2518. "Bar": nil,
  2519. "Baz": nil,
  2520. }
  2521. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2522. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2523. }
  2524. slurp, err := ioutil.ReadAll(r.Body)
  2525. if string(slurp) != testBody {
  2526. t.Errorf("read body %q; want %q", slurp, testBody)
  2527. }
  2528. if err != nil {
  2529. t.Fatalf("Body slurp: %v", err)
  2530. }
  2531. wantTrailerAfter := http.Header{
  2532. "Foo": {"foov"},
  2533. "Bar": {"barv"},
  2534. "Baz": {"bazv"},
  2535. }
  2536. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2537. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2538. }
  2539. }
  2540. testServerRequest(t, writeReq, checkReq)
  2541. }
  2542. // test that a server handler can send trailers
  2543. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2544. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2545. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2546. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2547. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2548. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2549. w.Header().Add("Trailer", "Server-Trailer-C")
  2550. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2551. // Regular headers:
  2552. w.Header().Set("Foo", "Bar")
  2553. w.Header().Set("Content-Length", "5") // len("Hello")
  2554. io.WriteString(w, "Hello")
  2555. if withFlush {
  2556. w.(http.Flusher).Flush()
  2557. }
  2558. w.Header().Set("Server-Trailer-A", "valuea")
  2559. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2560. // After a flush, random keys like Server-Surprise shouldn't show up:
  2561. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2562. // But we do permit promoting keys to trailers after a
  2563. // flush if they start with the magic
  2564. // otherwise-invalid "Trailer:" prefix:
  2565. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2566. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2567. w.Header().Set("Trailer:Range", "invalid")
  2568. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2569. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2570. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2571. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2572. return nil
  2573. }, func(st *serverTester) {
  2574. getSlash(st)
  2575. hf := st.wantHeaders()
  2576. if hf.StreamEnded() {
  2577. t.Fatal("response HEADERS had END_STREAM")
  2578. }
  2579. if !hf.HeadersEnded() {
  2580. t.Fatal("response HEADERS didn't have END_HEADERS")
  2581. }
  2582. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2583. wanth := [][2]string{
  2584. {":status", "200"},
  2585. {"foo", "Bar"},
  2586. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2587. {"trailer", "Server-Trailer-C"},
  2588. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2589. {"content-type", "text/plain; charset=utf-8"},
  2590. {"content-length", "5"},
  2591. }
  2592. if !reflect.DeepEqual(goth, wanth) {
  2593. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2594. }
  2595. df := st.wantData()
  2596. if string(df.Data()) != "Hello" {
  2597. t.Fatalf("Client read %q; want Hello", df.Data())
  2598. }
  2599. if df.StreamEnded() {
  2600. t.Fatalf("data frame had STREAM_ENDED")
  2601. }
  2602. tf := st.wantHeaders() // for the trailers
  2603. if !tf.StreamEnded() {
  2604. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2605. }
  2606. if !tf.HeadersEnded() {
  2607. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2608. }
  2609. wanth = [][2]string{
  2610. {"post-header-trailer", "hi1"},
  2611. {"post-header-trailer2", "hi2"},
  2612. {"server-trailer-a", "valuea"},
  2613. {"server-trailer-c", "valuec"},
  2614. }
  2615. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2616. if !reflect.DeepEqual(goth, wanth) {
  2617. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2618. }
  2619. })
  2620. }
  2621. // validate transmitted header field names & values
  2622. // golang.org/issue/14048
  2623. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2624. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2625. w.Header().Add("OK1", "x")
  2626. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2627. w.Header().Add("Bad1\x00", "x") // null in key
  2628. w.Header().Add("Bad2", "x\x00y") // null in value
  2629. return nil
  2630. }, func(st *serverTester) {
  2631. getSlash(st)
  2632. hf := st.wantHeaders()
  2633. if !hf.StreamEnded() {
  2634. t.Error("response HEADERS lacked END_STREAM")
  2635. }
  2636. if !hf.HeadersEnded() {
  2637. t.Fatal("response HEADERS didn't have END_HEADERS")
  2638. }
  2639. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2640. wanth := [][2]string{
  2641. {":status", "200"},
  2642. {"ok1", "x"},
  2643. {"content-type", "text/plain; charset=utf-8"},
  2644. {"content-length", "0"},
  2645. }
  2646. if !reflect.DeepEqual(goth, wanth) {
  2647. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2648. }
  2649. })
  2650. }
  2651. func BenchmarkServerGets(b *testing.B) {
  2652. defer disableGoroutineTracking()()
  2653. b.ReportAllocs()
  2654. const msg = "Hello, world"
  2655. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2656. io.WriteString(w, msg)
  2657. })
  2658. defer st.Close()
  2659. st.greet()
  2660. // Give the server quota to reply. (plus it has the the 64KB)
  2661. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2662. b.Fatal(err)
  2663. }
  2664. for i := 0; i < b.N; i++ {
  2665. id := 1 + uint32(i)*2
  2666. st.writeHeaders(HeadersFrameParam{
  2667. StreamID: id,
  2668. BlockFragment: st.encodeHeader(),
  2669. EndStream: true,
  2670. EndHeaders: true,
  2671. })
  2672. st.wantHeaders()
  2673. df := st.wantData()
  2674. if !df.StreamEnded() {
  2675. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2676. }
  2677. }
  2678. }
  2679. func BenchmarkServerPosts(b *testing.B) {
  2680. defer disableGoroutineTracking()()
  2681. b.ReportAllocs()
  2682. const msg = "Hello, world"
  2683. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2684. // Consume the (empty) body from th peer before replying, otherwise
  2685. // the server will sometimes (depending on scheduling) send the peer a
  2686. // a RST_STREAM with the CANCEL error code.
  2687. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2688. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2689. }
  2690. io.WriteString(w, msg)
  2691. })
  2692. defer st.Close()
  2693. st.greet()
  2694. // Give the server quota to reply. (plus it has the the 64KB)
  2695. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2696. b.Fatal(err)
  2697. }
  2698. for i := 0; i < b.N; i++ {
  2699. id := 1 + uint32(i)*2
  2700. st.writeHeaders(HeadersFrameParam{
  2701. StreamID: id,
  2702. BlockFragment: st.encodeHeader(":method", "POST"),
  2703. EndStream: false,
  2704. EndHeaders: true,
  2705. })
  2706. st.writeData(id, true, nil)
  2707. st.wantHeaders()
  2708. df := st.wantData()
  2709. if !df.StreamEnded() {
  2710. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2711. }
  2712. }
  2713. }
  2714. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2715. // Verify we don't hang.
  2716. func TestIssue53(t *testing.T) {
  2717. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2718. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2719. s := &http.Server{
  2720. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2721. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2722. w.Write([]byte("hello"))
  2723. }),
  2724. }
  2725. s2 := &Server{
  2726. MaxReadFrameSize: 1 << 16,
  2727. PermitProhibitedCipherSuites: true,
  2728. }
  2729. c := &issue53Conn{[]byte(data), false, false}
  2730. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2731. if !c.closed {
  2732. t.Fatal("connection is not closed")
  2733. }
  2734. }
  2735. type issue53Conn struct {
  2736. data []byte
  2737. closed bool
  2738. written bool
  2739. }
  2740. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2741. if len(c.data) == 0 {
  2742. return 0, io.EOF
  2743. }
  2744. n = copy(b, c.data)
  2745. c.data = c.data[n:]
  2746. return
  2747. }
  2748. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2749. c.written = true
  2750. return len(b), nil
  2751. }
  2752. func (c *issue53Conn) Close() error {
  2753. c.closed = true
  2754. return nil
  2755. }
  2756. func (c *issue53Conn) LocalAddr() net.Addr {
  2757. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2758. }
  2759. func (c *issue53Conn) RemoteAddr() net.Addr {
  2760. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2761. }
  2762. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2763. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2764. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2765. // golang.org/issue/12895
  2766. func TestConfigureServer(t *testing.T) {
  2767. tests := []struct {
  2768. name string
  2769. tlsConfig *tls.Config
  2770. wantErr string
  2771. }{
  2772. {
  2773. name: "empty server",
  2774. },
  2775. {
  2776. name: "just the required cipher suite",
  2777. tlsConfig: &tls.Config{
  2778. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2779. },
  2780. },
  2781. {
  2782. name: "missing required cipher suite",
  2783. tlsConfig: &tls.Config{
  2784. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2785. },
  2786. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2787. },
  2788. {
  2789. name: "required after bad",
  2790. tlsConfig: &tls.Config{
  2791. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2792. },
  2793. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2794. },
  2795. {
  2796. name: "bad after required",
  2797. tlsConfig: &tls.Config{
  2798. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2799. },
  2800. },
  2801. }
  2802. for _, tt := range tests {
  2803. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2804. err := ConfigureServer(srv, nil)
  2805. if (err != nil) != (tt.wantErr != "") {
  2806. if tt.wantErr != "" {
  2807. t.Errorf("%s: success, but want error", tt.name)
  2808. } else {
  2809. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2810. }
  2811. }
  2812. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2813. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2814. }
  2815. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2816. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2817. }
  2818. }
  2819. }
  2820. func TestServerRejectHeadWithBody(t *testing.T) {
  2821. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2822. // No response body.
  2823. })
  2824. defer st.Close()
  2825. st.greet()
  2826. st.writeHeaders(HeadersFrameParam{
  2827. StreamID: 1, // clients send odd numbers
  2828. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2829. EndStream: false, // what we're testing, a bogus HEAD request with body
  2830. EndHeaders: true,
  2831. })
  2832. st.wantRSTStream(1, ErrCodeProtocol)
  2833. }
  2834. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2835. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2836. // No response body. (or smaller than one frame)
  2837. })
  2838. defer st.Close()
  2839. st.greet()
  2840. st.writeHeaders(HeadersFrameParam{
  2841. StreamID: 1, // clients send odd numbers
  2842. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2843. EndStream: true,
  2844. EndHeaders: true,
  2845. })
  2846. h := st.wantHeaders()
  2847. headers := st.decodeHeader(h.HeaderBlockFragment())
  2848. want := [][2]string{
  2849. {":status", "200"},
  2850. {"content-type", "text/plain; charset=utf-8"},
  2851. }
  2852. if !reflect.DeepEqual(headers, want) {
  2853. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2854. }
  2855. }
  2856. // golang.org/issue/13495
  2857. func TestServerNoDuplicateContentType(t *testing.T) {
  2858. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2859. w.Header()["Content-Type"] = []string{""}
  2860. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2861. })
  2862. defer st.Close()
  2863. st.greet()
  2864. st.writeHeaders(HeadersFrameParam{
  2865. StreamID: 1,
  2866. BlockFragment: st.encodeHeader(),
  2867. EndStream: true,
  2868. EndHeaders: true,
  2869. })
  2870. h := st.wantHeaders()
  2871. headers := st.decodeHeader(h.HeaderBlockFragment())
  2872. want := [][2]string{
  2873. {":status", "200"},
  2874. {"content-type", ""},
  2875. {"content-length", "41"},
  2876. }
  2877. if !reflect.DeepEqual(headers, want) {
  2878. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2879. }
  2880. }
  2881. func disableGoroutineTracking() (restore func()) {
  2882. old := DebugGoroutines
  2883. DebugGoroutines = false
  2884. return func() { DebugGoroutines = old }
  2885. }
  2886. func BenchmarkServer_GetRequest(b *testing.B) {
  2887. defer disableGoroutineTracking()()
  2888. b.ReportAllocs()
  2889. const msg = "Hello, world."
  2890. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2891. n, err := io.Copy(ioutil.Discard, r.Body)
  2892. if err != nil || n > 0 {
  2893. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2894. }
  2895. io.WriteString(w, msg)
  2896. })
  2897. defer st.Close()
  2898. st.greet()
  2899. // Give the server quota to reply. (plus it has the the 64KB)
  2900. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2901. b.Fatal(err)
  2902. }
  2903. hbf := st.encodeHeader(":method", "GET")
  2904. for i := 0; i < b.N; i++ {
  2905. streamID := uint32(1 + 2*i)
  2906. st.writeHeaders(HeadersFrameParam{
  2907. StreamID: streamID,
  2908. BlockFragment: hbf,
  2909. EndStream: true,
  2910. EndHeaders: true,
  2911. })
  2912. st.wantHeaders()
  2913. st.wantData()
  2914. }
  2915. }
  2916. func BenchmarkServer_PostRequest(b *testing.B) {
  2917. defer disableGoroutineTracking()()
  2918. b.ReportAllocs()
  2919. const msg = "Hello, world."
  2920. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2921. n, err := io.Copy(ioutil.Discard, r.Body)
  2922. if err != nil || n > 0 {
  2923. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  2924. }
  2925. io.WriteString(w, msg)
  2926. })
  2927. defer st.Close()
  2928. st.greet()
  2929. // Give the server quota to reply. (plus it has the the 64KB)
  2930. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2931. b.Fatal(err)
  2932. }
  2933. hbf := st.encodeHeader(":method", "POST")
  2934. for i := 0; i < b.N; i++ {
  2935. streamID := uint32(1 + 2*i)
  2936. st.writeHeaders(HeadersFrameParam{
  2937. StreamID: streamID,
  2938. BlockFragment: hbf,
  2939. EndStream: false,
  2940. EndHeaders: true,
  2941. })
  2942. st.writeData(streamID, true, nil)
  2943. st.wantHeaders()
  2944. st.wantData()
  2945. }
  2946. }
  2947. type connStateConn struct {
  2948. net.Conn
  2949. cs tls.ConnectionState
  2950. }
  2951. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  2952. // golang.org/issue/12737 -- handle any net.Conn, not just
  2953. // *tls.Conn.
  2954. func TestServerHandleCustomConn(t *testing.T) {
  2955. var s Server
  2956. c1, c2 := net.Pipe()
  2957. clientDone := make(chan struct{})
  2958. handlerDone := make(chan struct{})
  2959. var req *http.Request
  2960. go func() {
  2961. defer close(clientDone)
  2962. defer c2.Close()
  2963. fr := NewFramer(c2, c2)
  2964. io.WriteString(c2, ClientPreface)
  2965. fr.WriteSettings()
  2966. fr.WriteSettingsAck()
  2967. f, err := fr.ReadFrame()
  2968. if err != nil {
  2969. t.Error(err)
  2970. return
  2971. }
  2972. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  2973. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  2974. return
  2975. }
  2976. f, err = fr.ReadFrame()
  2977. if err != nil {
  2978. t.Error(err)
  2979. return
  2980. }
  2981. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  2982. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  2983. return
  2984. }
  2985. var henc hpackEncoder
  2986. fr.WriteHeaders(HeadersFrameParam{
  2987. StreamID: 1,
  2988. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  2989. EndStream: true,
  2990. EndHeaders: true,
  2991. })
  2992. go io.Copy(ioutil.Discard, c2)
  2993. <-handlerDone
  2994. }()
  2995. const testString = "my custom ConnectionState"
  2996. fakeConnState := tls.ConnectionState{
  2997. ServerName: testString,
  2998. Version: tls.VersionTLS12,
  2999. }
  3000. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3001. BaseConfig: &http.Server{
  3002. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3003. defer close(handlerDone)
  3004. req = r
  3005. }),
  3006. }})
  3007. select {
  3008. case <-clientDone:
  3009. case <-time.After(5 * time.Second):
  3010. t.Fatal("timeout waiting for handler")
  3011. }
  3012. if req.TLS == nil {
  3013. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3014. }
  3015. if req.TLS.ServerName != testString {
  3016. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3017. }
  3018. }
  3019. // golang.org/issue/14214
  3020. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3021. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3022. t.Error("should not get to Handler")
  3023. })
  3024. defer st.Close()
  3025. st.greet()
  3026. st.bodylessReq1("connection", "foo")
  3027. hf := st.wantHeaders()
  3028. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3029. wanth := [][2]string{
  3030. {":status", "400"},
  3031. {"content-type", "text/plain; charset=utf-8"},
  3032. {"x-content-type-options", "nosniff"},
  3033. {"content-length", "51"},
  3034. }
  3035. if !reflect.DeepEqual(goth, wanth) {
  3036. t.Errorf("Got headers %v; want %v", goth, wanth)
  3037. }
  3038. }
  3039. type hpackEncoder struct {
  3040. enc *hpack.Encoder
  3041. buf bytes.Buffer
  3042. }
  3043. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3044. if len(headers)%2 == 1 {
  3045. panic("odd number of kv args")
  3046. }
  3047. he.buf.Reset()
  3048. if he.enc == nil {
  3049. he.enc = hpack.NewEncoder(&he.buf)
  3050. }
  3051. for len(headers) > 0 {
  3052. k, v := headers[0], headers[1]
  3053. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3054. if err != nil {
  3055. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3056. }
  3057. headers = headers[2:]
  3058. }
  3059. return he.buf.Bytes()
  3060. }
  3061. func TestCheckValidHTTP2Request(t *testing.T) {
  3062. tests := []struct {
  3063. h http.Header
  3064. want error
  3065. }{
  3066. {
  3067. h: http.Header{"Te": {"trailers"}},
  3068. want: nil,
  3069. },
  3070. {
  3071. h: http.Header{"Te": {"trailers", "bogus"}},
  3072. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3073. },
  3074. {
  3075. h: http.Header{"Foo": {""}},
  3076. want: nil,
  3077. },
  3078. {
  3079. h: http.Header{"Connection": {""}},
  3080. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3081. },
  3082. {
  3083. h: http.Header{"Proxy-Connection": {""}},
  3084. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3085. },
  3086. {
  3087. h: http.Header{"Keep-Alive": {""}},
  3088. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3089. },
  3090. {
  3091. h: http.Header{"Upgrade": {""}},
  3092. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3093. },
  3094. }
  3095. for i, tt := range tests {
  3096. got := checkValidHTTP2RequestHeaders(tt.h)
  3097. if !reflect.DeepEqual(got, tt.want) {
  3098. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3099. }
  3100. }
  3101. }
  3102. // golang.org/issue/14030
  3103. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3104. const msg = "Hello"
  3105. const msg2 = "World"
  3106. doRead := make(chan bool, 1)
  3107. defer close(doRead) // fallback cleanup
  3108. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3109. io.WriteString(w, msg)
  3110. w.(http.Flusher).Flush()
  3111. // Do a read, which might force a 100-continue status to be sent.
  3112. <-doRead
  3113. r.Body.Read(make([]byte, 10))
  3114. io.WriteString(w, msg2)
  3115. }, optOnlyServer)
  3116. defer st.Close()
  3117. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3118. defer tr.CloseIdleConnections()
  3119. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3120. req.Header.Set("Expect", "100-continue")
  3121. res, err := tr.RoundTrip(req)
  3122. if err != nil {
  3123. t.Fatal(err)
  3124. }
  3125. defer res.Body.Close()
  3126. buf := make([]byte, len(msg))
  3127. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3128. t.Fatal(err)
  3129. }
  3130. if string(buf) != msg {
  3131. t.Fatalf("msg = %q; want %q", buf, msg)
  3132. }
  3133. doRead <- true
  3134. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3135. t.Fatal(err)
  3136. }
  3137. if string(buf) != msg2 {
  3138. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3139. }
  3140. }
  3141. type funcReader func([]byte) (n int, err error)
  3142. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3143. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3144. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3145. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3146. unblock := make(chan bool, 1)
  3147. defer close(unblock)
  3148. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3149. // Don't read the 16KB request body. Wait until the client's
  3150. // done sending it and then return. This should cause the Server
  3151. // to then return those 16KB of flow control to the client.
  3152. <-unblock
  3153. }, optOnlyServer)
  3154. defer st.Close()
  3155. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3156. defer tr.CloseIdleConnections()
  3157. // This previously hung on the 4th iteration.
  3158. for i := 0; i < 6; i++ {
  3159. body := io.MultiReader(
  3160. io.LimitReader(neverEnding('A'), 16<<10),
  3161. funcReader(func([]byte) (n int, err error) {
  3162. unblock <- true
  3163. return 0, io.EOF
  3164. }),
  3165. )
  3166. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3167. res, err := tr.RoundTrip(req)
  3168. if err != nil {
  3169. t.Fatal(err)
  3170. }
  3171. res.Body.Close()
  3172. }
  3173. }
  3174. func TestServerIdleTimeout(t *testing.T) {
  3175. if testing.Short() {
  3176. t.Skip("skipping in short mode")
  3177. }
  3178. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3179. }, func(h2s *Server) {
  3180. h2s.IdleTimeout = 500 * time.Millisecond
  3181. })
  3182. defer st.Close()
  3183. st.greet()
  3184. ga := st.wantGoAway()
  3185. if ga.ErrCode != ErrCodeNo {
  3186. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3187. }
  3188. }
  3189. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3190. if testing.Short() {
  3191. t.Skip("skipping in short mode")
  3192. }
  3193. const timeout = 250 * time.Millisecond
  3194. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3195. time.Sleep(timeout * 2)
  3196. }, func(h2s *Server) {
  3197. h2s.IdleTimeout = timeout
  3198. })
  3199. defer st.Close()
  3200. st.greet()
  3201. // Send a request which takes twice the timeout. Verifies the
  3202. // idle timeout doesn't fire while we're in a request:
  3203. st.bodylessReq1()
  3204. st.wantHeaders()
  3205. // But the idle timeout should be rearmed after the request
  3206. // is done:
  3207. ga := st.wantGoAway()
  3208. if ga.ErrCode != ErrCodeNo {
  3209. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3210. }
  3211. }
  3212. // grpc-go closes the Request.Body currently with a Read.
  3213. // Verify that it doesn't race.
  3214. // See https://github.com/grpc/grpc-go/pull/938
  3215. func TestRequestBodyReadCloseRace(t *testing.T) {
  3216. for i := 0; i < 100; i++ {
  3217. body := &requestBody{
  3218. pipe: &pipe{
  3219. b: new(bytes.Buffer),
  3220. },
  3221. }
  3222. body.pipe.CloseWithError(io.EOF)
  3223. done := make(chan bool, 1)
  3224. buf := make([]byte, 10)
  3225. go func() {
  3226. time.Sleep(1 * time.Millisecond)
  3227. body.Close()
  3228. done <- true
  3229. }()
  3230. body.Read(buf)
  3231. <-done
  3232. }
  3233. }
  3234. func TestServerGracefulShutdown(t *testing.T) {
  3235. shutdownCh := make(chan struct{})
  3236. defer func() { testh1ServerShutdownChan = nil }()
  3237. testh1ServerShutdownChan = func(*http.Server) <-chan struct{} { return shutdownCh }
  3238. var st *serverTester
  3239. handlerDone := make(chan struct{})
  3240. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3241. defer close(handlerDone)
  3242. close(shutdownCh)
  3243. ga := st.wantGoAway()
  3244. if ga.ErrCode != ErrCodeNo {
  3245. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3246. }
  3247. if ga.LastStreamID != 1 {
  3248. t.Errorf("GOAWAY LastStreamID = %v; want 1", ga.LastStreamID)
  3249. }
  3250. w.Header().Set("x-foo", "bar")
  3251. })
  3252. defer st.Close()
  3253. st.greet()
  3254. st.bodylessReq1()
  3255. <-handlerDone
  3256. hf := st.wantHeaders()
  3257. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3258. wanth := [][2]string{
  3259. {":status", "200"},
  3260. {"x-foo", "bar"},
  3261. {"content-type", "text/plain; charset=utf-8"},
  3262. {"content-length", "0"},
  3263. }
  3264. if !reflect.DeepEqual(goth, wanth) {
  3265. t.Errorf("Got headers %v; want %v", goth, wanth)
  3266. }
  3267. n, err := st.cc.Read([]byte{0})
  3268. if n != 0 || err == nil {
  3269. t.Errorf("Read = %v, %v; want 0, non-nil", n, err)
  3270. }
  3271. }