server_test.go 62 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. // See https://code.google.com/p/go/source/browse/CONTRIBUTORS
  5. // Licensed under the same terms as Go itself:
  6. // https://code.google.com/p/go/source/browse/LICENSE
  7. package http2
  8. import (
  9. "bytes"
  10. "crypto/tls"
  11. "errors"
  12. "flag"
  13. "fmt"
  14. "io"
  15. "io/ioutil"
  16. "log"
  17. "net"
  18. "net/http"
  19. "net/http/httptest"
  20. "os"
  21. "reflect"
  22. "runtime"
  23. "strconv"
  24. "strings"
  25. "sync"
  26. "sync/atomic"
  27. "testing"
  28. "time"
  29. "golang.org/x/net/http2/hpack"
  30. )
  31. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  32. type serverTester struct {
  33. cc net.Conn // client conn
  34. t testing.TB
  35. ts *httptest.Server
  36. fr *Framer
  37. logBuf *bytes.Buffer
  38. logFilter []string // substrings to filter out
  39. scMu sync.Mutex // guards sc
  40. sc *serverConn
  41. // writing headers:
  42. headerBuf bytes.Buffer
  43. hpackEnc *hpack.Encoder
  44. // reading frames:
  45. frc chan Frame
  46. frErrc chan error
  47. readTimer *time.Timer
  48. }
  49. func init() {
  50. testHookOnPanicMu = new(sync.Mutex)
  51. }
  52. func resetHooks() {
  53. testHookOnPanicMu.Lock()
  54. testHookOnPanic = nil
  55. testHookOnPanicMu.Unlock()
  56. }
  57. type serverTesterOpt string
  58. var optOnlyServer = serverTesterOpt("only_server")
  59. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  60. resetHooks()
  61. logBuf := new(bytes.Buffer)
  62. ts := httptest.NewUnstartedServer(handler)
  63. tlsConfig := &tls.Config{
  64. InsecureSkipVerify: true,
  65. // The h2-14 is temporary, until curl is updated. (as used by unit tests
  66. // in Docker)
  67. NextProtos: []string{NextProtoTLS, "h2-14"},
  68. }
  69. onlyServer := false
  70. for _, opt := range opts {
  71. switch v := opt.(type) {
  72. case func(*tls.Config):
  73. v(tlsConfig)
  74. case func(*httptest.Server):
  75. v(ts)
  76. case serverTesterOpt:
  77. onlyServer = (v == optOnlyServer)
  78. default:
  79. t.Fatalf("unknown newServerTester option type %T", v)
  80. }
  81. }
  82. ConfigureServer(ts.Config, &Server{})
  83. st := &serverTester{
  84. t: t,
  85. ts: ts,
  86. logBuf: logBuf,
  87. frc: make(chan Frame, 1),
  88. frErrc: make(chan error, 1),
  89. }
  90. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  91. var stderrv io.Writer = ioutil.Discard
  92. if *stderrVerbose {
  93. stderrv = os.Stderr
  94. }
  95. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  96. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv, twriter{t: t, st: st}, logBuf), "", log.LstdFlags)
  97. ts.StartTLS()
  98. if VerboseLogs {
  99. t.Logf("Running test server at: %s", ts.URL)
  100. }
  101. testHookGetServerConn = func(v *serverConn) {
  102. st.scMu.Lock()
  103. defer st.scMu.Unlock()
  104. st.sc = v
  105. st.sc.testHookCh = make(chan func())
  106. }
  107. log.SetOutput(io.MultiWriter(stderrv, twriter{t: t, st: st}))
  108. if !onlyServer {
  109. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  110. if err != nil {
  111. t.Fatal(err)
  112. }
  113. st.cc = cc
  114. st.fr = NewFramer(cc, cc)
  115. }
  116. return st
  117. }
  118. func (st *serverTester) closeConn() {
  119. st.scMu.Lock()
  120. defer st.scMu.Unlock()
  121. st.sc.conn.Close()
  122. }
  123. func (st *serverTester) addLogFilter(phrase string) {
  124. st.logFilter = append(st.logFilter, phrase)
  125. }
  126. func (st *serverTester) stream(id uint32) *stream {
  127. ch := make(chan *stream, 1)
  128. st.sc.testHookCh <- func() {
  129. ch <- st.sc.streams[id]
  130. }
  131. return <-ch
  132. }
  133. func (st *serverTester) streamState(id uint32) streamState {
  134. ch := make(chan streamState, 1)
  135. st.sc.testHookCh <- func() {
  136. state, _ := st.sc.state(id)
  137. ch <- state
  138. }
  139. return <-ch
  140. }
  141. func (st *serverTester) Close() {
  142. st.ts.Close()
  143. if st.cc != nil {
  144. st.cc.Close()
  145. }
  146. log.SetOutput(os.Stderr)
  147. }
  148. // greet initiates the client's HTTP/2 connection into a state where
  149. // frames may be sent.
  150. func (st *serverTester) greet() {
  151. st.writePreface()
  152. st.writeInitialSettings()
  153. st.wantSettings()
  154. st.writeSettingsAck()
  155. st.wantSettingsAck()
  156. }
  157. func (st *serverTester) writePreface() {
  158. n, err := st.cc.Write(clientPreface)
  159. if err != nil {
  160. st.t.Fatalf("Error writing client preface: %v", err)
  161. }
  162. if n != len(clientPreface) {
  163. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  164. }
  165. }
  166. func (st *serverTester) writeInitialSettings() {
  167. if err := st.fr.WriteSettings(); err != nil {
  168. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  169. }
  170. }
  171. func (st *serverTester) writeSettingsAck() {
  172. if err := st.fr.WriteSettingsAck(); err != nil {
  173. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  174. }
  175. }
  176. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  177. if err := st.fr.WriteHeaders(p); err != nil {
  178. st.t.Fatalf("Error writing HEADERS: %v", err)
  179. }
  180. }
  181. func (st *serverTester) encodeHeaderField(k, v string) {
  182. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  183. if err != nil {
  184. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  185. }
  186. }
  187. // encodeHeader encodes headers and returns their HPACK bytes. headers
  188. // must contain an even number of key/value pairs. There may be
  189. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  190. // :scheme headers default to GET, / and https.
  191. func (st *serverTester) encodeHeader(headers ...string) []byte {
  192. if len(headers)%2 == 1 {
  193. panic("odd number of kv args")
  194. }
  195. st.headerBuf.Reset()
  196. if len(headers) == 0 {
  197. // Fast path, mostly for benchmarks, so test code doesn't pollute
  198. // profiles when we're looking to improve server allocations.
  199. st.encodeHeaderField(":method", "GET")
  200. st.encodeHeaderField(":path", "/")
  201. st.encodeHeaderField(":scheme", "https")
  202. return st.headerBuf.Bytes()
  203. }
  204. if len(headers) == 2 && headers[0] == ":method" {
  205. // Another fast path for benchmarks.
  206. st.encodeHeaderField(":method", headers[1])
  207. st.encodeHeaderField(":path", "/")
  208. st.encodeHeaderField(":scheme", "https")
  209. return st.headerBuf.Bytes()
  210. }
  211. pseudoCount := map[string]int{}
  212. keys := []string{":method", ":path", ":scheme"}
  213. vals := map[string][]string{
  214. ":method": {"GET"},
  215. ":path": {"/"},
  216. ":scheme": {"https"},
  217. }
  218. for len(headers) > 0 {
  219. k, v := headers[0], headers[1]
  220. headers = headers[2:]
  221. if _, ok := vals[k]; !ok {
  222. keys = append(keys, k)
  223. }
  224. if strings.HasPrefix(k, ":") {
  225. pseudoCount[k]++
  226. if pseudoCount[k] == 1 {
  227. vals[k] = []string{v}
  228. } else {
  229. // Allows testing of invalid headers w/ dup pseudo fields.
  230. vals[k] = append(vals[k], v)
  231. }
  232. } else {
  233. vals[k] = append(vals[k], v)
  234. }
  235. }
  236. st.headerBuf.Reset()
  237. for _, k := range keys {
  238. for _, v := range vals[k] {
  239. st.encodeHeaderField(k, v)
  240. }
  241. }
  242. return st.headerBuf.Bytes()
  243. }
  244. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  245. func (st *serverTester) bodylessReq1(headers ...string) {
  246. st.writeHeaders(HeadersFrameParam{
  247. StreamID: 1, // clients send odd numbers
  248. BlockFragment: st.encodeHeader(headers...),
  249. EndStream: true,
  250. EndHeaders: true,
  251. })
  252. }
  253. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  254. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  255. st.t.Fatalf("Error writing DATA: %v", err)
  256. }
  257. }
  258. func (st *serverTester) readFrame() (Frame, error) {
  259. go func() {
  260. fr, err := st.fr.ReadFrame()
  261. if err != nil {
  262. st.frErrc <- err
  263. } else {
  264. st.frc <- fr
  265. }
  266. }()
  267. t := st.readTimer
  268. if t == nil {
  269. t = time.NewTimer(2 * time.Second)
  270. st.readTimer = t
  271. }
  272. t.Reset(2 * time.Second)
  273. defer t.Stop()
  274. select {
  275. case f := <-st.frc:
  276. return f, nil
  277. case err := <-st.frErrc:
  278. return nil, err
  279. case <-t.C:
  280. return nil, errors.New("timeout waiting for frame")
  281. }
  282. }
  283. func (st *serverTester) wantHeaders() *HeadersFrame {
  284. f, err := st.readFrame()
  285. if err != nil {
  286. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  287. }
  288. hf, ok := f.(*HeadersFrame)
  289. if !ok {
  290. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  291. }
  292. return hf
  293. }
  294. func (st *serverTester) wantContinuation() *ContinuationFrame {
  295. f, err := st.readFrame()
  296. if err != nil {
  297. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  298. }
  299. cf, ok := f.(*ContinuationFrame)
  300. if !ok {
  301. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  302. }
  303. return cf
  304. }
  305. func (st *serverTester) wantData() *DataFrame {
  306. f, err := st.readFrame()
  307. if err != nil {
  308. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  309. }
  310. df, ok := f.(*DataFrame)
  311. if !ok {
  312. st.t.Fatalf("got a %T; want *DataFrame", f)
  313. }
  314. return df
  315. }
  316. func (st *serverTester) wantSettings() *SettingsFrame {
  317. f, err := st.readFrame()
  318. if err != nil {
  319. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  320. }
  321. sf, ok := f.(*SettingsFrame)
  322. if !ok {
  323. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  324. }
  325. return sf
  326. }
  327. func (st *serverTester) wantPing() *PingFrame {
  328. f, err := st.readFrame()
  329. if err != nil {
  330. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  331. }
  332. pf, ok := f.(*PingFrame)
  333. if !ok {
  334. st.t.Fatalf("got a %T; want *PingFrame", f)
  335. }
  336. return pf
  337. }
  338. func (st *serverTester) wantGoAway() *GoAwayFrame {
  339. f, err := st.readFrame()
  340. if err != nil {
  341. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  342. }
  343. gf, ok := f.(*GoAwayFrame)
  344. if !ok {
  345. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  346. }
  347. return gf
  348. }
  349. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  350. f, err := st.readFrame()
  351. if err != nil {
  352. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  353. }
  354. rs, ok := f.(*RSTStreamFrame)
  355. if !ok {
  356. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  357. }
  358. if rs.FrameHeader.StreamID != streamID {
  359. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  360. }
  361. if rs.ErrCode != errCode {
  362. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  363. }
  364. }
  365. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  366. f, err := st.readFrame()
  367. if err != nil {
  368. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  369. }
  370. wu, ok := f.(*WindowUpdateFrame)
  371. if !ok {
  372. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  373. }
  374. if wu.FrameHeader.StreamID != streamID {
  375. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  376. }
  377. if wu.Increment != incr {
  378. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  379. }
  380. }
  381. func (st *serverTester) wantSettingsAck() {
  382. f, err := st.readFrame()
  383. if err != nil {
  384. st.t.Fatal(err)
  385. }
  386. sf, ok := f.(*SettingsFrame)
  387. if !ok {
  388. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  389. }
  390. if !sf.Header().Flags.Has(FlagSettingsAck) {
  391. st.t.Fatal("Settings Frame didn't have ACK set")
  392. }
  393. }
  394. func TestServer(t *testing.T) {
  395. gotReq := make(chan bool, 1)
  396. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  397. w.Header().Set("Foo", "Bar")
  398. gotReq <- true
  399. })
  400. defer st.Close()
  401. covers("3.5", `
  402. The server connection preface consists of a potentially empty
  403. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  404. server sends in the HTTP/2 connection.
  405. `)
  406. st.writePreface()
  407. st.writeInitialSettings()
  408. st.wantSettings()
  409. st.writeSettingsAck()
  410. st.wantSettingsAck()
  411. st.writeHeaders(HeadersFrameParam{
  412. StreamID: 1, // clients send odd numbers
  413. BlockFragment: st.encodeHeader(),
  414. EndStream: true, // no DATA frames
  415. EndHeaders: true,
  416. })
  417. select {
  418. case <-gotReq:
  419. case <-time.After(2 * time.Second):
  420. t.Error("timeout waiting for request")
  421. }
  422. }
  423. func TestServer_Request_Get(t *testing.T) {
  424. testServerRequest(t, func(st *serverTester) {
  425. st.writeHeaders(HeadersFrameParam{
  426. StreamID: 1, // clients send odd numbers
  427. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  428. EndStream: true, // no DATA frames
  429. EndHeaders: true,
  430. })
  431. }, func(r *http.Request) {
  432. if r.Method != "GET" {
  433. t.Errorf("Method = %q; want GET", r.Method)
  434. }
  435. if r.URL.Path != "/" {
  436. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  437. }
  438. if r.ContentLength != 0 {
  439. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  440. }
  441. if r.Close {
  442. t.Error("Close = true; want false")
  443. }
  444. if !strings.Contains(r.RemoteAddr, ":") {
  445. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  446. }
  447. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  448. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  449. }
  450. wantHeader := http.Header{
  451. "Foo-Bar": []string{"some-value"},
  452. }
  453. if !reflect.DeepEqual(r.Header, wantHeader) {
  454. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  455. }
  456. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  457. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  458. }
  459. })
  460. }
  461. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  462. testServerRequest(t, func(st *serverTester) {
  463. st.writeHeaders(HeadersFrameParam{
  464. StreamID: 1, // clients send odd numbers
  465. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  466. EndStream: true, // no DATA frames
  467. EndHeaders: true,
  468. })
  469. }, func(r *http.Request) {
  470. if r.RequestURI != "/%2f/" {
  471. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  472. }
  473. if r.URL.Path != "///" {
  474. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  475. }
  476. })
  477. }
  478. // TODO: add a test with EndStream=true on the HEADERS but setting a
  479. // Content-Length anyway. Should we just omit it and force it to
  480. // zero?
  481. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  482. testServerRequest(t, func(st *serverTester) {
  483. st.writeHeaders(HeadersFrameParam{
  484. StreamID: 1, // clients send odd numbers
  485. BlockFragment: st.encodeHeader(":method", "POST"),
  486. EndStream: true,
  487. EndHeaders: true,
  488. })
  489. }, func(r *http.Request) {
  490. if r.Method != "POST" {
  491. t.Errorf("Method = %q; want POST", r.Method)
  492. }
  493. if r.ContentLength != 0 {
  494. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  495. }
  496. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  497. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  498. }
  499. })
  500. }
  501. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  502. testBodyContents(t, -1, "", func(st *serverTester) {
  503. st.writeHeaders(HeadersFrameParam{
  504. StreamID: 1, // clients send odd numbers
  505. BlockFragment: st.encodeHeader(":method", "POST"),
  506. EndStream: false, // to say DATA frames are coming
  507. EndHeaders: true,
  508. })
  509. st.writeData(1, true, nil) // just kidding. empty body.
  510. })
  511. }
  512. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  513. const content = "Some content"
  514. testBodyContents(t, -1, content, func(st *serverTester) {
  515. st.writeHeaders(HeadersFrameParam{
  516. StreamID: 1, // clients send odd numbers
  517. BlockFragment: st.encodeHeader(":method", "POST"),
  518. EndStream: false, // to say DATA frames are coming
  519. EndHeaders: true,
  520. })
  521. st.writeData(1, true, []byte(content))
  522. })
  523. }
  524. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  525. const content = "Some content"
  526. testBodyContents(t, -1, content, func(st *serverTester) {
  527. st.writeHeaders(HeadersFrameParam{
  528. StreamID: 1, // clients send odd numbers
  529. BlockFragment: st.encodeHeader(":method", "POST"),
  530. EndStream: false, // to say DATA frames are coming
  531. EndHeaders: true,
  532. })
  533. st.writeData(1, false, []byte(content[:5]))
  534. st.writeData(1, true, []byte(content[5:]))
  535. })
  536. }
  537. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  538. const content = "Some content"
  539. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  540. st.writeHeaders(HeadersFrameParam{
  541. StreamID: 1, // clients send odd numbers
  542. BlockFragment: st.encodeHeader(
  543. ":method", "POST",
  544. "content-length", strconv.Itoa(len(content)),
  545. ),
  546. EndStream: false, // to say DATA frames are coming
  547. EndHeaders: true,
  548. })
  549. st.writeData(1, true, []byte(content))
  550. })
  551. }
  552. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  553. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  554. func(st *serverTester) {
  555. st.writeHeaders(HeadersFrameParam{
  556. StreamID: 1, // clients send odd numbers
  557. BlockFragment: st.encodeHeader(
  558. ":method", "POST",
  559. "content-length", "3",
  560. ),
  561. EndStream: false, // to say DATA frames are coming
  562. EndHeaders: true,
  563. })
  564. st.writeData(1, true, []byte("12"))
  565. })
  566. }
  567. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  568. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  569. func(st *serverTester) {
  570. st.writeHeaders(HeadersFrameParam{
  571. StreamID: 1, // clients send odd numbers
  572. BlockFragment: st.encodeHeader(
  573. ":method", "POST",
  574. "content-length", "4",
  575. ),
  576. EndStream: false, // to say DATA frames are coming
  577. EndHeaders: true,
  578. })
  579. st.writeData(1, true, []byte("12345"))
  580. })
  581. }
  582. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  583. testServerRequest(t, write, func(r *http.Request) {
  584. if r.Method != "POST" {
  585. t.Errorf("Method = %q; want POST", r.Method)
  586. }
  587. if r.ContentLength != wantContentLength {
  588. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  589. }
  590. all, err := ioutil.ReadAll(r.Body)
  591. if err != nil {
  592. t.Fatal(err)
  593. }
  594. if string(all) != wantBody {
  595. t.Errorf("Read = %q; want %q", all, wantBody)
  596. }
  597. if err := r.Body.Close(); err != nil {
  598. t.Fatalf("Close: %v", err)
  599. }
  600. })
  601. }
  602. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  603. testServerRequest(t, write, func(r *http.Request) {
  604. if r.Method != "POST" {
  605. t.Errorf("Method = %q; want POST", r.Method)
  606. }
  607. if r.ContentLength != wantContentLength {
  608. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  609. }
  610. all, err := ioutil.ReadAll(r.Body)
  611. if err == nil {
  612. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  613. wantReadError, all)
  614. }
  615. if !strings.Contains(err.Error(), wantReadError) {
  616. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  617. }
  618. if err := r.Body.Close(); err != nil {
  619. t.Fatalf("Close: %v", err)
  620. }
  621. })
  622. }
  623. // Using a Host header, instead of :authority
  624. func TestServer_Request_Get_Host(t *testing.T) {
  625. const host = "example.com"
  626. testServerRequest(t, func(st *serverTester) {
  627. st.writeHeaders(HeadersFrameParam{
  628. StreamID: 1, // clients send odd numbers
  629. BlockFragment: st.encodeHeader("host", host),
  630. EndStream: true,
  631. EndHeaders: true,
  632. })
  633. }, func(r *http.Request) {
  634. if r.Host != host {
  635. t.Errorf("Host = %q; want %q", r.Host, host)
  636. }
  637. })
  638. }
  639. // Using an :authority pseudo-header, instead of Host
  640. func TestServer_Request_Get_Authority(t *testing.T) {
  641. const host = "example.com"
  642. testServerRequest(t, func(st *serverTester) {
  643. st.writeHeaders(HeadersFrameParam{
  644. StreamID: 1, // clients send odd numbers
  645. BlockFragment: st.encodeHeader(":authority", host),
  646. EndStream: true,
  647. EndHeaders: true,
  648. })
  649. }, func(r *http.Request) {
  650. if r.Host != host {
  651. t.Errorf("Host = %q; want %q", r.Host, host)
  652. }
  653. })
  654. }
  655. func TestServer_Request_WithContinuation(t *testing.T) {
  656. wantHeader := http.Header{
  657. "Foo-One": []string{"value-one"},
  658. "Foo-Two": []string{"value-two"},
  659. "Foo-Three": []string{"value-three"},
  660. }
  661. testServerRequest(t, func(st *serverTester) {
  662. fullHeaders := st.encodeHeader(
  663. "foo-one", "value-one",
  664. "foo-two", "value-two",
  665. "foo-three", "value-three",
  666. )
  667. remain := fullHeaders
  668. chunks := 0
  669. for len(remain) > 0 {
  670. const maxChunkSize = 5
  671. chunk := remain
  672. if len(chunk) > maxChunkSize {
  673. chunk = chunk[:maxChunkSize]
  674. }
  675. remain = remain[len(chunk):]
  676. if chunks == 0 {
  677. st.writeHeaders(HeadersFrameParam{
  678. StreamID: 1, // clients send odd numbers
  679. BlockFragment: chunk,
  680. EndStream: true, // no DATA frames
  681. EndHeaders: false, // we'll have continuation frames
  682. })
  683. } else {
  684. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  685. if err != nil {
  686. t.Fatal(err)
  687. }
  688. }
  689. chunks++
  690. }
  691. if chunks < 2 {
  692. t.Fatal("too few chunks")
  693. }
  694. }, func(r *http.Request) {
  695. if !reflect.DeepEqual(r.Header, wantHeader) {
  696. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  697. }
  698. })
  699. }
  700. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  701. func TestServer_Request_CookieConcat(t *testing.T) {
  702. const host = "example.com"
  703. testServerRequest(t, func(st *serverTester) {
  704. st.bodylessReq1(
  705. ":authority", host,
  706. "cookie", "a=b",
  707. "cookie", "c=d",
  708. "cookie", "e=f",
  709. )
  710. }, func(r *http.Request) {
  711. const want = "a=b; c=d; e=f"
  712. if got := r.Header.Get("Cookie"); got != want {
  713. t.Errorf("Cookie = %q; want %q", got, want)
  714. }
  715. })
  716. }
  717. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  718. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  719. }
  720. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  721. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  722. }
  723. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  724. // 8.1.2.3 Request Pseudo-Header Fields
  725. // "All HTTP/2 requests MUST include exactly one valid value" ...
  726. testRejectRequest(t, func(st *serverTester) {
  727. st.addLogFilter("duplicate pseudo-header")
  728. st.bodylessReq1(":method", "GET", ":method", "POST")
  729. })
  730. }
  731. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  732. // 8.1.2.3 Request Pseudo-Header Fields
  733. // "All pseudo-header fields MUST appear in the header block
  734. // before regular header fields. Any request or response that
  735. // contains a pseudo-header field that appears in a header
  736. // block after a regular header field MUST be treated as
  737. // malformed (Section 8.1.2.6)."
  738. testRejectRequest(t, func(st *serverTester) {
  739. st.addLogFilter("pseudo-header after regular header")
  740. var buf bytes.Buffer
  741. enc := hpack.NewEncoder(&buf)
  742. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  743. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  744. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  745. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  746. st.writeHeaders(HeadersFrameParam{
  747. StreamID: 1, // clients send odd numbers
  748. BlockFragment: buf.Bytes(),
  749. EndStream: true,
  750. EndHeaders: true,
  751. })
  752. })
  753. }
  754. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  755. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  756. }
  757. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  758. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  759. }
  760. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  761. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  762. }
  763. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  764. testRejectRequest(t, func(st *serverTester) {
  765. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  766. st.bodylessReq1(":unknown_thing", "")
  767. })
  768. }
  769. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  770. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  771. t.Fatal("server request made it to handler; should've been rejected")
  772. })
  773. defer st.Close()
  774. st.greet()
  775. send(st)
  776. st.wantRSTStream(1, ErrCodeProtocol)
  777. }
  778. func TestServer_Ping(t *testing.T) {
  779. st := newServerTester(t, nil)
  780. defer st.Close()
  781. st.greet()
  782. // Server should ignore this one, since it has ACK set.
  783. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  784. if err := st.fr.WritePing(true, ackPingData); err != nil {
  785. t.Fatal(err)
  786. }
  787. // But the server should reply to this one, since ACK is false.
  788. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  789. if err := st.fr.WritePing(false, pingData); err != nil {
  790. t.Fatal(err)
  791. }
  792. pf := st.wantPing()
  793. if !pf.Flags.Has(FlagPingAck) {
  794. t.Error("response ping doesn't have ACK set")
  795. }
  796. if pf.Data != pingData {
  797. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  798. }
  799. }
  800. func TestServer_RejectsLargeFrames(t *testing.T) {
  801. st := newServerTester(t, nil)
  802. defer st.Close()
  803. st.greet()
  804. // Write too large of a frame (too large by one byte)
  805. // We ignore the return value because it's expected that the server
  806. // will only read the first 9 bytes (the headre) and then disconnect.
  807. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  808. gf := st.wantGoAway()
  809. if gf.ErrCode != ErrCodeFrameSize {
  810. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  811. }
  812. }
  813. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  814. puppet := newHandlerPuppet()
  815. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  816. puppet.act(w, r)
  817. })
  818. defer st.Close()
  819. defer puppet.done()
  820. st.greet()
  821. st.writeHeaders(HeadersFrameParam{
  822. StreamID: 1, // clients send odd numbers
  823. BlockFragment: st.encodeHeader(":method", "POST"),
  824. EndStream: false, // data coming
  825. EndHeaders: true,
  826. })
  827. st.writeData(1, false, []byte("abcdef"))
  828. puppet.do(readBodyHandler(t, "abc"))
  829. st.wantWindowUpdate(0, 3)
  830. st.wantWindowUpdate(1, 3)
  831. puppet.do(readBodyHandler(t, "def"))
  832. st.wantWindowUpdate(0, 3)
  833. st.wantWindowUpdate(1, 3)
  834. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  835. puppet.do(readBodyHandler(t, "ghi"))
  836. puppet.do(readBodyHandler(t, "jkl"))
  837. st.wantWindowUpdate(0, 3)
  838. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  839. }
  840. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  841. st := newServerTester(t, nil)
  842. defer st.Close()
  843. st.greet()
  844. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  845. t.Fatal(err)
  846. }
  847. gf := st.wantGoAway()
  848. if gf.ErrCode != ErrCodeFlowControl {
  849. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  850. }
  851. if gf.LastStreamID != 0 {
  852. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  853. }
  854. }
  855. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  856. inHandler := make(chan bool)
  857. blockHandler := make(chan bool)
  858. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  859. inHandler <- true
  860. <-blockHandler
  861. })
  862. defer st.Close()
  863. defer close(blockHandler)
  864. st.greet()
  865. st.writeHeaders(HeadersFrameParam{
  866. StreamID: 1,
  867. BlockFragment: st.encodeHeader(":method", "POST"),
  868. EndStream: false, // keep it open
  869. EndHeaders: true,
  870. })
  871. <-inHandler
  872. // Send a bogus window update:
  873. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  874. t.Fatal(err)
  875. }
  876. st.wantRSTStream(1, ErrCodeFlowControl)
  877. }
  878. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  879. // then runs fn once in the handler, and verifies that the error returned from
  880. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  881. func testServerPostUnblock(t *testing.T,
  882. handler func(http.ResponseWriter, *http.Request) error,
  883. fn func(*serverTester),
  884. checkErr func(error),
  885. otherHeaders ...string) {
  886. inHandler := make(chan bool)
  887. errc := make(chan error, 1)
  888. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  889. inHandler <- true
  890. errc <- handler(w, r)
  891. })
  892. st.greet()
  893. st.writeHeaders(HeadersFrameParam{
  894. StreamID: 1,
  895. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  896. EndStream: false, // keep it open
  897. EndHeaders: true,
  898. })
  899. <-inHandler
  900. fn(st)
  901. select {
  902. case err := <-errc:
  903. if checkErr != nil {
  904. checkErr(err)
  905. }
  906. case <-time.After(5 * time.Second):
  907. t.Fatal("timeout waiting for Handler to return")
  908. }
  909. st.Close()
  910. }
  911. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  912. testServerPostUnblock(t,
  913. func(w http.ResponseWriter, r *http.Request) (err error) {
  914. _, err = r.Body.Read(make([]byte, 1))
  915. return
  916. },
  917. func(st *serverTester) {
  918. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  919. t.Fatal(err)
  920. }
  921. },
  922. func(err error) {
  923. if err == nil {
  924. t.Error("unexpected nil error from Request.Body.Read")
  925. }
  926. },
  927. )
  928. }
  929. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  930. testServerPostUnblock(t,
  931. func(w http.ResponseWriter, r *http.Request) (err error) {
  932. _, err = r.Body.Read(make([]byte, 1))
  933. return
  934. },
  935. func(st *serverTester) { st.cc.Close() },
  936. func(err error) {
  937. if err == nil {
  938. t.Error("unexpected nil error from Request.Body.Read")
  939. }
  940. },
  941. )
  942. }
  943. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  944. <-w.(http.CloseNotifier).CloseNotify()
  945. return nil
  946. }
  947. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  948. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  949. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  950. t.Fatal(err)
  951. }
  952. }, nil)
  953. }
  954. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  955. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  956. }
  957. // that CloseNotify unblocks after a stream error due to the client's
  958. // problem that's unrelated to them explicitly canceling it (which is
  959. // TestServer_CloseNotify_After_RSTStream above)
  960. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  961. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  962. // data longer than declared Content-Length => stream error
  963. st.writeData(1, true, []byte("1234"))
  964. }, nil, "content-length", "3")
  965. }
  966. func TestServer_StateTransitions(t *testing.T) {
  967. var st *serverTester
  968. inHandler := make(chan bool)
  969. writeData := make(chan bool)
  970. leaveHandler := make(chan bool)
  971. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  972. inHandler <- true
  973. if st.stream(1) == nil {
  974. t.Errorf("nil stream 1 in handler")
  975. }
  976. if got, want := st.streamState(1), stateOpen; got != want {
  977. t.Errorf("in handler, state is %v; want %v", got, want)
  978. }
  979. writeData <- true
  980. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  981. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  982. }
  983. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  984. t.Errorf("in handler, state is %v; want %v", got, want)
  985. }
  986. <-leaveHandler
  987. })
  988. st.greet()
  989. if st.stream(1) != nil {
  990. t.Fatal("stream 1 should be empty")
  991. }
  992. if got := st.streamState(1); got != stateIdle {
  993. t.Fatalf("stream 1 should be idle; got %v", got)
  994. }
  995. st.writeHeaders(HeadersFrameParam{
  996. StreamID: 1,
  997. BlockFragment: st.encodeHeader(":method", "POST"),
  998. EndStream: false, // keep it open
  999. EndHeaders: true,
  1000. })
  1001. <-inHandler
  1002. <-writeData
  1003. st.writeData(1, true, nil)
  1004. leaveHandler <- true
  1005. hf := st.wantHeaders()
  1006. if !hf.StreamEnded() {
  1007. t.Fatal("expected END_STREAM flag")
  1008. }
  1009. if got, want := st.streamState(1), stateClosed; got != want {
  1010. t.Errorf("at end, state is %v; want %v", got, want)
  1011. }
  1012. if st.stream(1) != nil {
  1013. t.Fatal("at end, stream 1 should be gone")
  1014. }
  1015. }
  1016. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1017. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1018. testServerRejects(t, func(st *serverTester) {
  1019. st.writeHeaders(HeadersFrameParam{
  1020. StreamID: 1,
  1021. BlockFragment: st.encodeHeader(),
  1022. EndStream: true,
  1023. EndHeaders: false,
  1024. })
  1025. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1026. StreamID: 3, // different stream.
  1027. BlockFragment: st.encodeHeader(),
  1028. EndStream: true,
  1029. EndHeaders: true,
  1030. })
  1031. })
  1032. }
  1033. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1034. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1035. testServerRejects(t, func(st *serverTester) {
  1036. st.writeHeaders(HeadersFrameParam{
  1037. StreamID: 1,
  1038. BlockFragment: st.encodeHeader(),
  1039. EndStream: true,
  1040. EndHeaders: false,
  1041. })
  1042. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1043. t.Fatal(err)
  1044. }
  1045. })
  1046. }
  1047. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1048. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1049. testServerRejects(t, func(st *serverTester) {
  1050. st.writeHeaders(HeadersFrameParam{
  1051. StreamID: 1,
  1052. BlockFragment: st.encodeHeader(),
  1053. EndStream: true,
  1054. EndHeaders: true,
  1055. })
  1056. st.wantHeaders()
  1057. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1058. t.Fatal(err)
  1059. }
  1060. })
  1061. }
  1062. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1063. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1064. testServerRejects(t, func(st *serverTester) {
  1065. st.writeHeaders(HeadersFrameParam{
  1066. StreamID: 1,
  1067. BlockFragment: st.encodeHeader(),
  1068. EndStream: true,
  1069. EndHeaders: false,
  1070. })
  1071. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1072. t.Fatal(err)
  1073. }
  1074. })
  1075. }
  1076. // No HEADERS on stream 0.
  1077. func TestServer_Rejects_Headers0(t *testing.T) {
  1078. testServerRejects(t, func(st *serverTester) {
  1079. st.fr.AllowIllegalWrites = true
  1080. st.writeHeaders(HeadersFrameParam{
  1081. StreamID: 0,
  1082. BlockFragment: st.encodeHeader(),
  1083. EndStream: true,
  1084. EndHeaders: true,
  1085. })
  1086. })
  1087. }
  1088. // No CONTINUATION on stream 0.
  1089. func TestServer_Rejects_Continuation0(t *testing.T) {
  1090. testServerRejects(t, func(st *serverTester) {
  1091. st.fr.AllowIllegalWrites = true
  1092. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1093. t.Fatal(err)
  1094. }
  1095. })
  1096. }
  1097. func TestServer_Rejects_PushPromise(t *testing.T) {
  1098. testServerRejects(t, func(st *serverTester) {
  1099. pp := PushPromiseParam{
  1100. StreamID: 1,
  1101. PromiseID: 3,
  1102. }
  1103. if err := st.fr.WritePushPromise(pp); err != nil {
  1104. t.Fatal(err)
  1105. }
  1106. })
  1107. }
  1108. // testServerRejects tests that the server hangs up with a GOAWAY
  1109. // frame and a server close after the client does something
  1110. // deserving a CONNECTION_ERROR.
  1111. func testServerRejects(t *testing.T, writeReq func(*serverTester)) {
  1112. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1113. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1114. defer st.Close()
  1115. st.greet()
  1116. writeReq(st)
  1117. st.wantGoAway()
  1118. errc := make(chan error, 1)
  1119. go func() {
  1120. fr, err := st.fr.ReadFrame()
  1121. if err == nil {
  1122. err = fmt.Errorf("got frame of type %T", fr)
  1123. }
  1124. errc <- err
  1125. }()
  1126. select {
  1127. case err := <-errc:
  1128. if err != io.EOF {
  1129. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1130. }
  1131. case <-time.After(2 * time.Second):
  1132. t.Error("timeout waiting for disconnect")
  1133. }
  1134. }
  1135. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1136. // write a single request with writeReq, and then verify that the
  1137. // *http.Request is built correctly in checkReq.
  1138. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1139. gotReq := make(chan bool, 1)
  1140. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1141. if r.Body == nil {
  1142. t.Fatal("nil Body")
  1143. }
  1144. checkReq(r)
  1145. gotReq <- true
  1146. })
  1147. defer st.Close()
  1148. st.greet()
  1149. writeReq(st)
  1150. select {
  1151. case <-gotReq:
  1152. case <-time.After(2 * time.Second):
  1153. t.Error("timeout waiting for request")
  1154. }
  1155. }
  1156. func getSlash(st *serverTester) { st.bodylessReq1() }
  1157. func TestServer_Response_NoData(t *testing.T) {
  1158. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1159. // Nothing.
  1160. return nil
  1161. }, func(st *serverTester) {
  1162. getSlash(st)
  1163. hf := st.wantHeaders()
  1164. if !hf.StreamEnded() {
  1165. t.Fatal("want END_STREAM flag")
  1166. }
  1167. if !hf.HeadersEnded() {
  1168. t.Fatal("want END_HEADERS flag")
  1169. }
  1170. })
  1171. }
  1172. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1173. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1174. w.Header().Set("Foo-Bar", "some-value")
  1175. return nil
  1176. }, func(st *serverTester) {
  1177. getSlash(st)
  1178. hf := st.wantHeaders()
  1179. if !hf.StreamEnded() {
  1180. t.Fatal("want END_STREAM flag")
  1181. }
  1182. if !hf.HeadersEnded() {
  1183. t.Fatal("want END_HEADERS flag")
  1184. }
  1185. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1186. wanth := [][2]string{
  1187. {":status", "200"},
  1188. {"foo-bar", "some-value"},
  1189. {"content-type", "text/plain; charset=utf-8"},
  1190. {"content-length", "0"},
  1191. }
  1192. if !reflect.DeepEqual(goth, wanth) {
  1193. t.Errorf("Got headers %v; want %v", goth, wanth)
  1194. }
  1195. })
  1196. }
  1197. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1198. const msg = "<html>this is HTML."
  1199. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1200. w.Header().Set("Content-Type", "foo/bar")
  1201. io.WriteString(w, msg)
  1202. return nil
  1203. }, func(st *serverTester) {
  1204. getSlash(st)
  1205. hf := st.wantHeaders()
  1206. if hf.StreamEnded() {
  1207. t.Fatal("don't want END_STREAM, expecting data")
  1208. }
  1209. if !hf.HeadersEnded() {
  1210. t.Fatal("want END_HEADERS flag")
  1211. }
  1212. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1213. wanth := [][2]string{
  1214. {":status", "200"},
  1215. {"content-type", "foo/bar"},
  1216. {"content-length", strconv.Itoa(len(msg))},
  1217. }
  1218. if !reflect.DeepEqual(goth, wanth) {
  1219. t.Errorf("Got headers %v; want %v", goth, wanth)
  1220. }
  1221. df := st.wantData()
  1222. if !df.StreamEnded() {
  1223. t.Error("expected DATA to have END_STREAM flag")
  1224. }
  1225. if got := string(df.Data()); got != msg {
  1226. t.Errorf("got DATA %q; want %q", got, msg)
  1227. }
  1228. })
  1229. }
  1230. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1231. const msg = "hi"
  1232. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1233. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1234. io.WriteString(w, msg)
  1235. return nil
  1236. }, func(st *serverTester) {
  1237. getSlash(st)
  1238. hf := st.wantHeaders()
  1239. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1240. wanth := [][2]string{
  1241. {":status", "200"},
  1242. {"content-type", "text/plain; charset=utf-8"},
  1243. {"content-length", strconv.Itoa(len(msg))},
  1244. }
  1245. if !reflect.DeepEqual(goth, wanth) {
  1246. t.Errorf("Got headers %v; want %v", goth, wanth)
  1247. }
  1248. })
  1249. }
  1250. // Header accessed only after the initial write.
  1251. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1252. const msg = "<html>this is HTML."
  1253. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1254. io.WriteString(w, msg)
  1255. w.Header().Set("foo", "should be ignored")
  1256. return nil
  1257. }, func(st *serverTester) {
  1258. getSlash(st)
  1259. hf := st.wantHeaders()
  1260. if hf.StreamEnded() {
  1261. t.Fatal("unexpected END_STREAM")
  1262. }
  1263. if !hf.HeadersEnded() {
  1264. t.Fatal("want END_HEADERS flag")
  1265. }
  1266. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1267. wanth := [][2]string{
  1268. {":status", "200"},
  1269. {"content-type", "text/html; charset=utf-8"},
  1270. {"content-length", strconv.Itoa(len(msg))},
  1271. }
  1272. if !reflect.DeepEqual(goth, wanth) {
  1273. t.Errorf("Got headers %v; want %v", goth, wanth)
  1274. }
  1275. })
  1276. }
  1277. // Header accessed before the initial write and later mutated.
  1278. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1279. const msg = "<html>this is HTML."
  1280. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1281. w.Header().Set("foo", "proper value")
  1282. io.WriteString(w, msg)
  1283. w.Header().Set("foo", "should be ignored")
  1284. return nil
  1285. }, func(st *serverTester) {
  1286. getSlash(st)
  1287. hf := st.wantHeaders()
  1288. if hf.StreamEnded() {
  1289. t.Fatal("unexpected END_STREAM")
  1290. }
  1291. if !hf.HeadersEnded() {
  1292. t.Fatal("want END_HEADERS flag")
  1293. }
  1294. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1295. wanth := [][2]string{
  1296. {":status", "200"},
  1297. {"foo", "proper value"},
  1298. {"content-type", "text/html; charset=utf-8"},
  1299. {"content-length", strconv.Itoa(len(msg))},
  1300. }
  1301. if !reflect.DeepEqual(goth, wanth) {
  1302. t.Errorf("Got headers %v; want %v", goth, wanth)
  1303. }
  1304. })
  1305. }
  1306. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1307. const msg = "<html>this is HTML."
  1308. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1309. io.WriteString(w, msg)
  1310. return nil
  1311. }, func(st *serverTester) {
  1312. getSlash(st)
  1313. hf := st.wantHeaders()
  1314. if hf.StreamEnded() {
  1315. t.Fatal("don't want END_STREAM, expecting data")
  1316. }
  1317. if !hf.HeadersEnded() {
  1318. t.Fatal("want END_HEADERS flag")
  1319. }
  1320. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1321. wanth := [][2]string{
  1322. {":status", "200"},
  1323. {"content-type", "text/html; charset=utf-8"},
  1324. {"content-length", strconv.Itoa(len(msg))},
  1325. }
  1326. if !reflect.DeepEqual(goth, wanth) {
  1327. t.Errorf("Got headers %v; want %v", goth, wanth)
  1328. }
  1329. df := st.wantData()
  1330. if !df.StreamEnded() {
  1331. t.Error("expected DATA to have END_STREAM flag")
  1332. }
  1333. if got := string(df.Data()); got != msg {
  1334. t.Errorf("got DATA %q; want %q", got, msg)
  1335. }
  1336. })
  1337. }
  1338. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1339. const msg = "<html>this is HTML"
  1340. const msg2 = ", and this is the next chunk"
  1341. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1342. io.WriteString(w, msg)
  1343. w.(http.Flusher).Flush()
  1344. io.WriteString(w, msg2)
  1345. return nil
  1346. }, func(st *serverTester) {
  1347. getSlash(st)
  1348. hf := st.wantHeaders()
  1349. if hf.StreamEnded() {
  1350. t.Fatal("unexpected END_STREAM flag")
  1351. }
  1352. if !hf.HeadersEnded() {
  1353. t.Fatal("want END_HEADERS flag")
  1354. }
  1355. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1356. wanth := [][2]string{
  1357. {":status", "200"},
  1358. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1359. // and no content-length
  1360. }
  1361. if !reflect.DeepEqual(goth, wanth) {
  1362. t.Errorf("Got headers %v; want %v", goth, wanth)
  1363. }
  1364. {
  1365. df := st.wantData()
  1366. if df.StreamEnded() {
  1367. t.Error("unexpected END_STREAM flag")
  1368. }
  1369. if got := string(df.Data()); got != msg {
  1370. t.Errorf("got DATA %q; want %q", got, msg)
  1371. }
  1372. }
  1373. {
  1374. df := st.wantData()
  1375. if !df.StreamEnded() {
  1376. t.Error("wanted END_STREAM flag on last data chunk")
  1377. }
  1378. if got := string(df.Data()); got != msg2 {
  1379. t.Errorf("got DATA %q; want %q", got, msg2)
  1380. }
  1381. }
  1382. })
  1383. }
  1384. func TestServer_Response_LargeWrite(t *testing.T) {
  1385. const size = 1 << 20
  1386. const maxFrameSize = 16 << 10
  1387. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1388. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1389. if err != nil {
  1390. return fmt.Errorf("Write error: %v", err)
  1391. }
  1392. if n != size {
  1393. return fmt.Errorf("wrong size %d from Write", n)
  1394. }
  1395. return nil
  1396. }, func(st *serverTester) {
  1397. if err := st.fr.WriteSettings(
  1398. Setting{SettingInitialWindowSize, 0},
  1399. Setting{SettingMaxFrameSize, maxFrameSize},
  1400. ); err != nil {
  1401. t.Fatal(err)
  1402. }
  1403. st.wantSettingsAck()
  1404. getSlash(st) // make the single request
  1405. // Give the handler quota to write:
  1406. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1407. t.Fatal(err)
  1408. }
  1409. // Give the handler quota to write to connection-level
  1410. // window as well
  1411. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1412. t.Fatal(err)
  1413. }
  1414. hf := st.wantHeaders()
  1415. if hf.StreamEnded() {
  1416. t.Fatal("unexpected END_STREAM flag")
  1417. }
  1418. if !hf.HeadersEnded() {
  1419. t.Fatal("want END_HEADERS flag")
  1420. }
  1421. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1422. wanth := [][2]string{
  1423. {":status", "200"},
  1424. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1425. // and no content-length
  1426. }
  1427. if !reflect.DeepEqual(goth, wanth) {
  1428. t.Errorf("Got headers %v; want %v", goth, wanth)
  1429. }
  1430. var bytes, frames int
  1431. for {
  1432. df := st.wantData()
  1433. bytes += len(df.Data())
  1434. frames++
  1435. for _, b := range df.Data() {
  1436. if b != 'a' {
  1437. t.Fatal("non-'a' byte seen in DATA")
  1438. }
  1439. }
  1440. if df.StreamEnded() {
  1441. break
  1442. }
  1443. }
  1444. if bytes != size {
  1445. t.Errorf("Got %d bytes; want %d", bytes, size)
  1446. }
  1447. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1448. t.Errorf("Got %d frames; want %d", frames, size)
  1449. }
  1450. })
  1451. }
  1452. // Test that the handler can't write more than the client allows
  1453. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1454. const size = 1 << 20
  1455. const maxFrameSize = 16 << 10
  1456. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1457. w.(http.Flusher).Flush()
  1458. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1459. if err != nil {
  1460. return fmt.Errorf("Write error: %v", err)
  1461. }
  1462. if n != size {
  1463. return fmt.Errorf("wrong size %d from Write", n)
  1464. }
  1465. return nil
  1466. }, func(st *serverTester) {
  1467. // Set the window size to something explicit for this test.
  1468. // It's also how much initial data we expect.
  1469. const initWindowSize = 123
  1470. if err := st.fr.WriteSettings(
  1471. Setting{SettingInitialWindowSize, initWindowSize},
  1472. Setting{SettingMaxFrameSize, maxFrameSize},
  1473. ); err != nil {
  1474. t.Fatal(err)
  1475. }
  1476. st.wantSettingsAck()
  1477. getSlash(st) // make the single request
  1478. defer func() { st.fr.WriteRSTStream(1, ErrCodeCancel) }()
  1479. hf := st.wantHeaders()
  1480. if hf.StreamEnded() {
  1481. t.Fatal("unexpected END_STREAM flag")
  1482. }
  1483. if !hf.HeadersEnded() {
  1484. t.Fatal("want END_HEADERS flag")
  1485. }
  1486. df := st.wantData()
  1487. if got := len(df.Data()); got != initWindowSize {
  1488. t.Fatalf("Initial window size = %d but got DATA with %d bytes", initWindowSize, got)
  1489. }
  1490. for _, quota := range []int{1, 13, 127} {
  1491. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1492. t.Fatal(err)
  1493. }
  1494. df := st.wantData()
  1495. if int(quota) != len(df.Data()) {
  1496. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1497. }
  1498. }
  1499. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1500. t.Fatal(err)
  1501. }
  1502. })
  1503. }
  1504. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1505. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1506. const size = 1 << 20
  1507. const maxFrameSize = 16 << 10
  1508. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1509. w.(http.Flusher).Flush()
  1510. errc := make(chan error, 1)
  1511. go func() {
  1512. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1513. errc <- err
  1514. }()
  1515. select {
  1516. case err := <-errc:
  1517. if err == nil {
  1518. return errors.New("unexpected nil error from Write in handler")
  1519. }
  1520. return nil
  1521. case <-time.After(2 * time.Second):
  1522. return errors.New("timeout waiting for Write in handler")
  1523. }
  1524. }, func(st *serverTester) {
  1525. if err := st.fr.WriteSettings(
  1526. Setting{SettingInitialWindowSize, 0},
  1527. Setting{SettingMaxFrameSize, maxFrameSize},
  1528. ); err != nil {
  1529. t.Fatal(err)
  1530. }
  1531. st.wantSettingsAck()
  1532. getSlash(st) // make the single request
  1533. hf := st.wantHeaders()
  1534. if hf.StreamEnded() {
  1535. t.Fatal("unexpected END_STREAM flag")
  1536. }
  1537. if !hf.HeadersEnded() {
  1538. t.Fatal("want END_HEADERS flag")
  1539. }
  1540. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1541. t.Fatal(err)
  1542. }
  1543. })
  1544. }
  1545. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1546. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1547. w.(http.Flusher).Flush()
  1548. // Nothing; send empty DATA
  1549. return nil
  1550. }, func(st *serverTester) {
  1551. // Handler gets no data quota:
  1552. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1553. t.Fatal(err)
  1554. }
  1555. st.wantSettingsAck()
  1556. getSlash(st) // make the single request
  1557. hf := st.wantHeaders()
  1558. if hf.StreamEnded() {
  1559. t.Fatal("unexpected END_STREAM flag")
  1560. }
  1561. if !hf.HeadersEnded() {
  1562. t.Fatal("want END_HEADERS flag")
  1563. }
  1564. df := st.wantData()
  1565. if got := len(df.Data()); got != 0 {
  1566. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1567. }
  1568. if !df.StreamEnded() {
  1569. t.Fatal("DATA didn't have END_STREAM")
  1570. }
  1571. })
  1572. }
  1573. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1574. const msg = "foo"
  1575. const reply = "bar"
  1576. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1577. if v := r.Header.Get("Expect"); v != "" {
  1578. t.Errorf("Expect header = %q; want empty", v)
  1579. }
  1580. buf := make([]byte, len(msg))
  1581. // This read should trigger the 100-continue being sent.
  1582. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1583. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1584. }
  1585. _, err := io.WriteString(w, reply)
  1586. return err
  1587. }, func(st *serverTester) {
  1588. st.writeHeaders(HeadersFrameParam{
  1589. StreamID: 1, // clients send odd numbers
  1590. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1591. EndStream: false,
  1592. EndHeaders: true,
  1593. })
  1594. hf := st.wantHeaders()
  1595. if hf.StreamEnded() {
  1596. t.Fatal("unexpected END_STREAM flag")
  1597. }
  1598. if !hf.HeadersEnded() {
  1599. t.Fatal("want END_HEADERS flag")
  1600. }
  1601. goth := decodeHeader(t, hf.HeaderBlockFragment())
  1602. wanth := [][2]string{
  1603. {":status", "100"},
  1604. }
  1605. if !reflect.DeepEqual(goth, wanth) {
  1606. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1607. }
  1608. // Okay, they sent status 100, so we can send our
  1609. // gigantic and/or sensitive "foo" payload now.
  1610. st.writeData(1, true, []byte(msg))
  1611. st.wantWindowUpdate(0, uint32(len(msg)))
  1612. hf = st.wantHeaders()
  1613. if hf.StreamEnded() {
  1614. t.Fatal("expected data to follow")
  1615. }
  1616. if !hf.HeadersEnded() {
  1617. t.Fatal("want END_HEADERS flag")
  1618. }
  1619. goth = decodeHeader(t, hf.HeaderBlockFragment())
  1620. wanth = [][2]string{
  1621. {":status", "200"},
  1622. {"content-type", "text/plain; charset=utf-8"},
  1623. {"content-length", strconv.Itoa(len(reply))},
  1624. }
  1625. if !reflect.DeepEqual(goth, wanth) {
  1626. t.Errorf("Got headers %v; want %v", goth, wanth)
  1627. }
  1628. df := st.wantData()
  1629. if string(df.Data()) != reply {
  1630. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1631. }
  1632. if !df.StreamEnded() {
  1633. t.Errorf("expect data stream end")
  1634. }
  1635. })
  1636. }
  1637. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  1638. errc := make(chan error, 1)
  1639. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1640. p := []byte("some data.\n")
  1641. for {
  1642. _, err := w.Write(p)
  1643. if err != nil {
  1644. errc <- err
  1645. return nil
  1646. }
  1647. }
  1648. }, func(st *serverTester) {
  1649. st.writeHeaders(HeadersFrameParam{
  1650. StreamID: 1,
  1651. BlockFragment: st.encodeHeader(),
  1652. EndStream: false,
  1653. EndHeaders: true,
  1654. })
  1655. hf := st.wantHeaders()
  1656. if hf.StreamEnded() {
  1657. t.Fatal("unexpected END_STREAM flag")
  1658. }
  1659. if !hf.HeadersEnded() {
  1660. t.Fatal("want END_HEADERS flag")
  1661. }
  1662. // Close the connection and wait for the handler to (hopefully) notice.
  1663. st.cc.Close()
  1664. select {
  1665. case <-errc:
  1666. case <-time.After(5 * time.Second):
  1667. t.Error("timeout")
  1668. }
  1669. })
  1670. }
  1671. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  1672. const testPath = "/some/path"
  1673. inHandler := make(chan uint32)
  1674. leaveHandler := make(chan bool)
  1675. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1676. id := w.(*responseWriter).rws.stream.id
  1677. inHandler <- id
  1678. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  1679. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  1680. }
  1681. <-leaveHandler
  1682. })
  1683. defer st.Close()
  1684. st.greet()
  1685. nextStreamID := uint32(1)
  1686. streamID := func() uint32 {
  1687. defer func() { nextStreamID += 2 }()
  1688. return nextStreamID
  1689. }
  1690. sendReq := func(id uint32, headers ...string) {
  1691. st.writeHeaders(HeadersFrameParam{
  1692. StreamID: id,
  1693. BlockFragment: st.encodeHeader(headers...),
  1694. EndStream: true,
  1695. EndHeaders: true,
  1696. })
  1697. }
  1698. for i := 0; i < defaultMaxStreams; i++ {
  1699. sendReq(streamID())
  1700. <-inHandler
  1701. }
  1702. defer func() {
  1703. for i := 0; i < defaultMaxStreams; i++ {
  1704. leaveHandler <- true
  1705. }
  1706. }()
  1707. // And this one should cross the limit:
  1708. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  1709. // even if we're rejecting it)
  1710. rejectID := streamID()
  1711. headerBlock := st.encodeHeader(":path", testPath)
  1712. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  1713. st.writeHeaders(HeadersFrameParam{
  1714. StreamID: rejectID,
  1715. BlockFragment: frag1,
  1716. EndStream: true,
  1717. EndHeaders: false, // CONTINUATION coming
  1718. })
  1719. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  1720. t.Fatal(err)
  1721. }
  1722. st.wantRSTStream(rejectID, ErrCodeProtocol)
  1723. // But let a handler finish:
  1724. leaveHandler <- true
  1725. st.wantHeaders()
  1726. // And now another stream should be able to start:
  1727. goodID := streamID()
  1728. sendReq(goodID, ":path", testPath)
  1729. select {
  1730. case got := <-inHandler:
  1731. if got != goodID {
  1732. t.Errorf("Got stream %d; want %d", got, goodID)
  1733. }
  1734. case <-time.After(3 * time.Second):
  1735. t.Error("timeout waiting for handler")
  1736. }
  1737. }
  1738. // So many response headers that the server needs to use CONTINUATION frames:
  1739. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  1740. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1741. h := w.Header()
  1742. for i := 0; i < 5000; i++ {
  1743. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  1744. }
  1745. return nil
  1746. }, func(st *serverTester) {
  1747. getSlash(st)
  1748. hf := st.wantHeaders()
  1749. if hf.HeadersEnded() {
  1750. t.Fatal("got unwanted END_HEADERS flag")
  1751. }
  1752. n := 0
  1753. for {
  1754. n++
  1755. cf := st.wantContinuation()
  1756. if cf.HeadersEnded() {
  1757. break
  1758. }
  1759. }
  1760. if n < 5 {
  1761. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  1762. }
  1763. })
  1764. }
  1765. // This previously crashed (reported by Mathieu Lonjaret as observed
  1766. // while using Camlistore) because we got a DATA frame from the client
  1767. // after the handler exited and our logic at the time was wrong,
  1768. // keeping a stream in the map in stateClosed, which tickled an
  1769. // invariant check later when we tried to remove that stream (via
  1770. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  1771. // ended.
  1772. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  1773. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1774. // nothing
  1775. return nil
  1776. }, func(st *serverTester) {
  1777. st.writeHeaders(HeadersFrameParam{
  1778. StreamID: 1,
  1779. BlockFragment: st.encodeHeader(),
  1780. EndStream: false, // DATA is coming
  1781. EndHeaders: true,
  1782. })
  1783. hf := st.wantHeaders()
  1784. if !hf.HeadersEnded() || !hf.StreamEnded() {
  1785. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  1786. }
  1787. // Sent when the a Handler closes while a client has
  1788. // indicated it's still sending DATA:
  1789. st.wantRSTStream(1, ErrCodeCancel)
  1790. // Now the handler has ended, so it's ended its
  1791. // stream, but the client hasn't closed its side
  1792. // (stateClosedLocal). So send more data and verify
  1793. // it doesn't crash with an internal invariant panic, like
  1794. // it did before.
  1795. st.writeData(1, true, []byte("foo"))
  1796. // Sent after a peer sends data anyway (admittedly the
  1797. // previous RST_STREAM might've still been in-flight),
  1798. // but they'll get the more friendly 'cancel' code
  1799. // first.
  1800. st.wantRSTStream(1, ErrCodeStreamClosed)
  1801. // Set up a bunch of machinery to record the panic we saw
  1802. // previously.
  1803. var (
  1804. panMu sync.Mutex
  1805. panicVal interface{}
  1806. )
  1807. testHookOnPanicMu.Lock()
  1808. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  1809. panMu.Lock()
  1810. panicVal = pv
  1811. panMu.Unlock()
  1812. return true
  1813. }
  1814. testHookOnPanicMu.Unlock()
  1815. // Now force the serve loop to end, via closing the connection.
  1816. st.cc.Close()
  1817. select {
  1818. case <-st.sc.doneServing:
  1819. // Loop has exited.
  1820. panMu.Lock()
  1821. got := panicVal
  1822. panMu.Unlock()
  1823. if got != nil {
  1824. t.Errorf("Got panic: %v", got)
  1825. }
  1826. case <-time.After(5 * time.Second):
  1827. t.Error("timeout")
  1828. }
  1829. })
  1830. }
  1831. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  1832. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  1833. func testRejectTLS(t *testing.T, max uint16) {
  1834. st := newServerTester(t, nil, func(c *tls.Config) {
  1835. c.MaxVersion = max
  1836. })
  1837. defer st.Close()
  1838. gf := st.wantGoAway()
  1839. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  1840. t.Errorf("Got error code %v; want %v", got, want)
  1841. }
  1842. }
  1843. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  1844. st := newServerTester(t, nil, func(c *tls.Config) {
  1845. // Only list bad ones:
  1846. c.CipherSuites = []uint16{
  1847. tls.TLS_RSA_WITH_RC4_128_SHA,
  1848. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  1849. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  1850. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  1851. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  1852. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  1853. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  1854. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  1855. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  1856. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  1857. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  1858. }
  1859. })
  1860. defer st.Close()
  1861. gf := st.wantGoAway()
  1862. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  1863. t.Errorf("Got error code %v; want %v", got, want)
  1864. }
  1865. }
  1866. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  1867. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  1868. st := newServerTester(t, nil, func(c *tls.Config) {
  1869. // Have the client only support the one required by the spec.
  1870. c.CipherSuites = []uint16{requiredSuite}
  1871. }, func(ts *httptest.Server) {
  1872. var srv *http.Server = ts.Config
  1873. // Have the server configured with one specific cipher suite
  1874. // which is banned. This tests that ConfigureServer ends up
  1875. // adding the good one to this list.
  1876. srv.TLSConfig = &tls.Config{
  1877. CipherSuites: []uint16{tls.TLS_RSA_WITH_AES_128_CBC_SHA}, // just a banned one
  1878. }
  1879. })
  1880. defer st.Close()
  1881. st.greet()
  1882. }
  1883. // TODO: move this onto *serverTester, and re-use the same hpack
  1884. // decoding context throughout. We're just getting lucky here with
  1885. // creating a new decoder each time.
  1886. func decodeHeader(t *testing.T, headerBlock []byte) (pairs [][2]string) {
  1887. d := hpack.NewDecoder(initialHeaderTableSize, func(f hpack.HeaderField) {
  1888. pairs = append(pairs, [2]string{f.Name, f.Value})
  1889. })
  1890. if _, err := d.Write(headerBlock); err != nil {
  1891. t.Fatalf("hpack decoding error: %v", err)
  1892. }
  1893. if err := d.Close(); err != nil {
  1894. t.Fatalf("hpack decoding error: %v", err)
  1895. }
  1896. return
  1897. }
  1898. // testServerResponse sets up an idle HTTP/2 connection and lets you
  1899. // write a single request with writeReq, and then reply to it in some way with the provided handler,
  1900. // and then verify the output with the serverTester again (assuming the handler returns nil)
  1901. func testServerResponse(t testing.TB,
  1902. handler func(http.ResponseWriter, *http.Request) error,
  1903. client func(*serverTester),
  1904. ) {
  1905. errc := make(chan error, 1)
  1906. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1907. if r.Body == nil {
  1908. t.Fatal("nil Body")
  1909. }
  1910. errc <- handler(w, r)
  1911. })
  1912. defer st.Close()
  1913. donec := make(chan bool)
  1914. go func() {
  1915. defer close(donec)
  1916. st.greet()
  1917. client(st)
  1918. }()
  1919. select {
  1920. case <-donec:
  1921. return
  1922. case <-time.After(5 * time.Second):
  1923. t.Fatal("timeout")
  1924. }
  1925. select {
  1926. case err := <-errc:
  1927. if err != nil {
  1928. t.Fatalf("Error in handler: %v", err)
  1929. }
  1930. case <-time.After(2 * time.Second):
  1931. t.Error("timeout waiting for handler to finish")
  1932. }
  1933. }
  1934. // readBodyHandler returns an http Handler func that reads len(want)
  1935. // bytes from r.Body and fails t if the contents read were not
  1936. // the value of want.
  1937. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  1938. return func(w http.ResponseWriter, r *http.Request) {
  1939. buf := make([]byte, len(want))
  1940. _, err := io.ReadFull(r.Body, buf)
  1941. if err != nil {
  1942. t.Error(err)
  1943. return
  1944. }
  1945. if string(buf) != want {
  1946. t.Errorf("read %q; want %q", buf, want)
  1947. }
  1948. }
  1949. }
  1950. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  1951. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  1952. // http://sourceforge.net/p/curl/bugs/1472/
  1953. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  1954. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  1955. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  1956. if runtime.GOOS != "linux" {
  1957. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  1958. }
  1959. requireCurl(t)
  1960. const msg = "Hello from curl!\n"
  1961. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  1962. w.Header().Set("Foo", "Bar")
  1963. w.Header().Set("Client-Proto", r.Proto)
  1964. io.WriteString(w, msg)
  1965. }))
  1966. ConfigureServer(ts.Config, &Server{
  1967. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  1968. })
  1969. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  1970. ts.StartTLS()
  1971. defer ts.Close()
  1972. var gotConn int32
  1973. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  1974. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  1975. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  1976. defer kill(container)
  1977. resc := make(chan interface{}, 1)
  1978. go func() {
  1979. res, err := dockerLogs(container)
  1980. if err != nil {
  1981. resc <- err
  1982. } else {
  1983. resc <- res
  1984. }
  1985. }()
  1986. select {
  1987. case res := <-resc:
  1988. if err, ok := res.(error); ok {
  1989. t.Fatal(err)
  1990. }
  1991. if !strings.Contains(string(res.([]byte)), "foo: Bar") {
  1992. t.Errorf("didn't see foo: Bar header")
  1993. t.Logf("Got: %s", res)
  1994. }
  1995. if !strings.Contains(string(res.([]byte)), "client-proto: HTTP/2") {
  1996. t.Errorf("didn't see client-proto: HTTP/2 header")
  1997. t.Logf("Got: %s", res)
  1998. }
  1999. if !strings.Contains(string(res.([]byte)), msg) {
  2000. t.Errorf("didn't see %q content", msg)
  2001. t.Logf("Got: %s", res)
  2002. }
  2003. case <-time.After(3 * time.Second):
  2004. t.Errorf("timeout waiting for curl")
  2005. }
  2006. if atomic.LoadInt32(&gotConn) == 0 {
  2007. t.Error("never saw an http2 connection")
  2008. }
  2009. }
  2010. // Issue 12843
  2011. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2012. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2013. defer st.Close()
  2014. // shake hands
  2015. st.writePreface()
  2016. st.writeInitialSettings()
  2017. frameSize := defaultMaxReadFrameSize
  2018. var advHeaderListSize *uint32
  2019. st.wantSettings().ForeachSetting(func(s Setting) error {
  2020. switch s.ID {
  2021. case SettingMaxFrameSize:
  2022. if s.Val < minMaxFrameSize {
  2023. frameSize = minMaxFrameSize
  2024. } else if s.Val > maxFrameSize {
  2025. frameSize = maxFrameSize
  2026. } else {
  2027. frameSize = int(s.Val)
  2028. }
  2029. case SettingMaxHeaderListSize:
  2030. advHeaderListSize = &s.Val
  2031. }
  2032. return nil
  2033. })
  2034. st.writeSettingsAck()
  2035. st.wantSettingsAck()
  2036. if advHeaderListSize == nil {
  2037. t.Errorf("server didn't advertise a max header list size")
  2038. } else if *advHeaderListSize == 0 {
  2039. t.Errorf("server advertised a max header list size of 0")
  2040. }
  2041. st.encodeHeaderField(":method", "GET")
  2042. st.encodeHeaderField(":path", "/")
  2043. st.encodeHeaderField(":scheme", "https")
  2044. cookie := strings.Repeat("*", 4058)
  2045. st.encodeHeaderField("cookie", cookie)
  2046. st.writeHeaders(HeadersFrameParam{
  2047. StreamID: 1,
  2048. BlockFragment: st.headerBuf.Bytes(),
  2049. EndStream: true,
  2050. EndHeaders: false,
  2051. })
  2052. // Capture the short encoding of a duplicate ~4K cookie, now
  2053. // that we've already sent it once.
  2054. st.headerBuf.Reset()
  2055. st.encodeHeaderField("cookie", cookie)
  2056. // Now send 1MB of it.
  2057. const size = 1 << 20
  2058. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2059. for len(b) > 0 {
  2060. chunk := b
  2061. if len(chunk) > frameSize {
  2062. chunk = chunk[:frameSize]
  2063. }
  2064. b = b[len(chunk):]
  2065. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2066. }
  2067. fr, err := st.fr.ReadFrame()
  2068. if err == nil {
  2069. t.Fatalf("want error; got unexpected frame: %#v", fr)
  2070. }
  2071. }
  2072. func BenchmarkServerGets(b *testing.B) {
  2073. b.ReportAllocs()
  2074. const msg = "Hello, world"
  2075. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2076. io.WriteString(w, msg)
  2077. })
  2078. defer st.Close()
  2079. st.greet()
  2080. // Give the server quota to reply. (plus it has the the 64KB)
  2081. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2082. b.Fatal(err)
  2083. }
  2084. for i := 0; i < b.N; i++ {
  2085. id := 1 + uint32(i)*2
  2086. st.writeHeaders(HeadersFrameParam{
  2087. StreamID: id,
  2088. BlockFragment: st.encodeHeader(),
  2089. EndStream: true,
  2090. EndHeaders: true,
  2091. })
  2092. st.wantHeaders()
  2093. df := st.wantData()
  2094. if !df.StreamEnded() {
  2095. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2096. }
  2097. }
  2098. }
  2099. func BenchmarkServerPosts(b *testing.B) {
  2100. b.ReportAllocs()
  2101. const msg = "Hello, world"
  2102. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2103. io.WriteString(w, msg)
  2104. })
  2105. defer st.Close()
  2106. st.greet()
  2107. // Give the server quota to reply. (plus it has the the 64KB)
  2108. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2109. b.Fatal(err)
  2110. }
  2111. for i := 0; i < b.N; i++ {
  2112. id := 1 + uint32(i)*2
  2113. st.writeHeaders(HeadersFrameParam{
  2114. StreamID: id,
  2115. BlockFragment: st.encodeHeader(":method", "POST"),
  2116. EndStream: false,
  2117. EndHeaders: true,
  2118. })
  2119. st.writeData(id, true, nil)
  2120. st.wantHeaders()
  2121. df := st.wantData()
  2122. if !df.StreamEnded() {
  2123. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2124. }
  2125. }
  2126. }