transport_test.go 111 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "context"
  9. "crypto/tls"
  10. "errors"
  11. "flag"
  12. "fmt"
  13. "io"
  14. "io/ioutil"
  15. "log"
  16. "math/rand"
  17. "net"
  18. "net/http"
  19. "net/http/httptest"
  20. "net/textproto"
  21. "net/url"
  22. "os"
  23. "reflect"
  24. "runtime"
  25. "sort"
  26. "strconv"
  27. "strings"
  28. "sync"
  29. "sync/atomic"
  30. "testing"
  31. "time"
  32. "golang.org/x/net/http2/hpack"
  33. )
  34. var (
  35. extNet = flag.Bool("extnet", false, "do external network tests")
  36. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  37. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  38. )
  39. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  40. var canceledCtx context.Context
  41. func init() {
  42. ctx, cancel := context.WithCancel(context.Background())
  43. cancel()
  44. canceledCtx = ctx
  45. }
  46. func TestTransportExternal(t *testing.T) {
  47. if !*extNet {
  48. t.Skip("skipping external network test")
  49. }
  50. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  51. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  52. res, err := rt.RoundTrip(req)
  53. if err != nil {
  54. t.Fatalf("%v", err)
  55. }
  56. res.Write(os.Stdout)
  57. }
  58. type fakeTLSConn struct {
  59. net.Conn
  60. }
  61. func (c *fakeTLSConn) ConnectionState() tls.ConnectionState {
  62. return tls.ConnectionState{
  63. Version: tls.VersionTLS12,
  64. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  65. }
  66. }
  67. func startH2cServer(t *testing.T) net.Listener {
  68. h2Server := &Server{}
  69. l := newLocalListener(t)
  70. go func() {
  71. conn, err := l.Accept()
  72. if err != nil {
  73. t.Error(err)
  74. return
  75. }
  76. h2Server.ServeConn(&fakeTLSConn{conn}, &ServeConnOpts{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  77. fmt.Fprintf(w, "Hello, %v, http: %v", r.URL.Path, r.TLS == nil)
  78. })})
  79. }()
  80. return l
  81. }
  82. func TestTransportH2c(t *testing.T) {
  83. l := startH2cServer(t)
  84. defer l.Close()
  85. req, err := http.NewRequest("GET", "http://"+l.Addr().String()+"/foobar", nil)
  86. if err != nil {
  87. t.Fatal(err)
  88. }
  89. tr := &Transport{
  90. AllowHTTP: true,
  91. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  92. return net.Dial(network, addr)
  93. },
  94. }
  95. res, err := tr.RoundTrip(req)
  96. if err != nil {
  97. t.Fatal(err)
  98. }
  99. if res.ProtoMajor != 2 {
  100. t.Fatal("proto not h2c")
  101. }
  102. body, err := ioutil.ReadAll(res.Body)
  103. if err != nil {
  104. t.Fatal(err)
  105. }
  106. if got, want := string(body), "Hello, /foobar, http: true"; got != want {
  107. t.Fatalf("response got %v, want %v", got, want)
  108. }
  109. }
  110. func TestTransport(t *testing.T) {
  111. const body = "sup"
  112. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  113. io.WriteString(w, body)
  114. }, optOnlyServer)
  115. defer st.Close()
  116. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  117. defer tr.CloseIdleConnections()
  118. u, err := url.Parse(st.ts.URL)
  119. if err != nil {
  120. t.Fatal(err)
  121. }
  122. for i, m := range []string{"GET", ""} {
  123. req := &http.Request{
  124. Method: m,
  125. URL: u,
  126. }
  127. res, err := tr.RoundTrip(req)
  128. if err != nil {
  129. t.Fatalf("%d: %s", i, err)
  130. }
  131. t.Logf("%d: Got res: %+v", i, res)
  132. if g, w := res.StatusCode, 200; g != w {
  133. t.Errorf("%d: StatusCode = %v; want %v", i, g, w)
  134. }
  135. if g, w := res.Status, "200 OK"; g != w {
  136. t.Errorf("%d: Status = %q; want %q", i, g, w)
  137. }
  138. wantHeader := http.Header{
  139. "Content-Length": []string{"3"},
  140. "Content-Type": []string{"text/plain; charset=utf-8"},
  141. "Date": []string{"XXX"}, // see cleanDate
  142. }
  143. cleanDate(res)
  144. if !reflect.DeepEqual(res.Header, wantHeader) {
  145. t.Errorf("%d: res Header = %v; want %v", i, res.Header, wantHeader)
  146. }
  147. if res.Request != req {
  148. t.Errorf("%d: Response.Request = %p; want %p", i, res.Request, req)
  149. }
  150. if res.TLS == nil {
  151. t.Errorf("%d: Response.TLS = nil; want non-nil", i)
  152. }
  153. slurp, err := ioutil.ReadAll(res.Body)
  154. if err != nil {
  155. t.Errorf("%d: Body read: %v", i, err)
  156. } else if string(slurp) != body {
  157. t.Errorf("%d: Body = %q; want %q", i, slurp, body)
  158. }
  159. res.Body.Close()
  160. }
  161. }
  162. func onSameConn(t *testing.T, modReq func(*http.Request)) bool {
  163. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  164. io.WriteString(w, r.RemoteAddr)
  165. }, optOnlyServer, func(c net.Conn, st http.ConnState) {
  166. t.Logf("conn %v is now state %v", c.RemoteAddr(), st)
  167. })
  168. defer st.Close()
  169. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  170. defer tr.CloseIdleConnections()
  171. get := func() string {
  172. req, err := http.NewRequest("GET", st.ts.URL, nil)
  173. if err != nil {
  174. t.Fatal(err)
  175. }
  176. modReq(req)
  177. res, err := tr.RoundTrip(req)
  178. if err != nil {
  179. t.Fatal(err)
  180. }
  181. defer res.Body.Close()
  182. slurp, err := ioutil.ReadAll(res.Body)
  183. if err != nil {
  184. t.Fatalf("Body read: %v", err)
  185. }
  186. addr := strings.TrimSpace(string(slurp))
  187. if addr == "" {
  188. t.Fatalf("didn't get an addr in response")
  189. }
  190. return addr
  191. }
  192. first := get()
  193. second := get()
  194. return first == second
  195. }
  196. func TestTransportReusesConns(t *testing.T) {
  197. if !onSameConn(t, func(*http.Request) {}) {
  198. t.Errorf("first and second responses were on different connections")
  199. }
  200. }
  201. func TestTransportReusesConn_RequestClose(t *testing.T) {
  202. if onSameConn(t, func(r *http.Request) { r.Close = true }) {
  203. t.Errorf("first and second responses were not on different connections")
  204. }
  205. }
  206. func TestTransportReusesConn_ConnClose(t *testing.T) {
  207. if onSameConn(t, func(r *http.Request) { r.Header.Set("Connection", "close") }) {
  208. t.Errorf("first and second responses were not on different connections")
  209. }
  210. }
  211. // Tests that the Transport only keeps one pending dial open per destination address.
  212. // https://golang.org/issue/13397
  213. func TestTransportGroupsPendingDials(t *testing.T) {
  214. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  215. io.WriteString(w, r.RemoteAddr)
  216. }, optOnlyServer)
  217. defer st.Close()
  218. tr := &Transport{
  219. TLSClientConfig: tlsConfigInsecure,
  220. }
  221. defer tr.CloseIdleConnections()
  222. var (
  223. mu sync.Mutex
  224. dials = map[string]int{}
  225. )
  226. var wg sync.WaitGroup
  227. for i := 0; i < 10; i++ {
  228. wg.Add(1)
  229. go func() {
  230. defer wg.Done()
  231. req, err := http.NewRequest("GET", st.ts.URL, nil)
  232. if err != nil {
  233. t.Error(err)
  234. return
  235. }
  236. res, err := tr.RoundTrip(req)
  237. if err != nil {
  238. t.Error(err)
  239. return
  240. }
  241. defer res.Body.Close()
  242. slurp, err := ioutil.ReadAll(res.Body)
  243. if err != nil {
  244. t.Errorf("Body read: %v", err)
  245. }
  246. addr := strings.TrimSpace(string(slurp))
  247. if addr == "" {
  248. t.Errorf("didn't get an addr in response")
  249. }
  250. mu.Lock()
  251. dials[addr]++
  252. mu.Unlock()
  253. }()
  254. }
  255. wg.Wait()
  256. if len(dials) != 1 {
  257. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  258. }
  259. tr.CloseIdleConnections()
  260. if err := retry(50, 10*time.Millisecond, func() error {
  261. cp, ok := tr.connPool().(*clientConnPool)
  262. if !ok {
  263. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  264. }
  265. cp.mu.Lock()
  266. defer cp.mu.Unlock()
  267. if len(cp.dialing) != 0 {
  268. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  269. }
  270. if len(cp.conns) != 0 {
  271. return fmt.Errorf("conns = %v; want empty", cp.conns)
  272. }
  273. if len(cp.keys) != 0 {
  274. return fmt.Errorf("keys = %v; want empty", cp.keys)
  275. }
  276. return nil
  277. }); err != nil {
  278. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  279. }
  280. }
  281. func retry(tries int, delay time.Duration, fn func() error) error {
  282. var err error
  283. for i := 0; i < tries; i++ {
  284. err = fn()
  285. if err == nil {
  286. return nil
  287. }
  288. time.Sleep(delay)
  289. }
  290. return err
  291. }
  292. func TestTransportAbortClosesPipes(t *testing.T) {
  293. shutdown := make(chan struct{})
  294. st := newServerTester(t,
  295. func(w http.ResponseWriter, r *http.Request) {
  296. w.(http.Flusher).Flush()
  297. <-shutdown
  298. },
  299. optOnlyServer,
  300. )
  301. defer st.Close()
  302. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  303. done := make(chan struct{})
  304. requestMade := make(chan struct{})
  305. go func() {
  306. defer close(done)
  307. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  308. req, err := http.NewRequest("GET", st.ts.URL, nil)
  309. if err != nil {
  310. t.Fatal(err)
  311. }
  312. res, err := tr.RoundTrip(req)
  313. if err != nil {
  314. t.Fatal(err)
  315. }
  316. defer res.Body.Close()
  317. close(requestMade)
  318. _, err = ioutil.ReadAll(res.Body)
  319. if err == nil {
  320. t.Error("expected error from res.Body.Read")
  321. }
  322. }()
  323. <-requestMade
  324. // Now force the serve loop to end, via closing the connection.
  325. st.closeConn()
  326. // deadlock? that's a bug.
  327. select {
  328. case <-done:
  329. case <-time.After(3 * time.Second):
  330. t.Fatal("timeout")
  331. }
  332. }
  333. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  334. // could be a table-driven test with extra goodies.
  335. func TestTransportPath(t *testing.T) {
  336. gotc := make(chan *url.URL, 1)
  337. st := newServerTester(t,
  338. func(w http.ResponseWriter, r *http.Request) {
  339. gotc <- r.URL
  340. },
  341. optOnlyServer,
  342. )
  343. defer st.Close()
  344. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  345. defer tr.CloseIdleConnections()
  346. const (
  347. path = "/testpath"
  348. query = "q=1"
  349. )
  350. surl := st.ts.URL + path + "?" + query
  351. req, err := http.NewRequest("POST", surl, nil)
  352. if err != nil {
  353. t.Fatal(err)
  354. }
  355. c := &http.Client{Transport: tr}
  356. res, err := c.Do(req)
  357. if err != nil {
  358. t.Fatal(err)
  359. }
  360. defer res.Body.Close()
  361. got := <-gotc
  362. if got.Path != path {
  363. t.Errorf("Read Path = %q; want %q", got.Path, path)
  364. }
  365. if got.RawQuery != query {
  366. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  367. }
  368. }
  369. func randString(n int) string {
  370. rnd := rand.New(rand.NewSource(int64(n)))
  371. b := make([]byte, n)
  372. for i := range b {
  373. b[i] = byte(rnd.Intn(256))
  374. }
  375. return string(b)
  376. }
  377. type panicReader struct{}
  378. func (panicReader) Read([]byte) (int, error) { panic("unexpected Read") }
  379. func (panicReader) Close() error { panic("unexpected Close") }
  380. func TestActualContentLength(t *testing.T) {
  381. tests := []struct {
  382. req *http.Request
  383. want int64
  384. }{
  385. // Verify we don't read from Body:
  386. 0: {
  387. req: &http.Request{Body: panicReader{}},
  388. want: -1,
  389. },
  390. // nil Body means 0, regardless of ContentLength:
  391. 1: {
  392. req: &http.Request{Body: nil, ContentLength: 5},
  393. want: 0,
  394. },
  395. // ContentLength is used if set.
  396. 2: {
  397. req: &http.Request{Body: panicReader{}, ContentLength: 5},
  398. want: 5,
  399. },
  400. // http.NoBody means 0, not -1.
  401. 3: {
  402. req: &http.Request{Body: http.NoBody},
  403. want: 0,
  404. },
  405. }
  406. for i, tt := range tests {
  407. got := actualContentLength(tt.req)
  408. if got != tt.want {
  409. t.Errorf("test[%d]: got %d; want %d", i, got, tt.want)
  410. }
  411. }
  412. }
  413. func TestTransportBody(t *testing.T) {
  414. bodyTests := []struct {
  415. body string
  416. noContentLen bool
  417. }{
  418. {body: "some message"},
  419. {body: "some message", noContentLen: true},
  420. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  421. {body: strings.Repeat("a", 1<<20)},
  422. {body: randString(16<<10 - 1)},
  423. {body: randString(16 << 10)},
  424. {body: randString(16<<10 + 1)},
  425. {body: randString(512<<10 - 1)},
  426. {body: randString(512 << 10)},
  427. {body: randString(512<<10 + 1)},
  428. {body: randString(1<<20 - 1)},
  429. {body: randString(1 << 20)},
  430. {body: randString(1<<20 + 2)},
  431. }
  432. type reqInfo struct {
  433. req *http.Request
  434. slurp []byte
  435. err error
  436. }
  437. gotc := make(chan reqInfo, 1)
  438. st := newServerTester(t,
  439. func(w http.ResponseWriter, r *http.Request) {
  440. slurp, err := ioutil.ReadAll(r.Body)
  441. if err != nil {
  442. gotc <- reqInfo{err: err}
  443. } else {
  444. gotc <- reqInfo{req: r, slurp: slurp}
  445. }
  446. },
  447. optOnlyServer,
  448. )
  449. defer st.Close()
  450. for i, tt := range bodyTests {
  451. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  452. defer tr.CloseIdleConnections()
  453. var body io.Reader = strings.NewReader(tt.body)
  454. if tt.noContentLen {
  455. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  456. }
  457. req, err := http.NewRequest("POST", st.ts.URL, body)
  458. if err != nil {
  459. t.Fatalf("#%d: %v", i, err)
  460. }
  461. c := &http.Client{Transport: tr}
  462. res, err := c.Do(req)
  463. if err != nil {
  464. t.Fatalf("#%d: %v", i, err)
  465. }
  466. defer res.Body.Close()
  467. ri := <-gotc
  468. if ri.err != nil {
  469. t.Errorf("#%d: read error: %v", i, ri.err)
  470. continue
  471. }
  472. if got := string(ri.slurp); got != tt.body {
  473. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  474. }
  475. wantLen := int64(len(tt.body))
  476. if tt.noContentLen && tt.body != "" {
  477. wantLen = -1
  478. }
  479. if ri.req.ContentLength != wantLen {
  480. t.Errorf("#%d. handler got ContentLength = %v; want %v", i, ri.req.ContentLength, wantLen)
  481. }
  482. }
  483. }
  484. func shortString(v string) string {
  485. const maxLen = 100
  486. if len(v) <= maxLen {
  487. return v
  488. }
  489. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  490. }
  491. func TestTransportDialTLS(t *testing.T) {
  492. var mu sync.Mutex // guards following
  493. var gotReq, didDial bool
  494. ts := newServerTester(t,
  495. func(w http.ResponseWriter, r *http.Request) {
  496. mu.Lock()
  497. gotReq = true
  498. mu.Unlock()
  499. },
  500. optOnlyServer,
  501. )
  502. defer ts.Close()
  503. tr := &Transport{
  504. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  505. mu.Lock()
  506. didDial = true
  507. mu.Unlock()
  508. cfg.InsecureSkipVerify = true
  509. c, err := tls.Dial(netw, addr, cfg)
  510. if err != nil {
  511. return nil, err
  512. }
  513. return c, c.Handshake()
  514. },
  515. }
  516. defer tr.CloseIdleConnections()
  517. client := &http.Client{Transport: tr}
  518. res, err := client.Get(ts.ts.URL)
  519. if err != nil {
  520. t.Fatal(err)
  521. }
  522. res.Body.Close()
  523. mu.Lock()
  524. if !gotReq {
  525. t.Error("didn't get request")
  526. }
  527. if !didDial {
  528. t.Error("didn't use dial hook")
  529. }
  530. }
  531. func TestConfigureTransport(t *testing.T) {
  532. t1 := &http.Transport{}
  533. err := ConfigureTransport(t1)
  534. if err != nil {
  535. t.Fatal(err)
  536. }
  537. if got := fmt.Sprintf("%#v", t1); !strings.Contains(got, `"h2"`) {
  538. // Laziness, to avoid buildtags.
  539. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  540. }
  541. wantNextProtos := []string{"h2", "http/1.1"}
  542. if t1.TLSClientConfig == nil {
  543. t.Errorf("nil t1.TLSClientConfig")
  544. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  545. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  546. }
  547. if err := ConfigureTransport(t1); err == nil {
  548. t.Error("unexpected success on second call to ConfigureTransport")
  549. }
  550. // And does it work?
  551. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  552. io.WriteString(w, r.Proto)
  553. }, optOnlyServer)
  554. defer st.Close()
  555. t1.TLSClientConfig.InsecureSkipVerify = true
  556. c := &http.Client{Transport: t1}
  557. res, err := c.Get(st.ts.URL)
  558. if err != nil {
  559. t.Fatal(err)
  560. }
  561. slurp, err := ioutil.ReadAll(res.Body)
  562. if err != nil {
  563. t.Fatal(err)
  564. }
  565. if got, want := string(slurp), "HTTP/2.0"; got != want {
  566. t.Errorf("body = %q; want %q", got, want)
  567. }
  568. }
  569. type capitalizeReader struct {
  570. r io.Reader
  571. }
  572. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  573. n, err = cr.r.Read(p)
  574. for i, b := range p[:n] {
  575. if b >= 'a' && b <= 'z' {
  576. p[i] = b - ('a' - 'A')
  577. }
  578. }
  579. return
  580. }
  581. type flushWriter struct {
  582. w io.Writer
  583. }
  584. func (fw flushWriter) Write(p []byte) (n int, err error) {
  585. n, err = fw.w.Write(p)
  586. if f, ok := fw.w.(http.Flusher); ok {
  587. f.Flush()
  588. }
  589. return
  590. }
  591. type clientTester struct {
  592. t *testing.T
  593. tr *Transport
  594. sc, cc net.Conn // server and client conn
  595. fr *Framer // server's framer
  596. client func() error
  597. server func() error
  598. }
  599. func newClientTester(t *testing.T) *clientTester {
  600. var dialOnce struct {
  601. sync.Mutex
  602. dialed bool
  603. }
  604. ct := &clientTester{
  605. t: t,
  606. }
  607. ct.tr = &Transport{
  608. TLSClientConfig: tlsConfigInsecure,
  609. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  610. dialOnce.Lock()
  611. defer dialOnce.Unlock()
  612. if dialOnce.dialed {
  613. return nil, errors.New("only one dial allowed in test mode")
  614. }
  615. dialOnce.dialed = true
  616. return ct.cc, nil
  617. },
  618. }
  619. ln := newLocalListener(t)
  620. cc, err := net.Dial("tcp", ln.Addr().String())
  621. if err != nil {
  622. t.Fatal(err)
  623. }
  624. sc, err := ln.Accept()
  625. if err != nil {
  626. t.Fatal(err)
  627. }
  628. ln.Close()
  629. ct.cc = cc
  630. ct.sc = sc
  631. ct.fr = NewFramer(sc, sc)
  632. return ct
  633. }
  634. func newLocalListener(t *testing.T) net.Listener {
  635. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  636. if err == nil {
  637. return ln
  638. }
  639. ln, err = net.Listen("tcp6", "[::1]:0")
  640. if err != nil {
  641. t.Fatal(err)
  642. }
  643. return ln
  644. }
  645. func (ct *clientTester) greet(settings ...Setting) {
  646. buf := make([]byte, len(ClientPreface))
  647. _, err := io.ReadFull(ct.sc, buf)
  648. if err != nil {
  649. ct.t.Fatalf("reading client preface: %v", err)
  650. }
  651. f, err := ct.fr.ReadFrame()
  652. if err != nil {
  653. ct.t.Fatalf("Reading client settings frame: %v", err)
  654. }
  655. if sf, ok := f.(*SettingsFrame); !ok {
  656. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  657. _ = sf // stash it away?
  658. }
  659. if err := ct.fr.WriteSettings(settings...); err != nil {
  660. ct.t.Fatal(err)
  661. }
  662. if err := ct.fr.WriteSettingsAck(); err != nil {
  663. ct.t.Fatal(err)
  664. }
  665. }
  666. func (ct *clientTester) readNonSettingsFrame() (Frame, error) {
  667. for {
  668. f, err := ct.fr.ReadFrame()
  669. if err != nil {
  670. return nil, err
  671. }
  672. if _, ok := f.(*SettingsFrame); ok {
  673. continue
  674. }
  675. return f, nil
  676. }
  677. }
  678. func (ct *clientTester) cleanup() {
  679. ct.tr.CloseIdleConnections()
  680. }
  681. func (ct *clientTester) run() {
  682. errc := make(chan error, 2)
  683. ct.start("client", errc, ct.client)
  684. ct.start("server", errc, ct.server)
  685. defer ct.cleanup()
  686. for i := 0; i < 2; i++ {
  687. if err := <-errc; err != nil {
  688. ct.t.Error(err)
  689. return
  690. }
  691. }
  692. }
  693. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  694. go func() {
  695. finished := false
  696. var err error
  697. defer func() {
  698. if !finished {
  699. err = fmt.Errorf("%s goroutine didn't finish.", which)
  700. } else if err != nil {
  701. err = fmt.Errorf("%s: %v", which, err)
  702. }
  703. errc <- err
  704. }()
  705. err = fn()
  706. finished = true
  707. }()
  708. }
  709. func (ct *clientTester) readFrame() (Frame, error) {
  710. return readFrameTimeout(ct.fr, 2*time.Second)
  711. }
  712. func (ct *clientTester) firstHeaders() (*HeadersFrame, error) {
  713. for {
  714. f, err := ct.readFrame()
  715. if err != nil {
  716. return nil, fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  717. }
  718. switch f.(type) {
  719. case *WindowUpdateFrame, *SettingsFrame:
  720. continue
  721. }
  722. hf, ok := f.(*HeadersFrame)
  723. if !ok {
  724. return nil, fmt.Errorf("Got %T; want HeadersFrame", f)
  725. }
  726. return hf, nil
  727. }
  728. }
  729. type countingReader struct {
  730. n *int64
  731. }
  732. func (r countingReader) Read(p []byte) (n int, err error) {
  733. for i := range p {
  734. p[i] = byte(i)
  735. }
  736. atomic.AddInt64(r.n, int64(len(p)))
  737. return len(p), err
  738. }
  739. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  740. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  741. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  742. const bodySize = 10 << 20
  743. clientDone := make(chan struct{})
  744. ct := newClientTester(t)
  745. ct.client = func() error {
  746. defer ct.cc.(*net.TCPConn).CloseWrite()
  747. defer close(clientDone)
  748. var n int64 // atomic
  749. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  750. if err != nil {
  751. return err
  752. }
  753. res, err := ct.tr.RoundTrip(req)
  754. if err != nil {
  755. return fmt.Errorf("RoundTrip: %v", err)
  756. }
  757. defer res.Body.Close()
  758. if res.StatusCode != status {
  759. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  760. }
  761. slurp, err := ioutil.ReadAll(res.Body)
  762. if err != nil {
  763. return fmt.Errorf("Slurp: %v", err)
  764. }
  765. if len(slurp) > 0 {
  766. return fmt.Errorf("unexpected body: %q", slurp)
  767. }
  768. if status == 200 {
  769. if got := atomic.LoadInt64(&n); got != bodySize {
  770. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  771. }
  772. } else {
  773. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  774. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  775. }
  776. }
  777. return nil
  778. }
  779. ct.server = func() error {
  780. ct.greet()
  781. var buf bytes.Buffer
  782. enc := hpack.NewEncoder(&buf)
  783. var dataRecv int64
  784. var closed bool
  785. for {
  786. f, err := ct.fr.ReadFrame()
  787. if err != nil {
  788. select {
  789. case <-clientDone:
  790. // If the client's done, it
  791. // will have reported any
  792. // errors on its side.
  793. return nil
  794. default:
  795. return err
  796. }
  797. }
  798. //println(fmt.Sprintf("server got frame: %v", f))
  799. switch f := f.(type) {
  800. case *WindowUpdateFrame, *SettingsFrame:
  801. case *HeadersFrame:
  802. if !f.HeadersEnded() {
  803. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  804. }
  805. if f.StreamEnded() {
  806. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  807. }
  808. case *DataFrame:
  809. dataLen := len(f.Data())
  810. if dataLen > 0 {
  811. if dataRecv == 0 {
  812. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  813. ct.fr.WriteHeaders(HeadersFrameParam{
  814. StreamID: f.StreamID,
  815. EndHeaders: true,
  816. EndStream: false,
  817. BlockFragment: buf.Bytes(),
  818. })
  819. }
  820. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  821. return err
  822. }
  823. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  824. return err
  825. }
  826. }
  827. dataRecv += int64(dataLen)
  828. if !closed && ((status != 200 && dataRecv > 0) ||
  829. (status == 200 && dataRecv == bodySize)) {
  830. closed = true
  831. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  832. return err
  833. }
  834. }
  835. default:
  836. return fmt.Errorf("Unexpected client frame %v", f)
  837. }
  838. }
  839. }
  840. ct.run()
  841. }
  842. // See golang.org/issue/13444
  843. func TestTransportFullDuplex(t *testing.T) {
  844. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  845. w.WriteHeader(200) // redundant but for clarity
  846. w.(http.Flusher).Flush()
  847. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  848. fmt.Fprintf(w, "bye.\n")
  849. }, optOnlyServer)
  850. defer st.Close()
  851. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  852. defer tr.CloseIdleConnections()
  853. c := &http.Client{Transport: tr}
  854. pr, pw := io.Pipe()
  855. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  856. if err != nil {
  857. t.Fatal(err)
  858. }
  859. req.ContentLength = -1
  860. res, err := c.Do(req)
  861. if err != nil {
  862. t.Fatal(err)
  863. }
  864. defer res.Body.Close()
  865. if res.StatusCode != 200 {
  866. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  867. }
  868. bs := bufio.NewScanner(res.Body)
  869. want := func(v string) {
  870. if !bs.Scan() {
  871. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  872. }
  873. }
  874. write := func(v string) {
  875. _, err := io.WriteString(pw, v)
  876. if err != nil {
  877. t.Fatalf("pipe write: %v", err)
  878. }
  879. }
  880. write("foo\n")
  881. want("FOO")
  882. write("bar\n")
  883. want("BAR")
  884. pw.Close()
  885. want("bye.")
  886. if err := bs.Err(); err != nil {
  887. t.Fatal(err)
  888. }
  889. }
  890. func TestTransportConnectRequest(t *testing.T) {
  891. gotc := make(chan *http.Request, 1)
  892. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  893. gotc <- r
  894. }, optOnlyServer)
  895. defer st.Close()
  896. u, err := url.Parse(st.ts.URL)
  897. if err != nil {
  898. t.Fatal(err)
  899. }
  900. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  901. defer tr.CloseIdleConnections()
  902. c := &http.Client{Transport: tr}
  903. tests := []struct {
  904. req *http.Request
  905. want string
  906. }{
  907. {
  908. req: &http.Request{
  909. Method: "CONNECT",
  910. Header: http.Header{},
  911. URL: u,
  912. },
  913. want: u.Host,
  914. },
  915. {
  916. req: &http.Request{
  917. Method: "CONNECT",
  918. Header: http.Header{},
  919. URL: u,
  920. Host: "example.com:123",
  921. },
  922. want: "example.com:123",
  923. },
  924. }
  925. for i, tt := range tests {
  926. res, err := c.Do(tt.req)
  927. if err != nil {
  928. t.Errorf("%d. RoundTrip = %v", i, err)
  929. continue
  930. }
  931. res.Body.Close()
  932. req := <-gotc
  933. if req.Method != "CONNECT" {
  934. t.Errorf("method = %q; want CONNECT", req.Method)
  935. }
  936. if req.Host != tt.want {
  937. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  938. }
  939. if req.URL.Host != tt.want {
  940. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  941. }
  942. }
  943. }
  944. type headerType int
  945. const (
  946. noHeader headerType = iota // omitted
  947. oneHeader
  948. splitHeader // broken into continuation on purpose
  949. )
  950. const (
  951. f0 = noHeader
  952. f1 = oneHeader
  953. f2 = splitHeader
  954. d0 = false
  955. d1 = true
  956. )
  957. // Test all 36 combinations of response frame orders:
  958. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  959. // Generated by http://play.golang.org/p/SScqYKJYXd
  960. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  961. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  962. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  963. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  964. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  965. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  966. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  967. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  968. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  969. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  970. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  971. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  972. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  973. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  974. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  975. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  976. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  977. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  978. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  979. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  980. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  981. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  982. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  983. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  984. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  985. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  986. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  987. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  988. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  989. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  990. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  991. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  992. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  993. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  994. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  995. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  996. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  997. const reqBody = "some request body"
  998. const resBody = "some response body"
  999. if resHeader == noHeader {
  1000. // TODO: test 100-continue followed by immediate
  1001. // server stream reset, without headers in the middle?
  1002. panic("invalid combination")
  1003. }
  1004. ct := newClientTester(t)
  1005. ct.client = func() error {
  1006. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  1007. if expect100Continue != noHeader {
  1008. req.Header.Set("Expect", "100-continue")
  1009. }
  1010. res, err := ct.tr.RoundTrip(req)
  1011. if err != nil {
  1012. return fmt.Errorf("RoundTrip: %v", err)
  1013. }
  1014. defer res.Body.Close()
  1015. if res.StatusCode != 200 {
  1016. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1017. }
  1018. slurp, err := ioutil.ReadAll(res.Body)
  1019. if err != nil {
  1020. return fmt.Errorf("Slurp: %v", err)
  1021. }
  1022. wantBody := resBody
  1023. if !withData {
  1024. wantBody = ""
  1025. }
  1026. if string(slurp) != wantBody {
  1027. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  1028. }
  1029. if trailers == noHeader {
  1030. if len(res.Trailer) > 0 {
  1031. t.Errorf("Trailer = %v; want none", res.Trailer)
  1032. }
  1033. } else {
  1034. want := http.Header{"Some-Trailer": {"some-value"}}
  1035. if !reflect.DeepEqual(res.Trailer, want) {
  1036. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  1037. }
  1038. }
  1039. return nil
  1040. }
  1041. ct.server = func() error {
  1042. ct.greet()
  1043. var buf bytes.Buffer
  1044. enc := hpack.NewEncoder(&buf)
  1045. for {
  1046. f, err := ct.fr.ReadFrame()
  1047. if err != nil {
  1048. return err
  1049. }
  1050. endStream := false
  1051. send := func(mode headerType) {
  1052. hbf := buf.Bytes()
  1053. switch mode {
  1054. case oneHeader:
  1055. ct.fr.WriteHeaders(HeadersFrameParam{
  1056. StreamID: f.Header().StreamID,
  1057. EndHeaders: true,
  1058. EndStream: endStream,
  1059. BlockFragment: hbf,
  1060. })
  1061. case splitHeader:
  1062. if len(hbf) < 2 {
  1063. panic("too small")
  1064. }
  1065. ct.fr.WriteHeaders(HeadersFrameParam{
  1066. StreamID: f.Header().StreamID,
  1067. EndHeaders: false,
  1068. EndStream: endStream,
  1069. BlockFragment: hbf[:1],
  1070. })
  1071. ct.fr.WriteContinuation(f.Header().StreamID, true, hbf[1:])
  1072. default:
  1073. panic("bogus mode")
  1074. }
  1075. }
  1076. switch f := f.(type) {
  1077. case *WindowUpdateFrame, *SettingsFrame:
  1078. case *DataFrame:
  1079. if !f.StreamEnded() {
  1080. // No need to send flow control tokens. The test request body is tiny.
  1081. continue
  1082. }
  1083. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1084. {
  1085. buf.Reset()
  1086. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1087. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  1088. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  1089. if trailers != noHeader {
  1090. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  1091. }
  1092. endStream = withData == false && trailers == noHeader
  1093. send(resHeader)
  1094. }
  1095. if withData {
  1096. endStream = trailers == noHeader
  1097. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  1098. }
  1099. if trailers != noHeader {
  1100. endStream = true
  1101. buf.Reset()
  1102. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  1103. send(trailers)
  1104. }
  1105. if endStream {
  1106. return nil
  1107. }
  1108. case *HeadersFrame:
  1109. if expect100Continue != noHeader {
  1110. buf.Reset()
  1111. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  1112. send(expect100Continue)
  1113. }
  1114. }
  1115. }
  1116. }
  1117. ct.run()
  1118. }
  1119. // Issue 26189, Issue 17739: ignore unknown 1xx responses
  1120. func TestTransportUnknown1xx(t *testing.T) {
  1121. var buf bytes.Buffer
  1122. defer func() { got1xxFuncForTests = nil }()
  1123. got1xxFuncForTests = func(code int, header textproto.MIMEHeader) error {
  1124. fmt.Fprintf(&buf, "code=%d header=%v\n", code, header)
  1125. return nil
  1126. }
  1127. ct := newClientTester(t)
  1128. ct.client = func() error {
  1129. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1130. res, err := ct.tr.RoundTrip(req)
  1131. if err != nil {
  1132. return fmt.Errorf("RoundTrip: %v", err)
  1133. }
  1134. defer res.Body.Close()
  1135. if res.StatusCode != 204 {
  1136. return fmt.Errorf("status code = %v; want 204", res.StatusCode)
  1137. }
  1138. want := `code=110 header=map[Foo-Bar:[110]]
  1139. code=111 header=map[Foo-Bar:[111]]
  1140. code=112 header=map[Foo-Bar:[112]]
  1141. code=113 header=map[Foo-Bar:[113]]
  1142. code=114 header=map[Foo-Bar:[114]]
  1143. `
  1144. if got := buf.String(); got != want {
  1145. t.Errorf("Got trace:\n%s\nWant:\n%s", got, want)
  1146. }
  1147. return nil
  1148. }
  1149. ct.server = func() error {
  1150. ct.greet()
  1151. var buf bytes.Buffer
  1152. enc := hpack.NewEncoder(&buf)
  1153. for {
  1154. f, err := ct.fr.ReadFrame()
  1155. if err != nil {
  1156. return err
  1157. }
  1158. switch f := f.(type) {
  1159. case *WindowUpdateFrame, *SettingsFrame:
  1160. case *HeadersFrame:
  1161. for i := 110; i <= 114; i++ {
  1162. buf.Reset()
  1163. enc.WriteField(hpack.HeaderField{Name: ":status", Value: fmt.Sprint(i)})
  1164. enc.WriteField(hpack.HeaderField{Name: "foo-bar", Value: fmt.Sprint(i)})
  1165. ct.fr.WriteHeaders(HeadersFrameParam{
  1166. StreamID: f.StreamID,
  1167. EndHeaders: true,
  1168. EndStream: false,
  1169. BlockFragment: buf.Bytes(),
  1170. })
  1171. }
  1172. buf.Reset()
  1173. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  1174. ct.fr.WriteHeaders(HeadersFrameParam{
  1175. StreamID: f.StreamID,
  1176. EndHeaders: true,
  1177. EndStream: false,
  1178. BlockFragment: buf.Bytes(),
  1179. })
  1180. return nil
  1181. }
  1182. }
  1183. }
  1184. ct.run()
  1185. }
  1186. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  1187. ct := newClientTester(t)
  1188. ct.client = func() error {
  1189. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1190. res, err := ct.tr.RoundTrip(req)
  1191. if err != nil {
  1192. return fmt.Errorf("RoundTrip: %v", err)
  1193. }
  1194. defer res.Body.Close()
  1195. if res.StatusCode != 200 {
  1196. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1197. }
  1198. slurp, err := ioutil.ReadAll(res.Body)
  1199. if err != nil {
  1200. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  1201. }
  1202. if len(slurp) > 0 {
  1203. return fmt.Errorf("body = %q; want nothing", slurp)
  1204. }
  1205. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  1206. return fmt.Errorf("expected Some-Trailer")
  1207. }
  1208. return nil
  1209. }
  1210. ct.server = func() error {
  1211. ct.greet()
  1212. var n int
  1213. var hf *HeadersFrame
  1214. for hf == nil && n < 10 {
  1215. f, err := ct.fr.ReadFrame()
  1216. if err != nil {
  1217. return err
  1218. }
  1219. hf, _ = f.(*HeadersFrame)
  1220. n++
  1221. }
  1222. var buf bytes.Buffer
  1223. enc := hpack.NewEncoder(&buf)
  1224. // send headers without Trailer header
  1225. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1226. ct.fr.WriteHeaders(HeadersFrameParam{
  1227. StreamID: hf.StreamID,
  1228. EndHeaders: true,
  1229. EndStream: false,
  1230. BlockFragment: buf.Bytes(),
  1231. })
  1232. // send trailers
  1233. buf.Reset()
  1234. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  1235. ct.fr.WriteHeaders(HeadersFrameParam{
  1236. StreamID: hf.StreamID,
  1237. EndHeaders: true,
  1238. EndStream: true,
  1239. BlockFragment: buf.Bytes(),
  1240. })
  1241. return nil
  1242. }
  1243. ct.run()
  1244. }
  1245. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1246. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1247. }
  1248. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1249. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1250. }
  1251. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1252. testInvalidTrailer(t, trailers, pseudoHeaderError(":colon"), func(enc *hpack.Encoder) {
  1253. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1254. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1255. })
  1256. }
  1257. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1258. testTransportInvalidTrailer_Capital(t, oneHeader)
  1259. }
  1260. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1261. testTransportInvalidTrailer_Capital(t, splitHeader)
  1262. }
  1263. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1264. testInvalidTrailer(t, trailers, headerFieldNameError("Capital"), func(enc *hpack.Encoder) {
  1265. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1266. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1267. })
  1268. }
  1269. func TestTransportInvalidTrailer_EmptyFieldName(t *testing.T) {
  1270. testInvalidTrailer(t, oneHeader, headerFieldNameError(""), func(enc *hpack.Encoder) {
  1271. enc.WriteField(hpack.HeaderField{Name: "", Value: "bad"})
  1272. })
  1273. }
  1274. func TestTransportInvalidTrailer_BinaryFieldValue(t *testing.T) {
  1275. testInvalidTrailer(t, oneHeader, headerFieldValueError("has\nnewline"), func(enc *hpack.Encoder) {
  1276. enc.WriteField(hpack.HeaderField{Name: "x", Value: "has\nnewline"})
  1277. })
  1278. }
  1279. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1280. ct := newClientTester(t)
  1281. ct.client = func() error {
  1282. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1283. res, err := ct.tr.RoundTrip(req)
  1284. if err != nil {
  1285. return fmt.Errorf("RoundTrip: %v", err)
  1286. }
  1287. defer res.Body.Close()
  1288. if res.StatusCode != 200 {
  1289. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1290. }
  1291. slurp, err := ioutil.ReadAll(res.Body)
  1292. se, ok := err.(StreamError)
  1293. if !ok || se.Cause != wantErr {
  1294. return fmt.Errorf("res.Body ReadAll error = %q, %#v; want StreamError with cause %T, %#v", slurp, err, wantErr, wantErr)
  1295. }
  1296. if len(slurp) > 0 {
  1297. return fmt.Errorf("body = %q; want nothing", slurp)
  1298. }
  1299. return nil
  1300. }
  1301. ct.server = func() error {
  1302. ct.greet()
  1303. var buf bytes.Buffer
  1304. enc := hpack.NewEncoder(&buf)
  1305. for {
  1306. f, err := ct.fr.ReadFrame()
  1307. if err != nil {
  1308. return err
  1309. }
  1310. switch f := f.(type) {
  1311. case *HeadersFrame:
  1312. var endStream bool
  1313. send := func(mode headerType) {
  1314. hbf := buf.Bytes()
  1315. switch mode {
  1316. case oneHeader:
  1317. ct.fr.WriteHeaders(HeadersFrameParam{
  1318. StreamID: f.StreamID,
  1319. EndHeaders: true,
  1320. EndStream: endStream,
  1321. BlockFragment: hbf,
  1322. })
  1323. case splitHeader:
  1324. if len(hbf) < 2 {
  1325. panic("too small")
  1326. }
  1327. ct.fr.WriteHeaders(HeadersFrameParam{
  1328. StreamID: f.StreamID,
  1329. EndHeaders: false,
  1330. EndStream: endStream,
  1331. BlockFragment: hbf[:1],
  1332. })
  1333. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1334. default:
  1335. panic("bogus mode")
  1336. }
  1337. }
  1338. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1339. {
  1340. buf.Reset()
  1341. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1342. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1343. endStream = false
  1344. send(oneHeader)
  1345. }
  1346. // Trailers:
  1347. {
  1348. endStream = true
  1349. buf.Reset()
  1350. writeTrailer(enc)
  1351. send(trailers)
  1352. }
  1353. return nil
  1354. }
  1355. }
  1356. }
  1357. ct.run()
  1358. }
  1359. // headerListSize returns the HTTP2 header list size of h.
  1360. // http://httpwg.org/specs/rfc7540.html#SETTINGS_MAX_HEADER_LIST_SIZE
  1361. // http://httpwg.org/specs/rfc7540.html#MaxHeaderBlock
  1362. func headerListSize(h http.Header) (size uint32) {
  1363. for k, vv := range h {
  1364. for _, v := range vv {
  1365. hf := hpack.HeaderField{Name: k, Value: v}
  1366. size += hf.Size()
  1367. }
  1368. }
  1369. return size
  1370. }
  1371. // padHeaders adds data to an http.Header until headerListSize(h) ==
  1372. // limit. Due to the way header list sizes are calculated, padHeaders
  1373. // cannot add fewer than len("Pad-Headers") + 32 bytes to h, and will
  1374. // call t.Fatal if asked to do so. PadHeaders first reserves enough
  1375. // space for an empty "Pad-Headers" key, then adds as many copies of
  1376. // filler as possible. Any remaining bytes necessary to push the
  1377. // header list size up to limit are added to h["Pad-Headers"].
  1378. func padHeaders(t *testing.T, h http.Header, limit uint64, filler string) {
  1379. if limit > 0xffffffff {
  1380. t.Fatalf("padHeaders: refusing to pad to more than 2^32-1 bytes. limit = %v", limit)
  1381. }
  1382. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1383. minPadding := uint64(hf.Size())
  1384. size := uint64(headerListSize(h))
  1385. minlimit := size + minPadding
  1386. if limit < minlimit {
  1387. t.Fatalf("padHeaders: limit %v < %v", limit, minlimit)
  1388. }
  1389. // Use a fixed-width format for name so that fieldSize
  1390. // remains constant.
  1391. nameFmt := "Pad-Headers-%06d"
  1392. hf = hpack.HeaderField{Name: fmt.Sprintf(nameFmt, 1), Value: filler}
  1393. fieldSize := uint64(hf.Size())
  1394. // Add as many complete filler values as possible, leaving
  1395. // room for at least one empty "Pad-Headers" key.
  1396. limit = limit - minPadding
  1397. for i := 0; size+fieldSize < limit; i++ {
  1398. name := fmt.Sprintf(nameFmt, i)
  1399. h.Add(name, filler)
  1400. size += fieldSize
  1401. }
  1402. // Add enough bytes to reach limit.
  1403. remain := limit - size
  1404. lastValue := strings.Repeat("*", int(remain))
  1405. h.Add("Pad-Headers", lastValue)
  1406. }
  1407. func TestPadHeaders(t *testing.T) {
  1408. check := func(h http.Header, limit uint32, fillerLen int) {
  1409. if h == nil {
  1410. h = make(http.Header)
  1411. }
  1412. filler := strings.Repeat("f", fillerLen)
  1413. padHeaders(t, h, uint64(limit), filler)
  1414. gotSize := headerListSize(h)
  1415. if gotSize != limit {
  1416. t.Errorf("Got size = %v; want %v", gotSize, limit)
  1417. }
  1418. }
  1419. // Try all possible combinations for small fillerLen and limit.
  1420. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1421. minLimit := hf.Size()
  1422. for limit := minLimit; limit <= 128; limit++ {
  1423. for fillerLen := 0; uint32(fillerLen) <= limit; fillerLen++ {
  1424. check(nil, limit, fillerLen)
  1425. }
  1426. }
  1427. // Try a few tests with larger limits, plus cumulative
  1428. // tests. Since these tests are cumulative, tests[i+1].limit
  1429. // must be >= tests[i].limit + minLimit. See the comment on
  1430. // padHeaders for more info on why the limit arg has this
  1431. // restriction.
  1432. tests := []struct {
  1433. fillerLen int
  1434. limit uint32
  1435. }{
  1436. {
  1437. fillerLen: 64,
  1438. limit: 1024,
  1439. },
  1440. {
  1441. fillerLen: 1024,
  1442. limit: 1286,
  1443. },
  1444. {
  1445. fillerLen: 256,
  1446. limit: 2048,
  1447. },
  1448. {
  1449. fillerLen: 1024,
  1450. limit: 10 * 1024,
  1451. },
  1452. {
  1453. fillerLen: 1023,
  1454. limit: 11 * 1024,
  1455. },
  1456. }
  1457. h := make(http.Header)
  1458. for _, tc := range tests {
  1459. check(nil, tc.limit, tc.fillerLen)
  1460. check(h, tc.limit, tc.fillerLen)
  1461. }
  1462. }
  1463. func TestTransportChecksRequestHeaderListSize(t *testing.T) {
  1464. st := newServerTester(t,
  1465. func(w http.ResponseWriter, r *http.Request) {
  1466. // Consume body & force client to send
  1467. // trailers before writing response.
  1468. // ioutil.ReadAll returns non-nil err for
  1469. // requests that attempt to send greater than
  1470. // maxHeaderListSize bytes of trailers, since
  1471. // those requests generate a stream reset.
  1472. ioutil.ReadAll(r.Body)
  1473. r.Body.Close()
  1474. },
  1475. func(ts *httptest.Server) {
  1476. ts.Config.MaxHeaderBytes = 16 << 10
  1477. },
  1478. optOnlyServer,
  1479. optQuiet,
  1480. )
  1481. defer st.Close()
  1482. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1483. defer tr.CloseIdleConnections()
  1484. checkRoundTrip := func(req *http.Request, wantErr error, desc string) {
  1485. res, err := tr.RoundTrip(req)
  1486. if err != wantErr {
  1487. if res != nil {
  1488. res.Body.Close()
  1489. }
  1490. t.Errorf("%v: RoundTrip err = %v; want %v", desc, err, wantErr)
  1491. return
  1492. }
  1493. if err == nil {
  1494. if res == nil {
  1495. t.Errorf("%v: response nil; want non-nil.", desc)
  1496. return
  1497. }
  1498. defer res.Body.Close()
  1499. if res.StatusCode != http.StatusOK {
  1500. t.Errorf("%v: response status = %v; want %v", desc, res.StatusCode, http.StatusOK)
  1501. }
  1502. return
  1503. }
  1504. if res != nil {
  1505. t.Errorf("%v: RoundTrip err = %v but response non-nil", desc, err)
  1506. }
  1507. }
  1508. headerListSizeForRequest := func(req *http.Request) (size uint64) {
  1509. contentLen := actualContentLength(req)
  1510. trailers, err := commaSeparatedTrailers(req)
  1511. if err != nil {
  1512. t.Fatalf("headerListSizeForRequest: %v", err)
  1513. }
  1514. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  1515. cc.henc = hpack.NewEncoder(&cc.hbuf)
  1516. cc.mu.Lock()
  1517. hdrs, err := cc.encodeHeaders(req, true, trailers, contentLen)
  1518. cc.mu.Unlock()
  1519. if err != nil {
  1520. t.Fatalf("headerListSizeForRequest: %v", err)
  1521. }
  1522. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(hf hpack.HeaderField) {
  1523. size += uint64(hf.Size())
  1524. })
  1525. if len(hdrs) > 0 {
  1526. if _, err := hpackDec.Write(hdrs); err != nil {
  1527. t.Fatalf("headerListSizeForRequest: %v", err)
  1528. }
  1529. }
  1530. return size
  1531. }
  1532. // Create a new Request for each test, rather than reusing the
  1533. // same Request, to avoid a race when modifying req.Headers.
  1534. // See https://github.com/golang/go/issues/21316
  1535. newRequest := func() *http.Request {
  1536. // Body must be non-nil to enable writing trailers.
  1537. body := strings.NewReader("hello")
  1538. req, err := http.NewRequest("POST", st.ts.URL, body)
  1539. if err != nil {
  1540. t.Fatalf("newRequest: NewRequest: %v", err)
  1541. }
  1542. return req
  1543. }
  1544. // Make an arbitrary request to ensure we get the server's
  1545. // settings frame and initialize peerMaxHeaderListSize.
  1546. req := newRequest()
  1547. checkRoundTrip(req, nil, "Initial request")
  1548. // Get the ClientConn associated with the request and validate
  1549. // peerMaxHeaderListSize.
  1550. addr := authorityAddr(req.URL.Scheme, req.URL.Host)
  1551. cc, err := tr.connPool().GetClientConn(req, addr)
  1552. if err != nil {
  1553. t.Fatalf("GetClientConn: %v", err)
  1554. }
  1555. cc.mu.Lock()
  1556. peerSize := cc.peerMaxHeaderListSize
  1557. cc.mu.Unlock()
  1558. st.scMu.Lock()
  1559. wantSize := uint64(st.sc.maxHeaderListSize())
  1560. st.scMu.Unlock()
  1561. if peerSize != wantSize {
  1562. t.Errorf("peerMaxHeaderListSize = %v; want %v", peerSize, wantSize)
  1563. }
  1564. // Sanity check peerSize. (*serverConn) maxHeaderListSize adds
  1565. // 320 bytes of padding.
  1566. wantHeaderBytes := uint64(st.ts.Config.MaxHeaderBytes) + 320
  1567. if peerSize != wantHeaderBytes {
  1568. t.Errorf("peerMaxHeaderListSize = %v; want %v.", peerSize, wantHeaderBytes)
  1569. }
  1570. // Pad headers & trailers, but stay under peerSize.
  1571. req = newRequest()
  1572. req.Header = make(http.Header)
  1573. req.Trailer = make(http.Header)
  1574. filler := strings.Repeat("*", 1024)
  1575. padHeaders(t, req.Trailer, peerSize, filler)
  1576. // cc.encodeHeaders adds some default headers to the request,
  1577. // so we need to leave room for those.
  1578. defaultBytes := headerListSizeForRequest(req)
  1579. padHeaders(t, req.Header, peerSize-defaultBytes, filler)
  1580. checkRoundTrip(req, nil, "Headers & Trailers under limit")
  1581. // Add enough header bytes to push us over peerSize.
  1582. req = newRequest()
  1583. req.Header = make(http.Header)
  1584. padHeaders(t, req.Header, peerSize, filler)
  1585. checkRoundTrip(req, errRequestHeaderListSize, "Headers over limit")
  1586. // Push trailers over the limit.
  1587. req = newRequest()
  1588. req.Trailer = make(http.Header)
  1589. padHeaders(t, req.Trailer, peerSize+1, filler)
  1590. checkRoundTrip(req, errRequestHeaderListSize, "Trailers over limit")
  1591. // Send headers with a single large value.
  1592. req = newRequest()
  1593. filler = strings.Repeat("*", int(peerSize))
  1594. req.Header = make(http.Header)
  1595. req.Header.Set("Big", filler)
  1596. checkRoundTrip(req, errRequestHeaderListSize, "Single large header")
  1597. // Send trailers with a single large value.
  1598. req = newRequest()
  1599. req.Trailer = make(http.Header)
  1600. req.Trailer.Set("Big", filler)
  1601. checkRoundTrip(req, errRequestHeaderListSize, "Single large trailer")
  1602. }
  1603. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1604. ct := newClientTester(t)
  1605. ct.client = func() error {
  1606. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1607. res, err := ct.tr.RoundTrip(req)
  1608. if err != errResponseHeaderListSize {
  1609. if res != nil {
  1610. res.Body.Close()
  1611. }
  1612. size := int64(0)
  1613. for k, vv := range res.Header {
  1614. for _, v := range vv {
  1615. size += int64(len(k)) + int64(len(v)) + 32
  1616. }
  1617. }
  1618. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1619. }
  1620. return nil
  1621. }
  1622. ct.server = func() error {
  1623. ct.greet()
  1624. var buf bytes.Buffer
  1625. enc := hpack.NewEncoder(&buf)
  1626. for {
  1627. f, err := ct.fr.ReadFrame()
  1628. if err != nil {
  1629. return err
  1630. }
  1631. switch f := f.(type) {
  1632. case *HeadersFrame:
  1633. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1634. large := strings.Repeat("a", 1<<10)
  1635. for i := 0; i < 5042; i++ {
  1636. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1637. }
  1638. if size, want := buf.Len(), 6329; size != want {
  1639. // Note: this number might change if
  1640. // our hpack implementation
  1641. // changes. That's fine. This is
  1642. // just a sanity check that our
  1643. // response can fit in a single
  1644. // header block fragment frame.
  1645. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1646. }
  1647. ct.fr.WriteHeaders(HeadersFrameParam{
  1648. StreamID: f.StreamID,
  1649. EndHeaders: true,
  1650. EndStream: true,
  1651. BlockFragment: buf.Bytes(),
  1652. })
  1653. return nil
  1654. }
  1655. }
  1656. }
  1657. ct.run()
  1658. }
  1659. // Test that the Transport returns a typed error from Response.Body.Read calls
  1660. // when the server sends an error. (here we use a panic, since that should generate
  1661. // a stream error, but others like cancel should be similar)
  1662. func TestTransportBodyReadErrorType(t *testing.T) {
  1663. doPanic := make(chan bool, 1)
  1664. st := newServerTester(t,
  1665. func(w http.ResponseWriter, r *http.Request) {
  1666. w.(http.Flusher).Flush() // force headers out
  1667. <-doPanic
  1668. panic("boom")
  1669. },
  1670. optOnlyServer,
  1671. optQuiet,
  1672. )
  1673. defer st.Close()
  1674. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1675. defer tr.CloseIdleConnections()
  1676. c := &http.Client{Transport: tr}
  1677. res, err := c.Get(st.ts.URL)
  1678. if err != nil {
  1679. t.Fatal(err)
  1680. }
  1681. defer res.Body.Close()
  1682. doPanic <- true
  1683. buf := make([]byte, 100)
  1684. n, err := res.Body.Read(buf)
  1685. want := StreamError{StreamID: 0x1, Code: 0x2}
  1686. if !reflect.DeepEqual(want, err) {
  1687. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1688. }
  1689. }
  1690. // golang.org/issue/13924
  1691. // This used to fail after many iterations, especially with -race:
  1692. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1693. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1694. var (
  1695. mu sync.Mutex
  1696. conn net.Conn // to close if set
  1697. )
  1698. st := newServerTester(t,
  1699. func(w http.ResponseWriter, r *http.Request) {
  1700. mu.Lock()
  1701. defer mu.Unlock()
  1702. if conn != nil {
  1703. conn.Close()
  1704. }
  1705. },
  1706. optOnlyServer,
  1707. )
  1708. defer st.Close()
  1709. tr := &Transport{
  1710. TLSClientConfig: tlsConfigInsecure,
  1711. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1712. tc, err := tls.Dial(network, addr, cfg)
  1713. if err != nil {
  1714. return nil, err
  1715. }
  1716. mu.Lock()
  1717. defer mu.Unlock()
  1718. conn = tc
  1719. return tc, nil
  1720. },
  1721. }
  1722. defer tr.CloseIdleConnections()
  1723. c := &http.Client{Transport: tr}
  1724. c.Get(st.ts.URL)
  1725. }
  1726. // Test that the http1 Transport.DisableKeepAlives option is respected
  1727. // and connections are closed as soon as idle.
  1728. // See golang.org/issue/14008
  1729. func TestTransportDisableKeepAlives(t *testing.T) {
  1730. st := newServerTester(t,
  1731. func(w http.ResponseWriter, r *http.Request) {
  1732. io.WriteString(w, "hi")
  1733. },
  1734. optOnlyServer,
  1735. )
  1736. defer st.Close()
  1737. connClosed := make(chan struct{}) // closed on tls.Conn.Close
  1738. tr := &Transport{
  1739. t1: &http.Transport{
  1740. DisableKeepAlives: true,
  1741. },
  1742. TLSClientConfig: tlsConfigInsecure,
  1743. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1744. tc, err := tls.Dial(network, addr, cfg)
  1745. if err != nil {
  1746. return nil, err
  1747. }
  1748. return &noteCloseConn{Conn: tc, closefn: func() { close(connClosed) }}, nil
  1749. },
  1750. }
  1751. c := &http.Client{Transport: tr}
  1752. res, err := c.Get(st.ts.URL)
  1753. if err != nil {
  1754. t.Fatal(err)
  1755. }
  1756. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1757. t.Fatal(err)
  1758. }
  1759. defer res.Body.Close()
  1760. select {
  1761. case <-connClosed:
  1762. case <-time.After(1 * time.Second):
  1763. t.Errorf("timeout")
  1764. }
  1765. }
  1766. // Test concurrent requests with Transport.DisableKeepAlives. We can share connections,
  1767. // but when things are totally idle, it still needs to close.
  1768. func TestTransportDisableKeepAlives_Concurrency(t *testing.T) {
  1769. const D = 25 * time.Millisecond
  1770. st := newServerTester(t,
  1771. func(w http.ResponseWriter, r *http.Request) {
  1772. time.Sleep(D)
  1773. io.WriteString(w, "hi")
  1774. },
  1775. optOnlyServer,
  1776. )
  1777. defer st.Close()
  1778. var dials int32
  1779. var conns sync.WaitGroup
  1780. tr := &Transport{
  1781. t1: &http.Transport{
  1782. DisableKeepAlives: true,
  1783. },
  1784. TLSClientConfig: tlsConfigInsecure,
  1785. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1786. tc, err := tls.Dial(network, addr, cfg)
  1787. if err != nil {
  1788. return nil, err
  1789. }
  1790. atomic.AddInt32(&dials, 1)
  1791. conns.Add(1)
  1792. return &noteCloseConn{Conn: tc, closefn: func() { conns.Done() }}, nil
  1793. },
  1794. }
  1795. c := &http.Client{Transport: tr}
  1796. var reqs sync.WaitGroup
  1797. const N = 20
  1798. for i := 0; i < N; i++ {
  1799. reqs.Add(1)
  1800. if i == N-1 {
  1801. // For the final request, try to make all the
  1802. // others close. This isn't verified in the
  1803. // count, other than the Log statement, since
  1804. // it's so timing dependent. This test is
  1805. // really to make sure we don't interrupt a
  1806. // valid request.
  1807. time.Sleep(D * 2)
  1808. }
  1809. go func() {
  1810. defer reqs.Done()
  1811. res, err := c.Get(st.ts.URL)
  1812. if err != nil {
  1813. t.Error(err)
  1814. return
  1815. }
  1816. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1817. t.Error(err)
  1818. return
  1819. }
  1820. res.Body.Close()
  1821. }()
  1822. }
  1823. reqs.Wait()
  1824. conns.Wait()
  1825. t.Logf("did %d dials, %d requests", atomic.LoadInt32(&dials), N)
  1826. }
  1827. type noteCloseConn struct {
  1828. net.Conn
  1829. onceClose sync.Once
  1830. closefn func()
  1831. }
  1832. func (c *noteCloseConn) Close() error {
  1833. c.onceClose.Do(c.closefn)
  1834. return c.Conn.Close()
  1835. }
  1836. func isTimeout(err error) bool {
  1837. switch err := err.(type) {
  1838. case nil:
  1839. return false
  1840. case *url.Error:
  1841. return isTimeout(err.Err)
  1842. case net.Error:
  1843. return err.Timeout()
  1844. }
  1845. return false
  1846. }
  1847. // Test that the http1 Transport.ResponseHeaderTimeout option and cancel is sent.
  1848. func TestTransportResponseHeaderTimeout_NoBody(t *testing.T) {
  1849. testTransportResponseHeaderTimeout(t, false)
  1850. }
  1851. func TestTransportResponseHeaderTimeout_Body(t *testing.T) {
  1852. testTransportResponseHeaderTimeout(t, true)
  1853. }
  1854. func testTransportResponseHeaderTimeout(t *testing.T, body bool) {
  1855. ct := newClientTester(t)
  1856. ct.tr.t1 = &http.Transport{
  1857. ResponseHeaderTimeout: 5 * time.Millisecond,
  1858. }
  1859. ct.client = func() error {
  1860. c := &http.Client{Transport: ct.tr}
  1861. var err error
  1862. var n int64
  1863. const bodySize = 4 << 20
  1864. if body {
  1865. _, err = c.Post("https://dummy.tld/", "text/foo", io.LimitReader(countingReader{&n}, bodySize))
  1866. } else {
  1867. _, err = c.Get("https://dummy.tld/")
  1868. }
  1869. if !isTimeout(err) {
  1870. t.Errorf("client expected timeout error; got %#v", err)
  1871. }
  1872. if body && n != bodySize {
  1873. t.Errorf("only read %d bytes of body; want %d", n, bodySize)
  1874. }
  1875. return nil
  1876. }
  1877. ct.server = func() error {
  1878. ct.greet()
  1879. for {
  1880. f, err := ct.fr.ReadFrame()
  1881. if err != nil {
  1882. t.Logf("ReadFrame: %v", err)
  1883. return nil
  1884. }
  1885. switch f := f.(type) {
  1886. case *DataFrame:
  1887. dataLen := len(f.Data())
  1888. if dataLen > 0 {
  1889. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  1890. return err
  1891. }
  1892. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  1893. return err
  1894. }
  1895. }
  1896. case *RSTStreamFrame:
  1897. if f.StreamID == 1 && f.ErrCode == ErrCodeCancel {
  1898. return nil
  1899. }
  1900. }
  1901. }
  1902. }
  1903. ct.run()
  1904. }
  1905. func TestTransportDisableCompression(t *testing.T) {
  1906. const body = "sup"
  1907. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1908. want := http.Header{
  1909. "User-Agent": []string{"Go-http-client/2.0"},
  1910. }
  1911. if !reflect.DeepEqual(r.Header, want) {
  1912. t.Errorf("request headers = %v; want %v", r.Header, want)
  1913. }
  1914. }, optOnlyServer)
  1915. defer st.Close()
  1916. tr := &Transport{
  1917. TLSClientConfig: tlsConfigInsecure,
  1918. t1: &http.Transport{
  1919. DisableCompression: true,
  1920. },
  1921. }
  1922. defer tr.CloseIdleConnections()
  1923. req, err := http.NewRequest("GET", st.ts.URL, nil)
  1924. if err != nil {
  1925. t.Fatal(err)
  1926. }
  1927. res, err := tr.RoundTrip(req)
  1928. if err != nil {
  1929. t.Fatal(err)
  1930. }
  1931. defer res.Body.Close()
  1932. }
  1933. // RFC 7540 section 8.1.2.2
  1934. func TestTransportRejectsConnHeaders(t *testing.T) {
  1935. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1936. var got []string
  1937. for k := range r.Header {
  1938. got = append(got, k)
  1939. }
  1940. sort.Strings(got)
  1941. w.Header().Set("Got-Header", strings.Join(got, ","))
  1942. }, optOnlyServer)
  1943. defer st.Close()
  1944. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1945. defer tr.CloseIdleConnections()
  1946. tests := []struct {
  1947. key string
  1948. value []string
  1949. want string
  1950. }{
  1951. {
  1952. key: "Upgrade",
  1953. value: []string{"anything"},
  1954. want: "ERROR: http2: invalid Upgrade request header: [\"anything\"]",
  1955. },
  1956. {
  1957. key: "Connection",
  1958. value: []string{"foo"},
  1959. want: "ERROR: http2: invalid Connection request header: [\"foo\"]",
  1960. },
  1961. {
  1962. key: "Connection",
  1963. value: []string{"close"},
  1964. want: "Accept-Encoding,User-Agent",
  1965. },
  1966. {
  1967. key: "Connection",
  1968. value: []string{"CLoSe"},
  1969. want: "Accept-Encoding,User-Agent",
  1970. },
  1971. {
  1972. key: "Connection",
  1973. value: []string{"close", "something-else"},
  1974. want: "ERROR: http2: invalid Connection request header: [\"close\" \"something-else\"]",
  1975. },
  1976. {
  1977. key: "Connection",
  1978. value: []string{"keep-alive"},
  1979. want: "Accept-Encoding,User-Agent",
  1980. },
  1981. {
  1982. key: "Connection",
  1983. value: []string{"Keep-ALIVE"},
  1984. want: "Accept-Encoding,User-Agent",
  1985. },
  1986. {
  1987. key: "Proxy-Connection", // just deleted and ignored
  1988. value: []string{"keep-alive"},
  1989. want: "Accept-Encoding,User-Agent",
  1990. },
  1991. {
  1992. key: "Transfer-Encoding",
  1993. value: []string{""},
  1994. want: "Accept-Encoding,User-Agent",
  1995. },
  1996. {
  1997. key: "Transfer-Encoding",
  1998. value: []string{"foo"},
  1999. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"foo\"]",
  2000. },
  2001. {
  2002. key: "Transfer-Encoding",
  2003. value: []string{"chunked"},
  2004. want: "Accept-Encoding,User-Agent",
  2005. },
  2006. {
  2007. key: "Transfer-Encoding",
  2008. value: []string{"chunked", "other"},
  2009. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"chunked\" \"other\"]",
  2010. },
  2011. {
  2012. key: "Content-Length",
  2013. value: []string{"123"},
  2014. want: "Accept-Encoding,User-Agent",
  2015. },
  2016. {
  2017. key: "Keep-Alive",
  2018. value: []string{"doop"},
  2019. want: "Accept-Encoding,User-Agent",
  2020. },
  2021. }
  2022. for _, tt := range tests {
  2023. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2024. req.Header[tt.key] = tt.value
  2025. res, err := tr.RoundTrip(req)
  2026. var got string
  2027. if err != nil {
  2028. got = fmt.Sprintf("ERROR: %v", err)
  2029. } else {
  2030. got = res.Header.Get("Got-Header")
  2031. res.Body.Close()
  2032. }
  2033. if got != tt.want {
  2034. t.Errorf("For key %q, value %q, got = %q; want %q", tt.key, tt.value, got, tt.want)
  2035. }
  2036. }
  2037. }
  2038. // golang.org/issue/14048
  2039. func TestTransportFailsOnInvalidHeaders(t *testing.T) {
  2040. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2041. var got []string
  2042. for k := range r.Header {
  2043. got = append(got, k)
  2044. }
  2045. sort.Strings(got)
  2046. w.Header().Set("Got-Header", strings.Join(got, ","))
  2047. }, optOnlyServer)
  2048. defer st.Close()
  2049. tests := [...]struct {
  2050. h http.Header
  2051. wantErr string
  2052. }{
  2053. 0: {
  2054. h: http.Header{"with space": {"foo"}},
  2055. wantErr: `invalid HTTP header name "with space"`,
  2056. },
  2057. 1: {
  2058. h: http.Header{"name": {"Брэд"}},
  2059. wantErr: "", // okay
  2060. },
  2061. 2: {
  2062. h: http.Header{"имя": {"Brad"}},
  2063. wantErr: `invalid HTTP header name "имя"`,
  2064. },
  2065. 3: {
  2066. h: http.Header{"foo": {"foo\x01bar"}},
  2067. wantErr: `invalid HTTP header value "foo\x01bar" for header "foo"`,
  2068. },
  2069. }
  2070. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2071. defer tr.CloseIdleConnections()
  2072. for i, tt := range tests {
  2073. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2074. req.Header = tt.h
  2075. res, err := tr.RoundTrip(req)
  2076. var bad bool
  2077. if tt.wantErr == "" {
  2078. if err != nil {
  2079. bad = true
  2080. t.Errorf("case %d: error = %v; want no error", i, err)
  2081. }
  2082. } else {
  2083. if !strings.Contains(fmt.Sprint(err), tt.wantErr) {
  2084. bad = true
  2085. t.Errorf("case %d: error = %v; want error %q", i, err, tt.wantErr)
  2086. }
  2087. }
  2088. if err == nil {
  2089. if bad {
  2090. t.Logf("case %d: server got headers %q", i, res.Header.Get("Got-Header"))
  2091. }
  2092. res.Body.Close()
  2093. }
  2094. }
  2095. }
  2096. // Tests that gzipReader doesn't crash on a second Read call following
  2097. // the first Read call's gzip.NewReader returning an error.
  2098. func TestGzipReader_DoubleReadCrash(t *testing.T) {
  2099. gz := &gzipReader{
  2100. body: ioutil.NopCloser(strings.NewReader("0123456789")),
  2101. }
  2102. var buf [1]byte
  2103. n, err1 := gz.Read(buf[:])
  2104. if n != 0 || !strings.Contains(fmt.Sprint(err1), "invalid header") {
  2105. t.Fatalf("Read = %v, %v; want 0, invalid header", n, err1)
  2106. }
  2107. n, err2 := gz.Read(buf[:])
  2108. if n != 0 || err2 != err1 {
  2109. t.Fatalf("second Read = %v, %v; want 0, %v", n, err2, err1)
  2110. }
  2111. }
  2112. func TestTransportNewTLSConfig(t *testing.T) {
  2113. tests := [...]struct {
  2114. conf *tls.Config
  2115. host string
  2116. want *tls.Config
  2117. }{
  2118. // Normal case.
  2119. 0: {
  2120. conf: nil,
  2121. host: "foo.com",
  2122. want: &tls.Config{
  2123. ServerName: "foo.com",
  2124. NextProtos: []string{NextProtoTLS},
  2125. },
  2126. },
  2127. // User-provided name (bar.com) takes precedence:
  2128. 1: {
  2129. conf: &tls.Config{
  2130. ServerName: "bar.com",
  2131. },
  2132. host: "foo.com",
  2133. want: &tls.Config{
  2134. ServerName: "bar.com",
  2135. NextProtos: []string{NextProtoTLS},
  2136. },
  2137. },
  2138. // NextProto is prepended:
  2139. 2: {
  2140. conf: &tls.Config{
  2141. NextProtos: []string{"foo", "bar"},
  2142. },
  2143. host: "example.com",
  2144. want: &tls.Config{
  2145. ServerName: "example.com",
  2146. NextProtos: []string{NextProtoTLS, "foo", "bar"},
  2147. },
  2148. },
  2149. // NextProto is not duplicated:
  2150. 3: {
  2151. conf: &tls.Config{
  2152. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2153. },
  2154. host: "example.com",
  2155. want: &tls.Config{
  2156. ServerName: "example.com",
  2157. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2158. },
  2159. },
  2160. }
  2161. for i, tt := range tests {
  2162. // Ignore the session ticket keys part, which ends up populating
  2163. // unexported fields in the Config:
  2164. if tt.conf != nil {
  2165. tt.conf.SessionTicketsDisabled = true
  2166. }
  2167. tr := &Transport{TLSClientConfig: tt.conf}
  2168. got := tr.newTLSConfig(tt.host)
  2169. got.SessionTicketsDisabled = false
  2170. if !reflect.DeepEqual(got, tt.want) {
  2171. t.Errorf("%d. got %#v; want %#v", i, got, tt.want)
  2172. }
  2173. }
  2174. }
  2175. // The Google GFE responds to HEAD requests with a HEADERS frame
  2176. // without END_STREAM, followed by a 0-length DATA frame with
  2177. // END_STREAM. Make sure we don't get confused by that. (We did.)
  2178. func TestTransportReadHeadResponse(t *testing.T) {
  2179. ct := newClientTester(t)
  2180. clientDone := make(chan struct{})
  2181. ct.client = func() error {
  2182. defer close(clientDone)
  2183. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2184. res, err := ct.tr.RoundTrip(req)
  2185. if err != nil {
  2186. return err
  2187. }
  2188. if res.ContentLength != 123 {
  2189. return fmt.Errorf("Content-Length = %d; want 123", res.ContentLength)
  2190. }
  2191. slurp, err := ioutil.ReadAll(res.Body)
  2192. if err != nil {
  2193. return fmt.Errorf("ReadAll: %v", err)
  2194. }
  2195. if len(slurp) > 0 {
  2196. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2197. }
  2198. return nil
  2199. }
  2200. ct.server = func() error {
  2201. ct.greet()
  2202. for {
  2203. f, err := ct.fr.ReadFrame()
  2204. if err != nil {
  2205. t.Logf("ReadFrame: %v", err)
  2206. return nil
  2207. }
  2208. hf, ok := f.(*HeadersFrame)
  2209. if !ok {
  2210. continue
  2211. }
  2212. var buf bytes.Buffer
  2213. enc := hpack.NewEncoder(&buf)
  2214. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2215. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2216. ct.fr.WriteHeaders(HeadersFrameParam{
  2217. StreamID: hf.StreamID,
  2218. EndHeaders: true,
  2219. EndStream: false, // as the GFE does
  2220. BlockFragment: buf.Bytes(),
  2221. })
  2222. ct.fr.WriteData(hf.StreamID, true, nil)
  2223. <-clientDone
  2224. return nil
  2225. }
  2226. }
  2227. ct.run()
  2228. }
  2229. func TestTransportReadHeadResponseWithBody(t *testing.T) {
  2230. // This test use not valid response format.
  2231. // Discarding logger output to not spam tests output.
  2232. log.SetOutput(ioutil.Discard)
  2233. defer log.SetOutput(os.Stderr)
  2234. response := "redirecting to /elsewhere"
  2235. ct := newClientTester(t)
  2236. clientDone := make(chan struct{})
  2237. ct.client = func() error {
  2238. defer close(clientDone)
  2239. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2240. res, err := ct.tr.RoundTrip(req)
  2241. if err != nil {
  2242. return err
  2243. }
  2244. if res.ContentLength != int64(len(response)) {
  2245. return fmt.Errorf("Content-Length = %d; want %d", res.ContentLength, len(response))
  2246. }
  2247. slurp, err := ioutil.ReadAll(res.Body)
  2248. if err != nil {
  2249. return fmt.Errorf("ReadAll: %v", err)
  2250. }
  2251. if len(slurp) > 0 {
  2252. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2253. }
  2254. return nil
  2255. }
  2256. ct.server = func() error {
  2257. ct.greet()
  2258. for {
  2259. f, err := ct.fr.ReadFrame()
  2260. if err != nil {
  2261. t.Logf("ReadFrame: %v", err)
  2262. return nil
  2263. }
  2264. hf, ok := f.(*HeadersFrame)
  2265. if !ok {
  2266. continue
  2267. }
  2268. var buf bytes.Buffer
  2269. enc := hpack.NewEncoder(&buf)
  2270. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2271. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: strconv.Itoa(len(response))})
  2272. ct.fr.WriteHeaders(HeadersFrameParam{
  2273. StreamID: hf.StreamID,
  2274. EndHeaders: true,
  2275. EndStream: false,
  2276. BlockFragment: buf.Bytes(),
  2277. })
  2278. ct.fr.WriteData(hf.StreamID, true, []byte(response))
  2279. <-clientDone
  2280. return nil
  2281. }
  2282. }
  2283. ct.run()
  2284. }
  2285. type neverEnding byte
  2286. func (b neverEnding) Read(p []byte) (int, error) {
  2287. for i := range p {
  2288. p[i] = byte(b)
  2289. }
  2290. return len(p), nil
  2291. }
  2292. // golang.org/issue/15425: test that a handler closing the request
  2293. // body doesn't terminate the stream to the peer. (It just stops
  2294. // readability from the handler's side, and eventually the client
  2295. // runs out of flow control tokens)
  2296. func TestTransportHandlerBodyClose(t *testing.T) {
  2297. const bodySize = 10 << 20
  2298. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2299. r.Body.Close()
  2300. io.Copy(w, io.LimitReader(neverEnding('A'), bodySize))
  2301. }, optOnlyServer)
  2302. defer st.Close()
  2303. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2304. defer tr.CloseIdleConnections()
  2305. g0 := runtime.NumGoroutine()
  2306. const numReq = 10
  2307. for i := 0; i < numReq; i++ {
  2308. req, err := http.NewRequest("POST", st.ts.URL, struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2309. if err != nil {
  2310. t.Fatal(err)
  2311. }
  2312. res, err := tr.RoundTrip(req)
  2313. if err != nil {
  2314. t.Fatal(err)
  2315. }
  2316. n, err := io.Copy(ioutil.Discard, res.Body)
  2317. res.Body.Close()
  2318. if n != bodySize || err != nil {
  2319. t.Fatalf("req#%d: Copy = %d, %v; want %d, nil", i, n, err, bodySize)
  2320. }
  2321. }
  2322. tr.CloseIdleConnections()
  2323. if !waitCondition(5*time.Second, 100*time.Millisecond, func() bool {
  2324. gd := runtime.NumGoroutine() - g0
  2325. return gd < numReq/2
  2326. }) {
  2327. t.Errorf("appeared to leak goroutines")
  2328. }
  2329. }
  2330. // https://golang.org/issue/15930
  2331. func TestTransportFlowControl(t *testing.T) {
  2332. const bufLen = 64 << 10
  2333. var total int64 = 100 << 20 // 100MB
  2334. if testing.Short() {
  2335. total = 10 << 20
  2336. }
  2337. var wrote int64 // updated atomically
  2338. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2339. b := make([]byte, bufLen)
  2340. for wrote < total {
  2341. n, err := w.Write(b)
  2342. atomic.AddInt64(&wrote, int64(n))
  2343. if err != nil {
  2344. t.Errorf("ResponseWriter.Write error: %v", err)
  2345. break
  2346. }
  2347. w.(http.Flusher).Flush()
  2348. }
  2349. }, optOnlyServer)
  2350. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2351. defer tr.CloseIdleConnections()
  2352. req, err := http.NewRequest("GET", st.ts.URL, nil)
  2353. if err != nil {
  2354. t.Fatal("NewRequest error:", err)
  2355. }
  2356. resp, err := tr.RoundTrip(req)
  2357. if err != nil {
  2358. t.Fatal("RoundTrip error:", err)
  2359. }
  2360. defer resp.Body.Close()
  2361. var read int64
  2362. b := make([]byte, bufLen)
  2363. for {
  2364. n, err := resp.Body.Read(b)
  2365. if err == io.EOF {
  2366. break
  2367. }
  2368. if err != nil {
  2369. t.Fatal("Read error:", err)
  2370. }
  2371. read += int64(n)
  2372. const max = transportDefaultStreamFlow
  2373. if w := atomic.LoadInt64(&wrote); -max > read-w || read-w > max {
  2374. t.Fatalf("Too much data inflight: server wrote %v bytes but client only received %v", w, read)
  2375. }
  2376. // Let the server get ahead of the client.
  2377. time.Sleep(1 * time.Millisecond)
  2378. }
  2379. }
  2380. // golang.org/issue/14627 -- if the server sends a GOAWAY frame, make
  2381. // the Transport remember it and return it back to users (via
  2382. // RoundTrip or request body reads) if needed (e.g. if the server
  2383. // proceeds to close the TCP connection before the client gets its
  2384. // response)
  2385. func TestTransportUsesGoAwayDebugError_RoundTrip(t *testing.T) {
  2386. testTransportUsesGoAwayDebugError(t, false)
  2387. }
  2388. func TestTransportUsesGoAwayDebugError_Body(t *testing.T) {
  2389. testTransportUsesGoAwayDebugError(t, true)
  2390. }
  2391. func testTransportUsesGoAwayDebugError(t *testing.T, failMidBody bool) {
  2392. ct := newClientTester(t)
  2393. clientDone := make(chan struct{})
  2394. const goAwayErrCode = ErrCodeHTTP11Required // arbitrary
  2395. const goAwayDebugData = "some debug data"
  2396. ct.client = func() error {
  2397. defer close(clientDone)
  2398. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2399. res, err := ct.tr.RoundTrip(req)
  2400. if failMidBody {
  2401. if err != nil {
  2402. return fmt.Errorf("unexpected client RoundTrip error: %v", err)
  2403. }
  2404. _, err = io.Copy(ioutil.Discard, res.Body)
  2405. res.Body.Close()
  2406. }
  2407. want := GoAwayError{
  2408. LastStreamID: 5,
  2409. ErrCode: goAwayErrCode,
  2410. DebugData: goAwayDebugData,
  2411. }
  2412. if !reflect.DeepEqual(err, want) {
  2413. t.Errorf("RoundTrip error = %T: %#v, want %T (%#v)", err, err, want, want)
  2414. }
  2415. return nil
  2416. }
  2417. ct.server = func() error {
  2418. ct.greet()
  2419. for {
  2420. f, err := ct.fr.ReadFrame()
  2421. if err != nil {
  2422. t.Logf("ReadFrame: %v", err)
  2423. return nil
  2424. }
  2425. hf, ok := f.(*HeadersFrame)
  2426. if !ok {
  2427. continue
  2428. }
  2429. if failMidBody {
  2430. var buf bytes.Buffer
  2431. enc := hpack.NewEncoder(&buf)
  2432. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2433. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2434. ct.fr.WriteHeaders(HeadersFrameParam{
  2435. StreamID: hf.StreamID,
  2436. EndHeaders: true,
  2437. EndStream: false,
  2438. BlockFragment: buf.Bytes(),
  2439. })
  2440. }
  2441. // Write two GOAWAY frames, to test that the Transport takes
  2442. // the interesting parts of both.
  2443. ct.fr.WriteGoAway(5, ErrCodeNo, []byte(goAwayDebugData))
  2444. ct.fr.WriteGoAway(5, goAwayErrCode, nil)
  2445. ct.sc.(*net.TCPConn).CloseWrite()
  2446. <-clientDone
  2447. return nil
  2448. }
  2449. }
  2450. ct.run()
  2451. }
  2452. func testTransportReturnsUnusedFlowControl(t *testing.T, oneDataFrame bool) {
  2453. ct := newClientTester(t)
  2454. clientClosed := make(chan struct{})
  2455. serverWroteFirstByte := make(chan struct{})
  2456. ct.client = func() error {
  2457. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2458. res, err := ct.tr.RoundTrip(req)
  2459. if err != nil {
  2460. return err
  2461. }
  2462. <-serverWroteFirstByte
  2463. if n, err := res.Body.Read(make([]byte, 1)); err != nil || n != 1 {
  2464. return fmt.Errorf("body read = %v, %v; want 1, nil", n, err)
  2465. }
  2466. res.Body.Close() // leaving 4999 bytes unread
  2467. close(clientClosed)
  2468. return nil
  2469. }
  2470. ct.server = func() error {
  2471. ct.greet()
  2472. var hf *HeadersFrame
  2473. for {
  2474. f, err := ct.fr.ReadFrame()
  2475. if err != nil {
  2476. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2477. }
  2478. switch f.(type) {
  2479. case *WindowUpdateFrame, *SettingsFrame:
  2480. continue
  2481. }
  2482. var ok bool
  2483. hf, ok = f.(*HeadersFrame)
  2484. if !ok {
  2485. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2486. }
  2487. break
  2488. }
  2489. var buf bytes.Buffer
  2490. enc := hpack.NewEncoder(&buf)
  2491. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2492. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2493. ct.fr.WriteHeaders(HeadersFrameParam{
  2494. StreamID: hf.StreamID,
  2495. EndHeaders: true,
  2496. EndStream: false,
  2497. BlockFragment: buf.Bytes(),
  2498. })
  2499. // Two cases:
  2500. // - Send one DATA frame with 5000 bytes.
  2501. // - Send two DATA frames with 1 and 4999 bytes each.
  2502. //
  2503. // In both cases, the client should consume one byte of data,
  2504. // refund that byte, then refund the following 4999 bytes.
  2505. //
  2506. // In the second case, the server waits for the client connection to
  2507. // close before seconding the second DATA frame. This tests the case
  2508. // where the client receives a DATA frame after it has reset the stream.
  2509. if oneDataFrame {
  2510. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 5000))
  2511. close(serverWroteFirstByte)
  2512. <-clientClosed
  2513. } else {
  2514. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 1))
  2515. close(serverWroteFirstByte)
  2516. <-clientClosed
  2517. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 4999))
  2518. }
  2519. waitingFor := "RSTStreamFrame"
  2520. for {
  2521. f, err := ct.fr.ReadFrame()
  2522. if err != nil {
  2523. return fmt.Errorf("ReadFrame while waiting for %s: %v", waitingFor, err)
  2524. }
  2525. if _, ok := f.(*SettingsFrame); ok {
  2526. continue
  2527. }
  2528. switch waitingFor {
  2529. case "RSTStreamFrame":
  2530. if rf, ok := f.(*RSTStreamFrame); !ok || rf.ErrCode != ErrCodeCancel {
  2531. return fmt.Errorf("Expected a RSTStreamFrame with code cancel; got %v", summarizeFrame(f))
  2532. }
  2533. waitingFor = "WindowUpdateFrame"
  2534. case "WindowUpdateFrame":
  2535. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != 4999 {
  2536. return fmt.Errorf("Expected WindowUpdateFrame for 4999 bytes; got %v", summarizeFrame(f))
  2537. }
  2538. return nil
  2539. }
  2540. }
  2541. }
  2542. ct.run()
  2543. }
  2544. // See golang.org/issue/16481
  2545. func TestTransportReturnsUnusedFlowControlSingleWrite(t *testing.T) {
  2546. testTransportReturnsUnusedFlowControl(t, true)
  2547. }
  2548. // See golang.org/issue/20469
  2549. func TestTransportReturnsUnusedFlowControlMultipleWrites(t *testing.T) {
  2550. testTransportReturnsUnusedFlowControl(t, false)
  2551. }
  2552. // Issue 16612: adjust flow control on open streams when transport
  2553. // receives SETTINGS with INITIAL_WINDOW_SIZE from server.
  2554. func TestTransportAdjustsFlowControl(t *testing.T) {
  2555. ct := newClientTester(t)
  2556. clientDone := make(chan struct{})
  2557. const bodySize = 1 << 20
  2558. ct.client = func() error {
  2559. defer ct.cc.(*net.TCPConn).CloseWrite()
  2560. defer close(clientDone)
  2561. req, _ := http.NewRequest("POST", "https://dummy.tld/", struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2562. res, err := ct.tr.RoundTrip(req)
  2563. if err != nil {
  2564. return err
  2565. }
  2566. res.Body.Close()
  2567. return nil
  2568. }
  2569. ct.server = func() error {
  2570. _, err := io.ReadFull(ct.sc, make([]byte, len(ClientPreface)))
  2571. if err != nil {
  2572. return fmt.Errorf("reading client preface: %v", err)
  2573. }
  2574. var gotBytes int64
  2575. var sentSettings bool
  2576. for {
  2577. f, err := ct.fr.ReadFrame()
  2578. if err != nil {
  2579. select {
  2580. case <-clientDone:
  2581. return nil
  2582. default:
  2583. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2584. }
  2585. }
  2586. switch f := f.(type) {
  2587. case *DataFrame:
  2588. gotBytes += int64(len(f.Data()))
  2589. // After we've got half the client's
  2590. // initial flow control window's worth
  2591. // of request body data, give it just
  2592. // enough flow control to finish.
  2593. if gotBytes >= initialWindowSize/2 && !sentSettings {
  2594. sentSettings = true
  2595. ct.fr.WriteSettings(Setting{ID: SettingInitialWindowSize, Val: bodySize})
  2596. ct.fr.WriteWindowUpdate(0, bodySize)
  2597. ct.fr.WriteSettingsAck()
  2598. }
  2599. if f.StreamEnded() {
  2600. var buf bytes.Buffer
  2601. enc := hpack.NewEncoder(&buf)
  2602. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2603. ct.fr.WriteHeaders(HeadersFrameParam{
  2604. StreamID: f.StreamID,
  2605. EndHeaders: true,
  2606. EndStream: true,
  2607. BlockFragment: buf.Bytes(),
  2608. })
  2609. }
  2610. }
  2611. }
  2612. }
  2613. ct.run()
  2614. }
  2615. // See golang.org/issue/16556
  2616. func TestTransportReturnsDataPaddingFlowControl(t *testing.T) {
  2617. ct := newClientTester(t)
  2618. unblockClient := make(chan bool, 1)
  2619. ct.client = func() error {
  2620. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2621. res, err := ct.tr.RoundTrip(req)
  2622. if err != nil {
  2623. return err
  2624. }
  2625. defer res.Body.Close()
  2626. <-unblockClient
  2627. return nil
  2628. }
  2629. ct.server = func() error {
  2630. ct.greet()
  2631. var hf *HeadersFrame
  2632. for {
  2633. f, err := ct.fr.ReadFrame()
  2634. if err != nil {
  2635. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2636. }
  2637. switch f.(type) {
  2638. case *WindowUpdateFrame, *SettingsFrame:
  2639. continue
  2640. }
  2641. var ok bool
  2642. hf, ok = f.(*HeadersFrame)
  2643. if !ok {
  2644. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2645. }
  2646. break
  2647. }
  2648. var buf bytes.Buffer
  2649. enc := hpack.NewEncoder(&buf)
  2650. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2651. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2652. ct.fr.WriteHeaders(HeadersFrameParam{
  2653. StreamID: hf.StreamID,
  2654. EndHeaders: true,
  2655. EndStream: false,
  2656. BlockFragment: buf.Bytes(),
  2657. })
  2658. pad := make([]byte, 5)
  2659. ct.fr.WriteDataPadded(hf.StreamID, false, make([]byte, 5000), pad) // without ending stream
  2660. f, err := ct.readNonSettingsFrame()
  2661. if err != nil {
  2662. return fmt.Errorf("ReadFrame while waiting for first WindowUpdateFrame: %v", err)
  2663. }
  2664. wantBack := uint32(len(pad)) + 1 // one byte for the length of the padding
  2665. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID != 0 {
  2666. return fmt.Errorf("Expected conn WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2667. }
  2668. f, err = ct.readNonSettingsFrame()
  2669. if err != nil {
  2670. return fmt.Errorf("ReadFrame while waiting for second WindowUpdateFrame: %v", err)
  2671. }
  2672. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID == 0 {
  2673. return fmt.Errorf("Expected stream WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2674. }
  2675. unblockClient <- true
  2676. return nil
  2677. }
  2678. ct.run()
  2679. }
  2680. // golang.org/issue/16572 -- RoundTrip shouldn't hang when it gets a
  2681. // StreamError as a result of the response HEADERS
  2682. func TestTransportReturnsErrorOnBadResponseHeaders(t *testing.T) {
  2683. ct := newClientTester(t)
  2684. ct.client = func() error {
  2685. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2686. res, err := ct.tr.RoundTrip(req)
  2687. if err == nil {
  2688. res.Body.Close()
  2689. return errors.New("unexpected successful GET")
  2690. }
  2691. want := StreamError{1, ErrCodeProtocol, headerFieldNameError(" content-type")}
  2692. if !reflect.DeepEqual(want, err) {
  2693. t.Errorf("RoundTrip error = %#v; want %#v", err, want)
  2694. }
  2695. return nil
  2696. }
  2697. ct.server = func() error {
  2698. ct.greet()
  2699. hf, err := ct.firstHeaders()
  2700. if err != nil {
  2701. return err
  2702. }
  2703. var buf bytes.Buffer
  2704. enc := hpack.NewEncoder(&buf)
  2705. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2706. enc.WriteField(hpack.HeaderField{Name: " content-type", Value: "bogus"}) // bogus spaces
  2707. ct.fr.WriteHeaders(HeadersFrameParam{
  2708. StreamID: hf.StreamID,
  2709. EndHeaders: true,
  2710. EndStream: false,
  2711. BlockFragment: buf.Bytes(),
  2712. })
  2713. for {
  2714. fr, err := ct.readFrame()
  2715. if err != nil {
  2716. return fmt.Errorf("error waiting for RST_STREAM from client: %v", err)
  2717. }
  2718. if _, ok := fr.(*SettingsFrame); ok {
  2719. continue
  2720. }
  2721. if rst, ok := fr.(*RSTStreamFrame); !ok || rst.StreamID != 1 || rst.ErrCode != ErrCodeProtocol {
  2722. t.Errorf("Frame = %v; want RST_STREAM for stream 1 with ErrCodeProtocol", summarizeFrame(fr))
  2723. }
  2724. break
  2725. }
  2726. return nil
  2727. }
  2728. ct.run()
  2729. }
  2730. // byteAndEOFReader returns is in an io.Reader which reads one byte
  2731. // (the underlying byte) and io.EOF at once in its Read call.
  2732. type byteAndEOFReader byte
  2733. func (b byteAndEOFReader) Read(p []byte) (n int, err error) {
  2734. if len(p) == 0 {
  2735. panic("unexpected useless call")
  2736. }
  2737. p[0] = byte(b)
  2738. return 1, io.EOF
  2739. }
  2740. // Issue 16788: the Transport had a regression where it started
  2741. // sending a spurious DATA frame with a duplicate END_STREAM bit after
  2742. // the request body writer goroutine had already read an EOF from the
  2743. // Request.Body and included the END_STREAM on a data-carrying DATA
  2744. // frame.
  2745. //
  2746. // Notably, to trigger this, the requests need to use a Request.Body
  2747. // which returns (non-0, io.EOF) and also needs to set the ContentLength
  2748. // explicitly.
  2749. func TestTransportBodyDoubleEndStream(t *testing.T) {
  2750. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2751. // Nothing.
  2752. }, optOnlyServer)
  2753. defer st.Close()
  2754. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2755. defer tr.CloseIdleConnections()
  2756. for i := 0; i < 2; i++ {
  2757. req, _ := http.NewRequest("POST", st.ts.URL, byteAndEOFReader('a'))
  2758. req.ContentLength = 1
  2759. res, err := tr.RoundTrip(req)
  2760. if err != nil {
  2761. t.Fatalf("failure on req %d: %v", i+1, err)
  2762. }
  2763. defer res.Body.Close()
  2764. }
  2765. }
  2766. // golang.org/issue/16847, golang.org/issue/19103
  2767. func TestTransportRequestPathPseudo(t *testing.T) {
  2768. type result struct {
  2769. path string
  2770. err string
  2771. }
  2772. tests := []struct {
  2773. req *http.Request
  2774. want result
  2775. }{
  2776. 0: {
  2777. req: &http.Request{
  2778. Method: "GET",
  2779. URL: &url.URL{
  2780. Host: "foo.com",
  2781. Path: "/foo",
  2782. },
  2783. },
  2784. want: result{path: "/foo"},
  2785. },
  2786. // In Go 1.7, we accepted paths of "//foo".
  2787. // In Go 1.8, we rejected it (issue 16847).
  2788. // In Go 1.9, we accepted it again (issue 19103).
  2789. 1: {
  2790. req: &http.Request{
  2791. Method: "GET",
  2792. URL: &url.URL{
  2793. Host: "foo.com",
  2794. Path: "//foo",
  2795. },
  2796. },
  2797. want: result{path: "//foo"},
  2798. },
  2799. // Opaque with //$Matching_Hostname/path
  2800. 2: {
  2801. req: &http.Request{
  2802. Method: "GET",
  2803. URL: &url.URL{
  2804. Scheme: "https",
  2805. Opaque: "//foo.com/path",
  2806. Host: "foo.com",
  2807. Path: "/ignored",
  2808. },
  2809. },
  2810. want: result{path: "/path"},
  2811. },
  2812. // Opaque with some other Request.Host instead:
  2813. 3: {
  2814. req: &http.Request{
  2815. Method: "GET",
  2816. Host: "bar.com",
  2817. URL: &url.URL{
  2818. Scheme: "https",
  2819. Opaque: "//bar.com/path",
  2820. Host: "foo.com",
  2821. Path: "/ignored",
  2822. },
  2823. },
  2824. want: result{path: "/path"},
  2825. },
  2826. // Opaque without the leading "//":
  2827. 4: {
  2828. req: &http.Request{
  2829. Method: "GET",
  2830. URL: &url.URL{
  2831. Opaque: "/path",
  2832. Host: "foo.com",
  2833. Path: "/ignored",
  2834. },
  2835. },
  2836. want: result{path: "/path"},
  2837. },
  2838. // Opaque we can't handle:
  2839. 5: {
  2840. req: &http.Request{
  2841. Method: "GET",
  2842. URL: &url.URL{
  2843. Scheme: "https",
  2844. Opaque: "//unknown_host/path",
  2845. Host: "foo.com",
  2846. Path: "/ignored",
  2847. },
  2848. },
  2849. want: result{err: `invalid request :path "https://unknown_host/path" from URL.Opaque = "//unknown_host/path"`},
  2850. },
  2851. // A CONNECT request:
  2852. 6: {
  2853. req: &http.Request{
  2854. Method: "CONNECT",
  2855. URL: &url.URL{
  2856. Host: "foo.com",
  2857. },
  2858. },
  2859. want: result{},
  2860. },
  2861. }
  2862. for i, tt := range tests {
  2863. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  2864. cc.henc = hpack.NewEncoder(&cc.hbuf)
  2865. cc.mu.Lock()
  2866. hdrs, err := cc.encodeHeaders(tt.req, false, "", -1)
  2867. cc.mu.Unlock()
  2868. var got result
  2869. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(f hpack.HeaderField) {
  2870. if f.Name == ":path" {
  2871. got.path = f.Value
  2872. }
  2873. })
  2874. if err != nil {
  2875. got.err = err.Error()
  2876. } else if len(hdrs) > 0 {
  2877. if _, err := hpackDec.Write(hdrs); err != nil {
  2878. t.Errorf("%d. bogus hpack: %v", i, err)
  2879. continue
  2880. }
  2881. }
  2882. if got != tt.want {
  2883. t.Errorf("%d. got %+v; want %+v", i, got, tt.want)
  2884. }
  2885. }
  2886. }
  2887. // golang.org/issue/17071 -- don't sniff the first byte of the request body
  2888. // before we've determined that the ClientConn is usable.
  2889. func TestRoundTripDoesntConsumeRequestBodyEarly(t *testing.T) {
  2890. const body = "foo"
  2891. req, _ := http.NewRequest("POST", "http://foo.com/", ioutil.NopCloser(strings.NewReader(body)))
  2892. cc := &ClientConn{
  2893. closed: true,
  2894. }
  2895. _, err := cc.RoundTrip(req)
  2896. if err != errClientConnUnusable {
  2897. t.Fatalf("RoundTrip = %v; want errClientConnUnusable", err)
  2898. }
  2899. slurp, err := ioutil.ReadAll(req.Body)
  2900. if err != nil {
  2901. t.Errorf("ReadAll = %v", err)
  2902. }
  2903. if string(slurp) != body {
  2904. t.Errorf("Body = %q; want %q", slurp, body)
  2905. }
  2906. }
  2907. func TestClientConnPing(t *testing.T) {
  2908. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {}, optOnlyServer)
  2909. defer st.Close()
  2910. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2911. defer tr.CloseIdleConnections()
  2912. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  2913. if err != nil {
  2914. t.Fatal(err)
  2915. }
  2916. if err = cc.Ping(context.Background()); err != nil {
  2917. t.Fatal(err)
  2918. }
  2919. }
  2920. // Issue 16974: if the server sent a DATA frame after the user
  2921. // canceled the Transport's Request, the Transport previously wrote to a
  2922. // closed pipe, got an error, and ended up closing the whole TCP
  2923. // connection.
  2924. func TestTransportCancelDataResponseRace(t *testing.T) {
  2925. cancel := make(chan struct{})
  2926. clientGotError := make(chan bool, 1)
  2927. const msg = "Hello."
  2928. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2929. if strings.Contains(r.URL.Path, "/hello") {
  2930. time.Sleep(50 * time.Millisecond)
  2931. io.WriteString(w, msg)
  2932. return
  2933. }
  2934. for i := 0; i < 50; i++ {
  2935. io.WriteString(w, "Some data.")
  2936. w.(http.Flusher).Flush()
  2937. if i == 2 {
  2938. close(cancel)
  2939. <-clientGotError
  2940. }
  2941. time.Sleep(10 * time.Millisecond)
  2942. }
  2943. }, optOnlyServer)
  2944. defer st.Close()
  2945. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2946. defer tr.CloseIdleConnections()
  2947. c := &http.Client{Transport: tr}
  2948. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2949. req.Cancel = cancel
  2950. res, err := c.Do(req)
  2951. if err != nil {
  2952. t.Fatal(err)
  2953. }
  2954. if _, err = io.Copy(ioutil.Discard, res.Body); err == nil {
  2955. t.Fatal("unexpected success")
  2956. }
  2957. clientGotError <- true
  2958. res, err = c.Get(st.ts.URL + "/hello")
  2959. if err != nil {
  2960. t.Fatal(err)
  2961. }
  2962. slurp, err := ioutil.ReadAll(res.Body)
  2963. if err != nil {
  2964. t.Fatal(err)
  2965. }
  2966. if string(slurp) != msg {
  2967. t.Errorf("Got = %q; want %q", slurp, msg)
  2968. }
  2969. }
  2970. // Issue 21316: It should be safe to reuse an http.Request after the
  2971. // request has completed.
  2972. func TestTransportNoRaceOnRequestObjectAfterRequestComplete(t *testing.T) {
  2973. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2974. w.WriteHeader(200)
  2975. io.WriteString(w, "body")
  2976. }, optOnlyServer)
  2977. defer st.Close()
  2978. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2979. defer tr.CloseIdleConnections()
  2980. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2981. resp, err := tr.RoundTrip(req)
  2982. if err != nil {
  2983. t.Fatal(err)
  2984. }
  2985. if _, err = io.Copy(ioutil.Discard, resp.Body); err != nil {
  2986. t.Fatalf("error reading response body: %v", err)
  2987. }
  2988. if err := resp.Body.Close(); err != nil {
  2989. t.Fatalf("error closing response body: %v", err)
  2990. }
  2991. // This access of req.Header should not race with code in the transport.
  2992. req.Header = http.Header{}
  2993. }
  2994. func TestTransportRetryAfterGOAWAY(t *testing.T) {
  2995. var dialer struct {
  2996. sync.Mutex
  2997. count int
  2998. }
  2999. ct1 := make(chan *clientTester)
  3000. ct2 := make(chan *clientTester)
  3001. ln := newLocalListener(t)
  3002. defer ln.Close()
  3003. tr := &Transport{
  3004. TLSClientConfig: tlsConfigInsecure,
  3005. }
  3006. tr.DialTLS = func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  3007. dialer.Lock()
  3008. defer dialer.Unlock()
  3009. dialer.count++
  3010. if dialer.count == 3 {
  3011. return nil, errors.New("unexpected number of dials")
  3012. }
  3013. cc, err := net.Dial("tcp", ln.Addr().String())
  3014. if err != nil {
  3015. return nil, fmt.Errorf("dial error: %v", err)
  3016. }
  3017. sc, err := ln.Accept()
  3018. if err != nil {
  3019. return nil, fmt.Errorf("accept error: %v", err)
  3020. }
  3021. ct := &clientTester{
  3022. t: t,
  3023. tr: tr,
  3024. cc: cc,
  3025. sc: sc,
  3026. fr: NewFramer(sc, sc),
  3027. }
  3028. switch dialer.count {
  3029. case 1:
  3030. ct1 <- ct
  3031. case 2:
  3032. ct2 <- ct
  3033. }
  3034. return cc, nil
  3035. }
  3036. errs := make(chan error, 3)
  3037. done := make(chan struct{})
  3038. defer close(done)
  3039. // Client.
  3040. go func() {
  3041. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3042. res, err := tr.RoundTrip(req)
  3043. if res != nil {
  3044. res.Body.Close()
  3045. if got := res.Header.Get("Foo"); got != "bar" {
  3046. err = fmt.Errorf("foo header = %q; want bar", got)
  3047. }
  3048. }
  3049. if err != nil {
  3050. err = fmt.Errorf("RoundTrip: %v", err)
  3051. }
  3052. errs <- err
  3053. }()
  3054. connToClose := make(chan io.Closer, 2)
  3055. // Server for the first request.
  3056. go func() {
  3057. var ct *clientTester
  3058. select {
  3059. case ct = <-ct1:
  3060. case <-done:
  3061. return
  3062. }
  3063. connToClose <- ct.cc
  3064. ct.greet()
  3065. hf, err := ct.firstHeaders()
  3066. if err != nil {
  3067. errs <- fmt.Errorf("server1 failed reading HEADERS: %v", err)
  3068. return
  3069. }
  3070. t.Logf("server1 got %v", hf)
  3071. if err := ct.fr.WriteGoAway(0 /*max id*/, ErrCodeNo, nil); err != nil {
  3072. errs <- fmt.Errorf("server1 failed writing GOAWAY: %v", err)
  3073. return
  3074. }
  3075. errs <- nil
  3076. }()
  3077. // Server for the second request.
  3078. go func() {
  3079. var ct *clientTester
  3080. select {
  3081. case ct = <-ct2:
  3082. case <-done:
  3083. return
  3084. }
  3085. connToClose <- ct.cc
  3086. ct.greet()
  3087. hf, err := ct.firstHeaders()
  3088. if err != nil {
  3089. errs <- fmt.Errorf("server2 failed reading HEADERS: %v", err)
  3090. return
  3091. }
  3092. t.Logf("server2 got %v", hf)
  3093. var buf bytes.Buffer
  3094. enc := hpack.NewEncoder(&buf)
  3095. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3096. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  3097. err = ct.fr.WriteHeaders(HeadersFrameParam{
  3098. StreamID: hf.StreamID,
  3099. EndHeaders: true,
  3100. EndStream: false,
  3101. BlockFragment: buf.Bytes(),
  3102. })
  3103. if err != nil {
  3104. errs <- fmt.Errorf("server2 failed writing response HEADERS: %v", err)
  3105. } else {
  3106. errs <- nil
  3107. }
  3108. }()
  3109. for k := 0; k < 3; k++ {
  3110. select {
  3111. case err := <-errs:
  3112. if err != nil {
  3113. t.Error(err)
  3114. }
  3115. case <-time.After(1 * time.Second):
  3116. t.Errorf("timed out")
  3117. }
  3118. }
  3119. for {
  3120. select {
  3121. case c := <-connToClose:
  3122. c.Close()
  3123. default:
  3124. return
  3125. }
  3126. }
  3127. }
  3128. func TestTransportRetryAfterRefusedStream(t *testing.T) {
  3129. clientDone := make(chan struct{})
  3130. ct := newClientTester(t)
  3131. ct.client = func() error {
  3132. defer ct.cc.(*net.TCPConn).CloseWrite()
  3133. defer close(clientDone)
  3134. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3135. resp, err := ct.tr.RoundTrip(req)
  3136. if err != nil {
  3137. return fmt.Errorf("RoundTrip: %v", err)
  3138. }
  3139. resp.Body.Close()
  3140. if resp.StatusCode != 204 {
  3141. return fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3142. }
  3143. return nil
  3144. }
  3145. ct.server = func() error {
  3146. ct.greet()
  3147. var buf bytes.Buffer
  3148. enc := hpack.NewEncoder(&buf)
  3149. nreq := 0
  3150. for {
  3151. f, err := ct.fr.ReadFrame()
  3152. if err != nil {
  3153. select {
  3154. case <-clientDone:
  3155. // If the client's done, it
  3156. // will have reported any
  3157. // errors on its side.
  3158. return nil
  3159. default:
  3160. return err
  3161. }
  3162. }
  3163. switch f := f.(type) {
  3164. case *WindowUpdateFrame, *SettingsFrame:
  3165. case *HeadersFrame:
  3166. if !f.HeadersEnded() {
  3167. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3168. }
  3169. nreq++
  3170. if nreq == 1 {
  3171. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3172. } else {
  3173. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3174. ct.fr.WriteHeaders(HeadersFrameParam{
  3175. StreamID: f.StreamID,
  3176. EndHeaders: true,
  3177. EndStream: true,
  3178. BlockFragment: buf.Bytes(),
  3179. })
  3180. }
  3181. default:
  3182. return fmt.Errorf("Unexpected client frame %v", f)
  3183. }
  3184. }
  3185. }
  3186. ct.run()
  3187. }
  3188. func TestTransportRetryHasLimit(t *testing.T) {
  3189. // Skip in short mode because the total expected delay is 1s+2s+4s+8s+16s=29s.
  3190. if testing.Short() {
  3191. t.Skip("skipping long test in short mode")
  3192. }
  3193. clientDone := make(chan struct{})
  3194. ct := newClientTester(t)
  3195. ct.client = func() error {
  3196. defer ct.cc.(*net.TCPConn).CloseWrite()
  3197. defer close(clientDone)
  3198. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3199. resp, err := ct.tr.RoundTrip(req)
  3200. if err == nil {
  3201. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3202. }
  3203. t.Logf("expected error, got: %v", err)
  3204. return nil
  3205. }
  3206. ct.server = func() error {
  3207. ct.greet()
  3208. for {
  3209. f, err := ct.fr.ReadFrame()
  3210. if err != nil {
  3211. select {
  3212. case <-clientDone:
  3213. // If the client's done, it
  3214. // will have reported any
  3215. // errors on its side.
  3216. return nil
  3217. default:
  3218. return err
  3219. }
  3220. }
  3221. switch f := f.(type) {
  3222. case *WindowUpdateFrame, *SettingsFrame:
  3223. case *HeadersFrame:
  3224. if !f.HeadersEnded() {
  3225. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3226. }
  3227. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3228. default:
  3229. return fmt.Errorf("Unexpected client frame %v", f)
  3230. }
  3231. }
  3232. }
  3233. ct.run()
  3234. }
  3235. func TestTransportResponseDataBeforeHeaders(t *testing.T) {
  3236. // This test use not valid response format.
  3237. // Discarding logger output to not spam tests output.
  3238. log.SetOutput(ioutil.Discard)
  3239. defer log.SetOutput(os.Stderr)
  3240. ct := newClientTester(t)
  3241. ct.client = func() error {
  3242. defer ct.cc.(*net.TCPConn).CloseWrite()
  3243. req := httptest.NewRequest("GET", "https://dummy.tld/", nil)
  3244. // First request is normal to ensure the check is per stream and not per connection.
  3245. _, err := ct.tr.RoundTrip(req)
  3246. if err != nil {
  3247. return fmt.Errorf("RoundTrip expected no error, got: %v", err)
  3248. }
  3249. // Second request returns a DATA frame with no HEADERS.
  3250. resp, err := ct.tr.RoundTrip(req)
  3251. if err == nil {
  3252. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3253. }
  3254. if err, ok := err.(StreamError); !ok || err.Code != ErrCodeProtocol {
  3255. return fmt.Errorf("expected stream PROTOCOL_ERROR, got: %v", err)
  3256. }
  3257. return nil
  3258. }
  3259. ct.server = func() error {
  3260. ct.greet()
  3261. for {
  3262. f, err := ct.fr.ReadFrame()
  3263. if err == io.EOF {
  3264. return nil
  3265. } else if err != nil {
  3266. return err
  3267. }
  3268. switch f := f.(type) {
  3269. case *WindowUpdateFrame, *SettingsFrame:
  3270. case *HeadersFrame:
  3271. switch f.StreamID {
  3272. case 1:
  3273. // Send a valid response to first request.
  3274. var buf bytes.Buffer
  3275. enc := hpack.NewEncoder(&buf)
  3276. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3277. ct.fr.WriteHeaders(HeadersFrameParam{
  3278. StreamID: f.StreamID,
  3279. EndHeaders: true,
  3280. EndStream: true,
  3281. BlockFragment: buf.Bytes(),
  3282. })
  3283. case 3:
  3284. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3285. }
  3286. default:
  3287. return fmt.Errorf("Unexpected client frame %v", f)
  3288. }
  3289. }
  3290. }
  3291. ct.run()
  3292. }
  3293. // tests Transport.StrictMaxConcurrentStreams
  3294. func TestTransportRequestsStallAtServerLimit(t *testing.T) {
  3295. const maxConcurrent = 2
  3296. greet := make(chan struct{}) // server sends initial SETTINGS frame
  3297. gotRequest := make(chan struct{}) // server received a request
  3298. clientDone := make(chan struct{})
  3299. // Collect errors from goroutines.
  3300. var wg sync.WaitGroup
  3301. errs := make(chan error, 100)
  3302. defer func() {
  3303. wg.Wait()
  3304. close(errs)
  3305. for err := range errs {
  3306. t.Error(err)
  3307. }
  3308. }()
  3309. // We will send maxConcurrent+2 requests. This checker goroutine waits for the
  3310. // following stages:
  3311. // 1. The first maxConcurrent requests are received by the server.
  3312. // 2. The client will cancel the next request
  3313. // 3. The server is unblocked so it can service the first maxConcurrent requests
  3314. // 4. The client will send the final request
  3315. wg.Add(1)
  3316. unblockClient := make(chan struct{})
  3317. clientRequestCancelled := make(chan struct{})
  3318. unblockServer := make(chan struct{})
  3319. go func() {
  3320. defer wg.Done()
  3321. // Stage 1.
  3322. for k := 0; k < maxConcurrent; k++ {
  3323. <-gotRequest
  3324. }
  3325. // Stage 2.
  3326. close(unblockClient)
  3327. <-clientRequestCancelled
  3328. // Stage 3: give some time for the final RoundTrip call to be scheduled and
  3329. // verify that the final request is not sent.
  3330. time.Sleep(50 * time.Millisecond)
  3331. select {
  3332. case <-gotRequest:
  3333. errs <- errors.New("last request did not stall")
  3334. close(unblockServer)
  3335. return
  3336. default:
  3337. }
  3338. close(unblockServer)
  3339. // Stage 4.
  3340. <-gotRequest
  3341. }()
  3342. ct := newClientTester(t)
  3343. ct.tr.StrictMaxConcurrentStreams = true
  3344. ct.client = func() error {
  3345. var wg sync.WaitGroup
  3346. defer func() {
  3347. wg.Wait()
  3348. close(clientDone)
  3349. ct.cc.(*net.TCPConn).CloseWrite()
  3350. }()
  3351. for k := 0; k < maxConcurrent+2; k++ {
  3352. wg.Add(1)
  3353. go func(k int) {
  3354. defer wg.Done()
  3355. // Don't send the second request until after receiving SETTINGS from the server
  3356. // to avoid a race where we use the default SettingMaxConcurrentStreams, which
  3357. // is much larger than maxConcurrent. We have to send the first request before
  3358. // waiting because the first request triggers the dial and greet.
  3359. if k > 0 {
  3360. <-greet
  3361. }
  3362. // Block until maxConcurrent requests are sent before sending any more.
  3363. if k >= maxConcurrent {
  3364. <-unblockClient
  3365. }
  3366. req, _ := http.NewRequest("GET", fmt.Sprintf("https://dummy.tld/%d", k), nil)
  3367. if k == maxConcurrent {
  3368. // This request will be canceled.
  3369. cancel := make(chan struct{})
  3370. req.Cancel = cancel
  3371. close(cancel)
  3372. _, err := ct.tr.RoundTrip(req)
  3373. close(clientRequestCancelled)
  3374. if err == nil {
  3375. errs <- fmt.Errorf("RoundTrip(%d) should have failed due to cancel", k)
  3376. return
  3377. }
  3378. } else {
  3379. resp, err := ct.tr.RoundTrip(req)
  3380. if err != nil {
  3381. errs <- fmt.Errorf("RoundTrip(%d): %v", k, err)
  3382. return
  3383. }
  3384. ioutil.ReadAll(resp.Body)
  3385. resp.Body.Close()
  3386. if resp.StatusCode != 204 {
  3387. errs <- fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3388. return
  3389. }
  3390. }
  3391. }(k)
  3392. }
  3393. return nil
  3394. }
  3395. ct.server = func() error {
  3396. var wg sync.WaitGroup
  3397. defer wg.Wait()
  3398. ct.greet(Setting{SettingMaxConcurrentStreams, maxConcurrent})
  3399. // Server write loop.
  3400. var buf bytes.Buffer
  3401. enc := hpack.NewEncoder(&buf)
  3402. writeResp := make(chan uint32, maxConcurrent+1)
  3403. wg.Add(1)
  3404. go func() {
  3405. defer wg.Done()
  3406. <-unblockServer
  3407. for id := range writeResp {
  3408. buf.Reset()
  3409. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3410. ct.fr.WriteHeaders(HeadersFrameParam{
  3411. StreamID: id,
  3412. EndHeaders: true,
  3413. EndStream: true,
  3414. BlockFragment: buf.Bytes(),
  3415. })
  3416. }
  3417. }()
  3418. // Server read loop.
  3419. var nreq int
  3420. for {
  3421. f, err := ct.fr.ReadFrame()
  3422. if err != nil {
  3423. select {
  3424. case <-clientDone:
  3425. // If the client's done, it will have reported any errors on its side.
  3426. return nil
  3427. default:
  3428. return err
  3429. }
  3430. }
  3431. switch f := f.(type) {
  3432. case *WindowUpdateFrame:
  3433. case *SettingsFrame:
  3434. // Wait for the client SETTINGS ack until ending the greet.
  3435. close(greet)
  3436. case *HeadersFrame:
  3437. if !f.HeadersEnded() {
  3438. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3439. }
  3440. gotRequest <- struct{}{}
  3441. nreq++
  3442. writeResp <- f.StreamID
  3443. if nreq == maxConcurrent+1 {
  3444. close(writeResp)
  3445. }
  3446. default:
  3447. return fmt.Errorf("Unexpected client frame %v", f)
  3448. }
  3449. }
  3450. }
  3451. ct.run()
  3452. }
  3453. func TestAuthorityAddr(t *testing.T) {
  3454. tests := []struct {
  3455. scheme, authority string
  3456. want string
  3457. }{
  3458. {"http", "foo.com", "foo.com:80"},
  3459. {"https", "foo.com", "foo.com:443"},
  3460. {"https", "foo.com:1234", "foo.com:1234"},
  3461. {"https", "1.2.3.4:1234", "1.2.3.4:1234"},
  3462. {"https", "1.2.3.4", "1.2.3.4:443"},
  3463. {"https", "[::1]:1234", "[::1]:1234"},
  3464. {"https", "[::1]", "[::1]:443"},
  3465. }
  3466. for _, tt := range tests {
  3467. got := authorityAddr(tt.scheme, tt.authority)
  3468. if got != tt.want {
  3469. t.Errorf("authorityAddr(%q, %q) = %q; want %q", tt.scheme, tt.authority, got, tt.want)
  3470. }
  3471. }
  3472. }
  3473. // Issue 20448: stop allocating for DATA frames' payload after
  3474. // Response.Body.Close is called.
  3475. func TestTransportAllocationsAfterResponseBodyClose(t *testing.T) {
  3476. megabyteZero := make([]byte, 1<<20)
  3477. writeErr := make(chan error, 1)
  3478. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3479. w.(http.Flusher).Flush()
  3480. var sum int64
  3481. for i := 0; i < 100; i++ {
  3482. n, err := w.Write(megabyteZero)
  3483. sum += int64(n)
  3484. if err != nil {
  3485. writeErr <- err
  3486. return
  3487. }
  3488. }
  3489. t.Logf("wrote all %d bytes", sum)
  3490. writeErr <- nil
  3491. }, optOnlyServer)
  3492. defer st.Close()
  3493. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3494. defer tr.CloseIdleConnections()
  3495. c := &http.Client{Transport: tr}
  3496. res, err := c.Get(st.ts.URL)
  3497. if err != nil {
  3498. t.Fatal(err)
  3499. }
  3500. var buf [1]byte
  3501. if _, err := res.Body.Read(buf[:]); err != nil {
  3502. t.Error(err)
  3503. }
  3504. if err := res.Body.Close(); err != nil {
  3505. t.Error(err)
  3506. }
  3507. trb, ok := res.Body.(transportResponseBody)
  3508. if !ok {
  3509. t.Fatalf("res.Body = %T; want transportResponseBody", res.Body)
  3510. }
  3511. if trb.cs.bufPipe.b != nil {
  3512. t.Errorf("response body pipe is still open")
  3513. }
  3514. gotErr := <-writeErr
  3515. if gotErr == nil {
  3516. t.Errorf("Handler unexpectedly managed to write its entire response without getting an error")
  3517. } else if gotErr != errStreamClosed {
  3518. t.Errorf("Handler Write err = %v; want errStreamClosed", gotErr)
  3519. }
  3520. }
  3521. // Issue 18891: make sure Request.Body == NoBody means no DATA frame
  3522. // is ever sent, even if empty.
  3523. func TestTransportNoBodyMeansNoDATA(t *testing.T) {
  3524. ct := newClientTester(t)
  3525. unblockClient := make(chan bool)
  3526. ct.client = func() error {
  3527. req, _ := http.NewRequest("GET", "https://dummy.tld/", http.NoBody)
  3528. ct.tr.RoundTrip(req)
  3529. <-unblockClient
  3530. return nil
  3531. }
  3532. ct.server = func() error {
  3533. defer close(unblockClient)
  3534. defer ct.cc.(*net.TCPConn).Close()
  3535. ct.greet()
  3536. for {
  3537. f, err := ct.fr.ReadFrame()
  3538. if err != nil {
  3539. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  3540. }
  3541. switch f := f.(type) {
  3542. default:
  3543. return fmt.Errorf("Got %T; want HeadersFrame", f)
  3544. case *WindowUpdateFrame, *SettingsFrame:
  3545. continue
  3546. case *HeadersFrame:
  3547. if !f.StreamEnded() {
  3548. return fmt.Errorf("got headers frame without END_STREAM")
  3549. }
  3550. return nil
  3551. }
  3552. }
  3553. }
  3554. ct.run()
  3555. }
  3556. func benchSimpleRoundTrip(b *testing.B, nHeaders int) {
  3557. defer disableGoroutineTracking()()
  3558. b.ReportAllocs()
  3559. st := newServerTester(b,
  3560. func(w http.ResponseWriter, r *http.Request) {
  3561. },
  3562. optOnlyServer,
  3563. optQuiet,
  3564. )
  3565. defer st.Close()
  3566. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3567. defer tr.CloseIdleConnections()
  3568. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3569. if err != nil {
  3570. b.Fatal(err)
  3571. }
  3572. for i := 0; i < nHeaders; i++ {
  3573. name := fmt.Sprint("A-", i)
  3574. req.Header.Set(name, "*")
  3575. }
  3576. b.ResetTimer()
  3577. for i := 0; i < b.N; i++ {
  3578. res, err := tr.RoundTrip(req)
  3579. if err != nil {
  3580. if res != nil {
  3581. res.Body.Close()
  3582. }
  3583. b.Fatalf("RoundTrip err = %v; want nil", err)
  3584. }
  3585. res.Body.Close()
  3586. if res.StatusCode != http.StatusOK {
  3587. b.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3588. }
  3589. }
  3590. }
  3591. type infiniteReader struct{}
  3592. func (r infiniteReader) Read(b []byte) (int, error) {
  3593. return len(b), nil
  3594. }
  3595. // Issue 20521: it is not an error to receive a response and end stream
  3596. // from the server without the body being consumed.
  3597. func TestTransportResponseAndResetWithoutConsumingBodyRace(t *testing.T) {
  3598. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3599. w.WriteHeader(http.StatusOK)
  3600. }, optOnlyServer)
  3601. defer st.Close()
  3602. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3603. defer tr.CloseIdleConnections()
  3604. // The request body needs to be big enough to trigger flow control.
  3605. req, _ := http.NewRequest("PUT", st.ts.URL, infiniteReader{})
  3606. res, err := tr.RoundTrip(req)
  3607. if err != nil {
  3608. t.Fatal(err)
  3609. }
  3610. if res.StatusCode != http.StatusOK {
  3611. t.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3612. }
  3613. }
  3614. // Verify transport doesn't crash when receiving bogus response lacking a :status header.
  3615. // Issue 22880.
  3616. func TestTransportHandlesInvalidStatuslessResponse(t *testing.T) {
  3617. ct := newClientTester(t)
  3618. ct.client = func() error {
  3619. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3620. _, err := ct.tr.RoundTrip(req)
  3621. const substr = "malformed response from server: missing status pseudo header"
  3622. if !strings.Contains(fmt.Sprint(err), substr) {
  3623. return fmt.Errorf("RoundTrip error = %v; want substring %q", err, substr)
  3624. }
  3625. return nil
  3626. }
  3627. ct.server = func() error {
  3628. ct.greet()
  3629. var buf bytes.Buffer
  3630. enc := hpack.NewEncoder(&buf)
  3631. for {
  3632. f, err := ct.fr.ReadFrame()
  3633. if err != nil {
  3634. return err
  3635. }
  3636. switch f := f.(type) {
  3637. case *HeadersFrame:
  3638. enc.WriteField(hpack.HeaderField{Name: "content-type", Value: "text/html"}) // no :status header
  3639. ct.fr.WriteHeaders(HeadersFrameParam{
  3640. StreamID: f.StreamID,
  3641. EndHeaders: true,
  3642. EndStream: false, // we'll send some DATA to try to crash the transport
  3643. BlockFragment: buf.Bytes(),
  3644. })
  3645. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3646. return nil
  3647. }
  3648. }
  3649. }
  3650. ct.run()
  3651. }
  3652. func BenchmarkClientRequestHeaders(b *testing.B) {
  3653. b.Run(" 0 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 0) })
  3654. b.Run(" 10 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 10) })
  3655. b.Run(" 100 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 100) })
  3656. b.Run("1000 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 1000) })
  3657. }
  3658. func activeStreams(cc *ClientConn) int {
  3659. cc.mu.Lock()
  3660. defer cc.mu.Unlock()
  3661. return len(cc.streams)
  3662. }
  3663. type closeMode int
  3664. const (
  3665. closeAtHeaders closeMode = iota
  3666. closeAtBody
  3667. shutdown
  3668. shutdownCancel
  3669. )
  3670. // See golang.org/issue/17292
  3671. func testClientConnClose(t *testing.T, closeMode closeMode) {
  3672. clientDone := make(chan struct{})
  3673. defer close(clientDone)
  3674. handlerDone := make(chan struct{})
  3675. closeDone := make(chan struct{})
  3676. beforeHeader := func() {}
  3677. bodyWrite := func(w http.ResponseWriter) {}
  3678. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3679. defer close(handlerDone)
  3680. beforeHeader()
  3681. w.WriteHeader(http.StatusOK)
  3682. w.(http.Flusher).Flush()
  3683. bodyWrite(w)
  3684. select {
  3685. case <-w.(http.CloseNotifier).CloseNotify():
  3686. // client closed connection before completion
  3687. if closeMode == shutdown || closeMode == shutdownCancel {
  3688. t.Error("expected request to complete")
  3689. }
  3690. case <-clientDone:
  3691. if closeMode == closeAtHeaders || closeMode == closeAtBody {
  3692. t.Error("expected connection closed by client")
  3693. }
  3694. }
  3695. }, optOnlyServer)
  3696. defer st.Close()
  3697. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3698. defer tr.CloseIdleConnections()
  3699. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  3700. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3701. if err != nil {
  3702. t.Fatal(err)
  3703. }
  3704. if closeMode == closeAtHeaders {
  3705. beforeHeader = func() {
  3706. if err := cc.Close(); err != nil {
  3707. t.Error(err)
  3708. }
  3709. close(closeDone)
  3710. }
  3711. }
  3712. var sendBody chan struct{}
  3713. if closeMode == closeAtBody {
  3714. sendBody = make(chan struct{})
  3715. bodyWrite = func(w http.ResponseWriter) {
  3716. <-sendBody
  3717. b := make([]byte, 32)
  3718. w.Write(b)
  3719. w.(http.Flusher).Flush()
  3720. if err := cc.Close(); err != nil {
  3721. t.Errorf("unexpected ClientConn close error: %v", err)
  3722. }
  3723. close(closeDone)
  3724. w.Write(b)
  3725. w.(http.Flusher).Flush()
  3726. }
  3727. }
  3728. res, err := cc.RoundTrip(req)
  3729. if res != nil {
  3730. defer res.Body.Close()
  3731. }
  3732. if closeMode == closeAtHeaders {
  3733. got := fmt.Sprint(err)
  3734. want := "http2: client connection force closed via ClientConn.Close"
  3735. if got != want {
  3736. t.Fatalf("RoundTrip error = %v, want %v", got, want)
  3737. }
  3738. } else {
  3739. if err != nil {
  3740. t.Fatalf("RoundTrip: %v", err)
  3741. }
  3742. if got, want := activeStreams(cc), 1; got != want {
  3743. t.Errorf("got %d active streams, want %d", got, want)
  3744. }
  3745. }
  3746. switch closeMode {
  3747. case shutdownCancel:
  3748. if err = cc.Shutdown(canceledCtx); err != context.Canceled {
  3749. t.Errorf("got %v, want %v", err, context.Canceled)
  3750. }
  3751. if cc.closing == false {
  3752. t.Error("expected closing to be true")
  3753. }
  3754. if cc.CanTakeNewRequest() == true {
  3755. t.Error("CanTakeNewRequest to return false")
  3756. }
  3757. if v, want := len(cc.streams), 1; v != want {
  3758. t.Errorf("expected %d active streams, got %d", want, v)
  3759. }
  3760. clientDone <- struct{}{}
  3761. <-handlerDone
  3762. case shutdown:
  3763. wait := make(chan struct{})
  3764. shutdownEnterWaitStateHook = func() {
  3765. close(wait)
  3766. shutdownEnterWaitStateHook = func() {}
  3767. }
  3768. defer func() { shutdownEnterWaitStateHook = func() {} }()
  3769. shutdown := make(chan struct{}, 1)
  3770. go func() {
  3771. if err = cc.Shutdown(context.Background()); err != nil {
  3772. t.Error(err)
  3773. }
  3774. close(shutdown)
  3775. }()
  3776. // Let the shutdown to enter wait state
  3777. <-wait
  3778. cc.mu.Lock()
  3779. if cc.closing == false {
  3780. t.Error("expected closing to be true")
  3781. }
  3782. cc.mu.Unlock()
  3783. if cc.CanTakeNewRequest() == true {
  3784. t.Error("CanTakeNewRequest to return false")
  3785. }
  3786. if got, want := activeStreams(cc), 1; got != want {
  3787. t.Errorf("got %d active streams, want %d", got, want)
  3788. }
  3789. // Let the active request finish
  3790. clientDone <- struct{}{}
  3791. // Wait for the shutdown to end
  3792. select {
  3793. case <-shutdown:
  3794. case <-time.After(2 * time.Second):
  3795. t.Fatal("expected server connection to close")
  3796. }
  3797. case closeAtHeaders, closeAtBody:
  3798. if closeMode == closeAtBody {
  3799. go close(sendBody)
  3800. if _, err := io.Copy(ioutil.Discard, res.Body); err == nil {
  3801. t.Error("expected a Copy error, got nil")
  3802. }
  3803. }
  3804. <-closeDone
  3805. if got, want := activeStreams(cc), 0; got != want {
  3806. t.Errorf("got %d active streams, want %d", got, want)
  3807. }
  3808. // wait for server to get the connection close notice
  3809. select {
  3810. case <-handlerDone:
  3811. case <-time.After(2 * time.Second):
  3812. t.Fatal("expected server connection to close")
  3813. }
  3814. }
  3815. }
  3816. // The client closes the connection just after the server got the client's HEADERS
  3817. // frame, but before the server sends its HEADERS response back. The expected
  3818. // result is an error on RoundTrip explaining the client closed the connection.
  3819. func TestClientConnCloseAtHeaders(t *testing.T) {
  3820. testClientConnClose(t, closeAtHeaders)
  3821. }
  3822. // The client closes the connection between two server's response DATA frames.
  3823. // The expected behavior is a response body io read error on the client.
  3824. func TestClientConnCloseAtBody(t *testing.T) {
  3825. testClientConnClose(t, closeAtBody)
  3826. }
  3827. // The client sends a GOAWAY frame before the server finished processing a request.
  3828. // We expect the connection not to close until the request is completed.
  3829. func TestClientConnShutdown(t *testing.T) {
  3830. testClientConnClose(t, shutdown)
  3831. }
  3832. // The client sends a GOAWAY frame before the server finishes processing a request,
  3833. // but cancels the passed context before the request is completed. The expected
  3834. // behavior is the client closing the connection after the context is canceled.
  3835. func TestClientConnShutdownCancel(t *testing.T) {
  3836. testClientConnClose(t, shutdownCancel)
  3837. }
  3838. // Issue 25009: use Request.GetBody if present, even if it seems like
  3839. // we might not need it. Apparently something else can still read from
  3840. // the original request body. Data race? In any case, rewinding
  3841. // unconditionally on retry is a nicer model anyway and should
  3842. // simplify code in the future (after the Go 1.11 freeze)
  3843. func TestTransportUsesGetBodyWhenPresent(t *testing.T) {
  3844. calls := 0
  3845. someBody := func() io.ReadCloser {
  3846. return struct{ io.ReadCloser }{ioutil.NopCloser(bytes.NewReader(nil))}
  3847. }
  3848. req := &http.Request{
  3849. Body: someBody(),
  3850. GetBody: func() (io.ReadCloser, error) {
  3851. calls++
  3852. return someBody(), nil
  3853. },
  3854. }
  3855. afterBodyWrite := false // pretend we haven't read+written the body yet
  3856. req2, err := shouldRetryRequest(req, errClientConnUnusable, afterBodyWrite)
  3857. if err != nil {
  3858. t.Fatal(err)
  3859. }
  3860. if calls != 1 {
  3861. t.Errorf("Calls = %d; want 1", calls)
  3862. }
  3863. if req2 == req {
  3864. t.Error("req2 changed")
  3865. }
  3866. if req2 == nil {
  3867. t.Fatal("req2 is nil")
  3868. }
  3869. if req2.Body == nil {
  3870. t.Fatal("req2.Body is nil")
  3871. }
  3872. if req2.GetBody == nil {
  3873. t.Fatal("req2.GetBody is nil")
  3874. }
  3875. if req2.Body == req.Body {
  3876. t.Error("req2.Body unchanged")
  3877. }
  3878. }
  3879. // Issue 22891: verify that the "https" altproto we register with net/http
  3880. // is a certain type: a struct with one field with our *http2.Transport in it.
  3881. func TestNoDialH2RoundTripperType(t *testing.T) {
  3882. t1 := new(http.Transport)
  3883. t2 := new(Transport)
  3884. rt := noDialH2RoundTripper{t2}
  3885. if err := registerHTTPSProtocol(t1, rt); err != nil {
  3886. t.Fatal(err)
  3887. }
  3888. rv := reflect.ValueOf(rt)
  3889. if rv.Type().Kind() != reflect.Struct {
  3890. t.Fatalf("kind = %v; net/http expects struct", rv.Type().Kind())
  3891. }
  3892. if n := rv.Type().NumField(); n != 1 {
  3893. t.Fatalf("fields = %d; net/http expects 1", n)
  3894. }
  3895. v := rv.Field(0)
  3896. if _, ok := v.Interface().(*Transport); !ok {
  3897. t.Fatalf("wrong kind %T; want *Transport", v.Interface())
  3898. }
  3899. }
  3900. type errReader struct {
  3901. body []byte
  3902. err error
  3903. }
  3904. func (r *errReader) Read(p []byte) (int, error) {
  3905. if len(r.body) > 0 {
  3906. n := copy(p, r.body)
  3907. r.body = r.body[n:]
  3908. return n, nil
  3909. }
  3910. return 0, r.err
  3911. }
  3912. func testTransportBodyReadError(t *testing.T, body []byte) {
  3913. clientDone := make(chan struct{})
  3914. ct := newClientTester(t)
  3915. ct.client = func() error {
  3916. defer ct.cc.(*net.TCPConn).CloseWrite()
  3917. defer close(clientDone)
  3918. checkNoStreams := func() error {
  3919. cp, ok := ct.tr.connPool().(*clientConnPool)
  3920. if !ok {
  3921. return fmt.Errorf("conn pool is %T; want *clientConnPool", ct.tr.connPool())
  3922. }
  3923. cp.mu.Lock()
  3924. defer cp.mu.Unlock()
  3925. conns, ok := cp.conns["dummy.tld:443"]
  3926. if !ok {
  3927. return fmt.Errorf("missing connection")
  3928. }
  3929. if len(conns) != 1 {
  3930. return fmt.Errorf("conn pool size: %v; expect 1", len(conns))
  3931. }
  3932. if activeStreams(conns[0]) != 0 {
  3933. return fmt.Errorf("active streams count: %v; want 0", activeStreams(conns[0]))
  3934. }
  3935. return nil
  3936. }
  3937. bodyReadError := errors.New("body read error")
  3938. body := &errReader{body, bodyReadError}
  3939. req, err := http.NewRequest("PUT", "https://dummy.tld/", body)
  3940. if err != nil {
  3941. return err
  3942. }
  3943. _, err = ct.tr.RoundTrip(req)
  3944. if err != bodyReadError {
  3945. return fmt.Errorf("err = %v; want %v", err, bodyReadError)
  3946. }
  3947. if err = checkNoStreams(); err != nil {
  3948. return err
  3949. }
  3950. return nil
  3951. }
  3952. ct.server = func() error {
  3953. ct.greet()
  3954. var receivedBody []byte
  3955. var resetCount int
  3956. for {
  3957. f, err := ct.fr.ReadFrame()
  3958. if err != nil {
  3959. select {
  3960. case <-clientDone:
  3961. // If the client's done, it
  3962. // will have reported any
  3963. // errors on its side.
  3964. if bytes.Compare(receivedBody, body) != 0 {
  3965. return fmt.Errorf("body: %v; expected %v", receivedBody, body)
  3966. }
  3967. if resetCount != 1 {
  3968. return fmt.Errorf("stream reset count: %v; expected: 1", resetCount)
  3969. }
  3970. return nil
  3971. default:
  3972. return err
  3973. }
  3974. }
  3975. switch f := f.(type) {
  3976. case *WindowUpdateFrame, *SettingsFrame:
  3977. case *HeadersFrame:
  3978. case *DataFrame:
  3979. receivedBody = append(receivedBody, f.Data()...)
  3980. case *RSTStreamFrame:
  3981. resetCount++
  3982. default:
  3983. return fmt.Errorf("Unexpected client frame %v", f)
  3984. }
  3985. }
  3986. }
  3987. ct.run()
  3988. }
  3989. func TestTransportBodyReadError_Immediately(t *testing.T) { testTransportBodyReadError(t, nil) }
  3990. func TestTransportBodyReadError_Some(t *testing.T) { testTransportBodyReadError(t, []byte("123")) }