Browse Source

x/net/ipv4: better wording for TODOs

LGTM=iant
R=iant
CC=golang-codereviews
https://golang.org/cl/167450043
Mikio Hara 11 years ago
parent
commit
3064e1c1ca
1 changed files with 3 additions and 3 deletions
  1. 3 3
      ipv4/header.go

+ 3 - 3
ipv4/header.go

@@ -100,7 +100,7 @@ func (h *Header) Marshal() ([]byte, error) {
 		b[posTotalLen], b[posTotalLen+1] = byte(h.TotalLen>>8), byte(h.TotalLen)
 		b[posTotalLen], b[posTotalLen+1] = byte(h.TotalLen>>8), byte(h.TotalLen)
 		b[posFragOff], b[posFragOff+1] = byte(flagsAndFragOff>>8), byte(flagsAndFragOff)
 		b[posFragOff], b[posFragOff+1] = byte(flagsAndFragOff>>8), byte(flagsAndFragOff)
 	} else {
 	} else {
-		// TODO(mikio): fix spurious word boundary access
+		// TODO(mikio): fix potential misaligned memory access
 		*(*uint16)(unsafe.Pointer(&b[posTotalLen : posTotalLen+1][0])) = uint16(h.TotalLen)
 		*(*uint16)(unsafe.Pointer(&b[posTotalLen : posTotalLen+1][0])) = uint16(h.TotalLen)
 		*(*uint16)(unsafe.Pointer(&b[posFragOff : posFragOff+1][0])) = uint16(flagsAndFragOff)
 		*(*uint16)(unsafe.Pointer(&b[posFragOff : posFragOff+1][0])) = uint16(flagsAndFragOff)
 	}
 	}
@@ -142,12 +142,12 @@ func ParseHeader(b []byte) (*Header, error) {
 		h.TotalLen = int(b[posTotalLen])<<8 | int(b[posTotalLen+1])
 		h.TotalLen = int(b[posTotalLen])<<8 | int(b[posTotalLen+1])
 		h.FragOff = int(b[posFragOff])<<8 | int(b[posFragOff+1])
 		h.FragOff = int(b[posFragOff])<<8 | int(b[posFragOff+1])
 	} else {
 	} else {
-		// TODO(mikio): fix spurious word boundary access
+		// TODO(mikio): fix potential misaligned memory access
 		h.TotalLen = int(*(*uint16)(unsafe.Pointer(&b[posTotalLen : posTotalLen+1][0])))
 		h.TotalLen = int(*(*uint16)(unsafe.Pointer(&b[posTotalLen : posTotalLen+1][0])))
 		if runtime.GOOS != "freebsd" || freebsdVersion < 1000000 {
 		if runtime.GOOS != "freebsd" || freebsdVersion < 1000000 {
 			h.TotalLen += hdrlen
 			h.TotalLen += hdrlen
 		}
 		}
-		// TODO(mikio): fix spurious word boundary access
+		// TODO(mikio): fix potential misaligned memory access
 		h.FragOff = int(*(*uint16)(unsafe.Pointer(&b[posFragOff : posFragOff+1][0])))
 		h.FragOff = int(*(*uint16)(unsafe.Pointer(&b[posFragOff : posFragOff+1][0])))
 	}
 	}
 	h.Flags = HeaderFlags(h.FragOff&0xe000) >> 13
 	h.Flags = HeaderFlags(h.FragOff&0xe000) >> 13