encode_test.go 26 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099
  1. // Copyright 2018 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package textpb_test
  5. import (
  6. "encoding/hex"
  7. "math"
  8. "strings"
  9. "testing"
  10. protoV1 "github.com/golang/protobuf/proto"
  11. "github.com/golang/protobuf/protoapi"
  12. "github.com/golang/protobuf/v2/encoding/textpb"
  13. "github.com/golang/protobuf/v2/internal/detrand"
  14. "github.com/golang/protobuf/v2/internal/encoding/pack"
  15. "github.com/golang/protobuf/v2/internal/encoding/wire"
  16. "github.com/golang/protobuf/v2/internal/impl"
  17. "github.com/golang/protobuf/v2/internal/legacy"
  18. "github.com/golang/protobuf/v2/internal/scalar"
  19. "github.com/golang/protobuf/v2/proto"
  20. preg "github.com/golang/protobuf/v2/reflect/protoregistry"
  21. "github.com/google/go-cmp/cmp"
  22. "github.com/google/go-cmp/cmp/cmpopts"
  23. // The legacy package must be imported prior to use of any legacy messages.
  24. // TODO: Remove this when protoV1 registers these hooks for you.
  25. _ "github.com/golang/protobuf/v2/internal/legacy"
  26. anypb "github.com/golang/protobuf/ptypes/any"
  27. "github.com/golang/protobuf/v2/encoding/textpb/testprotos/pb2"
  28. "github.com/golang/protobuf/v2/encoding/textpb/testprotos/pb3"
  29. )
  30. func init() {
  31. // Disable detrand to enable direct comparisons on outputs.
  32. detrand.Disable()
  33. }
  34. // splitLines is a cmpopts.Option for comparing strings with line breaks.
  35. var splitLines = cmpopts.AcyclicTransformer("SplitLines", func(s string) []string {
  36. return strings.Split(s, "\n")
  37. })
  38. func pb2Enum(i int32) *pb2.Enum {
  39. p := new(pb2.Enum)
  40. *p = pb2.Enum(i)
  41. return p
  42. }
  43. func pb2Enums_NestedEnum(i int32) *pb2.Enums_NestedEnum {
  44. p := new(pb2.Enums_NestedEnum)
  45. *p = pb2.Enums_NestedEnum(i)
  46. return p
  47. }
  48. func setExtension(m proto.Message, xd *protoapi.ExtensionDesc, val interface{}) {
  49. xt := legacy.Export{}.ExtensionTypeFromDesc(xd)
  50. knownFields := m.ProtoReflect().KnownFields()
  51. extTypes := knownFields.ExtensionTypes()
  52. extTypes.Register(xt)
  53. if val == nil {
  54. return
  55. }
  56. pval := xt.ValueOf(val)
  57. knownFields.Set(wire.Number(xd.Field), pval)
  58. }
  59. func wrapAnyPB(any *anypb.Any) proto.Message {
  60. return impl.Export{}.MessageOf(any).Interface()
  61. }
  62. // dhex decodes a hex-string and returns the bytes and panics if s is invalid.
  63. func dhex(s string) []byte {
  64. b, err := hex.DecodeString(s)
  65. if err != nil {
  66. panic(err)
  67. }
  68. return b
  69. }
  70. func TestMarshal(t *testing.T) {
  71. tests := []struct {
  72. desc string
  73. mo textpb.MarshalOptions
  74. input proto.Message
  75. want string
  76. wantErr bool
  77. }{{
  78. desc: "proto2 optional scalar fields not set",
  79. input: &pb2.Scalars{},
  80. want: "\n",
  81. }, {
  82. desc: "proto3 scalar fields not set",
  83. input: &pb3.Scalars{},
  84. want: "\n",
  85. }, {
  86. desc: "proto2 optional scalar fields set to zero values",
  87. input: &pb2.Scalars{
  88. OptBool: scalar.Bool(false),
  89. OptInt32: scalar.Int32(0),
  90. OptInt64: scalar.Int64(0),
  91. OptUint32: scalar.Uint32(0),
  92. OptUint64: scalar.Uint64(0),
  93. OptSint32: scalar.Int32(0),
  94. OptSint64: scalar.Int64(0),
  95. OptFixed32: scalar.Uint32(0),
  96. OptFixed64: scalar.Uint64(0),
  97. OptSfixed32: scalar.Int32(0),
  98. OptSfixed64: scalar.Int64(0),
  99. OptFloat: scalar.Float32(0),
  100. OptDouble: scalar.Float64(0),
  101. OptBytes: []byte{},
  102. OptString: scalar.String(""),
  103. },
  104. want: `opt_bool: false
  105. opt_int32: 0
  106. opt_int64: 0
  107. opt_uint32: 0
  108. opt_uint64: 0
  109. opt_sint32: 0
  110. opt_sint64: 0
  111. opt_fixed32: 0
  112. opt_fixed64: 0
  113. opt_sfixed32: 0
  114. opt_sfixed64: 0
  115. opt_float: 0
  116. opt_double: 0
  117. opt_bytes: ""
  118. opt_string: ""
  119. `,
  120. }, {
  121. desc: "proto3 scalar fields set to zero values",
  122. input: &pb3.Scalars{
  123. SBool: false,
  124. SInt32: 0,
  125. SInt64: 0,
  126. SUint32: 0,
  127. SUint64: 0,
  128. SSint32: 0,
  129. SSint64: 0,
  130. SFixed32: 0,
  131. SFixed64: 0,
  132. SSfixed32: 0,
  133. SSfixed64: 0,
  134. SFloat: 0,
  135. SDouble: 0,
  136. SBytes: []byte{},
  137. SString: "",
  138. },
  139. want: "\n",
  140. }, {
  141. desc: "proto2 optional scalar fields set to some values",
  142. input: &pb2.Scalars{
  143. OptBool: scalar.Bool(true),
  144. OptInt32: scalar.Int32(0xff),
  145. OptInt64: scalar.Int64(0xdeadbeef),
  146. OptUint32: scalar.Uint32(47),
  147. OptUint64: scalar.Uint64(0xdeadbeef),
  148. OptSint32: scalar.Int32(-1001),
  149. OptSint64: scalar.Int64(-0xffff),
  150. OptFixed64: scalar.Uint64(64),
  151. OptSfixed32: scalar.Int32(-32),
  152. // TODO: Update encoder to output same decimals.
  153. OptFloat: scalar.Float32(1.02),
  154. OptDouble: scalar.Float64(1.23e100),
  155. // TODO: Update encoder to not output UTF8 for bytes.
  156. OptBytes: []byte("\xe8\xb0\xb7\xe6\xad\x8c"),
  157. OptString: scalar.String("谷歌"),
  158. },
  159. want: `opt_bool: true
  160. opt_int32: 255
  161. opt_int64: 3735928559
  162. opt_uint32: 47
  163. opt_uint64: 3735928559
  164. opt_sint32: -1001
  165. opt_sint64: -65535
  166. opt_fixed64: 64
  167. opt_sfixed32: -32
  168. opt_float: 1.0199999809265137
  169. opt_double: 1.23e+100
  170. opt_bytes: "谷歌"
  171. opt_string: "谷歌"
  172. `,
  173. }, {
  174. desc: "float32 nan",
  175. input: &pb3.Scalars{
  176. SFloat: float32(math.NaN()),
  177. },
  178. want: "s_float: nan\n",
  179. }, {
  180. desc: "float32 positive infinity",
  181. input: &pb3.Scalars{
  182. SFloat: float32(math.Inf(1)),
  183. },
  184. want: "s_float: inf\n",
  185. }, {
  186. desc: "float32 negative infinity",
  187. input: &pb3.Scalars{
  188. SFloat: float32(math.Inf(-1)),
  189. },
  190. want: "s_float: -inf\n",
  191. }, {
  192. desc: "float64 nan",
  193. input: &pb3.Scalars{
  194. SDouble: math.NaN(),
  195. },
  196. want: "s_double: nan\n",
  197. }, {
  198. desc: "float64 positive infinity",
  199. input: &pb3.Scalars{
  200. SDouble: math.Inf(1),
  201. },
  202. want: "s_double: inf\n",
  203. }, {
  204. desc: "float64 negative infinity",
  205. input: &pb3.Scalars{
  206. SDouble: math.Inf(-1),
  207. },
  208. want: "s_double: -inf\n",
  209. }, {
  210. desc: "proto2 bytes set to empty string",
  211. input: &pb2.Scalars{
  212. OptBytes: []byte(""),
  213. },
  214. want: "opt_bytes: \"\"\n",
  215. }, {
  216. desc: "proto3 bytes set to empty string",
  217. input: &pb3.Scalars{
  218. SBytes: []byte(""),
  219. },
  220. want: "\n",
  221. }, {
  222. desc: "proto2 enum not set",
  223. input: &pb2.Enums{},
  224. want: "\n",
  225. }, {
  226. desc: "proto2 enum set to zero value",
  227. input: &pb2.Enums{
  228. OptEnum: pb2.Enum_UNKNOWN.Enum(),
  229. OptNestedEnum: pb2Enums_NestedEnum(0),
  230. },
  231. want: `opt_enum: UNKNOWN
  232. opt_nested_enum: 0
  233. `,
  234. }, {
  235. desc: "proto2 enum",
  236. input: &pb2.Enums{
  237. OptEnum: pb2.Enum_FIRST.Enum(),
  238. OptNestedEnum: pb2.Enums_UNO.Enum(),
  239. },
  240. want: `opt_enum: FIRST
  241. opt_nested_enum: UNO
  242. `,
  243. }, {
  244. desc: "proto2 enum set to numeric values",
  245. input: &pb2.Enums{
  246. OptEnum: pb2Enum(1),
  247. OptNestedEnum: pb2Enums_NestedEnum(2),
  248. },
  249. want: `opt_enum: FIRST
  250. opt_nested_enum: DOS
  251. `,
  252. }, {
  253. desc: "proto2 enum set to unnamed numeric values",
  254. input: &pb2.Enums{
  255. OptEnum: pb2Enum(101),
  256. OptNestedEnum: pb2Enums_NestedEnum(-101),
  257. },
  258. want: `opt_enum: 101
  259. opt_nested_enum: -101
  260. `,
  261. }, {
  262. desc: "proto3 enum not set",
  263. input: &pb3.Enums{},
  264. want: "\n",
  265. }, {
  266. desc: "proto3 enum set to zero value",
  267. input: &pb3.Enums{
  268. SEnum: pb3.Enum_ZERO,
  269. SNestedEnum: pb3.Enums_CERO,
  270. },
  271. want: "\n",
  272. }, {
  273. desc: "proto3 enum",
  274. input: &pb3.Enums{
  275. SEnum: pb3.Enum_ONE,
  276. SNestedEnum: pb3.Enums_DIEZ,
  277. },
  278. want: `s_enum: ONE
  279. s_nested_enum: DIEZ
  280. `,
  281. }, {
  282. desc: "proto3 enum set to numeric values",
  283. input: &pb3.Enums{
  284. SEnum: 2,
  285. SNestedEnum: 1,
  286. },
  287. want: `s_enum: TWO
  288. s_nested_enum: UNO
  289. `,
  290. }, {
  291. desc: "proto3 enum set to unnamed numeric values",
  292. input: &pb3.Enums{
  293. SEnum: -47,
  294. SNestedEnum: 47,
  295. },
  296. want: `s_enum: -47
  297. s_nested_enum: 47
  298. `,
  299. }, {
  300. desc: "proto2 nested message not set",
  301. input: &pb2.Nests{},
  302. want: "\n",
  303. }, {
  304. desc: "proto2 nested message set to empty",
  305. input: &pb2.Nests{
  306. OptNested: &pb2.Nested{},
  307. Optgroup: &pb2.Nests_OptGroup{},
  308. },
  309. want: `opt_nested: {}
  310. OptGroup: {}
  311. `,
  312. }, {
  313. desc: "proto2 nested messages",
  314. input: &pb2.Nests{
  315. OptNested: &pb2.Nested{
  316. OptString: scalar.String("nested message"),
  317. OptNested: &pb2.Nested{
  318. OptString: scalar.String("another nested message"),
  319. },
  320. },
  321. },
  322. want: `opt_nested: {
  323. opt_string: "nested message"
  324. opt_nested: {
  325. opt_string: "another nested message"
  326. }
  327. }
  328. `,
  329. }, {
  330. desc: "proto2 group fields",
  331. input: &pb2.Nests{
  332. Optgroup: &pb2.Nests_OptGroup{
  333. OptBool: scalar.Bool(true),
  334. OptString: scalar.String("inside a group"),
  335. OptNested: &pb2.Nested{
  336. OptString: scalar.String("nested message inside a group"),
  337. },
  338. Optnestedgroup: &pb2.Nests_OptGroup_OptNestedGroup{
  339. OptEnum: pb2.Enum_TENTH.Enum(),
  340. },
  341. },
  342. },
  343. want: `OptGroup: {
  344. opt_bool: true
  345. opt_string: "inside a group"
  346. opt_nested: {
  347. opt_string: "nested message inside a group"
  348. }
  349. OptNestedGroup: {
  350. opt_enum: TENTH
  351. }
  352. }
  353. `,
  354. }, {
  355. desc: "proto3 nested message not set",
  356. input: &pb3.Nests{},
  357. want: "\n",
  358. }, {
  359. desc: "proto3 nested message",
  360. input: &pb3.Nests{
  361. SNested: &pb3.Nested{
  362. SString: "nested message",
  363. SNested: &pb3.Nested{
  364. SString: "another nested message",
  365. },
  366. },
  367. },
  368. want: `s_nested: {
  369. s_string: "nested message"
  370. s_nested: {
  371. s_string: "another nested message"
  372. }
  373. }
  374. `,
  375. }, {
  376. desc: "oneof fields",
  377. input: &pb2.Oneofs{},
  378. want: "\n",
  379. }, {
  380. desc: "oneof field set to empty string",
  381. input: &pb2.Oneofs{
  382. Union: &pb2.Oneofs_Str{},
  383. },
  384. want: "str: \"\"\n",
  385. }, {
  386. desc: "oneof field set to string",
  387. input: &pb2.Oneofs{
  388. Union: &pb2.Oneofs_Str{
  389. Str: "hello",
  390. },
  391. },
  392. want: "str: \"hello\"\n",
  393. }, {
  394. desc: "oneof field set to empty message",
  395. input: &pb2.Oneofs{
  396. Union: &pb2.Oneofs_Msg{
  397. Msg: &pb2.Nested{},
  398. },
  399. },
  400. want: "msg: {}\n",
  401. }, {
  402. desc: "oneof field set to message",
  403. input: &pb2.Oneofs{
  404. Union: &pb2.Oneofs_Msg{
  405. Msg: &pb2.Nested{
  406. OptString: scalar.String("nested message"),
  407. },
  408. },
  409. },
  410. want: `msg: {
  411. opt_string: "nested message"
  412. }
  413. `,
  414. }, {
  415. desc: "repeated not set",
  416. input: &pb2.Repeats{},
  417. want: "\n",
  418. }, {
  419. desc: "repeated set to empty slices",
  420. input: &pb2.Repeats{
  421. RptBool: []bool{},
  422. RptInt32: []int32{},
  423. RptInt64: []int64{},
  424. RptUint32: []uint32{},
  425. RptUint64: []uint64{},
  426. RptFloat: []float32{},
  427. RptDouble: []float64{},
  428. RptBytes: [][]byte{},
  429. },
  430. want: "\n",
  431. }, {
  432. desc: "repeated set to some values",
  433. input: &pb2.Repeats{
  434. RptBool: []bool{true, false, true, true},
  435. RptInt32: []int32{1, 6, 0, 0},
  436. RptInt64: []int64{-64, 47},
  437. RptUint32: []uint32{0xff, 0xffff},
  438. RptUint64: []uint64{0xdeadbeef},
  439. // TODO: add float32 examples.
  440. RptDouble: []float64{math.NaN(), math.Inf(1), math.Inf(-1), 1.23e-308},
  441. RptString: []string{"hello", "世界"},
  442. RptBytes: [][]byte{
  443. []byte("hello"),
  444. []byte("\xe4\xb8\x96\xe7\x95\x8c"),
  445. },
  446. },
  447. want: `rpt_bool: true
  448. rpt_bool: false
  449. rpt_bool: true
  450. rpt_bool: true
  451. rpt_int32: 1
  452. rpt_int32: 6
  453. rpt_int32: 0
  454. rpt_int32: 0
  455. rpt_int64: -64
  456. rpt_int64: 47
  457. rpt_uint32: 255
  458. rpt_uint32: 65535
  459. rpt_uint64: 3735928559
  460. rpt_double: nan
  461. rpt_double: inf
  462. rpt_double: -inf
  463. rpt_double: 1.23e-308
  464. rpt_string: "hello"
  465. rpt_string: "世界"
  466. rpt_bytes: "hello"
  467. rpt_bytes: "世界"
  468. `,
  469. }, {
  470. desc: "repeated enum",
  471. input: &pb2.Enums{
  472. RptEnum: []pb2.Enum{pb2.Enum_FIRST, 2, pb2.Enum_TENTH, 42},
  473. RptNestedEnum: []pb2.Enums_NestedEnum{2, 47, 10},
  474. },
  475. want: `rpt_enum: FIRST
  476. rpt_enum: SECOND
  477. rpt_enum: TENTH
  478. rpt_enum: 42
  479. rpt_nested_enum: DOS
  480. rpt_nested_enum: 47
  481. rpt_nested_enum: DIEZ
  482. `,
  483. }, {
  484. desc: "repeated nested message set to empty",
  485. input: &pb2.Nests{
  486. RptNested: []*pb2.Nested{},
  487. Rptgroup: []*pb2.Nests_RptGroup{},
  488. },
  489. want: "\n",
  490. }, {
  491. desc: "repeated nested messages",
  492. input: &pb2.Nests{
  493. RptNested: []*pb2.Nested{
  494. {
  495. OptString: scalar.String("repeat nested one"),
  496. },
  497. {
  498. OptString: scalar.String("repeat nested two"),
  499. OptNested: &pb2.Nested{
  500. OptString: scalar.String("inside repeat nested two"),
  501. },
  502. },
  503. {},
  504. },
  505. },
  506. want: `rpt_nested: {
  507. opt_string: "repeat nested one"
  508. }
  509. rpt_nested: {
  510. opt_string: "repeat nested two"
  511. opt_nested: {
  512. opt_string: "inside repeat nested two"
  513. }
  514. }
  515. rpt_nested: {}
  516. `,
  517. }, {
  518. desc: "repeated group fields",
  519. input: &pb2.Nests{
  520. Rptgroup: []*pb2.Nests_RptGroup{
  521. {
  522. RptBool: []bool{true, false},
  523. },
  524. {},
  525. },
  526. },
  527. want: `RptGroup: {
  528. rpt_bool: true
  529. rpt_bool: false
  530. }
  531. RptGroup: {}
  532. `,
  533. }, {
  534. desc: "map fields empty",
  535. input: &pb2.Maps{},
  536. want: "\n",
  537. }, {
  538. desc: "map fields set to empty maps",
  539. input: &pb2.Maps{
  540. Int32ToStr: map[int32]string{},
  541. Sfixed64ToBool: map[int64]bool{},
  542. BoolToUint32: map[bool]uint32{},
  543. Uint64ToEnum: map[uint64]pb2.Enum{},
  544. StrToNested: map[string]*pb2.Nested{},
  545. StrToOneofs: map[string]*pb2.Oneofs{},
  546. },
  547. want: "\n",
  548. }, {
  549. desc: "map fields 1",
  550. input: &pb2.Maps{
  551. Int32ToStr: map[int32]string{
  552. -101: "-101",
  553. 0xff: "0xff",
  554. 0: "zero",
  555. },
  556. Sfixed64ToBool: map[int64]bool{
  557. 0xcafe: true,
  558. 0: false,
  559. },
  560. BoolToUint32: map[bool]uint32{
  561. true: 42,
  562. false: 101,
  563. },
  564. },
  565. want: `int32_to_str: {
  566. key: -101
  567. value: "-101"
  568. }
  569. int32_to_str: {
  570. key: 0
  571. value: "zero"
  572. }
  573. int32_to_str: {
  574. key: 255
  575. value: "0xff"
  576. }
  577. sfixed64_to_bool: {
  578. key: 0
  579. value: false
  580. }
  581. sfixed64_to_bool: {
  582. key: 51966
  583. value: true
  584. }
  585. bool_to_uint32: {
  586. key: false
  587. value: 101
  588. }
  589. bool_to_uint32: {
  590. key: true
  591. value: 42
  592. }
  593. `,
  594. }, {
  595. desc: "map fields 2",
  596. input: &pb2.Maps{
  597. Uint64ToEnum: map[uint64]pb2.Enum{
  598. 1: pb2.Enum_FIRST,
  599. 2: pb2.Enum_SECOND,
  600. 10: pb2.Enum_TENTH,
  601. },
  602. },
  603. want: `uint64_to_enum: {
  604. key: 1
  605. value: FIRST
  606. }
  607. uint64_to_enum: {
  608. key: 2
  609. value: SECOND
  610. }
  611. uint64_to_enum: {
  612. key: 10
  613. value: TENTH
  614. }
  615. `,
  616. }, {
  617. desc: "map fields 3",
  618. input: &pb2.Maps{
  619. StrToNested: map[string]*pb2.Nested{
  620. "nested_one": &pb2.Nested{
  621. OptString: scalar.String("nested in a map"),
  622. },
  623. },
  624. },
  625. want: `str_to_nested: {
  626. key: "nested_one"
  627. value: {
  628. opt_string: "nested in a map"
  629. }
  630. }
  631. `,
  632. }, {
  633. desc: "map fields 4",
  634. input: &pb2.Maps{
  635. StrToOneofs: map[string]*pb2.Oneofs{
  636. "string": &pb2.Oneofs{
  637. Union: &pb2.Oneofs_Str{
  638. Str: "hello",
  639. },
  640. },
  641. "nested": &pb2.Oneofs{
  642. Union: &pb2.Oneofs_Msg{
  643. Msg: &pb2.Nested{
  644. OptString: scalar.String("nested oneof in map field value"),
  645. },
  646. },
  647. },
  648. },
  649. },
  650. want: `str_to_oneofs: {
  651. key: "nested"
  652. value: {
  653. msg: {
  654. opt_string: "nested oneof in map field value"
  655. }
  656. }
  657. }
  658. str_to_oneofs: {
  659. key: "string"
  660. value: {
  661. str: "hello"
  662. }
  663. }
  664. `,
  665. }, {
  666. desc: "proto2 required fields not set",
  667. input: &pb2.Requireds{},
  668. want: "\n",
  669. wantErr: true,
  670. }, {
  671. desc: "proto2 required fields partially set",
  672. input: &pb2.Requireds{
  673. ReqBool: scalar.Bool(false),
  674. ReqFixed32: scalar.Uint32(47),
  675. ReqSfixed64: scalar.Int64(0xbeefcafe),
  676. ReqDouble: scalar.Float64(math.NaN()),
  677. ReqString: scalar.String("hello"),
  678. ReqEnum: pb2.Enum_FIRST.Enum(),
  679. },
  680. want: `req_bool: false
  681. req_fixed32: 47
  682. req_sfixed64: 3203386110
  683. req_double: nan
  684. req_string: "hello"
  685. req_enum: FIRST
  686. `,
  687. wantErr: true,
  688. }, {
  689. desc: "proto2 required fields all set",
  690. input: &pb2.Requireds{
  691. ReqBool: scalar.Bool(false),
  692. ReqFixed32: scalar.Uint32(0),
  693. ReqFixed64: scalar.Uint64(0),
  694. ReqSfixed32: scalar.Int32(0),
  695. ReqSfixed64: scalar.Int64(0),
  696. ReqFloat: scalar.Float32(0),
  697. ReqDouble: scalar.Float64(0),
  698. ReqString: scalar.String(""),
  699. ReqEnum: pb2.Enum_UNKNOWN.Enum(),
  700. ReqBytes: []byte{},
  701. ReqNested: &pb2.Nested{},
  702. },
  703. want: `req_bool: false
  704. req_fixed32: 0
  705. req_fixed64: 0
  706. req_sfixed32: 0
  707. req_sfixed64: 0
  708. req_float: 0
  709. req_double: 0
  710. req_string: ""
  711. req_bytes: ""
  712. req_enum: UNKNOWN
  713. req_nested: {}
  714. `,
  715. }, {
  716. desc: "indirect required field",
  717. input: &pb2.IndirectRequired{
  718. OptNested: &pb2.NestedWithRequired{},
  719. },
  720. want: "opt_nested: {}\n",
  721. wantErr: true,
  722. }, {
  723. desc: "indirect required field in empty repeated",
  724. input: &pb2.IndirectRequired{
  725. RptNested: []*pb2.NestedWithRequired{},
  726. },
  727. want: "\n",
  728. }, {
  729. desc: "indirect required field in repeated",
  730. input: &pb2.IndirectRequired{
  731. RptNested: []*pb2.NestedWithRequired{
  732. &pb2.NestedWithRequired{},
  733. },
  734. },
  735. want: "rpt_nested: {}\n",
  736. wantErr: true,
  737. }, {
  738. desc: "indirect required field in empty map",
  739. input: &pb2.IndirectRequired{
  740. StrToNested: map[string]*pb2.NestedWithRequired{},
  741. },
  742. want: "\n",
  743. }, {
  744. desc: "indirect required field in map",
  745. input: &pb2.IndirectRequired{
  746. StrToNested: map[string]*pb2.NestedWithRequired{
  747. "fail": &pb2.NestedWithRequired{},
  748. },
  749. },
  750. want: `str_to_nested: {
  751. key: "fail"
  752. value: {}
  753. }
  754. `,
  755. wantErr: true,
  756. }, {
  757. desc: "unknown varint and fixed types",
  758. input: &pb2.Scalars{
  759. OptString: scalar.String("this message contains unknown fields"),
  760. XXX_unrecognized: pack.Message{
  761. pack.Tag{101, pack.VarintType}, pack.Bool(true),
  762. pack.Tag{102, pack.VarintType}, pack.Varint(0xff),
  763. pack.Tag{103, pack.Fixed32Type}, pack.Uint32(47),
  764. pack.Tag{104, pack.Fixed64Type}, pack.Int64(0xdeadbeef),
  765. }.Marshal(),
  766. },
  767. want: `opt_string: "this message contains unknown fields"
  768. 101: 1
  769. 102: 255
  770. 103: 47
  771. 104: 3735928559
  772. `,
  773. }, {
  774. desc: "unknown length-delimited",
  775. input: &pb2.Scalars{
  776. XXX_unrecognized: pack.Message{
  777. pack.Tag{101, pack.BytesType}, pack.LengthPrefix{pack.Bool(true), pack.Bool(false)},
  778. pack.Tag{102, pack.BytesType}, pack.String("hello world"),
  779. pack.Tag{103, pack.BytesType}, pack.Bytes("\xe4\xb8\x96\xe7\x95\x8c"),
  780. }.Marshal(),
  781. },
  782. want: `101: "\x01\x00"
  783. 102: "hello world"
  784. 103: "世界"
  785. `,
  786. }, {
  787. desc: "unknown group type",
  788. input: &pb2.Scalars{
  789. XXX_unrecognized: pack.Message{
  790. pack.Tag{101, pack.StartGroupType}, pack.Tag{101, pack.EndGroupType},
  791. pack.Tag{102, pack.StartGroupType},
  792. pack.Tag{101, pack.VarintType}, pack.Bool(false),
  793. pack.Tag{102, pack.BytesType}, pack.String("inside a group"),
  794. pack.Tag{102, pack.EndGroupType},
  795. }.Marshal(),
  796. },
  797. want: `101: {}
  798. 102: {
  799. 101: 0
  800. 102: "inside a group"
  801. }
  802. `,
  803. }, {
  804. desc: "unknown unpack repeated field",
  805. input: &pb2.Scalars{
  806. XXX_unrecognized: pack.Message{
  807. pack.Tag{101, pack.BytesType}, pack.LengthPrefix{pack.Bool(true), pack.Bool(false), pack.Bool(true)},
  808. pack.Tag{102, pack.BytesType}, pack.String("hello"),
  809. pack.Tag{101, pack.VarintType}, pack.Bool(true),
  810. pack.Tag{102, pack.BytesType}, pack.String("世界"),
  811. }.Marshal(),
  812. },
  813. want: `101: "\x01\x00\x01"
  814. 101: 1
  815. 102: "hello"
  816. 102: "世界"
  817. `,
  818. }, {
  819. desc: "extensions of non-repeated fields",
  820. input: func() proto.Message {
  821. m := &pb2.Extensions{
  822. OptString: scalar.String("non-extension field"),
  823. OptBool: scalar.Bool(true),
  824. OptInt32: scalar.Int32(42),
  825. }
  826. setExtension(m, pb2.E_OptExtBool, true)
  827. setExtension(m, pb2.E_OptExtString, "extension field")
  828. setExtension(m, pb2.E_OptExtEnum, pb2.Enum_TENTH)
  829. setExtension(m, pb2.E_OptExtNested, &pb2.Nested{
  830. OptString: scalar.String("nested in an extension"),
  831. OptNested: &pb2.Nested{
  832. OptString: scalar.String("another nested in an extension"),
  833. },
  834. })
  835. return m
  836. }(),
  837. want: `opt_string: "non-extension field"
  838. opt_bool: true
  839. opt_int32: 42
  840. [pb2.opt_ext_bool]: true
  841. [pb2.opt_ext_enum]: TENTH
  842. [pb2.opt_ext_nested]: {
  843. opt_string: "nested in an extension"
  844. opt_nested: {
  845. opt_string: "another nested in an extension"
  846. }
  847. }
  848. [pb2.opt_ext_string]: "extension field"
  849. `,
  850. }, {
  851. desc: "registered extension but not set",
  852. input: func() proto.Message {
  853. m := &pb2.Extensions{}
  854. setExtension(m, pb2.E_OptExtNested, nil)
  855. return m
  856. }(),
  857. want: "\n",
  858. }, {
  859. desc: "extensions of repeated fields",
  860. input: func() proto.Message {
  861. m := &pb2.Extensions{}
  862. setExtension(m, pb2.E_RptExtEnum, &[]pb2.Enum{pb2.Enum_TENTH, 101, pb2.Enum_FIRST})
  863. setExtension(m, pb2.E_RptExtFixed32, &[]uint32{42, 47})
  864. setExtension(m, pb2.E_RptExtNested, &[]*pb2.Nested{
  865. &pb2.Nested{OptString: scalar.String("one")},
  866. &pb2.Nested{OptString: scalar.String("two")},
  867. &pb2.Nested{OptString: scalar.String("three")},
  868. })
  869. return m
  870. }(),
  871. want: `[pb2.rpt_ext_enum]: TENTH
  872. [pb2.rpt_ext_enum]: 101
  873. [pb2.rpt_ext_enum]: FIRST
  874. [pb2.rpt_ext_fixed32]: 42
  875. [pb2.rpt_ext_fixed32]: 47
  876. [pb2.rpt_ext_nested]: {
  877. opt_string: "one"
  878. }
  879. [pb2.rpt_ext_nested]: {
  880. opt_string: "two"
  881. }
  882. [pb2.rpt_ext_nested]: {
  883. opt_string: "three"
  884. }
  885. `,
  886. }, {
  887. desc: "extensions of non-repeated fields in another message",
  888. input: func() proto.Message {
  889. m := &pb2.Extensions{}
  890. setExtension(m, pb2.E_ExtensionsContainer_OptExtBool, true)
  891. setExtension(m, pb2.E_ExtensionsContainer_OptExtString, "extension field")
  892. setExtension(m, pb2.E_ExtensionsContainer_OptExtEnum, pb2.Enum_TENTH)
  893. setExtension(m, pb2.E_ExtensionsContainer_OptExtNested, &pb2.Nested{
  894. OptString: scalar.String("nested in an extension"),
  895. OptNested: &pb2.Nested{
  896. OptString: scalar.String("another nested in an extension"),
  897. },
  898. })
  899. return m
  900. }(),
  901. want: `[pb2.ExtensionsContainer.opt_ext_bool]: true
  902. [pb2.ExtensionsContainer.opt_ext_enum]: TENTH
  903. [pb2.ExtensionsContainer.opt_ext_nested]: {
  904. opt_string: "nested in an extension"
  905. opt_nested: {
  906. opt_string: "another nested in an extension"
  907. }
  908. }
  909. [pb2.ExtensionsContainer.opt_ext_string]: "extension field"
  910. `,
  911. }, {
  912. desc: "extensions of repeated fields in another message",
  913. input: func() proto.Message {
  914. m := &pb2.Extensions{
  915. OptString: scalar.String("non-extension field"),
  916. OptBool: scalar.Bool(true),
  917. OptInt32: scalar.Int32(42),
  918. }
  919. setExtension(m, pb2.E_ExtensionsContainer_RptExtEnum, &[]pb2.Enum{pb2.Enum_TENTH, 101, pb2.Enum_FIRST})
  920. setExtension(m, pb2.E_ExtensionsContainer_RptExtString, &[]string{"hello", "world"})
  921. setExtension(m, pb2.E_ExtensionsContainer_RptExtNested, &[]*pb2.Nested{
  922. &pb2.Nested{OptString: scalar.String("one")},
  923. &pb2.Nested{OptString: scalar.String("two")},
  924. &pb2.Nested{OptString: scalar.String("three")},
  925. })
  926. return m
  927. }(),
  928. want: `opt_string: "non-extension field"
  929. opt_bool: true
  930. opt_int32: 42
  931. [pb2.ExtensionsContainer.rpt_ext_enum]: TENTH
  932. [pb2.ExtensionsContainer.rpt_ext_enum]: 101
  933. [pb2.ExtensionsContainer.rpt_ext_enum]: FIRST
  934. [pb2.ExtensionsContainer.rpt_ext_nested]: {
  935. opt_string: "one"
  936. }
  937. [pb2.ExtensionsContainer.rpt_ext_nested]: {
  938. opt_string: "two"
  939. }
  940. [pb2.ExtensionsContainer.rpt_ext_nested]: {
  941. opt_string: "three"
  942. }
  943. [pb2.ExtensionsContainer.rpt_ext_string]: "hello"
  944. [pb2.ExtensionsContainer.rpt_ext_string]: "world"
  945. `,
  946. /* TODO: test for MessageSet
  947. }, {
  948. desc: "MessageSet",
  949. input: func() proto.Message {
  950. m := &pb2.MessageSet{}
  951. setExtension(m, pb2.E_MessageSetExtension_MessageSetExtension, &pb2.MessageSetExtension{
  952. OptString: scalar.String("a messageset extension"),
  953. })
  954. setExtension(m, pb2.E_MessageSetExtension_NotMessageSetExtension, &pb2.MessageSetExtension{
  955. OptString: scalar.String("not a messageset extension"),
  956. })
  957. setExtension(m, pb2.E_MessageSetExtension_ExtNested, &pb2.Nested{
  958. OptString: scalar.String("just a regular extension"),
  959. })
  960. return m
  961. }(),
  962. want: `[pb2.MessageSetExtension]: {
  963. opt_string: "a messageset extension"
  964. }
  965. [pb2.MessageSetExtension.ext_nested]: {
  966. opt_string: "just a regular extension"
  967. }
  968. [pb2.MessageSetExtension.not_message_set_extension]: {
  969. opt_string: "not a messageset extension"
  970. }
  971. `,
  972. */
  973. }, {
  974. desc: "Any message not expanded",
  975. mo: textpb.MarshalOptions{
  976. Resolver: preg.NewTypes(),
  977. },
  978. input: func() proto.Message {
  979. m := &pb2.Nested{
  980. OptString: scalar.String("embedded inside Any"),
  981. OptNested: &pb2.Nested{
  982. OptString: scalar.String("inception"),
  983. },
  984. }
  985. // TODO: Switch to V2 marshal when ready.
  986. b, err := protoV1.Marshal(m)
  987. if err != nil {
  988. t.Fatalf("error in binary marshaling message for Any.value: %v", err)
  989. }
  990. return wrapAnyPB(&anypb.Any{
  991. TypeUrl: "pb2.Nested",
  992. Value: b,
  993. })
  994. }(),
  995. want: `type_url: "pb2.Nested"
  996. value: "\n\x13embedded inside Any\x12\x0b\n\tinception"
  997. `,
  998. }, {
  999. desc: "Any message expanded",
  1000. mo: textpb.MarshalOptions{
  1001. Resolver: preg.NewTypes((&pb2.Nested{}).ProtoReflect().Type()),
  1002. },
  1003. input: func() proto.Message {
  1004. m := &pb2.Nested{
  1005. OptString: scalar.String("embedded inside Any"),
  1006. OptNested: &pb2.Nested{
  1007. OptString: scalar.String("inception"),
  1008. },
  1009. }
  1010. // TODO: Switch to V2 marshal when ready.
  1011. b, err := protoV1.Marshal(m)
  1012. if err != nil {
  1013. t.Fatalf("error in binary marshaling message for Any.value: %v", err)
  1014. }
  1015. return wrapAnyPB(&anypb.Any{
  1016. TypeUrl: "foo/pb2.Nested",
  1017. Value: b,
  1018. })
  1019. }(),
  1020. want: `[foo/pb2.Nested]: {
  1021. opt_string: "embedded inside Any"
  1022. opt_nested: {
  1023. opt_string: "inception"
  1024. }
  1025. }
  1026. `,
  1027. }, {
  1028. desc: "Any message expanded with missing required error",
  1029. mo: textpb.MarshalOptions{
  1030. Resolver: preg.NewTypes((&pb2.PartialRequired{}).ProtoReflect().Type()),
  1031. },
  1032. input: func() proto.Message {
  1033. m := &pb2.PartialRequired{
  1034. OptString: scalar.String("embedded inside Any"),
  1035. }
  1036. // TODO: Switch to V2 marshal when ready.
  1037. b, err := protoV1.Marshal(m)
  1038. // Ignore required not set error.
  1039. if _, ok := err.(*protoV1.RequiredNotSetError); !ok {
  1040. t.Fatalf("error in binary marshaling message for Any.value: %v", err)
  1041. }
  1042. return wrapAnyPB(&anypb.Any{
  1043. TypeUrl: string(m.ProtoReflect().Type().FullName()),
  1044. Value: b,
  1045. })
  1046. }(),
  1047. want: `[pb2.PartialRequired]: {
  1048. opt_string: "embedded inside Any"
  1049. }
  1050. `,
  1051. wantErr: true,
  1052. }, {
  1053. desc: "Any message with invalid value",
  1054. mo: textpb.MarshalOptions{
  1055. Resolver: preg.NewTypes((&pb2.Nested{}).ProtoReflect().Type()),
  1056. },
  1057. input: wrapAnyPB(&anypb.Any{
  1058. TypeUrl: "foo/pb2.Nested",
  1059. Value: dhex("80"),
  1060. }),
  1061. want: `type_url: "foo/pb2.Nested"
  1062. value: "\x80"
  1063. `,
  1064. }}
  1065. for _, tt := range tests {
  1066. tt := tt
  1067. t.Run(tt.desc, func(t *testing.T) {
  1068. t.Parallel()
  1069. b, err := tt.mo.Marshal(tt.input)
  1070. if err != nil && !tt.wantErr {
  1071. t.Errorf("Marshal() returned error: %v\n", err)
  1072. }
  1073. if err == nil && tt.wantErr {
  1074. t.Error("Marshal() got nil error, want error\n")
  1075. }
  1076. got := string(b)
  1077. if tt.want != "" && got != tt.want {
  1078. t.Errorf("Marshal()\n<got>\n%v\n<want>\n%v\n", got, tt.want)
  1079. if diff := cmp.Diff(tt.want, got, splitLines); diff != "" {
  1080. t.Errorf("Marshal() diff -want +got\n%v\n", diff)
  1081. }
  1082. }
  1083. })
  1084. }
  1085. }