Browse Source

Add a work about code review to the readme.
Fix an initial-install dependency problem.

R=rsc
http://codereview.appspot.com/687041

Rob Pike 16 years ago
parent
commit
c1430ff329
2 changed files with 13 additions and 0 deletions
  1. 6 0
      Makefile
  2. 7 0
      README

+ 6 - 0
Makefile

@@ -36,17 +36,23 @@ all:	install
 
 
 install:
 install:
 	cd proto && make install
 	cd proto && make install
+	cd compiler/descriptor && make install
+	cd compiler/plugin && make install
 	cd compiler && make install
 	cd compiler && make install
 
 
 clean:
 clean:
 	cd proto && make clean
 	cd proto && make clean
 	cd compiler && make clean
 	cd compiler && make clean
+	cd compiler/descriptor && make clean
+	cd compiler/plugin && make clean
 	cd compiler/testdata && make clean
 	cd compiler/testdata && make clean
 	cd compiler/descriptor && make clean
 	cd compiler/descriptor && make clean
 	cd compiler/plugin && make clean
 	cd compiler/plugin && make clean
 
 
 nuke:
 nuke:
 	cd proto && make nuke
 	cd proto && make nuke
+	cd compiler/descriptor && make nuke
+	cd compiler/plugin && make nuke
 	cd compiler && make nuke
 	cd compiler && make nuke
 	cd compiler/testdata && make nuke
 	cd compiler/testdata && make nuke
 	cd compiler/descriptor && make nuke
 	cd compiler/descriptor && make nuke

+ 7 - 0
README

@@ -57,7 +57,14 @@ package.
 The generated files will be suffixed .pb.go.  See the Test code below
 The generated files will be suffixed .pb.go.  See the Test code below
 for an example using such a file.
 for an example using such a file.
 
 
+This repository uses the same code review mechanism as Go, so
+if you wish to submit changes add the equivalent of these two lines
+to $GOROOT/src/pkg/goprotobuf.googlecode.com/hg/.hg/hgrc
 
 
+	[extensions]
+	codereview = $GOROOT/lib/codereview/codereview.py
+
+*where $GOROOT is the expanded text, such as /usr/foo/go*.
 
 
 The package comment for the proto library contains text describing
 The package comment for the proto library contains text describing
 the interface provided in Go for protocol buffers. Here is an edited
 the interface provided in Go for protocol buffers. Here is an edited