Просмотр исходного кода

protoc-gen-go: include groups in public import forwarders

Groups were being excluded from the set of messages we generate
forwarding declarations for. Include them.

Change-Id: Idb20c671ac610ada5fc357949f86a3053d16dfc6
Cherry-Pick: github.com/golang/protobuf@0382e7636b97e3f60fb188fef87a8d2c42c51ba9
Original-Author: Damien Neil <dneil@google.com>
Reviewed-on: https://go-review.googlesource.com/c/151431
Reviewed-by: Damien Neil <dneil@google.com>
Joe Tsai 7 лет назад
Родитель
Сommit
160af8e445
1 измененных файлов с 13 добавлено и 16 удалено
  1. 13 16
      protoc-gen-go/generator/generator.go

+ 13 - 16
protoc-gen-go/generator/generator.go

@@ -2708,26 +2708,23 @@ func (g *Generator) generateMessage(message *Descriptor) {
 	g.generateOneofFuncs(mc, topLevelFields)
 	g.P()
 
-	if !message.group {
-
-		var oneofTypes []string
-		for _, f := range topLevelFields {
-			if of, ok := f.(*oneofField); ok {
-				for _, osf := range of.subFields {
-					oneofTypes = append(oneofTypes, osf.oneofTypeName)
-				}
+	var oneofTypes []string
+	for _, f := range topLevelFields {
+		if of, ok := f.(*oneofField); ok {
+			for _, osf := range of.subFields {
+				oneofTypes = append(oneofTypes, osf.oneofTypeName)
 			}
 		}
+	}
 
-		opts := message.Options
-		ms := &messageSymbol{
-			sym:           goTypeName,
-			hasExtensions: len(message.ExtensionRange) > 0,
-			isMessageSet:  opts != nil && opts.GetMessageSetWireFormat(),
-			oneofTypes:    oneofTypes,
-		}
-		g.file.addExport(message, ms)
+	opts := message.Options
+	ms := &messageSymbol{
+		sym:           goTypeName,
+		hasExtensions: len(message.ExtensionRange) > 0,
+		isMessageSet:  opts != nil && opts.GetMessageSetWireFormat(),
+		oneofTypes:    oneofTypes,
 	}
+	g.file.addExport(message, ms)
 
 	for _, ext := range message.ext {
 		g.generateExtension(ext)