Explorar el Código

Refactors warning messages

Manu Mtz-Almeida hace 10 años
padre
commit
4cc2de6207
Se han modificado 2 ficheros con 13 adiciones y 8 borrados
  1. 11 1
      debug.go
  2. 2 7
      gin.go

+ 11 - 1
debug.go

@@ -27,7 +27,7 @@ func debugPrint(format string, values ...interface{}) {
 	}
 }
 
-func debugPrintWARNING() {
+func debugPrintWARNING_New() {
 	debugPrint(`[WARNING] Running in "debug" mode. Switch to "release" mode in production.
  - using env:	export GIN_MODE=release
  - using code:	gin.SetMode(gin.ReleaseMode)
@@ -35,6 +35,16 @@ func debugPrintWARNING() {
 `)
 }
 
+func debugPrintWARNING_SetHTMLTemplate() {
+	debugPrint(`[WARNING] Since SetHTMLTemplate() is NOT thread-safe. It should only be called
+at initialization. ie. before any route is registered or the router is listening in a socket:
+
+	router := gin.Default()
+	router.SetHTMLTemplate(template) // << good place
+
+`)
+}
+
 func debugPrintError(err error) {
 	if err != nil {
 		debugPrint("[ERROR] %v\n", err)

+ 2 - 7
gin.go

@@ -83,7 +83,7 @@ var _ RoutesInterface = &Engine{}
 // Returns a new blank Engine instance without any middleware attached.
 // The most basic configuration
 func New() *Engine {
-	debugPrintWARNING()
+	debugPrintWARNING_New()
 	engine := &Engine{
 		RouterGroup: RouterGroup{
 			Handlers: nil,
@@ -134,12 +134,7 @@ func (engine *Engine) LoadHTMLFiles(files ...string) {
 
 func (engine *Engine) SetHTMLTemplate(templ *template.Template) {
 	if len(engine.trees) > 0 {
-		debugPrint(`[WARNING] Since SetHTMLTemplate() is NOT thread-safe. It should only be called
-at initialization. ie. before any route is registered or the router is listening in a socket:
-
-	router := gin.Default()
-	router.SetHTMLTemplate(template) // << good place
-`)
+		debugPrintWARNING_SetHTMLTemplate()
 	}
 	engine.HTMLRender = render.HTMLProduction{Template: templ}
 }