security.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611
  1. // Copyright 2015 CoreOS, Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package security
  15. import (
  16. "encoding/json"
  17. "fmt"
  18. "path"
  19. "reflect"
  20. "sort"
  21. "strings"
  22. "time"
  23. "github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/crypto/bcrypt"
  24. "github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/net/context"
  25. etcderr "github.com/coreos/etcd/error"
  26. "github.com/coreos/etcd/etcdserver"
  27. "github.com/coreos/etcd/etcdserver/etcdserverpb"
  28. "github.com/coreos/etcd/pkg/types"
  29. "github.com/coreos/pkg/capnslog"
  30. )
  31. const (
  32. // StorePermsPrefix is the internal prefix of the storage layer dedicated to storing user data.
  33. StorePermsPrefix = "/2"
  34. // RootRoleName is the name of the ROOT role, with privileges to manage the cluster.
  35. RootRoleName = "root"
  36. // GuestRoleName is the name of the role that defines the privileges of an unauthenticated user.
  37. GuestRoleName = "guest"
  38. )
  39. var (
  40. plog = capnslog.NewPackageLogger("github.com/coreos/etcd/etcdserver", "security")
  41. )
  42. var rootRole = Role{
  43. Role: RootRoleName,
  44. Permissions: Permissions{
  45. KV: rwPermission{
  46. Read: []string{"*"},
  47. Write: []string{"*"},
  48. },
  49. },
  50. }
  51. var guestRole = Role{
  52. Role: GuestRoleName,
  53. Permissions: Permissions{
  54. KV: rwPermission{
  55. Read: []string{"*"},
  56. Write: []string{"*"},
  57. },
  58. },
  59. }
  60. type doer interface {
  61. Do(context.Context, etcdserverpb.Request) (etcdserver.Response, error)
  62. }
  63. type Store struct {
  64. server doer
  65. timeout time.Duration
  66. ensuredOnce bool
  67. }
  68. type User struct {
  69. User string `json:"user"`
  70. Password string `json:"password,omitempty"`
  71. Roles []string `json:"roles"`
  72. Grant []string `json:"grant,omitempty"`
  73. Revoke []string `json:"revoke,omitempty"`
  74. }
  75. type Role struct {
  76. Role string `json:"role"`
  77. Permissions Permissions `json:"permissions"`
  78. Grant *Permissions `json:"grant,omitempty"`
  79. Revoke *Permissions `json:"revoke,omitempty"`
  80. }
  81. type Permissions struct {
  82. KV rwPermission `json:"kv"`
  83. }
  84. type rwPermission struct {
  85. Read []string `json:"read"`
  86. Write []string `json:"write"`
  87. }
  88. type Error struct {
  89. errmsg string
  90. }
  91. func (se Error) Error() string { return se.errmsg }
  92. func mergeErr(s string, v ...interface{}) Error {
  93. return Error{fmt.Sprintf("security: "+s, v...)}
  94. }
  95. func securityErr(s string, v ...interface{}) Error {
  96. return Error{fmt.Sprintf("security: "+s, v...)}
  97. }
  98. func NewStore(server doer, timeout time.Duration) *Store {
  99. s := &Store{
  100. server: server,
  101. timeout: timeout,
  102. }
  103. return s
  104. }
  105. func (s *Store) AllUsers() ([]string, error) {
  106. resp, err := s.requestResource("/users/", false)
  107. if err != nil {
  108. if e, ok := err.(*etcderr.Error); ok {
  109. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  110. return []string{}, nil
  111. }
  112. }
  113. return nil, err
  114. }
  115. var nodes []string
  116. for _, n := range resp.Event.Node.Nodes {
  117. _, user := path.Split(n.Key)
  118. nodes = append(nodes, user)
  119. }
  120. sort.Strings(nodes)
  121. return nodes, nil
  122. }
  123. func (s *Store) GetUser(name string) (User, error) {
  124. resp, err := s.requestResource("/users/"+name, false)
  125. if err != nil {
  126. if e, ok := err.(*etcderr.Error); ok {
  127. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  128. return User{}, securityErr("User %s does not exist.", name)
  129. }
  130. }
  131. return User{}, err
  132. }
  133. var u User
  134. err = json.Unmarshal([]byte(*resp.Event.Node.Value), &u)
  135. if err != nil {
  136. return u, err
  137. }
  138. // Require that root always has a root role.
  139. if u.User == "root" {
  140. inRoles := false
  141. for _, r := range u.Roles {
  142. if r == RootRoleName {
  143. inRoles = true
  144. break
  145. }
  146. }
  147. if !inRoles {
  148. u.Roles = append(u.Roles, RootRoleName)
  149. }
  150. }
  151. return u, nil
  152. }
  153. func (s *Store) CreateOrUpdateUser(user User) (out User, created bool, err error) {
  154. _, err = s.GetUser(user.User)
  155. if err == nil {
  156. // Remove the update-user roles from updating downstream.
  157. // Roles are granted or revoked, not changed directly.
  158. user.Roles = nil
  159. out, err := s.UpdateUser(user)
  160. return out, false, err
  161. }
  162. u, err := s.CreateUser(user)
  163. return u, true, err
  164. }
  165. func (s *Store) CreateUser(user User) (User, error) {
  166. u, err := s.createUserInternal(user)
  167. if err == nil {
  168. plog.Noticef("created user %s", user.User)
  169. }
  170. return u, err
  171. }
  172. func (s *Store) createUserInternal(user User) (User, error) {
  173. if user.Password == "" {
  174. return user, securityErr("Cannot create user %s with an empty password", user.User)
  175. }
  176. hash, err := bcrypt.GenerateFromPassword([]byte(user.Password), bcrypt.DefaultCost)
  177. if err != nil {
  178. return user, err
  179. }
  180. user.Password = string(hash)
  181. _, err = s.createResource("/users/"+user.User, user)
  182. if err != nil {
  183. if e, ok := err.(*etcderr.Error); ok {
  184. if e.ErrorCode == etcderr.EcodeNodeExist {
  185. return user, securityErr("User %s already exists.", user.User)
  186. }
  187. }
  188. }
  189. return user, err
  190. }
  191. func (s *Store) DeleteUser(name string) error {
  192. if s.SecurityEnabled() && name == "root" {
  193. return securityErr("Cannot delete root user while security is enabled.")
  194. }
  195. _, err := s.deleteResource("/users/" + name)
  196. if err != nil {
  197. if e, ok := err.(*etcderr.Error); ok {
  198. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  199. return securityErr("User %s does not exist", name)
  200. }
  201. }
  202. return err
  203. }
  204. plog.Noticef("deleted user %s", name)
  205. return nil
  206. }
  207. func (s *Store) UpdateUser(user User) (User, error) {
  208. old, err := s.GetUser(user.User)
  209. if err != nil {
  210. if e, ok := err.(*etcderr.Error); ok {
  211. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  212. return user, securityErr("User %s doesn't exist.", user.User)
  213. }
  214. }
  215. return old, err
  216. }
  217. newUser, err := old.Merge(user)
  218. if err != nil {
  219. return old, err
  220. }
  221. if reflect.DeepEqual(old, newUser) {
  222. if user.Revoke != nil || user.Grant != nil {
  223. return old, securityErr("User not updated. Grant/Revoke lists didn't match any current roles.")
  224. }
  225. return old, securityErr("User not updated. Use Grant/Revoke/Password to update the user.")
  226. }
  227. _, err = s.updateResource("/users/"+user.User, newUser)
  228. if err == nil {
  229. plog.Noticef("updated user %s", user.User)
  230. }
  231. return newUser, err
  232. }
  233. func (s *Store) AllRoles() ([]string, error) {
  234. nodes := []string{RootRoleName}
  235. resp, err := s.requestResource("/roles/", false)
  236. if err != nil {
  237. if e, ok := err.(*etcderr.Error); ok {
  238. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  239. return nodes, nil
  240. }
  241. }
  242. return nil, err
  243. }
  244. for _, n := range resp.Event.Node.Nodes {
  245. _, role := path.Split(n.Key)
  246. nodes = append(nodes, role)
  247. }
  248. sort.Strings(nodes)
  249. return nodes, nil
  250. }
  251. func (s *Store) GetRole(name string) (Role, error) {
  252. if name == RootRoleName {
  253. return rootRole, nil
  254. }
  255. resp, err := s.requestResource("/roles/"+name, false)
  256. if err != nil {
  257. if e, ok := err.(*etcderr.Error); ok {
  258. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  259. return Role{}, securityErr("Role %s does not exist.", name)
  260. }
  261. }
  262. return Role{}, err
  263. }
  264. var r Role
  265. err = json.Unmarshal([]byte(*resp.Event.Node.Value), &r)
  266. if err != nil {
  267. return r, err
  268. }
  269. return r, nil
  270. }
  271. func (s *Store) CreateOrUpdateRole(r Role) (role Role, created bool, err error) {
  272. _, err = s.GetRole(r.Role)
  273. if err == nil {
  274. role, err = s.UpdateRole(r)
  275. created = false
  276. return
  277. }
  278. return r, true, s.CreateRole(r)
  279. }
  280. func (s *Store) CreateRole(role Role) error {
  281. if role.Role == RootRoleName {
  282. return securityErr("Cannot modify role %s: is root role.", role.Role)
  283. }
  284. _, err := s.createResource("/roles/"+role.Role, role)
  285. if err != nil {
  286. if e, ok := err.(*etcderr.Error); ok {
  287. if e.ErrorCode == etcderr.EcodeNodeExist {
  288. return securityErr("Role %s already exists.", role.Role)
  289. }
  290. }
  291. }
  292. if err == nil {
  293. plog.Noticef("created new role %s", role.Role)
  294. }
  295. return err
  296. }
  297. func (s *Store) DeleteRole(name string) error {
  298. if name == RootRoleName {
  299. return securityErr("Cannot modify role %s: is superuser role.", name)
  300. }
  301. _, err := s.deleteResource("/roles/" + name)
  302. if err != nil {
  303. if e, ok := err.(*etcderr.Error); ok {
  304. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  305. return securityErr("Role %s doesn't exist.", name)
  306. }
  307. }
  308. }
  309. if err == nil {
  310. plog.Noticef("deleted role %s", name)
  311. }
  312. return err
  313. }
  314. func (s *Store) UpdateRole(role Role) (Role, error) {
  315. old, err := s.GetRole(role.Role)
  316. if err != nil {
  317. if e, ok := err.(*etcderr.Error); ok {
  318. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  319. return role, securityErr("Role %s doesn't exist.", role.Role)
  320. }
  321. }
  322. return old, err
  323. }
  324. newRole, err := old.Merge(role)
  325. if err != nil {
  326. return old, err
  327. }
  328. if reflect.DeepEqual(old, newRole) {
  329. if role.Revoke != nil || role.Grant != nil {
  330. return old, securityErr("Role not updated. Grant/Revoke lists didn't match any current permissions.")
  331. }
  332. return old, securityErr("Role not updated. Use Grant/Revoke to update the role.")
  333. }
  334. _, err = s.updateResource("/roles/"+role.Role, newRole)
  335. if err == nil {
  336. plog.Noticef("updated role %s", role.Role)
  337. }
  338. return newRole, err
  339. }
  340. func (s *Store) SecurityEnabled() bool {
  341. return s.detectSecurity()
  342. }
  343. func (s *Store) EnableSecurity() error {
  344. if s.SecurityEnabled() {
  345. return securityErr("already enabled")
  346. }
  347. _, err := s.GetUser("root")
  348. if err != nil {
  349. return securityErr("No root user available, please create one")
  350. }
  351. _, err = s.GetRole(GuestRoleName)
  352. if err != nil {
  353. plog.Printf("no guest role access found, creating default")
  354. err := s.CreateRole(guestRole)
  355. if err != nil {
  356. plog.Errorf("error creating guest role. aborting security enable.")
  357. return err
  358. }
  359. }
  360. err = s.enableSecurity()
  361. if err == nil {
  362. plog.Noticef("security: enabled security")
  363. } else {
  364. plog.Errorf("error enabling security (%v)", err)
  365. }
  366. return err
  367. }
  368. func (s *Store) DisableSecurity() error {
  369. if !s.SecurityEnabled() {
  370. return securityErr("already disabled")
  371. }
  372. err := s.disableSecurity()
  373. if err == nil {
  374. plog.Noticef("security: disabled security")
  375. } else {
  376. plog.Errorf("error disabling security (%v)", err)
  377. }
  378. return err
  379. }
  380. // Merge applies the properties of the passed-in User to the User on which it
  381. // is called and returns a new User with these modifications applied. Think of
  382. // all Users as immutable sets of data. Merge allows you to perform the set
  383. // operations (desired grants and revokes) atomically
  384. func (u User) Merge(n User) (User, error) {
  385. var out User
  386. if u.User != n.User {
  387. return out, mergeErr("Merging user data with conflicting usernames: %s %s", u.User, n.User)
  388. }
  389. out.User = u.User
  390. if n.Password != "" {
  391. hash, err := bcrypt.GenerateFromPassword([]byte(n.Password), bcrypt.DefaultCost)
  392. if err != nil {
  393. return out, err
  394. }
  395. out.Password = string(hash)
  396. } else {
  397. out.Password = u.Password
  398. }
  399. currentRoles := types.NewUnsafeSet(u.Roles...)
  400. for _, g := range n.Grant {
  401. if currentRoles.Contains(g) {
  402. plog.Noticef("granting duplicate role %s for user %s", g, n.User)
  403. continue
  404. }
  405. currentRoles.Add(g)
  406. }
  407. for _, r := range n.Revoke {
  408. if !currentRoles.Contains(r) {
  409. plog.Noticef("revoking ungranted role %s for user %s", r, n.User)
  410. continue
  411. }
  412. currentRoles.Remove(r)
  413. }
  414. out.Roles = currentRoles.Values()
  415. return out, nil
  416. }
  417. func (u User) CheckPassword(password string) bool {
  418. err := bcrypt.CompareHashAndPassword([]byte(u.Password), []byte(password))
  419. return err == nil
  420. }
  421. // Merge for a role works the same as User above -- atomic Role application to
  422. // each of the substructures.
  423. func (r Role) Merge(n Role) (Role, error) {
  424. var out Role
  425. var err error
  426. if r.Role != n.Role {
  427. return out, mergeErr("Merging role with conflicting names: %s %s", r.Role, n.Role)
  428. }
  429. out.Role = r.Role
  430. out.Permissions, err = r.Permissions.Grant(n.Grant)
  431. if err != nil {
  432. return out, err
  433. }
  434. out.Permissions, err = out.Permissions.Revoke(n.Revoke)
  435. if err != nil {
  436. return out, err
  437. }
  438. return out, nil
  439. }
  440. func (r Role) HasKeyAccess(key string, write bool) bool {
  441. if r.Role == RootRoleName {
  442. return true
  443. }
  444. return r.Permissions.KV.HasAccess(key, write)
  445. }
  446. func (r Role) HasRecursiveAccess(key string, write bool) bool {
  447. if r.Role == RootRoleName {
  448. return true
  449. }
  450. return r.Permissions.KV.HasRecursiveAccess(key, write)
  451. }
  452. // Grant adds a set of permissions to the permission object on which it is called,
  453. // returning a new permission object.
  454. func (p Permissions) Grant(n *Permissions) (Permissions, error) {
  455. var out Permissions
  456. var err error
  457. if n == nil {
  458. return p, nil
  459. }
  460. out.KV, err = p.KV.Grant(n.KV)
  461. return out, err
  462. }
  463. // Revoke removes a set of permissions to the permission object on which it is called,
  464. // returning a new permission object.
  465. func (p Permissions) Revoke(n *Permissions) (Permissions, error) {
  466. var out Permissions
  467. var err error
  468. if n == nil {
  469. return p, nil
  470. }
  471. out.KV, err = p.KV.Revoke(n.KV)
  472. return out, err
  473. }
  474. // Grant adds a set of permissions to the permission object on which it is called,
  475. // returning a new permission object.
  476. func (rw rwPermission) Grant(n rwPermission) (rwPermission, error) {
  477. var out rwPermission
  478. currentRead := types.NewUnsafeSet(rw.Read...)
  479. for _, r := range n.Read {
  480. if currentRead.Contains(r) {
  481. return out, mergeErr("Granting duplicate read permission %s", r)
  482. }
  483. currentRead.Add(r)
  484. }
  485. currentWrite := types.NewUnsafeSet(rw.Write...)
  486. for _, w := range n.Write {
  487. if currentWrite.Contains(w) {
  488. return out, mergeErr("Granting duplicate write permission %s", w)
  489. }
  490. currentWrite.Add(w)
  491. }
  492. out.Read = currentRead.Values()
  493. out.Write = currentWrite.Values()
  494. return out, nil
  495. }
  496. // Revoke removes a set of permissions to the permission object on which it is called,
  497. // returning a new permission object.
  498. func (rw rwPermission) Revoke(n rwPermission) (rwPermission, error) {
  499. var out rwPermission
  500. currentRead := types.NewUnsafeSet(rw.Read...)
  501. for _, r := range n.Read {
  502. if !currentRead.Contains(r) {
  503. plog.Noticef("revoking ungranted read permission %s", r)
  504. continue
  505. }
  506. currentRead.Remove(r)
  507. }
  508. currentWrite := types.NewUnsafeSet(rw.Write...)
  509. for _, w := range n.Write {
  510. if !currentWrite.Contains(w) {
  511. plog.Noticef("revoking ungranted write permission %s", w)
  512. continue
  513. }
  514. currentWrite.Remove(w)
  515. }
  516. out.Read = currentRead.Values()
  517. out.Write = currentWrite.Values()
  518. return out, nil
  519. }
  520. func (rw rwPermission) HasAccess(key string, write bool) bool {
  521. var list []string
  522. if write {
  523. list = rw.Write
  524. } else {
  525. list = rw.Read
  526. }
  527. for _, pat := range list {
  528. match, err := simpleMatch(pat, key)
  529. if err == nil && match {
  530. return true
  531. }
  532. }
  533. return false
  534. }
  535. func (rw rwPermission) HasRecursiveAccess(key string, write bool) bool {
  536. list := rw.Read
  537. if write {
  538. list = rw.Write
  539. }
  540. for _, pat := range list {
  541. match, err := prefixMatch(pat, key)
  542. if err == nil && match {
  543. return true
  544. }
  545. }
  546. return false
  547. }
  548. func simpleMatch(pattern string, key string) (match bool, err error) {
  549. if pattern[len(pattern)-1] == '*' {
  550. return strings.HasPrefix(key, pattern[:len(pattern)-1]), nil
  551. }
  552. return key == pattern, nil
  553. }
  554. func prefixMatch(pattern string, key string) (match bool, err error) {
  555. if pattern[len(pattern)-1] != '*' {
  556. return false, nil
  557. }
  558. return strings.HasPrefix(key, pattern[:len(pattern)-1]), nil
  559. }