store_test.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868
  1. // Copyright 2016 The etcd Authors
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package auth
  15. import (
  16. "context"
  17. "fmt"
  18. "os"
  19. "reflect"
  20. "strings"
  21. "sync"
  22. "testing"
  23. "time"
  24. "go.etcd.io/etcd/auth/authpb"
  25. "go.etcd.io/etcd/etcdserver/api/v3rpc/rpctypes"
  26. pb "go.etcd.io/etcd/etcdserver/etcdserverpb"
  27. "go.etcd.io/etcd/mvcc/backend"
  28. "go.uber.org/zap"
  29. "golang.org/x/crypto/bcrypt"
  30. "google.golang.org/grpc/metadata"
  31. )
  32. func dummyIndexWaiter(index uint64) <-chan struct{} {
  33. ch := make(chan struct{})
  34. go func() {
  35. ch <- struct{}{}
  36. }()
  37. return ch
  38. }
  39. // TestNewAuthStoreRevision ensures newly auth store
  40. // keeps the old revision when there are no changes.
  41. func TestNewAuthStoreRevision(t *testing.T) {
  42. b, tPath := backend.NewDefaultTmpBackend()
  43. defer os.Remove(tPath)
  44. tp, err := NewTokenProvider(zap.NewExample(), tokenTypeSimple, dummyIndexWaiter)
  45. if err != nil {
  46. t.Fatal(err)
  47. }
  48. as := NewAuthStore(zap.NewExample(), b, tp, bcrypt.MinCost)
  49. err = enableAuthAndCreateRoot(as)
  50. if err != nil {
  51. t.Fatal(err)
  52. }
  53. old := as.Revision()
  54. as.Close()
  55. b.Close()
  56. // no changes to commit
  57. b2 := backend.NewDefaultBackend(tPath)
  58. as = NewAuthStore(zap.NewExample(), b2, tp, bcrypt.MinCost)
  59. new := as.Revision()
  60. as.Close()
  61. b2.Close()
  62. if old != new {
  63. t.Fatalf("expected revision %d, got %d", old, new)
  64. }
  65. }
  66. // TestNewAuthStoreBryptCost ensures that NewAuthStore uses default when given bcrypt-cost is invalid
  67. func TestNewAuthStoreBcryptCost(t *testing.T) {
  68. b, tPath := backend.NewDefaultTmpBackend()
  69. defer os.Remove(tPath)
  70. tp, err := NewTokenProvider(zap.NewExample(), tokenTypeSimple, dummyIndexWaiter)
  71. if err != nil {
  72. t.Fatal(err)
  73. }
  74. invalidCosts := [2]int{bcrypt.MinCost - 1, bcrypt.MaxCost + 1}
  75. for _, invalidCost := range invalidCosts {
  76. as := NewAuthStore(zap.NewExample(), b, tp, invalidCost)
  77. if as.BcryptCost() != bcrypt.DefaultCost {
  78. t.Fatalf("expected DefaultCost when bcryptcost is invalid")
  79. }
  80. as.Close()
  81. }
  82. b.Close()
  83. }
  84. func setupAuthStore(t *testing.T) (store *authStore, teardownfunc func(t *testing.T)) {
  85. b, tPath := backend.NewDefaultTmpBackend()
  86. tp, err := NewTokenProvider(zap.NewExample(), tokenTypeSimple, dummyIndexWaiter)
  87. if err != nil {
  88. t.Fatal(err)
  89. }
  90. as := NewAuthStore(zap.NewExample(), b, tp, bcrypt.MinCost)
  91. err = enableAuthAndCreateRoot(as)
  92. if err != nil {
  93. t.Fatal(err)
  94. }
  95. // adds a new role
  96. _, err = as.RoleAdd(&pb.AuthRoleAddRequest{Name: "role-test"})
  97. if err != nil {
  98. t.Fatal(err)
  99. }
  100. ua := &pb.AuthUserAddRequest{Name: "foo", Password: "bar", Options: &authpb.UserAddOptions{NoPassword: false}}
  101. _, err = as.UserAdd(ua) // add a non-existing user
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. tearDown := func(_ *testing.T) {
  106. b.Close()
  107. os.Remove(tPath)
  108. as.Close()
  109. }
  110. return as, tearDown
  111. }
  112. func enableAuthAndCreateRoot(as *authStore) error {
  113. _, err := as.UserAdd(&pb.AuthUserAddRequest{Name: "root", Password: "root", Options: &authpb.UserAddOptions{NoPassword: false}})
  114. if err != nil {
  115. return err
  116. }
  117. _, err = as.RoleAdd(&pb.AuthRoleAddRequest{Name: "root"})
  118. if err != nil {
  119. return err
  120. }
  121. _, err = as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "root", Role: "root"})
  122. if err != nil {
  123. return err
  124. }
  125. return as.AuthEnable()
  126. }
  127. func TestUserAdd(t *testing.T) {
  128. as, tearDown := setupAuthStore(t)
  129. defer tearDown(t)
  130. ua := &pb.AuthUserAddRequest{Name: "foo", Options: &authpb.UserAddOptions{NoPassword: false}}
  131. _, err := as.UserAdd(ua) // add an existing user
  132. if err == nil {
  133. t.Fatalf("expected %v, got %v", ErrUserAlreadyExist, err)
  134. }
  135. if err != ErrUserAlreadyExist {
  136. t.Fatalf("expected %v, got %v", ErrUserAlreadyExist, err)
  137. }
  138. ua = &pb.AuthUserAddRequest{Name: "", Options: &authpb.UserAddOptions{NoPassword: false}}
  139. _, err = as.UserAdd(ua) // add a user with empty name
  140. if err != ErrUserEmpty {
  141. t.Fatal(err)
  142. }
  143. }
  144. func TestRecover(t *testing.T) {
  145. as, tearDown := setupAuthStore(t)
  146. defer tearDown(t)
  147. as.enabled = false
  148. as.Recover(as.be)
  149. if !as.IsAuthEnabled() {
  150. t.Fatalf("expected auth enabled got disabled")
  151. }
  152. }
  153. func TestCheckPassword(t *testing.T) {
  154. as, tearDown := setupAuthStore(t)
  155. defer tearDown(t)
  156. // auth a non-existing user
  157. _, err := as.CheckPassword("foo-test", "bar")
  158. if err == nil {
  159. t.Fatalf("expected %v, got %v", ErrAuthFailed, err)
  160. }
  161. if err != ErrAuthFailed {
  162. t.Fatalf("expected %v, got %v", ErrAuthFailed, err)
  163. }
  164. // auth an existing user with correct password
  165. _, err = as.CheckPassword("foo", "bar")
  166. if err != nil {
  167. t.Fatal(err)
  168. }
  169. // auth an existing user but with wrong password
  170. _, err = as.CheckPassword("foo", "")
  171. if err == nil {
  172. t.Fatalf("expected %v, got %v", ErrAuthFailed, err)
  173. }
  174. if err != ErrAuthFailed {
  175. t.Fatalf("expected %v, got %v", ErrAuthFailed, err)
  176. }
  177. }
  178. func TestUserDelete(t *testing.T) {
  179. as, tearDown := setupAuthStore(t)
  180. defer tearDown(t)
  181. // delete an existing user
  182. ud := &pb.AuthUserDeleteRequest{Name: "foo"}
  183. _, err := as.UserDelete(ud)
  184. if err != nil {
  185. t.Fatal(err)
  186. }
  187. // delete a non-existing user
  188. _, err = as.UserDelete(ud)
  189. if err == nil {
  190. t.Fatalf("expected %v, got %v", ErrUserNotFound, err)
  191. }
  192. if err != ErrUserNotFound {
  193. t.Fatalf("expected %v, got %v", ErrUserNotFound, err)
  194. }
  195. }
  196. func TestUserChangePassword(t *testing.T) {
  197. as, tearDown := setupAuthStore(t)
  198. defer tearDown(t)
  199. ctx1 := context.WithValue(context.WithValue(context.TODO(), AuthenticateParamIndex{}, uint64(1)), AuthenticateParamSimpleTokenPrefix{}, "dummy")
  200. _, err := as.Authenticate(ctx1, "foo", "bar")
  201. if err != nil {
  202. t.Fatal(err)
  203. }
  204. _, err = as.UserChangePassword(&pb.AuthUserChangePasswordRequest{Name: "foo", Password: "baz"})
  205. if err != nil {
  206. t.Fatal(err)
  207. }
  208. ctx2 := context.WithValue(context.WithValue(context.TODO(), AuthenticateParamIndex{}, uint64(2)), AuthenticateParamSimpleTokenPrefix{}, "dummy")
  209. _, err = as.Authenticate(ctx2, "foo", "baz")
  210. if err != nil {
  211. t.Fatal(err)
  212. }
  213. // change a non-existing user
  214. _, err = as.UserChangePassword(&pb.AuthUserChangePasswordRequest{Name: "foo-test", Password: "bar"})
  215. if err == nil {
  216. t.Fatalf("expected %v, got %v", ErrUserNotFound, err)
  217. }
  218. if err != ErrUserNotFound {
  219. t.Fatalf("expected %v, got %v", ErrUserNotFound, err)
  220. }
  221. }
  222. func TestRoleAdd(t *testing.T) {
  223. as, tearDown := setupAuthStore(t)
  224. defer tearDown(t)
  225. // adds a new role
  226. _, err := as.RoleAdd(&pb.AuthRoleAddRequest{Name: "role-test-1"})
  227. if err != nil {
  228. t.Fatal(err)
  229. }
  230. }
  231. func TestUserGrant(t *testing.T) {
  232. as, tearDown := setupAuthStore(t)
  233. defer tearDown(t)
  234. // grants a role to the user
  235. _, err := as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo", Role: "role-test"})
  236. if err != nil {
  237. t.Fatal(err)
  238. }
  239. // grants a role to a non-existing user
  240. _, err = as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo-test", Role: "role-test"})
  241. if err == nil {
  242. t.Errorf("expected %v, got %v", ErrUserNotFound, err)
  243. }
  244. if err != ErrUserNotFound {
  245. t.Errorf("expected %v, got %v", ErrUserNotFound, err)
  246. }
  247. }
  248. func TestHasRole(t *testing.T) {
  249. as, tearDown := setupAuthStore(t)
  250. defer tearDown(t)
  251. // grants a role to the user
  252. _, err := as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo", Role: "role-test"})
  253. if err != nil {
  254. t.Fatal(err)
  255. }
  256. // checks role reflects correctly
  257. hr := as.HasRole("foo", "role-test")
  258. if !hr {
  259. t.Fatal("expected role granted, got false")
  260. }
  261. // checks non existent role
  262. hr = as.HasRole("foo", "non-existent-role")
  263. if hr {
  264. t.Fatal("expected role not found, got true")
  265. }
  266. // checks non existent user
  267. hr = as.HasRole("nouser", "role-test")
  268. if hr {
  269. t.Fatal("expected user not found got true")
  270. }
  271. }
  272. func TestIsOpPermitted(t *testing.T) {
  273. as, tearDown := setupAuthStore(t)
  274. defer tearDown(t)
  275. // add new role
  276. _, err := as.RoleAdd(&pb.AuthRoleAddRequest{Name: "role-test-1"})
  277. if err != nil {
  278. t.Fatal(err)
  279. }
  280. perm := &authpb.Permission{
  281. PermType: authpb.WRITE,
  282. Key: []byte("Keys"),
  283. RangeEnd: []byte("RangeEnd"),
  284. }
  285. _, err = as.RoleGrantPermission(&pb.AuthRoleGrantPermissionRequest{
  286. Name: "role-test-1",
  287. Perm: perm,
  288. })
  289. if err != nil {
  290. t.Fatal(err)
  291. }
  292. // grants a role to the user
  293. _, err = as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo", Role: "role-test-1"})
  294. if err != nil {
  295. t.Fatal(err)
  296. }
  297. // check permission reflected to user
  298. err = as.isOpPermitted("foo", as.Revision(), perm.Key, perm.RangeEnd, perm.PermType)
  299. if err != nil {
  300. t.Fatal(err)
  301. }
  302. }
  303. func TestGetUser(t *testing.T) {
  304. as, tearDown := setupAuthStore(t)
  305. defer tearDown(t)
  306. _, err := as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo", Role: "role-test"})
  307. if err != nil {
  308. t.Fatal(err)
  309. }
  310. u, err := as.UserGet(&pb.AuthUserGetRequest{Name: "foo"})
  311. if err != nil {
  312. t.Fatal(err)
  313. }
  314. if u == nil {
  315. t.Fatal("expect user not nil, got nil")
  316. }
  317. expected := []string{"role-test"}
  318. if !reflect.DeepEqual(expected, u.Roles) {
  319. t.Errorf("expected %v, got %v", expected, u.Roles)
  320. }
  321. // check non existent user
  322. _, err = as.UserGet(&pb.AuthUserGetRequest{Name: "nouser"})
  323. if err == nil {
  324. t.Errorf("expected %v, got %v", ErrUserNotFound, err)
  325. }
  326. }
  327. func TestListUsers(t *testing.T) {
  328. as, tearDown := setupAuthStore(t)
  329. defer tearDown(t)
  330. ua := &pb.AuthUserAddRequest{Name: "user1", Password: "pwd1", Options: &authpb.UserAddOptions{NoPassword: false}}
  331. _, err := as.UserAdd(ua) // add a non-existing user
  332. if err != nil {
  333. t.Fatal(err)
  334. }
  335. ul, err := as.UserList(&pb.AuthUserListRequest{})
  336. if err != nil {
  337. t.Fatal(err)
  338. }
  339. if !contains(ul.Users, "root") {
  340. t.Errorf("expected %v in %v", "root", ul.Users)
  341. }
  342. if !contains(ul.Users, "user1") {
  343. t.Errorf("expected %v in %v", "user1", ul.Users)
  344. }
  345. }
  346. func TestRoleGrantPermission(t *testing.T) {
  347. as, tearDown := setupAuthStore(t)
  348. defer tearDown(t)
  349. _, err := as.RoleAdd(&pb.AuthRoleAddRequest{Name: "role-test-1"})
  350. if err != nil {
  351. t.Fatal(err)
  352. }
  353. perm := &authpb.Permission{
  354. PermType: authpb.WRITE,
  355. Key: []byte("Keys"),
  356. RangeEnd: []byte("RangeEnd"),
  357. }
  358. _, err = as.RoleGrantPermission(&pb.AuthRoleGrantPermissionRequest{
  359. Name: "role-test-1",
  360. Perm: perm,
  361. })
  362. if err != nil {
  363. t.Error(err)
  364. }
  365. r, err := as.RoleGet(&pb.AuthRoleGetRequest{Role: "role-test-1"})
  366. if err != nil {
  367. t.Fatal(err)
  368. }
  369. if !reflect.DeepEqual(perm, r.Perm[0]) {
  370. t.Errorf("expected %v, got %v", perm, r.Perm[0])
  371. }
  372. }
  373. func TestRoleRevokePermission(t *testing.T) {
  374. as, tearDown := setupAuthStore(t)
  375. defer tearDown(t)
  376. _, err := as.RoleAdd(&pb.AuthRoleAddRequest{Name: "role-test-1"})
  377. if err != nil {
  378. t.Fatal(err)
  379. }
  380. perm := &authpb.Permission{
  381. PermType: authpb.WRITE,
  382. Key: []byte("Keys"),
  383. RangeEnd: []byte("RangeEnd"),
  384. }
  385. _, err = as.RoleGrantPermission(&pb.AuthRoleGrantPermissionRequest{
  386. Name: "role-test-1",
  387. Perm: perm,
  388. })
  389. if err != nil {
  390. t.Fatal(err)
  391. }
  392. _, err = as.RoleGet(&pb.AuthRoleGetRequest{Role: "role-test-1"})
  393. if err != nil {
  394. t.Fatal(err)
  395. }
  396. _, err = as.RoleRevokePermission(&pb.AuthRoleRevokePermissionRequest{
  397. Role: "role-test-1",
  398. Key: []byte("Keys"),
  399. RangeEnd: []byte("RangeEnd"),
  400. })
  401. if err != nil {
  402. t.Fatal(err)
  403. }
  404. var r *pb.AuthRoleGetResponse
  405. r, err = as.RoleGet(&pb.AuthRoleGetRequest{Role: "role-test-1"})
  406. if err != nil {
  407. t.Fatal(err)
  408. }
  409. if len(r.Perm) != 0 {
  410. t.Errorf("expected %v, got %v", 0, len(r.Perm))
  411. }
  412. }
  413. func TestUserRevokePermission(t *testing.T) {
  414. as, tearDown := setupAuthStore(t)
  415. defer tearDown(t)
  416. _, err := as.RoleAdd(&pb.AuthRoleAddRequest{Name: "role-test-1"})
  417. if err != nil {
  418. t.Fatal(err)
  419. }
  420. _, err = as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo", Role: "role-test"})
  421. if err != nil {
  422. t.Fatal(err)
  423. }
  424. _, err = as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: "foo", Role: "role-test-1"})
  425. if err != nil {
  426. t.Fatal(err)
  427. }
  428. u, err := as.UserGet(&pb.AuthUserGetRequest{Name: "foo"})
  429. if err != nil {
  430. t.Fatal(err)
  431. }
  432. expected := []string{"role-test", "role-test-1"}
  433. if !reflect.DeepEqual(expected, u.Roles) {
  434. t.Fatalf("expected %v, got %v", expected, u.Roles)
  435. }
  436. _, err = as.UserRevokeRole(&pb.AuthUserRevokeRoleRequest{Name: "foo", Role: "role-test-1"})
  437. if err != nil {
  438. t.Fatal(err)
  439. }
  440. u, err = as.UserGet(&pb.AuthUserGetRequest{Name: "foo"})
  441. if err != nil {
  442. t.Fatal(err)
  443. }
  444. expected = []string{"role-test"}
  445. if !reflect.DeepEqual(expected, u.Roles) {
  446. t.Errorf("expected %v, got %v", expected, u.Roles)
  447. }
  448. }
  449. func TestRoleDelete(t *testing.T) {
  450. as, tearDown := setupAuthStore(t)
  451. defer tearDown(t)
  452. _, err := as.RoleDelete(&pb.AuthRoleDeleteRequest{Role: "role-test"})
  453. if err != nil {
  454. t.Fatal(err)
  455. }
  456. rl, err := as.RoleList(&pb.AuthRoleListRequest{})
  457. if err != nil {
  458. t.Fatal(err)
  459. }
  460. expected := []string{"root"}
  461. if !reflect.DeepEqual(expected, rl.Roles) {
  462. t.Errorf("expected %v, got %v", expected, rl.Roles)
  463. }
  464. }
  465. func TestAuthInfoFromCtx(t *testing.T) {
  466. as, tearDown := setupAuthStore(t)
  467. defer tearDown(t)
  468. ctx := context.Background()
  469. ai, err := as.AuthInfoFromCtx(ctx)
  470. if err != nil && ai != nil {
  471. t.Errorf("expected (nil, nil), got (%v, %v)", ai, err)
  472. }
  473. // as if it came from RPC
  474. ctx = metadata.NewIncomingContext(context.Background(), metadata.New(map[string]string{"tokens": "dummy"}))
  475. ai, err = as.AuthInfoFromCtx(ctx)
  476. if err != nil && ai != nil {
  477. t.Errorf("expected (nil, nil), got (%v, %v)", ai, err)
  478. }
  479. ctx = context.WithValue(context.WithValue(context.TODO(), AuthenticateParamIndex{}, uint64(1)), AuthenticateParamSimpleTokenPrefix{}, "dummy")
  480. resp, err := as.Authenticate(ctx, "foo", "bar")
  481. if err != nil {
  482. t.Error(err)
  483. }
  484. ctx = metadata.NewIncomingContext(context.Background(), metadata.New(map[string]string{rpctypes.TokenFieldNameGRPC: "Invalid Token"}))
  485. _, err = as.AuthInfoFromCtx(ctx)
  486. if err != ErrInvalidAuthToken {
  487. t.Errorf("expected %v, got %v", ErrInvalidAuthToken, err)
  488. }
  489. ctx = metadata.NewIncomingContext(context.Background(), metadata.New(map[string]string{rpctypes.TokenFieldNameGRPC: "Invalid.Token"}))
  490. _, err = as.AuthInfoFromCtx(ctx)
  491. if err != ErrInvalidAuthToken {
  492. t.Errorf("expected %v, got %v", ErrInvalidAuthToken, err)
  493. }
  494. ctx = metadata.NewIncomingContext(context.Background(), metadata.New(map[string]string{rpctypes.TokenFieldNameGRPC: resp.Token}))
  495. ai, err = as.AuthInfoFromCtx(ctx)
  496. if err != nil {
  497. t.Error(err)
  498. }
  499. if ai.Username != "foo" {
  500. t.Errorf("expected %v, got %v", "foo", ai.Username)
  501. }
  502. }
  503. func TestAuthDisable(t *testing.T) {
  504. as, tearDown := setupAuthStore(t)
  505. defer tearDown(t)
  506. as.AuthDisable()
  507. ctx := context.WithValue(context.WithValue(context.TODO(), AuthenticateParamIndex{}, uint64(2)), AuthenticateParamSimpleTokenPrefix{}, "dummy")
  508. _, err := as.Authenticate(ctx, "foo", "bar")
  509. if err != ErrAuthNotEnabled {
  510. t.Errorf("expected %v, got %v", ErrAuthNotEnabled, err)
  511. }
  512. // Disabling disabled auth to make sure it can return safely if store is already disabled.
  513. as.AuthDisable()
  514. _, err = as.Authenticate(ctx, "foo", "bar")
  515. if err != ErrAuthNotEnabled {
  516. t.Errorf("expected %v, got %v", ErrAuthNotEnabled, err)
  517. }
  518. }
  519. // TestAuthRevisionRace ensures that access to authStore.revision is thread-safe.
  520. func TestAuthInfoFromCtxRace(t *testing.T) {
  521. b, tPath := backend.NewDefaultTmpBackend()
  522. defer os.Remove(tPath)
  523. tp, err := NewTokenProvider(zap.NewExample(), tokenTypeSimple, dummyIndexWaiter)
  524. if err != nil {
  525. t.Fatal(err)
  526. }
  527. as := NewAuthStore(zap.NewExample(), b, tp, bcrypt.MinCost)
  528. defer as.Close()
  529. donec := make(chan struct{})
  530. go func() {
  531. defer close(donec)
  532. ctx := metadata.NewIncomingContext(context.Background(), metadata.New(map[string]string{rpctypes.TokenFieldNameGRPC: "test"}))
  533. as.AuthInfoFromCtx(ctx)
  534. }()
  535. as.UserAdd(&pb.AuthUserAddRequest{Name: "test", Options: &authpb.UserAddOptions{NoPassword: false}})
  536. <-donec
  537. }
  538. func TestIsAdminPermitted(t *testing.T) {
  539. as, tearDown := setupAuthStore(t)
  540. defer tearDown(t)
  541. err := as.IsAdminPermitted(&AuthInfo{Username: "root", Revision: 1})
  542. if err != nil {
  543. t.Errorf("expected nil, got %v", err)
  544. }
  545. // invalid user
  546. err = as.IsAdminPermitted(&AuthInfo{Username: "rooti", Revision: 1})
  547. if err != ErrUserNotFound {
  548. t.Errorf("expected %v, got %v", ErrUserNotFound, err)
  549. }
  550. // non-admin user
  551. err = as.IsAdminPermitted(&AuthInfo{Username: "foo", Revision: 1})
  552. if err != ErrPermissionDenied {
  553. t.Errorf("expected %v, got %v", ErrPermissionDenied, err)
  554. }
  555. // disabled auth should return nil
  556. as.AuthDisable()
  557. err = as.IsAdminPermitted(&AuthInfo{Username: "root", Revision: 1})
  558. if err != nil {
  559. t.Errorf("expected nil, got %v", err)
  560. }
  561. }
  562. func TestRecoverFromSnapshot(t *testing.T) {
  563. as, _ := setupAuthStore(t)
  564. ua := &pb.AuthUserAddRequest{Name: "foo", Options: &authpb.UserAddOptions{NoPassword: false}}
  565. _, err := as.UserAdd(ua) // add an existing user
  566. if err == nil {
  567. t.Fatalf("expected %v, got %v", ErrUserAlreadyExist, err)
  568. }
  569. if err != ErrUserAlreadyExist {
  570. t.Fatalf("expected %v, got %v", ErrUserAlreadyExist, err)
  571. }
  572. ua = &pb.AuthUserAddRequest{Name: "", Options: &authpb.UserAddOptions{NoPassword: false}}
  573. _, err = as.UserAdd(ua) // add a user with empty name
  574. if err != ErrUserEmpty {
  575. t.Fatal(err)
  576. }
  577. as.Close()
  578. tp, err := NewTokenProvider(zap.NewExample(), tokenTypeSimple, dummyIndexWaiter)
  579. if err != nil {
  580. t.Fatal(err)
  581. }
  582. as2 := NewAuthStore(zap.NewExample(), as.be, tp, bcrypt.MinCost)
  583. defer func(a *authStore) {
  584. a.Close()
  585. }(as2)
  586. if !as2.IsAuthEnabled() {
  587. t.Fatal("recovering authStore from existing backend failed")
  588. }
  589. ul, err := as.UserList(&pb.AuthUserListRequest{})
  590. if err != nil {
  591. t.Fatal(err)
  592. }
  593. if !contains(ul.Users, "root") {
  594. t.Errorf("expected %v in %v", "root", ul.Users)
  595. }
  596. }
  597. func contains(array []string, str string) bool {
  598. for _, s := range array {
  599. if s == str {
  600. return true
  601. }
  602. }
  603. return false
  604. }
  605. func TestHammerSimpleAuthenticate(t *testing.T) {
  606. // set TTL values low to try to trigger races
  607. oldTTL, oldTTLRes := simpleTokenTTL, simpleTokenTTLResolution
  608. defer func() {
  609. simpleTokenTTL = oldTTL
  610. simpleTokenTTLResolution = oldTTLRes
  611. }()
  612. simpleTokenTTL = 10 * time.Millisecond
  613. simpleTokenTTLResolution = simpleTokenTTL
  614. users := make(map[string]struct{})
  615. as, tearDown := setupAuthStore(t)
  616. defer tearDown(t)
  617. // create lots of users
  618. for i := 0; i < 50; i++ {
  619. u := fmt.Sprintf("user-%d", i)
  620. ua := &pb.AuthUserAddRequest{Name: u, Password: "123", Options: &authpb.UserAddOptions{NoPassword: false}}
  621. if _, err := as.UserAdd(ua); err != nil {
  622. t.Fatal(err)
  623. }
  624. users[u] = struct{}{}
  625. }
  626. // hammer on authenticate with lots of users
  627. for i := 0; i < 10; i++ {
  628. var wg sync.WaitGroup
  629. wg.Add(len(users))
  630. for u := range users {
  631. go func(user string) {
  632. defer wg.Done()
  633. token := fmt.Sprintf("%s(%d)", user, i)
  634. ctx := context.WithValue(context.WithValue(context.TODO(), AuthenticateParamIndex{}, uint64(1)), AuthenticateParamSimpleTokenPrefix{}, token)
  635. if _, err := as.Authenticate(ctx, user, "123"); err != nil {
  636. t.Fatal(err)
  637. }
  638. if _, err := as.AuthInfoFromCtx(ctx); err != nil {
  639. t.Fatal(err)
  640. }
  641. }(u)
  642. }
  643. time.Sleep(time.Millisecond)
  644. wg.Wait()
  645. }
  646. }
  647. // TestRolesOrder tests authpb.User.Roles is sorted
  648. func TestRolesOrder(t *testing.T) {
  649. b, tPath := backend.NewDefaultTmpBackend()
  650. defer os.Remove(tPath)
  651. tp, err := NewTokenProvider(zap.NewExample(), tokenTypeSimple, dummyIndexWaiter)
  652. if err != nil {
  653. t.Fatal(err)
  654. }
  655. as := NewAuthStore(zap.NewExample(), b, tp, bcrypt.MinCost)
  656. err = enableAuthAndCreateRoot(as)
  657. if err != nil {
  658. t.Fatal(err)
  659. }
  660. username := "user"
  661. _, err = as.UserAdd(&pb.AuthUserAddRequest{Name: username, Password: "pass", Options: &authpb.UserAddOptions{NoPassword: false}})
  662. if err != nil {
  663. t.Fatal(err)
  664. }
  665. roles := []string{"role1", "role2", "abc", "xyz", "role3"}
  666. for _, role := range roles {
  667. _, err = as.RoleAdd(&pb.AuthRoleAddRequest{Name: role})
  668. if err != nil {
  669. t.Fatal(err)
  670. }
  671. _, err = as.UserGrantRole(&pb.AuthUserGrantRoleRequest{User: username, Role: role})
  672. if err != nil {
  673. t.Fatal(err)
  674. }
  675. }
  676. user, err := as.UserGet(&pb.AuthUserGetRequest{Name: username})
  677. if err != nil {
  678. t.Fatal(err)
  679. }
  680. for i := 1; i < len(user.Roles); i++ {
  681. if strings.Compare(user.Roles[i-1], user.Roles[i]) != -1 {
  682. t.Errorf("User.Roles isn't sorted (%s vs %s)", user.Roles[i-1], user.Roles[i])
  683. }
  684. }
  685. }
  686. func TestAuthInfoFromCtxWithRootSimple(t *testing.T) {
  687. testAuthInfoFromCtxWithRoot(t, tokenTypeSimple)
  688. }
  689. func TestAuthInfoFromCtxWithRootJWT(t *testing.T) {
  690. opts := testJWTOpts()
  691. testAuthInfoFromCtxWithRoot(t, opts)
  692. }
  693. // testAuthInfoFromCtxWithRoot ensures "WithRoot" properly embeds token in the context.
  694. func testAuthInfoFromCtxWithRoot(t *testing.T, opts string) {
  695. b, tPath := backend.NewDefaultTmpBackend()
  696. defer os.Remove(tPath)
  697. tp, err := NewTokenProvider(zap.NewExample(), opts, dummyIndexWaiter)
  698. if err != nil {
  699. t.Fatal(err)
  700. }
  701. as := NewAuthStore(zap.NewExample(), b, tp, bcrypt.MinCost)
  702. defer as.Close()
  703. if err = enableAuthAndCreateRoot(as); err != nil {
  704. t.Fatal(err)
  705. }
  706. ctx := context.Background()
  707. ctx = as.WithRoot(ctx)
  708. ai, aerr := as.AuthInfoFromCtx(ctx)
  709. if aerr != nil {
  710. t.Error(err)
  711. }
  712. if ai == nil {
  713. t.Error("expected non-nil *AuthInfo")
  714. }
  715. if ai.Username != "root" {
  716. t.Errorf("expected user name 'root', got %+v", ai)
  717. }
  718. }
  719. func TestUserNoPasswordAdd(t *testing.T) {
  720. as, tearDown := setupAuthStore(t)
  721. defer tearDown(t)
  722. username := "usernopass"
  723. ua := &pb.AuthUserAddRequest{Name: username, Options: &authpb.UserAddOptions{NoPassword: true}}
  724. _, err := as.UserAdd(ua)
  725. if err != nil {
  726. t.Fatal(err)
  727. }
  728. ctx := context.WithValue(context.WithValue(context.TODO(), AuthenticateParamIndex{}, uint64(1)), AuthenticateParamSimpleTokenPrefix{}, "dummy")
  729. _, err = as.Authenticate(ctx, username, "")
  730. if err != ErrAuthFailed {
  731. t.Fatalf("expected %v, got %v", ErrAuthFailed, err)
  732. }
  733. }