key.go 6.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261
  1. // Copyright 2015 The etcd Authors
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. // Package v3rpc implements etcd v3 RPC system based on gRPC.
  15. package v3rpc
  16. import (
  17. "sort"
  18. "github.com/coreos/etcd/etcdserver"
  19. "github.com/coreos/etcd/etcdserver/api/v3rpc/rpctypes"
  20. pb "github.com/coreos/etcd/etcdserver/etcdserverpb"
  21. "github.com/coreos/pkg/capnslog"
  22. "golang.org/x/net/context"
  23. )
  24. var (
  25. plog = capnslog.NewPackageLogger("github.com/coreos/etcd", "etcdserver/api/v3rpc")
  26. )
  27. type kvServer struct {
  28. hdr header
  29. kv etcdserver.RaftKV
  30. // maxTxnOps is the max operations per txn.
  31. // e.g suppose maxTxnOps = 128.
  32. // Txn.Success can have at most 128 operations,
  33. // and Txn.Failure can have at most 128 operations.
  34. maxTxnOps uint
  35. }
  36. func NewKVServer(s *etcdserver.EtcdServer) pb.KVServer {
  37. return &kvServer{hdr: newHeader(s), kv: s, maxTxnOps: s.Cfg.MaxTxnOps}
  38. }
  39. func (s *kvServer) Range(ctx context.Context, r *pb.RangeRequest) (*pb.RangeResponse, error) {
  40. if err := checkRangeRequest(r); err != nil {
  41. return nil, err
  42. }
  43. resp, err := s.kv.Range(ctx, r)
  44. if err != nil {
  45. return nil, togRPCError(err)
  46. }
  47. if resp.Header == nil {
  48. plog.Panic("unexpected nil resp.Header")
  49. }
  50. s.hdr.fill(resp.Header)
  51. return resp, nil
  52. }
  53. func (s *kvServer) Put(ctx context.Context, r *pb.PutRequest) (*pb.PutResponse, error) {
  54. if err := checkPutRequest(r); err != nil {
  55. return nil, err
  56. }
  57. resp, err := s.kv.Put(ctx, r)
  58. if err != nil {
  59. return nil, togRPCError(err)
  60. }
  61. if resp.Header == nil {
  62. plog.Panic("unexpected nil resp.Header")
  63. }
  64. s.hdr.fill(resp.Header)
  65. return resp, nil
  66. }
  67. func (s *kvServer) DeleteRange(ctx context.Context, r *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error) {
  68. if err := checkDeleteRequest(r); err != nil {
  69. return nil, err
  70. }
  71. resp, err := s.kv.DeleteRange(ctx, r)
  72. if err != nil {
  73. return nil, togRPCError(err)
  74. }
  75. if resp.Header == nil {
  76. plog.Panic("unexpected nil resp.Header")
  77. }
  78. s.hdr.fill(resp.Header)
  79. return resp, nil
  80. }
  81. func (s *kvServer) Txn(ctx context.Context, r *pb.TxnRequest) (*pb.TxnResponse, error) {
  82. if err := checkTxnRequest(r, int(s.maxTxnOps)); err != nil {
  83. return nil, err
  84. }
  85. resp, err := s.kv.Txn(ctx, r)
  86. if err != nil {
  87. return nil, togRPCError(err)
  88. }
  89. if resp.Header == nil {
  90. plog.Panic("unexpected nil resp.Header")
  91. }
  92. s.hdr.fill(resp.Header)
  93. return resp, nil
  94. }
  95. func (s *kvServer) Compact(ctx context.Context, r *pb.CompactionRequest) (*pb.CompactionResponse, error) {
  96. resp, err := s.kv.Compact(ctx, r)
  97. if err != nil {
  98. return nil, togRPCError(err)
  99. }
  100. if resp.Header == nil {
  101. plog.Panic("unexpected nil resp.Header")
  102. }
  103. s.hdr.fill(resp.Header)
  104. return resp, nil
  105. }
  106. func checkRangeRequest(r *pb.RangeRequest) error {
  107. if len(r.Key) == 0 {
  108. return rpctypes.ErrGRPCEmptyKey
  109. }
  110. return nil
  111. }
  112. func checkPutRequest(r *pb.PutRequest) error {
  113. if len(r.Key) == 0 {
  114. return rpctypes.ErrGRPCEmptyKey
  115. }
  116. if r.IgnoreValue && len(r.Value) != 0 {
  117. return rpctypes.ErrGRPCValueProvided
  118. }
  119. if r.IgnoreLease && r.Lease != 0 {
  120. return rpctypes.ErrGRPCLeaseProvided
  121. }
  122. return nil
  123. }
  124. func checkDeleteRequest(r *pb.DeleteRangeRequest) error {
  125. if len(r.Key) == 0 {
  126. return rpctypes.ErrGRPCEmptyKey
  127. }
  128. return nil
  129. }
  130. func checkTxnRequest(r *pb.TxnRequest, maxTxnOps int) error {
  131. plog.Infof("maxTxnOps %v", maxTxnOps)
  132. if len(r.Compare) > maxTxnOps || len(r.Success) > maxTxnOps || len(r.Failure) > maxTxnOps {
  133. return rpctypes.ErrGRPCTooManyOps
  134. }
  135. for _, c := range r.Compare {
  136. if len(c.Key) == 0 {
  137. return rpctypes.ErrGRPCEmptyKey
  138. }
  139. }
  140. for _, u := range r.Success {
  141. if err := checkRequestOp(u); err != nil {
  142. return err
  143. }
  144. }
  145. if err := checkRequestDupKeys(r.Success); err != nil {
  146. return err
  147. }
  148. for _, u := range r.Failure {
  149. if err := checkRequestOp(u); err != nil {
  150. return err
  151. }
  152. }
  153. return checkRequestDupKeys(r.Failure)
  154. }
  155. // checkRequestDupKeys gives rpctypes.ErrGRPCDuplicateKey if the same key is modified twice
  156. func checkRequestDupKeys(reqs []*pb.RequestOp) error {
  157. // check put overlap
  158. keys := make(map[string]struct{})
  159. for _, requ := range reqs {
  160. tv, ok := requ.Request.(*pb.RequestOp_RequestPut)
  161. if !ok {
  162. continue
  163. }
  164. preq := tv.RequestPut
  165. if preq == nil {
  166. continue
  167. }
  168. if _, ok := keys[string(preq.Key)]; ok {
  169. return rpctypes.ErrGRPCDuplicateKey
  170. }
  171. keys[string(preq.Key)] = struct{}{}
  172. }
  173. // no need to check deletes if no puts; delete overlaps are permitted
  174. if len(keys) == 0 {
  175. return nil
  176. }
  177. // sort keys for range checking
  178. sortedKeys := []string{}
  179. for k := range keys {
  180. sortedKeys = append(sortedKeys, k)
  181. }
  182. sort.Strings(sortedKeys)
  183. // check put overlap with deletes
  184. for _, requ := range reqs {
  185. tv, ok := requ.Request.(*pb.RequestOp_RequestDeleteRange)
  186. if !ok {
  187. continue
  188. }
  189. dreq := tv.RequestDeleteRange
  190. if dreq == nil {
  191. continue
  192. }
  193. if dreq.RangeEnd == nil {
  194. if _, found := keys[string(dreq.Key)]; found {
  195. return rpctypes.ErrGRPCDuplicateKey
  196. }
  197. } else {
  198. lo := sort.SearchStrings(sortedKeys, string(dreq.Key))
  199. hi := sort.SearchStrings(sortedKeys, string(dreq.RangeEnd))
  200. if lo != hi {
  201. // element between lo and hi => overlap
  202. return rpctypes.ErrGRPCDuplicateKey
  203. }
  204. }
  205. }
  206. return nil
  207. }
  208. func checkRequestOp(u *pb.RequestOp) error {
  209. // TODO: ensure only one of the field is set.
  210. switch uv := u.Request.(type) {
  211. case *pb.RequestOp_RequestRange:
  212. if uv.RequestRange != nil {
  213. return checkRangeRequest(uv.RequestRange)
  214. }
  215. case *pb.RequestOp_RequestPut:
  216. if uv.RequestPut != nil {
  217. return checkPutRequest(uv.RequestPut)
  218. }
  219. case *pb.RequestOp_RequestDeleteRange:
  220. if uv.RequestDeleteRange != nil {
  221. return checkDeleteRequest(uv.RequestDeleteRange)
  222. }
  223. default:
  224. // empty op
  225. return nil
  226. }
  227. return nil
  228. }