ctl_v3_auth_test.go 26 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962
  1. // Copyright 2016 The etcd Authors
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. // Skip proxy tests for now since auth is broken on grpcproxy.
  15. // +build !cluster_proxy
  16. package e2e
  17. import (
  18. "fmt"
  19. "os"
  20. "testing"
  21. "github.com/coreos/etcd/clientv3"
  22. )
  23. func TestCtlV3AuthEnable(t *testing.T) { testCtl(t, authEnableTest) }
  24. func TestCtlV3AuthDisable(t *testing.T) { testCtl(t, authDisableTest) }
  25. func TestCtlV3AuthWriteKey(t *testing.T) { testCtl(t, authCredWriteKeyTest) }
  26. func TestCtlV3AuthRoleUpdate(t *testing.T) { testCtl(t, authRoleUpdateTest) }
  27. func TestCtlV3AuthUserDeleteDuringOps(t *testing.T) { testCtl(t, authUserDeleteDuringOpsTest) }
  28. func TestCtlV3AuthRoleRevokeDuringOps(t *testing.T) { testCtl(t, authRoleRevokeDuringOpsTest) }
  29. func TestCtlV3AuthTxn(t *testing.T) { testCtl(t, authTestTxn) }
  30. func TestCtlV3AuthPrefixPerm(t *testing.T) { testCtl(t, authTestPrefixPerm) }
  31. func TestCtlV3AuthMemberAdd(t *testing.T) { testCtl(t, authTestMemberAdd) }
  32. func TestCtlV3AuthMemberRemove(t *testing.T) {
  33. testCtl(t, authTestMemberRemove, withQuorum(), withNoStrictReconfig())
  34. }
  35. func TestCtlV3AuthMemberUpdate(t *testing.T) { testCtl(t, authTestMemberUpdate) }
  36. func TestCtlV3AuthCertCN(t *testing.T) { testCtl(t, authTestCertCN, withCfg(configClientTLSCertAuth)) }
  37. func TestCtlV3AuthRevokeWithDelete(t *testing.T) { testCtl(t, authTestRevokeWithDelete) }
  38. func TestCtlV3AuthInvalidMgmt(t *testing.T) { testCtl(t, authTestInvalidMgmt) }
  39. func TestCtlV3AuthFromKeyPerm(t *testing.T) { testCtl(t, authTestFromKeyPerm) }
  40. func TestCtlV3AuthAndWatch(t *testing.T) { testCtl(t, authTestWatch) }
  41. func TestCtlV3AuthRoleGet(t *testing.T) { testCtl(t, authTestRoleGet) }
  42. func TestCtlV3AuthUserGet(t *testing.T) { testCtl(t, authTestUserGet) }
  43. func TestCtlV3AuthRoleList(t *testing.T) { testCtl(t, authTestRoleList) }
  44. func TestCtlV3AuthDefrag(t *testing.T) { testCtl(t, authTestDefrag) }
  45. func TestCtlV3AuthEndpointHealth(t *testing.T) {
  46. testCtl(t, authTestEndpointHealth, withQuorum())
  47. }
  48. func TestCtlV3AuthSnapshot(t *testing.T) { testCtl(t, authTestSnapshot) }
  49. func authEnableTest(cx ctlCtx) {
  50. if err := authEnable(cx); err != nil {
  51. cx.t.Fatal(err)
  52. }
  53. }
  54. func authEnable(cx ctlCtx) error {
  55. // create root user with root role
  56. if err := ctlV3User(cx, []string{"add", "root", "--interactive=false"}, "User root created", []string{"root"}); err != nil {
  57. return fmt.Errorf("failed to create root user %v", err)
  58. }
  59. if err := ctlV3User(cx, []string{"grant-role", "root", "root"}, "Role root is granted to user root", nil); err != nil {
  60. return fmt.Errorf("failed to grant root user root role %v", err)
  61. }
  62. if err := ctlV3AuthEnable(cx); err != nil {
  63. return fmt.Errorf("authEnableTest ctlV3AuthEnable error (%v)", err)
  64. }
  65. return nil
  66. }
  67. func ctlV3AuthEnable(cx ctlCtx) error {
  68. cmdArgs := append(cx.PrefixArgs(), "auth", "enable")
  69. return spawnWithExpect(cmdArgs, "Authentication Enabled")
  70. }
  71. func authDisableTest(cx ctlCtx) {
  72. // a key that isn't granted to test-user
  73. if err := ctlV3Put(cx, "hoo", "a", ""); err != nil {
  74. cx.t.Fatal(err)
  75. }
  76. if err := authEnable(cx); err != nil {
  77. cx.t.Fatal(err)
  78. }
  79. cx.user, cx.pass = "root", "root"
  80. authSetupTestUser(cx)
  81. // test-user doesn't have the permission, it must fail
  82. cx.user, cx.pass = "test-user", "pass"
  83. if err := ctlV3PutFailPerm(cx, "hoo", "bar"); err != nil {
  84. cx.t.Fatal(err)
  85. }
  86. cx.user, cx.pass = "root", "root"
  87. if err := ctlV3AuthDisable(cx); err != nil {
  88. cx.t.Fatalf("authDisableTest ctlV3AuthDisable error (%v)", err)
  89. }
  90. // now ErrAuthNotEnabled of Authenticate() is simply ignored
  91. cx.user, cx.pass = "test-user", "pass"
  92. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  93. cx.t.Fatal(err)
  94. }
  95. // now the key can be accessed
  96. cx.user, cx.pass = "", ""
  97. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  98. cx.t.Fatal(err)
  99. }
  100. // confirm put succeeded
  101. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar"}}...); err != nil {
  102. cx.t.Fatal(err)
  103. }
  104. }
  105. func ctlV3AuthDisable(cx ctlCtx) error {
  106. cmdArgs := append(cx.PrefixArgs(), "auth", "disable")
  107. return spawnWithExpect(cmdArgs, "Authentication Disabled")
  108. }
  109. func authCredWriteKeyTest(cx ctlCtx) {
  110. // baseline key to check for failed puts
  111. if err := ctlV3Put(cx, "foo", "a", ""); err != nil {
  112. cx.t.Fatal(err)
  113. }
  114. if err := authEnable(cx); err != nil {
  115. cx.t.Fatal(err)
  116. }
  117. cx.user, cx.pass = "root", "root"
  118. authSetupTestUser(cx)
  119. // confirm root role can access to all keys
  120. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  121. cx.t.Fatal(err)
  122. }
  123. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  124. cx.t.Fatal(err)
  125. }
  126. // try invalid user
  127. cx.user, cx.pass = "a", "b"
  128. if err := ctlV3PutFailAuth(cx, "foo", "bar"); err != nil {
  129. cx.t.Fatal(err)
  130. }
  131. // confirm put failed
  132. cx.user, cx.pass = "test-user", "pass"
  133. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  134. cx.t.Fatal(err)
  135. }
  136. // try good user
  137. cx.user, cx.pass = "test-user", "pass"
  138. if err := ctlV3Put(cx, "foo", "bar2", ""); err != nil {
  139. cx.t.Fatal(err)
  140. }
  141. // confirm put succeeded
  142. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar2"}}...); err != nil {
  143. cx.t.Fatal(err)
  144. }
  145. // try bad password
  146. cx.user, cx.pass = "test-user", "badpass"
  147. if err := ctlV3PutFailAuth(cx, "foo", "baz"); err != nil {
  148. cx.t.Fatal(err)
  149. }
  150. // confirm put failed
  151. cx.user, cx.pass = "test-user", "pass"
  152. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar2"}}...); err != nil {
  153. cx.t.Fatal(err)
  154. }
  155. }
  156. func authRoleUpdateTest(cx ctlCtx) {
  157. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  158. cx.t.Fatal(err)
  159. }
  160. if err := authEnable(cx); err != nil {
  161. cx.t.Fatal(err)
  162. }
  163. cx.user, cx.pass = "root", "root"
  164. authSetupTestUser(cx)
  165. // try put to not granted key
  166. cx.user, cx.pass = "test-user", "pass"
  167. if err := ctlV3PutFailPerm(cx, "hoo", "bar"); err != nil {
  168. cx.t.Fatal(err)
  169. }
  170. // grant a new key
  171. cx.user, cx.pass = "root", "root"
  172. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "hoo", "", false}); err != nil {
  173. cx.t.Fatal(err)
  174. }
  175. // try a newly granted key
  176. cx.user, cx.pass = "test-user", "pass"
  177. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  178. cx.t.Fatal(err)
  179. }
  180. // confirm put succeeded
  181. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar"}}...); err != nil {
  182. cx.t.Fatal(err)
  183. }
  184. // revoke the newly granted key
  185. cx.user, cx.pass = "root", "root"
  186. if err := ctlV3RoleRevokePermission(cx, "test-role", "hoo", "", false); err != nil {
  187. cx.t.Fatal(err)
  188. }
  189. // try put to the revoked key
  190. cx.user, cx.pass = "test-user", "pass"
  191. if err := ctlV3PutFailPerm(cx, "hoo", "bar"); err != nil {
  192. cx.t.Fatal(err)
  193. }
  194. // confirm a key still granted can be accessed
  195. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  196. cx.t.Fatal(err)
  197. }
  198. }
  199. func authUserDeleteDuringOpsTest(cx ctlCtx) {
  200. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  201. cx.t.Fatal(err)
  202. }
  203. if err := authEnable(cx); err != nil {
  204. cx.t.Fatal(err)
  205. }
  206. cx.user, cx.pass = "root", "root"
  207. authSetupTestUser(cx)
  208. // create a key
  209. cx.user, cx.pass = "test-user", "pass"
  210. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  211. cx.t.Fatal(err)
  212. }
  213. // confirm put succeeded
  214. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  215. cx.t.Fatal(err)
  216. }
  217. // delete the user
  218. cx.user, cx.pass = "root", "root"
  219. err := ctlV3User(cx, []string{"delete", "test-user"}, "User test-user deleted", []string{})
  220. if err != nil {
  221. cx.t.Fatal(err)
  222. }
  223. // check the user is deleted
  224. cx.user, cx.pass = "test-user", "pass"
  225. if err := ctlV3PutFailAuth(cx, "foo", "baz"); err != nil {
  226. cx.t.Fatal(err)
  227. }
  228. }
  229. func authRoleRevokeDuringOpsTest(cx ctlCtx) {
  230. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  231. cx.t.Fatal(err)
  232. }
  233. if err := authEnable(cx); err != nil {
  234. cx.t.Fatal(err)
  235. }
  236. cx.user, cx.pass = "root", "root"
  237. authSetupTestUser(cx)
  238. // create a key
  239. cx.user, cx.pass = "test-user", "pass"
  240. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  241. cx.t.Fatal(err)
  242. }
  243. // confirm put succeeded
  244. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  245. cx.t.Fatal(err)
  246. }
  247. // create a new role
  248. cx.user, cx.pass = "root", "root"
  249. if err := ctlV3Role(cx, []string{"add", "test-role2"}, "Role test-role2 created"); err != nil {
  250. cx.t.Fatal(err)
  251. }
  252. // grant a new key to the new role
  253. if err := ctlV3RoleGrantPermission(cx, "test-role2", grantingPerm{true, true, "hoo", "", false}); err != nil {
  254. cx.t.Fatal(err)
  255. }
  256. // grant the new role to the user
  257. if err := ctlV3User(cx, []string{"grant-role", "test-user", "test-role2"}, "Role test-role2 is granted to user test-user", nil); err != nil {
  258. cx.t.Fatal(err)
  259. }
  260. // try a newly granted key
  261. cx.user, cx.pass = "test-user", "pass"
  262. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  263. cx.t.Fatal(err)
  264. }
  265. // confirm put succeeded
  266. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar"}}...); err != nil {
  267. cx.t.Fatal(err)
  268. }
  269. // revoke a role from the user
  270. cx.user, cx.pass = "root", "root"
  271. err := ctlV3User(cx, []string{"revoke-role", "test-user", "test-role"}, "Role test-role is revoked from user test-user", []string{})
  272. if err != nil {
  273. cx.t.Fatal(err)
  274. }
  275. // check the role is revoked and permission is lost from the user
  276. cx.user, cx.pass = "test-user", "pass"
  277. if err := ctlV3PutFailPerm(cx, "foo", "baz"); err != nil {
  278. cx.t.Fatal(err)
  279. }
  280. // try a key that can be accessed from the remaining role
  281. cx.user, cx.pass = "test-user", "pass"
  282. if err := ctlV3Put(cx, "hoo", "bar2", ""); err != nil {
  283. cx.t.Fatal(err)
  284. }
  285. // confirm put succeeded
  286. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar2"}}...); err != nil {
  287. cx.t.Fatal(err)
  288. }
  289. }
  290. func ctlV3PutFailAuth(cx ctlCtx, key, val string) error {
  291. return spawnWithExpect(append(cx.PrefixArgs(), "put", key, val), "authentication failed")
  292. }
  293. func ctlV3PutFailPerm(cx ctlCtx, key, val string) error {
  294. return spawnWithExpect(append(cx.PrefixArgs(), "put", key, val), "permission denied")
  295. }
  296. func authSetupTestUser(cx ctlCtx) {
  297. if err := ctlV3User(cx, []string{"add", "test-user", "--interactive=false"}, "User test-user created", []string{"pass"}); err != nil {
  298. cx.t.Fatal(err)
  299. }
  300. if err := spawnWithExpect(append(cx.PrefixArgs(), "role", "add", "test-role"), "Role test-role created"); err != nil {
  301. cx.t.Fatal(err)
  302. }
  303. if err := ctlV3User(cx, []string{"grant-role", "test-user", "test-role"}, "Role test-role is granted to user test-user", nil); err != nil {
  304. cx.t.Fatal(err)
  305. }
  306. cmd := append(cx.PrefixArgs(), "role", "grant-permission", "test-role", "readwrite", "foo")
  307. if err := spawnWithExpect(cmd, "Role test-role updated"); err != nil {
  308. cx.t.Fatal(err)
  309. }
  310. }
  311. func authTestTxn(cx ctlCtx) {
  312. // keys with 1 suffix aren't granted to test-user
  313. // keys with 2 suffix are granted to test-user
  314. keys := []string{"c1", "s1", "f1"}
  315. grantedKeys := []string{"c2", "s2", "f2"}
  316. for _, key := range keys {
  317. if err := ctlV3Put(cx, key, "v", ""); err != nil {
  318. cx.t.Fatal(err)
  319. }
  320. }
  321. for _, key := range grantedKeys {
  322. if err := ctlV3Put(cx, key, "v", ""); err != nil {
  323. cx.t.Fatal(err)
  324. }
  325. }
  326. if err := authEnable(cx); err != nil {
  327. cx.t.Fatal(err)
  328. }
  329. cx.user, cx.pass = "root", "root"
  330. authSetupTestUser(cx)
  331. // grant keys to test-user
  332. cx.user, cx.pass = "root", "root"
  333. for _, key := range grantedKeys {
  334. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, key, "", false}); err != nil {
  335. cx.t.Fatal(err)
  336. }
  337. }
  338. // now test txn
  339. cx.interactive = true
  340. cx.user, cx.pass = "test-user", "pass"
  341. rqs := txnRequests{
  342. compare: []string{`version("c2") = "1"`},
  343. ifSucess: []string{"get s2"},
  344. ifFail: []string{"get f2"},
  345. results: []string{"SUCCESS", "s2", "v"},
  346. }
  347. if err := ctlV3Txn(cx, rqs); err != nil {
  348. cx.t.Fatal(err)
  349. }
  350. // a key of compare case isn't granted
  351. rqs = txnRequests{
  352. compare: []string{`version("c1") = "1"`},
  353. ifSucess: []string{"get s2"},
  354. ifFail: []string{"get f2"},
  355. results: []string{"Error: etcdserver: permission denied"},
  356. }
  357. if err := ctlV3Txn(cx, rqs); err != nil {
  358. cx.t.Fatal(err)
  359. }
  360. // a key of success case isn't granted
  361. rqs = txnRequests{
  362. compare: []string{`version("c2") = "1"`},
  363. ifSucess: []string{"get s1"},
  364. ifFail: []string{"get f2"},
  365. results: []string{"Error: etcdserver: permission denied"},
  366. }
  367. if err := ctlV3Txn(cx, rqs); err != nil {
  368. cx.t.Fatal(err)
  369. }
  370. // a key of failure case isn't granted
  371. rqs = txnRequests{
  372. compare: []string{`version("c2") = "1"`},
  373. ifSucess: []string{"get s2"},
  374. ifFail: []string{"get f1"},
  375. results: []string{"Error: etcdserver: permission denied"},
  376. }
  377. if err := ctlV3Txn(cx, rqs); err != nil {
  378. cx.t.Fatal(err)
  379. }
  380. }
  381. func authTestPrefixPerm(cx ctlCtx) {
  382. if err := authEnable(cx); err != nil {
  383. cx.t.Fatal(err)
  384. }
  385. cx.user, cx.pass = "root", "root"
  386. authSetupTestUser(cx)
  387. prefix := "/prefix/" // directory like prefix
  388. // grant keys to test-user
  389. cx.user, cx.pass = "root", "root"
  390. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, prefix, "", true}); err != nil {
  391. cx.t.Fatal(err)
  392. }
  393. // try a prefix granted permission
  394. cx.user, cx.pass = "test-user", "pass"
  395. for i := 0; i < 10; i++ {
  396. key := fmt.Sprintf("%s%d", prefix, i)
  397. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  398. cx.t.Fatal(err)
  399. }
  400. }
  401. if err := ctlV3PutFailPerm(cx, clientv3.GetPrefixRangeEnd(prefix), "baz"); err != nil {
  402. cx.t.Fatal(err)
  403. }
  404. // grant the entire keys to test-user
  405. cx.user, cx.pass = "root", "root"
  406. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "", "", true}); err != nil {
  407. cx.t.Fatal(err)
  408. }
  409. prefix2 := "/prefix2/"
  410. cx.user, cx.pass = "test-user", "pass"
  411. for i := 0; i < 10; i++ {
  412. key := fmt.Sprintf("%s%d", prefix2, i)
  413. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  414. cx.t.Fatal(err)
  415. }
  416. }
  417. }
  418. func authTestMemberAdd(cx ctlCtx) {
  419. if err := authEnable(cx); err != nil {
  420. cx.t.Fatal(err)
  421. }
  422. cx.user, cx.pass = "root", "root"
  423. authSetupTestUser(cx)
  424. peerURL := fmt.Sprintf("http://localhost:%d", etcdProcessBasePort+11)
  425. // ordinary user cannot add a new member
  426. cx.user, cx.pass = "test-user", "pass"
  427. if err := ctlV3MemberAdd(cx, peerURL); err == nil {
  428. cx.t.Fatalf("ordinary user must not be allowed to add a member")
  429. }
  430. // root can add a new member
  431. cx.user, cx.pass = "root", "root"
  432. if err := ctlV3MemberAdd(cx, peerURL); err != nil {
  433. cx.t.Fatal(err)
  434. }
  435. }
  436. func authTestMemberRemove(cx ctlCtx) {
  437. if err := authEnable(cx); err != nil {
  438. cx.t.Fatal(err)
  439. }
  440. cx.user, cx.pass = "root", "root"
  441. authSetupTestUser(cx)
  442. ep, memIDToRemove, clusterID := cx.memberToRemove()
  443. // ordinary user cannot remove a member
  444. cx.user, cx.pass = "test-user", "pass"
  445. if err := ctlV3MemberRemove(cx, ep, memIDToRemove, clusterID); err == nil {
  446. cx.t.Fatalf("ordinary user must not be allowed to remove a member")
  447. }
  448. // root can remove a member
  449. cx.user, cx.pass = "root", "root"
  450. if err := ctlV3MemberRemove(cx, ep, memIDToRemove, clusterID); err != nil {
  451. cx.t.Fatal(err)
  452. }
  453. }
  454. func authTestMemberUpdate(cx ctlCtx) {
  455. if err := authEnable(cx); err != nil {
  456. cx.t.Fatal(err)
  457. }
  458. cx.user, cx.pass = "root", "root"
  459. authSetupTestUser(cx)
  460. mr, err := getMemberList(cx)
  461. if err != nil {
  462. cx.t.Fatal(err)
  463. }
  464. // ordinary user cannot update a member
  465. cx.user, cx.pass = "test-user", "pass"
  466. peerURL := fmt.Sprintf("http://localhost:%d", etcdProcessBasePort+11)
  467. memberID := fmt.Sprintf("%x", mr.Members[0].ID)
  468. if err = ctlV3MemberUpdate(cx, memberID, peerURL); err == nil {
  469. cx.t.Fatalf("ordinary user must not be allowed to update a member")
  470. }
  471. // root can update a member
  472. cx.user, cx.pass = "root", "root"
  473. if err = ctlV3MemberUpdate(cx, memberID, peerURL); err != nil {
  474. cx.t.Fatal(err)
  475. }
  476. }
  477. func authTestCertCN(cx ctlCtx) {
  478. if err := ctlV3User(cx, []string{"add", "etcd", "--interactive=false"}, "User etcd created", []string{""}); err != nil {
  479. cx.t.Fatal(err)
  480. }
  481. if err := spawnWithExpect(append(cx.PrefixArgs(), "role", "add", "test-role"), "Role test-role created"); err != nil {
  482. cx.t.Fatal(err)
  483. }
  484. if err := ctlV3User(cx, []string{"grant-role", "etcd", "test-role"}, "Role test-role is granted to user etcd", nil); err != nil {
  485. cx.t.Fatal(err)
  486. }
  487. cmd := append(cx.PrefixArgs(), "role", "grant-permission", "test-role", "readwrite", "foo")
  488. if err := spawnWithExpect(cmd, "Role test-role updated"); err != nil {
  489. cx.t.Fatal(err)
  490. }
  491. // grant a new key
  492. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "hoo", "", false}); err != nil {
  493. cx.t.Fatal(err)
  494. }
  495. // try a granted key
  496. cx.user, cx.pass = "", ""
  497. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  498. cx.t.Fatal(err)
  499. }
  500. // try a non granted key
  501. cx.user, cx.pass = "", ""
  502. if err := ctlV3PutFailPerm(cx, "baz", "bar"); err == nil {
  503. cx.t.Fatal(err)
  504. }
  505. }
  506. func authTestRevokeWithDelete(cx ctlCtx) {
  507. if err := authEnable(cx); err != nil {
  508. cx.t.Fatal(err)
  509. }
  510. cx.user, cx.pass = "root", "root"
  511. authSetupTestUser(cx)
  512. // create a new role
  513. cx.user, cx.pass = "root", "root"
  514. if err := ctlV3Role(cx, []string{"add", "test-role2"}, "Role test-role2 created"); err != nil {
  515. cx.t.Fatal(err)
  516. }
  517. // grant the new role to the user
  518. if err := ctlV3User(cx, []string{"grant-role", "test-user", "test-role2"}, "Role test-role2 is granted to user test-user", nil); err != nil {
  519. cx.t.Fatal(err)
  520. }
  521. // check the result
  522. if err := ctlV3User(cx, []string{"get", "test-user"}, "Roles: test-role test-role2", nil); err != nil {
  523. cx.t.Fatal(err)
  524. }
  525. // delete the role, test-role2 must be revoked from test-user
  526. if err := ctlV3Role(cx, []string{"delete", "test-role2"}, "Role test-role2 deleted"); err != nil {
  527. cx.t.Fatal(err)
  528. }
  529. // check the result
  530. if err := ctlV3User(cx, []string{"get", "test-user"}, "Roles: test-role", nil); err != nil {
  531. cx.t.Fatal(err)
  532. }
  533. }
  534. func authTestInvalidMgmt(cx ctlCtx) {
  535. if err := authEnable(cx); err != nil {
  536. cx.t.Fatal(err)
  537. }
  538. if err := ctlV3Role(cx, []string{"delete", "root"}, "Error: etcdserver: invalid auth management"); err == nil {
  539. cx.t.Fatal("deleting the role root must not be allowed")
  540. }
  541. if err := ctlV3User(cx, []string{"revoke-role", "root", "root"}, "Error: etcdserver: invalid auth management", []string{}); err == nil {
  542. cx.t.Fatal("revoking the role root from the user root must not be allowed")
  543. }
  544. }
  545. func authTestFromKeyPerm(cx ctlCtx) {
  546. if err := authEnable(cx); err != nil {
  547. cx.t.Fatal(err)
  548. }
  549. cx.user, cx.pass = "root", "root"
  550. authSetupTestUser(cx)
  551. // grant keys after z to test-user
  552. cx.user, cx.pass = "root", "root"
  553. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "z", "\x00", false}); err != nil {
  554. cx.t.Fatal(err)
  555. }
  556. // try the granted open ended permission
  557. cx.user, cx.pass = "test-user", "pass"
  558. for i := 0; i < 10; i++ {
  559. key := fmt.Sprintf("z%d", i)
  560. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  561. cx.t.Fatal(err)
  562. }
  563. }
  564. largeKey := ""
  565. for i := 0; i < 10; i++ {
  566. largeKey += "\xff"
  567. if err := ctlV3Put(cx, largeKey, "val", ""); err != nil {
  568. cx.t.Fatal(err)
  569. }
  570. }
  571. // try a non granted key
  572. if err := ctlV3PutFailPerm(cx, "x", "baz"); err != nil {
  573. cx.t.Fatal(err)
  574. }
  575. // revoke the open ended permission
  576. cx.user, cx.pass = "root", "root"
  577. if err := ctlV3RoleRevokePermission(cx, "test-role", "z", "", true); err != nil {
  578. cx.t.Fatal(err)
  579. }
  580. // try the revoked open ended permission
  581. cx.user, cx.pass = "test-user", "pass"
  582. for i := 0; i < 10; i++ {
  583. key := fmt.Sprintf("z%d", i)
  584. if err := ctlV3PutFailPerm(cx, key, "val"); err != nil {
  585. cx.t.Fatal(err)
  586. }
  587. }
  588. // grant the entire keys
  589. cx.user, cx.pass = "root", "root"
  590. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "", "\x00", false}); err != nil {
  591. cx.t.Fatal(err)
  592. }
  593. // try keys, of course it must be allowed because test-role has a permission of the entire keys
  594. cx.user, cx.pass = "test-user", "pass"
  595. for i := 0; i < 10; i++ {
  596. key := fmt.Sprintf("z%d", i)
  597. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  598. cx.t.Fatal(err)
  599. }
  600. }
  601. // revoke the entire keys
  602. cx.user, cx.pass = "root", "root"
  603. if err := ctlV3RoleRevokePermission(cx, "test-role", "", "", true); err != nil {
  604. cx.t.Fatal(err)
  605. }
  606. // try the revoked entire key permission
  607. cx.user, cx.pass = "test-user", "pass"
  608. for i := 0; i < 10; i++ {
  609. key := fmt.Sprintf("z%d", i)
  610. if err := ctlV3PutFailPerm(cx, key, "val"); err != nil {
  611. cx.t.Fatal(err)
  612. }
  613. }
  614. }
  615. func authTestWatch(cx ctlCtx) {
  616. if err := authEnable(cx); err != nil {
  617. cx.t.Fatal(err)
  618. }
  619. cx.user, cx.pass = "root", "root"
  620. authSetupTestUser(cx)
  621. // grant a key range
  622. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "key", "key4", false}); err != nil {
  623. cx.t.Fatal(err)
  624. }
  625. tests := []struct {
  626. puts []kv
  627. args []string
  628. wkv []kv
  629. want bool
  630. }{
  631. { // watch 1 key, should be successful
  632. []kv{{"key", "value"}},
  633. []string{"key", "--rev", "1"},
  634. []kv{{"key", "value"}},
  635. true,
  636. },
  637. { // watch 3 keys by range, should be successful
  638. []kv{{"key1", "val1"}, {"key3", "val3"}, {"key2", "val2"}},
  639. []string{"key", "key3", "--rev", "1"},
  640. []kv{{"key1", "val1"}, {"key2", "val2"}},
  641. true,
  642. },
  643. { // watch 1 key, should not be successful
  644. []kv{},
  645. []string{"key5", "--rev", "1"},
  646. []kv{},
  647. false,
  648. },
  649. { // watch 3 keys by range, should not be successful
  650. []kv{},
  651. []string{"key", "key6", "--rev", "1"},
  652. []kv{},
  653. false,
  654. },
  655. }
  656. cx.user, cx.pass = "test-user", "pass"
  657. for i, tt := range tests {
  658. donec := make(chan struct{})
  659. go func(i int, puts []kv) {
  660. defer close(donec)
  661. for j := range puts {
  662. if err := ctlV3Put(cx, puts[j].key, puts[j].val, ""); err != nil {
  663. cx.t.Fatalf("watchTest #%d-%d: ctlV3Put error (%v)", i, j, err)
  664. }
  665. }
  666. }(i, tt.puts)
  667. var err error
  668. if tt.want {
  669. err = ctlV3Watch(cx, tt.args, tt.wkv...)
  670. } else {
  671. err = ctlV3WatchFailPerm(cx, tt.args)
  672. }
  673. if err != nil {
  674. if cx.dialTimeout > 0 && !isGRPCTimedout(err) {
  675. cx.t.Errorf("watchTest #%d: ctlV3Watch error (%v)", i, err)
  676. }
  677. }
  678. <-donec
  679. }
  680. }
  681. func authTestRoleGet(cx ctlCtx) {
  682. if err := authEnable(cx); err != nil {
  683. cx.t.Fatal(err)
  684. }
  685. cx.user, cx.pass = "root", "root"
  686. authSetupTestUser(cx)
  687. expected := []string{
  688. "Role test-role",
  689. "KV Read:", "foo",
  690. "KV Write:", "foo",
  691. }
  692. if err := spawnWithExpects(append(cx.PrefixArgs(), "role", "get", "test-role"), expected...); err != nil {
  693. cx.t.Fatal(err)
  694. }
  695. // test-user can get the information of test-role because it belongs to the role
  696. cx.user, cx.pass = "test-user", "pass"
  697. if err := spawnWithExpects(append(cx.PrefixArgs(), "role", "get", "test-role"), expected...); err != nil {
  698. cx.t.Fatal(err)
  699. }
  700. // test-user cannot get the information of root because it doesn't belong to the role
  701. expected = []string{
  702. "Error: etcdserver: permission denied",
  703. }
  704. if err := spawnWithExpects(append(cx.PrefixArgs(), "role", "get", "root"), expected...); err != nil {
  705. cx.t.Fatal(err)
  706. }
  707. }
  708. func authTestUserGet(cx ctlCtx) {
  709. if err := authEnable(cx); err != nil {
  710. cx.t.Fatal(err)
  711. }
  712. cx.user, cx.pass = "root", "root"
  713. authSetupTestUser(cx)
  714. expected := []string{
  715. "User: test-user",
  716. "Roles: test-role",
  717. }
  718. if err := spawnWithExpects(append(cx.PrefixArgs(), "user", "get", "test-user"), expected...); err != nil {
  719. cx.t.Fatal(err)
  720. }
  721. // test-user can get the information of test-user itself
  722. cx.user, cx.pass = "test-user", "pass"
  723. if err := spawnWithExpects(append(cx.PrefixArgs(), "user", "get", "test-user"), expected...); err != nil {
  724. cx.t.Fatal(err)
  725. }
  726. // test-user cannot get the information of root
  727. expected = []string{
  728. "Error: etcdserver: permission denied",
  729. }
  730. if err := spawnWithExpects(append(cx.PrefixArgs(), "user", "get", "root"), expected...); err != nil {
  731. cx.t.Fatal(err)
  732. }
  733. }
  734. func authTestRoleList(cx ctlCtx) {
  735. if err := authEnable(cx); err != nil {
  736. cx.t.Fatal(err)
  737. }
  738. cx.user, cx.pass = "root", "root"
  739. authSetupTestUser(cx)
  740. if err := spawnWithExpect(append(cx.PrefixArgs(), "role", "list"), "test-role"); err != nil {
  741. cx.t.Fatal(err)
  742. }
  743. }
  744. func authTestDefrag(cx ctlCtx) {
  745. maintenanceInitKeys(cx)
  746. if err := authEnable(cx); err != nil {
  747. cx.t.Fatal(err)
  748. }
  749. cx.user, cx.pass = "root", "root"
  750. authSetupTestUser(cx)
  751. // ordinary user cannot defrag
  752. cx.user, cx.pass = "test-user", "pass"
  753. if err := ctlV3Defrag(cx); err == nil {
  754. cx.t.Fatal("ordinary user should not be able to issue a defrag request")
  755. }
  756. // root can defrag
  757. cx.user, cx.pass = "root", "root"
  758. if err := ctlV3Defrag(cx); err != nil {
  759. cx.t.Fatal(err)
  760. }
  761. }
  762. func authTestSnapshot(cx ctlCtx) {
  763. maintenanceInitKeys(cx)
  764. if err := authEnable(cx); err != nil {
  765. cx.t.Fatal(err)
  766. }
  767. cx.user, cx.pass = "root", "root"
  768. authSetupTestUser(cx)
  769. fpath := "test.snapshot"
  770. defer os.RemoveAll(fpath)
  771. // ordinary user cannot save a snapshot
  772. cx.user, cx.pass = "test-user", "pass"
  773. if err := ctlV3SnapshotSave(cx, fpath); err == nil {
  774. cx.t.Fatal("ordinary user should not be able to save a snapshot")
  775. }
  776. // root can save a snapshot
  777. cx.user, cx.pass = "root", "root"
  778. if err := ctlV3SnapshotSave(cx, fpath); err != nil {
  779. cx.t.Fatalf("snapshotTest ctlV3SnapshotSave error (%v)", err)
  780. }
  781. st, err := getSnapshotStatus(cx, fpath)
  782. if err != nil {
  783. cx.t.Fatalf("snapshotTest getSnapshotStatus error (%v)", err)
  784. }
  785. if st.Revision != 4 {
  786. cx.t.Fatalf("expected 4, got %d", st.Revision)
  787. }
  788. if st.TotalKey < 3 {
  789. cx.t.Fatalf("expected at least 3, got %d", st.TotalKey)
  790. }
  791. }
  792. func authTestEndpointHealth(cx ctlCtx) {
  793. if err := authEnable(cx); err != nil {
  794. cx.t.Fatal(err)
  795. }
  796. cx.user, cx.pass = "root", "root"
  797. authSetupTestUser(cx)
  798. if err := ctlV3EndpointHealth(cx); err != nil {
  799. cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
  800. }
  801. // health checking with an ordinary user "succeeds" since permission denial goes through consensus
  802. cx.user, cx.pass = "test-user", "pass"
  803. if err := ctlV3EndpointHealth(cx); err != nil {
  804. cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
  805. }
  806. // succeed if permissions granted for ordinary user
  807. cx.user, cx.pass = "root", "root"
  808. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "health", "", false}); err != nil {
  809. cx.t.Fatal(err)
  810. }
  811. cx.user, cx.pass = "test-user", "pass"
  812. if err := ctlV3EndpointHealth(cx); err != nil {
  813. cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
  814. }
  815. }