security.go 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607
  1. // Copyright 2015 CoreOS, Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package security
  15. import (
  16. "encoding/json"
  17. "fmt"
  18. "log"
  19. "path"
  20. "reflect"
  21. "sort"
  22. "strings"
  23. "time"
  24. "github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/crypto/bcrypt"
  25. "github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/net/context"
  26. etcderr "github.com/coreos/etcd/error"
  27. "github.com/coreos/etcd/etcdserver"
  28. "github.com/coreos/etcd/etcdserver/etcdserverpb"
  29. "github.com/coreos/etcd/pkg/types"
  30. )
  31. const (
  32. // StorePermsPrefix is the internal prefix of the storage layer dedicated to storing user data.
  33. StorePermsPrefix = "/2"
  34. // RootRoleName is the name of the ROOT role, with privileges to manage the cluster.
  35. RootRoleName = "root"
  36. // GuestRoleName is the name of the role that defines the privileges of an unauthenticated user.
  37. GuestRoleName = "guest"
  38. )
  39. var rootRole = Role{
  40. Role: RootRoleName,
  41. Permissions: Permissions{
  42. KV: rwPermission{
  43. Read: []string{"*"},
  44. Write: []string{"*"},
  45. },
  46. },
  47. }
  48. var guestRole = Role{
  49. Role: GuestRoleName,
  50. Permissions: Permissions{
  51. KV: rwPermission{
  52. Read: []string{"*"},
  53. Write: []string{"*"},
  54. },
  55. },
  56. }
  57. type doer interface {
  58. Do(context.Context, etcdserverpb.Request) (etcdserver.Response, error)
  59. }
  60. type Store struct {
  61. server doer
  62. timeout time.Duration
  63. ensuredOnce bool
  64. }
  65. type User struct {
  66. User string `json:"user"`
  67. Password string `json:"password,omitempty"`
  68. Roles []string `json:"roles"`
  69. Grant []string `json:"grant,omitempty"`
  70. Revoke []string `json:"revoke,omitempty"`
  71. }
  72. type Role struct {
  73. Role string `json:"role"`
  74. Permissions Permissions `json:"permissions"`
  75. Grant *Permissions `json:"grant,omitempty"`
  76. Revoke *Permissions `json:"revoke,omitempty"`
  77. }
  78. type Permissions struct {
  79. KV rwPermission `json:"kv"`
  80. }
  81. type rwPermission struct {
  82. Read []string `json:"read"`
  83. Write []string `json:"write"`
  84. }
  85. type Error struct {
  86. errmsg string
  87. }
  88. func (se Error) Error() string { return se.errmsg }
  89. func mergeErr(s string, v ...interface{}) Error {
  90. return Error{fmt.Sprintf("security: "+s, v...)}
  91. }
  92. func securityErr(s string, v ...interface{}) Error {
  93. return Error{fmt.Sprintf("security: "+s, v...)}
  94. }
  95. func NewStore(server doer, timeout time.Duration) *Store {
  96. s := &Store{
  97. server: server,
  98. timeout: timeout,
  99. }
  100. return s
  101. }
  102. func (s *Store) AllUsers() ([]string, error) {
  103. resp, err := s.requestResource("/users/", false)
  104. if err != nil {
  105. if e, ok := err.(*etcderr.Error); ok {
  106. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  107. return []string{}, nil
  108. }
  109. }
  110. return nil, err
  111. }
  112. var nodes []string
  113. for _, n := range resp.Event.Node.Nodes {
  114. _, user := path.Split(n.Key)
  115. nodes = append(nodes, user)
  116. }
  117. sort.Strings(nodes)
  118. return nodes, nil
  119. }
  120. func (s *Store) GetUser(name string) (User, error) {
  121. resp, err := s.requestResource("/users/"+name, false)
  122. if err != nil {
  123. if e, ok := err.(*etcderr.Error); ok {
  124. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  125. return User{}, securityErr("User %s does not exist.", name)
  126. }
  127. }
  128. return User{}, err
  129. }
  130. var u User
  131. err = json.Unmarshal([]byte(*resp.Event.Node.Value), &u)
  132. if err != nil {
  133. return u, err
  134. }
  135. // Require that root always has a root role.
  136. if u.User == "root" {
  137. inRoles := false
  138. for _, r := range u.Roles {
  139. if r == RootRoleName {
  140. inRoles = true
  141. break
  142. }
  143. }
  144. if !inRoles {
  145. u.Roles = append(u.Roles, RootRoleName)
  146. }
  147. }
  148. return u, nil
  149. }
  150. func (s *Store) CreateOrUpdateUser(user User) (out User, created bool, err error) {
  151. _, err = s.GetUser(user.User)
  152. if err == nil {
  153. // Remove the update-user roles from updating downstream.
  154. // Roles are granted or revoked, not changed directly.
  155. user.Roles = nil
  156. out, err := s.UpdateUser(user)
  157. return out, false, err
  158. }
  159. u, err := s.CreateUser(user)
  160. return u, true, err
  161. }
  162. func (s *Store) CreateUser(user User) (User, error) {
  163. u, err := s.createUserInternal(user)
  164. if err == nil {
  165. log.Printf("security: created user %s", user.User)
  166. }
  167. return u, err
  168. }
  169. func (s *Store) createUserInternal(user User) (User, error) {
  170. if user.Password == "" {
  171. return user, securityErr("Cannot create user %s with an empty password", user.User)
  172. }
  173. hash, err := bcrypt.GenerateFromPassword([]byte(user.Password), bcrypt.DefaultCost)
  174. if err != nil {
  175. return user, err
  176. }
  177. user.Password = string(hash)
  178. _, err = s.createResource("/users/"+user.User, user)
  179. if err != nil {
  180. if e, ok := err.(*etcderr.Error); ok {
  181. if e.ErrorCode == etcderr.EcodeNodeExist {
  182. return user, securityErr("User %s already exists.", user.User)
  183. }
  184. }
  185. }
  186. return user, err
  187. }
  188. func (s *Store) DeleteUser(name string) error {
  189. if s.SecurityEnabled() && name == "root" {
  190. return securityErr("Cannot delete root user while security is enabled.")
  191. }
  192. _, err := s.deleteResource("/users/" + name)
  193. if err != nil {
  194. if e, ok := err.(*etcderr.Error); ok {
  195. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  196. return securityErr("User %s does not exist", name)
  197. }
  198. }
  199. return err
  200. }
  201. log.Printf("security: deleted user %s", name)
  202. return nil
  203. }
  204. func (s *Store) UpdateUser(user User) (User, error) {
  205. old, err := s.GetUser(user.User)
  206. if err != nil {
  207. if e, ok := err.(*etcderr.Error); ok {
  208. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  209. return user, securityErr("User %s doesn't exist.", user.User)
  210. }
  211. }
  212. return old, err
  213. }
  214. newUser, err := old.Merge(user)
  215. if err != nil {
  216. return old, err
  217. }
  218. if reflect.DeepEqual(old, newUser) {
  219. if user.Revoke != nil || user.Grant != nil {
  220. return old, securityErr("User not updated. Grant/Revoke lists didn't match any current roles.")
  221. }
  222. return old, securityErr("User not updated. Use Grant/Revoke/Password to update the user.")
  223. }
  224. _, err = s.updateResource("/users/"+user.User, newUser)
  225. if err == nil {
  226. log.Printf("security: updated user %s", user.User)
  227. }
  228. return newUser, err
  229. }
  230. func (s *Store) AllRoles() ([]string, error) {
  231. nodes := []string{RootRoleName}
  232. resp, err := s.requestResource("/roles/", false)
  233. if err != nil {
  234. if e, ok := err.(*etcderr.Error); ok {
  235. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  236. return nodes, nil
  237. }
  238. }
  239. return nil, err
  240. }
  241. for _, n := range resp.Event.Node.Nodes {
  242. _, role := path.Split(n.Key)
  243. nodes = append(nodes, role)
  244. }
  245. sort.Strings(nodes)
  246. return nodes, nil
  247. }
  248. func (s *Store) GetRole(name string) (Role, error) {
  249. if name == RootRoleName {
  250. return rootRole, nil
  251. }
  252. resp, err := s.requestResource("/roles/"+name, false)
  253. if err != nil {
  254. if e, ok := err.(*etcderr.Error); ok {
  255. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  256. return Role{}, securityErr("Role %s does not exist.", name)
  257. }
  258. }
  259. return Role{}, err
  260. }
  261. var r Role
  262. err = json.Unmarshal([]byte(*resp.Event.Node.Value), &r)
  263. if err != nil {
  264. return r, err
  265. }
  266. return r, nil
  267. }
  268. func (s *Store) CreateOrUpdateRole(r Role) (role Role, created bool, err error) {
  269. _, err = s.GetRole(r.Role)
  270. if err == nil {
  271. role, err = s.UpdateRole(r)
  272. created = false
  273. return
  274. }
  275. return r, true, s.CreateRole(r)
  276. }
  277. func (s *Store) CreateRole(role Role) error {
  278. if role.Role == RootRoleName {
  279. return securityErr("Cannot modify role %s: is root role.", role.Role)
  280. }
  281. _, err := s.createResource("/roles/"+role.Role, role)
  282. if err != nil {
  283. if e, ok := err.(*etcderr.Error); ok {
  284. if e.ErrorCode == etcderr.EcodeNodeExist {
  285. return securityErr("Role %s already exists.", role.Role)
  286. }
  287. }
  288. }
  289. if err == nil {
  290. log.Printf("security: created new role %s", role.Role)
  291. }
  292. return err
  293. }
  294. func (s *Store) DeleteRole(name string) error {
  295. if name == RootRoleName {
  296. return securityErr("Cannot modify role %s: is superuser role.", name)
  297. }
  298. _, err := s.deleteResource("/roles/" + name)
  299. if err != nil {
  300. if e, ok := err.(*etcderr.Error); ok {
  301. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  302. return securityErr("Role %s doesn't exist.", name)
  303. }
  304. }
  305. }
  306. if err == nil {
  307. log.Printf("security: deleted role %s", name)
  308. }
  309. return err
  310. }
  311. func (s *Store) UpdateRole(role Role) (Role, error) {
  312. old, err := s.GetRole(role.Role)
  313. if err != nil {
  314. if e, ok := err.(*etcderr.Error); ok {
  315. if e.ErrorCode == etcderr.EcodeKeyNotFound {
  316. return role, securityErr("Role %s doesn't exist.", role.Role)
  317. }
  318. }
  319. return old, err
  320. }
  321. newRole, err := old.Merge(role)
  322. if err != nil {
  323. return old, err
  324. }
  325. if reflect.DeepEqual(old, newRole) {
  326. if role.Revoke != nil || role.Grant != nil {
  327. return old, securityErr("Role not updated. Grant/Revoke lists didn't match any current permissions.")
  328. }
  329. return old, securityErr("Role not updated. Use Grant/Revoke to update the role.")
  330. }
  331. _, err = s.updateResource("/roles/"+role.Role, newRole)
  332. if err == nil {
  333. log.Printf("security: updated role %s", role.Role)
  334. }
  335. return newRole, err
  336. }
  337. func (s *Store) SecurityEnabled() bool {
  338. return s.detectSecurity()
  339. }
  340. func (s *Store) EnableSecurity() error {
  341. if s.SecurityEnabled() {
  342. return securityErr("already enabled")
  343. }
  344. _, err := s.GetUser("root")
  345. if err != nil {
  346. return securityErr("No root user available, please create one")
  347. }
  348. _, err = s.GetRole(GuestRoleName)
  349. if err != nil {
  350. log.Printf("security: no guest role access found, creating default")
  351. err := s.CreateRole(guestRole)
  352. if err != nil {
  353. log.Printf("security: error creating guest role. aborting security enable.")
  354. return err
  355. }
  356. }
  357. err = s.enableSecurity()
  358. if err == nil {
  359. log.Printf("security: enabled security")
  360. } else {
  361. log.Printf("error enabling security: %v", err)
  362. }
  363. return err
  364. }
  365. func (s *Store) DisableSecurity() error {
  366. if !s.SecurityEnabled() {
  367. return securityErr("already disabled")
  368. }
  369. err := s.disableSecurity()
  370. if err == nil {
  371. log.Printf("security: disabled security")
  372. } else {
  373. log.Printf("error disabling security: %v", err)
  374. }
  375. return err
  376. }
  377. // Merge applies the properties of the passed-in User to the User on which it
  378. // is called and returns a new User with these modifications applied. Think of
  379. // all Users as immutable sets of data. Merge allows you to perform the set
  380. // operations (desired grants and revokes) atomically
  381. func (u User) Merge(n User) (User, error) {
  382. var out User
  383. if u.User != n.User {
  384. return out, mergeErr("Merging user data with conflicting usernames: %s %s", u.User, n.User)
  385. }
  386. out.User = u.User
  387. if n.Password != "" {
  388. hash, err := bcrypt.GenerateFromPassword([]byte(n.Password), bcrypt.DefaultCost)
  389. if err != nil {
  390. return out, err
  391. }
  392. out.Password = string(hash)
  393. } else {
  394. out.Password = u.Password
  395. }
  396. currentRoles := types.NewUnsafeSet(u.Roles...)
  397. for _, g := range n.Grant {
  398. if currentRoles.Contains(g) {
  399. log.Printf("Granting duplicate role %s for user %s", g, n.User)
  400. continue
  401. }
  402. currentRoles.Add(g)
  403. }
  404. for _, r := range n.Revoke {
  405. if !currentRoles.Contains(r) {
  406. log.Printf("Revoking ungranted role %s for user %s", r, n.User)
  407. continue
  408. }
  409. currentRoles.Remove(r)
  410. }
  411. out.Roles = currentRoles.Values()
  412. return out, nil
  413. }
  414. func (u User) CheckPassword(password string) bool {
  415. err := bcrypt.CompareHashAndPassword([]byte(u.Password), []byte(password))
  416. return err == nil
  417. }
  418. // Merge for a role works the same as User above -- atomic Role application to
  419. // each of the substructures.
  420. func (r Role) Merge(n Role) (Role, error) {
  421. var out Role
  422. var err error
  423. if r.Role != n.Role {
  424. return out, mergeErr("Merging role with conflicting names: %s %s", r.Role, n.Role)
  425. }
  426. out.Role = r.Role
  427. out.Permissions, err = r.Permissions.Grant(n.Grant)
  428. if err != nil {
  429. return out, err
  430. }
  431. out.Permissions, err = out.Permissions.Revoke(n.Revoke)
  432. if err != nil {
  433. return out, err
  434. }
  435. return out, nil
  436. }
  437. func (r Role) HasKeyAccess(key string, write bool) bool {
  438. if r.Role == RootRoleName {
  439. return true
  440. }
  441. return r.Permissions.KV.HasAccess(key, write)
  442. }
  443. func (r Role) HasRecursiveAccess(key string, write bool) bool {
  444. if r.Role == RootRoleName {
  445. return true
  446. }
  447. return r.Permissions.KV.HasRecursiveAccess(key, write)
  448. }
  449. // Grant adds a set of permissions to the permission object on which it is called,
  450. // returning a new permission object.
  451. func (p Permissions) Grant(n *Permissions) (Permissions, error) {
  452. var out Permissions
  453. var err error
  454. if n == nil {
  455. return p, nil
  456. }
  457. out.KV, err = p.KV.Grant(n.KV)
  458. return out, err
  459. }
  460. // Revoke removes a set of permissions to the permission object on which it is called,
  461. // returning a new permission object.
  462. func (p Permissions) Revoke(n *Permissions) (Permissions, error) {
  463. var out Permissions
  464. var err error
  465. if n == nil {
  466. return p, nil
  467. }
  468. out.KV, err = p.KV.Revoke(n.KV)
  469. return out, err
  470. }
  471. // Grant adds a set of permissions to the permission object on which it is called,
  472. // returning a new permission object.
  473. func (rw rwPermission) Grant(n rwPermission) (rwPermission, error) {
  474. var out rwPermission
  475. currentRead := types.NewUnsafeSet(rw.Read...)
  476. for _, r := range n.Read {
  477. if currentRead.Contains(r) {
  478. return out, mergeErr("Granting duplicate read permission %s", r)
  479. }
  480. currentRead.Add(r)
  481. }
  482. currentWrite := types.NewUnsafeSet(rw.Write...)
  483. for _, w := range n.Write {
  484. if currentWrite.Contains(w) {
  485. return out, mergeErr("Granting duplicate write permission %s", w)
  486. }
  487. currentWrite.Add(w)
  488. }
  489. out.Read = currentRead.Values()
  490. out.Write = currentWrite.Values()
  491. return out, nil
  492. }
  493. // Revoke removes a set of permissions to the permission object on which it is called,
  494. // returning a new permission object.
  495. func (rw rwPermission) Revoke(n rwPermission) (rwPermission, error) {
  496. var out rwPermission
  497. currentRead := types.NewUnsafeSet(rw.Read...)
  498. for _, r := range n.Read {
  499. if !currentRead.Contains(r) {
  500. log.Printf("Revoking ungranted read permission %s", r)
  501. continue
  502. }
  503. currentRead.Remove(r)
  504. }
  505. currentWrite := types.NewUnsafeSet(rw.Write...)
  506. for _, w := range n.Write {
  507. if !currentWrite.Contains(w) {
  508. log.Printf("Revoking ungranted write permission %s", w)
  509. continue
  510. }
  511. currentWrite.Remove(w)
  512. }
  513. out.Read = currentRead.Values()
  514. out.Write = currentWrite.Values()
  515. return out, nil
  516. }
  517. func (rw rwPermission) HasAccess(key string, write bool) bool {
  518. var list []string
  519. if write {
  520. list = rw.Write
  521. } else {
  522. list = rw.Read
  523. }
  524. for _, pat := range list {
  525. match, err := simpleMatch(pat, key)
  526. if err == nil && match {
  527. return true
  528. }
  529. }
  530. return false
  531. }
  532. func (rw rwPermission) HasRecursiveAccess(key string, write bool) bool {
  533. list := rw.Read
  534. if write {
  535. list = rw.Write
  536. }
  537. for _, pat := range list {
  538. match, err := prefixMatch(pat, key)
  539. if err == nil && match {
  540. return true
  541. }
  542. }
  543. return false
  544. }
  545. func simpleMatch(pattern string, key string) (match bool, err error) {
  546. if pattern[len(pattern)-1] == '*' {
  547. return strings.HasPrefix(key, pattern[:len(pattern)-1]), nil
  548. }
  549. return key == pattern, nil
  550. }
  551. func prefixMatch(pattern string, key string) (match bool, err error) {
  552. if pattern[len(pattern)-1] != '*' {
  553. return false, nil
  554. }
  555. return strings.HasPrefix(key, pattern[:len(pattern)-1]), nil
  556. }