ctl_v3_auth_test.go 26 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959
  1. // Copyright 2016 The etcd Authors
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package e2e
  15. import (
  16. "fmt"
  17. "os"
  18. "testing"
  19. "github.com/coreos/etcd/clientv3"
  20. )
  21. func TestCtlV3AuthEnable(t *testing.T) { testCtl(t, authEnableTest) }
  22. func TestCtlV3AuthDisable(t *testing.T) { testCtl(t, authDisableTest) }
  23. func TestCtlV3AuthWriteKey(t *testing.T) { testCtl(t, authCredWriteKeyTest) }
  24. func TestCtlV3AuthRoleUpdate(t *testing.T) { testCtl(t, authRoleUpdateTest) }
  25. func TestCtlV3AuthUserDeleteDuringOps(t *testing.T) { testCtl(t, authUserDeleteDuringOpsTest) }
  26. func TestCtlV3AuthRoleRevokeDuringOps(t *testing.T) { testCtl(t, authRoleRevokeDuringOpsTest) }
  27. func TestCtlV3AuthTxn(t *testing.T) { testCtl(t, authTestTxn) }
  28. func TestCtlV3AuthPrefixPerm(t *testing.T) { testCtl(t, authTestPrefixPerm) }
  29. func TestCtlV3AuthMemberAdd(t *testing.T) { testCtl(t, authTestMemberAdd) }
  30. func TestCtlV3AuthMemberRemove(t *testing.T) {
  31. testCtl(t, authTestMemberRemove, withQuorum(), withNoStrictReconfig())
  32. }
  33. func TestCtlV3AuthMemberUpdate(t *testing.T) { testCtl(t, authTestMemberUpdate) }
  34. func TestCtlV3AuthCertCN(t *testing.T) { testCtl(t, authTestCertCN, withCfg(configClientTLSCertAuth)) }
  35. func TestCtlV3AuthRevokeWithDelete(t *testing.T) { testCtl(t, authTestRevokeWithDelete) }
  36. func TestCtlV3AuthInvalidMgmt(t *testing.T) { testCtl(t, authTestInvalidMgmt) }
  37. func TestCtlV3AuthFromKeyPerm(t *testing.T) { testCtl(t, authTestFromKeyPerm) }
  38. func TestCtlV3AuthAndWatch(t *testing.T) { testCtl(t, authTestWatch) }
  39. func TestCtlV3AuthRoleGet(t *testing.T) { testCtl(t, authTestRoleGet) }
  40. func TestCtlV3AuthUserGet(t *testing.T) { testCtl(t, authTestUserGet) }
  41. func TestCtlV3AuthRoleList(t *testing.T) { testCtl(t, authTestRoleList) }
  42. func TestCtlV3AuthDefrag(t *testing.T) { testCtl(t, authTestDefrag) }
  43. func TestCtlV3AuthEndpointHealth(t *testing.T) {
  44. testCtl(t, authTestEndpointHealth, withQuorum())
  45. }
  46. func TestCtlV3AuthSnapshot(t *testing.T) { testCtl(t, authTestSnapshot) }
  47. func authEnableTest(cx ctlCtx) {
  48. if err := authEnable(cx); err != nil {
  49. cx.t.Fatal(err)
  50. }
  51. }
  52. func authEnable(cx ctlCtx) error {
  53. // create root user with root role
  54. if err := ctlV3User(cx, []string{"add", "root", "--interactive=false"}, "User root created", []string{"root"}); err != nil {
  55. return fmt.Errorf("failed to create root user %v", err)
  56. }
  57. if err := ctlV3User(cx, []string{"grant-role", "root", "root"}, "Role root is granted to user root", nil); err != nil {
  58. return fmt.Errorf("failed to grant root user root role %v", err)
  59. }
  60. if err := ctlV3AuthEnable(cx); err != nil {
  61. return fmt.Errorf("authEnableTest ctlV3AuthEnable error (%v)", err)
  62. }
  63. return nil
  64. }
  65. func ctlV3AuthEnable(cx ctlCtx) error {
  66. cmdArgs := append(cx.PrefixArgs(), "auth", "enable")
  67. return spawnWithExpect(cmdArgs, "Authentication Enabled")
  68. }
  69. func authDisableTest(cx ctlCtx) {
  70. // a key that isn't granted to test-user
  71. if err := ctlV3Put(cx, "hoo", "a", ""); err != nil {
  72. cx.t.Fatal(err)
  73. }
  74. if err := authEnable(cx); err != nil {
  75. cx.t.Fatal(err)
  76. }
  77. cx.user, cx.pass = "root", "root"
  78. authSetupTestUser(cx)
  79. // test-user doesn't have the permission, it must fail
  80. cx.user, cx.pass = "test-user", "pass"
  81. if err := ctlV3PutFailPerm(cx, "hoo", "bar"); err != nil {
  82. cx.t.Fatal(err)
  83. }
  84. cx.user, cx.pass = "root", "root"
  85. if err := ctlV3AuthDisable(cx); err != nil {
  86. cx.t.Fatalf("authDisableTest ctlV3AuthDisable error (%v)", err)
  87. }
  88. // now ErrAuthNotEnabled of Authenticate() is simply ignored
  89. cx.user, cx.pass = "test-user", "pass"
  90. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  91. cx.t.Fatal(err)
  92. }
  93. // now the key can be accessed
  94. cx.user, cx.pass = "", ""
  95. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  96. cx.t.Fatal(err)
  97. }
  98. // confirm put succeeded
  99. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar"}}...); err != nil {
  100. cx.t.Fatal(err)
  101. }
  102. }
  103. func ctlV3AuthDisable(cx ctlCtx) error {
  104. cmdArgs := append(cx.PrefixArgs(), "auth", "disable")
  105. return spawnWithExpect(cmdArgs, "Authentication Disabled")
  106. }
  107. func authCredWriteKeyTest(cx ctlCtx) {
  108. // baseline key to check for failed puts
  109. if err := ctlV3Put(cx, "foo", "a", ""); err != nil {
  110. cx.t.Fatal(err)
  111. }
  112. if err := authEnable(cx); err != nil {
  113. cx.t.Fatal(err)
  114. }
  115. cx.user, cx.pass = "root", "root"
  116. authSetupTestUser(cx)
  117. // confirm root role can access to all keys
  118. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  119. cx.t.Fatal(err)
  120. }
  121. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  122. cx.t.Fatal(err)
  123. }
  124. // try invalid user
  125. cx.user, cx.pass = "a", "b"
  126. if err := ctlV3PutFailAuth(cx, "foo", "bar"); err != nil {
  127. cx.t.Fatal(err)
  128. }
  129. // confirm put failed
  130. cx.user, cx.pass = "test-user", "pass"
  131. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  132. cx.t.Fatal(err)
  133. }
  134. // try good user
  135. cx.user, cx.pass = "test-user", "pass"
  136. if err := ctlV3Put(cx, "foo", "bar2", ""); err != nil {
  137. cx.t.Fatal(err)
  138. }
  139. // confirm put succeeded
  140. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar2"}}...); err != nil {
  141. cx.t.Fatal(err)
  142. }
  143. // try bad password
  144. cx.user, cx.pass = "test-user", "badpass"
  145. if err := ctlV3PutFailAuth(cx, "foo", "baz"); err != nil {
  146. cx.t.Fatal(err)
  147. }
  148. // confirm put failed
  149. cx.user, cx.pass = "test-user", "pass"
  150. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar2"}}...); err != nil {
  151. cx.t.Fatal(err)
  152. }
  153. }
  154. func authRoleUpdateTest(cx ctlCtx) {
  155. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  156. cx.t.Fatal(err)
  157. }
  158. if err := authEnable(cx); err != nil {
  159. cx.t.Fatal(err)
  160. }
  161. cx.user, cx.pass = "root", "root"
  162. authSetupTestUser(cx)
  163. // try put to not granted key
  164. cx.user, cx.pass = "test-user", "pass"
  165. if err := ctlV3PutFailPerm(cx, "hoo", "bar"); err != nil {
  166. cx.t.Fatal(err)
  167. }
  168. // grant a new key
  169. cx.user, cx.pass = "root", "root"
  170. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "hoo", "", false}); err != nil {
  171. cx.t.Fatal(err)
  172. }
  173. // try a newly granted key
  174. cx.user, cx.pass = "test-user", "pass"
  175. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  176. cx.t.Fatal(err)
  177. }
  178. // confirm put succeeded
  179. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar"}}...); err != nil {
  180. cx.t.Fatal(err)
  181. }
  182. // revoke the newly granted key
  183. cx.user, cx.pass = "root", "root"
  184. if err := ctlV3RoleRevokePermission(cx, "test-role", "hoo", "", false); err != nil {
  185. cx.t.Fatal(err)
  186. }
  187. // try put to the revoked key
  188. cx.user, cx.pass = "test-user", "pass"
  189. if err := ctlV3PutFailPerm(cx, "hoo", "bar"); err != nil {
  190. cx.t.Fatal(err)
  191. }
  192. // confirm a key still granted can be accessed
  193. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  194. cx.t.Fatal(err)
  195. }
  196. }
  197. func authUserDeleteDuringOpsTest(cx ctlCtx) {
  198. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  199. cx.t.Fatal(err)
  200. }
  201. if err := authEnable(cx); err != nil {
  202. cx.t.Fatal(err)
  203. }
  204. cx.user, cx.pass = "root", "root"
  205. authSetupTestUser(cx)
  206. // create a key
  207. cx.user, cx.pass = "test-user", "pass"
  208. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  209. cx.t.Fatal(err)
  210. }
  211. // confirm put succeeded
  212. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  213. cx.t.Fatal(err)
  214. }
  215. // delete the user
  216. cx.user, cx.pass = "root", "root"
  217. err := ctlV3User(cx, []string{"delete", "test-user"}, "User test-user deleted", []string{})
  218. if err != nil {
  219. cx.t.Fatal(err)
  220. }
  221. // check the user is deleted
  222. cx.user, cx.pass = "test-user", "pass"
  223. if err := ctlV3PutFailAuth(cx, "foo", "baz"); err != nil {
  224. cx.t.Fatal(err)
  225. }
  226. }
  227. func authRoleRevokeDuringOpsTest(cx ctlCtx) {
  228. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  229. cx.t.Fatal(err)
  230. }
  231. if err := authEnable(cx); err != nil {
  232. cx.t.Fatal(err)
  233. }
  234. cx.user, cx.pass = "root", "root"
  235. authSetupTestUser(cx)
  236. // create a key
  237. cx.user, cx.pass = "test-user", "pass"
  238. if err := ctlV3Put(cx, "foo", "bar", ""); err != nil {
  239. cx.t.Fatal(err)
  240. }
  241. // confirm put succeeded
  242. if err := ctlV3Get(cx, []string{"foo"}, []kv{{"foo", "bar"}}...); err != nil {
  243. cx.t.Fatal(err)
  244. }
  245. // create a new role
  246. cx.user, cx.pass = "root", "root"
  247. if err := ctlV3Role(cx, []string{"add", "test-role2"}, "Role test-role2 created"); err != nil {
  248. cx.t.Fatal(err)
  249. }
  250. // grant a new key to the new role
  251. if err := ctlV3RoleGrantPermission(cx, "test-role2", grantingPerm{true, true, "hoo", "", false}); err != nil {
  252. cx.t.Fatal(err)
  253. }
  254. // grant the new role to the user
  255. if err := ctlV3User(cx, []string{"grant-role", "test-user", "test-role2"}, "Role test-role2 is granted to user test-user", nil); err != nil {
  256. cx.t.Fatal(err)
  257. }
  258. // try a newly granted key
  259. cx.user, cx.pass = "test-user", "pass"
  260. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  261. cx.t.Fatal(err)
  262. }
  263. // confirm put succeeded
  264. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar"}}...); err != nil {
  265. cx.t.Fatal(err)
  266. }
  267. // revoke a role from the user
  268. cx.user, cx.pass = "root", "root"
  269. err := ctlV3User(cx, []string{"revoke-role", "test-user", "test-role"}, "Role test-role is revoked from user test-user", []string{})
  270. if err != nil {
  271. cx.t.Fatal(err)
  272. }
  273. // check the role is revoked and permission is lost from the user
  274. cx.user, cx.pass = "test-user", "pass"
  275. if err := ctlV3PutFailPerm(cx, "foo", "baz"); err != nil {
  276. cx.t.Fatal(err)
  277. }
  278. // try a key that can be accessed from the remaining role
  279. cx.user, cx.pass = "test-user", "pass"
  280. if err := ctlV3Put(cx, "hoo", "bar2", ""); err != nil {
  281. cx.t.Fatal(err)
  282. }
  283. // confirm put succeeded
  284. if err := ctlV3Get(cx, []string{"hoo"}, []kv{{"hoo", "bar2"}}...); err != nil {
  285. cx.t.Fatal(err)
  286. }
  287. }
  288. func ctlV3PutFailAuth(cx ctlCtx, key, val string) error {
  289. return spawnWithExpect(append(cx.PrefixArgs(), "put", key, val), "authentication failed")
  290. }
  291. func ctlV3PutFailPerm(cx ctlCtx, key, val string) error {
  292. return spawnWithExpect(append(cx.PrefixArgs(), "put", key, val), "permission denied")
  293. }
  294. func authSetupTestUser(cx ctlCtx) {
  295. if err := ctlV3User(cx, []string{"add", "test-user", "--interactive=false"}, "User test-user created", []string{"pass"}); err != nil {
  296. cx.t.Fatal(err)
  297. }
  298. if err := spawnWithExpect(append(cx.PrefixArgs(), "role", "add", "test-role"), "Role test-role created"); err != nil {
  299. cx.t.Fatal(err)
  300. }
  301. if err := ctlV3User(cx, []string{"grant-role", "test-user", "test-role"}, "Role test-role is granted to user test-user", nil); err != nil {
  302. cx.t.Fatal(err)
  303. }
  304. cmd := append(cx.PrefixArgs(), "role", "grant-permission", "test-role", "readwrite", "foo")
  305. if err := spawnWithExpect(cmd, "Role test-role updated"); err != nil {
  306. cx.t.Fatal(err)
  307. }
  308. }
  309. func authTestTxn(cx ctlCtx) {
  310. // keys with 1 suffix aren't granted to test-user
  311. // keys with 2 suffix are granted to test-user
  312. keys := []string{"c1", "s1", "f1"}
  313. grantedKeys := []string{"c2", "s2", "f2"}
  314. for _, key := range keys {
  315. if err := ctlV3Put(cx, key, "v", ""); err != nil {
  316. cx.t.Fatal(err)
  317. }
  318. }
  319. for _, key := range grantedKeys {
  320. if err := ctlV3Put(cx, key, "v", ""); err != nil {
  321. cx.t.Fatal(err)
  322. }
  323. }
  324. if err := authEnable(cx); err != nil {
  325. cx.t.Fatal(err)
  326. }
  327. cx.user, cx.pass = "root", "root"
  328. authSetupTestUser(cx)
  329. // grant keys to test-user
  330. cx.user, cx.pass = "root", "root"
  331. for _, key := range grantedKeys {
  332. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, key, "", false}); err != nil {
  333. cx.t.Fatal(err)
  334. }
  335. }
  336. // now test txn
  337. cx.interactive = true
  338. cx.user, cx.pass = "test-user", "pass"
  339. rqs := txnRequests{
  340. compare: []string{`version("c2") = "1"`},
  341. ifSucess: []string{"get s2"},
  342. ifFail: []string{"get f2"},
  343. results: []string{"SUCCESS", "s2", "v"},
  344. }
  345. if err := ctlV3Txn(cx, rqs); err != nil {
  346. cx.t.Fatal(err)
  347. }
  348. // a key of compare case isn't granted
  349. rqs = txnRequests{
  350. compare: []string{`version("c1") = "1"`},
  351. ifSucess: []string{"get s2"},
  352. ifFail: []string{"get f2"},
  353. results: []string{"Error: etcdserver: permission denied"},
  354. }
  355. if err := ctlV3Txn(cx, rqs); err != nil {
  356. cx.t.Fatal(err)
  357. }
  358. // a key of success case isn't granted
  359. rqs = txnRequests{
  360. compare: []string{`version("c2") = "1"`},
  361. ifSucess: []string{"get s1"},
  362. ifFail: []string{"get f2"},
  363. results: []string{"Error: etcdserver: permission denied"},
  364. }
  365. if err := ctlV3Txn(cx, rqs); err != nil {
  366. cx.t.Fatal(err)
  367. }
  368. // a key of failure case isn't granted
  369. rqs = txnRequests{
  370. compare: []string{`version("c2") = "1"`},
  371. ifSucess: []string{"get s2"},
  372. ifFail: []string{"get f1"},
  373. results: []string{"Error: etcdserver: permission denied"},
  374. }
  375. if err := ctlV3Txn(cx, rqs); err != nil {
  376. cx.t.Fatal(err)
  377. }
  378. }
  379. func authTestPrefixPerm(cx ctlCtx) {
  380. if err := authEnable(cx); err != nil {
  381. cx.t.Fatal(err)
  382. }
  383. cx.user, cx.pass = "root", "root"
  384. authSetupTestUser(cx)
  385. prefix := "/prefix/" // directory like prefix
  386. // grant keys to test-user
  387. cx.user, cx.pass = "root", "root"
  388. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, prefix, "", true}); err != nil {
  389. cx.t.Fatal(err)
  390. }
  391. // try a prefix granted permission
  392. cx.user, cx.pass = "test-user", "pass"
  393. for i := 0; i < 10; i++ {
  394. key := fmt.Sprintf("%s%d", prefix, i)
  395. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  396. cx.t.Fatal(err)
  397. }
  398. }
  399. if err := ctlV3PutFailPerm(cx, clientv3.GetPrefixRangeEnd(prefix), "baz"); err != nil {
  400. cx.t.Fatal(err)
  401. }
  402. // grant the entire keys to test-user
  403. cx.user, cx.pass = "root", "root"
  404. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "", "", true}); err != nil {
  405. cx.t.Fatal(err)
  406. }
  407. prefix2 := "/prefix2/"
  408. cx.user, cx.pass = "test-user", "pass"
  409. for i := 0; i < 10; i++ {
  410. key := fmt.Sprintf("%s%d", prefix2, i)
  411. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  412. cx.t.Fatal(err)
  413. }
  414. }
  415. }
  416. func authTestMemberAdd(cx ctlCtx) {
  417. if err := authEnable(cx); err != nil {
  418. cx.t.Fatal(err)
  419. }
  420. cx.user, cx.pass = "root", "root"
  421. authSetupTestUser(cx)
  422. peerURL := fmt.Sprintf("http://localhost:%d", etcdProcessBasePort+11)
  423. // ordinary user cannot add a new member
  424. cx.user, cx.pass = "test-user", "pass"
  425. if err := ctlV3MemberAdd(cx, peerURL); err == nil {
  426. cx.t.Fatalf("ordinary user must not be allowed to add a member")
  427. }
  428. // root can add a new member
  429. cx.user, cx.pass = "root", "root"
  430. if err := ctlV3MemberAdd(cx, peerURL); err != nil {
  431. cx.t.Fatal(err)
  432. }
  433. }
  434. func authTestMemberRemove(cx ctlCtx) {
  435. if err := authEnable(cx); err != nil {
  436. cx.t.Fatal(err)
  437. }
  438. cx.user, cx.pass = "root", "root"
  439. authSetupTestUser(cx)
  440. ep, memIDToRemove, clusterID := cx.memberToRemove()
  441. // ordinary user cannot remove a member
  442. cx.user, cx.pass = "test-user", "pass"
  443. if err := ctlV3MemberRemove(cx, ep, memIDToRemove, clusterID); err == nil {
  444. cx.t.Fatalf("ordinary user must not be allowed to remove a member")
  445. }
  446. // root can remove a member
  447. cx.user, cx.pass = "root", "root"
  448. if err := ctlV3MemberRemove(cx, ep, memIDToRemove, clusterID); err != nil {
  449. cx.t.Fatal(err)
  450. }
  451. }
  452. func authTestMemberUpdate(cx ctlCtx) {
  453. if err := authEnable(cx); err != nil {
  454. cx.t.Fatal(err)
  455. }
  456. cx.user, cx.pass = "root", "root"
  457. authSetupTestUser(cx)
  458. mr, err := getMemberList(cx)
  459. if err != nil {
  460. cx.t.Fatal(err)
  461. }
  462. // ordinary user cannot update a member
  463. cx.user, cx.pass = "test-user", "pass"
  464. peerURL := fmt.Sprintf("http://localhost:%d", etcdProcessBasePort+11)
  465. memberID := fmt.Sprintf("%x", mr.Members[0].ID)
  466. if err = ctlV3MemberUpdate(cx, memberID, peerURL); err == nil {
  467. cx.t.Fatalf("ordinary user must not be allowed to update a member")
  468. }
  469. // root can update a member
  470. cx.user, cx.pass = "root", "root"
  471. if err = ctlV3MemberUpdate(cx, memberID, peerURL); err != nil {
  472. cx.t.Fatal(err)
  473. }
  474. }
  475. func authTestCertCN(cx ctlCtx) {
  476. if err := ctlV3User(cx, []string{"add", "etcd", "--interactive=false"}, "User etcd created", []string{""}); err != nil {
  477. cx.t.Fatal(err)
  478. }
  479. if err := spawnWithExpect(append(cx.PrefixArgs(), "role", "add", "test-role"), "Role test-role created"); err != nil {
  480. cx.t.Fatal(err)
  481. }
  482. if err := ctlV3User(cx, []string{"grant-role", "etcd", "test-role"}, "Role test-role is granted to user etcd", nil); err != nil {
  483. cx.t.Fatal(err)
  484. }
  485. cmd := append(cx.PrefixArgs(), "role", "grant-permission", "test-role", "readwrite", "foo")
  486. if err := spawnWithExpect(cmd, "Role test-role updated"); err != nil {
  487. cx.t.Fatal(err)
  488. }
  489. // grant a new key
  490. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "hoo", "", false}); err != nil {
  491. cx.t.Fatal(err)
  492. }
  493. // try a granted key
  494. cx.user, cx.pass = "", ""
  495. if err := ctlV3Put(cx, "hoo", "bar", ""); err != nil {
  496. cx.t.Fatal(err)
  497. }
  498. // try a non granted key
  499. cx.user, cx.pass = "", ""
  500. if err := ctlV3PutFailPerm(cx, "baz", "bar"); err == nil {
  501. cx.t.Fatal(err)
  502. }
  503. }
  504. func authTestRevokeWithDelete(cx ctlCtx) {
  505. if err := authEnable(cx); err != nil {
  506. cx.t.Fatal(err)
  507. }
  508. cx.user, cx.pass = "root", "root"
  509. authSetupTestUser(cx)
  510. // create a new role
  511. cx.user, cx.pass = "root", "root"
  512. if err := ctlV3Role(cx, []string{"add", "test-role2"}, "Role test-role2 created"); err != nil {
  513. cx.t.Fatal(err)
  514. }
  515. // grant the new role to the user
  516. if err := ctlV3User(cx, []string{"grant-role", "test-user", "test-role2"}, "Role test-role2 is granted to user test-user", nil); err != nil {
  517. cx.t.Fatal(err)
  518. }
  519. // check the result
  520. if err := ctlV3User(cx, []string{"get", "test-user"}, "Roles: test-role test-role2", nil); err != nil {
  521. cx.t.Fatal(err)
  522. }
  523. // delete the role, test-role2 must be revoked from test-user
  524. if err := ctlV3Role(cx, []string{"delete", "test-role2"}, "Role test-role2 deleted"); err != nil {
  525. cx.t.Fatal(err)
  526. }
  527. // check the result
  528. if err := ctlV3User(cx, []string{"get", "test-user"}, "Roles: test-role", nil); err != nil {
  529. cx.t.Fatal(err)
  530. }
  531. }
  532. func authTestInvalidMgmt(cx ctlCtx) {
  533. if err := authEnable(cx); err != nil {
  534. cx.t.Fatal(err)
  535. }
  536. if err := ctlV3Role(cx, []string{"delete", "root"}, "Error: etcdserver: invalid auth management"); err == nil {
  537. cx.t.Fatal("deleting the role root must not be allowed")
  538. }
  539. if err := ctlV3User(cx, []string{"revoke-role", "root", "root"}, "Error: etcdserver: invalid auth management", []string{}); err == nil {
  540. cx.t.Fatal("revoking the role root from the user root must not be allowed")
  541. }
  542. }
  543. func authTestFromKeyPerm(cx ctlCtx) {
  544. if err := authEnable(cx); err != nil {
  545. cx.t.Fatal(err)
  546. }
  547. cx.user, cx.pass = "root", "root"
  548. authSetupTestUser(cx)
  549. // grant keys after z to test-user
  550. cx.user, cx.pass = "root", "root"
  551. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "z", "\x00", false}); err != nil {
  552. cx.t.Fatal(err)
  553. }
  554. // try the granted open ended permission
  555. cx.user, cx.pass = "test-user", "pass"
  556. for i := 0; i < 10; i++ {
  557. key := fmt.Sprintf("z%d", i)
  558. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  559. cx.t.Fatal(err)
  560. }
  561. }
  562. largeKey := ""
  563. for i := 0; i < 10; i++ {
  564. largeKey += "\xff"
  565. if err := ctlV3Put(cx, largeKey, "val", ""); err != nil {
  566. cx.t.Fatal(err)
  567. }
  568. }
  569. // try a non granted key
  570. if err := ctlV3PutFailPerm(cx, "x", "baz"); err != nil {
  571. cx.t.Fatal(err)
  572. }
  573. // revoke the open ended permission
  574. cx.user, cx.pass = "root", "root"
  575. if err := ctlV3RoleRevokePermission(cx, "test-role", "z", "", true); err != nil {
  576. cx.t.Fatal(err)
  577. }
  578. // try the revoked open ended permission
  579. cx.user, cx.pass = "test-user", "pass"
  580. for i := 0; i < 10; i++ {
  581. key := fmt.Sprintf("z%d", i)
  582. if err := ctlV3PutFailPerm(cx, key, "val"); err != nil {
  583. cx.t.Fatal(err)
  584. }
  585. }
  586. // grant the entire keys
  587. cx.user, cx.pass = "root", "root"
  588. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "", "\x00", false}); err != nil {
  589. cx.t.Fatal(err)
  590. }
  591. // try keys, of course it must be allowed because test-role has a permission of the entire keys
  592. cx.user, cx.pass = "test-user", "pass"
  593. for i := 0; i < 10; i++ {
  594. key := fmt.Sprintf("z%d", i)
  595. if err := ctlV3Put(cx, key, "val", ""); err != nil {
  596. cx.t.Fatal(err)
  597. }
  598. }
  599. // revoke the entire keys
  600. cx.user, cx.pass = "root", "root"
  601. if err := ctlV3RoleRevokePermission(cx, "test-role", "", "", true); err != nil {
  602. cx.t.Fatal(err)
  603. }
  604. // try the revoked entire key permission
  605. cx.user, cx.pass = "test-user", "pass"
  606. for i := 0; i < 10; i++ {
  607. key := fmt.Sprintf("z%d", i)
  608. if err := ctlV3PutFailPerm(cx, key, "val"); err != nil {
  609. cx.t.Fatal(err)
  610. }
  611. }
  612. }
  613. func authTestWatch(cx ctlCtx) {
  614. if err := authEnable(cx); err != nil {
  615. cx.t.Fatal(err)
  616. }
  617. cx.user, cx.pass = "root", "root"
  618. authSetupTestUser(cx)
  619. // grant a key range
  620. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "key", "key4", false}); err != nil {
  621. cx.t.Fatal(err)
  622. }
  623. tests := []struct {
  624. puts []kv
  625. args []string
  626. wkv []kv
  627. want bool
  628. }{
  629. { // watch 1 key, should be successful
  630. []kv{{"key", "value"}},
  631. []string{"key", "--rev", "1"},
  632. []kv{{"key", "value"}},
  633. true,
  634. },
  635. { // watch 3 keys by range, should be successful
  636. []kv{{"key1", "val1"}, {"key3", "val3"}, {"key2", "val2"}},
  637. []string{"key", "key3", "--rev", "1"},
  638. []kv{{"key1", "val1"}, {"key2", "val2"}},
  639. true,
  640. },
  641. { // watch 1 key, should not be successful
  642. []kv{},
  643. []string{"key5", "--rev", "1"},
  644. []kv{},
  645. false,
  646. },
  647. { // watch 3 keys by range, should not be successful
  648. []kv{},
  649. []string{"key", "key6", "--rev", "1"},
  650. []kv{},
  651. false,
  652. },
  653. }
  654. cx.user, cx.pass = "test-user", "pass"
  655. for i, tt := range tests {
  656. donec := make(chan struct{})
  657. go func(i int, puts []kv) {
  658. defer close(donec)
  659. for j := range puts {
  660. if err := ctlV3Put(cx, puts[j].key, puts[j].val, ""); err != nil {
  661. cx.t.Fatalf("watchTest #%d-%d: ctlV3Put error (%v)", i, j, err)
  662. }
  663. }
  664. }(i, tt.puts)
  665. var err error
  666. if tt.want {
  667. err = ctlV3Watch(cx, tt.args, tt.wkv...)
  668. } else {
  669. err = ctlV3WatchFailPerm(cx, tt.args)
  670. }
  671. if err != nil {
  672. if cx.dialTimeout > 0 && !isGRPCTimedout(err) {
  673. cx.t.Errorf("watchTest #%d: ctlV3Watch error (%v)", i, err)
  674. }
  675. }
  676. <-donec
  677. }
  678. }
  679. func authTestRoleGet(cx ctlCtx) {
  680. if err := authEnable(cx); err != nil {
  681. cx.t.Fatal(err)
  682. }
  683. cx.user, cx.pass = "root", "root"
  684. authSetupTestUser(cx)
  685. expected := []string{
  686. "Role test-role",
  687. "KV Read:", "foo",
  688. "KV Write:", "foo",
  689. }
  690. if err := spawnWithExpects(append(cx.PrefixArgs(), "role", "get", "test-role"), expected...); err != nil {
  691. cx.t.Fatal(err)
  692. }
  693. // test-user can get the information of test-role because it belongs to the role
  694. cx.user, cx.pass = "test-user", "pass"
  695. if err := spawnWithExpects(append(cx.PrefixArgs(), "role", "get", "test-role"), expected...); err != nil {
  696. cx.t.Fatal(err)
  697. }
  698. // test-user cannot get the information of root because it doesn't belong to the role
  699. expected = []string{
  700. "Error: etcdserver: permission denied",
  701. }
  702. if err := spawnWithExpects(append(cx.PrefixArgs(), "role", "get", "root"), expected...); err != nil {
  703. cx.t.Fatal(err)
  704. }
  705. }
  706. func authTestUserGet(cx ctlCtx) {
  707. if err := authEnable(cx); err != nil {
  708. cx.t.Fatal(err)
  709. }
  710. cx.user, cx.pass = "root", "root"
  711. authSetupTestUser(cx)
  712. expected := []string{
  713. "User: test-user",
  714. "Roles: test-role",
  715. }
  716. if err := spawnWithExpects(append(cx.PrefixArgs(), "user", "get", "test-user"), expected...); err != nil {
  717. cx.t.Fatal(err)
  718. }
  719. // test-user can get the information of test-user itself
  720. cx.user, cx.pass = "test-user", "pass"
  721. if err := spawnWithExpects(append(cx.PrefixArgs(), "user", "get", "test-user"), expected...); err != nil {
  722. cx.t.Fatal(err)
  723. }
  724. // test-user cannot get the information of root
  725. expected = []string{
  726. "Error: etcdserver: permission denied",
  727. }
  728. if err := spawnWithExpects(append(cx.PrefixArgs(), "user", "get", "root"), expected...); err != nil {
  729. cx.t.Fatal(err)
  730. }
  731. }
  732. func authTestRoleList(cx ctlCtx) {
  733. if err := authEnable(cx); err != nil {
  734. cx.t.Fatal(err)
  735. }
  736. cx.user, cx.pass = "root", "root"
  737. authSetupTestUser(cx)
  738. if err := spawnWithExpect(append(cx.PrefixArgs(), "role", "list"), "test-role"); err != nil {
  739. cx.t.Fatal(err)
  740. }
  741. }
  742. func authTestDefrag(cx ctlCtx) {
  743. maintenanceInitKeys(cx)
  744. if err := authEnable(cx); err != nil {
  745. cx.t.Fatal(err)
  746. }
  747. cx.user, cx.pass = "root", "root"
  748. authSetupTestUser(cx)
  749. // ordinary user cannot defrag
  750. cx.user, cx.pass = "test-user", "pass"
  751. if err := ctlV3Defrag(cx); err == nil {
  752. cx.t.Fatal("ordinary user should not be able to issue a defrag request")
  753. }
  754. // root can defrag
  755. cx.user, cx.pass = "root", "root"
  756. if err := ctlV3Defrag(cx); err != nil {
  757. cx.t.Fatal(err)
  758. }
  759. }
  760. func authTestSnapshot(cx ctlCtx) {
  761. maintenanceInitKeys(cx)
  762. if err := authEnable(cx); err != nil {
  763. cx.t.Fatal(err)
  764. }
  765. cx.user, cx.pass = "root", "root"
  766. authSetupTestUser(cx)
  767. fpath := "test.snapshot"
  768. defer os.RemoveAll(fpath)
  769. // ordinary user cannot save a snapshot
  770. cx.user, cx.pass = "test-user", "pass"
  771. if err := ctlV3SnapshotSave(cx, fpath); err == nil {
  772. cx.t.Fatal("ordinary user should not be able to save a snapshot")
  773. }
  774. // root can save a snapshot
  775. cx.user, cx.pass = "root", "root"
  776. if err := ctlV3SnapshotSave(cx, fpath); err != nil {
  777. cx.t.Fatalf("snapshotTest ctlV3SnapshotSave error (%v)", err)
  778. }
  779. st, err := getSnapshotStatus(cx, fpath)
  780. if err != nil {
  781. cx.t.Fatalf("snapshotTest getSnapshotStatus error (%v)", err)
  782. }
  783. if st.Revision != 4 {
  784. cx.t.Fatalf("expected 4, got %d", st.Revision)
  785. }
  786. if st.TotalKey < 3 {
  787. cx.t.Fatalf("expected at least 3, got %d", st.TotalKey)
  788. }
  789. }
  790. func authTestEndpointHealth(cx ctlCtx) {
  791. if err := authEnable(cx); err != nil {
  792. cx.t.Fatal(err)
  793. }
  794. cx.user, cx.pass = "root", "root"
  795. authSetupTestUser(cx)
  796. if err := ctlV3EndpointHealth(cx); err != nil {
  797. cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
  798. }
  799. // health checking with an ordinary user "succeeds" since permission denial goes through consensus
  800. cx.user, cx.pass = "test-user", "pass"
  801. if err := ctlV3EndpointHealth(cx); err != nil {
  802. cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
  803. }
  804. // succeed if permissions granted for ordinary user
  805. cx.user, cx.pass = "root", "root"
  806. if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "health", "", false}); err != nil {
  807. cx.t.Fatal(err)
  808. }
  809. cx.user, cx.pass = "test-user", "pass"
  810. if err := ctlV3EndpointHealth(cx); err != nil {
  811. cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
  812. }
  813. }