kvstore.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710
  1. // Copyright 2015 The etcd Authors
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package mvcc
  15. import (
  16. "encoding/binary"
  17. "errors"
  18. "math"
  19. "math/rand"
  20. "sync"
  21. "time"
  22. "github.com/coreos/etcd/lease"
  23. "github.com/coreos/etcd/mvcc/backend"
  24. "github.com/coreos/etcd/mvcc/mvccpb"
  25. "github.com/coreos/etcd/pkg/schedule"
  26. "github.com/coreos/pkg/capnslog"
  27. "golang.org/x/net/context"
  28. )
  29. var (
  30. keyBucketName = []byte("key")
  31. metaBucketName = []byte("meta")
  32. // markedRevBytesLen is the byte length of marked revision.
  33. // The first `revBytesLen` bytes represents a normal revision. The last
  34. // one byte is the mark.
  35. markedRevBytesLen = revBytesLen + 1
  36. markBytePosition = markedRevBytesLen - 1
  37. markTombstone byte = 't'
  38. consistentIndexKeyName = []byte("consistent_index")
  39. scheduledCompactKeyName = []byte("scheduledCompactRev")
  40. finishedCompactKeyName = []byte("finishedCompactRev")
  41. ErrTxnIDMismatch = errors.New("mvcc: txn id mismatch")
  42. ErrCompacted = errors.New("mvcc: required revision has been compacted")
  43. ErrFutureRev = errors.New("mvcc: required revision is a future revision")
  44. ErrCanceled = errors.New("mvcc: watcher is canceled")
  45. plog = capnslog.NewPackageLogger("github.com/coreos/etcd", "mvcc")
  46. )
  47. // ConsistentIndexGetter is an interface that wraps the Get method.
  48. // Consistent index is the offset of an entry in a consistent replicated log.
  49. type ConsistentIndexGetter interface {
  50. // ConsistentIndex returns the consistent index of current executing entry.
  51. ConsistentIndex() uint64
  52. }
  53. type store struct {
  54. mu sync.Mutex // guards the following
  55. ig ConsistentIndexGetter
  56. b backend.Backend
  57. kvindex index
  58. le lease.Lessor
  59. currentRev revision
  60. // the main revision of the last compaction
  61. compactMainRev int64
  62. tx backend.BatchTx
  63. txnID int64 // tracks the current txnID to verify txn operations
  64. txnModify bool
  65. // bytesBuf8 is a byte slice of length 8
  66. // to avoid a repetitive allocation in saveIndex.
  67. bytesBuf8 []byte
  68. changes []mvccpb.KeyValue
  69. fifoSched schedule.Scheduler
  70. stopc chan struct{}
  71. }
  72. // NewStore returns a new store. It is useful to create a store inside
  73. // mvcc pkg. It should only be used for testing externally.
  74. func NewStore(b backend.Backend, le lease.Lessor, ig ConsistentIndexGetter) *store {
  75. s := &store{
  76. b: b,
  77. ig: ig,
  78. kvindex: newTreeIndex(),
  79. le: le,
  80. currentRev: revision{main: 1},
  81. compactMainRev: -1,
  82. bytesBuf8: make([]byte, 8),
  83. fifoSched: schedule.NewFIFOScheduler(),
  84. stopc: make(chan struct{}),
  85. }
  86. if s.le != nil {
  87. s.le.SetRangeDeleter(s)
  88. }
  89. tx := s.b.BatchTx()
  90. tx.Lock()
  91. tx.UnsafeCreateBucket(keyBucketName)
  92. tx.UnsafeCreateBucket(metaBucketName)
  93. tx.Unlock()
  94. s.b.ForceCommit()
  95. if err := s.restore(); err != nil {
  96. // TODO: return the error instead of panic here?
  97. panic("failed to recover store from backend")
  98. }
  99. return s
  100. }
  101. func (s *store) Rev() int64 {
  102. s.mu.Lock()
  103. defer s.mu.Unlock()
  104. return s.currentRev.main
  105. }
  106. func (s *store) FirstRev() int64 {
  107. s.mu.Lock()
  108. defer s.mu.Unlock()
  109. return s.compactMainRev
  110. }
  111. func (s *store) Put(key, value []byte, lease lease.LeaseID) int64 {
  112. id := s.TxnBegin()
  113. s.put(key, value, lease)
  114. s.txnEnd(id)
  115. putCounter.Inc()
  116. return int64(s.currentRev.main)
  117. }
  118. func (s *store) Range(key, end []byte, ro RangeOptions) (r *RangeResult, err error) {
  119. id := s.TxnBegin()
  120. kvs, count, rev, err := s.rangeKeys(key, end, ro.Limit, ro.Rev, ro.Count)
  121. s.txnEnd(id)
  122. rangeCounter.Inc()
  123. r = &RangeResult{
  124. KVs: kvs,
  125. Count: count,
  126. Rev: rev,
  127. }
  128. return r, err
  129. }
  130. func (s *store) DeleteRange(key, end []byte) (n, rev int64) {
  131. id := s.TxnBegin()
  132. n = s.deleteRange(key, end)
  133. s.txnEnd(id)
  134. deleteCounter.Inc()
  135. return n, int64(s.currentRev.main)
  136. }
  137. func (s *store) TxnBegin() int64 {
  138. s.mu.Lock()
  139. s.currentRev.sub = 0
  140. s.tx = s.b.BatchTx()
  141. s.tx.Lock()
  142. s.txnID = rand.Int63()
  143. return s.txnID
  144. }
  145. func (s *store) TxnEnd(txnID int64) error {
  146. err := s.txnEnd(txnID)
  147. if err != nil {
  148. return err
  149. }
  150. txnCounter.Inc()
  151. return nil
  152. }
  153. // txnEnd is used for unlocking an internal txn. It does
  154. // not increase the txnCounter.
  155. func (s *store) txnEnd(txnID int64) error {
  156. if txnID != s.txnID {
  157. return ErrTxnIDMismatch
  158. }
  159. // only update index if the txn modifies the mvcc state.
  160. // read only txn might execute with one write txn concurrently,
  161. // it should not write its index to mvcc.
  162. if s.txnModify {
  163. s.saveIndex()
  164. }
  165. s.txnModify = false
  166. s.tx.Unlock()
  167. if s.currentRev.sub != 0 {
  168. s.currentRev.main += 1
  169. }
  170. s.currentRev.sub = 0
  171. dbTotalSize.Set(float64(s.b.Size()))
  172. s.mu.Unlock()
  173. return nil
  174. }
  175. func (s *store) TxnRange(txnID int64, key, end []byte, ro RangeOptions) (r *RangeResult, err error) {
  176. if txnID != s.txnID {
  177. return nil, ErrTxnIDMismatch
  178. }
  179. kvs, count, rev, err := s.rangeKeys(key, end, ro.Limit, ro.Rev, ro.Count)
  180. r = &RangeResult{
  181. KVs: kvs,
  182. Count: count,
  183. Rev: rev,
  184. }
  185. return r, err
  186. }
  187. func (s *store) TxnPut(txnID int64, key, value []byte, lease lease.LeaseID) (rev int64, err error) {
  188. if txnID != s.txnID {
  189. return 0, ErrTxnIDMismatch
  190. }
  191. s.put(key, value, lease)
  192. return int64(s.currentRev.main + 1), nil
  193. }
  194. func (s *store) TxnDeleteRange(txnID int64, key, end []byte) (n, rev int64, err error) {
  195. if txnID != s.txnID {
  196. return 0, 0, ErrTxnIDMismatch
  197. }
  198. n = s.deleteRange(key, end)
  199. if n != 0 || s.currentRev.sub != 0 {
  200. rev = int64(s.currentRev.main + 1)
  201. } else {
  202. rev = int64(s.currentRev.main)
  203. }
  204. return n, rev, nil
  205. }
  206. func (s *store) compactBarrier(ctx context.Context, ch chan struct{}) {
  207. if ctx == nil || ctx.Err() != nil {
  208. s.mu.Lock()
  209. select {
  210. case <-s.stopc:
  211. default:
  212. f := func(ctx context.Context) { s.compactBarrier(ctx, ch) }
  213. s.fifoSched.Schedule(f)
  214. }
  215. s.mu.Unlock()
  216. return
  217. }
  218. close(ch)
  219. }
  220. func (s *store) Compact(rev int64) (<-chan struct{}, error) {
  221. s.mu.Lock()
  222. defer s.mu.Unlock()
  223. if rev <= s.compactMainRev {
  224. ch := make(chan struct{})
  225. f := func(ctx context.Context) { s.compactBarrier(ctx, ch) }
  226. s.fifoSched.Schedule(f)
  227. return ch, ErrCompacted
  228. }
  229. if rev > s.currentRev.main {
  230. return nil, ErrFutureRev
  231. }
  232. start := time.Now()
  233. s.compactMainRev = rev
  234. rbytes := newRevBytes()
  235. revToBytes(revision{main: rev}, rbytes)
  236. tx := s.b.BatchTx()
  237. tx.Lock()
  238. tx.UnsafePut(metaBucketName, scheduledCompactKeyName, rbytes)
  239. tx.Unlock()
  240. // ensure that desired compaction is persisted
  241. s.b.ForceCommit()
  242. keep := s.kvindex.Compact(rev)
  243. ch := make(chan struct{})
  244. var j = func(ctx context.Context) {
  245. if ctx.Err() != nil {
  246. s.compactBarrier(ctx, ch)
  247. return
  248. }
  249. if !s.scheduleCompaction(rev, keep) {
  250. s.compactBarrier(nil, ch)
  251. return
  252. }
  253. close(ch)
  254. }
  255. s.fifoSched.Schedule(j)
  256. indexCompactionPauseDurations.Observe(float64(time.Since(start) / time.Millisecond))
  257. return ch, nil
  258. }
  259. // DefaultIgnores is a map of keys to ignore in hash checking.
  260. var DefaultIgnores map[backend.IgnoreKey]struct{}
  261. func init() {
  262. DefaultIgnores = map[backend.IgnoreKey]struct{}{
  263. // consistent index might be changed due to v2 internal sync, which
  264. // is not controllable by the user.
  265. {Bucket: string(metaBucketName), Key: string(consistentIndexKeyName)}: {},
  266. }
  267. }
  268. func (s *store) Hash() (uint32, int64, error) {
  269. s.mu.Lock()
  270. defer s.mu.Unlock()
  271. s.b.ForceCommit()
  272. h, err := s.b.Hash(DefaultIgnores)
  273. rev := s.currentRev.main
  274. return h, rev, err
  275. }
  276. func (s *store) Commit() {
  277. s.mu.Lock()
  278. defer s.mu.Unlock()
  279. s.tx = s.b.BatchTx()
  280. s.tx.Lock()
  281. s.saveIndex()
  282. s.tx.Unlock()
  283. s.b.ForceCommit()
  284. }
  285. func (s *store) Restore(b backend.Backend) error {
  286. s.mu.Lock()
  287. defer s.mu.Unlock()
  288. close(s.stopc)
  289. s.fifoSched.Stop()
  290. s.b = b
  291. s.kvindex = newTreeIndex()
  292. s.currentRev = revision{main: 1}
  293. s.compactMainRev = -1
  294. s.tx = b.BatchTx()
  295. s.txnID = -1
  296. s.fifoSched = schedule.NewFIFOScheduler()
  297. s.stopc = make(chan struct{})
  298. return s.restore()
  299. }
  300. func (s *store) restore() error {
  301. min, max := newRevBytes(), newRevBytes()
  302. revToBytes(revision{main: 1}, min)
  303. revToBytes(revision{main: math.MaxInt64, sub: math.MaxInt64}, max)
  304. keyToLease := make(map[string]lease.LeaseID)
  305. // use an unordered map to hold the temp index data to speed up
  306. // the initial key index recovery.
  307. // we will convert this unordered map into the tree index later.
  308. unordered := make(map[string]*keyIndex, 100000)
  309. // restore index
  310. tx := s.b.BatchTx()
  311. tx.Lock()
  312. _, finishedCompactBytes := tx.UnsafeRange(metaBucketName, finishedCompactKeyName, nil, 0)
  313. if len(finishedCompactBytes) != 0 {
  314. s.compactMainRev = bytesToRev(finishedCompactBytes[0]).main
  315. plog.Printf("restore compact to %d", s.compactMainRev)
  316. }
  317. // TODO: limit N to reduce max memory usage
  318. keys, vals := tx.UnsafeRange(keyBucketName, min, max, 0)
  319. for i, key := range keys {
  320. var kv mvccpb.KeyValue
  321. if err := kv.Unmarshal(vals[i]); err != nil {
  322. plog.Fatalf("cannot unmarshal event: %v", err)
  323. }
  324. rev := bytesToRev(key[:revBytesLen])
  325. // restore index
  326. switch {
  327. case isTombstone(key):
  328. if ki, ok := unordered[string(kv.Key)]; ok {
  329. ki.tombstone(rev.main, rev.sub)
  330. }
  331. delete(keyToLease, string(kv.Key))
  332. default:
  333. ki, ok := unordered[string(kv.Key)]
  334. if ok {
  335. ki.put(rev.main, rev.sub)
  336. } else {
  337. ki = &keyIndex{key: kv.Key}
  338. ki.restore(revision{kv.CreateRevision, 0}, rev, kv.Version)
  339. unordered[string(kv.Key)] = ki
  340. }
  341. if lid := lease.LeaseID(kv.Lease); lid != lease.NoLease {
  342. keyToLease[string(kv.Key)] = lid
  343. } else {
  344. delete(keyToLease, string(kv.Key))
  345. }
  346. }
  347. // update revision
  348. s.currentRev = rev
  349. }
  350. // restore the tree index from the unordered index.
  351. for _, v := range unordered {
  352. s.kvindex.Insert(v)
  353. }
  354. // keys in the range [compacted revision -N, compaction] might all be deleted due to compaction.
  355. // the correct revision should be set to compaction revision in the case, not the largest revision
  356. // we have seen.
  357. if s.currentRev.main < s.compactMainRev {
  358. s.currentRev.main = s.compactMainRev
  359. }
  360. for key, lid := range keyToLease {
  361. if s.le == nil {
  362. panic("no lessor to attach lease")
  363. }
  364. err := s.le.Attach(lid, []lease.LeaseItem{{Key: key}})
  365. if err != nil {
  366. plog.Errorf("unexpected Attach error: %v", err)
  367. }
  368. }
  369. _, scheduledCompactBytes := tx.UnsafeRange(metaBucketName, scheduledCompactKeyName, nil, 0)
  370. scheduledCompact := int64(0)
  371. if len(scheduledCompactBytes) != 0 {
  372. scheduledCompact = bytesToRev(scheduledCompactBytes[0]).main
  373. if scheduledCompact <= s.compactMainRev {
  374. scheduledCompact = 0
  375. }
  376. }
  377. tx.Unlock()
  378. if scheduledCompact != 0 {
  379. s.Compact(scheduledCompact)
  380. plog.Printf("resume scheduled compaction at %d", scheduledCompact)
  381. }
  382. return nil
  383. }
  384. func (s *store) Close() error {
  385. close(s.stopc)
  386. s.fifoSched.Stop()
  387. return nil
  388. }
  389. func (a *store) Equal(b *store) bool {
  390. if a.currentRev != b.currentRev {
  391. return false
  392. }
  393. if a.compactMainRev != b.compactMainRev {
  394. return false
  395. }
  396. return a.kvindex.Equal(b.kvindex)
  397. }
  398. // range is a keyword in Go, add Keys suffix.
  399. func (s *store) rangeKeys(key, end []byte, limit, rangeRev int64, countOnly bool) (kvs []mvccpb.KeyValue, count int, curRev int64, err error) {
  400. curRev = int64(s.currentRev.main)
  401. if s.currentRev.sub > 0 {
  402. curRev += 1
  403. }
  404. if rangeRev > curRev {
  405. return nil, -1, s.currentRev.main, ErrFutureRev
  406. }
  407. var rev int64
  408. if rangeRev <= 0 {
  409. rev = curRev
  410. } else {
  411. rev = rangeRev
  412. }
  413. if rev < s.compactMainRev {
  414. return nil, -1, 0, ErrCompacted
  415. }
  416. _, revpairs := s.kvindex.Range(key, end, int64(rev))
  417. if len(revpairs) == 0 {
  418. return nil, 0, curRev, nil
  419. }
  420. if countOnly {
  421. return nil, len(revpairs), curRev, nil
  422. }
  423. for _, revpair := range revpairs {
  424. start, end := revBytesRange(revpair)
  425. _, vs := s.tx.UnsafeRange(keyBucketName, start, end, 0)
  426. if len(vs) != 1 {
  427. plog.Fatalf("range cannot find rev (%d,%d)", revpair.main, revpair.sub)
  428. }
  429. var kv mvccpb.KeyValue
  430. if err := kv.Unmarshal(vs[0]); err != nil {
  431. plog.Fatalf("cannot unmarshal event: %v", err)
  432. }
  433. kvs = append(kvs, kv)
  434. if limit > 0 && len(kvs) >= int(limit) {
  435. break
  436. }
  437. }
  438. return kvs, len(revpairs), curRev, nil
  439. }
  440. func (s *store) put(key, value []byte, leaseID lease.LeaseID) {
  441. s.txnModify = true
  442. rev := s.currentRev.main + 1
  443. c := rev
  444. oldLease := lease.NoLease
  445. // if the key exists before, use its previous created and
  446. // get its previous leaseID
  447. _, created, ver, err := s.kvindex.Get(key, rev)
  448. if err == nil {
  449. c = created.main
  450. oldLease = s.le.GetLease(lease.LeaseItem{Key: string(key)})
  451. }
  452. ibytes := newRevBytes()
  453. revToBytes(revision{main: rev, sub: s.currentRev.sub}, ibytes)
  454. ver = ver + 1
  455. kv := mvccpb.KeyValue{
  456. Key: key,
  457. Value: value,
  458. CreateRevision: c,
  459. ModRevision: rev,
  460. Version: ver,
  461. Lease: int64(leaseID),
  462. }
  463. d, err := kv.Marshal()
  464. if err != nil {
  465. plog.Fatalf("cannot marshal event: %v", err)
  466. }
  467. s.tx.UnsafeSeqPut(keyBucketName, ibytes, d)
  468. s.kvindex.Put(key, revision{main: rev, sub: s.currentRev.sub})
  469. s.changes = append(s.changes, kv)
  470. s.currentRev.sub += 1
  471. if oldLease != lease.NoLease {
  472. if s.le == nil {
  473. panic("no lessor to detach lease")
  474. }
  475. err = s.le.Detach(oldLease, []lease.LeaseItem{{Key: string(key)}})
  476. if err != nil {
  477. plog.Errorf("unexpected error from lease detach: %v", err)
  478. }
  479. }
  480. if leaseID != lease.NoLease {
  481. if s.le == nil {
  482. panic("no lessor to attach lease")
  483. }
  484. err = s.le.Attach(leaseID, []lease.LeaseItem{{Key: string(key)}})
  485. if err != nil {
  486. panic("unexpected error from lease Attach")
  487. }
  488. }
  489. }
  490. func (s *store) deleteRange(key, end []byte) int64 {
  491. s.txnModify = true
  492. rrev := s.currentRev.main
  493. if s.currentRev.sub > 0 {
  494. rrev += 1
  495. }
  496. keys, revs := s.kvindex.Range(key, end, rrev)
  497. if len(keys) == 0 {
  498. return 0
  499. }
  500. for i, key := range keys {
  501. s.delete(key, revs[i])
  502. }
  503. return int64(len(keys))
  504. }
  505. func (s *store) delete(key []byte, rev revision) {
  506. mainrev := s.currentRev.main + 1
  507. ibytes := newRevBytes()
  508. revToBytes(revision{main: mainrev, sub: s.currentRev.sub}, ibytes)
  509. ibytes = appendMarkTombstone(ibytes)
  510. kv := mvccpb.KeyValue{
  511. Key: key,
  512. }
  513. d, err := kv.Marshal()
  514. if err != nil {
  515. plog.Fatalf("cannot marshal event: %v", err)
  516. }
  517. s.tx.UnsafeSeqPut(keyBucketName, ibytes, d)
  518. err = s.kvindex.Tombstone(key, revision{main: mainrev, sub: s.currentRev.sub})
  519. if err != nil {
  520. plog.Fatalf("cannot tombstone an existing key (%s): %v", string(key), err)
  521. }
  522. s.changes = append(s.changes, kv)
  523. s.currentRev.sub += 1
  524. item := lease.LeaseItem{Key: string(key)}
  525. leaseID := s.le.GetLease(item)
  526. if leaseID != lease.NoLease {
  527. err = s.le.Detach(leaseID, []lease.LeaseItem{item})
  528. if err != nil {
  529. plog.Errorf("cannot detach %v", err)
  530. }
  531. }
  532. }
  533. func (s *store) getChanges() []mvccpb.KeyValue {
  534. changes := s.changes
  535. s.changes = make([]mvccpb.KeyValue, 0, 4)
  536. return changes
  537. }
  538. func (s *store) saveIndex() {
  539. if s.ig == nil {
  540. return
  541. }
  542. tx := s.tx
  543. bs := s.bytesBuf8
  544. binary.BigEndian.PutUint64(bs, s.ig.ConsistentIndex())
  545. // put the index into the underlying backend
  546. // tx has been locked in TxnBegin, so there is no need to lock it again
  547. tx.UnsafePut(metaBucketName, consistentIndexKeyName, bs)
  548. }
  549. func (s *store) ConsistentIndex() uint64 {
  550. // TODO: cache index in a uint64 field?
  551. tx := s.b.BatchTx()
  552. tx.Lock()
  553. defer tx.Unlock()
  554. _, vs := tx.UnsafeRange(metaBucketName, consistentIndexKeyName, nil, 0)
  555. if len(vs) == 0 {
  556. return 0
  557. }
  558. return binary.BigEndian.Uint64(vs[0])
  559. }
  560. // appendMarkTombstone appends tombstone mark to normal revision bytes.
  561. func appendMarkTombstone(b []byte) []byte {
  562. if len(b) != revBytesLen {
  563. plog.Panicf("cannot append mark to non normal revision bytes")
  564. }
  565. return append(b, markTombstone)
  566. }
  567. // isTombstone checks whether the revision bytes is a tombstone.
  568. func isTombstone(b []byte) bool {
  569. return len(b) == markedRevBytesLen && b[markBytePosition] == markTombstone
  570. }
  571. // revBytesRange returns the range of revision bytes at
  572. // the given revision.
  573. func revBytesRange(rev revision) (start, end []byte) {
  574. start = newRevBytes()
  575. revToBytes(rev, start)
  576. end = newRevBytes()
  577. endRev := revision{main: rev.main, sub: rev.sub + 1}
  578. revToBytes(endRev, end)
  579. return start, end
  580. }