key.go 6.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281
  1. // Copyright 2015 CoreOS, Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. // Package v3rpc implements etcd v3 RPC system based on gRPC.
  15. package v3rpc
  16. import (
  17. "sort"
  18. "github.com/coreos/etcd/etcdserver"
  19. "github.com/coreos/etcd/etcdserver/api/v3rpc/rpctypes"
  20. pb "github.com/coreos/etcd/etcdserver/etcdserverpb"
  21. "github.com/coreos/etcd/lease"
  22. "github.com/coreos/etcd/storage"
  23. "github.com/coreos/pkg/capnslog"
  24. "golang.org/x/net/context"
  25. "google.golang.org/grpc"
  26. "google.golang.org/grpc/codes"
  27. )
  28. var (
  29. plog = capnslog.NewPackageLogger("github.com/coreos/etcd/etcdserver/api", "v3rpc")
  30. // Max operations per txn list. For example, Txn.Success can have at most 128 operations,
  31. // and Txn.Failure can have at most 128 operations.
  32. MaxOpsPerTxn = 128
  33. )
  34. type kvServer struct {
  35. hdr header
  36. kv etcdserver.RaftKV
  37. }
  38. func NewKVServer(s *etcdserver.EtcdServer) pb.KVServer {
  39. return &kvServer{hdr: newHeader(s), kv: s}
  40. }
  41. func (s *kvServer) Range(ctx context.Context, r *pb.RangeRequest) (*pb.RangeResponse, error) {
  42. if err := checkRangeRequest(r); err != nil {
  43. return nil, err
  44. }
  45. resp, err := s.kv.Range(ctx, r)
  46. if err != nil {
  47. return nil, togRPCError(err)
  48. }
  49. if resp.Header == nil {
  50. plog.Panic("unexpected nil resp.Header")
  51. }
  52. s.hdr.fill(resp.Header)
  53. return resp, err
  54. }
  55. func (s *kvServer) Put(ctx context.Context, r *pb.PutRequest) (*pb.PutResponse, error) {
  56. if err := checkPutRequest(r); err != nil {
  57. return nil, err
  58. }
  59. resp, err := s.kv.Put(ctx, r)
  60. if err != nil {
  61. return nil, togRPCError(err)
  62. }
  63. if resp.Header == nil {
  64. plog.Panic("unexpected nil resp.Header")
  65. }
  66. s.hdr.fill(resp.Header)
  67. return resp, err
  68. }
  69. func (s *kvServer) DeleteRange(ctx context.Context, r *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error) {
  70. if err := checkDeleteRequest(r); err != nil {
  71. return nil, err
  72. }
  73. resp, err := s.kv.DeleteRange(ctx, r)
  74. if err != nil {
  75. return nil, togRPCError(err)
  76. }
  77. if resp.Header == nil {
  78. plog.Panic("unexpected nil resp.Header")
  79. }
  80. s.hdr.fill(resp.Header)
  81. return resp, err
  82. }
  83. func (s *kvServer) Txn(ctx context.Context, r *pb.TxnRequest) (*pb.TxnResponse, error) {
  84. if err := checkTxnRequest(r); err != nil {
  85. return nil, err
  86. }
  87. resp, err := s.kv.Txn(ctx, r)
  88. if err != nil {
  89. return nil, togRPCError(err)
  90. }
  91. if resp.Header == nil {
  92. plog.Panic("unexpected nil resp.Header")
  93. }
  94. s.hdr.fill(resp.Header)
  95. return resp, err
  96. }
  97. func (s *kvServer) Compact(ctx context.Context, r *pb.CompactionRequest) (*pb.CompactionResponse, error) {
  98. resp, err := s.kv.Compact(ctx, r)
  99. if err != nil {
  100. return nil, togRPCError(err)
  101. }
  102. if resp.Header == nil {
  103. plog.Panic("unexpected nil resp.Header")
  104. }
  105. s.hdr.fill(resp.Header)
  106. return resp, nil
  107. }
  108. func checkRangeRequest(r *pb.RangeRequest) error {
  109. if len(r.Key) == 0 {
  110. return rpctypes.ErrEmptyKey
  111. }
  112. return nil
  113. }
  114. func checkPutRequest(r *pb.PutRequest) error {
  115. if len(r.Key) == 0 {
  116. return rpctypes.ErrEmptyKey
  117. }
  118. return nil
  119. }
  120. func checkDeleteRequest(r *pb.DeleteRangeRequest) error {
  121. if len(r.Key) == 0 {
  122. return rpctypes.ErrEmptyKey
  123. }
  124. return nil
  125. }
  126. func checkTxnRequest(r *pb.TxnRequest) error {
  127. if len(r.Compare) > MaxOpsPerTxn || len(r.Success) > MaxOpsPerTxn || len(r.Failure) > MaxOpsPerTxn {
  128. return rpctypes.ErrTooManyOps
  129. }
  130. for _, c := range r.Compare {
  131. if len(c.Key) == 0 {
  132. return rpctypes.ErrEmptyKey
  133. }
  134. }
  135. for _, u := range r.Success {
  136. if err := checkRequestUnion(u); err != nil {
  137. return err
  138. }
  139. }
  140. if err := checkRequestDupKeys(r.Success); err != nil {
  141. return err
  142. }
  143. for _, u := range r.Failure {
  144. if err := checkRequestUnion(u); err != nil {
  145. return err
  146. }
  147. }
  148. if err := checkRequestDupKeys(r.Failure); err != nil {
  149. return err
  150. }
  151. return nil
  152. }
  153. // checkRequestDupKeys gives rpctypes.ErrDuplicateKey if the same key is modified twice
  154. func checkRequestDupKeys(reqs []*pb.RequestUnion) error {
  155. // check put overlap
  156. keys := make(map[string]struct{})
  157. for _, requ := range reqs {
  158. tv, ok := requ.Request.(*pb.RequestUnion_RequestPut)
  159. if !ok {
  160. continue
  161. }
  162. preq := tv.RequestPut
  163. if preq == nil {
  164. continue
  165. }
  166. key := string(preq.Key)
  167. if _, ok := keys[key]; ok {
  168. return rpctypes.ErrDuplicateKey
  169. }
  170. keys[key] = struct{}{}
  171. }
  172. // no need to check deletes if no puts; delete overlaps are permitted
  173. if len(keys) == 0 {
  174. return nil
  175. }
  176. // sort keys for range checking
  177. sortedKeys := []string{}
  178. for k := range keys {
  179. sortedKeys = append(sortedKeys, k)
  180. }
  181. sort.Strings(sortedKeys)
  182. // check put overlap with deletes
  183. for _, requ := range reqs {
  184. tv, ok := requ.Request.(*pb.RequestUnion_RequestDeleteRange)
  185. if !ok {
  186. continue
  187. }
  188. dreq := tv.RequestDeleteRange
  189. if dreq == nil {
  190. continue
  191. }
  192. key := string(dreq.Key)
  193. if dreq.RangeEnd == nil {
  194. if _, found := keys[key]; found {
  195. return rpctypes.ErrDuplicateKey
  196. }
  197. } else {
  198. lo := sort.SearchStrings(sortedKeys, key)
  199. hi := sort.SearchStrings(sortedKeys, string(dreq.RangeEnd))
  200. if lo != hi {
  201. // element between lo and hi => overlap
  202. return rpctypes.ErrDuplicateKey
  203. }
  204. }
  205. }
  206. return nil
  207. }
  208. func checkRequestUnion(u *pb.RequestUnion) error {
  209. // TODO: ensure only one of the field is set.
  210. switch uv := u.Request.(type) {
  211. case *pb.RequestUnion_RequestRange:
  212. if uv.RequestRange != nil {
  213. return checkRangeRequest(uv.RequestRange)
  214. }
  215. case *pb.RequestUnion_RequestPut:
  216. if uv.RequestPut != nil {
  217. return checkPutRequest(uv.RequestPut)
  218. }
  219. case *pb.RequestUnion_RequestDeleteRange:
  220. if uv.RequestDeleteRange != nil {
  221. return checkDeleteRequest(uv.RequestDeleteRange)
  222. }
  223. default:
  224. // empty union
  225. return nil
  226. }
  227. return nil
  228. }
  229. func togRPCError(err error) error {
  230. switch err {
  231. case storage.ErrCompacted:
  232. return rpctypes.ErrCompacted
  233. case storage.ErrFutureRev:
  234. return rpctypes.ErrFutureRev
  235. case lease.ErrLeaseNotFound:
  236. return rpctypes.ErrLeaseNotFound
  237. // TODO: handle error from raft and timeout
  238. case etcdserver.ErrRequestTooLarge:
  239. return rpctypes.ErrRequestTooLarge
  240. case etcdserver.ErrNoSpace:
  241. return rpctypes.ErrNoSpace
  242. default:
  243. return grpc.Errorf(codes.Internal, err.Error())
  244. }
  245. }