v3demo_server.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615
  1. // Copyright 2015 CoreOS, Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package etcdserver
  15. import (
  16. "bytes"
  17. "fmt"
  18. "sort"
  19. "time"
  20. "github.com/coreos/etcd/Godeps/_workspace/src/github.com/gogo/protobuf/proto"
  21. "github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/net/context"
  22. pb "github.com/coreos/etcd/etcdserver/etcdserverpb"
  23. "github.com/coreos/etcd/lease"
  24. "github.com/coreos/etcd/lease/leasehttp"
  25. dstorage "github.com/coreos/etcd/storage"
  26. "github.com/coreos/etcd/storage/storagepb"
  27. )
  28. const (
  29. // the max request size that raft accepts.
  30. // TODO: make this a flag? But we probably do not want to
  31. // accept large request which might block raft stream. User
  32. // specify a large value might end up with shooting in the foot.
  33. maxRequestBytes = 1.5 * 1024 * 1024
  34. )
  35. type RaftKV interface {
  36. Range(ctx context.Context, r *pb.RangeRequest) (*pb.RangeResponse, error)
  37. Put(ctx context.Context, r *pb.PutRequest) (*pb.PutResponse, error)
  38. DeleteRange(ctx context.Context, r *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error)
  39. Txn(ctx context.Context, r *pb.TxnRequest) (*pb.TxnResponse, error)
  40. Compact(ctx context.Context, r *pb.CompactionRequest) (*pb.CompactionResponse, error)
  41. Hash(ctx context.Context, r *pb.HashRequest) (*pb.HashResponse, error)
  42. }
  43. type Lessor interface {
  44. // LeaseCreate sends LeaseCreate request to raft and apply it after committed.
  45. LeaseCreate(ctx context.Context, r *pb.LeaseCreateRequest) (*pb.LeaseCreateResponse, error)
  46. // LeaseRevoke sends LeaseRevoke request to raft and apply it after committed.
  47. LeaseRevoke(ctx context.Context, r *pb.LeaseRevokeRequest) (*pb.LeaseRevokeResponse, error)
  48. // LeaseRenew renews the lease with given ID. The renewed TTL is returned. Or an error
  49. // is returned.
  50. LeaseRenew(id lease.LeaseID) (int64, error)
  51. }
  52. func (s *EtcdServer) Range(ctx context.Context, r *pb.RangeRequest) (*pb.RangeResponse, error) {
  53. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Range: r})
  54. if err != nil {
  55. return nil, err
  56. }
  57. return result.resp.(*pb.RangeResponse), result.err
  58. }
  59. func (s *EtcdServer) Put(ctx context.Context, r *pb.PutRequest) (*pb.PutResponse, error) {
  60. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Put: r})
  61. if err != nil {
  62. return nil, err
  63. }
  64. return result.resp.(*pb.PutResponse), result.err
  65. }
  66. func (s *EtcdServer) DeleteRange(ctx context.Context, r *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error) {
  67. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{DeleteRange: r})
  68. if err != nil {
  69. return nil, err
  70. }
  71. return result.resp.(*pb.DeleteRangeResponse), result.err
  72. }
  73. func (s *EtcdServer) Txn(ctx context.Context, r *pb.TxnRequest) (*pb.TxnResponse, error) {
  74. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Txn: r})
  75. if err != nil {
  76. return nil, err
  77. }
  78. return result.resp.(*pb.TxnResponse), result.err
  79. }
  80. func (s *EtcdServer) Compact(ctx context.Context, r *pb.CompactionRequest) (*pb.CompactionResponse, error) {
  81. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Compaction: r})
  82. if err != nil {
  83. return nil, err
  84. }
  85. return result.resp.(*pb.CompactionResponse), result.err
  86. }
  87. func (s *EtcdServer) Hash(ctx context.Context, r *pb.HashRequest) (*pb.HashResponse, error) {
  88. h, err := s.be.Hash()
  89. if err != nil {
  90. return nil, err
  91. }
  92. return &pb.HashResponse{Hash: h}, nil
  93. }
  94. func (s *EtcdServer) LeaseCreate(ctx context.Context, r *pb.LeaseCreateRequest) (*pb.LeaseCreateResponse, error) {
  95. // no id given? choose one
  96. for r.ID == int64(lease.NoLease) {
  97. // only use positive int64 id's
  98. r.ID = int64(s.reqIDGen.Next() & ((1 << 63) - 1))
  99. }
  100. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{LeaseCreate: r})
  101. if err != nil {
  102. return nil, err
  103. }
  104. return result.resp.(*pb.LeaseCreateResponse), result.err
  105. }
  106. func (s *EtcdServer) LeaseRevoke(ctx context.Context, r *pb.LeaseRevokeRequest) (*pb.LeaseRevokeResponse, error) {
  107. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{LeaseRevoke: r})
  108. if err != nil {
  109. return nil, err
  110. }
  111. return result.resp.(*pb.LeaseRevokeResponse), result.err
  112. }
  113. func (s *EtcdServer) LeaseRenew(id lease.LeaseID) (int64, error) {
  114. ttl, err := s.lessor.Renew(id)
  115. if err == nil {
  116. return ttl, nil
  117. }
  118. if err != lease.ErrNotPrimary {
  119. return -1, err
  120. }
  121. // renewals don't go through raft; forward to leader manually
  122. leader := s.cluster.Member(s.Leader())
  123. for i := 0; i < 5 && leader == nil; i++ {
  124. // wait an election
  125. dur := time.Duration(s.cfg.ElectionTicks) * time.Duration(s.cfg.TickMs) * time.Millisecond
  126. select {
  127. case <-time.After(dur):
  128. leader = s.cluster.Member(s.Leader())
  129. case <-s.done:
  130. return -1, ErrStopped
  131. }
  132. }
  133. if leader == nil || len(leader.PeerURLs) == 0 {
  134. return -1, ErrNoLeader
  135. }
  136. for _, url := range leader.PeerURLs {
  137. lurl := url + "/leases"
  138. ttl, err = leasehttp.RenewHTTP(id, lurl, s.peerRt, s.cfg.peerDialTimeout())
  139. if err == nil {
  140. break
  141. }
  142. }
  143. return ttl, err
  144. }
  145. type applyResult struct {
  146. resp proto.Message
  147. err error
  148. }
  149. func (s *EtcdServer) processInternalRaftRequest(ctx context.Context, r pb.InternalRaftRequest) (*applyResult, error) {
  150. r.ID = s.reqIDGen.Next()
  151. data, err := r.Marshal()
  152. if err != nil {
  153. return nil, err
  154. }
  155. if len(data) > maxRequestBytes {
  156. return nil, ErrRequestTooLarge
  157. }
  158. ch := s.w.Register(r.ID)
  159. s.r.Propose(ctx, data)
  160. select {
  161. case x := <-ch:
  162. return x.(*applyResult), nil
  163. case <-ctx.Done():
  164. s.w.Trigger(r.ID, nil) // GC wait
  165. return nil, ctx.Err()
  166. case <-s.done:
  167. return nil, ErrStopped
  168. }
  169. }
  170. // Watchable returns a watchable interface attached to the etcdserver.
  171. func (s *EtcdServer) Watchable() dstorage.Watchable {
  172. return s.getKV()
  173. }
  174. const (
  175. // noTxn is an invalid txn ID.
  176. // To apply with independent Range, Put, Delete, you can pass noTxn
  177. // to apply functions instead of a valid txn ID.
  178. noTxn = -1
  179. )
  180. func (s *EtcdServer) applyV3Request(r *pb.InternalRaftRequest) interface{} {
  181. kv := s.getKV()
  182. le := s.lessor
  183. ar := &applyResult{}
  184. switch {
  185. case r.Range != nil:
  186. ar.resp, ar.err = applyRange(noTxn, kv, r.Range)
  187. case r.Put != nil:
  188. ar.resp, ar.err = applyPut(noTxn, kv, le, r.Put)
  189. case r.DeleteRange != nil:
  190. ar.resp, ar.err = applyDeleteRange(noTxn, kv, r.DeleteRange)
  191. case r.Txn != nil:
  192. ar.resp, ar.err = applyTxn(kv, le, r.Txn)
  193. case r.Compaction != nil:
  194. ar.resp, ar.err = applyCompaction(kv, r.Compaction)
  195. case r.LeaseCreate != nil:
  196. ar.resp, ar.err = applyLeaseCreate(le, r.LeaseCreate)
  197. case r.LeaseRevoke != nil:
  198. ar.resp, ar.err = applyLeaseRevoke(le, r.LeaseRevoke)
  199. default:
  200. panic("not implemented")
  201. }
  202. return ar
  203. }
  204. func applyPut(txnID int64, kv dstorage.KV, le lease.Lessor, p *pb.PutRequest) (*pb.PutResponse, error) {
  205. resp := &pb.PutResponse{}
  206. resp.Header = &pb.ResponseHeader{}
  207. var (
  208. rev int64
  209. err error
  210. )
  211. if txnID != noTxn {
  212. rev, err = kv.TxnPut(txnID, p.Key, p.Value, lease.LeaseID(p.Lease))
  213. if err != nil {
  214. return nil, err
  215. }
  216. } else {
  217. leaseID := lease.LeaseID(p.Lease)
  218. if leaseID != lease.NoLease {
  219. if l := le.Lookup(leaseID); l == nil {
  220. return nil, lease.ErrLeaseNotFound
  221. }
  222. }
  223. rev = kv.Put(p.Key, p.Value, leaseID)
  224. }
  225. resp.Header.Revision = rev
  226. return resp, nil
  227. }
  228. type kvSort struct{ kvs []storagepb.KeyValue }
  229. func (s *kvSort) Swap(i, j int) {
  230. t := s.kvs[i]
  231. s.kvs[i] = s.kvs[j]
  232. s.kvs[j] = t
  233. }
  234. func (s *kvSort) Len() int { return len(s.kvs) }
  235. type kvSortByKey struct{ *kvSort }
  236. func (s *kvSortByKey) Less(i, j int) bool {
  237. return bytes.Compare(s.kvs[i].Key, s.kvs[j].Key) < 0
  238. }
  239. type kvSortByVersion struct{ *kvSort }
  240. func (s *kvSortByVersion) Less(i, j int) bool {
  241. return (s.kvs[i].Version - s.kvs[j].Version) < 0
  242. }
  243. type kvSortByCreate struct{ *kvSort }
  244. func (s *kvSortByCreate) Less(i, j int) bool {
  245. return (s.kvs[i].CreateRevision - s.kvs[j].CreateRevision) < 0
  246. }
  247. type kvSortByMod struct{ *kvSort }
  248. func (s *kvSortByMod) Less(i, j int) bool {
  249. return (s.kvs[i].ModRevision - s.kvs[j].ModRevision) < 0
  250. }
  251. type kvSortByValue struct{ *kvSort }
  252. func (s *kvSortByValue) Less(i, j int) bool {
  253. return bytes.Compare(s.kvs[i].Value, s.kvs[j].Value) < 0
  254. }
  255. func applyRange(txnID int64, kv dstorage.KV, r *pb.RangeRequest) (*pb.RangeResponse, error) {
  256. resp := &pb.RangeResponse{}
  257. resp.Header = &pb.ResponseHeader{}
  258. var (
  259. kvs []storagepb.KeyValue
  260. rev int64
  261. err error
  262. )
  263. limit := r.Limit
  264. if r.SortOrder != pb.RangeRequest_NONE {
  265. // fetch everything; sort and truncate afterwards
  266. limit = 0
  267. }
  268. if limit > 0 {
  269. // fetch one extra for 'more' flag
  270. limit = limit + 1
  271. }
  272. if txnID != noTxn {
  273. kvs, rev, err = kv.TxnRange(txnID, r.Key, r.RangeEnd, limit, r.Revision)
  274. if err != nil {
  275. return nil, err
  276. }
  277. } else {
  278. kvs, rev, err = kv.Range(r.Key, r.RangeEnd, limit, r.Revision)
  279. if err != nil {
  280. return nil, err
  281. }
  282. }
  283. if r.SortOrder != pb.RangeRequest_NONE {
  284. var sorter sort.Interface
  285. switch {
  286. case r.SortTarget == pb.RangeRequest_KEY:
  287. sorter = &kvSortByKey{&kvSort{kvs}}
  288. case r.SortTarget == pb.RangeRequest_VERSION:
  289. sorter = &kvSortByVersion{&kvSort{kvs}}
  290. case r.SortTarget == pb.RangeRequest_CREATE:
  291. sorter = &kvSortByCreate{&kvSort{kvs}}
  292. case r.SortTarget == pb.RangeRequest_MOD:
  293. sorter = &kvSortByMod{&kvSort{kvs}}
  294. case r.SortTarget == pb.RangeRequest_VALUE:
  295. sorter = &kvSortByValue{&kvSort{kvs}}
  296. }
  297. switch {
  298. case r.SortOrder == pb.RangeRequest_ASCEND:
  299. sort.Sort(sorter)
  300. case r.SortOrder == pb.RangeRequest_DESCEND:
  301. sort.Sort(sort.Reverse(sorter))
  302. }
  303. }
  304. if r.Limit > 0 && len(kvs) > int(r.Limit) {
  305. kvs = kvs[:r.Limit]
  306. resp.More = true
  307. }
  308. resp.Header.Revision = rev
  309. for i := range kvs {
  310. resp.Kvs = append(resp.Kvs, &kvs[i])
  311. }
  312. return resp, nil
  313. }
  314. func applyDeleteRange(txnID int64, kv dstorage.KV, dr *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error) {
  315. resp := &pb.DeleteRangeResponse{}
  316. resp.Header = &pb.ResponseHeader{}
  317. var (
  318. rev int64
  319. err error
  320. )
  321. if txnID != noTxn {
  322. _, rev, err = kv.TxnDeleteRange(txnID, dr.Key, dr.RangeEnd)
  323. if err != nil {
  324. return nil, err
  325. }
  326. } else {
  327. _, rev = kv.DeleteRange(dr.Key, dr.RangeEnd)
  328. }
  329. resp.Header.Revision = rev
  330. return resp, nil
  331. }
  332. func checkRequestLeases(le lease.Lessor, reqs []*pb.RequestUnion) error {
  333. for _, requ := range reqs {
  334. tv, ok := requ.Request.(*pb.RequestUnion_RequestPut)
  335. if !ok {
  336. continue
  337. }
  338. preq := tv.RequestPut
  339. if preq == nil || lease.LeaseID(preq.Lease) == lease.NoLease {
  340. continue
  341. }
  342. if l := le.Lookup(lease.LeaseID(preq.Lease)); l == nil {
  343. return lease.ErrLeaseNotFound
  344. }
  345. }
  346. return nil
  347. }
  348. func checkRequestRange(kv dstorage.KV, reqs []*pb.RequestUnion) error {
  349. for _, requ := range reqs {
  350. tv, ok := requ.Request.(*pb.RequestUnion_RequestRange)
  351. if !ok {
  352. continue
  353. }
  354. greq := tv.RequestRange
  355. if greq == nil || greq.Revision == 0 {
  356. continue
  357. }
  358. if greq.Revision > kv.Rev() {
  359. return dstorage.ErrFutureRev
  360. }
  361. if greq.Revision < kv.FirstRev() {
  362. return dstorage.ErrCompacted
  363. }
  364. }
  365. return nil
  366. }
  367. func applyTxn(kv dstorage.KV, le lease.Lessor, rt *pb.TxnRequest) (*pb.TxnResponse, error) {
  368. var revision int64
  369. ok := true
  370. for _, c := range rt.Compare {
  371. if revision, ok = applyCompare(kv, c); !ok {
  372. break
  373. }
  374. }
  375. var reqs []*pb.RequestUnion
  376. if ok {
  377. reqs = rt.Success
  378. } else {
  379. reqs = rt.Failure
  380. }
  381. if err := checkRequestLeases(le, reqs); err != nil {
  382. return nil, err
  383. }
  384. if err := checkRequestRange(kv, reqs); err != nil {
  385. return nil, err
  386. }
  387. // When executing the operations of txn, we need to hold the txn lock.
  388. // So the reader will not see any intermediate results.
  389. txnID := kv.TxnBegin()
  390. defer func() {
  391. err := kv.TxnEnd(txnID)
  392. if err != nil {
  393. panic(fmt.Sprint("unexpected error when closing txn", txnID))
  394. }
  395. }()
  396. resps := make([]*pb.ResponseUnion, len(reqs))
  397. for i := range reqs {
  398. resps[i] = applyUnion(txnID, kv, reqs[i])
  399. }
  400. if len(resps) != 0 {
  401. revision += 1
  402. }
  403. txnResp := &pb.TxnResponse{}
  404. txnResp.Header = &pb.ResponseHeader{}
  405. txnResp.Header.Revision = revision
  406. txnResp.Responses = resps
  407. txnResp.Succeeded = ok
  408. return txnResp, nil
  409. }
  410. func applyCompaction(kv dstorage.KV, compaction *pb.CompactionRequest) (*pb.CompactionResponse, error) {
  411. resp := &pb.CompactionResponse{}
  412. resp.Header = &pb.ResponseHeader{}
  413. err := kv.Compact(compaction.Revision)
  414. if err != nil {
  415. return nil, err
  416. }
  417. // get the current revision. which key to get is not important.
  418. _, resp.Header.Revision, _ = kv.Range([]byte("compaction"), nil, 1, 0)
  419. return resp, err
  420. }
  421. func applyUnion(txnID int64, kv dstorage.KV, union *pb.RequestUnion) *pb.ResponseUnion {
  422. switch tv := union.Request.(type) {
  423. case *pb.RequestUnion_RequestRange:
  424. if tv.RequestRange != nil {
  425. resp, err := applyRange(txnID, kv, tv.RequestRange)
  426. if err != nil {
  427. panic("unexpected error during txn")
  428. }
  429. return &pb.ResponseUnion{Response: &pb.ResponseUnion_ResponseRange{ResponseRange: resp}}
  430. }
  431. case *pb.RequestUnion_RequestPut:
  432. if tv.RequestPut != nil {
  433. resp, err := applyPut(txnID, kv, nil, tv.RequestPut)
  434. if err != nil {
  435. panic("unexpected error during txn")
  436. }
  437. return &pb.ResponseUnion{Response: &pb.ResponseUnion_ResponsePut{ResponsePut: resp}}
  438. }
  439. case *pb.RequestUnion_RequestDeleteRange:
  440. if tv.RequestDeleteRange != nil {
  441. resp, err := applyDeleteRange(txnID, kv, tv.RequestDeleteRange)
  442. if err != nil {
  443. panic("unexpected error during txn")
  444. }
  445. return &pb.ResponseUnion{Response: &pb.ResponseUnion_ResponseDeleteRange{ResponseDeleteRange: resp}}
  446. }
  447. default:
  448. // empty union
  449. return nil
  450. }
  451. return nil
  452. }
  453. // applyCompare applies the compare request.
  454. // It returns the revision at which the comparison happens. If the comparison
  455. // succeeds, the it returns true. Otherwise it returns false.
  456. func applyCompare(kv dstorage.KV, c *pb.Compare) (int64, bool) {
  457. ckvs, rev, err := kv.Range(c.Key, nil, 1, 0)
  458. if err != nil {
  459. if err == dstorage.ErrTxnIDMismatch {
  460. panic("unexpected txn ID mismatch error")
  461. }
  462. return rev, false
  463. }
  464. var ckv storagepb.KeyValue
  465. if len(ckvs) != 0 {
  466. ckv = ckvs[0]
  467. } else {
  468. // Use the zero value of ckv normally. However...
  469. if c.Target == pb.Compare_VALUE {
  470. // Always fail if we're comparing a value on a key that doesn't exist.
  471. // We can treat non-existence as the empty set explicitly, such that
  472. // even a key with a value of length 0 bytes is still a real key
  473. // that was written that way
  474. return rev, false
  475. }
  476. }
  477. // -1 is less, 0 is equal, 1 is greater
  478. var result int
  479. switch c.Target {
  480. case pb.Compare_VALUE:
  481. tv, _ := c.TargetUnion.(*pb.Compare_Value)
  482. if tv != nil {
  483. result = bytes.Compare(ckv.Value, tv.Value)
  484. }
  485. case pb.Compare_CREATE:
  486. tv, _ := c.TargetUnion.(*pb.Compare_CreateRevision)
  487. if tv != nil {
  488. result = compareInt64(ckv.CreateRevision, tv.CreateRevision)
  489. }
  490. case pb.Compare_MOD:
  491. tv, _ := c.TargetUnion.(*pb.Compare_ModRevision)
  492. if tv != nil {
  493. result = compareInt64(ckv.ModRevision, tv.ModRevision)
  494. }
  495. case pb.Compare_VERSION:
  496. tv, _ := c.TargetUnion.(*pb.Compare_Version)
  497. if tv != nil {
  498. result = compareInt64(ckv.Version, tv.Version)
  499. }
  500. }
  501. switch c.Result {
  502. case pb.Compare_EQUAL:
  503. if result != 0 {
  504. return rev, false
  505. }
  506. case pb.Compare_GREATER:
  507. if result != 1 {
  508. return rev, false
  509. }
  510. case pb.Compare_LESS:
  511. if result != -1 {
  512. return rev, false
  513. }
  514. }
  515. return rev, true
  516. }
  517. func applyLeaseCreate(le lease.Lessor, lc *pb.LeaseCreateRequest) (*pb.LeaseCreateResponse, error) {
  518. l, err := le.Grant(lease.LeaseID(lc.ID), lc.TTL)
  519. resp := &pb.LeaseCreateResponse{}
  520. if err == nil {
  521. resp.ID = int64(l.ID)
  522. resp.TTL = l.TTL
  523. }
  524. return resp, err
  525. }
  526. func applyLeaseRevoke(le lease.Lessor, lc *pb.LeaseRevokeRequest) (*pb.LeaseRevokeResponse, error) {
  527. err := le.Revoke(lease.LeaseID(lc.ID))
  528. return &pb.LeaseRevokeResponse{}, err
  529. }
  530. func compareInt64(a, b int64) int {
  531. switch {
  532. case a < b:
  533. return -1
  534. case a > b:
  535. return 1
  536. default:
  537. return 0
  538. }
  539. }