v3demo_server.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619
  1. // Copyright 2015 CoreOS, Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package etcdserver
  15. import (
  16. "bytes"
  17. "fmt"
  18. "sort"
  19. "time"
  20. "github.com/coreos/etcd/Godeps/_workspace/src/github.com/gogo/protobuf/proto"
  21. "github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/net/context"
  22. pb "github.com/coreos/etcd/etcdserver/etcdserverpb"
  23. "github.com/coreos/etcd/lease"
  24. "github.com/coreos/etcd/lease/leasehttp"
  25. dstorage "github.com/coreos/etcd/storage"
  26. "github.com/coreos/etcd/storage/storagepb"
  27. )
  28. const (
  29. // the max request size that raft accepts.
  30. // TODO: make this a flag? But we probably do not want to
  31. // accept large request which might block raft stream. User
  32. // specify a large value might end up with shooting in the foot.
  33. maxRequestBytes = 1.5 * 1024 * 1024
  34. )
  35. type RaftKV interface {
  36. Range(ctx context.Context, r *pb.RangeRequest) (*pb.RangeResponse, error)
  37. Put(ctx context.Context, r *pb.PutRequest) (*pb.PutResponse, error)
  38. DeleteRange(ctx context.Context, r *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error)
  39. Txn(ctx context.Context, r *pb.TxnRequest) (*pb.TxnResponse, error)
  40. Compact(ctx context.Context, r *pb.CompactionRequest) (*pb.CompactionResponse, error)
  41. Hash(ctx context.Context, r *pb.HashRequest) (*pb.HashResponse, error)
  42. }
  43. type Lessor interface {
  44. // LeaseCreate sends LeaseCreate request to raft and apply it after committed.
  45. LeaseCreate(ctx context.Context, r *pb.LeaseCreateRequest) (*pb.LeaseCreateResponse, error)
  46. // LeaseRevoke sends LeaseRevoke request to raft and apply it after committed.
  47. LeaseRevoke(ctx context.Context, r *pb.LeaseRevokeRequest) (*pb.LeaseRevokeResponse, error)
  48. // LeaseRenew renews the lease with given ID. The renewed TTL is returned. Or an error
  49. // is returned.
  50. LeaseRenew(id lease.LeaseID) (int64, error)
  51. }
  52. func (s *EtcdServer) Range(ctx context.Context, r *pb.RangeRequest) (*pb.RangeResponse, error) {
  53. if r.Serializable {
  54. return applyRange(noTxn, s.kv, r)
  55. }
  56. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Range: r})
  57. if err != nil {
  58. return nil, err
  59. }
  60. return result.resp.(*pb.RangeResponse), result.err
  61. }
  62. func (s *EtcdServer) Put(ctx context.Context, r *pb.PutRequest) (*pb.PutResponse, error) {
  63. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Put: r})
  64. if err != nil {
  65. return nil, err
  66. }
  67. return result.resp.(*pb.PutResponse), result.err
  68. }
  69. func (s *EtcdServer) DeleteRange(ctx context.Context, r *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error) {
  70. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{DeleteRange: r})
  71. if err != nil {
  72. return nil, err
  73. }
  74. return result.resp.(*pb.DeleteRangeResponse), result.err
  75. }
  76. func (s *EtcdServer) Txn(ctx context.Context, r *pb.TxnRequest) (*pb.TxnResponse, error) {
  77. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Txn: r})
  78. if err != nil {
  79. return nil, err
  80. }
  81. return result.resp.(*pb.TxnResponse), result.err
  82. }
  83. func (s *EtcdServer) Compact(ctx context.Context, r *pb.CompactionRequest) (*pb.CompactionResponse, error) {
  84. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{Compaction: r})
  85. if err != nil {
  86. return nil, err
  87. }
  88. return result.resp.(*pb.CompactionResponse), result.err
  89. }
  90. func (s *EtcdServer) Hash(ctx context.Context, r *pb.HashRequest) (*pb.HashResponse, error) {
  91. h, err := s.be.Hash()
  92. if err != nil {
  93. return nil, err
  94. }
  95. return &pb.HashResponse{Hash: h}, nil
  96. }
  97. func (s *EtcdServer) LeaseCreate(ctx context.Context, r *pb.LeaseCreateRequest) (*pb.LeaseCreateResponse, error) {
  98. // no id given? choose one
  99. for r.ID == int64(lease.NoLease) {
  100. // only use positive int64 id's
  101. r.ID = int64(s.reqIDGen.Next() & ((1 << 63) - 1))
  102. }
  103. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{LeaseCreate: r})
  104. if err != nil {
  105. return nil, err
  106. }
  107. return result.resp.(*pb.LeaseCreateResponse), result.err
  108. }
  109. func (s *EtcdServer) LeaseRevoke(ctx context.Context, r *pb.LeaseRevokeRequest) (*pb.LeaseRevokeResponse, error) {
  110. result, err := s.processInternalRaftRequest(ctx, pb.InternalRaftRequest{LeaseRevoke: r})
  111. if err != nil {
  112. return nil, err
  113. }
  114. return result.resp.(*pb.LeaseRevokeResponse), result.err
  115. }
  116. func (s *EtcdServer) LeaseRenew(id lease.LeaseID) (int64, error) {
  117. ttl, err := s.lessor.Renew(id)
  118. if err == nil {
  119. return ttl, nil
  120. }
  121. if err != lease.ErrNotPrimary {
  122. return -1, err
  123. }
  124. // renewals don't go through raft; forward to leader manually
  125. leader := s.cluster.Member(s.Leader())
  126. for i := 0; i < 5 && leader == nil; i++ {
  127. // wait an election
  128. dur := time.Duration(s.cfg.ElectionTicks) * time.Duration(s.cfg.TickMs) * time.Millisecond
  129. select {
  130. case <-time.After(dur):
  131. leader = s.cluster.Member(s.Leader())
  132. case <-s.done:
  133. return -1, ErrStopped
  134. }
  135. }
  136. if leader == nil || len(leader.PeerURLs) == 0 {
  137. return -1, ErrNoLeader
  138. }
  139. for _, url := range leader.PeerURLs {
  140. lurl := url + "/leases"
  141. ttl, err = leasehttp.RenewHTTP(id, lurl, s.peerRt, s.cfg.peerDialTimeout())
  142. if err == nil {
  143. break
  144. }
  145. }
  146. return ttl, err
  147. }
  148. type applyResult struct {
  149. resp proto.Message
  150. err error
  151. }
  152. func (s *EtcdServer) processInternalRaftRequest(ctx context.Context, r pb.InternalRaftRequest) (*applyResult, error) {
  153. r.ID = s.reqIDGen.Next()
  154. data, err := r.Marshal()
  155. if err != nil {
  156. return nil, err
  157. }
  158. if len(data) > maxRequestBytes {
  159. return nil, ErrRequestTooLarge
  160. }
  161. ch := s.w.Register(r.ID)
  162. s.r.Propose(ctx, data)
  163. select {
  164. case x := <-ch:
  165. return x.(*applyResult), nil
  166. case <-ctx.Done():
  167. s.w.Trigger(r.ID, nil) // GC wait
  168. return nil, ctx.Err()
  169. case <-s.done:
  170. return nil, ErrStopped
  171. }
  172. }
  173. // Watchable returns a watchable interface attached to the etcdserver.
  174. func (s *EtcdServer) Watchable() dstorage.Watchable {
  175. return s.getKV()
  176. }
  177. const (
  178. // noTxn is an invalid txn ID.
  179. // To apply with independent Range, Put, Delete, you can pass noTxn
  180. // to apply functions instead of a valid txn ID.
  181. noTxn = -1
  182. )
  183. func (s *EtcdServer) applyV3Request(r *pb.InternalRaftRequest) interface{} {
  184. kv := s.getKV()
  185. le := s.lessor
  186. ar := &applyResult{}
  187. switch {
  188. case r.Range != nil:
  189. ar.resp, ar.err = applyRange(noTxn, kv, r.Range)
  190. case r.Put != nil:
  191. ar.resp, ar.err = applyPut(noTxn, kv, le, r.Put)
  192. case r.DeleteRange != nil:
  193. ar.resp, ar.err = applyDeleteRange(noTxn, kv, r.DeleteRange)
  194. case r.Txn != nil:
  195. ar.resp, ar.err = applyTxn(kv, le, r.Txn)
  196. case r.Compaction != nil:
  197. ar.resp, ar.err = applyCompaction(kv, r.Compaction)
  198. case r.LeaseCreate != nil:
  199. ar.resp, ar.err = applyLeaseCreate(le, r.LeaseCreate)
  200. case r.LeaseRevoke != nil:
  201. ar.resp, ar.err = applyLeaseRevoke(le, r.LeaseRevoke)
  202. default:
  203. panic("not implemented")
  204. }
  205. return ar
  206. }
  207. func applyPut(txnID int64, kv dstorage.KV, le lease.Lessor, p *pb.PutRequest) (*pb.PutResponse, error) {
  208. resp := &pb.PutResponse{}
  209. resp.Header = &pb.ResponseHeader{}
  210. var (
  211. rev int64
  212. err error
  213. )
  214. if txnID != noTxn {
  215. rev, err = kv.TxnPut(txnID, p.Key, p.Value, lease.LeaseID(p.Lease))
  216. if err != nil {
  217. return nil, err
  218. }
  219. } else {
  220. leaseID := lease.LeaseID(p.Lease)
  221. if leaseID != lease.NoLease {
  222. if l := le.Lookup(leaseID); l == nil {
  223. return nil, lease.ErrLeaseNotFound
  224. }
  225. }
  226. rev = kv.Put(p.Key, p.Value, leaseID)
  227. }
  228. resp.Header.Revision = rev
  229. return resp, nil
  230. }
  231. type kvSort struct{ kvs []storagepb.KeyValue }
  232. func (s *kvSort) Swap(i, j int) {
  233. t := s.kvs[i]
  234. s.kvs[i] = s.kvs[j]
  235. s.kvs[j] = t
  236. }
  237. func (s *kvSort) Len() int { return len(s.kvs) }
  238. type kvSortByKey struct{ *kvSort }
  239. func (s *kvSortByKey) Less(i, j int) bool {
  240. return bytes.Compare(s.kvs[i].Key, s.kvs[j].Key) < 0
  241. }
  242. type kvSortByVersion struct{ *kvSort }
  243. func (s *kvSortByVersion) Less(i, j int) bool {
  244. return (s.kvs[i].Version - s.kvs[j].Version) < 0
  245. }
  246. type kvSortByCreate struct{ *kvSort }
  247. func (s *kvSortByCreate) Less(i, j int) bool {
  248. return (s.kvs[i].CreateRevision - s.kvs[j].CreateRevision) < 0
  249. }
  250. type kvSortByMod struct{ *kvSort }
  251. func (s *kvSortByMod) Less(i, j int) bool {
  252. return (s.kvs[i].ModRevision - s.kvs[j].ModRevision) < 0
  253. }
  254. type kvSortByValue struct{ *kvSort }
  255. func (s *kvSortByValue) Less(i, j int) bool {
  256. return bytes.Compare(s.kvs[i].Value, s.kvs[j].Value) < 0
  257. }
  258. func applyRange(txnID int64, kv dstorage.KV, r *pb.RangeRequest) (*pb.RangeResponse, error) {
  259. resp := &pb.RangeResponse{}
  260. resp.Header = &pb.ResponseHeader{}
  261. var (
  262. kvs []storagepb.KeyValue
  263. rev int64
  264. err error
  265. )
  266. limit := r.Limit
  267. if r.SortOrder != pb.RangeRequest_NONE {
  268. // fetch everything; sort and truncate afterwards
  269. limit = 0
  270. }
  271. if limit > 0 {
  272. // fetch one extra for 'more' flag
  273. limit = limit + 1
  274. }
  275. if txnID != noTxn {
  276. kvs, rev, err = kv.TxnRange(txnID, r.Key, r.RangeEnd, limit, r.Revision)
  277. if err != nil {
  278. return nil, err
  279. }
  280. } else {
  281. kvs, rev, err = kv.Range(r.Key, r.RangeEnd, limit, r.Revision)
  282. if err != nil {
  283. return nil, err
  284. }
  285. }
  286. if r.SortOrder != pb.RangeRequest_NONE {
  287. var sorter sort.Interface
  288. switch {
  289. case r.SortTarget == pb.RangeRequest_KEY:
  290. sorter = &kvSortByKey{&kvSort{kvs}}
  291. case r.SortTarget == pb.RangeRequest_VERSION:
  292. sorter = &kvSortByVersion{&kvSort{kvs}}
  293. case r.SortTarget == pb.RangeRequest_CREATE:
  294. sorter = &kvSortByCreate{&kvSort{kvs}}
  295. case r.SortTarget == pb.RangeRequest_MOD:
  296. sorter = &kvSortByMod{&kvSort{kvs}}
  297. case r.SortTarget == pb.RangeRequest_VALUE:
  298. sorter = &kvSortByValue{&kvSort{kvs}}
  299. }
  300. switch {
  301. case r.SortOrder == pb.RangeRequest_ASCEND:
  302. sort.Sort(sorter)
  303. case r.SortOrder == pb.RangeRequest_DESCEND:
  304. sort.Sort(sort.Reverse(sorter))
  305. }
  306. }
  307. if r.Limit > 0 && len(kvs) > int(r.Limit) {
  308. kvs = kvs[:r.Limit]
  309. resp.More = true
  310. }
  311. resp.Header.Revision = rev
  312. for i := range kvs {
  313. resp.Kvs = append(resp.Kvs, &kvs[i])
  314. }
  315. return resp, nil
  316. }
  317. func applyDeleteRange(txnID int64, kv dstorage.KV, dr *pb.DeleteRangeRequest) (*pb.DeleteRangeResponse, error) {
  318. resp := &pb.DeleteRangeResponse{}
  319. resp.Header = &pb.ResponseHeader{}
  320. var (
  321. rev int64
  322. err error
  323. )
  324. if txnID != noTxn {
  325. _, rev, err = kv.TxnDeleteRange(txnID, dr.Key, dr.RangeEnd)
  326. if err != nil {
  327. return nil, err
  328. }
  329. } else {
  330. _, rev = kv.DeleteRange(dr.Key, dr.RangeEnd)
  331. }
  332. resp.Header.Revision = rev
  333. return resp, nil
  334. }
  335. func checkRequestLeases(le lease.Lessor, reqs []*pb.RequestUnion) error {
  336. for _, requ := range reqs {
  337. tv, ok := requ.Request.(*pb.RequestUnion_RequestPut)
  338. if !ok {
  339. continue
  340. }
  341. preq := tv.RequestPut
  342. if preq == nil || lease.LeaseID(preq.Lease) == lease.NoLease {
  343. continue
  344. }
  345. if l := le.Lookup(lease.LeaseID(preq.Lease)); l == nil {
  346. return lease.ErrLeaseNotFound
  347. }
  348. }
  349. return nil
  350. }
  351. func checkRequestRange(kv dstorage.KV, reqs []*pb.RequestUnion) error {
  352. for _, requ := range reqs {
  353. tv, ok := requ.Request.(*pb.RequestUnion_RequestRange)
  354. if !ok {
  355. continue
  356. }
  357. greq := tv.RequestRange
  358. if greq == nil || greq.Revision == 0 {
  359. continue
  360. }
  361. if greq.Revision > kv.Rev() {
  362. return dstorage.ErrFutureRev
  363. }
  364. if greq.Revision < kv.FirstRev() {
  365. return dstorage.ErrCompacted
  366. }
  367. }
  368. return nil
  369. }
  370. func applyTxn(kv dstorage.KV, le lease.Lessor, rt *pb.TxnRequest) (*pb.TxnResponse, error) {
  371. var revision int64
  372. ok := true
  373. for _, c := range rt.Compare {
  374. if revision, ok = applyCompare(kv, c); !ok {
  375. break
  376. }
  377. }
  378. var reqs []*pb.RequestUnion
  379. if ok {
  380. reqs = rt.Success
  381. } else {
  382. reqs = rt.Failure
  383. }
  384. if err := checkRequestLeases(le, reqs); err != nil {
  385. return nil, err
  386. }
  387. if err := checkRequestRange(kv, reqs); err != nil {
  388. return nil, err
  389. }
  390. // When executing the operations of txn, we need to hold the txn lock.
  391. // So the reader will not see any intermediate results.
  392. txnID := kv.TxnBegin()
  393. defer func() {
  394. err := kv.TxnEnd(txnID)
  395. if err != nil {
  396. panic(fmt.Sprint("unexpected error when closing txn", txnID))
  397. }
  398. }()
  399. resps := make([]*pb.ResponseUnion, len(reqs))
  400. for i := range reqs {
  401. resps[i] = applyUnion(txnID, kv, reqs[i])
  402. }
  403. if len(resps) != 0 {
  404. revision += 1
  405. }
  406. txnResp := &pb.TxnResponse{}
  407. txnResp.Header = &pb.ResponseHeader{}
  408. txnResp.Header.Revision = revision
  409. txnResp.Responses = resps
  410. txnResp.Succeeded = ok
  411. return txnResp, nil
  412. }
  413. func applyCompaction(kv dstorage.KV, compaction *pb.CompactionRequest) (*pb.CompactionResponse, error) {
  414. resp := &pb.CompactionResponse{}
  415. resp.Header = &pb.ResponseHeader{}
  416. err := kv.Compact(compaction.Revision)
  417. if err != nil {
  418. return nil, err
  419. }
  420. // get the current revision. which key to get is not important.
  421. _, resp.Header.Revision, _ = kv.Range([]byte("compaction"), nil, 1, 0)
  422. return resp, err
  423. }
  424. func applyUnion(txnID int64, kv dstorage.KV, union *pb.RequestUnion) *pb.ResponseUnion {
  425. switch tv := union.Request.(type) {
  426. case *pb.RequestUnion_RequestRange:
  427. if tv.RequestRange != nil {
  428. resp, err := applyRange(txnID, kv, tv.RequestRange)
  429. if err != nil {
  430. panic("unexpected error during txn")
  431. }
  432. return &pb.ResponseUnion{Response: &pb.ResponseUnion_ResponseRange{ResponseRange: resp}}
  433. }
  434. case *pb.RequestUnion_RequestPut:
  435. if tv.RequestPut != nil {
  436. resp, err := applyPut(txnID, kv, nil, tv.RequestPut)
  437. if err != nil {
  438. panic("unexpected error during txn")
  439. }
  440. return &pb.ResponseUnion{Response: &pb.ResponseUnion_ResponsePut{ResponsePut: resp}}
  441. }
  442. case *pb.RequestUnion_RequestDeleteRange:
  443. if tv.RequestDeleteRange != nil {
  444. resp, err := applyDeleteRange(txnID, kv, tv.RequestDeleteRange)
  445. if err != nil {
  446. panic("unexpected error during txn")
  447. }
  448. return &pb.ResponseUnion{Response: &pb.ResponseUnion_ResponseDeleteRange{ResponseDeleteRange: resp}}
  449. }
  450. default:
  451. // empty union
  452. return nil
  453. }
  454. return nil
  455. }
  456. // applyCompare applies the compare request.
  457. // It returns the revision at which the comparison happens. If the comparison
  458. // succeeds, the it returns true. Otherwise it returns false.
  459. func applyCompare(kv dstorage.KV, c *pb.Compare) (int64, bool) {
  460. ckvs, rev, err := kv.Range(c.Key, nil, 1, 0)
  461. if err != nil {
  462. if err == dstorage.ErrTxnIDMismatch {
  463. panic("unexpected txn ID mismatch error")
  464. }
  465. return rev, false
  466. }
  467. var ckv storagepb.KeyValue
  468. if len(ckvs) != 0 {
  469. ckv = ckvs[0]
  470. } else {
  471. // Use the zero value of ckv normally. However...
  472. if c.Target == pb.Compare_VALUE {
  473. // Always fail if we're comparing a value on a key that doesn't exist.
  474. // We can treat non-existence as the empty set explicitly, such that
  475. // even a key with a value of length 0 bytes is still a real key
  476. // that was written that way
  477. return rev, false
  478. }
  479. }
  480. // -1 is less, 0 is equal, 1 is greater
  481. var result int
  482. switch c.Target {
  483. case pb.Compare_VALUE:
  484. tv, _ := c.TargetUnion.(*pb.Compare_Value)
  485. if tv != nil {
  486. result = bytes.Compare(ckv.Value, tv.Value)
  487. }
  488. case pb.Compare_CREATE:
  489. tv, _ := c.TargetUnion.(*pb.Compare_CreateRevision)
  490. if tv != nil {
  491. result = compareInt64(ckv.CreateRevision, tv.CreateRevision)
  492. }
  493. case pb.Compare_MOD:
  494. tv, _ := c.TargetUnion.(*pb.Compare_ModRevision)
  495. if tv != nil {
  496. result = compareInt64(ckv.ModRevision, tv.ModRevision)
  497. }
  498. case pb.Compare_VERSION:
  499. tv, _ := c.TargetUnion.(*pb.Compare_Version)
  500. if tv != nil {
  501. result = compareInt64(ckv.Version, tv.Version)
  502. }
  503. }
  504. switch c.Result {
  505. case pb.Compare_EQUAL:
  506. if result != 0 {
  507. return rev, false
  508. }
  509. case pb.Compare_GREATER:
  510. if result != 1 {
  511. return rev, false
  512. }
  513. case pb.Compare_LESS:
  514. if result != -1 {
  515. return rev, false
  516. }
  517. }
  518. return rev, true
  519. }
  520. func applyLeaseCreate(le lease.Lessor, lc *pb.LeaseCreateRequest) (*pb.LeaseCreateResponse, error) {
  521. l, err := le.Grant(lease.LeaseID(lc.ID), lc.TTL)
  522. resp := &pb.LeaseCreateResponse{}
  523. if err == nil {
  524. resp.ID = int64(l.ID)
  525. resp.TTL = l.TTL
  526. }
  527. return resp, err
  528. }
  529. func applyLeaseRevoke(le lease.Lessor, lc *pb.LeaseRevokeRequest) (*pb.LeaseRevokeResponse, error) {
  530. err := le.Revoke(lease.LeaseID(lc.ID))
  531. return &pb.LeaseRevokeResponse{}, err
  532. }
  533. func compareInt64(a, b int64) int {
  534. switch {
  535. case a < b:
  536. return -1
  537. case a > b:
  538. return 1
  539. default:
  540. return 0
  541. }
  542. }