Browse Source

etcdctlv3: lock command

Anthony Romano 9 years ago
parent
commit
ed44bb00f8
4 changed files with 110 additions and 0 deletions
  1. 2 0
      clientv3/concurrency/mutex.go
  2. 19 0
      etcdctlv3/README.md
  3. 88 0
      etcdctlv3/command/lock_command.go
  4. 1 0
      etcdctlv3/main.go

+ 2 - 0
clientv3/concurrency/mutex.go

@@ -92,6 +92,8 @@ func (m *Mutex) IsOwner() v3.Cmp {
 	return v3.Compare(v3.CreatedRevision(m.myKey), "=", m.myRev)
 	return v3.Compare(v3.CreatedRevision(m.myKey), "=", m.myRev)
 }
 }
 
 
+func (m *Mutex) Key() string { return m.myKey }
+
 type lockerMutex struct{ *Mutex }
 type lockerMutex struct{ *Mutex }
 
 
 func (lm *lockerMutex) Lock() {
 func (lm *lockerMutex) Lock() {

+ 19 - 0
etcdctlv3/README.md

@@ -264,6 +264,25 @@ bar
 
 
 ## Utility Commands
 ## Utility Commands
 
 
+### LOCK \<lockname\>
+
+LOCK acquires a distributed named mutex with a given name. Once the lock is acquired, it will be held until etcdctlv3 is terminated.
+
+#### Return value
+
+- Once the lock is acquired, the result for the GET on the unique lock holder key is displayed.
+
+- LOCK returns a zero exit code only if it is terminated by a signal and can release the lock.
+
+#### Example
+```bash
+./etcdctl lock mylock
+mylock/1234534535445
+
+
+```
+
+
 ### MAKE-MIRROR [options] \<destination\>
 ### MAKE-MIRROR [options] \<destination\>
 
 
 [make-mirror][mirror] mirrors a key prefix in an etcd cluster to a destination etcd cluster.
 [make-mirror][mirror] mirrors a key prefix in an etcd cluster to a destination etcd cluster.

+ 88 - 0
etcdctlv3/command/lock_command.go

@@ -0,0 +1,88 @@
+// Copyright 2016 CoreOS, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package command
+
+import (
+	"errors"
+	"os"
+	"os/signal"
+
+	"github.com/coreos/etcd/Godeps/_workspace/src/github.com/spf13/cobra"
+	"github.com/coreos/etcd/Godeps/_workspace/src/golang.org/x/net/context"
+	"github.com/coreos/etcd/clientv3"
+	"github.com/coreos/etcd/clientv3/concurrency"
+)
+
+// NewLockCommand returns the cobra command for "lock".
+func NewLockCommand() *cobra.Command {
+	c := &cobra.Command{
+		Use:   "lock <lockname>",
+		Short: "lock acquires a named lock",
+		Run:   lockCommandFunc,
+	}
+	return c
+}
+
+func lockCommandFunc(cmd *cobra.Command, args []string) {
+	if len(args) != 1 {
+		ExitWithError(ExitBadArgs, errors.New("lock takes one lock name arguement."))
+	}
+	c := mustClientFromCmd(cmd)
+	if err := lockUntilSignal(c, args[0]); err != nil {
+		ExitWithError(ExitError, err)
+	}
+}
+
+func lockUntilSignal(c *clientv3.Client, lockname string) error {
+	m := concurrency.NewMutex(context.TODO(), c, lockname)
+	ctx, cancel := context.WithCancel(context.TODO())
+
+	// unlock in case of ordinary shutdown
+	donec := make(chan struct{})
+	sigc := make(chan os.Signal, 1)
+	signal.Notify(sigc, os.Interrupt, os.Kill)
+	go func() {
+		<-sigc
+		cancel()
+		close(donec)
+	}()
+
+	s, serr := concurrency.NewSession(c)
+	if serr != nil {
+		return serr
+	}
+
+	if err := m.Lock(ctx); err != nil {
+		return err
+	}
+
+	k, kerr := clientv3.NewKV(c).Get(ctx, m.Key())
+	if kerr != nil {
+		return kerr
+	}
+	if len(k.Kvs) == 0 {
+		return errors.New("lock lost on init")
+	}
+
+	display.Get(*k)
+
+	select {
+	case <-donec:
+		return m.Unlock()
+	case <-s.Done():
+	}
+
+	return errors.New("session expired")
+}

+ 1 - 0
etcdctlv3/main.go

@@ -62,6 +62,7 @@ func init() {
 		command.NewMemberCommand(),
 		command.NewMemberCommand(),
 		command.NewSnapshotCommand(),
 		command.NewSnapshotCommand(),
 		command.NewMakeMirrorCommand(),
 		command.NewMakeMirrorCommand(),
+		command.NewLockCommand(),
 	)
 	)
 }
 }