Sfoglia il codice sorgente

storage/backend: add commitAndStop

After the upgrade of boltdb, db.Close waits for all txn to finish.
CommitAndStop commits the current txn and stop creating new ones.
Xiang Li 10 anni fa
parent
commit
e8f40b0412
2 ha cambiato i file con 18 aggiunte e 6 eliminazioni
  1. 1 1
      storage/backend/backend.go
  2. 17 5
      storage/backend/batch_tx.go

+ 1 - 1
storage/backend/backend.go

@@ -80,7 +80,7 @@ func (b *backend) run() {
 		select {
 		case <-time.After(b.batchInterval):
 		case <-b.stopc:
-			b.batchTx.Commit()
+			b.batchTx.CommitAndStop()
 			return
 		}
 		b.batchTx.Commit()

+ 17 - 5
storage/backend/batch_tx.go

@@ -16,6 +16,7 @@ type BatchTx interface {
 	UnsafeRange(bucketName []byte, key, endKey []byte, limit int64) (keys [][]byte, vals [][]byte)
 	UnsafeDelete(bucketName []byte, key []byte)
 	Commit()
+	CommitAndStop()
 }
 
 type batchTx struct {
@@ -43,7 +44,7 @@ func (t *batchTx) UnsafePut(bucketName []byte, key []byte, value []byte) {
 	}
 	t.pending++
 	if t.pending > t.backend.batchLimit {
-		t.commit()
+		t.commit(false)
 		t.pending = 0
 	}
 }
@@ -84,19 +85,26 @@ func (t *batchTx) UnsafeDelete(bucketName []byte, key []byte) {
 	}
 	t.pending++
 	if t.pending > t.backend.batchLimit {
-		t.commit()
+		t.commit(false)
 		t.pending = 0
 	}
 }
 
-// commitAndBegin commits a previous tx and begins a new writable one.
+// Commit commits a previous tx and begins a new writable one.
 func (t *batchTx) Commit() {
 	t.Lock()
 	defer t.Unlock()
-	t.commit()
+	t.commit(false)
 }
 
-func (t *batchTx) commit() {
+// CommitAndStop commits the previous tx and do not create a new one.
+func (t *batchTx) CommitAndStop() {
+	t.Lock()
+	defer t.Unlock()
+	t.commit(true)
+}
+
+func (t *batchTx) commit(stop bool) {
 	var err error
 	// commit the last tx
 	if t.tx != nil {
@@ -106,6 +114,10 @@ func (t *batchTx) commit() {
 		}
 	}
 
+	if stop {
+		return
+	}
+
 	// begin a new tx
 	t.tx, err = t.backend.db.Begin(true)
 	if err != nil {