Browse Source

Merge pull request #267 from xiangli-cmu/fix-wait-handler

fix wait handler should close connection if client leaves
Ben Johnson 12 years ago
parent
commit
e40bb2e8d8
1 changed files with 10 additions and 2 deletions
  1. 10 2
      server/v2/get_handler.go

+ 10 - 2
server/v2/get_handler.go

@@ -46,11 +46,19 @@ func GetHandler(w http.ResponseWriter, req *http.Request, s Server) error {
 		}
 
 		// Start the watcher on the store.
-		c, err := s.Store().Watch(key, recursive, sinceIndex, s.CommitIndex(), s.Term())
+		eventChan, err := s.Store().Watch(key, recursive, sinceIndex, s.CommitIndex(), s.Term())
 		if err != nil {
 			return etcdErr.NewError(500, key, store.UndefIndex, store.UndefTerm)
 		}
-		event = <-c
+
+		cn, _ := w.(http.CloseNotifier)
+		closeChan := cn.CloseNotify()
+
+		select {
+		case <-closeChan:
+			return nil
+		case event = <-eventChan:
+		}
 
 	} else { //get
 		// Retrieve the key from the store.