Browse Source

etcdserver/etcdhttp: remove closenotify watch

Blake Mizerany 11 years ago
parent
commit
cd3f047ccd
1 changed files with 0 additions and 19 deletions
  1. 0 19
      etcdserver2/etcdhttp/http.go

+ 0 - 19
etcdserver2/etcdhttp/http.go

@@ -35,21 +35,6 @@ func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	// avoid spawing goroutines for requests that are short lived.
-	if canBlock(rr) {
-		// cancel the request and release resources associated with it if the
-		// client closes their connection before we get a response.
-		if nf, ok := w.(http.CloseNotifier); ok {
-			go func() {
-				select {
-				case <-nf.CloseNotify():
-					cancel()
-				case <-ctx.Done():
-				}
-			}()
-		}
-	}
-
 	resp, err := h.Server.Do(ctx, rr)
 	if err != nil {
 		// TODO(bmizerany): switch on store errors and etcdserver.ErrUnknownMethod
@@ -96,7 +81,3 @@ func encodeResponse(ctx context.Context, w http.ResponseWriter, resp etcdserver.
 	}
 	return nil
 }
-
-func canBlock(r etcdserver.Request) bool {
-	return r.Method != "GET" || (r.Method == "GET" && r.Wait)
-}