Browse Source

embed,etcdmain: support structured logger

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Gyuho Lee 7 years ago
parent
commit
c712e08a42
3 changed files with 4 additions and 4 deletions
  1. 1 1
      embed/config.go
  2. 1 1
      embed/etcd.go
  3. 2 2
      etcdmain/etcd.go

+ 1 - 1
embed/config.go

@@ -352,7 +352,6 @@ func (cfg Config) GetLogger() *zap.Logger {
 func (cfg *Config) setupLogging() error {
 	switch cfg.Logger {
 	case "capnslog": // TODO: deprecate this in v3.5
-		capnslog.SetGlobalLogLevel(capnslog.INFO)
 		cfg.ClientTLSInfo.HandshakeFailure = logTLSHandshakeFailure
 		cfg.PeerTLSInfo.HandshakeFailure = logTLSHandshakeFailure
 
@@ -362,6 +361,7 @@ func (cfg *Config) setupLogging() error {
 			// enable info, warning, error
 			grpclog.SetLoggerV2(grpclog.NewLoggerV2(os.Stderr, os.Stderr, os.Stderr))
 		} else {
+			capnslog.SetGlobalLogLevel(capnslog.INFO)
 			// only discard info
 			grpclog.SetLoggerV2(grpclog.NewLoggerV2(ioutil.Discard, os.Stderr, os.Stderr))
 		}

+ 1 - 1
embed/etcd.go

@@ -571,7 +571,7 @@ func (e *Etcd) serveClients() (err error) {
 	var h http.Handler
 	if e.Config().EnableV2 {
 		if len(e.Config().ExperimentalEnableV2V3) > 0 {
-			srv := v2v3.NewServer(v3client.New(e.Server), e.cfg.ExperimentalEnableV2V3)
+			srv := v2v3.NewServer(e.cfg.logger, v3client.New(e.Server), e.cfg.ExperimentalEnableV2V3)
 			h = v2http.NewClientHandler(srv, e.Server.Cfg.ReqTimeout())
 		} else {
 			h = v2http.NewClientHandler(e.Server, e.Server.Cfg.ReqTimeout())

+ 2 - 2
etcdmain/etcd.go

@@ -259,7 +259,7 @@ func startEtcdOrProxyV2() {
 		}
 	}
 
-	osutil.HandleInterrupts()
+	osutil.HandleInterrupts(lg)
 
 	// At this point, the initialization of etcd is done.
 	// The listeners are listening on the TCP ports and ready
@@ -408,7 +408,7 @@ func startProxy(cfg *config) error {
 
 	clientURLs := []string{}
 	uf := func() []string {
-		gcls, gerr := etcdserver.GetClusterFromRemotePeers(peerURLs, tr)
+		gcls, gerr := etcdserver.GetClusterFromRemotePeers(lg, peerURLs, tr)
 		if gerr != nil {
 			if lg != nil {
 				lg.Warn(