Browse Source

test: disable "unparam" for now

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Gyuho Lee 7 years ago
parent
commit
c58f5cfeda
3 changed files with 3 additions and 3 deletions
  1. 1 1
      auth/store_test.go
  2. 1 1
      embed/serve.go
  3. 1 1
      test

+ 1 - 1
auth/store_test.go

@@ -120,7 +120,7 @@ func setupAuthStore(t *testing.T) (store *authStore, teardownfunc func(t *testin
 		t.Fatal(err)
 		t.Fatal(err)
 	}
 	}
 
 
-	tearDown := func(t *testing.T) {
+	tearDown := func(_ *testing.T) {
 		b.Close()
 		b.Close()
 		os.Remove(tPath)
 		os.Remove(tPath)
 		as.Close()
 		as.Close()

+ 1 - 1
embed/serve.go

@@ -276,7 +276,7 @@ func (sctx *serveCtx) createMux(gwmux *gw.ServeMux, handler http.Handler) *http.
 			gwmux,
 			gwmux,
 			wsproxy.WithRequestMutator(
 			wsproxy.WithRequestMutator(
 				// Default to the POST method for streams
 				// Default to the POST method for streams
-				func(incoming *http.Request, outgoing *http.Request) *http.Request {
+				func(_ *http.Request, outgoing *http.Request) *http.Request {
 					outgoing.Method = "POST"
 					outgoing.Method = "POST"
 					return outgoing
 					return outgoing
 				},
 				},

+ 1 - 1
test

@@ -616,6 +616,7 @@ function commit_title_pass {
 function fmt_pass {
 function fmt_pass {
 	toggle_failpoints disable
 	toggle_failpoints disable
 
 
+    # TODO: add "unparam"
 	for p in shellcheck \
 	for p in shellcheck \
 			markdown_you \
 			markdown_you \
 			markdown_marker \
 			markdown_marker \
@@ -625,7 +626,6 @@ function fmt_pass {
 			govet_shadow \
 			govet_shadow \
 			gosimple \
 			gosimple \
 			unused \
 			unused \
-			unparam \
 			staticcheck \
 			staticcheck \
 			revive \
 			revive \
 			unconvert \
 			unconvert \