Browse Source

apologize profusely about locking on windows

Barak Michener 11 năm trước cách đây
mục cha
commit
a5923e5b00
2 tập tin đã thay đổi với 6 bổ sung0 xóa
  1. 2 0
      Documentation/2.0/configuration.md
  2. 4 0
      etcdmain/const_windows.go

+ 2 - 0
Documentation/2.0/configuration.md

@@ -33,10 +33,12 @@ To start etcd automatically using custom settings at startup in Linux, using a [
 ##### -max-snapshots
 + Maximum number of snapshot files to retain (0 is unlimited)
 + default: 5
++ The default for users on Windows is unlimited, and manual purging down to 5 (or your preference for safety) is recommended.
 
 ##### -max-wals
 + Maximum number of wal files to retain (0 is unlimited)
 + default: 5
++ The default for users on Windows is unlimited, and manual purging down to 5 (or your preference for safety) is recommended.
 
 ##### -cors
 + Comma-separated white list of origins for CORS (cross-origin resource sharing).

+ 4 - 0
etcdmain/const_windows.go

@@ -2,6 +2,10 @@
 
 package etcdmain
 
+// TODO(barakmich): So because file locking on Windows is untested, the
+// temporary fix is to default to unlimited snapshots and WAL files, with manual
+// removal. Perhaps not the most elegant solution, but it's at least safe and
+// we'd totally love a PR to fix the story around locking.
 const (
 	defaultMaxSnapshots = 0
 	defaultMaxWALs      = 0