Browse Source

*: do not whitelist empty hosts

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Gyuho Lee 7 years ago
parent
commit
9f0027dfb2
2 changed files with 9 additions and 4 deletions
  1. 3 1
      embed/etcd.go
  2. 6 3
      etcdmain/config.go

+ 3 - 1
embed/etcd.go

@@ -176,7 +176,9 @@ func StartEtcd(inCfg *Config) (e *Etcd, err error) {
 
 	srvcfg.HostWhitelist = make(map[string]struct{}, len(cfg.HostWhitelist))
 	for _, h := range cfg.HostWhitelist {
-		srvcfg.HostWhitelist[h] = struct{}{}
+		if h != "" {
+			srvcfg.HostWhitelist[h] = struct{}{}
+		}
 	}
 
 	if e.Server, err = etcdserver.NewServer(srvcfg); err != nil {

+ 6 - 3
etcdmain/config.go

@@ -277,9 +277,12 @@ func (cfg *config) configFromCmdLine() error {
 		cfg.ec.ListenMetricsUrls = []url.URL(u)
 	}
 
-	hosts := strings.Split(cfg.cf.hostWhitelist, ",")
-	for i := range hosts {
-		hosts[i] = strings.TrimSpace(hosts[i])
+	hosts := []string{}
+	for _, h := range strings.Split(cfg.cf.hostWhitelist, ",") {
+		h = strings.TrimSpace(h)
+		if h != "" {
+			hosts = append(hosts, h)
+		}
 	}
 	cfg.ec.HostWhitelist = hosts