Browse Source

Merge pull request #10646 from yingnanzhang666/metrics_db_compaction

fix issue that metric db_compaction_total_duration_milliseconds is always 0
Jingyi Hu 6 years ago
parent
commit
943d6887c4
1 changed files with 1 additions and 1 deletions
  1. 1 1
      mvcc/kvstore_compaction.go

+ 1 - 1
mvcc/kvstore_compaction.go

@@ -23,7 +23,7 @@ import (
 
 
 func (s *store) scheduleCompaction(compactMainRev int64, keep map[revision]struct{}) bool {
 func (s *store) scheduleCompaction(compactMainRev int64, keep map[revision]struct{}) bool {
 	totalStart := time.Now()
 	totalStart := time.Now()
-	defer dbCompactionTotalMs.Observe(float64(time.Since(totalStart) / time.Millisecond))
+	defer func() { dbCompactionTotalMs.Observe(float64(time.Since(totalStart) / time.Millisecond)) }()
 	keyCompactions := 0
 	keyCompactions := 0
 	defer func() { dbCompactionKeysCounter.Add(float64(keyCompactions)) }()
 	defer func() { dbCompactionKeysCounter.Add(float64(keyCompactions)) }()