Browse Source

Merge pull request #2666 from philips/check-error-in-store

store: always check the error
Xiang Li 10 years ago
parent
commit
90a7978474
1 changed files with 4 additions and 2 deletions
  1. 4 2
      store/store.go

+ 4 - 2
store/store.go

@@ -354,8 +354,10 @@ func (s *store) CompareAndDelete(nodePath string, prevValue string, prevIndex ui
 		s.WatcherHub.notifyWatchers(e, path, true)
 		s.WatcherHub.notifyWatchers(e, path, true)
 	}
 	}
 
 
-	// delete a key-value pair, no error should happen
-	n.Remove(false, false, callback)
+	err = n.Remove(false, false, callback)
+	if err != nil {
+		return nil, err
+	}
 
 
 	s.WatcherHub.notify(e)
 	s.WatcherHub.notify(e)
 	s.Stats.Inc(CompareAndDeleteSuccess)
 	s.Stats.Inc(CompareAndDeleteSuccess)