Browse Source

etcdserver/etcdhttp: use MergeLogger to log etcdserver errors

Related https://github.com/coreos/etcd/issues/3812.
Gyu-Ho Lee 10 years ago
parent
commit
8f943f2f45
2 changed files with 6 additions and 4 deletions
  1. 2 2
      etcdserver/etcdhttp/client.go
  2. 4 2
      etcdserver/etcdhttp/http.go

+ 2 - 2
etcdserver/etcdhttp/client.go

@@ -605,9 +605,9 @@ func writeKeyError(w http.ResponseWriter, err error) {
 	default:
 	default:
 		switch err {
 		switch err {
 		case etcdserver.ErrTimeoutDueToLeaderFail, etcdserver.ErrTimeoutDueToConnectionLost:
 		case etcdserver.ErrTimeoutDueToLeaderFail, etcdserver.ErrTimeoutDueToConnectionLost:
-			plog.Error(err)
+			mlog.MergeError(err)
 		default:
 		default:
-			plog.Errorf("got unexpected response error (%v)", err)
+			mlog.MergeErrorf("got unexpected response error (%v)", err)
 		}
 		}
 		ee := etcdErr.NewError(etcdErr.EcodeRaftInternal, err.Error(), 0)
 		ee := etcdErr.NewError(etcdErr.EcodeRaftInternal, err.Error(), 0)
 		ee.WriteTo(w)
 		ee.WriteTo(w)

+ 4 - 2
etcdserver/etcdhttp/http.go

@@ -26,6 +26,7 @@ import (
 	"github.com/coreos/etcd/etcdserver"
 	"github.com/coreos/etcd/etcdserver"
 	"github.com/coreos/etcd/etcdserver/auth"
 	"github.com/coreos/etcd/etcdserver/auth"
 	"github.com/coreos/etcd/etcdserver/etcdhttp/httptypes"
 	"github.com/coreos/etcd/etcdserver/etcdhttp/httptypes"
+	"github.com/coreos/etcd/pkg/logutil"
 )
 )
 
 
 const (
 const (
@@ -35,6 +36,7 @@ const (
 
 
 var (
 var (
 	plog      = capnslog.NewPackageLogger("github.com/coreos/etcd", "etcdhttp")
 	plog      = capnslog.NewPackageLogger("github.com/coreos/etcd", "etcdhttp")
+	mlog      = logutil.NewMergeLogger(plog)
 	errClosed = errors.New("etcdhttp: client closed connection")
 	errClosed = errors.New("etcdhttp: client closed connection")
 )
 )
 
 
@@ -60,9 +62,9 @@ func writeError(w http.ResponseWriter, r *http.Request, err error) {
 	default:
 	default:
 		switch err {
 		switch err {
 		case etcdserver.ErrTimeoutDueToLeaderFail, etcdserver.ErrTimeoutDueToConnectionLost, etcdserver.ErrNotEnoughStartedMembers:
 		case etcdserver.ErrTimeoutDueToLeaderFail, etcdserver.ErrTimeoutDueToConnectionLost, etcdserver.ErrNotEnoughStartedMembers:
-			plog.Error(err)
+			mlog.MergeError(err)
 		default:
 		default:
-			plog.Errorf("got unexpected response error (%v)", err)
+			mlog.MergeErrorf("got unexpected response error (%v)", err)
 		}
 		}
 		herr := httptypes.NewHTTPError(http.StatusInternalServerError, "Internal Server Error")
 		herr := httptypes.NewHTTPError(http.StatusInternalServerError, "Internal Server Error")
 		if et := herr.WriteTo(w); et != nil {
 		if et := herr.WriteTo(w); et != nil {