Browse Source

remove new cluster check

Barak Michener 11 years ago
parent
commit
8a311e5b76
2 changed files with 9 additions and 12 deletions
  1. 7 9
      etcdserver/config.go
  2. 2 3
      etcdserver/config_test.go

+ 7 - 9
etcdserver/config.go

@@ -28,16 +28,14 @@ func (c *ServerConfig) Verify() error {
 		return fmt.Errorf("could not find name %v in cluster!", c.Name)
 		return fmt.Errorf("could not find name %v in cluster!", c.Name)
 	}
 	}
 
 
-	if c.ClusterState == ClusterStateValueNew {
-		// No identical IPs in the cluster peer list
-		urlMap := make(map[string]bool)
-		for _, m := range *c.Cluster {
-			for _, url := range m.PeerURLs {
-				if urlMap[url] {
-					return fmt.Errorf("duplicate url %v in server config", url)
-				}
-				urlMap[url] = true
+	// No identical IPs in the cluster peer list
+	urlMap := make(map[string]bool)
+	for _, m := range *c.Cluster {
+		for _, url := range m.PeerURLs {
+			if urlMap[url] {
+				return fmt.Errorf("duplicate url %v in server config", url)
 			}
 			}
+			urlMap[url] = true
 		}
 		}
 	}
 	}
 	return nil
 	return nil

+ 2 - 3
etcdserver/config_test.go

@@ -19,9 +19,8 @@ func TestConfigVerify(t *testing.T) {
 		cluster := &Cluster{}
 		cluster := &Cluster{}
 		cluster.Set(tt.clusterSetting)
 		cluster.Set(tt.clusterSetting)
 		cfg := ServerConfig{
 		cfg := ServerConfig{
-			Name:         "node1",
-			Cluster:      cluster,
-			ClusterState: ClusterStateValueNew,
+			Name:    "node1",
+			Cluster: cluster,
 		}
 		}
 		err := cfg.Verify()
 		err := cfg.Verify()
 		if (err == nil) && tt.shouldError {
 		if (err == nil) && tt.shouldError {