Browse Source

Merge pull request #10975 from lzhfromustc/currentRev

Add critical section to protect s.currentRev
Jingyi Hu 6 years ago
parent
commit
88d998be4c
1 changed files with 1 additions and 0 deletions
  1. 1 0
      mvcc/kvstore.go

+ 1 - 0
mvcc/kvstore.go

@@ -176,6 +176,7 @@ func (s *store) compactBarrier(ctx context.Context, ch chan struct{}) {
 }
 }
 
 
 func (s *store) Hash() (hash uint32, revision int64, err error) {
 func (s *store) Hash() (hash uint32, revision int64, err error) {
+	// TODO: hash and revision could be inconsistent, one possible fix is to add s.revMu.RLock() at the beginning of function, which is costly
 	start := time.Now()
 	start := time.Now()
 
 
 	s.b.ForceCommit()
 	s.b.ForceCommit()