Sfoglia il codice sorgente

etcdserver: remove TODO to delete URLStringsEqual

Discovery SRV supports to compare IP addresses with domain names,
so we need URLStringsEqual function.
Yicheng Qin 10 anni fa
parent
commit
72462a72fb
2 ha cambiato i file con 0 aggiunte e 2 eliminazioni
  1. 0 1
      etcdserver/cluster.go
  2. 0 1
      etcdserver/config.go

+ 0 - 1
etcdserver/cluster.go

@@ -424,7 +424,6 @@ func ValidateClusterAndAssignIDs(local *cluster, existing *cluster) error {
 	sort.Sort(MembersByPeerURLs(lms))
 
 	for i := range ems {
-		// TODO: Remove URLStringsEqual after improvement of using hostnames #2150 #2123
 		if !netutil.URLStringsEqual(ems[i].PeerURLs, lms[i].PeerURLs) {
 			return fmt.Errorf("unmatched member while checking PeerURLs")
 		}

+ 0 - 1
etcdserver/config.go

@@ -92,7 +92,6 @@ func (c *ServerConfig) verifyLocalMember(strict bool) error {
 	}
 
 	// Advertised peer URLs must match those in the cluster peer list
-	// TODO: Remove URLStringsEqual after improvement of using hostnames #2150 #2123
 	apurls := c.PeerURLs.StringSlice()
 	sort.Strings(apurls)
 	urls.Sort()