Browse Source

add comments in snapshot.go

Xiang Li 12 years ago
parent
commit
58e9e0c557
2 changed files with 10 additions and 7 deletions
  1. 9 7
      snapshot.go
  2. 1 0
      util.go

+ 9 - 7
snapshot.go

@@ -1,20 +1,25 @@
 package main
 
 import (
-	"fmt"
 	"time"
 )
 
+// basic conf.
+// TODO: find a good policy to do snapshot
 type snapshotConf struct {
-	// basic
+	// Etcd will check if snapshot is need every checkingInterval
 	checkingInterval time.Duration
-	lastWrites       uint64
-	writesThr        uint64
+	// The number of writes when the last snapshot happened
+	lastWrites uint64
+	// If the incremental number of writes since the last snapshot
+	// exceeds the write Threshold, etcd will do a snapshot
+	writesThr uint64
 }
 
 var snapConf *snapshotConf
 
 func newSnapshotConf() *snapshotConf {
+	// check snapshot every 3 seconds and the threshold is 20K
 	return &snapshotConf{time.Second * 3, etcdStore.TotalWrites(), 20 * 1000}
 }
 
@@ -26,9 +31,6 @@ func monitorSnapshot() {
 		if currentWrites > snapConf.writesThr {
 			raftServer.TakeSnapshot()
 			snapConf.lastWrites = etcdStore.TotalWrites()
-
-		} else {
-			fmt.Println(currentWrites)
 		}
 	}
 }

+ 1 - 0
util.go

@@ -25,6 +25,7 @@ func durationToExpireTime(strDuration string) (time.Time, error) {
 			return time.Unix(0, 0), err
 		}
 		return time.Now().Add(time.Second * (time.Duration)(duration)), nil
+
 	} else {
 		return time.Unix(0, 0), nil
 	}