Browse Source

etcdctl/ctlv3/command: don't print gRPC WARNING logs by default

Despite holding important information, these are too noisy.

See https://github.com/coreos/etcd/pull/9623
Eric Chiang 7 years ago
parent
commit
55001977ed
1 changed files with 5 additions and 3 deletions
  1. 5 3
      etcdctl/ctlv3/command/global.go

+ 5 - 3
etcdctl/ctlv3/command/global.go

@@ -128,9 +128,11 @@ func clientConfigFromCmd(cmd *cobra.Command) *clientConfig {
 			fmt.Fprintf(os.Stderr, "%s=%v\n", flags.FlagToEnv("ETCDCTL", f.Name), f.Value)
 		})
 	} else {
-		// Enable logging for WARNING and ERROR since these levels include issues with
-		// connecting to the server, such as TLS misconfiguration.
-		clientv3.SetLogger(grpclog.NewLoggerV2(ioutil.Discard, os.Stderr, os.Stderr))
+		// WARNING logs contain important information like TLS misconfirugation, but spams
+		// too many routine connection disconnects to turn on by default.
+		//
+		// See https://github.com/coreos/etcd/pull/9623 for background
+		clientv3.SetLogger(grpclog.NewLoggerV2(ioutil.Discard, ioutil.Discard, os.Stderr))
 	}
 
 	cfg := &clientConfig{}