Browse Source

grpcproxy: don't wait for ctx.Done() to close kv donec

Causes a goroutine leak in ActiveConnection.Close() tests. Channel is
vestigial since removing ccache; revisit if kv ever needs goroutines.
Anthony Romano 8 years ago
parent
commit
36f5b713bf
1 changed files with 1 additions and 5 deletions
  1. 1 5
      proxy/grpcproxy/kv.go

+ 1 - 5
proxy/grpcproxy/kv.go

@@ -33,11 +33,7 @@ func NewKvProxy(c *clientv3.Client) (pb.KVServer, <-chan struct{}) {
 		cache: cache.NewCache(cache.DefaultMaxEntries),
 	}
 	donec := make(chan struct{})
-	go func() {
-		defer close(donec)
-		<-c.Ctx().Done()
-		kv.cache.Close()
-	}()
+	close(donec)
 	return kv, donec
 }