Browse Source

Fix potential memory leak

Fix potential memory leak where zw is not Close() when an error occurs.
zaddok 6 years ago
parent
commit
5107928892
1 changed files with 2 additions and 0 deletions
  1. 2 0
      file.go

+ 2 - 0
file.go

@@ -109,10 +109,12 @@ func (f *File) WriteToBuffer() (*bytes.Buffer, error) {
 	for path, content := range f.XLSX {
 	for path, content := range f.XLSX {
 		fi, err := zw.Create(path)
 		fi, err := zw.Create(path)
 		if err != nil {
 		if err != nil {
+			zw.Close()
 			return buf, err
 			return buf, err
 		}
 		}
 		_, err = fi.Write(content)
 		_, err = fi.Write(content)
 		if err != nil {
 		if err != nil {
+			zw.Close()
 			return buf, err
 			return buf, err
 		}
 		}
 	}
 	}